{"action":"closed","issue":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/239","repository_url":"https://api.github.com/repos/jprichardson/node-fs-extra","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/239/comments","events_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/239/events","html_url":"https://github.com/jprichardson/node-fs-extra/issues/239","id":150113914,"number":239,"title":"Depreciate regular expressions for copy's filter","user":{"login":"martinheidegger","id":914122,"avatar_url":"https://avatars.githubusercontent.com/u/914122?v=3","gravatar_id":"","url":"https://api.github.com/users/martinheidegger","html_url":"https://github.com/martinheidegger","followers_url":"https://api.github.com/users/martinheidegger/followers","following_url":"https://api.github.com/users/martinheidegger/following{/other_user}","gists_url":"https://api.github.com/users/martinheidegger/gists{/gist_id}","starred_url":"https://api.github.com/users/martinheidegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinheidegger/subscriptions","organizations_url":"https://api.github.com/users/martinheidegger/orgs","repos_url":"https://api.github.com/users/martinheidegger/repos","events_url":"https://api.github.com/users/martinheidegger/events{/privacy}","received_events_url":"https://api.github.com/users/martinheidegger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/labels/documentation","name":"documentation","color":"009800"},{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/labels/feature-copy","name":"feature-copy","color":"006b75"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/milestones/3","html_url":"https://github.com/jprichardson/node-fs-extra/milestones/1.0.0","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/milestones/3/labels","id":1191270,"number":3,"title":"1.0.0","description":"","creator":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=3","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":20,"state":"open","created_at":"2015-07-02T17:43:55Z","updated_at":"2016-10-27T14:36:04Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-04-21T15:48:34Z","updated_at":"2016-10-27T14:36:04Z","closed_at":"2016-10-27T14:36:04Z","body":"Regular Expression filters in [ncp.js:38](https://github.com/jprichardson/node-fs-extra/blob/141422ee384fda83e3e1d4af2727bc9dca799f68/lib/copy/ncp.js#L38) are run against the full source path, i.e.:\r\n\r\n`/Users/martin/Private/projects/nodeschool/git-it-electron/node_modules/eslint/node_modules/uglify-js/node_modules/source-map/lib/util.js`\r\n\r\nIf I want in the folder `git-it-electron` to exclude the `eslint` folder I need to know that I am in the `/Users/martin/Private/projects/nodeschool/git-it-electron` folder when I do that. If I test for `/eslint/` then It would exclude the folder properly but If by some accident I would put the project in a folder called:\r\n\r\n`/Users/eslint/Private/projects/nodeschool/git-it-electron`\r\n\r\nIt would ignore all of the files in my project 😢 . This means that someone would need to implement the file matching with that in mind. Given that `ncp.js` already [considers the working directory](https://github.com/jprichardson/node-fs-extra/blob/141422ee384fda83e3e1d4af2727bc9dca799f68/lib/copy/ncp.js#L13) I think it would be specially awesome if\r\n\r\n   A. there would be the opportunity to have filters that work relatively to the working directory\r\n   B. there would be the opportunity to specify where the working directory is (overriding the good `process.cwd()` default)\r\n\r\nAdditionally it would be super awesome if the filter would allow [glob](https://www.npmjs.com/package/glob) file patterns instead of regexp patterns because they are made for files.\r\n\r\n_Note: I am thinking about the API a little and think it would be good to have an `include` and `exclude` option instead of filters. (Considering #65)_"}}
{"actor":{"display_login":"jprichardson"}}