{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/77903801","id":77903801,"diff_hunk":"@@ -276,8 +276,10 @@ internal abstract partial class AbstractSemanticQuickInfoProvider : AbstractQuic\n             var symbols = semanticModel.GetSymbols(token, document.Project.Solution.Workspace, bindLiteralsToUnderlyingType: true, cancellationToken: cancellationToken);\n \n             var bindableParent = document.GetLanguageService<ISyntaxFactsService>().GetBindableParent(token);\n-            var overloads = semanticModel.GetMemberGroup(bindableParent, cancellationToken);\n-\n+            var parentSymbol = semanticModel.GetSymbolInfo(bindableParent).Symbol;\n+            var overloads = semanticModel.GetMemberGroup(bindableParent, cancellationToken)\n+                                         .Where(s => parentSymbol == null || enclosingType.InheritsFromOrEquals(parentSymbol.ContainingType) || s.IsStatic == parentSymbol.IsStatic);\n+            ","path":"src/EditorFeatures/Core/Implementation/IntelliSense/QuickInfo/Providers/AbstractSemanticQuickInfoProvider.cs","position":9,"original_position":9,"commit_id":"8e0ce79eecb66707371d7a18fa913442b435bec5","original_commit_id":"8e0ce79eecb66707371d7a18fa913442b435bec5","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"body":"Not trying to make a statement about the correctness of this approach, but how similar is it to the code in completion which already handles static/instance?","created_at":"2016-09-07T21:06:10Z","updated_at":"2016-09-07T21:06:10Z","html_url":"https://github.com/dotnet/roslyn/pull/13464#discussion_r77903801","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13464","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/77903801"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13464#discussion_r77903801"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13464"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/13464","id":83334854,"html_url":"https://github.com/dotnet/roslyn/pull/13464","diff_url":"https://github.com/dotnet/roslyn/pull/13464.diff","patch_url":"https://github.com/dotnet/roslyn/pull/13464.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/13464","number":13464,"state":"open","locked":false,"title":"Don't use static overloads on instance for QuickInfo","user":{"login":"antonssonj","id":12250134,"avatar_url":"https://avatars.githubusercontent.com/u/12250134?v=3","gravatar_id":"","url":"https://api.github.com/users/antonssonj","html_url":"https://github.com/antonssonj","followers_url":"https://api.github.com/users/antonssonj/followers","following_url":"https://api.github.com/users/antonssonj/following{/other_user}","gists_url":"https://api.github.com/users/antonssonj/gists{/gist_id}","starred_url":"https://api.github.com/users/antonssonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonssonj/subscriptions","organizations_url":"https://api.github.com/users/antonssonj/orgs","repos_url":"https://api.github.com/users/antonssonj/repos","events_url":"https://api.github.com/users/antonssonj/events{/privacy}","received_events_url":"https://api.github.com/users/antonssonj/received_events","type":"User","site_admin":false},"body":"Fix #13462","created_at":"2016-08-30T19:47:56Z","updated_at":"2016-09-07T21:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b674944a28cbb6ddfcc95a3977db1d4c19d80803","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13464/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13464/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/13464/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/8e0ce79eecb66707371d7a18fa913442b435bec5","head":{"label":"antonssonj:master","ref":"master","sha":"8e0ce79eecb66707371d7a18fa913442b435bec5","user":{"login":"antonssonj","id":12250134,"avatar_url":"https://avatars.githubusercontent.com/u/12250134?v=3","gravatar_id":"","url":"https://api.github.com/users/antonssonj","html_url":"https://github.com/antonssonj","followers_url":"https://api.github.com/users/antonssonj/followers","following_url":"https://api.github.com/users/antonssonj/following{/other_user}","gists_url":"https://api.github.com/users/antonssonj/gists{/gist_id}","starred_url":"https://api.github.com/users/antonssonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonssonj/subscriptions","organizations_url":"https://api.github.com/users/antonssonj/orgs","repos_url":"https://api.github.com/users/antonssonj/repos","events_url":"https://api.github.com/users/antonssonj/events{/privacy}","received_events_url":"https://api.github.com/users/antonssonj/received_events","type":"User","site_admin":false},"repo":{"id":51840174,"name":"roslyn","full_name":"antonssonj/roslyn","owner":{"login":"antonssonj","id":12250134,"avatar_url":"https://avatars.githubusercontent.com/u/12250134?v=3","gravatar_id":"","url":"https://api.github.com/users/antonssonj","html_url":"https://github.com/antonssonj","followers_url":"https://api.github.com/users/antonssonj/followers","following_url":"https://api.github.com/users/antonssonj/following{/other_user}","gists_url":"https://api.github.com/users/antonssonj/gists{/gist_id}","starred_url":"https://api.github.com/users/antonssonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonssonj/subscriptions","organizations_url":"https://api.github.com/users/antonssonj/orgs","repos_url":"https://api.github.com/users/antonssonj/repos","events_url":"https://api.github.com/users/antonssonj/events{/privacy}","received_events_url":"https://api.github.com/users/antonssonj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antonssonj/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/antonssonj/roslyn","forks_url":"https://api.github.com/repos/antonssonj/roslyn/forks","keys_url":"https://api.github.com/repos/antonssonj/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antonssonj/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antonssonj/roslyn/teams","hooks_url":"https://api.github.com/repos/antonssonj/roslyn/hooks","issue_events_url":"https://api.github.com/repos/antonssonj/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/antonssonj/roslyn/events","assignees_url":"https://api.github.com/repos/antonssonj/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/antonssonj/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/antonssonj/roslyn/tags","blobs_url":"https://api.github.com/repos/antonssonj/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antonssonj/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antonssonj/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/antonssonj/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antonssonj/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/antonssonj/roslyn/languages","stargazers_url":"https://api.github.com/repos/antonssonj/roslyn/stargazers","contributors_url":"https://api.github.com/repos/antonssonj/roslyn/contributors","subscribers_url":"https://api.github.com/repos/antonssonj/roslyn/subscribers","subscription_url":"https://api.github.com/repos/antonssonj/roslyn/subscription","commits_url":"https://api.github.com/repos/antonssonj/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/antonssonj/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/antonssonj/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/antonssonj/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/antonssonj/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/antonssonj/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antonssonj/roslyn/merges","archive_url":"https://api.github.com/repos/antonssonj/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antonssonj/roslyn/downloads","issues_url":"https://api.github.com/repos/antonssonj/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/antonssonj/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/antonssonj/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/antonssonj/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antonssonj/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/antonssonj/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/antonssonj/roslyn/deployments","created_at":"2016-02-16T14:05:06Z","updated_at":"2016-02-16T14:05:38Z","pushed_at":"2016-08-30T15:47:11Z","git_url":"git://github.com/antonssonj/roslyn.git","ssh_url":"git@github.com:antonssonj/roslyn.git","clone_url":"https://github.com/antonssonj/roslyn.git","svn_url":"https://github.com/antonssonj/roslyn","homepage":"","size":128858,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c484138f142ceead907aa557e2b12aaee58220b4","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-09-07T19:00:43Z","pushed_at":"2016-09-07T20:56:20Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":331501,"stargazers_count":6176,"watchers_count":6176,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1476,"mirror_url":null,"open_issues_count":3175,"forks":1476,"open_issues":3175,"watchers":6176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13464"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13464"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13464"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13464/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13464/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13464/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/8e0ce79eecb66707371d7a18fa913442b435bec5"}}}}
{"actor":{"display_login":"Pilchie"}}