{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/559","repository_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/559/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/559/comments","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/559/events","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/559","id":181834687,"number":559,"title":"Prefer the displayName rather than the fullName for prettier display","user":{"login":"alecharp","id":985955,"avatar_url":"https://avatars.githubusercontent.com/u/985955?v=3","gravatar_id":"","url":"https://api.github.com/users/alecharp","html_url":"https://github.com/alecharp","followers_url":"https://api.github.com/users/alecharp/followers","following_url":"https://api.github.com/users/alecharp/following{/other_user}","gists_url":"https://api.github.com/users/alecharp/gists{/gist_id}","starred_url":"https://api.github.com/users/alecharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecharp/subscriptions","organizations_url":"https://api.github.com/users/alecharp/orgs","repos_url":"https://api.github.com/users/alecharp/repos","events_url":"https://api.github.com/users/alecharp/events{/privacy}","received_events_url":"https://api.github.com/users/alecharp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/work-in-progress","name":"work-in-progress","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-08T16:22:14Z","updated_at":"2016-10-10T20:17:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/559","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/559","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/559.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/559.patch"},"body":"# Description\r\n\r\nSee [JENKINS-38042](https://issues.jenkins-ci.org/browse/JENKINS-38042).\r\n\r\nThere is no unit test as the displayed value of the `Link` in `PipelineRowItem` is not tested at this point. \r\n\r\nI \"manually\" validated the change: I created a job which I named `my-ugly-project` and set its __Display name__ to `My Beautiful project`. I also reacted another project without changing the __Display name__ to validate it didn't affect the current behavior. But as the `displayName` is filled with the `fullName` when it's not specified, then the front part of this plugin has no impact on this.\r\n\r\nI couldn't run a complete build of the project as the current `master` branch has code inspections issues (lines being too longs) even before I coded my patch.\r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [ ] Ran Acceptance Test Harness against PR changes.\r\n\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [ ] Reviewed the code\r\n- [ ] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@jenkinsci/code-reviewers @reviewbybees \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments/252734632","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/559#issuecomment-252734632","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/559","id":252734632,"user":{"login":"michaelneale","id":14976,"avatar_url":"https://avatars.githubusercontent.com/u/14976?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelneale","html_url":"https://github.com/michaelneale","followers_url":"https://api.github.com/users/michaelneale/followers","following_url":"https://api.github.com/users/michaelneale/following{/other_user}","gists_url":"https://api.github.com/users/michaelneale/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelneale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelneale/subscriptions","organizations_url":"https://api.github.com/users/michaelneale/orgs","repos_url":"https://api.github.com/users/michaelneale/repos","events_url":"https://api.github.com/users/michaelneale/events{/privacy}","received_events_url":"https://api.github.com/users/michaelneale/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T20:17:44Z","updated_at":"2016-10-10T20:17:44Z","body":"ok thanks @alecharp and thanks @scherler for clarifying this"}}
{"actor":{"display_login":"michaelneale"}}