{"push_id":1025381708,"size":52,"distinct_size":52,"ref":"refs/heads/master","head":"2e8644fa18739f9cd9ca639ef510477b8d27862d","before":"27e8e3fe31bf4eb48c20ac2fa667c643fc87e424","commits":[{"sha":"fd05c6458e7f36ab48cf4f088694eb18c8f23510","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Move `application_address` content into partial\n\nThe `application_address` local, when present, is only used for\nshowing content related to sending your application, so this\nmoves the content into a suitably named partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/fd05c6458e7f36ab48cf4f088694eb18c8f23510"},{"sha":"c572eca15de8b73c4c0a5d69caff554b4a521062","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Move rendering of `sending_your_application`\n\nMove the call to render `sending_your_application` to the outcome so\nwe don’t need to pass `application_address` through the \n`making_your_application` partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/c572eca15de8b73c4c0a5d69caff554b4a521062"},{"sha":"80fa4b1cb9f7317739a8b5f63e21b9d52573f13b","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Add calculator class to overseas passports\n\nAnd add ability to read and write the current_location in calculator,\nand save current_location in the first question.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/80fa4b1cb9f7317739a8b5f63e21b9d52573f13b"},{"sha":"146af04d49098eea199afaa726f8f6091d9c8a0e","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Add book_appointments_online? to calculator\n\nMove list of countries from outcome partial to calculator, and add \nmethod for outcomes to determine if the current_location allows it.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/146af04d49098eea199afaa726f8f6091d9c8a0e"},{"sha":"cec8068a82f3fbdd5cf696576e27755bf504012f","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove data in outcome for overseas passports\n\nRemove the data declared in partial `make_your_application` for\n`uk_visa_application_centre_countries` and replace with a method in\n`OverseasPassportCalculator` class that is now passed to the partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/cec8068a82f3fbdd5cf696576e27755bf504012f"},{"sha":"47daa7d81c5f50a0d2bdc79724d9447c91fbdd7c","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Re-format long array over multiple lines","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/47daa7d81c5f50a0d2bdc79724d9447c91fbdd7c"},{"sha":"7d7e4fe14845b4a956d7dad8f293fbb4c5b37c7b","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove data from outcome in overseas passports\n\nRemove the data declared in partial `make_your_application` for\n`uk_visa_application_with_colour_pictures` and replace with a method in\n`OverseasPassportCalculator` class that is now passed to the partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/7d7e4fe14845b4a956d7dad8f293fbb4c5b37c7b"},{"sha":"dfd1547b030a4ccfc71f51c0861398db62ab46aa","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Re-format long array over mutiple lines","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/dfd1547b030a4ccfc71f51c0861398db62ab46aa"},{"sha":"629a37315bac792b61612e2c6ec3860d2ac2b4d2","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove data from outcome in overseas passports\n\nRemove the data declared in partial `make_your_application` for\n`non_uk_visa_application_with_colour_pictures` and replace with a method\nin `OverseasPassportCalculator` class that is now passed to the partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/629a37315bac792b61612e2c6ec3860d2ac2b4d2"},{"sha":"7ab77fdaf1c4fabd32d8bb5532feafb5dbd668f3","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove `current_location` variable from partial\n\nWith `current_location` now saved in the overseas passports calculator,\nthis is the first step at removing the variable from being passed\naround the smart answer ERB files by remove it from the\n`making_your_application` partial.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/7ab77fdaf1c4fabd32d8bb5532feafb5dbd668f3"},{"sha":"69a5717b88b1d76eb814beb2afa1407d5739a27a","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove `save_input_as` state in overseas passports\n\nTo further remove the propagation of `current_location` throughout\noverseas passports, this makes the `calculator` available in the first\nquestion and sets `current_location` using a `next_node_calculation`\nso `save_input_as ‘current_location’` can be removed.\n\nThe `next_node_calculation` setting the value of `current_location` can\nbe removed in future commits once the reliance on this variable is\nremoved.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/69a5717b88b1d76eb814beb2afa1407d5739a27a"},{"sha":"a62aa022930dad163658b912ff37c86e1cde0f92","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove variable from overseas passports flow\n\nAdd `EXCLUDE_COUNTRIES` array to overseas passports calculator to allow\nthe data to be removed from the smart answer flow.\n\nThis type of array may better belong `PassportAndEmbassyDataQuery`\ndata class which can return all the data associated with overseas\npassports in future commits.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/a62aa022930dad163658b912ff37c86e1cde0f92"},{"sha":"6372e9d3f3a8d7bb22b2a52a97b230854bd97f9a","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Add `ineligible_country?` to calculator class\n\nRemove the array data embedded in the smart answers in favour of having\na method in the calculator class that can be tested in isolation.\n\nAgain, this data may better belong in the data query class or even a\nYML file in future commits.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/6372e9d3f3a8d7bb22b2a52a97b230854bd97f9a"},{"sha":"f497297a9753b160ac308f71a04337a4e877c4b8","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove array variable from overseas passports flow\n\nAdd method `apply_in_neighbouring_countries` to the overseas passports\ncalculator to allow the state to be removed from being embedded in the\nsmart answer flow and for tests to be written at unit level.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/f497297a9753b160ac308f71a04337a4e877c4b8"},{"sha":"685c15a9f2ad4c608f1c2f6aa8b8f05480ab81d3","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Optimise find world location in overseas passports\n\nThis code seemed to find a world location and then checked to see if it\nshould find an alternate world location and called find world location\nagain when true.\n\nThe implementation `ALT_EMBASSIES.has_key?(value)` is replaced in favour\nof `ALT_EMBASSIES[value] || value`, removing the very small possibility\nof having an alternate embassy location key with a `nil` or `false`\nvalue.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/685c15a9f2ad4c608f1c2f6aa8b8f05480ab81d3"},{"sha":"226214b70d5ec36bfa384857ebbde025ee9ca22a","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove alternative embassy logic from flow\n\nAdd method `alternative_embassy_location` to the overseas passports\ncalculator as a first step to remove the dependency on the data\nquery class in the smart answer flow.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/226214b70d5ec36bfa384857ebbde025ee9ca22a"},{"sha":"aafa63501b5912671f2ef49024e7a06630894482","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Move world location query from flow to calculator\n\nAdd `world_location` method to overseas passports calculator to allow\nit to be removed from the smart answer flow and for unit tests to be\nwritten around it’s logic.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/aafa63501b5912671f2ef49024e7a06630894482"},{"sha":"6dfdf0748e8a5e73c98570d032f07b3d2c8e1103","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Add `world_location_name` method to calculator\n\nReplace smart answer flow variable `title_output` by adding a method\nto the calculator to return the name of it's `world_location`.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/6dfdf0748e8a5e73c98570d032f07b3d2c8e1103"},{"sha":"1329ecf2fc90e7cd789124883591d629c7355f42","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove use of `current_location` in outcome\n\nThis value is now available in the calculator method `current_location`,\nwhich is available in the outcome.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/1329ecf2fc90e7cd789124883591d629c7355f42"},{"sha":"46f6cc8d0a02c9151715d7f5e8c07b0d05d31747","author":{"email":"505c84fc0d4eb0d7d674b5359732d24467a12f8e@gmail.com","name":"Erik Eide"},"message":"Remove smart answer flow variable from outcome\n\nReplace `current_location` with call to calculator#current_location \nwhich now returns the same value and will allow us to remove the\n`current_location` variable.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/46f6cc8d0a02c9151715d7f5e8c07b0d05d31747"}]}