{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/comments/65616310","id":65616310,"diff_hunk":"@@ -11,15 +11,19 @@\n import ucar.ma2.ArrayChar;\n import ucar.ma2.Index;\n import ucar.nc2.Variable;\n+import ucar.nc2.dataset.EnhanceScaleMissing;\n \n public class NetcdfReader {\n \n     private Array data;\n     \n     private IndexValuesConverter indexValuesConverter;\n     private Index index;\n+    private final Variable variable;\n \n     public NetcdfReader(Variable variable) throws IOException {","path":"src/main/java/au/org/emii/netcdf/iterator/reader/NetcdfReader.java","position":14,"original_position":14,"commit_id":"6983f3ff146fe3ae1436a427b9b313b5e1789eab","original_commit_id":"6983f3ff146fe3ae1436a427b9b313b5e1789eab","user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"body":"Not sure I have a problem with that in this case. Not doing this will complicate the client api or this class without refactoring which is probably best left to https://github.com/aodn/netcdf-iterator/issues/2. ","created_at":"2016-06-02T20:53:12Z","updated_at":"2016-06-02T20:53:12Z","html_url":"https://github.com/aodn/netcdf-iterator/pull/3#discussion_r65616310","pull_request_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/comments/65616310"},"html":{"href":"https://github.com/aodn/netcdf-iterator/pull/3#discussion_r65616310"},"pull_request":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3","id":71647184,"html_url":"https://github.com/aodn/netcdf-iterator/pull/3","diff_url":"https://github.com/aodn/netcdf-iterator/pull/3.diff","patch_url":"https://github.com/aodn/netcdf-iterator/pull/3.patch","issue_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/3","number":3,"state":"open","locked":false,"title":"Add a getDisplayValue option to NetCdfReader that returns an empty st…","user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"body":"…ring for missing values","created_at":"2016-05-27T01:05:34Z","updated_at":"2016-06-02T20:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd86744ea649a3a4fb9aabac3f560b1f2682b19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3/commits","review_comments_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3/comments","review_comment_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/3/comments","statuses_url":"https://api.github.com/repos/aodn/netcdf-iterator/statuses/6983f3ff146fe3ae1436a427b9b313b5e1789eab","head":{"label":"aodn:add-missing-option","ref":"add-missing-option","sha":"6983f3ff146fe3ae1436a427b9b313b5e1789eab","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":59718843,"name":"netcdf-iterator","full_name":"aodn/netcdf-iterator","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/netcdf-iterator","description":"Supporting routines for iterating over netcdf file contents","fork":false,"url":"https://api.github.com/repos/aodn/netcdf-iterator","forks_url":"https://api.github.com/repos/aodn/netcdf-iterator/forks","keys_url":"https://api.github.com/repos/aodn/netcdf-iterator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/netcdf-iterator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/netcdf-iterator/teams","hooks_url":"https://api.github.com/repos/aodn/netcdf-iterator/hooks","issue_events_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/netcdf-iterator/events","assignees_url":"https://api.github.com/repos/aodn/netcdf-iterator/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/netcdf-iterator/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/netcdf-iterator/tags","blobs_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/netcdf-iterator/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/netcdf-iterator/languages","stargazers_url":"https://api.github.com/repos/aodn/netcdf-iterator/stargazers","contributors_url":"https://api.github.com/repos/aodn/netcdf-iterator/contributors","subscribers_url":"https://api.github.com/repos/aodn/netcdf-iterator/subscribers","subscription_url":"https://api.github.com/repos/aodn/netcdf-iterator/subscription","commits_url":"https://api.github.com/repos/aodn/netcdf-iterator/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/netcdf-iterator/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/netcdf-iterator/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/netcdf-iterator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/netcdf-iterator/merges","archive_url":"https://api.github.com/repos/aodn/netcdf-iterator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/netcdf-iterator/downloads","issues_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/netcdf-iterator/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/netcdf-iterator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/netcdf-iterator/labels{/name}","releases_url":"https://api.github.com/repos/aodn/netcdf-iterator/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/netcdf-iterator/deployments","created_at":"2016-05-26T04:06:59Z","updated_at":"2016-05-26T04:48:19Z","pushed_at":"2016-05-27T01:05:34Z","git_url":"git://github.com/aodn/netcdf-iterator.git","ssh_url":"git@github.com:aodn/netcdf-iterator.git","clone_url":"https://github.com/aodn/netcdf-iterator.git","svn_url":"https://github.com/aodn/netcdf-iterator","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"e73f2472e0d0d26841f59933521b723a4a228b35","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":59718843,"name":"netcdf-iterator","full_name":"aodn/netcdf-iterator","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/netcdf-iterator","description":"Supporting routines for iterating over netcdf file contents","fork":false,"url":"https://api.github.com/repos/aodn/netcdf-iterator","forks_url":"https://api.github.com/repos/aodn/netcdf-iterator/forks","keys_url":"https://api.github.com/repos/aodn/netcdf-iterator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/netcdf-iterator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/netcdf-iterator/teams","hooks_url":"https://api.github.com/repos/aodn/netcdf-iterator/hooks","issue_events_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/netcdf-iterator/events","assignees_url":"https://api.github.com/repos/aodn/netcdf-iterator/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/netcdf-iterator/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/netcdf-iterator/tags","blobs_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/netcdf-iterator/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/netcdf-iterator/languages","stargazers_url":"https://api.github.com/repos/aodn/netcdf-iterator/stargazers","contributors_url":"https://api.github.com/repos/aodn/netcdf-iterator/contributors","subscribers_url":"https://api.github.com/repos/aodn/netcdf-iterator/subscribers","subscription_url":"https://api.github.com/repos/aodn/netcdf-iterator/subscription","commits_url":"https://api.github.com/repos/aodn/netcdf-iterator/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/netcdf-iterator/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/netcdf-iterator/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/netcdf-iterator/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/netcdf-iterator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/netcdf-iterator/merges","archive_url":"https://api.github.com/repos/aodn/netcdf-iterator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/netcdf-iterator/downloads","issues_url":"https://api.github.com/repos/aodn/netcdf-iterator/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/netcdf-iterator/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/netcdf-iterator/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/netcdf-iterator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/netcdf-iterator/labels{/name}","releases_url":"https://api.github.com/repos/aodn/netcdf-iterator/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/netcdf-iterator/deployments","created_at":"2016-05-26T04:06:59Z","updated_at":"2016-05-26T04:48:19Z","pushed_at":"2016-05-27T01:05:34Z","git_url":"git://github.com/aodn/netcdf-iterator.git","ssh_url":"git@github.com:aodn/netcdf-iterator.git","clone_url":"https://github.com/aodn/netcdf-iterator.git","svn_url":"https://github.com/aodn/netcdf-iterator","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3"},"html":{"href":"https://github.com/aodn/netcdf-iterator/pull/3"},"issue":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/issues/3"},"comments":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/netcdf-iterator/statuses/6983f3ff146fe3ae1436a427b9b313b5e1789eab"}}}}
{"actor":{"display_login":"jonescc"}}