{"action":"created","issue":{"url":"https://api.github.com/repos/netz98/n98-magerun2/issues/215","repository_url":"https://api.github.com/repos/netz98/n98-magerun2","labels_url":"https://api.github.com/repos/netz98/n98-magerun2/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/netz98/n98-magerun2/issues/215/comments","events_url":"https://api.github.com/repos/netz98/n98-magerun2/issues/215/events","html_url":"https://github.com/netz98/n98-magerun2/pull/215","id":162624554,"number":215,"title":"ScriptCommand legacy code refactored","user":{"login":"p-makowski","id":6819904,"avatar_url":"https://avatars.githubusercontent.com/u/6819904?v=3","gravatar_id":"","url":"https://api.github.com/users/p-makowski","html_url":"https://github.com/p-makowski","followers_url":"https://api.github.com/users/p-makowski/followers","following_url":"https://api.github.com/users/p-makowski/following{/other_user}","gists_url":"https://api.github.com/users/p-makowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-makowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-makowski/subscriptions","organizations_url":"https://api.github.com/users/p-makowski/orgs","repos_url":"https://api.github.com/users/p-makowski/repos","events_url":"https://api.github.com/users/p-makowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-makowski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T07:57:29Z","updated_at":"2016-06-28T15:51:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netz98/n98-magerun2/pulls/215","html_url":"https://github.com/netz98/n98-magerun2/pull/215","diff_url":"https://github.com/netz98/n98-magerun2/pull/215.diff","patch_url":"https://github.com/netz98/n98-magerun2/pull/215.patch"},"body":"Refactored code from PR https://github.com/netz98/n98-magerun2/pull/214 (already merged).\r\nRelates to Fix #212 .\r\n\r\nChanges proposed in this pull request:\r\nUsage of public methods ´\\Magento\\Framework\\App\\ProductMetadata::getVersion()´ ´\\Magento\\Framework\\App\\ProductMetadata::getEdition()´ is compatible with all tagged version of Magento 2 (see https://github.com/magento/magento2/blob/0.42.0-beta9/lib/internal/Magento/Framework/App/ProductMetadata.php)\r\nThere is no need to rely on ´\\Magento\\Framework\\AppInterface::VERSION´ constant any more, which was removed in Magento 2.1.\r\n"},"comment":{"url":"https://api.github.com/repos/netz98/n98-magerun2/issues/comments/229093031","html_url":"https://github.com/netz98/n98-magerun2/pull/215#issuecomment-229093031","issue_url":"https://api.github.com/repos/netz98/n98-magerun2/issues/215","id":229093031,"user":{"login":"p-makowski","id":6819904,"avatar_url":"https://avatars.githubusercontent.com/u/6819904?v=3","gravatar_id":"","url":"https://api.github.com/users/p-makowski","html_url":"https://github.com/p-makowski","followers_url":"https://api.github.com/users/p-makowski/followers","following_url":"https://api.github.com/users/p-makowski/following{/other_user}","gists_url":"https://api.github.com/users/p-makowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-makowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-makowski/subscriptions","organizations_url":"https://api.github.com/users/p-makowski/orgs","repos_url":"https://api.github.com/users/p-makowski/repos","events_url":"https://api.github.com/users/p-makowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-makowski/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T15:51:33Z","updated_at":"2016-06-28T15:51:33Z","body":"I didn't use rebase before, so having no time I updated upstream/develop and merged it to my branch. Is it OK for you now? I see that build failed again. Should I try to rebase? I think it won't have any effect currently. "}}
{"actor":{"display_login":"p-makowski"}}