{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/github-reports/pulls/comments/89976974","pull_request_review_id":10502352,"id":89976974,"diff_hunk":"@@ -109,12 +115,35 @@ public void givenUsersWhereRead_whenGettingGithubUsers_thenReturnAllUsers() thro\n     }\n \n     @Test\n-    public void givenUsersWereReadAndHaveNoContent_whenGettingGithubUsers_thenReturnAllUsers() throws IOException {\n+    public void givenUsersWereReadAndHaveNoContent_whenGettingGithubUsers_thenReturnAllUsers() {\n         given(mockUsersReader.hasContent()).willReturn(true);\n         given(mockUsersReader.getContent()).willReturn(Collections.emptyMap());\n \n         List<String> actualGithubUsers = floatGithubUserConverter.getGithubUsers();\n \n         assertEquals(Collections.emptyList(), actualGithubUsers);\n     }\n+\n+    @Test(expected = FailedToLoadMappingsException.class)\n+    public void givenUsersReaderFails_whenGettingGithubUsers_thenAnExceptionIsThrown() throws Exception {\n+        willThrow(IOException.class).given(mockUsersReader).read();\n+\n+        floatGithubUserConverter.getGithubUsers();\n+","path":"float/src/test/java/com/novoda/floatschedule/convert/FloatGithubUserConverterTest.java","position":60,"original_position":60,"commit_id":"2a9c6070f27ea6fdd3551d6c1473d3d01ddfc3ae","original_commit_id":"2a9c6070f27ea6fdd3551d6c1473d3d01ddfc3ae","user":{"login":"frapontillo","id":1140238,"avatar_url":"https://avatars.githubusercontent.com/u/1140238?v=3","gravatar_id":"","url":"https://api.github.com/users/frapontillo","html_url":"https://github.com/frapontillo","followers_url":"https://api.github.com/users/frapontillo/followers","following_url":"https://api.github.com/users/frapontillo/following{/other_user}","gists_url":"https://api.github.com/users/frapontillo/gists{/gist_id}","starred_url":"https://api.github.com/users/frapontillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frapontillo/subscriptions","organizations_url":"https://api.github.com/users/frapontillo/orgs","repos_url":"https://api.github.com/users/frapontillo/repos","events_url":"https://api.github.com/users/frapontillo/events{/privacy}","received_events_url":"https://api.github.com/users/frapontillo/received_events","type":"User","site_admin":false},"body":"Blank line, are we keeping them when we want to test for exceptions?","created_at":"2016-11-29T10:08:35Z","updated_at":"2016-11-29T10:09:49Z","html_url":"https://github.com/novoda/github-reports/pull/50#discussion_r89976974","pull_request_url":"https://api.github.com/repos/novoda/github-reports/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/comments/89976974"},"html":{"href":"https://github.com/novoda/github-reports/pull/50#discussion_r89976974"},"pull_request":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/github-reports/pulls/50","id":95424450,"html_url":"https://github.com/novoda/github-reports/pull/50","diff_url":"https://github.com/novoda/github-reports/pull/50.diff","patch_url":"https://github.com/novoda/github-reports/pull/50.patch","issue_url":"https://api.github.com/repos/novoda/github-reports/issues/50","number":50,"state":"open","locked":false,"title":"Integrate sheets","user":{"login":"takecare","id":212528,"avatar_url":"https://avatars.githubusercontent.com/u/212528?v=3","gravatar_id":"","url":"https://api.github.com/users/takecare","html_url":"https://github.com/takecare","followers_url":"https://api.github.com/users/takecare/followers","following_url":"https://api.github.com/users/takecare/following{/other_user}","gists_url":"https://api.github.com/users/takecare/gists{/gist_id}","starred_url":"https://api.github.com/users/takecare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takecare/subscriptions","organizations_url":"https://api.github.com/users/takecare/orgs","repos_url":"https://api.github.com/users/takecare/repos","events_url":"https://api.github.com/users/takecare/events{/privacy}","received_events_url":"https://api.github.com/users/takecare/received_events","type":"User","site_admin":false},"body":"#### Problem\r\n\r\nAs we now have in place what we need to hit a given sheets document and get its contents, we should now move to using it appropriately, i.e., read user mappings when needed.\r\n\r\n#### Solution\r\n\r\nAs we're aiming to provide an alternate solution (there's one already in place), it was first wrapped in an interface so as to guarantee a common API and non-breaking changes for its clients. This is the `GithubUserConverter` interface.\r\n\r\nSome extraction of predicates (filters) and suppliers (exceptions) took place in order do avoid duplication.\r\n\r\nSo we're now providing a `SheetsFloatGithubUserConverter` which will hit the document when its contents are empty, synchronously by default, given that when a client asks for a name we're assuming it needs it then.\r\n\r\n##### Test(s) added\r\n\r\nYes.\r\n","created_at":"2016-11-28T00:44:49Z","updated_at":"2016-11-29T10:09:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7cc3922eb5cd9a2844e222073f4faa560549666","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/github-reports/pulls/50/commits","review_comments_url":"https://api.github.com/repos/novoda/github-reports/pulls/50/comments","review_comment_url":"https://api.github.com/repos/novoda/github-reports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/github-reports/issues/50/comments","statuses_url":"https://api.github.com/repos/novoda/github-reports/statuses/2a9c6070f27ea6fdd3551d6c1473d3d01ddfc3ae","head":{"label":"novoda:integrate-sheets","ref":"integrate-sheets","sha":"2a9c6070f27ea6fdd3551d6c1473d3d01ddfc3ae","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":65547837,"name":"github-reports","full_name":"novoda/github-reports","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/github-reports","description":"Github reports for a given organisation","fork":false,"url":"https://api.github.com/repos/novoda/github-reports","forks_url":"https://api.github.com/repos/novoda/github-reports/forks","keys_url":"https://api.github.com/repos/novoda/github-reports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/github-reports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/github-reports/teams","hooks_url":"https://api.github.com/repos/novoda/github-reports/hooks","issue_events_url":"https://api.github.com/repos/novoda/github-reports/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/github-reports/events","assignees_url":"https://api.github.com/repos/novoda/github-reports/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/github-reports/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/github-reports/tags","blobs_url":"https://api.github.com/repos/novoda/github-reports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/github-reports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/github-reports/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/github-reports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/github-reports/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/github-reports/languages","stargazers_url":"https://api.github.com/repos/novoda/github-reports/stargazers","contributors_url":"https://api.github.com/repos/novoda/github-reports/contributors","subscribers_url":"https://api.github.com/repos/novoda/github-reports/subscribers","subscription_url":"https://api.github.com/repos/novoda/github-reports/subscription","commits_url":"https://api.github.com/repos/novoda/github-reports/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/github-reports/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/github-reports/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/github-reports/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/github-reports/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/github-reports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/github-reports/merges","archive_url":"https://api.github.com/repos/novoda/github-reports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/github-reports/downloads","issues_url":"https://api.github.com/repos/novoda/github-reports/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/github-reports/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/github-reports/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/github-reports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/github-reports/labels{/name}","releases_url":"https://api.github.com/repos/novoda/github-reports/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/github-reports/deployments","created_at":"2016-08-12T11:16:56Z","updated_at":"2016-11-26T17:59:14Z","pushed_at":"2016-11-28T20:25:14Z","git_url":"git://github.com/novoda/github-reports.git","ssh_url":"git@github.com:novoda/github-reports.git","clone_url":"https://github.com/novoda/github-reports.git","svn_url":"https://github.com/novoda/github-reports","homepage":"","size":11498,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"novoda:mappings-management","ref":"mappings-management","sha":"1e209db396ea87d44c27de3eca42d646e15ab75f","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":65547837,"name":"github-reports","full_name":"novoda/github-reports","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/github-reports","description":"Github reports for a given organisation","fork":false,"url":"https://api.github.com/repos/novoda/github-reports","forks_url":"https://api.github.com/repos/novoda/github-reports/forks","keys_url":"https://api.github.com/repos/novoda/github-reports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/github-reports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/github-reports/teams","hooks_url":"https://api.github.com/repos/novoda/github-reports/hooks","issue_events_url":"https://api.github.com/repos/novoda/github-reports/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/github-reports/events","assignees_url":"https://api.github.com/repos/novoda/github-reports/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/github-reports/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/github-reports/tags","blobs_url":"https://api.github.com/repos/novoda/github-reports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/github-reports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/github-reports/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/github-reports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/github-reports/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/github-reports/languages","stargazers_url":"https://api.github.com/repos/novoda/github-reports/stargazers","contributors_url":"https://api.github.com/repos/novoda/github-reports/contributors","subscribers_url":"https://api.github.com/repos/novoda/github-reports/subscribers","subscription_url":"https://api.github.com/repos/novoda/github-reports/subscription","commits_url":"https://api.github.com/repos/novoda/github-reports/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/github-reports/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/github-reports/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/github-reports/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/github-reports/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/github-reports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/github-reports/merges","archive_url":"https://api.github.com/repos/novoda/github-reports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/github-reports/downloads","issues_url":"https://api.github.com/repos/novoda/github-reports/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/github-reports/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/github-reports/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/github-reports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/github-reports/labels{/name}","releases_url":"https://api.github.com/repos/novoda/github-reports/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/github-reports/deployments","created_at":"2016-08-12T11:16:56Z","updated_at":"2016-11-26T17:59:14Z","pushed_at":"2016-11-28T20:25:14Z","git_url":"git://github.com/novoda/github-reports.git","ssh_url":"git@github.com:novoda/github-reports.git","clone_url":"https://github.com/novoda/github-reports.git","svn_url":"https://github.com/novoda/github-reports","homepage":"","size":11498,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/50"},"html":{"href":"https://github.com/novoda/github-reports/pull/50"},"issue":{"href":"https://api.github.com/repos/novoda/github-reports/issues/50"},"comments":{"href":"https://api.github.com/repos/novoda/github-reports/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/github-reports/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/github-reports/statuses/2a9c6070f27ea6fdd3551d6c1473d3d01ddfc3ae"}}}}
{"actor":{"display_login":"frapontillo"}}