{"action":"created","issue":{"url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/249","repository_url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog","labels_url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/249/comments","events_url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/249/events","html_url":"https://github.com/nakupanda/bootstrap3-dialog/issues/249","id":140055990,"number":249,"title":"NPM Module needs to point at dist, not src.","user":{"login":"baconface","id":4763342,"avatar_url":"https://avatars.githubusercontent.com/u/4763342?v=3","gravatar_id":"","url":"https://api.github.com/users/baconface","html_url":"https://github.com/baconface","followers_url":"https://api.github.com/users/baconface/followers","following_url":"https://api.github.com/users/baconface/following{/other_user}","gists_url":"https://api.github.com/users/baconface/gists{/gist_id}","starred_url":"https://api.github.com/users/baconface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baconface/subscriptions","organizations_url":"https://api.github.com/users/baconface/orgs","repos_url":"https://api.github.com/users/baconface/repos","events_url":"https://api.github.com/users/baconface/events{/privacy}","received_events_url":"https://api.github.com/users/baconface/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-11T01:11:36Z","updated_at":"2016-06-16T02:37:44Z","closed_at":null,"body":"Currently the package on NPM is 1.34.6. So maybe it has been fixed since then and not pushed. But the current version offered is affected by this.\r\n\r\nMy issue is my Gruntfile.js purposely removes the src from my project's root and it's dependencies. This is so my final release is a little lighter. Being an Electron application I can use all the trimming I can get. It appears the Node module uses the src instead of the dist for the bootstrap-dialog.js. As a result it gets stripped from my production build and breaks my application. Of course I can mess around with my Gruntfile.js and get around this. But I would prefer to not use/ship the src at all since a dist is offered.\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/comments/226373785","html_url":"https://github.com/nakupanda/bootstrap3-dialog/issues/249#issuecomment-226373785","issue_url":"https://api.github.com/repos/nakupanda/bootstrap3-dialog/issues/249","id":226373785,"user":{"login":"baconface","id":4763342,"avatar_url":"https://avatars.githubusercontent.com/u/4763342?v=3","gravatar_id":"","url":"https://api.github.com/users/baconface","html_url":"https://github.com/baconface","followers_url":"https://api.github.com/users/baconface/followers","following_url":"https://api.github.com/users/baconface/following{/other_user}","gists_url":"https://api.github.com/users/baconface/gists{/gist_id}","starred_url":"https://api.github.com/users/baconface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baconface/subscriptions","organizations_url":"https://api.github.com/users/baconface/orgs","repos_url":"https://api.github.com/users/baconface/repos","events_url":"https://api.github.com/users/baconface/events{/privacy}","received_events_url":"https://api.github.com/users/baconface/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T02:37:44Z","updated_at":"2016-06-16T02:37:44Z","body":"No problem. And for reference [here is a similar issue](https://github.com/electron/electron/issues/254) that was brought up about jQuery. Here it was clarified how Electron expects packages to be loaded as if it were in the CommonJS environment. To me, it just doesn't make since to use all packages with exports one way and then the `bootstrap3-dialog` a completely different way.\r\n\r\nhttps://github.com/electron/electron/issues/254"}}
{"actor":{"display_login":"baconface"}}