{"action":"created","issue":{"url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/83","repository_url":"https://api.github.com/repos/romix/akka-kryo-serialization","labels_url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/83/comments","events_url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/83/events","html_url":"https://github.com/romix/akka-kryo-serialization/issues/83","id":140499229,"number":83,"title":"[Discussion & PR?] Smaller messages with \"idstrategy = default\" and \"use-manifests = true\"","user":{"login":"guidomedina","id":1789197,"avatar_url":"https://avatars.githubusercontent.com/u/1789197?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomedina","html_url":"https://github.com/guidomedina","followers_url":"https://api.github.com/users/guidomedina/followers","following_url":"https://api.github.com/users/guidomedina/following{/other_user}","gists_url":"https://api.github.com/users/guidomedina/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomedina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomedina/subscriptions","organizations_url":"https://api.github.com/users/guidomedina/orgs","repos_url":"https://api.github.com/users/guidomedina/repos","events_url":"https://api.github.com/users/guidomedina/events{/privacy}","received_events_url":"https://api.github.com/users/guidomedina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-03-13T15:56:29Z","updated_at":"2016-03-14T15:03:58Z","closed_at":null,"body":"@romix @luben I added some logging to debug my message sizes and for `idstrategy = \"default\"` and `use-manifests = true` my messages are smaller than with no manifest which makes think something must have changed?\r\n\r\nWhat I mean here is that something must have changed that before no-manifest was rendering smaller messages.\r\n\r\nWhy is it `use-manifest = false` by default? Unless most people use `explicit` or `incremental` `idsestrategy`?, if that is not the case I propose two small changes, `use-manifests = true` by default and to invert the `if condition` where the first condition is `if (!useManifests) ...` negating the most probable execution.\r\n\r\nI have tested Scala performance and in general (this is probably also true for Java), the most probable condition should be the first tested which accomplishes the best performance (less false positives or fallbacks to else) and would also make that `if condition` clearer _- performance here isn't compelling enough to change but easier to read -_\r\n\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/comments/196356530","html_url":"https://github.com/romix/akka-kryo-serialization/issues/83#issuecomment-196356530","issue_url":"https://api.github.com/repos/romix/akka-kryo-serialization/issues/83","id":196356530,"user":{"login":"guidomedina","id":1789197,"avatar_url":"https://avatars.githubusercontent.com/u/1789197?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomedina","html_url":"https://github.com/guidomedina","followers_url":"https://api.github.com/users/guidomedina/followers","following_url":"https://api.github.com/users/guidomedina/following{/other_user}","gists_url":"https://api.github.com/users/guidomedina/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomedina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomedina/subscriptions","organizations_url":"https://api.github.com/users/guidomedina/orgs","repos_url":"https://api.github.com/users/guidomedina/repos","events_url":"https://api.github.com/users/guidomedina/events{/privacy}","received_events_url":"https://api.github.com/users/guidomedina/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T15:03:58Z","updated_at":"2016-03-14T15:03:58Z","body":"@luben I pushed again, only with minor corrections then, I think it is fair to say that the manifest usage needs a closer look, maybe there is something that can actually be improved there, I can only say that I'm getting smaller sizes with it = true."}}