{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/72362727","id":72362727,"diff_hunk":"@@ -1151,6 +1154,16 @@ public void delete(Iterable<SweepPriorityRow> rows) {\n         return transformed;\n     }\n \n+    @Override\n+    public Iterator<Map.Entry<SweepPriorityRow, SweepPriorityNamedColumnValue<?>>> getRowsColumnRange(Iterable<SweepPriorityRow> rows, ColumnRangeSelection columnRangeSelection, int batchHint) {\n+        Iterator<Map.Entry<Cell, byte[]>> results = t.getRowsColumnRange(getTableRef(), Persistables.persistAll(rows), columnRangeSelection, batchHint);\n+        return Iterators.transform(results, e -> {\n+            SweepPriorityRow row = SweepPriorityRow.BYTES_HYDRATOR.hydrateFromBytes(e.getKey().getRowName());\n+            SweepPriorityNamedColumnValue<?> colValue = shortNameToHydrator.get(PtBytes.toString(e.getKey().getColumnName())).hydrateFromBytes(e.getValue());\n+            return new AbstractMap.SimpleEntry<SweepPriorityRow, SweepPriorityNamedColumnValue<?>>(row, colValue);","path":"atlasdb-client/src/main/java/com/palantir/atlasdb/schema/generated/SweepPriorityTable.java","position":42,"original_position":42,"commit_id":"9750844258ee32121e5b3150dcc3aa133d42ee89","original_commit_id":"9750844258ee32121e5b3150dcc3aa133d42ee89","user":{"login":"schlosna","id":54594,"avatar_url":"https://avatars.githubusercontent.com/u/54594?v=3","gravatar_id":"","url":"https://api.github.com/users/schlosna","html_url":"https://github.com/schlosna","followers_url":"https://api.github.com/users/schlosna/followers","following_url":"https://api.github.com/users/schlosna/following{/other_user}","gists_url":"https://api.github.com/users/schlosna/gists{/gist_id}","starred_url":"https://api.github.com/users/schlosna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlosna/subscriptions","organizations_url":"https://api.github.com/users/schlosna/orgs","repos_url":"https://api.github.com/users/schlosna/repos","events_url":"https://api.github.com/users/schlosna/events{/privacy}","received_events_url":"https://api.github.com/users/schlosna/received_events","type":"User","site_admin":false},"body":"Might consider `Maps.immutableEntry` To prevent setValue (and avoid some generics cruft).","created_at":"2016-07-27T00:27:44Z","updated_at":"2016-07-27T00:27:44Z","html_url":"https://github.com/palantir/atlasdb/pull/724#discussion_r72362727","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/72362727"},"html":{"href":"https://github.com/palantir/atlasdb/pull/724#discussion_r72362727"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/724","id":78777171,"html_url":"https://github.com/palantir/atlasdb/pull/724","diff_url":"https://github.com/palantir/atlasdb/pull/724.diff","patch_url":"https://github.com/palantir/atlasdb/pull/724.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/724","number":724,"state":"open","locked":false,"title":"Feature/improved column paging","user":{"login":"jeffrey-c","id":20566289,"avatar_url":"https://avatars.githubusercontent.com/u/20566289?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffrey-c","html_url":"https://github.com/jeffrey-c","followers_url":"https://api.github.com/users/jeffrey-c/followers","following_url":"https://api.github.com/users/jeffrey-c/following{/other_user}","gists_url":"https://api.github.com/users/jeffrey-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffrey-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffrey-c/subscriptions","organizations_url":"https://api.github.com/users/jeffrey-c/orgs","repos_url":"https://api.github.com/users/jeffrey-c/repos","events_url":"https://api.github.com/users/jeffrey-c/events{/privacy}","received_events_url":"https://api.github.com/users/jeffrey-c/received_events","type":"User","site_admin":false},"body":"Adding a new getRowsColumnRange method that should be more efficient on DbKvs and easier to consume in many situations. This takes a single batch limit for all the rows, instead of a limit per row, and returns all results in a single iterator instead of a visitiable per row. The implementation in DbKvs preloads column counts for each row to figure out exactly how to partition the requests; other implementations delegate to the existing getRowsColumnRange method.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/724)\n<!-- Reviewable:end -->\n","created_at":"2016-07-26T01:08:26Z","updated_at":"2016-07-27T00:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e51cb37149f9d2e5533aaba93084c249cba5886","assignee":{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false},"assignees":[{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false},{"login":"tmgordeeva","id":14338161,"avatar_url":"https://avatars.githubusercontent.com/u/14338161?v=3","gravatar_id":"","url":"https://api.github.com/users/tmgordeeva","html_url":"https://github.com/tmgordeeva","followers_url":"https://api.github.com/users/tmgordeeva/followers","following_url":"https://api.github.com/users/tmgordeeva/following{/other_user}","gists_url":"https://api.github.com/users/tmgordeeva/gists{/gist_id}","starred_url":"https://api.github.com/users/tmgordeeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmgordeeva/subscriptions","organizations_url":"https://api.github.com/users/tmgordeeva/orgs","repos_url":"https://api.github.com/users/tmgordeeva/repos","events_url":"https://api.github.com/users/tmgordeeva/events{/privacy}","received_events_url":"https://api.github.com/users/tmgordeeva/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/724/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/724/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/724/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/9750844258ee32121e5b3150dcc3aa133d42ee89","head":{"label":"palantir:feature/improved-column-paging","ref":"feature/improved-column-paging","sha":"9750844258ee32121e5b3150dcc3aa133d42ee89","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-07-25T13:10:10Z","pushed_at":"2016-07-27T00:02:12Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":23382,"stargazers_count":349,"watchers_count":349,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":77,"forks":54,"open_issues":77,"watchers":349,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"280f2b1682dcf20c52c9a31f837bf7a149713af8","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-07-25T13:10:10Z","pushed_at":"2016-07-27T00:02:12Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":23382,"stargazers_count":349,"watchers_count":349,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":77,"forks":54,"open_issues":77,"watchers":349,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/724"},"html":{"href":"https://github.com/palantir/atlasdb/pull/724"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/724"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/9750844258ee32121e5b3150dcc3aa133d42ee89"}}}}
{"actor":{"display_login":"schlosna"}}