{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/68232136","id":68232136,"diff_hunk":"@@ -172,34 +175,93 @@ def score_for_module(self, location):\n         return earned, possible\n \n \n-def descriptor_affects_grading(block_types_affecting_grading, descriptor):\n+@Memoized\n+def block_types_with_scores():","path":"lms/djangoapps/courseware/grades.py","position":54,"original_position":54,"commit_id":"b5818bc1a2c4c18e221244dcc46aedd62335cdaa","original_commit_id":"6bd04a5ddb12a82baf1e52f187e9ebac235feda7","user":{"login":"sanfordstudent","id":12545624,"avatar_url":"https://avatars.githubusercontent.com/u/12545624?v=3","gravatar_id":"","url":"https://api.github.com/users/sanfordstudent","html_url":"https://github.com/sanfordstudent","followers_url":"https://api.github.com/users/sanfordstudent/followers","following_url":"https://api.github.com/users/sanfordstudent/following{/other_user}","gists_url":"https://api.github.com/users/sanfordstudent/gists{/gist_id}","starred_url":"https://api.github.com/users/sanfordstudent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanfordstudent/subscriptions","organizations_url":"https://api.github.com/users/sanfordstudent/orgs","repos_url":"https://api.github.com/users/sanfordstudent/repos","events_url":"https://api.github.com/users/sanfordstudent/events{/privacy}","received_events_url":"https://api.github.com/users/sanfordstudent/received_events","type":"User","site_admin":false},"body":"Just wanted to say that the `Memoized` decorator is awesome.","created_at":"2016-06-23T13:18:53Z","updated_at":"2016-06-23T13:18:53Z","html_url":"https://github.com/edx/edx-platform/pull/12567#discussion_r68232136","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12567","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/68232136"},"html":{"href":"https://github.com/edx/edx-platform/pull/12567#discussion_r68232136"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12567"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12567","id":71497422,"html_url":"https://github.com/edx/edx-platform/pull/12567","diff_url":"https://github.com/edx/edx-platform/pull/12567.diff","patch_url":"https://github.com/edx/edx-platform/pull/12567.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12567","number":12567,"state":"open","locked":false,"title":"Grading uses Block Transformers","user":{"login":"nasthagiri","id":6772826,"avatar_url":"https://avatars.githubusercontent.com/u/6772826?v=3","gravatar_id":"","url":"https://api.github.com/users/nasthagiri","html_url":"https://github.com/nasthagiri","followers_url":"https://api.github.com/users/nasthagiri/followers","following_url":"https://api.github.com/users/nasthagiri/following{/other_user}","gists_url":"https://api.github.com/users/nasthagiri/gists{/gist_id}","starred_url":"https://api.github.com/users/nasthagiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasthagiri/subscriptions","organizations_url":"https://api.github.com/users/nasthagiri/orgs","repos_url":"https://api.github.com/users/nasthagiri/repos","events_url":"https://api.github.com/users/nasthagiri/events{/privacy}","received_events_url":"https://api.github.com/users/nasthagiri/received_events","type":"User","site_admin":false},"body":"This PR is the next stepping stone in improving the performance of the edX Progress Page and the grading code ([link to Epic](https://openedx.atlassian.net/browse/TNL-4447)). It updates the grading infrastructure to use the Block Transformers framework.  [Load testing](https://openedx.atlassian.net/wiki/display/TNL/Progress+Page+Load+Testing+Results) results show an overall 40% performance improvement over the existing code.\r\n\r\n*Things to note:*\r\n- The GradesBlockTransformer implemented in a [previous PR](https://openedx.atlassian.net/browse/TNL-4449) is now enabled and used by the grading code.\r\n- The always_recalculate_grades field is no longer honored as verified in a [previous ticket](https://openedx.atlassian.net/browse/TNL-4453).\r\n- As explained in [this CCX ticket](https://openedx.atlassian.net/browse/TNL-4648), the CCX field overrides needed to be moved from user-specific overrides to course-wide overrides for this work.\r\n- Since grades are used/required by many unit tests, the Block Transformer registry is now enabled for all unit tests (previously it was disabled by overriding `TransformerRegistry.USE_PLUGIN_MANAGER` in unit tests.\r\n- The `BlockStructure` interface was enhanced to support native `dict` and property accessors.\r\n- Utilities from `course_metadata_utils` were moved to `block_metadata_utils` in order to support them at the block level and not just the course level.\r\n\r\n*Follow-up performance work:* As we are not satisfied with the 40% increase (it still needs to be much faster to achieve real-time grading access), we plan to follow up with:\r\n- [Profiling of the Progress Page](https://openedx.atlassian.net/browse/TNL-4548)\r\n- Pursuing \"Persistent grades\" as a fallout of the [Spike on robustifying grades](https://openedx.atlassian.net/browse/TNL-4564).\r\n\r\n*Reviewers:*\r\n* @efischer19 Please review the full PR.\r\n* @sanfordstudent Please review the full PR, with extra focus on the largest commit: \"Update grades to use Block Structures\".\r\n* @jcdyer Please focus on the commit related to the BlockStructure API changes.\r\n* @pdpinch FYI on the CCX commit.\r\n* FYI @ormsbee, @catong ","created_at":"2016-05-26T04:03:36Z","updated_at":"2016-06-23T13:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e44d098250600e2407af1192888ec81f4fe2e2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12567/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12567/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12567/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/b5818bc1a2c4c18e221244dcc46aedd62335cdaa","head":{"label":"edx:tnl/grading","ref":"tnl/grading","sha":"b5818bc1a2c4c18e221244dcc46aedd62335cdaa","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-22T14:10:12Z","pushed_at":"2016-06-23T13:11:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":767517,"stargazers_count":2637,"watchers_count":2637,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1599,"mirror_url":null,"open_issues_count":175,"forks":1599,"open_issues":175,"watchers":2637,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"caedc92d6797b6dc3a40f4cba0c872a037fdd7d7","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-22T14:10:12Z","pushed_at":"2016-06-23T13:11:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":767517,"stargazers_count":2637,"watchers_count":2637,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1599,"mirror_url":null,"open_issues_count":175,"forks":1599,"open_issues":175,"watchers":2637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12567"},"html":{"href":"https://github.com/edx/edx-platform/pull/12567"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12567"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12567/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12567/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12567/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/b5818bc1a2c4c18e221244dcc46aedd62335cdaa"}}}}
{"actor":{"display_login":"sanfordstudent"}}