{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/20200","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/20200/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/20200/comments","events_url":"https://api.github.com/repos/docker/docker/issues/20200/events","html_url":"https://github.com/docker/docker/pull/20200","id":132788940,"number":20200,"title":"WIP: Don't smoosh hostname and domainname in API","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-10T19:03:10Z","updated_at":"2016-02-13T23:55:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20200","html_url":"https://github.com/docker/docker/pull/20200","diff_url":"https://github.com/docker/docker/pull/20200.diff","patch_url":"https://github.com/docker/docker/pull/20200.patch"},"body":"Fixes #14282 \r\n\r\nI think this is a better solution than #20196.  Rather than make the CLI split `--hostname`, let it happen at the backend.  This preserve's the user's intentions all the way through.  No API change needed.  No behavioral change from the CLI.  The results of `docker inspect` will be different for `--hostname=foo.bar.com` containers, but the user-visible behavior is the same.  The only behavioral change is for API users that specify both `hostname` and `domainname`, in which case the container's hostname will just be the `hostname` field.  Otherwise it behaves exactly the same.\r\n\r\nTests and docs are not updated yet, pending someone saying they don't hate this.  And yes, it obviously has to go into libnetwork, not here.  I'll do all that if folks say this is OK."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/183773288","html_url":"https://github.com/docker/docker/pull/20200#issuecomment-183773288","issue_url":"https://api.github.com/repos/docker/docker/issues/20200","id":183773288,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-02-13T23:55:04Z","updated_at":"2016-02-13T23:55:04Z","body":"Job: Docker-PRs-gccgo [FAILED](https://jenkins.dockerproject.org/job/Docker-PRs-gccgo/1887/console):\n\n~~~console\n\n---\nperations_unix.go:179:29: error: argument 2 has incompatible type\r\n   rlimits = append(rlimits, rl)\r\n                             ^\r\ndaemon/container_operations_unix.go:195:33: error: incompatible type for field 13 in struct construction\r\n   Rlimits:                      rlimits,\r\n                                 ^\r\ndaemon/container_operations_unix.go:141:18: error: incompatible types in assignment\r\n   ulIdx[ul.Name] = ul\r\n                  ^\r\nBuild step 'Execute shell' marked build as failure\n[PostBuildScript] - Execution post build scripts.\n[Docker-PRs-gccgo] $ /bin/sh -xe /tmp/hudson8607958572844247359.sh\n+ set +x\n\n\n---\n\n~~~"}}