{"action":"created","comment":{"url":"https://api.github.com/repos/trythings/trythings/pulls/comments/72800821","id":72800821,"diff_hunk":"@@ -92,10 +139,23 @@ func (s *SearchService) Create(ctx context.Context, se *Search) error {\n \t\treturn errors.New(\"Name is required\")\n \t}\n \n-\tif se.ViewID == \"\" {\n-\t\treturn errors.New(\"ViewID is required\")\n+\tif se.ViewID != \"\" {","path":"ellies-pad/api/search.go","position":85,"original_position":85,"commit_id":"afb372ede45c0a6f0a7c0c2b6dd030abb3e03a04","original_commit_id":"afb372ede45c0a6f0a7c0c2b6dd030abb3e03a04","user":{"login":"verticalpalette","id":619672,"avatar_url":"https://avatars.githubusercontent.com/u/619672?v=3","gravatar_id":"","url":"https://api.github.com/users/verticalpalette","html_url":"https://github.com/verticalpalette","followers_url":"https://api.github.com/users/verticalpalette/followers","following_url":"https://api.github.com/users/verticalpalette/following{/other_user}","gists_url":"https://api.github.com/users/verticalpalette/gists{/gist_id}","starred_url":"https://api.github.com/users/verticalpalette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verticalpalette/subscriptions","organizations_url":"https://api.github.com/users/verticalpalette/orgs","repos_url":"https://api.github.com/users/verticalpalette/repos","events_url":"https://api.github.com/users/verticalpalette/events{/privacy}","received_events_url":"https://api.github.com/users/verticalpalette/received_events","type":"User","site_admin":false},"body":"Let's add more validation. We can make the viewID required.","created_at":"2016-07-29T14:31:29Z","updated_at":"2016-07-29T14:31:29Z","html_url":"https://github.com/trythings/trythings/pull/11#discussion_r72800821","pull_request_url":"https://api.github.com/repos/trythings/trythings/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/trythings/trythings/pulls/comments/72800821"},"html":{"href":"https://github.com/trythings/trythings/pull/11#discussion_r72800821"},"pull_request":{"href":"https://api.github.com/repos/trythings/trythings/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/trythings/trythings/pulls/11","id":79256958,"html_url":"https://github.com/trythings/trythings/pull/11","diff_url":"https://github.com/trythings/trythings/pull/11.diff","patch_url":"https://github.com/trythings/trythings/pull/11.patch","issue_url":"https://api.github.com/repos/trythings/trythings/issues/11","number":11,"state":"open","locked":false,"title":"Replace task lists with paginated lists","user":{"login":"annie1","id":7551795,"avatar_url":"https://avatars.githubusercontent.com/u/7551795?v=3","gravatar_id":"","url":"https://api.github.com/users/annie1","html_url":"https://github.com/annie1","followers_url":"https://api.github.com/users/annie1/followers","following_url":"https://api.github.com/users/annie1/following{/other_user}","gists_url":"https://api.github.com/users/annie1/gists{/gist_id}","starred_url":"https://api.github.com/users/annie1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annie1/subscriptions","organizations_url":"https://api.github.com/users/annie1/orgs","repos_url":"https://api.github.com/users/annie1/repos","events_url":"https://api.github.com/users/annie1/events{/privacy}","received_events_url":"https://api.github.com/users/annie1/received_events","type":"User","site_admin":false},"body":"We used to do pagination on the client. Now we do it through Relay connections.","created_at":"2016-07-28T19:50:20Z","updated_at":"2016-07-29T14:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"638ed6364371905aae9d7102c85b07d57b85d370","assignee":{"login":"verticalpalette","id":619672,"avatar_url":"https://avatars.githubusercontent.com/u/619672?v=3","gravatar_id":"","url":"https://api.github.com/users/verticalpalette","html_url":"https://github.com/verticalpalette","followers_url":"https://api.github.com/users/verticalpalette/followers","following_url":"https://api.github.com/users/verticalpalette/following{/other_user}","gists_url":"https://api.github.com/users/verticalpalette/gists{/gist_id}","starred_url":"https://api.github.com/users/verticalpalette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verticalpalette/subscriptions","organizations_url":"https://api.github.com/users/verticalpalette/orgs","repos_url":"https://api.github.com/users/verticalpalette/repos","events_url":"https://api.github.com/users/verticalpalette/events{/privacy}","received_events_url":"https://api.github.com/users/verticalpalette/received_events","type":"User","site_admin":false},"assignees":[{"login":"verticalpalette","id":619672,"avatar_url":"https://avatars.githubusercontent.com/u/619672?v=3","gravatar_id":"","url":"https://api.github.com/users/verticalpalette","html_url":"https://github.com/verticalpalette","followers_url":"https://api.github.com/users/verticalpalette/followers","following_url":"https://api.github.com/users/verticalpalette/following{/other_user}","gists_url":"https://api.github.com/users/verticalpalette/gists{/gist_id}","starred_url":"https://api.github.com/users/verticalpalette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verticalpalette/subscriptions","organizations_url":"https://api.github.com/users/verticalpalette/orgs","repos_url":"https://api.github.com/users/verticalpalette/repos","events_url":"https://api.github.com/users/verticalpalette/events{/privacy}","received_events_url":"https://api.github.com/users/verticalpalette/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/trythings/trythings/pulls/11/commits","review_comments_url":"https://api.github.com/repos/trythings/trythings/pulls/11/comments","review_comment_url":"https://api.github.com/repos/trythings/trythings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trythings/trythings/issues/11/comments","statuses_url":"https://api.github.com/repos/trythings/trythings/statuses/afb372ede45c0a6f0a7c0c2b6dd030abb3e03a04","head":{"label":"trythings:pagination","ref":"pagination","sha":"afb372ede45c0a6f0a7c0c2b6dd030abb3e03a04","user":{"login":"trythings","id":12422529,"avatar_url":"https://avatars.githubusercontent.com/u/12422529?v=3","gravatar_id":"","url":"https://api.github.com/users/trythings","html_url":"https://github.com/trythings","followers_url":"https://api.github.com/users/trythings/followers","following_url":"https://api.github.com/users/trythings/following{/other_user}","gists_url":"https://api.github.com/users/trythings/gists{/gist_id}","starred_url":"https://api.github.com/users/trythings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trythings/subscriptions","organizations_url":"https://api.github.com/users/trythings/orgs","repos_url":"https://api.github.com/users/trythings/repos","events_url":"https://api.github.com/users/trythings/events{/privacy}","received_events_url":"https://api.github.com/users/trythings/received_events","type":"Organization","site_admin":false},"repo":{"id":38022669,"name":"trythings","full_name":"trythings/trythings","owner":{"login":"trythings","id":12422529,"avatar_url":"https://avatars.githubusercontent.com/u/12422529?v=3","gravatar_id":"","url":"https://api.github.com/users/trythings","html_url":"https://github.com/trythings","followers_url":"https://api.github.com/users/trythings/followers","following_url":"https://api.github.com/users/trythings/following{/other_user}","gists_url":"https://api.github.com/users/trythings/gists{/gist_id}","starred_url":"https://api.github.com/users/trythings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trythings/subscriptions","organizations_url":"https://api.github.com/users/trythings/orgs","repos_url":"https://api.github.com/users/trythings/repos","events_url":"https://api.github.com/users/trythings/events{/privacy}","received_events_url":"https://api.github.com/users/trythings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trythings/trythings","description":"","fork":false,"url":"https://api.github.com/repos/trythings/trythings","forks_url":"https://api.github.com/repos/trythings/trythings/forks","keys_url":"https://api.github.com/repos/trythings/trythings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trythings/trythings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trythings/trythings/teams","hooks_url":"https://api.github.com/repos/trythings/trythings/hooks","issue_events_url":"https://api.github.com/repos/trythings/trythings/issues/events{/number}","events_url":"https://api.github.com/repos/trythings/trythings/events","assignees_url":"https://api.github.com/repos/trythings/trythings/assignees{/user}","branches_url":"https://api.github.com/repos/trythings/trythings/branches{/branch}","tags_url":"https://api.github.com/repos/trythings/trythings/tags","blobs_url":"https://api.github.com/repos/trythings/trythings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trythings/trythings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trythings/trythings/git/refs{/sha}","trees_url":"https://api.github.com/repos/trythings/trythings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trythings/trythings/statuses/{sha}","languages_url":"https://api.github.com/repos/trythings/trythings/languages","stargazers_url":"https://api.github.com/repos/trythings/trythings/stargazers","contributors_url":"https://api.github.com/repos/trythings/trythings/contributors","subscribers_url":"https://api.github.com/repos/trythings/trythings/subscribers","subscription_url":"https://api.github.com/repos/trythings/trythings/subscription","commits_url":"https://api.github.com/repos/trythings/trythings/commits{/sha}","git_commits_url":"https://api.github.com/repos/trythings/trythings/git/commits{/sha}","comments_url":"https://api.github.com/repos/trythings/trythings/comments{/number}","issue_comment_url":"https://api.github.com/repos/trythings/trythings/issues/comments{/number}","contents_url":"https://api.github.com/repos/trythings/trythings/contents/{+path}","compare_url":"https://api.github.com/repos/trythings/trythings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trythings/trythings/merges","archive_url":"https://api.github.com/repos/trythings/trythings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trythings/trythings/downloads","issues_url":"https://api.github.com/repos/trythings/trythings/issues{/number}","pulls_url":"https://api.github.com/repos/trythings/trythings/pulls{/number}","milestones_url":"https://api.github.com/repos/trythings/trythings/milestones{/number}","notifications_url":"https://api.github.com/repos/trythings/trythings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trythings/trythings/labels{/name}","releases_url":"https://api.github.com/repos/trythings/trythings/releases{/id}","deployments_url":"https://api.github.com/repos/trythings/trythings/deployments","created_at":"2015-06-25T02:15:27Z","updated_at":"2016-02-09T07:18:07Z","pushed_at":"2016-07-28T22:26:13Z","git_url":"git://github.com/trythings/trythings.git","ssh_url":"git@github.com:trythings/trythings.git","clone_url":"https://github.com/trythings/trythings.git","svn_url":"https://github.com/trythings/trythings","homepage":null,"size":3118,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"trythings:master","ref":"master","sha":"d25589e7bc53eb1e671a548071f07aad4b0fcb47","user":{"login":"trythings","id":12422529,"avatar_url":"https://avatars.githubusercontent.com/u/12422529?v=3","gravatar_id":"","url":"https://api.github.com/users/trythings","html_url":"https://github.com/trythings","followers_url":"https://api.github.com/users/trythings/followers","following_url":"https://api.github.com/users/trythings/following{/other_user}","gists_url":"https://api.github.com/users/trythings/gists{/gist_id}","starred_url":"https://api.github.com/users/trythings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trythings/subscriptions","organizations_url":"https://api.github.com/users/trythings/orgs","repos_url":"https://api.github.com/users/trythings/repos","events_url":"https://api.github.com/users/trythings/events{/privacy}","received_events_url":"https://api.github.com/users/trythings/received_events","type":"Organization","site_admin":false},"repo":{"id":38022669,"name":"trythings","full_name":"trythings/trythings","owner":{"login":"trythings","id":12422529,"avatar_url":"https://avatars.githubusercontent.com/u/12422529?v=3","gravatar_id":"","url":"https://api.github.com/users/trythings","html_url":"https://github.com/trythings","followers_url":"https://api.github.com/users/trythings/followers","following_url":"https://api.github.com/users/trythings/following{/other_user}","gists_url":"https://api.github.com/users/trythings/gists{/gist_id}","starred_url":"https://api.github.com/users/trythings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trythings/subscriptions","organizations_url":"https://api.github.com/users/trythings/orgs","repos_url":"https://api.github.com/users/trythings/repos","events_url":"https://api.github.com/users/trythings/events{/privacy}","received_events_url":"https://api.github.com/users/trythings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trythings/trythings","description":"","fork":false,"url":"https://api.github.com/repos/trythings/trythings","forks_url":"https://api.github.com/repos/trythings/trythings/forks","keys_url":"https://api.github.com/repos/trythings/trythings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trythings/trythings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trythings/trythings/teams","hooks_url":"https://api.github.com/repos/trythings/trythings/hooks","issue_events_url":"https://api.github.com/repos/trythings/trythings/issues/events{/number}","events_url":"https://api.github.com/repos/trythings/trythings/events","assignees_url":"https://api.github.com/repos/trythings/trythings/assignees{/user}","branches_url":"https://api.github.com/repos/trythings/trythings/branches{/branch}","tags_url":"https://api.github.com/repos/trythings/trythings/tags","blobs_url":"https://api.github.com/repos/trythings/trythings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trythings/trythings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trythings/trythings/git/refs{/sha}","trees_url":"https://api.github.com/repos/trythings/trythings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trythings/trythings/statuses/{sha}","languages_url":"https://api.github.com/repos/trythings/trythings/languages","stargazers_url":"https://api.github.com/repos/trythings/trythings/stargazers","contributors_url":"https://api.github.com/repos/trythings/trythings/contributors","subscribers_url":"https://api.github.com/repos/trythings/trythings/subscribers","subscription_url":"https://api.github.com/repos/trythings/trythings/subscription","commits_url":"https://api.github.com/repos/trythings/trythings/commits{/sha}","git_commits_url":"https://api.github.com/repos/trythings/trythings/git/commits{/sha}","comments_url":"https://api.github.com/repos/trythings/trythings/comments{/number}","issue_comment_url":"https://api.github.com/repos/trythings/trythings/issues/comments{/number}","contents_url":"https://api.github.com/repos/trythings/trythings/contents/{+path}","compare_url":"https://api.github.com/repos/trythings/trythings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trythings/trythings/merges","archive_url":"https://api.github.com/repos/trythings/trythings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trythings/trythings/downloads","issues_url":"https://api.github.com/repos/trythings/trythings/issues{/number}","pulls_url":"https://api.github.com/repos/trythings/trythings/pulls{/number}","milestones_url":"https://api.github.com/repos/trythings/trythings/milestones{/number}","notifications_url":"https://api.github.com/repos/trythings/trythings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trythings/trythings/labels{/name}","releases_url":"https://api.github.com/repos/trythings/trythings/releases{/id}","deployments_url":"https://api.github.com/repos/trythings/trythings/deployments","created_at":"2015-06-25T02:15:27Z","updated_at":"2016-02-09T07:18:07Z","pushed_at":"2016-07-28T22:26:13Z","git_url":"git://github.com/trythings/trythings.git","ssh_url":"git@github.com:trythings/trythings.git","clone_url":"https://github.com/trythings/trythings.git","svn_url":"https://github.com/trythings/trythings","homepage":null,"size":3118,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trythings/trythings/pulls/11"},"html":{"href":"https://github.com/trythings/trythings/pull/11"},"issue":{"href":"https://api.github.com/repos/trythings/trythings/issues/11"},"comments":{"href":"https://api.github.com/repos/trythings/trythings/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/trythings/trythings/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/trythings/trythings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trythings/trythings/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/trythings/trythings/statuses/afb372ede45c0a6f0a7c0c2b6dd030abb3e03a04"}}}}
{"actor":{"display_login":"verticalpalette"}}