{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/13430","repository_url":"https://api.github.com/repos/emberjs/ember.js","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/13430/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13430/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/13430/events","html_url":"https://github.com/emberjs/ember.js/pull/13430","id":151912152,"number":13430,"title":"[WIP] [Glimmer2] Rerender on run loop if data has changed","user":{"login":"nickiaconis","id":1056681,"avatar_url":"https://avatars.githubusercontent.com/u/1056681?v=3","gravatar_id":"","url":"https://api.github.com/users/nickiaconis","html_url":"https://github.com/nickiaconis","followers_url":"https://api.github.com/users/nickiaconis/followers","following_url":"https://api.github.com/users/nickiaconis/following{/other_user}","gists_url":"https://api.github.com/users/nickiaconis/gists{/gist_id}","starred_url":"https://api.github.com/users/nickiaconis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickiaconis/subscriptions","organizations_url":"https://api.github.com/users/nickiaconis/orgs","repos_url":"https://api.github.com/users/nickiaconis/repos","events_url":"https://api.github.com/users/nickiaconis/events{/privacy}","received_events_url":"https://api.github.com/users/nickiaconis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/emberjs/ember.js/labels/Glimmer2","name":"Glimmer2","color":"1d76db"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-29T16:26:33Z","updated_at":"2016-05-06T04:39:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13430","html_url":"https://github.com/emberjs/ember.js/pull/13430","diff_url":"https://github.com/emberjs/ember.js/pull/13430.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13430.patch"},"body":"Marking an object as dirty kicks off a run loop if one has not already been started. At the start of every run loop, a task is scheduled on the render queue to rerender the main view if any changes have occurred.\r\n\r\nTested by disabling the automatic invocation of manual rerendering in the glimmer tests.\r\n\r\nWill require ember-dev to be updated since this invalidates the assumption that a run loop should never be automatically started inside a test."},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/217347036","html_url":"https://github.com/emberjs/ember.js/pull/13430#issuecomment-217347036","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13430","id":217347036,"user":{"login":"nickiaconis","id":1056681,"avatar_url":"https://avatars.githubusercontent.com/u/1056681?v=3","gravatar_id":"","url":"https://api.github.com/users/nickiaconis","html_url":"https://github.com/nickiaconis","followers_url":"https://api.github.com/users/nickiaconis/followers","following_url":"https://api.github.com/users/nickiaconis/following{/other_user}","gists_url":"https://api.github.com/users/nickiaconis/gists{/gist_id}","starred_url":"https://api.github.com/users/nickiaconis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickiaconis/subscriptions","organizations_url":"https://api.github.com/users/nickiaconis/orgs","repos_url":"https://api.github.com/users/nickiaconis/repos","events_url":"https://api.github.com/users/nickiaconis/events{/privacy}","received_events_url":"https://api.github.com/users/nickiaconis/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T04:39:36Z","updated_at":"2016-05-06T04:39:36Z","body":"I think `this.runTask` needs to stay for now. The changes here rerender on\nthe run loop, but we'll need to ensure a run loop is running whenever\nsomething is set, which is not included here, before we can strip the\n`this.runTask` stuff.\nOn May 5, 2016 9:32 PM, \"Chad Hietala\" <notifications@github.com> wrote:\n\n> LGTM. Are there any tests that we can either flip to @test or ones we\n> could write to validate? Maybe this.runTask stuff can now be cleaned up?\n>\n> —\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/emberjs/ember.js/pull/13430#issuecomment-217346227>\n>\n"}}