{"action":"created","issue":{"url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/56","repository_url":"https://api.github.com/repos/bgrainger/MySqlConnector","labels_url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/56/comments","events_url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/56/events","html_url":"https://github.com/bgrainger/MySqlConnector/pull/56","id":177314696,"number":56,"title":"Fix Connection Pool - Need Help with SideBySide.New","user":{"login":"caleblloyd","id":2414837,"avatar_url":"https://avatars.githubusercontent.com/u/2414837?v=3","gravatar_id":"","url":"https://api.github.com/users/caleblloyd","html_url":"https://github.com/caleblloyd","followers_url":"https://api.github.com/users/caleblloyd/followers","following_url":"https://api.github.com/users/caleblloyd/following{/other_user}","gists_url":"https://api.github.com/users/caleblloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/caleblloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleblloyd/subscriptions","organizations_url":"https://api.github.com/users/caleblloyd/orgs","repos_url":"https://api.github.com/users/caleblloyd/repos","events_url":"https://api.github.com/users/caleblloyd/events{/privacy}","received_events_url":"https://api.github.com/users/caleblloyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-15T23:28:17Z","updated_at":"2016-09-16T02:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bgrainger/MySqlConnector/pulls/56","html_url":"https://github.com/bgrainger/MySqlConnector/pull/56","diff_url":"https://github.com/bgrainger/MySqlConnector/pull/56.diff","patch_url":"https://github.com/bgrainger/MySqlConnector/pull/56.patch"},"body":"I've taken a stab at fixing the connection pool.  I tested this implementation with MySqlConnector.Performance, but it seems to hang the SideBySide.New tests.  SideBySide.New does not print which test is currently running, so I'm not sure how to debug.\r\n\r\n@bgrainger can you take a look at the SideBySide.New tests and see if you can tell why they are hanging?  If you can add logging to it to print the method it's in, I can resolve the bug.  I tried briefly but I'm not very familiar with XUnit.\r\n\r\nAsync targets are running stable at 1500 Requests Per Second in the Performance Tests.  Very nice!!!  I'm running on an Intel Core i5-6260U, load test, web app, and database all running on the same machine.  Should do better on a dedicated app server.\r\n\r\n\tRate = 1500 RPS\r\n\tDuration = 10s\r\n\tTargets = targets-async.txt\r\n\r\n\tRequests      [total, rate]            15000, 1500.10\r\n\tDuration      [total, attack, wait]    10.000748548s, 9.999322811s, 1.425737ms\r\n\tLatencies     [mean, 50, 95, 99, max]  23.299198ms, 2.395148ms, 168.782969ms, 271.810346ms, 395.213902ms\r\n\tBytes In      [total, mean]            173108268, 11540.55\r\n\tBytes Out     [total, mean]            5561250, 370.75\r\n\tSuccess       [ratio]                  100.00%\r\n\tStatus Codes  [code:count]             200:15000  \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/comments/247503379","html_url":"https://github.com/bgrainger/MySqlConnector/pull/56#issuecomment-247503379","issue_url":"https://api.github.com/repos/bgrainger/MySqlConnector/issues/56","id":247503379,"user":{"login":"bgrainger","id":188129,"avatar_url":"https://avatars.githubusercontent.com/u/188129?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrainger","html_url":"https://github.com/bgrainger","followers_url":"https://api.github.com/users/bgrainger/followers","following_url":"https://api.github.com/users/bgrainger/following{/other_user}","gists_url":"https://api.github.com/users/bgrainger/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrainger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrainger/subscriptions","organizations_url":"https://api.github.com/users/bgrainger/orgs","repos_url":"https://api.github.com/users/bgrainger/repos","events_url":"https://api.github.com/users/bgrainger/events{/privacy}","received_events_url":"https://api.github.com/users/bgrainger/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T02:18:37Z","updated_at":"2016-09-16T02:18:37Z","body":"> If load is high and sessions aren't getting returned to the pool fast enough, the current implementation will hand out unlimited connections and overwhelm the database.\r\n\r\nThat makes total sense. I need to find out why MySql.Data does in this instance... just block until a connection is available? Or fail immediately with an exception?"}}
{"actor":{"display_login":"bgrainger"}}