{"action":"created","issue":{"url":"https://api.github.com/repos/ValvePython/steam/issues/35","repository_url":"https://api.github.com/repos/ValvePython/steam","labels_url":"https://api.github.com/repos/ValvePython/steam/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/ValvePython/steam/issues/35/comments","events_url":"https://api.github.com/repos/ValvePython/steam/issues/35/events","html_url":"https://github.com/ValvePython/steam/pull/35","id":158515044,"number":35,"title":"Saving steam account credentials","user":{"login":"philippj","id":9590076,"avatar_url":"https://avatars.githubusercontent.com/u/9590076?v=3","gravatar_id":"","url":"https://api.github.com/users/philippj","html_url":"https://github.com/philippj","followers_url":"https://api.github.com/users/philippj/followers","following_url":"https://api.github.com/users/philippj/following{/other_user}","gists_url":"https://api.github.com/users/philippj/gists{/gist_id}","starred_url":"https://api.github.com/users/philippj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippj/subscriptions","organizations_url":"https://api.github.com/users/philippj/orgs","repos_url":"https://api.github.com/users/philippj/repos","events_url":"https://api.github.com/users/philippj/events{/privacy}","received_events_url":"https://api.github.com/users/philippj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-06-04T17:33:08Z","updated_at":"2016-06-18T11:55:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ValvePython/steam/pulls/35","html_url":"https://github.com/ValvePython/steam/pull/35","diff_url":"https://github.com/ValvePython/steam/pull/35.diff","patch_url":"https://github.com/ValvePython/steam/pull/35.patch"},"body":"For now it is used to store account credentials and creating login codes/confirmation keys.\r\n\r\nThe account credentials are json dumped and encrypted with the password, in byte format, as key.\r\nAlso i did add a newer version of setuptools to the requirements, because a fresh installed debian is failing to compile cryptography with an old version of it.\r\n\r\nI tried my best at adapting your coding style, if it just isnt working out, please tell me."},"comment":{"url":"https://api.github.com/repos/ValvePython/steam/issues/comments/226937630","html_url":"https://github.com/ValvePython/steam/pull/35#issuecomment-226937630","issue_url":"https://api.github.com/repos/ValvePython/steam/issues/35","id":226937630,"user":{"login":"rossengeorgiev","id":2720787,"avatar_url":"https://avatars.githubusercontent.com/u/2720787?v=3","gravatar_id":"","url":"https://api.github.com/users/rossengeorgiev","html_url":"https://github.com/rossengeorgiev","followers_url":"https://api.github.com/users/rossengeorgiev/followers","following_url":"https://api.github.com/users/rossengeorgiev/following{/other_user}","gists_url":"https://api.github.com/users/rossengeorgiev/gists{/gist_id}","starred_url":"https://api.github.com/users/rossengeorgiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossengeorgiev/subscriptions","organizations_url":"https://api.github.com/users/rossengeorgiev/orgs","repos_url":"https://api.github.com/users/rossengeorgiev/repos","events_url":"https://api.github.com/users/rossengeorgiev/events{/privacy}","received_events_url":"https://api.github.com/users/rossengeorgiev/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T11:55:24Z","updated_at":"2016-06-18T11:55:24Z","body":"I had a quick look over the code and there is a lot of cruft. Some quick points:\r\n\r\n* Instead of doing all that attribute shuffling put everything in a `dict` and expose it via `__getattr__`. See https://github.com/ValvePython/steam/blob/f37ac6158f1ea5dc0b0841e1458585c55198291a/steam/guard.py#L68-L74\r\n\r\n* I don't see what the purpose of encrypting stuff is. I think that is something the application using the package should deal with.\r\n\r\n* I like that that there is flag for whether to register for api key if there isn't one. That's great. However, the default value should be `False`. A parameters for specifying the hostname would be great as well, with say `localhost` as default.\r\n\r\n* I see `WebAuth` bits cause some issues. I don't think those whole process needs to be reimplemented. Just let `WebAuth` raise its' exceptions. If you have the twofactor secrets, you can simply send the twofactor code on the first request. Mail code and captcha will cause problems. I can't think off the top of my head how to do this so that the API end up nice and clean."}}
{"actor":{"display_login":"rossengeorgiev"}}