{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/255","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/255/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/255/events","html_url":"https://github.com/dcos/dcos-ui/pull/255","id":156758740,"number":255,"title":"[2/8] Deployments Table - Don't use ServicesList to list services","user":{"login":"philipnrmn","id":2989362,"avatar_url":"https://avatars.githubusercontent.com/u/2989362?v=3","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dcos/dcos-ui/labels/assignee","name":"assignee","color":"0e8a16"}],"state":"open","locked":false,"assignee":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-25T14:02:16Z","updated_at":"2016-05-26T01:40:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/255","html_url":"https://github.com/dcos/dcos-ui/pull/255","diff_url":"https://github.com/dcos/dcos-ui/pull/255.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/255.patch"},"body":"`ServicesList` is actually a list used for instances of `Framework`, not `Service`. In order to avoid casting our non-framework services to frameworks, let's use an array to hold services on deployments instead of a `List`. "},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/221755969","html_url":"https://github.com/dcos/dcos-ui/pull/255#issuecomment-221755969","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/255","id":221755969,"user":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T01:40:50Z","updated_at":"2016-05-26T01:40:50Z","body":"I think, we should repurpose the `ServiceList` to handle all kinds of services and not only `Frameworks, but that's out of scope of this PR. I'm fine with using a plain array here, especially as there is no parsing and stuff needed. Let's create a Jira and schedule some time to properly refactor the service list."}}
{"actor":{"display_login":"orlandohohmeier"}}