{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/73231507","id":73231507,"diff_hunk":"@@ -21,7 +21,21 @@ class FullscreenToggle extends Button {\n   buildCSSClass() {\n     return `vjs-fullscreen-control ${super.buildCSSClass()}`;\n   }\n-\n+  /**\n+   * Handles Fullscreenchange on the component and change control text accordingly\n+   *\n+   * @method handleFullscreenChange\n+   */\n+  handleFullscreenChange() {\n+    if (this.player_.isFullscreen()) {\n+      this.addClass('vjs-fullscreen');\n+      this.controlBar.fullscreenToggle.controlText('Non-Fullscreen');\n+    }\n+    else {\n+      this.removeClass('vjs-fullscreen');\n+      this.controlBar.fullscreenToggle.controlText('Fullscreen');","path":"src/js/control-bar/fullscreen-toggle.js","position":17,"original_position":17,"commit_id":"000e80466ec21a55d83be20091513891ab148057","original_commit_id":"000e80466ec21a55d83be20091513891ab148057","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"we should make sure the context for this method is the fullscreen toggle itself, otherwise it can be super confusing.","created_at":"2016-08-02T20:32:57Z","updated_at":"2016-08-02T20:32:57Z","html_url":"https://github.com/videojs/video.js/pull/3485#discussion_r73231507","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/3485","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/73231507"},"html":{"href":"https://github.com/videojs/video.js/pull/3485#discussion_r73231507"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3485"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3485","id":79652164,"html_url":"https://github.com/videojs/video.js/pull/3485","diff_url":"https://github.com/videojs/video.js/pull/3485.diff","patch_url":"https://github.com/videojs/video.js/pull/3485.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3485","number":3485,"state":"open","locked":false,"title":"Control text fullscreen fix on ESC","user":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR is to make sure the correct control text is displayed on the Fullscreen button after pressing the ESC key while in Fullscreen mode.\r\n\r\n**Current Status:**\r\n_(Steps to reproduce)_\r\n1) Load the player on a page.\r\n2) Press the fullscreen button, the player goes into fullscreen mode.\r\n2) Hit the ESC key on your keyboard, and the player will go back to normal mode, however the control text on fullscreen button does not change or revert back to text as `Fullscreen`. It reads as `Non-Fullscreen` which is not correct.\r\n\r\n**After this fix:**\r\nFollow Step 1  and Step 2 as above. Press the ESC key and the control text should now revert back to the correct text as `Fullscreen`\r\n\r\n**Before this fix (current scenario)**\r\n<img width=\"571\" alt=\"before_fix_fullscreen\" src=\"https://cloud.githubusercontent.com/assets/1349170/17311562/4a34877c-581a-11e6-8372-434acb4b88da.png\">\r\n**After this fix**\r\n<img width=\"521\" alt=\"after_fix_fullscreen\" src=\"https://cloud.githubusercontent.com/assets/1349170/17311574/5730087a-581a-11e6-8ae8-17aebb2bf428.png\">\r\n\r\n\r\n## Specific Changes proposed\r\nThe changes made in this fix makes sure that we have the correct control text when you exit fullscreen mode.\r\n\r\n## Requirements Checklist\r\n- [ ] Feature implemented / Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [ ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](http://jsbin.com/axedog/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n\r\n","created_at":"2016-08-01T23:09:57Z","updated_at":"2016-08-02T20:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7427b1f47de562d23bcbe5f101b981308ce3bb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3485/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3485/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3485/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/000e80466ec21a55d83be20091513891ab148057","head":{"label":"vdeshpande:fullScreenESCfix","ref":"fullScreenESCfix","sha":"000e80466ec21a55d83be20091513891ab148057","user":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"repo":{"id":45487782,"name":"video.js","full_name":"vdeshpande/video.js","owner":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdeshpande/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/vdeshpande/video.js","forks_url":"https://api.github.com/repos/vdeshpande/video.js/forks","keys_url":"https://api.github.com/repos/vdeshpande/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdeshpande/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdeshpande/video.js/teams","hooks_url":"https://api.github.com/repos/vdeshpande/video.js/hooks","issue_events_url":"https://api.github.com/repos/vdeshpande/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/vdeshpande/video.js/events","assignees_url":"https://api.github.com/repos/vdeshpande/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/vdeshpande/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/vdeshpande/video.js/tags","blobs_url":"https://api.github.com/repos/vdeshpande/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdeshpande/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdeshpande/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdeshpande/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdeshpande/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/vdeshpande/video.js/languages","stargazers_url":"https://api.github.com/repos/vdeshpande/video.js/stargazers","contributors_url":"https://api.github.com/repos/vdeshpande/video.js/contributors","subscribers_url":"https://api.github.com/repos/vdeshpande/video.js/subscribers","subscription_url":"https://api.github.com/repos/vdeshpande/video.js/subscription","commits_url":"https://api.github.com/repos/vdeshpande/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdeshpande/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdeshpande/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdeshpande/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdeshpande/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/vdeshpande/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdeshpande/video.js/merges","archive_url":"https://api.github.com/repos/vdeshpande/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdeshpande/video.js/downloads","issues_url":"https://api.github.com/repos/vdeshpande/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/vdeshpande/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/vdeshpande/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/vdeshpande/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdeshpande/video.js/labels{/name}","releases_url":"https://api.github.com/repos/vdeshpande/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/vdeshpande/video.js/deployments","created_at":"2015-11-03T18:42:34Z","updated_at":"2016-07-29T16:25:51Z","pushed_at":"2016-08-02T20:17:36Z","git_url":"git://github.com/vdeshpande/video.js.git","ssh_url":"git@github.com:vdeshpande/video.js.git","clone_url":"https://github.com/vdeshpande/video.js.git","svn_url":"https://github.com/vdeshpande/video.js","homepage":"www.videojs.com","size":72912,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"fc72fb90e7661594c0ea090e0e1e9838f8ec9486","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-08-02T19:09:22Z","pushed_at":"2016-08-02T20:17:39Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":110002,"stargazers_count":13141,"watchers_count":13141,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3815,"mirror_url":null,"open_issues_count":195,"forks":3815,"open_issues":195,"watchers":13141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3485"},"html":{"href":"https://github.com/videojs/video.js/pull/3485"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3485"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3485/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3485/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3485/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/000e80466ec21a55d83be20091513891ab148057"}}}}
{"actor":{"display_login":"gkatsev"}}