{"action":"created","comment":{"url":"https://api.github.com/repos/php-http/cache-plugin/pulls/comments/74728104","id":74728104,"diff_hunk":"@@ -138,6 +137,40 @@ public function handleRequest(RequestInterface $request, callable $next, callabl\n     }\n \n     /**\n+     * Calculate the timestamp when this cache item should be dropped from the cache. The lowest value return after\n+     * the calculation is $maxAge.","path":"src/CachePlugin.php","position":45,"original_position":45,"commit_id":"7dfeaa18a6144267a490ac81aca99d382aae6d89","original_commit_id":"7dfeaa18a6144267a490ac81aca99d382aae6d89","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"body":"FYI, I did not follow your suggestion here. ","created_at":"2016-08-15T07:34:37Z","updated_at":"2016-08-15T07:34:37Z","html_url":"https://github.com/php-http/cache-plugin/pull/20#discussion_r74728104","pull_request_url":"https://api.github.com/repos/php-http/cache-plugin/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/comments/74728104"},"html":{"href":"https://github.com/php-http/cache-plugin/pull/20#discussion_r74728104"},"pull_request":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/php-http/cache-plugin/pulls/20","id":81212113,"html_url":"https://github.com/php-http/cache-plugin/pull/20","diff_url":"https://github.com/php-http/cache-plugin/pull/20.diff","patch_url":"https://github.com/php-http/cache-plugin/pull/20.patch","issue_url":"https://api.github.com/repos/php-http/cache-plugin/issues/20","number":20,"state":"open","locked":false,"title":"Allow a cache item to be stored forever","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | no\r\n| Deprecations?   | no\r\n| Related tickets | fixes #19\r\n| Documentation   | https://github.com/php-http/documentation/pull/144\r\n| License         | MIT\r\n\r\n#### What's in this PR?\r\n\r\nIf you configure your `default_ttl` to be null you should store (and be valid) the response as long as the cache item is stored. \r\n\r\nAlso, if you configure `cache_lifetime` to be null you should store the cache item forever. \r\n\r\n\r\n#### Why?\r\n\r\nAt the moment we calculate the `expiresAt` as `$maxAge + time()` which is just `time()` when $maxAge is null. This is why we got issues like #19.\r\n\r\n","created_at":"2016-08-13T09:50:58Z","updated_at":"2016-08-15T07:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f09a8878b2f7146e054ab5e5b4eda51911ecbb22","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-http/cache-plugin/pulls/20/commits","review_comments_url":"https://api.github.com/repos/php-http/cache-plugin/pulls/20/comments","review_comment_url":"https://api.github.com/repos/php-http/cache-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-http/cache-plugin/issues/20/comments","statuses_url":"https://api.github.com/repos/php-http/cache-plugin/statuses/7dfeaa18a6144267a490ac81aca99d382aae6d89","head":{"label":"php-http:cache-forever","ref":"cache-forever","sha":"7dfeaa18a6144267a490ac81aca99d382aae6d89","user":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":57924909,"name":"cache-plugin","full_name":"php-http/cache-plugin","owner":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-http/cache-plugin","description":"PSR-6 Cache plugin for HTTPlug","fork":false,"url":"https://api.github.com/repos/php-http/cache-plugin","forks_url":"https://api.github.com/repos/php-http/cache-plugin/forks","keys_url":"https://api.github.com/repos/php-http/cache-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/cache-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/cache-plugin/teams","hooks_url":"https://api.github.com/repos/php-http/cache-plugin/hooks","issue_events_url":"https://api.github.com/repos/php-http/cache-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/cache-plugin/events","assignees_url":"https://api.github.com/repos/php-http/cache-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/cache-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/cache-plugin/tags","blobs_url":"https://api.github.com/repos/php-http/cache-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/cache-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/cache-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/cache-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/cache-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/cache-plugin/languages","stargazers_url":"https://api.github.com/repos/php-http/cache-plugin/stargazers","contributors_url":"https://api.github.com/repos/php-http/cache-plugin/contributors","subscribers_url":"https://api.github.com/repos/php-http/cache-plugin/subscribers","subscription_url":"https://api.github.com/repos/php-http/cache-plugin/subscription","commits_url":"https://api.github.com/repos/php-http/cache-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/cache-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/cache-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/cache-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/cache-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/cache-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/cache-plugin/merges","archive_url":"https://api.github.com/repos/php-http/cache-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/cache-plugin/downloads","issues_url":"https://api.github.com/repos/php-http/cache-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/cache-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/cache-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/cache-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/cache-plugin/labels{/name}","releases_url":"https://api.github.com/repos/php-http/cache-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/php-http/cache-plugin/deployments","created_at":"2016-05-02T22:19:09Z","updated_at":"2016-08-02T08:56:12Z","pushed_at":"2016-08-15T07:33:50Z","git_url":"git://github.com/php-http/cache-plugin.git","ssh_url":"git@github.com:php-http/cache-plugin.git","clone_url":"https://github.com/php-http/cache-plugin.git","svn_url":"https://github.com/php-http/cache-plugin","homepage":"http://docs.php-http.org/en/latest/plugins/cache.html","size":45,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"php-http:master","ref":"master","sha":"a9dbc04a880137b5e850e3bc0618190c0044278a","user":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":57924909,"name":"cache-plugin","full_name":"php-http/cache-plugin","owner":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-http/cache-plugin","description":"PSR-6 Cache plugin for HTTPlug","fork":false,"url":"https://api.github.com/repos/php-http/cache-plugin","forks_url":"https://api.github.com/repos/php-http/cache-plugin/forks","keys_url":"https://api.github.com/repos/php-http/cache-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/cache-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/cache-plugin/teams","hooks_url":"https://api.github.com/repos/php-http/cache-plugin/hooks","issue_events_url":"https://api.github.com/repos/php-http/cache-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/cache-plugin/events","assignees_url":"https://api.github.com/repos/php-http/cache-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/cache-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/cache-plugin/tags","blobs_url":"https://api.github.com/repos/php-http/cache-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/cache-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/cache-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/cache-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/cache-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/cache-plugin/languages","stargazers_url":"https://api.github.com/repos/php-http/cache-plugin/stargazers","contributors_url":"https://api.github.com/repos/php-http/cache-plugin/contributors","subscribers_url":"https://api.github.com/repos/php-http/cache-plugin/subscribers","subscription_url":"https://api.github.com/repos/php-http/cache-plugin/subscription","commits_url":"https://api.github.com/repos/php-http/cache-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/cache-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/cache-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/cache-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/cache-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/cache-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/cache-plugin/merges","archive_url":"https://api.github.com/repos/php-http/cache-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/cache-plugin/downloads","issues_url":"https://api.github.com/repos/php-http/cache-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/cache-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/cache-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/cache-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/cache-plugin/labels{/name}","releases_url":"https://api.github.com/repos/php-http/cache-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/php-http/cache-plugin/deployments","created_at":"2016-05-02T22:19:09Z","updated_at":"2016-08-02T08:56:12Z","pushed_at":"2016-08-15T07:33:50Z","git_url":"git://github.com/php-http/cache-plugin.git","ssh_url":"git@github.com:php-http/cache-plugin.git","clone_url":"https://github.com/php-http/cache-plugin.git","svn_url":"https://github.com/php-http/cache-plugin","homepage":"http://docs.php-http.org/en/latest/plugins/cache.html","size":45,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/20"},"html":{"href":"https://github.com/php-http/cache-plugin/pull/20"},"issue":{"href":"https://api.github.com/repos/php-http/cache-plugin/issues/20"},"comments":{"href":"https://api.github.com/repos/php-http/cache-plugin/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-http/cache-plugin/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/php-http/cache-plugin/statuses/7dfeaa18a6144267a490ac81aca99d382aae6d89"}}}}
{"actor":{"display_login":"Nyholm"}}