{"action":"created","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1435","repository_url":"https://api.github.com/repos/PCSX2/pcsx2","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1435/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1435/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1435/events","html_url":"https://github.com/PCSX2/pcsx2/pull/1435","id":162483783,"number":1435,"title":"GSDX: Improve scaling of custom resolution","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/GSdx:%20Hardware","name":"GSdx: Hardware","color":"006b75"},{"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/GSdx:%20Texture%20Cache","name":"GSdx: Texture Cache","color":"fc2929"},{"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Plugin:%20GSdx","name":"Plugin: GSdx","color":"fbca04"},{"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Waiting%20feedback","name":"Waiting feedback","color":"bfdadc"}],"state":"open","locked":false,"assignee":{"login":"gregory38","id":1569559,"avatar_url":"https://avatars.githubusercontent.com/u/1569559?v=3","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregory38","id":1569559,"avatar_url":"https://avatars.githubusercontent.com/u/1569559?v=3","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2016-06-27T15:43:46Z","updated_at":"2016-06-28T12:23:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1435","html_url":"https://github.com/PCSX2/pcsx2/pull/1435","diff_url":"https://github.com/PCSX2/pcsx2/pull/1435.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1435.patch"},"body":"**Summary of changes**:\r\n\r\n* Remove scaling hack which limited scaling size based on the scissor value.\r\n* Ignore Frame memory offsets for calculating dimensions value of display rectangle.\r\n* Improve frame buffer height management on custom resolution.\r\n\r\n**ICO 60Hz mode** ( ``master branch`` )\r\n\r\n![ICObefore.png](http://ultraimg.com/images/2016/06/27/ICObefore.png)\r\n\r\n**ICO 60Hz mode** ( ``Pull request branch with large frame buffer enabled`` )\r\n\r\n![ICOafter.png](http://ultraimg.com/images/2016/06/27/ICOafter.png)\r\n\r\n**Silent Hill 2** (``master branch``)\r\n\r\n![sh2_before.png](http://ultraimg.com/images/2016/06/27/sh2_before.png)\r\n\r\n**Note**:\r\n```\r\n Outputs a scaled image of size 1024x672 when 1024x768 is set on custom resolution.\r\n```\r\n\r\n**Silent Hill 2** (``Pull request branch``)\r\n\r\n![SH2_after.png](http://ultraimg.com/images/2016/06/27/SH2_after.png)\r\n\r\n**Note**:\r\n```\r\n Properly outputs a scaled image of size 1024x768 when custom resolution is set to 1024x768.\r\n```\r\n\r\nFixes the Silent Hill 2 bug [reported on the forum](http://forums.pcsx2.net/Thread-GSDX-Texture-Cache-Bug-Report-Silent-Hill-2-GSdx-Screenshots-have-wrong-height)."},"comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments/229033319","html_url":"https://github.com/PCSX2/pcsx2/pull/1435#issuecomment-229033319","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1435","id":229033319,"user":{"login":"refractionpcsx2","id":6278726,"avatar_url":"https://avatars.githubusercontent.com/u/6278726?v=3","gravatar_id":"","url":"https://api.github.com/users/refractionpcsx2","html_url":"https://github.com/refractionpcsx2","followers_url":"https://api.github.com/users/refractionpcsx2/followers","following_url":"https://api.github.com/users/refractionpcsx2/following{/other_user}","gists_url":"https://api.github.com/users/refractionpcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/refractionpcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refractionpcsx2/subscriptions","organizations_url":"https://api.github.com/users/refractionpcsx2/orgs","repos_url":"https://api.github.com/users/refractionpcsx2/repos","events_url":"https://api.github.com/users/refractionpcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/refractionpcsx2/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T12:23:37Z","updated_at":"2016-06-28T12:23:37Z","body":"> Why do you think the game needs twice the size of height to properly output half of it ?\r\n\r\nI can't remember the technicalities, something to do with the internal size vs the real size, you'll have to ask @gregory38 \r\n\r\n> What do you mean by Screenshot issue\r\n\r\nScreenshots were coming out at the wrong size in the scaling modes, but I believe that has been fixed. People were using custom res to get correctly sized screenshots."}}
{"actor":{"display_login":"refractionpcsx2"}}