{"action":"opened","number":52,"pull_request":{"url":"https://api.github.com/repos/lyft/mapper/pulls/52","id":69256424,"html_url":"https://github.com/lyft/mapper/pull/52","diff_url":"https://github.com/lyft/mapper/pull/52.diff","patch_url":"https://github.com/lyft/mapper/pull/52.patch","issue_url":"https://api.github.com/repos/lyft/mapper/issues/52","number":52,"state":"open","locked":false,"title":"Make transformations throw MissingFieldErrors","user":{"login":"keith","id":283886,"avatar_url":"https://avatars.githubusercontent.com/u/283886?v=3","gravatar_id":"","url":"https://api.github.com/users/keith","html_url":"https://github.com/keith","followers_url":"https://api.github.com/users/keith/followers","following_url":"https://api.github.com/users/keith/following{/other_user}","gists_url":"https://api.github.com/users/keith/gists{/gist_id}","starred_url":"https://api.github.com/users/keith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith/subscriptions","organizations_url":"https://api.github.com/users/keith/orgs","repos_url":"https://api.github.com/users/keith/repos","events_url":"https://api.github.com/users/keith/events{/privacy}","received_events_url":"https://api.github.com/users/keith/received_events","type":"User","site_admin":false},"body":"When implementing custom errors I decided to make the transformation\r\nfunction swallow `MissingFieldError`s since we were using `rethrows` and\r\nit would have been a breaking API change. Now we're going to bump for a\r\nbreaking API change, and this is more true to what is actually going\r\nwrong in order for the function to throw.\r\n\r\nSee previous conversation Previously to not make a breaking API \r\n","created_at":"2016-05-07T23:56:36Z","updated_at":"2016-05-07T23:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lyft/mapper/pulls/52/commits","review_comments_url":"https://api.github.com/repos/lyft/mapper/pulls/52/comments","review_comment_url":"https://api.github.com/repos/lyft/mapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/mapper/issues/52/comments","statuses_url":"https://api.github.com/repos/lyft/mapper/statuses/12d7d2edd644d2736c8bfd798be6684bcdfc6d90","head":{"label":"lyft:ks/transformation-throws","ref":"ks/transformation-throws","sha":"12d7d2edd644d2736c8bfd798be6684bcdfc6d90","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":44777644,"name":"mapper","full_name":"lyft/mapper","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/mapper","description":"A JSON deserialization library for Swift","fork":false,"url":"https://api.github.com/repos/lyft/mapper","forks_url":"https://api.github.com/repos/lyft/mapper/forks","keys_url":"https://api.github.com/repos/lyft/mapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/mapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/mapper/teams","hooks_url":"https://api.github.com/repos/lyft/mapper/hooks","issue_events_url":"https://api.github.com/repos/lyft/mapper/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/mapper/events","assignees_url":"https://api.github.com/repos/lyft/mapper/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/mapper/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/mapper/tags","blobs_url":"https://api.github.com/repos/lyft/mapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/mapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/mapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/mapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/mapper/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/mapper/languages","stargazers_url":"https://api.github.com/repos/lyft/mapper/stargazers","contributors_url":"https://api.github.com/repos/lyft/mapper/contributors","subscribers_url":"https://api.github.com/repos/lyft/mapper/subscribers","subscription_url":"https://api.github.com/repos/lyft/mapper/subscription","commits_url":"https://api.github.com/repos/lyft/mapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/mapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/mapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/mapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/mapper/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/mapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/mapper/merges","archive_url":"https://api.github.com/repos/lyft/mapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/mapper/downloads","issues_url":"https://api.github.com/repos/lyft/mapper/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/mapper/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/mapper/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/mapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/mapper/labels{/name}","releases_url":"https://api.github.com/repos/lyft/mapper/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/mapper/deployments","created_at":"2015-10-22T22:46:01Z","updated_at":"2016-05-06T08:05:51Z","pushed_at":"2016-05-07T23:56:28Z","git_url":"git://github.com/lyft/mapper.git","ssh_url":"git@github.com:lyft/mapper.git","clone_url":"https://github.com/lyft/mapper.git","svn_url":"https://github.com/lyft/mapper","homepage":"","size":125,"stargazers_count":596,"watchers_count":596,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":596,"default_branch":"master"}},"base":{"label":"lyft:master","ref":"master","sha":"adc0da38a4341f200c24fb1d5b41113afbe8ca99","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":44777644,"name":"mapper","full_name":"lyft/mapper","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/mapper","description":"A JSON deserialization library for Swift","fork":false,"url":"https://api.github.com/repos/lyft/mapper","forks_url":"https://api.github.com/repos/lyft/mapper/forks","keys_url":"https://api.github.com/repos/lyft/mapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/mapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/mapper/teams","hooks_url":"https://api.github.com/repos/lyft/mapper/hooks","issue_events_url":"https://api.github.com/repos/lyft/mapper/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/mapper/events","assignees_url":"https://api.github.com/repos/lyft/mapper/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/mapper/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/mapper/tags","blobs_url":"https://api.github.com/repos/lyft/mapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/mapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/mapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/mapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/mapper/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/mapper/languages","stargazers_url":"https://api.github.com/repos/lyft/mapper/stargazers","contributors_url":"https://api.github.com/repos/lyft/mapper/contributors","subscribers_url":"https://api.github.com/repos/lyft/mapper/subscribers","subscription_url":"https://api.github.com/repos/lyft/mapper/subscription","commits_url":"https://api.github.com/repos/lyft/mapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/mapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/mapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/mapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/mapper/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/mapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/mapper/merges","archive_url":"https://api.github.com/repos/lyft/mapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/mapper/downloads","issues_url":"https://api.github.com/repos/lyft/mapper/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/mapper/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/mapper/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/mapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/mapper/labels{/name}","releases_url":"https://api.github.com/repos/lyft/mapper/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/mapper/deployments","created_at":"2015-10-22T22:46:01Z","updated_at":"2016-05-06T08:05:51Z","pushed_at":"2016-05-07T23:56:28Z","git_url":"git://github.com/lyft/mapper.git","ssh_url":"git@github.com:lyft/mapper.git","clone_url":"https://github.com/lyft/mapper.git","svn_url":"https://github.com/lyft/mapper","homepage":"","size":125,"stargazers_count":596,"watchers_count":596,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/mapper/pulls/52"},"html":{"href":"https://github.com/lyft/mapper/pull/52"},"issue":{"href":"https://api.github.com/repos/lyft/mapper/issues/52"},"comments":{"href":"https://api.github.com/repos/lyft/mapper/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/mapper/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/mapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/mapper/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/mapper/statuses/12d7d2edd644d2736c8bfd798be6684bcdfc6d90"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":6,"changed_files":4}}