{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glTF/issues/697","repository_url":"https://api.github.com/repos/KhronosGroup/glTF","labels_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/697/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/697/comments","events_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/697/events","html_url":"https://github.com/KhronosGroup/glTF/issues/697","id":173441574,"number":697,"title":"[PBR extension] Provide example implementation and specify (suggested) shading model","user":{"login":"mlimper","id":1853237,"avatar_url":"https://avatars.githubusercontent.com/u/1853237?v=3","gravatar_id":"","url":"https://api.github.com/users/mlimper","html_url":"https://github.com/mlimper","followers_url":"https://api.github.com/users/mlimper/followers","following_url":"https://api.github.com/users/mlimper/following{/other_user}","gists_url":"https://api.github.com/users/mlimper/gists{/gist_id}","starred_url":"https://api.github.com/users/mlimper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlimper/subscriptions","organizations_url":"https://api.github.com/users/mlimper/orgs","repos_url":"https://api.github.com/users/mlimper/repos","events_url":"https://api.github.com/users/mlimper/events{/privacy}","received_events_url":"https://api.github.com/users/mlimper/received_events","type":"User","site_admin":false},"labels":[{"id":431586985,"url":"https://api.github.com/repos/KhronosGroup/glTF/labels/PBR","name":"PBR","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-26T12:26:13Z","updated_at":"2016-10-30T22:09:42Z","closed_at":null,"body":"We need and simple, yet expressive reference application, and especially example shader code for reference.\nAlso, the shading model we use must be very concretely defined in either the spec or in the appendix, being a suggested shading model.\n\nThis also involves to create corresponding, extensive documentation in the spec, especially about the concrete shading model and exact behaviour / semantics of parameters.\n"},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glTF/issues/comments/257183249","html_url":"https://github.com/KhronosGroup/glTF/issues/697#issuecomment-257183249","issue_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/697","id":257183249,"user":{"login":"mlimper","id":1853237,"avatar_url":"https://avatars.githubusercontent.com/u/1853237?v=3","gravatar_id":"","url":"https://api.github.com/users/mlimper","html_url":"https://github.com/mlimper","followers_url":"https://api.github.com/users/mlimper/followers","following_url":"https://api.github.com/users/mlimper/following{/other_user}","gists_url":"https://api.github.com/users/mlimper/gists{/gist_id}","starred_url":"https://api.github.com/users/mlimper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlimper/subscriptions","organizations_url":"https://api.github.com/users/mlimper/orgs","repos_url":"https://api.github.com/users/mlimper/repos","events_url":"https://api.github.com/users/mlimper/events{/privacy}","received_events_url":"https://api.github.com/users/mlimper/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T22:09:42Z","updated_at":"2016-10-30T22:09:42Z","body":"@cedricpinson What do you think about the used approximations?\r\n\r\n> frostbite Moving Frostbite to PBR (Sébastien Lagarde & Charles de Rousiers) http://blog.selfshadow.com/publications/s2014-shading-course/\r\n\r\nI just checked that talk and I get the impression that Schlick for Fresnel and GGF for Normal Distribution are already pretty standard - they mention a specific variant of the Smith Geometry term, however (\"Height-correlated Smith\"). What is you experience / your opinion about these terms, do you have a specific configuration which you believe would work well?\r\n"}}
{"actor":{"display_login":"mlimper"}}