{"action":"created","issue":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1459","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1459/labels{/name}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1459/comments","events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1459/events","html_url":"https://github.com/phoenixframework/phoenix/pull/1459","id":125640417,"number":1459,"title":"pipe_through now only accepts lists","user":{"login":"kyledecot","id":192464,"avatar_url":"https://avatars.githubusercontent.com/u/192464?v=3","gravatar_id":"","url":"https://api.github.com/users/kyledecot","html_url":"https://github.com/kyledecot","followers_url":"https://api.github.com/users/kyledecot/followers","following_url":"https://api.github.com/users/kyledecot/following{/other_user}","gists_url":"https://api.github.com/users/kyledecot/gists{/gist_id}","starred_url":"https://api.github.com/users/kyledecot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyledecot/subscriptions","organizations_url":"https://api.github.com/users/kyledecot/orgs","repos_url":"https://api.github.com/users/kyledecot/repos","events_url":"https://api.github.com/users/kyledecot/events{/privacy}","received_events_url":"https://api.github.com/users/kyledecot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-08T16:10:12Z","updated_at":"2016-01-08T16:19:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1459","html_url":"https://github.com/phoenixframework/phoenix/pull/1459","diff_url":"https://github.com/phoenixframework/phoenix/pull/1459.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/1459.patch"},"body":"This PR changes `pipe_through/2` to only allow lists. This change was prompted by a comment that @josevalim made on my [attempted ecto PR](https://github.com/elixir-lang/ecto/pull/1191) which essentially said that should avoid the rails trait of allowing a function to take all sorts of different types of arguments.\r\n\r\nThis change would break a lot of people's applications so this PR is simply meant to start a conversation on if/how we should be about making such a change.\r\n\r\n*note: I actually didn't know that pipe_through could take a list until I saw it used in the Programming Phoenix book. I think this change might also make it more apparent to newcomers as well*  \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments/170045217","html_url":"https://github.com/phoenixframework/phoenix/pull/1459#issuecomment-170045217","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1459","id":170045217,"user":{"login":"chrismccord","id":576796,"avatar_url":"https://avatars.githubusercontent.com/u/576796?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismccord","html_url":"https://github.com/chrismccord","followers_url":"https://api.github.com/users/chrismccord/followers","following_url":"https://api.github.com/users/chrismccord/following{/other_user}","gists_url":"https://api.github.com/users/chrismccord/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismccord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismccord/subscriptions","organizations_url":"https://api.github.com/users/chrismccord/orgs","repos_url":"https://api.github.com/users/chrismccord/repos","events_url":"https://api.github.com/users/chrismccord/events{/privacy}","received_events_url":"https://api.github.com/users/chrismccord/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T16:19:19Z","updated_at":"2016-01-08T16:19:19Z","body":"I agree with the sentiment, but we'd have to deprecate first, then wait until a major release, so I'm not sure if it's worth it"}}