{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/83532258","pull_request_review_id":4372392,"id":83532258,"diff_hunk":"@@ -44,6 +44,26 @@ class GenerateXcodeprojTests: XCTestCase {\n #endif\n     }\n \n+    func testDidNotIncludeExcludedDirectory() {\n+        #if os(macOS)\n+            mktmpdir { dstdir in\n+                try makeDirectories(dstdir.appending(component: \"excludeMe\"))\n+\n+                func dummy() throws -> [Module] {\n+                    return [try SwiftModule(name: \"DummyModuleName\", sources: Sources(paths: [], root: dstdir))]\n+                }\n+\n+                let projectName = \"DummyProjectName\"\n+                let dummyPackage = Package(manifest: Manifest(path: dstdir, url: dstdir.asString, package: PackageDescription.Package(name: \"Foo\", exclude: [\"excludeMe\"]), products: [], version: nil), path: dstdir, modules: [], testModules: [], products: [])\n+                let graph = PackageGraph(rootPackage: dummyPackage, modules: try dummy(), externalModules: [])\n+                let outpath = try Xcodeproj.generate(outputDir: dstdir, projectName: projectName, graph: graph, options: XcodeprojOptions())\n+\n+                let pbxproj = try String(contentsOfFile: outpath.appending(component: \"project.pbxproj\").asString)\n+                XCTAssert(!pbxproj.contains(\"excludeMe\"))","path":"Tests/XcodeprojTests/GenerateXcodeprojTests.swift","position":19,"original_position":19,"commit_id":"87dda476336c3da1422337828f0d5c8713fedc2b","original_commit_id":"87dda476336c3da1422337828f0d5c8713fedc2b","user":{"login":"aciidb0mb3r","id":4136295,"avatar_url":"https://avatars.githubusercontent.com/u/4136295?v=3","gravatar_id":"","url":"https://api.github.com/users/aciidb0mb3r","html_url":"https://github.com/aciidb0mb3r","followers_url":"https://api.github.com/users/aciidb0mb3r/followers","following_url":"https://api.github.com/users/aciidb0mb3r/following{/other_user}","gists_url":"https://api.github.com/users/aciidb0mb3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aciidb0mb3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aciidb0mb3r/subscriptions","organizations_url":"https://api.github.com/users/aciidb0mb3r/orgs","repos_url":"https://api.github.com/users/aciidb0mb3r/repos","events_url":"https://api.github.com/users/aciidb0mb3r/events{/privacy}","received_events_url":"https://api.github.com/users/aciidb0mb3r/received_events","type":"User","site_admin":false},"body":"This should test the model `Xcode.Project` instead of reading `project.pbxproj`","created_at":"2016-10-15T13:36:09Z","updated_at":"2016-10-15T13:36:09Z","html_url":"https://github.com/apple/swift-package-manager/pull/737#discussion_r83532258","pull_request_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/737","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/83532258"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/737#discussion_r83532258"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/737"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/737","id":89493080,"html_url":"https://github.com/apple/swift-package-manager/pull/737","diff_url":"https://github.com/apple/swift-package-manager/pull/737.diff","patch_url":"https://github.com/apple/swift-package-manager/pull/737.patch","issue_url":"https://api.github.com/repos/apple/swift-package-manager/issues/737","number":737,"state":"open","locked":false,"title":"[Xcodeproj] Don't add excluded directories as blue folders","user":{"login":"emlai","id":7543552,"avatar_url":"https://avatars.githubusercontent.com/u/7543552?v=3","gravatar_id":"","url":"https://api.github.com/users/emlai","html_url":"https://github.com/emlai","followers_url":"https://api.github.com/users/emlai/followers","following_url":"https://api.github.com/users/emlai/following{/other_user}","gists_url":"https://api.github.com/users/emlai/gists{/gist_id}","starred_url":"https://api.github.com/users/emlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlai/subscriptions","organizations_url":"https://api.github.com/users/emlai/orgs","repos_url":"https://api.github.com/users/emlai/repos","events_url":"https://api.github.com/users/emlai/events{/privacy}","received_events_url":"https://api.github.com/users/emlai/received_events","type":"User","site_admin":false},"body":"Xcode project generation now considers the [`exclude`](https://github.com/apple/swift-package-manager/blob/master/Documentation/Reference.md#exclude) list when deciding which extra directories to add as folder references.\r\n","created_at":"2016-10-15T13:19:16Z","updated_at":"2016-10-15T13:36:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"411d1fbfcfb0f015c39701e350c1c788f1a4da8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/737/commits","review_comments_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/737/comments","review_comment_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/issues/737/comments","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/87dda476336c3da1422337828f0d5c8713fedc2b","head":{"label":"emlai:xcodeproj-exclude","ref":"xcodeproj-exclude","sha":"87dda476336c3da1422337828f0d5c8713fedc2b","user":{"login":"emlai","id":7543552,"avatar_url":"https://avatars.githubusercontent.com/u/7543552?v=3","gravatar_id":"","url":"https://api.github.com/users/emlai","html_url":"https://github.com/emlai","followers_url":"https://api.github.com/users/emlai/followers","following_url":"https://api.github.com/users/emlai/following{/other_user}","gists_url":"https://api.github.com/users/emlai/gists{/gist_id}","starred_url":"https://api.github.com/users/emlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlai/subscriptions","organizations_url":"https://api.github.com/users/emlai/orgs","repos_url":"https://api.github.com/users/emlai/repos","events_url":"https://api.github.com/users/emlai/events{/privacy}","received_events_url":"https://api.github.com/users/emlai/received_events","type":"User","site_admin":false},"repo":{"id":69689165,"name":"swift-package-manager","full_name":"emlai/swift-package-manager","owner":{"login":"emlai","id":7543552,"avatar_url":"https://avatars.githubusercontent.com/u/7543552?v=3","gravatar_id":"","url":"https://api.github.com/users/emlai","html_url":"https://github.com/emlai","followers_url":"https://api.github.com/users/emlai/followers","following_url":"https://api.github.com/users/emlai/following{/other_user}","gists_url":"https://api.github.com/users/emlai/gists{/gist_id}","starred_url":"https://api.github.com/users/emlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlai/subscriptions","organizations_url":"https://api.github.com/users/emlai/orgs","repos_url":"https://api.github.com/users/emlai/repos","events_url":"https://api.github.com/users/emlai/events{/privacy}","received_events_url":"https://api.github.com/users/emlai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emlai/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":true,"url":"https://api.github.com/repos/emlai/swift-package-manager","forks_url":"https://api.github.com/repos/emlai/swift-package-manager/forks","keys_url":"https://api.github.com/repos/emlai/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emlai/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emlai/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/emlai/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/emlai/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/emlai/swift-package-manager/events","assignees_url":"https://api.github.com/repos/emlai/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/emlai/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/emlai/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/emlai/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emlai/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emlai/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/emlai/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emlai/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/emlai/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/emlai/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/emlai/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/emlai/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/emlai/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/emlai/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/emlai/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/emlai/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/emlai/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/emlai/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/emlai/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emlai/swift-package-manager/merges","archive_url":"https://api.github.com/repos/emlai/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emlai/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/emlai/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/emlai/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/emlai/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/emlai/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emlai/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/emlai/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/emlai/swift-package-manager/deployments","created_at":"2016-09-30T17:54:46Z","updated_at":"2016-09-30T17:54:47Z","pushed_at":"2016-10-15T13:13:47Z","git_url":"git://github.com/emlai/swift-package-manager.git","ssh_url":"git@github.com:emlai/swift-package-manager.git","clone_url":"https://github.com/emlai/swift-package-manager.git","svn_url":"https://github.com/emlai/swift-package-manager","homepage":"","size":3500,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"10e741658b64a800032ac90344096e6a0e597b95","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44840041,"name":"swift-package-manager","full_name":"apple/swift-package-manager","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift-package-manager","forks_url":"https://api.github.com/repos/apple/swift-package-manager/forks","keys_url":"https://api.github.com/repos/apple/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/apple/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-package-manager/events","assignees_url":"https://api.github.com/repos/apple/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/apple/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/apple/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/apple/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-package-manager/merges","archive_url":"https://api.github.com/repos/apple/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/apple/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-package-manager/deployments","created_at":"2015-10-23T21:41:12Z","updated_at":"2016-10-15T06:54:41Z","pushed_at":"2016-10-15T13:19:16Z","git_url":"git://github.com/apple/swift-package-manager.git","ssh_url":"git@github.com:apple/swift-package-manager.git","clone_url":"https://github.com/apple/swift-package-manager.git","svn_url":"https://github.com/apple/swift-package-manager","homepage":"","size":4483,"stargazers_count":4793,"watchers_count":4793,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":8,"forks":452,"open_issues":8,"watchers":4793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/737"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/737"},"issue":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/737"},"comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-package-manager/statuses/87dda476336c3da1422337828f0d5c8713fedc2b"}}}}
{"actor":{"display_login":"aciidb0mb3r"}}