{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1762","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1762/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1762/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1762/events","html_url":"https://github.com/apache/zeppelin/pull/1762","id":195555740,"number":1762,"title":"[ZEPPELIN-1810] Removed incorrect usage of getString","user":{"login":"FireArrow","id":1497322,"avatar_url":"https://avatars.githubusercontent.com/u/1497322?v=3","gravatar_id":"","url":"https://api.github.com/users/FireArrow","html_url":"https://github.com/FireArrow","followers_url":"https://api.github.com/users/FireArrow/followers","following_url":"https://api.github.com/users/FireArrow/following{/other_user}","gists_url":"https://api.github.com/users/FireArrow/gists{/gist_id}","starred_url":"https://api.github.com/users/FireArrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FireArrow/subscriptions","organizations_url":"https://api.github.com/users/FireArrow/orgs","repos_url":"https://api.github.com/users/FireArrow/repos","events_url":"https://api.github.com/users/FireArrow/events{/privacy}","received_events_url":"https://api.github.com/users/FireArrow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-14T15:08:36Z","updated_at":"2016-12-15T10:02:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1762","html_url":"https://github.com/apache/zeppelin/pull/1762","diff_url":"https://github.com/apache/zeppelin/pull/1762.diff","patch_url":"https://github.com/apache/zeppelin/pull/1762.patch"},"body":"### What is this PR for?\r\nThe changes in the fix for https://issues.apache.org/jira/browse/ZEPPELIN-1319 introduced a bug which makes setting path to keystore and truststore impossible from zeppelin-site.xml.\r\nThe reason seems to be an incorrect use of getString() here\r\nhttps://github.com/apache/zeppelin/pull/1319/files#diff-69b17249ac9d265091d730130d973f4aR282 \r\nand here\r\nhttps://github.com/apache/zeppelin/pull/1319/files#diff-69b17249ac9d265091d730130d973f4aR311\r\nThere should be no getString there, just \"path\" as it is.\r\n\r\n\r\n### What type of PR is it?\r\nHot Fix\r\n\r\n### Todos\r\n* [ ] - Task\r\n\r\n### What is the Jira issue?\r\nhttps://issues.apache.org/jira/browse/ZEPPELIN-1810\r\n\r\n### How should this be tested?\r\nBefore this fix:\r\nIn `zeppelin-site.xml`\r\n* setting `zeppelin.ssl` to `true`\r\n* setting `zeppelin.ssl.keystore.path` to a relative path to a keystore (technically it doens't have to exist at all)\r\n* setting `zeppelin.ssl.truststore.path` to a relative path to a truststore Zeppelin \r\n\r\nNow Zeppelin won't start. In the log you can read something like\r\n```WARN [2016-12-14 13:55:45,522] ({main} AbstractLifeCycle.java[setFailed]:212) - FAILED SslContextFactory@8f2098e(/home/firearrow/zeppelin/incubator-zeppelin/conf/null,/home/firearrow/zeppelin/incubator-zeppelin/conf/null): java.io.FileNotFoundException: /home/firearrow/zeppelin/incubator-zeppelin/conf/null (No such file or directory)```\r\n\r\nWith this fix the correct path is resolved\r\n\r\nEdit: Proof reading and formatting fixes\r\n### Screenshots (if appropriate)\r\nN/A\r\n\r\n### Questions:\r\n* Does the licenses files need update? No\r\n* Is there breaking changes for older versions? No\r\n* Does this needs documentation? No\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/267288362","html_url":"https://github.com/apache/zeppelin/pull/1762#issuecomment-267288362","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1762","id":267288362,"user":{"login":"FireArrow","id":1497322,"avatar_url":"https://avatars.githubusercontent.com/u/1497322?v=3","gravatar_id":"","url":"https://api.github.com/users/FireArrow","html_url":"https://github.com/FireArrow","followers_url":"https://api.github.com/users/FireArrow/followers","following_url":"https://api.github.com/users/FireArrow/following{/other_user}","gists_url":"https://api.github.com/users/FireArrow/gists{/gist_id}","starred_url":"https://api.github.com/users/FireArrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FireArrow/subscriptions","organizations_url":"https://api.github.com/users/FireArrow/orgs","repos_url":"https://api.github.com/users/FireArrow/repos","events_url":"https://api.github.com/users/FireArrow/events{/privacy}","received_events_url":"https://api.github.com/users/FireArrow/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T10:02:24Z","updated_at":"2016-12-15T10:02:24Z","body":"Failure seems unrelated... It fails with a null pointer here: https://github.com/FireArrow/zeppelin/blob/ZEPPELIN-1810%5D/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java#L309\r\nBut it only happened on one of the build jobs. Not sure what that's about."}}
{"actor":{"display_login":"FireArrow"}}