{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/1018","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/events","html_url":"https://github.com/opencontainers/runc/pull/1018","id":174945454,"number":1018,"title":"Consoles, consoles, consoles.","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"id":237521611,"url":"https://api.github.com/repos/opencontainers/runc/labels/status/0-triage","name":"status/0-triage","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opencontainers/runc/milestones/4","html_url":"https://github.com/opencontainers/runc/milestones/1.0.0","labels_url":"https://api.github.com/repos/opencontainers/runc/milestones/4/labels","id":1756705,"number":4,"title":"1.0.0","description":"Final milestone for the runc 1.0.0 Release","creator":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":19,"state":"open","created_at":"2016-05-09T23:22:52Z","updated_at":"2016-10-26T08:45:15Z","due_on":null,"closed_at":null},"comments":114,"created_at":"2016-09-04T12:01:10Z","updated_at":"2016-11-17T09:33:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1018","html_url":"https://github.com/opencontainers/runc/pull/1018","diff_url":"https://github.com/opencontainers/runc/pull/1018.diff","patch_url":"https://github.com/opencontainers/runc/pull/1018.patch"},"body":"This is the big console rewrite. For some design information, see [this](https://gist.github.com/cyphar/8c6b9db84fc1f2cc2d037ef07942ca83). TODO list:\n- [x] Implement the console masterfd passing.\n- [x] Rewrite parts of `tty.go` to work with the new setup.\n- [x] Remove `--console` and add `--console-socket`.\n  - [x] Need to figure out a sane protocol for sending things to `--console-socket`.\n  - [x] Write a small implementation of a `--console-socket` consumer as a sanity check [can be done in a separate PR].\n- [x] Figure out how to make the test suite behave.\n  - [x] `TestExecInTTY`.\n  - [x] bats `integration`.\n- [x] Need to figure out why runC is blocking on `recvfd()`.\n\nFixes #814, #910, docker/docker#11462, docker/docker#8755 and countless other issues.\n~~Depends on #975, #977.~~\ndocker/docker#9212 and similar issues are **not** fixed by this patchset, as we still need to consider how to handle `/dev/console` in certain cases.\n\nSigned-off-by: Aleksa Sarai asarai@suse.de\n"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/261198487","html_url":"https://github.com/opencontainers/runc/pull/1018#issuecomment-261198487","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1018","id":261198487,"user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T09:33:51Z","updated_at":"2016-11-17T09:33:51Z","body":"@cyphar Why would passing an fd number make testing with bats so hard? I think handle fd number in runc could make the code cleaner, but I'm also fine with current implementation."}}
{"actor":{"display_login":"hqhq"}}