{"action":"created","comment":{"url":"https://api.github.com/repos/flatpak/flatpak/pulls/comments/68504719","id":68504719,"diff_hunk":"@@ -21,6 +21,13 @@ set -euo pipefail\n \n . $(dirname $0)/libtest.sh\n \n+# This test looks for specific localized strings. Prefer a UTF-8 locale\n+if locale -a | grep '^C\\.UTF-8$' >/dev/null; then","path":"tests/test-basic.sh","position":5,"original_position":5,"commit_id":"844da7f8d0a5a4544cef8ce4cee7c4d5024171cb","original_commit_id":"844da7f8d0a5a4544cef8ce4cee7c4d5024171cb","user":{"login":"matthiasclasen","id":4834845,"avatar_url":"https://avatars.githubusercontent.com/u/4834845?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasclasen","html_url":"https://github.com/matthiasclasen","followers_url":"https://api.github.com/users/matthiasclasen/followers","following_url":"https://api.github.com/users/matthiasclasen/following{/other_user}","gists_url":"https://api.github.com/users/matthiasclasen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasclasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasclasen/subscriptions","organizations_url":"https://api.github.com/users/matthiasclasen/orgs","repos_url":"https://api.github.com/users/matthiasclasen/repos","events_url":"https://api.github.com/users/matthiasclasen/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasclasen/received_events","type":"User","site_admin":false},"body":"Do we really need this extra clutter ? Does Debian support systems without C.UTF-8 ? Even if Debian does, is there a good reason for supporting this in the flatpak test setup ?","created_at":"2016-06-26T15:28:27Z","updated_at":"2016-06-26T15:28:27Z","html_url":"https://github.com/flatpak/flatpak/pull/154#discussion_r68504719","pull_request_url":"https://api.github.com/repos/flatpak/flatpak/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/comments/68504719"},"html":{"href":"https://github.com/flatpak/flatpak/pull/154#discussion_r68504719"},"pull_request":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak/pulls/154","id":75211553,"html_url":"https://github.com/flatpak/flatpak/pull/154","diff_url":"https://github.com/flatpak/flatpak/pull/154.diff","patch_url":"https://github.com/flatpak/flatpak/pull/154.patch","issue_url":"https://api.github.com/repos/flatpak/flatpak/issues/154","number":154,"state":"open","locked":false,"title":"test-basic: do not fail in non-English locales","user":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"body":"One of the variations tested on Debian's reproducible build\r\ninfrastructure is that the second build is done in a French locale.\r\nThis test fails there, because it doesn't see \"Usage:\" in the help.","created_at":"2016-06-25T18:47:40Z","updated_at":"2016-06-26T15:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8881c154535b675cbf78a29597a32d24e8b935db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flatpak/flatpak/pulls/154/commits","review_comments_url":"https://api.github.com/repos/flatpak/flatpak/pulls/154/comments","review_comment_url":"https://api.github.com/repos/flatpak/flatpak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flatpak/flatpak/issues/154/comments","statuses_url":"https://api.github.com/repos/flatpak/flatpak/statuses/844da7f8d0a5a4544cef8ce4cee7c4d5024171cb","head":{"label":"smcv:test-locale","ref":"test-locale","sha":"844da7f8d0a5a4544cef8ce4cee7c4d5024171cb","user":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"repo":{"id":59521190,"name":"flatpak","full_name":"smcv/flatpak","owner":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smcv/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":true,"url":"https://api.github.com/repos/smcv/flatpak","forks_url":"https://api.github.com/repos/smcv/flatpak/forks","keys_url":"https://api.github.com/repos/smcv/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smcv/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smcv/flatpak/teams","hooks_url":"https://api.github.com/repos/smcv/flatpak/hooks","issue_events_url":"https://api.github.com/repos/smcv/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/smcv/flatpak/events","assignees_url":"https://api.github.com/repos/smcv/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/smcv/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/smcv/flatpak/tags","blobs_url":"https://api.github.com/repos/smcv/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smcv/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smcv/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/smcv/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smcv/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/smcv/flatpak/languages","stargazers_url":"https://api.github.com/repos/smcv/flatpak/stargazers","contributors_url":"https://api.github.com/repos/smcv/flatpak/contributors","subscribers_url":"https://api.github.com/repos/smcv/flatpak/subscribers","subscription_url":"https://api.github.com/repos/smcv/flatpak/subscription","commits_url":"https://api.github.com/repos/smcv/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/smcv/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/smcv/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/smcv/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/smcv/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/smcv/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smcv/flatpak/merges","archive_url":"https://api.github.com/repos/smcv/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smcv/flatpak/downloads","issues_url":"https://api.github.com/repos/smcv/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/smcv/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/smcv/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/smcv/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smcv/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/smcv/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/smcv/flatpak/deployments","created_at":"2016-05-23T21:58:51Z","updated_at":"2016-05-23T21:58:52Z","pushed_at":"2016-06-26T10:15:29Z","git_url":"git://github.com/smcv/flatpak.git","ssh_url":"git@github.com:smcv/flatpak.git","clone_url":"https://github.com/smcv/flatpak.git","svn_url":"https://github.com/smcv/flatpak","homepage":"http://flatpak.org","size":2153,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flatpak:master","ref":"master","sha":"5eede390787c6d4dd75b0845d5cc74c043f8ab1c","user":{"login":"flatpak","id":19473042,"avatar_url":"https://avatars.githubusercontent.com/u/19473042?v=3","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"repo":{"id":59213200,"name":"flatpak","full_name":"flatpak/flatpak","owner":{"login":"flatpak","id":19473042,"avatar_url":"https://avatars.githubusercontent.com/u/19473042?v=3","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flatpak/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":false,"url":"https://api.github.com/repos/flatpak/flatpak","forks_url":"https://api.github.com/repos/flatpak/flatpak/forks","keys_url":"https://api.github.com/repos/flatpak/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flatpak/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flatpak/flatpak/teams","hooks_url":"https://api.github.com/repos/flatpak/flatpak/hooks","issue_events_url":"https://api.github.com/repos/flatpak/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/flatpak/flatpak/events","assignees_url":"https://api.github.com/repos/flatpak/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/flatpak/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/flatpak/flatpak/tags","blobs_url":"https://api.github.com/repos/flatpak/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flatpak/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flatpak/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/flatpak/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flatpak/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/flatpak/flatpak/languages","stargazers_url":"https://api.github.com/repos/flatpak/flatpak/stargazers","contributors_url":"https://api.github.com/repos/flatpak/flatpak/contributors","subscribers_url":"https://api.github.com/repos/flatpak/flatpak/subscribers","subscription_url":"https://api.github.com/repos/flatpak/flatpak/subscription","commits_url":"https://api.github.com/repos/flatpak/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/flatpak/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/flatpak/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/flatpak/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/flatpak/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/flatpak/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flatpak/flatpak/merges","archive_url":"https://api.github.com/repos/flatpak/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flatpak/flatpak/downloads","issues_url":"https://api.github.com/repos/flatpak/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/flatpak/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/flatpak/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/flatpak/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flatpak/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/flatpak/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/flatpak/flatpak/deployments","created_at":"2016-05-19T14:19:21Z","updated_at":"2016-06-26T13:03:32Z","pushed_at":"2016-06-26T10:16:00Z","git_url":"git://github.com/flatpak/flatpak.git","ssh_url":"git@github.com:flatpak/flatpak.git","clone_url":"https://github.com/flatpak/flatpak.git","svn_url":"https://github.com/flatpak/flatpak","homepage":"http://flatpak.org","size":2138,"stargazers_count":271,"watchers_count":271,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":80,"forks":22,"open_issues":80,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/154"},"html":{"href":"https://github.com/flatpak/flatpak/pull/154"},"issue":{"href":"https://api.github.com/repos/flatpak/flatpak/issues/154"},"comments":{"href":"https://api.github.com/repos/flatpak/flatpak/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/flatpak/flatpak/statuses/844da7f8d0a5a4544cef8ce4cee7c4d5024171cb"}}}}
{"actor":{"display_login":"matthiasclasen"}}