{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/57725024","id":57725024,"diff_hunk":"@@ -70,8 +70,15 @@\n \tisb\n \n \t/* ---------------------------------------------------------------------\n-\t * Enable the SError interrupt now that the exception vectors have been\n-\t * setup.\n+\t * Early set RES1 bits in SCR_EL3. Set EA bit as well to catch both\n+\t * synchronous and asynchronous exceptions in EL3.","path":"include/common/el3_common_macros.S","position":7,"original_position":7,"commit_id":"e1704e2bdd7ae4010dd281b5574f290d364eb1aa","original_commit_id":"e1704e2bdd7ae4010dd281b5574f290d364eb1aa","user":{"login":"danh-arm","id":5684642,"avatar_url":"https://avatars.githubusercontent.com/u/5684642?v=3","gravatar_id":"","url":"https://api.github.com/users/danh-arm","html_url":"https://github.com/danh-arm","followers_url":"https://api.github.com/users/danh-arm/followers","following_url":"https://api.github.com/users/danh-arm/following{/other_user}","gists_url":"https://api.github.com/users/danh-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/danh-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danh-arm/subscriptions","organizations_url":"https://api.github.com/users/danh-arm/orgs","repos_url":"https://api.github.com/users/danh-arm/repos","events_url":"https://api.github.com/users/danh-arm/events{/privacy}","received_events_url":"https://api.github.com/users/danh-arm/received_events","type":"User","site_admin":false},"body":"Sorry to be pedantic, but I think it's really important we get the language here correct. This affects aborts, not all exception types. Also, you use the term \"SError\" in some places, and \"asynchronous external abort\" in others without saying they're the same thing. Suggest saying here \"Set EA bit as well to catch External Aborts and SError Interrupts in EL3\". In the commit message you could say something like \"SError Interrupts are also known as asynchronous external aborts\".","created_at":"2016-03-29T13:46:29Z","updated_at":"2016-03-29T13:46:29Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/554#discussion_r57725024","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/57725024"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/554#discussion_r57725024"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554","id":63045031,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/554","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/554.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/554.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/554","number":554,"state":"open","locked":false,"title":"Enable asynchronous abort exceptions during boot","user":{"login":"ljerry","id":6551820,"avatar_url":"https://avatars.githubusercontent.com/u/6551820?v=3","gravatar_id":"","url":"https://api.github.com/users/ljerry","html_url":"https://github.com/ljerry","followers_url":"https://api.github.com/users/ljerry/followers","following_url":"https://api.github.com/users/ljerry/following{/other_user}","gists_url":"https://api.github.com/users/ljerry/gists{/gist_id}","starred_url":"https://api.github.com/users/ljerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljerry/subscriptions","organizations_url":"https://api.github.com/users/ljerry/orgs","repos_url":"https://api.github.com/users/ljerry/repos","events_url":"https://api.github.com/users/ljerry/events{/privacy}","received_events_url":"https://api.github.com/users/ljerry/received_events","type":"User","site_admin":false},"body":"On r0p2 revision and above revision, despite what is stated in ARM DDI0500D TRM\r\nCortex A53 r0p2 SCR_EL3 description in Table 4-77, asynchronous exceptions\r\ngenerated by the code running in EL3 are not taken in EL3 when SCR_EL3[EA] is\r\nzero.\r\nDDI0487A.b Architecture Reference Manual does not reflect the actual\r\nbehaviour of r0p2.\r\n\r\nDDI0487A.e Architecture Reference Manual D7.2.80 SCR_EL3 description depicts\r\nthe observed behaviour.\r\n\r\nFixes arm-software/tf-issues#368\r\n\r\nSigned-off-by: Gerald Lejeune <gerald.lejeune@st.com>","created_at":"2016-03-16T10:49:52Z","updated_at":"2016-03-29T13:46:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0898adf823b4a52da601b6bfaa5d66ab4f5e2670","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/554/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/e1704e2bdd7ae4010dd281b5574f290d364eb1aa","head":{"label":"ljerry:tf_issue_368_ter","ref":"tf_issue_368_ter","sha":"e1704e2bdd7ae4010dd281b5574f290d364eb1aa","user":{"login":"ljerry","id":6551820,"avatar_url":"https://avatars.githubusercontent.com/u/6551820?v=3","gravatar_id":"","url":"https://api.github.com/users/ljerry","html_url":"https://github.com/ljerry","followers_url":"https://api.github.com/users/ljerry/followers","following_url":"https://api.github.com/users/ljerry/following{/other_user}","gists_url":"https://api.github.com/users/ljerry/gists{/gist_id}","starred_url":"https://api.github.com/users/ljerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljerry/subscriptions","organizations_url":"https://api.github.com/users/ljerry/orgs","repos_url":"https://api.github.com/users/ljerry/repos","events_url":"https://api.github.com/users/ljerry/events{/privacy}","received_events_url":"https://api.github.com/users/ljerry/received_events","type":"User","site_admin":false},"repo":{"id":23704597,"name":"arm-trusted-firmware","full_name":"ljerry/arm-trusted-firmware","owner":{"login":"ljerry","id":6551820,"avatar_url":"https://avatars.githubusercontent.com/u/6551820?v=3","gravatar_id":"","url":"https://api.github.com/users/ljerry","html_url":"https://github.com/ljerry","followers_url":"https://api.github.com/users/ljerry/followers","following_url":"https://api.github.com/users/ljerry/following{/other_user}","gists_url":"https://api.github.com/users/ljerry/gists{/gist_id}","starred_url":"https://api.github.com/users/ljerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljerry/subscriptions","organizations_url":"https://api.github.com/users/ljerry/orgs","repos_url":"https://api.github.com/users/ljerry/repos","events_url":"https://api.github.com/users/ljerry/events{/privacy}","received_events_url":"https://api.github.com/users/ljerry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljerry/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/ljerry/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ljerry/arm-trusted-firmware/deployments","created_at":"2014-09-05T13:49:55Z","updated_at":"2015-03-18T13:55:02Z","pushed_at":"2016-03-25T15:35:42Z","git_url":"git://github.com/ljerry/arm-trusted-firmware.git","ssh_url":"git@github.com:ljerry/arm-trusted-firmware.git","clone_url":"https://github.com/ljerry/arm-trusted-firmware.git","svn_url":"https://github.com/ljerry/arm-trusted-firmware","homepage":null,"size":6208,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"55a85659c0a35dba10c72a9c38b82b29f77a90ad","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2016-03-26T01:38:41Z","pushed_at":"2016-03-25T15:35:42Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":null,"size":8382,"stargazers_count":157,"watchers_count":157,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":17,"forks":156,"open_issues":17,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/554"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/554"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/e1704e2bdd7ae4010dd281b5574f290d364eb1aa"}}}}