{"action":"created","comment":{"url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/58314713","id":58314713,"diff_hunk":"@@ -1342,6 +1360,27 @@\n \n \t\t\t\treturn false;\n \t\t\t},\n+\t\t\t_touchmove: function(ev) {\n+\t\t\t\tif (ev.changedTouches === undefined) {\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\n+\t\t\t\tvar touch = ev.changedTouches[0];\n+\n+\t\t\t\tvar xDiff = touch.pageX - this.touchX;\n+\t\t\t\tvar yDiff = touch.pageY - this.touchY;\n+\n+\t\t\t\tif (!this._state.inDrag) {\n+\t\t\t\t\t// Vertical Slider\n+\t\t\t\t\tif (this.options.orientation === 'vertical' && (xDiff <= 5 && xDiff >= -5) && (yDiff >=15 || yDiff <= -15)) {\n+\t\t\t\t\t\tthis._mousedown(ev);\n+\t\t\t\t\t}\n+\t\t\t\t\t// Horizontal slider.\n+\t\t\t\t\telse if ((yDiff <= 5 && yDiff >= -5) && (xDiff >= 15 || xDiff <= -15)) {\n+\t\t\t\t\t\tthis._mousedown(ev);","path":"src/js/bootstrap-slider.js","position":73,"original_position":73,"commit_id":"22d5062eaf97761b84c0565f9abea9ccadbb4142","original_commit_id":"22d5062eaf97761b84c0565f9abea9ccadbb4142","user":{"login":"rovolution","id":437318,"avatar_url":"https://avatars.githubusercontent.com/u/437318?v=3","gravatar_id":"","url":"https://api.github.com/users/rovolution","html_url":"https://github.com/rovolution","followers_url":"https://api.github.com/users/rovolution/followers","following_url":"https://api.github.com/users/rovolution/following{/other_user}","gists_url":"https://api.github.com/users/rovolution/gists{/gist_id}","starred_url":"https://api.github.com/users/rovolution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovolution/subscriptions","organizations_url":"https://api.github.com/users/rovolution/orgs","repos_url":"https://api.github.com/users/rovolution/repos","events_url":"https://api.github.com/users/rovolution/events{/privacy}","received_events_url":"https://api.github.com/users/rovolution/received_events","type":"User","site_admin":false},"body":"this should be `this._mousemove()` since this is analogous to the `mousemove`","created_at":"2016-04-03T18:14:35Z","updated_at":"2016-04-03T18:14:35Z","html_url":"https://github.com/seiyria/bootstrap-slider/pull/551#discussion_r58314713","pull_request_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551","_links":{"self":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/58314713"},"html":{"href":"https://github.com/seiyria/bootstrap-slider/pull/551#discussion_r58314713"},"pull_request":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551","id":64850979,"html_url":"https://github.com/seiyria/bootstrap-slider/pull/551","diff_url":"https://github.com/seiyria/bootstrap-slider/pull/551.diff","patch_url":"https://github.com/seiyria/bootstrap-slider/pull/551.patch","issue_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/551","number":551,"state":"open","locked":false,"title":"Touch move conflicting with user trying to scroll fix","user":{"login":"jerrylow","id":984430,"avatar_url":"https://avatars.githubusercontent.com/u/984430?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrylow","html_url":"https://github.com/jerrylow","followers_url":"https://api.github.com/users/jerrylow/followers","following_url":"https://api.github.com/users/jerrylow/following{/other_user}","gists_url":"https://api.github.com/users/jerrylow/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrylow/subscriptions","organizations_url":"https://api.github.com/users/jerrylow/orgs","repos_url":"https://api.github.com/users/jerrylow/repos","events_url":"https://api.github.com/users/jerrylow/events{/privacy}","received_events_url":"https://api.github.com/users/jerrylow/received_events","type":"User","site_admin":false},"body":"Fixing issue #428 where scrolling on mobile devices are locked in the slider.\r\n\r\nHere's the fixed version in demo: http://codepen.io/jerrylow/pen/wGrBVo\r\n\r\nAlso the previous issue with video demonstration:\r\n\r\nCodepen: http://codepen.io/anon/pen/LVKeQq\r\nVideo: http://jerrylow.com/demo/bootstrap-slider/bootstrap-slider-demo.mp4\r\n\r\nChanges:\r\n\r\nI'm detecting the direction of the swipe before determining if they're trying to scroll or swipe on the slider. There's a threshold if they stay within 5px (+/-) of the slider direction also moving a distance greater than 15px. I did a bunch of tests with 5, 10, 15, 20, 25. Anything greater than 20 there was a bit of delay so it wasn't as responsive. Ten was ok but there's still an issue if the user is swiping slightly diagonal. Fifteen pixels seems to be the best balance to solve the issue on a basic level.","created_at":"2016-03-31T20:11:56Z","updated_at":"2016-04-03T18:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adaea617714326fd8403e8f422a824a89f6cbbc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551/commits","review_comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551/comments","review_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/551/comments","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/22d5062eaf97761b84c0565f9abea9ccadbb4142","head":{"label":"jerrylow:Touch-Fix","ref":"Touch-Fix","sha":"22d5062eaf97761b84c0565f9abea9ccadbb4142","user":{"login":"jerrylow","id":984430,"avatar_url":"https://avatars.githubusercontent.com/u/984430?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrylow","html_url":"https://github.com/jerrylow","followers_url":"https://api.github.com/users/jerrylow/followers","following_url":"https://api.github.com/users/jerrylow/following{/other_user}","gists_url":"https://api.github.com/users/jerrylow/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrylow/subscriptions","organizations_url":"https://api.github.com/users/jerrylow/orgs","repos_url":"https://api.github.com/users/jerrylow/repos","events_url":"https://api.github.com/users/jerrylow/events{/privacy}","received_events_url":"https://api.github.com/users/jerrylow/received_events","type":"User","site_admin":false},"repo":{"id":55165685,"name":"bootstrap-slider","full_name":"jerrylow/bootstrap-slider","owner":{"login":"jerrylow","id":984430,"avatar_url":"https://avatars.githubusercontent.com/u/984430?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrylow","html_url":"https://github.com/jerrylow","followers_url":"https://api.github.com/users/jerrylow/followers","following_url":"https://api.github.com/users/jerrylow/following{/other_user}","gists_url":"https://api.github.com/users/jerrylow/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrylow/subscriptions","organizations_url":"https://api.github.com/users/jerrylow/orgs","repos_url":"https://api.github.com/users/jerrylow/repos","events_url":"https://api.github.com/users/jerrylow/events{/privacy}","received_events_url":"https://api.github.com/users/jerrylow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerrylow/bootstrap-slider","description":"A complete rewrite of the original bootstrap-slider by Stefan Petre.","fork":true,"url":"https://api.github.com/repos/jerrylow/bootstrap-slider","forks_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/releases{/id}","deployments_url":"https://api.github.com/repos/jerrylow/bootstrap-slider/deployments","created_at":"2016-03-31T16:24:56Z","updated_at":"2016-03-31T16:24:57Z","pushed_at":"2016-04-03T17:30:28Z","git_url":"git://github.com/jerrylow/bootstrap-slider.git","ssh_url":"git@github.com:jerrylow/bootstrap-slider.git","clone_url":"https://github.com/jerrylow/bootstrap-slider.git","svn_url":"https://github.com/jerrylow/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":16851,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seiyria:master","ref":"master","sha":"a740966d367c3e78dbb78af503d761e0538a1f13","user":{"login":"seiyria","id":763609,"avatar_url":"https://avatars.githubusercontent.com/u/763609?v=3","gravatar_id":"","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"repo":{"id":11111023,"name":"bootstrap-slider","full_name":"seiyria/bootstrap-slider","owner":{"login":"seiyria","id":763609,"avatar_url":"https://avatars.githubusercontent.com/u/763609?v=3","gravatar_id":"","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seiyria/bootstrap-slider","description":"A complete rewrite of the original bootstrap-slider by Stefan Petre.","fork":false,"url":"https://api.github.com/repos/seiyria/bootstrap-slider","forks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/seiyria/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seiyria/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seiyria/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/seiyria/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/seiyria/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/seiyria/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seiyria/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/seiyria/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seiyria/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/seiyria/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/seiyria/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seiyria/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/seiyria/bootstrap-slider/releases{/id}","deployments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/deployments","created_at":"2013-07-02T00:25:54Z","updated_at":"2016-04-03T15:11:13Z","pushed_at":"2016-04-03T17:30:29Z","git_url":"git://github.com/seiyria/bootstrap-slider.git","ssh_url":"git@github.com:seiyria/bootstrap-slider.git","clone_url":"https://github.com/seiyria/bootstrap-slider.git","svn_url":"https://github.com/seiyria/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":17553,"stargazers_count":1368,"watchers_count":1368,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":520,"mirror_url":null,"open_issues_count":48,"forks":520,"open_issues":48,"watchers":1368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551"},"html":{"href":"https://github.com/seiyria/bootstrap-slider/pull/551"},"issue":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/551"},"comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/22d5062eaf97761b84c0565f9abea9ccadbb4142"}}}}