{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Hosting/pulls/comments/74258387","id":74258387,"diff_hunk":"@@ -16,4 +16,25 @@ public virtual IServiceProvider ConfigureServices(IServiceCollection services)\n             return services.BuildServiceProvider();\n         }\n     }\n+\n+    public abstract class StartupBase<TContainer> : IStartup\n+    {\n+        private readonly IServiceProviderFactory _factory;\n+\n+        public StartupBase(IServiceProviderFactory factory)\n+        {\n+            _factory = factory;\n+        }\n+\n+        public abstract void Configure(IApplicationBuilder app);\n+\n+        public IServiceProvider ConfigureServices(IServiceCollection services)\n+        {\n+            var builder = _factory.CreateBuilder(services);","path":"src/Microsoft.AspNetCore.Hosting/Startup/StartupBase.cs","position":18,"original_position":18,"commit_id":"ad39b228dc684d4bf337ddb576e5071a94c05751","original_commit_id":"ad39b228dc684d4bf337ddb576e5071a94c05751","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"This should be virtual. ","created_at":"2016-08-10T14:45:23Z","updated_at":"2016-08-10T14:45:23Z","html_url":"https://github.com/aspnet/Hosting/pull/833#discussion_r74258387","pull_request_url":"https://api.github.com/repos/aspnet/Hosting/pulls/833","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/comments/74258387"},"html":{"href":"https://github.com/aspnet/Hosting/pull/833#discussion_r74258387"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/833"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Hosting/pulls/833","id":80699407,"html_url":"https://github.com/aspnet/Hosting/pull/833","diff_url":"https://github.com/aspnet/Hosting/pull/833.diff","patch_url":"https://github.com/aspnet/Hosting/pull/833.patch","issue_url":"https://api.github.com/repos/aspnet/Hosting/issues/833","number":833,"state":"open","locked":false,"title":"WIP: Service provider factory prototype","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"/cc @pakrym @halter73 ","created_at":"2016-08-09T21:37:47Z","updated_at":"2016-08-10T14:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ede555443dc3a3ea92a303108603e703419f9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Hosting/pulls/833/commits","review_comments_url":"https://api.github.com/repos/aspnet/Hosting/pulls/833/comments","review_comment_url":"https://api.github.com/repos/aspnet/Hosting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Hosting/issues/833/comments","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/ad39b228dc684d4bf337ddb576e5071a94c05751","head":{"label":"aspnet:davidfowl/service-provider-factory","ref":"davidfowl/service-provider-factory","sha":"ad39b228dc684d4bf337ddb576e5071a94c05751","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16630141,"name":"Hosting","full_name":"aspnet/Hosting","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Hosting","description":"Code for hosting and starting up an ASP.NET Core application.","fork":false,"url":"https://api.github.com/repos/aspnet/Hosting","forks_url":"https://api.github.com/repos/aspnet/Hosting/forks","keys_url":"https://api.github.com/repos/aspnet/Hosting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Hosting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Hosting/teams","hooks_url":"https://api.github.com/repos/aspnet/Hosting/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Hosting/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Hosting/events","assignees_url":"https://api.github.com/repos/aspnet/Hosting/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Hosting/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Hosting/tags","blobs_url":"https://api.github.com/repos/aspnet/Hosting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Hosting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Hosting/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Hosting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Hosting/languages","stargazers_url":"https://api.github.com/repos/aspnet/Hosting/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Hosting/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Hosting/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Hosting/subscription","commits_url":"https://api.github.com/repos/aspnet/Hosting/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Hosting/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Hosting/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Hosting/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Hosting/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Hosting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Hosting/merges","archive_url":"https://api.github.com/repos/aspnet/Hosting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Hosting/downloads","issues_url":"https://api.github.com/repos/aspnet/Hosting/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Hosting/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Hosting/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Hosting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Hosting/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Hosting/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Hosting/deployments","created_at":"2014-02-07T22:58:12Z","updated_at":"2016-08-03T15:39:14Z","pushed_at":"2016-08-09T23:30:13Z","git_url":"git://github.com/aspnet/Hosting.git","ssh_url":"git@github.com:aspnet/Hosting.git","clone_url":"https://github.com/aspnet/Hosting.git","svn_url":"https://github.com/aspnet/Hosting","homepage":"","size":3066,"stargazers_count":195,"watchers_count":195,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":52,"forks":121,"open_issues":52,"watchers":195,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"1aa5ebc585422834b21d052487247e58d3ace3d3","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16630141,"name":"Hosting","full_name":"aspnet/Hosting","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Hosting","description":"Code for hosting and starting up an ASP.NET Core application.","fork":false,"url":"https://api.github.com/repos/aspnet/Hosting","forks_url":"https://api.github.com/repos/aspnet/Hosting/forks","keys_url":"https://api.github.com/repos/aspnet/Hosting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Hosting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Hosting/teams","hooks_url":"https://api.github.com/repos/aspnet/Hosting/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Hosting/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Hosting/events","assignees_url":"https://api.github.com/repos/aspnet/Hosting/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Hosting/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Hosting/tags","blobs_url":"https://api.github.com/repos/aspnet/Hosting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Hosting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Hosting/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Hosting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Hosting/languages","stargazers_url":"https://api.github.com/repos/aspnet/Hosting/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Hosting/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Hosting/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Hosting/subscription","commits_url":"https://api.github.com/repos/aspnet/Hosting/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Hosting/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Hosting/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Hosting/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Hosting/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Hosting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Hosting/merges","archive_url":"https://api.github.com/repos/aspnet/Hosting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Hosting/downloads","issues_url":"https://api.github.com/repos/aspnet/Hosting/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Hosting/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Hosting/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Hosting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Hosting/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Hosting/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Hosting/deployments","created_at":"2014-02-07T22:58:12Z","updated_at":"2016-08-03T15:39:14Z","pushed_at":"2016-08-09T23:30:13Z","git_url":"git://github.com/aspnet/Hosting.git","ssh_url":"git@github.com:aspnet/Hosting.git","clone_url":"https://github.com/aspnet/Hosting.git","svn_url":"https://github.com/aspnet/Hosting","homepage":"","size":3066,"stargazers_count":195,"watchers_count":195,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":52,"forks":121,"open_issues":52,"watchers":195,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/833"},"html":{"href":"https://github.com/aspnet/Hosting/pull/833"},"issue":{"href":"https://api.github.com/repos/aspnet/Hosting/issues/833"},"comments":{"href":"https://api.github.com/repos/aspnet/Hosting/issues/833/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/833/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/833/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Hosting/statuses/ad39b228dc684d4bf337ddb576e5071a94c05751"}}}}
{"actor":{"display_login":"davidfowl"}}