{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/75850245","id":75850245,"diff_hunk":"@@ -0,0 +1,217 @@\n+/*!\n+ * Copyright (c) 2015 by Contributors\n+ * \\file caffe_data_iter.cc\n+ * \\brief register mnist iterator\n+*/\n+#include <caffe/proto/caffe.pb.h>\n+#include <dmlc/logging.h>\n+#include <dmlc/parameter.h>\n+#include <mxnet/operator.h>\n+#include <atomic>\n+\n+#include \"../../src/operator/operator_common.h\"\n+#include \"caffe_common.h\"\n+#include \"caffe_stream.h\"\n+#include \"caffe_fieldentry.h\"\n+#include \"caffe_blob.h\"\n+#include \"../../src/io/inst_vector.h\"\n+#include \"../../src/io/iter_prefetcher.h\"\n+#include \"../../src/operator/cast-inl.h\"\n+\n+namespace mxnet {\n+namespace io {\n+\n+struct CaffeDataParam : public dmlc::Parameter<CaffeDataParam> {\n+  /*! \\brief protobuf text */\n+  ::caffe::LayerParameter prototxt;\n+  /*! \\brief maximum iteration count */\n+  int max_iterations;","path":"plugin/caffe/caffe_data_iter.cc","position":28,"original_position":28,"commit_id":"88b4ac0671371b8ec7e1516b64f183251c4a8efa","original_commit_id":"88b4ac0671371b8ec7e1516b64f183251c4a8efa","user":{"login":"piiswrong","id":568948,"avatar_url":"https://avatars.githubusercontent.com/u/568948?v=3","gravatar_id":"","url":"https://api.github.com/users/piiswrong","html_url":"https://github.com/piiswrong","followers_url":"https://api.github.com/users/piiswrong/followers","following_url":"https://api.github.com/users/piiswrong/following{/other_user}","gists_url":"https://api.github.com/users/piiswrong/gists{/gist_id}","starred_url":"https://api.github.com/users/piiswrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piiswrong/subscriptions","organizations_url":"https://api.github.com/users/piiswrong/orgs","repos_url":"https://api.github.com/users/piiswrong/repos","events_url":"https://api.github.com/users/piiswrong/events{/privacy}","received_events_url":"https://api.github.com/users/piiswrong/received_events","type":"User","site_admin":false},"body":"I understand. I'm just suggesting rename max_iterations to epoch_size for naming consistency. You can have a look at FeedForward.fit interface. epoch_size means how many batches there are for an epoch there","created_at":"2016-08-23T11:52:47Z","updated_at":"2016-08-23T11:52:47Z","html_url":"https://github.com/dmlc/mxnet/pull/3103#discussion_r75850245","pull_request_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3103","_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/75850245"},"html":{"href":"https://github.com/dmlc/mxnet/pull/3103#discussion_r75850245"},"pull_request":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3103"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/3103","id":82232565,"html_url":"https://github.com/dmlc/mxnet/pull/3103","diff_url":"https://github.com/dmlc/mxnet/pull/3103.diff","patch_url":"https://github.com/dmlc/mxnet/pull/3103.patch","issue_url":"https://api.github.com/repos/dmlc/mxnet/issues/3103","number":3103,"state":"open","locked":false,"title":"Caffe data layer to MXIter converter","user":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars.githubusercontent.com/u/11234557?v=3","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"body":"Supply prototxt for caffe model's data layer and it is created with an MXNet data iterator interface.  In additioin, added caffe-converter-tool converted caffe model to json file loading in caffe_net.py\r\n","created_at":"2016-08-22T17:42:25Z","updated_at":"2016-08-23T11:52:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24f0a289067ddb0968dbd795211b8400e0767a2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3103/commits","review_comments_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3103/comments","review_comment_url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/mxnet/issues/3103/comments","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/88b4ac0671371b8ec7e1516b64f183251c4a8efa","head":{"label":"cjolivier01:master","ref":"master","sha":"88b4ac0671371b8ec7e1516b64f183251c4a8efa","user":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars.githubusercontent.com/u/11234557?v=3","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"repo":{"id":66292371,"name":"mxnet","full_name":"cjolivier01/mxnet","owner":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars.githubusercontent.com/u/11234557?v=3","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjolivier01/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/cjolivier01/mxnet","forks_url":"https://api.github.com/repos/cjolivier01/mxnet/forks","keys_url":"https://api.github.com/repos/cjolivier01/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjolivier01/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjolivier01/mxnet/teams","hooks_url":"https://api.github.com/repos/cjolivier01/mxnet/hooks","issue_events_url":"https://api.github.com/repos/cjolivier01/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/cjolivier01/mxnet/events","assignees_url":"https://api.github.com/repos/cjolivier01/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/cjolivier01/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/cjolivier01/mxnet/tags","blobs_url":"https://api.github.com/repos/cjolivier01/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjolivier01/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjolivier01/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjolivier01/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjolivier01/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/cjolivier01/mxnet/languages","stargazers_url":"https://api.github.com/repos/cjolivier01/mxnet/stargazers","contributors_url":"https://api.github.com/repos/cjolivier01/mxnet/contributors","subscribers_url":"https://api.github.com/repos/cjolivier01/mxnet/subscribers","subscription_url":"https://api.github.com/repos/cjolivier01/mxnet/subscription","commits_url":"https://api.github.com/repos/cjolivier01/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjolivier01/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjolivier01/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjolivier01/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjolivier01/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/cjolivier01/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjolivier01/mxnet/merges","archive_url":"https://api.github.com/repos/cjolivier01/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjolivier01/mxnet/downloads","issues_url":"https://api.github.com/repos/cjolivier01/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/cjolivier01/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/cjolivier01/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/cjolivier01/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjolivier01/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/cjolivier01/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/cjolivier01/mxnet/deployments","created_at":"2016-08-22T17:12:33Z","updated_at":"2016-08-22T17:12:36Z","pushed_at":"2016-08-23T00:02:59Z","git_url":"git://github.com/cjolivier01/mxnet.git","ssh_url":"git@github.com:cjolivier01/mxnet.git","clone_url":"https://github.com/cjolivier01/mxnet.git","svn_url":"https://github.com/cjolivier01/mxnet","homepage":"http://mxnet.io","size":8500,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"ce92c1074754a5a5fb607d3c59dd119c37cd6aea","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"mxnet","full_name":"dmlc/mxnet","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/dmlc/mxnet","forks_url":"https://api.github.com/repos/dmlc/mxnet/forks","keys_url":"https://api.github.com/repos/dmlc/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/mxnet/teams","hooks_url":"https://api.github.com/repos/dmlc/mxnet/hooks","issue_events_url":"https://api.github.com/repos/dmlc/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/mxnet/events","assignees_url":"https://api.github.com/repos/dmlc/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/mxnet/tags","blobs_url":"https://api.github.com/repos/dmlc/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/mxnet/languages","stargazers_url":"https://api.github.com/repos/dmlc/mxnet/stargazers","contributors_url":"https://api.github.com/repos/dmlc/mxnet/contributors","subscribers_url":"https://api.github.com/repos/dmlc/mxnet/subscribers","subscription_url":"https://api.github.com/repos/dmlc/mxnet/subscription","commits_url":"https://api.github.com/repos/dmlc/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/mxnet/merges","archive_url":"https://api.github.com/repos/dmlc/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/mxnet/downloads","issues_url":"https://api.github.com/repos/dmlc/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2016-08-23T11:11:30Z","pushed_at":"2016-08-23T00:03:01Z","git_url":"git://github.com/dmlc/mxnet.git","ssh_url":"git@github.com:dmlc/mxnet.git","clone_url":"https://github.com/dmlc/mxnet.git","svn_url":"https://github.com/dmlc/mxnet","homepage":"http://mxnet.io","size":12234,"stargazers_count":4811,"watchers_count":4811,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1811,"mirror_url":null,"open_issues_count":579,"forks":1811,"open_issues":579,"watchers":4811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3103"},"html":{"href":"https://github.com/dmlc/mxnet/pull/3103"},"issue":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/3103"},"comments":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/3103/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3103/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3103/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/mxnet/statuses/88b4ac0671371b8ec7e1516b64f183251c4a8efa"}}}}
{"actor":{"display_login":"piiswrong"}}