{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/comments/82383418","pull_request_review_id":3295843,"id":82383418,"diff_hunk":"@@ -44,8 +50,21 @@\n             TfsTelemetryInstrumentationInfo.isDeveloperMode());\n     }\n \n+    public synchronized static void checkDisableTelemetryProperty() {\n+        // Unfortunately, we can't push the disabled logic onto the\n+        // TelemetryClient itself because the initialization code for\n+        // that object simply takes too much time. So, we have to stop\n+        // the sending of telemetry here in the helper class.\n+\n+        // If the system property exists or the env var is true, then we disable\n+        // telemetry.\n+        sendingTelemetryDisabled = System.getProperty(DISABLE_TELEMETRY_PROPERTY_NAME) != null","path":"source/com.microsoft.tfs.core/src/com/microsoft/tfs/core/telemetry/TfsTelemetryHelper.java","position":35,"original_position":35,"commit_id":"83ba9feb40d11bc1e6596621b601d172101c93f8","original_commit_id":"83ba9feb40d11bc1e6596621b601d172101c93f8","user":{"login":"AlexRukhlin","id":3045393,"avatar_url":"https://avatars.githubusercontent.com/u/3045393?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexRukhlin","html_url":"https://github.com/AlexRukhlin","followers_url":"https://api.github.com/users/AlexRukhlin/followers","following_url":"https://api.github.com/users/AlexRukhlin/following{/other_user}","gists_url":"https://api.github.com/users/AlexRukhlin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexRukhlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexRukhlin/subscriptions","organizations_url":"https://api.github.com/users/AlexRukhlin/orgs","repos_url":"https://api.github.com/users/AlexRukhlin/repos","events_url":"https://api.github.com/users/AlexRukhlin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexRukhlin/received_events","type":"User","site_admin":false},"body":"Can we move this initialization to the CLCTelemetryHelper class? We might make it just as a static initializer. e.g.\r\n    static {\r\n        sendingTelemetryDisabled = System.getProperty(DISABLE_TELEMETRY_PROPERTY_NAME) != null\r\n            || EnvironmentVariables.getBoolean(DISABLE_TELEMETRY_ENVIRONMENT_VAR, false);\r\n    }\r\n","created_at":"2016-10-07T12:58:07Z","updated_at":"2016-10-07T12:58:07Z","html_url":"https://github.com/Microsoft/team-explorer-everywhere/pull/120#discussion_r82383418","pull_request_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/comments/82383418"},"html":{"href":"https://github.com/Microsoft/team-explorer-everywhere/pull/120#discussion_r82383418"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120","id":87395459,"html_url":"https://github.com/Microsoft/team-explorer-everywhere/pull/120","diff_url":"https://github.com/Microsoft/team-explorer-everywhere/pull/120.diff","patch_url":"https://github.com/Microsoft/team-explorer-everywhere/pull/120.patch","issue_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/120","number":120,"state":"open","locked":false,"title":"Adding the ability to disable telemetry with env var or system property","user":{"login":"jpricketMSFT","id":2790254,"avatar_url":"https://avatars.githubusercontent.com/u/2790254?v=3","gravatar_id":"","url":"https://api.github.com/users/jpricketMSFT","html_url":"https://github.com/jpricketMSFT","followers_url":"https://api.github.com/users/jpricketMSFT/followers","following_url":"https://api.github.com/users/jpricketMSFT/following{/other_user}","gists_url":"https://api.github.com/users/jpricketMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/jpricketMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpricketMSFT/subscriptions","organizations_url":"https://api.github.com/users/jpricketMSFT/orgs","repos_url":"https://api.github.com/users/jpricketMSFT/repos","events_url":"https://api.github.com/users/jpricketMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/jpricketMSFT/received_events","type":"User","site_admin":false},"body":"These changes are needed to speed up the CLC when being called from an IDE like IntelliJ. It also gives the user a way to turn off telemetry.","created_at":"2016-09-29T21:15:15Z","updated_at":"2016-10-07T12:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17b6fe077f4ea827753c276fb677abbf988de019","assignee":{"login":"AlexRukhlin","id":3045393,"avatar_url":"https://avatars.githubusercontent.com/u/3045393?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexRukhlin","html_url":"https://github.com/AlexRukhlin","followers_url":"https://api.github.com/users/AlexRukhlin/followers","following_url":"https://api.github.com/users/AlexRukhlin/following{/other_user}","gists_url":"https://api.github.com/users/AlexRukhlin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexRukhlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexRukhlin/subscriptions","organizations_url":"https://api.github.com/users/AlexRukhlin/orgs","repos_url":"https://api.github.com/users/AlexRukhlin/repos","events_url":"https://api.github.com/users/AlexRukhlin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexRukhlin/received_events","type":"User","site_admin":false},"assignees":[{"login":"AlexRukhlin","id":3045393,"avatar_url":"https://avatars.githubusercontent.com/u/3045393?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexRukhlin","html_url":"https://github.com/AlexRukhlin","followers_url":"https://api.github.com/users/AlexRukhlin/followers","following_url":"https://api.github.com/users/AlexRukhlin/following{/other_user}","gists_url":"https://api.github.com/users/AlexRukhlin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexRukhlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexRukhlin/subscriptions","organizations_url":"https://api.github.com/users/AlexRukhlin/orgs","repos_url":"https://api.github.com/users/AlexRukhlin/repos","events_url":"https://api.github.com/users/AlexRukhlin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexRukhlin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120/commits","review_comments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120/comments","review_comment_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/120/comments","statuses_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/statuses/83ba9feb40d11bc1e6596621b601d172101c93f8","head":{"label":"Microsoft:users/jpricket/fast","ref":"users/jpricket/fast","sha":"83ba9feb40d11bc1e6596621b601d172101c93f8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":52110673,"name":"team-explorer-everywhere","full_name":"Microsoft/team-explorer-everywhere","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/team-explorer-everywhere","description":"Team Explorer Everywhere Plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere","forks_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/forks","keys_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/teams","hooks_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/events","assignees_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/tags","blobs_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/languages","stargazers_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/subscription","commits_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/merges","archive_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/downloads","issues_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/deployments","created_at":"2016-02-19T19:20:02Z","updated_at":"2016-09-07T19:40:33Z","pushed_at":"2016-10-06T20:53:37Z","git_url":"git://github.com/Microsoft/team-explorer-everywhere.git","ssh_url":"git@github.com:Microsoft/team-explorer-everywhere.git","clone_url":"https://github.com/Microsoft/team-explorer-everywhere.git","svn_url":"https://github.com/Microsoft/team-explorer-everywhere","homepage":null,"size":46210,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":12,"forks":11,"open_issues":12,"watchers":52,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"ce0168adc33cf9234601d55e4c439c427432f333","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":52110673,"name":"team-explorer-everywhere","full_name":"Microsoft/team-explorer-everywhere","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/team-explorer-everywhere","description":"Team Explorer Everywhere Plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere","forks_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/forks","keys_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/teams","hooks_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/events","assignees_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/tags","blobs_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/languages","stargazers_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/subscription","commits_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/merges","archive_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/downloads","issues_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/deployments","created_at":"2016-02-19T19:20:02Z","updated_at":"2016-09-07T19:40:33Z","pushed_at":"2016-10-06T20:53:37Z","git_url":"git://github.com/Microsoft/team-explorer-everywhere.git","ssh_url":"git@github.com:Microsoft/team-explorer-everywhere.git","clone_url":"https://github.com/Microsoft/team-explorer-everywhere.git","svn_url":"https://github.com/Microsoft/team-explorer-everywhere","homepage":null,"size":46210,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":12,"forks":11,"open_issues":12,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120"},"html":{"href":"https://github.com/Microsoft/team-explorer-everywhere/pull/120"},"issue":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/120"},"comments":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/team-explorer-everywhere/statuses/83ba9feb40d11bc1e6596621b601d172101c93f8"}}}}
{"actor":{"display_login":"AlexRukhlin"}}