{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/87945320","pull_request_review_id":8534737,"id":87945320,"diff_hunk":"@@ -332,40 +384,62 @@ public String subclass(TypeDescription.Generic superClass) {\n     return res;\n   }\n \n-  private static Implementation getRestrictionCoderDelegation(DoFnSignature signature) {\n+  private static Implementation getRestrictionCoderDelegation(\n+      TypeDescription doFnType, DoFnSignature signature) {\n     if (signature.processElement().isSplittable()) {\n       if (signature.getRestrictionCoder() == null) {\n         return MethodDelegation.to(\n             new DefaultRestrictionCoder(signature.getInitialRestriction().restrictionT()));\n       } else {\n         return new DowncastingParametersMethodDelegation(\n+            doFnType,\n             signature.getRestrictionCoder().targetMethod());\n       }\n     } else {\n       return ExceptionMethod.throwing(UnsupportedOperationException.class);\n     }\n   }\n \n-  private static Implementation splitRestrictionDelegation(DoFnSignature signature) {\n+  private static Implementation splitRestrictionDelegation(\n+      TypeDescription doFnType, DoFnSignature signature) {\n     if (signature.splitRestriction() == null) {\n       return MethodDelegation.to(DefaultSplitRestriction.class);\n     } else {\n-      return new DowncastingParametersMethodDelegation(signature.splitRestriction().targetMethod());\n+      return new DowncastingParametersMethodDelegation(\n+          doFnType, signature.splitRestriction().targetMethod());\n     }\n   }\n \n   /** Delegates to the given method if available, or does nothing. */\n-  private static Implementation delegateOrNoop(DoFnSignature.DoFnMethod method) {\n+  private static Implementation delegateOrNoop(TypeDescription doFnType, DoFnSignature.DoFnMethod\n+      method) {\n     return (method == null)\n         ? FixedValue.originType()\n-        : new DoFnMethodDelegation(method.targetMethod());\n+        : new DoFnMethodDelegation(doFnType, method.targetMethod());\n   }\n \n   /** Delegates to the given method if available, or throws UnsupportedOperationException. */\n-  private static Implementation delegateWithDowncastOrThrow(DoFnSignature.DoFnMethod method) {\n+  private static Implementation delegateWithDowncastOrThrow(\n+      TypeDescription doFnType, DoFnSignature.DoFnMethod method) {\n     return (method == null)\n         ? ExceptionMethod.throwing(UnsupportedOperationException.class)\n-        : new DowncastingParametersMethodDelegation(method.targetMethod());\n+        : new DowncastingParametersMethodDelegation(doFnType, method.targetMethod());\n+  }\n+\n+  /**\n+   * Internal delegation class for generated {@link DoFnInvoker} instances.\n+   *\n+   * <p>This class should <i>not</i> be accessed directly, or by Beam users. It must be public for\n+   * generated instances to have adequate access, as they are generated \"inside\" the invoked {@link\n+   * DoFn} class.\n+   */\n+  public static class OnTimerMethodDelegation {\n+    public static void invokeOnTimer(\n+        @This DoFnInvokerBase invoker,\n+        @Argument(0) String timerId,\n+        @Argument(1) ExtraContextFactory args) {\n+      ((OnTimerInvoker) invoker.onTimerInvokers.get(timerId)).invokeOnTimer(args);","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java","position":null,"original_position":221,"commit_id":"e9c4160887eac765dcdf1b34ac46d742c0581f44","original_commit_id":"948514af4d8e47bce8f2651969c9bd2a0796806a","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"body":"Yes. Done. Not sure why I didn't think of that.","created_at":"2016-11-15T04:08:13Z","updated_at":"2016-11-15T04:38:00Z","html_url":"https://github.com/apache/incubator-beam/pull/1307#discussion_r87945320","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1307","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/87945320"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1307#discussion_r87945320"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1307"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1307","id":92709266,"html_url":"https://github.com/apache/incubator-beam/pull/1307","diff_url":"https://github.com/apache/incubator-beam/pull/1307.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1307.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1307","number":1307,"state":"open","locked":false,"title":"[BEAM-27] Connect generated DoFnInvoker's invokerOnTimer to generated OnTimerInvoker","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [x] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\n","created_at":"2016-11-08T03:28:53Z","updated_at":"2016-11-15T04:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"049b167909a98de9389a64525a6516dc47fdcbb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1307/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1307/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1307/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/e9c4160887eac765dcdf1b34ac46d742c0581f44","head":{"label":"kennknowles:DoFnInvokers-OnTimerInvokers","ref":"DoFnInvokers-OnTimerInvokers","sha":"e9c4160887eac765dcdf1b34ac46d742c0581f44","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"repo":{"id":52646147,"name":"incubator-beam","full_name":"kennknowles/incubator-beam","owner":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennknowles/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/kennknowles/incubator-beam","forks_url":"https://api.github.com/repos/kennknowles/incubator-beam/forks","keys_url":"https://api.github.com/repos/kennknowles/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennknowles/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennknowles/incubator-beam/teams","hooks_url":"https://api.github.com/repos/kennknowles/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/kennknowles/incubator-beam/events","assignees_url":"https://api.github.com/repos/kennknowles/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/kennknowles/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/kennknowles/incubator-beam/tags","blobs_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennknowles/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/kennknowles/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/kennknowles/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/kennknowles/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/kennknowles/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/kennknowles/incubator-beam/subscription","commits_url":"https://api.github.com/repos/kennknowles/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennknowles/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennknowles/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/kennknowles/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennknowles/incubator-beam/merges","archive_url":"https://api.github.com/repos/kennknowles/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennknowles/incubator-beam/downloads","issues_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/kennknowles/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/kennknowles/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/kennknowles/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennknowles/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/kennknowles/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/kennknowles/incubator-beam/deployments","created_at":"2016-02-27T02:37:09Z","updated_at":"2016-02-27T02:37:12Z","pushed_at":"2016-11-15T04:37:50Z","git_url":"git://github.com/kennknowles/incubator-beam.git","ssh_url":"git@github.com:kennknowles/incubator-beam.git","clone_url":"https://github.com/kennknowles/incubator-beam.git","svn_url":"https://github.com/kennknowles/incubator-beam","homepage":null,"size":21419,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8bfa0851930f38fd1f63b3b17b7fb15f0f88beda","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-11-15T01:58:50Z","pushed_at":"2016-11-15T04:37:51Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":35579,"stargazers_count":463,"watchers_count":463,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":278,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":63,"forks":278,"open_issues":63,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1307"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1307"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1307"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1307/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1307/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1307/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/e9c4160887eac765dcdf1b34ac46d742c0581f44"}}}}
{"actor":{"display_login":"kennknowles"}}