{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1183","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1183/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1183/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1183/events","html_url":"https://github.com/solidusio/solidus/pull/1183","id":156544271,"number":1183,"title":"Spree::Config.send_core_emails supports :only and :except","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-24T15:54:20Z","updated_at":"2016-06-01T17:00:40Z","closed_at":"2016-06-01T17:00:40Z","pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1183","html_url":"https://github.com/solidusio/solidus/pull/1183","diff_url":"https://github.com/solidusio/solidus/pull/1183.diff","patch_url":"https://github.com/solidusio/solidus/pull/1183.patch"},"body":"Previously send_core_emails could be true or false. Now it\nalso supports a Hash with :only and/or :except, to turn off\nmailing for certain Mailers only. \n\nThe existing test for send_core_emails in order_mailer_spec\nwas actually a false positive, it would have returned\ntrue even if send_core_emails=true, because a multi-part\nemail has no #body. The new specs have been moved to a\nbase_mailer_spec, and the one existing spec rewritten\nto actually spec the right thing, with some kind of\nhacky shared examples that seem to test actual situation\nwhen #mail is called or not."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/223057931","html_url":"https://github.com/solidusio/solidus/pull/1183#issuecomment-223057931","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1183","id":223057931,"user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T17:00:40Z","updated_at":"2016-06-01T17:00:40Z","body":"i've got an idea for an EmailDispatcher, I agree that's a better way to do it, I'll try to PR that soon. \r\n\r\nIt probably shouldn't be called `EmailDispatcher`, probably shouldn't even have the word `email` in it -- it could hypothetically be switched out for something that sends these notifications via other or additional methods too (txt message, slack, carrier pigeon). Any ideas for a name? "}}
{"actor":{"display_login":"jrochkind"}}