{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/94099059","pull_request_review_id":14629515,"id":94099059,"diff_hunk":"@@ -23,28 +18,32 @@ class GlossaryModal extends React.Component {\n     let element;\n     if (this.props.isVisible) {","path":"src/js/rx/components/GlossaryModal.jsx","position":22,"original_position":22,"commit_id":"695b8ac68fc52a672074745c860f65e3113bc998","original_commit_id":"695b8ac68fc52a672074745c860f65e3113bc998","user":{"login":"U-DON","id":1067024,"avatar_url":"https://avatars.githubusercontent.com/u/1067024?v=3","gravatar_id":"","url":"https://api.github.com/users/U-DON","html_url":"https://github.com/U-DON","followers_url":"https://api.github.com/users/U-DON/followers","following_url":"https://api.github.com/users/U-DON/following{/other_user}","gists_url":"https://api.github.com/users/U-DON/gists{/gist_id}","starred_url":"https://api.github.com/users/U-DON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/U-DON/subscriptions","organizations_url":"https://api.github.com/users/U-DON/orgs","repos_url":"https://api.github.com/users/U-DON/repos","events_url":"https://api.github.com/users/U-DON/events{/privacy}","received_events_url":"https://api.github.com/users/U-DON/received_events","type":"User","site_admin":false},"body":"This should probably be added to the propTypes, but I've also noticed before that it'd be redundant to do handling around the visibility of the modal when Modal already does that.\r\n\r\nAnd looking at the propTypes of Modal, it doesn't seem like we should require the content, since most use cases have an initially hidden modal that doesn't have content.\r\n\r\nAnyway, just a couple of thoughts on how the apps are using modals, and not something that needs to change for this PR.","created_at":"2016-12-29T03:32:31Z","updated_at":"2016-12-29T03:32:57Z","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522#discussion_r94099059","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/94099059"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522#discussion_r94099059"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522","id":99607836,"html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/4522","number":4522,"state":"open","locked":false,"title":"Use common modal component for glossary modal","user":{"login":"bshyong","id":303289,"avatar_url":"https://avatars.githubusercontent.com/u/303289?v=3","gravatar_id":"","url":"https://api.github.com/users/bshyong","html_url":"https://github.com/bshyong","followers_url":"https://api.github.com/users/bshyong/followers","following_url":"https://api.github.com/users/bshyong/following{/other_user}","gists_url":"https://api.github.com/users/bshyong/gists{/gist_id}","starred_url":"https://api.github.com/users/bshyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bshyong/subscriptions","organizations_url":"https://api.github.com/users/bshyong/orgs","repos_url":"https://api.github.com/users/bshyong/repos","events_url":"https://api.github.com/users/bshyong/events{/privacy}","received_events_url":"https://api.github.com/users/bshyong/received_events","type":"User","site_admin":false},"body":"- Resolves #4517","created_at":"2016-12-29T00:53:32Z","updated_at":"2016-12-29T03:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99ab38400e2a4bd5d1db9bd20304f84e32db7a0c","assignee":{"login":"U-DON","id":1067024,"avatar_url":"https://avatars.githubusercontent.com/u/1067024?v=3","gravatar_id":"","url":"https://api.github.com/users/U-DON","html_url":"https://github.com/U-DON","followers_url":"https://api.github.com/users/U-DON/followers","following_url":"https://api.github.com/users/U-DON/following{/other_user}","gists_url":"https://api.github.com/users/U-DON/gists{/gist_id}","starred_url":"https://api.github.com/users/U-DON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/U-DON/subscriptions","organizations_url":"https://api.github.com/users/U-DON/orgs","repos_url":"https://api.github.com/users/U-DON/repos","events_url":"https://api.github.com/users/U-DON/events{/privacy}","received_events_url":"https://api.github.com/users/U-DON/received_events","type":"User","site_admin":false},"assignees":[{"login":"U-DON","id":1067024,"avatar_url":"https://avatars.githubusercontent.com/u/1067024?v=3","gravatar_id":"","url":"https://api.github.com/users/U-DON","html_url":"https://github.com/U-DON","followers_url":"https://api.github.com/users/U-DON/followers","following_url":"https://api.github.com/users/U-DON/following{/other_user}","gists_url":"https://api.github.com/users/U-DON/gists{/gist_id}","starred_url":"https://api.github.com/users/U-DON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/U-DON/subscriptions","organizations_url":"https://api.github.com/users/U-DON/orgs","repos_url":"https://api.github.com/users/U-DON/repos","events_url":"https://api.github.com/users/U-DON/events{/privacy}","received_events_url":"https://api.github.com/users/U-DON/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/4522/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/695b8ac68fc52a672074745c860f65e3113bc998","head":{"label":"department-of-veterans-affairs:resolve-4517","ref":"resolve-4517","sha":"695b8ac68fc52a672074745c860f65e3113bc998","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Beta version of Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2016-12-24T09:54:24Z","pushed_at":"2016-12-29T02:25:20Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":105893,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":186,"forks":40,"open_issues":186,"watchers":73,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"929bc4c8ead53a4b7142af182301d674e4228940","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Beta version of Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2016-12-24T09:54:24Z","pushed_at":"2016-12-29T02:25:20Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":105893,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":186,"forks":40,"open_issues":186,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/4522"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/4522"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/4522/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/4522/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/695b8ac68fc52a672074745c860f65e3113bc998"}}}}
{"actor":{"display_login":"U-DON"}}