{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/58170735","id":58170735,"diff_hunk":"@@ -4957,13 +4959,13 @@ void DesignHasPartClass::Eval(const ScriptingContext& parent_context,\n }\n \n bool DesignHasPartClass::RootCandidateInvariant() const\n-{ return (m_low->RootCandidateInvariant() && m_high->RootCandidateInvariant()); }\n+{ return (m_low && m_high ? m_low->RootCandidateInvariant() && m_high->RootCandidateInvariant() : false); }","path":"universe/Condition.cpp","position":21,"original_position":21,"commit_id":"2b146ffb8057d66e03b1cfb214e32f31ec426da4","original_commit_id":"2b146ffb8057d66e03b1cfb214e32f31ec426da4","user":{"login":"geoffthemedio","id":11386908,"avatar_url":"https://avatars.githubusercontent.com/u/11386908?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffthemedio","html_url":"https://github.com/geoffthemedio","followers_url":"https://api.github.com/users/geoffthemedio/followers","following_url":"https://api.github.com/users/geoffthemedio/following{/other_user}","gists_url":"https://api.github.com/users/geoffthemedio/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffthemedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffthemedio/subscriptions","organizations_url":"https://api.github.com/users/geoffthemedio/orgs","repos_url":"https://api.github.com/users/geoffthemedio/repos","events_url":"https://api.github.com/users/geoffthemedio/events{/privacy}","received_events_url":"https://api.github.com/users/geoffthemedio/received_events","type":"User","site_admin":false},"body":"need more complicated logic here to handle presence or absense of either independnetly. and if both aren't there, then it should return true.","created_at":"2016-04-01T07:28:32Z","updated_at":"2016-04-01T07:28:32Z","html_url":"https://github.com/freeorion/freeorion/pull/578#discussion_r58170735","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/58170735"},"html":{"href":"https://github.com/freeorion/freeorion/pull/578#discussion_r58170735"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/578","id":64712285,"html_url":"https://github.com/freeorion/freeorion/pull/578","diff_url":"https://github.com/freeorion/freeorion/pull/578.diff","patch_url":"https://github.com/freeorion/freeorion/pull/578.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/578","number":578,"state":"open","locked":false,"title":"STATIC_CODE_ANALYSIS_FIXES","user":{"login":"matthoppe","id":14843880,"avatar_url":"https://avatars.githubusercontent.com/u/14843880?v=3","gravatar_id":"","url":"https://api.github.com/users/matthoppe","html_url":"https://github.com/matthoppe","followers_url":"https://api.github.com/users/matthoppe/followers","following_url":"https://api.github.com/users/matthoppe/following{/other_user}","gists_url":"https://api.github.com/users/matthoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/matthoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthoppe/subscriptions","organizations_url":"https://api.github.com/users/matthoppe/orgs","repos_url":"https://api.github.com/users/matthoppe/repos","events_url":"https://api.github.com/users/matthoppe/events{/privacy}","received_events_url":"https://api.github.com/users/matthoppe/received_events","type":"User","site_admin":false},"body":"Minor code adjustments to handle null pointer dereferences and some copy and paste errors.","created_at":"2016-03-30T23:12:32Z","updated_at":"2016-04-01T07:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8b9d55e8d0edb5fc179df43fc3fb1d2b2f49af2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/578/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/578/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/578/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/2b146ffb8057d66e03b1cfb214e32f31ec426da4","head":{"label":"matthoppe:null_pointer_fixes","ref":"null_pointer_fixes","sha":"2b146ffb8057d66e03b1cfb214e32f31ec426da4","user":{"login":"matthoppe","id":14843880,"avatar_url":"https://avatars.githubusercontent.com/u/14843880?v=3","gravatar_id":"","url":"https://api.github.com/users/matthoppe","html_url":"https://github.com/matthoppe","followers_url":"https://api.github.com/users/matthoppe/followers","following_url":"https://api.github.com/users/matthoppe/following{/other_user}","gists_url":"https://api.github.com/users/matthoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/matthoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthoppe/subscriptions","organizations_url":"https://api.github.com/users/matthoppe/orgs","repos_url":"https://api.github.com/users/matthoppe/repos","events_url":"https://api.github.com/users/matthoppe/events{/privacy}","received_events_url":"https://api.github.com/users/matthoppe/received_events","type":"User","site_admin":false},"repo":{"id":54163663,"name":"freeorion","full_name":"matthoppe/freeorion","owner":{"login":"matthoppe","id":14843880,"avatar_url":"https://avatars.githubusercontent.com/u/14843880?v=3","gravatar_id":"","url":"https://api.github.com/users/matthoppe","html_url":"https://github.com/matthoppe","followers_url":"https://api.github.com/users/matthoppe/followers","following_url":"https://api.github.com/users/matthoppe/following{/other_user}","gists_url":"https://api.github.com/users/matthoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/matthoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthoppe/subscriptions","organizations_url":"https://api.github.com/users/matthoppe/orgs","repos_url":"https://api.github.com/users/matthoppe/repos","events_url":"https://api.github.com/users/matthoppe/events{/privacy}","received_events_url":"https://api.github.com/users/matthoppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthoppe/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/matthoppe/freeorion","forks_url":"https://api.github.com/repos/matthoppe/freeorion/forks","keys_url":"https://api.github.com/repos/matthoppe/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthoppe/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthoppe/freeorion/teams","hooks_url":"https://api.github.com/repos/matthoppe/freeorion/hooks","issue_events_url":"https://api.github.com/repos/matthoppe/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/matthoppe/freeorion/events","assignees_url":"https://api.github.com/repos/matthoppe/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/matthoppe/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/matthoppe/freeorion/tags","blobs_url":"https://api.github.com/repos/matthoppe/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthoppe/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthoppe/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthoppe/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthoppe/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/matthoppe/freeorion/languages","stargazers_url":"https://api.github.com/repos/matthoppe/freeorion/stargazers","contributors_url":"https://api.github.com/repos/matthoppe/freeorion/contributors","subscribers_url":"https://api.github.com/repos/matthoppe/freeorion/subscribers","subscription_url":"https://api.github.com/repos/matthoppe/freeorion/subscription","commits_url":"https://api.github.com/repos/matthoppe/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthoppe/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthoppe/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthoppe/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthoppe/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/matthoppe/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthoppe/freeorion/merges","archive_url":"https://api.github.com/repos/matthoppe/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthoppe/freeorion/downloads","issues_url":"https://api.github.com/repos/matthoppe/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/matthoppe/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/matthoppe/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/matthoppe/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthoppe/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/matthoppe/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/matthoppe/freeorion/deployments","created_at":"2016-03-18T01:37:25Z","updated_at":"2016-03-18T01:37:31Z","pushed_at":"2016-03-30T23:09:39Z","git_url":"git://github.com/matthoppe/freeorion.git","ssh_url":"git@github.com:matthoppe/freeorion.git","clone_url":"https://github.com/matthoppe/freeorion.git","svn_url":"https://github.com/matthoppe/freeorion","homepage":"http://www.freeorion.org/","size":514466,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"a190c023ed83b238c65448e9512cf3071ea93fdb","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2016-03-31T18:06:57Z","pushed_at":"2016-04-01T07:10:24Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":532863,"stargazers_count":135,"watchers_count":135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":48,"forks":55,"open_issues":48,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/578"},"html":{"href":"https://github.com/freeorion/freeorion/pull/578"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/578"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/2b146ffb8057d66e03b1cfb214e32f31ec426da4"}}}}