{"action":"created","comment":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/71707383","id":71707383,"diff_hunk":"@@ -180,15 +160,63 @@ define('Scene/Scene', [\n         this.gfxEngine.update();\n     };\n \n-    Scene.prototype.wait = function(timeWait) {\n+    /**\n+     * Notifies the scene it needs to be updated due to changes exterior to the\n+     * scene itself (e.g. camera movement).\n+     */\n+    Scene.prototype.notifyChange = function() {\n+        this.needsUpdate = true;\n+        // request new frame in case the rendering loop was on hold\n+        // force rendering to ensure interactivity\n+        requestAnimationFrame(function(timestamp) { this.step(timestamp, true); }.bind(this));\n+    };\n \n-        var waitTime = timeWait ? timeWait: 20;\n+    /**\n+     * Subdivide layers and clean them if necessary\n+     */\n+    Scene.prototype.processLayers = function() {","path":"src/Scene/Scene.js","position":103,"original_position":103,"commit_id":"bf550d8489afdd14d5cedb3631914d4127b56ee9","original_commit_id":"bf550d8489afdd14d5cedb3631914d4127b56ee9","user":{"login":"Jeremy-Gaillard","id":1814191,"avatar_url":"https://avatars.githubusercontent.com/u/1814191?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeremy-Gaillard","html_url":"https://github.com/Jeremy-Gaillard","followers_url":"https://api.github.com/users/Jeremy-Gaillard/followers","following_url":"https://api.github.com/users/Jeremy-Gaillard/following{/other_user}","gists_url":"https://api.github.com/users/Jeremy-Gaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremy-Gaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremy-Gaillard/subscriptions","organizations_url":"https://api.github.com/users/Jeremy-Gaillard/orgs","repos_url":"https://api.github.com/users/Jeremy-Gaillard/repos","events_url":"https://api.github.com/users/Jeremy-Gaillard/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremy-Gaillard/received_events","type":"User","site_admin":false},"body":"I'll try to find better names.\r\nupdateLayers updates the state of the layer for visualisation (tile visibility, sse...)\r\nprocessLayers creates commands and cleans the quadtree.","created_at":"2016-07-21T13:46:57Z","updated_at":"2016-07-21T13:46:57Z","html_url":"https://github.com/iTowns/itowns2/pull/141#discussion_r71707383","pull_request_url":"https://api.github.com/repos/iTowns/itowns2/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/71707383"},"html":{"href":"https://github.com/iTowns/itowns2/pull/141#discussion_r71707383"},"pull_request":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/141","id":76621373,"html_url":"https://github.com/iTowns/itowns2/pull/141","diff_url":"https://github.com/iTowns/itowns2/pull/141.diff","patch_url":"https://github.com/iTowns/itowns2/pull/141.patch","issue_url":"https://api.github.com/repos/iTowns/itowns2/issues/141","number":141,"state":"open","locked":false,"title":"Use requestAnimationFrame for update loop","user":{"login":"Jeremy-Gaillard","id":1814191,"avatar_url":"https://avatars.githubusercontent.com/u/1814191?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeremy-Gaillard","html_url":"https://github.com/Jeremy-Gaillard","followers_url":"https://api.github.com/users/Jeremy-Gaillard/followers","following_url":"https://api.github.com/users/Jeremy-Gaillard/following{/other_user}","gists_url":"https://api.github.com/users/Jeremy-Gaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremy-Gaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremy-Gaillard/subscriptions","organizations_url":"https://api.github.com/users/Jeremy-Gaillard/orgs","repos_url":"https://api.github.com/users/Jeremy-Gaillard/repos","events_url":"https://api.github.com/users/Jeremy-Gaillard/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremy-Gaillard/received_events","type":"User","site_admin":false},"body":"Replaced setTimeout by requestAnimationFrame.\r\n\r\nRemoved calls to scene update (scene.wait()) from managerCommands and c3Dengine and clarified the update mechanism.","created_at":"2016-07-07T15:59:53Z","updated_at":"2016-07-21T13:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"908d6bc3071b60e65c7a072eeb69dbd5200feee9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/iTowns/itowns2/pulls/141/commits","review_comments_url":"https://api.github.com/repos/iTowns/itowns2/pulls/141/comments","review_comment_url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iTowns/itowns2/issues/141/comments","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/bf550d8489afdd14d5cedb3631914d4127b56ee9","head":{"label":"iTowns:updateLoop","ref":"updateLoop","sha":"bf550d8489afdd14d5cedb3631914d4127b56ee9","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-07-19T13:18:05Z","pushed_at":"2016-07-21T11:32:01Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":62480,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":89,"forks":11,"open_issues":89,"watchers":13,"default_branch":"master"}},"base":{"label":"iTowns:master","ref":"master","sha":"0cbdd7265c355f80a4fad8c1d020d7bd546a034c","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-07-19T13:18:05Z","pushed_at":"2016-07-21T11:32:01Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":62480,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":89,"forks":11,"open_issues":89,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/141"},"html":{"href":"https://github.com/iTowns/itowns2/pull/141"},"issue":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/141"},"comments":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/iTowns/itowns2/statuses/bf550d8489afdd14d5cedb3631914d4127b56ee9"}}}}
{"actor":{"display_login":"Jeremy-Gaillard"}}