{"action":"created","issue":{"url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/291","repository_url":"https://api.github.com/repos/PHPOffice/PHPExcel","labels_url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/291/labels{/name}","comments_url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/291/comments","events_url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/291/events","html_url":"https://github.com/PHPOffice/PHPExcel/pull/291","id":24676595,"number":291,"title":"Mark all failing unit tests to be skipped","user":{"login":"PowerKiKi","id":72603,"avatar_url":"https://avatars.githubusercontent.com/u/72603?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerKiKi","html_url":"https://github.com/PowerKiKi","followers_url":"https://api.github.com/users/PowerKiKi/followers","following_url":"https://api.github.com/users/PowerKiKi/following{/other_user}","gists_url":"https://api.github.com/users/PowerKiKi/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerKiKi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerKiKi/subscriptions","organizations_url":"https://api.github.com/users/PowerKiKi/orgs","repos_url":"https://api.github.com/users/PowerKiKi/repos","events_url":"https://api.github.com/users/PowerKiKi/events{/privacy}","received_events_url":"https://api.github.com/users/PowerKiKi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PHPOffice/PHPExcel/labels/Source%20-%20Pull%20Request","name":"Source - Pull Request","color":"0b02e1"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2013-12-22T06:37:20Z","updated_at":"2016-05-20T03:21:22Z","closed_at":"2016-05-19T12:33:06Z","pull_request":{"url":"https://api.github.com/repos/PHPOffice/PHPExcel/pulls/291","html_url":"https://github.com/PHPOffice/PHPExcel/pull/291","diff_url":"https://github.com/PHPOffice/PHPExcel/pull/291.diff","patch_url":"https://github.com/PHPOffice/PHPExcel/pull/291.patch"},"body":"This allow us to start on a clean state, to progressively fix existing\r\nfailing tests and add new tests easily. All of that while ensuring that\r\nwe don't introduce regressions.\r\n\r\nI would recommend merging this as soon as possible to have clean state for further development.\r\n\r\nAlso, as you can see on my Travis (https://travis-ci.org/PowerKiKi/PHPExcel/builds/15840389) PHP 5.2 is the only version that fails. I would drop support for that version by modyfing `.travis` file. But that may be too drastic and not in line with PHPExcel roadmap ..."},"comment":{"url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/comments/220508096","html_url":"https://github.com/PHPOffice/PHPExcel/pull/291#issuecomment-220508096","issue_url":"https://api.github.com/repos/PHPOffice/PHPExcel/issues/291","id":220508096,"user":{"login":"PowerKiKi","id":72603,"avatar_url":"https://avatars.githubusercontent.com/u/72603?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerKiKi","html_url":"https://github.com/PowerKiKi","followers_url":"https://api.github.com/users/PowerKiKi/followers","following_url":"https://api.github.com/users/PowerKiKi/following{/other_user}","gists_url":"https://api.github.com/users/PowerKiKi/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerKiKi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerKiKi/subscriptions","organizations_url":"https://api.github.com/users/PowerKiKi/orgs","repos_url":"https://api.github.com/users/PowerKiKi/repos","events_url":"https://api.github.com/users/PowerKiKi/events{/privacy}","received_events_url":"https://api.github.com/users/PowerKiKi/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T03:21:22Z","updated_at":"2016-05-20T03:21:22Z","body":"@Progi1984 I see that they are still +100 failing tests on Travis for any given PHP versions. What is the strategy for those ? If they are not skipped, as suggested, it will only add noise for newly implemented tests or newly failing tests. \r\n\r\nI'd go as far as to say that the situation got worse since the time I created this PR. It used to be only ~50 failing tests. And now it is more than twice that.\r\n\r\nObviously the best way to go is to fix all of them at once. But this will take (a lot of) time and meanwhile the situation will degrade even further.\r\n\r\nWhat are you thoughts on that ?"}}
{"actor":{"display_login":"PowerKiKi"}}