{"action":"created","issue":{"url":"https://api.github.com/repos/jbehley/octree/issues/3","repository_url":"https://api.github.com/repos/jbehley/octree","labels_url":"https://api.github.com/repos/jbehley/octree/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/jbehley/octree/issues/3/comments","events_url":"https://api.github.com/repos/jbehley/octree/issues/3/events","html_url":"https://github.com/jbehley/octree/issues/3","id":194248330,"number":3,"title":"Bug in overlaps method","user":{"login":"SylvainBertrand","id":15932806,"avatar_url":"https://avatars.githubusercontent.com/u/15932806?v=3","gravatar_id":"","url":"https://api.github.com/users/SylvainBertrand","html_url":"https://github.com/SylvainBertrand","followers_url":"https://api.github.com/users/SylvainBertrand/followers","following_url":"https://api.github.com/users/SylvainBertrand/following{/other_user}","gists_url":"https://api.github.com/users/SylvainBertrand/gists{/gist_id}","starred_url":"https://api.github.com/users/SylvainBertrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SylvainBertrand/subscriptions","organizations_url":"https://api.github.com/users/SylvainBertrand/orgs","repos_url":"https://api.github.com/users/SylvainBertrand/repos","events_url":"https://api.github.com/users/SylvainBertrand/events{/privacy}","received_events_url":"https://api.github.com/users/SylvainBertrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jbehley","id":11506664,"avatar_url":"https://avatars.githubusercontent.com/u/11506664?v=3","gravatar_id":"","url":"https://api.github.com/users/jbehley","html_url":"https://github.com/jbehley","followers_url":"https://api.github.com/users/jbehley/followers","following_url":"https://api.github.com/users/jbehley/following{/other_user}","gists_url":"https://api.github.com/users/jbehley/gists{/gist_id}","starred_url":"https://api.github.com/users/jbehley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbehley/subscriptions","organizations_url":"https://api.github.com/users/jbehley/orgs","repos_url":"https://api.github.com/users/jbehley/repos","events_url":"https://api.github.com/users/jbehley/events{/privacy}","received_events_url":"https://api.github.com/users/jbehley/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbehley","id":11506664,"avatar_url":"https://avatars.githubusercontent.com/u/11506664?v=3","gravatar_id":"","url":"https://api.github.com/users/jbehley","html_url":"https://github.com/jbehley","followers_url":"https://api.github.com/users/jbehley/followers","following_url":"https://api.github.com/users/jbehley/following{/other_user}","gists_url":"https://api.github.com/users/jbehley/gists{/gist_id}","starred_url":"https://api.github.com/users/jbehley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbehley/subscriptions","organizations_url":"https://api.github.com/users/jbehley/orgs","repos_url":"https://api.github.com/users/jbehley/repos","events_url":"https://api.github.com/users/jbehley/events{/privacy}","received_events_url":"https://api.github.com/users/jbehley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-08T05:07:54Z","updated_at":"2016-12-08T11:08:06Z","closed_at":null,"body":"Hi!\r\nThanks a lot for sharing your code!!\r\n\r\nI believe there is a bug with the method overlaps.\r\nMore precisely in Octree.hpp line 722:  \"if (x < o->extent || y < o->extent || z < o->extent) return true;\"\r\nThe concept seems correct in 2D, however in 3D, at least two of the three conditions have to be valid at the same time to be able to return true.\r\n\r\nA simple example revealing the bug is the following:\r\nquery = (x = 0.025, y = 0.025, 0.025)\r\nradius = 0.025\r\noctant_center = (x = 0.025, y = -0.025, z = -0.025)\r\noctant_extent = 0.025\r\n\r\nWhen displaying the octant and the sphere, it is clear that the sphere does not overlap with the octant although the overlaps method returns true.\r\n"},"comment":{"url":"https://api.github.com/repos/jbehley/octree/issues/comments/265715047","html_url":"https://github.com/jbehley/octree/issues/3#issuecomment-265715047","issue_url":"https://api.github.com/repos/jbehley/octree/issues/3","id":265715047,"user":{"login":"jbehley","id":11506664,"avatar_url":"https://avatars.githubusercontent.com/u/11506664?v=3","gravatar_id":"","url":"https://api.github.com/users/jbehley","html_url":"https://github.com/jbehley","followers_url":"https://api.github.com/users/jbehley/followers","following_url":"https://api.github.com/users/jbehley/following{/other_user}","gists_url":"https://api.github.com/users/jbehley/gists{/gist_id}","starred_url":"https://api.github.com/users/jbehley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbehley/subscriptions","organizations_url":"https://api.github.com/users/jbehley/orgs","repos_url":"https://api.github.com/users/jbehley/repos","events_url":"https://api.github.com/users/jbehley/events{/privacy}","received_events_url":"https://api.github.com/users/jbehley/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T11:08:06Z","updated_at":"2016-12-08T11:08:06Z","body":"Hi @SylvainBertrand,\r\n\r\nthanks for your interest in my Octree implementation and thanks for pointing out this issue! You are  totally correct and that's a case I didn't considered in my derivation in the paper. I'm working on a fix and will hopefully fix this issue soon. So stay tuned.\r\n\r\nFrom my initial experiments and understanding of this issue, it seems that it should still result in the correct neighbor results, but should have an influence on the runtime, of course. Currently, it seems like that I'm just testing more then necessary. So after fixing this issue, the runtime should be better. \r\n\r\nBut let's first see if I find a simple and elegant fix for this issue without altering the code to much.\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"jbehley"}}