{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/82063442","pull_request_review_id":2996105,"id":82063442,"diff_hunk":"@@ -6656,6 +6656,54 @@ def test_local_useless_alloc():\n     assert isinstance(topo[-1].op, T.Alloc)\n \n \n+def test_local_log_sum_exp1():\n+    # Tests if optimization is applied\n+    x = matrix('x')\n+    y = T.log(T.sum(T.exp(x), axis=1))","path":"theano/tensor/tests/test_opt.py","position":7,"original_position":7,"commit_id":"8eaa12f2c3a86460634a4d3030a81276a02ce8e9","original_commit_id":"8eaa12f2c3a86460634a4d3030a81276a02ce8e9","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"We should test with:\r\n- axes other than the last\r\n- multiple axes\r\n- sum with and without `keepdims`\r\n- more dimensions than 2, and a dimshuffle after the sum, for instance `T.log(T.sum(T.exp(t3), axis=1).T)`\r\n\r\nAnd make sure the tests pass with DebugMode.","created_at":"2016-10-05T20:30:49Z","updated_at":"2016-10-05T20:31:03Z","html_url":"https://github.com/Theano/Theano/pull/4736#discussion_r82063442","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4736","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/82063442"},"html":{"href":"https://github.com/Theano/Theano/pull/4736#discussion_r82063442"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4736"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4736","id":77331289,"html_url":"https://github.com/Theano/Theano/pull/4736","diff_url":"https://github.com/Theano/Theano/pull/4736.diff","patch_url":"https://github.com/Theano/Theano/pull/4736.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4736","number":4736,"state":"open","locked":false,"title":"Log sum exp optimization for numerical stability","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"body":"Ticket #1563, @mgermain ","created_at":"2016-07-13T17:44:04Z","updated_at":"2016-10-05T20:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dbebbfad568c63cc21467868057d4acdd52d28a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4736/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4736/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4736/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/8eaa12f2c3a86460634a4d3030a81276a02ce8e9","head":{"label":"adbrebs:logSumExp","ref":"logSumExp","sha":"8eaa12f2c3a86460634a4d3030a81276a02ce8e9","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"repo":{"id":29032332,"name":"Theano","full_name":"adbrebs/Theano","owner":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adbrebs/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/adbrebs/Theano","forks_url":"https://api.github.com/repos/adbrebs/Theano/forks","keys_url":"https://api.github.com/repos/adbrebs/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adbrebs/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adbrebs/Theano/teams","hooks_url":"https://api.github.com/repos/adbrebs/Theano/hooks","issue_events_url":"https://api.github.com/repos/adbrebs/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/adbrebs/Theano/events","assignees_url":"https://api.github.com/repos/adbrebs/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/adbrebs/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/adbrebs/Theano/tags","blobs_url":"https://api.github.com/repos/adbrebs/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adbrebs/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adbrebs/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/adbrebs/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adbrebs/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/adbrebs/Theano/languages","stargazers_url":"https://api.github.com/repos/adbrebs/Theano/stargazers","contributors_url":"https://api.github.com/repos/adbrebs/Theano/contributors","subscribers_url":"https://api.github.com/repos/adbrebs/Theano/subscribers","subscription_url":"https://api.github.com/repos/adbrebs/Theano/subscription","commits_url":"https://api.github.com/repos/adbrebs/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/adbrebs/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/adbrebs/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/adbrebs/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/adbrebs/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/adbrebs/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adbrebs/Theano/merges","archive_url":"https://api.github.com/repos/adbrebs/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adbrebs/Theano/downloads","issues_url":"https://api.github.com/repos/adbrebs/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/adbrebs/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/adbrebs/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/adbrebs/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adbrebs/Theano/labels{/name}","releases_url":"https://api.github.com/repos/adbrebs/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/adbrebs/Theano/deployments","created_at":"2015-01-09T19:45:48Z","updated_at":"2016-01-22T15:17:00Z","pushed_at":"2016-10-04T14:25:47Z","git_url":"git://github.com/adbrebs/Theano.git","ssh_url":"git@github.com:adbrebs/Theano.git","clone_url":"https://github.com/adbrebs/Theano.git","svn_url":"https://github.com/adbrebs/Theano","homepage":"http://www.deeplearning.net/software/theano","size":58396,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"58e93f9b94113d39fab7da6aefaf354cddead2e1","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-10-05T18:22:21Z","pushed_at":"2016-10-05T18:00:28Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":78076,"stargazers_count":4674,"watchers_count":4674,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1657,"mirror_url":null,"open_issues_count":710,"forks":1657,"open_issues":710,"watchers":4674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4736"},"html":{"href":"https://github.com/Theano/Theano/pull/4736"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4736"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4736/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4736/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4736/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/8eaa12f2c3a86460634a4d3030a81276a02ce8e9"}}}}
{"actor":{"display_login":"lamblin"}}