{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/1390","repository_url":"https://api.github.com/repos/NLog/NLog","labels_url":"https://api.github.com/repos/NLog/NLog/issues/1390/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1390/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/1390/events","html_url":"https://github.com/NLog/NLog/pull/1390","id":150139245,"number":1390,"title":"Hierarchical config support for targets","user":{"login":"luigiberrettini","id":4513301,"avatar_url":"https://avatars.githubusercontent.com/u/4513301?v=3","gravatar_id":"","url":"https://api.github.com/users/luigiberrettini","html_url":"https://github.com/luigiberrettini","followers_url":"https://api.github.com/users/luigiberrettini/followers","following_url":"https://api.github.com/users/luigiberrettini/following{/other_user}","gists_url":"https://api.github.com/users/luigiberrettini/gists{/gist_id}","starred_url":"https://api.github.com/users/luigiberrettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigiberrettini/subscriptions","organizations_url":"https://api.github.com/users/luigiberrettini/orgs","repos_url":"https://api.github.com/users/luigiberrettini/repos","events_url":"https://api.github.com/users/luigiberrettini/events{/privacy}","received_events_url":"https://api.github.com/users/luigiberrettini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-04-21T17:24:51Z","updated_at":"2016-04-22T15:10:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1390","html_url":"https://github.com/NLog/NLog/pull/1390","diff_url":"https://github.com/NLog/NLog/pull/1390.diff","patch_url":"https://github.com/NLog/NLog/pull/1390.patch"},"body":"I simply added the _SetItemFromElement_ method in _XmlLoggingConfiguration_ so that _SetPropertyFromElement_ calls it when parsing the configuration\r\nI then added a test and the needed fake Target.\r\n\r\n**NLog version**\r\n4.3.0\r\n\r\n**Work arounds**\r\nNone\r\n\r\n**Config when implemented**\r\nTake a look at [my Syslog target fork] (https://github.com/luigiberrettini/NLog.Targets.Syslog/blob/master/src/TestApp/NLog.config)\r\nThe GitHub version of the target does not work because it references the official NuGet package of NLog 4.3.0 (I tested it locally with the changes to NLog included in this PR)\r\n```xml\r\n    <target xsi:type=\"syslog:Syslog\" name=\"syslog5424-tgt\">\r\n      <syslog:layout xsi:type=\"SimpleLayout\" text=\"${message} ${exception:format=ToString,StackTrace}\" />\r\n      <syslog:sysLogServer>127.0.0.1</syslog:sysLogServer>\r\n      <syslog:port>1514</syslog:port>\r\n      <syslog:facility>Local4</syslog:facility>\r\n      <syslog:protocol>UDP</syslog:protocol>\r\n      <syslog:ssl>false</syslog:ssl>\r\n      <syslog:splitNewlines>false</syslog:splitNewlines>\r\n      <syslog:rfc>Rfc5424</syslog:rfc>\r\n      <syslog:rfc3164 hostname=\"notUsedHostname\" tag=\"notUsedTag\" />\r\n      <syslog:rfc5424 protocolVersion=\"1\" hostname=\"${machinename}\" appName=\"${logger}\" procId=\"${processid}\" msgId=\"testMsgId\">\r\n        <syslog:structuredData>\r\n          <syslog:sdElement sdId=\"thread@${enterpriseId}\">\r\n            <syslog:sdParam name=\"id\" value=\"${threadid}\" />\r\n            <syslog:sdParam name=\"myParam\" value=\"myValue\" />\r\n          </syslog:sdElement>\r\n          <syslog:sdElement sdId=\"timeQuality\">\r\n            <syslog:sdParam name=\"tzKnown\" value=\"1\" />\r\n            <syslog:sdParam name=\"isSynced\" value=\"1\" />\r\n            <syslog:sdParam name=\"syncAccuracy\" value=\"60000000\" />\r\n          </syslog:sdElement>\r\n          <syslog:sdElement sdId=\"origin\">\r\n            <syslog:sdParam name=\"ip\" value=\"10.10.10.1\" />\r\n            <syslog:sdParam name=\"ip\" value=\"192.0.2.1\" />\r\n            <syslog:sdParam name=\"enterpriseId\" value=\"${enterpriseId}\" />\r\n            <syslog:sdParam name=\"software\" value=\"MyAmazingSw\" />\r\n            <syslog:sdParam name=\"swVersion\" value=\"3.5\" />\r\n          </syslog:sdElement>\r\n          <syslog:sdElement sdId=\"meta\">\r\n            <syslog:sdParam name=\"sequenceId\" value=\"${sequenceId}\" />\r\n            <syslog:sdParam name=\"sysUpTime\" value=\"30200\" />\r\n            <syslog:sdParam name=\"language\" value=\"en-US\" />\r\n          </syslog:sdElement>\r\n        </syslog:structuredData>\r\n      </syslog:rfc5424>\r\n    </target>\r\n```"},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/213467485","html_url":"https://github.com/NLog/NLog/pull/1390#issuecomment-213467485","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1390","id":213467485,"user":{"login":"luigiberrettini","id":4513301,"avatar_url":"https://avatars.githubusercontent.com/u/4513301?v=3","gravatar_id":"","url":"https://api.github.com/users/luigiberrettini","html_url":"https://github.com/luigiberrettini","followers_url":"https://api.github.com/users/luigiberrettini/followers","following_url":"https://api.github.com/users/luigiberrettini/following{/other_user}","gists_url":"https://api.github.com/users/luigiberrettini/gists{/gist_id}","starred_url":"https://api.github.com/users/luigiberrettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigiberrettini/subscriptions","organizations_url":"https://api.github.com/users/luigiberrettini/orgs","repos_url":"https://api.github.com/users/luigiberrettini/repos","events_url":"https://api.github.com/users/luigiberrettini/events{/privacy}","received_events_url":"https://api.github.com/users/luigiberrettini/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T15:10:52Z","updated_at":"2016-04-22T15:10:52Z","body":"I put he classes in the same file of the tests.\r\n\r\nIf you think the PR is ok after these changes can you already give me a rough estimate of the time needed to have a new NuGet version?"}}