{"action":"created","issue":{"url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/184","repository_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit","labels_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/184/comments","events_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/184/events","html_url":"https://github.com/OvercastNetwork/SportBukkit/pull/184","id":137505931,"number":184,"title":"[WIP] Rebase to CraftBukkit 1.9","user":{"login":"jedediah","id":35292,"avatar_url":"https://avatars.githubusercontent.com/u/35292?v=3","gravatar_id":"","url":"https://api.github.com/users/jedediah","html_url":"https://github.com/jedediah","followers_url":"https://api.github.com/users/jedediah/followers","following_url":"https://api.github.com/users/jedediah/following{/other_user}","gists_url":"https://api.github.com/users/jedediah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedediah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedediah/subscriptions","organizations_url":"https://api.github.com/users/jedediah/orgs","repos_url":"https://api.github.com/users/jedediah/repos","events_url":"https://api.github.com/users/jedediah/events{/privacy}","received_events_url":"https://api.github.com/users/jedediah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-03-01T08:17:58Z","updated_at":"2016-03-13T03:05:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/pulls/184","html_url":"https://github.com/OvercastNetwork/SportBukkit/pull/184","diff_url":"https://github.com/OvercastNetwork/SportBukkit/pull/184.diff","patch_url":"https://github.com/OvercastNetwork/SportBukkit/pull/184.patch"},"body":"Changes:\r\n* pom.xml changes moved before all other patches\r\n* Get rid of `v#_#R#` name mangling, because it confuses dev tools\r\n* Replace `getEntityCount` and `setEntityCount` with just `allocateEntityId`\r\n* Velocity in `BlockDispenseEvent` is now always used as velocity, never as a position. `BlockDispenseEntityEvent` has a new location property for this purpose.\r\n* Make the pressure plate event spam patch actually do something\r\n* Name mangling of Location.set* methods in the \"Location extends Vector\" patch moved to `mangle.csrg`. It used to be part of `deprecation-mappings.csrg`, but that was removed upstream.\r\n\r\nRemoved:\r\n* \"remove the remove queue\" patch\r\n* Entity visibility API, because it would now be much more difficult to implement\r\n* Dropper inventory patch, appears to be fixed upstream\r\n* `DataWatcher` optimization, because the original class changed too much\r\n* Egg-spawner interaction patch, appears to be fixed upstream\r\n* Our attribute API, except for item attribute modifiers, which is not implemented upstream yet\r\n* \"Fix damage cooldown reducing explosion knockback\" because applied upstream\r\n* \"Fix HideFlags missing from NBT whitelist\" because fixed upstream\r\n* \"Don't filter negative damage values\" because applied upstream\r\n\r\nAdded:\r\n* Arrow pickup rule API\r\n* Arrow damage API\r\n* Villager multi-trade API\r\n* Absorption API\r\n* Enhanced boss bar API\r\n* Empty chunk API\r\n* Team collision API\r\n* Registration API - wrapper around Mojang's registration system for everything\r\n* Update potion API to use registration\r\n* Legacy potion support\r\n\r\nNeeds testing:\r\n\r\n- [x] Interaction-override API\r\n- [x] Is remove queue fixed?\r\n- [x] Dropper inventory fixed?\r\n- [x] Egg-spawner interaction cancelling\r\n- [x] Custom replacement item in `PlayerItemConsumeEvent`"},"comment":{"url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/comments/195861108","html_url":"https://github.com/OvercastNetwork/SportBukkit/pull/184#issuecomment-195861108","issue_url":"https://api.github.com/repos/OvercastNetwork/SportBukkit/issues/184","id":195861108,"user":{"login":"twizmwazin","id":1341797,"avatar_url":"https://avatars.githubusercontent.com/u/1341797?v=3","gravatar_id":"","url":"https://api.github.com/users/twizmwazin","html_url":"https://github.com/twizmwazin","followers_url":"https://api.github.com/users/twizmwazin/followers","following_url":"https://api.github.com/users/twizmwazin/following{/other_user}","gists_url":"https://api.github.com/users/twizmwazin/gists{/gist_id}","starred_url":"https://api.github.com/users/twizmwazin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twizmwazin/subscriptions","organizations_url":"https://api.github.com/users/twizmwazin/orgs","repos_url":"https://api.github.com/users/twizmwazin/repos","events_url":"https://api.github.com/users/twizmwazin/events{/privacy}","received_events_url":"https://api.github.com/users/twizmwazin/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T03:05:30Z","updated_at":"2016-03-13T03:05:30Z","body":"I'm not sure that md_5 would support using components in bukkit, I'd see him more likely to have a spigot patch to add support for them there. However, for compatibility sake here, unless I'm missing something, is there any reason we can't just use `TextComponet.fromLegacyText(String message)` and `BaseComponent.toLegacyText(BaseComponent... components)`?"}}