{"action":"created","comment":{"url":"https://api.github.com/repos/bemhint/bemhint/pulls/comments/89874849","pull_request_review_id":10404971,"id":89874849,"diff_hunk":"@@ -168,7 +168,9 @@ module.exports = inherit({\n             .map(function(config, path) {\n                 path = resolve.sync(path, {basedir: this._basedir});\n \n-                return config && new Plugin(path, config);\n+                return config && new Plugin(path, config, {","path":"lib/config.js","position":5,"original_position":5,"commit_id":"15999c420856292a5ea19282aa430e0f13147a89","original_commit_id":"15999c420856292a5ea19282aa430e0f13147a89","user":{"login":"eGavr","id":6376693,"avatar_url":"https://avatars.githubusercontent.com/u/6376693?v=3","gravatar_id":"","url":"https://api.github.com/users/eGavr","html_url":"https://github.com/eGavr","followers_url":"https://api.github.com/users/eGavr/followers","following_url":"https://api.github.com/users/eGavr/following{/other_user}","gists_url":"https://api.github.com/users/eGavr/gists{/gist_id}","starred_url":"https://api.github.com/users/eGavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eGavr/subscriptions","organizations_url":"https://api.github.com/users/eGavr/orgs","repos_url":"https://api.github.com/users/eGavr/repos","events_url":"https://api.github.com/users/eGavr/events{/privacy}","received_events_url":"https://api.github.com/users/eGavr/received_events","type":"User","site_admin":false},"body":"а ты не хочешь все эти конфиги в один объект объединить и уменьшить количество аргументов, которые принимают конструкторы?\r\n\r\nну типо есть три типа конфигов у плагина:\r\n\r\n```js\r\n{\r\n    userConfig: {}, // конфиг, который указывает пользователь в основном конфиге\r\n    predefinedConfig: {} // конфиг, который указан в реализации плагина\r\n    baseConfig: {}, // какие-то свойства основного конфига\r\n}\r\n```","created_at":"2016-11-28T20:16:55Z","updated_at":"2016-11-28T20:25:24Z","html_url":"https://github.com/bemhint/bemhint/pull/75#discussion_r89874849","pull_request_url":"https://api.github.com/repos/bemhint/bemhint/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/comments/89874849"},"html":{"href":"https://github.com/bemhint/bemhint/pull/75#discussion_r89874849"},"pull_request":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/bemhint/bemhint/pulls/75","id":93931877,"html_url":"https://github.com/bemhint/bemhint/pull/75","diff_url":"https://github.com/bemhint/bemhint/pull/75.diff","patch_url":"https://github.com/bemhint/bemhint/pull/75.patch","issue_url":"https://api.github.com/repos/bemhint/bemhint/issues/75","number":75,"state":"open","locked":false,"title":"Add resolvePath logic to plugin config","user":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"body":"* pass `_resolvePath` through\r\n  * `Config.prototype.requirePlugins`\r\n  * `Plugin.prototype.__constructor`\r\n  * wraps in `options`\r\n  * `PluginConfig.prototype.__constructor`\r\n* complete Readme\r\n* complete and correct tests","created_at":"2016-11-16T09:45:25Z","updated_at":"2016-11-28T20:25:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86d80e6788d88b6978e18f871e6f4d40f871a1d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bemhint/bemhint/pulls/75/commits","review_comments_url":"https://api.github.com/repos/bemhint/bemhint/pulls/75/comments","review_comment_url":"https://api.github.com/repos/bemhint/bemhint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bemhint/bemhint/issues/75/comments","statuses_url":"https://api.github.com/repos/bemhint/bemhint/statuses/15999c420856292a5ea19282aa430e0f13147a89","head":{"label":"Vittly:basedir-to-plugin-issue","ref":"basedir-to-plugin-issue","sha":"15999c420856292a5ea19282aa430e0f13147a89","user":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"repo":{"id":73903274,"name":"bemhint","full_name":"Vittly/bemhint","owner":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vittly/bemhint","description":"Linter of BEM projects","fork":true,"url":"https://api.github.com/repos/Vittly/bemhint","forks_url":"https://api.github.com/repos/Vittly/bemhint/forks","keys_url":"https://api.github.com/repos/Vittly/bemhint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vittly/bemhint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vittly/bemhint/teams","hooks_url":"https://api.github.com/repos/Vittly/bemhint/hooks","issue_events_url":"https://api.github.com/repos/Vittly/bemhint/issues/events{/number}","events_url":"https://api.github.com/repos/Vittly/bemhint/events","assignees_url":"https://api.github.com/repos/Vittly/bemhint/assignees{/user}","branches_url":"https://api.github.com/repos/Vittly/bemhint/branches{/branch}","tags_url":"https://api.github.com/repos/Vittly/bemhint/tags","blobs_url":"https://api.github.com/repos/Vittly/bemhint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vittly/bemhint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vittly/bemhint/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vittly/bemhint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vittly/bemhint/statuses/{sha}","languages_url":"https://api.github.com/repos/Vittly/bemhint/languages","stargazers_url":"https://api.github.com/repos/Vittly/bemhint/stargazers","contributors_url":"https://api.github.com/repos/Vittly/bemhint/contributors","subscribers_url":"https://api.github.com/repos/Vittly/bemhint/subscribers","subscription_url":"https://api.github.com/repos/Vittly/bemhint/subscription","commits_url":"https://api.github.com/repos/Vittly/bemhint/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vittly/bemhint/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vittly/bemhint/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vittly/bemhint/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vittly/bemhint/contents/{+path}","compare_url":"https://api.github.com/repos/Vittly/bemhint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vittly/bemhint/merges","archive_url":"https://api.github.com/repos/Vittly/bemhint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vittly/bemhint/downloads","issues_url":"https://api.github.com/repos/Vittly/bemhint/issues{/number}","pulls_url":"https://api.github.com/repos/Vittly/bemhint/pulls{/number}","milestones_url":"https://api.github.com/repos/Vittly/bemhint/milestones{/number}","notifications_url":"https://api.github.com/repos/Vittly/bemhint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vittly/bemhint/labels{/name}","releases_url":"https://api.github.com/repos/Vittly/bemhint/releases{/id}","deployments_url":"https://api.github.com/repos/Vittly/bemhint/deployments","created_at":"2016-11-16T09:13:58Z","updated_at":"2016-11-16T09:13:59Z","pushed_at":"2016-11-28T06:19:46Z","git_url":"git://github.com/Vittly/bemhint.git","ssh_url":"git@github.com:Vittly/bemhint.git","clone_url":"https://github.com/Vittly/bemhint.git","svn_url":"https://github.com/Vittly/bemhint","homepage":"","size":155,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bemhint:master","ref":"master","sha":"1eb3ad417db0075a7fe54f83fddb5a882cc22564","user":{"login":"bemhint","id":18241542,"avatar_url":"https://avatars.githubusercontent.com/u/18241542?v=3","gravatar_id":"","url":"https://api.github.com/users/bemhint","html_url":"https://github.com/bemhint","followers_url":"https://api.github.com/users/bemhint/followers","following_url":"https://api.github.com/users/bemhint/following{/other_user}","gists_url":"https://api.github.com/users/bemhint/gists{/gist_id}","starred_url":"https://api.github.com/users/bemhint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemhint/subscriptions","organizations_url":"https://api.github.com/users/bemhint/orgs","repos_url":"https://api.github.com/users/bemhint/repos","events_url":"https://api.github.com/users/bemhint/events{/privacy}","received_events_url":"https://api.github.com/users/bemhint/received_events","type":"Organization","site_admin":false},"repo":{"id":28726632,"name":"bemhint","full_name":"bemhint/bemhint","owner":{"login":"bemhint","id":18241542,"avatar_url":"https://avatars.githubusercontent.com/u/18241542?v=3","gravatar_id":"","url":"https://api.github.com/users/bemhint","html_url":"https://github.com/bemhint","followers_url":"https://api.github.com/users/bemhint/followers","following_url":"https://api.github.com/users/bemhint/following{/other_user}","gists_url":"https://api.github.com/users/bemhint/gists{/gist_id}","starred_url":"https://api.github.com/users/bemhint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemhint/subscriptions","organizations_url":"https://api.github.com/users/bemhint/orgs","repos_url":"https://api.github.com/users/bemhint/repos","events_url":"https://api.github.com/users/bemhint/events{/privacy}","received_events_url":"https://api.github.com/users/bemhint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bemhint/bemhint","description":"Linter of BEM projects","fork":false,"url":"https://api.github.com/repos/bemhint/bemhint","forks_url":"https://api.github.com/repos/bemhint/bemhint/forks","keys_url":"https://api.github.com/repos/bemhint/bemhint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bemhint/bemhint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bemhint/bemhint/teams","hooks_url":"https://api.github.com/repos/bemhint/bemhint/hooks","issue_events_url":"https://api.github.com/repos/bemhint/bemhint/issues/events{/number}","events_url":"https://api.github.com/repos/bemhint/bemhint/events","assignees_url":"https://api.github.com/repos/bemhint/bemhint/assignees{/user}","branches_url":"https://api.github.com/repos/bemhint/bemhint/branches{/branch}","tags_url":"https://api.github.com/repos/bemhint/bemhint/tags","blobs_url":"https://api.github.com/repos/bemhint/bemhint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bemhint/bemhint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bemhint/bemhint/git/refs{/sha}","trees_url":"https://api.github.com/repos/bemhint/bemhint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bemhint/bemhint/statuses/{sha}","languages_url":"https://api.github.com/repos/bemhint/bemhint/languages","stargazers_url":"https://api.github.com/repos/bemhint/bemhint/stargazers","contributors_url":"https://api.github.com/repos/bemhint/bemhint/contributors","subscribers_url":"https://api.github.com/repos/bemhint/bemhint/subscribers","subscription_url":"https://api.github.com/repos/bemhint/bemhint/subscription","commits_url":"https://api.github.com/repos/bemhint/bemhint/commits{/sha}","git_commits_url":"https://api.github.com/repos/bemhint/bemhint/git/commits{/sha}","comments_url":"https://api.github.com/repos/bemhint/bemhint/comments{/number}","issue_comment_url":"https://api.github.com/repos/bemhint/bemhint/issues/comments{/number}","contents_url":"https://api.github.com/repos/bemhint/bemhint/contents/{+path}","compare_url":"https://api.github.com/repos/bemhint/bemhint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bemhint/bemhint/merges","archive_url":"https://api.github.com/repos/bemhint/bemhint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bemhint/bemhint/downloads","issues_url":"https://api.github.com/repos/bemhint/bemhint/issues{/number}","pulls_url":"https://api.github.com/repos/bemhint/bemhint/pulls{/number}","milestones_url":"https://api.github.com/repos/bemhint/bemhint/milestones{/number}","notifications_url":"https://api.github.com/repos/bemhint/bemhint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bemhint/bemhint/labels{/name}","releases_url":"https://api.github.com/repos/bemhint/bemhint/releases{/id}","deployments_url":"https://api.github.com/repos/bemhint/bemhint/deployments","created_at":"2015-01-02T21:19:28Z","updated_at":"2016-11-22T07:33:28Z","pushed_at":"2016-11-28T06:19:48Z","git_url":"git://github.com/bemhint/bemhint.git","ssh_url":"git@github.com:bemhint/bemhint.git","clone_url":"https://github.com/bemhint/bemhint.git","svn_url":"https://github.com/bemhint/bemhint","homepage":"","size":152,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/75"},"html":{"href":"https://github.com/bemhint/bemhint/pull/75"},"issue":{"href":"https://api.github.com/repos/bemhint/bemhint/issues/75"},"comments":{"href":"https://api.github.com/repos/bemhint/bemhint/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bemhint/bemhint/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/bemhint/bemhint/statuses/15999c420856292a5ea19282aa430e0f13147a89"}}}}
{"actor":{"display_login":"eGavr"}}