{"action":"created","issue":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/1170","repository_url":"https://api.github.com/repos/pkp/pkp-lib","labels_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1170/labels{/name}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1170/comments","events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1170/events","html_url":"https://github.com/pkp/pkp-lib/issues/1170","id":135428561,"number":1170,"title":"[OJS] Issue galley grid retains `empty` class after a galley added","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pkp/pkp-lib/labels/Open%20Journal%20Systems","name":"Open Journal Systems","color":"aabbaa"},{"url":"https://api.github.com/repos/pkp/pkp-lib/labels/Open%20Monograph%20Press","name":"Open Monograph Press","color":"a2c6dc"}],"state":"open","locked":false,"assignee":{"login":"beghelli","id":593977,"avatar_url":"https://avatars.githubusercontent.com/u/593977?v=3","gravatar_id":"","url":"https://api.github.com/users/beghelli","html_url":"https://github.com/beghelli","followers_url":"https://api.github.com/users/beghelli/followers","following_url":"https://api.github.com/users/beghelli/following{/other_user}","gists_url":"https://api.github.com/users/beghelli/gists{/gist_id}","starred_url":"https://api.github.com/users/beghelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beghelli/subscriptions","organizations_url":"https://api.github.com/users/beghelli/orgs","repos_url":"https://api.github.com/users/beghelli/repos","events_url":"https://api.github.com/users/beghelli/events{/privacy}","received_events_url":"https://api.github.com/users/beghelli/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4","html_url":"https://github.com/pkp/pkp-lib/milestones/OMP%201.2","labels_url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4/labels","id":892323,"number":4,"title":"OMP 1.2","description":"OMP 1.2 is a major revision of OMP building on the stable OMP 1.1.1 branch but adding numerous new features and changes, including Javascript library upgrades, a move to Composer for dependency management, and more.","creator":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":120,"state":"open","created_at":"2014-12-04T23:55:42Z","updated_at":"2016-03-08T16:39:57Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-22T14:13:05Z","updated_at":"2016-03-09T00:38:49Z","closed_at":null,"body":"If the grid in Edit Issue > Issue Galleys is empty, then you add a galley, the row is added but the `empty` class is still attached to the grid's `tbody`. As a result, the styling is off and the empty row indicator is visible."},"comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/194038525","html_url":"https://github.com/pkp/pkp-lib/issues/1170#issuecomment-194038525","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1170","id":194038525,"user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T00:38:49Z","updated_at":"2016-03-09T00:38:49Z","body":"@beghelli, could you take a look at this? Best I can tell, the problem was introduced with grid features.\r\n\r\nIt seems to me that we need to create a `tbody` for the first row that's added to a grid, but currently the grid handler is adding the row to the `tbody.empty` placeholder. I'm a little lost in considering grid features, category grids, etc., which I suspect you're more conversant with.\r\n\r\nWith the fix I tried before reverted, you should see this on any grid -- I was using the reviewer grid (adding a reviewer to a blank list), and also the discussion grid on the same reviewer workflow page."}}