{"action":"closed","number":590,"pull_request":{"url":"https://api.github.com/repos/codenvy/che-core/pulls/590","id":54920920,"html_url":"https://github.com/codenvy/che-core/pull/590","diff_url":"https://github.com/codenvy/che-core/pull/590.diff","patch_url":"https://github.com/codenvy/che-core/pull/590.patch","issue_url":"https://api.github.com/repos/codenvy/che-core/issues/590","number":590,"state":"closed","locked":false,"title":"Authentication token fixes","user":{"login":"tareqhs","id":196764,"avatar_url":"https://avatars.githubusercontent.com/u/196764?v=3","gravatar_id":"","url":"https://api.github.com/users/tareqhs","html_url":"https://github.com/tareqhs","followers_url":"https://api.github.com/users/tareqhs/followers","following_url":"https://api.github.com/users/tareqhs/following{/other_user}","gists_url":"https://api.github.com/users/tareqhs/gists{/gist_id}","starred_url":"https://api.github.com/users/tareqhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tareqhs/subscriptions","organizations_url":"https://api.github.com/users/tareqhs/orgs","repos_url":"https://api.github.com/users/tareqhs/repos","events_url":"https://api.github.com/users/tareqhs/events{/privacy}","received_events_url":"https://api.github.com/users/tareqhs/received_events","type":"User","site_admin":false},"body":"Some fixes to make pass authentication token correctly across multi-threading in Che.\r\n\r\n* Do not not add an explicit token query parameter is the download-sources URL that is passed from the build request from BuildQueue to the slave builder, leave it to the authentication header.\r\n* Do not not add an explicit token query parameter is the URL of the deployment sources that is passed from the run request from RunQueue to the slave runner, leave it to the authentication header.\r\n* Add authorization header to the HTTP requests issued from HTTP download plugin so that core components do not fail due to authorization issues when using it.\r\n* Propagate thread-local context to default builder task in Che, so that the sources manager issues the download-sources HTTP call with the required authentication information available.\r\n\r\nSigned-off-by: Tareq Sharafy <tareq.sha@gmail.com>","created_at":"2016-01-03T08:18:39Z","updated_at":"2016-05-04T07:06:54Z","closed_at":"2016-05-04T07:06:54Z","merged_at":"2016-05-04T07:06:54Z","merge_commit_sha":"acda57cb4523fb7f0d7a14d3c32254c34fc6d567","assignee":{"login":"skabashnyuk","id":1614429,"avatar_url":"https://avatars.githubusercontent.com/u/1614429?v=3","gravatar_id":"","url":"https://api.github.com/users/skabashnyuk","html_url":"https://github.com/skabashnyuk","followers_url":"https://api.github.com/users/skabashnyuk/followers","following_url":"https://api.github.com/users/skabashnyuk/following{/other_user}","gists_url":"https://api.github.com/users/skabashnyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/skabashnyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skabashnyuk/subscriptions","organizations_url":"https://api.github.com/users/skabashnyuk/orgs","repos_url":"https://api.github.com/users/skabashnyuk/repos","events_url":"https://api.github.com/users/skabashnyuk/events{/privacy}","received_events_url":"https://api.github.com/users/skabashnyuk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/codenvy/che-core/pulls/590/commits","review_comments_url":"https://api.github.com/repos/codenvy/che-core/pulls/590/comments","review_comment_url":"https://api.github.com/repos/codenvy/che-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codenvy/che-core/issues/590/comments","statuses_url":"https://api.github.com/repos/codenvy/che-core/statuses/c65dca5c097a4532432568ad71885ab195899786","head":{"label":"tareqhs:auth_token_fixes","ref":"auth_token_fixes","sha":"c65dca5c097a4532432568ad71885ab195899786","user":{"login":"tareqhs","id":196764,"avatar_url":"https://avatars.githubusercontent.com/u/196764?v=3","gravatar_id":"","url":"https://api.github.com/users/tareqhs","html_url":"https://github.com/tareqhs","followers_url":"https://api.github.com/users/tareqhs/followers","following_url":"https://api.github.com/users/tareqhs/following{/other_user}","gists_url":"https://api.github.com/users/tareqhs/gists{/gist_id}","starred_url":"https://api.github.com/users/tareqhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tareqhs/subscriptions","organizations_url":"https://api.github.com/users/tareqhs/orgs","repos_url":"https://api.github.com/users/tareqhs/repos","events_url":"https://api.github.com/users/tareqhs/events{/privacy}","received_events_url":"https://api.github.com/users/tareqhs/received_events","type":"User","site_admin":false},"repo":{"id":36723909,"name":"che-core","full_name":"tareqhs/che-core","owner":{"login":"tareqhs","id":196764,"avatar_url":"https://avatars.githubusercontent.com/u/196764?v=3","gravatar_id":"","url":"https://api.github.com/users/tareqhs","html_url":"https://github.com/tareqhs","followers_url":"https://api.github.com/users/tareqhs/followers","following_url":"https://api.github.com/users/tareqhs/following{/other_user}","gists_url":"https://api.github.com/users/tareqhs/gists{/gist_id}","starred_url":"https://api.github.com/users/tareqhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tareqhs/subscriptions","organizations_url":"https://api.github.com/users/tareqhs/orgs","repos_url":"https://api.github.com/users/tareqhs/repos","events_url":"https://api.github.com/users/tareqhs/events{/privacy}","received_events_url":"https://api.github.com/users/tareqhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tareqhs/che-core","description":"Core for che","fork":true,"url":"https://api.github.com/repos/tareqhs/che-core","forks_url":"https://api.github.com/repos/tareqhs/che-core/forks","keys_url":"https://api.github.com/repos/tareqhs/che-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tareqhs/che-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tareqhs/che-core/teams","hooks_url":"https://api.github.com/repos/tareqhs/che-core/hooks","issue_events_url":"https://api.github.com/repos/tareqhs/che-core/issues/events{/number}","events_url":"https://api.github.com/repos/tareqhs/che-core/events","assignees_url":"https://api.github.com/repos/tareqhs/che-core/assignees{/user}","branches_url":"https://api.github.com/repos/tareqhs/che-core/branches{/branch}","tags_url":"https://api.github.com/repos/tareqhs/che-core/tags","blobs_url":"https://api.github.com/repos/tareqhs/che-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tareqhs/che-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tareqhs/che-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tareqhs/che-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tareqhs/che-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tareqhs/che-core/languages","stargazers_url":"https://api.github.com/repos/tareqhs/che-core/stargazers","contributors_url":"https://api.github.com/repos/tareqhs/che-core/contributors","subscribers_url":"https://api.github.com/repos/tareqhs/che-core/subscribers","subscription_url":"https://api.github.com/repos/tareqhs/che-core/subscription","commits_url":"https://api.github.com/repos/tareqhs/che-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tareqhs/che-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tareqhs/che-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tareqhs/che-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tareqhs/che-core/contents/{+path}","compare_url":"https://api.github.com/repos/tareqhs/che-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tareqhs/che-core/merges","archive_url":"https://api.github.com/repos/tareqhs/che-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tareqhs/che-core/downloads","issues_url":"https://api.github.com/repos/tareqhs/che-core/issues{/number}","pulls_url":"https://api.github.com/repos/tareqhs/che-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tareqhs/che-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tareqhs/che-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tareqhs/che-core/labels{/name}","releases_url":"https://api.github.com/repos/tareqhs/che-core/releases{/id}","deployments_url":"https://api.github.com/repos/tareqhs/che-core/deployments","created_at":"2015-06-02T09:50:30Z","updated_at":"2015-06-02T09:50:35Z","pushed_at":"2016-05-03T12:49:20Z","git_url":"git://github.com/tareqhs/che-core.git","ssh_url":"git@github.com:tareqhs/che-core.git","clone_url":"https://github.com/tareqhs/che-core.git","svn_url":"https://github.com/tareqhs/che-core","homepage":null,"size":11870,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codenvy:3.x","ref":"3.x","sha":"9d6d0aec27af47b6911effa931ec8c9732f8cf2e","user":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"repo":{"id":32935706,"name":"che-core","full_name":"codenvy/che-core","owner":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codenvy/che-core","description":"Core for che","fork":false,"url":"https://api.github.com/repos/codenvy/che-core","forks_url":"https://api.github.com/repos/codenvy/che-core/forks","keys_url":"https://api.github.com/repos/codenvy/che-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codenvy/che-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codenvy/che-core/teams","hooks_url":"https://api.github.com/repos/codenvy/che-core/hooks","issue_events_url":"https://api.github.com/repos/codenvy/che-core/issues/events{/number}","events_url":"https://api.github.com/repos/codenvy/che-core/events","assignees_url":"https://api.github.com/repos/codenvy/che-core/assignees{/user}","branches_url":"https://api.github.com/repos/codenvy/che-core/branches{/branch}","tags_url":"https://api.github.com/repos/codenvy/che-core/tags","blobs_url":"https://api.github.com/repos/codenvy/che-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codenvy/che-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codenvy/che-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/codenvy/che-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codenvy/che-core/statuses/{sha}","languages_url":"https://api.github.com/repos/codenvy/che-core/languages","stargazers_url":"https://api.github.com/repos/codenvy/che-core/stargazers","contributors_url":"https://api.github.com/repos/codenvy/che-core/contributors","subscribers_url":"https://api.github.com/repos/codenvy/che-core/subscribers","subscription_url":"https://api.github.com/repos/codenvy/che-core/subscription","commits_url":"https://api.github.com/repos/codenvy/che-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/codenvy/che-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/codenvy/che-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/codenvy/che-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/codenvy/che-core/contents/{+path}","compare_url":"https://api.github.com/repos/codenvy/che-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codenvy/che-core/merges","archive_url":"https://api.github.com/repos/codenvy/che-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codenvy/che-core/downloads","issues_url":"https://api.github.com/repos/codenvy/che-core/issues{/number}","pulls_url":"https://api.github.com/repos/codenvy/che-core/pulls{/number}","milestones_url":"https://api.github.com/repos/codenvy/che-core/milestones{/number}","notifications_url":"https://api.github.com/repos/codenvy/che-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codenvy/che-core/labels{/name}","releases_url":"https://api.github.com/repos/codenvy/che-core/releases{/id}","deployments_url":"https://api.github.com/repos/codenvy/che-core/deployments","created_at":"2015-03-26T15:30:10Z","updated_at":"2016-03-13T18:39:44Z","pushed_at":"2016-05-04T07:06:54Z","git_url":"git://github.com/codenvy/che-core.git","ssh_url":"git@github.com:codenvy/che-core.git","clone_url":"https://github.com/codenvy/che-core.git","svn_url":"https://github.com/codenvy/che-core","homepage":null,"size":16325,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":25,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/codenvy/che-core/pulls/590"},"html":{"href":"https://github.com/codenvy/che-core/pull/590"},"issue":{"href":"https://api.github.com/repos/codenvy/che-core/issues/590"},"comments":{"href":"https://api.github.com/repos/codenvy/che-core/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/codenvy/che-core/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/codenvy/che-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codenvy/che-core/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/codenvy/che-core/statuses/c65dca5c097a4532432568ad71885ab195899786"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tareqhs","id":196764,"avatar_url":"https://avatars.githubusercontent.com/u/196764?v=3","gravatar_id":"","url":"https://api.github.com/users/tareqhs","html_url":"https://github.com/tareqhs","followers_url":"https://api.github.com/users/tareqhs/followers","following_url":"https://api.github.com/users/tareqhs/following{/other_user}","gists_url":"https://api.github.com/users/tareqhs/gists{/gist_id}","starred_url":"https://api.github.com/users/tareqhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tareqhs/subscriptions","organizations_url":"https://api.github.com/users/tareqhs/orgs","repos_url":"https://api.github.com/users/tareqhs/repos","events_url":"https://api.github.com/users/tareqhs/events{/privacy}","received_events_url":"https://api.github.com/users/tareqhs/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":4,"additions":26,"deletions":24,"changed_files":4}}