{"action":"opened","issue":{"url":"https://api.github.com/repos/brianmario/charlock_holmes/issues/111","repository_url":"https://api.github.com/repos/brianmario/charlock_holmes","labels_url":"https://api.github.com/repos/brianmario/charlock_holmes/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/brianmario/charlock_holmes/issues/111/comments","events_url":"https://api.github.com/repos/brianmario/charlock_holmes/issues/111/events","html_url":"https://github.com/brianmario/charlock_holmes/issues/111","id":187277118,"number":111,"title":"U_BUFFER_OVERFLOW_ERROR and U_STRING_NOT_TERMINATED_WARNING need to be handled the same way instead of raising an error","user":{"login":"koljaa","id":101635,"avatar_url":"https://avatars.githubusercontent.com/u/101635?v=3","gravatar_id":"","url":"https://api.github.com/users/koljaa","html_url":"https://github.com/koljaa","followers_url":"https://api.github.com/users/koljaa/followers","following_url":"https://api.github.com/users/koljaa/following{/other_user}","gists_url":"https://api.github.com/users/koljaa/gists{/gist_id}","starred_url":"https://api.github.com/users/koljaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koljaa/subscriptions","organizations_url":"https://api.github.com/users/koljaa/orgs","repos_url":"https://api.github.com/users/koljaa/repos","events_url":"https://api.github.com/users/koljaa/events{/privacy}","received_events_url":"https://api.github.com/users/koljaa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-04T08:27:11Z","updated_at":"2016-11-04T08:27:11Z","closed_at":null,"body":"http://userguide.icu-project.org/strings\r\nRegarding the following statement in the release notes the U_STRING_NOT_TERMINATED_WARNING error need to be handle the same way as U_BUFFER_OVERFLOW_ERROR.\r\nhttps://github.com/brianmario/charlock_holmes/blob/master/ext/charlock_holmes/converter.c#L29\r\n\r\n\"Some functions used to set an overflow error code even when only the terminating NUL did not fit into the output buffer. These functions now set UErrorCode to U_STRING_NOT_TERMINATED_WARNING rather than to U_BUFFER_OVERFLOW_ERROR.\"\r\n\r\nOr is there any reason why the U_STRING_NOT_TERMINATED_WARNING should raise an error?"}}
{"actor":{"display_login":"koljaa"}}