{"action":"closed","number":1327,"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327","id":61802345,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1327","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1327.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1327.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1327","number":1327,"state":"closed","locked":false,"title":"[ASCollectionView] scrollableDirections must account for alwaysBounce(Vertical | Horizontal)","user":{"login":"samhsiung","id":194822,"avatar_url":"https://avatars.githubusercontent.com/u/194822?v=3","gravatar_id":"","url":"https://api.github.com/users/samhsiung","html_url":"https://github.com/samhsiung","followers_url":"https://api.github.com/users/samhsiung/followers","following_url":"https://api.github.com/users/samhsiung/following{/other_user}","gists_url":"https://api.github.com/users/samhsiung/gists{/gist_id}","starred_url":"https://api.github.com/users/samhsiung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhsiung/subscriptions","organizations_url":"https://api.github.com/users/samhsiung/orgs","repos_url":"https://api.github.com/users/samhsiung/repos","events_url":"https://api.github.com/users/samhsiung/events{/privacy}","received_events_url":"https://api.github.com/users/samhsiung/received_events","type":"User","site_admin":false},"body":"If a UIScrollVIew has alwaysBounce(Vertical|Horizontal) = YES then it will always be scrollable in that direction.  Adding these additional checks will allow us to handle cases where an ASCV without a flow layout has a data source whose first page load doesn't expand contentSize beyond bounds in the desired scroll direction. When the user scrolls in the intended direction, batch fetching will be triggered if there is more content to load.","created_at":"2016-03-05T05:42:22Z","updated_at":"2016-03-06T00:35:48Z","closed_at":"2016-03-06T00:35:48Z","merged_at":"2016-03-06T00:35:48Z","merge_commit_sha":"dc2ae6cfeeedb6596d7743d4c3d2b723dab638dd","assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/16","html_url":"https://github.com/facebook/AsyncDisplayKit/milestones/1.9.7","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/16/labels","id":1538836,"number":16,"title":"1.9.7","description":null,"creator":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":126,"state":"open","created_at":"2016-01-23T21:06:45Z","updated_at":"2016-03-06T00:35:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1327/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/85394f09b42d841fade0d56a80b36c2282e9128e","head":{"label":"samhsiung:fix_scrollable_directions","ref":"fix_scrollable_directions","sha":"85394f09b42d841fade0d56a80b36c2282e9128e","user":{"login":"samhsiung","id":194822,"avatar_url":"https://avatars.githubusercontent.com/u/194822?v=3","gravatar_id":"","url":"https://api.github.com/users/samhsiung","html_url":"https://github.com/samhsiung","followers_url":"https://api.github.com/users/samhsiung/followers","following_url":"https://api.github.com/users/samhsiung/following{/other_user}","gists_url":"https://api.github.com/users/samhsiung/gists{/gist_id}","starred_url":"https://api.github.com/users/samhsiung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhsiung/subscriptions","organizations_url":"https://api.github.com/users/samhsiung/orgs","repos_url":"https://api.github.com/users/samhsiung/repos","events_url":"https://api.github.com/users/samhsiung/events{/privacy}","received_events_url":"https://api.github.com/users/samhsiung/received_events","type":"User","site_admin":false},"repo":{"id":45215907,"name":"AsyncDisplayKit","full_name":"samhsiung/AsyncDisplayKit","owner":{"login":"samhsiung","id":194822,"avatar_url":"https://avatars.githubusercontent.com/u/194822?v=3","gravatar_id":"","url":"https://api.github.com/users/samhsiung","html_url":"https://github.com/samhsiung","followers_url":"https://api.github.com/users/samhsiung/followers","following_url":"https://api.github.com/users/samhsiung/following{/other_user}","gists_url":"https://api.github.com/users/samhsiung/gists{/gist_id}","starred_url":"https://api.github.com/users/samhsiung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhsiung/subscriptions","organizations_url":"https://api.github.com/users/samhsiung/orgs","repos_url":"https://api.github.com/users/samhsiung/repos","events_url":"https://api.github.com/users/samhsiung/events{/privacy}","received_events_url":"https://api.github.com/users/samhsiung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samhsiung/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit","forks_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/samhsiung/AsyncDisplayKit/deployments","created_at":"2015-10-29T23:05:35Z","updated_at":"2016-03-01T05:58:09Z","pushed_at":"2016-03-05T05:34:19Z","git_url":"git://github.com/samhsiung/AsyncDisplayKit.git","ssh_url":"git@github.com:samhsiung/AsyncDisplayKit.git","clone_url":"https://github.com/samhsiung/AsyncDisplayKit.git","svn_url":"https://github.com/samhsiung/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":16292,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"30463db034054bd73d5083f16f9da21985f1b3ba","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-03-05T16:54:44Z","pushed_at":"2016-03-06T00:35:48Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":18147,"stargazers_count":7425,"watchers_count":7425,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1158,"mirror_url":null,"open_issues_count":191,"forks":1158,"open_issues":191,"watchers":7425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1327"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1327"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1327/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1327/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/85394f09b42d841fade0d56a80b36c2282e9128e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}