{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/77705980","id":77705980,"diff_hunk":"@@ -97,6 +97,40 @@ typedef NS_ENUM(NSInteger, GTFetchPruneOption) {\n /// will point to an error describing what happened).\n - (BOOL)pushBranches:(NSArray<GTBranch *> *)branches toRemote:(GTRemote *)remote withOptions:(nullable NSDictionary *)options error:(NSError **)error progress:(nullable void (^)(unsigned int current, unsigned int total, size_t bytes, BOOL *stop))progressBlock;\n \n+/// Push an array of branches to a remote, together with notes (in one push).\n+/// Normally, if you use Git notes functionality, to push the notes to remote, you would have to\n+/// do two operations: pushBranches followed by pushNotes. This is unrational, so we offer you a handy\n+/// shortcut that allows to push the branches together with the notes.\n+///\n+/// branches      - An array of branches to push. Must not be nil.\n+/// remote        - The remote to push to. Must not be nil.\n+/// options       - Options applied to the push operation. Can be NULL.\n+///                 Recognized options are:\n+///                 `GTRepositoryRemoteOptionsCredentialProvider`\n+/// referenceName - Reference name for notes, if they should be pushed together with the branches.\n+///                 Use +[GTNote defaultReferenceNameWithError:] to push the default note reference.\n+///                 Passing NULL here will make notes NOT to be pushed.\n+/// error         - The error if one occurred. Can be NULL.\n+/// progressBlock - An optional callback for monitoring progress. May be NULL.\n+///\n+/// Returns YES if the push was successful, NO otherwise (and `error`, if provided,\n+/// will point to an error describing what happened).\n+- (BOOL)pushBranches:(NSArray<GTBranch *> *)branches toRemote:(GTRemote *)remote withOptions:(nullable NSDictionary *)options withNotesReferenceName:(nullable NSString*)notesReferenceName error:(NSError **)error progress:(nullable void (^)(unsigned int current, unsigned int total, size_t bytes, BOOL *stop))progressBlock;","path":"ObjectiveGit/GTRepository+RemoteOperations.h","position":22,"original_position":22,"commit_id":"0661bab43ffc5329b53d7158a7536604e7ead418","original_commit_id":"0661bab43ffc5329b53d7158a7536604e7ead418","user":{"login":"tiennou","id":81099,"avatar_url":"https://avatars.githubusercontent.com/u/81099?v=3","gravatar_id":"","url":"https://api.github.com/users/tiennou","html_url":"https://github.com/tiennou","followers_url":"https://api.github.com/users/tiennou/followers","following_url":"https://api.github.com/users/tiennou/following{/other_user}","gists_url":"https://api.github.com/users/tiennou/gists{/gist_id}","starred_url":"https://api.github.com/users/tiennou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiennou/subscriptions","organizations_url":"https://api.github.com/users/tiennou/orgs","repos_url":"https://api.github.com/users/tiennou/repos","events_url":"https://api.github.com/users/tiennou/events{/privacy}","received_events_url":"https://api.github.com/users/tiennou/received_events","type":"User","site_admin":false},"body":"I'm not particularly fond of a new method just for pushing notes. Maybe a new option (`GTRepositoryRemoteOptionsNotesReferences`) would be better, taking an array of notes \"namespace\" ?\r\n\r\nArguably, it stems from the fact that this is the branch-pushing mechanism, and branches don't really exist (everything's just a reference to git), and notes are another \"kind\" of references.\r\n\r\n@pietbrauer Opinion ? I'm not that comfortable with notes, as I've never used them 😟.","created_at":"2016-09-06T19:52:59Z","updated_at":"2016-09-06T19:52:59Z","html_url":"https://github.com/libgit2/objective-git/pull/576#discussion_r77705980","pull_request_url":"https://api.github.com/repos/libgit2/objective-git/pulls/576","_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments/77705980"},"html":{"href":"https://github.com/libgit2/objective-git/pull/576#discussion_r77705980"},"pull_request":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/576"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/objective-git/pulls/576","id":70714996,"html_url":"https://github.com/libgit2/objective-git/pull/576","diff_url":"https://github.com/libgit2/objective-git/pull/576.diff","patch_url":"https://github.com/libgit2/objective-git/pull/576.patch","issue_url":"https://api.github.com/repos/libgit2/objective-git/issues/576","number":576,"state":"open","locked":false,"title":"Git notes","user":{"login":"slavikus","id":143051,"avatar_url":"https://avatars.githubusercontent.com/u/143051?v=3","gravatar_id":"","url":"https://api.github.com/users/slavikus","html_url":"https://github.com/slavikus","followers_url":"https://api.github.com/users/slavikus/followers","following_url":"https://api.github.com/users/slavikus/following{/other_user}","gists_url":"https://api.github.com/users/slavikus/gists{/gist_id}","starred_url":"https://api.github.com/users/slavikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavikus/subscriptions","organizations_url":"https://api.github.com/users/slavikus/orgs","repos_url":"https://api.github.com/users/slavikus/repos","events_url":"https://api.github.com/users/slavikus/events{/privacy}","received_events_url":"https://api.github.com/users/slavikus/received_events","type":"User","site_admin":false},"body":"Adding support for Git Notes already supported in libgit2. A new class, `GTNote` has been added, along with a few methods for `GTRepository` to create and remove notes, as well as push them to remotes.","created_at":"2016-05-19T15:28:14Z","updated_at":"2016-09-06T19:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"573d1edc3c43b2fc4c6305f7d9e845f26d8b64ac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/objective-git/pulls/576/commits","review_comments_url":"https://api.github.com/repos/libgit2/objective-git/pulls/576/comments","review_comment_url":"https://api.github.com/repos/libgit2/objective-git/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/objective-git/issues/576/comments","statuses_url":"https://api.github.com/repos/libgit2/objective-git/statuses/0661bab43ffc5329b53d7158a7536604e7ead418","head":{"label":"slavikus:git-notes","ref":"git-notes","sha":"0661bab43ffc5329b53d7158a7536604e7ead418","user":{"login":"slavikus","id":143051,"avatar_url":"https://avatars.githubusercontent.com/u/143051?v=3","gravatar_id":"","url":"https://api.github.com/users/slavikus","html_url":"https://github.com/slavikus","followers_url":"https://api.github.com/users/slavikus/followers","following_url":"https://api.github.com/users/slavikus/following{/other_user}","gists_url":"https://api.github.com/users/slavikus/gists{/gist_id}","starred_url":"https://api.github.com/users/slavikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavikus/subscriptions","organizations_url":"https://api.github.com/users/slavikus/orgs","repos_url":"https://api.github.com/users/slavikus/repos","events_url":"https://api.github.com/users/slavikus/events{/privacy}","received_events_url":"https://api.github.com/users/slavikus/received_events","type":"User","site_admin":false},"repo":{"id":40138200,"name":"objective-git","full_name":"slavikus/objective-git","owner":{"login":"slavikus","id":143051,"avatar_url":"https://avatars.githubusercontent.com/u/143051?v=3","gravatar_id":"","url":"https://api.github.com/users/slavikus","html_url":"https://github.com/slavikus","followers_url":"https://api.github.com/users/slavikus/followers","following_url":"https://api.github.com/users/slavikus/following{/other_user}","gists_url":"https://api.github.com/users/slavikus/gists{/gist_id}","starred_url":"https://api.github.com/users/slavikus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavikus/subscriptions","organizations_url":"https://api.github.com/users/slavikus/orgs","repos_url":"https://api.github.com/users/slavikus/repos","events_url":"https://api.github.com/users/slavikus/events{/privacy}","received_events_url":"https://api.github.com/users/slavikus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slavikus/objective-git","description":"Objective-C bindings to libgit2","fork":true,"url":"https://api.github.com/repos/slavikus/objective-git","forks_url":"https://api.github.com/repos/slavikus/objective-git/forks","keys_url":"https://api.github.com/repos/slavikus/objective-git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slavikus/objective-git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slavikus/objective-git/teams","hooks_url":"https://api.github.com/repos/slavikus/objective-git/hooks","issue_events_url":"https://api.github.com/repos/slavikus/objective-git/issues/events{/number}","events_url":"https://api.github.com/repos/slavikus/objective-git/events","assignees_url":"https://api.github.com/repos/slavikus/objective-git/assignees{/user}","branches_url":"https://api.github.com/repos/slavikus/objective-git/branches{/branch}","tags_url":"https://api.github.com/repos/slavikus/objective-git/tags","blobs_url":"https://api.github.com/repos/slavikus/objective-git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slavikus/objective-git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slavikus/objective-git/git/refs{/sha}","trees_url":"https://api.github.com/repos/slavikus/objective-git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slavikus/objective-git/statuses/{sha}","languages_url":"https://api.github.com/repos/slavikus/objective-git/languages","stargazers_url":"https://api.github.com/repos/slavikus/objective-git/stargazers","contributors_url":"https://api.github.com/repos/slavikus/objective-git/contributors","subscribers_url":"https://api.github.com/repos/slavikus/objective-git/subscribers","subscription_url":"https://api.github.com/repos/slavikus/objective-git/subscription","commits_url":"https://api.github.com/repos/slavikus/objective-git/commits{/sha}","git_commits_url":"https://api.github.com/repos/slavikus/objective-git/git/commits{/sha}","comments_url":"https://api.github.com/repos/slavikus/objective-git/comments{/number}","issue_comment_url":"https://api.github.com/repos/slavikus/objective-git/issues/comments{/number}","contents_url":"https://api.github.com/repos/slavikus/objective-git/contents/{+path}","compare_url":"https://api.github.com/repos/slavikus/objective-git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slavikus/objective-git/merges","archive_url":"https://api.github.com/repos/slavikus/objective-git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slavikus/objective-git/downloads","issues_url":"https://api.github.com/repos/slavikus/objective-git/issues{/number}","pulls_url":"https://api.github.com/repos/slavikus/objective-git/pulls{/number}","milestones_url":"https://api.github.com/repos/slavikus/objective-git/milestones{/number}","notifications_url":"https://api.github.com/repos/slavikus/objective-git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slavikus/objective-git/labels{/name}","releases_url":"https://api.github.com/repos/slavikus/objective-git/releases{/id}","deployments_url":"https://api.github.com/repos/slavikus/objective-git/deployments","created_at":"2015-08-03T17:23:20Z","updated_at":"2016-01-22T13:13:54Z","pushed_at":"2016-07-15T13:26:52Z","git_url":"git://github.com/slavikus/objective-git.git","ssh_url":"git@github.com:slavikus/objective-git.git","clone_url":"https://github.com/slavikus/objective-git.git","svn_url":"https://github.com/slavikus/objective-git","homepage":"","size":61314,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"7febb4fec0f45a6ac28fbb2c9859ecbfc373bb36","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":1427977,"name":"objective-git","full_name":"libgit2/objective-git","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/objective-git","description":"Objective-C bindings to libgit2","fork":false,"url":"https://api.github.com/repos/libgit2/objective-git","forks_url":"https://api.github.com/repos/libgit2/objective-git/forks","keys_url":"https://api.github.com/repos/libgit2/objective-git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/objective-git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/objective-git/teams","hooks_url":"https://api.github.com/repos/libgit2/objective-git/hooks","issue_events_url":"https://api.github.com/repos/libgit2/objective-git/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/objective-git/events","assignees_url":"https://api.github.com/repos/libgit2/objective-git/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/objective-git/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/objective-git/tags","blobs_url":"https://api.github.com/repos/libgit2/objective-git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/objective-git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/objective-git/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/objective-git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/objective-git/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/objective-git/languages","stargazers_url":"https://api.github.com/repos/libgit2/objective-git/stargazers","contributors_url":"https://api.github.com/repos/libgit2/objective-git/contributors","subscribers_url":"https://api.github.com/repos/libgit2/objective-git/subscribers","subscription_url":"https://api.github.com/repos/libgit2/objective-git/subscription","commits_url":"https://api.github.com/repos/libgit2/objective-git/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/objective-git/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/objective-git/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/objective-git/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/objective-git/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/objective-git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/objective-git/merges","archive_url":"https://api.github.com/repos/libgit2/objective-git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/objective-git/downloads","issues_url":"https://api.github.com/repos/libgit2/objective-git/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/objective-git/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/objective-git/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/objective-git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/objective-git/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/objective-git/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/objective-git/deployments","created_at":"2011-03-01T21:28:58Z","updated_at":"2016-08-27T15:18:42Z","pushed_at":"2016-08-17T07:12:00Z","git_url":"git://github.com/libgit2/objective-git.git","ssh_url":"git@github.com:libgit2/objective-git.git","clone_url":"https://github.com/libgit2/objective-git.git","svn_url":"https://github.com/libgit2/objective-git","homepage":"","size":64186,"stargazers_count":850,"watchers_count":850,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":24,"forks":205,"open_issues":24,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/576"},"html":{"href":"https://github.com/libgit2/objective-git/pull/576"},"issue":{"href":"https://api.github.com/repos/libgit2/objective-git/issues/576"},"comments":{"href":"https://api.github.com/repos/libgit2/objective-git/issues/576/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/576/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/objective-git/pulls/576/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/objective-git/statuses/0661bab43ffc5329b53d7158a7536604e7ead418"}}}}
{"actor":{"display_login":"tiennou"}}