{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/draft-js/pulls/comments/67431908","id":67431908,"diff_hunk":"@@ -366,12 +374,23 @@ function genFragment(\n   }\n \n   var entityId: ?string = null;\n-  var href: ?string = null;\n \n   while (child) {\n     if (nodeName === 'a' && child.href && hasValidLinkText(child)) {\n-      href = new URI(child.href).toString();\n-      entityId = DraftEntity.create('LINK', 'MUTABLE', {url: href});\n+      // had to cast to Object due to https://github.com/facebook/flow/issues/1730\n+      const anchor: Object = child;\n+\n+      let entityConfig = {};","path":"src/model/encoding/convertFromHTMLToContentBlocks.js","position":32,"original_position":32,"commit_id":"bd74cf78af6a7f61a6b9bd7a7f493f0d9cc27307","original_commit_id":"bd74cf78af6a7f61a6b9bd7a7f493f0d9cc27307","user":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars.githubusercontent.com/u/1042131?v=3","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"body":"Sorry, It was a personal preference where I tend to prefer to not use const when adding properties to referenced Objects, will update it to const","created_at":"2016-06-16T21:57:57Z","updated_at":"2016-06-16T21:57:57Z","html_url":"https://github.com/facebook/draft-js/pull/374#discussion_r67431908","pull_request_url":"https://api.github.com/repos/facebook/draft-js/pulls/374","_links":{"self":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/comments/67431908"},"html":{"href":"https://github.com/facebook/draft-js/pull/374#discussion_r67431908"},"pull_request":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/374"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/draft-js/pulls/374","id":69101891,"html_url":"https://github.com/facebook/draft-js/pull/374","diff_url":"https://github.com/facebook/draft-js/pull/374.diff","patch_url":"https://github.com/facebook/draft-js/pull/374.patch","issue_url":"https://api.github.com/repos/facebook/draft-js/issues/374","number":374,"state":"open","locked":false,"title":"Adding more attributes to convertFromHTMLToContentBlocks entity whitelist","user":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars.githubusercontent.com/u/1042131?v=3","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"body":"Making sure that entities also support other common attributes for importing from html and pasting content. This is very important for compatibility with already existing applications\r\n","created_at":"2016-05-06T03:44:35Z","updated_at":"2016-06-16T21:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67ffde57e76a65c0cc822686276d8b4b1ff8ac73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/draft-js/pulls/374/commits","review_comments_url":"https://api.github.com/repos/facebook/draft-js/pulls/374/comments","review_comment_url":"https://api.github.com/repos/facebook/draft-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/draft-js/issues/374/comments","statuses_url":"https://api.github.com/repos/facebook/draft-js/statuses/bd74cf78af6a7f61a6b9bd7a7f493f0d9cc27307","head":{"label":"mitermayer:adding-extra-supported-whitelist-for-entities","ref":"adding-extra-supported-whitelist-for-entities","sha":"bd74cf78af6a7f61a6b9bd7a7f493f0d9cc27307","user":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars.githubusercontent.com/u/1042131?v=3","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"repo":{"id":52320588,"name":"draft-js","full_name":"mitermayer/draft-js","owner":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars.githubusercontent.com/u/1042131?v=3","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitermayer/draft-js","description":"A React framework for building text editors.","fork":true,"url":"https://api.github.com/repos/mitermayer/draft-js","forks_url":"https://api.github.com/repos/mitermayer/draft-js/forks","keys_url":"https://api.github.com/repos/mitermayer/draft-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitermayer/draft-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitermayer/draft-js/teams","hooks_url":"https://api.github.com/repos/mitermayer/draft-js/hooks","issue_events_url":"https://api.github.com/repos/mitermayer/draft-js/issues/events{/number}","events_url":"https://api.github.com/repos/mitermayer/draft-js/events","assignees_url":"https://api.github.com/repos/mitermayer/draft-js/assignees{/user}","branches_url":"https://api.github.com/repos/mitermayer/draft-js/branches{/branch}","tags_url":"https://api.github.com/repos/mitermayer/draft-js/tags","blobs_url":"https://api.github.com/repos/mitermayer/draft-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitermayer/draft-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitermayer/draft-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitermayer/draft-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitermayer/draft-js/statuses/{sha}","languages_url":"https://api.github.com/repos/mitermayer/draft-js/languages","stargazers_url":"https://api.github.com/repos/mitermayer/draft-js/stargazers","contributors_url":"https://api.github.com/repos/mitermayer/draft-js/contributors","subscribers_url":"https://api.github.com/repos/mitermayer/draft-js/subscribers","subscription_url":"https://api.github.com/repos/mitermayer/draft-js/subscription","commits_url":"https://api.github.com/repos/mitermayer/draft-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitermayer/draft-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitermayer/draft-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitermayer/draft-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitermayer/draft-js/contents/{+path}","compare_url":"https://api.github.com/repos/mitermayer/draft-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitermayer/draft-js/merges","archive_url":"https://api.github.com/repos/mitermayer/draft-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitermayer/draft-js/downloads","issues_url":"https://api.github.com/repos/mitermayer/draft-js/issues{/number}","pulls_url":"https://api.github.com/repos/mitermayer/draft-js/pulls{/number}","milestones_url":"https://api.github.com/repos/mitermayer/draft-js/milestones{/number}","notifications_url":"https://api.github.com/repos/mitermayer/draft-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitermayer/draft-js/labels{/name}","releases_url":"https://api.github.com/repos/mitermayer/draft-js/releases{/id}","deployments_url":"https://api.github.com/repos/mitermayer/draft-js/deployments","created_at":"2016-02-23T01:44:20Z","updated_at":"2016-02-23T01:44:22Z","pushed_at":"2016-06-16T21:54:42Z","git_url":"git://github.com/mitermayer/draft-js.git","ssh_url":"git@github.com:mitermayer/draft-js.git","clone_url":"https://github.com/mitermayer/draft-js.git","svn_url":"https://github.com/mitermayer/draft-js","homepage":"https://facebook.github.io/draft-js/","size":2378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"d2360b6ded6fae6acc4d845972763a9959528c95","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":52113921,"name":"draft-js","full_name":"facebook/draft-js","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/draft-js","description":"A React framework for building text editors.","fork":false,"url":"https://api.github.com/repos/facebook/draft-js","forks_url":"https://api.github.com/repos/facebook/draft-js/forks","keys_url":"https://api.github.com/repos/facebook/draft-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/draft-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/draft-js/teams","hooks_url":"https://api.github.com/repos/facebook/draft-js/hooks","issue_events_url":"https://api.github.com/repos/facebook/draft-js/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/draft-js/events","assignees_url":"https://api.github.com/repos/facebook/draft-js/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/draft-js/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/draft-js/tags","blobs_url":"https://api.github.com/repos/facebook/draft-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/draft-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/draft-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/draft-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/draft-js/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/draft-js/languages","stargazers_url":"https://api.github.com/repos/facebook/draft-js/stargazers","contributors_url":"https://api.github.com/repos/facebook/draft-js/contributors","subscribers_url":"https://api.github.com/repos/facebook/draft-js/subscribers","subscription_url":"https://api.github.com/repos/facebook/draft-js/subscription","commits_url":"https://api.github.com/repos/facebook/draft-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/draft-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/draft-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/draft-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/draft-js/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/draft-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/draft-js/merges","archive_url":"https://api.github.com/repos/facebook/draft-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/draft-js/downloads","issues_url":"https://api.github.com/repos/facebook/draft-js/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/draft-js/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/draft-js/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/draft-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/draft-js/labels{/name}","releases_url":"https://api.github.com/repos/facebook/draft-js/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/draft-js/deployments","created_at":"2016-02-19T20:18:26Z","updated_at":"2016-06-16T19:36:21Z","pushed_at":"2016-06-16T21:47:12Z","git_url":"git://github.com/facebook/draft-js.git","ssh_url":"git@github.com:facebook/draft-js.git","clone_url":"https://github.com/facebook/draft-js.git","svn_url":"https://github.com/facebook/draft-js","homepage":"https://facebook.github.io/draft-js/","size":3080,"stargazers_count":6569,"watchers_count":6569,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":132,"forks":419,"open_issues":132,"watchers":6569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/374"},"html":{"href":"https://github.com/facebook/draft-js/pull/374"},"issue":{"href":"https://api.github.com/repos/facebook/draft-js/issues/374"},"comments":{"href":"https://api.github.com/repos/facebook/draft-js/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/draft-js/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/draft-js/statuses/bd74cf78af6a7f61a6b9bd7a7f493f0d9cc27307"}}}}
{"actor":{"display_login":"mitermayer"}}