{"action":"created","issue":{"url":"https://api.github.com/repos/chaijs/chai/issues/794","repository_url":"https://api.github.com/repos/chaijs/chai","labels_url":"https://api.github.com/repos/chaijs/chai/issues/794/labels{/name}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/794/comments","events_url":"https://api.github.com/repos/chaijs/chai/issues/794/events","html_url":"https://github.com/chaijs/chai/pull/794","id":176188387,"number":794,"title":"Enabling showDiff for assert's equal and notEqual methods. Closes #790","user":{"login":"lucasfcosta","id":6868147,"avatar_url":"https://avatars.githubusercontent.com/u/6868147?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasfcosta","html_url":"https://github.com/lucasfcosta","followers_url":"https://api.github.com/users/lucasfcosta/followers","following_url":"https://api.github.com/users/lucasfcosta/following{/other_user}","gists_url":"https://api.github.com/users/lucasfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasfcosta/subscriptions","organizations_url":"https://api.github.com/users/lucasfcosta/orgs","repos_url":"https://api.github.com/users/lucasfcosta/repos","events_url":"https://api.github.com/users/lucasfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/lucasfcosta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-10T16:32:42Z","updated_at":"2016-09-10T16:47:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/794","html_url":"https://github.com/chaijs/chai/pull/794","diff_url":"https://github.com/chaijs/chai/pull/794.diff","patch_url":"https://github.com/chaijs/chai/pull/794.patch"},"body":"This aims to close #790.\r\n\r\nAs explained on [this post](https://github.com/chaijs/chai/issues/790#issuecomment-246078537) the `equal` and `notEqual` methods on the `assert` interface, which called `Assertion.assert` directly, didn't have the `showDiff` flag turned on and that would make their error messages look different because of the way the test runner showed results.\r\n\r\nIn order to make that behavior consistent with the `equal` related methods on other interfaces, I enabled the `showDiff` flag for these assertions too.\r\n\r\nI didn't add any tests since this was a problem related to the test runner and not ours.\r\nPlease read the post I linked above for more details.\r\nThanks everyone 😄 "},"comment":{"url":"https://api.github.com/repos/chaijs/chai/issues/comments/246122101","html_url":"https://github.com/chaijs/chai/pull/794#issuecomment-246122101","issue_url":"https://api.github.com/repos/chaijs/chai/issues/794","id":246122101,"user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T16:47:29Z","updated_at":"2016-09-10T16:47:29Z","body":"LGTM!"}}
{"actor":{"display_login":"meeber"}}