{"action":"created","comment":{"url":"https://api.github.com/repos/zikula/core/pulls/comments/56762810","id":56762810,"diff_hunk":"@@ -1465,4 +1452,21 @@ private function getInstaller($module, array $modInfo)\n \n         return $installer;\n     }\n+\n+    /**\n+     * Determines whether the current site is the main site within a Multisites system.\n+     *\n+     * @return boolean True if this is the main site, false otherwise.\n+     */\n+    private function isMainSite()\n+    {\n+        $msConfig = $this->serviceManager['multisites'];\n+\n+        return (\n+            ($msConfig['mainsiteurl'] == $this->request->query->get('sitedns', null)\n+                && $msConfig['based_on_domains'] == 0)\n+            || ($msConfig['mainsiteurl'] == $_SERVER['HTTP_HOST']\n+                && $msConfig['based_on_domains'] == 1)\n+        );\n+    }","path":"src/system/ExtensionsModule/Api/AdminApi.php","position":null,"original_position":92,"commit_id":"4f179cce26b927e00abdee6ca6c81d33439a04ca","original_commit_id":"afbb857047851acbdbbcf12683c419187cd17f2d","user":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=3","gravatar_id":"","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"body":"@Guite you never responded to my concerns here. ","created_at":"2016-03-20T11:34:02Z","updated_at":"2016-03-20T11:34:02Z","html_url":"https://github.com/zikula/core/pull/2804#discussion_r56762810","pull_request_url":"https://api.github.com/repos/zikula/core/pulls/2804","_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/comments/56762810"},"html":{"href":"https://github.com/zikula/core/pull/2804#discussion_r56762810"},"pull_request":{"href":"https://api.github.com/repos/zikula/core/pulls/2804"}}},"pull_request":{"url":"https://api.github.com/repos/zikula/core/pulls/2804","id":63248619,"html_url":"https://github.com/zikula/core/pull/2804","diff_url":"https://github.com/zikula/core/pull/2804.diff","patch_url":"https://github.com/zikula/core/pull/2804.patch","issue_url":"https://api.github.com/repos/zikula/core/issues/2804","number":2804,"state":"open","locked":false,"title":"minor cleanup regarding Multisites","user":{"login":"Guite","id":277531,"avatar_url":"https://avatars.githubusercontent.com/u/277531?v=3","gravatar_id":"","url":"https://api.github.com/users/Guite","html_url":"https://github.com/Guite","followers_url":"https://api.github.com/users/Guite/followers","following_url":"https://api.github.com/users/Guite/following{/other_user}","gists_url":"https://api.github.com/users/Guite/gists{/gist_id}","starred_url":"https://api.github.com/users/Guite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guite/subscriptions","organizations_url":"https://api.github.com/users/Guite/orgs","repos_url":"https://api.github.com/users/Guite/repos","events_url":"https://api.github.com/users/Guite/events{/privacy}","received_events_url":"https://api.github.com/users/Guite/received_events","type":"User","site_admin":false},"body":"| Q                 | A\r\n| ----------------- | ---\r\n| Bug fix?          | no\r\n| New feature?      | no\r\n| BC breaks?        | no\r\n| Deprecations?     | no\r\n| Tests pass?       | yes\r\n| Fixed tickets     | -\r\n| Refs tickets      | -\r\n| License           | MIT\r\n| Doc PR            | -\r\n| Changelog updated | no\r\n","created_at":"2016-03-17T16:09:46Z","updated_at":"2016-03-20T11:34:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77f39eb84b174c405e5bf21655c6632abdc0f7f3","assignee":null,"milestone":{"url":"https://api.github.com/repos/zikula/core/milestones/19","html_url":"https://github.com/zikula/core/milestones/1.4.2","labels_url":"https://api.github.com/repos/zikula/core/milestones/19/labels","id":1391003,"number":19,"title":"1.4.2","description":"second service release for 1.4.x series.","creator":{"login":"cmfcmf","id":2145092,"avatar_url":"https://avatars.githubusercontent.com/u/2145092?v=3","gravatar_id":"","url":"https://api.github.com/users/cmfcmf","html_url":"https://github.com/cmfcmf","followers_url":"https://api.github.com/users/cmfcmf/followers","following_url":"https://api.github.com/users/cmfcmf/following{/other_user}","gists_url":"https://api.github.com/users/cmfcmf/gists{/gist_id}","starred_url":"https://api.github.com/users/cmfcmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmfcmf/subscriptions","organizations_url":"https://api.github.com/users/cmfcmf/orgs","repos_url":"https://api.github.com/users/cmfcmf/repos","events_url":"https://api.github.com/users/cmfcmf/events{/privacy}","received_events_url":"https://api.github.com/users/cmfcmf/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":92,"state":"open","created_at":"2015-11-03T10:48:29Z","updated_at":"2016-03-19T19:23:45Z","due_on":"2016-03-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zikula/core/pulls/2804/commits","review_comments_url":"https://api.github.com/repos/zikula/core/pulls/2804/comments","review_comment_url":"https://api.github.com/repos/zikula/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zikula/core/issues/2804/comments","statuses_url":"https://api.github.com/repos/zikula/core/statuses/4f179cce26b927e00abdee6ca6c81d33439a04ca","head":{"label":"Guite:multisites","ref":"multisites","sha":"4f179cce26b927e00abdee6ca6c81d33439a04ca","user":{"login":"Guite","id":277531,"avatar_url":"https://avatars.githubusercontent.com/u/277531?v=3","gravatar_id":"","url":"https://api.github.com/users/Guite","html_url":"https://github.com/Guite","followers_url":"https://api.github.com/users/Guite/followers","following_url":"https://api.github.com/users/Guite/following{/other_user}","gists_url":"https://api.github.com/users/Guite/gists{/gist_id}","starred_url":"https://api.github.com/users/Guite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guite/subscriptions","organizations_url":"https://api.github.com/users/Guite/orgs","repos_url":"https://api.github.com/users/Guite/repos","events_url":"https://api.github.com/users/Guite/events{/privacy}","received_events_url":"https://api.github.com/users/Guite/received_events","type":"User","site_admin":false},"repo":{"id":49314136,"name":"core","full_name":"Guite/core","owner":{"login":"Guite","id":277531,"avatar_url":"https://avatars.githubusercontent.com/u/277531?v=3","gravatar_id":"","url":"https://api.github.com/users/Guite","html_url":"https://github.com/Guite","followers_url":"https://api.github.com/users/Guite/followers","following_url":"https://api.github.com/users/Guite/following{/other_user}","gists_url":"https://api.github.com/users/Guite/gists{/gist_id}","starred_url":"https://api.github.com/users/Guite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guite/subscriptions","organizations_url":"https://api.github.com/users/Guite/orgs","repos_url":"https://api.github.com/users/Guite/repos","events_url":"https://api.github.com/users/Guite/events{/privacy}","received_events_url":"https://api.github.com/users/Guite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Guite/core","description":"Zikula Core Framework","fork":true,"url":"https://api.github.com/repos/Guite/core","forks_url":"https://api.github.com/repos/Guite/core/forks","keys_url":"https://api.github.com/repos/Guite/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guite/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guite/core/teams","hooks_url":"https://api.github.com/repos/Guite/core/hooks","issue_events_url":"https://api.github.com/repos/Guite/core/issues/events{/number}","events_url":"https://api.github.com/repos/Guite/core/events","assignees_url":"https://api.github.com/repos/Guite/core/assignees{/user}","branches_url":"https://api.github.com/repos/Guite/core/branches{/branch}","tags_url":"https://api.github.com/repos/Guite/core/tags","blobs_url":"https://api.github.com/repos/Guite/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guite/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guite/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guite/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guite/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Guite/core/languages","stargazers_url":"https://api.github.com/repos/Guite/core/stargazers","contributors_url":"https://api.github.com/repos/Guite/core/contributors","subscribers_url":"https://api.github.com/repos/Guite/core/subscribers","subscription_url":"https://api.github.com/repos/Guite/core/subscription","commits_url":"https://api.github.com/repos/Guite/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guite/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guite/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guite/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guite/core/contents/{+path}","compare_url":"https://api.github.com/repos/Guite/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guite/core/merges","archive_url":"https://api.github.com/repos/Guite/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guite/core/downloads","issues_url":"https://api.github.com/repos/Guite/core/issues{/number}","pulls_url":"https://api.github.com/repos/Guite/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Guite/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Guite/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guite/core/labels{/name}","releases_url":"https://api.github.com/repos/Guite/core/releases{/id}","deployments_url":"https://api.github.com/repos/Guite/core/deployments","created_at":"2016-01-09T06:45:55Z","updated_at":"2016-01-12T21:15:15Z","pushed_at":"2016-03-18T13:26:36Z","git_url":"git://github.com/Guite/core.git","ssh_url":"git@github.com:Guite/core.git","clone_url":"https://github.com/Guite/core.git","svn_url":"https://github.com/Guite/core","homepage":"http://zikula.org/","size":57116,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.4"}},"base":{"label":"zikula:1.4","ref":"1.4","sha":"4f1232bea3d3eaa5953b6c1f9d27af1152924055","user":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"repo":{"id":781544,"name":"core","full_name":"zikula/core","owner":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zikula/core","description":"Zikula Core Framework","fork":false,"url":"https://api.github.com/repos/zikula/core","forks_url":"https://api.github.com/repos/zikula/core/forks","keys_url":"https://api.github.com/repos/zikula/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikula/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikula/core/teams","hooks_url":"https://api.github.com/repos/zikula/core/hooks","issue_events_url":"https://api.github.com/repos/zikula/core/issues/events{/number}","events_url":"https://api.github.com/repos/zikula/core/events","assignees_url":"https://api.github.com/repos/zikula/core/assignees{/user}","branches_url":"https://api.github.com/repos/zikula/core/branches{/branch}","tags_url":"https://api.github.com/repos/zikula/core/tags","blobs_url":"https://api.github.com/repos/zikula/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikula/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikula/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikula/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikula/core/statuses/{sha}","languages_url":"https://api.github.com/repos/zikula/core/languages","stargazers_url":"https://api.github.com/repos/zikula/core/stargazers","contributors_url":"https://api.github.com/repos/zikula/core/contributors","subscribers_url":"https://api.github.com/repos/zikula/core/subscribers","subscription_url":"https://api.github.com/repos/zikula/core/subscription","commits_url":"https://api.github.com/repos/zikula/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikula/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikula/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikula/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikula/core/contents/{+path}","compare_url":"https://api.github.com/repos/zikula/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikula/core/merges","archive_url":"https://api.github.com/repos/zikula/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikula/core/downloads","issues_url":"https://api.github.com/repos/zikula/core/issues{/number}","pulls_url":"https://api.github.com/repos/zikula/core/pulls{/number}","milestones_url":"https://api.github.com/repos/zikula/core/milestones{/number}","notifications_url":"https://api.github.com/repos/zikula/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikula/core/labels{/name}","releases_url":"https://api.github.com/repos/zikula/core/releases{/id}","deployments_url":"https://api.github.com/repos/zikula/core/deployments","created_at":"2010-07-18T10:35:53Z","updated_at":"2016-03-14T23:52:20Z","pushed_at":"2016-03-19T20:31:59Z","git_url":"git://github.com/zikula/core.git","ssh_url":"git@github.com:zikula/core.git","clone_url":"https://github.com/zikula/core.git","svn_url":"https://github.com/zikula/core","homepage":"http://zikula.org/","size":68538,"stargazers_count":176,"watchers_count":176,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":163,"forks":78,"open_issues":163,"watchers":176,"default_branch":"1.4"}},"_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/2804"},"html":{"href":"https://github.com/zikula/core/pull/2804"},"issue":{"href":"https://api.github.com/repos/zikula/core/issues/2804"},"comments":{"href":"https://api.github.com/repos/zikula/core/issues/2804/comments"},"review_comments":{"href":"https://api.github.com/repos/zikula/core/pulls/2804/comments"},"review_comment":{"href":"https://api.github.com/repos/zikula/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zikula/core/pulls/2804/commits"},"statuses":{"href":"https://api.github.com/repos/zikula/core/statuses/4f179cce26b927e00abdee6ca6c81d33439a04ca"}}}}