{"action":"opened","issue":{"url":"https://api.github.com/repos/pac4j/pac4j/issues/480","repository_url":"https://api.github.com/repos/pac4j/pac4j","labels_url":"https://api.github.com/repos/pac4j/pac4j/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/pac4j/pac4j/issues/480/comments","events_url":"https://api.github.com/repos/pac4j/pac4j/issues/480/events","html_url":"https://github.com/pac4j/pac4j/issues/480","id":133037697,"number":480,"title":"Don't include default port on https","user":{"login":"jonathanlabin","id":12402905,"avatar_url":"https://avatars.githubusercontent.com/u/12402905?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanlabin","html_url":"https://github.com/jonathanlabin","followers_url":"https://api.github.com/users/jonathanlabin/followers","following_url":"https://api.github.com/users/jonathanlabin/following{/other_user}","gists_url":"https://api.github.com/users/jonathanlabin/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanlabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanlabin/subscriptions","organizations_url":"https://api.github.com/users/jonathanlabin/orgs","repos_url":"https://api.github.com/users/jonathanlabin/repos","events_url":"https://api.github.com/users/jonathanlabin/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanlabin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-11T17:39:30Z","updated_at":"2016-02-11T17:39:30Z","closed_at":null,"body":"In https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/main/java/org/pac4j/core/http/RelativeCallbackUrlResolver.java#L36 the port number will be inserted into the URL even if it is the default HTTPS port.  This logic should really be of the form:\r\nIf ((http AND port != DEFAULT_PORT) OR (https AND port != DEFAULT_HTTP_PORT))\r\n\r\nThe corresponding DEFAULT_HTTP_PORT constant would also need to be created in https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/main/java/org/pac4j/core/context/HttpConstants.java"}}