{"action":"closed","issue":{"url":"https://api.github.com/repos/UniversityofHelsinki/mece-php/issues/2","repository_url":"https://api.github.com/repos/UniversityofHelsinki/mece-php","labels_url":"https://api.github.com/repos/UniversityofHelsinki/mece-php/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/UniversityofHelsinki/mece-php/issues/2/comments","events_url":"https://api.github.com/repos/UniversityofHelsinki/mece-php/issues/2/events","html_url":"https://github.com/UniversityofHelsinki/mece-php/issues/2","id":156689326,"number":2,"title":"A quick code review","user":{"login":"janipalsamaki","id":1157184,"avatar_url":"https://avatars.githubusercontent.com/u/1157184?v=3","gravatar_id":"","url":"https://api.github.com/users/janipalsamaki","html_url":"https://github.com/janipalsamaki","followers_url":"https://api.github.com/users/janipalsamaki/followers","following_url":"https://api.github.com/users/janipalsamaki/following{/other_user}","gists_url":"https://api.github.com/users/janipalsamaki/gists{/gist_id}","starred_url":"https://api.github.com/users/janipalsamaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janipalsamaki/subscriptions","organizations_url":"https://api.github.com/users/janipalsamaki/orgs","repos_url":"https://api.github.com/users/janipalsamaki/repos","events_url":"https://api.github.com/users/janipalsamaki/events{/privacy}","received_events_url":"https://api.github.com/users/janipalsamaki/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-25T08:17:29Z","updated_at":"2016-06-17T14:02:29Z","closed_at":"2016-06-17T14:02:29Z","body":"## Class reference is not case-sensitive\r\n\r\n`NotificationMessage.php`:260 (`new \\StdClass();`)\r\n\r\n## Typos (some of them)\r\n\r\n`Message.php`:74 (\"an string\" -> \"a string\")\r\n\r\n`Message.php`:78 (\"langauges\")\r\n\r\n`Message.php`:96 (\"an recipient\" -> \"a recipient\")\r\n\r\n`MultilingualStringValue.php`:38 (\"langauges\")\r\n\r\n`VersionTrait.php`:14 (\"accross\")\r\n\r\n`MultilingualStringValueTest`:48 (\"Langauge\")\r\n\r\n## Possibility to simplify code\r\n\r\n`NotificationMessage.php` (several places):\r\n \r\n`DateTime` instances can be compared directly as of PHP 5.2.2.\r\n \r\nInstead of:\r\n\r\n`if ($deadline->getTimestamp() > $this->getExpiration()->getTimestamp()) {`\r\n\r\nOne could write:\r\n\r\n`if ($deadline > $this->getExpiration()) {`\r\n\r\n## Possibly redundant (obvious) comments that provide no extra value\r\n\r\nThe most basic setter methods would not probably require an explanation that states the obvious, for example:\r\n\r\n```\r\n/**\r\n * Getter method for getting link.\r\n * @return MultilingualStringValue\r\n */\r\n public function getLink() {\r\n   return $this->link;\r\n }\r\n```\r\n\r\nThis might be enough:\r\n\r\n```\r\n/**\r\n * @return MultilingualStringValue\r\n */\r\n public function getLink() {\r\n   return $this->link;\r\n }\r\n```"}}
{"actor":{"display_login":"mikaelkundert"}}