{"action":"created","issue":{"url":"https://api.github.com/repos/servo/saltfs/issues/518","repository_url":"https://api.github.com/repos/servo/saltfs","labels_url":"https://api.github.com/repos/servo/saltfs/issues/518/labels{/name}","comments_url":"https://api.github.com/repos/servo/saltfs/issues/518/comments","events_url":"https://api.github.com/repos/servo/saltfs/issues/518/events","html_url":"https://github.com/servo/saltfs/pull/518","id":184277197,"number":518,"title":"add http-observatory tests","user":{"login":"jarondl","id":2776956,"avatar_url":"https://avatars.githubusercontent.com/u/2776956?v=3","gravatar_id":"","url":"https://api.github.com/users/jarondl","html_url":"https://github.com/jarondl","followers_url":"https://api.github.com/users/jarondl/followers","following_url":"https://api.github.com/users/jarondl/following{/other_user}","gists_url":"https://api.github.com/users/jarondl/gists{/gist_id}","starred_url":"https://api.github.com/users/jarondl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarondl/subscriptions","organizations_url":"https://api.github.com/users/jarondl/orgs","repos_url":"https://api.github.com/users/jarondl/repos","events_url":"https://api.github.com/users/jarondl/events{/privacy}","received_events_url":"https://api.github.com/users/jarondl/received_events","type":"User","site_admin":false},"labels":[{"id":409781844,"url":"https://api.github.com/repos/servo/saltfs/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"assignees":[{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-10-20T16:24:42Z","updated_at":"2016-10-31T15:34:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/saltfs/pulls/518","html_url":"https://github.com/servo/saltfs/pull/518","diff_url":"https://github.com/servo/saltfs/pull/518.diff","patch_url":"https://github.com/servo/saltfs/pull/518.patch"},"body":"Add a locally (docker) deployed http-observatory test.\nIt requires a minimum score of 65, and also prints the test results to\nstdout.\nHelps with #473.\nWill fail on travis for two reasons: \n1. #505 - buildbot does not run automatically on travis right now\n2. #511 - the security headers were not merged yet, so our score is 0\n\nThe code is not so elegant, running external code from within Python, but it works.\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/saltfs/518)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/saltfs/issues/comments/257327127","html_url":"https://github.com/servo/saltfs/pull/518#issuecomment-257327127","issue_url":"https://api.github.com/repos/servo/saltfs/issues/518","id":257327127,"user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T15:34:11Z","updated_at":"2016-10-31T15:34:11Z","body":"One note about integration: the tests already run under a Python3 interpreter, so you should be able to import the observatory modules and call functions directly from the test code, without needing a separate script/virtualenv and forking a separate Python process to run it."}}
{"actor":{"display_login":"aneeshusa"}}