{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1546","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1546/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1546/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1546/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1546","id":183331226,"number":1546,"title":"Provide gas at proper ratio","user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-17T05:55:00Z","updated_at":"2016-10-17T16:24:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1546","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1546","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1546.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1546.patch"},"body":"PR #1477 changed some of the intended behavior of the Oxygen Generator due to some of the details of how it was implemented. This PR attempts to restore the intended functionality with minimal alteration of GasConnection prior to a hopefully cohesive upgrade to the functionality of the GasConnection component that allows the Oxygen Generator to behave as intended without breaking other aspects of the component and without somewhat hackish workarounds. There was also a small error that would very occasionally crop up due to operating with a rounded version of the rooms gas pressure rather than the actual gas pressure.\r\n\r\nThe intended functionality was that the Oxygen Generator would have a set rate of gas production, and each gas produced would be produced at a portion of that rate relative to its target portion of gas. As of #1477 it was changed to each gas having a rate set individually. This PR sets the rates for each individually as it would be under the old system (original rate was 0.16, so o2 is 20% of that, or 0.032, and n2 is 80% of that, or 0.128). Future upgrades will hopefully allow the intended but unimplemented functionality (that was not easily achievable with LUA) of having the gas rate consistent, such that if the room was at the limit for N2 (and therefore the generator didn't need to produce any) it would produce O2 at a rate of 0.16.\r\n\r\nThe issue regarding the rounded gas pressure would cause it to stop producing gas before a room was entirely full as it was rounding the pressure, which would cause irregularities depending on game speed (particularly as game speed was changed) where the pressure would get close enough to the target pressure that it rounded to that amount. This PR removed the rounding so that it is working with the actual gas pressure, and leave the prettified rounding solely to the UI display."},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/254257596","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1546#issuecomment-254257596","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1546","id":254257596,"user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T16:24:09Z","updated_at":"2016-10-17T16:24:09Z","body":"I think so. Assuming xml as it is now would continue to produce as it does now?"}}
{"actor":{"display_login":"koosemose"}}