{"action":"created","comment":{"url":"https://api.github.com/repos/linnovate/mean/pulls/comments/82513777","pull_request_review_id":3418277,"id":82513777,"diff_hunk":"@@ -5,128 +5,168 @@ var gulpLoadPlugins = require('gulp-load-plugins')\n var through = require('through')\n var gutil = require('gulp-util')\n var plugins = gulpLoadPlugins()\n+var path = require('path')\n var paths = {\n   js: ['./*.js', 'config/**/*.js', 'gulp/**/*.js', 'tools/**/*.js', 'packages/**/*.js', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**', '!packages/**/assets/**/js/**'],\n   html: ['packages/**/*.html', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**'],\n-  css: ['packages/**/*.css', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**', '!packages/core/**/public/assets/css/*.css'],\n+  css: ['packages/**/*.css', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**'],\n   less: ['packages/**/*.less', '!packages/**/_*.less', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**'],\n-  sass: ['packages/**/*.scss', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**'],\n-  webpack: ['./app.js', 'packages/**/public/**/*.css', 'packages/**/public/**/*.js', '!packages/**/public/assets/lib/**', '!packages/**/node_modules/**']\n+  sass: ['packages/**/*.scss', '!packages/**/node_modules/**', '!packages/**/assets/**/lib/**']\n }\n var webpack = require('webpack')\n var webpackConfig = require('../webpack.config.js')\n \n-// var defaultTasks = ['clean', 'standard', 'less', 'csslint', 'devServe', 'watch']\n-var defaultTasks = ['webpack:build-dev', 'clean', 'less', 'sass', 'csslint', 'devServe', 'watch']\n+/** General watch/restart flow **/\n+// .less / .scss files are watched by less/sass and produce .css files\n+// .js / .css files are watched by nodemon, invoke webpack,csslint, and standard as needed before restarting and invoking livereload after\n+// .html files are watched by livereload explicitly\n \n-gulp.task('env:development', function () {\n-  process.env.NODE_ENV = 'development'\n-})\n+var startupTasks = ['devServe']\n \n-function count (taskName, message) {\n-  var fileCount = 0\n+gulp.task('development', startupTasks)\n+gulp.task('devServe', ['env:development', 'webpack:build-dev', 'standard', 'csslint', 'watch'], devServeTask)\n+gulp.task('env:development', envDevelopmentTask)\n+gulp.task('webpack:build-dev', ['sass', 'less'], webpackBuild)\n+gulp.task('sass', sassTask)\n+gulp.task('less', lessTask)\n+gulp.task('standard', standardTask)\n+gulp.task('csslint', csslintTask)\n \n-  function countFiles (file) {\n-    fileCount++\n-  }\n+gulp.task('webpack:rebuild-dev', webpackBuild)\n+gulp.task('watch', watchTask)\n+gulp.task('livereload', livereloadTask)\n \n-  function endStream () {\n-    gutil.log(gutil.colors.cyan(taskName + ': ') + fileCount + ' ' + message || 'files processed.')\n-    this.emit('end')\n-  }\n+////////////////////////////////////////////////////////////////////\n \n-  return through(countFiles, endStream)\n+// modify some webpack config options\n+var devConfig = Object.create(webpackConfig)\n+devConfig.devtool = 'sourcemap'\n+devConfig.debug = true\n+// create a single instance of the compiler to allow caching\n+var devCompiler = webpack(devConfig)\n+\n+function webpackBuild (callback) {\n+  // run webpack\n+  devCompiler.run(function (err, stats) {\n+    if (err) throw new gutil.PluginError('webpackBuild', err)\n+    gutil.log('webpackBuild', stats.toString({\n+      colors: true\n+    }))\n+    callback()\n+  })\n }\n \n-gulp.task('standard', function () {\n-  return gulp.src(paths.js)\n+function standardTask (callback) {\n+  gulp.src(paths.js)\n     .pipe(plugins.standard())\n     .pipe(plugins.standard.reporter('default', {\n       quiet: false,\n       breakOnError: true,\n       breakOnWarning: true\n     }))\n-})\n+  callback()\n+}\n+\n+function envDevelopmentTask (callback) {\n+  process.env.NODE_ENV = 'development'","path":"gulp/development.js","position":88,"original_position":88,"commit_id":"ace94d95474ee722d791c9dfe1613d1ad435cfd4","original_commit_id":"ace94d95474ee722d791c9dfe1613d1ad435cfd4","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2016-10-09T03:15:45Z","updated_at":"2016-10-09T03:15:45Z","html_url":"https://github.com/linnovate/mean/pull/1682#discussion_r82513777","pull_request_url":"https://api.github.com/repos/linnovate/mean/pulls/1682","_links":{"self":{"href":"https://api.github.com/repos/linnovate/mean/pulls/comments/82513777"},"html":{"href":"https://github.com/linnovate/mean/pull/1682#discussion_r82513777"},"pull_request":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1682"}}},"pull_request":{"url":"https://api.github.com/repos/linnovate/mean/pulls/1682","id":88566928,"html_url":"https://github.com/linnovate/mean/pull/1682","diff_url":"https://github.com/linnovate/mean/pull/1682.diff","patch_url":"https://github.com/linnovate/mean/pull/1682.patch","issue_url":"https://api.github.com/repos/linnovate/mean/issues/1682","number":1682,"state":"open","locked":false,"title":"Reworked development gulp - Fixes linnovate/mean#1674","user":{"login":"adskjohn","id":13243453,"avatar_url":"https://avatars.githubusercontent.com/u/13243453?v=3","gravatar_id":"","url":"https://api.github.com/users/adskjohn","html_url":"https://github.com/adskjohn","followers_url":"https://api.github.com/users/adskjohn/followers","following_url":"https://api.github.com/users/adskjohn/following{/other_user}","gists_url":"https://api.github.com/users/adskjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/adskjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adskjohn/subscriptions","organizations_url":"https://api.github.com/users/adskjohn/orgs","repos_url":"https://api.github.com/users/adskjohn/repos","events_url":"https://api.github.com/users/adskjohn/events{/privacy}","received_events_url":"https://api.github.com/users/adskjohn/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-09T03:15:39Z","updated_at":"2016-10-09T03:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab3f31efb453d9a359b5a978adaec57d3b2ce7a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linnovate/mean/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/linnovate/mean/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/linnovate/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linnovate/mean/issues/1682/comments","statuses_url":"https://api.github.com/repos/linnovate/mean/statuses/ace94d95474ee722d791c9dfe1613d1ad435cfd4","head":{"label":"autodesk-forks:update/gulp-rewrite","ref":"update/gulp-rewrite","sha":"ace94d95474ee722d791c9dfe1613d1ad435cfd4","user":{"login":"autodesk-forks","id":13626597,"avatar_url":"https://avatars.githubusercontent.com/u/13626597?v=3","gravatar_id":"","url":"https://api.github.com/users/autodesk-forks","html_url":"https://github.com/autodesk-forks","followers_url":"https://api.github.com/users/autodesk-forks/followers","following_url":"https://api.github.com/users/autodesk-forks/following{/other_user}","gists_url":"https://api.github.com/users/autodesk-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/autodesk-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autodesk-forks/subscriptions","organizations_url":"https://api.github.com/users/autodesk-forks/orgs","repos_url":"https://api.github.com/users/autodesk-forks/repos","events_url":"https://api.github.com/users/autodesk-forks/events{/privacy}","received_events_url":"https://api.github.com/users/autodesk-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":61817290,"name":"mean","full_name":"autodesk-forks/mean","owner":{"login":"autodesk-forks","id":13626597,"avatar_url":"https://avatars.githubusercontent.com/u/13626597?v=3","gravatar_id":"","url":"https://api.github.com/users/autodesk-forks","html_url":"https://github.com/autodesk-forks","followers_url":"https://api.github.com/users/autodesk-forks/followers","following_url":"https://api.github.com/users/autodesk-forks/following{/other_user}","gists_url":"https://api.github.com/users/autodesk-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/autodesk-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autodesk-forks/subscriptions","organizations_url":"https://api.github.com/users/autodesk-forks/orgs","repos_url":"https://api.github.com/users/autodesk-forks/repos","events_url":"https://api.github.com/users/autodesk-forks/events{/privacy}","received_events_url":"https://api.github.com/users/autodesk-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autodesk-forks/mean","description":"MEAN (Mongo, Express, Angular, Node) - A Simple, Scalable and Easy starting point for full stack javascript web development - utilizing many of the best practices we've found on the way","fork":true,"url":"https://api.github.com/repos/autodesk-forks/mean","forks_url":"https://api.github.com/repos/autodesk-forks/mean/forks","keys_url":"https://api.github.com/repos/autodesk-forks/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autodesk-forks/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autodesk-forks/mean/teams","hooks_url":"https://api.github.com/repos/autodesk-forks/mean/hooks","issue_events_url":"https://api.github.com/repos/autodesk-forks/mean/issues/events{/number}","events_url":"https://api.github.com/repos/autodesk-forks/mean/events","assignees_url":"https://api.github.com/repos/autodesk-forks/mean/assignees{/user}","branches_url":"https://api.github.com/repos/autodesk-forks/mean/branches{/branch}","tags_url":"https://api.github.com/repos/autodesk-forks/mean/tags","blobs_url":"https://api.github.com/repos/autodesk-forks/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autodesk-forks/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autodesk-forks/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/autodesk-forks/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autodesk-forks/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/autodesk-forks/mean/languages","stargazers_url":"https://api.github.com/repos/autodesk-forks/mean/stargazers","contributors_url":"https://api.github.com/repos/autodesk-forks/mean/contributors","subscribers_url":"https://api.github.com/repos/autodesk-forks/mean/subscribers","subscription_url":"https://api.github.com/repos/autodesk-forks/mean/subscription","commits_url":"https://api.github.com/repos/autodesk-forks/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/autodesk-forks/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/autodesk-forks/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/autodesk-forks/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/autodesk-forks/mean/contents/{+path}","compare_url":"https://api.github.com/repos/autodesk-forks/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autodesk-forks/mean/merges","archive_url":"https://api.github.com/repos/autodesk-forks/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autodesk-forks/mean/downloads","issues_url":"https://api.github.com/repos/autodesk-forks/mean/issues{/number}","pulls_url":"https://api.github.com/repos/autodesk-forks/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/autodesk-forks/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/autodesk-forks/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autodesk-forks/mean/labels{/name}","releases_url":"https://api.github.com/repos/autodesk-forks/mean/releases{/id}","deployments_url":"https://api.github.com/repos/autodesk-forks/mean/deployments","created_at":"2016-06-23T15:45:37Z","updated_at":"2016-06-23T15:45:38Z","pushed_at":"2016-10-09T03:14:53Z","git_url":"git://github.com/autodesk-forks/mean.git","ssh_url":"git@github.com:autodesk-forks/mean.git","clone_url":"https://github.com/autodesk-forks/mean.git","svn_url":"https://github.com/autodesk-forks/mean","homepage":"http://mean.io","size":7755,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linnovate:master","ref":"master","sha":"4162f2c44cec1b87b5a495f2e776845aa9b011d1","user":{"login":"linnovate","id":307487,"avatar_url":"https://avatars.githubusercontent.com/u/307487?v=3","gravatar_id":"","url":"https://api.github.com/users/linnovate","html_url":"https://github.com/linnovate","followers_url":"https://api.github.com/users/linnovate/followers","following_url":"https://api.github.com/users/linnovate/following{/other_user}","gists_url":"https://api.github.com/users/linnovate/gists{/gist_id}","starred_url":"https://api.github.com/users/linnovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linnovate/subscriptions","organizations_url":"https://api.github.com/users/linnovate/orgs","repos_url":"https://api.github.com/users/linnovate/repos","events_url":"https://api.github.com/users/linnovate/events{/privacy}","received_events_url":"https://api.github.com/users/linnovate/received_events","type":"Organization","site_admin":false},"repo":{"id":10219106,"name":"mean","full_name":"linnovate/mean","owner":{"login":"linnovate","id":307487,"avatar_url":"https://avatars.githubusercontent.com/u/307487?v=3","gravatar_id":"","url":"https://api.github.com/users/linnovate","html_url":"https://github.com/linnovate","followers_url":"https://api.github.com/users/linnovate/followers","following_url":"https://api.github.com/users/linnovate/following{/other_user}","gists_url":"https://api.github.com/users/linnovate/gists{/gist_id}","starred_url":"https://api.github.com/users/linnovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linnovate/subscriptions","organizations_url":"https://api.github.com/users/linnovate/orgs","repos_url":"https://api.github.com/users/linnovate/repos","events_url":"https://api.github.com/users/linnovate/events{/privacy}","received_events_url":"https://api.github.com/users/linnovate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linnovate/mean","description":"MEAN (Mongo, Express, Angular, Node) - A Simple, Scalable and Easy starting point for full stack javascript web development - utilizing many of the best practices we've found on the way","fork":false,"url":"https://api.github.com/repos/linnovate/mean","forks_url":"https://api.github.com/repos/linnovate/mean/forks","keys_url":"https://api.github.com/repos/linnovate/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linnovate/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linnovate/mean/teams","hooks_url":"https://api.github.com/repos/linnovate/mean/hooks","issue_events_url":"https://api.github.com/repos/linnovate/mean/issues/events{/number}","events_url":"https://api.github.com/repos/linnovate/mean/events","assignees_url":"https://api.github.com/repos/linnovate/mean/assignees{/user}","branches_url":"https://api.github.com/repos/linnovate/mean/branches{/branch}","tags_url":"https://api.github.com/repos/linnovate/mean/tags","blobs_url":"https://api.github.com/repos/linnovate/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linnovate/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linnovate/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/linnovate/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linnovate/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/linnovate/mean/languages","stargazers_url":"https://api.github.com/repos/linnovate/mean/stargazers","contributors_url":"https://api.github.com/repos/linnovate/mean/contributors","subscribers_url":"https://api.github.com/repos/linnovate/mean/subscribers","subscription_url":"https://api.github.com/repos/linnovate/mean/subscription","commits_url":"https://api.github.com/repos/linnovate/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/linnovate/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/linnovate/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/linnovate/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/linnovate/mean/contents/{+path}","compare_url":"https://api.github.com/repos/linnovate/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linnovate/mean/merges","archive_url":"https://api.github.com/repos/linnovate/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linnovate/mean/downloads","issues_url":"https://api.github.com/repos/linnovate/mean/issues{/number}","pulls_url":"https://api.github.com/repos/linnovate/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/linnovate/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/linnovate/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linnovate/mean/labels{/name}","releases_url":"https://api.github.com/repos/linnovate/mean/releases{/id}","deployments_url":"https://api.github.com/repos/linnovate/mean/deployments","created_at":"2013-05-22T12:15:47Z","updated_at":"2016-10-08T18:36:59Z","pushed_at":"2016-10-09T03:15:39Z","git_url":"git://github.com/linnovate/mean.git","ssh_url":"git@github.com:linnovate/mean.git","clone_url":"https://github.com/linnovate/mean.git","svn_url":"https://github.com/linnovate/mean","homepage":"http://mean.io","size":11751,"stargazers_count":9505,"watchers_count":9505,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2882,"mirror_url":null,"open_issues_count":168,"forks":2882,"open_issues":168,"watchers":9505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1682"},"html":{"href":"https://github.com/linnovate/mean/pull/1682"},"issue":{"href":"https://api.github.com/repos/linnovate/mean/issues/1682"},"comments":{"href":"https://api.github.com/repos/linnovate/mean/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/linnovate/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/linnovate/mean/statuses/ace94d95474ee722d791c9dfe1613d1ad435cfd4"}}}}
{"actor":{"display_login":"houndci-bot"}}