{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/2043","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/2043/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/2043/comments","events_url":"https://api.github.com/repos/keybase/client/issues/2043/events","html_url":"https://github.com/keybase/client/pull/2043","id":134114439,"number":2043,"title":"Tracker update states","user":{"login":"cjb","id":21217,"avatar_url":"https://avatars.githubusercontent.com/u/21217?v=3","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-16T22:29:11Z","updated_at":"2016-02-17T01:11:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/2043","html_url":"https://github.com/keybase/client/pull/2043","diff_url":"https://github.com/keybase/client/pull/2043.diff","patch_url":"https://github.com/keybase/client/pull/2043.patch"},"body":"@keybase/react-hackers\r\n\r\nI wanted to add some new trackerStates that @gabriel and I can each start using in trackerv2 straight away.  \"followed\" and \"refollowed\" correspond to states where you've performed some action and now the tracker popup just needs to say \"Close\".  There's also a \"followedProofsAdded\" state -- for when someone you follow added new proofs -- which we won't use immediately because we don't plan to do a popup for that yet.\r\n\r\nThe additions to trackerv1's `statusColor` map are necessary because it (and maybe other parts of the code!) makes the mistake of thinking that `SimpleProofState` is a *per-proof* state that it should make per-proof rendering decisions based on.  But `SimpleProofState` is actually the same thing as the \"global\" trackerState -- we probably should've called it `SimpleTrackerState` instead.\r\n\r\nI think that the `revoked` entry in `SimpleProofState` is actually a per-proof state that snuck in to our global tracker states.  But I guess I can re-use it for `unfollowed` without harm?"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/184959435","html_url":"https://github.com/keybase/client/pull/2043#issuecomment-184959435","issue_url":"https://api.github.com/repos/keybase/client/issues/2043","id":184959435,"user":{"login":"cjb","id":21217,"avatar_url":"https://avatars.githubusercontent.com/u/21217?v=3","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T01:11:04Z","updated_at":"2016-02-17T01:11:04Z","body":"Judging by convo on Slack, we're actually gonna split out TrackerState instead."}}