{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/miner/clj-ftp/pulls/22","id":74554103,"html_url":"https://github.com/miner/clj-ftp/pull/22","diff_url":"https://github.com/miner/clj-ftp/pull/22.diff","patch_url":"https://github.com/miner/clj-ftp/pull/22.patch","issue_url":"https://api.github.com/repos/miner/clj-ftp/issues/22","number":22,"state":"closed","locked":false,"title":"Don't double-decode URL user-info; fixes #21","user":{"login":"samroberton","id":1249650,"avatar_url":"https://avatars.githubusercontent.com/u/1249650?v=3","gravatar_id":"","url":"https://api.github.com/users/samroberton","html_url":"https://github.com/samroberton","followers_url":"https://api.github.com/users/samroberton/followers","following_url":"https://api.github.com/users/samroberton/following{/other_user}","gists_url":"https://api.github.com/users/samroberton/gists{/gist_id}","starred_url":"https://api.github.com/users/samroberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samroberton/subscriptions","organizations_url":"https://api.github.com/users/samroberton/orgs","repos_url":"https://api.github.com/users/samroberton/repos","events_url":"https://api.github.com/users/samroberton/events{/privacy}","received_events_url":"https://api.github.com/users/samroberton/received_events","type":"User","site_admin":false},"body":"The URL's user-info component was being decoded once by `urly`, and then\r\nsubsequently again by `with-ftp`.  If the username or password contains\r\na '%' character, the second decode will fail or produce the wrong result.\r\n\r\nThe commit removes `urly`, since it didn't seem to be adding much, and\r\nstill the bug is not properly fixable while still using it: `urly`\r\ndecodes the user-info before returning it, but this leads to ambiguity\r\nif the (decoded) username contains a ':' (unlikely, but legal).","created_at":"2016-06-21T05:41:06Z","updated_at":"2016-07-01T16:00:09Z","closed_at":"2016-07-01T16:00:08Z","merged_at":"2016-07-01T16:00:08Z","merge_commit_sha":"1a7dd22800baad130cfb32f51a7df8911d31de30","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miner/clj-ftp/pulls/22/commits","review_comments_url":"https://api.github.com/repos/miner/clj-ftp/pulls/22/comments","review_comment_url":"https://api.github.com/repos/miner/clj-ftp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miner/clj-ftp/issues/22/comments","statuses_url":"https://api.github.com/repos/miner/clj-ftp/statuses/e0fae12ceab83cb9767d843397aa57746041d918","head":{"label":"samroberton:dont-double-decode-user-info","ref":"dont-double-decode-user-info","sha":"e0fae12ceab83cb9767d843397aa57746041d918","user":{"login":"samroberton","id":1249650,"avatar_url":"https://avatars.githubusercontent.com/u/1249650?v=3","gravatar_id":"","url":"https://api.github.com/users/samroberton","html_url":"https://github.com/samroberton","followers_url":"https://api.github.com/users/samroberton/followers","following_url":"https://api.github.com/users/samroberton/following{/other_user}","gists_url":"https://api.github.com/users/samroberton/gists{/gist_id}","starred_url":"https://api.github.com/users/samroberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samroberton/subscriptions","organizations_url":"https://api.github.com/users/samroberton/orgs","repos_url":"https://api.github.com/users/samroberton/repos","events_url":"https://api.github.com/users/samroberton/events{/privacy}","received_events_url":"https://api.github.com/users/samroberton/received_events","type":"User","site_admin":false},"repo":{"id":61605249,"name":"clj-ftp","full_name":"samroberton/clj-ftp","owner":{"login":"samroberton","id":1249650,"avatar_url":"https://avatars.githubusercontent.com/u/1249650?v=3","gravatar_id":"","url":"https://api.github.com/users/samroberton","html_url":"https://github.com/samroberton","followers_url":"https://api.github.com/users/samroberton/followers","following_url":"https://api.github.com/users/samroberton/following{/other_user}","gists_url":"https://api.github.com/users/samroberton/gists{/gist_id}","starred_url":"https://api.github.com/users/samroberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samroberton/subscriptions","organizations_url":"https://api.github.com/users/samroberton/orgs","repos_url":"https://api.github.com/users/samroberton/repos","events_url":"https://api.github.com/users/samroberton/events{/privacy}","received_events_url":"https://api.github.com/users/samroberton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samroberton/clj-ftp","description":"Clojure wrapper for Apache Commons Net for basic FTP","fork":true,"url":"https://api.github.com/repos/samroberton/clj-ftp","forks_url":"https://api.github.com/repos/samroberton/clj-ftp/forks","keys_url":"https://api.github.com/repos/samroberton/clj-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samroberton/clj-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samroberton/clj-ftp/teams","hooks_url":"https://api.github.com/repos/samroberton/clj-ftp/hooks","issue_events_url":"https://api.github.com/repos/samroberton/clj-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/samroberton/clj-ftp/events","assignees_url":"https://api.github.com/repos/samroberton/clj-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/samroberton/clj-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/samroberton/clj-ftp/tags","blobs_url":"https://api.github.com/repos/samroberton/clj-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samroberton/clj-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samroberton/clj-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/samroberton/clj-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samroberton/clj-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/samroberton/clj-ftp/languages","stargazers_url":"https://api.github.com/repos/samroberton/clj-ftp/stargazers","contributors_url":"https://api.github.com/repos/samroberton/clj-ftp/contributors","subscribers_url":"https://api.github.com/repos/samroberton/clj-ftp/subscribers","subscription_url":"https://api.github.com/repos/samroberton/clj-ftp/subscription","commits_url":"https://api.github.com/repos/samroberton/clj-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/samroberton/clj-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/samroberton/clj-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/samroberton/clj-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/samroberton/clj-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/samroberton/clj-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samroberton/clj-ftp/merges","archive_url":"https://api.github.com/repos/samroberton/clj-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samroberton/clj-ftp/downloads","issues_url":"https://api.github.com/repos/samroberton/clj-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/samroberton/clj-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/samroberton/clj-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/samroberton/clj-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samroberton/clj-ftp/labels{/name}","releases_url":"https://api.github.com/repos/samroberton/clj-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/samroberton/clj-ftp/deployments","created_at":"2016-06-21T05:39:24Z","updated_at":"2016-06-21T05:39:25Z","pushed_at":"2016-06-21T05:40:00Z","git_url":"git://github.com/samroberton/clj-ftp.git","ssh_url":"git@github.com:samroberton/clj-ftp.git","clone_url":"https://github.com/samroberton/clj-ftp.git","svn_url":"https://github.com/samroberton/clj-ftp","homepage":null,"size":1891,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miner:master","ref":"master","sha":"ca7fe38ea051d77ef7ee6d0d0689ecd93ad0227c","user":{"login":"miner","id":25400,"avatar_url":"https://avatars.githubusercontent.com/u/25400?v=3","gravatar_id":"","url":"https://api.github.com/users/miner","html_url":"https://github.com/miner","followers_url":"https://api.github.com/users/miner/followers","following_url":"https://api.github.com/users/miner/following{/other_user}","gists_url":"https://api.github.com/users/miner/gists{/gist_id}","starred_url":"https://api.github.com/users/miner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miner/subscriptions","organizations_url":"https://api.github.com/users/miner/orgs","repos_url":"https://api.github.com/users/miner/repos","events_url":"https://api.github.com/users/miner/events{/privacy}","received_events_url":"https://api.github.com/users/miner/received_events","type":"User","site_admin":false},"repo":{"id":4513609,"name":"clj-ftp","full_name":"miner/clj-ftp","owner":{"login":"miner","id":25400,"avatar_url":"https://avatars.githubusercontent.com/u/25400?v=3","gravatar_id":"","url":"https://api.github.com/users/miner","html_url":"https://github.com/miner","followers_url":"https://api.github.com/users/miner/followers","following_url":"https://api.github.com/users/miner/following{/other_user}","gists_url":"https://api.github.com/users/miner/gists{/gist_id}","starred_url":"https://api.github.com/users/miner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miner/subscriptions","organizations_url":"https://api.github.com/users/miner/orgs","repos_url":"https://api.github.com/users/miner/repos","events_url":"https://api.github.com/users/miner/events{/privacy}","received_events_url":"https://api.github.com/users/miner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miner/clj-ftp","description":"Clojure wrapper for Apache Commons Net for basic FTP","fork":false,"url":"https://api.github.com/repos/miner/clj-ftp","forks_url":"https://api.github.com/repos/miner/clj-ftp/forks","keys_url":"https://api.github.com/repos/miner/clj-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miner/clj-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miner/clj-ftp/teams","hooks_url":"https://api.github.com/repos/miner/clj-ftp/hooks","issue_events_url":"https://api.github.com/repos/miner/clj-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/miner/clj-ftp/events","assignees_url":"https://api.github.com/repos/miner/clj-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/miner/clj-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/miner/clj-ftp/tags","blobs_url":"https://api.github.com/repos/miner/clj-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miner/clj-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miner/clj-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/miner/clj-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miner/clj-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/miner/clj-ftp/languages","stargazers_url":"https://api.github.com/repos/miner/clj-ftp/stargazers","contributors_url":"https://api.github.com/repos/miner/clj-ftp/contributors","subscribers_url":"https://api.github.com/repos/miner/clj-ftp/subscribers","subscription_url":"https://api.github.com/repos/miner/clj-ftp/subscription","commits_url":"https://api.github.com/repos/miner/clj-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/miner/clj-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/miner/clj-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/miner/clj-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/miner/clj-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/miner/clj-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miner/clj-ftp/merges","archive_url":"https://api.github.com/repos/miner/clj-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miner/clj-ftp/downloads","issues_url":"https://api.github.com/repos/miner/clj-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/miner/clj-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/miner/clj-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/miner/clj-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miner/clj-ftp/labels{/name}","releases_url":"https://api.github.com/repos/miner/clj-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/miner/clj-ftp/deployments","created_at":"2012-05-31T22:16:25Z","updated_at":"2016-05-18T12:17:12Z","pushed_at":"2016-07-01T16:00:09Z","git_url":"git://github.com/miner/clj-ftp.git","ssh_url":"git@github.com:miner/clj-ftp.git","clone_url":"https://github.com/miner/clj-ftp.git","svn_url":"https://github.com/miner/clj-ftp","homepage":null,"size":1897,"stargazers_count":19,"watchers_count":19,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miner/clj-ftp/pulls/22"},"html":{"href":"https://github.com/miner/clj-ftp/pull/22"},"issue":{"href":"https://api.github.com/repos/miner/clj-ftp/issues/22"},"comments":{"href":"https://api.github.com/repos/miner/clj-ftp/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/miner/clj-ftp/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/miner/clj-ftp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miner/clj-ftp/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/miner/clj-ftp/statuses/e0fae12ceab83cb9767d843397aa57746041d918"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"miner","id":25400,"avatar_url":"https://avatars.githubusercontent.com/u/25400?v=3","gravatar_id":"","url":"https://api.github.com/users/miner","html_url":"https://github.com/miner","followers_url":"https://api.github.com/users/miner/followers","following_url":"https://api.github.com/users/miner/following{/other_user}","gists_url":"https://api.github.com/users/miner/gists{/gist_id}","starred_url":"https://api.github.com/users/miner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miner/subscriptions","organizations_url":"https://api.github.com/users/miner/orgs","repos_url":"https://api.github.com/users/miner/repos","events_url":"https://api.github.com/users/miner/events{/privacy}","received_events_url":"https://api.github.com/users/miner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"miner"}}