{"action":"created","issue":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3238","repository_url":"https://api.github.com/repos/Project-OSRM/osrm-backend","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3238/labels{/name}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3238/comments","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3238/events","html_url":"https://github.com/Project-OSRM/osrm-backend/issues/3238","id":187032784,"number":3238,"title":"Rename QueryNode to NodeLocation or similar","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"labels":[{"id":336727645,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels/Refactor","name":"Refactor","color":"009800","default":false},{"id":431299891,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels/Starter%20Task","name":"Starter Task","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/20","html_url":"https://github.com/Project-OSRM/osrm-backend/milestones/5.6.0","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/20/labels","id":1985499,"number":20,"title":"5.6.0","description":"","creator":{"login":"MoKob","id":12932279,"avatar_url":"https://avatars.githubusercontent.com/u/12932279?v=3","gravatar_id":"","url":"https://api.github.com/users/MoKob","html_url":"https://github.com/MoKob","followers_url":"https://api.github.com/users/MoKob/followers","following_url":"https://api.github.com/users/MoKob/following{/other_user}","gists_url":"https://api.github.com/users/MoKob/gists{/gist_id}","starred_url":"https://api.github.com/users/MoKob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoKob/subscriptions","organizations_url":"https://api.github.com/users/MoKob/orgs","repos_url":"https://api.github.com/users/MoKob/repos","events_url":"https://api.github.com/users/MoKob/events{/privacy}","received_events_url":"https://api.github.com/users/MoKob/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":11,"state":"open","created_at":"2016-09-06T07:09:04Z","updated_at":"2016-11-14T17:36:03Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-11-03T11:19:14Z","updated_at":"2016-11-15T00:15:24Z","closed_at":null,"body":"`QueryNode` really is `(lon, lat, osm node id)`.\r\n\"QueryNode\" makes this more confusing than it has to be.\r\n\r\nIn addition, `QueryNode` stores two variables `FixedLongitude`, `FixedLatitude`. We have an abstraction for this: `Coordinate` which already provides functionality for comparison, conversion and so on.\r\n\r\n`QueryNode` should just inherit from `Coordinate` and add a osm node id to the mix."},"comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments/260506414","html_url":"https://github.com/Project-OSRM/osrm-backend/issues/3238#issuecomment-260506414","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3238","id":260506414,"user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T00:15:24Z","updated_at":"2016-11-15T00:15:24Z","body":"For the record (and my understanding) this is where we write the `QueryNode` into the `.osrm.nodes` file: https://github.com/Project-OSRM/osrm-backend/blob/538bbd47d1ee169764b66df3ef67ecfe131cdfec/src/extractor/extractor.cpp#L523-L536\r\n\r\nThe extractor already writes `ExternalMemoryNodes` (think `QueryNode` + barrier / traffic signal) into the `.osrm` file. And then immediately reads it in again. Should be refactored, too."}}
{"actor":{"display_login":"daniel-j-h"}}