{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/77368216","id":77368216,"diff_hunk":"@@ -33,15 +33,17 @@\n \n     if $::osfamily =~ /windows/ {\n       $local_package_file_path = windows_native_path(\"${::puppet_agent::params::local_packages_dir}/${package_file_name}\")\n+      $mode = '0664'","path":"manifests/prepare/package.pp","position":4,"original_position":4,"commit_id":"0ecc9f4703d04c73b2a68c86460c46b9dfd5603f","original_commit_id":"0ecc9f4703d04c73b2a68c86460c46b9dfd5603f","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"I concur with `undef` being sufficient on Windows.","created_at":"2016-09-02T15:46:19Z","updated_at":"2016-09-02T15:46:19Z","html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147#discussion_r77368216","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/77368216"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147#discussion_r77368216"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147","id":82599484,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147","diff_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/147","number":147,"state":"open","locked":false,"title":"Set perms for Windows package differently than for Linux","user":{"login":"esalberg","id":9370354,"avatar_url":"https://avatars.githubusercontent.com/u/9370354?v=3","gravatar_id":"","url":"https://api.github.com/users/esalberg","html_url":"https://github.com/esalberg","followers_url":"https://api.github.com/users/esalberg/followers","following_url":"https://api.github.com/users/esalberg/following{/other_user}","gists_url":"https://api.github.com/users/esalberg/gists{/gist_id}","starred_url":"https://api.github.com/users/esalberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esalberg/subscriptions","organizations_url":"https://api.github.com/users/esalberg/orgs","repos_url":"https://api.github.com/users/esalberg/repos","events_url":"https://api.github.com/users/esalberg/events{/privacy}","received_events_url":"https://api.github.com/users/esalberg/received_events","type":"User","site_admin":false},"body":"See issue:\r\nhttps://github.com/puppetlabs/puppetlabs-puppet_agent/issues/146\r\n\r\nAll I did was set the Windows permissions on that file to be 0664 and leave everything else 0644.  I don't know if this is the correct way to patch what I was seeing or not, but I figured I'd put in the PR anyway.  I'll have more testing done in the next couple of days as I move all my agents to PE 2016.","created_at":"2016-08-24T19:07:22Z","updated_at":"2016-09-02T15:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c18361565311718a741a350ada31604aa810ee05","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/147/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/0ecc9f4703d04c73b2a68c86460c46b9dfd5603f","head":{"label":"esalberg:msi_perms","ref":"msi_perms","sha":"0ecc9f4703d04c73b2a68c86460c46b9dfd5603f","user":{"login":"esalberg","id":9370354,"avatar_url":"https://avatars.githubusercontent.com/u/9370354?v=3","gravatar_id":"","url":"https://api.github.com/users/esalberg","html_url":"https://github.com/esalberg","followers_url":"https://api.github.com/users/esalberg/followers","following_url":"https://api.github.com/users/esalberg/following{/other_user}","gists_url":"https://api.github.com/users/esalberg/gists{/gist_id}","starred_url":"https://api.github.com/users/esalberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esalberg/subscriptions","organizations_url":"https://api.github.com/users/esalberg/orgs","repos_url":"https://api.github.com/users/esalberg/repos","events_url":"https://api.github.com/users/esalberg/events{/privacy}","received_events_url":"https://api.github.com/users/esalberg/received_events","type":"User","site_admin":false},"repo":{"id":66488071,"name":"puppetlabs-puppet_agent","full_name":"esalberg/puppetlabs-puppet_agent","owner":{"login":"esalberg","id":9370354,"avatar_url":"https://avatars.githubusercontent.com/u/9370354?v=3","gravatar_id":"","url":"https://api.github.com/users/esalberg","html_url":"https://github.com/esalberg","followers_url":"https://api.github.com/users/esalberg/followers","following_url":"https://api.github.com/users/esalberg/following{/other_user}","gists_url":"https://api.github.com/users/esalberg/gists{/gist_id}","starred_url":"https://api.github.com/users/esalberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esalberg/subscriptions","organizations_url":"https://api.github.com/users/esalberg/orgs","repos_url":"https://api.github.com/users/esalberg/repos","events_url":"https://api.github.com/users/esalberg/events{/privacy}","received_events_url":"https://api.github.com/users/esalberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esalberg/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":true,"url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/esalberg/puppetlabs-puppet_agent/deployments","created_at":"2016-08-24T18:11:53Z","updated_at":"2016-08-24T18:11:54Z","pushed_at":"2016-08-31T18:27:41Z","git_url":"git://github.com/esalberg/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:esalberg/puppetlabs-puppet_agent.git","clone_url":"https://github.com/esalberg/puppetlabs-puppet_agent.git","svn_url":"https://github.com/esalberg/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/MODULES","size":371,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"57d2caea480b821c21577a1985311a4a0bd13dea","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":35058943,"name":"puppetlabs-puppet_agent","full_name":"puppetlabs/puppetlabs-puppet_agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/deployments","created_at":"2015-05-04T20:50:16Z","updated_at":"2016-07-19T17:06:08Z","pushed_at":"2016-08-25T17:49:06Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppet_agent.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/MODULES","size":600,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":9,"forks":47,"open_issues":9,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/147"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/147"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/0ecc9f4703d04c73b2a68c86460c46b9dfd5603f"}}}}
{"actor":{"display_login":"MikaelSmith"}}