{"action":"created","comment":{"url":"https://api.github.com/repos/dart-atom/dartlang/pulls/comments/65819779","id":65819779,"diff_hunk":"@@ -81,14 +81,14 @@ class Server {\n   }\n \n   void _processMessage(String message) {\n-    if (message.startsWith('#')) return;\n-    if (message.startsWith('Observatory listening on')) return;\n-    if (message.startsWith('Could not start Observatory')) return;\n-    if (message.startsWith('SocketException: ')) return;\n+    _onReceive.add(message);\n \n-    try {\n-      _onReceive.add(message);\n+    if (!message.startsWith('{')) {\n+      _logger.warning('unknown message: ${message}');\n+      return;\n+    }\n \n+    try {\n       var json = JSON.decode(message);","path":"lib/analysis/analysis_server_lib.dart","position":18,"original_position":18,"commit_id":"4d974b8b94cf446d8c26c66d9b95ef33ec5ef4e5","original_commit_id":"4d974b8b94cf446d8c26c66d9b95ef33ec5ef4e5","user":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"body":"try/catch around JSON.decode ?","created_at":"2016-06-05T15:56:35Z","updated_at":"2016-06-05T15:56:35Z","html_url":"https://github.com/dart-atom/dartlang/pull/1019#discussion_r65819779","pull_request_url":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019","_links":{"self":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/comments/65819779"},"html":{"href":"https://github.com/dart-atom/dartlang/pull/1019#discussion_r65819779"},"pull_request":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019"}}},"pull_request":{"url":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019","id":72614670,"html_url":"https://github.com/dart-atom/dartlang/pull/1019","diff_url":"https://github.com/dart-atom/dartlang/pull/1019.diff","patch_url":"https://github.com/dart-atom/dartlang/pull/1019.patch","issue_url":"https://api.github.com/repos/dart-atom/dartlang/issues/1019","number":1019,"state":"closed","locked":false,"title":"show the information about the analysis server's obs. port","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"- show the information about the analysis server's obs. port\r\n- make the analysis server debug option visible on the settings page\r\n\r\n<img width=\"298\" alt=\"screen shot 2016-06-04 at 3 18 34 pm\" src=\"https://cloud.githubusercontent.com/assets/1269969/15802448/dcd77bba-2a67-11e6-8e3a-87b577dce8d8.png\">\r\n\r\n@danrubel (likely will TBR)\r\n","created_at":"2016-06-04T22:20:32Z","updated_at":"2016-06-05T15:56:35Z","closed_at":"2016-06-04T22:26:31Z","merged_at":"2016-06-04T22:26:31Z","merge_commit_sha":"e3867c183b77b6371fc0673a2073645b3d3a6897","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/dart-atom/dartlang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-atom/dartlang/issues/1019/comments","statuses_url":"https://api.github.com/repos/dart-atom/dartlang/statuses/4d974b8b94cf446d8c26c66d9b95ef33ec5ef4e5","head":{"label":"dart-atom:show_obs_port","ref":"show_obs_port","sha":"4d974b8b94cf446d8c26c66d9b95ef33ec5ef4e5","user":{"login":"dart-atom","id":13003945,"avatar_url":"https://avatars.githubusercontent.com/u/13003945?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-atom","html_url":"https://github.com/dart-atom","followers_url":"https://api.github.com/users/dart-atom/followers","following_url":"https://api.github.com/users/dart-atom/following{/other_user}","gists_url":"https://api.github.com/users/dart-atom/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-atom/subscriptions","organizations_url":"https://api.github.com/users/dart-atom/orgs","repos_url":"https://api.github.com/users/dart-atom/repos","events_url":"https://api.github.com/users/dart-atom/events{/privacy}","received_events_url":"https://api.github.com/users/dart-atom/received_events","type":"Organization","site_admin":false},"repo":{"id":38737233,"name":"dartlang","full_name":"dart-atom/dartlang","owner":{"login":"dart-atom","id":13003945,"avatar_url":"https://avatars.githubusercontent.com/u/13003945?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-atom","html_url":"https://github.com/dart-atom","followers_url":"https://api.github.com/users/dart-atom/followers","following_url":"https://api.github.com/users/dart-atom/following{/other_user}","gists_url":"https://api.github.com/users/dart-atom/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-atom/subscriptions","organizations_url":"https://api.github.com/users/dart-atom/orgs","repos_url":"https://api.github.com/users/dart-atom/repos","events_url":"https://api.github.com/users/dart-atom/events{/privacy}","received_events_url":"https://api.github.com/users/dart-atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-atom/dartlang","description":"A Dart plugin for Atom.","fork":false,"url":"https://api.github.com/repos/dart-atom/dartlang","forks_url":"https://api.github.com/repos/dart-atom/dartlang/forks","keys_url":"https://api.github.com/repos/dart-atom/dartlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-atom/dartlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-atom/dartlang/teams","hooks_url":"https://api.github.com/repos/dart-atom/dartlang/hooks","issue_events_url":"https://api.github.com/repos/dart-atom/dartlang/issues/events{/number}","events_url":"https://api.github.com/repos/dart-atom/dartlang/events","assignees_url":"https://api.github.com/repos/dart-atom/dartlang/assignees{/user}","branches_url":"https://api.github.com/repos/dart-atom/dartlang/branches{/branch}","tags_url":"https://api.github.com/repos/dart-atom/dartlang/tags","blobs_url":"https://api.github.com/repos/dart-atom/dartlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-atom/dartlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-atom/dartlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-atom/dartlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-atom/dartlang/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-atom/dartlang/languages","stargazers_url":"https://api.github.com/repos/dart-atom/dartlang/stargazers","contributors_url":"https://api.github.com/repos/dart-atom/dartlang/contributors","subscribers_url":"https://api.github.com/repos/dart-atom/dartlang/subscribers","subscription_url":"https://api.github.com/repos/dart-atom/dartlang/subscription","commits_url":"https://api.github.com/repos/dart-atom/dartlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-atom/dartlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-atom/dartlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-atom/dartlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-atom/dartlang/contents/{+path}","compare_url":"https://api.github.com/repos/dart-atom/dartlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-atom/dartlang/merges","archive_url":"https://api.github.com/repos/dart-atom/dartlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-atom/dartlang/downloads","issues_url":"https://api.github.com/repos/dart-atom/dartlang/issues{/number}","pulls_url":"https://api.github.com/repos/dart-atom/dartlang/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-atom/dartlang/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-atom/dartlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-atom/dartlang/labels{/name}","releases_url":"https://api.github.com/repos/dart-atom/dartlang/releases{/id}","deployments_url":"https://api.github.com/repos/dart-atom/dartlang/deployments","created_at":"2015-07-08T06:49:44Z","updated_at":"2016-06-05T03:48:38Z","pushed_at":"2016-06-04T23:08:10Z","git_url":"git://github.com/dart-atom/dartlang.git","ssh_url":"git@github.com:dart-atom/dartlang.git","clone_url":"https://github.com/dart-atom/dartlang.git","svn_url":"https://github.com/dart-atom/dartlang","homepage":"http://dart-atom.github.io/dartlang/","size":31453,"stargazers_count":92,"watchers_count":92,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":201,"forks":23,"open_issues":201,"watchers":92,"default_branch":"master"}},"base":{"label":"dart-atom:master","ref":"master","sha":"f1d403b08523483c84ae717555b9436037eca07c","user":{"login":"dart-atom","id":13003945,"avatar_url":"https://avatars.githubusercontent.com/u/13003945?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-atom","html_url":"https://github.com/dart-atom","followers_url":"https://api.github.com/users/dart-atom/followers","following_url":"https://api.github.com/users/dart-atom/following{/other_user}","gists_url":"https://api.github.com/users/dart-atom/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-atom/subscriptions","organizations_url":"https://api.github.com/users/dart-atom/orgs","repos_url":"https://api.github.com/users/dart-atom/repos","events_url":"https://api.github.com/users/dart-atom/events{/privacy}","received_events_url":"https://api.github.com/users/dart-atom/received_events","type":"Organization","site_admin":false},"repo":{"id":38737233,"name":"dartlang","full_name":"dart-atom/dartlang","owner":{"login":"dart-atom","id":13003945,"avatar_url":"https://avatars.githubusercontent.com/u/13003945?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-atom","html_url":"https://github.com/dart-atom","followers_url":"https://api.github.com/users/dart-atom/followers","following_url":"https://api.github.com/users/dart-atom/following{/other_user}","gists_url":"https://api.github.com/users/dart-atom/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-atom/subscriptions","organizations_url":"https://api.github.com/users/dart-atom/orgs","repos_url":"https://api.github.com/users/dart-atom/repos","events_url":"https://api.github.com/users/dart-atom/events{/privacy}","received_events_url":"https://api.github.com/users/dart-atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-atom/dartlang","description":"A Dart plugin for Atom.","fork":false,"url":"https://api.github.com/repos/dart-atom/dartlang","forks_url":"https://api.github.com/repos/dart-atom/dartlang/forks","keys_url":"https://api.github.com/repos/dart-atom/dartlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-atom/dartlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-atom/dartlang/teams","hooks_url":"https://api.github.com/repos/dart-atom/dartlang/hooks","issue_events_url":"https://api.github.com/repos/dart-atom/dartlang/issues/events{/number}","events_url":"https://api.github.com/repos/dart-atom/dartlang/events","assignees_url":"https://api.github.com/repos/dart-atom/dartlang/assignees{/user}","branches_url":"https://api.github.com/repos/dart-atom/dartlang/branches{/branch}","tags_url":"https://api.github.com/repos/dart-atom/dartlang/tags","blobs_url":"https://api.github.com/repos/dart-atom/dartlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-atom/dartlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-atom/dartlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-atom/dartlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-atom/dartlang/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-atom/dartlang/languages","stargazers_url":"https://api.github.com/repos/dart-atom/dartlang/stargazers","contributors_url":"https://api.github.com/repos/dart-atom/dartlang/contributors","subscribers_url":"https://api.github.com/repos/dart-atom/dartlang/subscribers","subscription_url":"https://api.github.com/repos/dart-atom/dartlang/subscription","commits_url":"https://api.github.com/repos/dart-atom/dartlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-atom/dartlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-atom/dartlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-atom/dartlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-atom/dartlang/contents/{+path}","compare_url":"https://api.github.com/repos/dart-atom/dartlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-atom/dartlang/merges","archive_url":"https://api.github.com/repos/dart-atom/dartlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-atom/dartlang/downloads","issues_url":"https://api.github.com/repos/dart-atom/dartlang/issues{/number}","pulls_url":"https://api.github.com/repos/dart-atom/dartlang/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-atom/dartlang/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-atom/dartlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-atom/dartlang/labels{/name}","releases_url":"https://api.github.com/repos/dart-atom/dartlang/releases{/id}","deployments_url":"https://api.github.com/repos/dart-atom/dartlang/deployments","created_at":"2015-07-08T06:49:44Z","updated_at":"2016-06-05T03:48:38Z","pushed_at":"2016-06-04T23:08:10Z","git_url":"git://github.com/dart-atom/dartlang.git","ssh_url":"git@github.com:dart-atom/dartlang.git","clone_url":"https://github.com/dart-atom/dartlang.git","svn_url":"https://github.com/dart-atom/dartlang","homepage":"http://dart-atom.github.io/dartlang/","size":31453,"stargazers_count":92,"watchers_count":92,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":201,"forks":23,"open_issues":201,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019"},"html":{"href":"https://github.com/dart-atom/dartlang/pull/1019"},"issue":{"href":"https://api.github.com/repos/dart-atom/dartlang/issues/1019"},"comments":{"href":"https://api.github.com/repos/dart-atom/dartlang/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-atom/dartlang/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/dart-atom/dartlang/statuses/4d974b8b94cf446d8c26c66d9b95ef33ec5ef4e5"}}}}
{"actor":{"display_login":"danrubel"}}