{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/68438839","id":68438839,"diff_hunk":"@@ -36,13 +93,15 @@ module.exports = function(version_, agent_) {\n     return {};\n   }\n   return {\n-    'src/node/src/grpc_extension.js': {\n-      patch: function(extension) {\n+    'src/node/src/client.js': {\n+      patch: function(client) {\n         agent = agent_;\n-        shimmer.wrap(extension.Call.prototype, 'startBatch', startBatchWrap);\n+        shimmer.wrap(client, 'makeClientConstructor',\n+            makeClientConstructorWrap);\n       },\n-      unpatch: function(extension) {\n-        shimmer.unwrap(extension.Call.prototype, 'startBatch');\n+      unpatch: function(client) {\n+        shimmer.unwrap(client, 'makeClientConstructor');\n+        agent_.logger.info('gRPC makeClientConstructor: unpatched');","path":"lib/hooks/userspace/hook-grpc.js","position":93,"original_position":93,"commit_id":"9c0aef96de8aa2feb2ae926b5c3e418a2d0e4664","original_commit_id":"9c0aef96de8aa2feb2ae926b5c3e418a2d0e4664","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"Is the above correct?","created_at":"2016-06-24T18:13:52Z","updated_at":"2016-06-24T18:13:52Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267#discussion_r68438839","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/68438839"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267#discussion_r68438839"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267","id":74991836,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267","diff_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/267","number":267,"state":"open","locked":false,"title":"Support for gRPC time tracing","user":{"login":"misterpoe","id":6500458,"avatar_url":"https://avatars.githubusercontent.com/u/6500458?v=3","gravatar_id":"","url":"https://api.github.com/users/misterpoe","html_url":"https://github.com/misterpoe","followers_url":"https://api.github.com/users/misterpoe/followers","following_url":"https://api.github.com/users/misterpoe/following{/other_user}","gists_url":"https://api.github.com/users/misterpoe/gists{/gist_id}","starred_url":"https://api.github.com/users/misterpoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterpoe/subscriptions","organizations_url":"https://api.github.com/users/misterpoe/orgs","repos_url":"https://api.github.com/users/misterpoe/repos","events_url":"https://api.github.com/users/misterpoe/events{/privacy}","received_events_url":"https://api.github.com/users/misterpoe/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-23T17:09:15Z","updated_at":"2016-06-24T18:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1618bb53832c2992cc5a4172c55d7daeac70915b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/267/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/9c0aef96de8aa2feb2ae926b5c3e418a2d0e4664","head":{"label":"misterpoe:grpc","ref":"grpc","sha":"9c0aef96de8aa2feb2ae926b5c3e418a2d0e4664","user":{"login":"misterpoe","id":6500458,"avatar_url":"https://avatars.githubusercontent.com/u/6500458?v=3","gravatar_id":"","url":"https://api.github.com/users/misterpoe","html_url":"https://github.com/misterpoe","followers_url":"https://api.github.com/users/misterpoe/followers","following_url":"https://api.github.com/users/misterpoe/following{/other_user}","gists_url":"https://api.github.com/users/misterpoe/gists{/gist_id}","starred_url":"https://api.github.com/users/misterpoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterpoe/subscriptions","organizations_url":"https://api.github.com/users/misterpoe/orgs","repos_url":"https://api.github.com/users/misterpoe/repos","events_url":"https://api.github.com/users/misterpoe/events{/privacy}","received_events_url":"https://api.github.com/users/misterpoe/received_events","type":"User","site_admin":false},"repo":{"id":61762398,"name":"cloud-trace-nodejs","full_name":"misterpoe/cloud-trace-nodejs","owner":{"login":"misterpoe","id":6500458,"avatar_url":"https://avatars.githubusercontent.com/u/6500458?v=3","gravatar_id":"","url":"https://api.github.com/users/misterpoe","html_url":"https://github.com/misterpoe","followers_url":"https://api.github.com/users/misterpoe/followers","following_url":"https://api.github.com/users/misterpoe/following{/other_user}","gists_url":"https://api.github.com/users/misterpoe/gists{/gist_id}","starred_url":"https://api.github.com/users/misterpoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterpoe/subscriptions","organizations_url":"https://api.github.com/users/misterpoe/orgs","repos_url":"https://api.github.com/users/misterpoe/repos","events_url":"https://api.github.com/users/misterpoe/events{/privacy}","received_events_url":"https://api.github.com/users/misterpoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misterpoe/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":true,"url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/misterpoe/cloud-trace-nodejs/deployments","created_at":"2016-06-23T01:12:53Z","updated_at":"2016-06-23T01:12:54Z","pushed_at":"2016-06-24T17:26:36Z","git_url":"git://github.com/misterpoe/cloud-trace-nodejs.git","ssh_url":"git@github.com:misterpoe/cloud-trace-nodejs.git","clone_url":"https://github.com/misterpoe/cloud-trace-nodejs.git","svn_url":"https://github.com/misterpoe/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":1040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"239890b0c636d7dca802b09862a3aa32e485304a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":41170869,"name":"cloud-trace-nodejs","full_name":"GoogleCloudPlatform/cloud-trace-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/deployments","created_at":"2015-08-21T18:23:09Z","updated_at":"2016-06-21T08:05:27Z","pushed_at":"2016-06-24T17:26:37Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-trace-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":1077,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":5,"forks":17,"open_issues":5,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/267"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/267"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/9c0aef96de8aa2feb2ae926b5c3e418a2d0e4664"}}}}
{"actor":{"display_login":"ofrobots"}}