{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/57674668","id":57674668,"diff_hunk":"@@ -238,3 +238,128 @@ private[ml] object DecisionTreeModelReadWrite {\n     finalNodes.head\n   }\n }\n+\n+private[ml] object RandomForestModelReadWrite {\n+\n+  /**\n+    * Info for a [[org.apache.spark.ml.tree.Split]]\n+    *\n+    * @param featureIndex  Index of feature split on\n+    * @param leftCategoriesOrThreshold  For categorical feature, set of leftCategories.\n+    *                                   For continuous feature, threshold.\n+    * @param numCategories  For categorical feature, number of categories.\n+    *                       For continuous feature, -1.\n+    */\n+  case class SplitData(","path":"mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala","position":16,"original_position":16,"commit_id":"68b9358f128c365d573c5881b06f420276fd44ff","original_commit_id":"68b9358f128c365d573c5881b06f420276fd44ff","user":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"body":"Why is this copied here?  Can you reuse the existing SplitData?","created_at":"2016-03-29T05:51:08Z","updated_at":"2016-03-29T05:51:08Z","html_url":"https://github.com/apache/spark/pull/12023#discussion_r57674668","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12023","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/57674668"},"html":{"href":"https://github.com/apache/spark/pull/12023#discussion_r57674668"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12023"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12023","id":64405048,"html_url":"https://github.com/apache/spark/pull/12023","diff_url":"https://github.com/apache/spark/pull/12023.diff","patch_url":"https://github.com/apache/spark/pull/12023.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12023","number":12023,"state":"open","locked":false,"title":"[Spark-13784][ML][WIP] Model export/import for spark.ml: RandomForests","user":{"login":"GayathriMurali","id":7002441,"avatar_url":"https://avatars.githubusercontent.com/u/7002441?v=3","gravatar_id":"","url":"https://api.github.com/users/GayathriMurali","html_url":"https://github.com/GayathriMurali","followers_url":"https://api.github.com/users/GayathriMurali/followers","following_url":"https://api.github.com/users/GayathriMurali/following{/other_user}","gists_url":"https://api.github.com/users/GayathriMurali/gists{/gist_id}","starred_url":"https://api.github.com/users/GayathriMurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayathriMurali/subscriptions","organizations_url":"https://api.github.com/users/GayathriMurali/orgs","repos_url":"https://api.github.com/users/GayathriMurali/repos","events_url":"https://api.github.com/users/GayathriMurali/events{/privacy}","received_events_url":"https://api.github.com/users/GayathriMurali/received_events","type":"User","site_admin":false},"body":"Please help review the code. I have the WIP included to make sure the changes look correct. \r\n\r\n## What changes were proposed in this pull request?\r\n\r\nModel export/import for spark.ml RandomForests\r\n\r\n\r\n\r\n","created_at":"2016-03-29T02:23:15Z","updated_at":"2016-03-29T05:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8101727e3a6ea49542a30bc64b8d094be65b6a25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12023/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12023/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12023/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/68b9358f128c365d573c5881b06f420276fd44ff","head":{"label":"GayathriMurali:SPARK-13784","ref":"SPARK-13784","sha":"68b9358f128c365d573c5881b06f420276fd44ff","user":{"login":"GayathriMurali","id":7002441,"avatar_url":"https://avatars.githubusercontent.com/u/7002441?v=3","gravatar_id":"","url":"https://api.github.com/users/GayathriMurali","html_url":"https://github.com/GayathriMurali","followers_url":"https://api.github.com/users/GayathriMurali/followers","following_url":"https://api.github.com/users/GayathriMurali/following{/other_user}","gists_url":"https://api.github.com/users/GayathriMurali/gists{/gist_id}","starred_url":"https://api.github.com/users/GayathriMurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayathriMurali/subscriptions","organizations_url":"https://api.github.com/users/GayathriMurali/orgs","repos_url":"https://api.github.com/users/GayathriMurali/repos","events_url":"https://api.github.com/users/GayathriMurali/events{/privacy}","received_events_url":"https://api.github.com/users/GayathriMurali/received_events","type":"User","site_admin":false},"repo":{"id":42072330,"name":"spark","full_name":"GayathriMurali/spark","owner":{"login":"GayathriMurali","id":7002441,"avatar_url":"https://avatars.githubusercontent.com/u/7002441?v=3","gravatar_id":"","url":"https://api.github.com/users/GayathriMurali","html_url":"https://github.com/GayathriMurali","followers_url":"https://api.github.com/users/GayathriMurali/followers","following_url":"https://api.github.com/users/GayathriMurali/following{/other_user}","gists_url":"https://api.github.com/users/GayathriMurali/gists{/gist_id}","starred_url":"https://api.github.com/users/GayathriMurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayathriMurali/subscriptions","organizations_url":"https://api.github.com/users/GayathriMurali/orgs","repos_url":"https://api.github.com/users/GayathriMurali/repos","events_url":"https://api.github.com/users/GayathriMurali/events{/privacy}","received_events_url":"https://api.github.com/users/GayathriMurali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GayathriMurali/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/GayathriMurali/spark","forks_url":"https://api.github.com/repos/GayathriMurali/spark/forks","keys_url":"https://api.github.com/repos/GayathriMurali/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GayathriMurali/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GayathriMurali/spark/teams","hooks_url":"https://api.github.com/repos/GayathriMurali/spark/hooks","issue_events_url":"https://api.github.com/repos/GayathriMurali/spark/issues/events{/number}","events_url":"https://api.github.com/repos/GayathriMurali/spark/events","assignees_url":"https://api.github.com/repos/GayathriMurali/spark/assignees{/user}","branches_url":"https://api.github.com/repos/GayathriMurali/spark/branches{/branch}","tags_url":"https://api.github.com/repos/GayathriMurali/spark/tags","blobs_url":"https://api.github.com/repos/GayathriMurali/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GayathriMurali/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GayathriMurali/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/GayathriMurali/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GayathriMurali/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/GayathriMurali/spark/languages","stargazers_url":"https://api.github.com/repos/GayathriMurali/spark/stargazers","contributors_url":"https://api.github.com/repos/GayathriMurali/spark/contributors","subscribers_url":"https://api.github.com/repos/GayathriMurali/spark/subscribers","subscription_url":"https://api.github.com/repos/GayathriMurali/spark/subscription","commits_url":"https://api.github.com/repos/GayathriMurali/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/GayathriMurali/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/GayathriMurali/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/GayathriMurali/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/GayathriMurali/spark/contents/{+path}","compare_url":"https://api.github.com/repos/GayathriMurali/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GayathriMurali/spark/merges","archive_url":"https://api.github.com/repos/GayathriMurali/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GayathriMurali/spark/downloads","issues_url":"https://api.github.com/repos/GayathriMurali/spark/issues{/number}","pulls_url":"https://api.github.com/repos/GayathriMurali/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/GayathriMurali/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/GayathriMurali/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GayathriMurali/spark/labels{/name}","releases_url":"https://api.github.com/repos/GayathriMurali/spark/releases{/id}","deployments_url":"https://api.github.com/repos/GayathriMurali/spark/deployments","created_at":"2015-09-07T20:07:00Z","updated_at":"2015-09-07T20:07:22Z","pushed_at":"2016-03-29T02:19:53Z","git_url":"git://github.com/GayathriMurali/spark.git","ssh_url":"git@github.com:GayathriMurali/spark.git","clone_url":"https://github.com/GayathriMurali/spark.git","svn_url":"https://github.com/GayathriMurali/spark","homepage":null,"size":152763,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"38326cad873017ca07e90bc4472d01a42589d4cb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-03-29T03:46:19Z","pushed_at":"2016-03-29T05:48:55Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":450096,"stargazers_count":7963,"watchers_count":7963,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7342,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":414,"forks":7342,"open_issues":414,"watchers":7963,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12023"},"html":{"href":"https://github.com/apache/spark/pull/12023"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12023"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12023/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12023/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12023/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/68b9358f128c365d573c5881b06f420276fd44ff"}}}}