{"action":"created","comment":{"url":"https://api.github.com/repos/inasafe/inasafe/pulls/comments/87934390","pull_request_review_id":8524516,"id":87934390,"diff_hunk":"@@ -59,12 +60,18 @@ def minimum_needs_extractor(impact_report, component_metadata):\n             if need_parameter.unit.abbreviation:\n                 header = '%s [%s]' % (\n                     header, need_parameter.unit.abbreviation)\n+            # We don't have any layer to store minimum needs for now.\n+            # So, for now just calculate it manually\n             need_index = analysis_layer.fieldNameIndex(\n-                need_parameter.name)\n+                total_affected_field['field_name'])","path":"safe/reportv4/extractors/minimum_needs.py","position":16,"original_position":16,"commit_id":"99039488eb072ad45cfd2d3338a5e6978337d298","original_commit_id":"eb76a228222b026b598e35cdb70b469d87d0259a","user":{"login":"Gustry","id":1609292,"avatar_url":"https://avatars.githubusercontent.com/u/1609292?v=3","gravatar_id":"","url":"https://api.github.com/users/Gustry","html_url":"https://github.com/Gustry","followers_url":"https://api.github.com/users/Gustry/followers","following_url":"https://api.github.com/users/Gustry/following{/other_user}","gists_url":"https://api.github.com/users/Gustry/gists{/gist_id}","starred_url":"https://api.github.com/users/Gustry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gustry/subscriptions","organizations_url":"https://api.github.com/users/Gustry/orgs","repos_url":"https://api.github.com/users/Gustry/repos","events_url":"https://api.github.com/users/Gustry/events{/privacy}","received_events_url":"https://api.github.com/users/Gustry/received_events","type":"User","site_admin":false},"body":"Correct. In the impact layer (the layer where postprocessing ran), you should find, in the future, the minimum needs.","created_at":"2016-11-15T01:52:38Z","updated_at":"2016-11-15T01:52:39Z","html_url":"https://github.com/inasafe/inasafe/pull/3436#discussion_r87934390","pull_request_url":"https://api.github.com/repos/inasafe/inasafe/pulls/3436","_links":{"self":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/comments/87934390"},"html":{"href":"https://github.com/inasafe/inasafe/pull/3436#discussion_r87934390"},"pull_request":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/3436"}}},"pull_request":{"url":"https://api.github.com/repos/inasafe/inasafe/pulls/3436","id":93629546,"html_url":"https://github.com/inasafe/inasafe/pull/3436","diff_url":"https://github.com/inasafe/inasafe/pull/3436.diff","patch_url":"https://github.com/inasafe/inasafe/pull/3436.patch","issue_url":"https://api.github.com/repos/inasafe/inasafe/issues/3436","number":3436,"state":"open","locked":false,"title":"Handle population exposure report","user":{"login":"lucernae","id":831865,"avatar_url":"https://avatars.githubusercontent.com/u/831865?v=3","gravatar_id":"","url":"https://api.github.com/users/lucernae","html_url":"https://github.com/lucernae","followers_url":"https://api.github.com/users/lucernae/followers","following_url":"https://api.github.com/users/lucernae/following{/other_user}","gists_url":"https://api.github.com/users/lucernae/gists{/gist_id}","starred_url":"https://api.github.com/users/lucernae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucernae/subscriptions","organizations_url":"https://api.github.com/users/lucernae/orgs","repos_url":"https://api.github.com/users/lucernae/repos","events_url":"https://api.github.com/users/lucernae/events{/privacy}","received_events_url":"https://api.github.com/users/lucernae/received_events","type":"User","site_admin":false},"body":"Handled:\r\n- minimum needs\r\n- remove itemization definition\r\n- report test just check created report for now (without comparing it to control files)\r\n- show impact report in dock for impact and analysis layer (checked from layer_purpose)","created_at":"2016-11-14T19:21:31Z","updated_at":"2016-11-15T01:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"084bbcae7be967601d962ee0cb08592f49102aff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/inasafe/inasafe/pulls/3436/commits","review_comments_url":"https://api.github.com/repos/inasafe/inasafe/pulls/3436/comments","review_comment_url":"https://api.github.com/repos/inasafe/inasafe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inasafe/inasafe/issues/3436/comments","statuses_url":"https://api.github.com/repos/inasafe/inasafe/statuses/99039488eb072ad45cfd2d3338a5e6978337d298","head":{"label":"lucernae:report-v4-impact-summary","ref":"report-v4-impact-summary","sha":"99039488eb072ad45cfd2d3338a5e6978337d298","user":{"login":"lucernae","id":831865,"avatar_url":"https://avatars.githubusercontent.com/u/831865?v=3","gravatar_id":"","url":"https://api.github.com/users/lucernae","html_url":"https://github.com/lucernae","followers_url":"https://api.github.com/users/lucernae/followers","following_url":"https://api.github.com/users/lucernae/following{/other_user}","gists_url":"https://api.github.com/users/lucernae/gists{/gist_id}","starred_url":"https://api.github.com/users/lucernae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucernae/subscriptions","organizations_url":"https://api.github.com/users/lucernae/orgs","repos_url":"https://api.github.com/users/lucernae/repos","events_url":"https://api.github.com/users/lucernae/events{/privacy}","received_events_url":"https://api.github.com/users/lucernae/received_events","type":"User","site_admin":false},"repo":{"id":20049620,"name":"inasafe","full_name":"lucernae/inasafe","owner":{"login":"lucernae","id":831865,"avatar_url":"https://avatars.githubusercontent.com/u/831865?v=3","gravatar_id":"","url":"https://api.github.com/users/lucernae","html_url":"https://github.com/lucernae","followers_url":"https://api.github.com/users/lucernae/followers","following_url":"https://api.github.com/users/lucernae/following{/other_user}","gists_url":"https://api.github.com/users/lucernae/gists{/gist_id}","starred_url":"https://api.github.com/users/lucernae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucernae/subscriptions","organizations_url":"https://api.github.com/users/lucernae/orgs","repos_url":"https://api.github.com/users/lucernae/repos","events_url":"https://api.github.com/users/lucernae/events{/privacy}","received_events_url":"https://api.github.com/users/lucernae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucernae/inasafe","description":"InaSAFE - QGIS plugin for estimating impact from natural disasters","fork":true,"url":"https://api.github.com/repos/lucernae/inasafe","forks_url":"https://api.github.com/repos/lucernae/inasafe/forks","keys_url":"https://api.github.com/repos/lucernae/inasafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucernae/inasafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucernae/inasafe/teams","hooks_url":"https://api.github.com/repos/lucernae/inasafe/hooks","issue_events_url":"https://api.github.com/repos/lucernae/inasafe/issues/events{/number}","events_url":"https://api.github.com/repos/lucernae/inasafe/events","assignees_url":"https://api.github.com/repos/lucernae/inasafe/assignees{/user}","branches_url":"https://api.github.com/repos/lucernae/inasafe/branches{/branch}","tags_url":"https://api.github.com/repos/lucernae/inasafe/tags","blobs_url":"https://api.github.com/repos/lucernae/inasafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucernae/inasafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucernae/inasafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucernae/inasafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucernae/inasafe/statuses/{sha}","languages_url":"https://api.github.com/repos/lucernae/inasafe/languages","stargazers_url":"https://api.github.com/repos/lucernae/inasafe/stargazers","contributors_url":"https://api.github.com/repos/lucernae/inasafe/contributors","subscribers_url":"https://api.github.com/repos/lucernae/inasafe/subscribers","subscription_url":"https://api.github.com/repos/lucernae/inasafe/subscription","commits_url":"https://api.github.com/repos/lucernae/inasafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucernae/inasafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucernae/inasafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucernae/inasafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucernae/inasafe/contents/{+path}","compare_url":"https://api.github.com/repos/lucernae/inasafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucernae/inasafe/merges","archive_url":"https://api.github.com/repos/lucernae/inasafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucernae/inasafe/downloads","issues_url":"https://api.github.com/repos/lucernae/inasafe/issues{/number}","pulls_url":"https://api.github.com/repos/lucernae/inasafe/pulls{/number}","milestones_url":"https://api.github.com/repos/lucernae/inasafe/milestones{/number}","notifications_url":"https://api.github.com/repos/lucernae/inasafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucernae/inasafe/labels{/name}","releases_url":"https://api.github.com/repos/lucernae/inasafe/releases{/id}","deployments_url":"https://api.github.com/repos/lucernae/inasafe/deployments","created_at":"2014-05-22T05:59:11Z","updated_at":"2016-03-02T19:28:22Z","pushed_at":"2016-11-14T21:44:12Z","git_url":"git://github.com/lucernae/inasafe.git","ssh_url":"git@github.com:lucernae/inasafe.git","clone_url":"https://github.com/lucernae/inasafe.git","svn_url":"https://github.com/lucernae/inasafe","homepage":"www.inasafe.org","size":193034,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"inasafe:develop","ref":"develop","sha":"38679709c0d35f443910fe0b1e63e5ffe8b71904","user":{"login":"inasafe","id":1843347,"avatar_url":"https://avatars.githubusercontent.com/u/1843347?v=3","gravatar_id":"","url":"https://api.github.com/users/inasafe","html_url":"https://github.com/inasafe","followers_url":"https://api.github.com/users/inasafe/followers","following_url":"https://api.github.com/users/inasafe/following{/other_user}","gists_url":"https://api.github.com/users/inasafe/gists{/gist_id}","starred_url":"https://api.github.com/users/inasafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inasafe/subscriptions","organizations_url":"https://api.github.com/users/inasafe/orgs","repos_url":"https://api.github.com/users/inasafe/repos","events_url":"https://api.github.com/users/inasafe/events{/privacy}","received_events_url":"https://api.github.com/users/inasafe/received_events","type":"Organization","site_admin":false},"repo":{"id":3135721,"name":"inasafe","full_name":"inasafe/inasafe","owner":{"login":"inasafe","id":1843347,"avatar_url":"https://avatars.githubusercontent.com/u/1843347?v=3","gravatar_id":"","url":"https://api.github.com/users/inasafe","html_url":"https://github.com/inasafe","followers_url":"https://api.github.com/users/inasafe/followers","following_url":"https://api.github.com/users/inasafe/following{/other_user}","gists_url":"https://api.github.com/users/inasafe/gists{/gist_id}","starred_url":"https://api.github.com/users/inasafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inasafe/subscriptions","organizations_url":"https://api.github.com/users/inasafe/orgs","repos_url":"https://api.github.com/users/inasafe/repos","events_url":"https://api.github.com/users/inasafe/events{/privacy}","received_events_url":"https://api.github.com/users/inasafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inasafe/inasafe","description":"InaSAFE - QGIS plugin for estimating impact from natural disasters","fork":false,"url":"https://api.github.com/repos/inasafe/inasafe","forks_url":"https://api.github.com/repos/inasafe/inasafe/forks","keys_url":"https://api.github.com/repos/inasafe/inasafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inasafe/inasafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inasafe/inasafe/teams","hooks_url":"https://api.github.com/repos/inasafe/inasafe/hooks","issue_events_url":"https://api.github.com/repos/inasafe/inasafe/issues/events{/number}","events_url":"https://api.github.com/repos/inasafe/inasafe/events","assignees_url":"https://api.github.com/repos/inasafe/inasafe/assignees{/user}","branches_url":"https://api.github.com/repos/inasafe/inasafe/branches{/branch}","tags_url":"https://api.github.com/repos/inasafe/inasafe/tags","blobs_url":"https://api.github.com/repos/inasafe/inasafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inasafe/inasafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inasafe/inasafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/inasafe/inasafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inasafe/inasafe/statuses/{sha}","languages_url":"https://api.github.com/repos/inasafe/inasafe/languages","stargazers_url":"https://api.github.com/repos/inasafe/inasafe/stargazers","contributors_url":"https://api.github.com/repos/inasafe/inasafe/contributors","subscribers_url":"https://api.github.com/repos/inasafe/inasafe/subscribers","subscription_url":"https://api.github.com/repos/inasafe/inasafe/subscription","commits_url":"https://api.github.com/repos/inasafe/inasafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/inasafe/inasafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/inasafe/inasafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/inasafe/inasafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/inasafe/inasafe/contents/{+path}","compare_url":"https://api.github.com/repos/inasafe/inasafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inasafe/inasafe/merges","archive_url":"https://api.github.com/repos/inasafe/inasafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inasafe/inasafe/downloads","issues_url":"https://api.github.com/repos/inasafe/inasafe/issues{/number}","pulls_url":"https://api.github.com/repos/inasafe/inasafe/pulls{/number}","milestones_url":"https://api.github.com/repos/inasafe/inasafe/milestones{/number}","notifications_url":"https://api.github.com/repos/inasafe/inasafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inasafe/inasafe/labels{/name}","releases_url":"https://api.github.com/repos/inasafe/inasafe/releases{/id}","deployments_url":"https://api.github.com/repos/inasafe/inasafe/deployments","created_at":"2012-01-09T10:34:29Z","updated_at":"2016-11-11T09:06:55Z","pushed_at":"2016-11-15T01:34:32Z","git_url":"git://github.com/inasafe/inasafe.git","ssh_url":"git@github.com:inasafe/inasafe.git","clone_url":"https://github.com/inasafe/inasafe.git","svn_url":"https://github.com/inasafe/inasafe","homepage":"www.inasafe.org","size":212065,"stargazers_count":94,"watchers_count":94,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":344,"forks":90,"open_issues":344,"watchers":94,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/3436"},"html":{"href":"https://github.com/inasafe/inasafe/pull/3436"},"issue":{"href":"https://api.github.com/repos/inasafe/inasafe/issues/3436"},"comments":{"href":"https://api.github.com/repos/inasafe/inasafe/issues/3436/comments"},"review_comments":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/3436/comments"},"review_comment":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inasafe/inasafe/pulls/3436/commits"},"statuses":{"href":"https://api.github.com/repos/inasafe/inasafe/statuses/99039488eb072ad45cfd2d3338a5e6978337d298"}}}}
{"actor":{"display_login":"Gustry"}}