{"push_id":1047269641,"size":1,"distinct_size":1,"ref":"refs/heads/collision","head":"967e364c7d2830d75b751359a72c28cce5a035ee","before":"c981bc0de711719d11001548f9bec9661f820333","commits":[{"sha":"967e364c7d2830d75b751359a72c28cce5a035ee","author":{"email":"e632d5a6487cfeafb93007ea89e5907aa2428917@gmail.com","name":"Jordan Rust"},"message":"Fixed Rotation with Kicking!\n\nFinally fixed the rotation clipping bug, hopefully for good. Now when you rotate, the rotation method checks three positions. The first is normal rotation, if that doesn't work, it checks one block over on the x axis, if that doesn't work, it check one block left on the x axis from the original rotation. If none work, the block doesn't rotate.\n\nThings to work on:\n\n- The line still uses the old rotation. It needs its own rotation method, overriding the main Piece one.\n\n- The line also still uses the old layout for being rendered, with the axis of rotation on the outermost block. This needs to be changed to a custom rotation, different than the other 3-length pieces.\n\n- Z and S shapes start facing the wrong direction. Quick fix is changing the initial rotation.\n\n- If you rotate while at the top or bottom of the screen, the game crashes. This is because of indexOf in the blockCollision function is being run on an array that doesn't exist. The bottom will be fixed by adding kicking on the bottom, similar to the sides. I don't want kicking at the top, but it should be able to clip through the top. The pieces should always start in full view though.\n\n- Losing conditions : This still needs to be worked on. This should only be tested in the grabNewPiece method, to prevent issues with rotation when a piece is first loaded. I also need to take into account piece clipping when they load, and let that signal a losing condition.","distinct":true,"url":"https://api.github.com/repos/NyxHemera/tetris-ga/commits/967e364c7d2830d75b751359a72c28cce5a035ee"}]}