{"action":"created","issue":{"url":"https://api.github.com/repos/apache/commons-lang/issues/218","repository_url":"https://api.github.com/repos/apache/commons-lang","labels_url":"https://api.github.com/repos/apache/commons-lang/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/apache/commons-lang/issues/218/comments","events_url":"https://api.github.com/repos/apache/commons-lang/issues/218/events","html_url":"https://github.com/apache/commons-lang/pull/218","id":191589909,"number":218,"title":"Fix/different annotations test","user":{"login":"Abrasha","id":11317222,"avatar_url":"https://avatars.githubusercontent.com/u/11317222?v=3","gravatar_id":"","url":"https://api.github.com/users/Abrasha","html_url":"https://github.com/Abrasha","followers_url":"https://api.github.com/users/Abrasha/followers","following_url":"https://api.github.com/users/Abrasha/following{/other_user}","gists_url":"https://api.github.com/users/Abrasha/gists{/gist_id}","starred_url":"https://api.github.com/users/Abrasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abrasha/subscriptions","organizations_url":"https://api.github.com/users/Abrasha/orgs","repos_url":"https://api.github.com/users/Abrasha/repos","events_url":"https://api.github.com/users/Abrasha/events{/privacy}","received_events_url":"https://api.github.com/users/Abrasha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-24T20:54:06Z","updated_at":"2016-11-24T21:00:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/commons-lang/pulls/218","html_url":"https://github.com/apache/commons-lang/pull/218","diff_url":"https://github.com/apache/commons-lang/pull/218.diff","patch_url":"https://github.com/apache/commons-lang/pull/218.patch"},"body":"```\r\n@Test\r\npublic void testAnnotationsOfDifferingTypes() {\r\n    assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field4.getAnnotation(NestAnnotation.class)));\r\n    assertFalse(AnnotationUtils.equals(field4.getAnnotation(NestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));\r\n}\r\n```\r\n\r\nThis test is successful, but checks a different behaviour than expected.\r\n\r\n`field4.getAnnotation(NestAnnotation.class)` is expected to return an annotation of type `NestAnnotation`, but actually it returns `null` because the Retention of annotation is set to default.\r\n\r\nAs a result, test did not cover quite important case.\r\n\r\nSee discussion: [#217](https://github.com/apache/commons-lang/pull/217)"},"comment":{"url":"https://api.github.com/repos/apache/commons-lang/issues/comments/262844117","html_url":"https://github.com/apache/commons-lang/pull/218#issuecomment-262844117","issue_url":"https://api.github.com/repos/apache/commons-lang/issues/218","id":262844117,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T21:00:57Z","updated_at":"2016-11-24T21:00:57Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8989989/badge)](https://coveralls.io/builds/8989989)\n\nCoverage increased (+0.01%) to 93.66% when pulling **21f2c9c176f704620af2c531cb88646e7b6144d7 on Abrasha:fix/different-annotations-test** into **41bc4cd029fc486b5570ec344cdeae049bbca860 on apache:master**.\n"}}
{"actor":{"display_login":"coveralls"}}