{"action":"created","issue":{"url":"https://api.github.com/repos/divio/django-cms/issues/5831","repository_url":"https://api.github.com/repos/divio/django-cms","labels_url":"https://api.github.com/repos/divio/django-cms/issues/5831/labels{/name}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/5831/comments","events_url":"https://api.github.com/repos/divio/django-cms/issues/5831/events","html_url":"https://github.com/divio/django-cms/issues/5831","id":198176042,"number":5831,"title":"Method CMSPluginBase._get_render_template raises wrong exception","user":{"login":"jrief","id":1132472,"avatar_url":"https://avatars.githubusercontent.com/u/1132472?v=3","gravatar_id":"","url":"https://api.github.com/users/jrief","html_url":"https://github.com/jrief","followers_url":"https://api.github.com/users/jrief/followers","following_url":"https://api.github.com/users/jrief/following{/other_user}","gists_url":"https://api.github.com/users/jrief/gists{/gist_id}","starred_url":"https://api.github.com/users/jrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrief/subscriptions","organizations_url":"https://api.github.com/users/jrief/orgs","repos_url":"https://api.github.com/users/jrief/repos","events_url":"https://api.github.com/users/jrief/events{/privacy}","received_events_url":"https://api.github.com/users/jrief/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-30T17:51:35Z","updated_at":"2016-12-30T17:54:31Z","closed_at":null,"body":"In class ``CMSPluginBase`` the method ``_get_render_template`` raises a ``ValidationError``, if the returned template is ``None``. In my opinion the correct exception should be a ``TemplateDoesNotExist`` exception, since a ``ValidationError`` shall only be used to reject invalid form data."},"comment":{"url":"https://api.github.com/repos/divio/django-cms/issues/comments/269801422","html_url":"https://github.com/divio/django-cms/issues/5831#issuecomment-269801422","issue_url":"https://api.github.com/repos/divio/django-cms/issues/5831","id":269801422,"user":{"login":"czpython","id":994951,"avatar_url":"https://avatars.githubusercontent.com/u/994951?v=3","gravatar_id":"","url":"https://api.github.com/users/czpython","html_url":"https://github.com/czpython","followers_url":"https://api.github.com/users/czpython/followers","following_url":"https://api.github.com/users/czpython/following{/other_user}","gists_url":"https://api.github.com/users/czpython/gists{/gist_id}","starred_url":"https://api.github.com/users/czpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czpython/subscriptions","organizations_url":"https://api.github.com/users/czpython/orgs","repos_url":"https://api.github.com/users/czpython/repos","events_url":"https://api.github.com/users/czpython/events{/privacy}","received_events_url":"https://api.github.com/users/czpython/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T17:54:31Z","updated_at":"2016-12-30T17:54:31Z","body":"Agree but I think we should use `ImproperlyConfigured` instead."}}
{"actor":{"display_login":"czpython"}}