{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/core-plans/issues/58","repository_url":"https://api.github.com/repos/habitat-sh/core-plans","labels_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/58/comments","events_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/58/events","html_url":"https://github.com/habitat-sh/core-plans/pull/58","id":165803819,"number":58,"title":"Change name of protobuf2.5 plan","user":{"login":"smith","id":9912,"avatar_url":"https://avatars.githubusercontent.com/u/9912?v=3","gravatar_id":"","url":"https://api.github.com/users/smith","html_url":"https://github.com/smith","followers_url":"https://api.github.com/users/smith/followers","following_url":"https://api.github.com/users/smith/following{/other_user}","gists_url":"https://api.github.com/users/smith/gists{/gist_id}","starred_url":"https://api.github.com/users/smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith/subscriptions","organizations_url":"https://api.github.com/users/smith/orgs","repos_url":"https://api.github.com/users/smith/repos","events_url":"https://api.github.com/users/smith/events{/privacy}","received_events_url":"https://api.github.com/users/smith/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/habitat-sh/core-plans/labels/In%20Progress","name":"In Progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-15T14:47:00Z","updated_at":"2016-07-15T18:28:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/58","html_url":"https://github.com/habitat-sh/core-plans/pull/58","diff_url":"https://github.com/habitat-sh/core-plans/pull/58.diff","patch_url":"https://github.com/habitat-sh/core-plans/pull/58.patch"},"body":"The `pkg_name` of the protobuf2.5 plan must also be `protobuf2.5`, or\r\nany built packages would go into the namespace for core/protobuf, whose\r\nplan uses a different version.\r\n\r\nSet a `pkg_distname` in the plan and use that to make the plan build.\r\n\r\nFix the protobuf-c plan to use the correct ident.\r\n\r\n![giphy4](https://cloud.githubusercontent.com/assets/9912/16878153/0d1d0f78-4a71-11e6-9409-e548b704834d.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/habitat-sh/core-plans/issues/comments/233030679","html_url":"https://github.com/habitat-sh/core-plans/pull/58#issuecomment-233030679","issue_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/58","id":233030679,"user":{"login":"reset","id":54036,"avatar_url":"https://avatars.githubusercontent.com/u/54036?v=3","gravatar_id":"","url":"https://api.github.com/users/reset","html_url":"https://github.com/reset","followers_url":"https://api.github.com/users/reset/followers","following_url":"https://api.github.com/users/reset/following{/other_user}","gists_url":"https://api.github.com/users/reset/gists{/gist_id}","starred_url":"https://api.github.com/users/reset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reset/subscriptions","organizations_url":"https://api.github.com/users/reset/orgs","repos_url":"https://api.github.com/users/reset/repos","events_url":"https://api.github.com/users/reset/events{/privacy}","received_events_url":"https://api.github.com/users/reset/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T18:28:11Z","updated_at":"2016-07-15T18:28:11Z","body":"@smith this is definitely necessary but I think the existence of a protobuf2.5 package is fundamentally incorrect. The name of the package shouldn't contain the version number since our ident system already allows for this. I saw this as part of an 8 package PR and didn't have time to comment on it before it was merged in.\r\n\r\nIf we want a version of protobuf 2.5.0 build and published then we should modify the protobuf plan.sh for a one off and publish that to the depot. Then ask for anyone who requires protobuf 2.5.0 to specify a dep of `core/protobuf/2.5.0`"}}
{"actor":{"display_login":"reset"}}