{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jicofo/pulls/comments/77642096","id":77642096,"diff_hunk":"@@ -58,7 +58,8 @@\n      * Caches early presence packets triggered by Smack, before there was member\n      * joined event.\n      */\n-    private Map<String, Presence> presenceCache = new HashMap<>();\n+    private final Map<String, Presence> presenceCache\n+        = new ConcurrentHashMap<>();","path":"src/main/java/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java","position":6,"original_position":6,"commit_id":"8e769999285843f53efbac715372aaa30400a6f2","original_commit_id":"8e769999285843f53efbac715372aaa30400a6f2","user":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"body":"I'm not sure that it's much better than before. It's true that the presenceCache will be consistently modified as far as the generic Map interface goes. But will it be consistently modified as far as ChatRoomImpl goes? I'm not sure. In 2 out of 3 uses presenceCache is protected by members, in the remaining 1 out of 3 uses it's not protected by members. Murky business.","created_at":"2016-09-06T14:11:56Z","updated_at":"2016-09-06T14:11:56Z","html_url":"https://github.com/jitsi/jicofo/pull/117#discussion_r77642096","pull_request_url":"https://api.github.com/repos/jitsi/jicofo/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/comments/77642096"},"html":{"href":"https://github.com/jitsi/jicofo/pull/117#discussion_r77642096"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jicofo/pulls/117","id":83486244,"html_url":"https://github.com/jitsi/jicofo/pull/117","diff_url":"https://github.com/jitsi/jicofo/pull/117.diff","patch_url":"https://github.com/jitsi/jicofo/pull/117.patch","issue_url":"https://api.github.com/repos/jitsi/jicofo/issues/117","number":117,"state":"open","locked":false,"title":"Sync fixes","user":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-31T16:29:59Z","updated_at":"2016-09-06T14:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48d23f0435acf305dcd6135e429a48e43a4127b2","assignee":{"login":"paweldomas","id":2965063,"avatar_url":"https://avatars.githubusercontent.com/u/2965063?v=3","gravatar_id":"","url":"https://api.github.com/users/paweldomas","html_url":"https://github.com/paweldomas","followers_url":"https://api.github.com/users/paweldomas/followers","following_url":"https://api.github.com/users/paweldomas/following{/other_user}","gists_url":"https://api.github.com/users/paweldomas/gists{/gist_id}","starred_url":"https://api.github.com/users/paweldomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paweldomas/subscriptions","organizations_url":"https://api.github.com/users/paweldomas/orgs","repos_url":"https://api.github.com/users/paweldomas/repos","events_url":"https://api.github.com/users/paweldomas/events{/privacy}","received_events_url":"https://api.github.com/users/paweldomas/received_events","type":"User","site_admin":false},"assignees":[{"login":"paweldomas","id":2965063,"avatar_url":"https://avatars.githubusercontent.com/u/2965063?v=3","gravatar_id":"","url":"https://api.github.com/users/paweldomas","html_url":"https://github.com/paweldomas","followers_url":"https://api.github.com/users/paweldomas/followers","following_url":"https://api.github.com/users/paweldomas/following{/other_user}","gists_url":"https://api.github.com/users/paweldomas/gists{/gist_id}","starred_url":"https://api.github.com/users/paweldomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paweldomas/subscriptions","organizations_url":"https://api.github.com/users/paweldomas/orgs","repos_url":"https://api.github.com/users/paweldomas/repos","events_url":"https://api.github.com/users/paweldomas/events{/privacy}","received_events_url":"https://api.github.com/users/paweldomas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jicofo/pulls/117/commits","review_comments_url":"https://api.github.com/repos/jitsi/jicofo/pulls/117/comments","review_comment_url":"https://api.github.com/repos/jitsi/jicofo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jicofo/issues/117/comments","statuses_url":"https://api.github.com/repos/jitsi/jicofo/statuses/8e769999285843f53efbac715372aaa30400a6f2","head":{"label":"bgrozev:sync-fixes","ref":"sync-fixes","sha":"8e769999285843f53efbac715372aaa30400a6f2","user":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"repo":{"id":53366270,"name":"jicofo","full_name":"bgrozev/jicofo","owner":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgrozev/jicofo","description":"JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.","fork":true,"url":"https://api.github.com/repos/bgrozev/jicofo","forks_url":"https://api.github.com/repos/bgrozev/jicofo/forks","keys_url":"https://api.github.com/repos/bgrozev/jicofo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgrozev/jicofo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgrozev/jicofo/teams","hooks_url":"https://api.github.com/repos/bgrozev/jicofo/hooks","issue_events_url":"https://api.github.com/repos/bgrozev/jicofo/issues/events{/number}","events_url":"https://api.github.com/repos/bgrozev/jicofo/events","assignees_url":"https://api.github.com/repos/bgrozev/jicofo/assignees{/user}","branches_url":"https://api.github.com/repos/bgrozev/jicofo/branches{/branch}","tags_url":"https://api.github.com/repos/bgrozev/jicofo/tags","blobs_url":"https://api.github.com/repos/bgrozev/jicofo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgrozev/jicofo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgrozev/jicofo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgrozev/jicofo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgrozev/jicofo/statuses/{sha}","languages_url":"https://api.github.com/repos/bgrozev/jicofo/languages","stargazers_url":"https://api.github.com/repos/bgrozev/jicofo/stargazers","contributors_url":"https://api.github.com/repos/bgrozev/jicofo/contributors","subscribers_url":"https://api.github.com/repos/bgrozev/jicofo/subscribers","subscription_url":"https://api.github.com/repos/bgrozev/jicofo/subscription","commits_url":"https://api.github.com/repos/bgrozev/jicofo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgrozev/jicofo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgrozev/jicofo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgrozev/jicofo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgrozev/jicofo/contents/{+path}","compare_url":"https://api.github.com/repos/bgrozev/jicofo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgrozev/jicofo/merges","archive_url":"https://api.github.com/repos/bgrozev/jicofo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgrozev/jicofo/downloads","issues_url":"https://api.github.com/repos/bgrozev/jicofo/issues{/number}","pulls_url":"https://api.github.com/repos/bgrozev/jicofo/pulls{/number}","milestones_url":"https://api.github.com/repos/bgrozev/jicofo/milestones{/number}","notifications_url":"https://api.github.com/repos/bgrozev/jicofo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgrozev/jicofo/labels{/name}","releases_url":"https://api.github.com/repos/bgrozev/jicofo/releases{/id}","deployments_url":"https://api.github.com/repos/bgrozev/jicofo/deployments","created_at":"2016-03-07T23:19:25Z","updated_at":"2016-03-07T23:19:27Z","pushed_at":"2016-08-31T16:29:08Z","git_url":"git://github.com/bgrozev/jicofo.git","ssh_url":"git@github.com:bgrozev/jicofo.git","clone_url":"https://github.com/bgrozev/jicofo.git","svn_url":"https://github.com/bgrozev/jicofo","homepage":"","size":32707,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"19dd4d917f6885f64696b16c510b5ea2379f44d6","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":26950457,"name":"jicofo","full_name":"jitsi/jicofo","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jicofo","description":"JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.","fork":false,"url":"https://api.github.com/repos/jitsi/jicofo","forks_url":"https://api.github.com/repos/jitsi/jicofo/forks","keys_url":"https://api.github.com/repos/jitsi/jicofo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jicofo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jicofo/teams","hooks_url":"https://api.github.com/repos/jitsi/jicofo/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jicofo/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jicofo/events","assignees_url":"https://api.github.com/repos/jitsi/jicofo/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jicofo/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jicofo/tags","blobs_url":"https://api.github.com/repos/jitsi/jicofo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jicofo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jicofo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jicofo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jicofo/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jicofo/languages","stargazers_url":"https://api.github.com/repos/jitsi/jicofo/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jicofo/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jicofo/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jicofo/subscription","commits_url":"https://api.github.com/repos/jitsi/jicofo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jicofo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jicofo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jicofo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jicofo/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jicofo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jicofo/merges","archive_url":"https://api.github.com/repos/jitsi/jicofo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jicofo/downloads","issues_url":"https://api.github.com/repos/jitsi/jicofo/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jicofo/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jicofo/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jicofo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jicofo/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jicofo/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jicofo/deployments","created_at":"2014-11-21T07:40:29Z","updated_at":"2016-09-05T09:38:59Z","pushed_at":"2016-09-03T00:38:06Z","git_url":"git://github.com/jitsi/jicofo.git","ssh_url":"git@github.com:jitsi/jicofo.git","clone_url":"https://github.com/jitsi/jicofo.git","svn_url":"https://github.com/jitsi/jicofo","homepage":"","size":33137,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":23,"forks":43,"open_issues":23,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/117"},"html":{"href":"https://github.com/jitsi/jicofo/pull/117"},"issue":{"href":"https://api.github.com/repos/jitsi/jicofo/issues/117"},"comments":{"href":"https://api.github.com/repos/jitsi/jicofo/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jicofo/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jicofo/statuses/8e769999285843f53efbac715372aaa30400a6f2"}}}}
{"actor":{"display_login":"lyubomir"}}