{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23956","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23956/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23956/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23956/events","html_url":"https://github.com/kubernetes/kubernetes/issues/23956","id":146464977,"number":23956,"title":"Kubelet's logic of checking docker running in host does not work in systemd distro","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":891,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2016-04-07T21:15:30Z","due_on":"2016-03-16T07:00:00Z","closed_at":null},"comments":13,"created_at":"2016-04-06T23:29:10Z","updated_at":"2016-04-07T21:32:16Z","closed_at":null,"body":"I notice that kubelet does not create \"/docker-daemon\" cgroup if docker is managed by systemd, because the function isProcessRunningInHost call (https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/container_manager_linux.go#L448) returns false. As a result, test cases in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubelet_perf.go will all fail. This isProcessRunningInHost function (https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/container_manager_linux.go#L408) compares /proc/1/ns/mnt with /proc/<docker pid>/ns/mnt to determine if docker is running in host. But this is not true if docker is managed by systemd (such as in CoreOS). You can see that docker has different mount namespace from pid 1, if docker is managed by systemd. But docker and pid 1 process have the same pid namespace.\r\n\r\nWhy would kubelet check the mount namespace, instead of pid namespace? Could you fix this issue in kubelet container manager?\r\n\r\n@dchen1107 @vishh \r\n\r\ncc/ @roberthbailey @fabioy @zmerlynn @wonderfly FYI."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/207096136","html_url":"https://github.com/kubernetes/kubernetes/issues/23956#issuecomment-207096136","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23956","id":207096136,"user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T21:32:16Z","updated_at":"2016-04-07T21:32:16Z","body":"But kubernetes-e2e-gce-serial including above three tests are part of critical builds: http://kubekins.dls.corp.google.com/view/Critical%20Builds/job/kubernetes-e2e-gce-serial/ \r\n\r\nAnyway, I just want to make sure we are running into this issue next time. Thanks! \r\n\r\n"}}