{"action":"opened","number":83,"pull_request":{"url":"https://api.github.com/repos/sillsdev/chorus/pulls/83","id":59757409,"html_url":"https://github.com/sillsdev/chorus/pull/83","diff_url":"https://github.com/sillsdev/chorus/pull/83.diff","patch_url":"https://github.com/sillsdev/chorus/pull/83.patch","issue_url":"https://api.github.com/repos/sillsdev/chorus/issues/83","number":83,"state":"open","locked":false,"title":"Fix ServerSettingsModel.InitFromUri to use UrlDecode","user":{"login":"megahirt","id":3444521,"avatar_url":"https://avatars.githubusercontent.com/u/3444521?v=3","gravatar_id":"","url":"https://api.github.com/users/megahirt","html_url":"https://github.com/megahirt","followers_url":"https://api.github.com/users/megahirt/followers","following_url":"https://api.github.com/users/megahirt/following{/other_user}","gists_url":"https://api.github.com/users/megahirt/gists{/gist_id}","starred_url":"https://api.github.com/users/megahirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megahirt/subscriptions","organizations_url":"https://api.github.com/users/megahirt/orgs","repos_url":"https://api.github.com/users/megahirt/repos","events_url":"https://api.github.com/users/megahirt/events{/privacy}","received_events_url":"https://api.github.com/users/megahirt/received_events","type":"User","site_admin":false},"body":"This fixes a bug in the Chorus Internet Settings Dialog which was reported to me by a WeSay user.  The previous code would allow a situation whereby the user has a password with a special character in it like % that when saved into the password field and then the dialog is re-opened, the password has \"grown\" in length.  This is caused by the password field not being properly url decoded when extracted from the URL.\r\n\r\nA regression test is also accompanied.\r\n\r\nYou can test this bug in the latest version of either Fieldworks, WeSay or any other app using the Chorus Internet Settings Dialog box.","created_at":"2016-02-18T06:44:03Z","updated_at":"2016-02-18T06:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sillsdev/chorus/pulls/83/commits","review_comments_url":"https://api.github.com/repos/sillsdev/chorus/pulls/83/comments","review_comment_url":"https://api.github.com/repos/sillsdev/chorus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sillsdev/chorus/issues/83/comments","statuses_url":"https://api.github.com/repos/sillsdev/chorus/statuses/91fa455216e9265fe47519750d395314ea4d38ac","head":{"label":"megahirt:bugFixServerSettingsModel","ref":"bugFixServerSettingsModel","sha":"91fa455216e9265fe47519750d395314ea4d38ac","user":{"login":"megahirt","id":3444521,"avatar_url":"https://avatars.githubusercontent.com/u/3444521?v=3","gravatar_id":"","url":"https://api.github.com/users/megahirt","html_url":"https://github.com/megahirt","followers_url":"https://api.github.com/users/megahirt/followers","following_url":"https://api.github.com/users/megahirt/following{/other_user}","gists_url":"https://api.github.com/users/megahirt/gists{/gist_id}","starred_url":"https://api.github.com/users/megahirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megahirt/subscriptions","organizations_url":"https://api.github.com/users/megahirt/orgs","repos_url":"https://api.github.com/users/megahirt/repos","events_url":"https://api.github.com/users/megahirt/events{/privacy}","received_events_url":"https://api.github.com/users/megahirt/received_events","type":"User","site_admin":false},"repo":{"id":19685527,"name":"chorus","full_name":"megahirt/chorus","owner":{"login":"megahirt","id":3444521,"avatar_url":"https://avatars.githubusercontent.com/u/3444521?v=3","gravatar_id":"","url":"https://api.github.com/users/megahirt","html_url":"https://github.com/megahirt","followers_url":"https://api.github.com/users/megahirt/followers","following_url":"https://api.github.com/users/megahirt/following{/other_user}","gists_url":"https://api.github.com/users/megahirt/gists{/gist_id}","starred_url":"https://api.github.com/users/megahirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megahirt/subscriptions","organizations_url":"https://api.github.com/users/megahirt/orgs","repos_url":"https://api.github.com/users/megahirt/repos","events_url":"https://api.github.com/users/megahirt/events{/privacy}","received_events_url":"https://api.github.com/users/megahirt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/megahirt/chorus","description":"End-user collaboration library via 3-way xml merging and hg dvcs under the hood","fork":true,"url":"https://api.github.com/repos/megahirt/chorus","forks_url":"https://api.github.com/repos/megahirt/chorus/forks","keys_url":"https://api.github.com/repos/megahirt/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/megahirt/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/megahirt/chorus/teams","hooks_url":"https://api.github.com/repos/megahirt/chorus/hooks","issue_events_url":"https://api.github.com/repos/megahirt/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/megahirt/chorus/events","assignees_url":"https://api.github.com/repos/megahirt/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/megahirt/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/megahirt/chorus/tags","blobs_url":"https://api.github.com/repos/megahirt/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/megahirt/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/megahirt/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/megahirt/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/megahirt/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/megahirt/chorus/languages","stargazers_url":"https://api.github.com/repos/megahirt/chorus/stargazers","contributors_url":"https://api.github.com/repos/megahirt/chorus/contributors","subscribers_url":"https://api.github.com/repos/megahirt/chorus/subscribers","subscription_url":"https://api.github.com/repos/megahirt/chorus/subscription","commits_url":"https://api.github.com/repos/megahirt/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/megahirt/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/megahirt/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/megahirt/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/megahirt/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/megahirt/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/megahirt/chorus/merges","archive_url":"https://api.github.com/repos/megahirt/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/megahirt/chorus/downloads","issues_url":"https://api.github.com/repos/megahirt/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/megahirt/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/megahirt/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/megahirt/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/megahirt/chorus/labels{/name}","releases_url":"https://api.github.com/repos/megahirt/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/megahirt/chorus/deployments","created_at":"2014-05-12T04:10:08Z","updated_at":"2014-05-14T08:10:12Z","pushed_at":"2016-02-18T06:41:44Z","git_url":"git://github.com/megahirt/chorus.git","ssh_url":"git@github.com:megahirt/chorus.git","clone_url":"https://github.com/megahirt/chorus.git","svn_url":"https://github.com/megahirt/chorus","homepage":"http://projects.palaso.org/projects/chorus","size":43535,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sillsdev:master","ref":"master","sha":"8515507208c1539220ebee854cf5e7e479e1de6d","user":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?v=3","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"repo":{"id":14127818,"name":"chorus","full_name":"sillsdev/chorus","owner":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars.githubusercontent.com/u/1095739?v=3","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sillsdev/chorus","description":"End-user collaboration library via 3-way xml merging and hg dvcs under the hood","fork":false,"url":"https://api.github.com/repos/sillsdev/chorus","forks_url":"https://api.github.com/repos/sillsdev/chorus/forks","keys_url":"https://api.github.com/repos/sillsdev/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sillsdev/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sillsdev/chorus/teams","hooks_url":"https://api.github.com/repos/sillsdev/chorus/hooks","issue_events_url":"https://api.github.com/repos/sillsdev/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/sillsdev/chorus/events","assignees_url":"https://api.github.com/repos/sillsdev/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/sillsdev/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/sillsdev/chorus/tags","blobs_url":"https://api.github.com/repos/sillsdev/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sillsdev/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sillsdev/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/sillsdev/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sillsdev/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/sillsdev/chorus/languages","stargazers_url":"https://api.github.com/repos/sillsdev/chorus/stargazers","contributors_url":"https://api.github.com/repos/sillsdev/chorus/contributors","subscribers_url":"https://api.github.com/repos/sillsdev/chorus/subscribers","subscription_url":"https://api.github.com/repos/sillsdev/chorus/subscription","commits_url":"https://api.github.com/repos/sillsdev/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/sillsdev/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/sillsdev/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/sillsdev/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/sillsdev/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/sillsdev/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sillsdev/chorus/merges","archive_url":"https://api.github.com/repos/sillsdev/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sillsdev/chorus/downloads","issues_url":"https://api.github.com/repos/sillsdev/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/sillsdev/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/sillsdev/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/sillsdev/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sillsdev/chorus/labels{/name}","releases_url":"https://api.github.com/repos/sillsdev/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/sillsdev/chorus/deployments","created_at":"2013-11-05T00:31:14Z","updated_at":"2015-05-22T09:30:09Z","pushed_at":"2016-02-18T06:44:03Z","git_url":"git://github.com/sillsdev/chorus.git","ssh_url":"git@github.com:sillsdev/chorus.git","clone_url":"https://github.com/sillsdev/chorus.git","svn_url":"https://github.com/sillsdev/chorus","homepage":"http://projects.palaso.org/projects/chorus","size":44129,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sillsdev/chorus/pulls/83"},"html":{"href":"https://github.com/sillsdev/chorus/pull/83"},"issue":{"href":"https://api.github.com/repos/sillsdev/chorus/issues/83"},"comments":{"href":"https://api.github.com/repos/sillsdev/chorus/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/sillsdev/chorus/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/sillsdev/chorus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sillsdev/chorus/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/sillsdev/chorus/statuses/91fa455216e9265fe47519750d395314ea4d38ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":4,"changed_files":2}}