{"action":"opened","number":6720,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720","id":67930168,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/6720","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6720.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6720.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6720","number":6720,"state":"open","locked":false,"title":"Modified GMM initialization to only use linear memory and time in sph…","user":{"login":"vlad17","id":5834964,"avatar_url":"https://avatars.githubusercontent.com/u/5834964?v=3","gravatar_id":"","url":"https://api.github.com/users/vlad17","html_url":"https://github.com/vlad17","followers_url":"https://api.github.com/users/vlad17/followers","following_url":"https://api.github.com/users/vlad17/following{/other_user}","gists_url":"https://api.github.com/users/vlad17/gists{/gist_id}","starred_url":"https://api.github.com/users/vlad17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlad17/subscriptions","organizations_url":"https://api.github.com/users/vlad17/orgs","repos_url":"https://api.github.com/users/vlad17/repos","events_url":"https://api.github.com/users/vlad17/events{/privacy}","received_events_url":"https://api.github.com/users/vlad17/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\n\r\nNot an reported issue, to my knowledge.\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nWhen running a 'diag' GMM on a high-dimensional feature space, a Memory Error was thrown. This is suspicious because quadratic memory should not be used for diagonal GMM fitting. Indeed, there was a section of gmm.py that had a needless covariance matrix calculation for the 'diag' and 'spherical' cases.\r\n\r\nThe modified code fixes that; behavior should be the same for 'diag'.\r\n\r\nFor 'spherical', the previous code initialized the variance term to the average value of all terms in the covariance matrix. The new code CHANGES this behavior; now it is the average value of the diagonal terms only. This is a more appropriate initialization anyway.\r\n\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2016-04-26T17:57:25Z","updated_at":"2016-04-26T17:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6720/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/eda9911943b9175011ad36b38a6b857353366a2f","head":{"label":"vlad17:linear-gmm-init","ref":"linear-gmm-init","sha":"eda9911943b9175011ad36b38a6b857353366a2f","user":{"login":"vlad17","id":5834964,"avatar_url":"https://avatars.githubusercontent.com/u/5834964?v=3","gravatar_id":"","url":"https://api.github.com/users/vlad17","html_url":"https://github.com/vlad17","followers_url":"https://api.github.com/users/vlad17/followers","following_url":"https://api.github.com/users/vlad17/following{/other_user}","gists_url":"https://api.github.com/users/vlad17/gists{/gist_id}","starred_url":"https://api.github.com/users/vlad17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlad17/subscriptions","organizations_url":"https://api.github.com/users/vlad17/orgs","repos_url":"https://api.github.com/users/vlad17/repos","events_url":"https://api.github.com/users/vlad17/events{/privacy}","received_events_url":"https://api.github.com/users/vlad17/received_events","type":"User","site_admin":false},"repo":{"id":57141696,"name":"scikit-learn","full_name":"vlad17/scikit-learn","owner":{"login":"vlad17","id":5834964,"avatar_url":"https://avatars.githubusercontent.com/u/5834964?v=3","gravatar_id":"","url":"https://api.github.com/users/vlad17","html_url":"https://github.com/vlad17","followers_url":"https://api.github.com/users/vlad17/followers","following_url":"https://api.github.com/users/vlad17/following{/other_user}","gists_url":"https://api.github.com/users/vlad17/gists{/gist_id}","starred_url":"https://api.github.com/users/vlad17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlad17/subscriptions","organizations_url":"https://api.github.com/users/vlad17/orgs","repos_url":"https://api.github.com/users/vlad17/repos","events_url":"https://api.github.com/users/vlad17/events{/privacy}","received_events_url":"https://api.github.com/users/vlad17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlad17/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/vlad17/scikit-learn","forks_url":"https://api.github.com/repos/vlad17/scikit-learn/forks","keys_url":"https://api.github.com/repos/vlad17/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlad17/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlad17/scikit-learn/teams","hooks_url":"https://api.github.com/repos/vlad17/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/vlad17/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/vlad17/scikit-learn/events","assignees_url":"https://api.github.com/repos/vlad17/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/vlad17/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/vlad17/scikit-learn/tags","blobs_url":"https://api.github.com/repos/vlad17/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlad17/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlad17/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlad17/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlad17/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/vlad17/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/vlad17/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/vlad17/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/vlad17/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/vlad17/scikit-learn/subscription","commits_url":"https://api.github.com/repos/vlad17/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlad17/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlad17/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlad17/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlad17/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/vlad17/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlad17/scikit-learn/merges","archive_url":"https://api.github.com/repos/vlad17/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlad17/scikit-learn/downloads","issues_url":"https://api.github.com/repos/vlad17/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/vlad17/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/vlad17/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/vlad17/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlad17/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/vlad17/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/vlad17/scikit-learn/deployments","created_at":"2016-04-26T15:52:48Z","updated_at":"2016-04-26T15:52:55Z","pushed_at":"2016-04-26T17:51:50Z","git_url":"git://github.com/vlad17/scikit-learn.git","ssh_url":"git@github.com:vlad17/scikit-learn.git","clone_url":"https://github.com/vlad17/scikit-learn.git","svn_url":"https://github.com/vlad17/scikit-learn","homepage":"http://scikit-learn.org","size":65748,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"78a674875e30417afe9621346ba022834c138351","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-04-26T17:15:49Z","pushed_at":"2016-04-26T17:14:23Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":112944,"stargazers_count":11063,"watchers_count":11063,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6422,"mirror_url":null,"open_issues_count":1173,"forks":6422,"open_issues":1173,"watchers":11063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6720"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6720"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6720/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6720/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/eda9911943b9175011ad36b38a6b857353366a2f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":4,"changed_files":1}}