{"action":"created","comment":{"url":"https://api.github.com/repos/scalapenos/stamina/pulls/comments/53456628","id":53456628,"diff_hunk":"@@ -0,0 +1,39 @@\n+package stamina\n+package json\n+\n+import spray.json._\n+import DefaultJsonProtocol._\n+\n+class OverlappingPersisterSpec extends StaminaJsonSpec {\n+  \"The persisters construction DSL\" should {\n+    case class Event[P](payload: P)\n+    case class Payload1(msg: String)\n+    case class Payload2(value: Int)\n+\n+    implicit val payload1Format = jsonFormat1(Payload1)\n+    implicit val payload2Format = jsonFormat1(Payload2)\n+\n+    implicit val eventPayload1Format = jsonFormat1(Event[Payload1])\n+    implicit val eventPayload2Format = jsonFormat1(Event[Payload2])\n+\n+    /** #43 In the future we might want to support this situation instead of failing at initialization time */\n+    \"correctly handle overlapping persisters\" in {\n+      val e = intercept[IllegalArgumentException] {\n+        Persisters(\n+          persister[Event[Payload1]](\"payload1\"),\n+          persister[Event[Payload2]](\"payload2\")\n+        )\n+      }\n+      e.getMessage() should be(\"requirement failed: Overlapping persisters: Tags payload1, payload2 all persist class stamina.json.OverlappingPersisterSpec$$anonfun$1$Event$3\")","path":"stamina-json/src/test/scala/stamina/json/OverlappingPersistersSpec.scala","position":null,"original_position":27,"commit_id":"161694f31ab4538af73a5c16b4c5e8928c125d2f","original_commit_id":"5ec5c9fa75cd408f31d51df5ccaaacd511979b1f","user":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-02-19T12:50:53Z","updated_at":"2016-02-19T12:50:53Z","html_url":"https://github.com/scalapenos/stamina/pull/44#discussion_r53456628","pull_request_url":"https://api.github.com/repos/scalapenos/stamina/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/comments/53456628"},"html":{"href":"https://github.com/scalapenos/stamina/pull/44#discussion_r53456628"},"pull_request":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/scalapenos/stamina/pulls/44","id":59933338,"html_url":"https://github.com/scalapenos/stamina/pull/44","diff_url":"https://github.com/scalapenos/stamina/pull/44.diff","patch_url":"https://github.com/scalapenos/stamina/pull/44.patch","issue_url":"https://api.github.com/repos/scalapenos/stamina/issues/44","number":44,"state":"open","locked":false,"title":"Fail at run time when persisters overlap","user":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-02-19T10:52:09Z","updated_at":"2016-02-19T12:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3438899ee93447bae9ed7290b7e86cca311da0b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scalapenos/stamina/pulls/44/commits","review_comments_url":"https://api.github.com/repos/scalapenos/stamina/pulls/44/comments","review_comment_url":"https://api.github.com/repos/scalapenos/stamina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalapenos/stamina/issues/44/comments","statuses_url":"https://api.github.com/repos/scalapenos/stamina/statuses/161694f31ab4538af73a5c16b4c5e8928c125d2f","head":{"label":"raboof:overlappingPersisters","ref":"overlappingPersisters","sha":"161694f31ab4538af73a5c16b4c5e8928c125d2f","user":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"repo":{"id":34112074,"name":"stamina","full_name":"raboof/stamina","owner":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raboof/stamina","description":"An alternative approach to serialization in akka-persistence","fork":true,"url":"https://api.github.com/repos/raboof/stamina","forks_url":"https://api.github.com/repos/raboof/stamina/forks","keys_url":"https://api.github.com/repos/raboof/stamina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raboof/stamina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raboof/stamina/teams","hooks_url":"https://api.github.com/repos/raboof/stamina/hooks","issue_events_url":"https://api.github.com/repos/raboof/stamina/issues/events{/number}","events_url":"https://api.github.com/repos/raboof/stamina/events","assignees_url":"https://api.github.com/repos/raboof/stamina/assignees{/user}","branches_url":"https://api.github.com/repos/raboof/stamina/branches{/branch}","tags_url":"https://api.github.com/repos/raboof/stamina/tags","blobs_url":"https://api.github.com/repos/raboof/stamina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raboof/stamina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raboof/stamina/git/refs{/sha}","trees_url":"https://api.github.com/repos/raboof/stamina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raboof/stamina/statuses/{sha}","languages_url":"https://api.github.com/repos/raboof/stamina/languages","stargazers_url":"https://api.github.com/repos/raboof/stamina/stargazers","contributors_url":"https://api.github.com/repos/raboof/stamina/contributors","subscribers_url":"https://api.github.com/repos/raboof/stamina/subscribers","subscription_url":"https://api.github.com/repos/raboof/stamina/subscription","commits_url":"https://api.github.com/repos/raboof/stamina/commits{/sha}","git_commits_url":"https://api.github.com/repos/raboof/stamina/git/commits{/sha}","comments_url":"https://api.github.com/repos/raboof/stamina/comments{/number}","issue_comment_url":"https://api.github.com/repos/raboof/stamina/issues/comments{/number}","contents_url":"https://api.github.com/repos/raboof/stamina/contents/{+path}","compare_url":"https://api.github.com/repos/raboof/stamina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raboof/stamina/merges","archive_url":"https://api.github.com/repos/raboof/stamina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raboof/stamina/downloads","issues_url":"https://api.github.com/repos/raboof/stamina/issues{/number}","pulls_url":"https://api.github.com/repos/raboof/stamina/pulls{/number}","milestones_url":"https://api.github.com/repos/raboof/stamina/milestones{/number}","notifications_url":"https://api.github.com/repos/raboof/stamina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raboof/stamina/labels{/name}","releases_url":"https://api.github.com/repos/raboof/stamina/releases{/id}","deployments_url":"https://api.github.com/repos/raboof/stamina/deployments","created_at":"2015-04-17T11:05:08Z","updated_at":"2015-04-17T11:05:09Z","pushed_at":"2016-02-19T12:50:33Z","git_url":"git://github.com/raboof/stamina.git","ssh_url":"git@github.com:raboof/stamina.git","clone_url":"https://github.com/raboof/stamina.git","svn_url":"https://github.com/raboof/stamina","homepage":null,"size":155,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalapenos:master","ref":"master","sha":"1b936d31bde2ee2f1ae0d0b9d9f86d9822c84b48","user":{"login":"scalapenos","id":3343186,"avatar_url":"https://avatars.githubusercontent.com/u/3343186?v=3","gravatar_id":"","url":"https://api.github.com/users/scalapenos","html_url":"https://github.com/scalapenos","followers_url":"https://api.github.com/users/scalapenos/followers","following_url":"https://api.github.com/users/scalapenos/following{/other_user}","gists_url":"https://api.github.com/users/scalapenos/gists{/gist_id}","starred_url":"https://api.github.com/users/scalapenos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalapenos/subscriptions","organizations_url":"https://api.github.com/users/scalapenos/orgs","repos_url":"https://api.github.com/users/scalapenos/repos","events_url":"https://api.github.com/users/scalapenos/events{/privacy}","received_events_url":"https://api.github.com/users/scalapenos/received_events","type":"Organization","site_admin":false},"repo":{"id":28387011,"name":"stamina","full_name":"scalapenos/stamina","owner":{"login":"scalapenos","id":3343186,"avatar_url":"https://avatars.githubusercontent.com/u/3343186?v=3","gravatar_id":"","url":"https://api.github.com/users/scalapenos","html_url":"https://github.com/scalapenos","followers_url":"https://api.github.com/users/scalapenos/followers","following_url":"https://api.github.com/users/scalapenos/following{/other_user}","gists_url":"https://api.github.com/users/scalapenos/gists{/gist_id}","starred_url":"https://api.github.com/users/scalapenos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalapenos/subscriptions","organizations_url":"https://api.github.com/users/scalapenos/orgs","repos_url":"https://api.github.com/users/scalapenos/repos","events_url":"https://api.github.com/users/scalapenos/events{/privacy}","received_events_url":"https://api.github.com/users/scalapenos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalapenos/stamina","description":"Schema evolution for akka-persistence","fork":false,"url":"https://api.github.com/repos/scalapenos/stamina","forks_url":"https://api.github.com/repos/scalapenos/stamina/forks","keys_url":"https://api.github.com/repos/scalapenos/stamina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalapenos/stamina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalapenos/stamina/teams","hooks_url":"https://api.github.com/repos/scalapenos/stamina/hooks","issue_events_url":"https://api.github.com/repos/scalapenos/stamina/issues/events{/number}","events_url":"https://api.github.com/repos/scalapenos/stamina/events","assignees_url":"https://api.github.com/repos/scalapenos/stamina/assignees{/user}","branches_url":"https://api.github.com/repos/scalapenos/stamina/branches{/branch}","tags_url":"https://api.github.com/repos/scalapenos/stamina/tags","blobs_url":"https://api.github.com/repos/scalapenos/stamina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalapenos/stamina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalapenos/stamina/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalapenos/stamina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalapenos/stamina/statuses/{sha}","languages_url":"https://api.github.com/repos/scalapenos/stamina/languages","stargazers_url":"https://api.github.com/repos/scalapenos/stamina/stargazers","contributors_url":"https://api.github.com/repos/scalapenos/stamina/contributors","subscribers_url":"https://api.github.com/repos/scalapenos/stamina/subscribers","subscription_url":"https://api.github.com/repos/scalapenos/stamina/subscription","commits_url":"https://api.github.com/repos/scalapenos/stamina/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalapenos/stamina/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalapenos/stamina/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalapenos/stamina/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalapenos/stamina/contents/{+path}","compare_url":"https://api.github.com/repos/scalapenos/stamina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalapenos/stamina/merges","archive_url":"https://api.github.com/repos/scalapenos/stamina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalapenos/stamina/downloads","issues_url":"https://api.github.com/repos/scalapenos/stamina/issues{/number}","pulls_url":"https://api.github.com/repos/scalapenos/stamina/pulls{/number}","milestones_url":"https://api.github.com/repos/scalapenos/stamina/milestones{/number}","notifications_url":"https://api.github.com/repos/scalapenos/stamina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalapenos/stamina/labels{/name}","releases_url":"https://api.github.com/repos/scalapenos/stamina/releases{/id}","deployments_url":"https://api.github.com/repos/scalapenos/stamina/deployments","created_at":"2014-12-23T08:32:54Z","updated_at":"2016-02-19T12:40:00Z","pushed_at":"2016-02-19T12:50:35Z","git_url":"git://github.com/scalapenos/stamina.git","ssh_url":"git@github.com:scalapenos/stamina.git","clone_url":"https://github.com/scalapenos/stamina.git","svn_url":"https://github.com/scalapenos/stamina","homepage":"","size":211,"stargazers_count":74,"watchers_count":74,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/44"},"html":{"href":"https://github.com/scalapenos/stamina/pull/44"},"issue":{"href":"https://api.github.com/repos/scalapenos/stamina/issues/44"},"comments":{"href":"https://api.github.com/repos/scalapenos/stamina/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalapenos/stamina/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/scalapenos/stamina/statuses/161694f31ab4538af73a5c16b4c5e8928c125d2f"}}}}