{"action":"created","comment":{"url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/comments/92904238","pull_request_review_id":13430052,"id":92904238,"diff_hunk":"@@ -13,22 +13,48 @@\n const compilerPackage = require('google-closure-compiler');\n const gulp = require('gulp');\n const sourcemaps = require('gulp-sourcemaps');\n+const rollup = require('rollup-stream');\n+const source = require('vinyl-source-stream');\n \n const closureCompiler = compilerPackage.gulp();\n \n-gulp.task('default', () => {\n-  return gulp.src('./src/custom-elements.js', {base: './'})\n+function createDefaultTask(closureOptions = {}) {\n+  return function() {\n+    const defaultClosureOptions = {\n+      compilation_level: 'ADVANCED',\n+      warning_level: 'VERBOSE',\n+      language_in: 'ECMASCRIPT6_STRICT',\n+      language_out: 'ECMASCRIPT5_STRICT',\n+      externs: ['externs/html5.js', 'externs/custom-elements.js'],\n+      dependency_mode: 'STRICT',\n+      entry_point: ['/src/custom-elements'],\n+      js_output_file: 'custom-elements.min.js',\n+      new_type_inf: true,\n+      rewrite_polyfills: false,\n+    };\n+\n+    return gulp.src('./src/*.js', {base: './'})\n       .pipe(sourcemaps.init())\n-      .pipe(closureCompiler({\n-          compilation_level: 'ADVANCED',\n-          warning_level: 'VERBOSE',\n-          language_in: 'ECMASCRIPT6_STRICT',\n-          language_out: 'ECMASCRIPT5_STRICT',\n-          externs: ['externs/html5.js', 'externs/custom-elements.js'],\n-          js_output_file: 'custom-elements.min.js',\n-          new_type_inf: true,\n-          rewrite_polyfills: false,\n-        }))\n+      .pipe(closureCompiler(Object.assign(defaultClosureOptions, closureOptions)))\n       .pipe(sourcemaps.write('/'))\n       .pipe(gulp.dest('./'));\n+  }\n+}\n+\n+gulp.task('default', createDefaultTask());\n+gulp.task('debug', createDefaultTask({\n+  compilation_level: 'SIMPLE',","path":"gulpfile.js","position":46,"original_position":46,"commit_id":"eb6849dfec061ae1589247ad130f9f8414238dd1","original_commit_id":"8379b47e26cb798816294c30399cd135b0223c29","user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"body":"why compile at all for debugging? ","created_at":"2016-12-16T23:38:09Z","updated_at":"2016-12-16T23:38:09Z","html_url":"https://github.com/webcomponents/custom-elements/pull/35#discussion_r92904238","pull_request_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/comments/92904238"},"html":{"href":"https://github.com/webcomponents/custom-elements/pull/35#discussion_r92904238"},"pull_request":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35","id":98027626,"html_url":"https://github.com/webcomponents/custom-elements/pull/35","diff_url":"https://github.com/webcomponents/custom-elements/pull/35.diff","patch_url":"https://github.com/webcomponents/custom-elements/pull/35.patch","issue_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/35","number":35,"state":"open","locked":false,"title":"Create `debug` and `rollup` tasks for debugging.","user":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"body":"The 'debug' task is the same as 'default', with extra options given to closure compiler to make its output a bit easier to read.\r\nThe 'rollup' task is used to compile modules only and leave as much unmodified as possible. I think this will be easiest to debug, but it's furthest from the compiled form.","created_at":"2016-12-14T20:17:36Z","updated_at":"2016-12-16T23:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a42201079c08e0fdee59d7e40bfd30f006c1042","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35/commits","review_comments_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35/comments","review_comment_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/35/comments","statuses_url":"https://api.github.com/repos/webcomponents/custom-elements/statuses/eb6849dfec061ae1589247ad130f9f8414238dd1","head":{"label":"webcomponents:rollup","ref":"rollup","sha":"eb6849dfec061ae1589247ad130f9f8414238dd1","user":{"login":"webcomponents","id":1905708,"avatar_url":"https://avatars.githubusercontent.com/u/1905708?v=3","gravatar_id":"","url":"https://api.github.com/users/webcomponents","html_url":"https://github.com/webcomponents","followers_url":"https://api.github.com/users/webcomponents/followers","following_url":"https://api.github.com/users/webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcomponents/subscriptions","organizations_url":"https://api.github.com/users/webcomponents/orgs","repos_url":"https://api.github.com/users/webcomponents/repos","events_url":"https://api.github.com/users/webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/webcomponents/received_events","type":"Organization","site_admin":false},"repo":{"id":67723354,"name":"custom-elements","full_name":"webcomponents/custom-elements","owner":{"login":"webcomponents","id":1905708,"avatar_url":"https://avatars.githubusercontent.com/u/1905708?v=3","gravatar_id":"","url":"https://api.github.com/users/webcomponents","html_url":"https://github.com/webcomponents","followers_url":"https://api.github.com/users/webcomponents/followers","following_url":"https://api.github.com/users/webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcomponents/subscriptions","organizations_url":"https://api.github.com/users/webcomponents/orgs","repos_url":"https://api.github.com/users/webcomponents/repos","events_url":"https://api.github.com/users/webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/webcomponents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webcomponents/custom-elements","description":"A polyfill for HTML Custom Elements v1","fork":false,"url":"https://api.github.com/repos/webcomponents/custom-elements","forks_url":"https://api.github.com/repos/webcomponents/custom-elements/forks","keys_url":"https://api.github.com/repos/webcomponents/custom-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webcomponents/custom-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webcomponents/custom-elements/teams","hooks_url":"https://api.github.com/repos/webcomponents/custom-elements/hooks","issue_events_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/events{/number}","events_url":"https://api.github.com/repos/webcomponents/custom-elements/events","assignees_url":"https://api.github.com/repos/webcomponents/custom-elements/assignees{/user}","branches_url":"https://api.github.com/repos/webcomponents/custom-elements/branches{/branch}","tags_url":"https://api.github.com/repos/webcomponents/custom-elements/tags","blobs_url":"https://api.github.com/repos/webcomponents/custom-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webcomponents/custom-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webcomponents/custom-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/webcomponents/custom-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webcomponents/custom-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/webcomponents/custom-elements/languages","stargazers_url":"https://api.github.com/repos/webcomponents/custom-elements/stargazers","contributors_url":"https://api.github.com/repos/webcomponents/custom-elements/contributors","subscribers_url":"https://api.github.com/repos/webcomponents/custom-elements/subscribers","subscription_url":"https://api.github.com/repos/webcomponents/custom-elements/subscription","commits_url":"https://api.github.com/repos/webcomponents/custom-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/webcomponents/custom-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/webcomponents/custom-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/webcomponents/custom-elements/contents/{+path}","compare_url":"https://api.github.com/repos/webcomponents/custom-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webcomponents/custom-elements/merges","archive_url":"https://api.github.com/repos/webcomponents/custom-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webcomponents/custom-elements/downloads","issues_url":"https://api.github.com/repos/webcomponents/custom-elements/issues{/number}","pulls_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/webcomponents/custom-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/webcomponents/custom-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webcomponents/custom-elements/labels{/name}","releases_url":"https://api.github.com/repos/webcomponents/custom-elements/releases{/id}","deployments_url":"https://api.github.com/repos/webcomponents/custom-elements/deployments","created_at":"2016-09-08T17:03:05Z","updated_at":"2016-12-11T14:08:52Z","pushed_at":"2016-12-16T23:38:41Z","git_url":"git://github.com/webcomponents/custom-elements.git","ssh_url":"git@github.com:webcomponents/custom-elements.git","clone_url":"https://github.com/webcomponents/custom-elements.git","svn_url":"https://github.com/webcomponents/custom-elements","homepage":"","size":296,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":18,"forks":13,"open_issues":18,"watchers":73,"default_branch":"master"}},"base":{"label":"webcomponents:master","ref":"master","sha":"cd37517c50f097f5cca7b5277011c48e5a16789e","user":{"login":"webcomponents","id":1905708,"avatar_url":"https://avatars.githubusercontent.com/u/1905708?v=3","gravatar_id":"","url":"https://api.github.com/users/webcomponents","html_url":"https://github.com/webcomponents","followers_url":"https://api.github.com/users/webcomponents/followers","following_url":"https://api.github.com/users/webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcomponents/subscriptions","organizations_url":"https://api.github.com/users/webcomponents/orgs","repos_url":"https://api.github.com/users/webcomponents/repos","events_url":"https://api.github.com/users/webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/webcomponents/received_events","type":"Organization","site_admin":false},"repo":{"id":67723354,"name":"custom-elements","full_name":"webcomponents/custom-elements","owner":{"login":"webcomponents","id":1905708,"avatar_url":"https://avatars.githubusercontent.com/u/1905708?v=3","gravatar_id":"","url":"https://api.github.com/users/webcomponents","html_url":"https://github.com/webcomponents","followers_url":"https://api.github.com/users/webcomponents/followers","following_url":"https://api.github.com/users/webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcomponents/subscriptions","organizations_url":"https://api.github.com/users/webcomponents/orgs","repos_url":"https://api.github.com/users/webcomponents/repos","events_url":"https://api.github.com/users/webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/webcomponents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webcomponents/custom-elements","description":"A polyfill for HTML Custom Elements v1","fork":false,"url":"https://api.github.com/repos/webcomponents/custom-elements","forks_url":"https://api.github.com/repos/webcomponents/custom-elements/forks","keys_url":"https://api.github.com/repos/webcomponents/custom-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webcomponents/custom-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webcomponents/custom-elements/teams","hooks_url":"https://api.github.com/repos/webcomponents/custom-elements/hooks","issue_events_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/events{/number}","events_url":"https://api.github.com/repos/webcomponents/custom-elements/events","assignees_url":"https://api.github.com/repos/webcomponents/custom-elements/assignees{/user}","branches_url":"https://api.github.com/repos/webcomponents/custom-elements/branches{/branch}","tags_url":"https://api.github.com/repos/webcomponents/custom-elements/tags","blobs_url":"https://api.github.com/repos/webcomponents/custom-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webcomponents/custom-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webcomponents/custom-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/webcomponents/custom-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webcomponents/custom-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/webcomponents/custom-elements/languages","stargazers_url":"https://api.github.com/repos/webcomponents/custom-elements/stargazers","contributors_url":"https://api.github.com/repos/webcomponents/custom-elements/contributors","subscribers_url":"https://api.github.com/repos/webcomponents/custom-elements/subscribers","subscription_url":"https://api.github.com/repos/webcomponents/custom-elements/subscription","commits_url":"https://api.github.com/repos/webcomponents/custom-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/webcomponents/custom-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/webcomponents/custom-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/webcomponents/custom-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/webcomponents/custom-elements/contents/{+path}","compare_url":"https://api.github.com/repos/webcomponents/custom-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webcomponents/custom-elements/merges","archive_url":"https://api.github.com/repos/webcomponents/custom-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webcomponents/custom-elements/downloads","issues_url":"https://api.github.com/repos/webcomponents/custom-elements/issues{/number}","pulls_url":"https://api.github.com/repos/webcomponents/custom-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/webcomponents/custom-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/webcomponents/custom-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webcomponents/custom-elements/labels{/name}","releases_url":"https://api.github.com/repos/webcomponents/custom-elements/releases{/id}","deployments_url":"https://api.github.com/repos/webcomponents/custom-elements/deployments","created_at":"2016-09-08T17:03:05Z","updated_at":"2016-12-11T14:08:52Z","pushed_at":"2016-12-16T23:38:41Z","git_url":"git://github.com/webcomponents/custom-elements.git","ssh_url":"git@github.com:webcomponents/custom-elements.git","clone_url":"https://github.com/webcomponents/custom-elements.git","svn_url":"https://github.com/webcomponents/custom-elements","homepage":"","size":296,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":18,"forks":13,"open_issues":18,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35"},"html":{"href":"https://github.com/webcomponents/custom-elements/pull/35"},"issue":{"href":"https://api.github.com/repos/webcomponents/custom-elements/issues/35"},"comments":{"href":"https://api.github.com/repos/webcomponents/custom-elements/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webcomponents/custom-elements/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/webcomponents/custom-elements/statuses/eb6849dfec061ae1589247ad130f9f8414238dd1"}}}}
{"actor":{"display_login":"justinfagnani"}}