{"action":"created","issue":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/154","repository_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc","labels_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/154/comments","events_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/154/events","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/154","id":147436855,"number":154,"title":"Auto-run hook for Xcode project settings modifications","user":{"login":"derwaldgeist","id":3984535,"avatar_url":"https://avatars.githubusercontent.com/u/3984535?v=3","gravatar_id":"","url":"https://api.github.com/users/derwaldgeist","html_url":"https://github.com/derwaldgeist","followers_url":"https://api.github.com/users/derwaldgeist/followers","following_url":"https://api.github.com/users/derwaldgeist/following{/other_user}","gists_url":"https://api.github.com/users/derwaldgeist/gists{/gist_id}","starred_url":"https://api.github.com/users/derwaldgeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derwaldgeist/subscriptions","organizations_url":"https://api.github.com/users/derwaldgeist/orgs","repos_url":"https://api.github.com/users/derwaldgeist/repos","events_url":"https://api.github.com/users/derwaldgeist/events{/privacy}","received_events_url":"https://api.github.com/users/derwaldgeist/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-04-11T13:53:14Z","updated_at":"2016-11-21T10:08:45Z","closed_at":"2016-11-21T10:08:45Z","pull_request":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/154","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/154","diff_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/154.diff","patch_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/154.patch"},"body":"Hi @ibc,\n\nthis is to automize the integration of the Xcode project settings hook into the build process, so the users of the plugin won't have to integrate the hook themselves. I made this because the standard way of integrating hooks is not possible with Meteor.\n\nSome implementation notes:\n- The hook now runs \"after_prepare\", because otherwise Meteor would reset the Xcode project settings once the prepare phase is run. I don't know why exactly, but I found this out watching the Xcode project file during the build process. Details can be found here: https://forums.meteor.com/t/cordova-how-to-apply-platform-hook-with-meteor/17692\n- I've replaced the require() for xcode by context.requireCordovaModule('xcode'), because otherwise the script won't find this package when run in the Meteor context.\n- xcodeProject.parseSync() instead of parse() reduces the risk that two plugin hooks run in parallel would override their modifications. This was inspired by a comment in the cordova-disable-bitcode plugin.\n- I changed the minimum iOS version to 9.0, as you are supporting this according to your docs and I did not see any reason why to limit this further.\n- I have only tested the plugin in Meteor, not in plain vanilla Cordova, but it should work there, too.\n- I've also added .editorconfig and .jsbeautifyrc for convenience. Otherwise, my Atom editor would have changed the existing coding style, and maybe this will help other contributors, too.\n\nThere is also a patch to the FakeWebSocket implementation. The existing code would break Meteor's web sockets in rare cases, when `close()` was called before `this.ws` was available. Maybe that's a side-effect of setting `this.ws` inside a timeout(). Just checking this.ws and returning if it is not available yet is of course not optimal, since this will not close the native websocket. Maybe you'll find a better way to handle this.\n"},"comment":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/comments/261895792","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/154#issuecomment-261895792","issue_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/154","id":261895792,"user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T10:08:45Z","updated_at":"2016-11-21T10:08:45Z","body":"I committed the editorconfig change in 7e093b0, but I'm rejecting the rest of the PR based on my reasoning here: https://github.com/eface2face/cordova-plugin-iosrtc/pull/154#issuecomment-260282609"}}
{"actor":{"display_login":"saghul"}}