{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/49287911","id":49287911,"diff_hunk":"@@ -127,10 +127,10 @@ FramebufferManager::FramebufferManager()\n \tD3D::SetDebugObjectName((ID3D11DeviceChild*)m_efb.color_staging_buf, \"EFB color staging texture (used for Renderer::AccessEFB)\");\n \n \t// EFB depth buffer - primary depth buffer\n-\ttexdesc = CD3D11_TEXTURE2D_DESC(DXGI_FORMAT_R24G8_TYPELESS, m_target_width, m_target_height, m_efb.slices, 1, D3D11_BIND_DEPTH_STENCIL | D3D11_BIND_SHADER_RESOURCE, D3D11_USAGE_DEFAULT, 0, sample_desc.Count, sample_desc.Quality);\n+\ttexdesc = CD3D11_TEXTURE2D_DESC(DXGI_FORMAT_R32G8X24_TYPELESS, m_target_width, m_target_height, m_efb.slices, 1, D3D11_BIND_DEPTH_STENCIL | D3D11_BIND_SHADER_RESOURCE, D3D11_USAGE_DEFAULT, 0, sample_desc.Count, sample_desc.Quality);\n \thr = D3D::device->CreateTexture2D(&texdesc, nullptr, &buf);\n \tCHECK(hr==S_OK, \"create EFB depth texture (size: %dx%d; hr=%#x)\", m_target_width, m_target_height, hr);\n-\tm_efb.depth_tex = new D3DTexture2D(buf, (D3D11_BIND_FLAG)(D3D11_BIND_DEPTH_STENCIL|D3D11_BIND_SHADER_RESOURCE), DXGI_FORMAT_R24_UNORM_X8_TYPELESS, DXGI_FORMAT_D24_UNORM_S8_UINT, DXGI_FORMAT_UNKNOWN, (sample_desc.Count > 1));\n+\tm_efb.depth_tex = new D3DTexture2D(buf, (D3D11_BIND_FLAG)(D3D11_BIND_DEPTH_STENCIL|D3D11_BIND_SHADER_RESOURCE), DXGI_FORMAT_R32_FLOAT_X8X24_TYPELESS, DXGI_FORMAT_D32_FLOAT_S8X24_UINT, DXGI_FORMAT_UNKNOWN, (sample_desc.Count > 1));","path":"Source/Core/VideoBackends/D3D/FramebufferManager.cpp","position":9,"original_position":9,"commit_id":"3fd266f21e81a981da4b70f5f86111d4faf8bb0b","original_commit_id":"3fd266f21e81a981da4b70f5f86111d4faf8bb0b","user":{"login":"hdcmeta","id":15706555,"avatar_url":"https://avatars.githubusercontent.com/u/15706555?v=3","gravatar_id":"","url":"https://api.github.com/users/hdcmeta","html_url":"https://github.com/hdcmeta","followers_url":"https://api.github.com/users/hdcmeta/followers","following_url":"https://api.github.com/users/hdcmeta/following{/other_user}","gists_url":"https://api.github.com/users/hdcmeta/gists{/gist_id}","starred_url":"https://api.github.com/users/hdcmeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdcmeta/subscriptions","organizations_url":"https://api.github.com/users/hdcmeta/orgs","repos_url":"https://api.github.com/users/hdcmeta/repos","events_url":"https://api.github.com/users/hdcmeta/events{/privacy}","received_events_url":"https://api.github.com/users/hdcmeta/received_events","type":"User","site_admin":false},"body":"Just to check, should resolved_depth_tex below on line 168 also be changed to this format?","created_at":"2016-01-11T03:24:39Z","updated_at":"2016-01-11T03:24:39Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3495#discussion_r49287911","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/49287911"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3495#discussion_r49287911"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495","id":55579430,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3495","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3495.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3495.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3495","number":3495,"state":"open","locked":false,"title":"D3D: Use a 32-bit floating point depth buffer.","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"body":"This was previously reverted because of a regression on the DefJam FIFO in PR #2415, due to recent changes this seems to no longer be the case.\r\n\r\nThe advantage of using a 32-bit depth buffer is that it fixes round-trip errors as shown by the z poke hw test. Together with the commit that fixes the depth range for Z pokes, D3D has no more roundtrip errors.","created_at":"2016-01-11T00:39:08Z","updated_at":"2016-01-11T03:24:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f09e517655fa8063fc7a32f0d18319c91c4d668","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3495/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3fd266f21e81a981da4b70f5f86111d4faf8bb0b","head":{"label":"Armada651:d3d-float","ref":"d3d-float","sha":"3fd266f21e81a981da4b70f5f86111d4faf8bb0b","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"repo":{"id":16296067,"name":"dolphin","full_name":"Armada651/dolphin","owner":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Armada651/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Armada651/dolphin","forks_url":"https://api.github.com/repos/Armada651/dolphin/forks","keys_url":"https://api.github.com/repos/Armada651/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Armada651/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Armada651/dolphin/teams","hooks_url":"https://api.github.com/repos/Armada651/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Armada651/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Armada651/dolphin/events","assignees_url":"https://api.github.com/repos/Armada651/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Armada651/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Armada651/dolphin/tags","blobs_url":"https://api.github.com/repos/Armada651/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Armada651/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Armada651/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Armada651/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Armada651/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Armada651/dolphin/languages","stargazers_url":"https://api.github.com/repos/Armada651/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Armada651/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Armada651/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Armada651/dolphin/subscription","commits_url":"https://api.github.com/repos/Armada651/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Armada651/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Armada651/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Armada651/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Armada651/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Armada651/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Armada651/dolphin/merges","archive_url":"https://api.github.com/repos/Armada651/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Armada651/dolphin/downloads","issues_url":"https://api.github.com/repos/Armada651/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Armada651/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Armada651/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Armada651/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Armada651/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Armada651/dolphin/releases{/id}","created_at":"2014-01-27T23:04:02Z","updated_at":"2015-07-25T22:40:25Z","pushed_at":"2016-01-11T00:36:08Z","git_url":"git://github.com/Armada651/dolphin.git","ssh_url":"git@github.com:Armada651/dolphin.git","clone_url":"https://github.com/Armada651/dolphin.git","svn_url":"https://github.com/Armada651/dolphin","homepage":null,"size":235282,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"e7fbd1fd50adfdb620cc4d5a85acf7c3cfc21e48","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-01-10T22:16:35Z","pushed_at":"2016-01-11T03:05:20Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":252139,"stargazers_count":1937,"watchers_count":1937,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":79,"forks":588,"open_issues":79,"watchers":1937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3495"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3495"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3495/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3495/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3fd266f21e81a981da4b70f5f86111d4faf8bb0b"}}}}