{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/nuclide/pulls/comments/81661600","pull_request_review_id":2625532,"id":81661600,"diff_hunk":"@@ -147,73 +141,82 @@ xdebug.remote_port = 9000\n ```\n \n > In the Nuclide Settings, there is an option to specify the remote port as well. If you specify\n-> the port in an ini file via `xdebug.remote_port`, make sure that setting matches what is in the\n-> Nuclide setting.\n+> the port in an `.ini` file with `xdebug.remote_port`, make sure it matches what is in the\n+> Nuclide port setting found under `nuclide-debugger-php`.\n+\n+Make sure the **Arguments for your PHP runtime** setting points to your `.ini` file.\n+\n+***Example***\n+\n+```bash\n+-c /root/docker-shared/code/xdebug.ini\n+```\n+\n+The **Path to your PHP runtime** setting should indicate the location of HHVM on your server, such as `/usr/bin/hhvm`.\n+\n \n ### Debugging: HHVM Toolbar\n \n-Nuclide provides an HHVM toolbar. You can launch the toolbar from the\n-[Nuclide toolbar](/docs/features/toolbar/#buttons) or from the\n-[command-palette](/docs/editor/basics/#command-palette) with `Nuclide HHVM Toolbar: Toggle`.\n+<!-- HHVM TOOLBAR WILL BE MOVING INTO TASK RUNNER -->\n+Nuclide provides an HHVM toolbar. You can launch the toolbar from the [Nuclide toolbar](/docs/features/toolbar/#buttons) or from the\n+[Command Palette](/docs/editor/basics/#command-palette) with `Nuclide HHVM Toolbar: Toggle`.\n \n-> You have to have a Hack or PHP file open to successfully launch the toolbar.\n+> You must have a Hack or PHP file open to successfully launch the toolbar.\n \n ![](/static/images/docs/feature-debugger-languages-hack-php-hhvm-toolbar.png)\n \n-Now you can choose between debugging a webserver or a script.\n+You can choose between debugging a webserver or a script.\n \n ![](/static/images/docs/feature-debugger-languages-hack-php-hhvm-toolbar-webserver-script.png)\n \n Set [breakpoints](/docs/features/debugger/#basics__breakpoints) in your code.\n \n-Once you decide the type of debugging you plan to do, click `Attach`. This will bring up the\n-debugger UI and stop at the first breakpoint you set.\n+Once you decide the type of debugging you plan to do, click **Attach** (webserver) or **Launch** (script). This opens the\n+Debugger Controls and stops at the first breakpoint.\n \n You can then follow the [basic debugging information](/docs/features/debugger/#basics) provided\n above and use the additional features of the Output Window, Evaluation and other HHVM-specific\n debugging settings as described below to debug your code.\n \n-Here is an example of debugging a running HHVM server:\n-\n-![](/static/images/docs/feature-debugger-languages-hack-php-server-debugging.png)\n+![](/static/images/docs/feature-debugger-languages-hack-debugging.png)\n \n In both the script and server launching/attaching scenarios, the line at which you've set a\n breakpoint will highlight in blue when the breakpoint is hit. When this happens, execution of your\n-code is paused and you can use the debugger to step, evaluate expressions, inspect the current\n-callstack, etc.\n+code is paused and you can use the Debugger Controls to step, evaluate expressions, inspect the current\n+call stack, etc.\n \n ### Debugging: Command-Line\n \n-You can also debug without using the HHVM Toolbar by debugging directly from the command-line.\n+You can also debug directly from the command-line.\n \n-1. Have a PHP or Hack file active in the [editing area](/docs/editor/basics/#editing-area).\n-2. `cmd-shift-Y` to bring up the process attachment UI.\n-3. Choose the remote server that has your project and HHVM installed from the attachment UI.\n-It should look similar to:\n+1. Have a PHP or Hack file active in the [Editing Area](/docs/editor/basics/#editing-area).\n+2. Click on the **Toggle Debugger** icon in the [Nuclide toolbar](/docs/features/toolbar/#buttons) or press `Cmd-Shift-Y` to bring up the Debugger Selection window.\n+3. Select the remote server where your project is located from the **Connection** drop-down menu. It should default to the remote location of the PHP or Hack file you have open.\n+4. Select the file's type from the **Type** drop-down menu.  For either PHP or Hack, choose **PHP**.\n+5. Select **Attach** from the **Action** drop-down menu.\n \n-    ![](/static/images/docs/feature-debugger-languages-hack-php-attach.png)","path":"docs/_docs/languages/hack.md","position":194,"original_position":194,"commit_id":"e0da9a94de533bd7344936d016e942a6e69e5985","original_commit_id":"e0da9a94de533bd7344936d016e942a6e69e5985","user":{"login":"zardra","id":5318444,"avatar_url":"https://avatars.githubusercontent.com/u/5318444?v=3","gravatar_id":"","url":"https://api.github.com/users/zardra","html_url":"https://github.com/zardra","followers_url":"https://api.github.com/users/zardra/followers","following_url":"https://api.github.com/users/zardra/following{/other_user}","gists_url":"https://api.github.com/users/zardra/gists{/gist_id}","starred_url":"https://api.github.com/users/zardra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardra/subscriptions","organizations_url":"https://api.github.com/users/zardra/orgs","repos_url":"https://api.github.com/users/zardra/repos","events_url":"https://api.github.com/users/zardra/events{/privacy}","received_events_url":"https://api.github.com/users/zardra/received_events","type":"User","site_admin":false},"body":"Deleted","created_at":"2016-10-03T23:25:48Z","updated_at":"2016-10-03T23:25:48Z","html_url":"https://github.com/facebook/nuclide/pull/759#discussion_r81661600","pull_request_url":"https://api.github.com/repos/facebook/nuclide/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/comments/81661600"},"html":{"href":"https://github.com/facebook/nuclide/pull/759#discussion_r81661600"},"pull_request":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/nuclide/pulls/759","id":87767386,"html_url":"https://github.com/facebook/nuclide/pull/759","diff_url":"https://github.com/facebook/nuclide/pull/759.diff","patch_url":"https://github.com/facebook/nuclide/pull/759.patch","issue_url":"https://api.github.com/repos/facebook/nuclide/issues/759","number":759,"state":"open","locked":false,"title":"Updated Hack doc","user":{"login":"zardra","id":5318444,"avatar_url":"https://avatars.githubusercontent.com/u/5318444?v=3","gravatar_id":"","url":"https://api.github.com/users/zardra","html_url":"https://github.com/zardra","followers_url":"https://api.github.com/users/zardra/followers","following_url":"https://api.github.com/users/zardra/following{/other_user}","gists_url":"https://api.github.com/users/zardra/gists{/gist_id}","starred_url":"https://api.github.com/users/zardra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardra/subscriptions","organizations_url":"https://api.github.com/users/zardra/orgs","repos_url":"https://api.github.com/users/zardra/repos","events_url":"https://api.github.com/users/zardra/events{/privacy}","received_events_url":"https://api.github.com/users/zardra/received_events","type":"User","site_admin":false},"body":"Updated debugging section to have more information for XDebug, added new screenshots for the new Debugger UI, and overall editing.","created_at":"2016-10-03T18:35:11Z","updated_at":"2016-10-03T23:25:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"736ac624b6a2c03d2be2bf97d40ddf541bbd4d87","assignee":{"login":"johnislarry","id":1064522,"avatar_url":"https://avatars.githubusercontent.com/u/1064522?v=3","gravatar_id":"","url":"https://api.github.com/users/johnislarry","html_url":"https://github.com/johnislarry","followers_url":"https://api.github.com/users/johnislarry/followers","following_url":"https://api.github.com/users/johnislarry/following{/other_user}","gists_url":"https://api.github.com/users/johnislarry/gists{/gist_id}","starred_url":"https://api.github.com/users/johnislarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnislarry/subscriptions","organizations_url":"https://api.github.com/users/johnislarry/orgs","repos_url":"https://api.github.com/users/johnislarry/repos","events_url":"https://api.github.com/users/johnislarry/events{/privacy}","received_events_url":"https://api.github.com/users/johnislarry/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnislarry","id":1064522,"avatar_url":"https://avatars.githubusercontent.com/u/1064522?v=3","gravatar_id":"","url":"https://api.github.com/users/johnislarry","html_url":"https://github.com/johnislarry","followers_url":"https://api.github.com/users/johnislarry/followers","following_url":"https://api.github.com/users/johnislarry/following{/other_user}","gists_url":"https://api.github.com/users/johnislarry/gists{/gist_id}","starred_url":"https://api.github.com/users/johnislarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnislarry/subscriptions","organizations_url":"https://api.github.com/users/johnislarry/orgs","repos_url":"https://api.github.com/users/johnislarry/repos","events_url":"https://api.github.com/users/johnislarry/events{/privacy}","received_events_url":"https://api.github.com/users/johnislarry/received_events","type":"User","site_admin":false},{"login":"JoelMarcey","id":3757713,"avatar_url":"https://avatars.githubusercontent.com/u/3757713?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelMarcey","html_url":"https://github.com/JoelMarcey","followers_url":"https://api.github.com/users/JoelMarcey/followers","following_url":"https://api.github.com/users/JoelMarcey/following{/other_user}","gists_url":"https://api.github.com/users/JoelMarcey/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelMarcey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelMarcey/subscriptions","organizations_url":"https://api.github.com/users/JoelMarcey/orgs","repos_url":"https://api.github.com/users/JoelMarcey/repos","events_url":"https://api.github.com/users/JoelMarcey/events{/privacy}","received_events_url":"https://api.github.com/users/JoelMarcey/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/nuclide/pulls/759/commits","review_comments_url":"https://api.github.com/repos/facebook/nuclide/pulls/759/comments","review_comment_url":"https://api.github.com/repos/facebook/nuclide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/nuclide/issues/759/comments","statuses_url":"https://api.github.com/repos/facebook/nuclide/statuses/e0da9a94de533bd7344936d016e942a6e69e5985","head":{"label":"zardra:hack","ref":"hack","sha":"e0da9a94de533bd7344936d016e942a6e69e5985","user":{"login":"zardra","id":5318444,"avatar_url":"https://avatars.githubusercontent.com/u/5318444?v=3","gravatar_id":"","url":"https://api.github.com/users/zardra","html_url":"https://github.com/zardra","followers_url":"https://api.github.com/users/zardra/followers","following_url":"https://api.github.com/users/zardra/following{/other_user}","gists_url":"https://api.github.com/users/zardra/gists{/gist_id}","starred_url":"https://api.github.com/users/zardra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardra/subscriptions","organizations_url":"https://api.github.com/users/zardra/orgs","repos_url":"https://api.github.com/users/zardra/repos","events_url":"https://api.github.com/users/zardra/events{/privacy}","received_events_url":"https://api.github.com/users/zardra/received_events","type":"User","site_admin":false},"repo":{"id":68651323,"name":"nuclide","full_name":"zardra/nuclide","owner":{"login":"zardra","id":5318444,"avatar_url":"https://avatars.githubusercontent.com/u/5318444?v=3","gravatar_id":"","url":"https://api.github.com/users/zardra","html_url":"https://github.com/zardra","followers_url":"https://api.github.com/users/zardra/followers","following_url":"https://api.github.com/users/zardra/following{/other_user}","gists_url":"https://api.github.com/users/zardra/gists{/gist_id}","starred_url":"https://api.github.com/users/zardra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardra/subscriptions","organizations_url":"https://api.github.com/users/zardra/orgs","repos_url":"https://api.github.com/users/zardra/repos","events_url":"https://api.github.com/users/zardra/events{/privacy}","received_events_url":"https://api.github.com/users/zardra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zardra/nuclide","description":"An open IDE for web and native mobile development, built on top of Atom ","fork":true,"url":"https://api.github.com/repos/zardra/nuclide","forks_url":"https://api.github.com/repos/zardra/nuclide/forks","keys_url":"https://api.github.com/repos/zardra/nuclide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zardra/nuclide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zardra/nuclide/teams","hooks_url":"https://api.github.com/repos/zardra/nuclide/hooks","issue_events_url":"https://api.github.com/repos/zardra/nuclide/issues/events{/number}","events_url":"https://api.github.com/repos/zardra/nuclide/events","assignees_url":"https://api.github.com/repos/zardra/nuclide/assignees{/user}","branches_url":"https://api.github.com/repos/zardra/nuclide/branches{/branch}","tags_url":"https://api.github.com/repos/zardra/nuclide/tags","blobs_url":"https://api.github.com/repos/zardra/nuclide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zardra/nuclide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zardra/nuclide/git/refs{/sha}","trees_url":"https://api.github.com/repos/zardra/nuclide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zardra/nuclide/statuses/{sha}","languages_url":"https://api.github.com/repos/zardra/nuclide/languages","stargazers_url":"https://api.github.com/repos/zardra/nuclide/stargazers","contributors_url":"https://api.github.com/repos/zardra/nuclide/contributors","subscribers_url":"https://api.github.com/repos/zardra/nuclide/subscribers","subscription_url":"https://api.github.com/repos/zardra/nuclide/subscription","commits_url":"https://api.github.com/repos/zardra/nuclide/commits{/sha}","git_commits_url":"https://api.github.com/repos/zardra/nuclide/git/commits{/sha}","comments_url":"https://api.github.com/repos/zardra/nuclide/comments{/number}","issue_comment_url":"https://api.github.com/repos/zardra/nuclide/issues/comments{/number}","contents_url":"https://api.github.com/repos/zardra/nuclide/contents/{+path}","compare_url":"https://api.github.com/repos/zardra/nuclide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zardra/nuclide/merges","archive_url":"https://api.github.com/repos/zardra/nuclide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zardra/nuclide/downloads","issues_url":"https://api.github.com/repos/zardra/nuclide/issues{/number}","pulls_url":"https://api.github.com/repos/zardra/nuclide/pulls{/number}","milestones_url":"https://api.github.com/repos/zardra/nuclide/milestones{/number}","notifications_url":"https://api.github.com/repos/zardra/nuclide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zardra/nuclide/labels{/name}","releases_url":"https://api.github.com/repos/zardra/nuclide/releases{/id}","deployments_url":"https://api.github.com/repos/zardra/nuclide/deployments","created_at":"2016-09-19T22:16:08Z","updated_at":"2016-09-19T22:16:15Z","pushed_at":"2016-10-03T23:21:18Z","git_url":"git://github.com/zardra/nuclide.git","ssh_url":"git@github.com:zardra/nuclide.git","clone_url":"https://github.com/zardra/nuclide.git","svn_url":"https://github.com/zardra/nuclide","homepage":"http://nuclide.io","size":100608,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b712e70ef7889bc7d41c791a969da3495cc32953","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":31524768,"name":"nuclide","full_name":"facebook/nuclide","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/nuclide","description":"An open IDE for web and native mobile development, built on top of Atom ","fork":false,"url":"https://api.github.com/repos/facebook/nuclide","forks_url":"https://api.github.com/repos/facebook/nuclide/forks","keys_url":"https://api.github.com/repos/facebook/nuclide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/nuclide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/nuclide/teams","hooks_url":"https://api.github.com/repos/facebook/nuclide/hooks","issue_events_url":"https://api.github.com/repos/facebook/nuclide/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/nuclide/events","assignees_url":"https://api.github.com/repos/facebook/nuclide/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/nuclide/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/nuclide/tags","blobs_url":"https://api.github.com/repos/facebook/nuclide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/nuclide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/nuclide/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/nuclide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/nuclide/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/nuclide/languages","stargazers_url":"https://api.github.com/repos/facebook/nuclide/stargazers","contributors_url":"https://api.github.com/repos/facebook/nuclide/contributors","subscribers_url":"https://api.github.com/repos/facebook/nuclide/subscribers","subscription_url":"https://api.github.com/repos/facebook/nuclide/subscription","commits_url":"https://api.github.com/repos/facebook/nuclide/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/nuclide/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/nuclide/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/nuclide/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/nuclide/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/nuclide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/nuclide/merges","archive_url":"https://api.github.com/repos/facebook/nuclide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/nuclide/downloads","issues_url":"https://api.github.com/repos/facebook/nuclide/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/nuclide/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/nuclide/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/nuclide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/nuclide/labels{/name}","releases_url":"https://api.github.com/repos/facebook/nuclide/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/nuclide/deployments","created_at":"2015-03-02T05:25:27Z","updated_at":"2016-10-03T22:57:30Z","pushed_at":"2016-10-03T23:24:37Z","git_url":"git://github.com/facebook/nuclide.git","ssh_url":"git@github.com:facebook/nuclide.git","clone_url":"https://github.com/facebook/nuclide.git","svn_url":"https://github.com/facebook/nuclide","homepage":"http://nuclide.io","size":103855,"stargazers_count":5098,"watchers_count":5098,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":352,"mirror_url":null,"open_issues_count":225,"forks":352,"open_issues":225,"watchers":5098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/759"},"html":{"href":"https://github.com/facebook/nuclide/pull/759"},"issue":{"href":"https://api.github.com/repos/facebook/nuclide/issues/759"},"comments":{"href":"https://api.github.com/repos/facebook/nuclide/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/nuclide/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/nuclide/statuses/e0da9a94de533bd7344936d016e942a6e69e5985"}}}}
{"actor":{"display_login":"zardra"}}