{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10694","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10694/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10694/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10694/events","html_url":"https://github.com/servo/servo/pull/10694","id":149285160,"number":10694,"title":"Add a method for dumping profiles as self-contained HTML w/ timeline visualization","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2016-04-18T22:08:46Z","updated_at":"2016-04-26T15:46:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10694","html_url":"https://github.com/servo/servo/pull/10694","diff_url":"https://github.com/servo/servo/pull/10694.diff","patch_url":"https://github.com/servo/servo/pull/10694.patch"},"body":"This commit adds the `--profiler-trace-path` flag. When combined with `-p` to\r\nenable profiling, it dumps a profile as a self-contained HTML file to the given\r\npath. The profile visualizes the traced operations as a Gantt-chart style\r\ntimeline.\r\n\r\nExample output HTML file: http://media.fitzgeraldnick.com/dumping-grounds/trace-reddit.html\r\n\r\nMostly I made this because I wanted to see what kind of data the profiler has, and thought that this might be useful for others as well. I'm happy to add tests if we can figure out how to integrate them into CI, but I'm not sure how that would work.\r\n\r\nThoughts?\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10694)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/214789502","html_url":"https://github.com/servo/servo/pull/10694#issuecomment-214789502","issue_url":"https://api.github.com/repos/servo/servo/issues/10694","id":214789502,"user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T15:46:57Z","updated_at":"2016-04-26T15:46:57Z","body":"> The yellow overlay is \"above\" the scrollbar which prevents me from click-dragging it to scroll quickly.\n\nDo you mean the scrollbar on the right, for scrolling up and down? Would `overflow: auto` -> `overflow: scroll` fix it?\n\n> Zooming by scrolling on the upper slider should be 10~100 times faster. Right now scrolling the full length of my trackpad or my finger on a mouse wheel make the zoom level barely change.\n\nInteresting! What OS/hardware are you on? On OSX/MBPr, I can zoom all the way out in one swipe.\n\nThese kinds of little tweaks feel like the kinds of things we can handle in follow ups, to me -- do you feel the same?\n\n---\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[components/profile/Cargo.toml, line 33 \\[r4\\]](https://reviewable.io:443/reviews/servo/servo/10694#-KGHRygA9VIM8-rOxNb-:-KGIDlwu7BbuCuVH2cKm:-718544411) ([raw file](https://github.com/servo/servo/blob/aa2cb546da7f9c8b6a3d16cbbb31b0dcf773e4eb/components/profile/Cargo.toml#L33)):*\nI think this happened when I did `cargo add serde_json`... I'll try and clean it up.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/10694#-:-KGIE7qVpRRwsc_jqm-7:-1048397591)*\n<!-- Sent from Reviewable.io -->\n"}}