{"action":"created","comment":{"url":"https://api.github.com/repos/simonduq/contiki/pulls/comments/52943081","id":52943081,"diff_hunk":"@@ -206,8 +208,10 @@ rpl_srh_get_next_hop(uip_ipaddr_t *ipaddr)\n     }\n   }\n \n-  if(uip_next_hdr != NULL && *uip_next_hdr == UIP_PROTO_ROUTING\n-      && UIP_RH_BUF->routing_type == RPL_RH_TYPE_SRH) {\n+  if((uip_next_hdr != NULL && *uip_next_hdr == UIP_PROTO_ROUTING\n+      && UIP_RH_BUF->routing_type == RPL_RH_TYPE_SRH) ||\n+     (default_instance->current_dag->rank == ROOT_RANK(default_instance) &&\n+      rpl_ns_get_node(dag, &UIP_IP_BUF->destipaddr) != NULL)) {","path":"core/net/rpl/rpl-ext-header.c","position":21,"original_position":21,"commit_id":"6a2a4bd36f7657c892bbc1889c4c334ee4128a65","original_commit_id":"6a2a4bd36f7657c892bbc1889c4c334ee4128a65","user":{"login":"simonduq","id":1425999,"avatar_url":"https://avatars.githubusercontent.com/u/1425999?v=3","gravatar_id":"","url":"https://api.github.com/users/simonduq","html_url":"https://github.com/simonduq","followers_url":"https://api.github.com/users/simonduq/followers","following_url":"https://api.github.com/users/simonduq/following{/other_user}","gists_url":"https://api.github.com/users/simonduq/gists{/gist_id}","starred_url":"https://api.github.com/users/simonduq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonduq/subscriptions","organizations_url":"https://api.github.com/users/simonduq/orgs","repos_url":"https://api.github.com/users/simonduq/repos","events_url":"https://api.github.com/users/simonduq/events{/privacy}","received_events_url":"https://api.github.com/users/simonduq/received_events","type":"User","site_admin":false},"body":"This confuses me. Can you explain?","created_at":"2016-02-15T21:02:18Z","updated_at":"2016-02-15T21:02:18Z","html_url":"https://github.com/simonduq/contiki/pull/35#discussion_r52943081","pull_request_url":"https://api.github.com/repos/simonduq/contiki/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/comments/52943081"},"html":{"href":"https://github.com/simonduq/contiki/pull/35#discussion_r52943081"},"pull_request":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/simonduq/contiki/pulls/35","id":59397763,"html_url":"https://github.com/simonduq/contiki/pull/35","diff_url":"https://github.com/simonduq/contiki/pull/35.diff","patch_url":"https://github.com/simonduq/contiki/pull/35.patch","issue_url":"https://api.github.com/repos/simonduq/contiki/issues/35","number":35,"state":"open","locked":false,"title":"Enable the root to send back a DAO-ACK","user":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"body":"I found that the root node did not respond to a DAO with K-bit on. This PR solves the issue.\r\n\r\nTo test this change, I used `regression-tests/12-rpl/05-rpl-up-and-down-routes.csc` with putting the followings into `code/project-conf.h`.\r\n\r\n> #define RPL_CONF_DAO_ACK 1\r\n> #define RPL_CONF_WITH_NON_STORING 1\r\n> #undef RPL_CONF_WITH_STORING\r\n> #define RPL_CONF_WITH_STORING 0\r\n> #undef RPL_CONF_MOP\r\n> #define RPL_CONF_MOP RPL_MOP_NON_STORING","created_at":"2016-02-15T18:11:23Z","updated_at":"2016-02-15T21:02:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e715739c61af2bdc5c4ef78f50c35591d1e4d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simonduq/contiki/pulls/35/commits","review_comments_url":"https://api.github.com/repos/simonduq/contiki/pulls/35/comments","review_comment_url":"https://api.github.com/repos/simonduq/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simonduq/contiki/issues/35/comments","statuses_url":"https://api.github.com/repos/simonduq/contiki/statuses/6a2a4bd36f7657c892bbc1889c4c334ee4128a65","head":{"label":"yatch:pr-non-storing-dao-ack","ref":"pr-non-storing-dao-ack","sha":"6a2a4bd36f7657c892bbc1889c4c334ee4128a65","user":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"repo":{"id":46338132,"name":"contiki","full_name":"yatch/contiki","owner":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yatch/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/yatch/contiki","forks_url":"https://api.github.com/repos/yatch/contiki/forks","keys_url":"https://api.github.com/repos/yatch/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yatch/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yatch/contiki/teams","hooks_url":"https://api.github.com/repos/yatch/contiki/hooks","issue_events_url":"https://api.github.com/repos/yatch/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/yatch/contiki/events","assignees_url":"https://api.github.com/repos/yatch/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/yatch/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/yatch/contiki/tags","blobs_url":"https://api.github.com/repos/yatch/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yatch/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yatch/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/yatch/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yatch/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/yatch/contiki/languages","stargazers_url":"https://api.github.com/repos/yatch/contiki/stargazers","contributors_url":"https://api.github.com/repos/yatch/contiki/contributors","subscribers_url":"https://api.github.com/repos/yatch/contiki/subscribers","subscription_url":"https://api.github.com/repos/yatch/contiki/subscription","commits_url":"https://api.github.com/repos/yatch/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/yatch/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/yatch/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/yatch/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/yatch/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/yatch/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yatch/contiki/merges","archive_url":"https://api.github.com/repos/yatch/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yatch/contiki/downloads","issues_url":"https://api.github.com/repos/yatch/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/yatch/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/yatch/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/yatch/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yatch/contiki/labels{/name}","releases_url":"https://api.github.com/repos/yatch/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/yatch/contiki/deployments","created_at":"2015-11-17T09:54:36Z","updated_at":"2016-02-04T13:27:16Z","pushed_at":"2016-02-15T19:12:40Z","git_url":"git://github.com/yatch/contiki.git","ssh_url":"git@github.com:yatch/contiki.git","clone_url":"https://github.com/yatch/contiki.git","svn_url":"https://github.com/yatch/contiki","homepage":"http://www.contiki-os.org/","size":67105,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simonduq:pr/rpl-non-storing","ref":"pr/rpl-non-storing","sha":"aa6cfd71852714c5288ca18ae92c4178eef00993","user":{"login":"simonduq","id":1425999,"avatar_url":"https://avatars.githubusercontent.com/u/1425999?v=3","gravatar_id":"","url":"https://api.github.com/users/simonduq","html_url":"https://github.com/simonduq","followers_url":"https://api.github.com/users/simonduq/followers","following_url":"https://api.github.com/users/simonduq/following{/other_user}","gists_url":"https://api.github.com/users/simonduq/gists{/gist_id}","starred_url":"https://api.github.com/users/simonduq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonduq/subscriptions","organizations_url":"https://api.github.com/users/simonduq/orgs","repos_url":"https://api.github.com/users/simonduq/repos","events_url":"https://api.github.com/users/simonduq/events{/privacy}","received_events_url":"https://api.github.com/users/simonduq/received_events","type":"User","site_admin":false},"repo":{"id":6440493,"name":"contiki","full_name":"simonduq/contiki","owner":{"login":"simonduq","id":1425999,"avatar_url":"https://avatars.githubusercontent.com/u/1425999?v=3","gravatar_id":"","url":"https://api.github.com/users/simonduq","html_url":"https://github.com/simonduq","followers_url":"https://api.github.com/users/simonduq/followers","following_url":"https://api.github.com/users/simonduq/following{/other_user}","gists_url":"https://api.github.com/users/simonduq/gists{/gist_id}","starred_url":"https://api.github.com/users/simonduq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonduq/subscriptions","organizations_url":"https://api.github.com/users/simonduq/orgs","repos_url":"https://api.github.com/users/simonduq/repos","events_url":"https://api.github.com/users/simonduq/events{/privacy}","received_events_url":"https://api.github.com/users/simonduq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonduq/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/simonduq/contiki","forks_url":"https://api.github.com/repos/simonduq/contiki/forks","keys_url":"https://api.github.com/repos/simonduq/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonduq/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonduq/contiki/teams","hooks_url":"https://api.github.com/repos/simonduq/contiki/hooks","issue_events_url":"https://api.github.com/repos/simonduq/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/simonduq/contiki/events","assignees_url":"https://api.github.com/repos/simonduq/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/simonduq/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/simonduq/contiki/tags","blobs_url":"https://api.github.com/repos/simonduq/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonduq/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonduq/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonduq/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonduq/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/simonduq/contiki/languages","stargazers_url":"https://api.github.com/repos/simonduq/contiki/stargazers","contributors_url":"https://api.github.com/repos/simonduq/contiki/contributors","subscribers_url":"https://api.github.com/repos/simonduq/contiki/subscribers","subscription_url":"https://api.github.com/repos/simonduq/contiki/subscription","commits_url":"https://api.github.com/repos/simonduq/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonduq/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonduq/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonduq/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonduq/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/simonduq/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonduq/contiki/merges","archive_url":"https://api.github.com/repos/simonduq/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonduq/contiki/downloads","issues_url":"https://api.github.com/repos/simonduq/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/simonduq/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/simonduq/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/simonduq/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonduq/contiki/labels{/name}","releases_url":"https://api.github.com/repos/simonduq/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/simonduq/contiki/deployments","created_at":"2012-10-29T12:55:12Z","updated_at":"2015-08-30T09:49:37Z","pushed_at":"2016-02-15T18:11:23Z","git_url":"git://github.com/simonduq/contiki.git","ssh_url":"git@github.com:simonduq/contiki.git","clone_url":"https://github.com/simonduq/contiki.git","svn_url":"https://github.com/simonduq/contiki","homepage":"http://www.contiki-os.org/","size":73992,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/35"},"html":{"href":"https://github.com/simonduq/contiki/pull/35"},"issue":{"href":"https://api.github.com/repos/simonduq/contiki/issues/35"},"comments":{"href":"https://api.github.com/repos/simonduq/contiki/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simonduq/contiki/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/simonduq/contiki/statuses/6a2a4bd36f7657c892bbc1889c4c334ee4128a65"}}}}