{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91736971","pull_request_review_id":12248518,"id":91736971,"diff_hunk":"@@ -5019,3 +5019,11 @@ func GetNodeExternalIP(node *v1.Node) string {\n \t}\n \treturn host\n }\n+func getNodeNames(nodes []*v1.Node) []string {\n+\tnames := []string{}\n+\tfor _, node := range nodes {\n+\t\tnames = append(names, node.Name)\n+\t}\n+\treturn names\n+","path":"test/e2e/framework/util.go","position":null,"original_position":19,"commit_id":"24c1c795ae60dba9eb4740bd43afad6cdf4d42f1","original_commit_id":"44f72826d9a934a14ba6b424fcfb33fa8eba46e5","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"body":"> remove empty line.\r\n@k82cn ok","created_at":"2016-12-09T15:34:15Z","updated_at":"2016-12-09T15:34:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/38283#discussion_r91736971","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91736971"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38283#discussion_r91736971"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283","id":96912781,"html_url":"https://github.com/kubernetes/kubernetes/pull/38283","diff_url":"https://github.com/kubernetes/kubernetes/pull/38283.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38283.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38283","number":38283,"state":"open","locked":false,"title":"fix issue 38229","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"body":"fix this https://github.com/kubernetes/kubernetes/issues/38220","created_at":"2016-12-07T12:17:50Z","updated_at":"2016-12-09T15:34:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69e664e789d07b5f4e5fd8d02cb150025d13bdc1","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38283/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/24c1c795ae60dba9eb4740bd43afad6cdf4d42f1","head":{"label":"wanghaoran1988:fix_issue_38220","ref":"fix_issue_38220","sha":"24c1c795ae60dba9eb4740bd43afad6cdf4d42f1","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"repo":{"id":63595566,"name":"kubernetes","full_name":"wanghaoran1988/kubernetes","owner":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wanghaoran1988/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/wanghaoran1988/kubernetes","forks_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/forks","keys_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/teams","hooks_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/events","assignees_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/tags","blobs_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/subscription","commits_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/merges","archive_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/downloads","issues_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wanghaoran1988/kubernetes/deployments","created_at":"2016-07-18T11:01:16Z","updated_at":"2016-07-18T11:01:34Z","pushed_at":"2016-12-09T15:33:47Z","git_url":"git://github.com/wanghaoran1988/kubernetes.git","ssh_url":"git@github.com:wanghaoran1988/kubernetes.git","clone_url":"https://github.com/wanghaoran1988/kubernetes.git","svn_url":"https://github.com/wanghaoran1988/kubernetes","homepage":"http://kubernetes.io","size":363132,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f5f109ca11049defc2a7bec2ba9f2907e2899187","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-09T15:08:40Z","pushed_at":"2016-12-09T15:33:55Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":663991,"stargazers_count":19047,"watchers_count":19047,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6335,"mirror_url":null,"open_issues_count":5383,"forks":6335,"open_issues":5383,"watchers":19047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38283"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38283"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38283/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38283/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/24c1c795ae60dba9eb4740bd43afad6cdf4d42f1"}}}}
{"actor":{"display_login":"wanghaoran1988"}}