{"action":"closed","number":20965,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965","id":89585591,"html_url":"https://github.com/elastic/elasticsearch/pull/20965","diff_url":"https://github.com/elastic/elasticsearch/pull/20965.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/20965.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20965","number":20965,"state":"closed","locked":false,"title":"Expose splitOnWhitespace in `Query String Query`","user":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars.githubusercontent.com/u/15977469?v=3","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"body":"This change adds an option called `split_on_whitespace` which prevents the query parser to split free text part on whitespace prior to analysis. Instead the queryparser would parse around only real 'operators'. Default to true.\nFor instance the query `\"foo bar\"` would let the analyzer of the targeted field decide how the tokens should be splitted.\nSome options are missing in this change but I'd like to add them in a follow up PR in order to be able to simplify the backport in 5.x. The missing options (changes) are:\n- A `type` option which similarly to the `multi_match` query defines how the free text should be parsed when multi fields are defined.\n- Simple range query with additional tokens like \">100 50\" are broken when `split_on_whitespace` is set to false. It should be possible to preserve this syntax and make the parser aware of this special syntax even when `split_on_whitespace` is set to false.\n- Since all this options would make the `query_string_query` very similar to a match (multi_match) query we should be able to share the code that produce the final Lucene query.\n\nFixes #20841\n","created_at":"2016-10-17T09:09:40Z","updated_at":"2016-11-02T09:00:41Z","closed_at":"2016-11-02T09:00:40Z","merged_at":"2016-11-02T09:00:40Z","merge_commit_sha":"9d6fac809c2f9daf94d9c20a8a206f03e6cbac58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20965/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/3ee2faef92d295b6600defce2313c0bf9c0824f3","head":{"label":"jimczi:split_on_whitespace","ref":"split_on_whitespace","sha":"3ee2faef92d295b6600defce2313c0bf9c0824f3","user":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars.githubusercontent.com/u/15977469?v=3","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"repo":{"id":46779835,"name":"elasticsearch","full_name":"jimczi/elasticsearch","owner":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars.githubusercontent.com/u/15977469?v=3","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimczi/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jimczi/elasticsearch","forks_url":"https://api.github.com/repos/jimczi/elasticsearch/forks","keys_url":"https://api.github.com/repos/jimczi/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimczi/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimczi/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jimczi/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jimczi/elasticsearch/events","assignees_url":"https://api.github.com/repos/jimczi/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jimczi/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jimczi/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimczi/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimczi/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimczi/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jimczi/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jimczi/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jimczi/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jimczi/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jimczi/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jimczi/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimczi/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimczi/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimczi/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jimczi/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimczi/elasticsearch/merges","archive_url":"https://api.github.com/repos/jimczi/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimczi/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jimczi/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jimczi/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jimczi/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jimczi/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimczi/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jimczi/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jimczi/elasticsearch/deployments","created_at":"2015-11-24T09:08:46Z","updated_at":"2016-01-11T09:19:57Z","pushed_at":"2016-11-02T08:59:40Z","git_url":"git://github.com/jimczi/elasticsearch.git","ssh_url":"git@github.com:jimczi/elasticsearch.git","clone_url":"https://github.com/jimczi/elasticsearch.git","svn_url":"https://github.com/jimczi/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":239153,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"aa6cd93e0f860faf869e46386beea3836f635816","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-11-02T08:17:56Z","pushed_at":"2016-11-02T09:00:40Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":366511,"stargazers_count":19105,"watchers_count":19105,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6534,"mirror_url":null,"open_issues_count":1159,"forks":6534,"open_issues":1159,"watchers":19105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/20965"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20965"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20965/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20965/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/3ee2faef92d295b6600defce2313c0bf9c0824f3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars.githubusercontent.com/u/15977469?v=3","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":3,"additions":182,"deletions":4,"changed_files":7}}
{"actor":{"display_login":"jimczi"}}