{"action":"created","issue":{"url":"https://api.github.com/repos/petkaantonov/bluebird/issues/887","labels_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/887/labels{/name}","comments_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/887/comments","events_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/887/events","html_url":"https://github.com/petkaantonov/bluebird/pull/887","id":118453881,"number":887,"title":"Added steed to benchmarks","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-23T19:28:45Z","updated_at":"2016-01-06T19:05:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/petkaantonov/bluebird/pulls/887","html_url":"https://github.com/petkaantonov/bluebird/pull/887","diff_url":"https://github.com/petkaantonov/bluebird/pull/887.diff","patch_url":"https://github.com/petkaantonov/bluebird/pull/887.patch"},"body":"I've added [steed](http://npm.im/steed) to the benchmarks.\r\n\r\nIt takes a different approach compared to neo-async, and possibly the performance might be different. It recycles functions, so they can be optimized (vs allocating new functions). In my tests, performance is similar or better (and it does not pollute `--trace_opt`): here it comes slightly lower, and I still have to investigate what is happening.\r\n\r\nAnyway, it is worth benchmarking.\r\n\r\nBTW, I have found that the benchmarks are more favorable to promise-based apps, because they allocates a lot of functions, which in most cases are not needed in a callback-based implementation. "},"comment":{"url":"https://api.github.com/repos/petkaantonov/bluebird/issues/comments/169422398","html_url":"https://github.com/petkaantonov/bluebird/pull/887#issuecomment-169422398","issue_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/887","id":169422398,"user":{"login":"spion","id":502412,"avatar_url":"https://avatars.githubusercontent.com/u/502412?v=3","gravatar_id":"","url":"https://api.github.com/users/spion","html_url":"https://github.com/spion","followers_url":"https://api.github.com/users/spion/followers","following_url":"https://api.github.com/users/spion/following{/other_user}","gists_url":"https://api.github.com/users/spion/gists{/gist_id}","starred_url":"https://api.github.com/users/spion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spion/subscriptions","organizations_url":"https://api.github.com/users/spion/orgs","repos_url":"https://api.github.com/users/spion/repos","events_url":"https://api.github.com/users/spion/events{/privacy}","received_events_url":"https://api.github.com/users/spion/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T19:05:34Z","updated_at":"2016-01-06T19:05:34Z","body":"Looks okay to me, but I haven't had a chance to test whether everything executes correctly. The trouble with the benchmark code is that there is no verification that all implementations ultimately do the same thing..."}}