{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/228","repository_url":"https://api.github.com/repos/OCA/account-financial-reporting","labels_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/228/comments","events_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/228/events","html_url":"https://github.com/OCA/account-financial-reporting/pull/228","id":178438484,"number":228,"title":"8.0 financial_report_webkit: Better Partner Ledger + Open Invoices report","user":{"login":"alexis-via","id":1157917,"avatar_url":"https://avatars.githubusercontent.com/u/1157917?v=3","gravatar_id":"","url":"https://api.github.com/users/alexis-via","html_url":"https://github.com/alexis-via","followers_url":"https://api.github.com/users/alexis-via/followers","following_url":"https://api.github.com/users/alexis-via/following{/other_user}","gists_url":"https://api.github.com/users/alexis-via/gists{/gist_id}","starred_url":"https://api.github.com/users/alexis-via/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexis-via/subscriptions","organizations_url":"https://api.github.com/users/alexis-via/orgs","repos_url":"https://api.github.com/users/alexis-via/repos","events_url":"https://api.github.com/users/alexis-via/events{/privacy}","received_events_url":"https://api.github.com/users/alexis-via/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-21T19:18:41Z","updated_at":"2016-09-21T19:22:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/228","html_url":"https://github.com/OCA/account-financial-reporting/pull/228","diff_url":"https://github.com/OCA/account-financial-reporting/pull/228.diff","patch_url":"https://github.com/OCA/account-financial-reporting/pull/228.patch"},"body":"I improved Partner Ledger and Open Invoices Report to allow the selection of all account types (not just receivable and/or payable) and I added a filter on accounts.\r\n\r\nI also renamed the object account.aged.trial.balance.webkit to aged.trial.balance.webkit to make it shorter.\r\nPostgres limits the length of table and index names to 63 characters cf https://til.hashrocket.com/posts/8f87c65a0a-postgresqls-max-identifier-length-is-63-bytes.\r\nThis causes a problem with a M2M field from account.aged.trial.balance.webkit to account.account (for account filter) because the names of the 2 indexes of the M2M table would be:\r\n\r\n* account_account_account_aged_trial_balance_webkit_rel_account_aged_trial_balance_webkit_id_index\r\n* account_account_account_aged_trial_balance_webkit_rel_account_account_id_index\r\n\r\nThe labels are longer than 63 characters and the 63 first caracters are identical:\r\n\r\naccount_account_account_aged_trial_balance_webkit_rel_account_a (63 chars)\r\n\r\nBad luck: the first different caracters is character 64 !\r\nThat's why I decided to reduce the size of the object name 'account.aged.trial.balance.webkit'."},"comment":{"url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/comments/248715578","html_url":"https://github.com/OCA/account-financial-reporting/pull/228#issuecomment-248715578","issue_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/228","id":248715578,"user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T19:22:38Z","updated_at":"2016-09-21T19:22:38Z","body":"Instead of changing the table name, just use `relation` attribute of the many2many field to set manually the many2many table, because this change in an stable version can't be as there are modules that can inherit the renamed table."}}
{"actor":{"display_login":"pedrobaeza"}}