{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray-ng/pulls/comments/87086280","pull_request_review_id":7712460,"id":87086280,"diff_hunk":"@@ -182,13 +207,17 @@ int64_t task_arg_length(task_spec *spec, int64_t arg_index) {\n }\n \n int64_t task_args_add_ref(task_spec *spec, object_id obj_id) {\n+  /* Check that the task is still under construction. */\n+  CHECK(task_ids_equal(spec->task_id, NIL_TASK_ID));","path":"src/common/task.c","position":187,"original_position":124,"commit_id":"b13cfcf519259abd7da183d22be9473072f947c0","original_commit_id":"4d366a25fcca845b095d0993b017000d7ea2fd9b","user":{"login":"pcmoritz","id":113316,"avatar_url":"https://avatars.githubusercontent.com/u/113316?v=3","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false},"body":"DCHECK","created_at":"2016-11-08T21:22:34Z","updated_at":"2016-11-08T21:22:34Z","html_url":"https://github.com/ray-project/ray-ng/pull/31#discussion_r87086280","pull_request_url":"https://api.github.com/repos/ray-project/ray-ng/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/comments/87086280"},"html":{"href":"https://github.com/ray-project/ray-ng/pull/31#discussion_r87086280"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray-ng/pulls/31","id":92664043,"html_url":"https://github.com/ray-project/ray-ng/pull/31","diff_url":"https://github.com/ray-project/ray-ng/pull/31.diff","patch_url":"https://github.com/ray-project/ray-ng/pull/31.patch","issue_url":"https://api.github.com/repos/ray-project/ray-ng/issues/31","number":31,"state":"open","locked":false,"title":"Compute task IDs and object IDs deterministically.","user":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars.githubusercontent.com/u/249517?v=3","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-07T21:06:51Z","updated_at":"2016-11-08T21:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a3b56f3d16c36a458c2d67dde7aabf0755499a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray-ng/pulls/31/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray-ng/pulls/31/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray-ng/issues/31/comments","statuses_url":"https://api.github.com/repos/ray-project/ray-ng/statuses/b13cfcf519259abd7da183d22be9473072f947c0","head":{"label":"ray-project:objids","ref":"objids","sha":"b13cfcf519259abd7da183d22be9473072f947c0","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray-ng","full_name":"ray-project/ray-ng","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray-ng","description":null,"fork":false,"url":"https://api.github.com/repos/ray-project/ray-ng","forks_url":"https://api.github.com/repos/ray-project/ray-ng/forks","keys_url":"https://api.github.com/repos/ray-project/ray-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray-ng/teams","hooks_url":"https://api.github.com/repos/ray-project/ray-ng/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray-ng/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray-ng/events","assignees_url":"https://api.github.com/repos/ray-project/ray-ng/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray-ng/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray-ng/tags","blobs_url":"https://api.github.com/repos/ray-project/ray-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray-ng/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray-ng/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray-ng/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray-ng/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray-ng/subscription","commits_url":"https://api.github.com/repos/ray-project/ray-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray-ng/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray-ng/merges","archive_url":"https://api.github.com/repos/ray-project/ray-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray-ng/downloads","issues_url":"https://api.github.com/repos/ray-project/ray-ng/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray-ng/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray-ng/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray-ng/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2016-10-29T22:22:34Z","pushed_at":"2016-11-08T21:19:01Z","git_url":"git://github.com/ray-project/ray-ng.git","ssh_url":"git@github.com:ray-project/ray-ng.git","clone_url":"https://github.com/ray-project/ray-ng.git","svn_url":"https://github.com/ray-project/ray-ng","homepage":null,"size":1906,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"90f88af902cdb04d8acd448c284f57b6728564eb","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray-ng","full_name":"ray-project/ray-ng","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray-ng","description":null,"fork":false,"url":"https://api.github.com/repos/ray-project/ray-ng","forks_url":"https://api.github.com/repos/ray-project/ray-ng/forks","keys_url":"https://api.github.com/repos/ray-project/ray-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray-ng/teams","hooks_url":"https://api.github.com/repos/ray-project/ray-ng/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray-ng/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray-ng/events","assignees_url":"https://api.github.com/repos/ray-project/ray-ng/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray-ng/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray-ng/tags","blobs_url":"https://api.github.com/repos/ray-project/ray-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray-ng/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray-ng/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray-ng/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray-ng/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray-ng/subscription","commits_url":"https://api.github.com/repos/ray-project/ray-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray-ng/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray-ng/merges","archive_url":"https://api.github.com/repos/ray-project/ray-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray-ng/downloads","issues_url":"https://api.github.com/repos/ray-project/ray-ng/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray-ng/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray-ng/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray-ng/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2016-10-29T22:22:34Z","pushed_at":"2016-11-08T21:19:01Z","git_url":"git://github.com/ray-project/ray-ng.git","ssh_url":"git@github.com:ray-project/ray-ng.git","clone_url":"https://github.com/ray-project/ray-ng.git","svn_url":"https://github.com/ray-project/ray-ng","homepage":null,"size":1906,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/31"},"html":{"href":"https://github.com/ray-project/ray-ng/pull/31"},"issue":{"href":"https://api.github.com/repos/ray-project/ray-ng/issues/31"},"comments":{"href":"https://api.github.com/repos/ray-project/ray-ng/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray-ng/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray-ng/statuses/b13cfcf519259abd7da183d22be9473072f947c0"}}}}
{"actor":{"display_login":"pcmoritz"}}