{"action":"created","comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/64702383","id":64702383,"diff_hunk":"@@ -109,6 +109,9 @@ export function spawn(command: string, args?: Array<string> | null, options?: Sp\n }\n \n export async function getElectronVersion(packageData: any, packageJsonPath: string): Promise<string> {\n+  if (packageData.config['electron-version']) {\n+    return packageData.config['electron-version']","path":"src/util.ts","position":5,"original_position":5,"commit_id":"1febf6c88e0c90e57285a256a0ed80099a9cd28e","original_commit_id":"1febf6c88e0c90e57285a256a0ed80099a9cd28e","user":{"login":"develar","id":350686,"avatar_url":"https://avatars.githubusercontent.com/u/350686?v=3","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"body":"In any case user will get clear error on electron-download.\r\n\r\nElectron version is not documented at all, yeah... We should document it some day.","created_at":"2016-05-26T07:36:10Z","updated_at":"2016-05-26T07:36:11Z","html_url":"https://github.com/electron-userland/electron-builder/pull/418#discussion_r64702383","pull_request_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/64702383"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/418#discussion_r64702383"},"pull_request":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418","id":70845737,"html_url":"https://github.com/electron-userland/electron-builder/pull/418","diff_url":"https://github.com/electron-userland/electron-builder/pull/418.diff","patch_url":"https://github.com/electron-userland/electron-builder/pull/418.patch","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/418","number":418,"state":"closed","locked":false,"title":"feat: Support finding electron version in package config","user":{"login":"mcfedr","id":704356,"avatar_url":"https://avatars.githubusercontent.com/u/704356?v=3","gravatar_id":"","url":"https://api.github.com/users/mcfedr","html_url":"https://github.com/mcfedr","followers_url":"https://api.github.com/users/mcfedr/followers","following_url":"https://api.github.com/users/mcfedr/following{/other_user}","gists_url":"https://api.github.com/users/mcfedr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcfedr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcfedr/subscriptions","organizations_url":"https://api.github.com/users/mcfedr/orgs","repos_url":"https://api.github.com/users/mcfedr/repos","events_url":"https://api.github.com/users/mcfedr/events{/privacy}","received_events_url":"https://api.github.com/users/mcfedr/received_events","type":"User","site_admin":false},"body":"Allows the user to avoid extra downloads of electron for current\r\nplatform when he might not need to. Also allows using versions that\r\nare not released on electron-prebuilt\r\n\r\nhttps://github.com/electron-userland/electron-packager/pull/374","created_at":"2016-05-20T12:18:54Z","updated_at":"2016-05-26T07:36:11Z","closed_at":"2016-05-26T07:33:30Z","merged_at":null,"merge_commit_sha":"d057a0145ec607dc80bdd3db35f5ed8cb3a53889","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418/commits","review_comments_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418/comments","review_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/418/comments","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/1febf6c88e0c90e57285a256a0ed80099a9cd28e","head":{"label":"mcfedr:electron-version","ref":"electron-version","sha":"1febf6c88e0c90e57285a256a0ed80099a9cd28e","user":{"login":"mcfedr","id":704356,"avatar_url":"https://avatars.githubusercontent.com/u/704356?v=3","gravatar_id":"","url":"https://api.github.com/users/mcfedr","html_url":"https://github.com/mcfedr","followers_url":"https://api.github.com/users/mcfedr/followers","following_url":"https://api.github.com/users/mcfedr/following{/other_user}","gists_url":"https://api.github.com/users/mcfedr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcfedr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcfedr/subscriptions","organizations_url":"https://api.github.com/users/mcfedr/orgs","repos_url":"https://api.github.com/users/mcfedr/repos","events_url":"https://api.github.com/users/mcfedr/events{/privacy}","received_events_url":"https://api.github.com/users/mcfedr/received_events","type":"User","site_admin":false},"repo":{"id":59291828,"name":"electron-builder","full_name":"mcfedr/electron-builder","owner":{"login":"mcfedr","id":704356,"avatar_url":"https://avatars.githubusercontent.com/u/704356?v=3","gravatar_id":"","url":"https://api.github.com/users/mcfedr","html_url":"https://github.com/mcfedr","followers_url":"https://api.github.com/users/mcfedr/followers","following_url":"https://api.github.com/users/mcfedr/following{/other_user}","gists_url":"https://api.github.com/users/mcfedr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcfedr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcfedr/subscriptions","organizations_url":"https://api.github.com/users/mcfedr/orgs","repos_url":"https://api.github.com/users/mcfedr/repos","events_url":"https://api.github.com/users/mcfedr/events{/privacy}","received_events_url":"https://api.github.com/users/mcfedr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcfedr/electron-builder","description":"Complete solution to package and deploy Electron apps","fork":true,"url":"https://api.github.com/repos/mcfedr/electron-builder","forks_url":"https://api.github.com/repos/mcfedr/electron-builder/forks","keys_url":"https://api.github.com/repos/mcfedr/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcfedr/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcfedr/electron-builder/teams","hooks_url":"https://api.github.com/repos/mcfedr/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/mcfedr/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/mcfedr/electron-builder/events","assignees_url":"https://api.github.com/repos/mcfedr/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/mcfedr/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/mcfedr/electron-builder/tags","blobs_url":"https://api.github.com/repos/mcfedr/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcfedr/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcfedr/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcfedr/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcfedr/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/mcfedr/electron-builder/languages","stargazers_url":"https://api.github.com/repos/mcfedr/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/mcfedr/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/mcfedr/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/mcfedr/electron-builder/subscription","commits_url":"https://api.github.com/repos/mcfedr/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcfedr/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcfedr/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcfedr/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcfedr/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/mcfedr/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcfedr/electron-builder/merges","archive_url":"https://api.github.com/repos/mcfedr/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcfedr/electron-builder/downloads","issues_url":"https://api.github.com/repos/mcfedr/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/mcfedr/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/mcfedr/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/mcfedr/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcfedr/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/mcfedr/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/mcfedr/electron-builder/deployments","created_at":"2016-05-20T12:18:22Z","updated_at":"2016-05-20T12:18:23Z","pushed_at":"2016-05-20T12:18:44Z","git_url":"git://github.com/mcfedr/electron-builder.git","ssh_url":"git@github.com:mcfedr/electron-builder.git","clone_url":"https://github.com/mcfedr/electron-builder.git","svn_url":"https://github.com/mcfedr/electron-builder","homepage":"","size":105222,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron-userland:master","ref":"master","sha":"f5c6fcfc15b3e85ba9b34491829f3d25b6cb0dcb","user":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"repo":{"id":35998691,"name":"electron-builder","full_name":"electron-userland/electron-builder","owner":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron-userland/electron-builder","description":"Complete solution to package and deploy Electron apps","fork":false,"url":"https://api.github.com/repos/electron-userland/electron-builder","forks_url":"https://api.github.com/repos/electron-userland/electron-builder/forks","keys_url":"https://api.github.com/repos/electron-userland/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron-userland/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron-userland/electron-builder/teams","hooks_url":"https://api.github.com/repos/electron-userland/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/electron-userland/electron-builder/events","assignees_url":"https://api.github.com/repos/electron-userland/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/electron-userland/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/electron-userland/electron-builder/tags","blobs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron-userland/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron-userland/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/electron-userland/electron-builder/languages","stargazers_url":"https://api.github.com/repos/electron-userland/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/electron-userland/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/electron-userland/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/electron-userland/electron-builder/subscription","commits_url":"https://api.github.com/repos/electron-userland/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron-userland/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron-userland/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/electron-userland/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron-userland/electron-builder/merges","archive_url":"https://api.github.com/repos/electron-userland/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron-userland/electron-builder/downloads","issues_url":"https://api.github.com/repos/electron-userland/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/electron-userland/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/electron-userland/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/electron-userland/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/electron-userland/electron-builder/deployments","created_at":"2015-05-21T07:45:02Z","updated_at":"2016-05-25T23:17:49Z","pushed_at":"2016-05-26T07:33:52Z","git_url":"git://github.com/electron-userland/electron-builder.git","ssh_url":"git@github.com:electron-userland/electron-builder.git","clone_url":"https://github.com/electron-userland/electron-builder.git","svn_url":"https://github.com/electron-userland/electron-builder","homepage":"","size":105534,"stargazers_count":891,"watchers_count":891,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":20,"forks":87,"open_issues":20,"watchers":891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/418"},"issue":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/418"},"comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/electron-userland/electron-builder/statuses/1febf6c88e0c90e57285a256a0ed80099a9cd28e"}}}}
{"actor":{"display_login":"develar"}}