{"action":"created","comment":{"url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/comments/64046776","id":64046776,"diff_hunk":"@@ -32,3 +32,25 @@\n                                       node?.tag is 'tag:yaml.org,2002:map'\n \n @NON_PRINTABLE = /[^\\x09\\x0A\\x0D\\x20-\\x7E\\x85\\xA0-\\uD7FF\\uE000-\\uFFFD]/\n+\n+@stringifyJSONCircularDepth = (json, depth = 1000) ->","path":"src/util.coffee","position":10,"original_position":5,"commit_id":"7bd7ad4958a79766f9e5f3fafa73dda4a4f1a380","original_commit_id":"8391697e18dd0d167889cfa7d6be0f7ce82e2a88","user":{"login":"dmartinezg","id":1099335,"avatar_url":"https://avatars.githubusercontent.com/u/1099335?v=3","gravatar_id":"","url":"https://api.github.com/users/dmartinezg","html_url":"https://github.com/dmartinezg","followers_url":"https://api.github.com/users/dmartinezg/followers","following_url":"https://api.github.com/users/dmartinezg/following{/other_user}","gists_url":"https://api.github.com/users/dmartinezg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmartinezg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmartinezg/subscriptions","organizations_url":"https://api.github.com/users/dmartinezg/orgs","repos_url":"https://api.github.com/users/dmartinezg/repos","events_url":"https://api.github.com/users/dmartinezg/events{/privacy}","received_events_url":"https://api.github.com/users/dmartinezg/received_events","type":"User","site_admin":false},"body":"My sentiment exactly @derrickburns, I think that the parser should just abort on any circular reference detected.","created_at":"2016-05-20T14:09:51Z","updated_at":"2016-05-20T14:09:51Z","html_url":"https://github.com/raml-org/raml-js-parser/pull/180#discussion_r64046776","pull_request_url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/comments/64046776"},"html":{"href":"https://github.com/raml-org/raml-js-parser/pull/180#discussion_r64046776"},"pull_request":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180","id":70334359,"html_url":"https://github.com/raml-org/raml-js-parser/pull/180","diff_url":"https://github.com/raml-org/raml-js-parser/pull/180.diff","patch_url":"https://github.com/raml-org/raml-js-parser/pull/180.patch","issue_url":"https://api.github.com/repos/raml-org/raml-js-parser/issues/180","number":180,"state":"open","locked":false,"title":"Features/dereferencing support with circular references","user":{"login":"repocho","id":3710022,"avatar_url":"https://avatars.githubusercontent.com/u/3710022?v=3","gravatar_id":"","url":"https://api.github.com/users/repocho","html_url":"https://github.com/repocho","followers_url":"https://api.github.com/users/repocho/followers","following_url":"https://api.github.com/users/repocho/following{/other_user}","gists_url":"https://api.github.com/users/repocho/gists{/gist_id}","starred_url":"https://api.github.com/users/repocho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repocho/subscriptions","organizations_url":"https://api.github.com/users/repocho/orgs","repos_url":"https://api.github.com/users/repocho/repos","events_url":"https://api.github.com/users/repocho/events{/privacy}","received_events_url":"https://api.github.com/users/repocho/received_events","type":"User","site_admin":false},"body":"Fixes #179 \r\n\r\nFinally I limited the circular references up to 500 by default which in my case is not throwing errors. \r\n\r\nIf there is a harder limit of nodejs you can set the maxDepth like this example:\r\n\r\n`raml.loadFile('raml-files/circular.raml', {\r\n      dereferenceSchemas: { maxDepth: 25}\r\n})`","created_at":"2016-05-17T10:36:19Z","updated_at":"2016-05-20T14:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b720a127d3be857c7bfd32d44ddfd428da3a093","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180/commits","review_comments_url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180/comments","review_comment_url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raml-org/raml-js-parser/issues/180/comments","statuses_url":"https://api.github.com/repos/raml-org/raml-js-parser/statuses/7bd7ad4958a79766f9e5f3fafa73dda4a4f1a380","head":{"label":"repocho:features/dereferencing-support-with-circular-references","ref":"features/dereferencing-support-with-circular-references","sha":"7bd7ad4958a79766f9e5f3fafa73dda4a4f1a380","user":{"login":"repocho","id":3710022,"avatar_url":"https://avatars.githubusercontent.com/u/3710022?v=3","gravatar_id":"","url":"https://api.github.com/users/repocho","html_url":"https://github.com/repocho","followers_url":"https://api.github.com/users/repocho/followers","following_url":"https://api.github.com/users/repocho/following{/other_user}","gists_url":"https://api.github.com/users/repocho/gists{/gist_id}","starred_url":"https://api.github.com/users/repocho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repocho/subscriptions","organizations_url":"https://api.github.com/users/repocho/orgs","repos_url":"https://api.github.com/users/repocho/repos","events_url":"https://api.github.com/users/repocho/events{/privacy}","received_events_url":"https://api.github.com/users/repocho/received_events","type":"User","site_admin":false},"repo":{"id":58745147,"name":"raml-js-parser","full_name":"repocho/raml-js-parser","owner":{"login":"repocho","id":3710022,"avatar_url":"https://avatars.githubusercontent.com/u/3710022?v=3","gravatar_id":"","url":"https://api.github.com/users/repocho","html_url":"https://github.com/repocho","followers_url":"https://api.github.com/users/repocho/followers","following_url":"https://api.github.com/users/repocho/following{/other_user}","gists_url":"https://api.github.com/users/repocho/gists{/gist_id}","starred_url":"https://api.github.com/users/repocho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repocho/subscriptions","organizations_url":"https://api.github.com/users/repocho/orgs","repos_url":"https://api.github.com/users/repocho/repos","events_url":"https://api.github.com/users/repocho/events{/privacy}","received_events_url":"https://api.github.com/users/repocho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/repocho/raml-js-parser","description":"A RAML parser based on PyYAML written in CoffeScript and available for use as NodeJs module or in-browser.","fork":true,"url":"https://api.github.com/repos/repocho/raml-js-parser","forks_url":"https://api.github.com/repos/repocho/raml-js-parser/forks","keys_url":"https://api.github.com/repos/repocho/raml-js-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/repocho/raml-js-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/repocho/raml-js-parser/teams","hooks_url":"https://api.github.com/repos/repocho/raml-js-parser/hooks","issue_events_url":"https://api.github.com/repos/repocho/raml-js-parser/issues/events{/number}","events_url":"https://api.github.com/repos/repocho/raml-js-parser/events","assignees_url":"https://api.github.com/repos/repocho/raml-js-parser/assignees{/user}","branches_url":"https://api.github.com/repos/repocho/raml-js-parser/branches{/branch}","tags_url":"https://api.github.com/repos/repocho/raml-js-parser/tags","blobs_url":"https://api.github.com/repos/repocho/raml-js-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/repocho/raml-js-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/repocho/raml-js-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/repocho/raml-js-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/repocho/raml-js-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/repocho/raml-js-parser/languages","stargazers_url":"https://api.github.com/repos/repocho/raml-js-parser/stargazers","contributors_url":"https://api.github.com/repos/repocho/raml-js-parser/contributors","subscribers_url":"https://api.github.com/repos/repocho/raml-js-parser/subscribers","subscription_url":"https://api.github.com/repos/repocho/raml-js-parser/subscription","commits_url":"https://api.github.com/repos/repocho/raml-js-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/repocho/raml-js-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/repocho/raml-js-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/repocho/raml-js-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/repocho/raml-js-parser/contents/{+path}","compare_url":"https://api.github.com/repos/repocho/raml-js-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/repocho/raml-js-parser/merges","archive_url":"https://api.github.com/repos/repocho/raml-js-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/repocho/raml-js-parser/downloads","issues_url":"https://api.github.com/repos/repocho/raml-js-parser/issues{/number}","pulls_url":"https://api.github.com/repos/repocho/raml-js-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/repocho/raml-js-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/repocho/raml-js-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/repocho/raml-js-parser/labels{/name}","releases_url":"https://api.github.com/repos/repocho/raml-js-parser/releases{/id}","deployments_url":"https://api.github.com/repos/repocho/raml-js-parser/deployments","created_at":"2016-05-13T14:01:06Z","updated_at":"2016-05-13T14:01:07Z","pushed_at":"2016-05-17T16:55:16Z","git_url":"git://github.com/repocho/raml-js-parser.git","ssh_url":"git@github.com:repocho/raml-js-parser.git","clone_url":"https://github.com/repocho/raml-js-parser.git","svn_url":"https://github.com/repocho/raml-js-parser","homepage":"","size":3469,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raml-org:master","ref":"master","sha":"004e404d324674aed256daa2974fd856d0f7429d","user":{"login":"raml-org","id":5579724,"avatar_url":"https://avatars.githubusercontent.com/u/5579724?v=3","gravatar_id":"","url":"https://api.github.com/users/raml-org","html_url":"https://github.com/raml-org","followers_url":"https://api.github.com/users/raml-org/followers","following_url":"https://api.github.com/users/raml-org/following{/other_user}","gists_url":"https://api.github.com/users/raml-org/gists{/gist_id}","starred_url":"https://api.github.com/users/raml-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raml-org/subscriptions","organizations_url":"https://api.github.com/users/raml-org/orgs","repos_url":"https://api.github.com/users/raml-org/repos","events_url":"https://api.github.com/users/raml-org/events{/privacy}","received_events_url":"https://api.github.com/users/raml-org/received_events","type":"Organization","site_admin":false},"repo":{"id":10970624,"name":"raml-js-parser","full_name":"raml-org/raml-js-parser","owner":{"login":"raml-org","id":5579724,"avatar_url":"https://avatars.githubusercontent.com/u/5579724?v=3","gravatar_id":"","url":"https://api.github.com/users/raml-org","html_url":"https://github.com/raml-org","followers_url":"https://api.github.com/users/raml-org/followers","following_url":"https://api.github.com/users/raml-org/following{/other_user}","gists_url":"https://api.github.com/users/raml-org/gists{/gist_id}","starred_url":"https://api.github.com/users/raml-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raml-org/subscriptions","organizations_url":"https://api.github.com/users/raml-org/orgs","repos_url":"https://api.github.com/users/raml-org/repos","events_url":"https://api.github.com/users/raml-org/events{/privacy}","received_events_url":"https://api.github.com/users/raml-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raml-org/raml-js-parser","description":"A RAML parser based on PyYAML written in CoffeScript and available for use as NodeJs module or in-browser.","fork":false,"url":"https://api.github.com/repos/raml-org/raml-js-parser","forks_url":"https://api.github.com/repos/raml-org/raml-js-parser/forks","keys_url":"https://api.github.com/repos/raml-org/raml-js-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raml-org/raml-js-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raml-org/raml-js-parser/teams","hooks_url":"https://api.github.com/repos/raml-org/raml-js-parser/hooks","issue_events_url":"https://api.github.com/repos/raml-org/raml-js-parser/issues/events{/number}","events_url":"https://api.github.com/repos/raml-org/raml-js-parser/events","assignees_url":"https://api.github.com/repos/raml-org/raml-js-parser/assignees{/user}","branches_url":"https://api.github.com/repos/raml-org/raml-js-parser/branches{/branch}","tags_url":"https://api.github.com/repos/raml-org/raml-js-parser/tags","blobs_url":"https://api.github.com/repos/raml-org/raml-js-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raml-org/raml-js-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raml-org/raml-js-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/raml-org/raml-js-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raml-org/raml-js-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/raml-org/raml-js-parser/languages","stargazers_url":"https://api.github.com/repos/raml-org/raml-js-parser/stargazers","contributors_url":"https://api.github.com/repos/raml-org/raml-js-parser/contributors","subscribers_url":"https://api.github.com/repos/raml-org/raml-js-parser/subscribers","subscription_url":"https://api.github.com/repos/raml-org/raml-js-parser/subscription","commits_url":"https://api.github.com/repos/raml-org/raml-js-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/raml-org/raml-js-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/raml-org/raml-js-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/raml-org/raml-js-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/raml-org/raml-js-parser/contents/{+path}","compare_url":"https://api.github.com/repos/raml-org/raml-js-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raml-org/raml-js-parser/merges","archive_url":"https://api.github.com/repos/raml-org/raml-js-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raml-org/raml-js-parser/downloads","issues_url":"https://api.github.com/repos/raml-org/raml-js-parser/issues{/number}","pulls_url":"https://api.github.com/repos/raml-org/raml-js-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/raml-org/raml-js-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/raml-org/raml-js-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raml-org/raml-js-parser/labels{/name}","releases_url":"https://api.github.com/repos/raml-org/raml-js-parser/releases{/id}","deployments_url":"https://api.github.com/repos/raml-org/raml-js-parser/deployments","created_at":"2013-06-26T14:49:42Z","updated_at":"2016-05-13T13:58:35Z","pushed_at":"2016-05-17T16:55:17Z","git_url":"git://github.com/raml-org/raml-js-parser.git","ssh_url":"git@github.com:raml-org/raml-js-parser.git","clone_url":"https://github.com/raml-org/raml-js-parser.git","svn_url":"https://github.com/raml-org/raml-js-parser","homepage":"","size":4101,"stargazers_count":176,"watchers_count":176,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":17,"forks":55,"open_issues":17,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180"},"html":{"href":"https://github.com/raml-org/raml-js-parser/pull/180"},"issue":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/issues/180"},"comments":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/raml-org/raml-js-parser/statuses/7bd7ad4958a79766f9e5f3fafa73dda4a4f1a380"}}}}
{"actor":{"display_login":"dmartinezg"}}