{"action":"created","issue":{"url":"https://api.github.com/repos/pivotal/cedar/issues/395","repository_url":"https://api.github.com/repos/pivotal/cedar","labels_url":"https://api.github.com/repos/pivotal/cedar/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/pivotal/cedar/issues/395/comments","events_url":"https://api.github.com/repos/pivotal/cedar/issues/395/events","html_url":"https://github.com/pivotal/cedar/pull/395","id":167300569,"number":395,"title":"Raise errors when dsl is misused","user":{"login":"tjarratt","id":249262,"avatar_url":"https://avatars.githubusercontent.com/u/249262?v=3","gravatar_id":"","url":"https://api.github.com/users/tjarratt","html_url":"https://github.com/tjarratt","followers_url":"https://api.github.com/users/tjarratt/followers","following_url":"https://api.github.com/users/tjarratt/following{/other_user}","gists_url":"https://api.github.com/users/tjarratt/gists{/gist_id}","starred_url":"https://api.github.com/users/tjarratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjarratt/subscriptions","organizations_url":"https://api.github.com/users/tjarratt/orgs","repos_url":"https://api.github.com/users/tjarratt/repos","events_url":"https://api.github.com/users/tjarratt/events{/privacy}","received_events_url":"https://api.github.com/users/tjarratt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-25T07:32:09Z","updated_at":"2016-07-25T15:24:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pivotal/cedar/pulls/395","html_url":"https://github.com/pivotal/cedar/pull/395","diff_url":"https://github.com/pivotal/cedar/pull/395.diff","patch_url":"https://github.com/pivotal/cedar/pull/395.patch"},"body":"Fixes #394.\r\n\r\nThe first commit is the brunt of this feature work. DSL misuse encompasses two main failure modes:\r\n\r\n* someone calls `it()`, `describe()`, or `context()` inside of an `it()` block\r\n  * this would never work because the newly-added tests are never run\r\n* someone tries to call any of the above functions outside of a test\r\n  * this would never work because there is no spec yet to add them to until we build the tree\r\n\r\nIn writing this feature I tried to avoid adding much more scope to Cedar's public interface, but found it necessary to expose `CDRdisableSpecValidation()` and `CDRenableSpecValidation()` functions so that we could keep our existing tests that create cedar examples by calling `it()` inside of a test. I also thought it desirable to allow someone to disable this feature, if they were using Cedar in some interesting way.\r\n\r\nThen, once I was totally done with this feature, writing a happy commit message and running all of the test suite ... I discovered a completely unrelated regression in the Type Utilities part of Cedar. The commit message for that is pretty verbose -- I recommend reading it if you want to know when a valid pointer sometimes can be misconstrued to be a NULL pointer. It was quite a find."},"comment":{"url":"https://api.github.com/repos/pivotal/cedar/issues/comments/234986842","html_url":"https://github.com/pivotal/cedar/pull/395#issuecomment-234986842","issue_url":"https://api.github.com/repos/pivotal/cedar/issues/395","id":234986842,"user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T15:24:48Z","updated_at":"2016-07-25T15:24:48Z","body":"Cool! Quick added something similar in https://github.com/Quick/Quick/pull/448, and I think that reduced the number of issues being reported on the project."}}
{"actor":{"display_login":"modocache"}}