{"action":"created","issue":{"url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/103","repository_url":"https://api.github.com/repos/imanuelcostigan/RSQLServer","labels_url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/103/comments","events_url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/103/events","html_url":"https://github.com/imanuelcostigan/RSQLServer/pull/103","id":176205702,"number":103,"title":"added sqlData and sqlAppendTable","user":{"login":"r2evans","id":5815808,"avatar_url":"https://avatars.githubusercontent.com/u/5815808?v=3","gravatar_id":"","url":"https://api.github.com/users/r2evans","html_url":"https://github.com/r2evans","followers_url":"https://api.github.com/users/r2evans/followers","following_url":"https://api.github.com/users/r2evans/following{/other_user}","gists_url":"https://api.github.com/users/r2evans/gists{/gist_id}","starred_url":"https://api.github.com/users/r2evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r2evans/subscriptions","organizations_url":"https://api.github.com/users/r2evans/orgs","repos_url":"https://api.github.com/users/r2evans/repos","events_url":"https://api.github.com/users/r2evans/events{/privacy}","received_events_url":"https://api.github.com/users/r2evans/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-10T21:58:15Z","updated_at":"2016-09-16T06:57:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/pulls/103","html_url":"https://github.com/imanuelcostigan/RSQLServer/pull/103","diff_url":"https://github.com/imanuelcostigan/RSQLServer/pull/103.diff","patch_url":"https://github.com/imanuelcostigan/RSQLServer/pull/103.patch"},"body":"(No issue fixes.)\r\n\r\n\r\nChanges proposed:\r\n\r\n- methodized `sqlData` and `sqlAppendTable`\r\n- added tests (with \"SQL_PROD\" server available?)\r\n\r\n\r\n@imanuelcostigan\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/comments/247531537","html_url":"https://github.com/imanuelcostigan/RSQLServer/pull/103#issuecomment-247531537","issue_url":"https://api.github.com/repos/imanuelcostigan/RSQLServer/issues/103","id":247531537,"user":{"login":"r2evans","id":5815808,"avatar_url":"https://avatars.githubusercontent.com/u/5815808?v=3","gravatar_id":"","url":"https://api.github.com/users/r2evans","html_url":"https://github.com/r2evans","followers_url":"https://api.github.com/users/r2evans/followers","following_url":"https://api.github.com/users/r2evans/following{/other_user}","gists_url":"https://api.github.com/users/r2evans/gists{/gist_id}","starred_url":"https://api.github.com/users/r2evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r2evans/subscriptions","organizations_url":"https://api.github.com/users/r2evans/orgs","repos_url":"https://api.github.com/users/r2evans/repos","events_url":"https://api.github.com/users/r2evans/events{/privacy}","received_events_url":"https://api.github.com/users/r2evans/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T06:57:48Z","updated_at":"2016-09-16T06:57:48Z","body":"I've updated quoted strings. I know there are much better ways to deal with the prepared statements, but your code currently assumes `params` are of length one instead; I have seen examples in jTDS (such as [this one](https://www.mkyong.com/jdbc/jdbc-preparedstatement-example-batch-update/)) showing multi-row binding with a single execute), I just haven't sat down and played with the internals of rJava enough to know how to do it right.\r\n\r\nIf multi-row prepared statements are easily done, I agree that they would be better than this approach. In the meantime, I offer this as a slight improvement in performance at the expense of brute-forcing the db-quoting."}}
{"actor":{"display_login":"r2evans"}}