{"action":"created","comment":{"url":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments/57398577","id":57398577,"diff_hunk":"@@ -102,12 +106,17 @@ init([SupChild, Id]) ->\n     Ops     = ops_tuple(),\n     ShutdownOnError = basho_bench_config:get(shutdown_on_error, false),\n \n+    %% Check configuration for flag enabling new API that passes opaque State object to support accessor functions\n+    ApiPassState = basho_bench_config:get(api_pass_state),","path":"src/basho_bench_worker.erl","position":21,"original_position":21,"commit_id":"17a890a5c90289f0fbd398e4695deb2250640e8f","original_commit_id":"17a890a5c90289f0fbd398e4695deb2250640e8f","user":{"login":"chewbranca","id":5326,"avatar_url":"https://avatars.githubusercontent.com/u/5326?v=3","gravatar_id":"","url":"https://api.github.com/users/chewbranca","html_url":"https://github.com/chewbranca","followers_url":"https://api.github.com/users/chewbranca/followers","following_url":"https://api.github.com/users/chewbranca/following{/other_user}","gists_url":"https://api.github.com/users/chewbranca/gists{/gist_id}","starred_url":"https://api.github.com/users/chewbranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chewbranca/subscriptions","organizations_url":"https://api.github.com/users/chewbranca/orgs","repos_url":"https://api.github.com/users/chewbranca/repos","events_url":"https://api.github.com/users/chewbranca/events{/privacy}","received_events_url":"https://api.github.com/users/chewbranca/received_events","type":"User","site_admin":false},"body":"If this is going to be an optional new flag you'll likely want to add a default `false` value here so that it doesn't crash if `api_pass_state` is not defined in the config.","created_at":"2016-03-24T22:34:40Z","updated_at":"2016-03-24T22:34:40Z","html_url":"https://github.com/cloudant/basho_bench/pull/12#discussion_r57398577","pull_request_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments/57398577"},"html":{"href":"https://github.com/cloudant/basho_bench/pull/12#discussion_r57398577"},"pull_request":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/cloudant/basho_bench/pulls/12","id":63954125,"html_url":"https://github.com/cloudant/basho_bench/pull/12","diff_url":"https://github.com/cloudant/basho_bench/pull/12.diff","patch_url":"https://github.com/cloudant/basho_bench/pull/12.patch","issue_url":"https://api.github.com/repos/cloudant/basho_bench/issues/12","number":12,"state":"open","locked":false,"title":"63177 named generators pass state","user":{"login":"djschlegel2","id":12716993,"avatar_url":"https://avatars.githubusercontent.com/u/12716993?v=3","gravatar_id":"","url":"https://api.github.com/users/djschlegel2","html_url":"https://github.com/djschlegel2","followers_url":"https://api.github.com/users/djschlegel2/followers","following_url":"https://api.github.com/users/djschlegel2/following{/other_user}","gists_url":"https://api.github.com/users/djschlegel2/gists{/gist_id}","starred_url":"https://api.github.com/users/djschlegel2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djschlegel2/subscriptions","organizations_url":"https://api.github.com/users/djschlegel2/orgs","repos_url":"https://api.github.com/users/djschlegel2/repos","events_url":"https://api.github.com/users/djschlegel2/events{/privacy}","received_events_url":"https://api.github.com/users/djschlegel2/received_events","type":"User","site_admin":false},"body":"Proposed code for handling passed-state and named generators. \r\nNot combining key and value generators at this point, can discuss separately. \r\n","created_at":"2016-03-23T21:14:45Z","updated_at":"2016-03-24T22:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4615fd4da89cca28a06c034ed00394e1eb2c9be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/12/commits","review_comments_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/12/comments","review_comment_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/issues/12/comments","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/17a890a5c90289f0fbd398e4695deb2250640e8f","head":{"label":"cloudant:63177-named-generators-pass-state","ref":"63177-named-generators-pass-state","sha":"17a890a5c90289f0fbd398e4695deb2250640e8f","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":48444796,"name":"basho_bench","full_name":"cloudant/basho_bench","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/basho_bench","description":"A load-generation and testing tool for basically whatever you can write a returning Erlang function for.","fork":true,"url":"https://api.github.com/repos/cloudant/basho_bench","forks_url":"https://api.github.com/repos/cloudant/basho_bench/forks","keys_url":"https://api.github.com/repos/cloudant/basho_bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/basho_bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/basho_bench/teams","hooks_url":"https://api.github.com/repos/cloudant/basho_bench/hooks","issue_events_url":"https://api.github.com/repos/cloudant/basho_bench/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/basho_bench/events","assignees_url":"https://api.github.com/repos/cloudant/basho_bench/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/basho_bench/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/basho_bench/tags","blobs_url":"https://api.github.com/repos/cloudant/basho_bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/basho_bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/basho_bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/basho_bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/basho_bench/languages","stargazers_url":"https://api.github.com/repos/cloudant/basho_bench/stargazers","contributors_url":"https://api.github.com/repos/cloudant/basho_bench/contributors","subscribers_url":"https://api.github.com/repos/cloudant/basho_bench/subscribers","subscription_url":"https://api.github.com/repos/cloudant/basho_bench/subscription","commits_url":"https://api.github.com/repos/cloudant/basho_bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/basho_bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/basho_bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/basho_bench/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/basho_bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/basho_bench/merges","archive_url":"https://api.github.com/repos/cloudant/basho_bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/basho_bench/downloads","issues_url":"https://api.github.com/repos/cloudant/basho_bench/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/basho_bench/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/basho_bench/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/basho_bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/basho_bench/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/basho_bench/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/basho_bench/deployments","created_at":"2015-12-22T17:21:08Z","updated_at":"2015-12-22T17:21:10Z","pushed_at":"2016-03-23T21:14:47Z","git_url":"git://github.com/cloudant/basho_bench.git","ssh_url":"git@github.com:cloudant/basho_bench.git","clone_url":"https://github.com/cloudant/basho_bench.git","svn_url":"https://github.com/cloudant/basho_bench","homepage":"","size":2326,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudant:cloudant","ref":"cloudant","sha":"03b6db1c4f3a4630abd5bfb729b2ab20088858ed","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":48444796,"name":"basho_bench","full_name":"cloudant/basho_bench","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/basho_bench","description":"A load-generation and testing tool for basically whatever you can write a returning Erlang function for.","fork":true,"url":"https://api.github.com/repos/cloudant/basho_bench","forks_url":"https://api.github.com/repos/cloudant/basho_bench/forks","keys_url":"https://api.github.com/repos/cloudant/basho_bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/basho_bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/basho_bench/teams","hooks_url":"https://api.github.com/repos/cloudant/basho_bench/hooks","issue_events_url":"https://api.github.com/repos/cloudant/basho_bench/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/basho_bench/events","assignees_url":"https://api.github.com/repos/cloudant/basho_bench/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/basho_bench/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/basho_bench/tags","blobs_url":"https://api.github.com/repos/cloudant/basho_bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/basho_bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/basho_bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/basho_bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/basho_bench/languages","stargazers_url":"https://api.github.com/repos/cloudant/basho_bench/stargazers","contributors_url":"https://api.github.com/repos/cloudant/basho_bench/contributors","subscribers_url":"https://api.github.com/repos/cloudant/basho_bench/subscribers","subscription_url":"https://api.github.com/repos/cloudant/basho_bench/subscription","commits_url":"https://api.github.com/repos/cloudant/basho_bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/basho_bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/basho_bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/basho_bench/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/basho_bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/basho_bench/merges","archive_url":"https://api.github.com/repos/cloudant/basho_bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/basho_bench/downloads","issues_url":"https://api.github.com/repos/cloudant/basho_bench/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/basho_bench/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/basho_bench/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/basho_bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/basho_bench/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/basho_bench/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/basho_bench/deployments","created_at":"2015-12-22T17:21:08Z","updated_at":"2015-12-22T17:21:10Z","pushed_at":"2016-03-23T21:14:47Z","git_url":"git://github.com/cloudant/basho_bench.git","ssh_url":"git@github.com:cloudant/basho_bench.git","clone_url":"https://github.com/cloudant/basho_bench.git","svn_url":"https://github.com/cloudant/basho_bench","homepage":"","size":2326,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/12"},"html":{"href":"https://github.com/cloudant/basho_bench/pull/12"},"issue":{"href":"https://api.github.com/repos/cloudant/basho_bench/issues/12"},"comments":{"href":"https://api.github.com/repos/cloudant/basho_bench/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/cloudant/basho_bench/statuses/17a890a5c90289f0fbd398e4695deb2250640e8f"}}}}