{"action":"closed","number":126,"pull_request":{"url":"https://api.github.com/repos/alfredh/baresip/pulls/126","id":68504044,"html_url":"https://github.com/alfredh/baresip/pull/126","diff_url":"https://github.com/alfredh/baresip/pull/126.diff","patch_url":"https://github.com/alfredh/baresip/pull/126.patch","issue_url":"https://api.github.com/repos/alfredh/baresip/issues/126","number":126,"state":"closed","locked":false,"title":"aucodec: split srate into srate and crate (Clock Rate)","user":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"body":"All, @choene please review and test this patch.\r\n\r\nThe patch splits the \"srate\" parameter of struct aucodec into 2 parts; srate and crate.\r\nThe srate is the Audio sample-rate for the DSP, the crate is the RTP Clock rate.\r\n\r\nMost audio codecs will use exactly the same value here. The exception is e.g G.722 and MPA.\r\nFor example G.722 has 8000 Hz and 16000 Hz:\r\n\r\nhttps://tools.ietf.org/html/rfc3551#section-4.5.2\r\n\r\n```\r\n   Even though the actual sampling rate for G.722 audio is 16,000 Hz,\r\n   the RTP clock rate for the G722 payload format is 8,000 Hz because\r\n   that value was erroneously assigned in RFC 1890 and must remain\r\n   unchanged for backward compatibility.  The octet rate or sample-pair\r\n   rate is 8,000 Hz.\r\n```\r\n\r\nthe goal is to make audio.c agnostic to these codec details.\r\n","created_at":"2016-05-01T19:06:28Z","updated_at":"2016-05-07T14:19:17Z","closed_at":"2016-05-07T14:19:17Z","merged_at":"2016-05-07T14:19:17Z","merge_commit_sha":"0c7c2bfb50465641a4bfec39b6848ab58a7e2692","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alfredh/baresip/pulls/126/commits","review_comments_url":"https://api.github.com/repos/alfredh/baresip/pulls/126/comments","review_comment_url":"https://api.github.com/repos/alfredh/baresip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alfredh/baresip/issues/126/comments","statuses_url":"https://api.github.com/repos/alfredh/baresip/statuses/b839fce160d88ed93846af45fe34f655fe80c682","head":{"label":"alfredh:aucodec_split_srate","ref":"aucodec_split_srate","sha":"b839fce160d88ed93846af45fe34f655fe80c682","user":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"repo":{"id":16664594,"name":"baresip","full_name":"alfredh/baresip","owner":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfredh/baresip","description":"Baresip is a modular SIP User-Agent with audio and video support","fork":false,"url":"https://api.github.com/repos/alfredh/baresip","forks_url":"https://api.github.com/repos/alfredh/baresip/forks","keys_url":"https://api.github.com/repos/alfredh/baresip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfredh/baresip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfredh/baresip/teams","hooks_url":"https://api.github.com/repos/alfredh/baresip/hooks","issue_events_url":"https://api.github.com/repos/alfredh/baresip/issues/events{/number}","events_url":"https://api.github.com/repos/alfredh/baresip/events","assignees_url":"https://api.github.com/repos/alfredh/baresip/assignees{/user}","branches_url":"https://api.github.com/repos/alfredh/baresip/branches{/branch}","tags_url":"https://api.github.com/repos/alfredh/baresip/tags","blobs_url":"https://api.github.com/repos/alfredh/baresip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfredh/baresip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfredh/baresip/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfredh/baresip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfredh/baresip/statuses/{sha}","languages_url":"https://api.github.com/repos/alfredh/baresip/languages","stargazers_url":"https://api.github.com/repos/alfredh/baresip/stargazers","contributors_url":"https://api.github.com/repos/alfredh/baresip/contributors","subscribers_url":"https://api.github.com/repos/alfredh/baresip/subscribers","subscription_url":"https://api.github.com/repos/alfredh/baresip/subscription","commits_url":"https://api.github.com/repos/alfredh/baresip/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfredh/baresip/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfredh/baresip/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfredh/baresip/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfredh/baresip/contents/{+path}","compare_url":"https://api.github.com/repos/alfredh/baresip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfredh/baresip/merges","archive_url":"https://api.github.com/repos/alfredh/baresip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfredh/baresip/downloads","issues_url":"https://api.github.com/repos/alfredh/baresip/issues{/number}","pulls_url":"https://api.github.com/repos/alfredh/baresip/pulls{/number}","milestones_url":"https://api.github.com/repos/alfredh/baresip/milestones{/number}","notifications_url":"https://api.github.com/repos/alfredh/baresip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfredh/baresip/labels{/name}","releases_url":"https://api.github.com/repos/alfredh/baresip/releases{/id}","deployments_url":"https://api.github.com/repos/alfredh/baresip/deployments","created_at":"2014-02-09T10:44:09Z","updated_at":"2016-04-28T08:05:47Z","pushed_at":"2016-05-07T14:19:17Z","git_url":"git://github.com/alfredh/baresip.git","ssh_url":"git@github.com:alfredh/baresip.git","clone_url":"https://github.com/alfredh/baresip.git","svn_url":"https://github.com/alfredh/baresip","homepage":null,"size":1528,"stargazers_count":106,"watchers_count":106,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":8,"forks":48,"open_issues":8,"watchers":106,"default_branch":"master"}},"base":{"label":"alfredh:master","ref":"master","sha":"5148e7def697fc91d2ff7ec812d07b665f65397d","user":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"repo":{"id":16664594,"name":"baresip","full_name":"alfredh/baresip","owner":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfredh/baresip","description":"Baresip is a modular SIP User-Agent with audio and video support","fork":false,"url":"https://api.github.com/repos/alfredh/baresip","forks_url":"https://api.github.com/repos/alfredh/baresip/forks","keys_url":"https://api.github.com/repos/alfredh/baresip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfredh/baresip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfredh/baresip/teams","hooks_url":"https://api.github.com/repos/alfredh/baresip/hooks","issue_events_url":"https://api.github.com/repos/alfredh/baresip/issues/events{/number}","events_url":"https://api.github.com/repos/alfredh/baresip/events","assignees_url":"https://api.github.com/repos/alfredh/baresip/assignees{/user}","branches_url":"https://api.github.com/repos/alfredh/baresip/branches{/branch}","tags_url":"https://api.github.com/repos/alfredh/baresip/tags","blobs_url":"https://api.github.com/repos/alfredh/baresip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfredh/baresip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfredh/baresip/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfredh/baresip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfredh/baresip/statuses/{sha}","languages_url":"https://api.github.com/repos/alfredh/baresip/languages","stargazers_url":"https://api.github.com/repos/alfredh/baresip/stargazers","contributors_url":"https://api.github.com/repos/alfredh/baresip/contributors","subscribers_url":"https://api.github.com/repos/alfredh/baresip/subscribers","subscription_url":"https://api.github.com/repos/alfredh/baresip/subscription","commits_url":"https://api.github.com/repos/alfredh/baresip/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfredh/baresip/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfredh/baresip/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfredh/baresip/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfredh/baresip/contents/{+path}","compare_url":"https://api.github.com/repos/alfredh/baresip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfredh/baresip/merges","archive_url":"https://api.github.com/repos/alfredh/baresip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfredh/baresip/downloads","issues_url":"https://api.github.com/repos/alfredh/baresip/issues{/number}","pulls_url":"https://api.github.com/repos/alfredh/baresip/pulls{/number}","milestones_url":"https://api.github.com/repos/alfredh/baresip/milestones{/number}","notifications_url":"https://api.github.com/repos/alfredh/baresip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfredh/baresip/labels{/name}","releases_url":"https://api.github.com/repos/alfredh/baresip/releases{/id}","deployments_url":"https://api.github.com/repos/alfredh/baresip/deployments","created_at":"2014-02-09T10:44:09Z","updated_at":"2016-04-28T08:05:47Z","pushed_at":"2016-05-07T14:19:17Z","git_url":"git://github.com/alfredh/baresip.git","ssh_url":"git@github.com:alfredh/baresip.git","clone_url":"https://github.com/alfredh/baresip.git","svn_url":"https://github.com/alfredh/baresip","homepage":null,"size":1528,"stargazers_count":106,"watchers_count":106,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":8,"forks":48,"open_issues":8,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alfredh/baresip/pulls/126"},"html":{"href":"https://github.com/alfredh/baresip/pull/126"},"issue":{"href":"https://api.github.com/repos/alfredh/baresip/issues/126"},"comments":{"href":"https://api.github.com/repos/alfredh/baresip/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/alfredh/baresip/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/alfredh/baresip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alfredh/baresip/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/alfredh/baresip/statuses/b839fce160d88ed93846af45fe34f655fe80c682"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alfredh","id":114750,"avatar_url":"https://avatars.githubusercontent.com/u/114750?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredh","html_url":"https://github.com/alfredh","followers_url":"https://api.github.com/users/alfredh/followers","following_url":"https://api.github.com/users/alfredh/following{/other_user}","gists_url":"https://api.github.com/users/alfredh/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredh/subscriptions","organizations_url":"https://api.github.com/users/alfredh/orgs","repos_url":"https://api.github.com/users/alfredh/repos","events_url":"https://api.github.com/users/alfredh/events{/privacy}","received_events_url":"https://api.github.com/users/alfredh/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":52,"deletions":47,"changed_files":18}}