{"action":"created","comment":{"url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/comments/87823363","pull_request_review_id":8409269,"id":87823363,"diff_hunk":"@@ -0,0 +1,56 @@\n+#ifndef KALDI_GUARD_VOICEQUALITY_H_\n+#define KALDI_GUARD_VOICEQUALITY_H_\n+\n+#include \"base/kaldi-common.h\"\n+#include \"util/common-utils.h\"\n+#include \"feat/pitch-functions.h\"\n+#include <cmath>\n+#include <vector>\n+#include <algorithm>\n+#include <numeric>\n+\n+namespace kaldi\n+{\n+\tclass VoiceQualityFeaturesExtractor\n+\t{\n+\n+\tpublic:\n+        VoiceQualityFeaturesExtractor();\n+        virtual ~VoiceQualityFeaturesExtractor();\n+\n+        void povLocalCalculator(int frameNo, Matrix<BaseFloat> &pitchFeatures);\n+        void logHNRLocalCalculator(int frameNo, Matrix<BaseFloat> &pitchFeatures);\n+\n+        void jitterShimmerCalculator(int frameNo, const Vector<BaseFloat> &Waveform,\n+                    Matrix<BaseFloat> &pitchFeatures, PitchExtractionOptions &pitchOpts);\n+\n+        void computeFeatures(Matrix<BaseFloat> &pitchFeatures,\n+                             const Vector<BaseFloat> &Waveform);\n+\n+        //call computeFeatures() with pitchFeatures from ComputeKaldiPitch and the wave-data","path":"src/feat/feature-voice-quality-extractor.h","position":30,"original_position":30,"commit_id":"8ed5df9c621c92a6f37e1682b3c0c87c7511f3ea","original_commit_id":"ce7c4b11efa3fd6351c203e80b3320a417c4df50","user":{"login":"khers","id":11153535,"avatar_url":"https://avatars.githubusercontent.com/u/11153535?v=3","gravatar_id":"","url":"https://api.github.com/users/khers","html_url":"https://github.com/khers","followers_url":"https://api.github.com/users/khers/followers","following_url":"https://api.github.com/users/khers/following{/other_user}","gists_url":"https://api.github.com/users/khers/gists{/gist_id}","starred_url":"https://api.github.com/users/khers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khers/subscriptions","organizations_url":"https://api.github.com/users/khers/orgs","repos_url":"https://api.github.com/users/khers/repos","events_url":"https://api.github.com/users/khers/events{/privacy}","received_events_url":"https://api.github.com/users/khers/received_events","type":"User","site_admin":false},"body":"why are member variables public?","created_at":"2016-11-14T15:32:19Z","updated_at":"2016-11-14T15:32:19Z","html_url":"https://github.com/cobaltspeech/stable-kaldi/pull/35#discussion_r87823363","pull_request_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/comments/87823363"},"html":{"href":"https://github.com/cobaltspeech/stable-kaldi/pull/35#discussion_r87823363"},"pull_request":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35","id":93361460,"html_url":"https://github.com/cobaltspeech/stable-kaldi/pull/35","diff_url":"https://github.com/cobaltspeech/stable-kaldi/pull/35.diff","patch_url":"https://github.com/cobaltspeech/stable-kaldi/pull/35.patch","issue_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/35","number":35,"state":"open","locked":false,"title":"Voice quality feature integration","user":{"login":"fahim-zubayer","id":16551621,"avatar_url":"https://avatars.githubusercontent.com/u/16551621?v=3","gravatar_id":"","url":"https://api.github.com/users/fahim-zubayer","html_url":"https://github.com/fahim-zubayer","followers_url":"https://api.github.com/users/fahim-zubayer/followers","following_url":"https://api.github.com/users/fahim-zubayer/following{/other_user}","gists_url":"https://api.github.com/users/fahim-zubayer/gists{/gist_id}","starred_url":"https://api.github.com/users/fahim-zubayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahim-zubayer/subscriptions","organizations_url":"https://api.github.com/users/fahim-zubayer/orgs","repos_url":"https://api.github.com/users/fahim-zubayer/repos","events_url":"https://api.github.com/users/fahim-zubayer/events{/privacy}","received_events_url":"https://api.github.com/users/fahim-zubayer/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-11T16:43:56Z","updated_at":"2016-11-14T15:37:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58dac733c929fc74ff33d6074f99d5343746b22f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35/commits","review_comments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35/comments","review_comment_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/35/comments","statuses_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/statuses/8ed5df9c621c92a6f37e1682b3c0c87c7511f3ea","head":{"label":"cobaltspeech:voice_quality_feature_integration","ref":"voice_quality_feature_integration","sha":"8ed5df9c621c92a6f37e1682b3c0c87c7511f3ea","user":{"login":"cobaltspeech","id":15947802,"avatar_url":"https://avatars.githubusercontent.com/u/15947802?v=3","gravatar_id":"","url":"https://api.github.com/users/cobaltspeech","html_url":"https://github.com/cobaltspeech","followers_url":"https://api.github.com/users/cobaltspeech/followers","following_url":"https://api.github.com/users/cobaltspeech/following{/other_user}","gists_url":"https://api.github.com/users/cobaltspeech/gists{/gist_id}","starred_url":"https://api.github.com/users/cobaltspeech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobaltspeech/subscriptions","organizations_url":"https://api.github.com/users/cobaltspeech/orgs","repos_url":"https://api.github.com/users/cobaltspeech/repos","events_url":"https://api.github.com/users/cobaltspeech/events{/privacy}","received_events_url":"https://api.github.com/users/cobaltspeech/received_events","type":"Organization","site_admin":false},"repo":{"id":49249473,"name":"stable-kaldi","full_name":"cobaltspeech/stable-kaldi","owner":{"login":"cobaltspeech","id":15947802,"avatar_url":"https://avatars.githubusercontent.com/u/15947802?v=3","gravatar_id":"","url":"https://api.github.com/users/cobaltspeech","html_url":"https://github.com/cobaltspeech","followers_url":"https://api.github.com/users/cobaltspeech/followers","following_url":"https://api.github.com/users/cobaltspeech/following{/other_user}","gists_url":"https://api.github.com/users/cobaltspeech/gists{/gist_id}","starred_url":"https://api.github.com/users/cobaltspeech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobaltspeech/subscriptions","organizations_url":"https://api.github.com/users/cobaltspeech/orgs","repos_url":"https://api.github.com/users/cobaltspeech/repos","events_url":"https://api.github.com/users/cobaltspeech/events{/privacy}","received_events_url":"https://api.github.com/users/cobaltspeech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cobaltspeech/stable-kaldi","description":"A fixed version of kaldi with some minor patches. The version is fixed to guarantee performance, we'll try to periodically rebase on kaldi master.","fork":false,"url":"https://api.github.com/repos/cobaltspeech/stable-kaldi","forks_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/forks","keys_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/teams","hooks_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/hooks","issue_events_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/events","assignees_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/tags","blobs_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/languages","stargazers_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/stargazers","contributors_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/contributors","subscribers_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/subscribers","subscription_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/subscription","commits_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/merges","archive_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/downloads","issues_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/labels{/name}","releases_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/deployments","created_at":"2016-01-08T04:28:51Z","updated_at":"2016-10-27T17:50:41Z","pushed_at":"2016-11-11T16:43:56Z","git_url":"git://github.com/cobaltspeech/stable-kaldi.git","ssh_url":"git@github.com:cobaltspeech/stable-kaldi.git","clone_url":"https://github.com/cobaltspeech/stable-kaldi.git","svn_url":"https://github.com/cobaltspeech/stable-kaldi","homepage":null,"size":105977,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"cobaltspeech:master","ref":"master","sha":"62a2b12b1a5b0081100754bb3108d3bbdba2f072","user":{"login":"cobaltspeech","id":15947802,"avatar_url":"https://avatars.githubusercontent.com/u/15947802?v=3","gravatar_id":"","url":"https://api.github.com/users/cobaltspeech","html_url":"https://github.com/cobaltspeech","followers_url":"https://api.github.com/users/cobaltspeech/followers","following_url":"https://api.github.com/users/cobaltspeech/following{/other_user}","gists_url":"https://api.github.com/users/cobaltspeech/gists{/gist_id}","starred_url":"https://api.github.com/users/cobaltspeech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobaltspeech/subscriptions","organizations_url":"https://api.github.com/users/cobaltspeech/orgs","repos_url":"https://api.github.com/users/cobaltspeech/repos","events_url":"https://api.github.com/users/cobaltspeech/events{/privacy}","received_events_url":"https://api.github.com/users/cobaltspeech/received_events","type":"Organization","site_admin":false},"repo":{"id":49249473,"name":"stable-kaldi","full_name":"cobaltspeech/stable-kaldi","owner":{"login":"cobaltspeech","id":15947802,"avatar_url":"https://avatars.githubusercontent.com/u/15947802?v=3","gravatar_id":"","url":"https://api.github.com/users/cobaltspeech","html_url":"https://github.com/cobaltspeech","followers_url":"https://api.github.com/users/cobaltspeech/followers","following_url":"https://api.github.com/users/cobaltspeech/following{/other_user}","gists_url":"https://api.github.com/users/cobaltspeech/gists{/gist_id}","starred_url":"https://api.github.com/users/cobaltspeech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobaltspeech/subscriptions","organizations_url":"https://api.github.com/users/cobaltspeech/orgs","repos_url":"https://api.github.com/users/cobaltspeech/repos","events_url":"https://api.github.com/users/cobaltspeech/events{/privacy}","received_events_url":"https://api.github.com/users/cobaltspeech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cobaltspeech/stable-kaldi","description":"A fixed version of kaldi with some minor patches. The version is fixed to guarantee performance, we'll try to periodically rebase on kaldi master.","fork":false,"url":"https://api.github.com/repos/cobaltspeech/stable-kaldi","forks_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/forks","keys_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/teams","hooks_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/hooks","issue_events_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/events","assignees_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/tags","blobs_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/languages","stargazers_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/stargazers","contributors_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/contributors","subscribers_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/subscribers","subscription_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/subscription","commits_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/merges","archive_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/downloads","issues_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/labels{/name}","releases_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/cobaltspeech/stable-kaldi/deployments","created_at":"2016-01-08T04:28:51Z","updated_at":"2016-10-27T17:50:41Z","pushed_at":"2016-11-11T16:43:56Z","git_url":"git://github.com/cobaltspeech/stable-kaldi.git","ssh_url":"git@github.com:cobaltspeech/stable-kaldi.git","clone_url":"https://github.com/cobaltspeech/stable-kaldi.git","svn_url":"https://github.com/cobaltspeech/stable-kaldi","homepage":null,"size":105977,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35"},"html":{"href":"https://github.com/cobaltspeech/stable-kaldi/pull/35"},"issue":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/35"},"comments":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/cobaltspeech/stable-kaldi/statuses/8ed5df9c621c92a6f37e1682b3c0c87c7511f3ea"}}}}
{"actor":{"display_login":"khers"}}