{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/275","repository_url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin","labels_url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/275/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/275/comments","events_url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/275/events","html_url":"https://github.com/jenkinsci/gerrit-trigger-plugin/pull/275","id":137587115,"number":275,"title":"Diagnostics pages","user":{"login":"rsandell","id":300688,"avatar_url":"https://avatars.githubusercontent.com/u/300688?v=3","gravatar_id":"","url":"https://api.github.com/users/rsandell","html_url":"https://github.com/rsandell","followers_url":"https://api.github.com/users/rsandell/followers","following_url":"https://api.github.com/users/rsandell/following{/other_user}","gists_url":"https://api.github.com/users/rsandell/gists{/gist_id}","starred_url":"https://api.github.com/users/rsandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsandell/subscriptions","organizations_url":"https://api.github.com/users/rsandell/orgs","repos_url":"https://api.github.com/users/rsandell/repos","events_url":"https://api.github.com/users/rsandell/events{/privacy}","received_events_url":"https://api.github.com/users/rsandell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-03-01T14:26:46Z","updated_at":"2016-03-10T02:31:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/pulls/275","html_url":"https://github.com/jenkinsci/gerrit-trigger-plugin/pull/275","diff_url":"https://github.com/jenkinsci/gerrit-trigger-plugin/pull/275.diff","patch_url":"https://github.com/jenkinsci/gerrit-trigger-plugin/pull/275.patch"},"body":"Some management pages to get some diagnostics views into the internals of the trigger. Usable to troubleshoot why some strange behaviours are happening that I used to have system groovy scripts for."},"comment":{"url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/comments/194627503","html_url":"https://github.com/jenkinsci/gerrit-trigger-plugin/pull/275#issuecomment-194627503","issue_url":"https://api.github.com/repos/jenkinsci/gerrit-trigger-plugin/issues/275","id":194627503,"user":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars.githubusercontent.com/u/5400948?v=3","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T02:31:29Z","updated_at":"2016-03-10T02:31:29Z","body":"Overall:\r\n\r\n* Good:\r\n  - the approach makes sense here, for dumping running state to use in debugging.\r\n  - General implementation appears correct, from what I can tell, but concerned I might be missing something due to overall size here.\r\n* Bad:\r\n  - It feels like we may be dumping a lot of information that may not be pertinent.  I'd ask if we can reduce the amount of log produced here, to generate a better signal-to-noise ratio for analysis. Also, it might be helpful to offer separate options to dump for BuildMemory and EventListeners (with the former off by default, and the latter on).\r\n  - I would consider if it might be better to annotate the appropriate classes for serialization to a dump, rather than writing custom logging here?\r\n* BuildMemoryReport object has a lot of *deeply* nested types and collections.  Could we simplify this in some way to be easier to follow? \r\n* CheckMes: the null handling here feels iffy, I'm not 100% sure what intent is in some cases for proper behavior. \r\n\r\nUnfortunately I'm not familiar enough with the groovy views here to follow those components well enough for proper review yet. "}}