{"action":"created","comment":{"url":"https://api.github.com/repos/apache/falcon/pulls/comments/53728830","id":53728830,"diff_hunk":"@@ -280,20 +271,15 @@ public void addImportedInstance(WorkflowExecutionContext context) throws FalconE\n                 feedInstanceDataPath, sourceClusterName, datasourceName);\n         String feedInstanceName = getFeedInstanceName(feedName, sourceClusterName,\n                 feedInstanceDataPath, context.getNominalTimeAsISO8601());\n-        Vertex feedInstanceVertex = findVertex(feedInstanceName, RelationshipType.FEED_INSTANCE);\n-\n-        LOG.info(\"Vertex exists? name={}, type={}, v={}\",\n-                feedInstanceName, RelationshipType.FEED_INSTANCE, feedInstanceVertex);\n-        if (feedInstanceVertex == null) { // No record of instances NOT generated by Falcon\n-            LOG.info(\"{} instance vertex {} does not exist, add it\",\n-                    RelationshipType.FEED_INSTANCE, feedInstanceName);\n-            feedInstanceVertex = addFeedInstance(// add a new instance\n-                    feedInstanceName, context, feedName, context.getSrcClusterName());\n-        }\n+        Vertex feedInstanceVertex = addFeedInstance(\n+                feedInstanceName, context, feedName, context.getSrcClusterName());\n+\n+        Map<RelationshipProperty, String> properties = new HashMap<RelationshipProperty, String>();\n+        properties.put(RelationshipProperty.TIMESTAMP, context.getTimeStampAsISO8601());","path":"common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java","position":null,"original_position":109,"commit_id":"ff9556bd7869b1f67cd912b4bbeff6bf5d5853c3","original_commit_id":"b76f64237c2de1d7be25a03253f692143fbd0d96","user":{"login":"yzheng-hortonworks","id":10202347,"avatar_url":"https://avatars.githubusercontent.com/u/10202347?v=3","gravatar_id":"","url":"https://api.github.com/users/yzheng-hortonworks","html_url":"https://github.com/yzheng-hortonworks","followers_url":"https://api.github.com/users/yzheng-hortonworks/followers","following_url":"https://api.github.com/users/yzheng-hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/yzheng-hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/yzheng-hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzheng-hortonworks/subscriptions","organizations_url":"https://api.github.com/users/yzheng-hortonworks/orgs","repos_url":"https://api.github.com/users/yzheng-hortonworks/repos","events_url":"https://api.github.com/users/yzheng-hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/yzheng-hortonworks/received_events","type":"User","site_admin":false},"body":"The existing property is for message time, which is inherited from original code. I've added nominal time and status to edge properties for search of imported instance. Also added edge properties to search replicated and evicted instances as you commented below. Thanks for pointing this out, Venky.","created_at":"2016-02-23T02:29:05Z","updated_at":"2016-02-23T02:29:05Z","html_url":"https://github.com/apache/falcon/pull/47#discussion_r53728830","pull_request_url":"https://api.github.com/repos/apache/falcon/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments/53728830"},"html":{"href":"https://github.com/apache/falcon/pull/47#discussion_r53728830"},"pull_request":{"href":"https://api.github.com/repos/apache/falcon/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/apache/falcon/pulls/47","id":59875959,"html_url":"https://github.com/apache/falcon/pull/47","diff_url":"https://github.com/apache/falcon/pull/47.diff","patch_url":"https://github.com/apache/falcon/pull/47.patch","issue_url":"https://api.github.com/repos/apache/falcon/issues/47","number":47,"state":"open","locked":false,"title":"FALCON-1111 Instance update on titan DB based on JMS notifications on workflow jobs","user":{"login":"yzheng-hortonworks","id":10202347,"avatar_url":"https://avatars.githubusercontent.com/u/10202347?v=3","gravatar_id":"","url":"https://api.github.com/users/yzheng-hortonworks","html_url":"https://github.com/yzheng-hortonworks","followers_url":"https://api.github.com/users/yzheng-hortonworks/followers","following_url":"https://api.github.com/users/yzheng-hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/yzheng-hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/yzheng-hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzheng-hortonworks/subscriptions","organizations_url":"https://api.github.com/users/yzheng-hortonworks/orgs","repos_url":"https://api.github.com/users/yzheng-hortonworks/repos","events_url":"https://api.github.com/users/yzheng-hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/yzheng-hortonworks/received_events","type":"User","site_admin":false},"body":"Add running, succeeded, failed, killed and suspended instances to titan DB based on JMS notifications on workflow jobs. Instance-entity edge properties (e.g. nominal time, status) are also added for vertex-centric indexing.","created_at":"2016-02-18T22:42:47Z","updated_at":"2016-02-23T02:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"171d7c57997a239111d633b1e067efe773dd2d0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/falcon/pulls/47/commits","review_comments_url":"https://api.github.com/repos/apache/falcon/pulls/47/comments","review_comment_url":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/falcon/issues/47/comments","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/ff9556bd7869b1f67cd912b4bbeff6bf5d5853c3","head":{"label":"yzheng-hortonworks:FALCON-1111","ref":"FALCON-1111","sha":"ff9556bd7869b1f67cd912b4bbeff6bf5d5853c3","user":{"login":"yzheng-hortonworks","id":10202347,"avatar_url":"https://avatars.githubusercontent.com/u/10202347?v=3","gravatar_id":"","url":"https://api.github.com/users/yzheng-hortonworks","html_url":"https://github.com/yzheng-hortonworks","followers_url":"https://api.github.com/users/yzheng-hortonworks/followers","following_url":"https://api.github.com/users/yzheng-hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/yzheng-hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/yzheng-hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzheng-hortonworks/subscriptions","organizations_url":"https://api.github.com/users/yzheng-hortonworks/orgs","repos_url":"https://api.github.com/users/yzheng-hortonworks/repos","events_url":"https://api.github.com/users/yzheng-hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/yzheng-hortonworks/received_events","type":"User","site_admin":false},"repo":{"id":51108322,"name":"falcon","full_name":"yzheng-hortonworks/falcon","owner":{"login":"yzheng-hortonworks","id":10202347,"avatar_url":"https://avatars.githubusercontent.com/u/10202347?v=3","gravatar_id":"","url":"https://api.github.com/users/yzheng-hortonworks","html_url":"https://github.com/yzheng-hortonworks","followers_url":"https://api.github.com/users/yzheng-hortonworks/followers","following_url":"https://api.github.com/users/yzheng-hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/yzheng-hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/yzheng-hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzheng-hortonworks/subscriptions","organizations_url":"https://api.github.com/users/yzheng-hortonworks/orgs","repos_url":"https://api.github.com/users/yzheng-hortonworks/repos","events_url":"https://api.github.com/users/yzheng-hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/yzheng-hortonworks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yzheng-hortonworks/falcon","description":"Mirror of Apache Falcon","fork":true,"url":"https://api.github.com/repos/yzheng-hortonworks/falcon","forks_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/forks","keys_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/teams","hooks_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/hooks","issue_events_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/events","assignees_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/tags","blobs_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/languages","stargazers_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/stargazers","contributors_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/contributors","subscribers_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/subscribers","subscription_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/subscription","commits_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/merges","archive_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/downloads","issues_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/labels{/name}","releases_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/yzheng-hortonworks/falcon/deployments","created_at":"2016-02-04T21:51:32Z","updated_at":"2016-02-04T21:51:37Z","pushed_at":"2016-02-23T02:26:38Z","git_url":"git://github.com/yzheng-hortonworks/falcon.git","ssh_url":"git@github.com:yzheng-hortonworks/falcon.git","clone_url":"https://github.com/yzheng-hortonworks/falcon.git","svn_url":"https://github.com/yzheng-hortonworks/falcon","homepage":null,"size":28611,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9979a1fd815495a04f3ce2a0ce673f95c655e20d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11543457,"name":"falcon","full_name":"apache/falcon","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/falcon","description":"Mirror of Apache Falcon","fork":false,"url":"https://api.github.com/repos/apache/falcon","forks_url":"https://api.github.com/repos/apache/falcon/forks","keys_url":"https://api.github.com/repos/apache/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/falcon/teams","hooks_url":"https://api.github.com/repos/apache/falcon/hooks","issue_events_url":"https://api.github.com/repos/apache/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/apache/falcon/events","assignees_url":"https://api.github.com/repos/apache/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/apache/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/apache/falcon/tags","blobs_url":"https://api.github.com/repos/apache/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/falcon/languages","stargazers_url":"https://api.github.com/repos/apache/falcon/stargazers","contributors_url":"https://api.github.com/repos/apache/falcon/contributors","subscribers_url":"https://api.github.com/repos/apache/falcon/subscribers","subscription_url":"https://api.github.com/repos/apache/falcon/subscription","commits_url":"https://api.github.com/repos/apache/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/apache/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/falcon/merges","archive_url":"https://api.github.com/repos/apache/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/falcon/downloads","issues_url":"https://api.github.com/repos/apache/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/apache/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/falcon/labels{/name}","releases_url":"https://api.github.com/repos/apache/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/apache/falcon/deployments","created_at":"2013-07-20T07:00:14Z","updated_at":"2016-02-04T08:06:23Z","pushed_at":"2016-02-23T02:26:39Z","git_url":"git://github.com/apache/falcon.git","ssh_url":"git@github.com:apache/falcon.git","clone_url":"https://github.com/apache/falcon.git","svn_url":"https://github.com/apache/falcon","homepage":null,"size":29175,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":"git://git.apache.org/falcon.git","open_issues_count":15,"forks":74,"open_issues":15,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/47"},"html":{"href":"https://github.com/apache/falcon/pull/47"},"issue":{"href":"https://api.github.com/repos/apache/falcon/issues/47"},"comments":{"href":"https://api.github.com/repos/apache/falcon/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/falcon/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/falcon/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/apache/falcon/statuses/ff9556bd7869b1f67cd912b4bbeff6bf5d5853c3"}}}}