{"action":"created","issue":{"url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/89","labels_url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/89/comments","events_url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/89/events","html_url":"https://github.com/P-H-C/phc-winner-argon2/pull/89","id":128460466,"number":89,"title":"Introduces an automated test suite.","user":{"login":"technion","id":1948596,"avatar_url":"https://avatars.githubusercontent.com/u/1948596?v=3","gravatar_id":"","url":"https://api.github.com/users/technion","html_url":"https://github.com/technion","followers_url":"https://api.github.com/users/technion/followers","following_url":"https://api.github.com/users/technion/following{/other_user}","gists_url":"https://api.github.com/users/technion/gists{/gist_id}","starred_url":"https://api.github.com/users/technion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technion/subscriptions","organizations_url":"https://api.github.com/users/technion/orgs","repos_url":"https://api.github.com/users/technion/repos","events_url":"https://api.github.com/users/technion/events{/privacy}","received_events_url":"https://api.github.com/users/technion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-25T04:49:45Z","updated_at":"2016-01-25T12:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/pulls/89","html_url":"https://github.com/P-H-C/phc-winner-argon2/pull/89","diff_url":"https://github.com/P-H-C/phc-winner-argon2/pull/89.diff","patch_url":"https://github.com/P-H-C/phc-winner-argon2/pull/89.patch"},"body":"With respect to working on #85, I'd like to suggest introducing a test suite.\r\n\r\nThe existing kats/test.sh is great at testing block internals during a hash, but leaves large parts of functionality open. I also note that the majority of recent commits and bugfixes have related to the encoding, decoding, and error management.\r\n\r\nThis test suite covers all those elements, and should integrate well with a chosen CI system. If this PR is accepted I would be happy to assist further in resolving #85 by introducing a Travis configuration.\r\n\r\nThis PR also sets CFLAGS on test compilations to utilise additional compiler warnings, and ASAN, which provides further verification against several classes of bugs.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/comments/174488519","html_url":"https://github.com/P-H-C/phc-winner-argon2/pull/89#issuecomment-174488519","issue_url":"https://api.github.com/repos/P-H-C/phc-winner-argon2/issues/89","id":174488519,"user":{"login":"technion","id":1948596,"avatar_url":"https://avatars.githubusercontent.com/u/1948596?v=3","gravatar_id":"","url":"https://api.github.com/users/technion","html_url":"https://github.com/technion","followers_url":"https://api.github.com/users/technion/followers","following_url":"https://api.github.com/users/technion/following{/other_user}","gists_url":"https://api.github.com/users/technion/gists{/gist_id}","starred_url":"https://api.github.com/users/technion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technion/subscriptions","organizations_url":"https://api.github.com/users/technion/orgs","repos_url":"https://api.github.com/users/technion/repos","events_url":"https://api.github.com/users/technion/events{/privacy}","received_events_url":"https://api.github.com/users/technion/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T12:18:37Z","updated_at":"2016-01-25T12:18:37Z","body":"I have no problem with this - except to say this library basically has two functions that need testing. It's not really in the same position as, for example, my Ruby bindings, which have a much more in-depth test suite."}}