{"push_id":1367507435,"size":26,"distinct_size":26,"ref":"refs/heads/master","head":"e8eaaa772414e6193702f3933cbee919d6fcdc95","before":"d3b1a2b4ddab18eade677213d8692f2e4d14e946","commits":[{"sha":"35e8896153b9667b0583812679b3fd72a7470315","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: speed up module loading, skip EOF read\n\nStop reading from disk when we read fewer bytes than requested because\nthe next read will be the zero-sized EOF.\n\nPR-URL: https://github.com/nodejs/node/pull/9132\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/35e8896153b9667b0583812679b3fd72a7470315"},{"sha":"d52f5dc8646eb81f155d683d3b2eee1aec52c8e6","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: speed up module loading, don't resize buffer\n\nDon't bother shrinking the read buffer on the final read because we\ndispose it immediately afterwards.  Avoids some unnecessary memory\nallocation and copying.\n\nPR-URL: https://github.com/nodejs/node/pull/9132\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/d52f5dc8646eb81f155d683d3b2eee1aec52c8e6"},{"sha":"d77e818a54a72dc6eef752c215471913573a4874","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: simplify code, remove NodeInstanceData\n\nNodeInstanceData is not used meaningfully and makes the initialization\nlogic harder to follow.  Let's remove it and delete 100 lines of code\nin one fell swoop.\n\nPR-URL: https://github.com/nodejs/node/pull/9224\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/d77e818a54a72dc6eef752c215471913573a4874"},{"sha":"ceb602326066674b894c9fc4d53166d06a918c02","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: clean up program/isolate/env init logic\n\nReorder the initialization logic so that program-wide, per-isolate and\nper-environment initialization is more cleanly separated.\n\nPR-URL: https://github.com/nodejs/node/pull/9224\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/ceb602326066674b894c9fc4d53166d06a918c02"},{"sha":"1b8fca16bca4053351f693244da2246ab9a6fb82","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"test: move flaky test to test/pummel\n\nMove sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel\nbecause it fails for me locally quite frequently and because it takes\nabout five or six seconds to complete, which is too long for a test in\ntest/sequential.\n\nFixes: https://github.com/nodejs/node/issues/8744\nPR-URL: https://github.com/nodejs/node/pull/9241\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/1b8fca16bca4053351f693244da2246ab9a6fb82"},{"sha":"d1f7c965bb7eb541e345bf4079a5a168ee4f206a","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"test: make flaky pummel test more reliable\n\nIncrease the number of iterations from 1e4 to 1e5.  Makes the test pass\nfor me locally when previously it would fail 9 out of 10 times because\nthe running time was not enough to smooth away the outliers.\n\nFixes: https://github.com/nodejs/node/issues/8744\nPR-URL: https://github.com/nodejs/node/pull/9241\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/d1f7c965bb7eb541e345bf4079a5a168ee4f206a"},{"sha":"8fca311857f0aefbba3782cef6a9812aa784d33f","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"test: add more module loader test coverage\n\nVerify that a package.json without a .main property loads index.js.\n\nPR-URL: https://github.com/nodejs/node/pull/9196\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/8fca311857f0aefbba3782cef6a9812aa784d33f"},{"sha":"df29d9f5004a6d88603a9435782f4d7fcbcb3153","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"doc: add performance warning to require.extensions\n\nDiscourage using require.extensions because it slows down the module\nloader.  The number of file system operations that the module system\nhas to perform in order to resolve a `require(...)` statement to a\nfilename is proportional to the number of registered extensions.\n\nPR-URL: https://github.com/nodejs/node/pull/9196\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/df29d9f5004a6d88603a9435782f4d7fcbcb3153"},{"sha":"678c094357c8656a26bb3f7348fac02e3ecc2a88","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"module: skip directories known not to exist\n\nThere is no point in trying to search for files in a directory that\nwe know does not exist, so stop doing that.\n\nReduces the total number of stat(2) calls and the number of stat(2)\nmisses on a medium-sized application by about 21% and 29% respectively.\n\nReduces the total number of package.json open(2) calls and the number\nof open(2) misses by about 21% and 93% (!) respectively.\n\nBefore:\n\n    % time     seconds  usecs/call     calls    errors syscall\n    ------ ----------- ----------- --------- --------- ----------------\n     50.93    0.178419          38      4702           lstat\n     29.08    0.101875          36      2800      2010 stat\n     11.36    0.039796          43       932       215 open\n      5.39    0.018897          34       550           fstat\n      3.24    0.011337          34       336           pread\n    ------ ----------- ----------- --------- --------- ----------------\n    100.00    0.350324                  9320      2225 total\n\nAfter:\n\n    % time     seconds  usecs/call     calls    errors syscall\n    ------ ----------- ----------- --------- --------- ----------------\n     55.49    0.176638          38      4702           lstat\n     24.76    0.078826          35      2225      1435 stat\n     10.19    0.032434          44       733        16 open\n      6.19    0.019719          36       550           fstat\n      3.37    0.010723          32       336           pread\n    ------ ----------- ----------- --------- --------- ----------------\n    100.00    0.318340                  8546      1451 total\n\nPR-URL: https://github.com/nodejs/node/pull/9196\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/678c094357c8656a26bb3f7348fac02e3ecc2a88"},{"sha":"3d9b379cd03b966a22a9bcbbbc49caa8e7acc248","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"inspector: fix request path nullptr dereference\n\nFix a nullptr dereference when an invalid path is requested.\n\nRegression introduced in commit 69fc85d (\"inspector: generate UUID for\ndebug targets\"), caught by Coverity.\n\nPR-URL: https://github.com/nodejs/node/pull/9184\nReviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Eugene Ostroukhov <eostroukhov@google.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/3d9b379cd03b966a22a9bcbbbc49caa8e7acc248"},{"sha":"8e54c968e692fb55e2ddf0899172785c7b7b5812","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"test: remove test-v8-inspector-json-protocol test\n\nRemove parallel/test-v8-inspector-json-protocol, it duplicates the test\nfound in inspector/test-inspector.\n\nPR-URL: https://github.com/nodejs/node/pull/9184\nReviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Eugene Ostroukhov <eostroukhov@google.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/8e54c968e692fb55e2ddf0899172785c7b7b5812"},{"sha":"c5b07d4ec6de2cb362b887499e44655eaeb26cba","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"lib: fix beforeExit not working with -e\n\nCommit 93a44d5 (\"src: fix deferred events not working with -e\") defers\nevaluation of the script to the next tick.\n\nA side effect of that change is that 'beforeExit' listeners run before\nthe actual script.  'beforeExit' is emitted when the event loop is\nempty but process.nextTick() does not ref the event loop.\n\nFix that by using setImmediate().  Because it is implemented in terms\nof a uv_check_t handle, it interacts with the event loop properly.\n\nFixes: https://github.com/nodejs/node/issues/8534\nPR-URL: https://github.com/nodejs/node/pull/8821\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/c5b07d4ec6de2cb362b887499e44655eaeb26cba"},{"sha":"a5080000933108ff6d16bfb8705f18a8879fa138","author":{"name":"cjihrig","email":"b0a62289a2635542c30e3402b36d8cbeb000fe3e@gmail.com"},"message":"test: add coverage for execFileSync() errors\n\nThis commit adds coverage for errors returned by execFileSync()\nwhen the child process exits with a non-zero code.\n\nPR-URL: https://github.com/nodejs/node/pull/9211\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/a5080000933108ff6d16bfb8705f18a8879fa138"},{"sha":"dd13d71eb3ee34d84ca9059d40616bd0b44ca0ed","author":{"name":"cjihrig","email":"b0a62289a2635542c30e3402b36d8cbeb000fe3e@gmail.com"},"message":"child_process: remove unreachable execSync() code\n\nCode coverage showed that the execSync() variable inheritStderr\nwas never set to the default value of true. This is because\nthe default case is hit whenever normalizeExecArgs() returns an\nobject without an 'options' property. However, this can never\nbe the case because normalizeExecArgs() unconditionally creates\nthe options object. This commit removes the unreachable code.\n\nPR-URL: https://github.com/nodejs/node/pull/9209\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/dd13d71eb3ee34d84ca9059d40616bd0b44ca0ed"},{"sha":"0a8d0eaa9be35bfa899135118f1917dbd57dbda1","author":{"name":"Oliver Salzburg","email":"9ce8deaf4e868acbbdc0ea6247ba53f382ce3a35@gmail.com"},"message":"doc: mention case-insensitive env on windows\n\nOn Windows OS, environment variables are case-insensitive and are\ntreated likewise in NodeJS. This can be confusing and can lead\nto hard-to-debug problems when moving code from one environment\nto another.\n\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nPR-URL: https://github.com/nodejs/node/pull/9166\nFixes: https://github.com/nodejs/node/issues/9157","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/0a8d0eaa9be35bfa899135118f1917dbd57dbda1"},{"sha":"2a456162b67e914eec77849623dcdb87011a482f","author":{"name":"Oliver Salzburg","email":"9ce8deaf4e868acbbdc0ea6247ba53f382ce3a35@gmail.com"},"message":"test: case sensitivity of env variables\n\nEnvironment variables should be treated case-insensitive on Windows\nplatforms and case-sensitive on UNIX platforms.\n\nThis commit ensures this behavior persists.\n\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nPR-URL: https://github.com/nodejs/node/pull/9166\nFixes: https://github.com/nodejs/node/issues/9157","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/2a456162b67e914eec77849623dcdb87011a482f"},{"sha":"e4290dec2df252cbaaf79098784730924153b182","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src,tools: speed up startup by 2.5%\n\nUse zero-copy external string resources for storing the built-in JS\nsource code.  Saves a few hundred kilobyte of memory and consistently\nspeeds up `benchmark/misc/startup.js` by 2.5%.\n\nEverything old is new again!  Commit 74954ce (\"Add string class that\nuses ExternalAsciiStringResource.\") from 2011 did the same thing but\nI removed that in 2013 in commit 34b0a36 (\"src: don't use NewExternal()\nwith unaligned strings\") because of a limitation in the V8 API.\n\nV8 no longer requires that strings are aligned if they are one-byte\nstrings so it should be safe to re-enable external strings again.\n\nPR-URL: https://github.com/nodejs/node/pull/5458\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/e4290dec2df252cbaaf79098784730924153b182"},{"sha":"921d2b080e810dff89c78db7d7f4c2e9e92f57ec","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: make cross-context MakeCallback() calls work\n\nCheck that invoking a callback on a receiver from a different context\nworks.\n\nIt ran afoul of an `env->context() == isolate->GetCurrentContext()`\nassertion so retrieve the environment from the callback context and\nthe context to enter from the environment's context() method.\n\nWe could also have retrieved the environment from the receiver's context\nand that would have made little practical difference.  It just seemed\nmore correct to get it from the callback context because that is the\nactual execution context.\n\nPR-URL: https://github.com/nodejs/node/pull/9221\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/921d2b080e810dff89c78db7d7f4c2e9e92f57ec"},{"sha":"63c47e7189f8c157b6ceedabc3c292f7e6585abf","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"src: remove superfluous env_string string\n\nIt's only used once at startup in a single place so create the string\nin place instead of caching it for the lifetime of the isolate.\n\nPR-URL: https://github.com/nodejs/node/pull/9213\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/63c47e7189f8c157b6ceedabc3c292f7e6585abf"},{"sha":"2a654e47282c8b2847422f2d4c444180f214ab5c","author":{"name":"Evan Lucas","email":"268eff19096fcf534496275f846170f9618f73a6@me.com"},"message":"test: fix flaky test by removing timer\n\nThis fixes one of the tests that has been failing on CI on freebsd for\na bit by removing an unnecessary timer.\n\nPR-URL: https://github.com/nodejs/node/pull/9199\nFixes: https://github.com/nodejs/node/issues/7929\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/imyller/node/commits/2a654e47282c8b2847422f2d4c444180f214ab5c"}]}
{"actor":{"display_login":"imyller"}}