{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/151","repository_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness","labels_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/151/comments","events_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/151/events","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/151","id":163825138,"number":151,"title":"[JENKINS-34614] Fix for ftpd container connectivity problems","user":{"login":"mafraba","id":2007281,"avatar_url":"https://avatars.githubusercontent.com/u/2007281?v=3","gravatar_id":"","url":"https://api.github.com/users/mafraba","html_url":"https://github.com/mafraba","followers_url":"https://api.github.com/users/mafraba/followers","following_url":"https://api.github.com/users/mafraba/following{/other_user}","gists_url":"https://api.github.com/users/mafraba/gists{/gist_id}","starred_url":"https://api.github.com/users/mafraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafraba/subscriptions","organizations_url":"https://api.github.com/users/mafraba/orgs","repos_url":"https://api.github.com/users/mafraba/repos","events_url":"https://api.github.com/users/mafraba/events{/privacy}","received_events_url":"https://api.github.com/users/mafraba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-05T11:03:23Z","updated_at":"2016-07-05T14:44:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/151","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/151","diff_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/151.diff","patch_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/151.patch"},"body":"Fix for [JENKINS-34614](https://issues.jenkins-ci.org/browse/JENKINS-34614).\r\n\r\nSeveral factors were preventing the connection to the ftp server:\r\n\r\n1. Due to how FTP protocol works ([details here](http://www.slacksite.com/other/ftp.html)) we need an exact match of container and host ports. If anyone knows another solution please comment.\r\n2. We needed to force the 'passive' ip/host in the ftp server.\r\n\r\nMy proposed solution to address (1) is to add a new boolean property `matchHostPorts` in the `DockerFixture` annotation, which when true will force an exact port mapping between docker container and host.\r\n\r\nAlso modified the `FtpdContainer`'s `Dockerfile` to fix the ubuntu version, and to address (2).\r\n\r\n@reviewbybees esp @abayer, @olivergondza "},"comment":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/comments/230499041","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/151#issuecomment-230499041","issue_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/151","id":230499041,"user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T14:44:15Z","updated_at":"2016-07-05T14:44:15Z","body":"I have no idea if the tests ever worked. =) "}}
{"actor":{"display_login":"abayer"}}