{"action":"closed","number":405,"pull_request":{"url":"https://api.github.com/repos/18F/cg-deck/pulls/405","id":75892638,"html_url":"https://github.com/18F/cg-deck/pull/405","diff_url":"https://github.com/18F/cg-deck/pull/405.diff","patch_url":"https://github.com/18F/cg-deck/pull/405.patch","issue_url":"https://api.github.com/repos/18F/cg-deck/issues/405","number":405,"state":"closed","locked":false,"title":"Create service bug","user":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?v=3","gravatar_id":"","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"body":"There was a bug where if you create a service instance and then go to the service instances page, it would fail because of missing data for `updated_at` and `created_at`. This is because in the CF API, when you create a service instance, it delivers back an incomplete representation of it.\r\n\r\nI solved this by just fetching the service instance from the server rather then trying to deal with the incomplete one. I did this because it's easier to reason about a complete object that has the same format rather then trying to deal with a differently formatted object, which would split the logic of the codebase.\r\n\r\nref #403","created_at":"2016-06-30T21:18:50Z","updated_at":"2016-07-01T22:42:48Z","closed_at":"2016-07-01T22:42:48Z","merged_at":null,"merge_commit_sha":"64dcffefc75a568c05f1e0e23f4c2136edf9ff97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/cg-deck/pulls/405/commits","review_comments_url":"https://api.github.com/repos/18F/cg-deck/pulls/405/comments","review_comment_url":"https://api.github.com/repos/18F/cg-deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/cg-deck/issues/405/comments","statuses_url":"https://api.github.com/repos/18F/cg-deck/statuses/bcb03369c1c6a352a730531d9ad00f3afbb02fd5","head":{"label":"18F:ms-create_service_bug","ref":"ms-create_service_bug","sha":"bcb03369c1c6a352a730531d9ad00f3afbb02fd5","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":39210774,"name":"cg-deck","full_name":"18F/cg-deck","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-deck","description":"A web console for managing Cloud Foundry Apps","fork":false,"url":"https://api.github.com/repos/18F/cg-deck","forks_url":"https://api.github.com/repos/18F/cg-deck/forks","keys_url":"https://api.github.com/repos/18F/cg-deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-deck/teams","hooks_url":"https://api.github.com/repos/18F/cg-deck/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-deck/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-deck/events","assignees_url":"https://api.github.com/repos/18F/cg-deck/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-deck/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-deck/tags","blobs_url":"https://api.github.com/repos/18F/cg-deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-deck/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-deck/languages","stargazers_url":"https://api.github.com/repos/18F/cg-deck/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-deck/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-deck/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-deck/subscription","commits_url":"https://api.github.com/repos/18F/cg-deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-deck/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-deck/merges","archive_url":"https://api.github.com/repos/18F/cg-deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-deck/downloads","issues_url":"https://api.github.com/repos/18F/cg-deck/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-deck/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-deck/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-deck/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-deck/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-deck/deployments","created_at":"2015-07-16T17:27:45Z","updated_at":"2016-06-15T17:26:19Z","pushed_at":"2016-07-01T22:42:48Z","git_url":"git://github.com/18F/cg-deck.git","ssh_url":"git@github.com:18F/cg-deck.git","clone_url":"https://github.com/18F/cg-deck.git","svn_url":"https://github.com/18F/cg-deck","homepage":"https://console.cloud.gov","size":3548,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":92,"forks":0,"open_issues":92,"watchers":3,"default_branch":"master"}},"base":{"label":"18F:staging-alpha","ref":"staging-alpha","sha":"cba601c6048aa1004ebb14e0ee85a3571f8079b1","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":39210774,"name":"cg-deck","full_name":"18F/cg-deck","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-deck","description":"A web console for managing Cloud Foundry Apps","fork":false,"url":"https://api.github.com/repos/18F/cg-deck","forks_url":"https://api.github.com/repos/18F/cg-deck/forks","keys_url":"https://api.github.com/repos/18F/cg-deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-deck/teams","hooks_url":"https://api.github.com/repos/18F/cg-deck/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-deck/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-deck/events","assignees_url":"https://api.github.com/repos/18F/cg-deck/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-deck/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-deck/tags","blobs_url":"https://api.github.com/repos/18F/cg-deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-deck/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-deck/languages","stargazers_url":"https://api.github.com/repos/18F/cg-deck/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-deck/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-deck/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-deck/subscription","commits_url":"https://api.github.com/repos/18F/cg-deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-deck/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-deck/merges","archive_url":"https://api.github.com/repos/18F/cg-deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-deck/downloads","issues_url":"https://api.github.com/repos/18F/cg-deck/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-deck/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-deck/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-deck/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-deck/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-deck/deployments","created_at":"2015-07-16T17:27:45Z","updated_at":"2016-06-15T17:26:19Z","pushed_at":"2016-07-01T22:42:48Z","git_url":"git://github.com/18F/cg-deck.git","ssh_url":"git@github.com:18F/cg-deck.git","clone_url":"https://github.com/18F/cg-deck.git","svn_url":"https://github.com/18F/cg-deck","homepage":"https://console.cloud.gov","size":3548,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":92,"forks":0,"open_issues":92,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/cg-deck/pulls/405"},"html":{"href":"https://github.com/18F/cg-deck/pull/405"},"issue":{"href":"https://api.github.com/repos/18F/cg-deck/issues/405"},"comments":{"href":"https://api.github.com/repos/18F/cg-deck/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/cg-deck/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/cg-deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/cg-deck/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/18F/cg-deck/statuses/bcb03369c1c6a352a730531d9ad00f3afbb02fd5"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":2,"commits":6,"additions":105,"deletions":31,"changed_files":7}}
{"actor":{"display_login":"msecret"}}