{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/comments/86118897","pull_request_review_id":6792356,"id":86118897,"diff_hunk":"@@ -0,0 +1,16 @@\n+describe(\"EncryptAttachment\", function() {\n+    var testVectors = [\"\", \"SGVsbG8sIFdvcmxk\"];\n+\n+    for (var i = 0; i < testVectors.length; i++) {\n+        (function () {\n+            var want = testVectors[i];\n+            it(\"roundtrips \" + JSON.stringify(want), function() {\n+                return encryptAttachment(decodeBase64(want)).then(function(encryptResult) {","path":"test/encrypt.Spec.js","position":8,"original_position":8,"commit_id":"e890b53781b9a7308b9f7ae7b12dfe92aba42632","original_commit_id":"e890b53781b9a7308b9f7ae7b12dfe92aba42632","user":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"body":"I don't know Mocha enough to know if returning a Promise is enough to make this an async test. Is it?","created_at":"2016-11-02T11:16:47Z","updated_at":"2016-11-02T11:16:47Z","html_url":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1#discussion_r86118897","pull_request_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/comments/86118897"},"html":{"href":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1#discussion_r86118897"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1","id":91831864,"html_url":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1","diff_url":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1.diff","patch_url":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1.patch","issue_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/1","number":1,"state":"open","locked":false,"title":"Implement attachment encryption/decryption","user":{"login":"NegativeMjark","id":904009,"avatar_url":"https://avatars.githubusercontent.com/u/904009?v=3","gravatar_id":"","url":"https://api.github.com/users/NegativeMjark","html_url":"https://github.com/NegativeMjark","followers_url":"https://api.github.com/users/NegativeMjark/followers","following_url":"https://api.github.com/users/NegativeMjark/following{/other_user}","gists_url":"https://api.github.com/users/NegativeMjark/gists{/gist_id}","starred_url":"https://api.github.com/users/NegativeMjark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NegativeMjark/subscriptions","organizations_url":"https://api.github.com/users/NegativeMjark/orgs","repos_url":"https://api.github.com/users/NegativeMjark/repos","events_url":"https://api.github.com/users/NegativeMjark/events{/privacy}","received_events_url":"https://api.github.com/users/NegativeMjark/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-01T17:57:22Z","updated_at":"2016-11-02T11:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af7a1535f257d98c09cf95df8f756824b49717cb","assignee":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"assignees":[{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1/commits","review_comments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1/comments","review_comment_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/1/comments","statuses_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/statuses/e890b53781b9a7308b9f7ae7b12dfe92aba42632","head":{"label":"matrix-org:markjh/encrypt","ref":"markjh/encrypt","sha":"e890b53781b9a7308b9f7ae7b12dfe92aba42632","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":72554088,"name":"browser-encrypt-attachment","full_name":"matrix-org/browser-encrypt-attachment","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/browser-encrypt-attachment","description":"Browser JavaScript library for encrypting files using webcrypto.","fork":false,"url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment","forks_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/forks","keys_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/teams","hooks_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/events","assignees_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/tags","blobs_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/languages","stargazers_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/subscription","commits_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/merges","archive_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/downloads","issues_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/deployments","created_at":"2016-11-01T16:20:06Z","updated_at":"2016-11-01T16:20:06Z","pushed_at":"2016-11-01T17:57:22Z","git_url":"git://github.com/matrix-org/browser-encrypt-attachment.git","ssh_url":"git@github.com:matrix-org/browser-encrypt-attachment.git","clone_url":"https://github.com/matrix-org/browser-encrypt-attachment.git","svn_url":"https://github.com/matrix-org/browser-encrypt-attachment","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:master","ref":"master","sha":"620300e67724cbe4871a3fe5129713a91a29c5f8","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":72554088,"name":"browser-encrypt-attachment","full_name":"matrix-org/browser-encrypt-attachment","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/browser-encrypt-attachment","description":"Browser JavaScript library for encrypting files using webcrypto.","fork":false,"url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment","forks_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/forks","keys_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/teams","hooks_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/events","assignees_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/tags","blobs_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/languages","stargazers_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/subscription","commits_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/merges","archive_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/downloads","issues_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/deployments","created_at":"2016-11-01T16:20:06Z","updated_at":"2016-11-01T16:20:06Z","pushed_at":"2016-11-01T17:57:22Z","git_url":"git://github.com/matrix-org/browser-encrypt-attachment.git","ssh_url":"git@github.com:matrix-org/browser-encrypt-attachment.git","clone_url":"https://github.com/matrix-org/browser-encrypt-attachment.git","svn_url":"https://github.com/matrix-org/browser-encrypt-attachment","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1"},"html":{"href":"https://github.com/matrix-org/browser-encrypt-attachment/pull/1"},"issue":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/1"},"comments":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/browser-encrypt-attachment/statuses/e890b53781b9a7308b9f7ae7b12dfe92aba42632"}}}}
{"actor":{"display_login":"Kegsay"}}