{"action":"created","issue":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/1212","repository_url":"https://api.github.com/repos/xonsh/xonsh","labels_url":"https://api.github.com/repos/xonsh/xonsh/issues/1212/labels{/name}","comments_url":"https://api.github.com/repos/xonsh/xonsh/issues/1212/comments","events_url":"https://api.github.com/repos/xonsh/xonsh/issues/1212/events","html_url":"https://github.com/xonsh/xonsh/pull/1212","id":159804666,"number":1212,"title":"Remove Bash from Default Foreign Shells","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xonsh/xonsh/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xonsh/xonsh/milestones/4","html_url":"https://github.com/xonsh/xonsh/milestones/v0.4.0","labels_url":"https://api.github.com/repos/xonsh/xonsh/milestones/4/labels","id":1779851,"number":4,"title":"v0.4.0","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":120,"state":"open","created_at":"2016-05-20T22:54:44Z","updated_at":"2016-06-12T03:00:45Z","due_on":"2016-06-30T04:00:00Z","closed_at":null},"comments":2,"created_at":"2016-06-12T03:00:45Z","updated_at":"2016-06-12T03:58:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xonsh/xonsh/pulls/1212","html_url":"https://github.com/xonsh/xonsh/pull/1212","diff_url":"https://github.com/xonsh/xonsh/pull/1212.diff","patch_url":"https://github.com/xonsh/xonsh/pull/1212.patch"},"body":"This removes Bash from the default foreign shells in an attempt to reduce the startup time.  This adds some platform specific code for the default `$PATH`, and so it probably requires some testing on environments other than my own. @melund @gforsyth @Carreau @OllieTerrance, @ellocogato, @jivanyatra - your feedback and help would be super appreciated.\r\n\r\nHere are some timing comparisons on my desktop:\r\n\r\n```\r\n# interactive login shell, master\r\nscopatz@artemis ~ $ time -p xonsh --shell-type=readline -l -i -c \"print(42)\"\r\n42\r\nreal 0.35\r\nuser 0.33\r\nsys 0.01\r\n\r\n# interactive login shell, this branch\r\nscopatz@artemis ~ $ time -p xonsh --shell-type=readline -l -i -c \"print(42)\"\r\n42\r\nreal 0.28\r\nuser 0.27\r\nsys 0.00\r\n\r\n-------------\r\n\r\n# headless shell, master\r\nscopatz@artemis ~ $ time -p xonsh --shell-type=readline -c \"print(42)\"\r\n42\r\nreal 0.28\r\nuser 0.27\r\nsys 0.00\r\n\r\n# headless shell, this branch\r\nscopatz@artemis ~ $ time -p xonsh --shell-type=readline -c \"print(42)\"\r\n42\r\nreal 0.28\r\nuser 0.26\r\nsys 0.01\r\n```\r\n\r\nSo as expected it doesn't really effect running scripts, but it knocks about 20% off of the startup time of the command line REPL, getting us ever closer to my goal of 0.1 sec :)"},"comment":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/comments/225408741","html_url":"https://github.com/xonsh/xonsh/pull/1212#issuecomment-225408741","issue_url":"https://api.github.com/repos/xonsh/xonsh/issues/1212","id":225408741,"user":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T03:58:07Z","updated_at":"2016-06-12T03:58:07Z","body":"Looks good to me on the two GNU/Linux machines I've tested.  I can try on Windows and Cygwin as well.\r\n\r\nI saw similar things: about .1 seconds difference on login/interactive shells, and no difference on headless.\r\n\r\nDo we still want to keep the bash completer loaded and enabled by default?  That might get us some more speed...but, of course, we lose the niceties associated with the bash completer.  And then again, loading the cached bash completion functions isn't too slow."}}
{"actor":{"display_login":"adqm"}}