{"push_id":1405474555,"size":9,"distinct_size":5,"ref":"refs/heads/0.0.11-Z-FeatureDeactivation","head":"71cf0d7056f2ef112f56cdada1ccdcb6a90733b4","before":"42579d5fab54802ee3c7783b76140845c470920c","commits":[{"sha":"cacd1b292c10a059041e49b112337568386a0f10","author":{"name":"zathras-crypto","email":"9e5e7e54715d46ac88fa32dc603839e21257ed67@gmail.com"},"message":"Fix RPC output for trade matches.\n\nNotes:\nThe following shows a sell for 2000 Indiv for 1.0 Div.\n\n  The original offer\n     \"matches\" : [\n         {\n             \"txid\" : \"da18e6d80b8340d8f872ff14ff002ab645552760d12060e7e50d62d6a20539ee\",\n             \"block\" : 126,\n             \"address\" : \"mpwugZU3hfVkQzBumVNAkqB3cJKkpNxotJ\",\n             \"amountsold\" : \"1999\",\n             \"amountreceived\" : \"1.00000000\",\n             \"tradingfee\" : \"0.00000001\"\n         }\n     ],\n     \"block\" : 125,\n\n  The new offer (the liquidity taker):\n     \"matches\" : [\n         {\n             \"txid\" : \"4812b0389017b479d3fa8a0674d5b7403d07cd6a0d11d4133eb281816a91d7a8\",\n             \"block\" : 126,\n             \"address\" : \"mpwugZU3hfVkQzBumVNAkqB3cJKkpNxotJ\",\n             \"amountsold\" : \"1.00000000\",\n             \"amountreceived\" : \"1999\"\n         }\n     ],\n     \"block\" : 126,\n\nThis has the following bugs:\n   * Trading fee incorrectly appears in original offer matches when they did not pay any fee\n   * Trading fee does not appear in liquidity taking offer matches when they did pay a fee\n   * Trading fee shows incorrect divisibility\n   * Amount sold attribute in the original offers matches array shows 1999 sold, when in fact 2000 were sold\n\nThis commit squashes these issues with an update to getMatchingTrades.  Afterwards the same test gives results:\n\n  The original offer:\n     \"matches\" : [\n         {\n             \"txid\" : \"612baeb13daf43fa3e9c5e46b736f7b07d1d395c3b2a578befa4060d037c2594\",\n             \"block\" : 126,\n             \"address\" : \"mta18HMfntLhXHWezu4Nuc4Wzsxw2aDxKv\",\n             \"amountsold\" : \"2000\",\n             \"amountreceived\" : \"1.00000000\",\n             \"tradingfee\" : \"0.00000000\"\n         }\n     ],\n     \"block\" : 125,\n\nThe new offer (the liquidity taker):\n     \"matches\" : [\n         {\n             \"txid\" : \"0214cf43bed73cb6432f9ecc103421ed33ec1c49d2005e01d180b38811f6a87f\",\n             \"block\" : 126,\n             \"address\" : \"mta18HMfntLhXHWezu4Nuc4Wzsxw2aDxKv\",\n             \"amountsold\" : \"1.00000000\",\n             \"amountreceived\" : \"1999\",\n             \"tradingfee\" : \"1\"\n         }\n     ],\n     \"block\" : 126,","distinct":false,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/cacd1b292c10a059041e49b112337568386a0f10"},{"sha":"b856b29a27b92ddd2494e82cea3260cfdd53d8bf","author":{"name":"zathras-crypto","email":"9e5e7e54715d46ac88fa32dc603839e21257ed67@gmail.com"},"message":"This commit fixes the evaluation of whether a trade should incur a fee.\n\nUpdates to the test script (will follow later) now check that OMNI pair trades are free.  Prior to this change the results were:\n\nTesting a trade against self where the first token is OMNI\n   * Executing the trade\n   * Verifiying the results\n      # Checking no fee was taken...\n        * Checking the original trade matches to confirm trading fee was 0...PASS\n        * Checking the new trade matches to confirm trading fee was 0...FAIL (result:1)\n        * Checking the fee cache is empty for property 1...PASS\n        * Checking the fee cache is empty for property 3...FAIL (result:1)\n        * Checking the trading address didn't lose any #1 tokens after trade...PASS\n        * Checking the trading address didn't lose any #3 tokens after trade...FAIL (result:9999999)\n\nAfter this change, the same test provides the following results:\n\nTesting a trade against self where the first token is OMNI\n   * Executing the trade\n   * Verifiying the results\n      # Checking no fee was taken...\n        * Checking the original trade matches to confirm trading fee was 0...PASS\n        * Checking the new trade matches to confirm trading fee was 0...PASS\n        * Checking the fee cache is empty for property 1...PASS\n        * Checking the fee cache is empty for property 3...PASS\n        * Checking the trading address didn't lose any #1 tokens after trade...PASS\n        * Checking the trading address didn't lose any #3 tokens after trade...PASS","distinct":false,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/b856b29a27b92ddd2494e82cea3260cfdd53d8bf"},{"sha":"013d23f3152b91077d1cc2e8eeb53920d1d63af2","author":{"name":"zathras-crypto","email":"9e5e7e54715d46ac88fa32dc603839e21257ed67@gmail.com"},"message":"Update the fee test script.\n\nNote:\nPrevious script tested for fees by trading Omni tokens which should have been free.  This updated script checks that Omni based trades are indeed free, activates all pair trading and updates the property handling for the fee tests.","distinct":false,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/013d23f3152b91077d1cc2e8eeb53920d1d63af2"},{"sha":"1228f7d01aa4f954396723fb70bdd38cf9dc9de6","author":{"name":"zathras-crypto","email":"9e5e7e54715d46ac88fa32dc603839e21257ed67@gmail.com"},"message":"Remove devOmni bypass\n\nNote: bypass used to run test script only, not appropriate for mainnet","distinct":false,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/1228f7d01aa4f954396723fb70bdd38cf9dc9de6"},{"sha":"8af9eae62699e3d25b6572c3e4f4ee3185779674","author":{"name":"dexX7","email":"6e89032c4b54b9b65b2742eb145839de8b17b4f9@bitwatch.co"},"message":"Merge pull request #426\n\n1228f7d Remove devOmni bypass (zathras-crypto)\n013d23f Update the fee test script. (zathras-crypto)\nb856b29 This commit fixes the evaluation of whether a trade should incur a fee. (zathras-crypto)\ncacd1b2 Fix RPC output for trade matches. (zathras-crypto)","distinct":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/8af9eae62699e3d25b6572c3e4f4ee3185779674"},{"sha":"65682613c47dedc6ab9b8313528b8a25a4f408ac","author":{"name":"dexX7","email":"6e89032c4b54b9b65b2742eb145839de8b17b4f9@bitwatch.co"},"message":"Merge pull request #429\n\n42579d5 Change 2 to OMNI_PROPERTY_TMSC to improve code readability (thanks dexx7) (zathras-crypto)\nc1b65b3 Update test to check disabling the fee cache also (zathras-crypto)\nd605a1e Improve the basic tests to cover MetaDEx refunds too (zathras-crypto)\ne92cf25 Add refund of all orders on the MetaDEx if it's deactivated (zathras-crypto)\n21ef723 Add basic deactivation tests (zathras-crypto)\n0ccc5a5 Update comments to note where DeactivateFeature lives (zathras-crypto)\nded344c Add omni_senddeactivation to RPC (zathras-crypto)\n0a1dd65 Add interpret_Deactivation() and logicMath_Deactivation() (zathras-crypto)\nafbedee Add DeactivateFeature function (zathras-crypto)\n9383ab1 Add deactivation transaction type to omnicore.h (zathras-crypto)\n2df52d2 Add payload creation for deactivating features (zathras-crypto)","distinct":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/65682613c47dedc6ab9b8313528b8a25a4f408ac"},{"sha":"549378c9a77709a54a3c3df42668c700a81ff1be","author":{"name":"dexX7","email":"6e89032c4b54b9b65b2742eb145839de8b17b4f9@bitwatch.co"},"message":"Activate recent new features on testnet\n\nAll new features are activated on testnet, to allow testing of the fee system.","distinct":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/549378c9a77709a54a3c3df42668c700a81ff1be"},{"sha":"39cdd9d390e8a4028021f64f34a1b96fcea3aa4b","author":{"name":"dexX7","email":"6e89032c4b54b9b65b2742eb145839de8b17b4f9@bitwatch.co"},"message":"Merge pull request #431\n\n549378c Activate recent new features on testnet (dexX7)","distinct":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/39cdd9d390e8a4028021f64f34a1b96fcea3aa4b"},{"sha":"71cf0d7056f2ef112f56cdada1ccdcb6a90733b4","author":{"name":"zathras-crypto","email":"9e5e7e54715d46ac88fa32dc603839e21257ed67@gmail.com"},"message":"Change the number of signatures for deactivation to 3","distinct":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore/commits/71cf0d7056f2ef112f56cdada1ccdcb6a90733b4"}]}
{"actor":{"display_login":"zathras-crypto"}}