{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/comments/93552798","pull_request_review_id":14082896,"id":93552798,"diff_hunk":"@@ -119,60 +120,69 @@ public void configurePipeline(PipelineConfigurer pipelineConfigurer) throws Ille\n \n   @Override\n   public void transform(StructuredRecord input, Emitter<StructuredRecord> emitter) throws Exception {\n-    String log = getLog(input);\n-    if (log == null) {\n-      LOG.debug(\"Couldn't read schema, log message was null\");\n-      return;\n-    }\n-\n-    StructuredRecord output;\n-    if (S3_LOG.equals(config.logFormat)) {\n-      Matcher logMatcher = S3_LOG_PATTERN.matcher(log);\n-      if (!logMatcher.matches() || logMatcher.groupCount() < S3_REGEX_LENGTH) {\n-        LOG.debug(\"Couldn't parse log because log did not match the S3 format, log: {}\", log);\n-        return;\n-      }\n-      output = parseRequest(logMatcher, S3_INDICES);\n-    } else if (CLF_LOG.equals(config.logFormat)) {\n-      Matcher logMatcher = CLF_LOG_PATTERN.matcher(log);\n-      if (!logMatcher.matches() || logMatcher.groupCount() < CLF_REGEX_LENGTH) {\n-        LOG.debug(\"Couldn't parse log because the log did not match the CLF format. log: {}\", log);\n-        return;\n-      }\n-      output = parseRequest(logMatcher, CLF_INDICES);\n-    } else {\n-      if (log.startsWith(\"#\")) {\n-        LOG.trace(\"Log is a comment. Ignoring...\");\n+    try {","path":"core-plugins/src/main/java/co/cask/hydrator/plugin/transform/LogParserTransform.java","position":36,"original_position":36,"commit_id":"2564b98c0d5cded8d2e1013b32afa243b774bccf","original_commit_id":"2564b98c0d5cded8d2e1013b32afa243b774bccf","user":{"login":"russorat","id":4805997,"avatar_url":"https://avatars.githubusercontent.com/u/4805997?v=3","gravatar_id":"","url":"https://api.github.com/users/russorat","html_url":"https://github.com/russorat","followers_url":"https://api.github.com/users/russorat/followers","following_url":"https://api.github.com/users/russorat/following{/other_user}","gists_url":"https://api.github.com/users/russorat/gists{/gist_id}","starred_url":"https://api.github.com/users/russorat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russorat/subscriptions","organizations_url":"https://api.github.com/users/russorat/orgs","repos_url":"https://api.github.com/users/russorat/repos","events_url":"https://api.github.com/users/russorat/events{/privacy}","received_events_url":"https://api.github.com/users/russorat/received_events","type":"User","site_admin":false},"body":"In this case, let's not wrap all transform methods in a try catch. The reason being that if something really bad happens in the Transform function that you weren't explicitly emitting errors for, the pipeline should still fail so you can update your code. So remove the try catch wrapper for the transform function.","created_at":"2016-12-22T01:32:58Z","updated_at":"2016-12-22T01:32:58Z","html_url":"https://github.com/caskdata/hydrator-plugins/pull/568#discussion_r93552798","pull_request_url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/comments/93552798"},"html":{"href":"https://github.com/caskdata/hydrator-plugins/pull/568#discussion_r93552798"},"pull_request":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568","id":98573440,"html_url":"https://github.com/caskdata/hydrator-plugins/pull/568","diff_url":"https://github.com/caskdata/hydrator-plugins/pull/568.diff","patch_url":"https://github.com/caskdata/hydrator-plugins/pull/568.patch","issue_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/568","number":568,"state":"open","locked":false,"title":"[HYDRATOR-1162] All *Parser plugins should have the ability to write to an error dataset","user":{"login":"rashig","id":13198718,"avatar_url":"https://avatars.githubusercontent.com/u/13198718?v=3","gravatar_id":"","url":"https://api.github.com/users/rashig","html_url":"https://github.com/rashig","followers_url":"https://api.github.com/users/rashig/followers","following_url":"https://api.github.com/users/rashig/following{/other_user}","gists_url":"https://api.github.com/users/rashig/gists{/gist_id}","starred_url":"https://api.github.com/users/rashig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashig/subscriptions","organizations_url":"https://api.github.com/users/rashig/orgs","repos_url":"https://api.github.com/users/rashig/repos","events_url":"https://api.github.com/users/rashig/events{/privacy}","received_events_url":"https://api.github.com/users/rashig/received_events","type":"User","site_admin":false},"body":"JIRA Link:\r\nhttps://issues.cask.co/browse/HYDRATOR-1162","created_at":"2016-12-19T14:23:22Z","updated_at":"2016-12-22T01:32:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7299d102293387297ffdd1f9cb51377ff4263d65","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568/commits","review_comments_url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568/comments","review_comment_url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/568/comments","statuses_url":"https://api.github.com/repos/caskdata/hydrator-plugins/statuses/2564b98c0d5cded8d2e1013b32afa243b774bccf","head":{"label":"rashig:feature/plugins-error-dataset","ref":"feature/plugins-error-dataset","sha":"2564b98c0d5cded8d2e1013b32afa243b774bccf","user":{"login":"rashig","id":13198718,"avatar_url":"https://avatars.githubusercontent.com/u/13198718?v=3","gravatar_id":"","url":"https://api.github.com/users/rashig","html_url":"https://github.com/rashig","followers_url":"https://api.github.com/users/rashig/followers","following_url":"https://api.github.com/users/rashig/following{/other_user}","gists_url":"https://api.github.com/users/rashig/gists{/gist_id}","starred_url":"https://api.github.com/users/rashig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashig/subscriptions","organizations_url":"https://api.github.com/users/rashig/orgs","repos_url":"https://api.github.com/users/rashig/repos","events_url":"https://api.github.com/users/rashig/events{/privacy}","received_events_url":"https://api.github.com/users/rashig/received_events","type":"User","site_admin":false},"repo":{"id":58214089,"name":"hydrator-plugins","full_name":"rashig/hydrator-plugins","owner":{"login":"rashig","id":13198718,"avatar_url":"https://avatars.githubusercontent.com/u/13198718?v=3","gravatar_id":"","url":"https://api.github.com/users/rashig","html_url":"https://github.com/rashig","followers_url":"https://api.github.com/users/rashig/followers","following_url":"https://api.github.com/users/rashig/following{/other_user}","gists_url":"https://api.github.com/users/rashig/gists{/gist_id}","starred_url":"https://api.github.com/users/rashig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashig/subscriptions","organizations_url":"https://api.github.com/users/rashig/orgs","repos_url":"https://api.github.com/users/rashig/repos","events_url":"https://api.github.com/users/rashig/events{/privacy}","received_events_url":"https://api.github.com/users/rashig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rashig/hydrator-plugins","description":"Cask Hydrator Plugins Repository","fork":true,"url":"https://api.github.com/repos/rashig/hydrator-plugins","forks_url":"https://api.github.com/repos/rashig/hydrator-plugins/forks","keys_url":"https://api.github.com/repos/rashig/hydrator-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rashig/hydrator-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rashig/hydrator-plugins/teams","hooks_url":"https://api.github.com/repos/rashig/hydrator-plugins/hooks","issue_events_url":"https://api.github.com/repos/rashig/hydrator-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/rashig/hydrator-plugins/events","assignees_url":"https://api.github.com/repos/rashig/hydrator-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/rashig/hydrator-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/rashig/hydrator-plugins/tags","blobs_url":"https://api.github.com/repos/rashig/hydrator-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rashig/hydrator-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rashig/hydrator-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/rashig/hydrator-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rashig/hydrator-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/rashig/hydrator-plugins/languages","stargazers_url":"https://api.github.com/repos/rashig/hydrator-plugins/stargazers","contributors_url":"https://api.github.com/repos/rashig/hydrator-plugins/contributors","subscribers_url":"https://api.github.com/repos/rashig/hydrator-plugins/subscribers","subscription_url":"https://api.github.com/repos/rashig/hydrator-plugins/subscription","commits_url":"https://api.github.com/repos/rashig/hydrator-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/rashig/hydrator-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/rashig/hydrator-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/rashig/hydrator-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/rashig/hydrator-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/rashig/hydrator-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rashig/hydrator-plugins/merges","archive_url":"https://api.github.com/repos/rashig/hydrator-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rashig/hydrator-plugins/downloads","issues_url":"https://api.github.com/repos/rashig/hydrator-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/rashig/hydrator-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/rashig/hydrator-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/rashig/hydrator-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rashig/hydrator-plugins/labels{/name}","releases_url":"https://api.github.com/repos/rashig/hydrator-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/rashig/hydrator-plugins/deployments","created_at":"2016-05-06T14:47:04Z","updated_at":"2016-05-06T14:47:07Z","pushed_at":"2016-12-21T11:14:18Z","git_url":"git://github.com/rashig/hydrator-plugins.git","ssh_url":"git@github.com:rashig/hydrator-plugins.git","clone_url":"https://github.com/rashig/hydrator-plugins.git","svn_url":"https://github.com/rashig/hydrator-plugins","homepage":"","size":4010,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"b8c8df76a72f1d22ef3cca1f7c3e79b571df231a","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":39922362,"name":"hydrator-plugins","full_name":"caskdata/hydrator-plugins","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/hydrator-plugins","description":"Cask Hydrator Plugins Repository","fork":false,"url":"https://api.github.com/repos/caskdata/hydrator-plugins","forks_url":"https://api.github.com/repos/caskdata/hydrator-plugins/forks","keys_url":"https://api.github.com/repos/caskdata/hydrator-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/hydrator-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/hydrator-plugins/teams","hooks_url":"https://api.github.com/repos/caskdata/hydrator-plugins/hooks","issue_events_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/hydrator-plugins/events","assignees_url":"https://api.github.com/repos/caskdata/hydrator-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/hydrator-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/hydrator-plugins/tags","blobs_url":"https://api.github.com/repos/caskdata/hydrator-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/hydrator-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/hydrator-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/hydrator-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/hydrator-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/hydrator-plugins/languages","stargazers_url":"https://api.github.com/repos/caskdata/hydrator-plugins/stargazers","contributors_url":"https://api.github.com/repos/caskdata/hydrator-plugins/contributors","subscribers_url":"https://api.github.com/repos/caskdata/hydrator-plugins/subscribers","subscription_url":"https://api.github.com/repos/caskdata/hydrator-plugins/subscription","commits_url":"https://api.github.com/repos/caskdata/hydrator-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/hydrator-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/hydrator-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/hydrator-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/hydrator-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/hydrator-plugins/merges","archive_url":"https://api.github.com/repos/caskdata/hydrator-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/hydrator-plugins/downloads","issues_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/hydrator-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/hydrator-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/hydrator-plugins/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/hydrator-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/hydrator-plugins/deployments","created_at":"2015-07-30T00:14:48Z","updated_at":"2016-12-07T13:09:32Z","pushed_at":"2016-12-22T00:34:34Z","git_url":"git://github.com/caskdata/hydrator-plugins.git","ssh_url":"git@github.com:caskdata/hydrator-plugins.git","clone_url":"https://github.com/caskdata/hydrator-plugins.git","svn_url":"https://github.com/caskdata/hydrator-plugins","homepage":"","size":4438,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":18,"forks":21,"open_issues":18,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568"},"html":{"href":"https://github.com/caskdata/hydrator-plugins/pull/568"},"issue":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/568"},"comments":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/hydrator-plugins/statuses/2564b98c0d5cded8d2e1013b32afa243b774bccf"}}}}
{"actor":{"display_login":"russorat"}}