{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/58778012","id":58778012,"diff_hunk":"@@ -23,10 +24,12 @@\n class DumpExtension extends \\Twig_Extension\n {\n     private $cloner;\n+    private $dumper;\n \n-    public function __construct(ClonerInterface $cloner)\n+    public function __construct(ClonerInterface $cloner, DataDumperInterface $dumper = null)","path":"src/Symfony/Bridge/Twig/Extension/DumpExtension.php","position":15,"original_position":15,"commit_id":"6e50f1cba9f405d26a2efa9e17346a0f355606ab","original_commit_id":"6e50f1cba9f405d26a2efa9e17346a0f355606ab","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"It would be the caller's responsibility to use the same dumper when calling this dump method.\r\nWhy would this still force to extend the class btw?","created_at":"2016-04-06T20:41:43Z","updated_at":"2016-04-06T20:41:43Z","html_url":"https://github.com/symfony/symfony/pull/18466#discussion_r58778012","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18466","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/58778012"},"html":{"href":"https://github.com/symfony/symfony/pull/18466#discussion_r58778012"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18466"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18466","id":65501407,"html_url":"https://github.com/symfony/symfony/pull/18466","diff_url":"https://github.com/symfony/symfony/pull/18466.diff","patch_url":"https://github.com/symfony/symfony/pull/18466.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18466","number":18466,"state":"open","locked":false,"title":"[Bridge][Twig] Optionally pass dumper into DumpExtension","user":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| License       | MIT\r\n\r\nAllow the dumper to be passed into `DumpExtension` constructor. This allows a different dumper to be used or even just `HtmlDumper` with a non-default configuration, such as different styles.\r\n\r\nNote: The dumper's output is ignored.","created_at":"2016-04-06T17:02:36Z","updated_at":"2016-04-06T20:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca1a6675daaccf91000d1416b1a8b7cd7f146cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18466/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18466/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18466/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/6e50f1cba9f405d26a2efa9e17346a0f355606ab","head":{"label":"CarsonF:ioc-dump-extension","ref":"ioc-dump-extension","sha":"6e50f1cba9f405d26a2efa9e17346a0f355606ab","user":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"repo":{"id":45508493,"name":"symfony","full_name":"CarsonF/symfony","owner":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarsonF/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/CarsonF/symfony","forks_url":"https://api.github.com/repos/CarsonF/symfony/forks","keys_url":"https://api.github.com/repos/CarsonF/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarsonF/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarsonF/symfony/teams","hooks_url":"https://api.github.com/repos/CarsonF/symfony/hooks","issue_events_url":"https://api.github.com/repos/CarsonF/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/CarsonF/symfony/events","assignees_url":"https://api.github.com/repos/CarsonF/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/CarsonF/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/CarsonF/symfony/tags","blobs_url":"https://api.github.com/repos/CarsonF/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarsonF/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarsonF/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarsonF/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarsonF/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/CarsonF/symfony/languages","stargazers_url":"https://api.github.com/repos/CarsonF/symfony/stargazers","contributors_url":"https://api.github.com/repos/CarsonF/symfony/contributors","subscribers_url":"https://api.github.com/repos/CarsonF/symfony/subscribers","subscription_url":"https://api.github.com/repos/CarsonF/symfony/subscription","commits_url":"https://api.github.com/repos/CarsonF/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarsonF/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarsonF/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarsonF/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarsonF/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/CarsonF/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarsonF/symfony/merges","archive_url":"https://api.github.com/repos/CarsonF/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarsonF/symfony/downloads","issues_url":"https://api.github.com/repos/CarsonF/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/CarsonF/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/CarsonF/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/CarsonF/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarsonF/symfony/labels{/name}","releases_url":"https://api.github.com/repos/CarsonF/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/CarsonF/symfony/deployments","created_at":"2015-11-04T01:59:01Z","updated_at":"2015-11-04T01:59:19Z","pushed_at":"2016-04-06T19:43:21Z","git_url":"git://github.com/CarsonF/symfony.git","ssh_url":"git@github.com:CarsonF/symfony.git","clone_url":"https://github.com/CarsonF/symfony.git","svn_url":"https://github.com/CarsonF/symfony","homepage":"symfony.com","size":70381,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.8"}},"base":{"label":"symfony:master","ref":"master","sha":"45b557a5a7461738fc615cb80fc4076cbbdc251d","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-04-06T20:16:09Z","pushed_at":"2016-04-06T20:28:44Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":105716,"stargazers_count":12080,"watchers_count":12080,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4742,"mirror_url":null,"open_issues_count":723,"forks":4742,"open_issues":723,"watchers":12080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18466"},"html":{"href":"https://github.com/symfony/symfony/pull/18466"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18466"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18466/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18466/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18466/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/6e50f1cba9f405d26a2efa9e17346a0f355606ab"}}}}