{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/74601956","id":74601956,"diff_hunk":"@@ -42,6 +42,17 @@ public class PrepareTargets\n         public static BuildTargetResult Init(BuildTargetContext c)\n         {\n             var configEnv = Environment.GetEnvironmentVariable(\"CONFIGURATION\");\n+            string platformEnv = Environment.GetEnvironmentVariable(\"TARGETPLATFORM\") ?? RuntimeEnvironment.OperatingSystemPlatform.ToString();\n+            string targetRID = Environment.GetEnvironmentVariable(\"TARGETRID\");\n+            if (targetRID == null)\n+            {\n+                targetRID = RuntimeEnvironment.GetRuntimeIdentifier();\n+                if (targetRID.StartsWith(\"win\") && (targetRID.EndsWith(\"x86\") || targetRID.EndsWith(\"x64\")))","path":"build_projects/dotnet-host-build/PrepareTargets.cs","position":9,"original_position":9,"commit_id":"2563dc27e0802ddb8c69d9903cc7640e5de9e153","original_commit_id":"2563dc27e0802ddb8c69d9903cc7640e5de9e153","user":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"body":"If the TARGETRID env variable isn't set in build.ps1 (i.e. the TargetArch isn't set), then `RuntimeEnvironment.GetRuntimeIdentifier` returns your version-specific RID e.g. on a win10 x64 machine it returns `win10-x64`. We want it to be `win7-x64`.","created_at":"2016-08-12T14:40:01Z","updated_at":"2016-08-12T14:40:01Z","html_url":"https://github.com/dotnet/core-setup/pull/236#discussion_r74601956","pull_request_url":"https://api.github.com/repos/dotnet/core-setup/pulls/236","_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/74601956"},"html":{"href":"https://github.com/dotnet/core-setup/pull/236#discussion_r74601956"},"pull_request":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/236","id":81023999,"html_url":"https://github.com/dotnet/core-setup/pull/236","diff_url":"https://github.com/dotnet/core-setup/pull/236.diff","patch_url":"https://github.com/dotnet/core-setup/pull/236.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/236","number":236,"state":"open","locked":false,"title":"Add win10-arm64 and netcoreapp1.1 support","user":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"body":"Adds parameterization to the Target framework and Target RID when doing a full build.cmd.  The end result of this is that core-setup packages can now be built for win10-arm64.\r\n- Modifies CMake targets to allow win10-arm64 as a valid RID and arm64 as a valid machine platform.\r\n- build.ps1 now allows passing a TargetArch (e.g. x64, arm64), ToolsDir (used for arm64 native build), and Framework (defaulted to netcoreapp1.0).\r\n- Extracted all instances of RuntimeInformation.CurrentRuntimeEnvironment (and friends) where possible, and added environment variable checks to override the behavior.\r\n- Can now build for a different architecture than the current platform.\r\n- Adds package projects and targets for win10-arm64\r\n- Adds .NETCoreApp1.1 as a targetframework for the Microsoft.NETCore.App meta package.\r\n  - .NETCoreApp1.1 has updated (i.e. beta) package dependency versions as well as a new dependency on Microsoft.NetCore.Targets to ensure native dependencies (clrcompression) are resolved to the correct version.\r\n  - The targetframework definition for .NETCoreApp1.0 is unchanged.\r\n\r\nCaveats:\r\n  - The win10-arm64 product zip produced by this is missing libuv but is otherwise at correct parity with the win7-x64 zip.\r\n  - MSI installers for win10-arm64 are being produced but do not yet work correctly.\r\n  - crossgen is disabled for win10-arm64\r\n  - tests are still tethered to the current platform and thus don't work when building for a TargetPlatform other than the current platform.\r\n\r\n@ericstj @weshaggard @gkhanna79 \r\n\r\nfyi: @livarcocc ","created_at":"2016-08-11T20:21:12Z","updated_at":"2016-08-12T14:40:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a426c8c85548b62772d4c26294df99aaf5fe49da","assignee":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"assignees":[{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/core-setup/milestones/2","html_url":"https://github.com/dotnet/core-setup/milestones/1.1.0","labels_url":"https://api.github.com/repos/dotnet/core-setup/milestones/2/labels","id":1809814,"number":2,"title":"1.1.0","description":"","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":4,"state":"open","created_at":"2016-06-06T04:11:17Z","updated_at":"2016-08-11T20:21:12Z","due_on":"2016-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/236/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/236/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/236/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/2563dc27e0802ddb8c69d9903cc7640e5de9e153","head":{"label":"ianhays:win10-arm64","ref":"win10-arm64","sha":"2563dc27e0802ddb8c69d9903cc7640e5de9e153","user":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"repo":{"id":63731209,"name":"core-setup","full_name":"ianhays/core-setup","owner":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianhays/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/ianhays/core-setup","forks_url":"https://api.github.com/repos/ianhays/core-setup/forks","keys_url":"https://api.github.com/repos/ianhays/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianhays/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianhays/core-setup/teams","hooks_url":"https://api.github.com/repos/ianhays/core-setup/hooks","issue_events_url":"https://api.github.com/repos/ianhays/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/ianhays/core-setup/events","assignees_url":"https://api.github.com/repos/ianhays/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/ianhays/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/ianhays/core-setup/tags","blobs_url":"https://api.github.com/repos/ianhays/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianhays/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianhays/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianhays/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianhays/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/ianhays/core-setup/languages","stargazers_url":"https://api.github.com/repos/ianhays/core-setup/stargazers","contributors_url":"https://api.github.com/repos/ianhays/core-setup/contributors","subscribers_url":"https://api.github.com/repos/ianhays/core-setup/subscribers","subscription_url":"https://api.github.com/repos/ianhays/core-setup/subscription","commits_url":"https://api.github.com/repos/ianhays/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianhays/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianhays/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianhays/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianhays/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/ianhays/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianhays/core-setup/merges","archive_url":"https://api.github.com/repos/ianhays/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianhays/core-setup/downloads","issues_url":"https://api.github.com/repos/ianhays/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/ianhays/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/ianhays/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/ianhays/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianhays/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/ianhays/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/ianhays/core-setup/deployments","created_at":"2016-07-19T22:07:47Z","updated_at":"2016-07-19T22:07:48Z","pushed_at":"2016-08-11T22:46:12Z","git_url":"git://github.com/ianhays/core-setup.git","ssh_url":"git@github.com:ianhays/core-setup.git","clone_url":"https://github.com/ianhays/core-setup.git","svn_url":"https://github.com/ianhays/core-setup","homepage":"","size":1324,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b79fc7fed0b8d89b83f1fe170d4d6c0d41c3123d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"name":"core-setup","full_name":"dotnet/core-setup","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2016-08-09T13:07:29Z","pushed_at":"2016-08-11T22:46:12Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"git@github.com:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":1443,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":38,"forks":32,"open_issues":38,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/236"},"html":{"href":"https://github.com/dotnet/core-setup/pull/236"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/236"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/2563dc27e0802ddb8c69d9903cc7640e5de9e153"}}}}
{"actor":{"display_login":"ianhays"}}