{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/80433731","id":80433731,"diff_hunk":"@@ -1585,8 +1592,11 @@ construct_spec(nvlist_t *props, int argc, char **argv)\n \t\t\t * construct the appropriate nvlist describing the vdev.\n \t\t\t */\n \t\t\tif ((nv = make_leaf_vdev(props, argv[0],\n-\t\t\t    is_log)) == NULL)\n+\t\t\t    is_log)) == NULL) {\n+\t\t\t\tfree(spares);\n+\t\t\t\tfree(top);","path":"cmd/zpool/zpool_vdev.c","position":null,"original_position":42,"commit_id":"f60ba1a0e208c3223c39a7489e90d3a50b7f9f56","original_commit_id":"d658982d38352347642f3e9388fe8a8239782632","user":{"login":"heary-cao","id":20164092,"avatar_url":"https://avatars.githubusercontent.com/u/20164092?v=3","gravatar_id":"","url":"https://api.github.com/users/heary-cao","html_url":"https://github.com/heary-cao","followers_url":"https://api.github.com/users/heary-cao/followers","following_url":"https://api.github.com/users/heary-cao/following{/other_user}","gists_url":"https://api.github.com/users/heary-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/heary-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heary-cao/subscriptions","organizations_url":"https://api.github.com/users/heary-cao/orgs","repos_url":"https://api.github.com/users/heary-cao/repos","events_url":"https://api.github.com/users/heary-cao/events{/privacy}","received_events_url":"https://api.github.com/users/heary-cao/received_events","type":"User","site_admin":false},"body":"@rlaager please review it again\r\n","created_at":"2016-09-26T09:06:52Z","updated_at":"2016-09-26T09:06:52Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5143#discussion_r80433731","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/80433731"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5143#discussion_r80433731"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143","id":86091174,"html_url":"https://github.com/zfsonlinux/zfs/pull/5143","diff_url":"https://github.com/zfsonlinux/zfs/pull/5143.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5143.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5143","number":5143,"state":"open","locked":false,"title":"fix coverity defects with CID 147610, 147608,147607","user":{"login":"heary-cao","id":20164092,"avatar_url":"https://avatars.githubusercontent.com/u/20164092?v=3","gravatar_id":"","url":"https://api.github.com/users/heary-cao","html_url":"https://github.com/heary-cao","followers_url":"https://api.github.com/users/heary-cao/followers","following_url":"https://api.github.com/users/heary-cao/following{/other_user}","gists_url":"https://api.github.com/users/heary-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/heary-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heary-cao/subscriptions","organizations_url":"https://api.github.com/users/heary-cao/orgs","repos_url":"https://api.github.com/users/heary-cao/repos","events_url":"https://api.github.com/users/heary-cao/events{/privacy}","received_events_url":"https://api.github.com/users/heary-cao/received_events","type":"User","site_admin":false},"body":"issues:\r\nfix coverity defects\r\ncoverity scan CID:147610, Type: Resource leak.\r\nreason: strdup copy, but zfs_open fail , not free copy. so resource leak.\r\n\r\ncoverity scan CID:147608, Type: Resource leak.\r\ncoverity scan CID:147607, Type: Resource leak.\r\nreason: realloc top spares, but invalid vdev specification, not free top,spares. \r\nso resource leak.\r\n\r\nSigned-off-by: cao.xuewen <cao.xuewen@zte.com.cn>","created_at":"2016-09-21T03:11:48Z","updated_at":"2016-09-26T09:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8101cadd90e5c56fe1e17c2d448f8545d6b5c70","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5143/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f60ba1a0e208c3223c39a7489e90d3a50b7f9f56","head":{"label":"heary-cao:fix_147610","ref":"fix_147610","sha":"f60ba1a0e208c3223c39a7489e90d3a50b7f9f56","user":{"login":"heary-cao","id":20164092,"avatar_url":"https://avatars.githubusercontent.com/u/20164092?v=3","gravatar_id":"","url":"https://api.github.com/users/heary-cao","html_url":"https://github.com/heary-cao","followers_url":"https://api.github.com/users/heary-cao/followers","following_url":"https://api.github.com/users/heary-cao/following{/other_user}","gists_url":"https://api.github.com/users/heary-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/heary-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heary-cao/subscriptions","organizations_url":"https://api.github.com/users/heary-cao/orgs","repos_url":"https://api.github.com/users/heary-cao/repos","events_url":"https://api.github.com/users/heary-cao/events{/privacy}","received_events_url":"https://api.github.com/users/heary-cao/received_events","type":"User","site_admin":false},"repo":{"id":64269405,"name":"zfs","full_name":"heary-cao/zfs","owner":{"login":"heary-cao","id":20164092,"avatar_url":"https://avatars.githubusercontent.com/u/20164092?v=3","gravatar_id":"","url":"https://api.github.com/users/heary-cao","html_url":"https://github.com/heary-cao","followers_url":"https://api.github.com/users/heary-cao/followers","following_url":"https://api.github.com/users/heary-cao/following{/other_user}","gists_url":"https://api.github.com/users/heary-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/heary-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heary-cao/subscriptions","organizations_url":"https://api.github.com/users/heary-cao/orgs","repos_url":"https://api.github.com/users/heary-cao/repos","events_url":"https://api.github.com/users/heary-cao/events{/privacy}","received_events_url":"https://api.github.com/users/heary-cao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heary-cao/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/heary-cao/zfs","forks_url":"https://api.github.com/repos/heary-cao/zfs/forks","keys_url":"https://api.github.com/repos/heary-cao/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heary-cao/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heary-cao/zfs/teams","hooks_url":"https://api.github.com/repos/heary-cao/zfs/hooks","issue_events_url":"https://api.github.com/repos/heary-cao/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/heary-cao/zfs/events","assignees_url":"https://api.github.com/repos/heary-cao/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/heary-cao/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/heary-cao/zfs/tags","blobs_url":"https://api.github.com/repos/heary-cao/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heary-cao/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heary-cao/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/heary-cao/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heary-cao/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/heary-cao/zfs/languages","stargazers_url":"https://api.github.com/repos/heary-cao/zfs/stargazers","contributors_url":"https://api.github.com/repos/heary-cao/zfs/contributors","subscribers_url":"https://api.github.com/repos/heary-cao/zfs/subscribers","subscription_url":"https://api.github.com/repos/heary-cao/zfs/subscription","commits_url":"https://api.github.com/repos/heary-cao/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/heary-cao/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/heary-cao/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/heary-cao/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/heary-cao/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/heary-cao/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heary-cao/zfs/merges","archive_url":"https://api.github.com/repos/heary-cao/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heary-cao/zfs/downloads","issues_url":"https://api.github.com/repos/heary-cao/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/heary-cao/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/heary-cao/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/heary-cao/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heary-cao/zfs/labels{/name}","releases_url":"https://api.github.com/repos/heary-cao/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/heary-cao/zfs/deployments","created_at":"2016-07-27T02:13:00Z","updated_at":"2016-07-27T02:13:07Z","pushed_at":"2016-09-26T09:01:54Z","git_url":"git://github.com/heary-cao/zfs.git","ssh_url":"git@github.com:heary-cao/zfs.git","clone_url":"https://github.com/heary-cao/zfs.git","svn_url":"https://github.com/heary-cao/zfs","homepage":"http://zfsonlinux.org/","size":32128,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"92bc9278689fcce48183182f2488ead42a9eb790","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-09-22T00:22:33Z","pushed_at":"2016-09-26T09:01:55Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":60010,"stargazers_count":2061,"watchers_count":2061,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":513,"mirror_url":null,"open_issues_count":1055,"forks":513,"open_issues":1055,"watchers":2061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5143"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5143"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5143/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5143/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f60ba1a0e208c3223c39a7489e90d3a50b7f9f56"}}}}
{"actor":{"display_login":"heary-cao"}}