{"action":"created","comment":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments/73880314","id":73880314,"diff_hunk":"@@ -440,18 +451,33 @@ export default class VictoryGroup extends React.Component {\n     return React.cloneElement(containerComponent, parentProps);\n   }\n \n-  renderGroup(children, style) {\n+  renderGroup(children, modifiedProps, style) {\n+    const { clipPathComponent } = modifiedProps;\n+    const barWidth = style.data.width;\n+    const clipComponent = React.cloneElement(clipPathComponent, Object.assign(\n+      {},\n+      {\n+        padding: modifiedProps.padding,\n+        clipId: modifiedProps.clipId,\n+        barWidth,\n+        clipWidth: modifiedProps.clipWidth + barWidth * 2 || modifiedProps.width + barWidth * 2,","path":"src/components/victory-group/victory-group.js","position":null,"original_position":67,"commit_id":"e904b1f498ce98099e44a70b2edf58b6169c066e","original_commit_id":"7018ac32bfbbd4de96ad9bdcc6a2fca560e084c5","user":{"login":"chilijung","id":1216029,"avatar_url":"https://avatars.githubusercontent.com/u/1216029?v=3","gravatar_id":"","url":"https://api.github.com/users/chilijung","html_url":"https://github.com/chilijung","followers_url":"https://api.github.com/users/chilijung/followers","following_url":"https://api.github.com/users/chilijung/following{/other_user}","gists_url":"https://api.github.com/users/chilijung/gists{/gist_id}","starred_url":"https://api.github.com/users/chilijung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilijung/subscriptions","organizations_url":"https://api.github.com/users/chilijung/orgs","repos_url":"https://api.github.com/users/chilijung/repos","events_url":"https://api.github.com/users/chilijung/events{/privacy}","received_events_url":"https://api.github.com/users/chilijung/received_events","type":"User","site_admin":false},"body":"fixed https://github.com/FormidableLabs/victory-chart/pull/333/commits/99e7af3b863494df1eaf5a38da7cc35390ed3d59","created_at":"2016-08-08T14:04:47Z","updated_at":"2016-08-08T14:04:47Z","html_url":"https://github.com/FormidableLabs/victory-chart/pull/333#discussion_r73880314","pull_request_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333","_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments/73880314"},"html":{"href":"https://github.com/FormidableLabs/victory-chart/pull/333#discussion_r73880314"},"pull_request":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333"}}},"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333","id":80029269,"html_url":"https://github.com/FormidableLabs/victory-chart/pull/333","diff_url":"https://github.com/FormidableLabs/victory-chart/pull/333.diff","patch_url":"https://github.com/FormidableLabs/victory-chart/pull/333.patch","issue_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/333","number":333,"state":"open","locked":false,"title":"Fix/transition with curtain method","user":{"login":"chilijung","id":1216029,"avatar_url":"https://avatars.githubusercontent.com/u/1216029?v=3","gravatar_id":"","url":"https://api.github.com/users/chilijung","html_url":"https://github.com/chilijung","followers_url":"https://api.github.com/users/chilijung/followers","following_url":"https://api.github.com/users/chilijung/following{/other_user}","gists_url":"https://api.github.com/users/chilijung/gists{/gist_id}","starred_url":"https://api.github.com/users/chilijung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilijung/subscriptions","organizations_url":"https://api.github.com/users/chilijung/orgs","repos_url":"https://api.github.com/users/chilijung/repos","events_url":"https://api.github.com/users/chilijung/events{/privacy}","received_events_url":"https://api.github.com/users/chilijung/received_events","type":"User","site_admin":false},"body":"@boygirl ! fix transition with curtain method \r\n\r\nDEMO!!!!\r\n\r\n![animate](https://cloud.githubusercontent.com/assets/1216029/17393388/f0851758-5a55-11e6-98c3-4078d2827c68.gif)\r\n![line](https://cloud.githubusercontent.com/assets/1216029/17393389/f08e4918-5a55-11e6-8c8b-d8515859e281.gif)\r\n\r\nThis work perfect with bars and axes! If it also looks good to you. I'll implement in area chart!","created_at":"2016-08-04T07:15:01Z","updated_at":"2016-08-08T14:04:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e4c2bf977ac8110257a10245bf9e7635542870","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333/commits","review_comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333/comments","review_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/333/comments","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/e904b1f498ce98099e44a70b2edf58b6169c066e","head":{"label":"FormidableLabs:fix/transition-curtain-method","ref":"fix/transition-curtain-method","sha":"e904b1f498ce98099e44a70b2edf58b6169c066e","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40037231,"name":"victory-chart","full_name":"FormidableLabs/victory-chart","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/victory-chart","description":"Chart Component for Victory","fork":false,"url":"https://api.github.com/repos/FormidableLabs/victory-chart","forks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/forks","keys_url":"https://api.github.com/repos/FormidableLabs/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/victory-chart/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/events","assignees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/victory-chart/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/victory-chart/merges","archive_url":"https://api.github.com/repos/FormidableLabs/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/victory-chart/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/deployments","created_at":"2015-08-01T06:05:36Z","updated_at":"2016-08-04T18:54:53Z","pushed_at":"2016-08-08T14:00:57Z","git_url":"git://github.com/FormidableLabs/victory-chart.git","ssh_url":"git@github.com:FormidableLabs/victory-chart.git","clone_url":"https://github.com/FormidableLabs/victory-chart.git","svn_url":"https://github.com/FormidableLabs/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14415,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":23,"forks":31,"open_issues":23,"watchers":61,"default_branch":"master"}},"base":{"label":"FormidableLabs:master","ref":"master","sha":"4976ecea07ed6005b39037dabadc2680e3c8cc79","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40037231,"name":"victory-chart","full_name":"FormidableLabs/victory-chart","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/victory-chart","description":"Chart Component for Victory","fork":false,"url":"https://api.github.com/repos/FormidableLabs/victory-chart","forks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/forks","keys_url":"https://api.github.com/repos/FormidableLabs/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/victory-chart/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/events","assignees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/victory-chart/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/victory-chart/merges","archive_url":"https://api.github.com/repos/FormidableLabs/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/victory-chart/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/deployments","created_at":"2015-08-01T06:05:36Z","updated_at":"2016-08-04T18:54:53Z","pushed_at":"2016-08-08T14:00:57Z","git_url":"git://github.com/FormidableLabs/victory-chart.git","ssh_url":"git@github.com:FormidableLabs/victory-chart.git","clone_url":"https://github.com/FormidableLabs/victory-chart.git","svn_url":"https://github.com/FormidableLabs/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14415,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":23,"forks":31,"open_issues":23,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333"},"html":{"href":"https://github.com/FormidableLabs/victory-chart/pull/333"},"issue":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/333"},"comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/e904b1f498ce98099e44a70b2edf58b6169c066e"}}}}
{"actor":{"display_login":"chilijung"}}