{"action":"created","comment":{"url":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments/71435635","id":71435635,"diff_hunk":"@@ -269,9 +272,17 @@ Perhaps you want to use the \\`returnPartialData\\` option?`);\n \n   // Handle all scalar types here\n   if (! field.selectionSet) {\n-    return {\n-      result: storeValue,\n-    };\n+    if (!isJsonValue(storeValue)) {","path":"src/data/diffAgainstStore.ts","position":25,"original_position":25,"commit_id":"ea4fe7b2a7b1ca8d37a0eaf063ad85e819e8e2a4","original_commit_id":"ea4fe7b2a7b1ca8d37a0eaf063ad85e819e8e2a4","user":{"login":"stubailo","id":448783,"avatar_url":"https://avatars.githubusercontent.com/u/448783?v=3","gravatar_id":"","url":"https://api.github.com/users/stubailo","html_url":"https://github.com/stubailo","followers_url":"https://api.github.com/users/stubailo/followers","following_url":"https://api.github.com/users/stubailo/following{/other_user}","gists_url":"https://api.github.com/users/stubailo/gists{/gist_id}","starred_url":"https://api.github.com/users/stubailo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stubailo/subscriptions","organizations_url":"https://api.github.com/users/stubailo/orgs","repos_url":"https://api.github.com/users/stubailo/repos","events_url":"https://api.github.com/users/stubailo/events{/privacy}","received_events_url":"https://api.github.com/users/stubailo/received_events","type":"User","site_admin":false},"body":"I'd prefer to reorder these, so that we don't need the `!`. Then we also don't need the cast since TypeScript can figure out the types for us I think.","created_at":"2016-07-19T22:23:17Z","updated_at":"2016-07-19T22:23:17Z","html_url":"https://github.com/apollostack/apollo-client/pull/389#discussion_r71435635","pull_request_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments/71435635"},"html":{"href":"https://github.com/apollostack/apollo-client/pull/389#discussion_r71435635"},"pull_request":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-client/pulls/389","id":77162012,"html_url":"https://github.com/apollostack/apollo-client/pull/389","diff_url":"https://github.com/apollostack/apollo-client/pull/389.diff","patch_url":"https://github.com/apollostack/apollo-client/pull/389.patch","issue_url":"https://api.github.com/repos/apollostack/apollo-client/issues/389","number":389,"state":"open","locked":false,"title":"Fixed the orphaned node bug","user":{"login":"Poincare","id":217352,"avatar_url":"https://avatars.githubusercontent.com/u/217352?v=3","gravatar_id":"","url":"https://api.github.com/users/Poincare","html_url":"https://github.com/Poincare","followers_url":"https://api.github.com/users/Poincare/followers","following_url":"https://api.github.com/users/Poincare/following{/other_user}","gists_url":"https://api.github.com/users/Poincare/gists{/gist_id}","starred_url":"https://api.github.com/users/Poincare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poincare/subscriptions","organizations_url":"https://api.github.com/users/Poincare/orgs","repos_url":"https://api.github.com/users/Poincare/repos","events_url":"https://api.github.com/users/Poincare/events{/privacy}","received_events_url":"https://api.github.com/users/Poincare/received_events","type":"User","site_admin":false},"body":"Fixes #344.\r\n\r\nTODO:\r\n\r\n- [ ] Update CHANGELOG.md with your change\r\n- [ ] Make sure all of the significant new logic is covered by tests\r\n- [ ] Rebase your changes on master so that they can be merged easily\r\n- [ ] Make sure all tests and linter rules pass\r\n\r\n","created_at":"2016-07-12T17:53:51Z","updated_at":"2016-07-19T22:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"143776d1f7c3ef451561a293545c01488c6e2d94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/389/commits","review_comments_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/389/comments","review_comment_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/issues/389/comments","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/ea4fe7b2a7b1ca8d37a0eaf063ad85e819e8e2a4","head":{"label":"apollostack:orphaned_node","ref":"orphaned_node","sha":"ea4fe7b2a7b1ca8d37a0eaf063ad85e819e8e2a4","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollostack/apollo-client","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-client","description":":rocket: A simple caching client for any GraphQL server and UI framework","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-client","forks_url":"https://api.github.com/repos/apollostack/apollo-client/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-client/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-client/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2016-07-19T12:23:20Z","pushed_at":"2016-07-19T22:17:16Z","git_url":"git://github.com/apollostack/apollo-client.git","ssh_url":"git@github.com:apollostack/apollo-client.git","clone_url":"https://github.com/apollostack/apollo-client.git","svn_url":"https://github.com/apollostack/apollo-client","homepage":"http://docs.apollostack.com/apollo-client/","size":1680,"stargazers_count":645,"watchers_count":645,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":73,"forks":49,"open_issues":73,"watchers":645,"default_branch":"master"}},"base":{"label":"apollostack:master","ref":"master","sha":"378cbbe6054d0bae2b4ede2387d19dc2d1927567","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollostack/apollo-client","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-client","description":":rocket: A simple caching client for any GraphQL server and UI framework","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-client","forks_url":"https://api.github.com/repos/apollostack/apollo-client/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-client/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-client/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2016-07-19T12:23:20Z","pushed_at":"2016-07-19T22:17:16Z","git_url":"git://github.com/apollostack/apollo-client.git","ssh_url":"git@github.com:apollostack/apollo-client.git","clone_url":"https://github.com/apollostack/apollo-client.git","svn_url":"https://github.com/apollostack/apollo-client","homepage":"http://docs.apollostack.com/apollo-client/","size":1680,"stargazers_count":645,"watchers_count":645,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":73,"forks":49,"open_issues":73,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/389"},"html":{"href":"https://github.com/apollostack/apollo-client/pull/389"},"issue":{"href":"https://api.github.com/repos/apollostack/apollo-client/issues/389"},"comments":{"href":"https://api.github.com/repos/apollostack/apollo-client/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/apollo-client/statuses/ea4fe7b2a7b1ca8d37a0eaf063ad85e819e8e2a4"}}}}
{"actor":{"display_login":"stubailo"}}