{"action":"created","issue":{"url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/132","repository_url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded","labels_url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/132/comments","events_url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/132/events","html_url":"https://github.com/AuthMe-Team/AuthMeReloaded/pull/132","id":157378563,"number":132,"title":"[Do not merge] Player listener cleanup","user":{"login":"ljacqu","id":8417009,"avatar_url":"https://avatars.githubusercontent.com/u/8417009?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacqu","html_url":"https://github.com/ljacqu","followers_url":"https://api.github.com/users/ljacqu/followers","following_url":"https://api.github.com/users/ljacqu/following{/other_user}","gists_url":"https://api.github.com/users/ljacqu/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacqu/subscriptions","organizations_url":"https://api.github.com/users/ljacqu/orgs","repos_url":"https://api.github.com/users/ljacqu/repos","events_url":"https://api.github.com/users/ljacqu/events{/privacy}","received_events_url":"https://api.github.com/users/ljacqu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-29T09:56:01Z","updated_at":"2016-05-30T15:53:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/pulls/132","html_url":"https://github.com/AuthMe-Team/AuthMeReloaded/pull/132","diff_url":"https://github.com/AuthMe-Team/AuthMeReloaded/pull/132.diff","patch_url":"https://github.com/AuthMe-Team/AuthMeReloaded/pull/132.patch"},"body":"This PR does the following:\r\n- moves the logic of join checks into a separate class\r\n  - create unit tests for most methods\r\n- structures the checks we perform into individual methods\r\n  - offers clean overview of which checks are being performed where, in which order\r\n  - reduces duplication in onPlayerLogin and onPreLogin\r\n- **(!)** moves checks only done in onPreLogin to onPlayerLogin: not all servers fire onPreLogin in offline mode\r\n\r\nTODO:\r\n- verify that all features work (name validation, kick non registered, anti bot, name casing, single session, player country) on Spigot and CraftBukkit\r\n\r\nRequest for comments—@sgdc3 @games647 @DNx5 & anyone interested. I will not merge before Wednesday so feel free to take the time to look the changes over (much appreciated!)."},"comment":{"url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/comments/222519268","html_url":"https://github.com/AuthMe-Team/AuthMeReloaded/pull/132#issuecomment-222519268","issue_url":"https://api.github.com/repos/AuthMe-Team/AuthMeReloaded/issues/132","id":222519268,"user":{"login":"sgdc3","id":8779252,"avatar_url":"https://avatars.githubusercontent.com/u/8779252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgdc3","html_url":"https://github.com/sgdc3","followers_url":"https://api.github.com/users/sgdc3/followers","following_url":"https://api.github.com/users/sgdc3/following{/other_user}","gists_url":"https://api.github.com/users/sgdc3/gists{/gist_id}","starred_url":"https://api.github.com/users/sgdc3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgdc3/subscriptions","organizations_url":"https://api.github.com/users/sgdc3/orgs","repos_url":"https://api.github.com/users/sgdc3/repos","events_url":"https://api.github.com/users/sgdc3/events{/privacy}","received_events_url":"https://api.github.com/users/sgdc3/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T15:53:39Z","updated_at":"2016-05-30T15:53:39Z","body":"@ljacqu Exactly"}}
{"actor":{"display_login":"sgdc3"}}