{"action":"created","comment":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/76931038","id":76931038,"diff_hunk":"@@ -1349,6 +1349,13 @@ def setAcquisitionEra(self, era, parentAcquisitionEra=None):\n         \"\"\"\n         if isinstance(era, dict):\n             taskEra = era.get(self.name(), parentAcquisitionEra)\n+            if taskEra is None:\n+                # We cannot properly set AcqEra for ACDC of TaskChain Merge\n+                # failures, so we should look up for a similar taskname in\n+                # the acqera dict passed from the requestor\n+                for taskname in era:","path":"src/python/WMCore/WMSpec/WMTask.py","position":8,"original_position":8,"commit_id":"6b9e8efb26ff132c896f6b85b7fdb2360696d54b","original_commit_id":"6b9e8efb26ff132c896f6b85b7fdb2360696d54b","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"body":"Hmm, I had that in mind as well. But in this specific case, I don't think it has a parent task, since the Merge task would be the first Task in the ACDC request.","created_at":"2016-08-31T06:33:05Z","updated_at":"2016-08-31T06:33:05Z","html_url":"https://github.com/dmwm/WMCore/pull/7130#discussion_r76931038","pull_request_url":"https://api.github.com/repos/dmwm/WMCore/pulls/7130","_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/76931038"},"html":{"href":"https://github.com/dmwm/WMCore/pull/7130#discussion_r76931038"},"pull_request":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/7130"}}},"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/7130","id":83348071,"html_url":"https://github.com/dmwm/WMCore/pull/7130","diff_url":"https://github.com/dmwm/WMCore/pull/7130.diff","patch_url":"https://github.com/dmwm/WMCore/pull/7130.patch","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/7130","number":7130,"state":"open","locked":false,"title":"Properly set AcqEra for any task level - TaskChain","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"body":"Fixes #6941\r\n\r\nMakes AcqEra parameter mandatory for assignment in reqmgr (it already is, I hope, in reqmgr2).\r\nAbout the assign_optional validation, I could not find anything validating it in ReqMgr. Should we call this validation function being used by reqmgr2:\r\nhttps://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/WMWorkloadTools.py#L241\r\n?\r\n\r\nFor ACDCs of TaskChain Merge jobs, we sometimes don't have the Processing task in the workflow, meaning AcqEra key/value would not find that TaskName. I added a workaround such that Merge tasks will inherit the value from its parent according to one string contains another.\r\n\r\n@ticoann I still have to test it, but feel free to make comments :)","created_at":"2016-08-30T21:11:11Z","updated_at":"2016-08-31T06:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf5f17ff4dbc4107d086b3901542d0ef1bf755dc","assignee":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"assignees":[{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dmwm/WMCore/pulls/7130/commits","review_comments_url":"https://api.github.com/repos/dmwm/WMCore/pulls/7130/comments","review_comment_url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/7130/comments","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/6b9e8efb26ff132c896f6b85b7fdb2360696d54b","head":{"label":"amaltaro:fix-AcqEra","ref":"fix-AcqEra","sha":"6b9e8efb26ff132c896f6b85b7fdb2360696d54b","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"repo":{"id":20023049,"name":"WMCore","full_name":"amaltaro/WMCore","owner":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amaltaro/WMCore","description":"WMCore","fork":true,"url":"https://api.github.com/repos/amaltaro/WMCore","forks_url":"https://api.github.com/repos/amaltaro/WMCore/forks","keys_url":"https://api.github.com/repos/amaltaro/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amaltaro/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amaltaro/WMCore/teams","hooks_url":"https://api.github.com/repos/amaltaro/WMCore/hooks","issue_events_url":"https://api.github.com/repos/amaltaro/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/amaltaro/WMCore/events","assignees_url":"https://api.github.com/repos/amaltaro/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/amaltaro/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/amaltaro/WMCore/tags","blobs_url":"https://api.github.com/repos/amaltaro/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amaltaro/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amaltaro/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/amaltaro/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amaltaro/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/amaltaro/WMCore/languages","stargazers_url":"https://api.github.com/repos/amaltaro/WMCore/stargazers","contributors_url":"https://api.github.com/repos/amaltaro/WMCore/contributors","subscribers_url":"https://api.github.com/repos/amaltaro/WMCore/subscribers","subscription_url":"https://api.github.com/repos/amaltaro/WMCore/subscription","commits_url":"https://api.github.com/repos/amaltaro/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/amaltaro/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/amaltaro/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/amaltaro/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/amaltaro/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/amaltaro/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amaltaro/WMCore/merges","archive_url":"https://api.github.com/repos/amaltaro/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amaltaro/WMCore/downloads","issues_url":"https://api.github.com/repos/amaltaro/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/amaltaro/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/amaltaro/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/amaltaro/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amaltaro/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/amaltaro/WMCore/releases{/id}","deployments_url":"https://api.github.com/repos/amaltaro/WMCore/deployments","created_at":"2014-05-21T13:56:20Z","updated_at":"2016-02-08T17:15:36Z","pushed_at":"2016-08-30T21:01:46Z","git_url":"git://github.com/amaltaro/WMCore.git","ssh_url":"git@github.com:amaltaro/WMCore.git","clone_url":"https://github.com/amaltaro/WMCore.git","svn_url":"https://github.com/amaltaro/WMCore","homepage":"https://svnweb.cern.ch/trac/CMSDMWM/","size":28671,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dmwm:master","ref":"master","sha":"c79d64289a4815543b20893ce7b7d4d0ac34c5c3","user":{"login":"dmwm","id":988897,"avatar_url":"https://avatars.githubusercontent.com/u/988897?v=3","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"repo":{"id":2370458,"name":"WMCore","full_name":"dmwm/WMCore","owner":{"login":"dmwm","id":988897,"avatar_url":"https://avatars.githubusercontent.com/u/988897?v=3","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmwm/WMCore","description":"WMCore","fork":false,"url":"https://api.github.com/repos/dmwm/WMCore","forks_url":"https://api.github.com/repos/dmwm/WMCore/forks","keys_url":"https://api.github.com/repos/dmwm/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmwm/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmwm/WMCore/teams","hooks_url":"https://api.github.com/repos/dmwm/WMCore/hooks","issue_events_url":"https://api.github.com/repos/dmwm/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/dmwm/WMCore/events","assignees_url":"https://api.github.com/repos/dmwm/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/dmwm/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/dmwm/WMCore/tags","blobs_url":"https://api.github.com/repos/dmwm/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmwm/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmwm/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmwm/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dmwm/WMCore/languages","stargazers_url":"https://api.github.com/repos/dmwm/WMCore/stargazers","contributors_url":"https://api.github.com/repos/dmwm/WMCore/contributors","subscribers_url":"https://api.github.com/repos/dmwm/WMCore/subscribers","subscription_url":"https://api.github.com/repos/dmwm/WMCore/subscription","commits_url":"https://api.github.com/repos/dmwm/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmwm/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmwm/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmwm/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmwm/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/dmwm/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmwm/WMCore/merges","archive_url":"https://api.github.com/repos/dmwm/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmwm/WMCore/downloads","issues_url":"https://api.github.com/repos/dmwm/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/dmwm/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dmwm/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dmwm/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmwm/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/dmwm/WMCore/releases{/id}","deployments_url":"https://api.github.com/repos/dmwm/WMCore/deployments","created_at":"2011-09-12T10:37:21Z","updated_at":"2016-08-22T14:35:43Z","pushed_at":"2016-08-31T03:04:54Z","git_url":"git://github.com/dmwm/WMCore.git","ssh_url":"git@github.com:dmwm/WMCore.git","clone_url":"https://github.com/dmwm/WMCore.git","svn_url":"https://github.com/dmwm/WMCore","homepage":"https://svnweb.cern.ch/trac/CMSDMWM/","size":35357,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":431,"forks":57,"open_issues":431,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/7130"},"html":{"href":"https://github.com/dmwm/WMCore/pull/7130"},"issue":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/7130"},"comments":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/7130/comments"},"review_comments":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/7130/comments"},"review_comment":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/7130/commits"},"statuses":{"href":"https://api.github.com/repos/dmwm/WMCore/statuses/6b9e8efb26ff132c896f6b85b7fdb2360696d54b"}}}}
{"actor":{"display_login":"amaltaro"}}