{"action":"created","issue":{"url":"https://api.github.com/repos/adobe/brackets/issues/12442","repository_url":"https://api.github.com/repos/adobe/brackets","labels_url":"https://api.github.com/repos/adobe/brackets/issues/12442/labels{/name}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/12442/comments","events_url":"https://api.github.com/repos/adobe/brackets/issues/12442/events","html_url":"https://github.com/adobe/brackets/pull/12442","id":156124385,"number":12442,"title":"Multiline regular expression selection support","user":{"login":"dakaraphi","id":10656375,"avatar_url":"https://avatars.githubusercontent.com/u/10656375?v=3","gravatar_id":"","url":"https://api.github.com/users/dakaraphi","html_url":"https://github.com/dakaraphi","followers_url":"https://api.github.com/users/dakaraphi/followers","following_url":"https://api.github.com/users/dakaraphi/following{/other_user}","gists_url":"https://api.github.com/users/dakaraphi/gists{/gist_id}","starred_url":"https://api.github.com/users/dakaraphi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakaraphi/subscriptions","organizations_url":"https://api.github.com/users/dakaraphi/orgs","repos_url":"https://api.github.com/users/dakaraphi/repos","events_url":"https://api.github.com/users/dakaraphi/events{/privacy}","received_events_url":"https://api.github.com/users/dakaraphi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-21T22:23:03Z","updated_at":"2016-05-27T08:24:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/12442","html_url":"https://github.com/adobe/brackets/pull/12442","diff_url":"https://github.com/adobe/brackets/pull/12442.diff","patch_url":"https://github.com/adobe/brackets/pull/12442.patch"},"body":"#12281\r\n\r\nThis change is a new implementation of the search cursor which can support multi line regular expression selections.\r\n**Notable changes:**\r\n\r\n1. Multi line selections are now supported\r\n1. The search cursor scans the entire document at once vs. the old implementation which was line by line.\r\n1. The new search cursor can be used by other extensions that wish to take advantage of the performance of using the internal document line index.\r\n1. Performance improvements\r\n      1. A copy of the entire document is no longer created for every key press when typing in the search box.\r\n      1. Next and previous navigation is much faster as it now just uses the cached locations.\r\n      1. Performance is no longer strongly related to document size.  It is now more related to the number of matches.\r\n      1. For comparison, previous implementation would take 6 sec for 3 million matches.  The new implementation can find 3 million matches in less than 300 ms.\r\n      1. Increased the highlight limit to 10000 from 2000 as it seems we can now hightlight a greater number within the same time.\r\n1. Considerations\r\n      1. Although performance is faster in most use cases, there is a trade off for very large numbers of matches.  So with a very large document, using \".\" to match everything can create a pause on typing.  We might want to limit total matches or require more than \".\" to be entered before starting search."},"comment":{"url":"https://api.github.com/repos/adobe/brackets/issues/comments/222089314","html_url":"https://github.com/adobe/brackets/pull/12442#issuecomment-222089314","issue_url":"https://api.github.com/repos/adobe/brackets/issues/12442","id":222089314,"user":{"login":"nethip","id":1577184,"avatar_url":"https://avatars.githubusercontent.com/u/1577184?v=3","gravatar_id":"","url":"https://api.github.com/users/nethip","html_url":"https://github.com/nethip","followers_url":"https://api.github.com/users/nethip/followers","following_url":"https://api.github.com/users/nethip/following{/other_user}","gists_url":"https://api.github.com/users/nethip/gists{/gist_id}","starred_url":"https://api.github.com/users/nethip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nethip/subscriptions","organizations_url":"https://api.github.com/users/nethip/orgs","repos_url":"https://api.github.com/users/nethip/repos","events_url":"https://api.github.com/users/nethip/events{/privacy}","received_events_url":"https://api.github.com/users/nethip/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T08:24:19Z","updated_at":"2016-05-27T08:24:19Z","body":"Awesome!"}}
{"actor":{"display_login":"nethip"}}