{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51827751","id":51827751,"diff_hunk":"@@ -0,0 +1,288 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+#include \"pal_types.h\"\n+#include \"pal_utilities.h\"\n+#include \"pal_gssapi.h\"\n+\n+#if HAVE_GSSFW_HEADERS\n+#include <GSS/GSS.h>\n+#else\n+#include <gssapi/gssapi_ext.h>\n+#include <gssapi/gssapi_krb5.h>\n+#endif\n+\n+#include <assert.h>\n+#include <string.h>\n+\n+static_assert(PAL_GSS_C_DELEG_FLAG == GSS_C_DELEG_FLAG, \"\");\n+static_assert(PAL_GSS_C_MUTUAL_FLAG == GSS_C_MUTUAL_FLAG, \"\");\n+static_assert(PAL_GSS_C_REPLAY_FLAG == GSS_C_REPLAY_FLAG, \"\");\n+static_assert(PAL_GSS_C_SEQUENCE_FLAG == GSS_C_SEQUENCE_FLAG, \"\");\n+static_assert(PAL_GSS_C_CONF_FLAG == GSS_C_CONF_FLAG, \"\");\n+static_assert(PAL_GSS_C_INTEG_FLAG == GSS_C_INTEG_FLAG, \"\");\n+static_assert(PAL_GSS_C_ANON_FLAG == GSS_C_ANON_FLAG, \"\");\n+static_assert(PAL_GSS_C_PROT_READY_FLAG == GSS_C_PROT_READY_FLAG, \"\");\n+static_assert(PAL_GSS_C_TRANS_FLAG == GSS_C_TRANS_FLAG, \"\");\n+static_assert(PAL_GSS_C_DCE_STYLE == GSS_C_DCE_STYLE, \"\");\n+static_assert(PAL_GSS_C_IDENTIFY_FLAG == GSS_C_IDENTIFY_FLAG, \"\");\n+static_assert(PAL_GSS_C_EXTENDED_ERROR_FLAG == GSS_C_EXTENDED_ERROR_FLAG, \"\");\n+static_assert(PAL_GSS_C_DELEG_POLICY_FLAG == GSS_C_DELEG_POLICY_FLAG, \"\");\n+\n+static_assert(PAL_GSS_COMPLETE == GSS_S_COMPLETE, \"\");\n+static_assert(PAL_GSS_CONTINUE_NEEDED == GSS_S_CONTINUE_NEEDED, \"\");\n+\n+#if !HAVE_GSS_SPNEGO_MECHANISM\n+static char gss_mech_value[] = \"\\x2b\\x06\\x01\\x05\\x05\\x02\"; // Binary representation of SPNEGO Oid (RFC 4178)\n+#endif\n+\n+static uint32_t NetSecurityNative_HandleError(uint32_t majorStatus,\n+                                              gss_buffer_t gssBuffer,\n+                                              struct PAL_GssBuffer *targetBuffer)\n+{\n+    assert(targetBuffer != nullptr);\n+    assert(gssBuffer != nullptr);\n+    if (GSS_ERROR(majorStatus))\n+    {\n+        assert (gssBuffer->value == nullptr);\n+        targetBuffer->length = 0;\n+        targetBuffer->data = nullptr;\n+        return majorStatus;","path":"src/Native/System.Net.Security.Native/pal_gssapi.cpp","position":51,"original_position":51,"commit_id":"1037ba5a29a923809da78de1e140c046fca2446c","original_commit_id":"1037ba5a29a923809da78de1e140c046fca2446c","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Nit: you can remove this return statement and then have the next two lines just be in an else block.","created_at":"2016-02-04T04:18:06Z","updated_at":"2016-02-04T04:18:06Z","html_url":"https://github.com/dotnet/corefx/pull/5774#discussion_r51827751","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/5774","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51827751"},"html":{"href":"https://github.com/dotnet/corefx/pull/5774#discussion_r51827751"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5774"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/5774","id":57637799,"html_url":"https://github.com/dotnet/corefx/pull/5774","diff_url":"https://github.com/dotnet/corefx/pull/5774.diff","patch_url":"https://github.com/dotnet/corefx/pull/5774.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5774","number":5774,"state":"open","locked":false,"title":"Introducing native shims for libgssapi in order to support NegotiateStream","user":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"body":"Introducing native shims for libgssapi in order to support NegotiateStream\r\n\r\n","created_at":"2016-01-29T11:45:49Z","updated_at":"2016-02-04T04:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0ccf5728548a36df1dd665b38a01db5ffef64c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/5774/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/5774/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5774/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/1037ba5a29a923809da78de1e140c046fca2446c","head":{"label":"kapilash:devnegostream","ref":"devnegostream","sha":"1037ba5a29a923809da78de1e140c046fca2446c","user":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"repo":{"id":32931025,"name":"corefx","full_name":"kapilash/corefx","owner":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kapilash/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/kapilash/corefx","forks_url":"https://api.github.com/repos/kapilash/corefx/forks","keys_url":"https://api.github.com/repos/kapilash/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapilash/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapilash/corefx/teams","hooks_url":"https://api.github.com/repos/kapilash/corefx/hooks","issue_events_url":"https://api.github.com/repos/kapilash/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/kapilash/corefx/events","assignees_url":"https://api.github.com/repos/kapilash/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/kapilash/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/kapilash/corefx/tags","blobs_url":"https://api.github.com/repos/kapilash/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapilash/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapilash/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapilash/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapilash/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/kapilash/corefx/languages","stargazers_url":"https://api.github.com/repos/kapilash/corefx/stargazers","contributors_url":"https://api.github.com/repos/kapilash/corefx/contributors","subscribers_url":"https://api.github.com/repos/kapilash/corefx/subscribers","subscription_url":"https://api.github.com/repos/kapilash/corefx/subscription","commits_url":"https://api.github.com/repos/kapilash/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapilash/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapilash/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapilash/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kapilash/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/kapilash/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapilash/corefx/merges","archive_url":"https://api.github.com/repos/kapilash/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapilash/corefx/downloads","issues_url":"https://api.github.com/repos/kapilash/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/kapilash/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/kapilash/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/kapilash/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapilash/corefx/labels{/name}","releases_url":"https://api.github.com/repos/kapilash/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/kapilash/corefx/deployments","created_at":"2015-03-26T14:08:29Z","updated_at":"2016-01-11T04:01:08Z","pushed_at":"2016-02-03T17:26:32Z","git_url":"git://github.com/kapilash/corefx.git","ssh_url":"git@github.com:kapilash/corefx.git","clone_url":"https://github.com/kapilash/corefx.git","svn_url":"https://github.com/kapilash/corefx","homepage":"","size":51349,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/negotiatestream","ref":"dev/negotiatestream","sha":"e0e94b1d4ac854b0dd1ef3725d8492bcfa0229c9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-04T03:30:34Z","pushed_at":"2016-02-04T02:35:32Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":61464,"stargazers_count":9074,"watchers_count":9074,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2105,"mirror_url":null,"open_issues_count":813,"forks":2105,"open_issues":813,"watchers":9074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5774"},"html":{"href":"https://github.com/dotnet/corefx/pull/5774"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5774"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5774/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5774/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5774/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/1037ba5a29a923809da78de1e140c046fca2446c"}}}}