{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/62029632","id":62029632,"diff_hunk":"@@ -128,6 +128,15 @@ class NavigationCardStack extends React.Component<DefaultProps, Props, void> {\n \n   _renderScene(props: NavigationSceneRendererProps): ReactElement {\n     const isVertical = this.props.direction === 'vertical';\n+    const { navigationState } = this.props;\n+\n+    // if the scene is stale and has the same index than\n+    // current navigation state index, the navigation card\n+    // shouldn't be rendered\n+    if(props.scene.isStale && props.scene.index === navigationState.index)\n+    {\n+      return null;","path":"Libraries/CustomComponents/NavigationExperimental/NavigationCardStack.js","position":11,"original_position":11,"commit_id":"b7aba2253f5f64912839aa56154c1a0d9edca448","original_commit_id":"b7aba2253f5f64912839aa56154c1a0d9edca448","user":{"login":"eslint-bot","id":16061708,"avatar_url":"https://avatars.githubusercontent.com/u/16061708?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint-bot","html_url":"https://github.com/eslint-bot","followers_url":"https://api.github.com/users/eslint-bot/followers","following_url":"https://api.github.com/users/eslint-bot/following{/other_user}","gists_url":"https://api.github.com/users/eslint-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint-bot/subscriptions","organizations_url":"https://api.github.com/users/eslint-bot/orgs","repos_url":"https://api.github.com/users/eslint-bot/repos","events_url":"https://api.github.com/users/eslint-bot/events{/privacy}","received_events_url":"https://api.github.com/users/eslint-bot/received_events","type":"User","site_admin":false},"body":"null This type is incompatible with React$Element","created_at":"2016-05-04T12:26:23Z","updated_at":"2016-05-04T12:26:23Z","html_url":"https://github.com/facebook/react-native/pull/7383#discussion_r62029632","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/7383","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/62029632"},"html":{"href":"https://github.com/facebook/react-native/pull/7383#discussion_r62029632"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7383"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7383","id":68852168,"html_url":"https://github.com/facebook/react-native/pull/7383","diff_url":"https://github.com/facebook/react-native/pull/7383.diff","patch_url":"https://github.com/facebook/react-native/pull/7383.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7383","number":7383,"state":"open","locked":false,"title":"don't render stale scenes that have the same index than current navigationState","user":{"login":"formatlos","id":214001,"avatar_url":"https://avatars.githubusercontent.com/u/214001?v=3","gravatar_id":"","url":"https://api.github.com/users/formatlos","html_url":"https://github.com/formatlos","followers_url":"https://api.github.com/users/formatlos/followers","following_url":"https://api.github.com/users/formatlos/following{/other_user}","gists_url":"https://api.github.com/users/formatlos/gists{/gist_id}","starred_url":"https://api.github.com/users/formatlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formatlos/subscriptions","organizations_url":"https://api.github.com/users/formatlos/orgs","repos_url":"https://api.github.com/users/formatlos/repos","events_url":"https://api.github.com/users/formatlos/events{/privacy}","received_events_url":"https://api.github.com/users/formatlos/received_events","type":"User","site_admin":false},"body":"NavigationCardStack renders the NavigationCard for the current scene even if the scene is stale and has the same index than current navigationState. \r\n\r\nIn practice that means that when resetting the navigationState to a previous state, it renders the stale NavigationCard above the actual NavigationCard. \r\n\r\nExample: \r\n\r\n```javascript\r\n// initial navigationState\r\nnavState = {\r\n\tindex: 0,\r\n\tchildren: [\r\n\t\t{ key: 'First'}\r\n\t]\r\n}\r\n\r\n// reset\r\nnavState = {\r\n\tindex: 0,\r\n\tchildren: [\r\n\t\t{ key: 'Second' }\r\n\t]\r\n}\r\n\r\n// reset\r\n\r\nnavState = {\r\n\tindex: 0,\r\n\tchildren: [\r\n\t\t{ key: 'First'}\r\n\t]\r\n}\r\n\r\n```","created_at":"2016-05-04T12:16:58Z","updated_at":"2016-05-04T12:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2854c150c1091ddfb4708516809a6327600678f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/7383/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/7383/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7383/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/b7aba2253f5f64912839aa56154c1a0d9edca448","head":{"label":"formatlos:feature/navigation-card-stack-reset","ref":"feature/navigation-card-stack-reset","sha":"b7aba2253f5f64912839aa56154c1a0d9edca448","user":{"login":"formatlos","id":214001,"avatar_url":"https://avatars.githubusercontent.com/u/214001?v=3","gravatar_id":"","url":"https://api.github.com/users/formatlos","html_url":"https://github.com/formatlos","followers_url":"https://api.github.com/users/formatlos/followers","following_url":"https://api.github.com/users/formatlos/following{/other_user}","gists_url":"https://api.github.com/users/formatlos/gists{/gist_id}","starred_url":"https://api.github.com/users/formatlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formatlos/subscriptions","organizations_url":"https://api.github.com/users/formatlos/orgs","repos_url":"https://api.github.com/users/formatlos/repos","events_url":"https://api.github.com/users/formatlos/events{/privacy}","received_events_url":"https://api.github.com/users/formatlos/received_events","type":"User","site_admin":false},"repo":{"id":55777457,"name":"react-native","full_name":"formatlos/react-native","owner":{"login":"formatlos","id":214001,"avatar_url":"https://avatars.githubusercontent.com/u/214001?v=3","gravatar_id":"","url":"https://api.github.com/users/formatlos","html_url":"https://github.com/formatlos","followers_url":"https://api.github.com/users/formatlos/followers","following_url":"https://api.github.com/users/formatlos/following{/other_user}","gists_url":"https://api.github.com/users/formatlos/gists{/gist_id}","starred_url":"https://api.github.com/users/formatlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formatlos/subscriptions","organizations_url":"https://api.github.com/users/formatlos/orgs","repos_url":"https://api.github.com/users/formatlos/repos","events_url":"https://api.github.com/users/formatlos/events{/privacy}","received_events_url":"https://api.github.com/users/formatlos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/formatlos/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/formatlos/react-native","forks_url":"https://api.github.com/repos/formatlos/react-native/forks","keys_url":"https://api.github.com/repos/formatlos/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/formatlos/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/formatlos/react-native/teams","hooks_url":"https://api.github.com/repos/formatlos/react-native/hooks","issue_events_url":"https://api.github.com/repos/formatlos/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/formatlos/react-native/events","assignees_url":"https://api.github.com/repos/formatlos/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/formatlos/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/formatlos/react-native/tags","blobs_url":"https://api.github.com/repos/formatlos/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/formatlos/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/formatlos/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/formatlos/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/formatlos/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/formatlos/react-native/languages","stargazers_url":"https://api.github.com/repos/formatlos/react-native/stargazers","contributors_url":"https://api.github.com/repos/formatlos/react-native/contributors","subscribers_url":"https://api.github.com/repos/formatlos/react-native/subscribers","subscription_url":"https://api.github.com/repos/formatlos/react-native/subscription","commits_url":"https://api.github.com/repos/formatlos/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/formatlos/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/formatlos/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/formatlos/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/formatlos/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/formatlos/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/formatlos/react-native/merges","archive_url":"https://api.github.com/repos/formatlos/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/formatlos/react-native/downloads","issues_url":"https://api.github.com/repos/formatlos/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/formatlos/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/formatlos/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/formatlos/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/formatlos/react-native/labels{/name}","releases_url":"https://api.github.com/repos/formatlos/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/formatlos/react-native/deployments","created_at":"2016-04-08T12:30:22Z","updated_at":"2016-05-04T11:54:42Z","pushed_at":"2016-05-04T12:06:20Z","git_url":"git://github.com/formatlos/react-native.git","ssh_url":"git@github.com:formatlos/react-native.git","clone_url":"https://github.com/formatlos/react-native.git","svn_url":"https://github.com/formatlos/react-native","homepage":"http://facebook.github.io/react-native/","size":55449,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"46d98e1d688890b18445b9fe7e9d208f4ea6c758","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-05-04T12:01:47Z","pushed_at":"2016-05-04T12:19:53Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":96049,"stargazers_count":31653,"watchers_count":31653,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6348,"mirror_url":null,"open_issues_count":729,"forks":6348,"open_issues":729,"watchers":31653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7383"},"html":{"href":"https://github.com/facebook/react-native/pull/7383"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/7383"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/7383/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7383/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7383/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/b7aba2253f5f64912839aa56154c1a0d9edca448"}}}}