{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/86547067","pull_request_review_id":7201471,"id":86547067,"diff_hunk":"@@ -435,6 +433,11 @@ int mount_all(const char *dest,\n                                 o = options;\n                 }\n \n+                if (streq_ptr(mount_table[k].where, \"/sys/fs/selinux\") && is_dir(\"/sys/fs/selinux\", true) < 0) {\n+                        log_debug(\"SELINUX not active, skipping selinux mounts.\");\n+                        continue;\n+                }","path":"src/nspawn/nspawn-mount.c","position":18,"original_position":18,"commit_id":"700826b9b859e06acfde54d7c0ae90fcc1a5a075","original_commit_id":"700826b9b859e06acfde54d7c0ae90fcc1a5a075","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"well, depends. I'd downgrade it to LOG_DEBUG if \"fatal\" is set to false for the entry. @keszybz opinions?","created_at":"2016-11-04T13:43:31Z","updated_at":"2016-11-04T13:43:31Z","html_url":"https://github.com/systemd/systemd/pull/4569#discussion_r86547067","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/4569","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/86547067"},"html":{"href":"https://github.com/systemd/systemd/pull/4569#discussion_r86547067"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4569"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4569","id":92327198,"html_url":"https://github.com/systemd/systemd/pull/4569","diff_url":"https://github.com/systemd/systemd/pull/4569.diff","patch_url":"https://github.com/systemd/systemd/pull/4569.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4569","number":4569,"state":"open","locked":false,"title":"systemd-nspawn: dont try to mount non existing selinux directories","user":{"login":"tblume","id":6848570,"avatar_url":"https://avatars.githubusercontent.com/u/6848570?v=3","gravatar_id":"","url":"https://api.github.com/users/tblume","html_url":"https://github.com/tblume","followers_url":"https://api.github.com/users/tblume/followers","following_url":"https://api.github.com/users/tblume/following{/other_user}","gists_url":"https://api.github.com/users/tblume/gists{/gist_id}","starred_url":"https://api.github.com/users/tblume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tblume/subscriptions","organizations_url":"https://api.github.com/users/tblume/orgs","repos_url":"https://api.github.com/users/tblume/repos","events_url":"https://api.github.com/users/tblume/events{/privacy}","received_events_url":"https://api.github.com/users/tblume/received_events","type":"User","site_admin":false},"body":"The #ifdef HAVE_SELINUX is not sufficient to cover the case when selinux is shipped\r\nbut not installed or not activated.\r\nSuggesting to replace the ifdef by a check whether /sys/fs/selinux is present.\r\nThis avoids unnecessary error messages from failing mounts.","created_at":"2016-11-04T11:56:46Z","updated_at":"2016-11-04T13:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b35d0fd1404c8d833d7b28ce0ffb62c5f43b253d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/4569/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/4569/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4569/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/700826b9b859e06acfde54d7c0ae90fcc1a5a075","head":{"label":"tblume:systemd-nspawn-mount-error2","ref":"systemd-nspawn-mount-error2","sha":"700826b9b859e06acfde54d7c0ae90fcc1a5a075","user":{"login":"tblume","id":6848570,"avatar_url":"https://avatars.githubusercontent.com/u/6848570?v=3","gravatar_id":"","url":"https://api.github.com/users/tblume","html_url":"https://github.com/tblume","followers_url":"https://api.github.com/users/tblume/followers","following_url":"https://api.github.com/users/tblume/following{/other_user}","gists_url":"https://api.github.com/users/tblume/gists{/gist_id}","starred_url":"https://api.github.com/users/tblume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tblume/subscriptions","organizations_url":"https://api.github.com/users/tblume/orgs","repos_url":"https://api.github.com/users/tblume/repos","events_url":"https://api.github.com/users/tblume/events{/privacy}","received_events_url":"https://api.github.com/users/tblume/received_events","type":"User","site_admin":false},"repo":{"id":40581947,"name":"systemd-upstream","full_name":"tblume/systemd-upstream","owner":{"login":"tblume","id":6848570,"avatar_url":"https://avatars.githubusercontent.com/u/6848570?v=3","gravatar_id":"","url":"https://api.github.com/users/tblume","html_url":"https://github.com/tblume","followers_url":"https://api.github.com/users/tblume/followers","following_url":"https://api.github.com/users/tblume/following{/other_user}","gists_url":"https://api.github.com/users/tblume/gists{/gist_id}","starred_url":"https://api.github.com/users/tblume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tblume/subscriptions","organizations_url":"https://api.github.com/users/tblume/orgs","repos_url":"https://api.github.com/users/tblume/repos","events_url":"https://api.github.com/users/tblume/events{/privacy}","received_events_url":"https://api.github.com/users/tblume/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tblume/systemd-upstream","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/tblume/systemd-upstream","forks_url":"https://api.github.com/repos/tblume/systemd-upstream/forks","keys_url":"https://api.github.com/repos/tblume/systemd-upstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tblume/systemd-upstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tblume/systemd-upstream/teams","hooks_url":"https://api.github.com/repos/tblume/systemd-upstream/hooks","issue_events_url":"https://api.github.com/repos/tblume/systemd-upstream/issues/events{/number}","events_url":"https://api.github.com/repos/tblume/systemd-upstream/events","assignees_url":"https://api.github.com/repos/tblume/systemd-upstream/assignees{/user}","branches_url":"https://api.github.com/repos/tblume/systemd-upstream/branches{/branch}","tags_url":"https://api.github.com/repos/tblume/systemd-upstream/tags","blobs_url":"https://api.github.com/repos/tblume/systemd-upstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tblume/systemd-upstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tblume/systemd-upstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/tblume/systemd-upstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tblume/systemd-upstream/statuses/{sha}","languages_url":"https://api.github.com/repos/tblume/systemd-upstream/languages","stargazers_url":"https://api.github.com/repos/tblume/systemd-upstream/stargazers","contributors_url":"https://api.github.com/repos/tblume/systemd-upstream/contributors","subscribers_url":"https://api.github.com/repos/tblume/systemd-upstream/subscribers","subscription_url":"https://api.github.com/repos/tblume/systemd-upstream/subscription","commits_url":"https://api.github.com/repos/tblume/systemd-upstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/tblume/systemd-upstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/tblume/systemd-upstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/tblume/systemd-upstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/tblume/systemd-upstream/contents/{+path}","compare_url":"https://api.github.com/repos/tblume/systemd-upstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tblume/systemd-upstream/merges","archive_url":"https://api.github.com/repos/tblume/systemd-upstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tblume/systemd-upstream/downloads","issues_url":"https://api.github.com/repos/tblume/systemd-upstream/issues{/number}","pulls_url":"https://api.github.com/repos/tblume/systemd-upstream/pulls{/number}","milestones_url":"https://api.github.com/repos/tblume/systemd-upstream/milestones{/number}","notifications_url":"https://api.github.com/repos/tblume/systemd-upstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tblume/systemd-upstream/labels{/name}","releases_url":"https://api.github.com/repos/tblume/systemd-upstream/releases{/id}","deployments_url":"https://api.github.com/repos/tblume/systemd-upstream/deployments","created_at":"2015-08-12T05:31:55Z","updated_at":"2016-01-11T14:10:48Z","pushed_at":"2016-11-04T11:49:38Z","git_url":"git://github.com/tblume/systemd-upstream.git","ssh_url":"git@github.com:tblume/systemd-upstream.git","clone_url":"https://github.com/tblume/systemd-upstream.git","svn_url":"https://github.com/tblume/systemd-upstream","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":61704,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"cf88547034d72e0c43e880b89d36643befc54bb9","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-11-04T13:35:47Z","pushed_at":"2016-11-04T13:40:54Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":76710,"stargazers_count":1439,"watchers_count":1439,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":609,"mirror_url":null,"open_issues_count":489,"forks":609,"open_issues":489,"watchers":1439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4569"},"html":{"href":"https://github.com/systemd/systemd/pull/4569"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/4569"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/4569/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4569/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4569/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/700826b9b859e06acfde54d7c0ae90fcc1a5a075"}}}}
{"actor":{"display_login":"poettering"}}