{"action":"created","issue":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/159","repository_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel","labels_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/159/comments","events_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/159/events","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/159","id":191183560,"number":159,"title":"Fix last slides not visible","user":{"login":"mdaxtman","id":8061227,"avatar_url":"https://avatars.githubusercontent.com/u/8061227?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaxtman","html_url":"https://github.com/mdaxtman","followers_url":"https://api.github.com/users/mdaxtman/followers","following_url":"https://api.github.com/users/mdaxtman/following{/other_user}","gists_url":"https://api.github.com/users/mdaxtman/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaxtman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaxtman/subscriptions","organizations_url":"https://api.github.com/users/mdaxtman/orgs","repos_url":"https://api.github.com/users/mdaxtman/repos","events_url":"https://api.github.com/users/mdaxtman/events{/privacy}","received_events_url":"https://api.github.com/users/mdaxtman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-23T03:50:52Z","updated_at":"2016-11-23T16:49:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/pulls/159","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/159","diff_url":"https://github.com/FormidableLabs/nuka-carousel/pull/159.diff","patch_url":"https://github.com/FormidableLabs/nuka-carousel/pull/159.patch"},"body":"@kenwheeler \r\n\r\naddresses #96, and is a more comprehensive fix than #110 will close both once this is merged.\r\n\r\n![nuka](https://cloud.githubusercontent.com/assets/8061227/20550585/1f88a9e2-b0ec-11e6-8c55-4e1ab97eadea.gif)\r\n\r\n- This PR takes into account what new prop `scrollMode` is, and doesn't show empty cells when finished scrolling if that prop is left blank or set to `remainder`.\r\n\r\n- If `slidesToShow` and `slidesToScroll` are not mathematically divisible into each other, this PR ensures that the decorators function correctly to navigate to the last slide in the deck, even if the last slide index < `currentSlide` + n of `slidesToScroll`.\r\n\r\n- `cellAlign` is taken into account so that whitespace is not shown if `scrollMode === \"remainder\"`\r\n\r\n- Navigation through decorators as well as swiping are taken into account with this fix."},"comment":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/comments/262569710","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/159#issuecomment-262569710","issue_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/159","id":262569710,"user":{"login":"gkrinc","id":2718382,"avatar_url":"https://avatars.githubusercontent.com/u/2718382?v=3","gravatar_id":"","url":"https://api.github.com/users/gkrinc","html_url":"https://github.com/gkrinc","followers_url":"https://api.github.com/users/gkrinc/followers","following_url":"https://api.github.com/users/gkrinc/following{/other_user}","gists_url":"https://api.github.com/users/gkrinc/gists{/gist_id}","starred_url":"https://api.github.com/users/gkrinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkrinc/subscriptions","organizations_url":"https://api.github.com/users/gkrinc/orgs","repos_url":"https://api.github.com/users/gkrinc/repos","events_url":"https://api.github.com/users/gkrinc/events{/privacy}","received_events_url":"https://api.github.com/users/gkrinc/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T16:49:46Z","updated_at":"2016-11-23T16:49:46Z","body":"This helped a bit, but I still can't scroll to the last slide. I couldn't get to the last 2 items before, so this is a step in the right direction. \r\n\r\nThese are my settings:\r\n\r\n```\r\nslidesToShow: 3,\r\nslidesToScroll: 1,\r\ncellAlign: 'center',\r\nscrollMode: 'remainder',\r\n```\r\n\r\nTotal slides: 9\r\n\r\nThe 8th slide centers and the 9th is visible on the right, but I can't scroll to the 9th slide.\r\nIs\r\n\r\n"}}
{"actor":{"display_login":"gkrinc"}}