{"action":"created","comment":{"url":"https://api.github.com/repos/trello/navi/pulls/comments/85933920","pull_request_review_id":6618297,"id":85933920,"diff_hunk":"@@ -20,21 +19,25 @@\n     this.event = event;\n   }\n \n-  @Override public void call(final Subscriber<? super T> subscriber) {\n-    final Listener<T> listener = new Listener<T>() {\n-      @Override public void call(@NonNull T t) {\n-        if (!subscriber.isUnsubscribed()) {\n-          subscriber.onNext(t);\n-        }\n-      }\n-    };\n-\n+  @Override public void subscribe(final ObservableEmitter<T> emitter) throws Exception {\n+    EmitterListener<T> listener = new EmitterListener<>(emitter);\n+    emitter.setCancellable(listener);\n     component.addListener(event, listener);\n+  }\n+\n+  private class EmitterListener<T> implements Listener<T>, Cancellable {","path":"navi/src/main/java/com/trello/navi2/rx/NaviOnSubscribe.java","position":null,"original_position":36,"commit_id":"4dc6b9953dcc080cd602fbfbe27bfb874905401c","original_commit_id":"7a9d6d3fc44a91e670c05191abb3589b93992d09","user":{"login":"dlew","id":514850,"avatar_url":"https://avatars.githubusercontent.com/u/514850?v=3","gravatar_id":"","url":"https://api.github.com/users/dlew","html_url":"https://github.com/dlew","followers_url":"https://api.github.com/users/dlew/followers","following_url":"https://api.github.com/users/dlew/following{/other_user}","gists_url":"https://api.github.com/users/dlew/gists{/gist_id}","starred_url":"https://api.github.com/users/dlew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlew/subscriptions","organizations_url":"https://api.github.com/users/dlew/orgs","repos_url":"https://api.github.com/users/dlew/repos","events_url":"https://api.github.com/users/dlew/events{/privacy}","received_events_url":"https://api.github.com/users/dlew/received_events","type":"User","site_admin":false},"body":"Good call.","created_at":"2016-11-01T14:04:51Z","updated_at":"2016-11-01T14:04:51Z","html_url":"https://github.com/trello/navi/pull/77#discussion_r85933920","pull_request_url":"https://api.github.com/repos/trello/navi/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/trello/navi/pulls/comments/85933920"},"html":{"href":"https://github.com/trello/navi/pull/77#discussion_r85933920"},"pull_request":{"href":"https://api.github.com/repos/trello/navi/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/trello/navi/pulls/77","id":91785026,"html_url":"https://github.com/trello/navi/pull/77","diff_url":"https://github.com/trello/navi/pull/77.diff","patch_url":"https://github.com/trello/navi/pull/77.patch","issue_url":"https://api.github.com/repos/trello/navi/issues/77","number":77,"state":"open","locked":false,"title":"Upgrade app to work with RxJava 2","user":{"login":"dlew","id":514850,"avatar_url":"https://avatars.githubusercontent.com/u/514850?v=3","gravatar_id":"","url":"https://api.github.com/users/dlew","html_url":"https://github.com/dlew","followers_url":"https://api.github.com/users/dlew/followers","following_url":"https://api.github.com/users/dlew/following{/other_user}","gists_url":"https://api.github.com/users/dlew/gists{/gist_id}","starred_url":"https://api.github.com/users/dlew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlew/subscriptions","organizations_url":"https://api.github.com/users/dlew/orgs","repos_url":"https://api.github.com/users/dlew/repos","events_url":"https://api.github.com/users/dlew/events{/privacy}","received_events_url":"https://api.github.com/users/dlew/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-01T13:43:17Z","updated_at":"2016-11-01T14:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ec270fd2d4e3b7ef373393ada36571a6e29dbf1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/trello/navi/pulls/77/commits","review_comments_url":"https://api.github.com/repos/trello/navi/pulls/77/comments","review_comment_url":"https://api.github.com/repos/trello/navi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trello/navi/issues/77/comments","statuses_url":"https://api.github.com/repos/trello/navi/statuses/4dc6b9953dcc080cd602fbfbe27bfb874905401c","head":{"label":"trello:dlew/rxjava2","ref":"dlew/rxjava2","sha":"4dc6b9953dcc080cd602fbfbe27bfb874905401c","user":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"repo":{"id":43755261,"name":"navi","full_name":"trello/navi","owner":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trello/navi","description":"Adds listening capabilities to Activities and Fragments","fork":false,"url":"https://api.github.com/repos/trello/navi","forks_url":"https://api.github.com/repos/trello/navi/forks","keys_url":"https://api.github.com/repos/trello/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trello/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trello/navi/teams","hooks_url":"https://api.github.com/repos/trello/navi/hooks","issue_events_url":"https://api.github.com/repos/trello/navi/issues/events{/number}","events_url":"https://api.github.com/repos/trello/navi/events","assignees_url":"https://api.github.com/repos/trello/navi/assignees{/user}","branches_url":"https://api.github.com/repos/trello/navi/branches{/branch}","tags_url":"https://api.github.com/repos/trello/navi/tags","blobs_url":"https://api.github.com/repos/trello/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trello/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trello/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/trello/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trello/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/trello/navi/languages","stargazers_url":"https://api.github.com/repos/trello/navi/stargazers","contributors_url":"https://api.github.com/repos/trello/navi/contributors","subscribers_url":"https://api.github.com/repos/trello/navi/subscribers","subscription_url":"https://api.github.com/repos/trello/navi/subscription","commits_url":"https://api.github.com/repos/trello/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/trello/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/trello/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/trello/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/trello/navi/contents/{+path}","compare_url":"https://api.github.com/repos/trello/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trello/navi/merges","archive_url":"https://api.github.com/repos/trello/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trello/navi/downloads","issues_url":"https://api.github.com/repos/trello/navi/issues{/number}","pulls_url":"https://api.github.com/repos/trello/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/trello/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/trello/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trello/navi/labels{/name}","releases_url":"https://api.github.com/repos/trello/navi/releases{/id}","deployments_url":"https://api.github.com/repos/trello/navi/deployments","created_at":"2015-10-06T14:17:51Z","updated_at":"2016-11-01T13:28:35Z","pushed_at":"2016-11-01T14:04:48Z","git_url":"git://github.com/trello/navi.git","ssh_url":"git@github.com:trello/navi.git","clone_url":"https://github.com/trello/navi.git","svn_url":"https://github.com/trello/navi","homepage":null,"size":379,"stargazers_count":477,"watchers_count":477,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":477,"default_branch":"1.x"}},"base":{"label":"trello:2.x","ref":"2.x","sha":"25429edcbe470a02cfe38756439e9a2be1bff56b","user":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"repo":{"id":43755261,"name":"navi","full_name":"trello/navi","owner":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trello/navi","description":"Adds listening capabilities to Activities and Fragments","fork":false,"url":"https://api.github.com/repos/trello/navi","forks_url":"https://api.github.com/repos/trello/navi/forks","keys_url":"https://api.github.com/repos/trello/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trello/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trello/navi/teams","hooks_url":"https://api.github.com/repos/trello/navi/hooks","issue_events_url":"https://api.github.com/repos/trello/navi/issues/events{/number}","events_url":"https://api.github.com/repos/trello/navi/events","assignees_url":"https://api.github.com/repos/trello/navi/assignees{/user}","branches_url":"https://api.github.com/repos/trello/navi/branches{/branch}","tags_url":"https://api.github.com/repos/trello/navi/tags","blobs_url":"https://api.github.com/repos/trello/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trello/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trello/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/trello/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trello/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/trello/navi/languages","stargazers_url":"https://api.github.com/repos/trello/navi/stargazers","contributors_url":"https://api.github.com/repos/trello/navi/contributors","subscribers_url":"https://api.github.com/repos/trello/navi/subscribers","subscription_url":"https://api.github.com/repos/trello/navi/subscription","commits_url":"https://api.github.com/repos/trello/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/trello/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/trello/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/trello/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/trello/navi/contents/{+path}","compare_url":"https://api.github.com/repos/trello/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trello/navi/merges","archive_url":"https://api.github.com/repos/trello/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trello/navi/downloads","issues_url":"https://api.github.com/repos/trello/navi/issues{/number}","pulls_url":"https://api.github.com/repos/trello/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/trello/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/trello/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trello/navi/labels{/name}","releases_url":"https://api.github.com/repos/trello/navi/releases{/id}","deployments_url":"https://api.github.com/repos/trello/navi/deployments","created_at":"2015-10-06T14:17:51Z","updated_at":"2016-11-01T13:28:35Z","pushed_at":"2016-11-01T14:04:48Z","git_url":"git://github.com/trello/navi.git","ssh_url":"git@github.com:trello/navi.git","clone_url":"https://github.com/trello/navi.git","svn_url":"https://github.com/trello/navi","homepage":null,"size":379,"stargazers_count":477,"watchers_count":477,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":477,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/trello/navi/pulls/77"},"html":{"href":"https://github.com/trello/navi/pull/77"},"issue":{"href":"https://api.github.com/repos/trello/navi/issues/77"},"comments":{"href":"https://api.github.com/repos/trello/navi/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/trello/navi/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/trello/navi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trello/navi/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/trello/navi/statuses/4dc6b9953dcc080cd602fbfbe27bfb874905401c"}}}}
{"actor":{"display_login":"dlew"}}