{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/1436","repository_url":"https://api.github.com/repos/minetest/minetest_game","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/1436/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/1436/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/1436/events","html_url":"https://github.com/minetest/minetest_game/pull/1436","id":193266940,"number":1436,"title":"Fire: Rewrite fire sound code","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"labels":[{"id":344564648,"url":"https://api.github.com/repos/minetest/minetest_game/labels/Sounds","name":"Sounds","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/minetest/minetest_game/milestones/2","html_url":"https://github.com/minetest/minetest_game/milestones/0.4.15","labels_url":"https://api.github.com/repos/minetest/minetest_game/milestones/2/labels","id":1898060,"number":2,"title":"0.4.15","description":"","creator":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":49,"state":"open","created_at":"2016-07-22T03:36:21Z","updated_at":"2016-12-04T07:00:48Z","due_on":"2016-12-21T00:00:00Z","closed_at":null},"comments":6,"created_at":"2016-12-03T05:24:01Z","updated_at":"2016-12-04T21:17:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/1436","html_url":"https://github.com/minetest/minetest_game/pull/1436","diff_url":"https://github.com/minetest/minetest_game/pull/1436.diff","patch_url":"https://github.com/minetest/minetest_game/pull/1436.patch"},"body":"Previous code:\r\nUsed looped sounds without attaching them to objects or playing direct\r\nto players. This may be causing a bug where sounds are heard at extreme\r\ndistance.\r\nEntering a world with already present flames results in silent flames.\r\nSounds are often played at a large number of points in a 6 node lattice.\r\n\r\nNew code:\r\nCreated with github member BluebirdGreycoat.\r\nPermanent flame now has sound.\r\nA regular update cycle for players, plus instant updates on flame\r\n'construct' or 'destruct' for nearby players.\r\nFor multiple flames, sound is positioned roughly near the centre of all\r\nflames, and has volume determined by flame number.\r\nThe original freesound 'large fire' recording was used to create 3 sounds\r\nthat play at random for a non-repetitive effect. At low volume it is\r\nsuitable for small fires.\r\n////////////////////////////////////////////////////\r\n\r\nSee #1112 and #1385 for discussion.\r\nThe existing sound code has serious problems and bugs so must be removed for release.\r\nWIP, fire sounds should perhaps be made optional?"},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/264731889","html_url":"https://github.com/minetest/minetest_game/pull/1436#issuecomment-264731889","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/1436","id":264731889,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T21:17:09Z","updated_at":"2016-12-04T21:17:09Z","body":"Everything you mention is for a reason, these becomes clear once you work on this, i'll try to explain soon. The reaction time we discussed before, it's a balance against the constant load of searching around players, it's less critical now because any add or remove of flames causes an instant update."}}
{"actor":{"display_login":"paramat"}}