{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/13960","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/13960/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/13960/comments","events_url":"https://api.github.com/repos/apache/spark/issues/13960/events","html_url":"https://github.com/apache/spark/pull/13960","id":162823250,"number":13960,"title":"[SQL] Support null handling for vectorized hashmap during hash aggregate","user":{"login":"ooq","id":5876435,"avatar_url":"https://avatars.githubusercontent.com/u/5876435?v=3","gravatar_id":"","url":"https://api.github.com/users/ooq","html_url":"https://github.com/ooq","followers_url":"https://api.github.com/users/ooq/followers","following_url":"https://api.github.com/users/ooq/following{/other_user}","gists_url":"https://api.github.com/users/ooq/gists{/gist_id}","starred_url":"https://api.github.com/users/ooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooq/subscriptions","organizations_url":"https://api.github.com/users/ooq/orgs","repos_url":"https://api.github.com/users/ooq/repos","events_url":"https://api.github.com/users/ooq/events{/privacy}","received_events_url":"https://api.github.com/users/ooq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-29T01:36:33Z","updated_at":"2016-06-29T01:38:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13960","html_url":"https://github.com/apache/spark/pull/13960","diff_url":"https://github.com/apache/spark/pull/13960.diff","patch_url":"https://github.com/apache/spark/pull/13960.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThe current impl of vectorized hashmap does not support null keys. This patch fix the problem by adding `generateFindOrInsertWithNullable()` method in `VectorizedHashMapGenerator.scala`, which code-generates another version of `findOrInsert` that handles null keys. \r\n\r\nWe need null support so the aggregate logic does not have to fallback to BytesToBytesMap. This would also us to remove BytesToBytesMap completely.\r\n\r\n## How was this patch tested?\r\n\r\nNo additional test is added. A simple benchmark test is included to show the performance gain.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/229233405","html_url":"https://github.com/apache/spark/pull/13960#issuecomment-229233405","issue_url":"https://api.github.com/repos/apache/spark/issues/13960","id":229233405,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T01:38:59Z","updated_at":"2016-06-29T01:38:59Z","body":"Test FAILed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61430/\nTest FAILed."}}
{"actor":{"display_login":"AmplabJenkins"}}