{"action":"created","comment":{"url":"https://api.github.com/repos/google/flexbox-layout/pulls/comments/81100596","pull_request_review_id":2104721,"id":81100596,"diff_hunk":"@@ -238,4 +238,24 @@\n      * @param flexBasisPercent the order attribute\n      */\n     void setFlexBasisPercent(float flexBasisPercent);\n+\n+    /**\n+     * @return the left margin of the flex item.\n+     */\n+    int getLeftMargin();\n+\n+    /**\n+     * @return the top margin of the flex item.\n+     */\n+    int getTopMargin();","path":"flexbox/src/main/java/com/google/android/flexbox/FlexItem.java","position":null,"original_position":13,"commit_id":"4c10de3a868759908d3408d2db3966cb27aef884","original_commit_id":"4c308a2d1790b179e36937a70ead73853c2092c7","user":{"login":"thagikura","id":796361,"avatar_url":"https://avatars.githubusercontent.com/u/796361?v=3","gravatar_id":"","url":"https://api.github.com/users/thagikura","html_url":"https://github.com/thagikura","followers_url":"https://api.github.com/users/thagikura/followers","following_url":"https://api.github.com/users/thagikura/following{/other_user}","gists_url":"https://api.github.com/users/thagikura/gists{/gist_id}","starred_url":"https://api.github.com/users/thagikura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thagikura/subscriptions","organizations_url":"https://api.github.com/users/thagikura/orgs","repos_url":"https://api.github.com/users/thagikura/repos","events_url":"https://api.github.com/users/thagikura/events{/privacy}","received_events_url":"https://api.github.com/users/thagikura/received_events","type":"User","site_admin":false},"body":"Renamed those to getMargin~~~~","created_at":"2016-09-29T09:47:22Z","updated_at":"2016-09-29T09:47:22Z","html_url":"https://github.com/google/flexbox-layout/pull/128#discussion_r81100596","pull_request_url":"https://api.github.com/repos/google/flexbox-layout/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/comments/81100596"},"html":{"href":"https://github.com/google/flexbox-layout/pull/128#discussion_r81100596"},"pull_request":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/google/flexbox-layout/pulls/128","id":86496694,"html_url":"https://github.com/google/flexbox-layout/pull/128","diff_url":"https://github.com/google/flexbox-layout/pull/128.diff","patch_url":"https://github.com/google/flexbox-layout/pull/128.patch","issue_url":"https://api.github.com/repos/google/flexbox-layout/issues/128","number":128,"state":"open","locked":false,"title":"Extract the common logic to calculate the initial flex lines ","user":{"login":"thagikura","id":796361,"avatar_url":"https://avatars.githubusercontent.com/u/796361?v=3","gravatar_id":"","url":"https://api.github.com/users/thagikura","html_url":"https://github.com/thagikura","followers_url":"https://api.github.com/users/thagikura/followers","following_url":"https://api.github.com/users/thagikura/following{/other_user}","gists_url":"https://api.github.com/users/thagikura/gists{/gist_id}","starred_url":"https://api.github.com/users/thagikura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thagikura/subscriptions","organizations_url":"https://api.github.com/users/thagikura/orgs","repos_url":"https://api.github.com/users/thagikura/repos","events_url":"https://api.github.com/users/thagikura/events{/privacy}","received_events_url":"https://api.github.com/users/thagikura/received_events","type":"User","site_admin":false},"body":"This PR extracts the common logic to calculate the initial flex lines from the FlexboxLayout to FlexboxHelper to re-use it from the FlexboxLayout and the FlexboxLayoutManager.","created_at":"2016-09-23T11:27:27Z","updated_at":"2016-09-29T09:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f991c0854cda2e33170b56490fd500a8d3b984","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/flexbox-layout/pulls/128/commits","review_comments_url":"https://api.github.com/repos/google/flexbox-layout/pulls/128/comments","review_comment_url":"https://api.github.com/repos/google/flexbox-layout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/flexbox-layout/issues/128/comments","statuses_url":"https://api.github.com/repos/google/flexbox-layout/statuses/4c10de3a868759908d3408d2db3966cb27aef884","head":{"label":"google:share_common_flexline_logic","ref":"share_common_flexline_logic","sha":"4c10de3a868759908d3408d2db3966cb27aef884","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58034548,"name":"flexbox-layout","full_name":"google/flexbox-layout","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/flexbox-layout","description":"Flexbox for Android ","fork":false,"url":"https://api.github.com/repos/google/flexbox-layout","forks_url":"https://api.github.com/repos/google/flexbox-layout/forks","keys_url":"https://api.github.com/repos/google/flexbox-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flexbox-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flexbox-layout/teams","hooks_url":"https://api.github.com/repos/google/flexbox-layout/hooks","issue_events_url":"https://api.github.com/repos/google/flexbox-layout/issues/events{/number}","events_url":"https://api.github.com/repos/google/flexbox-layout/events","assignees_url":"https://api.github.com/repos/google/flexbox-layout/assignees{/user}","branches_url":"https://api.github.com/repos/google/flexbox-layout/branches{/branch}","tags_url":"https://api.github.com/repos/google/flexbox-layout/tags","blobs_url":"https://api.github.com/repos/google/flexbox-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flexbox-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flexbox-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flexbox-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flexbox-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flexbox-layout/languages","stargazers_url":"https://api.github.com/repos/google/flexbox-layout/stargazers","contributors_url":"https://api.github.com/repos/google/flexbox-layout/contributors","subscribers_url":"https://api.github.com/repos/google/flexbox-layout/subscribers","subscription_url":"https://api.github.com/repos/google/flexbox-layout/subscription","commits_url":"https://api.github.com/repos/google/flexbox-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flexbox-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flexbox-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flexbox-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flexbox-layout/contents/{+path}","compare_url":"https://api.github.com/repos/google/flexbox-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flexbox-layout/merges","archive_url":"https://api.github.com/repos/google/flexbox-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flexbox-layout/downloads","issues_url":"https://api.github.com/repos/google/flexbox-layout/issues{/number}","pulls_url":"https://api.github.com/repos/google/flexbox-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flexbox-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flexbox-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flexbox-layout/labels{/name}","releases_url":"https://api.github.com/repos/google/flexbox-layout/releases{/id}","deployments_url":"https://api.github.com/repos/google/flexbox-layout/deployments","created_at":"2016-05-04T08:11:22Z","updated_at":"2016-09-29T06:47:06Z","pushed_at":"2016-09-29T09:44:47Z","git_url":"git://github.com/google/flexbox-layout.git","ssh_url":"git@github.com:google/flexbox-layout.git","clone_url":"https://github.com/google/flexbox-layout.git","svn_url":"https://github.com/google/flexbox-layout","homepage":"","size":38554,"stargazers_count":5022,"watchers_count":5022,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":5,"forks":507,"open_issues":5,"watchers":5022,"default_branch":"master"}},"base":{"label":"google:dev_recyclerview","ref":"dev_recyclerview","sha":"9e5aedb7ec249412fc13a9ac3132bce76822b11b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58034548,"name":"flexbox-layout","full_name":"google/flexbox-layout","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/flexbox-layout","description":"Flexbox for Android ","fork":false,"url":"https://api.github.com/repos/google/flexbox-layout","forks_url":"https://api.github.com/repos/google/flexbox-layout/forks","keys_url":"https://api.github.com/repos/google/flexbox-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flexbox-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flexbox-layout/teams","hooks_url":"https://api.github.com/repos/google/flexbox-layout/hooks","issue_events_url":"https://api.github.com/repos/google/flexbox-layout/issues/events{/number}","events_url":"https://api.github.com/repos/google/flexbox-layout/events","assignees_url":"https://api.github.com/repos/google/flexbox-layout/assignees{/user}","branches_url":"https://api.github.com/repos/google/flexbox-layout/branches{/branch}","tags_url":"https://api.github.com/repos/google/flexbox-layout/tags","blobs_url":"https://api.github.com/repos/google/flexbox-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flexbox-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flexbox-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flexbox-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flexbox-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flexbox-layout/languages","stargazers_url":"https://api.github.com/repos/google/flexbox-layout/stargazers","contributors_url":"https://api.github.com/repos/google/flexbox-layout/contributors","subscribers_url":"https://api.github.com/repos/google/flexbox-layout/subscribers","subscription_url":"https://api.github.com/repos/google/flexbox-layout/subscription","commits_url":"https://api.github.com/repos/google/flexbox-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flexbox-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flexbox-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flexbox-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flexbox-layout/contents/{+path}","compare_url":"https://api.github.com/repos/google/flexbox-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flexbox-layout/merges","archive_url":"https://api.github.com/repos/google/flexbox-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flexbox-layout/downloads","issues_url":"https://api.github.com/repos/google/flexbox-layout/issues{/number}","pulls_url":"https://api.github.com/repos/google/flexbox-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flexbox-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flexbox-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flexbox-layout/labels{/name}","releases_url":"https://api.github.com/repos/google/flexbox-layout/releases{/id}","deployments_url":"https://api.github.com/repos/google/flexbox-layout/deployments","created_at":"2016-05-04T08:11:22Z","updated_at":"2016-09-29T06:47:06Z","pushed_at":"2016-09-29T09:44:47Z","git_url":"git://github.com/google/flexbox-layout.git","ssh_url":"git@github.com:google/flexbox-layout.git","clone_url":"https://github.com/google/flexbox-layout.git","svn_url":"https://github.com/google/flexbox-layout","homepage":"","size":38554,"stargazers_count":5022,"watchers_count":5022,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":5,"forks":507,"open_issues":5,"watchers":5022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/128"},"html":{"href":"https://github.com/google/flexbox-layout/pull/128"},"issue":{"href":"https://api.github.com/repos/google/flexbox-layout/issues/128"},"comments":{"href":"https://api.github.com/repos/google/flexbox-layout/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/flexbox-layout/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/google/flexbox-layout/statuses/4c10de3a868759908d3408d2db3966cb27aef884"}}}}
{"actor":{"display_login":"thagikura"}}