{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/71360094","id":71360094,"diff_hunk":"@@ -400,28 +400,28 @@ func verifyContainerResources(resources *containertypes.Resources, sysInfo *sysi\n \t\treturn warnings, fmt.Errorf(\"Invalid QoS settings: %s does not support Maximum IO Bandwidth or Maximum IO IOps\", runtime.GOOS)\n \t}\n \tif len(resources.BlkioWeightDevice) > 0 && !sysInfo.BlkioWeightDevice {\n-\t\twarnings = append(warnings, \"Your kernel does not support Block I/O weight_device.\")\n-\t\tlogrus.Warn(\"Your kernel does not support Block I/O weight_device. Weight-device discarded.\")\n+\t\twarnings = append(warnings, \"Your kernel does not support Block I/O weight_device or the cgroup is not mounted.\")\n+\t\tlogrus.Warn(\"Your kernel does not support Block I/O weight_device or the cgroup is not mounted. Weight-device discarded.\")\n \t\tresources.BlkioWeightDevice = []*pblkiodev.WeightDevice{}\n \t}\n \tif len(resources.BlkioDeviceReadBps) > 0 && !sysInfo.BlkioReadBpsDevice {\n-\t\twarnings = append(warnings, \"Your kernel does not support Block read limit in bytes per second.\")\n-\t\tlogrus.Warn(\"Your kernel does not support Block I/O read limit in bytes per second. --device-read-bps discarded.\")\n+\t\twarnings = append(warnings, \"Your kernel does not support BPS Block I/O read limit or the cgroup is not mounted.\")\n+\t\tlogrus.Warn(\"Your kernel does not support BPS Block I/O read limit or the cgroup is not mounted. --device-read-bps discarded.\")\n \t\tresources.BlkioDeviceReadBps = []*pblkiodev.ThrottleDevice{}\n \t}\n \tif len(resources.BlkioDeviceWriteBps) > 0 && !sysInfo.BlkioWriteBpsDevice {\n-\t\twarnings = append(warnings, \"Your kernel does not support Block write limit in bytes per second.\")\n-\t\tlogrus.Warn(\"Your kernel does not support Block I/O write limit in bytes per second. --device-write-bps discarded.\")\n+\t\twarnings = append(warnings, \"Your kernel does not support BPS Block I/O write limit or the cgroup is not mounted.\")","path":"daemon/daemon_unix.go","position":131,"original_position":131,"commit_id":"c5d34e98ac61631375421200cb11e5f471800d8c","original_commit_id":"c5d34e98ac61631375421200cb11e5f471800d8c","user":{"login":"clnperez","id":4493281,"avatar_url":"https://avatars.githubusercontent.com/u/4493281?v=3","gravatar_id":"","url":"https://api.github.com/users/clnperez","html_url":"https://github.com/clnperez","followers_url":"https://api.github.com/users/clnperez/followers","following_url":"https://api.github.com/users/clnperez/following{/other_user}","gists_url":"https://api.github.com/users/clnperez/gists{/gist_id}","starred_url":"https://api.github.com/users/clnperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clnperez/subscriptions","organizations_url":"https://api.github.com/users/clnperez/orgs","repos_url":"https://api.github.com/users/clnperez/repos","events_url":"https://api.github.com/users/clnperez/events{/privacy}","received_events_url":"https://api.github.com/users/clnperez/received_events","type":"User","site_admin":false},"body":"Just to save space, since it was already a long message. :) If you think  that's not a problem I can change it back. ","created_at":"2016-07-19T15:19:26Z","updated_at":"2016-07-19T15:19:26Z","html_url":"https://github.com/docker/docker/pull/24773#discussion_r71360094","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/24773","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/71360094"},"html":{"href":"https://github.com/docker/docker/pull/24773#discussion_r71360094"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/24773"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24773","id":77879113,"html_url":"https://github.com/docker/docker/pull/24773","diff_url":"https://github.com/docker/docker/pull/24773.diff","patch_url":"https://github.com/docker/docker/pull/24773.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/24773","number":24773,"state":"open","locked":false,"title":"More accurate cgroup error messages","user":{"login":"clnperez","id":4493281,"avatar_url":"https://avatars.githubusercontent.com/u/4493281?v=3","gravatar_id":"","url":"https://api.github.com/users/clnperez","html_url":"https://github.com/clnperez","followers_url":"https://api.github.com/users/clnperez/followers","following_url":"https://api.github.com/users/clnperez/following{/other_user}","gists_url":"https://api.github.com/users/clnperez/gists{/gist_id}","starred_url":"https://api.github.com/users/clnperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clnperez/subscriptions","organizations_url":"https://api.github.com/users/clnperez/orgs","repos_url":"https://api.github.com/users/clnperez/repos","events_url":"https://api.github.com/users/clnperez/events{/privacy}","received_events_url":"https://api.github.com/users/clnperez/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nAdded, \"or the cgroup is not mounted\" for all the cgroup error messages.\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\numount a cgroup (e.g. cpusets), and then create a container using that one. You'll see a more helpful warning message.\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\nA kernel may support any of these, but an admin may have unmounted\r\ncertain cgroups, so let's include that possibility in the error so\r\nas to avoid users thinking they have a kernel issue.\r\n\r\nSigned-off-by: Christy Perez <christy@linux.vnet.ibm.com>","created_at":"2016-07-18T21:04:28Z","updated_at":"2016-07-19T15:19:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074dded57acfe7e788c08b809f1fc95113b0e968","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/24773/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/24773/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/24773/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/c5d34e98ac61631375421200cb11e5f471800d8c","head":{"label":"clnperez:cgroup-warnings","ref":"cgroup-warnings","sha":"c5d34e98ac61631375421200cb11e5f471800d8c","user":{"login":"clnperez","id":4493281,"avatar_url":"https://avatars.githubusercontent.com/u/4493281?v=3","gravatar_id":"","url":"https://api.github.com/users/clnperez","html_url":"https://github.com/clnperez","followers_url":"https://api.github.com/users/clnperez/followers","following_url":"https://api.github.com/users/clnperez/following{/other_user}","gists_url":"https://api.github.com/users/clnperez/gists{/gist_id}","starred_url":"https://api.github.com/users/clnperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clnperez/subscriptions","organizations_url":"https://api.github.com/users/clnperez/orgs","repos_url":"https://api.github.com/users/clnperez/repos","events_url":"https://api.github.com/users/clnperez/events{/privacy}","received_events_url":"https://api.github.com/users/clnperez/received_events","type":"User","site_admin":false},"repo":{"id":32043400,"name":"docker","full_name":"clnperez/docker","owner":{"login":"clnperez","id":4493281,"avatar_url":"https://avatars.githubusercontent.com/u/4493281?v=3","gravatar_id":"","url":"https://api.github.com/users/clnperez","html_url":"https://github.com/clnperez","followers_url":"https://api.github.com/users/clnperez/followers","following_url":"https://api.github.com/users/clnperez/following{/other_user}","gists_url":"https://api.github.com/users/clnperez/gists{/gist_id}","starred_url":"https://api.github.com/users/clnperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clnperez/subscriptions","organizations_url":"https://api.github.com/users/clnperez/orgs","repos_url":"https://api.github.com/users/clnperez/repos","events_url":"https://api.github.com/users/clnperez/events{/privacy}","received_events_url":"https://api.github.com/users/clnperez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clnperez/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/clnperez/docker","forks_url":"https://api.github.com/repos/clnperez/docker/forks","keys_url":"https://api.github.com/repos/clnperez/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clnperez/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clnperez/docker/teams","hooks_url":"https://api.github.com/repos/clnperez/docker/hooks","issue_events_url":"https://api.github.com/repos/clnperez/docker/issues/events{/number}","events_url":"https://api.github.com/repos/clnperez/docker/events","assignees_url":"https://api.github.com/repos/clnperez/docker/assignees{/user}","branches_url":"https://api.github.com/repos/clnperez/docker/branches{/branch}","tags_url":"https://api.github.com/repos/clnperez/docker/tags","blobs_url":"https://api.github.com/repos/clnperez/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clnperez/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clnperez/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/clnperez/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clnperez/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/clnperez/docker/languages","stargazers_url":"https://api.github.com/repos/clnperez/docker/stargazers","contributors_url":"https://api.github.com/repos/clnperez/docker/contributors","subscribers_url":"https://api.github.com/repos/clnperez/docker/subscribers","subscription_url":"https://api.github.com/repos/clnperez/docker/subscription","commits_url":"https://api.github.com/repos/clnperez/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/clnperez/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/clnperez/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/clnperez/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/clnperez/docker/contents/{+path}","compare_url":"https://api.github.com/repos/clnperez/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clnperez/docker/merges","archive_url":"https://api.github.com/repos/clnperez/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clnperez/docker/downloads","issues_url":"https://api.github.com/repos/clnperez/docker/issues{/number}","pulls_url":"https://api.github.com/repos/clnperez/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/clnperez/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/clnperez/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clnperez/docker/labels{/name}","releases_url":"https://api.github.com/repos/clnperez/docker/releases{/id}","deployments_url":"https://api.github.com/repos/clnperez/docker/deployments","created_at":"2015-03-11T21:58:26Z","updated_at":"2016-01-19T23:38:41Z","pushed_at":"2016-07-19T15:13:00Z","git_url":"git://github.com/clnperez/docker.git","ssh_url":"git@github.com:clnperez/docker.git","clone_url":"https://github.com/clnperez/docker.git","svn_url":"https://github.com/clnperez/docker","homepage":"http://www.docker.com","size":97775,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e7b96102ff4df9209ca721e13f8f088d4da4c734","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-07-19T15:18:41Z","pushed_at":"2016-07-19T15:11:51Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":205003,"stargazers_count":33135,"watchers_count":33135,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9600,"mirror_url":null,"open_issues_count":1998,"forks":9600,"open_issues":1998,"watchers":33135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/24773"},"html":{"href":"https://github.com/docker/docker/pull/24773"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/24773"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/24773/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/24773/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/24773/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/c5d34e98ac61631375421200cb11e5f471800d8c"}}}}
{"actor":{"display_login":"clnperez"}}