{"action":"created","comment":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments/71543297","id":71543297,"diff_hunk":"@@ -757,7 +757,7 @@\n \n // notice that we can't use wxCHECK_VISUALC_VERSION() here as this file is\n // included from wx/platform.h before wxCHECK_VISUALC_VERSION() is defined\n-#ifdef _MSC_VER\n+#if defined(_MSC_VER) || defined(__MINGW32__)","path":"include/wx/setup_inc.h","position":5,"original_position":5,"commit_id":"f9c7d1795a12220056c93f72fa8b3e38a5406cfa","original_commit_id":"f9c7d1795a12220056c93f72fa8b3e38a5406cfa","user":{"login":"firodj","id":1750918,"avatar_url":"https://avatars.githubusercontent.com/u/1750918?v=3","gravatar_id":"","url":"https://api.github.com/users/firodj","html_url":"https://github.com/firodj","followers_url":"https://api.github.com/users/firodj/followers","following_url":"https://api.github.com/users/firodj/following{/other_user}","gists_url":"https://api.github.com/users/firodj/gists{/gist_id}","starred_url":"https://api.github.com/users/firodj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firodj/subscriptions","organizations_url":"https://api.github.com/users/firodj/orgs","repos_url":"https://api.github.com/users/firodj/repos","events_url":"https://api.github.com/users/firodj/events{/privacy}","received_events_url":"https://api.github.com/users/firodj/received_events","type":"User","site_admin":false},"body":"yup, I just use with mingw64 5.3.0 i686, but still not test on non w64. thx","created_at":"2016-07-20T15:06:44Z","updated_at":"2016-07-20T15:06:44Z","html_url":"https://github.com/wxWidgets/wxWidgets/pull/308#discussion_r71543297","pull_request_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments/71543297"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/308#discussion_r71543297"},"pull_request":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308","id":78064653,"html_url":"https://github.com/wxWidgets/wxWidgets/pull/308","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/308.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/308.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/308","number":308,"state":"open","locked":false,"title":"add ignore files for mingw and enable gdi+","user":{"login":"firodj","id":1750918,"avatar_url":"https://avatars.githubusercontent.com/u/1750918?v=3","gravatar_id":"","url":"https://api.github.com/users/firodj","html_url":"https://github.com/firodj","followers_url":"https://api.github.com/users/firodj/followers","following_url":"https://api.github.com/users/firodj/following{/other_user}","gists_url":"https://api.github.com/users/firodj/gists{/gist_id}","starred_url":"https://api.github.com/users/firodj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firodj/subscriptions","organizations_url":"https://api.github.com/users/firodj/orgs","repos_url":"https://api.github.com/users/firodj/repos","events_url":"https://api.github.com/users/firodj/events{/privacy}","received_events_url":"https://api.github.com/users/firodj/received_events","type":"User","site_admin":false},"body":"i'am using mingw64 5.3.0, and these changes:\r\n* ignore mingw specified files\r\n* enable wxGraphicsContext on MINGW","created_at":"2016-07-19T23:09:11Z","updated_at":"2016-07-20T15:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7176359a70902136e74dc2909e9d7c0fcf71e4c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/308/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/f9c7d1795a12220056c93f72fa8b3e38a5406cfa","head":{"label":"firodj:firodj","ref":"firodj","sha":"f9c7d1795a12220056c93f72fa8b3e38a5406cfa","user":{"login":"firodj","id":1750918,"avatar_url":"https://avatars.githubusercontent.com/u/1750918?v=3","gravatar_id":"","url":"https://api.github.com/users/firodj","html_url":"https://github.com/firodj","followers_url":"https://api.github.com/users/firodj/followers","following_url":"https://api.github.com/users/firodj/following{/other_user}","gists_url":"https://api.github.com/users/firodj/gists{/gist_id}","starred_url":"https://api.github.com/users/firodj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firodj/subscriptions","organizations_url":"https://api.github.com/users/firodj/orgs","repos_url":"https://api.github.com/users/firodj/repos","events_url":"https://api.github.com/users/firodj/events{/privacy}","received_events_url":"https://api.github.com/users/firodj/received_events","type":"User","site_admin":false},"repo":{"id":63733278,"name":"wxWidgets","full_name":"firodj/wxWidgets","owner":{"login":"firodj","id":1750918,"avatar_url":"https://avatars.githubusercontent.com/u/1750918?v=3","gravatar_id":"","url":"https://api.github.com/users/firodj","html_url":"https://github.com/firodj","followers_url":"https://api.github.com/users/firodj/followers","following_url":"https://api.github.com/users/firodj/following{/other_user}","gists_url":"https://api.github.com/users/firodj/gists{/gist_id}","starred_url":"https://api.github.com/users/firodj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firodj/subscriptions","organizations_url":"https://api.github.com/users/firodj/orgs","repos_url":"https://api.github.com/users/firodj/repos","events_url":"https://api.github.com/users/firodj/events{/privacy}","received_events_url":"https://api.github.com/users/firodj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/firodj/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: http://trac.wxwidgets.org/","fork":true,"url":"https://api.github.com/repos/firodj/wxWidgets","forks_url":"https://api.github.com/repos/firodj/wxWidgets/forks","keys_url":"https://api.github.com/repos/firodj/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firodj/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firodj/wxWidgets/teams","hooks_url":"https://api.github.com/repos/firodj/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/firodj/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/firodj/wxWidgets/events","assignees_url":"https://api.github.com/repos/firodj/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/firodj/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/firodj/wxWidgets/tags","blobs_url":"https://api.github.com/repos/firodj/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firodj/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firodj/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/firodj/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firodj/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/firodj/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/firodj/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/firodj/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/firodj/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/firodj/wxWidgets/subscription","commits_url":"https://api.github.com/repos/firodj/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/firodj/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/firodj/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/firodj/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/firodj/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/firodj/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firodj/wxWidgets/merges","archive_url":"https://api.github.com/repos/firodj/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firodj/wxWidgets/downloads","issues_url":"https://api.github.com/repos/firodj/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/firodj/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/firodj/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/firodj/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firodj/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/firodj/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/firodj/wxWidgets/deployments","created_at":"2016-07-19T22:57:37Z","updated_at":"2016-07-19T22:58:07Z","pushed_at":"2016-07-19T23:05:26Z","git_url":"git://github.com/firodj/wxWidgets.git","ssh_url":"git@github.com:firodj/wxWidgets.git","clone_url":"https://github.com/firodj/wxWidgets.git","svn_url":"https://github.com/firodj/wxWidgets","homepage":"https://www.wxwidgets.org/","size":293438,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"e371214cfa118b86b9a54c8b6b977ca1ec2cd750","user":{"login":"wxWidgets","id":791023,"avatar_url":"https://avatars.githubusercontent.com/u/791023?v=3","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"name":"wxWidgets","full_name":"wxWidgets/wxWidgets","owner":{"login":"wxWidgets","id":791023,"avatar_url":"https://avatars.githubusercontent.com/u/791023?v=3","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: http://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2016-07-20T09:51:14Z","pushed_at":"2016-07-19T23:09:12Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":354441,"stargazers_count":1142,"watchers_count":1142,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":489,"mirror_url":null,"open_issues_count":17,"forks":489,"open_issues":17,"watchers":1142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/308"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/308"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/f9c7d1795a12220056c93f72fa8b3e38a5406cfa"}}}}
{"actor":{"display_login":"firodj"}}