{"action":"created","issue":{"url":"https://api.github.com/repos/graphql-java/graphql-java/issues/37","repository_url":"https://api.github.com/repos/graphql-java/graphql-java","labels_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/37/comments","events_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/37/events","html_url":"https://github.com/graphql-java/graphql-java/issues/37","id":109918038,"number":37,"title":"Asynchronous DataFetcher?","user":{"login":"ybayk","id":1779404,"avatar_url":"https://avatars.githubusercontent.com/u/1779404?v=3","gravatar_id":"","url":"https://api.github.com/users/ybayk","html_url":"https://github.com/ybayk","followers_url":"https://api.github.com/users/ybayk/followers","following_url":"https://api.github.com/users/ybayk/following{/other_user}","gists_url":"https://api.github.com/users/ybayk/gists{/gist_id}","starred_url":"https://api.github.com/users/ybayk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybayk/subscriptions","organizations_url":"https://api.github.com/users/ybayk/orgs","repos_url":"https://api.github.com/users/ybayk/repos","events_url":"https://api.github.com/users/ybayk/events{/privacy}","received_events_url":"https://api.github.com/users/ybayk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2015-10-06T01:19:10Z","updated_at":"2016-09-06T19:20:06Z","closed_at":null,"body":"~~Please consider adding support of Future return type for DataFetcher API.~~\r\nActually scratched that. We just noticed it is possible to provide a custom executor service per fetcher. But it will still block for each fetcher.\r\nIs it actually possible to go async all the way?  \r\n1) Across all fetchers\r\n2) Make top level graphql execute() async as well."},"comment":{"url":"https://api.github.com/repos/graphql-java/graphql-java/issues/comments/245059995","html_url":"https://github.com/graphql-java/graphql-java/issues/37#issuecomment-245059995","issue_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/37","id":245059995,"user":{"login":"akhahaha","id":1884980,"avatar_url":"https://avatars.githubusercontent.com/u/1884980?v=3","gravatar_id":"","url":"https://api.github.com/users/akhahaha","html_url":"https://github.com/akhahaha","followers_url":"https://api.github.com/users/akhahaha/followers","following_url":"https://api.github.com/users/akhahaha/following{/other_user}","gists_url":"https://api.github.com/users/akhahaha/gists{/gist_id}","starred_url":"https://api.github.com/users/akhahaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhahaha/subscriptions","organizations_url":"https://api.github.com/users/akhahaha/orgs","repos_url":"https://api.github.com/users/akhahaha/repos","events_url":"https://api.github.com/users/akhahaha/events{/privacy}","received_events_url":"https://api.github.com/users/akhahaha/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T19:20:06Z","updated_at":"2016-09-06T19:20:06Z","body":"You have a good point: we shouldn't be deprecating methods lightly.\r\n\r\nIt seems to me that in order to avoid deprecating the get() method, the ExecutionStrategy must decide to either wait for the DataFetchCallback or process the serial return value of get(). One workaround for this ambiguous situation would be to create a separate AsyncExecutionStrategy and perhaps an executeAsync() function to handle the callback methods. The drawbacks to this would be some likely code duplication, at the very least.\r\n\r\nMy point also remains that per GraphQL-JS specification, the library should be async capable by default, and callbacks of some sort are the way to go about this. Perhaps the best solution for something this drastic would be to break backwards compatibility and push it out as v3.0.0?"}}
{"actor":{"display_login":"akhahaha"}}