{"action":"created","issue":{"url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/20","repository_url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise","labels_url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/20/comments","events_url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/20/events","html_url":"https://github.com/Real-Serious-Games/C-Sharp-Promise/pull/20","id":162204574,"number":20,"title":"Updates","user":{"login":"nloewen","id":348510,"avatar_url":"https://avatars.githubusercontent.com/u/348510?v=3","gravatar_id":"","url":"https://api.github.com/users/nloewen","html_url":"https://github.com/nloewen","followers_url":"https://api.github.com/users/nloewen/followers","following_url":"https://api.github.com/users/nloewen/following{/other_user}","gists_url":"https://api.github.com/users/nloewen/gists{/gist_id}","starred_url":"https://api.github.com/users/nloewen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nloewen/subscriptions","organizations_url":"https://api.github.com/users/nloewen/orgs","repos_url":"https://api.github.com/users/nloewen/repos","events_url":"https://api.github.com/users/nloewen/events{/privacy}","received_events_url":"https://api.github.com/users/nloewen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-24T18:31:25Z","updated_at":"2016-07-06T21:05:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/pulls/20","html_url":"https://github.com/Real-Serious-Games/C-Sharp-Promise/pull/20","diff_url":"https://github.com/Real-Serious-Games/C-Sharp-Promise/pull/20.diff","patch_url":"https://github.com/Real-Serious-Games/C-Sharp-Promise/pull/20.patch"},"body":"I've implemented some changes that I needed for my project.\r\n\r\n#### Create unified base class/interface for generic and non-generic promises\r\nThis allows code which can handle any type of promise. Creating IPromiseBase allows IPromise, IPromise<int>, and IPromise<MyFunClass> to all be treated identically, without creating code branches for each. The IPromiseBase interface is implemented explicitly, which avoids creating ambiguous functions.\r\n\r\nAdditionally, the Promise_Base class allows for a decent amount of code reuse between generic and non-generic promises.\r\n\r\n#### Implement Finally\r\nImplemented as described in issue #9. It's just a wrapper around existing functionality.\r\n"},"comment":{"url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/comments/230906501","html_url":"https://github.com/Real-Serious-Games/C-Sharp-Promise/pull/20#issuecomment-230906501","issue_url":"https://api.github.com/repos/Real-Serious-Games/C-Sharp-Promise/issues/20","id":230906501,"user":{"login":"df-marc","id":9000249,"avatar_url":"https://avatars.githubusercontent.com/u/9000249?v=3","gravatar_id":"","url":"https://api.github.com/users/df-marc","html_url":"https://github.com/df-marc","followers_url":"https://api.github.com/users/df-marc/followers","following_url":"https://api.github.com/users/df-marc/following{/other_user}","gists_url":"https://api.github.com/users/df-marc/gists{/gist_id}","starred_url":"https://api.github.com/users/df-marc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/df-marc/subscriptions","organizations_url":"https://api.github.com/users/df-marc/orgs","repos_url":"https://api.github.com/users/df-marc/repos","events_url":"https://api.github.com/users/df-marc/events{/privacy}","received_events_url":"https://api.github.com/users/df-marc/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T21:05:42Z","updated_at":"2016-07-06T21:05:42Z","body":"I'd love to get Finally support in RSG.Promises! If you separated these into two PR's, it might be easier for Ashley to land the Finally support while the team decides which (if any) big refactor PR to take. I hope so anyway."}}
{"actor":{"display_login":"df-marc"}}