{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/73423412","id":73423412,"diff_hunk":"@@ -54,17 +54,35 @@ module.exports = function<T, P, I, C>(config : HostConfig<T, P, I, C>) {\n     workInProgress.pendingWorkPriority = NoWork;\n   }\n \n-  function updateClassComponent(current, workInProgress) {\n+  function updateClassComponent(current : ?Fiber, workInProgress : Fiber) {\n     var props = workInProgress.pendingProps;\n-    if (!workInProgress.stateNode) {\n+    var instance = workInProgress.stateNode;\n+    if (!instance) {\n       var ctor = workInProgress.type;\n-      workInProgress.stateNode = new ctor(props);\n+      workInProgress.stateNode = instance = new ctor(props);\n+    } else if (typeof instance.shouldComponentUpdate === 'function') {","path":"src/renderers/shared/fiber/ReactFiberBeginWork.js","position":null,"original_position":13,"commit_id":"26d131434d733bcb089711af1379d2caacc2c407","original_commit_id":"864136b2c788aee112131f02188ac1b03e2e2d9c","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"nit: in ReactCompositeComponent we do `if (inst.shouldComponentUpdate)` which fails on non-functions whereas yours silently ignores them","created_at":"2016-08-03T21:20:44Z","updated_at":"2016-08-03T21:20:44Z","html_url":"https://github.com/facebook/react/pull/7248#discussion_r73423412","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/7248","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/73423412"},"html":{"href":"https://github.com/facebook/react/pull/7248#discussion_r73423412"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/7248"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7248","id":77047970,"html_url":"https://github.com/facebook/react/pull/7248","diff_url":"https://github.com/facebook/react/pull/7248.diff","patch_url":"https://github.com/facebook/react/pull/7248.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/7248","number":7248,"state":"open","locked":false,"title":"[Fiber] Various minor tweaks and a few big ones","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"See individual commits.","created_at":"2016-07-12T01:18:34Z","updated_at":"2016-08-03T21:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c30ce59e5b5c8a8801706f5070a4f98c0347abb","assignee":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"assignees":[{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/7248/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/7248/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/7248/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/26d131434d733bcb089711af1379d2caacc2c407","head":{"label":"sebmarkbage:fibercleanup","ref":"fibercleanup","sha":"26d131434d733bcb089711af1379d2caacc2c407","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"repo":{"id":10374314,"name":"react","full_name":"sebmarkbage/react","owner":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebmarkbage/react","description":"React is a JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/sebmarkbage/react","forks_url":"https://api.github.com/repos/sebmarkbage/react/forks","keys_url":"https://api.github.com/repos/sebmarkbage/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebmarkbage/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebmarkbage/react/teams","hooks_url":"https://api.github.com/repos/sebmarkbage/react/hooks","issue_events_url":"https://api.github.com/repos/sebmarkbage/react/issues/events{/number}","events_url":"https://api.github.com/repos/sebmarkbage/react/events","assignees_url":"https://api.github.com/repos/sebmarkbage/react/assignees{/user}","branches_url":"https://api.github.com/repos/sebmarkbage/react/branches{/branch}","tags_url":"https://api.github.com/repos/sebmarkbage/react/tags","blobs_url":"https://api.github.com/repos/sebmarkbage/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebmarkbage/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebmarkbage/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebmarkbage/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebmarkbage/react/statuses/{sha}","languages_url":"https://api.github.com/repos/sebmarkbage/react/languages","stargazers_url":"https://api.github.com/repos/sebmarkbage/react/stargazers","contributors_url":"https://api.github.com/repos/sebmarkbage/react/contributors","subscribers_url":"https://api.github.com/repos/sebmarkbage/react/subscribers","subscription_url":"https://api.github.com/repos/sebmarkbage/react/subscription","commits_url":"https://api.github.com/repos/sebmarkbage/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebmarkbage/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebmarkbage/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebmarkbage/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebmarkbage/react/contents/{+path}","compare_url":"https://api.github.com/repos/sebmarkbage/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebmarkbage/react/merges","archive_url":"https://api.github.com/repos/sebmarkbage/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebmarkbage/react/downloads","issues_url":"https://api.github.com/repos/sebmarkbage/react/issues{/number}","pulls_url":"https://api.github.com/repos/sebmarkbage/react/pulls{/number}","milestones_url":"https://api.github.com/repos/sebmarkbage/react/milestones{/number}","notifications_url":"https://api.github.com/repos/sebmarkbage/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebmarkbage/react/labels{/name}","releases_url":"https://api.github.com/repos/sebmarkbage/react/releases{/id}","deployments_url":"https://api.github.com/repos/sebmarkbage/react/deployments","created_at":"2013-05-30T03:09:16Z","updated_at":"2016-07-04T15:18:22Z","pushed_at":"2016-08-02T01:42:18Z","git_url":"git://github.com/sebmarkbage/react.git","ssh_url":"git@github.com:sebmarkbage/react.git","clone_url":"https://github.com/sebmarkbage/react.git","svn_url":"https://github.com/sebmarkbage/react","homepage":"http://facebook.github.io/react/","size":59566,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"8aed0cd67ec7c52a689bd729ad4ec9ee4a80b45b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-08-03T20:52:09Z","pushed_at":"2016-08-03T21:12:03Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":126420,"stargazers_count":46679,"watchers_count":46679,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8131,"mirror_url":null,"open_issues_count":620,"forks":8131,"open_issues":620,"watchers":46679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/7248"},"html":{"href":"https://github.com/facebook/react/pull/7248"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/7248"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/7248/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/7248/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/7248/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/26d131434d733bcb089711af1379d2caacc2c407"}}}}
{"actor":{"display_login":"spicyj"}}