{"action":"created","issue":{"url":"https://api.github.com/repos/nbgallery/ipydeps/issues/7","repository_url":"https://api.github.com/repos/nbgallery/ipydeps","labels_url":"https://api.github.com/repos/nbgallery/ipydeps/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/nbgallery/ipydeps/issues/7/comments","events_url":"https://api.github.com/repos/nbgallery/ipydeps/issues/7/events","html_url":"https://github.com/nbgallery/ipydeps/issues/7","id":171806521,"number":7,"title":"Overrides vs dependencies","user":{"login":"jeffyjefflabs","id":18747664,"avatar_url":"https://avatars.githubusercontent.com/u/18747664?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffyjefflabs","html_url":"https://github.com/jeffyjefflabs","followers_url":"https://api.github.com/users/jeffyjefflabs/followers","following_url":"https://api.github.com/users/jeffyjefflabs/following{/other_user}","gists_url":"https://api.github.com/users/jeffyjefflabs/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffyjefflabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffyjefflabs/subscriptions","organizations_url":"https://api.github.com/users/jeffyjefflabs/orgs","repos_url":"https://api.github.com/users/jeffyjefflabs/repos","events_url":"https://api.github.com/users/jeffyjefflabs/events{/privacy}","received_events_url":"https://api.github.com/users/jeffyjefflabs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-18T02:50:58Z","updated_at":"2016-08-18T03:17:30Z","closed_at":null,"body":"After executing override commands from the dependencies file, ipydeps should still pip install the module.  There are cases where those commands merely install a dependency (e.g. matplotlib requires freetype-dev) rather than a complete replacement for pip (e.g. the numpy apk).\r\n\r\nPossibly this could be an option specified in the dependencies file, but it doesn't really hurt to do the pip install regardless -- if the override commands installed the actual package, you'll just get a message that it's already installed."},"comment":{"url":"https://api.github.com/repos/nbgallery/ipydeps/issues/comments/240613414","html_url":"https://github.com/nbgallery/ipydeps/issues/7#issuecomment-240613414","issue_url":"https://api.github.com/repos/nbgallery/ipydeps/issues/7","id":240613414,"user":{"login":"jeffyjefflabs","id":18747664,"avatar_url":"https://avatars.githubusercontent.com/u/18747664?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffyjefflabs","html_url":"https://github.com/jeffyjefflabs","followers_url":"https://api.github.com/users/jeffyjefflabs/followers","following_url":"https://api.github.com/users/jeffyjefflabs/following{/other_user}","gists_url":"https://api.github.com/users/jeffyjefflabs/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffyjefflabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffyjefflabs/subscriptions","organizations_url":"https://api.github.com/users/jeffyjefflabs/orgs","repos_url":"https://api.github.com/users/jeffyjefflabs/repos","events_url":"https://api.github.com/users/jeffyjefflabs/events{/privacy}","received_events_url":"https://api.github.com/users/jeffyjefflabs/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T03:17:30Z","updated_at":"2016-08-18T03:17:30Z","body":"Exactly.  I put a little patch into the docker image so it will just execute the _pip.main call even when there are overrides.  I thought about just adding the pip command into dependencies.json, but it's more complicated than that because you may not know additional options for the pip command (as when used with pypki2).\r\n\r\nSo, quick & dirty fix is to just remove the line that I commented out in the patch.  Better solution would be a way to specify in dependencies.json that you still need to run a pip command, but you'll need to add in the extra arguments from pypki2 or whatever else is configured."}}
{"actor":{"display_login":"jeffyjefflabs"}}