{"action":"closed","issue":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/752","repository_url":"https://api.github.com/repos/ClusterLabs/resource-agents","labels_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/752/labels{/name}","comments_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/752/comments","events_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/752/events","html_url":"https://github.com/ClusterLabs/resource-agents/issues/752","id":131561483,"number":752,"title":"v3.9.7 tag should be an annotated tag","user":{"login":"kskmori","id":637248,"avatar_url":"https://avatars.githubusercontent.com/u/637248?v=3","gravatar_id":"","url":"https://api.github.com/users/kskmori","html_url":"https://github.com/kskmori","followers_url":"https://api.github.com/users/kskmori/followers","following_url":"https://api.github.com/users/kskmori/following{/other_user}","gists_url":"https://api.github.com/users/kskmori/gists{/gist_id}","starred_url":"https://api.github.com/users/kskmori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kskmori/subscriptions","organizations_url":"https://api.github.com/users/kskmori/orgs","repos_url":"https://api.github.com/users/kskmori/repos","events_url":"https://api.github.com/users/kskmori/events{/privacy}","received_events_url":"https://api.github.com/users/kskmori/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-05T05:43:20Z","updated_at":"2016-02-08T05:04:52Z","closed_at":"2016-02-08T05:04:52Z","body":"On v3.9.7, make dist creates an invalid versioned tarball. This is caused because v3.9.7 was tagged as a \"lightweight tag\" instead of \"annotated tag\" and hence git describe confuses the latest version.\r\n\r\nSteps to reproduce:\r\n```\r\n[root@build-centos71 resource-agents ((v3.9.7))]# git checkout v3.9.7\r\nHEAD is now at e697f43... Merge pull request #749 from oalbrigt/3.9.7\r\n[root@build-centos71 resource-agents ((v3.9.7))]# git describe\r\nv3.9.6-272-ge697f43\r\n[root@build-centos71 resource-agents ((v3.9.7))]# ./autogen.sh && ./configure && make dist\r\n(omit)\r\nresource-agents configuration:\r\n  Version                  = 3.9.6.272-e697f\r\n(omit)\r\n[root@build-centos71 resource-agents ((v3.9.7))]# ls *.bz2\r\nresource-agents-3.9.6.272-e697f.tar.bz2\r\n```\r\n\r\nYou can make sure which are tagged by\r\n```\r\n[root@build-centos71 resource-agents ((v3.9.7))]# git cat-file -t v3.9.5\r\ntag\r\n[root@build-centos71 resource-agents ((v3.9.7))]# git cat-file -t v3.9.6\r\ntag\r\n[root@build-centos71 resource-agents ((v3.9.7))]# git cat-file -t v3.9.7\r\ncommit\r\n[root@build-centos71 resource-agents ((v3.9.7))]# \r\n```\r\nwhere 'tag' means an annotated tag and 'commit' means a lightweight tag.\r\n\r\nI'm not sure if it is possible to replace an already pushed tag by an annotated tag on the github, though.\r\n"}}