{"action":"created","comment":{"url":"https://api.github.com/repos/dabaitu/presto/pulls/comments/75370547","id":75370547,"diff_hunk":"@@ -72,7 +74,7 @@ StatementClient.prototype.advance = function(lastRecordNumber) {\n     var statementClient = this;\n     $.ajax({\n         type: \"GET\",\n-        url: this.currentResults.nextUri,\n+        url: this.isHttps ? this.currentResults.nextUri.replace(\"http\", \"https\") : this.currentResults.nextUri,","path":"presto-main/src/main/resources/webapp/tableau/presto-client.js","position":14,"original_position":14,"commit_id":"6e9bfea61ae214640c764d57da42aeaefced1387","original_commit_id":"6e9bfea61ae214640c764d57da42aeaefced1387","user":{"login":"ZhihaoJia","id":1378104,"avatar_url":"https://avatars.githubusercontent.com/u/1378104?v=3","gravatar_id":"","url":"https://api.github.com/users/ZhihaoJia","html_url":"https://github.com/ZhihaoJia","followers_url":"https://api.github.com/users/ZhihaoJia/followers","following_url":"https://api.github.com/users/ZhihaoJia/following{/other_user}","gists_url":"https://api.github.com/users/ZhihaoJia/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhihaoJia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhihaoJia/subscriptions","organizations_url":"https://api.github.com/users/ZhihaoJia/orgs","repos_url":"https://api.github.com/users/ZhihaoJia/repos","events_url":"https://api.github.com/users/ZhihaoJia/events{/privacy}","received_events_url":"https://api.github.com/users/ZhihaoJia/received_events","type":"User","site_admin":false},"body":"If `nextUri` already contains `'https'`, we might be replacing the prefix and end up with `'httpss'`. To be safer, I think we could match more of the string. We could also do the replacement the other way around (ie. switch from '`https'` to `'http'`) as well if `this.isHttps` is false.\r\n\r\nProbably not necessary, but matching the prefix instead of first occurrence may add more safety (ie. `.replace(/^http/, 'https')`).","created_at":"2016-08-18T19:12:04Z","updated_at":"2016-08-18T19:12:04Z","html_url":"https://github.com/dabaitu/presto/pull/1#discussion_r75370547","pull_request_url":"https://api.github.com/repos/dabaitu/presto/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/comments/75370547"},"html":{"href":"https://github.com/dabaitu/presto/pull/1#discussion_r75370547"},"pull_request":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/dabaitu/presto/pulls/1","id":81867692,"html_url":"https://github.com/dabaitu/presto/pull/1","diff_url":"https://github.com/dabaitu/presto/pull/1.diff","patch_url":"https://github.com/dabaitu/presto/pull/1.patch","issue_url":"https://api.github.com/repos/dabaitu/presto/issues/1","number":1,"state":"open","locked":false,"title":"Fix tableau connector js","user":{"login":"dabaitu","id":3894166,"avatar_url":"https://avatars.githubusercontent.com/u/3894166?v=3","gravatar_id":"","url":"https://api.github.com/users/dabaitu","html_url":"https://github.com/dabaitu","followers_url":"https://api.github.com/users/dabaitu/followers","following_url":"https://api.github.com/users/dabaitu/following{/other_user}","gists_url":"https://api.github.com/users/dabaitu/gists{/gist_id}","starred_url":"https://api.github.com/users/dabaitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabaitu/subscriptions","organizations_url":"https://api.github.com/users/dabaitu/orgs","repos_url":"https://api.github.com/users/dabaitu/repos","events_url":"https://api.github.com/users/dabaitu/events{/privacy}","received_events_url":"https://api.github.com/users/dabaitu/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-18T18:48:46Z","updated_at":"2016-08-18T19:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e5813e4abe34258c1bfe680db3ea70fd07269d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dabaitu/presto/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dabaitu/presto/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dabaitu/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dabaitu/presto/issues/1/comments","statuses_url":"https://api.github.com/repos/dabaitu/presto/statuses/6e9bfea61ae214640c764d57da42aeaefced1387","head":{"label":"dabaitu:fix-tableau-connector-js","ref":"fix-tableau-connector-js","sha":"6e9bfea61ae214640c764d57da42aeaefced1387","user":{"login":"dabaitu","id":3894166,"avatar_url":"https://avatars.githubusercontent.com/u/3894166?v=3","gravatar_id":"","url":"https://api.github.com/users/dabaitu","html_url":"https://github.com/dabaitu","followers_url":"https://api.github.com/users/dabaitu/followers","following_url":"https://api.github.com/users/dabaitu/following{/other_user}","gists_url":"https://api.github.com/users/dabaitu/gists{/gist_id}","starred_url":"https://api.github.com/users/dabaitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabaitu/subscriptions","organizations_url":"https://api.github.com/users/dabaitu/orgs","repos_url":"https://api.github.com/users/dabaitu/repos","events_url":"https://api.github.com/users/dabaitu/events{/privacy}","received_events_url":"https://api.github.com/users/dabaitu/received_events","type":"User","site_admin":false},"repo":{"id":63443798,"name":"presto","full_name":"dabaitu/presto","owner":{"login":"dabaitu","id":3894166,"avatar_url":"https://avatars.githubusercontent.com/u/3894166?v=3","gravatar_id":"","url":"https://api.github.com/users/dabaitu","html_url":"https://github.com/dabaitu","followers_url":"https://api.github.com/users/dabaitu/followers","following_url":"https://api.github.com/users/dabaitu/following{/other_user}","gists_url":"https://api.github.com/users/dabaitu/gists{/gist_id}","starred_url":"https://api.github.com/users/dabaitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabaitu/subscriptions","organizations_url":"https://api.github.com/users/dabaitu/orgs","repos_url":"https://api.github.com/users/dabaitu/repos","events_url":"https://api.github.com/users/dabaitu/events{/privacy}","received_events_url":"https://api.github.com/users/dabaitu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dabaitu/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/dabaitu/presto","forks_url":"https://api.github.com/repos/dabaitu/presto/forks","keys_url":"https://api.github.com/repos/dabaitu/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabaitu/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabaitu/presto/teams","hooks_url":"https://api.github.com/repos/dabaitu/presto/hooks","issue_events_url":"https://api.github.com/repos/dabaitu/presto/issues/events{/number}","events_url":"https://api.github.com/repos/dabaitu/presto/events","assignees_url":"https://api.github.com/repos/dabaitu/presto/assignees{/user}","branches_url":"https://api.github.com/repos/dabaitu/presto/branches{/branch}","tags_url":"https://api.github.com/repos/dabaitu/presto/tags","blobs_url":"https://api.github.com/repos/dabaitu/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabaitu/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabaitu/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabaitu/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabaitu/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/dabaitu/presto/languages","stargazers_url":"https://api.github.com/repos/dabaitu/presto/stargazers","contributors_url":"https://api.github.com/repos/dabaitu/presto/contributors","subscribers_url":"https://api.github.com/repos/dabaitu/presto/subscribers","subscription_url":"https://api.github.com/repos/dabaitu/presto/subscription","commits_url":"https://api.github.com/repos/dabaitu/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabaitu/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabaitu/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabaitu/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabaitu/presto/contents/{+path}","compare_url":"https://api.github.com/repos/dabaitu/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabaitu/presto/merges","archive_url":"https://api.github.com/repos/dabaitu/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabaitu/presto/downloads","issues_url":"https://api.github.com/repos/dabaitu/presto/issues{/number}","pulls_url":"https://api.github.com/repos/dabaitu/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/dabaitu/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/dabaitu/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabaitu/presto/labels{/name}","releases_url":"https://api.github.com/repos/dabaitu/presto/releases{/id}","deployments_url":"https://api.github.com/repos/dabaitu/presto/deployments","created_at":"2016-07-15T18:44:46Z","updated_at":"2016-07-15T18:44:58Z","pushed_at":"2016-08-18T18:48:46Z","git_url":"git://github.com/dabaitu/presto.git","ssh_url":"git@github.com:dabaitu/presto.git","clone_url":"https://github.com/dabaitu/presto.git","svn_url":"https://github.com/dabaitu/presto","homepage":"https://prestodb.io","size":60757,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dabaitu:twitter-master","ref":"twitter-master","sha":"8d08d22d0b61686940c81bae863cacd625f70be3","user":{"login":"dabaitu","id":3894166,"avatar_url":"https://avatars.githubusercontent.com/u/3894166?v=3","gravatar_id":"","url":"https://api.github.com/users/dabaitu","html_url":"https://github.com/dabaitu","followers_url":"https://api.github.com/users/dabaitu/followers","following_url":"https://api.github.com/users/dabaitu/following{/other_user}","gists_url":"https://api.github.com/users/dabaitu/gists{/gist_id}","starred_url":"https://api.github.com/users/dabaitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabaitu/subscriptions","organizations_url":"https://api.github.com/users/dabaitu/orgs","repos_url":"https://api.github.com/users/dabaitu/repos","events_url":"https://api.github.com/users/dabaitu/events{/privacy}","received_events_url":"https://api.github.com/users/dabaitu/received_events","type":"User","site_admin":false},"repo":{"id":63443798,"name":"presto","full_name":"dabaitu/presto","owner":{"login":"dabaitu","id":3894166,"avatar_url":"https://avatars.githubusercontent.com/u/3894166?v=3","gravatar_id":"","url":"https://api.github.com/users/dabaitu","html_url":"https://github.com/dabaitu","followers_url":"https://api.github.com/users/dabaitu/followers","following_url":"https://api.github.com/users/dabaitu/following{/other_user}","gists_url":"https://api.github.com/users/dabaitu/gists{/gist_id}","starred_url":"https://api.github.com/users/dabaitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabaitu/subscriptions","organizations_url":"https://api.github.com/users/dabaitu/orgs","repos_url":"https://api.github.com/users/dabaitu/repos","events_url":"https://api.github.com/users/dabaitu/events{/privacy}","received_events_url":"https://api.github.com/users/dabaitu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dabaitu/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/dabaitu/presto","forks_url":"https://api.github.com/repos/dabaitu/presto/forks","keys_url":"https://api.github.com/repos/dabaitu/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabaitu/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabaitu/presto/teams","hooks_url":"https://api.github.com/repos/dabaitu/presto/hooks","issue_events_url":"https://api.github.com/repos/dabaitu/presto/issues/events{/number}","events_url":"https://api.github.com/repos/dabaitu/presto/events","assignees_url":"https://api.github.com/repos/dabaitu/presto/assignees{/user}","branches_url":"https://api.github.com/repos/dabaitu/presto/branches{/branch}","tags_url":"https://api.github.com/repos/dabaitu/presto/tags","blobs_url":"https://api.github.com/repos/dabaitu/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabaitu/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabaitu/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabaitu/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabaitu/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/dabaitu/presto/languages","stargazers_url":"https://api.github.com/repos/dabaitu/presto/stargazers","contributors_url":"https://api.github.com/repos/dabaitu/presto/contributors","subscribers_url":"https://api.github.com/repos/dabaitu/presto/subscribers","subscription_url":"https://api.github.com/repos/dabaitu/presto/subscription","commits_url":"https://api.github.com/repos/dabaitu/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabaitu/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabaitu/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabaitu/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabaitu/presto/contents/{+path}","compare_url":"https://api.github.com/repos/dabaitu/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabaitu/presto/merges","archive_url":"https://api.github.com/repos/dabaitu/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabaitu/presto/downloads","issues_url":"https://api.github.com/repos/dabaitu/presto/issues{/number}","pulls_url":"https://api.github.com/repos/dabaitu/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/dabaitu/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/dabaitu/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabaitu/presto/labels{/name}","releases_url":"https://api.github.com/repos/dabaitu/presto/releases{/id}","deployments_url":"https://api.github.com/repos/dabaitu/presto/deployments","created_at":"2016-07-15T18:44:46Z","updated_at":"2016-07-15T18:44:58Z","pushed_at":"2016-08-18T18:48:46Z","git_url":"git://github.com/dabaitu/presto.git","ssh_url":"git@github.com:dabaitu/presto.git","clone_url":"https://github.com/dabaitu/presto.git","svn_url":"https://github.com/dabaitu/presto","homepage":"https://prestodb.io","size":60757,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/1"},"html":{"href":"https://github.com/dabaitu/presto/pull/1"},"issue":{"href":"https://api.github.com/repos/dabaitu/presto/issues/1"},"comments":{"href":"https://api.github.com/repos/dabaitu/presto/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dabaitu/presto/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dabaitu/presto/statuses/6e9bfea61ae214640c764d57da42aeaefced1387"}}}}
{"actor":{"display_login":"ZhihaoJia"}}