{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments/88710387","pull_request_review_id":9278154,"id":88710387,"diff_hunk":"@@ -25,6 +25,8 @@\n \n (def ^:private column-width \"calc(50% - 4px)\")\n \n+(defn count-owners [acl-vec]\n+  (count (filter #(= (:role %) owner-level) acl-vec)))","path":"src/cljs/org/broadinstitute/firecloud_ui/page/method_repo/methods_configs_acl.cljs","position":5,"original_position":5,"commit_id":"fff5c0686bec6ca949009520c34ea6b5d6a7eb52","original_commit_id":"fff5c0686bec6ca949009520c34ea6b5d6a7eb52","user":{"login":"MattPutnam","id":785011,"avatar_url":"https://avatars.githubusercontent.com/u/785011?v=3","gravatar_id":"","url":"https://api.github.com/users/MattPutnam","html_url":"https://github.com/MattPutnam","followers_url":"https://api.github.com/users/MattPutnam/followers","following_url":"https://api.github.com/users/MattPutnam/following{/other_user}","gists_url":"https://api.github.com/users/MattPutnam/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPutnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPutnam/subscriptions","organizations_url":"https://api.github.com/users/MattPutnam/orgs","repos_url":"https://api.github.com/users/MattPutnam/repos","events_url":"https://api.github.com/users/MattPutnam/events{/privacy}","received_events_url":"https://api.github.com/users/MattPutnam/received_events","type":"User","site_admin":false},"body":"Another option:\r\n\r\n    (defn count-owners [acl-vec]\r\n      (count (filter (comp #{owner-level} :role) acl-vec)))","created_at":"2016-11-18T18:23:43Z","updated_at":"2016-11-18T18:38:24Z","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/573#discussion_r88710387","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments/88710387"},"html":{"href":"https://github.com/broadinstitute/firecloud-ui/pull/573#discussion_r88710387"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573","id":94402458,"html_url":"https://github.com/broadinstitute/firecloud-ui/pull/573","diff_url":"https://github.com/broadinstitute/firecloud-ui/pull/573.diff","patch_url":"https://github.com/broadinstitute/firecloud-ui/pull/573.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/573","number":573,"state":"open","locked":false,"title":"GAWB-1236: Prevent single-owner acl from removing only owner permissions","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"PR for https://broadinstitute.atlassian.net/browse/GAWB-1236\r\n\r\nThis addresses, but does not complete GAWB-1236\r\nPlease see https://github.com/broadinstitute/agora/pull/171 for the Agora side of this PR. These can be tested separately.\r\n\r\nAdd a check for deletion of permissions to prevent removing all managers and therefore leaving the entity in an un-manageable state.\r\n\r\nLooking for feedback on the UI handling. The one thing I don't like is the following condition: \r\n* if there is a single owner ACL, then that ACL is appropriately disabled\r\n* upon adding new ACLs, or changing ACLs, that disabled state should toggle off if another owner is added.\r\n\r\n---\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [x] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * Add notes on what you've tested\r\n- [x] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [x] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [x] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [x] Tell the tech lead (TL) that the PR exists if they wants to look at it\r\n- [x] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n","created_at":"2016-11-18T17:24:14Z","updated_at":"2016-11-18T18:38:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"672e994f9c983b6b87338ec7ceb3ef7479a7f6bc","assignee":{"login":"MattPutnam","id":785011,"avatar_url":"https://avatars.githubusercontent.com/u/785011?v=3","gravatar_id":"","url":"https://api.github.com/users/MattPutnam","html_url":"https://github.com/MattPutnam","followers_url":"https://api.github.com/users/MattPutnam/followers","following_url":"https://api.github.com/users/MattPutnam/following{/other_user}","gists_url":"https://api.github.com/users/MattPutnam/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPutnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPutnam/subscriptions","organizations_url":"https://api.github.com/users/MattPutnam/orgs","repos_url":"https://api.github.com/users/MattPutnam/repos","events_url":"https://api.github.com/users/MattPutnam/events{/privacy}","received_events_url":"https://api.github.com/users/MattPutnam/received_events","type":"User","site_admin":false},"assignees":[{"login":"MattPutnam","id":785011,"avatar_url":"https://avatars.githubusercontent.com/u/785011?v=3","gravatar_id":"","url":"https://api.github.com/users/MattPutnam","html_url":"https://github.com/MattPutnam","followers_url":"https://api.github.com/users/MattPutnam/followers","following_url":"https://api.github.com/users/MattPutnam/following{/other_user}","gists_url":"https://api.github.com/users/MattPutnam/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPutnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPutnam/subscriptions","organizations_url":"https://api.github.com/users/MattPutnam/orgs","repos_url":"https://api.github.com/users/MattPutnam/repos","events_url":"https://api.github.com/users/MattPutnam/events{/privacy}","received_events_url":"https://api.github.com/users/MattPutnam/received_events","type":"User","site_admin":false},{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/573/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/fff5c0686bec6ca949009520c34ea6b5d6a7eb52","head":{"label":"broadinstitute:gr-GAWB-1236","ref":"gr-GAWB-1236","sha":"fff5c0686bec6ca949009520c34ea6b5d6a7eb52","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-ui","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2016-11-04T19:53:18Z","pushed_at":"2016-11-18T17:35:12Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":null,"size":2747,"stargazers_count":6,"watchers_count":6,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":6,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"2470a397f75a2a143bbbcbf5b781d3234b62698e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-ui","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2016-11-04T19:53:18Z","pushed_at":"2016-11-18T17:35:12Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":null,"size":2747,"stargazers_count":6,"watchers_count":6,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573"},"html":{"href":"https://github.com/broadinstitute/firecloud-ui/pull/573"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/573"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/fff5c0686bec6ca949009520c34ea6b5d6a7eb52"}}}}
{"actor":{"display_login":"MattPutnam"}}