{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1525","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1525/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1525/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1525/events","html_url":"https://github.com/ReactiveX/rxjs/pull/1525","id":142941714,"number":1525,"title":"fix(Symbol): $$observable is not defined","user":{"login":"bouzuya","id":1221346,"avatar_url":"https://avatars.githubusercontent.com/u/1221346?v=3","gravatar_id":"","url":"https://api.github.com/users/bouzuya","html_url":"https://github.com/bouzuya","followers_url":"https://api.github.com/users/bouzuya/followers","following_url":"https://api.github.com/users/bouzuya/following{/other_user}","gists_url":"https://api.github.com/users/bouzuya/gists{/gist_id}","starred_url":"https://api.github.com/users/bouzuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bouzuya/subscriptions","organizations_url":"https://api.github.com/users/bouzuya/orgs","repos_url":"https://api.github.com/users/bouzuya/repos","events_url":"https://api.github.com/users/bouzuya/events{/privacy}","received_events_url":"https://api.github.com/users/bouzuya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-23T11:58:12Z","updated_at":"2016-03-23T17:12:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1525","html_url":"https://github.com/ReactiveX/rxjs/pull/1525","diff_url":"https://github.com/ReactiveX/rxjs/pull/1525.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/1525.patch"},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to either Core or KitchenSink\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\n\r\n`$$observable` is not defined if `Symbol.observable` is defined.\r\n\r\nrxjs@5.0.0-beta.2 & is-observalbe@0.1.0\r\n\r\n```\r\nvar isObservable = require('is-observable');\r\nvar Observable = require('rxjs').Observable;\r\n\r\nconsole.log(isObservable(Observable.empty())); // true\r\n```\r\n\r\n```\r\nvar Observable = require('rxjs').Observable;\r\nvar isObservable = require('is-observable');\r\n\r\nconsole.log(isObservable(Observable.empty())); // true\r\n```\r\n\r\n\r\nrxjs@5.0.0-beta.3 & is-observalbe@0.1.0\r\n\r\n```\r\nvar isObservable = require('is-observable'); // Symbol.observable is defined\r\nvar Observable = require('rxjs').Observable;\r\n\r\nconsole.log(isObservable(Observable.empty())); // false\r\n```\r\n\r\n```\r\nvar Observable = require('rxjs').Observable;\r\nvar isObservable = require('is-observable');\r\n\r\nconsole.log(isObservable(Observable.empty())); // true\r\n```\r\n\r\n**Related issue (if exists):**\r\n"},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/200446705","html_url":"https://github.com/ReactiveX/rxjs/pull/1525#issuecomment-200446705","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1525","id":200446705,"user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T17:12:27Z","updated_at":"2016-03-23T17:12:27Z","body":"Maybe I understand incorrectly, is this related to https://github.com/ReactiveX/rxjs/issues/142, now Rx doesn't to further polyfills if symbol's defined?"}}