{"action":"created","issue":{"url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/73","repository_url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider","labels_url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/73/comments","events_url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/73/events","html_url":"https://github.com/fsprojects/AzureStorageTypeProvider/pull/73","id":160765210,"number":73,"title":"Proposed Fix for Issue #41","user":{"login":"stewart-r","id":5658894,"avatar_url":"https://avatars.githubusercontent.com/u/5658894?v=3","gravatar_id":"","url":"https://api.github.com/users/stewart-r","html_url":"https://github.com/stewart-r","followers_url":"https://api.github.com/users/stewart-r/followers","following_url":"https://api.github.com/users/stewart-r/following{/other_user}","gists_url":"https://api.github.com/users/stewart-r/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart-r/subscriptions","organizations_url":"https://api.github.com/users/stewart-r/orgs","repos_url":"https://api.github.com/users/stewart-r/repos","events_url":"https://api.github.com/users/stewart-r/events{/privacy}","received_events_url":"https://api.github.com/users/stewart-r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-16T21:27:52Z","updated_at":"2016-06-19T23:12:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/pulls/73","html_url":"https://github.com/fsprojects/AzureStorageTypeProvider/pull/73","diff_url":"https://github.com/fsprojects/AzureStorageTypeProvider/pull/73.diff","patch_url":"https://github.com/fsprojects/AzureStorageTypeProvider/pull/73.patch"},"body":"I believe this fixes this issue.\r\n\r\nInstead of simply using a batch size of 100 we now check the maximum possible size of the entity type we are given and calculate the batch size from there by dividing the max batch size by the max size of an entity then using the min of that result and 100.\r\n\r\nin order to calculate the max size of an entity I used the table [here](https://msdn.microsoft.com/en-us/library/dd179338.aspx)\r\n\r\nI did have a concern that as I am measuring only the properties on a ``DynamicTableEntity`` that later elements in the array may have a different set of properties but, on reflection, I don't think this is possible. I think it's impossible because, as it is being called from inside the `Insert` function, the ``DynamicTableEntity`` will have just been mapped from the generated table entity?\r\n"},"comment":{"url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/comments/227026257","html_url":"https://github.com/fsprojects/AzureStorageTypeProvider/pull/73#issuecomment-227026257","issue_url":"https://api.github.com/repos/fsprojects/AzureStorageTypeProvider/issues/73","id":227026257,"user":{"login":"isaacabraham","id":1781813,"avatar_url":"https://avatars.githubusercontent.com/u/1781813?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacabraham","html_url":"https://github.com/isaacabraham","followers_url":"https://api.github.com/users/isaacabraham/followers","following_url":"https://api.github.com/users/isaacabraham/following{/other_user}","gists_url":"https://api.github.com/users/isaacabraham/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacabraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacabraham/subscriptions","organizations_url":"https://api.github.com/users/isaacabraham/orgs","repos_url":"https://api.github.com/users/isaacabraham/repos","events_url":"https://api.github.com/users/isaacabraham/events{/privacy}","received_events_url":"https://api.github.com/users/isaacabraham/received_events","type":"User","site_admin":false},"created_at":"2016-06-19T23:12:28Z","updated_at":"2016-06-19T23:12:28Z","body":"Thanks for this - I was dreading doing it :-) I'm a bit busy over the next couple of days so apologies - but I *will* get around to reviewing this (and then no doubt accepting the PR)."}}
{"actor":{"display_login":"isaacabraham"}}