{"action":"created","comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/88141059","pull_request_review_id":8723947,"id":88141059,"diff_hunk":"@@ -315,7 +323,7 @@ inline int32 TransitionModel::TransitionIdToPdf(int32 trans_id) const {\n   KALDI_ASSERT(static_cast<size_t>(trans_id) < id2state_.size() &&\n                \"Likely graph/model mismatch (graph built from wrong model?)\");\n   int32 trans_state = id2state_[trans_id];\n-  return triples_[trans_state-1].pdf;","path":"src/hmm/transition-model.h","position":91,"original_position":91,"commit_id":"a440e4aa6696d7a64c998918ce96aa7feda37f0b","original_commit_id":"a440e4aa6696d7a64c998918ce96aa7feda37f0b","user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"body":"There is a problem in this function.  It needs to check whether it's a self-loop pdf, and possibly return self_loop_pdf.  BTW, I think we should consider changing the 'pdf' in the tuples and in the HMM-states to 'forward_pdf'.  This might be clearer.  What do you think?","created_at":"2016-11-15T23:50:48Z","updated_at":"2016-11-15T23:50:48Z","html_url":"https://github.com/kaldi-asr/kaldi/pull/1105#discussion_r88141059","pull_request_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105","_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/88141059"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/1105#discussion_r88141059"},"pull_request":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105"}}},"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105","id":88631158,"html_url":"https://github.com/kaldi-asr/kaldi/pull/1105","diff_url":"https://github.com/kaldi-asr/kaldi/pull/1105.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/1105.patch","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1105","number":1105,"state":"open","locked":false,"title":"WIP: Modify TransitionModel for more compact chain-model graphs","user":{"login":"naxingyu","id":3320260,"avatar_url":"https://avatars.githubusercontent.com/u/3320260?v=3","gravatar_id":"","url":"https://api.github.com/users/naxingyu","html_url":"https://github.com/naxingyu","followers_url":"https://api.github.com/users/naxingyu/followers","following_url":"https://api.github.com/users/naxingyu/following{/other_user}","gists_url":"https://api.github.com/users/naxingyu/gists{/gist_id}","starred_url":"https://api.github.com/users/naxingyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naxingyu/subscriptions","organizations_url":"https://api.github.com/users/naxingyu/orgs","repos_url":"https://api.github.com/users/naxingyu/repos","events_url":"https://api.github.com/users/naxingyu/events{/privacy}","received_events_url":"https://api.github.com/users/naxingyu/received_events","type":"User","site_admin":false},"body":"Place holder for addressing #1031 . WIP log:\r\n1. self_loop_pdf_class added to HmmState, done\r\n2. self_loop_pdf added to Tuple in TransitionModel. done\r\n3. another branch of ContextDependencyInterface::GetPdfInfo. ugly done\r\n4. create test code for new structures. done\r\n5. back compatability for all read code. done\r\n6. normal HMM validation using RM. done\r\n7. chain code modification. done\r\n8. chain validation using RM. done\r\n9. iterate 2nd version of GetPdfInfo. done\r\n10. documents and comments. tbd...\r\n","created_at":"2016-10-10T09:17:53Z","updated_at":"2016-11-15T23:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac57f03609b6b3b1b03271e18f0ee6de575562f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1105/comments","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/a440e4aa6696d7a64c998918ce96aa7feda37f0b","head":{"label":"naxingyu:modify-transition-model","ref":"modify-transition-model","sha":"a440e4aa6696d7a64c998918ce96aa7feda37f0b","user":{"login":"naxingyu","id":3320260,"avatar_url":"https://avatars.githubusercontent.com/u/3320260?v=3","gravatar_id":"","url":"https://api.github.com/users/naxingyu","html_url":"https://github.com/naxingyu","followers_url":"https://api.github.com/users/naxingyu/followers","following_url":"https://api.github.com/users/naxingyu/following{/other_user}","gists_url":"https://api.github.com/users/naxingyu/gists{/gist_id}","starred_url":"https://api.github.com/users/naxingyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naxingyu/subscriptions","organizations_url":"https://api.github.com/users/naxingyu/orgs","repos_url":"https://api.github.com/users/naxingyu/repos","events_url":"https://api.github.com/users/naxingyu/events{/privacy}","received_events_url":"https://api.github.com/users/naxingyu/received_events","type":"User","site_admin":false},"repo":{"id":48671146,"name":"kaldi","full_name":"naxingyu/kaldi","owner":{"login":"naxingyu","id":3320260,"avatar_url":"https://avatars.githubusercontent.com/u/3320260?v=3","gravatar_id":"","url":"https://api.github.com/users/naxingyu","html_url":"https://github.com/naxingyu","followers_url":"https://api.github.com/users/naxingyu/followers","following_url":"https://api.github.com/users/naxingyu/following{/other_user}","gists_url":"https://api.github.com/users/naxingyu/gists{/gist_id}","starred_url":"https://api.github.com/users/naxingyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naxingyu/subscriptions","organizations_url":"https://api.github.com/users/naxingyu/orgs","repos_url":"https://api.github.com/users/naxingyu/repos","events_url":"https://api.github.com/users/naxingyu/events{/privacy}","received_events_url":"https://api.github.com/users/naxingyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naxingyu/kaldi","description":"This is now the official location of the Kaldi project.","fork":true,"url":"https://api.github.com/repos/naxingyu/kaldi","forks_url":"https://api.github.com/repos/naxingyu/kaldi/forks","keys_url":"https://api.github.com/repos/naxingyu/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naxingyu/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naxingyu/kaldi/teams","hooks_url":"https://api.github.com/repos/naxingyu/kaldi/hooks","issue_events_url":"https://api.github.com/repos/naxingyu/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/naxingyu/kaldi/events","assignees_url":"https://api.github.com/repos/naxingyu/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/naxingyu/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/naxingyu/kaldi/tags","blobs_url":"https://api.github.com/repos/naxingyu/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naxingyu/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naxingyu/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/naxingyu/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naxingyu/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/naxingyu/kaldi/languages","stargazers_url":"https://api.github.com/repos/naxingyu/kaldi/stargazers","contributors_url":"https://api.github.com/repos/naxingyu/kaldi/contributors","subscribers_url":"https://api.github.com/repos/naxingyu/kaldi/subscribers","subscription_url":"https://api.github.com/repos/naxingyu/kaldi/subscription","commits_url":"https://api.github.com/repos/naxingyu/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/naxingyu/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/naxingyu/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/naxingyu/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/naxingyu/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/naxingyu/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naxingyu/kaldi/merges","archive_url":"https://api.github.com/repos/naxingyu/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naxingyu/kaldi/downloads","issues_url":"https://api.github.com/repos/naxingyu/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/naxingyu/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/naxingyu/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/naxingyu/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naxingyu/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/naxingyu/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/naxingyu/kaldi/deployments","created_at":"2015-12-28T03:11:49Z","updated_at":"2016-01-26T05:55:50Z","pushed_at":"2016-11-15T10:38:45Z","git_url":"git://github.com/naxingyu/kaldi.git","ssh_url":"git@github.com:naxingyu/kaldi.git","clone_url":"https://github.com/naxingyu/kaldi.git","svn_url":"https://github.com/naxingyu/kaldi","homepage":"http://kaldi-asr.org","size":103269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaldi-asr:master","ref":"master","sha":"463ef75eea339e22dcbf1da06c3d13323cbbcbf2","user":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":34275045,"name":"kaldi","full_name":"kaldi-asr/kaldi","owner":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaldi-asr/kaldi","description":"This is now the official location of the Kaldi project.","fork":false,"url":"https://api.github.com/repos/kaldi-asr/kaldi","forks_url":"https://api.github.com/repos/kaldi-asr/kaldi/forks","keys_url":"https://api.github.com/repos/kaldi-asr/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaldi-asr/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaldi-asr/kaldi/teams","hooks_url":"https://api.github.com/repos/kaldi-asr/kaldi/hooks","issue_events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/events","assignees_url":"https://api.github.com/repos/kaldi-asr/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/kaldi-asr/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/tags","blobs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/kaldi-asr/kaldi/languages","stargazers_url":"https://api.github.com/repos/kaldi-asr/kaldi/stargazers","contributors_url":"https://api.github.com/repos/kaldi-asr/kaldi/contributors","subscribers_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscribers","subscription_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscription","commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaldi-asr/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/kaldi-asr/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaldi-asr/kaldi/merges","archive_url":"https://api.github.com/repos/kaldi-asr/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaldi-asr/kaldi/downloads","issues_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/kaldi-asr/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/kaldi-asr/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/kaldi-asr/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/kaldi-asr/kaldi/deployments","created_at":"2015-04-20T17:23:16Z","updated_at":"2016-11-15T18:20:52Z","pushed_at":"2016-11-15T20:52:21Z","git_url":"git://github.com/kaldi-asr/kaldi.git","ssh_url":"git@github.com:kaldi-asr/kaldi.git","clone_url":"https://github.com/kaldi-asr/kaldi.git","svn_url":"https://github.com/kaldi-asr/kaldi","homepage":"http://kaldi-asr.org","size":151298,"stargazers_count":1291,"watchers_count":1291,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":650,"mirror_url":null,"open_issues_count":94,"forks":650,"open_issues":94,"watchers":1291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/1105"},"issue":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1105"},"comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/a440e4aa6696d7a64c998918ce96aa7feda37f0b"}}}}
{"actor":{"display_login":"danpovey"}}