{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/7356","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/7356/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7356/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/7356/events","html_url":"https://github.com/eslint/eslint/issues/7356","id":182880221,"number":7356,"title":"add outer padding to rule padded-blocks and cover existing jscs functionality","user":{"login":"quinn","id":3764,"avatar_url":"https://avatars.githubusercontent.com/u/3764?v=3","gravatar_id":"","url":"https://api.github.com/users/quinn","html_url":"https://github.com/quinn","followers_url":"https://api.github.com/users/quinn/followers","following_url":"https://api.github.com/users/quinn/following{/other_user}","gists_url":"https://api.github.com/users/quinn/gists{/gist_id}","starred_url":"https://api.github.com/users/quinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinn/subscriptions","organizations_url":"https://api.github.com/users/quinn/orgs","repos_url":"https://api.github.com/users/quinn/repos","events_url":"https://api.github.com/users/quinn/events{/privacy}","received_events_url":"https://api.github.com/users/quinn/received_events","type":"User","site_admin":false},"labels":[{"id":45711352,"url":"https://api.github.com/repos/eslint/eslint/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":255319420,"url":"https://api.github.com/repos/eslint/eslint/labels/evaluating","name":"evaluating","color":"fef2c0","default":false},{"id":45798639,"url":"https://api.github.com/repos/eslint/eslint/labels/rule","name":"rule","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/eslint/eslint/milestones/15","html_url":"https://github.com/eslint/eslint/milestones/JSCS%20Compatibility","labels_url":"https://api.github.com/repos/eslint/eslint/milestones/15/labels","id":1707375,"number":15,"title":"JSCS Compatibility","description":"","creator":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":27,"state":"open","created_at":"2016-04-14T18:09:38Z","updated_at":"2016-10-28T20:05:55Z","due_on":null,"closed_at":null},"comments":33,"created_at":"2016-10-13T19:36:53Z","updated_at":"2016-11-09T19:37:55Z","closed_at":null,"body":"## 1st proposal: updating padded-blocks\r\n```\r\n{\r\n  inner: \"always\" | \"never\" | \"before\" | \"after\"\r\n  outer: \"always\" | \"never\" | \"before\" | \"after\"\r\n  prefer: \"inner\" | \"outer\"\r\n  outerExceptions: \"inCallExpressions\" | \"inNewExpressions\" | \"inArrayExpressions\" | \"inProperties\" | \"singleLine\"\r\n  innerExceptions: \"blocks\" | \"classes\" | \"switches\"\r\n}\r\n```\r\n\r\nThe above doesn't yet include additional options for backwards compatibility. \r\n\r\nrelated issues:\r\n- https://github.com/eslint/eslint/issues/3092\r\n- https://github.com/eslint/eslint/issues/5982\r\n- https://github.com/eslint/eslint/issues/5949\r\n\r\nrelated / converging rules:\r\n- http://jscs.info/rule/requirePaddingNewLinesAfterBlocks.html\r\n- http://eslint.org/docs/rules/padded-blocks\r\n- I think jscs has another rule for padding before blocks?\r\n\r\n## ~~2nd proposal~~\r\n\r\n~~no modifications to `padded-blocks`. new rule that has exceptions to allow `padded-blocks` to work, if there is a conflict an error is thrown (is this even a thing?)~~\r\n\r\n```\r\n\"padding-around-blocks\": true | \"before\" | \"after\", {\r\n  \"exceptions\": \"inCallExpressions\" | \"inNewExpressions\" | \r\n                \"inArrayExpressions\" | \"inProperties\" | \"singleLine\" | \r\n                \"afterOpeningBlock\" | \"beforeEndingBlock\"\r\n}\r\n```\r\n\r\n~~`\"afterOpeningBlock\"` and `\"beforeEndingBlock\"` specify whether the rule should apply to a block placed at the beginning or end of the inside of another block. If they are both specified, then `padded-blocks` should work as expected. If they are not specified, then the new rule could potentially result in an error depending how `padded-blocks` is configured.~~"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/259505391","html_url":"https://github.com/eslint/eslint/issues/7356#issuecomment-259505391","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7356","id":259505391,"user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T19:37:55Z","updated_at":"2016-11-09T19:37:55Z","body":"Thanks for clarifying. My concern about starting to implement it right now would be that if other team members have some objection to the proposal, and we end up making changes to it before officially accepting the issue, then some the time you spend implementing this proposal might end up going to waste. But it's up to you."}}
{"actor":{"display_login":"not-an-aardvark"}}