{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/79759630","id":79759630,"diff_hunk":"@@ -536,11 +536,10 @@ protected function init() {\n \t\t\twindow.ss.config = \" . $this->getCombinedClientConfig() . \";\n \t\t\");\n \n-\t\tRequirements::javascript(ltrim(FRAMEWORK_ADMIN_DIR . '/client/dist/js/bundle-lib.js', '/'));\n+\t\tRequirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/vendor.js');","path":"admin/code/LeftAndMain.php","position":5,"original_position":5,"commit_id":"0e68570a1f6e9fb14ac2abf94ccb908cb845147d","original_commit_id":"9f4c1f63061bd46a4177aeef828ac30771c3ac94","user":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"body":"Was wondering where that came from - I thought it might've been David misunderstanding how the framework constants work...","created_at":"2016-09-21T04:38:51Z","updated_at":"2016-09-21T04:38:51Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/6049#discussion_r79759630","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/79759630"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/6049#discussion_r79759630"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049","id":86082939,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/6049","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/6049.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/6049.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6049","number":6049,"state":"open","locked":false,"title":"Optimise webpack build time","user":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"body":"Merge with https://github.com/silverstripe/silverstripe-cms/pull/1617","created_at":"2016-09-21T01:15:23Z","updated_at":"2016-09-21T04:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8718cc560721002d7c4507706b545433d2eda82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6049/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/0e68570a1f6e9fb14ac2abf94ccb908cb845147d","head":{"label":"open-sausages:pulls/4.0/webpack-optimise","ref":"pulls/4.0/webpack-optimise","sha":"0e68570a1f6e9fb14ac2abf94ccb908cb845147d","user":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"repo":{"id":37888247,"name":"silverstripe-framework","full_name":"open-sausages/silverstripe-framework","owner":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-sausages/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/open-sausages/silverstripe-framework","forks_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/open-sausages/silverstripe-framework/deployments","created_at":"2015-06-23T00:36:38Z","updated_at":"2015-06-23T00:36:43Z","pushed_at":"2016-09-21T04:30:56Z","git_url":"git://github.com/open-sausages/silverstripe-framework.git","ssh_url":"git@github.com:open-sausages/silverstripe-framework.git","clone_url":"https://github.com/open-sausages/silverstripe-framework.git","svn_url":"https://github.com/open-sausages/silverstripe-framework","homepage":"http://silverstripe.org/","size":90113,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"a85ba1222b2b6e830b131570291108e0430469cf","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2016-09-18T10:44:04Z","pushed_at":"2016-09-21T04:30:57Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":121280,"stargazers_count":520,"watchers_count":520,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":647,"forks":621,"open_issues":647,"watchers":520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/6049"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6049"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6049/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6049/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/0e68570a1f6e9fb14ac2abf94ccb908cb845147d"}}}}
{"actor":{"display_login":"chillu"}}