{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/48897954","id":48897954,"diff_hunk":"@@ -55,20 +55,75 @@\n @black: #000000;\n \n // # Text colors\n-@disabled-text-color: @gray-600;\n-@disabled-background-color: @gray-300;\n-@linkColor: @blue-700; // *TODO* convert var name to kebab?\n-@linkColorHover: saturate(@linkColor, 15%); // *TODO* convert var name to kebab?\n+@app-headers-text-color: @gray-900; // TODO: Once Approved,then Implement Into Components\n+@app-body-text-color: @gray-800; // TODO: Once Approved, then Implement Into Components\n+@disabled-background-color: @gray-300; // TODO: Change To Include \"app-\" prefix in Var Name, and Then Update Related Component LESS Files.\n+@disabled-text-color: @gray-600; // TODO: Same as above\n+@app-disabled-icon-color: @gray-600;\n+@link-color: @blue-700; // TODO: Change To Include \"app-\" prefix in Var Name, and Then Update Related Component LESS Files.\n+@link-hover-color: saturate(@link-color, 15%); // TODO: Change To Include \"app-\" prefix in Var Name, and Then Update Related Component LESS Files.\n+\n+// # App Default Borders\n+// TODO: Once Approved,then Define and Implement Into Components.\n+@app-default-border-color: @gray-400;\n+\n+// # App Margin and Padding\n+// TODO: Once Approved,then Define and Implement Into Components.\n+// Maybe these would be Mixins\n+// COULD BE LARGE EPIC FOR A SPRINT\n+@app-default-row-margin: 0;\n+@app-default-row-padding: 0;\n+@app-default-column-margin: 0;\n+@app-default-column-padding: 0;\n+\n+// # App UX Interactive States\n+// These could be used through many components when referring to the interactive states\n+// ex. rxDatePicker, rxPaginate, rxSelect, and etc.\n+// TODO: Once Approved, then Implement Into Components\n+@app-default-selected-background-color: @blue-700;\n+@app-default-selected-text-color: @white;\n+@app-default-hover-background-color: @blue-100;\n+@app-default-hover-text-color: @gray-900;\n+\n+// # Notifications\n+// These could be new Vars to sum up and consolidate rxNotify, rxSortColumn, and rxBulkSelect Warnings\n+// TODO: Once Approved, then Implement Into Components\n+@app-active-alert-background-color: @green-100;","path":"src/styles/vars.less","position":41,"original_position":41,"commit_id":"d266202de8e21dfb7972643dedda98f8d067fc8e","original_commit_id":"d266202de8e21dfb7972643dedda98f8d067fc8e","user":{"login":"glynnis","id":1529366,"avatar_url":"https://avatars.githubusercontent.com/u/1529366?v=3","gravatar_id":"","url":"https://api.github.com/users/glynnis","html_url":"https://github.com/glynnis","followers_url":"https://api.github.com/users/glynnis/followers","following_url":"https://api.github.com/users/glynnis/following{/other_user}","gists_url":"https://api.github.com/users/glynnis/gists{/gist_id}","starred_url":"https://api.github.com/users/glynnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glynnis/subscriptions","organizations_url":"https://api.github.com/users/glynnis/orgs","repos_url":"https://api.github.com/users/glynnis/repos","events_url":"https://api.github.com/users/glynnis/events{/privacy}","received_events_url":"https://api.github.com/users/glynnis/received_events","type":"User","site_admin":false},"body":":+1:","created_at":"2016-01-05T21:22:48Z","updated_at":"2016-01-05T21:22:48Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/1471#discussion_r48897954","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/48897954"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1471#discussion_r48897954"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471","id":54429645,"html_url":"https://github.com/rackerlabs/encore-ui/pull/1471","diff_url":"https://github.com/rackerlabs/encore-ui/pull/1471.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/1471.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1471","number":1471,"state":"open","locked":false,"title":"style(vars): FRMW-546 Setup Global Vars","user":{"login":"ssalinas24","id":14296817,"avatar_url":"https://avatars.githubusercontent.com/u/14296817?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas24","html_url":"https://github.com/ssalinas24","followers_url":"https://api.github.com/users/ssalinas24/followers","following_url":"https://api.github.com/users/ssalinas24/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas24/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas24/subscriptions","organizations_url":"https://api.github.com/users/ssalinas24/orgs","repos_url":"https://api.github.com/users/ssalinas24/repos","events_url":"https://api.github.com/users/ssalinas24/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas24/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.rax.io/browse/FRMW-546\r\n\r\n- [ ] Dev LGTM\r\n- [ ] Dev LGTM\r\n- [ ] Design LGTM\r\n\r\nI have added variables that I believe will help consolidate and unify some of the duplicated properties and styling that i have seen through out components. However, this is only based on my brief history with the framework, and the items that I have had related tasks to. I would highly appreciate any feedback from any DEVS that have way more history with the framework, in case I can add additional items that i may have missed.","created_at":"2015-12-23T00:13:23Z","updated_at":"2016-01-05T21:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db226333c5a8c50ba934169388861ee317544f46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1471/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/d266202de8e21dfb7972643dedda98f8d067fc8e","head":{"label":"rackerlabs:FRMW-546-setup-global-variables","ref":"FRMW-546-setup-global-variables","sha":"d266202de8e21dfb7972643dedda98f8d067fc8e","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-09-10T15:50:43Z","pushed_at":"2016-01-05T21:17:44Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":32041,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":16,"forks":48,"open_issues":16,"watchers":37,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"ab895aab0d6a24b7c91090953ca79dfdb3747d81","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-09-10T15:50:43Z","pushed_at":"2016-01-05T21:17:44Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":32041,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":16,"forks":48,"open_issues":16,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1471"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1471"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/d266202de8e21dfb7972643dedda98f8d067fc8e"}}}}