{"action":"created","issue":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/375","repository_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk","labels_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/375/labels{/name}","comments_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/375/comments","events_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/375/events","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/375","id":171637435,"number":375,"title":"Add GN build support for crosswalk-linux","user":{"login":"heke123","id":3487569,"avatar_url":"https://avatars.githubusercontent.com/u/3487569?v=3","gravatar_id":"","url":"https://api.github.com/users/heke123","html_url":"https://github.com/heke123","followers_url":"https://api.github.com/users/heke123/followers","following_url":"https://api.github.com/users/heke123/following{/other_user}","gists_url":"https://api.github.com/users/heke123/gists{/gist_id}","starred_url":"https://api.github.com/users/heke123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heke123/subscriptions","organizations_url":"https://api.github.com/users/heke123/orgs","repos_url":"https://api.github.com/users/heke123/repos","events_url":"https://api.github.com/users/heke123/events{/privacy}","received_events_url":"https://api.github.com/users/heke123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-17T11:43:15Z","updated_at":"2016-08-17T12:04:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/pulls/375","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/375","diff_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/375.diff","patch_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/375.patch"},"body":"As Chromium will deprecate GYP build system since M54, we need to enable\r\nGN build support for Crosswalk as soon as possible.\r\nSet xwalk as \"extra_deps\" to Chromium in xwalk/build/common.gni:\r\n`root_extra_deps = [ \"//xwalk:xwalk_builder\" ]`"},"comment":{"url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/comments/240391574","html_url":"https://github.com/crosswalk-project/chromium-crosswalk/pull/375#issuecomment-240391574","issue_url":"https://api.github.com/repos/crosswalk-project/chromium-crosswalk/issues/375","id":240391574,"user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T12:04:24Z","updated_at":"2016-08-17T12:04:24Z","body":"The changes look fine to me, but they need to be committed differently: the `enable_webvr` part should be a separate commit backported from upstream (use `git cherry-pick`, edit the commit message to mention it is a backport like [this one](https://github.com/crosswalk-project/chromium-crosswalk/commit/701504902f6ee7676d020ab88ff69982cb7426b4) and make sure it does not contain the \"Cr-Commit-Position\" line) and then you can add `xwalk` to the exec_script whitelist in another one (and explain why it is needed)."}}
{"actor":{"display_login":"rakuco"}}