{"action":"created","issue":{"url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/111","repository_url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle","labels_url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/111/comments","events_url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/111/events","html_url":"https://github.com/elixir-lang/elixir-tmbundle/pull/111","id":181020563,"number":111,"title":"Stop special-casing `when`","user":{"login":"princemaple","id":1329716,"avatar_url":"https://avatars.githubusercontent.com/u/1329716?v=3","gravatar_id":"","url":"https://api.github.com/users/princemaple","html_url":"https://github.com/princemaple","followers_url":"https://api.github.com/users/princemaple/followers","following_url":"https://api.github.com/users/princemaple/following{/other_user}","gists_url":"https://api.github.com/users/princemaple/gists{/gist_id}","starred_url":"https://api.github.com/users/princemaple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princemaple/subscriptions","organizations_url":"https://api.github.com/users/princemaple/orgs","repos_url":"https://api.github.com/users/princemaple/repos","events_url":"https://api.github.com/users/princemaple/events{/privacy}","received_events_url":"https://api.github.com/users/princemaple/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-04T22:23:39Z","updated_at":"2016-10-04T22:35:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/pulls/111","html_url":"https://github.com/elixir-lang/elixir-tmbundle/pull/111","diff_url":"https://github.com/elixir-lang/elixir-tmbundle/pull/111.diff","patch_url":"https://github.com/elixir-lang/elixir-tmbundle/pull/111.patch"},"body":"The syntax highlighting for `when` has being ambiguous and confusing.\r\nThis PR fixes the highlighting by removing the special highlighting for `when` in `def` and `defp`\r\n\r\nBefore:\r\n![sp161005_091841](https://cloud.githubusercontent.com/assets/1329716/19094643/ca1b4486-8adc-11e6-8a03-2abbb73cf19a.png)\r\n\r\nAfter:\r\n![sp161005_091728](https://cloud.githubusercontent.com/assets/1329716/19094596/9002885e-8adc-11e6-8e71-f9485cb4f03a.png)\r\n\r\nAlso, `when`s following `defmacro` and `defmacrop` are not special-cased, they look like \"After\".\r\n"},"comment":{"url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/comments/251533567","html_url":"https://github.com/elixir-lang/elixir-tmbundle/pull/111#issuecomment-251533567","issue_url":"https://api.github.com/repos/elixir-lang/elixir-tmbundle/issues/111","id":251533567,"user":{"login":"talklittle","id":87961,"avatar_url":"https://avatars.githubusercontent.com/u/87961?v=3","gravatar_id":"","url":"https://api.github.com/users/talklittle","html_url":"https://github.com/talklittle","followers_url":"https://api.github.com/users/talklittle/followers","following_url":"https://api.github.com/users/talklittle/following{/other_user}","gists_url":"https://api.github.com/users/talklittle/gists{/gist_id}","starred_url":"https://api.github.com/users/talklittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talklittle/subscriptions","organizations_url":"https://api.github.com/users/talklittle/orgs","repos_url":"https://api.github.com/users/talklittle/repos","events_url":"https://api.github.com/users/talklittle/events{/privacy}","received_events_url":"https://api.github.com/users/talklittle/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T22:35:27Z","updated_at":"2016-10-04T22:35:27Z","body":"The root problem is that `def`s spanning multiple lines are not recognized as part of the same expression.\r\n\r\nE.g. wrong variable highlighting of `var2` in:\r\n\r\n```\r\ndef myfunc(var1,\r\n           var2)\r\n```\r\n\r\nSo the inconsistent `when` highlighting is a symptom of the bigger underlying bug"}}
{"actor":{"display_login":"talklittle"}}