{"action":"opened","number":1968,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968","id":72209054,"html_url":"https://github.com/openshift/openshift-ansible/pull/1968","diff_url":"https://github.com/openshift/openshift-ansible/pull/1968.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1968.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1968","number":1968,"state":"open","locked":false,"title":"[v2] Move os_firewall_allow from defaults to role dependencies.","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"* Move `os_firewall_allow` from defaults to role dependencies for all roles.\r\n* Fix issue with openshift-loadbalancer refactor, ensuring that `haproxy_frontend_port` is fed from the playbook to drive firewall configuration.\r\n\r\nThe loadbalancer refactor changes were merged post cut so, if we're doing backports for critical fixes, these changes shouldn't be included in the update since the update won't be impacted by them.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1339431\r\n\r\n@detiber PTAL","created_at":"2016-06-01T16:10:28Z","updated_at":"2016-06-01T16:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1968/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/4b347b84711fdf0906fa3a270f51c38c23fe247e","head":{"label":"abutcher:os-firewall-eval","ref":"os-firewall-eval","sha":"4b347b84711fdf0906fa3a270f51c38c23fe247e","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"repo":{"id":40020725,"name":"openshift-ansible","full_name":"abutcher/openshift-ansible","owner":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abutcher/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/abutcher/openshift-ansible","forks_url":"https://api.github.com/repos/abutcher/openshift-ansible/forks","keys_url":"https://api.github.com/repos/abutcher/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abutcher/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abutcher/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/abutcher/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abutcher/openshift-ansible/events","assignees_url":"https://api.github.com/repos/abutcher/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abutcher/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abutcher/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abutcher/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/abutcher/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/abutcher/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abutcher/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abutcher/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abutcher/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abutcher/openshift-ansible/merges","archive_url":"https://api.github.com/repos/abutcher/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abutcher/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abutcher/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abutcher/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abutcher/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abutcher/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/abutcher/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/abutcher/openshift-ansible/deployments","created_at":"2015-07-31T19:07:31Z","updated_at":"2016-01-11T17:14:40Z","pushed_at":"2016-06-01T16:05:47Z","git_url":"git://github.com/abutcher/openshift-ansible.git","ssh_url":"git@github.com:abutcher/openshift-ansible.git","clone_url":"https://github.com/abutcher/openshift-ansible.git","svn_url":"https://github.com/abutcher/openshift-ansible","homepage":"","size":4984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"1c6787d2692a8060580b0e6ff37a26b87d08c701","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-06-01T03:03:27Z","pushed_at":"2016-06-01T14:58:53Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":6450,"stargazers_count":176,"watchers_count":176,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":309,"mirror_url":null,"open_issues_count":297,"forks":309,"open_issues":297,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1968"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1968"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1968/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1968/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/4b347b84711fdf0906fa3a270f51c38c23fe247e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":37,"deletions":39,"changed_files":11}}
{"actor":{"display_login":"abutcher"}}