{"action":"created","comment":{"url":"https://api.github.com/repos/erikrose/parsimonious/pulls/comments/79979585","id":79979585,"diff_hunk":"@@ -142,3 +142,8 @@ def visit_greeting(self, thing, visited_children):\n             raise PrimalScream('This should percolate up!')\n \n     assert_raises(PrimalScream, Screamer().parse, 'howdy')\n+\n+\n+def test_node_inequality():\n+    node = Node('text', 'o hai', 0, 5)\n+    assert node != 5","path":"parsimonious/tests/test_nodes.py","position":8,"original_position":8,"commit_id":"05e8aaa83c62e2e51530e3c84f4dab7a8e36a2d1","original_commit_id":"05e8aaa83c62e2e51530e3c84f4dab7a8e36a2d1","user":{"login":"cknv","id":123179,"avatar_url":"https://avatars.githubusercontent.com/u/123179?v=3","gravatar_id":"","url":"https://api.github.com/users/cknv","html_url":"https://github.com/cknv","followers_url":"https://api.github.com/users/cknv/followers","following_url":"https://api.github.com/users/cknv/following{/other_user}","gists_url":"https://api.github.com/users/cknv/gists{/gist_id}","starred_url":"https://api.github.com/users/cknv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cknv/subscriptions","organizations_url":"https://api.github.com/users/cknv/orgs","repos_url":"https://api.github.com/users/cknv/repos","events_url":"https://api.github.com/users/cknv/events{/privacy}","received_events_url":"https://api.github.com/users/cknv/received_events","type":"User","site_admin":false},"body":"Absolutely! I am mostly familiar with pytest and not much with nose, so I just hacked away at it until I had a failing test.","created_at":"2016-09-22T06:02:31Z","updated_at":"2016-09-22T06:02:31Z","html_url":"https://github.com/erikrose/parsimonious/pull/98#discussion_r79979585","pull_request_url":"https://api.github.com/repos/erikrose/parsimonious/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/comments/79979585"},"html":{"href":"https://github.com/erikrose/parsimonious/pull/98#discussion_r79979585"},"pull_request":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/erikrose/parsimonious/pulls/98","id":85535982,"html_url":"https://github.com/erikrose/parsimonious/pull/98","diff_url":"https://github.com/erikrose/parsimonious/pull/98.diff","patch_url":"https://github.com/erikrose/parsimonious/pull/98.patch","issue_url":"https://api.github.com/repos/erikrose/parsimonious/issues/98","number":98,"state":"open","locked":false,"title":"Type check when comparing nodes","user":{"login":"cknv","id":123179,"avatar_url":"https://avatars.githubusercontent.com/u/123179?v=3","gravatar_id":"","url":"https://api.github.com/users/cknv","html_url":"https://github.com/cknv","followers_url":"https://api.github.com/users/cknv/followers","following_url":"https://api.github.com/users/cknv/following{/other_user}","gists_url":"https://api.github.com/users/cknv/gists{/gist_id}","starred_url":"https://api.github.com/users/cknv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cknv/subscriptions","organizations_url":"https://api.github.com/users/cknv/orgs","repos_url":"https://api.github.com/users/cknv/repos","events_url":"https://api.github.com/users/cknv/events{/privacy}","received_events_url":"https://api.github.com/users/cknv/received_events","type":"User","site_admin":false},"body":"This should close #95 by making the `Node` give up comparisons with things that are not of its class.\r\n\r\nI went with returning `NotImplemented` as that gives `other` a chance to do the comparison.\r\n\r\nI thought about using\r\n```python\r\nif not isinstance(other, type(self)):\r\n    ...\r\n```\r\nBut I don't really know what is the preferred style, so I just went with the simpler.","created_at":"2016-09-16T08:33:34Z","updated_at":"2016-09-22T06:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5cf26f112035bda6a8cc382512a26f217d5a684","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/erikrose/parsimonious/pulls/98/commits","review_comments_url":"https://api.github.com/repos/erikrose/parsimonious/pulls/98/comments","review_comment_url":"https://api.github.com/repos/erikrose/parsimonious/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikrose/parsimonious/issues/98/comments","statuses_url":"https://api.github.com/repos/erikrose/parsimonious/statuses/05e8aaa83c62e2e51530e3c84f4dab7a8e36a2d1","head":{"label":"cknv:node-eq-improvement","ref":"node-eq-improvement","sha":"05e8aaa83c62e2e51530e3c84f4dab7a8e36a2d1","user":{"login":"cknv","id":123179,"avatar_url":"https://avatars.githubusercontent.com/u/123179?v=3","gravatar_id":"","url":"https://api.github.com/users/cknv","html_url":"https://github.com/cknv","followers_url":"https://api.github.com/users/cknv/followers","following_url":"https://api.github.com/users/cknv/following{/other_user}","gists_url":"https://api.github.com/users/cknv/gists{/gist_id}","starred_url":"https://api.github.com/users/cknv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cknv/subscriptions","organizations_url":"https://api.github.com/users/cknv/orgs","repos_url":"https://api.github.com/users/cknv/repos","events_url":"https://api.github.com/users/cknv/events{/privacy}","received_events_url":"https://api.github.com/users/cknv/received_events","type":"User","site_admin":false},"repo":{"id":68362357,"name":"parsimonious","full_name":"cknv/parsimonious","owner":{"login":"cknv","id":123179,"avatar_url":"https://avatars.githubusercontent.com/u/123179?v=3","gravatar_id":"","url":"https://api.github.com/users/cknv","html_url":"https://github.com/cknv","followers_url":"https://api.github.com/users/cknv/followers","following_url":"https://api.github.com/users/cknv/following{/other_user}","gists_url":"https://api.github.com/users/cknv/gists{/gist_id}","starred_url":"https://api.github.com/users/cknv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cknv/subscriptions","organizations_url":"https://api.github.com/users/cknv/orgs","repos_url":"https://api.github.com/users/cknv/repos","events_url":"https://api.github.com/users/cknv/events{/privacy}","received_events_url":"https://api.github.com/users/cknv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cknv/parsimonious","description":"The fastest pure-Python PEG parser I can muster","fork":true,"url":"https://api.github.com/repos/cknv/parsimonious","forks_url":"https://api.github.com/repos/cknv/parsimonious/forks","keys_url":"https://api.github.com/repos/cknv/parsimonious/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cknv/parsimonious/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cknv/parsimonious/teams","hooks_url":"https://api.github.com/repos/cknv/parsimonious/hooks","issue_events_url":"https://api.github.com/repos/cknv/parsimonious/issues/events{/number}","events_url":"https://api.github.com/repos/cknv/parsimonious/events","assignees_url":"https://api.github.com/repos/cknv/parsimonious/assignees{/user}","branches_url":"https://api.github.com/repos/cknv/parsimonious/branches{/branch}","tags_url":"https://api.github.com/repos/cknv/parsimonious/tags","blobs_url":"https://api.github.com/repos/cknv/parsimonious/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cknv/parsimonious/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cknv/parsimonious/git/refs{/sha}","trees_url":"https://api.github.com/repos/cknv/parsimonious/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cknv/parsimonious/statuses/{sha}","languages_url":"https://api.github.com/repos/cknv/parsimonious/languages","stargazers_url":"https://api.github.com/repos/cknv/parsimonious/stargazers","contributors_url":"https://api.github.com/repos/cknv/parsimonious/contributors","subscribers_url":"https://api.github.com/repos/cknv/parsimonious/subscribers","subscription_url":"https://api.github.com/repos/cknv/parsimonious/subscription","commits_url":"https://api.github.com/repos/cknv/parsimonious/commits{/sha}","git_commits_url":"https://api.github.com/repos/cknv/parsimonious/git/commits{/sha}","comments_url":"https://api.github.com/repos/cknv/parsimonious/comments{/number}","issue_comment_url":"https://api.github.com/repos/cknv/parsimonious/issues/comments{/number}","contents_url":"https://api.github.com/repos/cknv/parsimonious/contents/{+path}","compare_url":"https://api.github.com/repos/cknv/parsimonious/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cknv/parsimonious/merges","archive_url":"https://api.github.com/repos/cknv/parsimonious/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cknv/parsimonious/downloads","issues_url":"https://api.github.com/repos/cknv/parsimonious/issues{/number}","pulls_url":"https://api.github.com/repos/cknv/parsimonious/pulls{/number}","milestones_url":"https://api.github.com/repos/cknv/parsimonious/milestones{/number}","notifications_url":"https://api.github.com/repos/cknv/parsimonious/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cknv/parsimonious/labels{/name}","releases_url":"https://api.github.com/repos/cknv/parsimonious/releases{/id}","deployments_url":"https://api.github.com/repos/cknv/parsimonious/deployments","created_at":"2016-09-16T08:00:00Z","updated_at":"2016-09-16T08:00:01Z","pushed_at":"2016-09-16T08:16:21Z","git_url":"git://github.com/cknv/parsimonious.git","ssh_url":"git@github.com:cknv/parsimonious.git","clone_url":"https://github.com/cknv/parsimonious.git","svn_url":"https://github.com/cknv/parsimonious","homepage":"","size":356,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erikrose:master","ref":"master","sha":"538aac8454425e72f059fb2ca196a4187be4653f","user":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"repo":{"id":3343080,"name":"parsimonious","full_name":"erikrose/parsimonious","owner":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikrose/parsimonious","description":"The fastest pure-Python PEG parser I can muster","fork":false,"url":"https://api.github.com/repos/erikrose/parsimonious","forks_url":"https://api.github.com/repos/erikrose/parsimonious/forks","keys_url":"https://api.github.com/repos/erikrose/parsimonious/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikrose/parsimonious/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikrose/parsimonious/teams","hooks_url":"https://api.github.com/repos/erikrose/parsimonious/hooks","issue_events_url":"https://api.github.com/repos/erikrose/parsimonious/issues/events{/number}","events_url":"https://api.github.com/repos/erikrose/parsimonious/events","assignees_url":"https://api.github.com/repos/erikrose/parsimonious/assignees{/user}","branches_url":"https://api.github.com/repos/erikrose/parsimonious/branches{/branch}","tags_url":"https://api.github.com/repos/erikrose/parsimonious/tags","blobs_url":"https://api.github.com/repos/erikrose/parsimonious/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikrose/parsimonious/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikrose/parsimonious/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikrose/parsimonious/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikrose/parsimonious/statuses/{sha}","languages_url":"https://api.github.com/repos/erikrose/parsimonious/languages","stargazers_url":"https://api.github.com/repos/erikrose/parsimonious/stargazers","contributors_url":"https://api.github.com/repos/erikrose/parsimonious/contributors","subscribers_url":"https://api.github.com/repos/erikrose/parsimonious/subscribers","subscription_url":"https://api.github.com/repos/erikrose/parsimonious/subscription","commits_url":"https://api.github.com/repos/erikrose/parsimonious/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikrose/parsimonious/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikrose/parsimonious/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikrose/parsimonious/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikrose/parsimonious/contents/{+path}","compare_url":"https://api.github.com/repos/erikrose/parsimonious/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikrose/parsimonious/merges","archive_url":"https://api.github.com/repos/erikrose/parsimonious/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikrose/parsimonious/downloads","issues_url":"https://api.github.com/repos/erikrose/parsimonious/issues{/number}","pulls_url":"https://api.github.com/repos/erikrose/parsimonious/pulls{/number}","milestones_url":"https://api.github.com/repos/erikrose/parsimonious/milestones{/number}","notifications_url":"https://api.github.com/repos/erikrose/parsimonious/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikrose/parsimonious/labels{/name}","releases_url":"https://api.github.com/repos/erikrose/parsimonious/releases{/id}","deployments_url":"https://api.github.com/repos/erikrose/parsimonious/deployments","created_at":"2012-02-03T09:10:42Z","updated_at":"2016-09-21T17:19:23Z","pushed_at":"2016-09-16T08:33:34Z","git_url":"git://github.com/erikrose/parsimonious.git","ssh_url":"git@github.com:erikrose/parsimonious.git","clone_url":"https://github.com/erikrose/parsimonious.git","svn_url":"https://github.com/erikrose/parsimonious","homepage":"","size":391,"stargazers_count":624,"watchers_count":624,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":31,"forks":54,"open_issues":31,"watchers":624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/98"},"html":{"href":"https://github.com/erikrose/parsimonious/pull/98"},"issue":{"href":"https://api.github.com/repos/erikrose/parsimonious/issues/98"},"comments":{"href":"https://api.github.com/repos/erikrose/parsimonious/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikrose/parsimonious/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/erikrose/parsimonious/statuses/05e8aaa83c62e2e51530e3c84f4dab7a8e36a2d1"}}}}
{"actor":{"display_login":"cknv"}}