{"action":"closed","issue":{"url":"https://api.github.com/repos/jterrace/pyssim/issues/20","repository_url":"https://api.github.com/repos/jterrace/pyssim","labels_url":"https://api.github.com/repos/jterrace/pyssim/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/jterrace/pyssim/issues/20/comments","events_url":"https://api.github.com/repos/jterrace/pyssim/issues/20/events","html_url":"https://github.com/jterrace/pyssim/issues/20","id":164570223,"number":20,"title":"Explicitly list dependencies in setup.py","user":{"login":"asottile","id":1810591,"avatar_url":"https://avatars.githubusercontent.com/u/1810591?v=3","gravatar_id":"","url":"https://api.github.com/users/asottile","html_url":"https://github.com/asottile","followers_url":"https://api.github.com/users/asottile/followers","following_url":"https://api.github.com/users/asottile/following{/other_user}","gists_url":"https://api.github.com/users/asottile/gists{/gist_id}","starred_url":"https://api.github.com/users/asottile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asottile/subscriptions","organizations_url":"https://api.github.com/users/asottile/orgs","repos_url":"https://api.github.com/users/asottile/repos","events_url":"https://api.github.com/users/asottile/events{/privacy}","received_events_url":"https://api.github.com/users/asottile/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-08T16:42:36Z","updated_at":"2016-07-08T19:45:14Z","closed_at":"2016-07-08T19:45:14Z","body":"Currently I can do the following:\r\n\r\n```\r\nvirtualenv venv\r\nvenv/bin/pip install numpy scipy pillow\r\nvenv/bin/pip wheel pyssim -w .\r\n```\r\n\r\nThis will build a wheel of pyssim.\r\n\r\nThen I will attempt to install that wheel in another virtualenv\r\n\r\n```\r\nvirtualenv venv2\r\nvenv2/bin/pip install pyssim-0.3-py2-none-any.whl\r\n```\r\n\r\nThen I try and use pyssim:\r\n\r\n```\r\n$ ./venv2/bin/python -c 'import ssim'\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 1, in <module>\r\n  File \"/tmp/foo/venv2/local/lib/python2.7/site-packages/ssim/__init__.py\", line 5, in <module>\r\n    from ssim.ssimlib import SSIM\r\n  File \"/tmp/foo/venv2/local/lib/python2.7/site-packages/ssim/ssimlib.py\", line 9, in <module>\r\n    import numpy as np\r\nImportError: No module named numpy\r\n```\r\n\r\n*BOOM*\r\n\r\nThe reasoning for this:\r\nYou should specify your dependencies statically in setup.py and not optionally based on imports :)"}}
{"actor":{"display_login":"jterrace"}}