{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/65668333","id":65668333,"diff_hunk":"@@ -1816,6 +1810,8 @@ simple_pattern_not_ident:\n       { $1 }\n   | mod_longident DOT simple_delimited_pattern\n       { mkpat @@ Ppat_open(mkrhs $1 1, $3) }\n+  | mod_longident DOT LBRACKET RBRACKET\n+    { mkpat @@ Ppat_construct ( mkrhs (Lident \"[]\") 1, None) }","path":"parsing/parser.mly","position":null,"original_position":18,"commit_id":"1c4ee3a41aa0ff920289bad816278a99c5acfe22","original_commit_id":"3dc3f1d5acae4ae1f6f1eb5842dbac2867d1c730","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"body":"Thanks for the comments.  I intentionally kept the behaviour the same as trunk, where `M` is ignored in the pattern `M.[]`.  But I agree that using `M` to resolve `[]` is better, so I've added `Ppat_open` in 1c4ee3a.","created_at":"2016-06-03T07:48:13Z","updated_at":"2016-06-03T07:48:13Z","html_url":"https://github.com/ocaml/ocaml/pull/599#discussion_r65668333","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/599","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/65668333"},"html":{"href":"https://github.com/ocaml/ocaml/pull/599#discussion_r65668333"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/599"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/599","id":72094078,"html_url":"https://github.com/ocaml/ocaml/pull/599","diff_url":"https://github.com/ocaml/ocaml/pull/599.diff","patch_url":"https://github.com/ocaml/ocaml/pull/599.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/599","number":599,"state":"open","locked":false,"title":"Fix the reduce/reduce conflicts in the grammar","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"body":"This pull request fixes the conflicts in the grammar in the current trunk.  The present status of `parsing/parser.mly` is as follows:\r\n\r\n```\r\nboot/ocamlyacc -v -e parsing/parser.mly\r\n1 rule never reduced\r\n126 reduce/reduce conflicts.\r\n```\r\n\r\nHappily, the conflicts all have straightforward resolutions.  The changes are as follows:\r\n\r\n * The following productions are removed:\r\n\r\n   ```\r\n   pattern -> mod_longident DOT LPAREN pattern RPAREN\r\n   pattern -> mod_longident DOT LPAREN pattern error\r\n   pattern -> mod_longident DOT LPAREN error\r\n   ```\r\n\r\n   These productions are redundant because the RHSs can be generated via different routes:\r\n\r\n   ```\r\n   pattern ->\r\n     pattern_gen ->\r\n       simple_pattern ->\r\n          simple_pattern_not_ident ->\r\n             mod_longident DOT LPAREN pattern RPAREN\r\n   ```\r\n   (etc.)\r\n\r\n * The following duplication is removed:\r\n\r\n   ```\r\n   simple_delimited_pattern -> LBRACE lbl_pattern_list error\r\n   simple_delimited_pattern -> LBRACE lbl_pattern_list error\r\n   ```\r\n\r\n * The following redundancy\r\n\r\n   ```\r\n   simple_pattern_not_ident ->\r\n      simple_delimited_pattern ->\r\n         LBRACKET RBRACKET\r\n   simple_pattern_not_ident ->\r\n      constr_longident ->\r\n         LBRACKET RBRACKET\r\n   ```\r\n\r\n   is replaced by removing the first production and adding a new production for qualified `[]` patterns:\r\n\r\n   ```\r\n   simple_pattern_not_ident -> mod_longident DOT LBRACKET RBRACKET\r\n   ```\r\n","created_at":"2016-05-31T22:09:46Z","updated_at":"2016-06-03T07:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c203bf16c9d522650a76071bde32c4b33389638f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/599/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/599/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/599/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/1c4ee3a41aa0ff920289bad816278a99c5acfe22","head":{"label":"yallop:fix-local-open-pattern-grammar","ref":"fix-local-open-pattern-grammar","sha":"1c4ee3a41aa0ff920289bad816278a99c5acfe22","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"repo":{"id":7024227,"name":"ocaml","full_name":"yallop/ocaml","owner":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yallop/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/yallop/ocaml","forks_url":"https://api.github.com/repos/yallop/ocaml/forks","keys_url":"https://api.github.com/repos/yallop/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yallop/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yallop/ocaml/teams","hooks_url":"https://api.github.com/repos/yallop/ocaml/hooks","issue_events_url":"https://api.github.com/repos/yallop/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/yallop/ocaml/events","assignees_url":"https://api.github.com/repos/yallop/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/yallop/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/yallop/ocaml/tags","blobs_url":"https://api.github.com/repos/yallop/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yallop/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yallop/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/yallop/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yallop/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/yallop/ocaml/languages","stargazers_url":"https://api.github.com/repos/yallop/ocaml/stargazers","contributors_url":"https://api.github.com/repos/yallop/ocaml/contributors","subscribers_url":"https://api.github.com/repos/yallop/ocaml/subscribers","subscription_url":"https://api.github.com/repos/yallop/ocaml/subscription","commits_url":"https://api.github.com/repos/yallop/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/yallop/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/yallop/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/yallop/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/yallop/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/yallop/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yallop/ocaml/merges","archive_url":"https://api.github.com/repos/yallop/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yallop/ocaml/downloads","issues_url":"https://api.github.com/repos/yallop/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/yallop/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/yallop/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/yallop/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yallop/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/yallop/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/yallop/ocaml/deployments","created_at":"2012-12-05T20:38:01Z","updated_at":"2015-01-22T22:17:32Z","pushed_at":"2016-06-03T07:45:20Z","git_url":"git://github.com/yallop/ocaml.git","ssh_url":"git@github.com:yallop/ocaml.git","clone_url":"https://github.com/yallop/ocaml.git","svn_url":"https://github.com/yallop/ocaml","homepage":null,"size":136654,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"f54c38ba0c88a74b710ff392cf466c0427dc7b26","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2016-06-02T12:55:52Z","pushed_at":"2016-06-03T07:45:21Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":233838,"stargazers_count":802,"watchers_count":802,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":103,"forks":252,"open_issues":103,"watchers":802,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/599"},"html":{"href":"https://github.com/ocaml/ocaml/pull/599"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/599"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/599/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/599/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/599/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/1c4ee3a41aa0ff920289bad816278a99c5acfe22"}}}}
{"actor":{"display_login":"yallop"}}