{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/88848298","pull_request_review_id":9407521,"id":88848298,"diff_hunk":"@@ -506,15 +520,63 @@ declare namespace webpack {\n     }\n \n     interface DefinePluginStatic {\n-        new (definitions: any): Plugin;\n+        new (definitions: {[key: string]: any}): Plugin;\n     }\n \n     interface ProvidePluginStatic {\n-        new (definitions: any): Plugin;\n+        new (definitions: {[key: string]: any}): Plugin;\n     }\n \n     interface SourceMapDevToolPluginStatic {\n-        new (options: any): Plugin;\n+        new (options?: SourceMapDevToolPluginOptions): Plugin;\n+    }\n+\n+    // if string | false | null, maps to the filename option\n+    type SourceMapDevToolPluginOptions = string | false | null | {\n+        // output filename pattern (false/null to append)\n+        filename?: string | false | null,\n+        // source map comment pattern (false to not append)\n+        append?: false | string,\n+        // template for the module filename inside the source map\n+        moduleFilenameTemplate?: string,\n+        // fallback used when the moduleFilenameTemplate produces a collision\n+        fallbackModuleFilenameTemplate?: string,\n+        // test/include/exclude files\n+        test?: Condition | Condition[],\n+        include?: Condition | Condition[],\n+        exclude?: Condition | Condition[]\n+        // whether to include the footer comment with source information\n+        noSources?: boolean,\n+        // the source map sourceRoot (\"The URL root from which all sources are relative.\")\n+        sourceRoot?: string | null,","path":"webpack/index.d.ts","position":152,"original_position":152,"commit_id":"321afeee70686e630c0df36b12a8461c22f38e80","original_commit_id":"321afeee70686e630c0df36b12a8461c22f38e80","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars.githubusercontent.com/u/73085?v=3","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"body":"`string | falsy`","created_at":"2016-11-21T08:39:56Z","updated_at":"2016-11-21T08:39:56Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821#discussion_r88848298","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/88848298"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821#discussion_r88848298"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821","id":94572685,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12821","number":12821,"state":"open","locked":false,"title":"Improve webpack 2 definitions","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars.githubusercontent.com/u/73085?v=3","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"body":"- [x] Prefer to make your PR against the `types-2.0` branch.\r\n- [x] Test the change in your own code.\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes).\r\n- [x] Run `npm run lint -- package-name` if a `tslint.json` is present.\r\n\r\nThere were some preexisting lint failures, but I didn't try fixing them here.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to  documentation or source code which provides context for the suggested changes:\r\n* https://github.com/webpack/webpack/blob/master/lib/webpack.js\r\n* https://github.com/webpack/webpack/blob/master/lib/NamedModulesPlugin.js\r\n* https://github.com/webpack/webpack/blob/master/lib/SourceMapDevToolPlugin.js\r\n* https://github.com/webpack/webpack/blob/master/lib/EvalSourceMapDevToolPlugin.js\r\n* https://github.com/webpack/webpack/blob/master/lib/ModuleFilenameHelpers.js\r\n* https://github.com/webpack/webpack/blob/master/lib/SourceMapDevToolModuleOptionsPlugin.js\r\n* https://github.com/webpack/webpack-sources/blob/master/lib/SourceAndMapMixin.js\r\n* I believe `sourceRoot` is meant to be consumed by the `source-map` module.\r\n- [x] Increase the version number in the header if appropriate.\r\n","created_at":"2016-11-21T08:37:45Z","updated_at":"2016-11-21T08:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0321eb78f1d14bb9e2798e025aa58daa3c1177f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12821/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/321afeee70686e630c0df36b12a8461c22f38e80","head":{"label":"Kovensky:patch-2","ref":"patch-2","sha":"321afeee70686e630c0df36b12a8461c22f38e80","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars.githubusercontent.com/u/73085?v=3","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"repo":{"id":64543448,"name":"DefinitelyTyped","full_name":"Kovensky/DefinitelyTyped","owner":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars.githubusercontent.com/u/73085?v=3","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kovensky/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/Kovensky/DefinitelyTyped","forks_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/Kovensky/DefinitelyTyped/deployments","created_at":"2016-07-30T12:40:02Z","updated_at":"2016-07-30T12:40:10Z","pushed_at":"2016-11-21T08:31:02Z","git_url":"git://github.com/Kovensky/DefinitelyTyped.git","ssh_url":"git@github.com:Kovensky/DefinitelyTyped.git","clone_url":"https://github.com/Kovensky/DefinitelyTyped.git","svn_url":"https://github.com/Kovensky/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":139314,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:types-2.0","ref":"types-2.0","sha":"dff6949f85bbe4cc9f374ba8c342ab4381128315","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-11-21T03:59:55Z","pushed_at":"2016-11-21T08:37:45Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":227730,"stargazers_count":8973,"watchers_count":8973,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7105,"mirror_url":null,"open_issues_count":1240,"forks":7105,"open_issues":1240,"watchers":8973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12821"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12821"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12821/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12821/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/321afeee70686e630c0df36b12a8461c22f38e80"}}}}
{"actor":{"display_login":"Kovensky"}}