{"action":"created","comment":{"url":"https://api.github.com/repos/openemr/openemr/pulls/comments/73113817","id":73113817,"diff_hunk":"@@ -375,6 +375,7 @@ function ActiveIssueCodeRecycleFn($thispid2, $ISSUE_TYPES2) {\n <html>\n <head>\n <?php html_header_show();?>\n+    <script type=\"text/javascript\" src=\"<?php echo $GLOBALS['assets_static_relative']; ?>/jquery-min-1-9-1/index.js\"></script>","path":"interface/patient_file/summary/add_edit_issue.php","position":4,"original_position":4,"commit_id":"402770a8e63d9c9eae66fd88225dcc137f149939","original_commit_id":"ed504dc2c8741d1e82b978e19896aded7e270a6d","user":{"login":"matrix-drorgo","id":18376627,"avatar_url":"https://avatars.githubusercontent.com/u/18376627?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-drorgo","html_url":"https://github.com/matrix-drorgo","followers_url":"https://api.github.com/users/matrix-drorgo/followers","following_url":"https://api.github.com/users/matrix-drorgo/following{/other_user}","gists_url":"https://api.github.com/users/matrix-drorgo/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-drorgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-drorgo/subscriptions","organizations_url":"https://api.github.com/users/matrix-drorgo/orgs","repos_url":"https://api.github.com/users/matrix-drorgo/repos","events_url":"https://api.github.com/users/matrix-drorgo/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-drorgo/received_events","type":"User","site_admin":false},"body":"The jquery has already been moved to line 378 . ","created_at":"2016-08-02T08:27:38Z","updated_at":"2016-08-02T08:27:38Z","html_url":"https://github.com/openemr/openemr/pull/164#discussion_r73113817","pull_request_url":"https://api.github.com/repos/openemr/openemr/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/openemr/openemr/pulls/comments/73113817"},"html":{"href":"https://github.com/openemr/openemr/pull/164#discussion_r73113817"},"pull_request":{"href":"https://api.github.com/repos/openemr/openemr/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/openemr/openemr/pulls/164","id":79147478,"html_url":"https://github.com/openemr/openemr/pull/164","diff_url":"https://github.com/openemr/openemr/pull/164.diff","patch_url":"https://github.com/openemr/openemr/pull/164.patch","issue_url":"https://api.github.com/repos/openemr/openemr/issues/164","number":164,"state":"open","locked":false,"title":"New feature for page validation","user":{"login":"matrix-drorgo","id":18376627,"avatar_url":"https://avatars.githubusercontent.com/u/18376627?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-drorgo","html_url":"https://github.com/matrix-drorgo","followers_url":"https://api.github.com/users/matrix-drorgo/followers","following_url":"https://api.github.com/users/matrix-drorgo/following{/other_user}","gists_url":"https://api.github.com/users/matrix-drorgo/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-drorgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-drorgo/subscriptions","organizations_url":"https://api.github.com/users/matrix-drorgo/orgs","repos_url":"https://api.github.com/users/matrix-drorgo/repos","events_url":"https://api.github.com/users/matrix-drorgo/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-drorgo/received_events","type":"User","site_admin":false},"body":"This feature should upgrade the page forms validation in all of the openemr system to use validate.js library.The purpose was to add the ability to validate pages forms and fields  in the system using the list_options table and use it all around the forms in the openemr in a little of customization and code writing.\r\n\r\nin these branch we did the implementation in the add_edit_issue.php form.\r\n\r\nIn order to use this feature first you will need to create a new page validation under administration->lists there under The PageValidation list add using the validate.js library validation format add the new fields validations.\r\n\r\nbelow is an example for two fields form_title and form_diagnosis in add_edit_issue.php that needs to be validated on submit.\r\n \r\nID = add_edit_issue    //this is the id of the record in the database\r\nTITLE = add_edit_issue.php      //this is the page file in the system\r\nActive = 0/1\r\nNotes = {form_title:{presence: true},form_diagnosis:{presence: true}}  //this is the page format \r\n\r\nAfter creating this record  Globals.php will collect all the pages that need to be validated.\r\nall that left is to go in the page needed and like in add_edit_issue.php validate these fields using \r\nthe submitme function that is implemented in the \r\n/home/drorgo/projects/openemrValidation/openemr/library/validation/validation_script.js.php\r\n\r\nfile..\r\n\r\n****8 To have backward compatibility when adding these feature in other forms ,the actual hardcoded validation rules should be translated to the new validate.js rules and inserted to lists using the steps I have mentioned above.\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2016-07-28T07:15:22Z","updated_at":"2016-08-02T08:27:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59d181d969435f959a6457ac29ff8b0d38c553ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openemr/openemr/pulls/164/commits","review_comments_url":"https://api.github.com/repos/openemr/openemr/pulls/164/comments","review_comment_url":"https://api.github.com/repos/openemr/openemr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openemr/openemr/issues/164/comments","statuses_url":"https://api.github.com/repos/openemr/openemr/statuses/402770a8e63d9c9eae66fd88225dcc137f149939","head":{"label":"matrix-israel:DG/PageValidationCheckJS","ref":"DG/PageValidationCheckJS","sha":"402770a8e63d9c9eae66fd88225dcc137f149939","user":{"login":"matrix-israel","id":17746552,"avatar_url":"https://avatars.githubusercontent.com/u/17746552?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-israel","html_url":"https://github.com/matrix-israel","followers_url":"https://api.github.com/users/matrix-israel/followers","following_url":"https://api.github.com/users/matrix-israel/following{/other_user}","gists_url":"https://api.github.com/users/matrix-israel/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-israel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-israel/subscriptions","organizations_url":"https://api.github.com/users/matrix-israel/orgs","repos_url":"https://api.github.com/users/matrix-israel/repos","events_url":"https://api.github.com/users/matrix-israel/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-israel/received_events","type":"Organization","site_admin":false},"repo":{"id":54314139,"name":"openemr","full_name":"matrix-israel/openemr","owner":{"login":"matrix-israel","id":17746552,"avatar_url":"https://avatars.githubusercontent.com/u/17746552?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-israel","html_url":"https://github.com/matrix-israel","followers_url":"https://api.github.com/users/matrix-israel/followers","following_url":"https://api.github.com/users/matrix-israel/following{/other_user}","gists_url":"https://api.github.com/users/matrix-israel/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-israel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-israel/subscriptions","organizations_url":"https://api.github.com/users/matrix-israel/orgs","repos_url":"https://api.github.com/users/matrix-israel/repos","events_url":"https://api.github.com/users/matrix-israel/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-israel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-israel/openemr","description":"Mirror of official OpenEMR Sourceforge repository","fork":true,"url":"https://api.github.com/repos/matrix-israel/openemr","forks_url":"https://api.github.com/repos/matrix-israel/openemr/forks","keys_url":"https://api.github.com/repos/matrix-israel/openemr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-israel/openemr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-israel/openemr/teams","hooks_url":"https://api.github.com/repos/matrix-israel/openemr/hooks","issue_events_url":"https://api.github.com/repos/matrix-israel/openemr/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-israel/openemr/events","assignees_url":"https://api.github.com/repos/matrix-israel/openemr/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-israel/openemr/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-israel/openemr/tags","blobs_url":"https://api.github.com/repos/matrix-israel/openemr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-israel/openemr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-israel/openemr/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-israel/openemr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-israel/openemr/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-israel/openemr/languages","stargazers_url":"https://api.github.com/repos/matrix-israel/openemr/stargazers","contributors_url":"https://api.github.com/repos/matrix-israel/openemr/contributors","subscribers_url":"https://api.github.com/repos/matrix-israel/openemr/subscribers","subscription_url":"https://api.github.com/repos/matrix-israel/openemr/subscription","commits_url":"https://api.github.com/repos/matrix-israel/openemr/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-israel/openemr/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-israel/openemr/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-israel/openemr/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-israel/openemr/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-israel/openemr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-israel/openemr/merges","archive_url":"https://api.github.com/repos/matrix-israel/openemr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-israel/openemr/downloads","issues_url":"https://api.github.com/repos/matrix-israel/openemr/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-israel/openemr/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-israel/openemr/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-israel/openemr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-israel/openemr/labels{/name}","releases_url":"https://api.github.com/repos/matrix-israel/openemr/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-israel/openemr/deployments","created_at":"2016-03-20T11:32:59Z","updated_at":"2016-03-22T10:56:31Z","pushed_at":"2016-08-02T08:15:52Z","git_url":"git://github.com/matrix-israel/openemr.git","ssh_url":"git@github.com:matrix-israel/openemr.git","clone_url":"https://github.com/matrix-israel/openemr.git","svn_url":"https://github.com/matrix-israel/openemr","homepage":"http://open-emr.org/","size":257107,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openemr:master","ref":"master","sha":"f23541d26b9b60e0b18e7b2b391acfb88e24566d","user":{"login":"openemr","id":283089,"avatar_url":"https://avatars.githubusercontent.com/u/283089?v=3","gravatar_id":"","url":"https://api.github.com/users/openemr","html_url":"https://github.com/openemr","followers_url":"https://api.github.com/users/openemr/followers","following_url":"https://api.github.com/users/openemr/following{/other_user}","gists_url":"https://api.github.com/users/openemr/gists{/gist_id}","starred_url":"https://api.github.com/users/openemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openemr/subscriptions","organizations_url":"https://api.github.com/users/openemr/orgs","repos_url":"https://api.github.com/users/openemr/repos","events_url":"https://api.github.com/users/openemr/events{/privacy}","received_events_url":"https://api.github.com/users/openemr/received_events","type":"User","site_admin":false},"repo":{"id":679584,"name":"openemr","full_name":"openemr/openemr","owner":{"login":"openemr","id":283089,"avatar_url":"https://avatars.githubusercontent.com/u/283089?v=3","gravatar_id":"","url":"https://api.github.com/users/openemr","html_url":"https://github.com/openemr","followers_url":"https://api.github.com/users/openemr/followers","following_url":"https://api.github.com/users/openemr/following{/other_user}","gists_url":"https://api.github.com/users/openemr/gists{/gist_id}","starred_url":"https://api.github.com/users/openemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openemr/subscriptions","organizations_url":"https://api.github.com/users/openemr/orgs","repos_url":"https://api.github.com/users/openemr/repos","events_url":"https://api.github.com/users/openemr/events{/privacy}","received_events_url":"https://api.github.com/users/openemr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/openemr/openemr","description":"Mirror of official OpenEMR Sourceforge repository","fork":false,"url":"https://api.github.com/repos/openemr/openemr","forks_url":"https://api.github.com/repos/openemr/openemr/forks","keys_url":"https://api.github.com/repos/openemr/openemr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openemr/openemr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openemr/openemr/teams","hooks_url":"https://api.github.com/repos/openemr/openemr/hooks","issue_events_url":"https://api.github.com/repos/openemr/openemr/issues/events{/number}","events_url":"https://api.github.com/repos/openemr/openemr/events","assignees_url":"https://api.github.com/repos/openemr/openemr/assignees{/user}","branches_url":"https://api.github.com/repos/openemr/openemr/branches{/branch}","tags_url":"https://api.github.com/repos/openemr/openemr/tags","blobs_url":"https://api.github.com/repos/openemr/openemr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openemr/openemr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openemr/openemr/git/refs{/sha}","trees_url":"https://api.github.com/repos/openemr/openemr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openemr/openemr/statuses/{sha}","languages_url":"https://api.github.com/repos/openemr/openemr/languages","stargazers_url":"https://api.github.com/repos/openemr/openemr/stargazers","contributors_url":"https://api.github.com/repos/openemr/openemr/contributors","subscribers_url":"https://api.github.com/repos/openemr/openemr/subscribers","subscription_url":"https://api.github.com/repos/openemr/openemr/subscription","commits_url":"https://api.github.com/repos/openemr/openemr/commits{/sha}","git_commits_url":"https://api.github.com/repos/openemr/openemr/git/commits{/sha}","comments_url":"https://api.github.com/repos/openemr/openemr/comments{/number}","issue_comment_url":"https://api.github.com/repos/openemr/openemr/issues/comments{/number}","contents_url":"https://api.github.com/repos/openemr/openemr/contents/{+path}","compare_url":"https://api.github.com/repos/openemr/openemr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openemr/openemr/merges","archive_url":"https://api.github.com/repos/openemr/openemr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openemr/openemr/downloads","issues_url":"https://api.github.com/repos/openemr/openemr/issues{/number}","pulls_url":"https://api.github.com/repos/openemr/openemr/pulls{/number}","milestones_url":"https://api.github.com/repos/openemr/openemr/milestones{/number}","notifications_url":"https://api.github.com/repos/openemr/openemr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openemr/openemr/labels{/name}","releases_url":"https://api.github.com/repos/openemr/openemr/releases{/id}","deployments_url":"https://api.github.com/repos/openemr/openemr/deployments","created_at":"2010-05-21T19:54:08Z","updated_at":"2016-07-26T06:27:42Z","pushed_at":"2016-08-02T08:15:52Z","git_url":"git://github.com/openemr/openemr.git","ssh_url":"git@github.com:openemr/openemr.git","clone_url":"https://github.com/openemr/openemr.git","svn_url":"https://github.com/openemr/openemr","homepage":"http://open-emr.org/","size":277744,"stargazers_count":294,"watchers_count":294,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":443,"mirror_url":null,"open_issues_count":41,"forks":443,"open_issues":41,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openemr/openemr/pulls/164"},"html":{"href":"https://github.com/openemr/openemr/pull/164"},"issue":{"href":"https://api.github.com/repos/openemr/openemr/issues/164"},"comments":{"href":"https://api.github.com/repos/openemr/openemr/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/openemr/openemr/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/openemr/openemr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openemr/openemr/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/openemr/openemr/statuses/402770a8e63d9c9eae66fd88225dcc137f149939"}}}}
{"actor":{"display_login":"matrix-drorgo"}}