{"action":"closed","number":1690,"pull_request":{"url":"https://api.github.com/repos/haraka/Haraka/pulls/1690","id":90885301,"html_url":"https://github.com/haraka/Haraka/pull/1690","diff_url":"https://github.com/haraka/Haraka/pull/1690.diff","patch_url":"https://github.com/haraka/Haraka/pull/1690.patch","issue_url":"https://api.github.com/repos/haraka/Haraka/issues/1690","number":1690,"state":"closed","locked":false,"title":"remove tls.ini loading and is_no_tls_host to net_utils","user":{"login":"msimerson","id":261635,"avatar_url":"https://avatars.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n- move tls_socket.load_tls_ini() loading to net_utils.load_tls_ini()\r\n    - with wildcard boolean support (haraka/haraka-net-utils#5)\r\n- replace tls_socket.is_no_tls_host() with more abstract net_utils.ip_in_list()\r\n- refactors outbound tls.ini loading into new function outbound.get_tls_options()\r\n    - with test coverage\r\n    - adds missing dhparam file loading\r\n\r\nChecklist:\r\n- [x] docs updated\r\n- [x] tests updated","created_at":"2016-10-25T20:29:07Z","updated_at":"2016-10-25T21:55:27Z","closed_at":"2016-10-25T21:55:27Z","merged_at":"2016-10-25T21:55:27Z","merge_commit_sha":"6fc40068d71e052ea7da9bd0fa001ba7e3b2f3da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haraka/Haraka/pulls/1690/commits","review_comments_url":"https://api.github.com/repos/haraka/Haraka/pulls/1690/comments","review_comment_url":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haraka/Haraka/issues/1690/comments","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/f016cf03392f66c0a47aea72b1dab27e0e491c51","head":{"label":"msimerson:reduce-tls-socket","ref":"reduce-tls-socket","sha":"f016cf03392f66c0a47aea72b1dab27e0e491c51","user":{"login":"msimerson","id":261635,"avatar_url":"https://avatars.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"repo":{"id":9718691,"name":"Haraka","full_name":"msimerson/Haraka","owner":{"login":"msimerson","id":261635,"avatar_url":"https://avatars.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msimerson/Haraka","description":"An event driven SMTP server","fork":true,"url":"https://api.github.com/repos/msimerson/Haraka","forks_url":"https://api.github.com/repos/msimerson/Haraka/forks","keys_url":"https://api.github.com/repos/msimerson/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msimerson/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msimerson/Haraka/teams","hooks_url":"https://api.github.com/repos/msimerson/Haraka/hooks","issue_events_url":"https://api.github.com/repos/msimerson/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/msimerson/Haraka/events","assignees_url":"https://api.github.com/repos/msimerson/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/msimerson/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/msimerson/Haraka/tags","blobs_url":"https://api.github.com/repos/msimerson/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msimerson/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msimerson/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/msimerson/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msimerson/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/msimerson/Haraka/languages","stargazers_url":"https://api.github.com/repos/msimerson/Haraka/stargazers","contributors_url":"https://api.github.com/repos/msimerson/Haraka/contributors","subscribers_url":"https://api.github.com/repos/msimerson/Haraka/subscribers","subscription_url":"https://api.github.com/repos/msimerson/Haraka/subscription","commits_url":"https://api.github.com/repos/msimerson/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/msimerson/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/msimerson/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/msimerson/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/msimerson/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/msimerson/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msimerson/Haraka/merges","archive_url":"https://api.github.com/repos/msimerson/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msimerson/Haraka/downloads","issues_url":"https://api.github.com/repos/msimerson/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/msimerson/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/msimerson/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/msimerson/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msimerson/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/msimerson/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/msimerson/Haraka/deployments","created_at":"2013-04-27T17:45:55Z","updated_at":"2015-05-07T00:36:33Z","pushed_at":"2016-10-25T21:44:13Z","git_url":"git://github.com/msimerson/Haraka.git","ssh_url":"git@github.com:msimerson/Haraka.git","clone_url":"https://github.com/msimerson/Haraka.git","svn_url":"https://github.com/msimerson/Haraka","homepage":"http://haraka.github.com/","size":4767,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haraka:master","ref":"master","sha":"aa6d42e346f3e9af851cc2e814c713e8b2c00ade","user":{"login":"haraka","id":1111229,"avatar_url":"https://avatars.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"repo":{"id":1464380,"name":"Haraka","full_name":"haraka/Haraka","owner":{"login":"haraka","id":1111229,"avatar_url":"https://avatars.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haraka/Haraka","description":"An event driven SMTP server","fork":false,"url":"https://api.github.com/repos/haraka/Haraka","forks_url":"https://api.github.com/repos/haraka/Haraka/forks","keys_url":"https://api.github.com/repos/haraka/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haraka/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haraka/Haraka/teams","hooks_url":"https://api.github.com/repos/haraka/Haraka/hooks","issue_events_url":"https://api.github.com/repos/haraka/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/haraka/Haraka/events","assignees_url":"https://api.github.com/repos/haraka/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/haraka/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/haraka/Haraka/tags","blobs_url":"https://api.github.com/repos/haraka/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haraka/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haraka/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/haraka/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/haraka/Haraka/languages","stargazers_url":"https://api.github.com/repos/haraka/Haraka/stargazers","contributors_url":"https://api.github.com/repos/haraka/Haraka/contributors","subscribers_url":"https://api.github.com/repos/haraka/Haraka/subscribers","subscription_url":"https://api.github.com/repos/haraka/Haraka/subscription","commits_url":"https://api.github.com/repos/haraka/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/haraka/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/haraka/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/haraka/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/haraka/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/haraka/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haraka/Haraka/merges","archive_url":"https://api.github.com/repos/haraka/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haraka/Haraka/downloads","issues_url":"https://api.github.com/repos/haraka/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/haraka/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/haraka/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/haraka/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haraka/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/haraka/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/haraka/Haraka/deployments","created_at":"2011-03-10T17:00:20Z","updated_at":"2016-10-25T16:08:55Z","pushed_at":"2016-10-25T21:55:27Z","git_url":"git://github.com/haraka/Haraka.git","ssh_url":"git@github.com:haraka/Haraka.git","clone_url":"https://github.com/haraka/Haraka.git","svn_url":"https://github.com/haraka/Haraka","homepage":"http://haraka.github.io/","size":7646,"stargazers_count":2265,"watchers_count":2265,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":32,"forks":319,"open_issues":32,"watchers":2265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1690"},"html":{"href":"https://github.com/haraka/Haraka/pull/1690"},"issue":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1690"},"comments":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1690/comments"},"review_comments":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1690/comments"},"review_comment":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1690/commits"},"statuses":{"href":"https://api.github.com/repos/haraka/Haraka/statuses/f016cf03392f66c0a47aea72b1dab27e0e491c51"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"msimerson","id":261635,"avatar_url":"https://avatars.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":120,"deletions":133,"changed_files":11}}
{"actor":{"display_login":"msimerson"}}