{"action":"created","comment":{"url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/comments/65668262","id":65668262,"diff_hunk":"@@ -1,15 +1,16 @@\n-var apiPort = process.env.NODE_PORT || 3000; // eslint-disable-line no-var\n-var apiUrl = 'http://localhost:' + apiPort; // eslint-disable-line no-var\n-var frontendUrl = 'http://localhost:8080'; // eslint-disable-line no-var\n+const apiPort = process.env.NODE_PORT || 3000; // eslint-disable-line no-var\n+const apiUrl = `http://localhost:${apiPort}`; // eslint-disable-line no-var\n+const frontendUrl = 'http://localhost:8080'; // eslint-disable-line no-var\n+const allowOrigin = [frontendUrl, apiUrl];","path":"config/default.js","position":7,"original_position":7,"commit_id":"d7d61275e552701f0893683b55bbe83ce5e7be0c","original_commit_id":"cb6f628a71c62a218d4e2192001e5632ecc7d1ca","user":{"login":"brikou","id":383212,"avatar_url":"https://avatars.githubusercontent.com/u/383212?v=3","gravatar_id":"","url":"https://api.github.com/users/brikou","html_url":"https://github.com/brikou","followers_url":"https://api.github.com/users/brikou/followers","following_url":"https://api.github.com/users/brikou/following{/other_user}","gists_url":"https://api.github.com/users/brikou/gists{/gist_id}","starred_url":"https://api.github.com/users/brikou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikou/subscriptions","organizations_url":"https://api.github.com/users/brikou/orgs","repos_url":"https://api.github.com/users/brikou/repos","events_url":"https://api.github.com/users/brikou/events{/privacy}","received_events_url":"https://api.github.com/users/brikou/received_events","type":"User","site_admin":false},"body":"IMO array variable should use plural form and because this project is still alpha we can change it to a better name (fe `allowedOrigins`). What do you think of it?","created_at":"2016-06-03T07:47:46Z","updated_at":"2016-06-03T07:47:46Z","html_url":"https://github.com/marmelab/javascript-boilerplate/pull/99#discussion_r65668262","pull_request_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/comments/65668262"},"html":{"href":"https://github.com/marmelab/javascript-boilerplate/pull/99#discussion_r65668262"},"pull_request":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99","id":72351540,"html_url":"https://github.com/marmelab/javascript-boilerplate/pull/99","diff_url":"https://github.com/marmelab/javascript-boilerplate/pull/99.diff","patch_url":"https://github.com/marmelab/javascript-boilerplate/pull/99.patch","issue_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/99","number":99,"state":"open","locked":false,"title":"[RFR] Fix CORS allow-origin","user":{"login":"djhi","id":1122076,"avatar_url":"https://avatars.githubusercontent.com/u/1122076?v=3","gravatar_id":"","url":"https://api.github.com/users/djhi","html_url":"https://github.com/djhi","followers_url":"https://api.github.com/users/djhi/followers","following_url":"https://api.github.com/users/djhi/following{/other_user}","gists_url":"https://api.github.com/users/djhi/gists{/gist_id}","starred_url":"https://api.github.com/users/djhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhi/subscriptions","organizations_url":"https://api.github.com/users/djhi/orgs","repos_url":"https://api.github.com/users/djhi/repos","events_url":"https://api.github.com/users/djhi/events{/privacy}","received_events_url":"https://api.github.com/users/djhi/received_events","type":"User","site_admin":false},"body":"Supersede #90","created_at":"2016-06-02T14:02:33Z","updated_at":"2016-06-03T07:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82f34716ddd87aff0f60a431e5988cadb1b083ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99/commits","review_comments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99/comments","review_comment_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/99/comments","statuses_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/statuses/d7d61275e552701f0893683b55bbe83ce5e7be0c","head":{"label":"marmelab:fix-cors-origins","ref":"fix-cors-origins","sha":"d7d61275e552701f0893683b55bbe83ce5e7be0c","user":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":49864754,"name":"javascript-boilerplate","full_name":"marmelab/javascript-boilerplate","owner":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/javascript-boilerplate","description":"Node.js+Koa.js+PostgreSQL+React.js+Webpack+Mocha+Makefile, a starter kit for new apps","fork":false,"url":"https://api.github.com/repos/marmelab/javascript-boilerplate","forks_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/forks","keys_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/teams","hooks_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/events","assignees_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/tags","blobs_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/languages","stargazers_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/subscription","commits_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/merges","archive_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/downloads","issues_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/deployments","created_at":"2016-01-18T09:05:11Z","updated_at":"2016-06-02T17:07:40Z","pushed_at":"2016-06-03T07:46:59Z","git_url":"git://github.com/marmelab/javascript-boilerplate.git","ssh_url":"git@github.com:marmelab/javascript-boilerplate.git","clone_url":"https://github.com/marmelab/javascript-boilerplate.git","svn_url":"https://github.com/marmelab/javascript-boilerplate","homepage":null,"size":698,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":68,"default_branch":"master"}},"base":{"label":"marmelab:master","ref":"master","sha":"6bcd8c3840dcc3321e11abac62212a78a9d05eb7","user":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":49864754,"name":"javascript-boilerplate","full_name":"marmelab/javascript-boilerplate","owner":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/javascript-boilerplate","description":"Node.js+Koa.js+PostgreSQL+React.js+Webpack+Mocha+Makefile, a starter kit for new apps","fork":false,"url":"https://api.github.com/repos/marmelab/javascript-boilerplate","forks_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/forks","keys_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/teams","hooks_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/events","assignees_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/tags","blobs_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/languages","stargazers_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/subscription","commits_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/merges","archive_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/downloads","issues_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/javascript-boilerplate/deployments","created_at":"2016-01-18T09:05:11Z","updated_at":"2016-06-02T17:07:40Z","pushed_at":"2016-06-03T07:46:59Z","git_url":"git://github.com/marmelab/javascript-boilerplate.git","ssh_url":"git@github.com:marmelab/javascript-boilerplate.git","clone_url":"https://github.com/marmelab/javascript-boilerplate.git","svn_url":"https://github.com/marmelab/javascript-boilerplate","homepage":null,"size":698,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99"},"html":{"href":"https://github.com/marmelab/javascript-boilerplate/pull/99"},"issue":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/99"},"comments":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/marmelab/javascript-boilerplate/statuses/d7d61275e552701f0893683b55bbe83ce5e7be0c"}}}}
{"actor":{"display_login":"brikou"}}