{"action":"created","issue":{"url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/113","repository_url":"https://api.github.com/repos/projecthydra-labs/hyrax","labels_url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/113/comments","events_url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/113/events","html_url":"https://github.com/projecthydra-labs/hyrax/issues/113","id":197052321,"number":113,"title":"Document config values for contact form","user":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"labels":[{"id":505053940,"url":"https://api.github.com/repos/projecthydra-labs/hyrax/labels/MOVE%20TO%20HYRAX!","name":"MOVE TO HYRAX!","color":"d4c5f9","default":false},{"id":505053956,"url":"https://api.github.com/repos/projecthydra-labs/hyrax/labels/technical%20debt","name":"technical debt","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/projecthydra-labs/hyrax/milestones/1","html_url":"https://github.com/projecthydra-labs/hyrax/milestone/1","labels_url":"https://api.github.com/repos/projecthydra-labs/hyrax/milestones/1/labels","id":2210731,"number":1,"title":"Backlog","description":"","creator":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":27,"state":"open","created_at":"2016-12-21T19:45:35Z","updated_at":"2016-12-21T22:49:15Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-12-21T22:49:15Z","updated_at":"2016-12-21T22:49:19Z","closed_at":null,"body":"<a href=\"https://github.com/hackmastera\"><img src=\"https://avatars.githubusercontent.com/u/845363?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [hackmastera](https://github.com/hackmastera)**\n_Thursday Feb 18, 2016 at 19:33 GMT_\n_Originally opened as https://github.com/projecthydra/sufia/issues/1587_\n\n----\n\n### Descriptive summary\n\nVersions: all\n### Expected behavior\n\nShould be easy to figure out how to configure stuff\n### Actual behavior\n\nHave to dig and troubleshoot to find these values\n### Related work\n\nAdd these config values to readme and/or config file generators:\n\nhttps://github.com/projecthydra/sufia/blob/fc2dc3d86afcd3f53919b301ed036a648e260190/app/models/contact_form.rb#L24-L25\n\n"},"comment":{"url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/comments/268664462","html_url":"https://github.com/projecthydra-labs/hyrax/issues/113#issuecomment-268664462","issue_url":"https://api.github.com/repos/projecthydra-labs/hyrax/issues/113","id":268664462,"user":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T22:49:19Z","updated_at":"2016-12-21T22:49:19Z","body":"<a href=\"https://github.com/mjgiarlo\"><img src=\"https://avatars.githubusercontent.com/u/131982?v=3\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [mjgiarlo](https://github.com/mjgiarlo)**\n_Thursday Feb 18, 2016 at 21:54 GMT_\n\n----\n\nOK, I think I disagree with my earlier self that this is cruft, now that @hackmastera inspired me to dig deeper. I share the following as perhaps interesting \"discovery\" information.\n\nHere's what the GW folks (@kercher, @kilahimm) did to get their contact form working and wired up:\n\nhttps://github.com/gwu-libraries/gw-sufia#configure-contact-form-emailing\n\n@awead -- after looking into this more, I think you Penn Staters _do_ use the Sufia form, though you have the config in your env-specific Rails configs so that the contact form values differ per environment (though the `Sufia::Engine.configure` is most definitely old-style -- now we use `Sufia.config` instead):\n\nhttps://github.com/psu-stewardship/scholarsphere/blob/5eea37b92388fbebc9a1339f184cc6142ac52e1f/config/environments/development.rb#L3-L4 \n\nThe Albertans wanted to customize their contact form, so they created their own form based on what Sufia already has (probably via copypasta, but IMO it may be premature to consider modulizing the contact form for easier extension/customization):\n\nhttps://github.com/ualbertalib/HydraNorth/blob/adea71d5ba7e4a29125daf5d5ea68cb056815180/config/environments/development.rb#L17-L23\n\nSo Sufia **does** use the undocumented `contact_email` or `from_email` config values; we should document these better and add them to the Sufia initializer, perhaps with more documentation recommending that folks might want to break these values out into `config/environments/*.rb` per Sufia best practice (as evidenced by PSU, GW, and UA)?\n\nThoughts on this approach? Was it even clear? @awead @hackmastera @jcoyne \n\n"}}
{"actor":{"display_login":"mjgiarlo"}}