{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/comments/81980407","pull_request_review_id":2919619,"id":81980407,"diff_hunk":"@@ -189,7 +189,9 @@ object ReadOperand (Instruction instruction)\n \t\t\tcase OperandType.InlineSig:\n \t\t\t\treturn GetCallSite (ReadToken ());\n \t\t\tcase OperandType.InlineString:\n-\t\t\t\treturn GetString (ReadToken ());\n+\t\t\t\tvar token = ReadToken ();\n+\t\t\t\tbody.instructionTokens.Add (instruction, token);\n+\t\t\t\treturn GetString (token);","path":"Mono.Cecil.Cil/CodeReader.cs","position":7,"original_position":7,"commit_id":"e37b793409bada022db52bec3d000fece299452c","original_commit_id":"e37b793409bada022db52bec3d000fece299452c","user":{"login":"joncham","id":260892,"avatar_url":"https://avatars.githubusercontent.com/u/260892?v=3","gravatar_id":"","url":"https://api.github.com/users/joncham","html_url":"https://github.com/joncham","followers_url":"https://api.github.com/users/joncham/followers","following_url":"https://api.github.com/users/joncham/following{/other_user}","gists_url":"https://api.github.com/users/joncham/gists{/gist_id}","starred_url":"https://api.github.com/users/joncham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joncham/subscriptions","organizations_url":"https://api.github.com/users/joncham/orgs","repos_url":"https://api.github.com/users/joncham/repos","events_url":"https://api.github.com/users/joncham/events{/privacy}","received_events_url":"https://api.github.com/users/joncham/received_events","type":"User","site_admin":false},"body":"Does this handle all string literals?","created_at":"2016-10-05T14:09:07Z","updated_at":"2016-10-05T14:09:18Z","html_url":"https://github.com/Unity-Technologies/cecil/pull/7#discussion_r81980407","pull_request_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/comments/81980407"},"html":{"href":"https://github.com/Unity-Technologies/cecil/pull/7#discussion_r81980407"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7","id":88083493,"html_url":"https://github.com/Unity-Technologies/cecil/pull/7","diff_url":"https://github.com/Unity-Technologies/cecil/pull/7.diff","patch_url":"https://github.com/Unity-Technologies/cecil/pull/7.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/7","number":7,"state":"open","locked":false,"title":"Il2cpp on mono - string tokens","user":{"login":"brianradunity","id":19916020,"avatar_url":"https://avatars.githubusercontent.com/u/19916020?v=3","gravatar_id":"","url":"https://api.github.com/users/brianradunity","html_url":"https://github.com/brianradunity","followers_url":"https://api.github.com/users/brianradunity/followers","following_url":"https://api.github.com/users/brianradunity/following{/other_user}","gists_url":"https://api.github.com/users/brianradunity/gists{/gist_id}","starred_url":"https://api.github.com/users/brianradunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianradunity/subscriptions","organizations_url":"https://api.github.com/users/brianradunity/orgs","repos_url":"https://api.github.com/users/brianradunity/repos","events_url":"https://api.github.com/users/brianradunity/events{/privacy}","received_events_url":"https://api.github.com/users/brianradunity/received_events","type":"User","site_admin":false},"body":"The new effort to run IL2CPP on the mono runtime instead of libil2cpp requires the metadata tokens for ldstr instructions, which Cecil currently discards.  This change stores these tokens in a dictionary on the MethodBody object, indexed by the instruction.","created_at":"2016-10-05T14:00:44Z","updated_at":"2016-10-05T14:09:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6608015ae8ed083bacdf8ba49dde74f42cb035ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/7/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/cecil/statuses/e37b793409bada022db52bec3d000fece299452c","head":{"label":"Unity-Technologies:il2cpp-on-mono-string-tokens","ref":"il2cpp-on-mono-string-tokens","sha":"e37b793409bada022db52bec3d000fece299452c","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":1028647,"name":"cecil","full_name":"Unity-Technologies/cecil","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/cecil","description":"Cecil is a library to generate and inspect programs and libraries in the ECMA CIL form.","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/cecil","forks_url":"https://api.github.com/repos/Unity-Technologies/cecil/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/cecil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/cecil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/cecil/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/cecil/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/cecil/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/cecil/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/cecil/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/cecil/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/cecil/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/cecil/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/cecil/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/cecil/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/cecil/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/cecil/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/cecil/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/cecil/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/cecil/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/cecil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/cecil/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/cecil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/cecil/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/cecil/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/cecil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/cecil/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/cecil/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/cecil/deployments","created_at":"2010-10-27T13:11:05Z","updated_at":"2016-08-23T09:24:53Z","pushed_at":"2016-10-05T14:00:45Z","git_url":"git://github.com/Unity-Technologies/cecil.git","ssh_url":"git@github.com:Unity-Technologies/cecil.git","clone_url":"https://github.com/Unity-Technologies/cecil.git","svn_url":"https://github.com/Unity-Technologies/cecil","homepage":"http://www.mono-project.com/Cecil","size":2476,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"Unity-Technologies:master","ref":"master","sha":"c813a98dd72ec358c7fa9570c6f4e1371589efe5","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":1028647,"name":"cecil","full_name":"Unity-Technologies/cecil","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/cecil","description":"Cecil is a library to generate and inspect programs and libraries in the ECMA CIL form.","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/cecil","forks_url":"https://api.github.com/repos/Unity-Technologies/cecil/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/cecil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/cecil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/cecil/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/cecil/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/cecil/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/cecil/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/cecil/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/cecil/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/cecil/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/cecil/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/cecil/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/cecil/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/cecil/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/cecil/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/cecil/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/cecil/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/cecil/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/cecil/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/cecil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/cecil/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/cecil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/cecil/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/cecil/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/cecil/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/cecil/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/cecil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/cecil/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/cecil/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/cecil/deployments","created_at":"2010-10-27T13:11:05Z","updated_at":"2016-08-23T09:24:53Z","pushed_at":"2016-10-05T14:00:45Z","git_url":"git://github.com/Unity-Technologies/cecil.git","ssh_url":"git@github.com:Unity-Technologies/cecil.git","clone_url":"https://github.com/Unity-Technologies/cecil.git","svn_url":"https://github.com/Unity-Technologies/cecil","homepage":"http://www.mono-project.com/Cecil","size":2476,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7"},"html":{"href":"https://github.com/Unity-Technologies/cecil/pull/7"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/issues/7"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/cecil/statuses/e37b793409bada022db52bec3d000fece299452c"}}}}
{"actor":{"display_login":"joncham"}}