{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/77216938","id":77216938,"diff_hunk":"@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {\n     val normalized1 = logicalPlan.transformAllExpressions {\n       case udf: ScalaUDF => udf.copy(function = null)\n       case gen: UserDefinedGenerator => gen.copy(function = null)\n+      // SPARK-17356: In usage of mllib, Metadata may store a huge vector of data, transforming\n+      // it to JSON may trigger OutOfMemoryError.\n+      case a @ Alias(child, name) if a.explicitMetadata.isDefined =>\n+        Alias(child, name)(a.exprId, a.qualifier, Some(Metadata.empty), a.isGenerated)\n+      case a: AttributeReference if a.metadata != Metadata.empty =>\n+        AttributeReference(a.name, a.dataType, a.nullable, Metadata.empty)(a.exprId, a.qualifier,\n+          a.isGenerated)","path":"sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala","position":19,"original_position":19,"commit_id":"368e0971a4af43d065be854a231443cffa4f5769","original_commit_id":"368e0971a4af43d065be854a231443cffa4f5769","user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"body":"If we have https://github.com/apache/spark/pull/14915/files#diff-eac5b02bb450a235fef5e902a2671254R623, do we still need these?","created_at":"2016-09-01T17:24:53Z","updated_at":"2016-09-01T17:24:53Z","html_url":"https://github.com/apache/spark/pull/14915#discussion_r77216938","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/14915","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/77216938"},"html":{"href":"https://github.com/apache/spark/pull/14915#discussion_r77216938"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/14915"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14915","id":83595769,"html_url":"https://github.com/apache/spark/pull/14915","diff_url":"https://github.com/apache/spark/pull/14915.diff","patch_url":"https://github.com/apache/spark/pull/14915.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/14915","number":14915,"state":"open","locked":false,"title":"[SPARK-17356][SQL] Fix out of memory issue when generating JSON for TreeNode","user":{"login":"clockfly","id":2595532,"avatar_url":"https://avatars.githubusercontent.com/u/2595532?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfly","html_url":"https://github.com/clockfly","followers_url":"https://api.github.com/users/clockfly/followers","following_url":"https://api.github.com/users/clockfly/following{/other_user}","gists_url":"https://api.github.com/users/clockfly/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfly/subscriptions","organizations_url":"https://api.github.com/users/clockfly/orgs","repos_url":"https://api.github.com/users/clockfly/repos","events_url":"https://api.github.com/users/clockfly/events{/privacy}","received_events_url":"https://api.github.com/users/clockfly/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nclass `org.apache.spark.sql.types.Metadata` is widely used in mllib to store some ml attributes. `Metadata` is commonly stored in `Alias` expression. \r\n\r\n```\r\ncase class Alias(child: Expression, name: String)(\r\n    val exprId: ExprId = NamedExpression.newExprId,\r\n    val qualifier: Option[String] = None,\r\n    val explicitMetadata: Option[Metadata] = None,\r\n    override val isGenerated: java.lang.Boolean = false)\r\n```\r\n\r\nThe `Metadata` can take a big memory footprint since the number of attributes is big ( in scale of million). When `toJSON` is called on `Alias` expression, the `Metadata` will also be converted to a big JSON string. \r\nIf a plan contains many such kind of `Alias` expressions, it may trigger out of memory error when `toJSON` is called, since converting all `Metadata` references to JSON will take huge memory.\r\n \r\nWith this PR, we will skip scanning Metadata when doing JSON conversion. For a reproducer of the OOM, and analysis, please look at jira https://issues.apache.org/jira/browse/SPARK-17356. \r\n\r\n## How was this patch tested?\r\n\r\nExisting tests.\r\n","created_at":"2016-09-01T09:07:45Z","updated_at":"2016-09-01T17:24:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1bf3d560787c9da5f77686282bb3843eb50a755","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/14915/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/14915/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/14915/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/368e0971a4af43d065be854a231443cffa4f5769","head":{"label":"clockfly:json_oom","ref":"json_oom","sha":"368e0971a4af43d065be854a231443cffa4f5769","user":{"login":"clockfly","id":2595532,"avatar_url":"https://avatars.githubusercontent.com/u/2595532?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfly","html_url":"https://github.com/clockfly","followers_url":"https://api.github.com/users/clockfly/followers","following_url":"https://api.github.com/users/clockfly/following{/other_user}","gists_url":"https://api.github.com/users/clockfly/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfly/subscriptions","organizations_url":"https://api.github.com/users/clockfly/orgs","repos_url":"https://api.github.com/users/clockfly/repos","events_url":"https://api.github.com/users/clockfly/events{/privacy}","received_events_url":"https://api.github.com/users/clockfly/received_events","type":"User","site_admin":false},"repo":{"id":57937220,"name":"spark","full_name":"clockfly/spark","owner":{"login":"clockfly","id":2595532,"avatar_url":"https://avatars.githubusercontent.com/u/2595532?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfly","html_url":"https://github.com/clockfly","followers_url":"https://api.github.com/users/clockfly/followers","following_url":"https://api.github.com/users/clockfly/following{/other_user}","gists_url":"https://api.github.com/users/clockfly/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfly/subscriptions","organizations_url":"https://api.github.com/users/clockfly/orgs","repos_url":"https://api.github.com/users/clockfly/repos","events_url":"https://api.github.com/users/clockfly/events{/privacy}","received_events_url":"https://api.github.com/users/clockfly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clockfly/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/clockfly/spark","forks_url":"https://api.github.com/repos/clockfly/spark/forks","keys_url":"https://api.github.com/repos/clockfly/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clockfly/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clockfly/spark/teams","hooks_url":"https://api.github.com/repos/clockfly/spark/hooks","issue_events_url":"https://api.github.com/repos/clockfly/spark/issues/events{/number}","events_url":"https://api.github.com/repos/clockfly/spark/events","assignees_url":"https://api.github.com/repos/clockfly/spark/assignees{/user}","branches_url":"https://api.github.com/repos/clockfly/spark/branches{/branch}","tags_url":"https://api.github.com/repos/clockfly/spark/tags","blobs_url":"https://api.github.com/repos/clockfly/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clockfly/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clockfly/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/clockfly/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clockfly/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/clockfly/spark/languages","stargazers_url":"https://api.github.com/repos/clockfly/spark/stargazers","contributors_url":"https://api.github.com/repos/clockfly/spark/contributors","subscribers_url":"https://api.github.com/repos/clockfly/spark/subscribers","subscription_url":"https://api.github.com/repos/clockfly/spark/subscription","commits_url":"https://api.github.com/repos/clockfly/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/clockfly/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/clockfly/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/clockfly/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/clockfly/spark/contents/{+path}","compare_url":"https://api.github.com/repos/clockfly/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clockfly/spark/merges","archive_url":"https://api.github.com/repos/clockfly/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clockfly/spark/downloads","issues_url":"https://api.github.com/repos/clockfly/spark/issues{/number}","pulls_url":"https://api.github.com/repos/clockfly/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/clockfly/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/clockfly/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clockfly/spark/labels{/name}","releases_url":"https://api.github.com/repos/clockfly/spark/releases{/id}","deployments_url":"https://api.github.com/repos/clockfly/spark/deployments","created_at":"2016-05-03T02:58:50Z","updated_at":"2016-05-03T02:59:11Z","pushed_at":"2016-09-01T08:31:42Z","git_url":"git://github.com/clockfly/spark.git","ssh_url":"git@github.com:clockfly/spark.git","clone_url":"https://github.com/clockfly/spark.git","svn_url":"https://github.com/clockfly/spark","homepage":null,"size":181050,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"adaaffa34ef0ef6a7baa5c1fea848cf5bc3987a2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-01T15:38:14Z","pushed_at":"2016-09-01T17:19:12Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":519898,"stargazers_count":9851,"watchers_count":9851,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9198,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":488,"forks":9198,"open_issues":488,"watchers":9851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/14915"},"html":{"href":"https://github.com/apache/spark/pull/14915"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/14915"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/14915/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/14915/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/14915/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/368e0971a4af43d065be854a231443cffa4f5769"}}}}
{"actor":{"display_login":"yhuai"}}