{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/browser-payment-api/issues/185","repository_url":"https://api.github.com/repos/w3c/browser-payment-api","labels_url":"https://api.github.com/repos/w3c/browser-payment-api/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/w3c/browser-payment-api/issues/185/comments","events_url":"https://api.github.com/repos/w3c/browser-payment-api/issues/185/events","html_url":"https://github.com/w3c/browser-payment-api/issues/185","id":154124255,"number":185,"title":"Currency Types and Rendering","user":{"login":"adamroach","id":2974852,"avatar_url":"https://avatars.githubusercontent.com/u/2974852?v=3","gravatar_id":"","url":"https://api.github.com/users/adamroach","html_url":"https://github.com/adamroach","followers_url":"https://api.github.com/users/adamroach/followers","following_url":"https://api.github.com/users/adamroach/following{/other_user}","gists_url":"https://api.github.com/users/adamroach/gists{/gist_id}","starred_url":"https://api.github.com/users/adamroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamroach/subscriptions","organizations_url":"https://api.github.com/users/adamroach/orgs","repos_url":"https://api.github.com/users/adamroach/repos","events_url":"https://api.github.com/users/adamroach/events{/privacy}","received_events_url":"https://api.github.com/users/adamroach/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/w3c/browser-payment-api/labels/Cat:%20Design/Technical","name":"Cat: Design/Technical","color":"1d76db"},{"url":"https://api.github.com/repos/w3c/browser-payment-api/labels/Doc:BrowserAPI","name":"Doc:BrowserAPI","color":"d4c5f9"},{"url":"https://api.github.com/repos/w3c/browser-payment-api/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/w3c/browser-payment-api/labels/Priority:%20High","name":"Priority: High","color":"f9d0c4"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/w3c/browser-payment-api/milestones/7","html_url":"https://github.com/w3c/browser-payment-api/milestones/23%20June","labels_url":"https://api.github.com/repos/w3c/browser-payment-api/milestones/7/labels","id":1844250,"number":7,"title":"23 June","description":"","creator":{"login":"adrianhopebailie","id":49902,"avatar_url":"https://avatars.githubusercontent.com/u/49902?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianhopebailie","html_url":"https://github.com/adrianhopebailie","followers_url":"https://api.github.com/users/adrianhopebailie/followers","following_url":"https://api.github.com/users/adrianhopebailie/following{/other_user}","gists_url":"https://api.github.com/users/adrianhopebailie/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianhopebailie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianhopebailie/subscriptions","organizations_url":"https://api.github.com/users/adrianhopebailie/orgs","repos_url":"https://api.github.com/users/adrianhopebailie/repos","events_url":"https://api.github.com/users/adrianhopebailie/events{/privacy}","received_events_url":"https://api.github.com/users/adrianhopebailie/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-06-22T21:59:50Z","updated_at":"2016-06-22T22:12:47Z","due_on":"2016-06-22T22:00:00Z","closed_at":null},"comments":62,"created_at":"2016-05-10T22:51:33Z","updated_at":"2016-06-23T17:18:59Z","closed_at":null,"body":"I have some concerns with being able to sensibly render line items, especially with the “currency” field being *effectively* free-form (the current version says that it may be but does not have to be an ISO currency code).\r\n\r\nSimply stated, no one using a US locale checking out from a US store expects to see “58.73 USD,” and this will certainly confuse some people. They’ll want to see “$58.73”. But if there’s no hard-and-fast convention about what “currency” means, then rendering this sensibly will be difficult. So, minimally, I think we need to say that anything that matches an ISO code *is* *guaranteed* to be that currency.\r\n\r\nWithout strictly requiring the currency code to be an ISO-registered value, though, this becomes problematic: any other three-letter code effectively becomes “squatting” in the space, and runs the (admittedly small but nonzero) chance of being later allocated by ISO. Which means that what we really want is some way to say “this is the ISO code for a currency”, and a mutually exclusive way to say “this is not represented with an ISO code, but with a different identifier, which is XXX.”\r\n\r\nThere's probably more thought to be given to these non-ISO identifiers in terms of renderability, but I'm mostly worried about the conventional currency cases to start with."},"comment":{"url":"https://api.github.com/repos/w3c/browser-payment-api/issues/comments/228119645","html_url":"https://github.com/w3c/browser-payment-api/issues/185#issuecomment-228119645","issue_url":"https://api.github.com/repos/w3c/browser-payment-api/issues/185","id":228119645,"user":{"login":"adamroach","id":2974852,"avatar_url":"https://avatars.githubusercontent.com/u/2974852?v=3","gravatar_id":"","url":"https://api.github.com/users/adamroach","html_url":"https://github.com/adamroach","followers_url":"https://api.github.com/users/adamroach/followers","following_url":"https://api.github.com/users/adamroach/following{/other_user}","gists_url":"https://api.github.com/users/adamroach/gists{/gist_id}","starred_url":"https://api.github.com/users/adamroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamroach/subscriptions","organizations_url":"https://api.github.com/users/adamroach/orgs","repos_url":"https://api.github.com/users/adamroach/repos","events_url":"https://api.github.com/users/adamroach/events{/privacy}","received_events_url":"https://api.github.com/users/adamroach/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T17:18:59Z","updated_at":"2016-06-23T17:18:59Z","body":"@adrianhopebailie --\r\n1. Yes, `system` is a URI\r\n2. I'm okay with a default of `urn:iso:std:iso:4217`\r\n3. The value of `code` can be any string that is valid _within the system_"}}
{"actor":{"display_login":"adamroach"}}