{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/94276634","pull_request_review_id":14806819,"id":94276634,"diff_hunk":"@@ -159,9 +161,14 @@ class CriticalRequestChains extends Formatter {\n \n         // Create the appropriate tree marker based on the depth of this\n         // node as well as whether or not it has children and is itself the last child.\n-        const treeMarker = ancestorTreeMarker +\n-            (isLastChild ? '┗━' : '┣━') +\n-            (hasChildren ? '┳' : '━');\n+        let treeMarker = ancestorTreeMarker;\n+        if (process.platform === 'win32') {\n+          treeMarker += (isLastChild ? '\\u2514\\u2500' : '\\u251C\\u2500') +","path":"lighthouse-core/formatters/critical-request-chains.js","position":20,"original_position":20,"commit_id":"cd1159eb0810628cb411704e2f68cd0e200be07b","original_commit_id":"cd1159eb0810628cb411704e2f68cd0e200be07b","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"maybe do this as with `ancestorTreeMarker ` above, where the symbol is picked conditionally (maybe at file level) but all platforms construct the string in the same way?","created_at":"2016-12-31T18:46:00Z","updated_at":"2016-12-31T18:50:45Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/1307#discussion_r94276634","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/94276634"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/1307#discussion_r94276634"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307","id":99319196,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/1307","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/1307.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/1307.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1307","number":1307,"state":"open","locked":false,"title":"Windows log fixes","user":{"login":"XhmikosR","id":349621,"avatar_url":"https://avatars.githubusercontent.com/u/349621?v=3","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"body":"This is #1272 cherry picked, #1305 cherry picked and fixed.\r\n\r\nVerified everything works on my Windows VM.\r\n\r\n![after](https://cloud.githubusercontent.com/assets/349621/21470596/cf8a6d88-ca98-11e6-8397-ab704556c833.png)\r\n\r\nCloses #1272, closes #1305.\r\nFixes #1228, fixes #1261.\r\n\r\n**Note to maintainers**: Do **not** squash the branch when merging in order to keep author information.\r\n\r\nOh, and merry Christmas 🎄 \r\n\r\n/CC @Janpot to confirm you are OK with cherry picking your patch and close 1272.","created_at":"2016-12-25T09:57:21Z","updated_at":"2016-12-31T18:50:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b736ae41c375fdb1be25ba1738d8f2cfdc8f1615","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1307/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/cd1159eb0810628cb411704e2f68cd0e200be07b","head":{"label":"XhmikosR:windows-log-fixes","ref":"windows-log-fixes","sha":"cd1159eb0810628cb411704e2f68cd0e200be07b","user":{"login":"XhmikosR","id":349621,"avatar_url":"https://avatars.githubusercontent.com/u/349621?v=3","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"repo":{"id":77228498,"name":"lighthouse","full_name":"XhmikosR/lighthouse","owner":{"login":"XhmikosR","id":349621,"avatar_url":"https://avatars.githubusercontent.com/u/349621?v=3","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XhmikosR/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":true,"url":"https://api.github.com/repos/XhmikosR/lighthouse","forks_url":"https://api.github.com/repos/XhmikosR/lighthouse/forks","keys_url":"https://api.github.com/repos/XhmikosR/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XhmikosR/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XhmikosR/lighthouse/teams","hooks_url":"https://api.github.com/repos/XhmikosR/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/XhmikosR/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/XhmikosR/lighthouse/events","assignees_url":"https://api.github.com/repos/XhmikosR/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/XhmikosR/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/XhmikosR/lighthouse/tags","blobs_url":"https://api.github.com/repos/XhmikosR/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XhmikosR/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XhmikosR/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/XhmikosR/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XhmikosR/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/XhmikosR/lighthouse/languages","stargazers_url":"https://api.github.com/repos/XhmikosR/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/XhmikosR/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/XhmikosR/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/XhmikosR/lighthouse/subscription","commits_url":"https://api.github.com/repos/XhmikosR/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/XhmikosR/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/XhmikosR/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/XhmikosR/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/XhmikosR/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/XhmikosR/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XhmikosR/lighthouse/merges","archive_url":"https://api.github.com/repos/XhmikosR/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XhmikosR/lighthouse/downloads","issues_url":"https://api.github.com/repos/XhmikosR/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/XhmikosR/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/XhmikosR/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/XhmikosR/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XhmikosR/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/XhmikosR/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/XhmikosR/lighthouse/deployments","created_at":"2016-12-23T13:53:25Z","updated_at":"2016-12-23T13:53:29Z","pushed_at":"2016-12-31T18:41:52Z","git_url":"git://github.com/XhmikosR/lighthouse.git","ssh_url":"git@github.com:XhmikosR/lighthouse.git","clone_url":"https://github.com/XhmikosR/lighthouse.git","svn_url":"https://github.com/XhmikosR/lighthouse","homepage":"","size":9238,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"e98cefda30d605e43c7557cea88e00b301079439","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-12-31T16:32:37Z","pushed_at":"2016-12-31T18:41:54Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"","size":9416,"stargazers_count":6113,"watchers_count":6113,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":224,"mirror_url":null,"open_issues_count":177,"forks":224,"open_issues":177,"watchers":6113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/1307"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1307"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1307/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1307/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/cd1159eb0810628cb411704e2f68cd0e200be07b"}}}}
{"actor":{"display_login":"brendankenny"}}