{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/novoda/pulls/comments/72448324","id":72448324,"diff_hunk":"@@ -387,13 +387,12 @@ The example above demonstrates the following style guidelines:\n \n ### Use of Self\n \n-For conciseness, avoid using `self` since Swift does not require it to access an object's properties or invoke its methods.\n-\n-Use `self` when required to differentiate between property names and arguments in initializers, and when referencing properties in closure expressions (as required by the compiler):\n+Always use `self` for property names in initializers. Otherwise, avoid using `self` unless its use is required by the compiler:","path":"style-guides/swift/README.markdown","position":16,"original_position":16,"commit_id":"f7c17328b1c4381edf1a5ebfe09077a541568bb0","original_commit_id":"f7c17328b1c4381edf1a5ebfe09077a541568bb0","user":{"login":"amlcurran","id":666285,"avatar_url":"https://avatars.githubusercontent.com/u/666285?v=3","gravatar_id":"","url":"https://api.github.com/users/amlcurran","html_url":"https://github.com/amlcurran","followers_url":"https://api.github.com/users/amlcurran/followers","following_url":"https://api.github.com/users/amlcurran/following{/other_user}","gists_url":"https://api.github.com/users/amlcurran/gists{/gist_id}","starred_url":"https://api.github.com/users/amlcurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amlcurran/subscriptions","organizations_url":"https://api.github.com/users/amlcurran/orgs","repos_url":"https://api.github.com/users/amlcurran/repos","events_url":"https://api.github.com/users/amlcurran/events{/privacy}","received_events_url":"https://api.github.com/users/amlcurran/received_events","type":"User","site_admin":false},"body":"I've already made a comment previously https://github.com/novoda/novoda/pull/21#discussion_r71130802\r\n\r\nI agree with Wagner. I feel like this looks weird\r\n\r\n```swift\r\nself.foo = foo\r\nself.bar = bar\r\nwoo = Woo(other: other)\r\n```","created_at":"2016-07-27T14:23:17Z","updated_at":"2016-07-27T14:23:17Z","html_url":"https://github.com/novoda/novoda/pull/34#discussion_r72448324","pull_request_url":"https://api.github.com/repos/novoda/novoda/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/novoda/novoda/pulls/comments/72448324"},"html":{"href":"https://github.com/novoda/novoda/pull/34#discussion_r72448324"},"pull_request":{"href":"https://api.github.com/repos/novoda/novoda/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/novoda/pulls/34","id":78646113,"html_url":"https://github.com/novoda/novoda/pull/34","diff_url":"https://github.com/novoda/novoda/pull/34.diff","patch_url":"https://github.com/novoda/novoda/pull/34.patch","issue_url":"https://api.github.com/repos/novoda/novoda/issues/34","number":34,"state":"open","locked":false,"title":"[Swift] style guide - Use of self","user":{"login":"wltrup","id":1015142,"avatar_url":"https://avatars.githubusercontent.com/u/1015142?v=3","gravatar_id":"","url":"https://api.github.com/users/wltrup","html_url":"https://github.com/wltrup","followers_url":"https://api.github.com/users/wltrup/followers","following_url":"https://api.github.com/users/wltrup/following{/other_user}","gists_url":"https://api.github.com/users/wltrup/gists{/gist_id}","starred_url":"https://api.github.com/users/wltrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltrup/subscriptions","organizations_url":"https://api.github.com/users/wltrup/orgs","repos_url":"https://api.github.com/users/wltrup/repos","events_url":"https://api.github.com/users/wltrup/events{/privacy}","received_events_url":"https://api.github.com/users/wltrup/received_events","type":"User","site_admin":false},"body":"TL;DR\r\n\r\nThis PR proposes the style guide rule that we should always use `self` for properties in an initialiser but never otherwise, unless the compiler requires it. ","created_at":"2016-07-25T08:52:37Z","updated_at":"2016-07-27T14:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/novoda/pulls/34/commits","review_comments_url":"https://api.github.com/repos/novoda/novoda/pulls/34/comments","review_comment_url":"https://api.github.com/repos/novoda/novoda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/novoda/issues/34/comments","statuses_url":"https://api.github.com/repos/novoda/novoda/statuses/f7c17328b1c4381edf1a5ebfe09077a541568bb0","head":{"label":"novoda:swift-style-guide-use-of-self","ref":"swift-style-guide-use-of-self","sha":"f7c17328b1c4381edf1a5ebfe09077a541568bb0","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":26584518,"name":"novoda","full_name":"novoda/novoda","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/novoda","description":"Common things for all Novoda's open source projects","fork":false,"url":"https://api.github.com/repos/novoda/novoda","forks_url":"https://api.github.com/repos/novoda/novoda/forks","keys_url":"https://api.github.com/repos/novoda/novoda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/novoda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/novoda/teams","hooks_url":"https://api.github.com/repos/novoda/novoda/hooks","issue_events_url":"https://api.github.com/repos/novoda/novoda/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/novoda/events","assignees_url":"https://api.github.com/repos/novoda/novoda/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/novoda/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/novoda/tags","blobs_url":"https://api.github.com/repos/novoda/novoda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/novoda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/novoda/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/novoda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/novoda/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/novoda/languages","stargazers_url":"https://api.github.com/repos/novoda/novoda/stargazers","contributors_url":"https://api.github.com/repos/novoda/novoda/contributors","subscribers_url":"https://api.github.com/repos/novoda/novoda/subscribers","subscription_url":"https://api.github.com/repos/novoda/novoda/subscription","commits_url":"https://api.github.com/repos/novoda/novoda/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/novoda/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/novoda/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/novoda/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/novoda/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/novoda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/novoda/merges","archive_url":"https://api.github.com/repos/novoda/novoda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/novoda/downloads","issues_url":"https://api.github.com/repos/novoda/novoda/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/novoda/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/novoda/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/novoda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/novoda/labels{/name}","releases_url":"https://api.github.com/repos/novoda/novoda/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/novoda/deployments","created_at":"2014-11-13T11:22:09Z","updated_at":"2016-07-22T14:00:11Z","pushed_at":"2016-07-27T10:30:12Z","git_url":"git://github.com/novoda/novoda.git","ssh_url":"git@github.com:novoda/novoda.git","clone_url":"https://github.com/novoda/novoda.git","svn_url":"https://github.com/novoda/novoda","homepage":"http://www.novoda.com/blog","size":794,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":12,"default_branch":"master"}},"base":{"label":"novoda:master","ref":"master","sha":"974ad3a9612dc0b6ed45393cb2df08a117468235","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":26584518,"name":"novoda","full_name":"novoda/novoda","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/novoda","description":"Common things for all Novoda's open source projects","fork":false,"url":"https://api.github.com/repos/novoda/novoda","forks_url":"https://api.github.com/repos/novoda/novoda/forks","keys_url":"https://api.github.com/repos/novoda/novoda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/novoda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/novoda/teams","hooks_url":"https://api.github.com/repos/novoda/novoda/hooks","issue_events_url":"https://api.github.com/repos/novoda/novoda/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/novoda/events","assignees_url":"https://api.github.com/repos/novoda/novoda/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/novoda/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/novoda/tags","blobs_url":"https://api.github.com/repos/novoda/novoda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/novoda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/novoda/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/novoda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/novoda/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/novoda/languages","stargazers_url":"https://api.github.com/repos/novoda/novoda/stargazers","contributors_url":"https://api.github.com/repos/novoda/novoda/contributors","subscribers_url":"https://api.github.com/repos/novoda/novoda/subscribers","subscription_url":"https://api.github.com/repos/novoda/novoda/subscription","commits_url":"https://api.github.com/repos/novoda/novoda/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/novoda/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/novoda/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/novoda/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/novoda/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/novoda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/novoda/merges","archive_url":"https://api.github.com/repos/novoda/novoda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/novoda/downloads","issues_url":"https://api.github.com/repos/novoda/novoda/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/novoda/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/novoda/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/novoda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/novoda/labels{/name}","releases_url":"https://api.github.com/repos/novoda/novoda/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/novoda/deployments","created_at":"2014-11-13T11:22:09Z","updated_at":"2016-07-22T14:00:11Z","pushed_at":"2016-07-27T10:30:12Z","git_url":"git://github.com/novoda/novoda.git","ssh_url":"git@github.com:novoda/novoda.git","clone_url":"https://github.com/novoda/novoda.git","svn_url":"https://github.com/novoda/novoda","homepage":"http://www.novoda.com/blog","size":794,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/novoda/pulls/34"},"html":{"href":"https://github.com/novoda/novoda/pull/34"},"issue":{"href":"https://api.github.com/repos/novoda/novoda/issues/34"},"comments":{"href":"https://api.github.com/repos/novoda/novoda/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/novoda/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/novoda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/novoda/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/novoda/statuses/f7c17328b1c4381edf1a5ebfe09077a541568bb0"}}}}
{"actor":{"display_login":"amlcurran"}}