{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46","id":71266817,"html_url":"https://github.com/rmosolgo/graphql-relay-ruby/pull/46","diff_url":"https://github.com/rmosolgo/graphql-relay-ruby/pull/46.diff","patch_url":"https://github.com/rmosolgo/graphql-relay-ruby/pull/46.patch","issue_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/46","number":46,"state":"open","locked":false,"title":"Make mutation responses NON_NULL","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":true},"body":"The [Relay Spec](https://facebook.github.io/relay/graphql/mutations.htm) appears to be explicit about what the response for a\r\nMutation should look like:\r\n\r\n> All mutations include in their input a clientMutationId string, which\r\n> is then returned as part of the object returned by the mutation field.\r\n\r\nHowever, the graphql-relay-ruby gem currently does not correctly make\r\nthe response of a Mutation non-nullable. Mutation's must _always_\r\nrespond with their constructed return type (`MutationNamePayload`)\r\nbecause the provided `clientMutationId` must be accessible to the\r\nclient.\r\n\r\nThis was a simple fix, just prefixing the `return_type` with a `!` when\r\nconstructing the mutation's `field`.\r\n\r\nSigned-off-by: David Celis <me@davidcel.is>","created_at":"2016-05-24T18:10:22Z","updated_at":"2016-05-24T18:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46/commits","review_comments_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46/comments","review_comment_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/46/comments","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/statuses/2d786b02342b43117f6b3ce45780fb001357076e","head":{"label":"davidcelis:master","ref":"master","sha":"2d786b02342b43117f6b3ce45780fb001357076e","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":true},"repo":{"id":56805307,"name":"graphql-relay-ruby","full_name":"davidcelis/graphql-relay-ruby","owner":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/davidcelis/graphql-relay-ruby","description":"Relay helpers for GraphQL & Ruby","fork":true,"url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby","forks_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/forks","keys_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/teams","hooks_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/hooks","issue_events_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/events","assignees_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/tags","blobs_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/languages","stargazers_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/stargazers","contributors_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/contributors","subscribers_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/subscribers","subscription_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/subscription","commits_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/merges","archive_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/downloads","issues_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/labels{/name}","releases_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/davidcelis/graphql-relay-ruby/deployments","created_at":"2016-04-21T20:59:18Z","updated_at":"2016-04-21T20:59:19Z","pushed_at":"2016-05-24T18:08:49Z","git_url":"git://github.com/davidcelis/graphql-relay-ruby.git","ssh_url":"git@github.com:davidcelis/graphql-relay-ruby.git","clone_url":"https://github.com/davidcelis/graphql-relay-ruby.git","svn_url":"https://github.com/davidcelis/graphql-relay-ruby","homepage":null,"size":155,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rmosolgo:master","ref":"master","sha":"cc970db2be0febd3c3569f4d67c3cf191a27c008","user":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"repo":{"id":40828842,"name":"graphql-relay-ruby","full_name":"rmosolgo/graphql-relay-ruby","owner":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmosolgo/graphql-relay-ruby","description":"Relay helpers for GraphQL & Ruby","fork":false,"url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby","forks_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/forks","keys_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/teams","hooks_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/hooks","issue_events_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/events","assignees_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/tags","blobs_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/languages","stargazers_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/stargazers","contributors_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/contributors","subscribers_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/subscribers","subscription_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/subscription","commits_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/merges","archive_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/downloads","issues_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/deployments","created_at":"2015-08-16T16:49:54Z","updated_at":"2016-05-23T10:21:44Z","pushed_at":"2016-05-10T21:06:52Z","git_url":"git://github.com/rmosolgo/graphql-relay-ruby.git","ssh_url":"git@github.com:rmosolgo/graphql-relay-ruby.git","clone_url":"https://github.com/rmosolgo/graphql-relay-ruby.git","svn_url":"https://github.com/rmosolgo/graphql-relay-ruby","homepage":null,"size":162,"stargazers_count":82,"watchers_count":82,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46"},"html":{"href":"https://github.com/rmosolgo/graphql-relay-ruby/pull/46"},"issue":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/46"},"comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/rmosolgo/graphql-relay-ruby/statuses/2d786b02342b43117f6b3ce45780fb001357076e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"davidcelis"}}