{"action":"created","comment":{"url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/comments/72611368","id":72611368,"diff_hunk":"@@ -180,15 +179,41 @@ module.exports = React.createClass({\n     </ul>;\n   },\n \n+  _renderPreview: function() {\n+    return <div ref=\"previewContainer\" className={this._getPreviewClasses()}>\n+      {this.loadChild('preview')}\n+    </div>\n+  },\n+\n   _renderContentFrame: function() {\n     return <div ref=\"contentFrame\" className={this._getContentFrameClasses()}>\n-      <div ref=\"previewContainer\" className={this._getPreviewClasses()}>\n-        {this.loadChild('preview')}\n-      </div>\n-      {this.props.editor ? this._renderFixtureEditor() : null}\n+      {this.props.editor ? this._renderSplitPane() : this._renderPreview()}\n     </div>\n   },\n \n+  _renderSplitPane: function() {\n+    return <SplitPane\n+      split={this._getOrientationDirection()}\n+      ref='editorPreviewSplitPane'\n+      defaultSize={localStorage.getItem('splitPos')}\n+      onChange={size => localStorage.setItem('splitPos', size)}","path":"src/components/component-playground.jsx","position":66,"original_position":66,"commit_id":"4893b0ee0cb7a70103a16004c4232390d21691e7","original_commit_id":"4893b0ee0cb7a70103a16004c4232390d21691e7","user":{"login":"catalin-miron-hs","id":12442360,"avatar_url":"https://avatars.githubusercontent.com/u/12442360?v=3","gravatar_id":"","url":"https://api.github.com/users/catalin-miron-hs","html_url":"https://github.com/catalin-miron-hs","followers_url":"https://api.github.com/users/catalin-miron-hs/followers","following_url":"https://api.github.com/users/catalin-miron-hs/following{/other_user}","gists_url":"https://api.github.com/users/catalin-miron-hs/gists{/gist_id}","starred_url":"https://api.github.com/users/catalin-miron-hs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalin-miron-hs/subscriptions","organizations_url":"https://api.github.com/users/catalin-miron-hs/orgs","repos_url":"https://api.github.com/users/catalin-miron-hs/repos","events_url":"https://api.github.com/users/catalin-miron-hs/events{/privacy}","received_events_url":"https://api.github.com/users/catalin-miron-hs/received_events","type":"User","site_admin":false},"body":"you should also test that `onChange` the `localStorage` has the `splitPos` item","created_at":"2016-07-28T12:23:47Z","updated_at":"2016-07-28T12:23:47Z","html_url":"https://github.com/uberVU/react-component-playground/pull/4#discussion_r72611368","pull_request_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/comments/72611368"},"html":{"href":"https://github.com/uberVU/react-component-playground/pull/4#discussion_r72611368"},"pull_request":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4","id":78689719,"html_url":"https://github.com/uberVU/react-component-playground/pull/4","diff_url":"https://github.com/uberVU/react-component-playground/pull/4.diff","patch_url":"https://github.com/uberVU/react-component-playground/pull/4.patch","issue_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/4","number":4,"state":"open","locked":false,"title":"Make editor and preview panels resizable using react-split-pane","user":{"login":"bogdan-stefan-hs","id":20299983,"avatar_url":"https://avatars.githubusercontent.com/u/20299983?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdan-stefan-hs","html_url":"https://github.com/bogdan-stefan-hs","followers_url":"https://api.github.com/users/bogdan-stefan-hs/followers","following_url":"https://api.github.com/users/bogdan-stefan-hs/following{/other_user}","gists_url":"https://api.github.com/users/bogdan-stefan-hs/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdan-stefan-hs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdan-stefan-hs/subscriptions","organizations_url":"https://api.github.com/users/bogdan-stefan-hs/orgs","repos_url":"https://api.github.com/users/bogdan-stefan-hs/repos","events_url":"https://api.github.com/users/bogdan-stefan-hs/events{/privacy}","received_events_url":"https://api.github.com/users/bogdan-stefan-hs/received_events","type":"User","site_admin":false},"body":"## Need\r\n```gherkin\r\nAs a developer\r\nI want to be able to resize the editor panel\r\nSo that I can use the screen space efficiently.\r\n```\r\n## Deliverables\r\n- [x] The separator between the editor and preview panes can be dragged to resize them (when the editor pane enlarges, the preview pane shrinks and vice versa)\r\n\r\n## Solution\r\n#### Prerequisites\r\n- Use the React SplitPane component located [here](https://github.com/ubervu/react-split-pane)\r\n\r\n#### TODO\r\n- [x] Add the editor and preview pane components to a SplitPane \r\n- [x] Check if any rendering tests fail, and adapt them to the new component\r\n","created_at":"2016-07-25T14:22:02Z","updated_at":"2016-07-28T12:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26c2fa0be42565dd1601a008d0559860a40afea6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4/commits","review_comments_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4/comments","review_comment_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/4/comments","statuses_url":"https://api.github.com/repos/uberVU/react-component-playground/statuses/4893b0ee0cb7a70103a16004c4232390d21691e7","head":{"label":"uberVU:2-use-react-split-pane","ref":"2-use-react-split-pane","sha":"4893b0ee0cb7a70103a16004c4232390d21691e7","user":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"repo":{"id":63331493,"name":"react-component-playground","full_name":"uberVU/react-component-playground","owner":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberVU/react-component-playground","description":"Minimal frame for loading and testing React components in isolation.","fork":true,"url":"https://api.github.com/repos/uberVU/react-component-playground","forks_url":"https://api.github.com/repos/uberVU/react-component-playground/forks","keys_url":"https://api.github.com/repos/uberVU/react-component-playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberVU/react-component-playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberVU/react-component-playground/teams","hooks_url":"https://api.github.com/repos/uberVU/react-component-playground/hooks","issue_events_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/events{/number}","events_url":"https://api.github.com/repos/uberVU/react-component-playground/events","assignees_url":"https://api.github.com/repos/uberVU/react-component-playground/assignees{/user}","branches_url":"https://api.github.com/repos/uberVU/react-component-playground/branches{/branch}","tags_url":"https://api.github.com/repos/uberVU/react-component-playground/tags","blobs_url":"https://api.github.com/repos/uberVU/react-component-playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberVU/react-component-playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberVU/react-component-playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberVU/react-component-playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberVU/react-component-playground/statuses/{sha}","languages_url":"https://api.github.com/repos/uberVU/react-component-playground/languages","stargazers_url":"https://api.github.com/repos/uberVU/react-component-playground/stargazers","contributors_url":"https://api.github.com/repos/uberVU/react-component-playground/contributors","subscribers_url":"https://api.github.com/repos/uberVU/react-component-playground/subscribers","subscription_url":"https://api.github.com/repos/uberVU/react-component-playground/subscription","commits_url":"https://api.github.com/repos/uberVU/react-component-playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberVU/react-component-playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberVU/react-component-playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberVU/react-component-playground/contents/{+path}","compare_url":"https://api.github.com/repos/uberVU/react-component-playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberVU/react-component-playground/merges","archive_url":"https://api.github.com/repos/uberVU/react-component-playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberVU/react-component-playground/downloads","issues_url":"https://api.github.com/repos/uberVU/react-component-playground/issues{/number}","pulls_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls{/number}","milestones_url":"https://api.github.com/repos/uberVU/react-component-playground/milestones{/number}","notifications_url":"https://api.github.com/repos/uberVU/react-component-playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberVU/react-component-playground/labels{/name}","releases_url":"https://api.github.com/repos/uberVU/react-component-playground/releases{/id}","deployments_url":"https://api.github.com/repos/uberVU/react-component-playground/deployments","created_at":"2016-07-14T11:33:20Z","updated_at":"2016-07-15T10:41:33Z","pushed_at":"2016-07-27T15:37:19Z","git_url":"git://github.com/uberVU/react-component-playground.git","ssh_url":"git@github.com:uberVU/react-component-playground.git","clone_url":"https://github.com/uberVU/react-component-playground.git","svn_url":"https://github.com/uberVU/react-component-playground","homepage":"","size":161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"uberVU:0.3.x","ref":"0.3.x","sha":"babe5d5357f9ff79f70ed26a24d892cabffa03ff","user":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"repo":{"id":63331493,"name":"react-component-playground","full_name":"uberVU/react-component-playground","owner":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberVU/react-component-playground","description":"Minimal frame for loading and testing React components in isolation.","fork":true,"url":"https://api.github.com/repos/uberVU/react-component-playground","forks_url":"https://api.github.com/repos/uberVU/react-component-playground/forks","keys_url":"https://api.github.com/repos/uberVU/react-component-playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberVU/react-component-playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberVU/react-component-playground/teams","hooks_url":"https://api.github.com/repos/uberVU/react-component-playground/hooks","issue_events_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/events{/number}","events_url":"https://api.github.com/repos/uberVU/react-component-playground/events","assignees_url":"https://api.github.com/repos/uberVU/react-component-playground/assignees{/user}","branches_url":"https://api.github.com/repos/uberVU/react-component-playground/branches{/branch}","tags_url":"https://api.github.com/repos/uberVU/react-component-playground/tags","blobs_url":"https://api.github.com/repos/uberVU/react-component-playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberVU/react-component-playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberVU/react-component-playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberVU/react-component-playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberVU/react-component-playground/statuses/{sha}","languages_url":"https://api.github.com/repos/uberVU/react-component-playground/languages","stargazers_url":"https://api.github.com/repos/uberVU/react-component-playground/stargazers","contributors_url":"https://api.github.com/repos/uberVU/react-component-playground/contributors","subscribers_url":"https://api.github.com/repos/uberVU/react-component-playground/subscribers","subscription_url":"https://api.github.com/repos/uberVU/react-component-playground/subscription","commits_url":"https://api.github.com/repos/uberVU/react-component-playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberVU/react-component-playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberVU/react-component-playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberVU/react-component-playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberVU/react-component-playground/contents/{+path}","compare_url":"https://api.github.com/repos/uberVU/react-component-playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberVU/react-component-playground/merges","archive_url":"https://api.github.com/repos/uberVU/react-component-playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberVU/react-component-playground/downloads","issues_url":"https://api.github.com/repos/uberVU/react-component-playground/issues{/number}","pulls_url":"https://api.github.com/repos/uberVU/react-component-playground/pulls{/number}","milestones_url":"https://api.github.com/repos/uberVU/react-component-playground/milestones{/number}","notifications_url":"https://api.github.com/repos/uberVU/react-component-playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberVU/react-component-playground/labels{/name}","releases_url":"https://api.github.com/repos/uberVU/react-component-playground/releases{/id}","deployments_url":"https://api.github.com/repos/uberVU/react-component-playground/deployments","created_at":"2016-07-14T11:33:20Z","updated_at":"2016-07-15T10:41:33Z","pushed_at":"2016-07-27T15:37:19Z","git_url":"git://github.com/uberVU/react-component-playground.git","ssh_url":"git@github.com:uberVU/react-component-playground.git","clone_url":"https://github.com/uberVU/react-component-playground.git","svn_url":"https://github.com/uberVU/react-component-playground","homepage":"","size":161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4"},"html":{"href":"https://github.com/uberVU/react-component-playground/pull/4"},"issue":{"href":"https://api.github.com/repos/uberVU/react-component-playground/issues/4"},"comments":{"href":"https://api.github.com/repos/uberVU/react-component-playground/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uberVU/react-component-playground/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/uberVU/react-component-playground/statuses/4893b0ee0cb7a70103a16004c4232390d21691e7"}}}}
{"actor":{"display_login":"catalin-miron-hs"}}