{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/15602","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/15602/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15602/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/15602/events","html_url":"https://github.com/dotnet/roslyn/pull/15602","id":192480304,"number":15602,"title":"Analyzer install script fixes","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"labels":[{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-30T05:41:24Z","updated_at":"2016-11-30T21:41:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15602","html_url":"https://github.com/dotnet/roslyn/pull/15602","diff_url":"https://github.com/dotnet/roslyn/pull/15602.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15602.patch"},"body":"**Customer scenario**\r\n\r\nAnalyzers that are localized with satellite assemblies so users can review messages in their own language are improperly installed to packages.config based projects, leaving extra analyzer assemblies listed in Solution Explorer.\r\n\r\nAlso, removal of VB-specific analyzers fail.\r\n\r\nFinally, the several copies of install.ps1 and uninstall.ps1 have grown out of sync. This PR makes them perfectly in sync with each other.\r\n\r\n**Bugs this fixes:** \r\n\r\nNot filed. I figured I'd offer the fix instead of the bug. But there is a mail thread to the rosdisc DL with the subject line: \"Analyzer satellite assembly showing up in SE\"\r\n\r\n**Workarounds, if any**\r\n\r\nThe user can hand edit the install.ps1 and uninstall.ps1 script files that comes in the template or samples.\r\n\r\n**Risk**\r\n\r\nIf an error is introduced by this, it won't immediately regress anything. But developers of analyzers that use the templates may hit a failure to install packages that they'll need to manually fix.\r\n\r\n**Performance impact**\r\n\r\nNone.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo.\r\n\r\n**Root cause analysis:**\r\n\r\nI suppose localized analyzers isn't something Roslyn has tested.\r\nAnd uninstalling VB analyzers from packages.config projects using the sample uninstall.ps1 script also wasn't tested.\r\n\r\n**How was the bug found?**\r\n\r\nI'm developing analyzers that are localized to several cultures and noticed this when I installed them as part of testing."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/264004349","html_url":"https://github.com/dotnet/roslyn/pull/15602#issuecomment-264004349","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15602","id":264004349,"user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T21:41:16Z","updated_at":"2016-11-30T21:41:16Z","body":"failure - https://github.com/dotnet/roslyn/issues/11868"}}
{"actor":{"display_login":"heejaechang"}}