{"action":"opened","number":40,"pull_request":{"url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40","id":65403799,"html_url":"https://github.com/keen/keen-dataviz.js/pull/40","diff_url":"https://github.com/keen/keen-dataviz.js/pull/40.diff","patch_url":"https://github.com/keen/keen-dataviz.js/pull/40.patch","issue_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/40","number":40,"state":"open","locked":false,"title":"[WIP] Nightwatch tests","user":{"login":"joannecheng","id":638351,"avatar_url":"https://avatars.githubusercontent.com/u/638351?v=3","gravatar_id":"","url":"https://api.github.com/users/joannecheng","html_url":"https://github.com/joannecheng","followers_url":"https://api.github.com/users/joannecheng/followers","following_url":"https://api.github.com/users/joannecheng/following{/other_user}","gists_url":"https://api.github.com/users/joannecheng/gists{/gist_id}","starred_url":"https://api.github.com/users/joannecheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joannecheng/subscriptions","organizations_url":"https://api.github.com/users/joannecheng/orgs","repos_url":"https://api.github.com/users/joannecheng/repos","events_url":"https://api.github.com/users/joannecheng/events{/privacy}","received_events_url":"https://api.github.com/users/joannecheng/received_events","type":"User","site_admin":false},"body":"## What does this PR do? How does it affect users?\r\n\r\nThis starts to add [nightwatch](http://nightwatchjs.org) tests to keen-dataviz.\r\n\r\n## How should this be tested?\r\n\r\n* Install selenium server (`brew install selenium-server-standalone`)\r\n* Run selenium server (`brew info selenium-server-standalone`)\r\n* Run `npm install`\r\n* Run `nightwatch`\r\n* Watch tests pass!\r\n\r\nStep through the code line by line. Things to keep in mind as you review:\r\n - Are there any edge cases not covered by this code?\r\n - Does this code follow conventions (naming, formatting, modularization, etc) where applicable?\r\n\r\nFetch the branch and/or deploy to staging to test the following:\r\n\r\n- [ ] Does the code compile without warnings (check shell, console)?\r\n- [ ] Do all tests pass?\r\n- [ ] Does the UI, pixel by pixel, look exactly as expected (check various screen sizes, including mobile)?\r\n- [ ] If the feature makes requests from the browser, inspect them in the Web Inspector. Do they look as expected (parameters, headers, etc)?\r\n- [ ] If the feature sends data to Keen, is the data visible in the project if you run an extraction (include link to collection/query)?\r\n- [ ] If the feature saves data to a database, can you confirm the data is indeed created in the database?\r\n\r\n## Related tickets?\r\n","created_at":"2016-04-06T03:04:13Z","updated_at":"2016-04-06T03:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f77b73adf6fa634026275ccb3494c7d7b72ee692","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40/commits","review_comments_url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40/comments","review_comment_url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/40/comments","statuses_url":"https://api.github.com/repos/keen/keen-dataviz.js/statuses/03c8abc9cf279d328137a62fc6b828f8be3a0af6","head":{"label":"keen:nightwatch","ref":"nightwatch","sha":"03c8abc9cf279d328137a62fc6b828f8be3a0af6","user":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"repo":{"id":41111304,"name":"keen-dataviz.js","full_name":"keen/keen-dataviz.js","owner":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keen/keen-dataviz.js","description":"NEW: Data Visualization SDK for Keen IO","fork":false,"url":"https://api.github.com/repos/keen/keen-dataviz.js","forks_url":"https://api.github.com/repos/keen/keen-dataviz.js/forks","keys_url":"https://api.github.com/repos/keen/keen-dataviz.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keen/keen-dataviz.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keen/keen-dataviz.js/teams","hooks_url":"https://api.github.com/repos/keen/keen-dataviz.js/hooks","issue_events_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/events{/number}","events_url":"https://api.github.com/repos/keen/keen-dataviz.js/events","assignees_url":"https://api.github.com/repos/keen/keen-dataviz.js/assignees{/user}","branches_url":"https://api.github.com/repos/keen/keen-dataviz.js/branches{/branch}","tags_url":"https://api.github.com/repos/keen/keen-dataviz.js/tags","blobs_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keen/keen-dataviz.js/statuses/{sha}","languages_url":"https://api.github.com/repos/keen/keen-dataviz.js/languages","stargazers_url":"https://api.github.com/repos/keen/keen-dataviz.js/stargazers","contributors_url":"https://api.github.com/repos/keen/keen-dataviz.js/contributors","subscribers_url":"https://api.github.com/repos/keen/keen-dataviz.js/subscribers","subscription_url":"https://api.github.com/repos/keen/keen-dataviz.js/subscription","commits_url":"https://api.github.com/repos/keen/keen-dataviz.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/keen/keen-dataviz.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/keen/keen-dataviz.js/contents/{+path}","compare_url":"https://api.github.com/repos/keen/keen-dataviz.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keen/keen-dataviz.js/merges","archive_url":"https://api.github.com/repos/keen/keen-dataviz.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keen/keen-dataviz.js/downloads","issues_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues{/number}","pulls_url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls{/number}","milestones_url":"https://api.github.com/repos/keen/keen-dataviz.js/milestones{/number}","notifications_url":"https://api.github.com/repos/keen/keen-dataviz.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keen/keen-dataviz.js/labels{/name}","releases_url":"https://api.github.com/repos/keen/keen-dataviz.js/releases{/id}","deployments_url":"https://api.github.com/repos/keen/keen-dataviz.js/deployments","created_at":"2015-08-20T18:07:56Z","updated_at":"2016-03-25T09:25:23Z","pushed_at":"2016-04-06T03:04:13Z","git_url":"git://github.com/keen/keen-dataviz.js.git","ssh_url":"git@github.com:keen/keen-dataviz.js.git","clone_url":"https://github.com/keen/keen-dataviz.js.git","svn_url":"https://github.com/keen/keen-dataviz.js","homepage":"http://keen.github.io/keen-dataviz.js/","size":1159,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"keen:master","ref":"master","sha":"efeb0beae071b416d088c271fd5114cd9a5e29c7","user":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"repo":{"id":41111304,"name":"keen-dataviz.js","full_name":"keen/keen-dataviz.js","owner":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keen/keen-dataviz.js","description":"NEW: Data Visualization SDK for Keen IO","fork":false,"url":"https://api.github.com/repos/keen/keen-dataviz.js","forks_url":"https://api.github.com/repos/keen/keen-dataviz.js/forks","keys_url":"https://api.github.com/repos/keen/keen-dataviz.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keen/keen-dataviz.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keen/keen-dataviz.js/teams","hooks_url":"https://api.github.com/repos/keen/keen-dataviz.js/hooks","issue_events_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/events{/number}","events_url":"https://api.github.com/repos/keen/keen-dataviz.js/events","assignees_url":"https://api.github.com/repos/keen/keen-dataviz.js/assignees{/user}","branches_url":"https://api.github.com/repos/keen/keen-dataviz.js/branches{/branch}","tags_url":"https://api.github.com/repos/keen/keen-dataviz.js/tags","blobs_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keen/keen-dataviz.js/statuses/{sha}","languages_url":"https://api.github.com/repos/keen/keen-dataviz.js/languages","stargazers_url":"https://api.github.com/repos/keen/keen-dataviz.js/stargazers","contributors_url":"https://api.github.com/repos/keen/keen-dataviz.js/contributors","subscribers_url":"https://api.github.com/repos/keen/keen-dataviz.js/subscribers","subscription_url":"https://api.github.com/repos/keen/keen-dataviz.js/subscription","commits_url":"https://api.github.com/repos/keen/keen-dataviz.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/keen/keen-dataviz.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/keen/keen-dataviz.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/keen/keen-dataviz.js/contents/{+path}","compare_url":"https://api.github.com/repos/keen/keen-dataviz.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keen/keen-dataviz.js/merges","archive_url":"https://api.github.com/repos/keen/keen-dataviz.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keen/keen-dataviz.js/downloads","issues_url":"https://api.github.com/repos/keen/keen-dataviz.js/issues{/number}","pulls_url":"https://api.github.com/repos/keen/keen-dataviz.js/pulls{/number}","milestones_url":"https://api.github.com/repos/keen/keen-dataviz.js/milestones{/number}","notifications_url":"https://api.github.com/repos/keen/keen-dataviz.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keen/keen-dataviz.js/labels{/name}","releases_url":"https://api.github.com/repos/keen/keen-dataviz.js/releases{/id}","deployments_url":"https://api.github.com/repos/keen/keen-dataviz.js/deployments","created_at":"2015-08-20T18:07:56Z","updated_at":"2016-03-25T09:25:23Z","pushed_at":"2016-04-06T03:04:13Z","git_url":"git://github.com/keen/keen-dataviz.js.git","ssh_url":"git@github.com:keen/keen-dataviz.js.git","clone_url":"https://github.com/keen/keen-dataviz.js.git","svn_url":"https://github.com/keen/keen-dataviz.js","homepage":"http://keen.github.io/keen-dataviz.js/","size":1159,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40"},"html":{"href":"https://github.com/keen/keen-dataviz.js/pull/40"},"issue":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/issues/40"},"comments":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/keen/keen-dataviz.js/statuses/03c8abc9cf279d328137a62fc6b828f8be3a0af6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":227,"deletions":0,"changed_files":8}}