{"action":"created","comment":{"url":"https://api.github.com/repos/mitchellh/packer/pulls/comments/78684517","id":78684517,"diff_hunk":"@@ -157,7 +157,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe\n \t\tui.Message(fmt.Sprintf(\"temp admin password: '%s'\", b.config.Password))\n \t}\n \n-\tb.runner = b.createRunner(&steps, ui)\n+\tb.runner = packerCommon.NewRunner(steps, b.config.PackerConfig, ui)","path":"builder/azure/arm/builder.go","position":5,"original_position":5,"commit_id":"897463e538d5719f4426e6a41bcd656171e49a49","original_commit_id":"897463e538d5719f4426e6a41bcd656171e49a49","user":{"login":"boumenot","id":91112,"avatar_url":"https://avatars.githubusercontent.com/u/91112?v=3","gravatar_id":"","url":"https://api.github.com/users/boumenot","html_url":"https://github.com/boumenot","followers_url":"https://api.github.com/users/boumenot/followers","following_url":"https://api.github.com/users/boumenot/following{/other_user}","gists_url":"https://api.github.com/users/boumenot/gists{/gist_id}","starred_url":"https://api.github.com/users/boumenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boumenot/subscriptions","organizations_url":"https://api.github.com/users/boumenot/orgs","repos_url":"https://api.github.com/users/boumenot/repos","events_url":"https://api.github.com/users/boumenot/events{/privacy}","received_events_url":"https://api.github.com/users/boumenot/received_events","type":"User","site_admin":false},"body":"I really like how this code is simplified for every builder.","created_at":"2016-09-14T04:24:59Z","updated_at":"2016-09-14T04:24:59Z","html_url":"https://github.com/mitchellh/packer/pull/3885#discussion_r78684517","pull_request_url":"https://api.github.com/repos/mitchellh/packer/pulls/3885","_links":{"self":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/comments/78684517"},"html":{"href":"https://github.com/mitchellh/packer/pull/3885#discussion_r78684517"},"pull_request":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3885"}}},"pull_request":{"url":"https://api.github.com/repos/mitchellh/packer/pulls/3885","id":85148004,"html_url":"https://github.com/mitchellh/packer/pull/3885","diff_url":"https://github.com/mitchellh/packer/pull/3885.diff","patch_url":"https://github.com/mitchellh/packer/pull/3885.patch","issue_url":"https://api.github.com/repos/mitchellh/packer/issues/3885","number":3885,"state":"open","locked":false,"title":"Add -on-error command line argument to allow preserving artifacts on builder errors","user":{"login":"orivej","id":101514,"avatar_url":"https://avatars.githubusercontent.com/u/101514?v=3","gravatar_id":"","url":"https://api.github.com/users/orivej","html_url":"https://github.com/orivej","followers_url":"https://api.github.com/users/orivej/followers","following_url":"https://api.github.com/users/orivej/following{/other_user}","gists_url":"https://api.github.com/users/orivej/gists{/gist_id}","starred_url":"https://api.github.com/users/orivej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orivej/subscriptions","organizations_url":"https://api.github.com/users/orivej/orgs","repos_url":"https://api.github.com/users/orivej/repos","events_url":"https://api.github.com/users/orivej/events{/privacy}","received_events_url":"https://api.github.com/users/orivej/received_events","type":"User","site_admin":false},"body":"This pull request resolves #409 by providing an option to delay or skip cleanup after unsuccessful `packer build`:\r\n\r\n```\r\n  -on-error=cleanup          When a builder fails, clean up and exit (the default)\r\n  -on-error=abort            When a builder fails, abort without cleanup\r\n  -on-error=ask              When a builder fails, prompt for action\r\n```\r\n\r\nRunning with `-on-error=ask`:\r\n\r\n```\r\n==> qemu: Step \"StepProvision\" failed\r\n==> qemu: [C]lean up and exit, [A]bort without cleanup, or [R]etry step (build may fail even if retry succeeds)? [car] |\r\n```","created_at":"2016-09-14T00:16:24Z","updated_at":"2016-09-14T04:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7fcf02943983555e64139f90506286d64990edd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/packer/pulls/3885/commits","review_comments_url":"https://api.github.com/repos/mitchellh/packer/pulls/3885/comments","review_comment_url":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitchellh/packer/issues/3885/comments","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/897463e538d5719f4426e6a41bcd656171e49a49","head":{"label":"orivej:on-error","ref":"on-error","sha":"897463e538d5719f4426e6a41bcd656171e49a49","user":{"login":"orivej","id":101514,"avatar_url":"https://avatars.githubusercontent.com/u/101514?v=3","gravatar_id":"","url":"https://api.github.com/users/orivej","html_url":"https://github.com/orivej","followers_url":"https://api.github.com/users/orivej/followers","following_url":"https://api.github.com/users/orivej/following{/other_user}","gists_url":"https://api.github.com/users/orivej/gists{/gist_id}","starred_url":"https://api.github.com/users/orivej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orivej/subscriptions","organizations_url":"https://api.github.com/users/orivej/orgs","repos_url":"https://api.github.com/users/orivej/repos","events_url":"https://api.github.com/users/orivej/events{/privacy}","received_events_url":"https://api.github.com/users/orivej/received_events","type":"User","site_admin":false},"repo":{"id":43341945,"name":"packer","full_name":"orivej/packer","owner":{"login":"orivej","id":101514,"avatar_url":"https://avatars.githubusercontent.com/u/101514?v=3","gravatar_id":"","url":"https://api.github.com/users/orivej","html_url":"https://github.com/orivej","followers_url":"https://api.github.com/users/orivej/followers","following_url":"https://api.github.com/users/orivej/following{/other_user}","gists_url":"https://api.github.com/users/orivej/gists{/gist_id}","starred_url":"https://api.github.com/users/orivej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orivej/subscriptions","organizations_url":"https://api.github.com/users/orivej/orgs","repos_url":"https://api.github.com/users/orivej/repos","events_url":"https://api.github.com/users/orivej/events{/privacy}","received_events_url":"https://api.github.com/users/orivej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orivej/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":true,"url":"https://api.github.com/repos/orivej/packer","forks_url":"https://api.github.com/repos/orivej/packer/forks","keys_url":"https://api.github.com/repos/orivej/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orivej/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orivej/packer/teams","hooks_url":"https://api.github.com/repos/orivej/packer/hooks","issue_events_url":"https://api.github.com/repos/orivej/packer/issues/events{/number}","events_url":"https://api.github.com/repos/orivej/packer/events","assignees_url":"https://api.github.com/repos/orivej/packer/assignees{/user}","branches_url":"https://api.github.com/repos/orivej/packer/branches{/branch}","tags_url":"https://api.github.com/repos/orivej/packer/tags","blobs_url":"https://api.github.com/repos/orivej/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orivej/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orivej/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/orivej/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orivej/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/orivej/packer/languages","stargazers_url":"https://api.github.com/repos/orivej/packer/stargazers","contributors_url":"https://api.github.com/repos/orivej/packer/contributors","subscribers_url":"https://api.github.com/repos/orivej/packer/subscribers","subscription_url":"https://api.github.com/repos/orivej/packer/subscription","commits_url":"https://api.github.com/repos/orivej/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/orivej/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/orivej/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/orivej/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/orivej/packer/contents/{+path}","compare_url":"https://api.github.com/repos/orivej/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orivej/packer/merges","archive_url":"https://api.github.com/repos/orivej/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orivej/packer/downloads","issues_url":"https://api.github.com/repos/orivej/packer/issues{/number}","pulls_url":"https://api.github.com/repos/orivej/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/orivej/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/orivej/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orivej/packer/labels{/name}","releases_url":"https://api.github.com/repos/orivej/packer/releases{/id}","deployments_url":"https://api.github.com/repos/orivej/packer/deployments","created_at":"2015-09-29T03:11:39Z","updated_at":"2015-12-05T18:55:44Z","pushed_at":"2016-09-14T01:22:54Z","git_url":"git://github.com/orivej/packer.git","ssh_url":"git@github.com:orivej/packer.git","clone_url":"https://github.com/orivej/packer.git","svn_url":"https://github.com/orivej/packer","homepage":"http://www.packer.io","size":19603,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"release-2"}},"base":{"label":"mitchellh:master","ref":"master","sha":"f6f50cd1df433a5bd7c24a81ad7001b3c223e24c","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":8966356,"name":"packer","full_name":"mitchellh/packer","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":false,"url":"https://api.github.com/repos/mitchellh/packer","forks_url":"https://api.github.com/repos/mitchellh/packer/forks","keys_url":"https://api.github.com/repos/mitchellh/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/packer/teams","hooks_url":"https://api.github.com/repos/mitchellh/packer/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/packer/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/packer/events","assignees_url":"https://api.github.com/repos/mitchellh/packer/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/packer/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/packer/tags","blobs_url":"https://api.github.com/repos/mitchellh/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/packer/languages","stargazers_url":"https://api.github.com/repos/mitchellh/packer/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/packer/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/packer/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/packer/subscription","commits_url":"https://api.github.com/repos/mitchellh/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellh/packer/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/packer/merges","archive_url":"https://api.github.com/repos/mitchellh/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/packer/downloads","issues_url":"https://api.github.com/repos/mitchellh/packer/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/packer/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/packer/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellh/packer/deployments","created_at":"2013-03-23T05:43:03Z","updated_at":"2016-09-13T18:58:06Z","pushed_at":"2016-09-14T01:22:54Z","git_url":"git://github.com/mitchellh/packer.git","ssh_url":"git@github.com:mitchellh/packer.git","clone_url":"https://github.com/mitchellh/packer.git","svn_url":"https://github.com/mitchellh/packer","homepage":"http://www.packer.io","size":37108,"stargazers_count":5683,"watchers_count":5683,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":568,"forks":1365,"open_issues":568,"watchers":5683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3885"},"html":{"href":"https://github.com/mitchellh/packer/pull/3885"},"issue":{"href":"https://api.github.com/repos/mitchellh/packer/issues/3885"},"comments":{"href":"https://api.github.com/repos/mitchellh/packer/issues/3885/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3885/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3885/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/packer/statuses/897463e538d5719f4426e6a41bcd656171e49a49"}}}}
{"actor":{"display_login":"boumenot"}}