{"action":"created","issue":{"url":"https://api.github.com/repos/BobSimons/erddap/issues/3","repository_url":"https://api.github.com/repos/BobSimons/erddap","labels_url":"https://api.github.com/repos/BobSimons/erddap/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/BobSimons/erddap/issues/3/comments","events_url":"https://api.github.com/repos/BobSimons/erddap/issues/3/events","html_url":"https://github.com/BobSimons/erddap/pull/3","id":184876763,"number":3,"title":"Small javadoc and code changes to easier compile project","user":{"login":"kwilcox","id":13939,"avatar_url":"https://avatars.githubusercontent.com/u/13939?v=3","gravatar_id":"","url":"https://api.github.com/users/kwilcox","html_url":"https://github.com/kwilcox","followers_url":"https://api.github.com/users/kwilcox/followers","following_url":"https://api.github.com/users/kwilcox/following{/other_user}","gists_url":"https://api.github.com/users/kwilcox/gists{/gist_id}","starred_url":"https://api.github.com/users/kwilcox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwilcox/subscriptions","organizations_url":"https://api.github.com/users/kwilcox/orgs","repos_url":"https://api.github.com/users/kwilcox/repos","events_url":"https://api.github.com/users/kwilcox/events{/privacy}","received_events_url":"https://api.github.com/users/kwilcox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-24T15:37:55Z","updated_at":"2016-10-25T18:42:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BobSimons/erddap/pulls/3","html_url":"https://github.com/BobSimons/erddap/pull/3","diff_url":"https://github.com/BobSimons/erddap/pull/3.diff","patch_url":"https://github.com/BobSimons/erddap/pull/3.patch"},"body":"This PR represents the changes I need to apply to each new ERDDAP version pushed to GitHub in order to more easily integrate it with our systems.\r\n\r\n* Yes - some of these changes are in files marked with comments like \"THIS CLASS IS NO LONGER SUPPORTED\". We still compile these classes and making these changes will allow for easier updates in the future.\r\n* No - we do not use any of these classes on our production instances\r\n* No - I have not tested these changes. @BobSimons will need to run the tests on his machine to verify any compatibility issues. I believe the changes are safe.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/BobSimons/erddap/issues/comments/256133990","html_url":"https://github.com/BobSimons/erddap/pull/3#issuecomment-256133990","issue_url":"https://api.github.com/repos/BobSimons/erddap/issues/3","id":256133990,"user":{"login":"BobSimons","id":1485624,"avatar_url":"https://avatars.githubusercontent.com/u/1485624?v=3","gravatar_id":"","url":"https://api.github.com/users/BobSimons","html_url":"https://github.com/BobSimons","followers_url":"https://api.github.com/users/BobSimons/followers","following_url":"https://api.github.com/users/BobSimons/following{/other_user}","gists_url":"https://api.github.com/users/BobSimons/gists{/gist_id}","starred_url":"https://api.github.com/users/BobSimons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobSimons/subscriptions","organizations_url":"https://api.github.com/users/BobSimons/orgs","repos_url":"https://api.github.com/users/BobSimons/repos","events_url":"https://api.github.com/users/BobSimons/events{/privacy}","received_events_url":"https://api.github.com/users/BobSimons/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T18:42:01Z","updated_at":"2016-10-25T18:42:01Z","body":"In my last email, I said I thought there were references to older code.\nI was wrong. Sorry.\n\nI made all the changes in my code with some tiny additional changes,\nnotably:\n* When I added releaseResources() method to several sgt classes, I made it\nso that they set the class' data to null.\n\nThe changes will be in the next group of changes I make to the master\nbranch on Git.  I think my compiling and tests won't detect all your\nchanges because they are in unused classes.\n\nThank you very much.\n\n\nOn Mon, Oct 24, 2016 at 9:04 AM, Bob Simons - NOAA Federal <\nbob.simons@noaa.gov> wrote:\n\n> Basically: Yes, it's great to hear that you are working on the code and\n> would like to make changes. Yes, the changes look good.\n>\n> But what version of ERDDAP is this based on? The current version in Git is\n> labelled 1.74, from about 2 weeks ago.\n> https://github.com/BobSimons/erddap\n> <https://github.com/BobSimons/erddap/pull/3.patch>\n> In my code, I can't find some of the code listed in the diff.\n>\n> ---\n> If your changes are based on older code (1.72?), since the changes are\n> limited, and since I'm so poorly skilled with Git (I know I have to get\n> better), it may make sense for me to make the changes here (if they are\n> still relevant), and post a new version to git (which I have to do this\n> week anyway for other reasons). How about that approach?\n>\n> I know that soon (in the next few weeks), I need to be able to do pulls\n> and branches and merges and such with Git. If I have questions, can I ask\n> you?\n>\n> Thanks.\n>\n>\n>\n>\n> On Mon, Oct 24, 2016 at 8:37 AM, Kyle Wilcox <notifications@github.com>\n> wrote:\n>\n>> This PR represents the changes I need to apply to each new ERDDAP version\n>> pushed to GitHub in order to more easily integrate it with our systems.\n>>\n>>    - Yes - some of these changes are in files marked with comments like\n>>    \"THIS CLASS IS NO LONGER SUPPORTED\". We still compile these classes and\n>>    making these changes will allow for easier updates in the future.\n>>    - No - we do not use any of these classes on our production instances\n>>    - No - I have not tested these changes. @BobSimons\n>>    <https://github.com/BobSimons> will need to run the tests on his\n>>    machine to verify any compatibility issues. I believe the changes are safe.\n>>\n>> ------------------------------\n>> You can view, comment on, or merge this pull request online at:\n>>\n>>   https://github.com/BobSimons/erddap/pull/3\n>> Commit Summary\n>>\n>>    - Small javadoc and code changes to easier compile project\n>>\n>> File Changes\n>>\n>>    - *M* WEB-INF/classes/com/cohort/util/JpegEncoder.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-0> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/coastwatch/Projects.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-1> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/coastwatch/griddata/OpendapDum\n>>    p.java <https://github.com/BobSimons/erddap/pull/3/files#diff-2> (5)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/coastwatch/sgt/GSHHSNewOnHold.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-3> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/coastwatch/util/Directory.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-4> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDGridFromBina\n>>    ryFile.java <https://github.com/BobSimons/erddap/pull/3/files#diff-5>\n>>    (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDGridFromMatF\n>>    iles.java <https://github.com/BobSimons/erddap/pull/3/files#diff-6>\n>>    (19)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDTableCopyPos\n>>    t.java <https://github.com/BobSimons/erddap/pull/3/files#diff-7> (30)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDTableFromAsc\n>>    iiService.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-8> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDTableFromErd\n>>    dap.java <https://github.com/BobSimons/erddap/pull/3/files#diff-9>\n>>    (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDTableFromNOS\n>>    .java <https://github.com/BobSimons/erddap/pull/3/files#diff-10> (7)\n>>    - *M* WEB-INF/classes/gov/noaa/pfel/erddap/dataset/EDDTableFromPos\n>>    tNcFiles.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-11> (2)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/LinearTransform.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-12> (4)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/MapGraph.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-13> (4)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/Pane.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-14> (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/PolarGraph.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-15> (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/TableLookupTransform.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-16> (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/demo/PseudoRealTimeData.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-17> (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/dm/SimpleTuple.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-18> (4)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/swing/UserIcon.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-19> (5)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/sgt/swing/ValueIcon.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-20> (3)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/util/ExponentialTransformDown.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-21> (4)\n>>    - *M* WEB-INF/classes/gov/noaa/pmel/util/ExponentialTransformUp.java\n>>    <https://github.com/BobSimons/erddap/pull/3/files#diff-22> (4)\n>>\n>> Patch Links:\n>>\n>>    - https://github.com/BobSimons/erddap/pull/3.patch\n>>    - https://github.com/BobSimons/erddap/pull/3.diff\n>>\n>> —\n>> You are receiving this because you were mentioned.\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/BobSimons/erddap/pull/3>, or mute the thread\n>> <https://github.com/notifications/unsubscribe-auth/ABarOM-bmxlDGILtUFB9sn5RyYGHHiy-ks5q3NDUgaJpZM4Ke8cY>\n>> .\n>>\n>\n>\n>\n> --\n> Sincerely,\n>\n> Bob Simons\n> IT Specialist\n> Environmental Research Division\n> NOAA Southwest Fisheries Science Center\n> 99 Pacific St., Suite 255A      (New!)\n> Monterey, CA 93940               (New!)\n> Phone: (831)333-9878            (New!)\n> Fax:   (831)648-8440\n> Email: bob.simons@noaa.gov\n>\n> The contents of this message are mine personally and\n> do not necessarily reflect any position of the\n> Government or the National Oceanic and Atmospheric Administration.\n> <>< <>< <>< <>< <>< <>< <>< <>< <><\n>\n>\n\n\n-- \nSincerely,\n\nBob Simons\nIT Specialist\nEnvironmental Research Division\nNOAA Southwest Fisheries Science Center\n99 Pacific St., Suite 255A      (New!)\nMonterey, CA 93940               (New!)\nPhone: (831)333-9878            (New!)\nFax:   (831)648-8440\nEmail: bob.simons@noaa.gov\n\nThe contents of this message are mine personally and\ndo not necessarily reflect any position of the\nGovernment or the National Oceanic and Atmospheric Administration.\n<>< <>< <>< <>< <>< <>< <>< <>< <><\n"}}
{"actor":{"display_login":"BobSimons"}}