{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14","id":79819265,"html_url":"https://github.com/mmatyas/EmulationStation/pull/14","diff_url":"https://github.com/mmatyas/EmulationStation/pull/14.diff","patch_url":"https://github.com/mmatyas/EmulationStation/pull/14.patch","issue_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/14","number":14,"state":"open","locked":false,"title":"Add symlink support","user":{"login":"mmatyas","id":4354863,"avatar_url":"https://avatars.githubusercontent.com/u/4354863?v=3","gravatar_id":"","url":"https://api.github.com/users/mmatyas","html_url":"https://github.com/mmatyas","followers_url":"https://api.github.com/users/mmatyas/followers","following_url":"https://api.github.com/users/mmatyas/following{/other_user}","gists_url":"https://api.github.com/users/mmatyas/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatyas/subscriptions","organizations_url":"https://api.github.com/users/mmatyas/orgs","repos_url":"https://api.github.com/users/mmatyas/repos","events_url":"https://api.github.com/users/mmatyas/events{/privacy}","received_events_url":"https://api.github.com/users/mmatyas/received_events","type":"User","site_admin":false},"body":"> The problem is that removeCommonPath doesn't work with symlinks 'cause fs::canonical returns the path of the original file instead of the symlink's, and relativeTo doesn't necessarily have to match the former, it's ment to match the latter. This causes that the scraped metadata doesn't work. We can avoid this by applying fs::canonical just to the parent path and then append the filename when the file is a symlink.\r\n\r\nSouce: Aloshi/EmulationStation#430","created_at":"2016-08-02T22:20:17Z","updated_at":"2016-08-02T22:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/14/comments","statuses_url":"https://api.github.com/repos/mmatyas/EmulationStation/statuses/e2dd1a8fda84bcac005cdba24a5a57b07163e3d0","head":{"label":"mmatyas:symlink","ref":"symlink","sha":"e2dd1a8fda84bcac005cdba24a5a57b07163e3d0","user":{"login":"mmatyas","id":4354863,"avatar_url":"https://avatars.githubusercontent.com/u/4354863?v=3","gravatar_id":"","url":"https://api.github.com/users/mmatyas","html_url":"https://github.com/mmatyas","followers_url":"https://api.github.com/users/mmatyas/followers","following_url":"https://api.github.com/users/mmatyas/following{/other_user}","gists_url":"https://api.github.com/users/mmatyas/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatyas/subscriptions","organizations_url":"https://api.github.com/users/mmatyas/orgs","repos_url":"https://api.github.com/users/mmatyas/repos","events_url":"https://api.github.com/users/mmatyas/events{/privacy}","received_events_url":"https://api.github.com/users/mmatyas/received_events","type":"User","site_admin":false},"repo":{"id":64314031,"name":"EmulationStation","full_name":"mmatyas/EmulationStation","owner":{"login":"mmatyas","id":4354863,"avatar_url":"https://avatars.githubusercontent.com/u/4354863?v=3","gravatar_id":"","url":"https://api.github.com/users/mmatyas","html_url":"https://github.com/mmatyas","followers_url":"https://api.github.com/users/mmatyas/followers","following_url":"https://api.github.com/users/mmatyas/following{/other_user}","gists_url":"https://api.github.com/users/mmatyas/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatyas/subscriptions","organizations_url":"https://api.github.com/users/mmatyas/orgs","repos_url":"https://api.github.com/users/mmatyas/repos","events_url":"https://api.github.com/users/mmatyas/events{/privacy}","received_events_url":"https://api.github.com/users/mmatyas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmatyas/EmulationStation","description":"A flexible emulator front-end supporting keyboardless navigation and custom system themes.","fork":true,"url":"https://api.github.com/repos/mmatyas/EmulationStation","forks_url":"https://api.github.com/repos/mmatyas/EmulationStation/forks","keys_url":"https://api.github.com/repos/mmatyas/EmulationStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmatyas/EmulationStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmatyas/EmulationStation/teams","hooks_url":"https://api.github.com/repos/mmatyas/EmulationStation/hooks","issue_events_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/events{/number}","events_url":"https://api.github.com/repos/mmatyas/EmulationStation/events","assignees_url":"https://api.github.com/repos/mmatyas/EmulationStation/assignees{/user}","branches_url":"https://api.github.com/repos/mmatyas/EmulationStation/branches{/branch}","tags_url":"https://api.github.com/repos/mmatyas/EmulationStation/tags","blobs_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmatyas/EmulationStation/statuses/{sha}","languages_url":"https://api.github.com/repos/mmatyas/EmulationStation/languages","stargazers_url":"https://api.github.com/repos/mmatyas/EmulationStation/stargazers","contributors_url":"https://api.github.com/repos/mmatyas/EmulationStation/contributors","subscribers_url":"https://api.github.com/repos/mmatyas/EmulationStation/subscribers","subscription_url":"https://api.github.com/repos/mmatyas/EmulationStation/subscription","commits_url":"https://api.github.com/repos/mmatyas/EmulationStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmatyas/EmulationStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmatyas/EmulationStation/contents/{+path}","compare_url":"https://api.github.com/repos/mmatyas/EmulationStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmatyas/EmulationStation/merges","archive_url":"https://api.github.com/repos/mmatyas/EmulationStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmatyas/EmulationStation/downloads","issues_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues{/number}","pulls_url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls{/number}","milestones_url":"https://api.github.com/repos/mmatyas/EmulationStation/milestones{/number}","notifications_url":"https://api.github.com/repos/mmatyas/EmulationStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmatyas/EmulationStation/labels{/name}","releases_url":"https://api.github.com/repos/mmatyas/EmulationStation/releases{/id}","deployments_url":"https://api.github.com/repos/mmatyas/EmulationStation/deployments","created_at":"2016-07-27T14:12:02Z","updated_at":"2016-08-01T11:06:00Z","pushed_at":"2016-08-02T22:20:17Z","git_url":"git://github.com/mmatyas/EmulationStation.git","ssh_url":"git@github.com:mmatyas/EmulationStation.git","clone_url":"https://github.com/mmatyas/EmulationStation.git","svn_url":"https://github.com/mmatyas/EmulationStation","homepage":"","size":7327,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mmatyas:master","ref":"master","sha":"16470e50b9ef007261ee44c55af970a0ef8b6439","user":{"login":"mmatyas","id":4354863,"avatar_url":"https://avatars.githubusercontent.com/u/4354863?v=3","gravatar_id":"","url":"https://api.github.com/users/mmatyas","html_url":"https://github.com/mmatyas","followers_url":"https://api.github.com/users/mmatyas/followers","following_url":"https://api.github.com/users/mmatyas/following{/other_user}","gists_url":"https://api.github.com/users/mmatyas/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatyas/subscriptions","organizations_url":"https://api.github.com/users/mmatyas/orgs","repos_url":"https://api.github.com/users/mmatyas/repos","events_url":"https://api.github.com/users/mmatyas/events{/privacy}","received_events_url":"https://api.github.com/users/mmatyas/received_events","type":"User","site_admin":false},"repo":{"id":64314031,"name":"EmulationStation","full_name":"mmatyas/EmulationStation","owner":{"login":"mmatyas","id":4354863,"avatar_url":"https://avatars.githubusercontent.com/u/4354863?v=3","gravatar_id":"","url":"https://api.github.com/users/mmatyas","html_url":"https://github.com/mmatyas","followers_url":"https://api.github.com/users/mmatyas/followers","following_url":"https://api.github.com/users/mmatyas/following{/other_user}","gists_url":"https://api.github.com/users/mmatyas/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatyas/subscriptions","organizations_url":"https://api.github.com/users/mmatyas/orgs","repos_url":"https://api.github.com/users/mmatyas/repos","events_url":"https://api.github.com/users/mmatyas/events{/privacy}","received_events_url":"https://api.github.com/users/mmatyas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmatyas/EmulationStation","description":"A flexible emulator front-end supporting keyboardless navigation and custom system themes.","fork":true,"url":"https://api.github.com/repos/mmatyas/EmulationStation","forks_url":"https://api.github.com/repos/mmatyas/EmulationStation/forks","keys_url":"https://api.github.com/repos/mmatyas/EmulationStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmatyas/EmulationStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmatyas/EmulationStation/teams","hooks_url":"https://api.github.com/repos/mmatyas/EmulationStation/hooks","issue_events_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/events{/number}","events_url":"https://api.github.com/repos/mmatyas/EmulationStation/events","assignees_url":"https://api.github.com/repos/mmatyas/EmulationStation/assignees{/user}","branches_url":"https://api.github.com/repos/mmatyas/EmulationStation/branches{/branch}","tags_url":"https://api.github.com/repos/mmatyas/EmulationStation/tags","blobs_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmatyas/EmulationStation/statuses/{sha}","languages_url":"https://api.github.com/repos/mmatyas/EmulationStation/languages","stargazers_url":"https://api.github.com/repos/mmatyas/EmulationStation/stargazers","contributors_url":"https://api.github.com/repos/mmatyas/EmulationStation/contributors","subscribers_url":"https://api.github.com/repos/mmatyas/EmulationStation/subscribers","subscription_url":"https://api.github.com/repos/mmatyas/EmulationStation/subscription","commits_url":"https://api.github.com/repos/mmatyas/EmulationStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmatyas/EmulationStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmatyas/EmulationStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmatyas/EmulationStation/contents/{+path}","compare_url":"https://api.github.com/repos/mmatyas/EmulationStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmatyas/EmulationStation/merges","archive_url":"https://api.github.com/repos/mmatyas/EmulationStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmatyas/EmulationStation/downloads","issues_url":"https://api.github.com/repos/mmatyas/EmulationStation/issues{/number}","pulls_url":"https://api.github.com/repos/mmatyas/EmulationStation/pulls{/number}","milestones_url":"https://api.github.com/repos/mmatyas/EmulationStation/milestones{/number}","notifications_url":"https://api.github.com/repos/mmatyas/EmulationStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmatyas/EmulationStation/labels{/name}","releases_url":"https://api.github.com/repos/mmatyas/EmulationStation/releases{/id}","deployments_url":"https://api.github.com/repos/mmatyas/EmulationStation/deployments","created_at":"2016-07-27T14:12:02Z","updated_at":"2016-08-01T11:06:00Z","pushed_at":"2016-08-02T22:20:17Z","git_url":"git://github.com/mmatyas/EmulationStation.git","ssh_url":"git@github.com:mmatyas/EmulationStation.git","clone_url":"https://github.com/mmatyas/EmulationStation.git","svn_url":"https://github.com/mmatyas/EmulationStation","homepage":"","size":7327,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14"},"html":{"href":"https://github.com/mmatyas/EmulationStation/pull/14"},"issue":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/issues/14"},"comments":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mmatyas/EmulationStation/statuses/e2dd1a8fda84bcac005cdba24a5a57b07163e3d0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mmatyas"}}