{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/comments/50014804","id":50014804,"diff_hunk":"@@ -89,6 +96,30 @@ Arguments:\n EOF\n }\n \n+# This function checks if there variables like BASEDIR, CLASSLOADER_FILE etc exists ( checks all variables defined in template_vars )\n+# If environment variable exists, it's value is used as default when parsing template","path":"bin/vhost.sh","position":50,"original_position":50,"commit_id":"cabfb47448e7dc9fd81061aa5a7398ddcc30c9b3","original_commit_id":"cabfb47448e7dc9fd81061aa5a7398ddcc30c9b3","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"This part is breaking one aspect of the script, variables %BODY_SIZE_LIMIT_M%, %TIMEOUT_S% and %HOST_LIST% are internal aliases with somewhat other format to be able to inject into nginx, and not exposed as arguments. Idea is that you should be able to run the command more or less the same no matter which server you want to configure. \r\n\r\nWith change here this changes, it means you directly use the variables in format for nginx instead of the format documented for the script.","created_at":"2016-01-18T16:01:45Z","updated_at":"2016-01-18T16:01:45Z","html_url":"https://github.com/ezsystems/ezplatform/pull/83#discussion_r50014804","pull_request_url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/comments/50014804"},"html":{"href":"https://github.com/ezsystems/ezplatform/pull/83#discussion_r50014804"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83","id":56356572,"html_url":"https://github.com/ezsystems/ezplatform/pull/83","diff_url":"https://github.com/ezsystems/ezplatform/pull/83.diff","patch_url":"https://github.com/ezsystems/ezplatform/pull/83.patch","issue_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/83","number":83,"state":"open","locked":false,"title":"WIP: Nginx bash vhost script","user":{"login":"vidarl","id":289778,"avatar_url":"https://avatars.githubusercontent.com/u/289778?v=3","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"body":"Continuation of AR's https://github.com/ezsystems/ezplatform/pull/81\r\n\r\nThis PR adds nginx part of the changes + some fixes to AR's PR","created_at":"2016-01-18T15:31:13Z","updated_at":"2016-01-18T16:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a0d4aafeada8bf9c4f93b712b937d7bb2229b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/83/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform/statuses/cabfb47448e7dc9fd81061aa5a7398ddcc30c9b3","head":{"label":"vidarl:nginx_bash_vhost_script","ref":"nginx_bash_vhost_script","sha":"cabfb47448e7dc9fd81061aa5a7398ddcc30c9b3","user":{"login":"vidarl","id":289778,"avatar_url":"https://avatars.githubusercontent.com/u/289778?v=3","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"repo":{"id":41670725,"name":"ezplatform","full_name":"vidarl/ezplatform","owner":{"login":"vidarl","id":289778,"avatar_url":"https://avatars.githubusercontent.com/u/289778?v=3","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidarl/ezplatform","description":"This is eZ Platform (aka eZ Publish 6.x), it is a meta repository that pulls in all dependencies for full distribution.","fork":true,"url":"https://api.github.com/repos/vidarl/ezplatform","forks_url":"https://api.github.com/repos/vidarl/ezplatform/forks","keys_url":"https://api.github.com/repos/vidarl/ezplatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidarl/ezplatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidarl/ezplatform/teams","hooks_url":"https://api.github.com/repos/vidarl/ezplatform/hooks","issue_events_url":"https://api.github.com/repos/vidarl/ezplatform/issues/events{/number}","events_url":"https://api.github.com/repos/vidarl/ezplatform/events","assignees_url":"https://api.github.com/repos/vidarl/ezplatform/assignees{/user}","branches_url":"https://api.github.com/repos/vidarl/ezplatform/branches{/branch}","tags_url":"https://api.github.com/repos/vidarl/ezplatform/tags","blobs_url":"https://api.github.com/repos/vidarl/ezplatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidarl/ezplatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidarl/ezplatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidarl/ezplatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidarl/ezplatform/statuses/{sha}","languages_url":"https://api.github.com/repos/vidarl/ezplatform/languages","stargazers_url":"https://api.github.com/repos/vidarl/ezplatform/stargazers","contributors_url":"https://api.github.com/repos/vidarl/ezplatform/contributors","subscribers_url":"https://api.github.com/repos/vidarl/ezplatform/subscribers","subscription_url":"https://api.github.com/repos/vidarl/ezplatform/subscription","commits_url":"https://api.github.com/repos/vidarl/ezplatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidarl/ezplatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidarl/ezplatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidarl/ezplatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidarl/ezplatform/contents/{+path}","compare_url":"https://api.github.com/repos/vidarl/ezplatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidarl/ezplatform/merges","archive_url":"https://api.github.com/repos/vidarl/ezplatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidarl/ezplatform/downloads","issues_url":"https://api.github.com/repos/vidarl/ezplatform/issues{/number}","pulls_url":"https://api.github.com/repos/vidarl/ezplatform/pulls{/number}","milestones_url":"https://api.github.com/repos/vidarl/ezplatform/milestones{/number}","notifications_url":"https://api.github.com/repos/vidarl/ezplatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidarl/ezplatform/labels{/name}","releases_url":"https://api.github.com/repos/vidarl/ezplatform/releases{/id}","created_at":"2015-08-31T10:58:12Z","updated_at":"2015-08-31T10:58:13Z","pushed_at":"2016-01-18T15:28:33Z","git_url":"git://github.com/vidarl/ezplatform.git","ssh_url":"git@github.com:vidarl/ezplatform.git","clone_url":"https://github.com/vidarl/ezplatform.git","svn_url":"https://github.com/vidarl/ezplatform","homepage":"http://share.ez.no  ","size":6683,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:bash_vhost_script","ref":"bash_vhost_script","sha":"28b6442d12058cb108595be495791549882bfaa2","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":31363530,"name":"ezplatform","full_name":"ezsystems/ezplatform","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezplatform","description":"eZ Platform (aka eZ Publish 6.x), a meta repository that pulls in all dependencies for clean distribution.","fork":false,"url":"https://api.github.com/repos/ezsystems/ezplatform","forks_url":"https://api.github.com/repos/ezsystems/ezplatform/forks","keys_url":"https://api.github.com/repos/ezsystems/ezplatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezplatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezplatform/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezplatform/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezplatform/events","assignees_url":"https://api.github.com/repos/ezsystems/ezplatform/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezplatform/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezplatform/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezplatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezplatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezplatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezplatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezplatform/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezplatform/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezplatform/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezplatform/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezplatform/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezplatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezplatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezplatform/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezplatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezplatform/merges","archive_url":"https://api.github.com/repos/ezsystems/ezplatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezplatform/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezplatform/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezplatform/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezplatform/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezplatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezplatform/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezplatform/releases{/id}","created_at":"2015-02-26T11:12:45Z","updated_at":"2016-01-17T23:21:47Z","pushed_at":"2016-01-18T15:31:13Z","git_url":"git://github.com/ezsystems/ezplatform.git","ssh_url":"git@github.com:ezsystems/ezplatform.git","clone_url":"https://github.com/ezsystems/ezplatform.git","svn_url":"https://github.com/ezsystems/ezplatform","homepage":"http://ezplatform.com/","size":6751,"stargazers_count":66,"watchers_count":66,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":6,"forks":46,"open_issues":6,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83"},"html":{"href":"https://github.com/ezsystems/ezplatform/pull/83"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezplatform/issues/83"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezplatform/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezplatform/statuses/cabfb47448e7dc9fd81061aa5a7398ddcc30c9b3"}}}}