{"action":"created","issue":{"url":"https://api.github.com/repos/vstakhov/rspamd/issues/525","repository_url":"https://api.github.com/repos/vstakhov/rspamd","labels_url":"https://api.github.com/repos/vstakhov/rspamd/issues/525/labels{/name}","comments_url":"https://api.github.com/repos/vstakhov/rspamd/issues/525/comments","events_url":"https://api.github.com/repos/vstakhov/rspamd/issues/525/events","html_url":"https://github.com/vstakhov/rspamd/issues/525","id":133645885,"number":525,"title":"Why is the check_html_image function limited to embedded images?","user":{"login":"moisseev","id":2275981,"avatar_url":"https://avatars.githubusercontent.com/u/2275981?v=3","gravatar_id":"","url":"https://api.github.com/users/moisseev","html_url":"https://github.com/moisseev","followers_url":"https://api.github.com/users/moisseev/followers","following_url":"https://api.github.com/users/moisseev/following{/other_user}","gists_url":"https://api.github.com/users/moisseev/gists{/gist_id}","starred_url":"https://api.github.com/users/moisseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moisseev/subscriptions","organizations_url":"https://api.github.com/users/moisseev/orgs","repos_url":"https://api.github.com/users/moisseev/repos","events_url":"https://api.github.com/users/moisseev/events{/privacy}","received_events_url":"https://api.github.com/users/moisseev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-15T07:45:30Z","updated_at":"2016-02-15T11:53:05Z","closed_at":null,"body":"Is there a reason to this condition?\r\nhttps://github.com/vstakhov/rspamd/blob/73373fe6130293dbb563be86f5f2d85c3c15ba6e/rules/html.lua#L36\r\nWhy not to remove it and catch linked images like that as well?\r\n~~~html\r\n<a href=\"http://wikidrupal.ru/go/masterlittera.com/jexr/aHR0cDovL29jYnB=\r\nhYy5wdy8/YXBrODV5bDQyejR6NjV2djMyYTB0eg==\"><img src=\"https://pbs.tw=\r\nimg.com/media/CWX8-jZWEAIV1js.jpg\"></a>\r\n~~~\r\n\r\n~~~html\r\n<a href=\"http://msichicago.org/exit.php?url=onsol.ru/dire\r\nct/go/aHR0cDovL3Byb3MucnBpb24ucnUvP2doM3htOG50bW5vNGdo\" class=\"underline\"><\r\nimg src=\"https://pbs.twimg.com/media/CWH4FYRWsAEohcC.jpg\"\r\n></a>\r\n~~~\r\n"},"comment":{"url":"https://api.github.com/repos/vstakhov/rspamd/issues/comments/184179301","html_url":"https://github.com/vstakhov/rspamd/issues/525#issuecomment-184179301","issue_url":"https://api.github.com/repos/vstakhov/rspamd/issues/525","id":184179301,"user":{"login":"moisseev","id":2275981,"avatar_url":"https://avatars.githubusercontent.com/u/2275981?v=3","gravatar_id":"","url":"https://api.github.com/users/moisseev","html_url":"https://github.com/moisseev","followers_url":"https://api.github.com/users/moisseev/followers","following_url":"https://api.github.com/users/moisseev/following{/other_user}","gists_url":"https://api.github.com/users/moisseev/gists{/gist_id}","starred_url":"https://api.github.com/users/moisseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moisseev/subscriptions","organizations_url":"https://api.github.com/users/moisseev/orgs","repos_url":"https://api.github.com/users/moisseev/repos","events_url":"https://api.github.com/users/moisseev/events{/privacy}","received_events_url":"https://api.github.com/users/moisseev/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T11:53:05Z","updated_at":"2016-02-15T11:53:05Z","body":"Do you really have evidence of such legitimate messages with  just a single external image that use an image as a link (`<img>` element inside `<a>`)? If you meant legitimate messages with a link to an image in `href` attribute but without an `<img>` element, it should be safe just remove the condition."}}