{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/82198053","pull_request_review_id":3121436,"id":82198053,"diff_hunk":"@@ -2546,11 +2546,11 @@ struct SpellXSpellVisualEntry\n struct SummonPropertiesEntry\n {\n     uint32 ID;\n+    uint32 Flags;\n     uint32 Category;\n     uint32 Faction;\n     uint32 Type;\n-    int32 Slot;","path":"src/server/game/DataStores/DB2Structure.h","position":8,"original_position":8,"commit_id":"b0c970be0f2e525830ab0557dadc294611371eaa","original_commit_id":"b0c970be0f2e525830ab0557dadc294611371eaa","user":{"login":"matukaa","id":7106864,"avatar_url":"https://avatars.githubusercontent.com/u/7106864?v=3","gravatar_id":"","url":"https://api.github.com/users/matukaa","html_url":"https://github.com/matukaa","followers_url":"https://api.github.com/users/matukaa/followers","following_url":"https://api.github.com/users/matukaa/following{/other_user}","gists_url":"https://api.github.com/users/matukaa/gists{/gist_id}","starred_url":"https://api.github.com/users/matukaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matukaa/subscriptions","organizations_url":"https://api.github.com/users/matukaa/orgs","repos_url":"https://api.github.com/users/matukaa/repos","events_url":"https://api.github.com/users/matukaa/events{/privacy}","received_events_url":"https://api.github.com/users/matukaa/received_events","type":"User","site_admin":false},"body":"@Shauren @funjoker please check SummonProperties.db2. Slot is NOT an int32, neither uint32. it must be uint8. there are many new spells in legion having Slot = 255 (that is -1 in uint8 format). check the effect handler for summon, it will try to add the Summon into the specified slot IF slot>0. that is key, because m_SummonSlot for players is an array with a capacity of 9. it is unwise to try to add a summon there. it will crash","created_at":"2016-10-06T14:14:53Z","updated_at":"2016-10-06T14:14:53Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/18040#discussion_r82198053","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/82198053"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18040#discussion_r82198053"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040","id":88015961,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/18040","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/18040.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/18040.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18040","number":18040,"state":"open","locked":false,"title":"Update SummonProperties.db2 structure and HotfixeDB","user":{"login":"funjoker","id":846960,"avatar_url":"https://avatars.githubusercontent.com/u/846960?v=3","gravatar_id":"","url":"https://api.github.com/users/funjoker","html_url":"https://github.com/funjoker","followers_url":"https://api.github.com/users/funjoker/followers","following_url":"https://api.github.com/users/funjoker/following{/other_user}","gists_url":"https://api.github.com/users/funjoker/gists{/gist_id}","starred_url":"https://api.github.com/users/funjoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funjoker/subscriptions","organizations_url":"https://api.github.com/users/funjoker/orgs","repos_url":"https://api.github.com/users/funjoker/repos","events_url":"https://api.github.com/users/funjoker/events{/privacy}","received_events_url":"https://api.github.com/users/funjoker/received_events","type":"User","site_admin":false},"body":"[//]: # (************************************************************)\r\n[//]: # (** DON'T DELETE THIS TEMPLATE ELSE YOUR PR WILL BE CLOSED **)\r\n[//]: # (************************************************************)\r\n\r\n**Changes proposed:**\r\n\r\n-  Apply structure Core and DB\r\n\r\n\r\n**Target branch(es):** 6.x\r\n\r\n**Issues addressed:** Closes #18036\r\n\r\n**Tests performed:** Builds. NPCs are summoned. Now some Bugs due to summon code\r\n\r\n**Known issues and TODO list:**\r\n\r\n-  New Types\r\n-  Some missing handling of Types\r\n","created_at":"2016-10-05T04:50:39Z","updated_at":"2016-10-06T14:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e7bcad581f11f16d4fe7d5e59f9223b0e30c103","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18040/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/b0c970be0f2e525830ab0557dadc294611371eaa","head":{"label":"funjoker:6.x","ref":"6.x","sha":"b0c970be0f2e525830ab0557dadc294611371eaa","user":{"login":"funjoker","id":846960,"avatar_url":"https://avatars.githubusercontent.com/u/846960?v=3","gravatar_id":"","url":"https://api.github.com/users/funjoker","html_url":"https://github.com/funjoker","followers_url":"https://api.github.com/users/funjoker/followers","following_url":"https://api.github.com/users/funjoker/following{/other_user}","gists_url":"https://api.github.com/users/funjoker/gists{/gist_id}","starred_url":"https://api.github.com/users/funjoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funjoker/subscriptions","organizations_url":"https://api.github.com/users/funjoker/orgs","repos_url":"https://api.github.com/users/funjoker/repos","events_url":"https://api.github.com/users/funjoker/events{/privacy}","received_events_url":"https://api.github.com/users/funjoker/received_events","type":"User","site_admin":false},"repo":{"id":70028056,"name":"TrinityCore","full_name":"funjoker/TrinityCore","owner":{"login":"funjoker","id":846960,"avatar_url":"https://avatars.githubusercontent.com/u/846960?v=3","gravatar_id":"","url":"https://api.github.com/users/funjoker","html_url":"https://github.com/funjoker","followers_url":"https://api.github.com/users/funjoker/followers","following_url":"https://api.github.com/users/funjoker/following{/other_user}","gists_url":"https://api.github.com/users/funjoker/gists{/gist_id}","starred_url":"https://api.github.com/users/funjoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funjoker/subscriptions","organizations_url":"https://api.github.com/users/funjoker/orgs","repos_url":"https://api.github.com/users/funjoker/repos","events_url":"https://api.github.com/users/funjoker/events{/privacy}","received_events_url":"https://api.github.com/users/funjoker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/funjoker/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/funjoker/TrinityCore","forks_url":"https://api.github.com/repos/funjoker/TrinityCore/forks","keys_url":"https://api.github.com/repos/funjoker/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funjoker/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funjoker/TrinityCore/teams","hooks_url":"https://api.github.com/repos/funjoker/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/funjoker/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/funjoker/TrinityCore/events","assignees_url":"https://api.github.com/repos/funjoker/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/funjoker/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/funjoker/TrinityCore/tags","blobs_url":"https://api.github.com/repos/funjoker/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funjoker/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funjoker/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/funjoker/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funjoker/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/funjoker/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/funjoker/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/funjoker/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/funjoker/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/funjoker/TrinityCore/subscription","commits_url":"https://api.github.com/repos/funjoker/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/funjoker/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/funjoker/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/funjoker/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/funjoker/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/funjoker/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funjoker/TrinityCore/merges","archive_url":"https://api.github.com/repos/funjoker/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funjoker/TrinityCore/downloads","issues_url":"https://api.github.com/repos/funjoker/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/funjoker/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/funjoker/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/funjoker/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funjoker/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/funjoker/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/funjoker/TrinityCore/deployments","created_at":"2016-10-05T03:46:06Z","updated_at":"2016-10-05T03:46:24Z","pushed_at":"2016-10-06T00:00:42Z","git_url":"git://github.com/funjoker/TrinityCore.git","ssh_url":"git@github.com:funjoker/TrinityCore.git","clone_url":"https://github.com/funjoker/TrinityCore.git","svn_url":"https://github.com/funjoker/TrinityCore","homepage":"http://www.trinitycore.org","size":376803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:6.x","ref":"6.x","sha":"9d07fa9bfc4f67280915bb0c90f9bbfda4bc9deb","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-10-06T09:50:19Z","pushed_at":"2016-10-06T09:29:10Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":806888,"stargazers_count":3485,"watchers_count":3485,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3560,"mirror_url":null,"open_issues_count":1292,"forks":3560,"open_issues":1292,"watchers":3485,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18040"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18040"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18040/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18040/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/b0c970be0f2e525830ab0557dadc294611371eaa"}}}}
{"actor":{"display_login":"matukaa"}}