{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/web-ext/pulls/comments/73934309","id":73934309,"diff_hunk":"@@ -2,19 +2,74 @@\n import bunyan, {nameFromLevel, createLogger as defaultLogCreator}\n   from 'bunyan';\n \n+// Flow types\n+\n+import type {Logger} from 'bunyan';\n+\n+import type {Writable} from 'stream';\n+import type {WriteStream} from 'tty';\n+\n+export type FakeProcess = {\n+  stdout: Writable | WriteStream;\n+};\n+\n+export type ConsoleExtraParams = {\n+  localProcess?: FakeProcess,\n+};\n+\n+// Bunyan-related types\n+\n+export type TRACE = 10\n+export type DEBUG = 20;\n+export type INFO = 30;\n+export type WARN = 40;\n+export type ERROR = 50;\n+export type FATAL = 60;\n+\n+export type BunyanLogLevel =\n+  TRACE | DEBUG | INFO | WARN | ERROR | FATAL;\n+\n+export type ConsoleStreamParams = {\n+  verbose?: boolean,\n+};\n+\n+export type ConsoleFormatParams = {","path":"src/util/logger.js","position":35,"original_position":35,"commit_id":"38ff882817ad89996a8e72e134a48fe32bf2beab","original_commit_id":"38ff882817ad89996a8e72e134a48fe32bf2beab","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"I think `BunyanLogEntry` would be a better name","created_at":"2016-08-08T19:04:10Z","updated_at":"2016-08-08T19:04:10Z","html_url":"https://github.com/mozilla/web-ext/pull/424#discussion_r73934309","pull_request_url":"https://api.github.com/repos/mozilla/web-ext/pulls/424","_links":{"self":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/comments/73934309"},"html":{"href":"https://github.com/mozilla/web-ext/pull/424#discussion_r73934309"},"pull_request":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/web-ext/pulls/424","id":80463254,"html_url":"https://github.com/mozilla/web-ext/pull/424","diff_url":"https://github.com/mozilla/web-ext/pull/424.diff","patch_url":"https://github.com/mozilla/web-ext/pull/424.patch","issue_url":"https://api.github.com/repos/mozilla/web-ext/issues/424","number":424,"state":"open","locked":false,"title":"Test: add more flow types","user":{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"body":"In this PR there are the changes related to the additional flow type checking (that are currently part of #411) extracted and extended with much more flow types checks.\r\n\r\nOnce we complete this PR, #411 will be rebased on the final version of these changes and it will be limited to the introduction of the `async/await` syntax (with the additional safety net provided by the additional static analysis that flow will be able to provide).","created_at":"2016-08-08T14:44:06Z","updated_at":"2016-08-08T19:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"052c0f241714209405abb3a4345545e986046f5d","assignee":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"assignees":[{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/web-ext/pulls/424/commits","review_comments_url":"https://api.github.com/repos/mozilla/web-ext/pulls/424/comments","review_comment_url":"https://api.github.com/repos/mozilla/web-ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/web-ext/issues/424/comments","statuses_url":"https://api.github.com/repos/mozilla/web-ext/statuses/38ff882817ad89996a8e72e134a48fe32bf2beab","head":{"label":"rpl:test/add-more-flow-types","ref":"test/add-more-flow-types","sha":"38ff882817ad89996a8e72e134a48fe32bf2beab","user":{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"repo":{"id":52906404,"name":"web-ext","full_name":"rpl/web-ext","owner":{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpl/web-ext","description":"A command line tool to help build, run, and test web extensions","fork":true,"url":"https://api.github.com/repos/rpl/web-ext","forks_url":"https://api.github.com/repos/rpl/web-ext/forks","keys_url":"https://api.github.com/repos/rpl/web-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpl/web-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpl/web-ext/teams","hooks_url":"https://api.github.com/repos/rpl/web-ext/hooks","issue_events_url":"https://api.github.com/repos/rpl/web-ext/issues/events{/number}","events_url":"https://api.github.com/repos/rpl/web-ext/events","assignees_url":"https://api.github.com/repos/rpl/web-ext/assignees{/user}","branches_url":"https://api.github.com/repos/rpl/web-ext/branches{/branch}","tags_url":"https://api.github.com/repos/rpl/web-ext/tags","blobs_url":"https://api.github.com/repos/rpl/web-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpl/web-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpl/web-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpl/web-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpl/web-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/rpl/web-ext/languages","stargazers_url":"https://api.github.com/repos/rpl/web-ext/stargazers","contributors_url":"https://api.github.com/repos/rpl/web-ext/contributors","subscribers_url":"https://api.github.com/repos/rpl/web-ext/subscribers","subscription_url":"https://api.github.com/repos/rpl/web-ext/subscription","commits_url":"https://api.github.com/repos/rpl/web-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpl/web-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpl/web-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpl/web-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpl/web-ext/contents/{+path}","compare_url":"https://api.github.com/repos/rpl/web-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpl/web-ext/merges","archive_url":"https://api.github.com/repos/rpl/web-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpl/web-ext/downloads","issues_url":"https://api.github.com/repos/rpl/web-ext/issues{/number}","pulls_url":"https://api.github.com/repos/rpl/web-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/rpl/web-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/rpl/web-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpl/web-ext/labels{/name}","releases_url":"https://api.github.com/repos/rpl/web-ext/releases{/id}","deployments_url":"https://api.github.com/repos/rpl/web-ext/deployments","created_at":"2016-03-01T20:10:06Z","updated_at":"2016-03-01T20:10:07Z","pushed_at":"2016-08-08T14:14:46Z","git_url":"git://github.com/rpl/web-ext.git","ssh_url":"git@github.com:rpl/web-ext.git","clone_url":"https://github.com/rpl/web-ext.git","svn_url":"https://github.com/rpl/web-ext","homepage":null,"size":413,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"74d7541d51f3f9f0521a65d9d7e6b67e24013fb4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50859563,"name":"web-ext","full_name":"mozilla/web-ext","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/web-ext","description":"A command line tool to help build, run, and test web extensions","fork":false,"url":"https://api.github.com/repos/mozilla/web-ext","forks_url":"https://api.github.com/repos/mozilla/web-ext/forks","keys_url":"https://api.github.com/repos/mozilla/web-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/web-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/web-ext/teams","hooks_url":"https://api.github.com/repos/mozilla/web-ext/hooks","issue_events_url":"https://api.github.com/repos/mozilla/web-ext/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/web-ext/events","assignees_url":"https://api.github.com/repos/mozilla/web-ext/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/web-ext/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/web-ext/tags","blobs_url":"https://api.github.com/repos/mozilla/web-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/web-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/web-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/web-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/web-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/web-ext/languages","stargazers_url":"https://api.github.com/repos/mozilla/web-ext/stargazers","contributors_url":"https://api.github.com/repos/mozilla/web-ext/contributors","subscribers_url":"https://api.github.com/repos/mozilla/web-ext/subscribers","subscription_url":"https://api.github.com/repos/mozilla/web-ext/subscription","commits_url":"https://api.github.com/repos/mozilla/web-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/web-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/web-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/web-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/web-ext/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/web-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/web-ext/merges","archive_url":"https://api.github.com/repos/mozilla/web-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/web-ext/downloads","issues_url":"https://api.github.com/repos/mozilla/web-ext/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/web-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/web-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/web-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/web-ext/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/web-ext/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/web-ext/deployments","created_at":"2016-02-01T18:08:32Z","updated_at":"2016-08-04T04:02:44Z","pushed_at":"2016-08-08T17:50:25Z","git_url":"git://github.com/mozilla/web-ext.git","ssh_url":"git@github.com:mozilla/web-ext.git","clone_url":"https://github.com/mozilla/web-ext.git","svn_url":"https://github.com/mozilla/web-ext","homepage":null,"size":455,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":50,"forks":22,"open_issues":50,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/424"},"html":{"href":"https://github.com/mozilla/web-ext/pull/424"},"issue":{"href":"https://api.github.com/repos/mozilla/web-ext/issues/424"},"comments":{"href":"https://api.github.com/repos/mozilla/web-ext/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/web-ext/statuses/38ff882817ad89996a8e72e134a48fe32bf2beab"}}}}
{"actor":{"display_login":"kumar303"}}