{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/prism/pulls/comments/83441001","pull_request_review_id":4286384,"id":83441001,"diff_hunk":"@@ -53,8 +53,8 @@ type Distributor struct {\n type ReadRing interface {\n \tprometheus.Collector\n \n-\tGet(key uint32) (ring.IngesterDesc, error)\n-\tGetAll() []ring.IngesterDesc\n+\tGet(key uint32, n int, heartbeatTimeout time.Duration) ([]ring.IngesterDesc, error)\n+\tGetAll(heartbeatTimeout time.Duration) []ring.IngesterDesc","path":"distributor.go","position":40,"original_position":29,"commit_id":"d96c4a55e1d36e5f5fa6b2ae1acc19aa5237eb54","original_commit_id":"2d3501220b3f661631fbcd744fa84ebd475180c7","user":{"login":"juliusv","id":538008,"avatar_url":"https://avatars.githubusercontent.com/u/538008?v=3","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"From discussion: consider making the heartbeat timeout a property of the ring instead of passing it in on each call. Then the ring could also report in its metrics `Collect()` method how many total vs. timed out ingesters there are.","created_at":"2016-10-14T15:07:13Z","updated_at":"2016-10-14T15:07:13Z","html_url":"https://github.com/weaveworks/prism/pull/49#discussion_r83441001","pull_request_url":"https://api.github.com/repos/weaveworks/prism/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/comments/83441001"},"html":{"href":"https://github.com/weaveworks/prism/pull/49#discussion_r83441001"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/prism/pulls/49","id":89223543,"html_url":"https://github.com/weaveworks/prism/pull/49","diff_url":"https://github.com/weaveworks/prism/pull/49.diff","patch_url":"https://github.com/weaveworks/prism/pull/49.patch","issue_url":"https://api.github.com/repos/weaveworks/prism/issues/49","number":49,"state":"open","locked":false,"title":"[WIP] Read and write from/to multiple ingesters","user":{"login":"juliusv","id":538008,"avatar_url":"https://avatars.githubusercontent.com/u/538008?v=3","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"@jml FYI\r\n\r\nNot sure what to do about `LabelValuesForLabelName()`. It is only used for the UI to retrieve all metric names for autocompletion. Currently I just try to read from *all* ingesters in there, and it's not clear whether it makes sense to introduce any failure thresholds in there (since we're not querying N ingesters for a hash, but all, independent of any hash).","created_at":"2016-10-13T15:17:34Z","updated_at":"2016-10-14T15:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d7a254adcf385c1664bfae3b26ae5fb07714e72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/prism/pulls/49/commits","review_comments_url":"https://api.github.com/repos/weaveworks/prism/pulls/49/comments","review_comment_url":"https://api.github.com/repos/weaveworks/prism/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/prism/issues/49/comments","statuses_url":"https://api.github.com/repos/weaveworks/prism/statuses/d96c4a55e1d36e5f5fa6b2ae1acc19aa5237eb54","head":{"label":"weaveworks:replication","ref":"replication","sha":"d96c4a55e1d36e5f5fa6b2ae1acc19aa5237eb54","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":67793333,"name":"prism","full_name":"weaveworks/prism","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/prism","description":"A multitenant, horizontally scalable Prometheus as a Service","fork":false,"url":"https://api.github.com/repos/weaveworks/prism","forks_url":"https://api.github.com/repos/weaveworks/prism/forks","keys_url":"https://api.github.com/repos/weaveworks/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/prism/teams","hooks_url":"https://api.github.com/repos/weaveworks/prism/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/prism/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/prism/events","assignees_url":"https://api.github.com/repos/weaveworks/prism/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/prism/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/prism/tags","blobs_url":"https://api.github.com/repos/weaveworks/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/prism/languages","stargazers_url":"https://api.github.com/repos/weaveworks/prism/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/prism/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/prism/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/prism/subscription","commits_url":"https://api.github.com/repos/weaveworks/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/prism/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/prism/merges","archive_url":"https://api.github.com/repos/weaveworks/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/prism/downloads","issues_url":"https://api.github.com/repos/weaveworks/prism/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/prism/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/prism/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/prism/deployments","created_at":"2016-09-09T11:23:12Z","updated_at":"2016-10-11T20:22:36Z","pushed_at":"2016-10-14T15:05:01Z","git_url":"git://github.com/weaveworks/prism.git","ssh_url":"git@github.com:weaveworks/prism.git","clone_url":"https://github.com/weaveworks/prism.git","svn_url":"https://github.com/weaveworks/prism","homepage":null,"size":5383,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":21,"forks":1,"open_issues":21,"watchers":13,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"094681ca19f43b7be9d3f4a60faefaf1cb7bcaab","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":67793333,"name":"prism","full_name":"weaveworks/prism","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/prism","description":"A multitenant, horizontally scalable Prometheus as a Service","fork":false,"url":"https://api.github.com/repos/weaveworks/prism","forks_url":"https://api.github.com/repos/weaveworks/prism/forks","keys_url":"https://api.github.com/repos/weaveworks/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/prism/teams","hooks_url":"https://api.github.com/repos/weaveworks/prism/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/prism/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/prism/events","assignees_url":"https://api.github.com/repos/weaveworks/prism/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/prism/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/prism/tags","blobs_url":"https://api.github.com/repos/weaveworks/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/prism/languages","stargazers_url":"https://api.github.com/repos/weaveworks/prism/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/prism/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/prism/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/prism/subscription","commits_url":"https://api.github.com/repos/weaveworks/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/prism/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/prism/merges","archive_url":"https://api.github.com/repos/weaveworks/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/prism/downloads","issues_url":"https://api.github.com/repos/weaveworks/prism/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/prism/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/prism/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/prism/deployments","created_at":"2016-09-09T11:23:12Z","updated_at":"2016-10-11T20:22:36Z","pushed_at":"2016-10-14T15:05:01Z","git_url":"git://github.com/weaveworks/prism.git","ssh_url":"git@github.com:weaveworks/prism.git","clone_url":"https://github.com/weaveworks/prism.git","svn_url":"https://github.com/weaveworks/prism","homepage":null,"size":5383,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":21,"forks":1,"open_issues":21,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/49"},"html":{"href":"https://github.com/weaveworks/prism/pull/49"},"issue":{"href":"https://api.github.com/repos/weaveworks/prism/issues/49"},"comments":{"href":"https://api.github.com/repos/weaveworks/prism/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/prism/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/prism/statuses/d96c4a55e1d36e5f5fa6b2ae1acc19aa5237eb54"}}}}
{"actor":{"display_login":"juliusv"}}