{"action":"created","issue":{"url":"https://api.github.com/repos/torch/nn/issues/563","labels_url":"https://api.github.com/repos/torch/nn/issues/563/labels{/name}","comments_url":"https://api.github.com/repos/torch/nn/issues/563/comments","events_url":"https://api.github.com/repos/torch/nn/issues/563/events","html_url":"https://github.com/torch/nn/pull/563","id":126059034,"number":563,"title":"Don't re-flatten parameters if they are already flattened","user":{"login":"colesbury","id":655866,"avatar_url":"https://avatars.githubusercontent.com/u/655866?v=3","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2016-01-11T23:06:22Z","updated_at":"2016-01-20T04:05:47Z","closed_at":"2016-01-12T00:21:46Z","pull_request":{"url":"https://api.github.com/repos/torch/nn/pulls/563","html_url":"https://github.com/torch/nn/pull/563","diff_url":"https://github.com/torch/nn/pull/563.diff","patch_url":"https://github.com/torch/nn/pull/563.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/torch/nn/issues/comments/173079320","html_url":"https://github.com/torch/nn/pull/563#issuecomment-173079320","issue_url":"https://api.github.com/repos/torch/nn/issues/563","id":173079320,"user":{"login":"soumith","id":1310570,"avatar_url":"https://avatars.githubusercontent.com/u/1310570?v=3","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T04:05:47Z","updated_at":"2016-01-20T04:05:47Z","body":"Okay fine, let's do this:\r\n- create a function called flattenParameters() that does what @colesbury proposes.\r\n- add a big WARNING to getParamters stating the depreceation. We can publish a depreceation date of July 2016.\r\n- In August 2016, we move getParameters to silently call flattenParameters.\r\n\r\nInternally, immediately move all getParameters to flattenParameters."}}