{"action":"created","issue":{"url":"https://api.github.com/repos/rear/rear/issues/801","repository_url":"https://api.github.com/repos/rear/rear","labels_url":"https://api.github.com/repos/rear/rear/issues/801/labels{/name}","comments_url":"https://api.github.com/repos/rear/rear/issues/801/comments","events_url":"https://api.github.com/repos/rear/rear/issues/801/events","html_url":"https://github.com/rear/rear/issues/801","id":142952130,"number":801,"title":"ebiso (wrongly) called even if BIOS is used","user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars.githubusercontent.com/u/1788608?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rear/rear/labels/bug","name":"bug","color":"d7e102"},{"url":"https://api.github.com/repos/rear/rear/labels/cleanup","name":"cleanup","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars.githubusercontent.com/u/1788608?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rear/rear/milestones/7","html_url":"https://github.com/rear/rear/milestones/Rear%20v1.19","labels_url":"https://api.github.com/repos/rear/rear/milestones/7/labels","id":893185,"number":7,"title":"Rear v1.19","description":"","creator":{"login":"gdha","id":888633,"avatar_url":"https://avatars.githubusercontent.com/u/888633?v=3","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":3,"state":"open","created_at":"2014-12-05T17:07:39Z","updated_at":"2016-03-23T12:55:16Z","due_on":"2016-06-29T22:00:00Z","closed_at":null},"comments":9,"created_at":"2016-03-23T12:55:16Z","updated_at":"2016-03-24T14:35:17Z","closed_at":null,"body":"I am using rear 1.18\r\non a QEMU/KVM virtual machine\r\nwith BIOS.\r\n\r\nNevertheless I have in /etc/rear/local.conf\r\n<pre>\r\nISO_MKISOFS_BIN=/usr/bin/ebiso\r\n</pre>\r\n\r\nThat leads to the following:\r\n<pre>\r\n# rear -d -D mkbackup\r\nRelax-and-Recover 1.18 / Git\r\nUsing log file: /var/log/rear/rear-g34.log\r\nmkdir: created directory '/var/lib/rear/output'\r\nCreating disk layout\r\nCreating root filesystem layout\r\nCopying files and directories\r\nCopying binaries and libraries\r\nCopying kernel modules\r\nCreating initramfs\r\nMaking ISO image\r\nWrote ISO image: /var/lib/rear/output/rear-g34.iso ()\r\nCopying resulting files to nfs location\r\nERROR: Could not copy files to nfs location\r\nAborting due to an error, check /var/log/rear/rear-g34.log for details\r\nYou should also rm -Rf /tmp/rear.tZn8Fadjbn7L2EI\r\nTerminated\r\n</pre>\r\n\r\nIn /var/log/rear/rear-g34.log there is\r\n<pre>\r\n+ source /usr/share/rear/prep/ISO/GNU/Linux/32_verify_mkisofs.sh\r\n++ '[' -x /usr/bin/ebiso ']'\r\n++ StopIfError 'Could not find '\\''mkisofs'\\'' compatible program. Please install '\\''mkisofs'\\'', '\\''genisoimage'\\'' or '\\''ebiso'\\'' into your path or manually set ISO_MKISOFS_BIN [/usr/bin/ebiso]'\r\n++ ((  0 != 0  ))\r\n++ Log 'Using '\\''/usr/bin/ebiso'\\'' to create ISO images'\r\n...\r\n+ source /usr/share/rear/output/ISO/Linux-i386/80_create_isofs.sh\r\n++ '[' -x /usr/bin/ebiso ']'\r\n++ StopIfError 'ISO_MKISOFS_BIN [/usr/bin/ebiso] not an executable !'\r\n++ ((  0 != 0  ))\r\n+++ basename /usr/bin/ebiso\r\n++ [[ ebiso = \\e\\b\\i\\s\\o ]]\r\n+++ basename\r\nbasename: missing operand\r\nTry 'basename --help' for more information.\r\n...\r\n+ source /usr/share/rear/output/ISO/Linux-i386/82_create_iso_image.sh\r\n++ Log 'Starting '\\''/usr/bin/ebiso'\\'''\r\n...\r\n++ echo -e 'Making ISO image'\r\n++ ((  USING_UEFI_BOOTLOADER  ))\r\n++ EFIBOOT=\r\n++ pushd /tmp/rear.tZn8Fadjbn7L2EI/tmp/isofs\r\n+++ basename /usr/bin/ebiso\r\n++ [[ ebiso = \\e\\b\\i\\s\\o ]]\r\n++ [[ '' == 1 ]]\r\n++ /usr/bin/ebiso -v -o /var/lib/rear/output/rear-g34.iso -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -R -J -volid RELAXRECOVER -v -iso-level 3 .\r\n++ StopIfError 'Could not create ISO image (with /usr/bin/ebiso)'\r\n++ ((  0 != 0  ))\r\n++ popd\r\n</pre>\r\n\r\nWhat that wrong ebiso call results on command line:\r\n<pre>\r\n# pushd /tmp/rear.tZn8Fadjbn7L2EI/tmp/isofs\r\n/tmp/rear.tZn8Fadjbn7L2EI/tmp/isofs ~\r\n\r\n# /usr/bin/ebiso -v -o /var/lib/rear/output/rear-g34.iso -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -R -J -volid RELAXRECOVER -v -iso-level 3 .\r\n\r\n0.2.1\r\n\r\n# echo $?\r\n0\r\n</pre>\r\nThe wrong ebiso call results actually only a \"ebiso -v\" which runs successfully so that no error is detected here.\r\n\r\nIn particular the following if else clause in\r\nusr/share/rear/output/ISO/Linux-i386/82_create_iso_image.sh\r\ndoes not work in practice:\r\n<pre>\r\npushd $TMP_DIR/isofs >&8\r\n# ebiso currenlty works only with UEFI\r\nif [[ $(basename $ISO_MKISOFS_BIN) = \"ebiso\" && $USING_UEFI_BOOTLOADER == 1 ]]; then\r\n   $ISO_MKISOFS_BIN -R -o $ISO_DIR/$ISO_PREFIX.iso -e boot/efiboot.img .\r\nelse\r\n   $ISO_MKISOFS_BIN $v -o \"$ISO_DIR/$ISO_PREFIX.iso\" -b isolinux/isolinux.bin -c isolinux/boot.cat \\\r\n       -no-emul-boot -boot-load-size 4 -boot-info-table \\\r\n       -R -J -volid \"$ISO_VOLID\" $EFIBOOT -v -iso-level 3 .  >&8\r\n       ##-R -J -volid \"$ISO_VOLID\" $EFIBOOT  \"${ISO_FILES[@]}\"  >&8\r\nfi\r\nStopIfError \"Could not create ISO image (with $ISO_MKISOFS_BIN)\"\r\npopd >&8\r\n</pre>\r\n\r\n@gozora \r\nI will try to fix it...\r\n"},"comment":{"url":"https://api.github.com/repos/rear/rear/issues/comments/200864789","html_url":"https://github.com/rear/rear/issues/801#issuecomment-200864789","issue_url":"https://api.github.com/repos/rear/rear/issues/801","id":200864789,"user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars.githubusercontent.com/u/1788608?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T14:35:17Z","updated_at":"2016-03-24T14:35:17Z","body":"The second pull request https://github.com/rear/rear/pull/807 allows generic yes/no values for USING_UEFI_BOOTLOADER\r\n\r\nAs a consequence it use everywhere generic tests via\r\n`is_true $USING_UEFI_BOOTLOADER` and\r\n`is_false $USING_UEFI_BOOTLOADER`\r\n\r\nThe latter requires the new counterpart function\r\nis_false to test for an explicit 'no' value.\r\n"}}