{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12317","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12317/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12317/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12317/events","html_url":"https://github.com/apache/spark/pull/12317","id":147608271,"number":12317,"title":"[SPARK-14549][ML] Copy the Vector and Matrix classes from mllib to ml in mllib-local","user":{"login":"dbtsai","id":1134574,"avatar_url":"https://avatars.githubusercontent.com/u/1134574?v=3","gravatar_id":"","url":"https://api.github.com/users/dbtsai","html_url":"https://github.com/dbtsai","followers_url":"https://api.github.com/users/dbtsai/followers","following_url":"https://api.github.com/users/dbtsai/following{/other_user}","gists_url":"https://api.github.com/users/dbtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbtsai/subscriptions","organizations_url":"https://api.github.com/users/dbtsai/orgs","repos_url":"https://api.github.com/users/dbtsai/repos","events_url":"https://api.github.com/users/dbtsai/events{/privacy}","received_events_url":"https://api.github.com/users/dbtsai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-04-12T01:56:30Z","updated_at":"2016-04-15T08:17:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12317","html_url":"https://github.com/apache/spark/pull/12317","diff_url":"https://github.com/apache/spark/pull/12317.diff","patch_url":"https://github.com/apache/spark/pull/12317.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis task will copy the Vector and Matrix classes from mllib to ml package in mllib-local jar. The UDTs and `since` annotation in ml vector and matrix will be removed from now. UDTs will be achieved by #SPARK-14487, and `since` will be replaced by /* @ since 1.2.0 */\r\n\r\nThe BLAS implementation will be copied, and some of the test utilities will be copies as well. \r\n\r\nSummary of changes:\r\n\r\n1. In mllib-local/src/main/scala/org/apache/spark/**ml**/linalg/BLAS.scala\r\n  - Copied from mllib/src/main/scala/org/apache/spark/**mllib**/linalg/BLAS.scala\r\n  - logDebug(\"gemm: alpha is equal to 0 and beta is equal to 1. Returning C.\") is removed in ml version.\r\n2. In  mllib-local/src/main/scala/org/apache/spark/**ml**/linalg/Matrices.scala\r\n  - Copied from mllib/src/main/scala/org/apache/spark/**mllib**/linalg/Matrices.scala\r\n  - `@Since` was removed, and we'll use standard `/* @Since /*` Java doc. Will be in another PR.\r\n  - `UDT` related code was removed, and will use `SPARK-13944` https://github.com/apache/spark/pull/12259  to replace the annotation. \r\n3. In mllib-local/src/main/scala/org/apache/spark/**ml**/linalg/Vectors.scala\r\n  - Copied from mllib/src/main/scala/org/apache/spark/**mllib**/linalg/Vectors.scala\r\n  - `@Since` was removed.\r\n  - `UDT` related code was removed.\r\n  - In `def parseNumeric`, it was throwing `throw new SparkException(s\"Cannot parse $other.\")`, and now it's throwing `throw new IllegalArgumentException(s\"Cannot parse $other.\")`\r\n4. In mllib/src/main/scala/org/apache/spark/**mllib**/linalg/Vectors.scala\r\n  - For consistency with ML version of vector, `def parseNumeric` is now throwing `throw new IllegalArgumentException(s\"Cannot parse $other.\")`\r\n5. mllib/src/main/scala/org/apache/spark/**mllib**/util/NumericParser.scala is moved to mllib-local/src/main/scala/org/apache/spark/**ml**/util/NumericParser.scala\r\n  - All the `throw new SparkException` were replaced by `throw new IllegalArgumentException`\r\n\r\n## How was this patch tested?\r\n\r\nunit tests"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/210353251","html_url":"https://github.com/apache/spark/pull/12317#issuecomment-210353251","issue_url":"https://api.github.com/repos/apache/spark/issues/12317","id":210353251,"user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T08:17:16Z","updated_at":"2016-04-15T08:17:16Z","body":"LGTM. Merged into master. Thanks!"}}