{"push_id":1392829994,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"c499f82f2aa6ee4281556f5bcba6f27df34a9bd7","before":"328c26e11158407ed53b5f8269fd6b109930e7c6","commits":[{"sha":"afd7df2507c21f3927a0e2ccd8809cf86cb5d67c","author":{"name":"Mark Asselstine","email":"5e77d3480dcee62f8916bb903c6c79f584f0a89e@windriver.com"},"message":"consul: drop QA warning about ldflags/GNU HASH\n\nFixes #50\n\nPreviously we made this QA error a QA warning such that we would be\nreminded to look more closely at this one day. Having had some time\nthis has now been looked into and the following summarizes the\ninvestigation.\n\nUnlike packages like 'bolt' and other GO applicaitons consul is not\nlinked statically. Like these other GO applications it is being linked\nwith GO's internal linker which, unlike the external/'system' linker, does not\nhave support for GNU HASH. The combination of these two things result\nin it failing the --hash-style check and producing the QA Warning:\n\nWARNING: consul-git-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary:\n  '.../tmp/work/core2-64-overc-linux/consul/git-r0/packages-split/consul/usr/bin/consul' [ldflags]\n\nWe could work around this by using the external linker but this has\nseveral downsides such as portability and thread handling ... as\ndiscussed here: https://github.com/golang/go/issues/5238\n\nModifying the golang.bbclass I am able to demonstrate that using:\n\ngo install -ldflags '-linkmode external' ${PKG_NAME}\n\ndoes satisfy the QA check but when weighing the benefits of using the\nGNU HASH vs the known and unknown downsides of not using the GO\ninternal linker I believe we are better off using the GO internal\nlinker.\n\nAn alternative might be to link consul statically, but my reading\nseems to indicate that this could also come with its own\nchallenges. So the best solution at this time is to simply ignore the\nfact that we are not using GNU HASH, giving up a few known benefits\nbut avoiding introducing unknown complications.\n\nSigned-off-by: Mark Asselstine <mark.asselstine@windriver.com>","distinct":true,"url":"https://api.github.com/repos/OverC/meta-overc/commits/afd7df2507c21f3927a0e2ccd8809cf86cb5d67c"},{"sha":"c499f82f2aa6ee4281556f5bcba6f27df34a9bd7","author":{"name":"Bruce Ashfield","email":"4366d30734bc0d1f2e1a4507ae460627587dc573@gmail.com"},"message":"Merge pull request #51 from masselstine/master\n\nconsul: drop QA warning about ldflags/GNU HASH","distinct":true,"url":"https://api.github.com/repos/OverC/meta-overc/commits/c499f82f2aa6ee4281556f5bcba6f27df34a9bd7"}]}
{"actor":{"display_login":"zeddii"}}