{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/4313","repository_url":"https://api.github.com/repos/emberjs/data","labels_url":"https://api.github.com/repos/emberjs/data/issues/4313/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4313/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/4313/events","html_url":"https://github.com/emberjs/data/pull/4313","id":146856707,"number":4313,"title":"During normalization, use property lookup instead of hasOwnProp checks","user":{"login":"sly7-7","id":1826661,"avatar_url":"https://avatars.githubusercontent.com/u/1826661?v=3","gravatar_id":"","url":"https://api.github.com/users/sly7-7","html_url":"https://github.com/sly7-7","followers_url":"https://api.github.com/users/sly7-7/followers","following_url":"https://api.github.com/users/sly7-7/following{/other_user}","gists_url":"https://api.github.com/users/sly7-7/gists{/gist_id}","starred_url":"https://api.github.com/users/sly7-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sly7-7/subscriptions","organizations_url":"https://api.github.com/users/sly7-7/orgs","repos_url":"https://api.github.com/users/sly7-7/repos","events_url":"https://api.github.com/users/sly7-7/events{/privacy}","received_events_url":"https://api.github.com/users/sly7-7/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/emberjs/data/labels/Needs%20Team%20Discussion","name":"Needs Team Discussion","color":"5319e7"},{"url":"https://api.github.com/repos/emberjs/data/labels/perf","name":"perf","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-08T08:27:14Z","updated_at":"2016-04-08T22:51:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4313","html_url":"https://github.com/emberjs/data/pull/4313","diff_url":"https://github.com/emberjs/data/pull/4313.diff","patch_url":"https://github.com/emberjs/data/pull/4313.patch"},"body":"To follow #4311 and according to https://github.com/emberjs/data/issues/2289#issuecomment-206990820, the server returning an undefined value is just invalid, I think we can now replace all those slowly hasOwnProp checks during the normalization process.\r\nSeems like this would improve perfs :)\r\n\r\nThis will need #2289 to be merged before (the same tests where failing).\r\nI will rebase after that\r\n\r\nkindly ping to @stefanpenner @igorT @wecc @bmac \r\n"},"comment":{"url":"https://api.github.com/repos/emberjs/data/issues/comments/207639336","html_url":"https://github.com/emberjs/data/pull/4313#issuecomment-207639336","issue_url":"https://api.github.com/repos/emberjs/data/issues/4313","id":207639336,"user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T22:51:00Z","updated_at":"2016-04-08T22:51:00Z","body":"This most likely will, at the time I made the recommendation I had an active benchmark (in ember-data not just a micro one) but I have since mis-placed it.\r\n\r\nI can try finding it, or hopefully i'll have some time soon to revisit it, so we can double check this improvement."}}