{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/478","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/478/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/478/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/478/events","html_url":"https://github.com/eclipse/jetty.project/pull/478","id":145304152,"number":478,"title":"Improve Proxy protocol to support fallback to non-Proxy connections transparently","user":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-01T22:54:47Z","updated_at":"2016-05-04T00:46:36Z","closed_at":"2016-05-04T00:46:36Z","pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/478","html_url":"https://github.com/eclipse/jetty.project/pull/478","diff_url":"https://github.com/eclipse/jetty.project/pull/478.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/478.patch"},"body":"* Rework ProxyV?Connection to handoff buffers via `UpgradeFrom`/`UpgradeTo` rather than a bespoke constructor\r\n* Add HttpConnection `UpgradeTo` support\r\n* ProxyConnectionFactory now allows a fallback for non-Proxy protocol connections\r\n\r\nTODO:\r\n* SslConnection needs `UpgradeTo` support, but how do I test it?  It seems that `SslSocket` doesn't allow you to send unencrypted data, which makes it difficult to create the necessary mixed unencrypted / encrypted data stream\r\n\r\nThis is a work in progress asking for feedback, please do not merge just yet!"},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/216711337","html_url":"https://github.com/eclipse/jetty.project/pull/478#issuecomment-216711337","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/478","id":216711337,"user":{"login":"gregw","id":70829,"avatar_url":"https://avatars.githubusercontent.com/u/70829?v=3","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T00:46:36Z","updated_at":"2016-05-04T00:46:36Z","body":"OK I'm closing this again as we didn't provoke any more discussion.   It is a good patch looking for a better use-case to justify it (or something similar).  Thanks."}}