{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/49856742","id":49856742,"diff_hunk":"@@ -1,119 +1,236 @@\n <div class=\"content\">\n   <project-page>\n-    <div>\n-      <div class=\"page-header page-header-bleed-right\">\n-        <delete-link\n-          class=\"pull-right fa-lg\"\n-          resource-type=\"project\"\n-          resource-name=\"{{project.metadata.name}}\"\n-          project-name=\"{{project.metadata.name}}\"\n-          display-name=\"{{(project | displayName)}}\"\n-          alerts=\"alerts\"\n-          button-only>\n-        </delete-link>\n-        <h1>Project Settings</h1>\n-      </div>\n+    <div class=\"breadcrumb\"></div>\n+    <alerts alerts=\"alerts\"></alerts>\n+    <div class=\"tile__\">\n+      <h1>\n+        Project Settings\n+        <div class=\"pull-right dropdown\">\n+          <a href=\"\"\n+            class=\"dropdown-toggle resource-actions-dropdown\"\n+            data-toggle=\"dropdown\">\n+            <i class=\"fa fa-ellipsis-v\"></i>\n+            <span class=\"sr-only\">Actions</span>\n+          </a>\n+          <ul class=\"dropdown-menu actions action-button\">\n+            <li>\n+              <a href=\"\"\n+                role=\"button\"\n+                ng-click=\"toggle()\"\n+                ><i class=\"fa fa-pencil fa-fw\" aria-hidden=\"true\"></i>Edit</a>\n+            </li>\n+            <li>\n+              <delete-link\n+                resource-type=\"project\"\n+                resource-name=\"{{project.metadata.name}}\"\n+                project-name=\"{{project.metadata.name}}\"\n+                display-name=\"{{(project | displayName)}}\"\n+                alerts=\"alerts\">\n+              </delete-link>\n+            </li>\n+          </ul>\n+        </div>\n+      </h1>\n+      <div class=\"resource-details\">\n+        <div class=\"row\">\n+          <div class=\"col-lg-6\">\n+            <h3>General information</h3>\n+\n+\n+            <div column ng-if=\"show.display\">\n+              <div row>\n+                <div flex><strong>Name:</strong></div>\n+                <div flex grow=\"4\">{{projectName}}</div>\n+              </div>\n+              <div row>\n+                <div flex><strong>Display name:</strong></div>\n+                <div row flex grow=\"4\">\n+                  <div\n+                    ng-if=\"project | displayName: true\">\n+                    {{project | displayName: true}}\n+                  </div>\n+                  <div\n+                    ng-if=\"!(project | displayName: true)\">\n+                    <em>No display name</em>\n+                  </div>\n+                  <!--\n+                  <div flex>\n+                    &nbsp;\n+                    <a\n+                      ng-if=\"show.actions\"\n+                      ng-click=\"toggle()\"\n+                      class=\"btn btn-default btn-xs\"\n+                      title=\"Edit\">\n+                      <i class=\"icon icon-pencil\"></i>\n+                    </a>\n+                  </div>\n+                  -->\n+                </div>\n+              </div>\n+              <div row>\n+                <div flex><strong>Description:</strong></div>\n+                <div row flex grow=\"4\">\n+                  <div\n+                    ng-if=\"project | description\">\n+                    <truncate-long-text\n+                      content=\"project | description\"\n+                      limit=\"1024\"\n+                      use-word-boundary=\"true\"></truncate-long-text>\n+                  </div>\n+                  <div\n+                    ng-if=\"!(project | description)\">\n+                    <em>No description</em>\n+                  </div>\n+                  <!--\n+                  <div flex>\n+                    &nbsp;\n+                    <a\n+                      ng-if=\"show.actions\"\n+                      ng-click=\"toggle()\"\n+                      class=\"btn btn-default btn-xs\"\n+                      title=\"Edit\">\n+                      <i class=\"icon icon-pencil\"></i>\n+                    </a>\n+                  </div>\n+                  -->\n+                </div>\n+              </div>\n+            </div>\n+\n+\n+            <form novalidate ng-if=\"show.form\">\n+              <div row>\n+                <div flex><strong>Name:</strong></div>\n+                <div flex grow=\"4\">{{projectName}}</div>\n+              </div>\n+              <div\n+                row\n+                class='form-group'\n+                ng-class=\"{'has-error': form.project_display_name.$error.oscKeyValid}\">\n+                <div flex><strong>Display name: </strong></div>\n+                <div flex grow=\"2\">\n+                  <input class=\"form-control\"\n+                         type=\"text\"\n+                         name=\"project_display_name\"\n+                         placeholder=\"project display name\"\n+                         ng-model=\"project.metadata.annotations['openshift.io/display-name']\">\n+                </div>\n+                <div flex grow=\"2\"></div>\n+              </div>\n+              <div\n+                row\n+                class='form-group'\n+                ng-class=\"{'has-error': form.project_description.$error.oscKeyValid}\">\n+                <div flex><strong>Description: </strong></div>\n+                <div flex grow=\"2\">\n+                  <input class=\"form-control\"\n+                         type=\"text\"\n+                         name=\"project_description\"\n+                         placeholder=\"project description\"\n+                         ng-model=\"project.metadata.annotations['openshift.io/description']\">","path":"assets/app/views/settings.html","position":143,"original_position":143,"commit_id":"d6f6a0945f45ccb34cd2e4afa25281131abf71b2","original_commit_id":"d6f6a0945f45ccb34cd2e4afa25281131abf71b2","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Same comment here: we should remove the annotation if no value.","created_at":"2016-01-15T14:14:51Z","updated_at":"2016-01-15T14:14:51Z","html_url":"https://github.com/openshift/origin/pull/6667#discussion_r49856742","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6667","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/49856742"},"html":{"href":"https://github.com/openshift/origin/pull/6667#discussion_r49856742"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6667"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6667","id":56099609,"html_url":"https://github.com/openshift/origin/pull/6667","diff_url":"https://github.com/openshift/origin/pull/6667.diff","patch_url":"https://github.com/openshift/origin/pull/6667.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6667","number":6667,"state":"open","locked":false,"title":"Edit project display name & description via settings page","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"Adds a drop down menu to top left of settings page (similar to what we have elsewhere) with edit & delete options.  Edit will display an inline form allowing user to update the project's `displayName` and `description`.\r\n\r\n![screen shot 2016-01-14 at 4 42 52 pm](https://cloud.githubusercontent.com/assets/280512/12338777/5c39ff2a-badf-11e5-9c28-38c6b200e500.png)\r\n![screen shot 2016-01-14 at 4 42 58 pm](https://cloud.githubusercontent.com/assets/280512/12338778/5ee25164-badf-11e5-8390-55b62364c34e.png)\r\n\r\n@jwforres @spadgett @sg00dwin for review!\r\n","created_at":"2016-01-14T21:55:23Z","updated_at":"2016-01-15T14:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beb611e751436658723ee97a508d1f814fd53f60","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6667/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6667/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6667/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/d6f6a0945f45ccb34cd2e4afa25281131abf71b2","head":{"label":"benjaminapetersen:bpeterse/edit-project","ref":"bpeterse/edit-project","sha":"d6f6a0945f45ccb34cd2e4afa25281131abf71b2","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":37674696,"name":"origin","full_name":"benjaminapetersen/origin","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin","forks_url":"https://api.github.com/repos/benjaminapetersen/origin/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin/releases{/id}","created_at":"2015-06-18T17:38:49Z","updated_at":"2015-06-18T17:38:52Z","pushed_at":"2016-01-14T21:53:03Z","git_url":"git://github.com/benjaminapetersen/origin.git","ssh_url":"git@github.com:benjaminapetersen/origin.git","clone_url":"https://github.com/benjaminapetersen/origin.git","svn_url":"https://github.com/benjaminapetersen/origin","homepage":"http://www.openshift.org","size":193436,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bpeterse/bug/3436-osc-key-value"}},"base":{"label":"openshift:master","ref":"master","sha":"cda63dcc6b3a98389d824bfd28864b4a1257a446","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-01-15T12:40:12Z","pushed_at":"2016-01-15T14:01:25Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":247861,"stargazers_count":912,"watchers_count":912,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":771,"forks":580,"open_issues":771,"watchers":912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6667"},"html":{"href":"https://github.com/openshift/origin/pull/6667"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6667"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6667/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6667/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6667/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/d6f6a0945f45ccb34cd2e4afa25281131abf71b2"}}}}