{"action":"created","issue":{"url":"https://api.github.com/repos/CCI-MOC/haas/issues/474","repository_url":"https://api.github.com/repos/CCI-MOC/haas","labels_url":"https://api.github.com/repos/CCI-MOC/haas/issues/474/labels{/name}","comments_url":"https://api.github.com/repos/CCI-MOC/haas/issues/474/comments","events_url":"https://api.github.com/repos/CCI-MOC/haas/issues/474/events","html_url":"https://github.com/CCI-MOC/haas/issues/474","id":99401131,"number":474,"title":"Check for port in node_connect_network()","user":{"login":"henn","id":1813729,"avatar_url":"https://avatars.githubusercontent.com/u/1813729?v=3","gravatar_id":"","url":"https://api.github.com/users/henn","html_url":"https://github.com/henn","followers_url":"https://api.github.com/users/henn/followers","following_url":"https://api.github.com/users/henn/following{/other_user}","gists_url":"https://api.github.com/users/henn/gists{/gist_id}","starred_url":"https://api.github.com/users/henn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henn/subscriptions","organizations_url":"https://api.github.com/users/henn/orgs","repos_url":"https://api.github.com/users/henn/repos","events_url":"https://api.github.com/users/henn/events{/privacy}","received_events_url":"https://api.github.com/users/henn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CCI-MOC/haas/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/CCI-MOC/haas/labels/easy","name":"easy","color":"bfe500"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/CCI-MOC/haas/milestones/5","html_url":"https://github.com/CCI-MOC/haas/milestones/v0.2","labels_url":"https://api.github.com/repos/CCI-MOC/haas/milestones/5/labels","id":855160,"number":5,"title":"v0.2","description":"next release. We may rename this one down the line if we choose another name, but right now I want a place to put bugs that I'm promising to fix in the docs.","creator":{"login":"zenhack","id":883774,"avatar_url":"https://avatars.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2014-11-05T20:45:28Z","updated_at":"2016-05-17T02:15:00Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2015-08-06T10:00:44Z","updated_at":"2016-06-02T19:58:33Z","closed_at":null,"body":"In node_connect_network(), we currently do not verify that a NIC is connected to a port before adding the connection request to the Network Action Service queue.\r\n\r\nAccording to Ian in #455:\r\n> Started working on this, and found there was actually a test that checks for the behavior you're pointing out. Talked to @gsilvis, I think the reasoning at the time was that you should never actually have nics in the DB that aren't connected to the switch, and that this was an administrator error. The driver writes a warning to the log and just noops. I'm not sure I still think this is the right behaviour, but let's not add unrelated api changes to this patch.\r\n\r\nI think this is pretty straightforward (even if it breaks compatibility). Anyone disagree? @gsilvis @zenhack "},"comment":{"url":"https://api.github.com/repos/CCI-MOC/haas/issues/comments/223404203","html_url":"https://github.com/CCI-MOC/haas/issues/474#issuecomment-223404203","issue_url":"https://api.github.com/repos/CCI-MOC/haas/issues/474","id":223404203,"user":{"login":"gsilvis","id":597557,"avatar_url":"https://avatars.githubusercontent.com/u/597557?v=3","gravatar_id":"","url":"https://api.github.com/users/gsilvis","html_url":"https://github.com/gsilvis","followers_url":"https://api.github.com/users/gsilvis/followers","following_url":"https://api.github.com/users/gsilvis/following{/other_user}","gists_url":"https://api.github.com/users/gsilvis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsilvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsilvis/subscriptions","organizations_url":"https://api.github.com/users/gsilvis/orgs","repos_url":"https://api.github.com/users/gsilvis/repos","events_url":"https://api.github.com/users/gsilvis/events{/privacy}","received_events_url":"https://api.github.com/users/gsilvis/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T19:58:33Z","updated_at":"2016-06-02T19:58:33Z","body":"+1 for immediately checking that the NIC is attached, as a maybe only short-term solution.  But I'm going to keep bringing the other option up, whenever we talk about this :)"}}
{"actor":{"display_login":"gsilvis"}}