{"action":"closed","issue":{"url":"https://api.github.com/repos/theadam/react-flyd-class/issues/2","repository_url":"https://api.github.com/repos/theadam/react-flyd-class","labels_url":"https://api.github.com/repos/theadam/react-flyd-class/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/theadam/react-flyd-class/issues/2/comments","events_url":"https://api.github.com/repos/theadam/react-flyd-class/issues/2/events","html_url":"https://github.com/theadam/react-flyd-class/issues/2","id":165605880,"number":2,"title":"Bug when change not stream prop on a reactive class","user":{"login":"xialvjun","id":4413712,"avatar_url":"https://avatars.githubusercontent.com/u/4413712?v=3","gravatar_id":"","url":"https://api.github.com/users/xialvjun","html_url":"https://github.com/xialvjun","followers_url":"https://api.github.com/users/xialvjun/followers","following_url":"https://api.github.com/users/xialvjun/following{/other_user}","gists_url":"https://api.github.com/users/xialvjun/gists{/gist_id}","starred_url":"https://api.github.com/users/xialvjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xialvjun/subscriptions","organizations_url":"https://api.github.com/users/xialvjun/orgs","repos_url":"https://api.github.com/users/xialvjun/repos","events_url":"https://api.github.com/users/xialvjun/events{/privacy}","received_events_url":"https://api.github.com/users/xialvjun/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-14T16:39:55Z","updated_at":"2016-07-20T00:12:25Z","closed_at":"2016-07-20T00:12:25Z","body":"see [webpackbin](http://www.webpackbin.com/EkLI2jgDb)\r\n\r\nor\r\n\r\n```\r\nconst Span = reactive('span');\r\n\r\nconst plusClick$ = stream();\r\nconst minusClick$ = stream();\r\n\r\nconst action$ = merge(\r\n  plusClick$.map(() => 1),\r\n  minusClick$.map(() => -1)\r\n);\r\n\r\nconst count$ = scan((x, y) => x + y, 0, action$);\r\n\r\n\r\nclass Counter extends React.Component {\r\n  constructor(props){\r\n    super(props)\r\n    this.state = {normal_state: false}\r\n  }\r\n  \r\n  render() {\r\n    return (\r\n      <div>\r\n        <div>\r\n          <button id=\"plus\" onClick={ (e) => plusClick$(e) }>+</button>\r\n          <button id=\"minus\" onClick={ (e) => minusClick$(e) }>-</button>\r\n        </div>\r\n        <div>\r\n          Count: <Span style={{color: this.state.normal_state?'red':'blue'}}>{ count$ }</Span>\r\n          <button onClick={e=>this.setState({normal_state: !this.state.normal_state})}>toggle_normal_state</button>\r\n        </div>\r\n      </div>\r\n    )\r\n  }\r\n}\r\n```\r\n click the `toggle_normal_state` button won't change the reactive span's color. \r\nThe problem is normal state shouldn't be fixed in constructor...\r\n```\r\nconstructor(props) {\r\n      super(props);\r\n      this.displayName = `FlydReactiveElement-${tag}`;\r\n      this.state = pickProps(props, (key, value) => !isStream(value));\r\n      this.state.mount = true;\r\n    }\r\n```\r\n\r\nI'll make a PR tomorrow...or yourself fix it."}}
{"actor":{"display_login":"theadam"}}