{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/79651499","id":79651499,"diff_hunk":"@@ -3,27 +3,18 @@\n from urllib import urlencode\n \n from django.conf import settings\n-from django.core.urlresolvers import reverse\n from django.http import HttpResponseRedirect\n from django.utils.http import is_safe_url\n \n-import waffle\n-\n from olympia.amo.utils import urlparams\n \n \n def login_link(request):\n-    if waffle.switch_is_active('fxa-migrated'):\n-        return default_fxa_login_url(request)\n-    else:\n-        return link_with_final_destination(request, reverse('users.login'))\n+    return default_fxa_login_url(request)","path":"src/olympia/accounts/utils.py","position":18,"original_position":18,"commit_id":"868efa2f986f8866382341ef17239982ffc1673f","original_commit_id":"868efa2f986f8866382341ef17239982ffc1673f","user":{"login":"eviljeff","id":768592,"avatar_url":"https://avatars.githubusercontent.com/u/768592?v=3","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false},"body":"Is it feasible to strip out the redirection and either stick the code for `default_fxa_login_url` in here or change references to `login_link` to `default_fxa_login_url` where it's used?","created_at":"2016-09-20T16:19:06Z","updated_at":"2016-09-20T16:19:06Z","html_url":"https://github.com/mozilla/addons-server/pull/3563#discussion_r79651499","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3563","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/79651499"},"html":{"href":"https://github.com/mozilla/addons-server/pull/3563#discussion_r79651499"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3563"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/3563","id":86004978,"html_url":"https://github.com/mozilla/addons-server/pull/3563","diff_url":"https://github.com/mozilla/addons-server/pull/3563.diff","patch_url":"https://github.com/mozilla/addons-server/pull/3563.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/3563","number":3563,"state":"open","locked":false,"title":"Remove legacy login page","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"Trying to split this work into a bunch of smaller PRs. This removes the old login page and form. Hopefully the build is green but things are pretty tied together (the form tests hit the server).\r\n\r\nSupports #3049.","created_at":"2016-09-20T15:57:50Z","updated_at":"2016-09-20T16:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09048fc627ea8e822978e091a23546c2288a4584","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3563/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3563/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/3563/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/868efa2f986f8866382341ef17239982ffc1673f","head":{"label":"mstriemer:remove-legacy-login-form","ref":"remove-legacy-login-form","sha":"868efa2f986f8866382341ef17239982ffc1673f","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"repo":{"id":18221347,"name":"olympia","full_name":"mstriemer/olympia","owner":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstriemer/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/mstriemer/olympia","forks_url":"https://api.github.com/repos/mstriemer/olympia/forks","keys_url":"https://api.github.com/repos/mstriemer/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstriemer/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstriemer/olympia/teams","hooks_url":"https://api.github.com/repos/mstriemer/olympia/hooks","issue_events_url":"https://api.github.com/repos/mstriemer/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mstriemer/olympia/events","assignees_url":"https://api.github.com/repos/mstriemer/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mstriemer/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mstriemer/olympia/tags","blobs_url":"https://api.github.com/repos/mstriemer/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstriemer/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstriemer/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstriemer/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstriemer/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mstriemer/olympia/languages","stargazers_url":"https://api.github.com/repos/mstriemer/olympia/stargazers","contributors_url":"https://api.github.com/repos/mstriemer/olympia/contributors","subscribers_url":"https://api.github.com/repos/mstriemer/olympia/subscribers","subscription_url":"https://api.github.com/repos/mstriemer/olympia/subscription","commits_url":"https://api.github.com/repos/mstriemer/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstriemer/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstriemer/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstriemer/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstriemer/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mstriemer/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstriemer/olympia/merges","archive_url":"https://api.github.com/repos/mstriemer/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstriemer/olympia/downloads","issues_url":"https://api.github.com/repos/mstriemer/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mstriemer/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mstriemer/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mstriemer/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstriemer/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mstriemer/olympia/releases{/id}","deployments_url":"https://api.github.com/repos/mstriemer/olympia/deployments","created_at":"2014-03-28T17:58:28Z","updated_at":"2016-02-17T03:59:13Z","pushed_at":"2016-09-20T16:10:23Z","git_url":"git://github.com/mstriemer/olympia.git","ssh_url":"git@github.com:mstriemer/olympia.git","clone_url":"https://github.com/mstriemer/olympia.git","svn_url":"https://github.com/mstriemer/olympia","homepage":"","size":614116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"dd8f7145d8c1d431ff2224955c57f857d072e6fd","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-09-20T07:44:10Z","pushed_at":"2016-09-20T16:22:24Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":651281,"stargazers_count":118,"watchers_count":118,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":228,"forks":171,"open_issues":228,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3563"},"html":{"href":"https://github.com/mozilla/addons-server/pull/3563"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/3563"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/3563/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3563/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3563/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/868efa2f986f8866382341ef17239982ffc1673f"}}}}
{"actor":{"display_login":"eviljeff"}}