{"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45","id":73483398,"html_url":"https://github.com/zKillboard/zKillboard/pull/45","diff_url":"https://github.com/zKillboard/zKillboard/pull/45.diff","patch_url":"https://github.com/zKillboard/zKillboard/pull/45.patch","issue_url":"https://api.github.com/repos/zKillboard/zKillboard/issues/45","number":45,"state":"closed","locked":false,"title":"Rewrote the main cycle in Info::getLocationID","user":{"login":"geranai-yoda","id":19498580,"avatar_url":"https://avatars.githubusercontent.com/u/19498580?v=3","gravatar_id":"","url":"https://api.github.com/users/geranai-yoda","html_url":"https://github.com/geranai-yoda","followers_url":"https://api.github.com/users/geranai-yoda/followers","following_url":"https://api.github.com/users/geranai-yoda/following{/other_user}","gists_url":"https://api.github.com/users/geranai-yoda/gists{/gist_id}","starred_url":"https://api.github.com/users/geranai-yoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geranai-yoda/subscriptions","organizations_url":"https://api.github.com/users/geranai-yoda/orgs","repos_url":"https://api.github.com/users/geranai-yoda/repos","events_url":"https://api.github.com/users/geranai-yoda/events{/privacy}","received_events_url":"https://api.github.com/users/geranai-yoda/received_events","type":"User","site_admin":false},"body":"I don't write much PHP, so this is probably wrong. I was checking how you implemented that function and noticed you used that array and all those array operations on it, but then only returned the itemID value, so here's my take on solving the same problem with possibly a bit less cpu cycles!\r\n\r\nI apologize for code style / indentation / etc, didn't check if there was a standard to follow, was just a quick change, feel free to discard it :)\r\n","created_at":"2016-06-12T01:50:05Z","updated_at":"2016-07-05T18:12:07Z","closed_at":"2016-07-05T18:12:06Z","merged_at":"2016-07-05T18:12:06Z","merge_commit_sha":"c8653ec368d3726e8ba852292116a0485a9b8fff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45/commits","review_comments_url":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45/comments","review_comment_url":"https://api.github.com/repos/zKillboard/zKillboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zKillboard/zKillboard/issues/45/comments","statuses_url":"https://api.github.com/repos/zKillboard/zKillboard/statuses/193967b11e985ec1947658b76cceeda470a8e3b3","head":{"label":"geranai-yoda:master","ref":"master","sha":"193967b11e985ec1947658b76cceeda470a8e3b3","user":{"login":"geranai-yoda","id":19498580,"avatar_url":"https://avatars.githubusercontent.com/u/19498580?v=3","gravatar_id":"","url":"https://api.github.com/users/geranai-yoda","html_url":"https://github.com/geranai-yoda","followers_url":"https://api.github.com/users/geranai-yoda/followers","following_url":"https://api.github.com/users/geranai-yoda/following{/other_user}","gists_url":"https://api.github.com/users/geranai-yoda/gists{/gist_id}","starred_url":"https://api.github.com/users/geranai-yoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geranai-yoda/subscriptions","organizations_url":"https://api.github.com/users/geranai-yoda/orgs","repos_url":"https://api.github.com/users/geranai-yoda/repos","events_url":"https://api.github.com/users/geranai-yoda/events{/privacy}","received_events_url":"https://api.github.com/users/geranai-yoda/received_events","type":"User","site_admin":false},"repo":{"id":60348687,"name":"zKillboard","full_name":"geranai-yoda/zKillboard","owner":{"login":"geranai-yoda","id":19498580,"avatar_url":"https://avatars.githubusercontent.com/u/19498580?v=3","gravatar_id":"","url":"https://api.github.com/users/geranai-yoda","html_url":"https://github.com/geranai-yoda","followers_url":"https://api.github.com/users/geranai-yoda/followers","following_url":"https://api.github.com/users/geranai-yoda/following{/other_user}","gists_url":"https://api.github.com/users/geranai-yoda/gists{/gist_id}","starred_url":"https://api.github.com/users/geranai-yoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geranai-yoda/subscriptions","organizations_url":"https://api.github.com/users/geranai-yoda/orgs","repos_url":"https://api.github.com/users/geranai-yoda/repos","events_url":"https://api.github.com/users/geranai-yoda/events{/privacy}","received_events_url":"https://api.github.com/users/geranai-yoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geranai-yoda/zKillboard","description":"Easy does it","fork":true,"url":"https://api.github.com/repos/geranai-yoda/zKillboard","forks_url":"https://api.github.com/repos/geranai-yoda/zKillboard/forks","keys_url":"https://api.github.com/repos/geranai-yoda/zKillboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geranai-yoda/zKillboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geranai-yoda/zKillboard/teams","hooks_url":"https://api.github.com/repos/geranai-yoda/zKillboard/hooks","issue_events_url":"https://api.github.com/repos/geranai-yoda/zKillboard/issues/events{/number}","events_url":"https://api.github.com/repos/geranai-yoda/zKillboard/events","assignees_url":"https://api.github.com/repos/geranai-yoda/zKillboard/assignees{/user}","branches_url":"https://api.github.com/repos/geranai-yoda/zKillboard/branches{/branch}","tags_url":"https://api.github.com/repos/geranai-yoda/zKillboard/tags","blobs_url":"https://api.github.com/repos/geranai-yoda/zKillboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geranai-yoda/zKillboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geranai-yoda/zKillboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/geranai-yoda/zKillboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geranai-yoda/zKillboard/statuses/{sha}","languages_url":"https://api.github.com/repos/geranai-yoda/zKillboard/languages","stargazers_url":"https://api.github.com/repos/geranai-yoda/zKillboard/stargazers","contributors_url":"https://api.github.com/repos/geranai-yoda/zKillboard/contributors","subscribers_url":"https://api.github.com/repos/geranai-yoda/zKillboard/subscribers","subscription_url":"https://api.github.com/repos/geranai-yoda/zKillboard/subscription","commits_url":"https://api.github.com/repos/geranai-yoda/zKillboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/geranai-yoda/zKillboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/geranai-yoda/zKillboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/geranai-yoda/zKillboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/geranai-yoda/zKillboard/contents/{+path}","compare_url":"https://api.github.com/repos/geranai-yoda/zKillboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geranai-yoda/zKillboard/merges","archive_url":"https://api.github.com/repos/geranai-yoda/zKillboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geranai-yoda/zKillboard/downloads","issues_url":"https://api.github.com/repos/geranai-yoda/zKillboard/issues{/number}","pulls_url":"https://api.github.com/repos/geranai-yoda/zKillboard/pulls{/number}","milestones_url":"https://api.github.com/repos/geranai-yoda/zKillboard/milestones{/number}","notifications_url":"https://api.github.com/repos/geranai-yoda/zKillboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geranai-yoda/zKillboard/labels{/name}","releases_url":"https://api.github.com/repos/geranai-yoda/zKillboard/releases{/id}","deployments_url":"https://api.github.com/repos/geranai-yoda/zKillboard/deployments","created_at":"2016-06-03T13:12:12Z","updated_at":"2016-06-03T13:12:13Z","pushed_at":"2016-06-12T01:41:02Z","git_url":"git://github.com/geranai-yoda/zKillboard.git","ssh_url":"git@github.com:geranai-yoda/zKillboard.git","clone_url":"https://github.com/geranai-yoda/zKillboard.git","svn_url":"https://github.com/geranai-yoda/zKillboard","homepage":"https://zkillboard.com","size":7868,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zKillboard:master","ref":"master","sha":"751bf9bb8f351f259c8dbc1d91e2ae2320bd102e","user":{"login":"zKillboard","id":10120580,"avatar_url":"https://avatars.githubusercontent.com/u/10120580?v=3","gravatar_id":"","url":"https://api.github.com/users/zKillboard","html_url":"https://github.com/zKillboard","followers_url":"https://api.github.com/users/zKillboard/followers","following_url":"https://api.github.com/users/zKillboard/following{/other_user}","gists_url":"https://api.github.com/users/zKillboard/gists{/gist_id}","starred_url":"https://api.github.com/users/zKillboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zKillboard/subscriptions","organizations_url":"https://api.github.com/users/zKillboard/orgs","repos_url":"https://api.github.com/users/zKillboard/repos","events_url":"https://api.github.com/users/zKillboard/events{/privacy}","received_events_url":"https://api.github.com/users/zKillboard/received_events","type":"Organization","site_admin":false},"repo":{"id":36101000,"name":"zKillboard","full_name":"zKillboard/zKillboard","owner":{"login":"zKillboard","id":10120580,"avatar_url":"https://avatars.githubusercontent.com/u/10120580?v=3","gravatar_id":"","url":"https://api.github.com/users/zKillboard","html_url":"https://github.com/zKillboard","followers_url":"https://api.github.com/users/zKillboard/followers","following_url":"https://api.github.com/users/zKillboard/following{/other_user}","gists_url":"https://api.github.com/users/zKillboard/gists{/gist_id}","starred_url":"https://api.github.com/users/zKillboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zKillboard/subscriptions","organizations_url":"https://api.github.com/users/zKillboard/orgs","repos_url":"https://api.github.com/users/zKillboard/repos","events_url":"https://api.github.com/users/zKillboard/events{/privacy}","received_events_url":"https://api.github.com/users/zKillboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zKillboard/zKillboard","description":"Easy does it","fork":false,"url":"https://api.github.com/repos/zKillboard/zKillboard","forks_url":"https://api.github.com/repos/zKillboard/zKillboard/forks","keys_url":"https://api.github.com/repos/zKillboard/zKillboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zKillboard/zKillboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zKillboard/zKillboard/teams","hooks_url":"https://api.github.com/repos/zKillboard/zKillboard/hooks","issue_events_url":"https://api.github.com/repos/zKillboard/zKillboard/issues/events{/number}","events_url":"https://api.github.com/repos/zKillboard/zKillboard/events","assignees_url":"https://api.github.com/repos/zKillboard/zKillboard/assignees{/user}","branches_url":"https://api.github.com/repos/zKillboard/zKillboard/branches{/branch}","tags_url":"https://api.github.com/repos/zKillboard/zKillboard/tags","blobs_url":"https://api.github.com/repos/zKillboard/zKillboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zKillboard/zKillboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zKillboard/zKillboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/zKillboard/zKillboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zKillboard/zKillboard/statuses/{sha}","languages_url":"https://api.github.com/repos/zKillboard/zKillboard/languages","stargazers_url":"https://api.github.com/repos/zKillboard/zKillboard/stargazers","contributors_url":"https://api.github.com/repos/zKillboard/zKillboard/contributors","subscribers_url":"https://api.github.com/repos/zKillboard/zKillboard/subscribers","subscription_url":"https://api.github.com/repos/zKillboard/zKillboard/subscription","commits_url":"https://api.github.com/repos/zKillboard/zKillboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/zKillboard/zKillboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/zKillboard/zKillboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/zKillboard/zKillboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/zKillboard/zKillboard/contents/{+path}","compare_url":"https://api.github.com/repos/zKillboard/zKillboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zKillboard/zKillboard/merges","archive_url":"https://api.github.com/repos/zKillboard/zKillboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zKillboard/zKillboard/downloads","issues_url":"https://api.github.com/repos/zKillboard/zKillboard/issues{/number}","pulls_url":"https://api.github.com/repos/zKillboard/zKillboard/pulls{/number}","milestones_url":"https://api.github.com/repos/zKillboard/zKillboard/milestones{/number}","notifications_url":"https://api.github.com/repos/zKillboard/zKillboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zKillboard/zKillboard/labels{/name}","releases_url":"https://api.github.com/repos/zKillboard/zKillboard/releases{/id}","deployments_url":"https://api.github.com/repos/zKillboard/zKillboard/deployments","created_at":"2015-05-23T00:23:43Z","updated_at":"2016-06-30T16:57:23Z","pushed_at":"2016-07-05T18:12:07Z","git_url":"git://github.com/zKillboard/zKillboard.git","ssh_url":"git@github.com:zKillboard/zKillboard.git","clone_url":"https://github.com/zKillboard/zKillboard.git","svn_url":"https://github.com/zKillboard/zKillboard","homepage":"https://zkillboard.com","size":8382,"stargazers_count":66,"watchers_count":66,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":7,"forks":23,"open_issues":7,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45"},"html":{"href":"https://github.com/zKillboard/zKillboard/pull/45"},"issue":{"href":"https://api.github.com/repos/zKillboard/zKillboard/issues/45"},"comments":{"href":"https://api.github.com/repos/zKillboard/zKillboard/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/zKillboard/zKillboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zKillboard/zKillboard/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/zKillboard/zKillboard/statuses/193967b11e985ec1947658b76cceeda470a8e3b3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cvweiss","id":739285,"avatar_url":"https://avatars.githubusercontent.com/u/739285?v=3","gravatar_id":"","url":"https://api.github.com/users/cvweiss","html_url":"https://github.com/cvweiss","followers_url":"https://api.github.com/users/cvweiss/followers","following_url":"https://api.github.com/users/cvweiss/following{/other_user}","gists_url":"https://api.github.com/users/cvweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/cvweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvweiss/subscriptions","organizations_url":"https://api.github.com/users/cvweiss/orgs","repos_url":"https://api.github.com/users/cvweiss/repos","events_url":"https://api.github.com/users/cvweiss/events{/privacy}","received_events_url":"https://api.github.com/users/cvweiss/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"cvweiss"}}