{"action":"opened","number":76,"pull_request":{"url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76","id":67298238,"html_url":"https://github.com/binjitsu/binjitsu/pull/76","diff_url":"https://github.com/binjitsu/binjitsu/pull/76.diff","patch_url":"https://github.com/binjitsu/binjitsu/pull/76.patch","issue_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/76","number":76,"state":"open","locked":false,"title":"Changed setRegisters to handle `pop; pop; ret` style gadgets. fix for…","user":{"login":"toomanybananas","id":694033,"avatar_url":"https://avatars.githubusercontent.com/u/694033?v=3","gravatar_id":"","url":"https://api.github.com/users/toomanybananas","html_url":"https://github.com/toomanybananas","followers_url":"https://api.github.com/users/toomanybananas/followers","following_url":"https://api.github.com/users/toomanybananas/following{/other_user}","gists_url":"https://api.github.com/users/toomanybananas/gists{/gist_id}","starred_url":"https://api.github.com/users/toomanybananas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toomanybananas/subscriptions","organizations_url":"https://api.github.com/users/toomanybananas/orgs","repos_url":"https://api.github.com/users/toomanybananas/repos","events_url":"https://api.github.com/users/toomanybananas/events{/privacy}","received_events_url":"https://api.github.com/users/toomanybananas/received_events","type":"User","site_admin":false},"body":"… #75 \r\n\r\nI'm not sure how (or if it even will try) to handle gadgets that are `pop; (some non pop instruction); ret`. \r\n\r\nThe stack is still annotated in rop.dump(), however what values go in which register are not annotated. It also can generate inefficent rop chains: If you have `pop rax; pop rbx; ret` as your gadget and try to set both of those registers, it will generate 2 chains instead of one.","created_at":"2016-04-21T05:18:23Z","updated_at":"2016-04-21T05:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76/commits","review_comments_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76/comments","review_comment_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/76/comments","statuses_url":"https://api.github.com/repos/binjitsu/binjitsu/statuses/49d2c53810215d780ef928c0ddcb12508289394b","head":{"label":"toomanybananas:master","ref":"master","sha":"49d2c53810215d780ef928c0ddcb12508289394b","user":{"login":"toomanybananas","id":694033,"avatar_url":"https://avatars.githubusercontent.com/u/694033?v=3","gravatar_id":"","url":"https://api.github.com/users/toomanybananas","html_url":"https://github.com/toomanybananas","followers_url":"https://api.github.com/users/toomanybananas/followers","following_url":"https://api.github.com/users/toomanybananas/following{/other_user}","gists_url":"https://api.github.com/users/toomanybananas/gists{/gist_id}","starred_url":"https://api.github.com/users/toomanybananas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toomanybananas/subscriptions","organizations_url":"https://api.github.com/users/toomanybananas/orgs","repos_url":"https://api.github.com/users/toomanybananas/repos","events_url":"https://api.github.com/users/toomanybananas/events{/privacy}","received_events_url":"https://api.github.com/users/toomanybananas/received_events","type":"User","site_admin":false},"repo":{"id":56730692,"name":"binjitsu","full_name":"toomanybananas/binjitsu","owner":{"login":"toomanybananas","id":694033,"avatar_url":"https://avatars.githubusercontent.com/u/694033?v=3","gravatar_id":"","url":"https://api.github.com/users/toomanybananas","html_url":"https://github.com/toomanybananas","followers_url":"https://api.github.com/users/toomanybananas/followers","following_url":"https://api.github.com/users/toomanybananas/following{/other_user}","gists_url":"https://api.github.com/users/toomanybananas/gists{/gist_id}","starred_url":"https://api.github.com/users/toomanybananas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toomanybananas/subscriptions","organizations_url":"https://api.github.com/users/toomanybananas/orgs","repos_url":"https://api.github.com/users/toomanybananas/repos","events_url":"https://api.github.com/users/toomanybananas/events{/privacy}","received_events_url":"https://api.github.com/users/toomanybananas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toomanybananas/binjitsu","description":"CTF framework and exploit development library","fork":true,"url":"https://api.github.com/repos/toomanybananas/binjitsu","forks_url":"https://api.github.com/repos/toomanybananas/binjitsu/forks","keys_url":"https://api.github.com/repos/toomanybananas/binjitsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toomanybananas/binjitsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toomanybananas/binjitsu/teams","hooks_url":"https://api.github.com/repos/toomanybananas/binjitsu/hooks","issue_events_url":"https://api.github.com/repos/toomanybananas/binjitsu/issues/events{/number}","events_url":"https://api.github.com/repos/toomanybananas/binjitsu/events","assignees_url":"https://api.github.com/repos/toomanybananas/binjitsu/assignees{/user}","branches_url":"https://api.github.com/repos/toomanybananas/binjitsu/branches{/branch}","tags_url":"https://api.github.com/repos/toomanybananas/binjitsu/tags","blobs_url":"https://api.github.com/repos/toomanybananas/binjitsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toomanybananas/binjitsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toomanybananas/binjitsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/toomanybananas/binjitsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toomanybananas/binjitsu/statuses/{sha}","languages_url":"https://api.github.com/repos/toomanybananas/binjitsu/languages","stargazers_url":"https://api.github.com/repos/toomanybananas/binjitsu/stargazers","contributors_url":"https://api.github.com/repos/toomanybananas/binjitsu/contributors","subscribers_url":"https://api.github.com/repos/toomanybananas/binjitsu/subscribers","subscription_url":"https://api.github.com/repos/toomanybananas/binjitsu/subscription","commits_url":"https://api.github.com/repos/toomanybananas/binjitsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/toomanybananas/binjitsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/toomanybananas/binjitsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/toomanybananas/binjitsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/toomanybananas/binjitsu/contents/{+path}","compare_url":"https://api.github.com/repos/toomanybananas/binjitsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toomanybananas/binjitsu/merges","archive_url":"https://api.github.com/repos/toomanybananas/binjitsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toomanybananas/binjitsu/downloads","issues_url":"https://api.github.com/repos/toomanybananas/binjitsu/issues{/number}","pulls_url":"https://api.github.com/repos/toomanybananas/binjitsu/pulls{/number}","milestones_url":"https://api.github.com/repos/toomanybananas/binjitsu/milestones{/number}","notifications_url":"https://api.github.com/repos/toomanybananas/binjitsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toomanybananas/binjitsu/labels{/name}","releases_url":"https://api.github.com/repos/toomanybananas/binjitsu/releases{/id}","deployments_url":"https://api.github.com/repos/toomanybananas/binjitsu/deployments","created_at":"2016-04-21T00:49:00Z","updated_at":"2016-04-21T00:49:03Z","pushed_at":"2016-04-21T05:12:59Z","git_url":"git://github.com/toomanybananas/binjitsu.git","ssh_url":"git@github.com:toomanybananas/binjitsu.git","clone_url":"https://github.com/toomanybananas/binjitsu.git","svn_url":"https://github.com/toomanybananas/binjitsu","homepage":"https://binjit.su","size":21319,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binjitsu:master","ref":"master","sha":"eb8f905449dbcbbcd45febdb84d312df2cf0a51e","user":{"login":"binjitsu","id":6656233,"avatar_url":"https://avatars.githubusercontent.com/u/6656233?v=3","gravatar_id":"","url":"https://api.github.com/users/binjitsu","html_url":"https://github.com/binjitsu","followers_url":"https://api.github.com/users/binjitsu/followers","following_url":"https://api.github.com/users/binjitsu/following{/other_user}","gists_url":"https://api.github.com/users/binjitsu/gists{/gist_id}","starred_url":"https://api.github.com/users/binjitsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binjitsu/subscriptions","organizations_url":"https://api.github.com/users/binjitsu/orgs","repos_url":"https://api.github.com/users/binjitsu/repos","events_url":"https://api.github.com/users/binjitsu/events{/privacy}","received_events_url":"https://api.github.com/users/binjitsu/received_events","type":"Organization","site_admin":false},"repo":{"id":29157870,"name":"binjitsu","full_name":"binjitsu/binjitsu","owner":{"login":"binjitsu","id":6656233,"avatar_url":"https://avatars.githubusercontent.com/u/6656233?v=3","gravatar_id":"","url":"https://api.github.com/users/binjitsu","html_url":"https://github.com/binjitsu","followers_url":"https://api.github.com/users/binjitsu/followers","following_url":"https://api.github.com/users/binjitsu/following{/other_user}","gists_url":"https://api.github.com/users/binjitsu/gists{/gist_id}","starred_url":"https://api.github.com/users/binjitsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binjitsu/subscriptions","organizations_url":"https://api.github.com/users/binjitsu/orgs","repos_url":"https://api.github.com/users/binjitsu/repos","events_url":"https://api.github.com/users/binjitsu/events{/privacy}","received_events_url":"https://api.github.com/users/binjitsu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binjitsu/binjitsu","description":"CTF framework and exploit development library","fork":true,"url":"https://api.github.com/repos/binjitsu/binjitsu","forks_url":"https://api.github.com/repos/binjitsu/binjitsu/forks","keys_url":"https://api.github.com/repos/binjitsu/binjitsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binjitsu/binjitsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binjitsu/binjitsu/teams","hooks_url":"https://api.github.com/repos/binjitsu/binjitsu/hooks","issue_events_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/events{/number}","events_url":"https://api.github.com/repos/binjitsu/binjitsu/events","assignees_url":"https://api.github.com/repos/binjitsu/binjitsu/assignees{/user}","branches_url":"https://api.github.com/repos/binjitsu/binjitsu/branches{/branch}","tags_url":"https://api.github.com/repos/binjitsu/binjitsu/tags","blobs_url":"https://api.github.com/repos/binjitsu/binjitsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binjitsu/binjitsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binjitsu/binjitsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/binjitsu/binjitsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binjitsu/binjitsu/statuses/{sha}","languages_url":"https://api.github.com/repos/binjitsu/binjitsu/languages","stargazers_url":"https://api.github.com/repos/binjitsu/binjitsu/stargazers","contributors_url":"https://api.github.com/repos/binjitsu/binjitsu/contributors","subscribers_url":"https://api.github.com/repos/binjitsu/binjitsu/subscribers","subscription_url":"https://api.github.com/repos/binjitsu/binjitsu/subscription","commits_url":"https://api.github.com/repos/binjitsu/binjitsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/binjitsu/binjitsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/binjitsu/binjitsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/binjitsu/binjitsu/contents/{+path}","compare_url":"https://api.github.com/repos/binjitsu/binjitsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binjitsu/binjitsu/merges","archive_url":"https://api.github.com/repos/binjitsu/binjitsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binjitsu/binjitsu/downloads","issues_url":"https://api.github.com/repos/binjitsu/binjitsu/issues{/number}","pulls_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls{/number}","milestones_url":"https://api.github.com/repos/binjitsu/binjitsu/milestones{/number}","notifications_url":"https://api.github.com/repos/binjitsu/binjitsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binjitsu/binjitsu/labels{/name}","releases_url":"https://api.github.com/repos/binjitsu/binjitsu/releases{/id}","deployments_url":"https://api.github.com/repos/binjitsu/binjitsu/deployments","created_at":"2015-01-12T21:28:40Z","updated_at":"2016-04-20T21:04:43Z","pushed_at":"2016-04-21T00:11:56Z","git_url":"git://github.com/binjitsu/binjitsu.git","ssh_url":"git@github.com:binjitsu/binjitsu.git","clone_url":"https://github.com/binjitsu/binjitsu.git","svn_url":"https://github.com/binjitsu/binjitsu","homepage":"https://binjit.su","size":22126,"stargazers_count":221,"watchers_count":221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":18,"forks":32,"open_issues":18,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76"},"html":{"href":"https://github.com/binjitsu/binjitsu/pull/76"},"issue":{"href":"https://api.github.com/repos/binjitsu/binjitsu/issues/76"},"comments":{"href":"https://api.github.com/repos/binjitsu/binjitsu/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/binjitsu/binjitsu/statuses/49d2c53810215d780ef928c0ddcb12508289394b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":2,"changed_files":1}}