{"action":"closed","number":131,"pull_request":{"url":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131","id":83654294,"html_url":"https://github.com/mattrubin/Authenticator/pull/131","diff_url":"https://github.com/mattrubin/Authenticator/pull/131.diff","patch_url":"https://github.com/mattrubin/Authenticator/pull/131.patch","issue_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/131","number":131,"state":"closed","locked":false,"title":"Token load failure","user":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"body":"If the token store fails to load, the app will be unusable.\r\n\r\nWith this change, if persistent tokens cannot be loaded from the keychain, the `TokenStore` initializer will throw an error and the `AppController` will respond with a `fatalError`. Crashing the app is not ideal, but it is preferable to presenting the user with an unusable interface, and it should result in crash reports being sent to iTunes Connect.","created_at":"2016-09-01T15:26:41Z","updated_at":"2016-09-01T15:48:09Z","closed_at":"2016-09-01T15:48:08Z","merged_at":"2016-09-01T15:48:08Z","merge_commit_sha":"cd4733f8da14468d3ea1772aac6c31feb1935665","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131/commits","review_comments_url":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131/comments","review_comment_url":"https://api.github.com/repos/mattrubin/Authenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/131/comments","statuses_url":"https://api.github.com/repos/mattrubin/Authenticator/statuses/1cc646ecc3a1add4db2d697ba8142d4cfac1efe2","head":{"label":"mattrubin:token-load-failure","ref":"token-load-failure","sha":"1cc646ecc3a1add4db2d697ba8142d4cfac1efe2","user":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"repo":{"id":12443591,"name":"Authenticator","full_name":"mattrubin/Authenticator","owner":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattrubin/Authenticator","description":"Two-Factor Authentication Client for iOS","fork":false,"url":"https://api.github.com/repos/mattrubin/Authenticator","forks_url":"https://api.github.com/repos/mattrubin/Authenticator/forks","keys_url":"https://api.github.com/repos/mattrubin/Authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattrubin/Authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattrubin/Authenticator/teams","hooks_url":"https://api.github.com/repos/mattrubin/Authenticator/hooks","issue_events_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/mattrubin/Authenticator/events","assignees_url":"https://api.github.com/repos/mattrubin/Authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/mattrubin/Authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/mattrubin/Authenticator/tags","blobs_url":"https://api.github.com/repos/mattrubin/Authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattrubin/Authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattrubin/Authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattrubin/Authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattrubin/Authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/mattrubin/Authenticator/languages","stargazers_url":"https://api.github.com/repos/mattrubin/Authenticator/stargazers","contributors_url":"https://api.github.com/repos/mattrubin/Authenticator/contributors","subscribers_url":"https://api.github.com/repos/mattrubin/Authenticator/subscribers","subscription_url":"https://api.github.com/repos/mattrubin/Authenticator/subscription","commits_url":"https://api.github.com/repos/mattrubin/Authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattrubin/Authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattrubin/Authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattrubin/Authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/mattrubin/Authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattrubin/Authenticator/merges","archive_url":"https://api.github.com/repos/mattrubin/Authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattrubin/Authenticator/downloads","issues_url":"https://api.github.com/repos/mattrubin/Authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/mattrubin/Authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/mattrubin/Authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/mattrubin/Authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattrubin/Authenticator/labels{/name}","releases_url":"https://api.github.com/repos/mattrubin/Authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/mattrubin/Authenticator/deployments","created_at":"2013-08-28T20:15:05Z","updated_at":"2016-09-01T12:01:55Z","pushed_at":"2016-09-01T15:48:08Z","git_url":"git://github.com/mattrubin/Authenticator.git","ssh_url":"git@github.com:mattrubin/Authenticator.git","clone_url":"https://github.com/mattrubin/Authenticator.git","svn_url":"https://github.com/mattrubin/Authenticator","homepage":"https://mattrubin.me/authenticator","size":15683,"stargazers_count":123,"watchers_count":123,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":123,"default_branch":"master"}},"base":{"label":"mattrubin:master","ref":"master","sha":"60306036d7e311d16606970ba02806fc75415cec","user":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"repo":{"id":12443591,"name":"Authenticator","full_name":"mattrubin/Authenticator","owner":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattrubin/Authenticator","description":"Two-Factor Authentication Client for iOS","fork":false,"url":"https://api.github.com/repos/mattrubin/Authenticator","forks_url":"https://api.github.com/repos/mattrubin/Authenticator/forks","keys_url":"https://api.github.com/repos/mattrubin/Authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattrubin/Authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattrubin/Authenticator/teams","hooks_url":"https://api.github.com/repos/mattrubin/Authenticator/hooks","issue_events_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/mattrubin/Authenticator/events","assignees_url":"https://api.github.com/repos/mattrubin/Authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/mattrubin/Authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/mattrubin/Authenticator/tags","blobs_url":"https://api.github.com/repos/mattrubin/Authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattrubin/Authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattrubin/Authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattrubin/Authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattrubin/Authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/mattrubin/Authenticator/languages","stargazers_url":"https://api.github.com/repos/mattrubin/Authenticator/stargazers","contributors_url":"https://api.github.com/repos/mattrubin/Authenticator/contributors","subscribers_url":"https://api.github.com/repos/mattrubin/Authenticator/subscribers","subscription_url":"https://api.github.com/repos/mattrubin/Authenticator/subscription","commits_url":"https://api.github.com/repos/mattrubin/Authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattrubin/Authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattrubin/Authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattrubin/Authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattrubin/Authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/mattrubin/Authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattrubin/Authenticator/merges","archive_url":"https://api.github.com/repos/mattrubin/Authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattrubin/Authenticator/downloads","issues_url":"https://api.github.com/repos/mattrubin/Authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/mattrubin/Authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/mattrubin/Authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/mattrubin/Authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattrubin/Authenticator/labels{/name}","releases_url":"https://api.github.com/repos/mattrubin/Authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/mattrubin/Authenticator/deployments","created_at":"2013-08-28T20:15:05Z","updated_at":"2016-09-01T12:01:55Z","pushed_at":"2016-09-01T15:48:08Z","git_url":"git://github.com/mattrubin/Authenticator.git","ssh_url":"git@github.com:mattrubin/Authenticator.git","clone_url":"https://github.com/mattrubin/Authenticator.git","svn_url":"https://github.com/mattrubin/Authenticator","homepage":"https://mattrubin.me/authenticator","size":15683,"stargazers_count":123,"watchers_count":123,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131"},"html":{"href":"https://github.com/mattrubin/Authenticator/pull/131"},"issue":{"href":"https://api.github.com/repos/mattrubin/Authenticator/issues/131"},"comments":{"href":"https://api.github.com/repos/mattrubin/Authenticator/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/mattrubin/Authenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattrubin/Authenticator/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/mattrubin/Authenticator/statuses/1cc646ecc3a1add4db2d697ba8142d4cfac1efe2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":30,"deletions":28,"changed_files":2}}
{"actor":{"display_login":"mattrubin"}}