{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/81460396","pull_request_review_id":2440581,"id":81460396,"diff_hunk":"@@ -0,0 +1,56 @@\n+// @flow weak\n+\n+import React, { PropTypes, Children, cloneElement } from 'react';\n+import { createStyleSheet } from 'jss-theme-reactor';\n+import classNames from 'classnames';\n+\n+export const styleSheet = createStyleSheet('BottomNavigation', (theme) => {\n+  return {\n+    root: {\n+      position: 'relative',\n+      width: '100%',","path":"src/BottomNavigation/BottomNavigation.js","position":11,"original_position":11,"commit_id":"92758f19e361f698870356ed12f962543249db50","original_commit_id":"92758f19e361f698870356ed12f962543249db50","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"What about removing this property?\r\nWe would need to add an extra `div` wrapper in the demo with a `flexGrow: 1` property to make sure we use all the available space.\r\nI think that it's better to let the parent handle the layout.","created_at":"2016-10-01T23:19:15Z","updated_at":"2016-10-01T23:35:15Z","html_url":"https://github.com/callemall/material-ui/pull/5263#discussion_r81460396","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/5263","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/81460396"},"html":{"href":"https://github.com/callemall/material-ui/pull/5263#discussion_r81460396"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5263"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5263","id":86947839,"html_url":"https://github.com/callemall/material-ui/pull/5263","diff_url":"https://github.com/callemall/material-ui/pull/5263.diff","patch_url":"https://github.com/callemall/material-ui/pull/5263.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5263","number":5263,"state":"open","locked":false,"title":"[BottomNavigation] Migration of bottom-navigation component","user":{"login":"pradel","id":5749437,"avatar_url":"https://avatars.githubusercontent.com/u/5749437?v=3","gravatar_id":"","url":"https://api.github.com/users/pradel","html_url":"https://github.com/pradel","followers_url":"https://api.github.com/users/pradel/followers","following_url":"https://api.github.com/users/pradel/following{/other_user}","gists_url":"https://api.github.com/users/pradel/gists{/gist_id}","starred_url":"https://api.github.com/users/pradel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradel/subscriptions","organizations_url":"https://api.github.com/users/pradel/orgs","repos_url":"https://api.github.com/users/pradel/repos","events_url":"https://api.github.com/users/pradel/events{/privacy}","received_events_url":"https://api.github.com/users/pradel/received_events","type":"User","site_admin":false},"body":"- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\nMigration of BottomNavigation component for next branch.\r\nI have added a showLabel prop since google say \"If there are four or five actions, display inactive views as icons only\".\r\n\r\nExample of demo page:\r\n![capture d ecran 2016-09-27 a 16 53 17](https://cloud.githubusercontent.com/assets/5749437/18879184/a3c7d07e-84d3-11e6-9af7-461136d9fef6.png)\r\n","created_at":"2016-09-27T15:00:50Z","updated_at":"2016-10-01T23:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc5f0f33a74f4f818d4a895044e05291338a8e89","assignee":{"login":"nathanmarks","id":4420103,"avatar_url":"https://avatars.githubusercontent.com/u/4420103?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanmarks","html_url":"https://github.com/nathanmarks","followers_url":"https://api.github.com/users/nathanmarks/followers","following_url":"https://api.github.com/users/nathanmarks/following{/other_user}","gists_url":"https://api.github.com/users/nathanmarks/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanmarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanmarks/subscriptions","organizations_url":"https://api.github.com/users/nathanmarks/orgs","repos_url":"https://api.github.com/users/nathanmarks/repos","events_url":"https://api.github.com/users/nathanmarks/events{/privacy}","received_events_url":"https://api.github.com/users/nathanmarks/received_events","type":"User","site_admin":false},"assignees":[{"login":"nathanmarks","id":4420103,"avatar_url":"https://avatars.githubusercontent.com/u/4420103?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanmarks","html_url":"https://github.com/nathanmarks","followers_url":"https://api.github.com/users/nathanmarks/followers","following_url":"https://api.github.com/users/nathanmarks/following{/other_user}","gists_url":"https://api.github.com/users/nathanmarks/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanmarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanmarks/subscriptions","organizations_url":"https://api.github.com/users/nathanmarks/orgs","repos_url":"https://api.github.com/users/nathanmarks/repos","events_url":"https://api.github.com/users/nathanmarks/events{/privacy}","received_events_url":"https://api.github.com/users/nathanmarks/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5263/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5263/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5263/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/92758f19e361f698870356ed12f962543249db50","head":{"label":"pradel:next-add-bottom-navigation","ref":"next-add-bottom-navigation","sha":"92758f19e361f698870356ed12f962543249db50","user":{"login":"pradel","id":5749437,"avatar_url":"https://avatars.githubusercontent.com/u/5749437?v=3","gravatar_id":"","url":"https://api.github.com/users/pradel","html_url":"https://github.com/pradel","followers_url":"https://api.github.com/users/pradel/followers","following_url":"https://api.github.com/users/pradel/following{/other_user}","gists_url":"https://api.github.com/users/pradel/gists{/gist_id}","starred_url":"https://api.github.com/users/pradel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradel/subscriptions","organizations_url":"https://api.github.com/users/pradel/orgs","repos_url":"https://api.github.com/users/pradel/repos","events_url":"https://api.github.com/users/pradel/events{/privacy}","received_events_url":"https://api.github.com/users/pradel/received_events","type":"User","site_admin":false},"repo":{"id":49950017,"name":"material-ui","full_name":"pradel/material-ui","owner":{"login":"pradel","id":5749437,"avatar_url":"https://avatars.githubusercontent.com/u/5749437?v=3","gravatar_id":"","url":"https://api.github.com/users/pradel","html_url":"https://github.com/pradel","followers_url":"https://api.github.com/users/pradel/followers","following_url":"https://api.github.com/users/pradel/following{/other_user}","gists_url":"https://api.github.com/users/pradel/gists{/gist_id}","starred_url":"https://api.github.com/users/pradel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradel/subscriptions","organizations_url":"https://api.github.com/users/pradel/orgs","repos_url":"https://api.github.com/users/pradel/repos","events_url":"https://api.github.com/users/pradel/events{/privacy}","received_events_url":"https://api.github.com/users/pradel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pradel/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/pradel/material-ui","forks_url":"https://api.github.com/repos/pradel/material-ui/forks","keys_url":"https://api.github.com/repos/pradel/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pradel/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pradel/material-ui/teams","hooks_url":"https://api.github.com/repos/pradel/material-ui/hooks","issue_events_url":"https://api.github.com/repos/pradel/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/pradel/material-ui/events","assignees_url":"https://api.github.com/repos/pradel/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/pradel/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/pradel/material-ui/tags","blobs_url":"https://api.github.com/repos/pradel/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pradel/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pradel/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pradel/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pradel/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/pradel/material-ui/languages","stargazers_url":"https://api.github.com/repos/pradel/material-ui/stargazers","contributors_url":"https://api.github.com/repos/pradel/material-ui/contributors","subscribers_url":"https://api.github.com/repos/pradel/material-ui/subscribers","subscription_url":"https://api.github.com/repos/pradel/material-ui/subscription","commits_url":"https://api.github.com/repos/pradel/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pradel/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pradel/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pradel/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pradel/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/pradel/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pradel/material-ui/merges","archive_url":"https://api.github.com/repos/pradel/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pradel/material-ui/downloads","issues_url":"https://api.github.com/repos/pradel/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/pradel/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/pradel/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/pradel/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pradel/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/pradel/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/pradel/material-ui/deployments","created_at":"2016-01-19T12:03:35Z","updated_at":"2016-01-19T12:03:37Z","pushed_at":"2016-09-27T15:17:56Z","git_url":"git://github.com/pradel/material-ui.git","ssh_url":"git@github.com:pradel/material-ui.git","clone_url":"https://github.com/pradel/material-ui.git","svn_url":"https://github.com/pradel/material-ui","homepage":"http://www.material-ui.com","size":46798,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:next","ref":"next","sha":"c2a6cfbd0a4e1d96da37427d45565df716e9b29c","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-10-01T22:21:00Z","pushed_at":"2016-10-01T23:34:19Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":80877,"stargazers_count":19903,"watchers_count":19903,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3594,"mirror_url":null,"open_issues_count":621,"forks":3594,"open_issues":621,"watchers":19903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5263"},"html":{"href":"https://github.com/callemall/material-ui/pull/5263"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5263"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5263/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5263/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5263/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/92758f19e361f698870356ed12f962543249db50"}}}}
{"actor":{"display_login":"oliviertassinari"}}