{"action":"created","issue":{"url":"https://api.github.com/repos/clemenscorny/brisk/issues/2","repository_url":"https://api.github.com/repos/clemenscorny/brisk","labels_url":"https://api.github.com/repos/clemenscorny/brisk/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/clemenscorny/brisk/issues/2/comments","events_url":"https://api.github.com/repos/clemenscorny/brisk/issues/2/events","html_url":"https://github.com/clemenscorny/brisk/issues/2","id":162297267,"number":2,"title":"'remove","user":{"login":"etale-cohomology","id":16262763,"avatar_url":"https://avatars.githubusercontent.com/u/16262763?v=3","gravatar_id":"","url":"https://api.github.com/users/etale-cohomology","html_url":"https://github.com/etale-cohomology","followers_url":"https://api.github.com/users/etale-cohomology/followers","following_url":"https://api.github.com/users/etale-cohomology/following{/other_user}","gists_url":"https://api.github.com/users/etale-cohomology/gists{/gist_id}","starred_url":"https://api.github.com/users/etale-cohomology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etale-cohomology/subscriptions","organizations_url":"https://api.github.com/users/etale-cohomology/orgs","repos_url":"https://api.github.com/users/etale-cohomology/repos","events_url":"https://api.github.com/users/etale-cohomology/events{/privacy}","received_events_url":"https://api.github.com/users/etale-cohomology/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/clemenscorny/brisk/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-06-25T20:04:59Z","updated_at":"2016-07-02T21:59:14Z","closed_at":null,"body":"I'm trying to build this on Ubuntu LTS 14.04, and I get the following error when trying to run `make`:\r\n\r\n    [ 71%] Built target agast_static\r\n    [ 78%] Building CXX object CMakeFiles/brisk.dir/src/brisk.cpp.o\r\n    /home/diego/git/brisk/src/brisk.cpp: In member function ‘virtual void brisk::BriskFeatureDetector::detectImpl(const cv::Mat&, std::vector<cv::KeyPoint>&, const cv::Mat&) const’:\r\n    /home/diego/git/brisk/src/brisk.cpp:659:37: error: ‘removeInvalidPoints’ was not declared in this scope removeInvalidPoints(mask, keypoints);\r\n    \r\n    make[2]: *** [CMakeFiles/brisk.dir/src/brisk.cpp.o] Error 1\r\n    make[1]: *** [CMakeFiles/brisk.dir/all] Error 2\r\n    make: *** [all] Error 2\r\n"},"comment":{"url":"https://api.github.com/repos/clemenscorny/brisk/issues/comments/230123987","html_url":"https://github.com/clemenscorny/brisk/issues/2#issuecomment-230123987","issue_url":"https://api.github.com/repos/clemenscorny/brisk/issues/2","id":230123987,"user":{"login":"dchang0","id":8884074,"avatar_url":"https://avatars.githubusercontent.com/u/8884074?v=3","gravatar_id":"","url":"https://api.github.com/users/dchang0","html_url":"https://github.com/dchang0","followers_url":"https://api.github.com/users/dchang0/followers","following_url":"https://api.github.com/users/dchang0/following{/other_user}","gists_url":"https://api.github.com/users/dchang0/gists{/gist_id}","starred_url":"https://api.github.com/users/dchang0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchang0/subscriptions","organizations_url":"https://api.github.com/users/dchang0/orgs","repos_url":"https://api.github.com/users/dchang0/repos","events_url":"https://api.github.com/users/dchang0/events{/privacy}","received_events_url":"https://api.github.com/users/dchang0/received_events","type":"User","site_admin":false},"created_at":"2016-07-02T21:59:13Z","updated_at":"2016-07-02T21:59:13Z","body":"Perhaps they moved the function out to xfeatures2d (or some other library)? You might want to check that first before porting...\n\n> On Jul 2, 2016, at 14:27, Clemens Korner <notifications@github.com> wrote:\n> \n> Thank you for the bug report.\n> I can reproduce this issue with OpenCV 3.1.\n> Somehow the OpenCV-team removed the function removeInvalidPoints in OpenCV 3.x from features2d\n> OpenCV 2.4 opencv2/features2d/features2d.hpp <https://github.com/Itseez/opencv/blob/2.4/modules/features2d/include/opencv2/features2d/features2d.hpp#L192> vs OpenCV 3.1 opencv2/features2d.hpp <https://github.com/Itseez/opencv/blob/master/modules/features2d/include/opencv2/features2d.hpp>\n> I'll try to port this function back to the brisk code.\n> \n> BR Clemens\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub <https://github.com/clemenscorny/brisk/issues/2#issuecomment-230122857>, or mute the thread <https://github.com/notifications/unsubscribe/AIePaqcm2GtsRc9CHg8x1RPJwv6aGfw0ks5qRte9gaJpZM4I-avF>.\n> \n\n"}}
{"actor":{"display_login":"dchang0"}}