{"action":"opened","number":634,"pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/634","id":98866707,"html_url":"https://github.com/lede-project/source/pull/634","diff_url":"https://github.com/lede-project/source/pull/634.diff","patch_url":"https://github.com/lede-project/source/pull/634.patch","issue_url":"https://api.github.com/repos/lede-project/source/issues/634","number":634,"state":"open","locked":false,"title":"dnsmasq: use interface-name for add_local_hostname","user":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"body":"`add_local_hostname` uses an artificial host file to enter the router address. dnsmasq actually provides an automatic service for this `--interface-name`, which is way more reliable for multi-address IP6. As provided here, walking through each DHCP'ed interface will add \"**iface.router.lan**\" with aliases \"router.lan\" and \"router.\" \r\n\r\nIf we want to add WAN by inference, then I suggest we a new UCI `add_local_gatename`. This would be used by many of us whose ISP has a default IP4 and no IP6 name. It is basically the same code applied to dhcp `ignore` interfaces (inference). I can add that to this pull, or create a new one.\r\n\r\nSigned-off-by: Eric Luehrsen <ericluehrsen@hotmail.com>","created_at":"2016-12-21T03:36:10Z","updated_at":"2016-12-21T03:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lede-project/source/pulls/634/commits","review_comments_url":"https://api.github.com/repos/lede-project/source/pulls/634/comments","review_comment_url":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lede-project/source/issues/634/comments","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/821a21380d2407f54806d4829c3ff5b55751fbaf","head":{"label":"EricLuehrsen:dnsmasq_iface_name","ref":"dnsmasq_iface_name","sha":"821a21380d2407f54806d4829c3ff5b55751fbaf","user":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"repo":{"id":73581900,"name":"lede-source","full_name":"EricLuehrsen/lede-source","owner":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricLuehrsen/lede-source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":true,"url":"https://api.github.com/repos/EricLuehrsen/lede-source","forks_url":"https://api.github.com/repos/EricLuehrsen/lede-source/forks","keys_url":"https://api.github.com/repos/EricLuehrsen/lede-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricLuehrsen/lede-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricLuehrsen/lede-source/teams","hooks_url":"https://api.github.com/repos/EricLuehrsen/lede-source/hooks","issue_events_url":"https://api.github.com/repos/EricLuehrsen/lede-source/issues/events{/number}","events_url":"https://api.github.com/repos/EricLuehrsen/lede-source/events","assignees_url":"https://api.github.com/repos/EricLuehrsen/lede-source/assignees{/user}","branches_url":"https://api.github.com/repos/EricLuehrsen/lede-source/branches{/branch}","tags_url":"https://api.github.com/repos/EricLuehrsen/lede-source/tags","blobs_url":"https://api.github.com/repos/EricLuehrsen/lede-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricLuehrsen/lede-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricLuehrsen/lede-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricLuehrsen/lede-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricLuehrsen/lede-source/statuses/{sha}","languages_url":"https://api.github.com/repos/EricLuehrsen/lede-source/languages","stargazers_url":"https://api.github.com/repos/EricLuehrsen/lede-source/stargazers","contributors_url":"https://api.github.com/repos/EricLuehrsen/lede-source/contributors","subscribers_url":"https://api.github.com/repos/EricLuehrsen/lede-source/subscribers","subscription_url":"https://api.github.com/repos/EricLuehrsen/lede-source/subscription","commits_url":"https://api.github.com/repos/EricLuehrsen/lede-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricLuehrsen/lede-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricLuehrsen/lede-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricLuehrsen/lede-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricLuehrsen/lede-source/contents/{+path}","compare_url":"https://api.github.com/repos/EricLuehrsen/lede-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricLuehrsen/lede-source/merges","archive_url":"https://api.github.com/repos/EricLuehrsen/lede-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricLuehrsen/lede-source/downloads","issues_url":"https://api.github.com/repos/EricLuehrsen/lede-source/issues{/number}","pulls_url":"https://api.github.com/repos/EricLuehrsen/lede-source/pulls{/number}","milestones_url":"https://api.github.com/repos/EricLuehrsen/lede-source/milestones{/number}","notifications_url":"https://api.github.com/repos/EricLuehrsen/lede-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricLuehrsen/lede-source/labels{/name}","releases_url":"https://api.github.com/repos/EricLuehrsen/lede-source/releases{/id}","deployments_url":"https://api.github.com/repos/EricLuehrsen/lede-source/deployments","created_at":"2016-11-12T22:23:33Z","updated_at":"2016-11-13T00:55:36Z","pushed_at":"2016-12-21T03:27:22Z","git_url":"git://github.com/EricLuehrsen/lede-source.git","ssh_url":"git@github.com:EricLuehrsen/lede-source.git","clone_url":"https://github.com/EricLuehrsen/lede-source.git","svn_url":"https://github.com/EricLuehrsen/lede-source","homepage":"","size":132961,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lede-project:master","ref":"master","sha":"05abcf518d5e2b7d6526fd7a87a88a268030694a","user":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"repo":{"id":58552470,"name":"source","full_name":"lede-project/source","owner":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lede-project/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":false,"url":"https://api.github.com/repos/lede-project/source","forks_url":"https://api.github.com/repos/lede-project/source/forks","keys_url":"https://api.github.com/repos/lede-project/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lede-project/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lede-project/source/teams","hooks_url":"https://api.github.com/repos/lede-project/source/hooks","issue_events_url":"https://api.github.com/repos/lede-project/source/issues/events{/number}","events_url":"https://api.github.com/repos/lede-project/source/events","assignees_url":"https://api.github.com/repos/lede-project/source/assignees{/user}","branches_url":"https://api.github.com/repos/lede-project/source/branches{/branch}","tags_url":"https://api.github.com/repos/lede-project/source/tags","blobs_url":"https://api.github.com/repos/lede-project/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lede-project/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lede-project/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/lede-project/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/{sha}","languages_url":"https://api.github.com/repos/lede-project/source/languages","stargazers_url":"https://api.github.com/repos/lede-project/source/stargazers","contributors_url":"https://api.github.com/repos/lede-project/source/contributors","subscribers_url":"https://api.github.com/repos/lede-project/source/subscribers","subscription_url":"https://api.github.com/repos/lede-project/source/subscription","commits_url":"https://api.github.com/repos/lede-project/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/lede-project/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/lede-project/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/lede-project/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/lede-project/source/contents/{+path}","compare_url":"https://api.github.com/repos/lede-project/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lede-project/source/merges","archive_url":"https://api.github.com/repos/lede-project/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lede-project/source/downloads","issues_url":"https://api.github.com/repos/lede-project/source/issues{/number}","pulls_url":"https://api.github.com/repos/lede-project/source/pulls{/number}","milestones_url":"https://api.github.com/repos/lede-project/source/milestones{/number}","notifications_url":"https://api.github.com/repos/lede-project/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lede-project/source/labels{/name}","releases_url":"https://api.github.com/repos/lede-project/source/releases{/id}","deployments_url":"https://api.github.com/repos/lede-project/source/deployments","created_at":"2016-05-11T14:31:34Z","updated_at":"2016-12-20T19:12:41Z","pushed_at":"2016-12-20T23:39:27Z","git_url":"git://github.com/lede-project/source.git","ssh_url":"git@github.com:lede-project/source.git","clone_url":"https://github.com/lede-project/source.git","svn_url":"https://github.com/lede-project/source","homepage":"","size":132954,"stargazers_count":390,"watchers_count":390,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":27,"forks":254,"open_issues":27,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/634"},"html":{"href":"https://github.com/lede-project/source/pull/634"},"issue":{"href":"https://api.github.com/repos/lede-project/source/issues/634"},"comments":{"href":"https://api.github.com/repos/lede-project/source/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/lede-project/source/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lede-project/source/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/lede-project/source/statuses/821a21380d2407f54806d4829c3ff5b55751fbaf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"EricLuehrsen"}}