{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/66424530","id":66424530,"diff_hunk":"@@ -2230,9 +2230,15 @@ void Framework::BuildRoute(m2::PointD const & start, m2::PointD const & finish,\n \n       InsertRoute(route);\n       StopLocationFollow();\n-      m2::RectD routeRect = route.GetPoly().GetLimitRect();\n-      routeRect.Scale(kRouteScaleMultiplier);\n-      ShowRect(routeRect, -1);\n+\n+      // Validate route (in case of bicycle routing it can be invalid).\n+      ASSERT(route.IsValid(), ());\n+      if (route.IsValid())\n+      {\n+        m2::RectD const routeRect = route.GetPoly().GetLimitRect();","path":"map/framework.cpp","position":12,"original_position":12,"commit_id":"635454f4b590ecdab6ec1688d1cc5ebfce0a10b5","original_commit_id":"635454f4b590ecdab6ec1688d1cc5ebfce0a10b5","user":{"login":"rokuz","id":5437220,"avatar_url":"https://avatars.githubusercontent.com/u/5437220?v=3","gravatar_id":"","url":"https://api.github.com/users/rokuz","html_url":"https://github.com/rokuz","followers_url":"https://api.github.com/users/rokuz/followers","following_url":"https://api.github.com/users/rokuz/following{/other_user}","gists_url":"https://api.github.com/users/rokuz/gists{/gist_id}","starred_url":"https://api.github.com/users/rokuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokuz/subscriptions","organizations_url":"https://api.github.com/users/rokuz/orgs","repos_url":"https://api.github.com/users/rokuz/repos","events_url":"https://api.github.com/users/rokuz/events{/privacy}","received_events_url":"https://api.github.com/users/rokuz/received_events","type":"User","site_admin":false},"body":"Нет :) GetLimitRect возвращает по значению, никакой только от & не будет, извини :)","created_at":"2016-06-09T11:32:35Z","updated_at":"2016-06-09T11:32:35Z","html_url":"https://github.com/mapsme/omim/pull/3501#discussion_r66424530","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/3501","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/66424530"},"html":{"href":"https://github.com/mapsme/omim/pull/3501#discussion_r66424530"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3501"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/3501","id":73188523,"html_url":"https://github.com/mapsme/omim/pull/3501","diff_url":"https://github.com/mapsme/omim/pull/3501.diff","patch_url":"https://github.com/mapsme/omim/pull/3501.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/3501","number":3501,"state":"open","locked":false,"title":"Added small route validation","user":{"login":"rokuz","id":5437220,"avatar_url":"https://avatars.githubusercontent.com/u/5437220?v=3","gravatar_id":"","url":"https://api.github.com/users/rokuz","html_url":"https://github.com/rokuz","followers_url":"https://api.github.com/users/rokuz/followers","following_url":"https://api.github.com/users/rokuz/following{/other_user}","gists_url":"https://api.github.com/users/rokuz/gists{/gist_id}","starred_url":"https://api.github.com/users/rokuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokuz/subscriptions","organizations_url":"https://api.github.com/users/rokuz/orgs","repos_url":"https://api.github.com/users/rokuz/repos","events_url":"https://api.github.com/users/rokuz/events{/privacy}","received_events_url":"https://api.github.com/users/rokuz/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-09T10:13:34Z","updated_at":"2016-06-09T11:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f4df61c6cadbdb1ad5617e9fbe05718c2796f65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/3501/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/3501/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/3501/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/635454f4b590ecdab6ec1688d1cc5ebfce0a10b5","head":{"label":"rokuz:added-route-checking","ref":"added-route-checking","sha":"635454f4b590ecdab6ec1688d1cc5ebfce0a10b5","user":{"login":"rokuz","id":5437220,"avatar_url":"https://avatars.githubusercontent.com/u/5437220?v=3","gravatar_id":"","url":"https://api.github.com/users/rokuz","html_url":"https://github.com/rokuz","followers_url":"https://api.github.com/users/rokuz/followers","following_url":"https://api.github.com/users/rokuz/following{/other_user}","gists_url":"https://api.github.com/users/rokuz/gists{/gist_id}","starred_url":"https://api.github.com/users/rokuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokuz/subscriptions","organizations_url":"https://api.github.com/users/rokuz/orgs","repos_url":"https://api.github.com/users/rokuz/repos","events_url":"https://api.github.com/users/rokuz/events{/privacy}","received_events_url":"https://api.github.com/users/rokuz/received_events","type":"User","site_admin":false},"repo":{"id":43427777,"name":"omim","full_name":"rokuz/omim","owner":{"login":"rokuz","id":5437220,"avatar_url":"https://avatars.githubusercontent.com/u/5437220?v=3","gravatar_id":"","url":"https://api.github.com/users/rokuz","html_url":"https://github.com/rokuz","followers_url":"https://api.github.com/users/rokuz/followers","following_url":"https://api.github.com/users/rokuz/following{/other_user}","gists_url":"https://api.github.com/users/rokuz/gists{/gist_id}","starred_url":"https://api.github.com/users/rokuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokuz/subscriptions","organizations_url":"https://api.github.com/users/rokuz/orgs","repos_url":"https://api.github.com/users/rokuz/repos","events_url":"https://api.github.com/users/rokuz/events{/privacy}","received_events_url":"https://api.github.com/users/rokuz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rokuz/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/rokuz/omim","forks_url":"https://api.github.com/repos/rokuz/omim/forks","keys_url":"https://api.github.com/repos/rokuz/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rokuz/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rokuz/omim/teams","hooks_url":"https://api.github.com/repos/rokuz/omim/hooks","issue_events_url":"https://api.github.com/repos/rokuz/omim/issues/events{/number}","events_url":"https://api.github.com/repos/rokuz/omim/events","assignees_url":"https://api.github.com/repos/rokuz/omim/assignees{/user}","branches_url":"https://api.github.com/repos/rokuz/omim/branches{/branch}","tags_url":"https://api.github.com/repos/rokuz/omim/tags","blobs_url":"https://api.github.com/repos/rokuz/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rokuz/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rokuz/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/rokuz/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rokuz/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/rokuz/omim/languages","stargazers_url":"https://api.github.com/repos/rokuz/omim/stargazers","contributors_url":"https://api.github.com/repos/rokuz/omim/contributors","subscribers_url":"https://api.github.com/repos/rokuz/omim/subscribers","subscription_url":"https://api.github.com/repos/rokuz/omim/subscription","commits_url":"https://api.github.com/repos/rokuz/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/rokuz/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/rokuz/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/rokuz/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/rokuz/omim/contents/{+path}","compare_url":"https://api.github.com/repos/rokuz/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rokuz/omim/merges","archive_url":"https://api.github.com/repos/rokuz/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rokuz/omim/downloads","issues_url":"https://api.github.com/repos/rokuz/omim/issues{/number}","pulls_url":"https://api.github.com/repos/rokuz/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/rokuz/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/rokuz/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rokuz/omim/labels{/name}","releases_url":"https://api.github.com/repos/rokuz/omim/releases{/id}","deployments_url":"https://api.github.com/repos/rokuz/omim/deployments","created_at":"2015-09-30T10:51:34Z","updated_at":"2016-01-11T09:50:49Z","pushed_at":"2016-06-09T10:53:56Z","git_url":"git://github.com/rokuz/omim.git","ssh_url":"git@github.com:rokuz/omim.git","clone_url":"https://github.com/rokuz/omim.git","svn_url":"https://github.com/rokuz/omim","homepage":null,"size":2472344,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:release-62","ref":"release-62","sha":"6694b5f0bd26e3410f1323252ed8a541cbee4c89","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-06-09T10:08:13Z","pushed_at":"2016-06-09T11:23:09Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2557012,"stargazers_count":1804,"watchers_count":1804,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":198,"forks":285,"open_issues":198,"watchers":1804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3501"},"html":{"href":"https://github.com/mapsme/omim/pull/3501"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/3501"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/3501/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3501/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3501/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/635454f4b590ecdab6ec1688d1cc5ebfce0a10b5"}}}}
{"actor":{"display_login":"rokuz"}}