{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/66009506","id":66009506,"diff_hunk":"@@ -7845,12 +7844,9 @@ GenTree *           Compiler::optIsBoolCond(GenTree *   condBranch,\n     {\n         isBool = true;\n     }\n-    else if (opr1->gtOper == GT_CNS_INT)\n+    else if (opr1->IsIntegralConst(0) || opr1->IsIntegralConst(1))","path":"src/jit/optimizer.cpp","position":15,"original_position":15,"commit_id":"c9100ae22e725c40871c11cae8a74a03e82d4849","original_commit_id":"c9100ae22e725c40871c11cae8a74a03e82d4849","user":{"login":"mikedn","id":9973420,"avatar_url":"https://avatars.githubusercontent.com/u/9973420?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedn","html_url":"https://github.com/mikedn","followers_url":"https://api.github.com/users/mikedn/followers","following_url":"https://api.github.com/users/mikedn/following{/other_user}","gists_url":"https://api.github.com/users/mikedn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedn/subscriptions","organizations_url":"https://api.github.com/users/mikedn/orgs","repos_url":"https://api.github.com/users/mikedn/repos","events_url":"https://api.github.com/users/mikedn/events{/privacy}","received_events_url":"https://api.github.com/users/mikedn/received_events","type":"User","site_admin":false},"body":"There seems to be another opportunity for `IsIntegralConst` a few lines above, 7834-7837.","created_at":"2016-06-07T04:46:43Z","updated_at":"2016-06-07T04:46:44Z","html_url":"https://github.com/dotnet/coreclr/pull/5426#discussion_r66009506","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5426","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/66009506"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5426#discussion_r66009506"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5426"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/5426","id":72418611,"html_url":"https://github.com/dotnet/coreclr/pull/5426","diff_url":"https://github.com/dotnet/coreclr/pull/5426.diff","patch_url":"https://github.com/dotnet/coreclr/pull/5426.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/5426","number":5426,"state":"open","locked":false,"title":"Add methods to check for integer constants one and minus one","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"body":"These are primarily motivated by simplifying the RyuJIT tutorial,\r\nbut also make the existing code a bit cleaner.","created_at":"2016-06-02T21:13:50Z","updated_at":"2016-06-07T04:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d258b858bb47afedb44af06e189677add10c7a55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5426/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5426/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/5426/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/c9100ae22e725c40871c11cae8a74a03e82d4849","head":{"label":"CarolEidt:IsOne","ref":"IsOne","sha":"c9100ae22e725c40871c11cae8a74a03e82d4849","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"repo":{"id":31747006,"name":"coreclr","full_name":"CarolEidt/coreclr","owner":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarolEidt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/CarolEidt/coreclr","forks_url":"https://api.github.com/repos/CarolEidt/coreclr/forks","keys_url":"https://api.github.com/repos/CarolEidt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarolEidt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarolEidt/coreclr/teams","hooks_url":"https://api.github.com/repos/CarolEidt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/CarolEidt/coreclr/events","assignees_url":"https://api.github.com/repos/CarolEidt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/CarolEidt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/CarolEidt/coreclr/tags","blobs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarolEidt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarolEidt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarolEidt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/CarolEidt/coreclr/languages","stargazers_url":"https://api.github.com/repos/CarolEidt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/CarolEidt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/CarolEidt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/CarolEidt/coreclr/subscription","commits_url":"https://api.github.com/repos/CarolEidt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarolEidt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarolEidt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarolEidt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/CarolEidt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarolEidt/coreclr/merges","archive_url":"https://api.github.com/repos/CarolEidt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarolEidt/coreclr/downloads","issues_url":"https://api.github.com/repos/CarolEidt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/CarolEidt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/CarolEidt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/CarolEidt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarolEidt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/CarolEidt/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/CarolEidt/coreclr/deployments","created_at":"2015-03-06T01:49:09Z","updated_at":"2016-01-16T00:00:55Z","pushed_at":"2016-06-07T01:35:51Z","git_url":"git://github.com/CarolEidt/coreclr.git","ssh_url":"git@github.com:CarolEidt/coreclr.git","clone_url":"https://github.com/CarolEidt/coreclr.git","svn_url":"https://github.com/CarolEidt/coreclr","homepage":"","size":85242,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1cabb148cec4e72216c0701e4436acedd6ae6875","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-06-07T02:10:49Z","pushed_at":"2016-06-07T03:45:42Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":92927,"stargazers_count":6474,"watchers_count":6474,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1479,"mirror_url":null,"open_issues_count":815,"forks":1479,"open_issues":815,"watchers":6474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5426"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5426"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5426"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5426/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5426/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5426/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/c9100ae22e725c40871c11cae8a74a03e82d4849"}}}}
{"actor":{"display_login":"mikedn"}}