{"action":"opened","number":7143,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/7143","id":60012868,"html_url":"https://github.com/highfidelity/hifi/pull/7143","diff_url":"https://github.com/highfidelity/hifi/pull/7143.diff","patch_url":"https://github.com/highfidelity/hifi/pull/7143.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/7143","number":7143,"state":"open","locked":false,"title":"Add support for pop-up windows to Qt WebEngineView","user":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"body":"Previously, we didn't handle requests by web sites to open new windows, which could prevent a site like www.asana.com from loading since it's login requires a new window.  This PR adds support for popups, so now these types of sites work.\r\n\r\nTo test:\r\n\r\n1. Open a browser with Ctrl-B\r\n2. Type in a site that requires a pop up for its login, like www.asana.com\r\n3. Click log-in and observe that a new window pops up that allows you to log in (this step fails in master)","created_at":"2016-02-19T21:52:50Z","updated_at":"2016-02-19T21:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7143/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7143/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/7143/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/afb6f1fe840b90d02fc22a3f2f175bf4b3b9ae0c","head":{"label":"imgntn:webengine-new-windows","ref":"webengine-new-windows","sha":"afb6f1fe840b90d02fc22a3f2f175bf4b3b9ae0c","user":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"repo":{"id":41923670,"name":"hifi","full_name":"imgntn/hifi","owner":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imgntn/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/imgntn/hifi","forks_url":"https://api.github.com/repos/imgntn/hifi/forks","keys_url":"https://api.github.com/repos/imgntn/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imgntn/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imgntn/hifi/teams","hooks_url":"https://api.github.com/repos/imgntn/hifi/hooks","issue_events_url":"https://api.github.com/repos/imgntn/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/imgntn/hifi/events","assignees_url":"https://api.github.com/repos/imgntn/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/imgntn/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/imgntn/hifi/tags","blobs_url":"https://api.github.com/repos/imgntn/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imgntn/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imgntn/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/imgntn/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imgntn/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/imgntn/hifi/languages","stargazers_url":"https://api.github.com/repos/imgntn/hifi/stargazers","contributors_url":"https://api.github.com/repos/imgntn/hifi/contributors","subscribers_url":"https://api.github.com/repos/imgntn/hifi/subscribers","subscription_url":"https://api.github.com/repos/imgntn/hifi/subscription","commits_url":"https://api.github.com/repos/imgntn/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/imgntn/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/imgntn/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/imgntn/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/imgntn/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/imgntn/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imgntn/hifi/merges","archive_url":"https://api.github.com/repos/imgntn/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imgntn/hifi/downloads","issues_url":"https://api.github.com/repos/imgntn/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/imgntn/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/imgntn/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/imgntn/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imgntn/hifi/labels{/name}","releases_url":"https://api.github.com/repos/imgntn/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/imgntn/hifi/deployments","created_at":"2015-09-04T15:35:51Z","updated_at":"2016-01-11T18:48:25Z","pushed_at":"2016-02-19T21:50:41Z","git_url":"git://github.com/imgntn/hifi.git","ssh_url":"git@github.com:imgntn/hifi.git","clone_url":"https://github.com/imgntn/hifi.git","svn_url":"https://github.com/imgntn/hifi","homepage":"","size":192176,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"75429e39bc3909ecc83e131ab2a57c430c4ef5a0","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-02-19T12:37:33Z","pushed_at":"2016-02-19T21:52:50Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":233434,"stargazers_count":356,"watchers_count":356,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":57,"forks":206,"open_issues":57,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7143"},"html":{"href":"https://github.com/highfidelity/hifi/pull/7143"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7143"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7143/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7143/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7143/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/afb6f1fe840b90d02fc22a3f2f175bf4b3b9ae0c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":26,"deletions":11,"changed_files":3}}