{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/widgets/pulls/comments/82407090","pull_request_review_id":3318846,"id":82407090,"diff_hunk":"@@ -24,14 +26,20 @@ export interface ResizePanelMixin {\n \t\thandle: string;\n \t};\n \twidth: string;\n+\theight: string;\n }\n \n export type ResizePanel = Widget<ResizePanelState> & ParentListMixin<Child> & Destroyable & ResizePanelMixin;\n \n export interface ResizePanelFactory extends ComposeFactory<ResizePanel, ResizePanelOptions> { }\n \n const resizeNodePropertiesMap = new WeakMap<ResizePanel, VNodeProperties>();\n-const resizingMap = new WeakMap<ResizePanel, { width: number, clientX: number }>();\n+const resizingMap = new WeakMap<ResizePanel, {","path":"src/createResizePanel.ts","position":27,"original_position":27,"commit_id":"cc92c14d2a32dae1a782090de8783aa25a38c523","original_commit_id":"d4ee1411c9acf2b004a8145cbb271740de4b4b01","user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"body":"Yeah, but should be dealt with as a separate issue.  I think there is other private state here that should be rationalised into a single weakmap and interface.","created_at":"2016-10-07T15:02:00Z","updated_at":"2016-10-07T15:02:00Z","html_url":"https://github.com/dojo/widgets/pull/35#discussion_r82407090","pull_request_url":"https://api.github.com/repos/dojo/widgets/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments/82407090"},"html":{"href":"https://github.com/dojo/widgets/pull/35#discussion_r82407090"},"pull_request":{"href":"https://api.github.com/repos/dojo/widgets/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/35","id":82208243,"html_url":"https://github.com/dojo/widgets/pull/35","diff_url":"https://github.com/dojo/widgets/pull/35.diff","patch_url":"https://github.com/dojo/widgets/pull/35.patch","issue_url":"https://api.github.com/repos/dojo/widgets/issues/35","number":35,"state":"open","locked":false,"title":"Basic theme and CSS module support","user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars.githubusercontent.com/u/334586?v=3","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"body":"Figured we can start this conversation...\r\n* PostCSS is used to generate CSS modules\r\n* CSS module JSON is generated as TS modules\r\n* Added height support to ResizePanel\r\n* Added intelligent aspect to Button to allow custom classes during creation\r\n\r\nNotes:\r\n* Generated CSS lives at `src/themes/structural/_generated/`\r\n* Generated CSS modules live at `src/themes/structural/modules/`\r\n* I had to comment out the `tslint` task for now; we either need to generate lint-able modules or ignore generated TS modules.","created_at":"2016-08-22T15:08:31Z","updated_at":"2016-10-07T15:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf784234cfb28093468436b879a077ad08d269f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/widgets/pulls/35/commits","review_comments_url":"https://api.github.com/repos/dojo/widgets/pulls/35/comments","review_comment_url":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/35/comments","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/cc92c14d2a32dae1a782090de8783aa25a38c523","head":{"label":"bitpshr:css-modules","ref":"css-modules","sha":"cc92c14d2a32dae1a782090de8783aa25a38c523","user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars.githubusercontent.com/u/334586?v=3","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"repo":{"id":63620211,"name":"widgets","full_name":"bitpshr/widgets","owner":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars.githubusercontent.com/u/334586?v=3","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitpshr/widgets","description":"A core UI component library for Dojo 2","fork":true,"url":"https://api.github.com/repos/bitpshr/widgets","forks_url":"https://api.github.com/repos/bitpshr/widgets/forks","keys_url":"https://api.github.com/repos/bitpshr/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpshr/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpshr/widgets/teams","hooks_url":"https://api.github.com/repos/bitpshr/widgets/hooks","issue_events_url":"https://api.github.com/repos/bitpshr/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/bitpshr/widgets/events","assignees_url":"https://api.github.com/repos/bitpshr/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/bitpshr/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/bitpshr/widgets/tags","blobs_url":"https://api.github.com/repos/bitpshr/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpshr/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpshr/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpshr/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpshr/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpshr/widgets/languages","stargazers_url":"https://api.github.com/repos/bitpshr/widgets/stargazers","contributors_url":"https://api.github.com/repos/bitpshr/widgets/contributors","subscribers_url":"https://api.github.com/repos/bitpshr/widgets/subscribers","subscription_url":"https://api.github.com/repos/bitpshr/widgets/subscription","commits_url":"https://api.github.com/repos/bitpshr/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpshr/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpshr/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpshr/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitpshr/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/bitpshr/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpshr/widgets/merges","archive_url":"https://api.github.com/repos/bitpshr/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpshr/widgets/downloads","issues_url":"https://api.github.com/repos/bitpshr/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/bitpshr/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpshr/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpshr/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpshr/widgets/labels{/name}","releases_url":"https://api.github.com/repos/bitpshr/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/bitpshr/widgets/deployments","created_at":"2016-07-18T16:44:07Z","updated_at":"2016-07-18T16:44:08Z","pushed_at":"2016-10-07T14:44:46Z","git_url":"git://github.com/bitpshr/widgets.git","ssh_url":"git@github.com:bitpshr/widgets.git","clone_url":"https://github.com/bitpshr/widgets.git","svn_url":"https://github.com/bitpshr/widgets","homepage":null,"size":868,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"44dc934aed98bbe4295178b4f97c13ae8cb2ccc6","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":55768463,"name":"widgets","full_name":"dojo/widgets","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/widgets","description":":rocket: UI components for dojo2.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2016-04-08T09:47:48Z","updated_at":"2016-09-02T12:08:15Z","pushed_at":"2016-10-07T14:44:47Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"","size":1083,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/35"},"html":{"href":"https://github.com/dojo/widgets/pull/35"},"issue":{"href":"https://api.github.com/repos/dojo/widgets/issues/35"},"comments":{"href":"https://api.github.com/repos/dojo/widgets/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/widgets/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/widgets/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/widgets/statuses/cc92c14d2a32dae1a782090de8783aa25a38c523"}}}}
{"actor":{"display_login":"kitsonk"}}