{"action":"closed","number":6668,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668","id":70016940,"html_url":"https://github.com/cockroachdb/cockroach/pull/6668","diff_url":"https://github.com/cockroachdb/cockroach/pull/6668.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6668.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6668","number":6668,"state":"closed","locked":false,"title":"[DO NOT MERGE] TestUnknownColumnIDDuringMutation","user":{"login":"paperstreet","id":52528,"avatar_url":"https://avatars.githubusercontent.com/u/52528?v=3","gravatar_id":"","url":"https://api.github.com/users/paperstreet","html_url":"https://github.com/paperstreet","followers_url":"https://api.github.com/users/paperstreet/followers","following_url":"https://api.github.com/users/paperstreet/following{/other_user}","gists_url":"https://api.github.com/users/paperstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/paperstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paperstreet/subscriptions","organizations_url":"https://api.github.com/users/paperstreet/orgs","repos_url":"https://api.github.com/users/paperstreet/repos","events_url":"https://api.github.com/users/paperstreet/events{/privacy}","received_events_url":"https://api.github.com/users/paperstreet/received_events","type":"User","site_admin":false},"body":"This test currently fails, exhibiting a bug at https://github.com/cockroachdb/cockroach/blob/master/sql/rowwriter.go#L475. The general issue is that there are places in insert/update/delete where we assume every column id that is referenced by an IndexDescriptor can be found in tableDesc.Columns. This is not true during a mutation that is adding a new unique column.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6668)\n<!-- Reviewable:end -->\n","created_at":"2016-05-13T15:45:46Z","updated_at":"2016-05-16T15:09:01Z","closed_at":"2016-05-16T15:09:01Z","merged_at":null,"merge_commit_sha":"3ba114f72716989d86432b489a9f725f84c4a40b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6668/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/56d5e3bf3b7d841d6f2012301f1c316ea0d2bb9a","head":{"label":"paperstreet:mutation_unknown_colid","ref":"mutation_unknown_colid","sha":"56d5e3bf3b7d841d6f2012301f1c316ea0d2bb9a","user":{"login":"paperstreet","id":52528,"avatar_url":"https://avatars.githubusercontent.com/u/52528?v=3","gravatar_id":"","url":"https://api.github.com/users/paperstreet","html_url":"https://github.com/paperstreet","followers_url":"https://api.github.com/users/paperstreet/followers","following_url":"https://api.github.com/users/paperstreet/following{/other_user}","gists_url":"https://api.github.com/users/paperstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/paperstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paperstreet/subscriptions","organizations_url":"https://api.github.com/users/paperstreet/orgs","repos_url":"https://api.github.com/users/paperstreet/repos","events_url":"https://api.github.com/users/paperstreet/events{/privacy}","received_events_url":"https://api.github.com/users/paperstreet/received_events","type":"User","site_admin":false},"repo":{"id":47640635,"name":"cockroach","full_name":"paperstreet/cockroach","owner":{"login":"paperstreet","id":52528,"avatar_url":"https://avatars.githubusercontent.com/u/52528?v=3","gravatar_id":"","url":"https://api.github.com/users/paperstreet","html_url":"https://github.com/paperstreet","followers_url":"https://api.github.com/users/paperstreet/followers","following_url":"https://api.github.com/users/paperstreet/following{/other_user}","gists_url":"https://api.github.com/users/paperstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/paperstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paperstreet/subscriptions","organizations_url":"https://api.github.com/users/paperstreet/orgs","repos_url":"https://api.github.com/users/paperstreet/repos","events_url":"https://api.github.com/users/paperstreet/events{/privacy}","received_events_url":"https://api.github.com/users/paperstreet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paperstreet/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/paperstreet/cockroach","forks_url":"https://api.github.com/repos/paperstreet/cockroach/forks","keys_url":"https://api.github.com/repos/paperstreet/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paperstreet/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paperstreet/cockroach/teams","hooks_url":"https://api.github.com/repos/paperstreet/cockroach/hooks","issue_events_url":"https://api.github.com/repos/paperstreet/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/paperstreet/cockroach/events","assignees_url":"https://api.github.com/repos/paperstreet/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/paperstreet/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/paperstreet/cockroach/tags","blobs_url":"https://api.github.com/repos/paperstreet/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paperstreet/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paperstreet/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/paperstreet/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paperstreet/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/paperstreet/cockroach/languages","stargazers_url":"https://api.github.com/repos/paperstreet/cockroach/stargazers","contributors_url":"https://api.github.com/repos/paperstreet/cockroach/contributors","subscribers_url":"https://api.github.com/repos/paperstreet/cockroach/subscribers","subscription_url":"https://api.github.com/repos/paperstreet/cockroach/subscription","commits_url":"https://api.github.com/repos/paperstreet/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/paperstreet/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/paperstreet/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/paperstreet/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/paperstreet/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/paperstreet/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paperstreet/cockroach/merges","archive_url":"https://api.github.com/repos/paperstreet/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paperstreet/cockroach/downloads","issues_url":"https://api.github.com/repos/paperstreet/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/paperstreet/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/paperstreet/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/paperstreet/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paperstreet/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/paperstreet/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/paperstreet/cockroach/deployments","created_at":"2015-12-08T18:19:02Z","updated_at":"2016-03-09T21:31:14Z","pushed_at":"2016-05-13T20:25:19Z","git_url":"git://github.com/paperstreet/cockroach.git","ssh_url":"git@github.com:paperstreet/cockroach.git","clone_url":"https://github.com/paperstreet/cockroach.git","svn_url":"https://github.com/paperstreet/cockroach","homepage":null,"size":159728,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"202f5279a47f927c64254fc9ae5e0d212b6bd19f","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-05-16T09:39:26Z","pushed_at":"2016-05-16T14:33:38Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":207096,"stargazers_count":6897,"watchers_count":6897,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":664,"mirror_url":null,"open_issues_count":457,"forks":664,"open_issues":457,"watchers":6897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/6668"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6668"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6668/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6668/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/56d5e3bf3b7d841d6f2012301f1c316ea0d2bb9a"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":72,"deletions":0,"changed_files":1}}