{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12373","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12373/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12373/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12373/events","html_url":"https://github.com/joomla/joomla-cms/pull/12373","id":181908512,"number":12373,"title":"[3.7.x] Add script version to all js files and replace deprecated script signatures usage","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"id":415102761,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-3.7.x","name":"PR-3.7.x","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.7.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14/labels","id":1750036,"number":14,"title":"Joomla 3.7.0","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":219,"state":"open","created_at":"2016-05-05T16:42:34Z","updated_at":"2016-10-29T09:38:52Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2016-10-09T20:18:39Z","updated_at":"2016-10-29T11:51:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12373","html_url":"https://github.com/joomla/joomla-cms/pull/12373","diff_url":"https://github.com/joomla/joomla-cms/pull/12373.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12373.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/9638 (js part).\r\n\r\n### Summary of Changes\r\n\r\nFollowing https://github.com/joomla/joomla-cms/pull/11289 merge, this PR replaces all deprecated script  methods signature usage across the CMS.\r\n\r\nAlso:\r\n- adds script version to all js files to solve https://github.com/joomla/joomla-cms/issues/9638\r\n- use the api in conditional ie statements (html5.js)\r\n\r\n### Testing Instructions\r\n\r\n1. Code review.\r\n2. Apply patch and navigate in the frontend/backend. Confirm all is working fine and check all external js files are loaded and with script version\r\n\r\n### Documentation Changes Required\r\n\r\nNone.\r\n\r\npinging @dgt41 "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/257087372","html_url":"https://github.com/joomla/joomla-cms/pull/12373#issuecomment-257087372","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12373","id":257087372,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T11:51:27Z","updated_at":"2016-10-29T11:51:27Z","body":"Do this:\r\n1. download https://github.com/joomla/joomla-cms/releases/download/3.6.4/Joomla_3.6.3_to_3.6.4-Stable-Patch_Package.zip\r\n2. Go to admin, check the page source and the version string we are using before the update.\r\n3. Them use that zip in Upload & Update in joomla update component\r\n4. Check the page source and notice the version string changed"}}
{"actor":{"display_login":"andrepereiradasilva"}}