{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/92832429","pull_request_review_id":13355308,"id":92832429,"diff_hunk":"@@ -988,7 +988,7 @@ protected void setCatalogItemId(BrooklynObject item, String catalogItemId) {\n             } catch (Exception e) {\n                 Exceptions.propagateIfFatal(e);\n             }\n-            return new ClassLoaderUtils(reflections.getClassLoader()).loadClass(jType);\n+            return new ClassLoaderUtils(reflections.getClassLoader(), managementContext).loadClass(jType);","path":"core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java","position":5,"original_position":5,"commit_id":"0691b20b52c3f1e437725b5f7ddc53d4a43090fc","original_commit_id":"0691b20b52c3f1e437725b5f7ddc53d4a43090fc","user":{"login":"neykov","id":3612111,"avatar_url":"https://avatars.githubusercontent.com/u/3612111?v=3","gravatar_id":"","url":"https://api.github.com/users/neykov","html_url":"https://github.com/neykov","followers_url":"https://api.github.com/users/neykov/followers","following_url":"https://api.github.com/users/neykov/following{/other_user}","gists_url":"https://api.github.com/users/neykov/gists{/gist_id}","starred_url":"https://api.github.com/users/neykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neykov/subscriptions","organizations_url":"https://api.github.com/users/neykov/orgs","repos_url":"https://api.github.com/users/neykov/repos","events_url":"https://api.github.com/users/neykov/events{/privacy}","received_events_url":"https://api.github.com/users/neykov/received_events","type":"User","site_admin":false},"body":"I fail to see how this fixes the test (looking at the `ClassLoaderUtils` code). If `jType` has a prefix it should be able to load it anyway. If not then it will fail.\r\n\r\nLooks good otherwise.","created_at":"2016-12-16T15:39:59Z","updated_at":"2016-12-16T15:39:59Z","html_url":"https://github.com/apache/brooklyn-server/pull/490#discussion_r92832429","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/92832429"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/490#discussion_r92832429"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/490","id":97975647,"html_url":"https://github.com/apache/brooklyn-server/pull/490","diff_url":"https://github.com/apache/brooklyn-server/pull/490.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/490.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/490","number":490,"state":"open","locked":false,"title":"Fix BROOKLYN-410: rebind locations from bundles","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"Builds on https://github.com/apache/brooklyn-server/pull/489 - please review and merge that first; then I'll rebase (which will make the first commit disappear).","created_at":"2016-12-14T15:35:58Z","updated_at":"2016-12-16T15:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58d101bbb34538575e434cdb9e57d8111d909b84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/490/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/490/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/490/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/0691b20b52c3f1e437725b5f7ddc53d4a43090fc","head":{"label":"aledsage:BROOKLYN-410","ref":"BROOKLYN-410","sha":"0691b20b52c3f1e437725b5f7ddc53d4a43090fc","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"repo":{"id":50909018,"name":"brooklyn-server","full_name":"aledsage/brooklyn-server","owner":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledsage/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/aledsage/brooklyn-server","forks_url":"https://api.github.com/repos/aledsage/brooklyn-server/forks","keys_url":"https://api.github.com/repos/aledsage/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledsage/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledsage/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/aledsage/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/aledsage/brooklyn-server/events","assignees_url":"https://api.github.com/repos/aledsage/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/aledsage/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledsage/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aledsage/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/aledsage/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/aledsage/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledsage/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledsage/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/aledsage/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledsage/brooklyn-server/merges","archive_url":"https://api.github.com/repos/aledsage/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledsage/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/aledsage/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aledsage/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aledsage/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledsage/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/aledsage/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/aledsage/brooklyn-server/deployments","created_at":"2016-02-02T09:23:44Z","updated_at":"2016-02-02T09:23:52Z","pushed_at":"2016-12-14T15:34:47Z","git_url":"git://github.com/aledsage/brooklyn-server.git","ssh_url":"git@github.com:aledsage/brooklyn-server.git","clone_url":"https://github.com/aledsage/brooklyn-server.git","svn_url":"https://github.com/aledsage/brooklyn-server","homepage":null,"size":32461,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b034a2727a6f6b1853008568814c057b3ea6f84f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-12-12T18:20:35Z","pushed_at":"2016-12-16T11:56:42Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":32392,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":27,"forks":40,"open_issues":27,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/490"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/490"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/490"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/0691b20b52c3f1e437725b5f7ddc53d4a43090fc"}}}}
{"actor":{"display_login":"neykov"}}