{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1","id":89571530,"html_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1","diff_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1.diff","patch_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1.patch","issue_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1","number":1,"state":"closed","locked":false,"title":"Refactor","user":{"login":"indiesquidge","id":3409645,"avatar_url":"https://avatars.githubusercontent.com/u/3409645?v=3","gravatar_id":"","url":"https://api.github.com/users/indiesquidge","html_url":"https://github.com/indiesquidge","followers_url":"https://api.github.com/users/indiesquidge/followers","following_url":"https://api.github.com/users/indiesquidge/following{/other_user}","gists_url":"https://api.github.com/users/indiesquidge/gists{/gist_id}","starred_url":"https://api.github.com/users/indiesquidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiesquidge/subscriptions","organizations_url":"https://api.github.com/users/indiesquidge/orgs","repos_url":"https://api.github.com/users/indiesquidge/repos","events_url":"https://api.github.com/users/indiesquidge/events{/privacy}","received_events_url":"https://api.github.com/users/indiesquidge/received_events","type":"User","site_admin":false},"body":"Hey @FoxHax,\r\n\r\nLove this Firewatch clock you made here. I took a look around the project and decided to do just a bit of refactoring. I'd love to know how you feel about the changes I've made!\r\n\r\n## Changes\r\n\r\n#### JavaScript\r\n\r\nRefactored `clock.js` to be more readable, maintainable, and declarative by separating it's functionality into named functions. Biggest thing here was making the `updateClock` function more concise and easier to understand.\r\n\r\nOne thing I intentionally removed was the `setTimeout` that was run every millisecond for the whole `updateClock` function. While this does exterminate the benefit of having the clock remain up to date to the second on the browser (well, millisecond even), it alleviates the need to repaint the background image, find the DOM elements, update the DOM elements, etc., which was happening *tens of thousands of times per second*. Now, perhaps we could discuss the best possible way for only the actual updates to run in a `setTimeout` (i.e, updating `wordClockElem`, `digitalClockElem`, and the `document.title`), but I personally think it's fine without the `setTimeout`.\r\n\r\n#### HTML\r\n\r\nThe updates made to this file are mostly just indentation. I updated the © to be more semantic and accessible by wrapping it in a `<span>`. The really change was using an SVG as the banner ribbon instead of a static image. Not only does this look sharper on the screen, but it saves us a full HTTP request since we no longer have an image to fetch. I also updated the favicon to be more retina display friendly.\r\n\r\n#### CSS\r\n\r\nOnly real change here was the necessary updates to the `.ribbon` class, which is now an SVG element.\r\n\r\n---\r\n\r\n### For the Future\r\n\r\n- The main thing I'd still like to do is make this mobile-friendly.\r\n- I am also working on porting it over to a be a Chrome Plugin Extension for new tabs.\r\n- Having a different background image for `Day.jpg` would be nice, considering it's the same image as `Sunset.jpg`, only with a slightly different shade\r\n\r\nThat's all for now! Thanks again for making this awesome little clock, man :)\r\n\r\nHuge fan of the game 💛 \r\n\r\n#Hacktoberfest\r\n\r\n– Austin","created_at":"2016-10-17T07:15:22Z","updated_at":"2016-10-17T07:24:49Z","closed_at":"2016-10-17T07:24:49Z","merged_at":"2016-10-17T07:24:49Z","merge_commit_sha":"6b3d3ff15bad512491c5bdb87ac8ee39f5a4cf28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1/commits","review_comments_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1/comments","review_comment_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1/comments","statuses_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/statuses/d57cdd8fad71c0ea90390370a0fdb0338bb2fa07","head":{"label":"indiesquidge:refactor","ref":"refactor","sha":"d57cdd8fad71c0ea90390370a0fdb0338bb2fa07","user":{"login":"indiesquidge","id":3409645,"avatar_url":"https://avatars.githubusercontent.com/u/3409645?v=3","gravatar_id":"","url":"https://api.github.com/users/indiesquidge","html_url":"https://github.com/indiesquidge","followers_url":"https://api.github.com/users/indiesquidge/followers","following_url":"https://api.github.com/users/indiesquidge/following{/other_user}","gists_url":"https://api.github.com/users/indiesquidge/gists{/gist_id}","starred_url":"https://api.github.com/users/indiesquidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiesquidge/subscriptions","organizations_url":"https://api.github.com/users/indiesquidge/orgs","repos_url":"https://api.github.com/users/indiesquidge/repos","events_url":"https://api.github.com/users/indiesquidge/events{/privacy}","received_events_url":"https://api.github.com/users/indiesquidge/received_events","type":"User","site_admin":false},"repo":{"id":71108202,"name":"FoxHax.github.io","full_name":"indiesquidge/FoxHax.github.io","owner":{"login":"indiesquidge","id":3409645,"avatar_url":"https://avatars.githubusercontent.com/u/3409645?v=3","gravatar_id":"","url":"https://api.github.com/users/indiesquidge","html_url":"https://github.com/indiesquidge","followers_url":"https://api.github.com/users/indiesquidge/followers","following_url":"https://api.github.com/users/indiesquidge/following{/other_user}","gists_url":"https://api.github.com/users/indiesquidge/gists{/gist_id}","starred_url":"https://api.github.com/users/indiesquidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiesquidge/subscriptions","organizations_url":"https://api.github.com/users/indiesquidge/orgs","repos_url":"https://api.github.com/users/indiesquidge/repos","events_url":"https://api.github.com/users/indiesquidge/events{/privacy}","received_events_url":"https://api.github.com/users/indiesquidge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indiesquidge/FoxHax.github.io","description":"My website","fork":true,"url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io","forks_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/forks","keys_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/teams","hooks_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/hooks","issue_events_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/events","assignees_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/tags","blobs_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/languages","stargazers_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/stargazers","contributors_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/contributors","subscribers_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/subscribers","subscription_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/subscription","commits_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/merges","archive_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/downloads","issues_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/labels{/name}","releases_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/indiesquidge/FoxHax.github.io/deployments","created_at":"2016-10-17T06:48:26Z","updated_at":"2016-10-17T06:48:28Z","pushed_at":"2016-10-17T06:49:18Z","git_url":"git://github.com/indiesquidge/FoxHax.github.io.git","ssh_url":"git@github.com:indiesquidge/FoxHax.github.io.git","clone_url":"https://github.com/indiesquidge/FoxHax.github.io.git","svn_url":"https://github.com/indiesquidge/FoxHax.github.io","homepage":null,"size":3803,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FoxHax:master","ref":"master","sha":"083a7310e1904ea747279586f063c708ffde9676","user":{"login":"FoxHax","id":5136714,"avatar_url":"https://avatars.githubusercontent.com/u/5136714?v=3","gravatar_id":"","url":"https://api.github.com/users/FoxHax","html_url":"https://github.com/FoxHax","followers_url":"https://api.github.com/users/FoxHax/followers","following_url":"https://api.github.com/users/FoxHax/following{/other_user}","gists_url":"https://api.github.com/users/FoxHax/gists{/gist_id}","starred_url":"https://api.github.com/users/FoxHax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoxHax/subscriptions","organizations_url":"https://api.github.com/users/FoxHax/orgs","repos_url":"https://api.github.com/users/FoxHax/repos","events_url":"https://api.github.com/users/FoxHax/events{/privacy}","received_events_url":"https://api.github.com/users/FoxHax/received_events","type":"User","site_admin":false},"repo":{"id":53828770,"name":"FoxHax.github.io","full_name":"FoxHax/FoxHax.github.io","owner":{"login":"FoxHax","id":5136714,"avatar_url":"https://avatars.githubusercontent.com/u/5136714?v=3","gravatar_id":"","url":"https://api.github.com/users/FoxHax","html_url":"https://github.com/FoxHax","followers_url":"https://api.github.com/users/FoxHax/followers","following_url":"https://api.github.com/users/FoxHax/following{/other_user}","gists_url":"https://api.github.com/users/FoxHax/gists{/gist_id}","starred_url":"https://api.github.com/users/FoxHax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoxHax/subscriptions","organizations_url":"https://api.github.com/users/FoxHax/orgs","repos_url":"https://api.github.com/users/FoxHax/repos","events_url":"https://api.github.com/users/FoxHax/events{/privacy}","received_events_url":"https://api.github.com/users/FoxHax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FoxHax/FoxHax.github.io","description":"My website","fork":false,"url":"https://api.github.com/repos/FoxHax/FoxHax.github.io","forks_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/forks","keys_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/teams","hooks_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/hooks","issue_events_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/events","assignees_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/tags","blobs_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/languages","stargazers_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/stargazers","contributors_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/contributors","subscribers_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/subscribers","subscription_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/subscription","commits_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/merges","archive_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/downloads","issues_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/labels{/name}","releases_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/deployments","created_at":"2016-03-14T05:15:50Z","updated_at":"2016-03-14T05:17:48Z","pushed_at":"2016-10-17T07:24:49Z","git_url":"git://github.com/FoxHax/FoxHax.github.io.git","ssh_url":"git@github.com:FoxHax/FoxHax.github.io.git","clone_url":"https://github.com/FoxHax/FoxHax.github.io.git","svn_url":"https://github.com/FoxHax/FoxHax.github.io","homepage":null,"size":3803,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1"},"html":{"href":"https://github.com/FoxHax/FoxHax.github.io/pull/1"},"issue":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1"},"comments":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/FoxHax/FoxHax.github.io/statuses/d57cdd8fad71c0ea90390370a0fdb0338bb2fa07"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"FoxHax","id":5136714,"avatar_url":"https://avatars.githubusercontent.com/u/5136714?v=3","gravatar_id":"","url":"https://api.github.com/users/FoxHax","html_url":"https://github.com/FoxHax","followers_url":"https://api.github.com/users/FoxHax/followers","following_url":"https://api.github.com/users/FoxHax/following{/other_user}","gists_url":"https://api.github.com/users/FoxHax/gists{/gist_id}","starred_url":"https://api.github.com/users/FoxHax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoxHax/subscriptions","organizations_url":"https://api.github.com/users/FoxHax/orgs","repos_url":"https://api.github.com/users/FoxHax/repos","events_url":"https://api.github.com/users/FoxHax/events{/privacy}","received_events_url":"https://api.github.com/users/FoxHax/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":109,"deletions":149,"changed_files":11}}
{"actor":{"display_login":"FoxHax"}}