{"action":"created","issue":{"url":"https://api.github.com/repos/lxde/libfm-qt/issues/41","repository_url":"https://api.github.com/repos/lxde/libfm-qt","labels_url":"https://api.github.com/repos/lxde/libfm-qt/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/lxde/libfm-qt/issues/41/comments","events_url":"https://api.github.com/repos/lxde/libfm-qt/issues/41/events","html_url":"https://github.com/lxde/libfm-qt/pull/41","id":179473139,"number":41,"title":"Also Consider GEmblemedIcon","user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars.githubusercontent.com/u/981076?v=3","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-27T11:58:37Z","updated_at":"2016-09-28T11:26:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lxde/libfm-qt/pulls/41","html_url":"https://github.com/lxde/libfm-qt/pull/41","diff_url":"https://github.com/lxde/libfm-qt/pull/41.diff","patch_url":"https://github.com/lxde/libfm-qt/pull/41.patch"},"body":"Fixes https://github.com/lxde/pcmanfm-qt/issues/400\r\n\r\nGEmblemedIcon wasn't handled by `IconTheme::convertFromGIcon()` (in icontheme.cpp)."},"comment":{"url":"https://api.github.com/repos/lxde/libfm-qt/issues/comments/250140781","html_url":"https://github.com/lxde/libfm-qt/pull/41#issuecomment-250140781","issue_url":"https://api.github.com/repos/lxde/libfm-qt/issues/41","id":250140781,"user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars.githubusercontent.com/u/981076?v=3","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T11:26:26Z","updated_at":"2016-09-28T11:26:26Z","body":"I experimented with emblems for two hours but the results weren't encouraging:\r\n\r\nUnfortunately, it seems that gvfs emblem info is ignored by libfm, so that my dream of optional emblems couldn't come true unless large changes are made to libfm :(\r\n\r\nOn the other hand, although adding emblems to encrypted volumes is easy in the way @palinek suggested, there's a serious problem that can't be solved with the current structure of the code: items don't have a size hint. In simple words, only *fixed size* emblems are possible, which are senseless because the icon size can be changed by pcmanfm-qt's preferences.\r\n\r\nI may attack these problems later again but, for now, this PR seems to be the best solution."}}
{"actor":{"display_login":"tsujan"}}