{"action":"created","comment":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/93769720","pull_request_review_id":14304872,"id":93769720,"diff_hunk":"@@ -1059,56 +1076,56 @@ shutdown(Pid, brutal_kill) ->\n \t\t    ok;\n \t\t{'DOWN', _MRef, process, Pid, OtherReason} ->\n \t\t    {error, OtherReason}\n-\t    end;\n-\t{error, Reason} ->      \n+        end;\n+\t{error, Reason} ->\n \t    {error, Reason}\n     end;\n shutdown(Pid, Time) ->\n     case monitor_child(Pid) of\n \tok ->\n \t    exit(Pid, shutdown), %% Try to shutdown gracefully\n-\t    receive \n+        receive\n \t\t{'DOWN', _MRef, process, Pid, shutdown} ->\n \t\t    ok;\n-\t\t{'DOWN', _MRef, process, Pid, OtherReason} ->\n+        {'DOWN', _MRef, process, Pid, OtherReason} ->\n \t\t    {error, OtherReason}\n \t    after Time ->\n \t\t    exit(Pid, kill),  %% Force termination.\n \t\t    receive\n \t\t\t{'DOWN', _MRef, process, Pid, OtherReason} ->\n-\t\t\t    {error, OtherReason}\n+                {error, OtherReason}\n \t\t    end\n \t    end;\n-\t{error, Reason} ->      \n+    {error, Reason} ->\n \t    {error, Reason}\n     end.\n \n %% Help function to shutdown/2 switches from link to monitor approach\n monitor_child(Pid) ->\n-    \n-    %% Do the monitor operation first so that if the child dies \n+\n+    %% Do the monitor operation first so that if the child dies\n     %% before the monitoring is done causing a 'DOWN'-message with\n     %% reason noproc, we will get the real reason in the 'EXIT'-message\n     %% unless a naughty child has already done unlink...\n     erlang:monitor(process, Pid),\n     unlink(Pid),\n \n     receive\n-\t%% If the child dies before the unlik we must empty\n-\t%% the mail-box of the 'EXIT'-message and the 'DOWN'-message.\n-\t{'EXIT', Pid, Reason} -> \n-\t    receive \n+    %% If the child dies before the unlik we must empty\n+    %% the mail-box of the 'EXIT'-message and the 'DOWN'-message.\n+\t{'EXIT', Pid, Reason} ->\n+        receive\n \t\t{'DOWN', _, process, Pid, _} ->\n \t\t    {error, Reason}","path":"apps/ejabberd/src/supervisor2.erl","position":182,"original_position":182,"commit_id":"8becb813c5f489856af97890a6effec2294f682e","original_commit_id":"8becb813c5f489856af97890a6effec2294f682e","user":{"login":"gadgetci","id":10134338,"avatar_url":"https://avatars.githubusercontent.com/u/10134338?v=3","gravatar_id":"","url":"https://api.github.com/users/gadgetci","html_url":"https://github.com/gadgetci","followers_url":"https://api.github.com/users/gadgetci/followers","following_url":"https://api.github.com/users/gadgetci/following{/other_user}","gists_url":"https://api.github.com/users/gadgetci/gists{/gist_id}","starred_url":"https://api.github.com/users/gadgetci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadgetci/subscriptions","organizations_url":"https://api.github.com/users/gadgetci/orgs","repos_url":"https://api.github.com/users/gadgetci/repos","events_url":"https://api.github.com/users/gadgetci/events{/privacy}","received_events_url":"https://api.github.com/users/gadgetci/received_events","type":"User","site_admin":false},"body":"According to **Elvis**:\n> Line 1119 has a tab at column 0.","created_at":"2016-12-23T14:16:13Z","updated_at":"2016-12-23T14:16:13Z","html_url":"https://github.com/esl/MongooseIM/pull/1132#discussion_r93769720","pull_request_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/93769720"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1132#discussion_r93769720"},"pull_request":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/1132","id":99245300,"html_url":"https://github.com/esl/MongooseIM/pull/1132","diff_url":"https://github.com/esl/MongooseIM/pull/1132.diff","patch_url":"https://github.com/esl/MongooseIM/pull/1132.patch","issue_url":"https://api.github.com/repos/esl/MongooseIM/issues/1132","number":1132,"state":"open","locked":false,"title":"Feature/improve cassandra performance","user":{"login":"rslota","id":1565663,"avatar_url":"https://avatars.githubusercontent.com/u/1565663?v=3","gravatar_id":"","url":"https://api.github.com/users/rslota","html_url":"https://github.com/rslota","followers_url":"https://api.github.com/users/rslota/followers","following_url":"https://api.github.com/users/rslota/following{/other_user}","gists_url":"https://api.github.com/users/rslota/gists{/gist_id}","starred_url":"https://api.github.com/users/rslota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rslota/subscriptions","organizations_url":"https://api.github.com/users/rslota/orgs","repos_url":"https://api.github.com/users/rslota/repos","events_url":"https://api.github.com/users/rslota/events{/privacy}","received_events_url":"https://api.github.com/users/rslota/received_events","type":"User","site_admin":false},"body":"This PR changes cassandra's client library to cqerl which is better supported by community then seestar. Also there are some changes in cassandra DB schema in order to improve query performance. \r\n\r\n","created_at":"2016-12-23T13:59:12Z","updated_at":"2016-12-23T14:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92bcec4df800434b3e2c06156b128fb68c1335ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esl/MongooseIM/issues/1132/comments","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/8becb813c5f489856af97890a6effec2294f682e","head":{"label":"esl:feature/improve-cassandra-performance","ref":"feature/improve-cassandra-performance","sha":"8becb813c5f489856af97890a6effec2294f682e","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2016-12-23T08:24:58Z","pushed_at":"2016-12-23T14:15:51Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":21896,"stargazers_count":636,"watchers_count":636,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":89,"forks":246,"open_issues":89,"watchers":636,"default_branch":"master"}},"base":{"label":"esl:master","ref":"master","sha":"c91cd625bfef2b4bb86394a75792b09dc0312a9e","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2016-12-23T08:24:58Z","pushed_at":"2016-12-23T14:15:51Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":21896,"stargazers_count":636,"watchers_count":636,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":89,"forks":246,"open_issues":89,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1132"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1132"},"issue":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1132"},"comments":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/esl/MongooseIM/statuses/8becb813c5f489856af97890a6effec2294f682e"}}}}
{"actor":{"display_login":"gadgetci"}}