{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75565930","id":75565930,"diff_hunk":"@@ -328,6 +354,24 @@ func (plugin *kubenetNetworkPlugin) setup(namespace string, name string, id kube\n \t\t\t\treturn fmt.Errorf(\"Error setting promiscuous mode on %s: %v\", BridgeName, err)\n \t\t\t}\n \t\t}\n+\n+\t\t// configure the ebtables rules to eliminate duplicate packets by best effort\n+\t\tebtablesPath, err := plugin.ebtables()\n+\t\tif err != nil {\n+\t\t\tglog.Warningf(\"Failed to get ebtables path: %v\", err)\n+\t\t} else {\n+\t\t\tglog.Infof(\"Filtering packets with ebtables on mac address: %v, gateway: %v, pod CIDR: %v\", macAddr.String(), plugin.gateway.String(), plugin.podCidr)","path":"pkg/kubelet/network/kubenet/kubenet_linux.go","position":78,"original_position":78,"commit_id":"c8992c0a2bcfb216c073c03ff6cc551915f99003","original_commit_id":"c8992c0a2bcfb216c073c03ff6cc551915f99003","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"This is only for promiscuous mode. \r\n\r\nWe can e2e this by setting up a udp server pod and check if requests comes in with duplicates","created_at":"2016-08-19T23:44:09Z","updated_at":"2016-08-19T23:44:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28717#discussion_r75565930","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75565930"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28717#discussion_r75565930"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717","id":76823042,"html_url":"https://github.com/kubernetes/kubernetes/pull/28717","diff_url":"https://github.com/kubernetes/kubernetes/pull/28717.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28717.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28717","number":28717,"state":"open","locked":false,"title":"use ebtables to filter duplicate network packets in promiscuous bridge mode","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"also fixes: #30783\r\n\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/28717)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-07-08T22:28:41Z","updated_at":"2016-08-19T23:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f8702d7643f83e5c91c6ab187cbaf4436cc67c","assignee":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"assignees":[{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"https://github.com/kubernetes/features/blob/master/release-1.4/Release-1.4.md","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":240,"closed_issues":261,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-08-19T23:05:04Z","due_on":"2016-09-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28717/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c8992c0a2bcfb216c073c03ff6cc551915f99003","head":{"label":"freehan:ebtable","ref":"ebtable","sha":"c8992c0a2bcfb216c073c03ff6cc551915f99003","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"repo":{"id":45570688,"name":"kubernetes","full_name":"freehan/kubernetes","owner":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freehan/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/freehan/kubernetes","forks_url":"https://api.github.com/repos/freehan/kubernetes/forks","keys_url":"https://api.github.com/repos/freehan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freehan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freehan/kubernetes/teams","hooks_url":"https://api.github.com/repos/freehan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/freehan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/freehan/kubernetes/events","assignees_url":"https://api.github.com/repos/freehan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/freehan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/freehan/kubernetes/tags","blobs_url":"https://api.github.com/repos/freehan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freehan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freehan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/freehan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freehan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/freehan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/freehan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/freehan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/freehan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/freehan/kubernetes/subscription","commits_url":"https://api.github.com/repos/freehan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/freehan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/freehan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/freehan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/freehan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/freehan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freehan/kubernetes/merges","archive_url":"https://api.github.com/repos/freehan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freehan/kubernetes/downloads","issues_url":"https://api.github.com/repos/freehan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/freehan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/freehan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/freehan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freehan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/freehan/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/freehan/kubernetes/deployments","created_at":"2015-11-04T22:09:37Z","updated_at":"2016-01-13T01:28:27Z","pushed_at":"2016-08-19T22:59:16Z","git_url":"git://github.com/freehan/kubernetes.git","ssh_url":"git@github.com:freehan/kubernetes.git","clone_url":"https://github.com/freehan/kubernetes.git","svn_url":"https://github.com/freehan/kubernetes","homepage":"http://kubernetes.io","size":312594,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"529edae1f692492072c3c636e73f708f4fd16d97","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-19T20:16:47Z","pushed_at":"2016-08-19T23:42:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":534038,"stargazers_count":16212,"watchers_count":16212,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5200,"mirror_url":null,"open_issues_count":4258,"forks":5200,"open_issues":4258,"watchers":16212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28717"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28717"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28717/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28717/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c8992c0a2bcfb216c073c03ff6cc551915f99003"}}}}
{"actor":{"display_login":"freehan"}}