{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/69196208","id":69196208,"diff_hunk":"@@ -298,18 +298,12 @@ private Global(Optional<Partitioning> nodePartitioning, Optional<Partitioning> s\n \n         public static Global coordinatorSingleStreamPartition()\n         {\n-            return partitionedOn(\n-                    COORDINATOR_DISTRIBUTION,\n-                    ImmutableList.of(),","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/optimizations/ActualProperties.java","position":19,"original_position":19,"commit_id":"4934adfb1262c0c94ff254b49a88258ab05ac487","original_commit_id":"f9d6ee29bb606b8795d5c0064741065a917f7f7b","user":{"login":"erichwang","id":737851,"avatar_url":"https://avatars.githubusercontent.com/u/737851?v=3","gravatar_id":"","url":"https://api.github.com/users/erichwang","html_url":"https://github.com/erichwang","followers_url":"https://api.github.com/users/erichwang/followers","following_url":"https://api.github.com/users/erichwang/following{/other_user}","gists_url":"https://api.github.com/users/erichwang/gists{/gist_id}","starred_url":"https://api.github.com/users/erichwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichwang/subscriptions","organizations_url":"https://api.github.com/users/erichwang/orgs","repos_url":"https://api.github.com/users/erichwang/repos","events_url":"https://api.github.com/users/erichwang/events{/privacy}","received_events_url":"https://api.github.com/users/erichwang/received_events","type":"User","site_admin":false},"body":"the property of empty partitioning columns for single partitions needs to be maintained, otherwise we will lose quite a bit of inference power","created_at":"2016-06-30T19:35:37Z","updated_at":"2016-06-30T19:35:37Z","html_url":"https://github.com/prestodb/presto/pull/5484#discussion_r69196208","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/5484","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/69196208"},"html":{"href":"https://github.com/prestodb/presto/pull/5484#discussion_r69196208"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5484"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/5484","id":74536757,"html_url":"https://github.com/prestodb/presto/pull/5484","diff_url":"https://github.com/prestodb/presto/pull/5484.diff","patch_url":"https://github.com/prestodb/presto/pull/5484.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/5484","number":5484,"state":"open","locked":false,"title":"Capture partition count in Plan","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"body":"When local parallel is enabled, the coordinator creates a query plan that\nrequires parallel execution, but parallelism is set on each working using\nthe task concurrency property.  If the coordinator and worker have\ndifferent settings for this property, the execution can fail.\n\nInstead of dividing the parallelism planning between the coordinator and\nthe worker, the coordinator makes the decision and records this in the\nplan.","created_at":"2016-06-21T00:56:38Z","updated_at":"2016-06-30T19:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d4fd8c3f6a657771f640e4cc10fe7fad08669f4","assignee":{"login":"erichwang","id":737851,"avatar_url":"https://avatars.githubusercontent.com/u/737851?v=3","gravatar_id":"","url":"https://api.github.com/users/erichwang","html_url":"https://github.com/erichwang","followers_url":"https://api.github.com/users/erichwang/followers","following_url":"https://api.github.com/users/erichwang/following{/other_user}","gists_url":"https://api.github.com/users/erichwang/gists{/gist_id}","starred_url":"https://api.github.com/users/erichwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichwang/subscriptions","organizations_url":"https://api.github.com/users/erichwang/orgs","repos_url":"https://api.github.com/users/erichwang/repos","events_url":"https://api.github.com/users/erichwang/events{/privacy}","received_events_url":"https://api.github.com/users/erichwang/received_events","type":"User","site_admin":false},"assignees":[{"login":"erichwang","id":737851,"avatar_url":"https://avatars.githubusercontent.com/u/737851?v=3","gravatar_id":"","url":"https://api.github.com/users/erichwang","html_url":"https://github.com/erichwang","followers_url":"https://api.github.com/users/erichwang/followers","following_url":"https://api.github.com/users/erichwang/following{/other_user}","gists_url":"https://api.github.com/users/erichwang/gists{/gist_id}","starred_url":"https://api.github.com/users/erichwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichwang/subscriptions","organizations_url":"https://api.github.com/users/erichwang/orgs","repos_url":"https://api.github.com/users/erichwang/repos","events_url":"https://api.github.com/users/erichwang/events{/privacy}","received_events_url":"https://api.github.com/users/erichwang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/5484/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/5484/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/5484/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/4934adfb1262c0c94ff254b49a88258ab05ac487","head":{"label":"dain:plan-partition-count","ref":"plan-partition-count","sha":"4934adfb1262c0c94ff254b49a88258ab05ac487","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"repo":{"id":5403482,"name":"presto","full_name":"dain/presto","owner":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dain/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/dain/presto","forks_url":"https://api.github.com/repos/dain/presto/forks","keys_url":"https://api.github.com/repos/dain/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dain/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dain/presto/teams","hooks_url":"https://api.github.com/repos/dain/presto/hooks","issue_events_url":"https://api.github.com/repos/dain/presto/issues/events{/number}","events_url":"https://api.github.com/repos/dain/presto/events","assignees_url":"https://api.github.com/repos/dain/presto/assignees{/user}","branches_url":"https://api.github.com/repos/dain/presto/branches{/branch}","tags_url":"https://api.github.com/repos/dain/presto/tags","blobs_url":"https://api.github.com/repos/dain/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dain/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dain/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dain/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dain/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/dain/presto/languages","stargazers_url":"https://api.github.com/repos/dain/presto/stargazers","contributors_url":"https://api.github.com/repos/dain/presto/contributors","subscribers_url":"https://api.github.com/repos/dain/presto/subscribers","subscription_url":"https://api.github.com/repos/dain/presto/subscription","commits_url":"https://api.github.com/repos/dain/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dain/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dain/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dain/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dain/presto/contents/{+path}","compare_url":"https://api.github.com/repos/dain/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dain/presto/merges","archive_url":"https://api.github.com/repos/dain/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dain/presto/downloads","issues_url":"https://api.github.com/repos/dain/presto/issues{/number}","pulls_url":"https://api.github.com/repos/dain/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/dain/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/dain/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dain/presto/labels{/name}","releases_url":"https://api.github.com/repos/dain/presto/releases{/id}","deployments_url":"https://api.github.com/repos/dain/presto/deployments","created_at":"2012-08-13T19:14:12Z","updated_at":"2015-06-24T10:03:33Z","pushed_at":"2016-06-29T02:12:10Z","git_url":"git://github.com/dain/presto.git","ssh_url":"git@github.com:dain/presto.git","clone_url":"https://github.com/dain/presto.git","svn_url":"https://github.com/dain/presto","homepage":"http://prestodb.io/","size":56933,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"dfa3e9191657f8aec85c47caebb103240fae4688","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-06-30T19:21:16Z","pushed_at":"2016-06-30T18:42:19Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":156452,"stargazers_count":4873,"watchers_count":4873,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1461,"mirror_url":null,"open_issues_count":562,"forks":1461,"open_issues":562,"watchers":4873,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5484"},"html":{"href":"https://github.com/prestodb/presto/pull/5484"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/5484"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/5484/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5484/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5484/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/4934adfb1262c0c94ff254b49a88258ab05ac487"}}}}
{"actor":{"display_login":"erichwang"}}