{"action":"created","issue":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/107","repository_url":"https://api.github.com/repos/MoMEMta/MoMEMta","labels_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/107/comments","events_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/107/events","html_url":"https://github.com/MoMEMta/MoMEMta/pull/107","id":181450321,"number":107,"title":"CMSSW support","user":{"login":"blinkseb","id":386274,"avatar_url":"https://avatars.githubusercontent.com/u/386274?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkseb","html_url":"https://github.com/blinkseb","followers_url":"https://api.github.com/users/blinkseb/followers","following_url":"https://api.github.com/users/blinkseb/following{/other_user}","gists_url":"https://api.github.com/users/blinkseb/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkseb/subscriptions","organizations_url":"https://api.github.com/users/blinkseb/orgs","repos_url":"https://api.github.com/users/blinkseb/repos","events_url":"https://api.github.com/users/blinkseb/events{/privacy}","received_events_url":"https://api.github.com/users/blinkseb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/labels/ready%20for%20review%20/%20comments","name":"ready for review / comments","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-06T15:36:53Z","updated_at":"2016-10-10T09:24:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/107","html_url":"https://github.com/MoMEMta/MoMEMta/pull/107","diff_url":"https://github.com/MoMEMta/MoMEMta/pull/107.diff","patch_url":"https://github.com/MoMEMta/MoMEMta/pull/107.patch"},"body":"This PR adds basic support for CMSSW:\r\n\r\n  1. Cmake automatically detects the presence of a CMSSW env. and reacts accordingly by using LHAPDF and boost from the release instead of the system.\r\n 2. When running install, MoMEMta is registered as a new tool inside the current release, which mean that any package can add MoMEMta as a dependency in their BuildFile.xml and use MoMEMta transparently\r\n\r\nThe main change here is that CMSSW does not ship Boost::log. In order to overcome this, I added a no-op logger used in case Boost::log is not present, which mean that there's *no* logging at all. A warning is issued during the cmake phase in this case.\r\n\r\nI'm starting to think it may be good to drop boost::log for the logging as it's a bit of pain to manage, and maybe a bit overcomplicated for our needs...? But that's for another PR "},"comment":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/comments/252570579","html_url":"https://github.com/MoMEMta/MoMEMta/pull/107#issuecomment-252570579","issue_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/107","id":252570579,"user":{"login":"blinkseb","id":386274,"avatar_url":"https://avatars.githubusercontent.com/u/386274?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkseb","html_url":"https://github.com/blinkseb","followers_url":"https://api.github.com/users/blinkseb/followers","following_url":"https://api.github.com/users/blinkseb/following{/other_user}","gists_url":"https://api.github.com/users/blinkseb/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkseb/subscriptions","organizations_url":"https://api.github.com/users/blinkseb/orgs","repos_url":"https://api.github.com/users/blinkseb/repos","events_url":"https://api.github.com/users/blinkseb/events{/privacy}","received_events_url":"https://api.github.com/users/blinkseb/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T09:24:49Z","updated_at":"2016-10-10T09:24:49Z","body":"IMO it's near impossible. It tooks almost two months just to add scikit into CMSSW, and it's well motivated. I don't think they will allow a new lib just for MoMEMta.\r\n\r\nI'll remove the `NO_LOGGING` option, and fix the rest :+1: "}}
{"actor":{"display_login":"blinkseb"}}