{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/78619569","id":78619569,"diff_hunk":"@@ -34,19 +35,19 @@\n     </li>\n </%def>\n \n-<div class=\"forum-nav-browse-menu-wrapper\" style=\"display: none\">\n+<div class=\"forum-nav-browse-menu-wrapper\" style=\"display: none\" role=\"combobox\" aria-label=\"${_(\"Discussion thread list\")}\" aria-expanded=\"true\" aria-owns=\"discussion_topics_listbox\">","path":"lms/templates/discussion/_filter_dropdown.html","position":13,"original_position":13,"commit_id":"05d886f80c2ef710f139ade7ea6574199ad515a1","original_commit_id":"05d886f80c2ef710f139ade7ea6574199ad515a1","user":{"login":"cptvitamin","id":444368,"avatar_url":"https://avatars.githubusercontent.com/u/444368?v=3","gravatar_id":"","url":"https://api.github.com/users/cptvitamin","html_url":"https://github.com/cptvitamin","followers_url":"https://api.github.com/users/cptvitamin/followers","following_url":"https://api.github.com/users/cptvitamin/following{/other_user}","gists_url":"https://api.github.com/users/cptvitamin/gists{/gist_id}","starred_url":"https://api.github.com/users/cptvitamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptvitamin/subscriptions","organizations_url":"https://api.github.com/users/cptvitamin/orgs","repos_url":"https://api.github.com/users/cptvitamin/repos","events_url":"https://api.github.com/users/cptvitamin/events{/privacy}","received_events_url":"https://api.github.com/users/cptvitamin/received_events","type":"User","site_admin":false},"body":"@alisan617 I believe the role=combobox, aria-expanded, and aria-owns should be in the input type=text below, which means you can remove the aria-label on this div.","created_at":"2016-09-13T18:42:37Z","updated_at":"2016-09-13T18:42:37Z","html_url":"https://github.com/edx/edx-platform/pull/13449#discussion_r78619569","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13449","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/78619569"},"html":{"href":"https://github.com/edx/edx-platform/pull/13449#discussion_r78619569"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13449"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13449","id":84941262,"html_url":"https://github.com/edx/edx-platform/pull/13449","diff_url":"https://github.com/edx/edx-platform/pull/13449.diff","patch_url":"https://github.com/edx/edx-platform/pull/13449.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13449","number":13449,"state":"open","locked":false,"title":"Add aria attributes to discussion topics sidebar","user":{"login":"alisan617","id":16127998,"avatar_url":"https://avatars.githubusercontent.com/u/16127998?v=3","gravatar_id":"","url":"https://api.github.com/users/alisan617","html_url":"https://github.com/alisan617","followers_url":"https://api.github.com/users/alisan617/followers","following_url":"https://api.github.com/users/alisan617/following{/other_user}","gists_url":"https://api.github.com/users/alisan617/gists{/gist_id}","starred_url":"https://api.github.com/users/alisan617/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisan617/subscriptions","organizations_url":"https://api.github.com/users/alisan617/orgs","repos_url":"https://api.github.com/users/alisan617/repos","events_url":"https://api.github.com/users/alisan617/events{/privacy}","received_events_url":"https://api.github.com/users/alisan617/received_events","type":"User","site_admin":false},"body":"[TNL-5169](https://openedx.atlassian.net/browse/TNL-5169)\r\n\r\n## Description\r\n\r\n- Add accessibility attributes to the discussion sidebar \"combobox\"\r\n- Fix the mouseover white background top alignment with the grey border in the unordered list\r\n\r\n[Sandbox] (https://discussion-combobox.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/discussion/forum/)\r\n\r\n## Testing\r\n- [x] i18n\r\n- [x] RTL\r\n- [ ] safecommit violation code review process\r\n\r\n\r\n## Reviewers\r\n- [ ] a11y review: @cptvitamin \r\n- [ ] Code review: @andy-armstrong \r\n- [ ] Code review: @bjacobel \r\n\r\n<img width=\"382\" alt=\"before\" src=\"https://cloud.githubusercontent.com/assets/16127998/18452228/1cf10e66-7908-11e6-82f4-b9b614b9ab21.png\">\r\n","created_at":"2016-09-12T20:44:21Z","updated_at":"2016-09-13T18:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d56f48796b56b0ad090020282373888a42526e47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13449/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13449/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13449/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/05d886f80c2ef710f139ade7ea6574199ad515a1","head":{"label":"edx:alisan/discussion-sidebar-topics-menu-TNL-5169","ref":"alisan/discussion-sidebar-topics-menu-TNL-5169","sha":"05d886f80c2ef710f139ade7ea6574199ad515a1","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-09-13T17:27:31Z","pushed_at":"2016-09-13T18:38:21Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":823334,"stargazers_count":2766,"watchers_count":2766,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1660,"mirror_url":null,"open_issues_count":136,"forks":1660,"open_issues":136,"watchers":2766,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ba1df07ff1169e35e27a845d4cf8fbd01114dcf5","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-09-13T17:27:31Z","pushed_at":"2016-09-13T18:38:21Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":823334,"stargazers_count":2766,"watchers_count":2766,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1660,"mirror_url":null,"open_issues_count":136,"forks":1660,"open_issues":136,"watchers":2766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13449"},"html":{"href":"https://github.com/edx/edx-platform/pull/13449"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13449"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13449/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13449/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13449/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/05d886f80c2ef710f139ade7ea6574199ad515a1"}}}}
{"actor":{"display_login":"cptvitamin"}}