{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/34059","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/34059/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34059/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/34059/events","html_url":"https://github.com/saltstack/salt/pull/34059","id":160619842,"number":34059,"title":"Vmware common gh","user":{"login":"alexbleotu","id":17009281,"avatar_url":"https://avatars.githubusercontent.com/u/17009281?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbleotu","html_url":"https://github.com/alexbleotu","followers_url":"https://api.github.com/users/alexbleotu/followers","following_url":"https://api.github.com/users/alexbleotu/following{/other_user}","gists_url":"https://api.github.com/users/alexbleotu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbleotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbleotu/subscriptions","organizations_url":"https://api.github.com/users/alexbleotu/orgs","repos_url":"https://api.github.com/users/alexbleotu/repos","events_url":"https://api.github.com/users/alexbleotu/events{/privacy}","received_events_url":"https://api.github.com/users/alexbleotu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"},{"url":"https://api.github.com/repos/saltstack/salt/labels/TEAM%20RIoT","name":"TEAM RIoT","color":"A9A9A9"}],"state":"open","locked":false,"assignee":{"login":"cro","id":83323,"avatar_url":"https://avatars.githubusercontent.com/u/83323?v=3","gravatar_id":"","url":"https://api.github.com/users/cro","html_url":"https://github.com/cro","followers_url":"https://api.github.com/users/cro/followers","following_url":"https://api.github.com/users/cro/following{/other_user}","gists_url":"https://api.github.com/users/cro/gists{/gist_id}","starred_url":"https://api.github.com/users/cro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cro/subscriptions","organizations_url":"https://api.github.com/users/cro/orgs","repos_url":"https://api.github.com/users/cro/repos","events_url":"https://api.github.com/users/cro/events{/privacy}","received_events_url":"https://api.github.com/users/cro/received_events","type":"User","site_admin":false},"assignees":[{"login":"cro","id":83323,"avatar_url":"https://avatars.githubusercontent.com/u/83323?v=3","gravatar_id":"","url":"https://api.github.com/users/cro","html_url":"https://github.com/cro","followers_url":"https://api.github.com/users/cro/followers","following_url":"https://api.github.com/users/cro/following{/other_user}","gists_url":"https://api.github.com/users/cro/gists{/gist_id}","starred_url":"https://api.github.com/users/cro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cro/subscriptions","organizations_url":"https://api.github.com/users/cro/orgs","repos_url":"https://api.github.com/users/cro/repos","events_url":"https://api.github.com/users/cro/events{/privacy}","received_events_url":"https://api.github.com/users/cro/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/89","html_url":"https://github.com/saltstack/salt/milestones/C%205","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/89/labels","id":1897763,"number":89,"title":"C 5","description":"","creator":{"login":"meggiebot","id":12242451,"avatar_url":"https://avatars.githubusercontent.com/u/12242451?v=3","gravatar_id":"","url":"https://api.github.com/users/meggiebot","html_url":"https://github.com/meggiebot","followers_url":"https://api.github.com/users/meggiebot/followers","following_url":"https://api.github.com/users/meggiebot/following{/other_user}","gists_url":"https://api.github.com/users/meggiebot/gists{/gist_id}","starred_url":"https://api.github.com/users/meggiebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meggiebot/subscriptions","organizations_url":"https://api.github.com/users/meggiebot/orgs","repos_url":"https://api.github.com/users/meggiebot/repos","events_url":"https://api.github.com/users/meggiebot/events{/privacy}","received_events_url":"https://api.github.com/users/meggiebot/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":17,"state":"open","created_at":"2016-07-21T22:34:47Z","updated_at":"2016-08-23T01:30:54Z","due_on":"2016-08-26T06:00:00Z","closed_at":null},"comments":45,"created_at":"2016-06-16T09:41:13Z","updated_at":"2016-08-23T10:03:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34059","html_url":"https://github.com/saltstack/salt/pull/34059","diff_url":"https://github.com/saltstack/salt/pull/34059.diff","patch_url":"https://github.com/saltstack/salt/pull/34059.patch"},"body":"### What does this PR do?\r\nImproved connection to a VMware vCenter Server or ESXi host\r\n    \r\n- added support for passthrough connections via SSPI\r\n- added function to specify if a connection is made to a vCenter or ESXi host\r\n- added function to disconnect from a vCenter or ESXi host\r\n- added tests for changed/new functions\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Tests written?\r\n\r\nYes"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/241685295","html_url":"https://github.com/saltstack/salt/pull/34059#issuecomment-241685295","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34059","id":241685295,"user":{"login":"alexbleotu","id":17009281,"avatar_url":"https://avatars.githubusercontent.com/u/17009281?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbleotu","html_url":"https://github.com/alexbleotu","followers_url":"https://api.github.com/users/alexbleotu/followers","following_url":"https://api.github.com/users/alexbleotu/following{/other_user}","gists_url":"https://api.github.com/users/alexbleotu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbleotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbleotu/subscriptions","organizations_url":"https://api.github.com/users/alexbleotu/orgs","repos_url":"https://api.github.com/users/alexbleotu/repos","events_url":"https://api.github.com/users/alexbleotu/events{/privacy}","received_events_url":"https://api.github.com/users/alexbleotu/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T10:03:33Z","updated_at":"2016-08-23T10:03:33Z","body":"@cro, @nmadhok  I checked the connection to both a vcenter with SSL certs and one without using python 2.7.3. With any python < 2.7.9 the connection doesn't fail at all because SSL cert validation is disabled by default. This was introduced in 2.7.9 (https://www.python.org/dev/peps/pep-0476/). Thus the connection simply works for me without raising any exception.  \r\n\r\nThe exceptions are only triggered in 2.7.9 where the validation is enabled, and the exception handling covers those exceptions. I can add an additional condition to check for the python version, but am not sure in which of your tests the connection fails when using python < 2.7.9. "}}
{"actor":{"display_login":"alexbleotu"}}