{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/89299190","pull_request_review_id":9844699,"id":89299190,"diff_hunk":"@@ -258,35 +259,43 @@ class UserCourseEnrollmentsList(generics.ListAPIView):\n           certified).\n         * url: URL to the downloadable version of the certificate, if exists.\n     \"\"\"\n-    queryset = CourseEnrollment.objects.all()\n-    serializer_class = CourseEnrollmentSerializer\n-    lookup_field = 'username'\n-\n-    # In Django Rest Framework v3, there is a default pagination\n-    # class that transmutes the response data into a dictionary\n-    # with pagination information.  The original response data (a list)\n-    # is stored in a \"results\" value of the dictionary.\n-    # For backwards compatibility with the existing API, we disable\n-    # the default behavior by setting the pagination_class to None.\n-    pagination_class = None","path":"lms/djangoapps/mobile_api/users/views.py","position":31,"original_position":31,"commit_id":"c256de1df55f9cae8ef2ce15d524f70778c8e857","original_commit_id":"e39a6818fe9997dde454236b305bc5b30657c2f5","user":{"login":"wajeeha-khalid","id":6745069,"avatar_url":"https://avatars.githubusercontent.com/u/6745069?v=3","gravatar_id":"","url":"https://api.github.com/users/wajeeha-khalid","html_url":"https://github.com/wajeeha-khalid","followers_url":"https://api.github.com/users/wajeeha-khalid/followers","following_url":"https://api.github.com/users/wajeeha-khalid/following{/other_user}","gists_url":"https://api.github.com/users/wajeeha-khalid/gists{/gist_id}","starred_url":"https://api.github.com/users/wajeeha-khalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wajeeha-khalid/subscriptions","organizations_url":"https://api.github.com/users/wajeeha-khalid/orgs","repos_url":"https://api.github.com/users/wajeeha-khalid/repos","events_url":"https://api.github.com/users/wajeeha-khalid/events{/privacy}","received_events_url":"https://api.github.com/users/wajeeha-khalid/received_events","type":"User","site_admin":false},"body":"@nasthagiri \r\nI have got the mobile app tested with this branch and its working fine. \r\nWhether i remove `pagination_class = None` or not; the API response remains the same.\r\n\r\nAlso, the apps are not using pagination for GET course enrolment api. Is it supposed to be this way?","created_at":"2016-11-23T11:39:12Z","updated_at":"2016-11-23T11:39:12Z","html_url":"https://github.com/edx/edx-platform/pull/13235#discussion_r89299190","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13235","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/89299190"},"html":{"href":"https://github.com/edx/edx-platform/pull/13235#discussion_r89299190"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13235"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13235","id":81299855,"html_url":"https://github.com/edx/edx-platform/pull/13235","diff_url":"https://github.com/edx/edx-platform/pull/13235.diff","patch_url":"https://github.com/edx/edx-platform/pull/13235.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13235","number":13235,"state":"open","locked":false,"title":"MA-2684: return correct marketing url for course about","user":{"login":"wajeeha-khalid","id":6745069,"avatar_url":"https://avatars.githubusercontent.com/u/6745069?v=3","gravatar_id":"","url":"https://api.github.com/users/wajeeha-khalid","html_url":"https://github.com/wajeeha-khalid","followers_url":"https://api.github.com/users/wajeeha-khalid/followers","following_url":"https://api.github.com/users/wajeeha-khalid/following{/other_user}","gists_url":"https://api.github.com/users/wajeeha-khalid/gists{/gist_id}","starred_url":"https://api.github.com/users/wajeeha-khalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wajeeha-khalid/subscriptions","organizations_url":"https://api.github.com/users/wajeeha-khalid/orgs","repos_url":"https://api.github.com/users/wajeeha-khalid/repos","events_url":"https://api.github.com/users/wajeeha-khalid/events{/privacy}","received_events_url":"https://api.github.com/users/wajeeha-khalid/received_events","type":"User","site_admin":false},"body":"## [MA-2684](https://openedx.atlassian.net/browse/MA-2684)\r\n1. Correct marketing site url returned in course enrollment API. Instead of using MKTG_ROOT use catalog utility to get correct url if marketing site is enabled else return lms course about url.\r\n2. Updated catalog utility to batch request multiple course runs and cache the data.\r\n### Testing\r\n- [x] Unit\r\n### Sandbox\r\n- [x] \r\n### Reviewers\r\n\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @jcdyer \r\n- [ ] Code review: @nasthagiri \r\n- [ ] Code review: @rlucioni \r\n### Post-review\r\n- [ ] Squash commits\r\n","created_at":"2016-08-15T11:23:43Z","updated_at":"2016-11-23T11:39:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e42b0777f0d76d0f4231c0318dc5ba6c68c27a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13235/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13235/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13235/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/c256de1df55f9cae8ef2ce15d524f70778c8e857","head":{"label":"edx:jia/MA-2684","ref":"jia/MA-2684","sha":"c256de1df55f9cae8ef2ce15d524f70778c8e857","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-22T13:18:36Z","pushed_at":"2016-11-23T11:31:33Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":865889,"stargazers_count":2871,"watchers_count":2871,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1707,"mirror_url":null,"open_issues_count":138,"forks":1707,"open_issues":138,"watchers":2871,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ca5c741f301983a25579c4dd1436d41379818877","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-22T13:18:36Z","pushed_at":"2016-11-23T11:31:33Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":865889,"stargazers_count":2871,"watchers_count":2871,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1707,"mirror_url":null,"open_issues_count":138,"forks":1707,"open_issues":138,"watchers":2871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13235"},"html":{"href":"https://github.com/edx/edx-platform/pull/13235"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13235"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13235/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13235/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13235/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/c256de1df55f9cae8ef2ce15d524f70778c8e857"}}}}
{"actor":{"display_login":"wajeeha-khalid"}}