{"action":"created","comment":{"url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments/68079207","id":68079207,"diff_hunk":"@@ -0,0 +1,73 @@\n+﻿using ReactNative.Bridge;\n+using System;\n+using System.Runtime.CompilerServices;\n+using Windows.UI.Xaml;\n+\n+namespace ReactNative.UIManager\n+{\n+    static class DependencyObjectExtensions\n+    {\n+        private static readonly ConditionalWeakTable<DependencyObject, DependencyObjectData> s_properties =\n+            new ConditionalWeakTable<DependencyObject, DependencyObjectData>();\n+\n+        public static void SetTag(this DependencyObject view, int tag)","path":"ReactWindows/ReactNative/UIManager/DependencyObjectExtensions.cs","position":13,"original_position":13,"commit_id":"928d98b0803b59ad5d5e1a193f247400b62d914a","original_commit_id":"928d98b0803b59ad5d5e1a193f247400b62d914a","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"Change to ReactTag.","created_at":"2016-06-22T15:47:49Z","updated_at":"2016-06-22T15:47:49Z","html_url":"https://github.com/ReactWindows/react-native-windows/pull/487#discussion_r68079207","pull_request_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487","_links":{"self":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments/68079207"},"html":{"href":"https://github.com/ReactWindows/react-native-windows/pull/487#discussion_r68079207"},"pull_request":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487","id":74807697,"html_url":"https://github.com/ReactWindows/react-native-windows/pull/487","diff_url":"https://github.com/ReactWindows/react-native-windows/pull/487.diff","patch_url":"https://github.com/ReactWindows/react-native-windows/pull/487.patch","issue_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/487","number":487,"state":"open","locked":false,"title":"feat(Text): Adds support for inline views inside Text component.","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"Android supports inline images, and iOS supports arbitrary inline views (that are bound by width and height). We added similar support for bounded inline views for UWP.\r\n\r\nThe approach required a shift away from the virtual approach that we were previously using for text.  Previously, text was fully managed in the shadow node hierarchy, and used the UpdateExtraData API on IViewManager to funnel the inline from shadow node to the view.  Now the virtual text nodes use proper view managers, although this required that we reduce the base class for views to DependencyObjecy, the least common denominator between FrameworkElement and Inline.\r\n\r\nWe also had to shift from using TextBlock to RichTextBlock to support paragraphs and InlineUIElement instances.","created_at":"2016-06-22T15:42:42Z","updated_at":"2016-06-22T15:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4f48ca31c283902bdcadddeefe922febf11cc57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487/commits","review_comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487/comments","review_comment_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/487/comments","statuses_url":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/928d98b0803b59ad5d5e1a193f247400b62d914a","head":{"label":"rozele:issue189","ref":"issue189","sha":"928d98b0803b59ad5d5e1a193f247400b62d914a","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"repo":{"id":59683079,"name":"react-native-windows","full_name":"rozele/react-native-windows","owner":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rozele/react-native-windows","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/rozele/react-native-windows","forks_url":"https://api.github.com/repos/rozele/react-native-windows/forks","keys_url":"https://api.github.com/repos/rozele/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rozele/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rozele/react-native-windows/teams","hooks_url":"https://api.github.com/repos/rozele/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/rozele/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/rozele/react-native-windows/events","assignees_url":"https://api.github.com/repos/rozele/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/rozele/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/rozele/react-native-windows/tags","blobs_url":"https://api.github.com/repos/rozele/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rozele/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rozele/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/rozele/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rozele/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/rozele/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/rozele/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/rozele/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/rozele/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/rozele/react-native-windows/subscription","commits_url":"https://api.github.com/repos/rozele/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/rozele/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/rozele/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/rozele/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/rozele/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/rozele/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rozele/react-native-windows/merges","archive_url":"https://api.github.com/repos/rozele/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rozele/react-native-windows/downloads","issues_url":"https://api.github.com/repos/rozele/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/rozele/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/rozele/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/rozele/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rozele/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/rozele/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/rozele/react-native-windows/deployments","created_at":"2016-05-25T17:20:35Z","updated_at":"2016-05-25T17:20:37Z","pushed_at":"2016-06-22T15:41:58Z","git_url":"git://github.com/rozele/react-native-windows.git","ssh_url":"git@github.com:rozele/react-native-windows.git","clone_url":"https://github.com/rozele/react-native-windows.git","svn_url":"https://github.com/rozele/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":142212,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ReactWindows"}},"base":{"label":"ReactWindows:master","ref":"master","sha":"98292342a7991514fdbde769ab89c0f9aa0555a5","user":{"login":"ReactWindows","id":18399765,"avatar_url":"https://avatars.githubusercontent.com/u/18399765?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactWindows","html_url":"https://github.com/ReactWindows","followers_url":"https://api.github.com/users/ReactWindows/followers","following_url":"https://api.github.com/users/ReactWindows/following{/other_user}","gists_url":"https://api.github.com/users/ReactWindows/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactWindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactWindows/subscriptions","organizations_url":"https://api.github.com/users/ReactWindows/orgs","repos_url":"https://api.github.com/users/ReactWindows/repos","events_url":"https://api.github.com/users/ReactWindows/events{/privacy}","received_events_url":"https://api.github.com/users/ReactWindows/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"ReactWindows/react-native-windows","owner":{"login":"ReactWindows","id":18399765,"avatar_url":"https://avatars.githubusercontent.com/u/18399765?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactWindows","html_url":"https://github.com/ReactWindows","followers_url":"https://api.github.com/users/ReactWindows/followers","following_url":"https://api.github.com/users/ReactWindows/following{/other_user}","gists_url":"https://api.github.com/users/ReactWindows/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactWindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactWindows/subscriptions","organizations_url":"https://api.github.com/users/ReactWindows/orgs","repos_url":"https://api.github.com/users/ReactWindows/repos","events_url":"https://api.github.com/users/ReactWindows/events{/privacy}","received_events_url":"https://api.github.com/users/ReactWindows/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactWindows/react-native-windows","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/ReactWindows/react-native-windows","forks_url":"https://api.github.com/repos/ReactWindows/react-native-windows/forks","keys_url":"https://api.github.com/repos/ReactWindows/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactWindows/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactWindows/react-native-windows/teams","hooks_url":"https://api.github.com/repos/ReactWindows/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/ReactWindows/react-native-windows/events","assignees_url":"https://api.github.com/repos/ReactWindows/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/ReactWindows/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/ReactWindows/react-native-windows/tags","blobs_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactWindows/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/ReactWindows/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/ReactWindows/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/ReactWindows/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/ReactWindows/react-native-windows/subscription","commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactWindows/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/ReactWindows/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactWindows/react-native-windows/merges","archive_url":"https://api.github.com/repos/ReactWindows/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactWindows/react-native-windows/downloads","issues_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactWindows/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactWindows/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactWindows/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/ReactWindows/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2016-06-22T10:04:37Z","pushed_at":"2016-06-22T15:42:43Z","git_url":"git://github.com/ReactWindows/react-native-windows.git","ssh_url":"git@github.com:ReactWindows/react-native-windows.git","clone_url":"https://github.com/ReactWindows/react-native-windows.git","svn_url":"https://github.com/ReactWindows/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":142514,"stargazers_count":652,"watchers_count":652,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":60,"forks":42,"open_issues":60,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487"},"html":{"href":"https://github.com/ReactWindows/react-native-windows/pull/487"},"issue":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/487"},"comments":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/928d98b0803b59ad5d5e1a193f247400b62d914a"}}}}
{"actor":{"display_login":"rozele"}}