{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4834","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/4834/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4834/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4834/events","html_url":"https://github.com/netty/netty/issues/4834","id":131163945,"number":4834,"title":"Race in AddressResolverGroup","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-03T21:44:39Z","updated_at":"2016-02-04T07:02:36Z","closed_at":null,"body":"https://github.com/netty/netty/blob/4.1/resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java\r\n\r\nHere, `resolvers` is synchronized when calling .get(), but not in the future callback `resolvers.remove(executor);`"},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/179680102","html_url":"https://github.com/netty/netty/issues/4834#issuecomment-179680102","issue_url":"https://api.github.com/repos/netty/netty/issues/4834","id":179680102,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T07:02:35Z","updated_at":"2016-02-04T07:02:35Z","body":"Because it's java8 only... Will fix the race though\n\n> Am 03.02.2016 um 23:09 schrieb Stephane Landelle <notifications@github.com>:\n> \n> Why not use a CHMv8 here? It seems the original concern was AddressResolver instantiation cost, but that's what computeIfAbsent is for. This would let us remove all the synchronized blocks.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}