{"action":"created","comment":{"url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/comments/68582813","id":68582813,"diff_hunk":"@@ -0,0 +1,435 @@\n+﻿using System.Linq;\n+using Nfield.Quota.Builders;\n+using NUnit.Framework;\n+\n+namespace Nfield.Quota.Tests\n+{\n+    [TestFixture]\n+    internal class QuotaFrameValidatorTests\n+    {\n+        [Test]\n+        public void Definitions_UniqueIdsAndNames_HappyPath()\n+        {\n+            var quotaFrame = new QuotaFrameBuilder()\n+                .Id(\"id\")\n+                .VariableDefinition(\"varId\", \"varName\", \"odinVarName\", var =>\n+                {\n+                    var.Level(\"level1Id\", \"level1Name\");\n+                    var.Level(\"level2Id\", \"level2Name\");\n+                })\n+                .Build();\n+\n+            var validator = new QuotaFrameValidator();\n+            var result = validator.Validate(quotaFrame);\n+\n+            Assert.That(result.IsValid, Is.True);\n+        }\n+\n+        [Test]\n+        public void Definitions_CannotBeEmpty()\n+        {\n+            var quotaFrame = new QuotaFrame();","path":"tests/Nfield.Quota.Tests/QuotaFrameValidatorTests.cs","position":31,"original_position":31,"commit_id":"a24f52428ca405b7f3af77c795f9ee9e54d4f08a","original_commit_id":"a24f52428ca405b7f3af77c795f9ee9e54d4f08a","user":{"login":"bjorncoltof","id":417181,"avatar_url":"https://avatars.githubusercontent.com/u/417181?v=3","gravatar_id":"","url":"https://api.github.com/users/bjorncoltof","html_url":"https://github.com/bjorncoltof","followers_url":"https://api.github.com/users/bjorncoltof/followers","following_url":"https://api.github.com/users/bjorncoltof/following{/other_user}","gists_url":"https://api.github.com/users/bjorncoltof/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorncoltof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorncoltof/subscriptions","organizations_url":"https://api.github.com/users/bjorncoltof/orgs","repos_url":"https://api.github.com/users/bjorncoltof/repos","events_url":"https://api.github.com/users/bjorncoltof/events{/privacy}","received_events_url":"https://api.github.com/users/bjorncoltof/received_events","type":"User","site_admin":false},"body":"But this is allowed when only setting a target.","created_at":"2016-06-27T14:12:27Z","updated_at":"2016-06-27T14:12:27Z","html_url":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4#discussion_r68582813","pull_request_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/comments/68582813"},"html":{"href":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4#discussion_r68582813"},"pull_request":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4","id":75084149,"html_url":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4","diff_url":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4.diff","patch_url":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4.patch","issue_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/4","number":4,"state":"open","locked":false,"title":"Validation on quota structure","user":{"login":"LNieuwmegen","id":4254342,"avatar_url":"https://avatars.githubusercontent.com/u/4254342?v=3","gravatar_id":"","url":"https://api.github.com/users/LNieuwmegen","html_url":"https://github.com/LNieuwmegen","followers_url":"https://api.github.com/users/LNieuwmegen/followers","following_url":"https://api.github.com/users/LNieuwmegen/following{/other_user}","gists_url":"https://api.github.com/users/LNieuwmegen/gists{/gist_id}","starred_url":"https://api.github.com/users/LNieuwmegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LNieuwmegen/subscriptions","organizations_url":"https://api.github.com/users/LNieuwmegen/orgs","repos_url":"https://api.github.com/users/LNieuwmegen/repos","events_url":"https://api.github.com/users/LNieuwmegen/events{/privacy}","received_events_url":"https://api.github.com/users/LNieuwmegen/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-24T09:02:32Z","updated_at":"2016-06-27T14:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71cd512ade567dac4d2547d121ff07d61c5117ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4/commits","review_comments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4/comments","review_comment_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/4/comments","statuses_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/statuses/a24f52428ca405b7f3af77c795f9ee9e54d4f08a","head":{"label":"NIPOSoftware:red-quota-validator","ref":"red-quota-validator","sha":"a24f52428ca405b7f3af77c795f9ee9e54d4f08a","user":{"login":"NIPOSoftware","id":4232703,"avatar_url":"https://avatars.githubusercontent.com/u/4232703?v=3","gravatar_id":"","url":"https://api.github.com/users/NIPOSoftware","html_url":"https://github.com/NIPOSoftware","followers_url":"https://api.github.com/users/NIPOSoftware/followers","following_url":"https://api.github.com/users/NIPOSoftware/following{/other_user}","gists_url":"https://api.github.com/users/NIPOSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/NIPOSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NIPOSoftware/subscriptions","organizations_url":"https://api.github.com/users/NIPOSoftware/orgs","repos_url":"https://api.github.com/users/NIPOSoftware/repos","events_url":"https://api.github.com/users/NIPOSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/NIPOSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":61640415,"name":"Nfield.Quota","full_name":"NIPOSoftware/Nfield.Quota","owner":{"login":"NIPOSoftware","id":4232703,"avatar_url":"https://avatars.githubusercontent.com/u/4232703?v=3","gravatar_id":"","url":"https://api.github.com/users/NIPOSoftware","html_url":"https://github.com/NIPOSoftware","followers_url":"https://api.github.com/users/NIPOSoftware/followers","following_url":"https://api.github.com/users/NIPOSoftware/following{/other_user}","gists_url":"https://api.github.com/users/NIPOSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/NIPOSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NIPOSoftware/subscriptions","organizations_url":"https://api.github.com/users/NIPOSoftware/orgs","repos_url":"https://api.github.com/users/NIPOSoftware/repos","events_url":"https://api.github.com/users/NIPOSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/NIPOSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NIPOSoftware/Nfield.Quota","description":"","fork":false,"url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota","forks_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/forks","keys_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/teams","hooks_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/hooks","issue_events_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/events{/number}","events_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/events","assignees_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/assignees{/user}","branches_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/branches{/branch}","tags_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/tags","blobs_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/refs{/sha}","trees_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/statuses/{sha}","languages_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/languages","stargazers_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/stargazers","contributors_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/contributors","subscribers_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/subscribers","subscription_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/subscription","commits_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/commits{/sha}","git_commits_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/commits{/sha}","comments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/comments{/number}","issue_comment_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/comments{/number}","contents_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/contents/{+path}","compare_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/merges","archive_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/downloads","issues_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues{/number}","pulls_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls{/number}","milestones_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/milestones{/number}","notifications_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/labels{/name}","releases_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/releases{/id}","deployments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/deployments","created_at":"2016-06-21T14:27:56Z","updated_at":"2016-06-22T11:05:14Z","pushed_at":"2016-06-27T13:45:11Z","git_url":"git://github.com/NIPOSoftware/Nfield.Quota.git","ssh_url":"git@github.com:NIPOSoftware/Nfield.Quota.git","clone_url":"https://github.com/NIPOSoftware/Nfield.Quota.git","svn_url":"https://github.com/NIPOSoftware/Nfield.Quota","homepage":null,"size":73,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"NIPOSoftware:development","ref":"development","sha":"aa3ca75994bdceb36ce47aeb8a86b9a202b36db9","user":{"login":"NIPOSoftware","id":4232703,"avatar_url":"https://avatars.githubusercontent.com/u/4232703?v=3","gravatar_id":"","url":"https://api.github.com/users/NIPOSoftware","html_url":"https://github.com/NIPOSoftware","followers_url":"https://api.github.com/users/NIPOSoftware/followers","following_url":"https://api.github.com/users/NIPOSoftware/following{/other_user}","gists_url":"https://api.github.com/users/NIPOSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/NIPOSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NIPOSoftware/subscriptions","organizations_url":"https://api.github.com/users/NIPOSoftware/orgs","repos_url":"https://api.github.com/users/NIPOSoftware/repos","events_url":"https://api.github.com/users/NIPOSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/NIPOSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":61640415,"name":"Nfield.Quota","full_name":"NIPOSoftware/Nfield.Quota","owner":{"login":"NIPOSoftware","id":4232703,"avatar_url":"https://avatars.githubusercontent.com/u/4232703?v=3","gravatar_id":"","url":"https://api.github.com/users/NIPOSoftware","html_url":"https://github.com/NIPOSoftware","followers_url":"https://api.github.com/users/NIPOSoftware/followers","following_url":"https://api.github.com/users/NIPOSoftware/following{/other_user}","gists_url":"https://api.github.com/users/NIPOSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/NIPOSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NIPOSoftware/subscriptions","organizations_url":"https://api.github.com/users/NIPOSoftware/orgs","repos_url":"https://api.github.com/users/NIPOSoftware/repos","events_url":"https://api.github.com/users/NIPOSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/NIPOSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NIPOSoftware/Nfield.Quota","description":"","fork":false,"url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota","forks_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/forks","keys_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/teams","hooks_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/hooks","issue_events_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/events{/number}","events_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/events","assignees_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/assignees{/user}","branches_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/branches{/branch}","tags_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/tags","blobs_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/refs{/sha}","trees_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/statuses/{sha}","languages_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/languages","stargazers_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/stargazers","contributors_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/contributors","subscribers_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/subscribers","subscription_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/subscription","commits_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/commits{/sha}","git_commits_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/git/commits{/sha}","comments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/comments{/number}","issue_comment_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/comments{/number}","contents_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/contents/{+path}","compare_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/merges","archive_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/downloads","issues_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues{/number}","pulls_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls{/number}","milestones_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/milestones{/number}","notifications_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/labels{/name}","releases_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/releases{/id}","deployments_url":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/deployments","created_at":"2016-06-21T14:27:56Z","updated_at":"2016-06-22T11:05:14Z","pushed_at":"2016-06-27T13:45:11Z","git_url":"git://github.com/NIPOSoftware/Nfield.Quota.git","ssh_url":"git@github.com:NIPOSoftware/Nfield.Quota.git","clone_url":"https://github.com/NIPOSoftware/Nfield.Quota.git","svn_url":"https://github.com/NIPOSoftware/Nfield.Quota","homepage":null,"size":73,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4"},"html":{"href":"https://github.com/NIPOSoftware/Nfield.Quota/pull/4"},"issue":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/4"},"comments":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/NIPOSoftware/Nfield.Quota/statuses/a24f52428ca405b7f3af77c795f9ee9e54d4f08a"}}}}
{"actor":{"display_login":"bjorncoltof"}}