{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/90931736","pull_request_review_id":11445180,"id":90931736,"diff_hunk":"@@ -0,0 +1,28 @@\n+// Licensed to the .NET Foundation under one or more agreements.","path":"src/System.Net.Requests/tests/HttpWebRequestTest.netstandard1.7.cs","position":1,"original_position":1,"commit_id":"22d5c79049f5b691297a9a3110e2843256e0c46e","original_commit_id":"22d5c79049f5b691297a9a3110e2843256e0c46e","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Yes for any projects that need to build in multiple configurations then we have been primarily splitting into other files and including the configuration as part of the file name. See https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/project-guidelines.md#code-file-naming-conventions. ","created_at":"2016-12-05T19:00:02Z","updated_at":"2016-12-05T19:00:02Z","html_url":"https://github.com/dotnet/corefx/pull/14175#discussion_r90931736","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/14175","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/90931736"},"html":{"href":"https://github.com/dotnet/corefx/pull/14175#discussion_r90931736"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14175"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/14175","id":96387962,"html_url":"https://github.com/dotnet/corefx/pull/14175","diff_url":"https://github.com/dotnet/corefx/pull/14175.diff","patch_url":"https://github.com/dotnet/corefx/pull/14175.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14175","number":14175,"state":"open","locked":false,"title":"Obsolete serialization of 2 types","user":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/dotnet/corefx/issues/14068\r\n\r\nI made some attempt to fix serialization for each of these types, but they have been sufficiently rewritten that it would need some design work (eg., some of the state was moved to nested or nested-nested types). Given the serializers were marked obsolete in Full framework, I chose to abandon that effort and made them throw rather than be broken.\r\n\r\n@stephentoub @davidsh @CIPop ","created_at":"2016-12-03T05:52:24Z","updated_at":"2016-12-05T19:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8ffa298eecc01111f72b0149329230f0d30351","assignee":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"assignees":[{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestones/1.2.0","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"1.2.0","description":".NET Core 1.2 Placeholder (next major release)\r\nhttps://github.com/dotnet/core/blob/master/roadmap.md","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":329,"closed_issues":3008,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-12-05T12:57:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/14175/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/14175/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14175/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/22d5c79049f5b691297a9a3110e2843256e0c46e","head":{"label":"danmosemsft:http2","ref":"http2","sha":"22d5c79049f5b691297a9a3110e2843256e0c46e","user":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"repo":{"id":58944563,"name":"corefx","full_name":"danmosemsft/corefx","owner":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danmosemsft/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/danmosemsft/corefx","forks_url":"https://api.github.com/repos/danmosemsft/corefx/forks","keys_url":"https://api.github.com/repos/danmosemsft/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danmosemsft/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danmosemsft/corefx/teams","hooks_url":"https://api.github.com/repos/danmosemsft/corefx/hooks","issue_events_url":"https://api.github.com/repos/danmosemsft/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/danmosemsft/corefx/events","assignees_url":"https://api.github.com/repos/danmosemsft/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/danmosemsft/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/danmosemsft/corefx/tags","blobs_url":"https://api.github.com/repos/danmosemsft/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danmosemsft/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danmosemsft/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/danmosemsft/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danmosemsft/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/danmosemsft/corefx/languages","stargazers_url":"https://api.github.com/repos/danmosemsft/corefx/stargazers","contributors_url":"https://api.github.com/repos/danmosemsft/corefx/contributors","subscribers_url":"https://api.github.com/repos/danmosemsft/corefx/subscribers","subscription_url":"https://api.github.com/repos/danmosemsft/corefx/subscription","commits_url":"https://api.github.com/repos/danmosemsft/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/danmosemsft/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/danmosemsft/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/danmosemsft/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/danmosemsft/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/danmosemsft/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danmosemsft/corefx/merges","archive_url":"https://api.github.com/repos/danmosemsft/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danmosemsft/corefx/downloads","issues_url":"https://api.github.com/repos/danmosemsft/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/danmosemsft/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/danmosemsft/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/danmosemsft/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danmosemsft/corefx/labels{/name}","releases_url":"https://api.github.com/repos/danmosemsft/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/danmosemsft/corefx/deployments","created_at":"2016-05-16T15:39:17Z","updated_at":"2016-05-16T15:39:42Z","pushed_at":"2016-12-04T19:09:45Z","git_url":"git://github.com/danmosemsft/corefx.git","ssh_url":"git@github.com:danmosemsft/corefx.git","clone_url":"https://github.com/danmosemsft/corefx.git","svn_url":"https://github.com/danmosemsft/corefx","homepage":"http://dotnet.github.io/","size":121373,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"62173b7583970a7f9d0d935a93c380d39045afa5","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-12-05T17:09:10Z","pushed_at":"2016-12-05T18:50:31Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":168596,"stargazers_count":10891,"watchers_count":10891,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2783,"mirror_url":null,"open_issues_count":1294,"forks":2783,"open_issues":1294,"watchers":10891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14175"},"html":{"href":"https://github.com/dotnet/corefx/pull/14175"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14175"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14175/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14175/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14175/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/22d5c79049f5b691297a9a3110e2843256e0c46e"}}}}
{"actor":{"display_login":"weshaggard"}}