{"action":"closed","number":9230,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230","id":60949803,"html_url":"https://github.com/joomla/joomla-cms/pull/9230","diff_url":"https://github.com/joomla/joomla-cms/pull/9230.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9230.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9230","number":9230,"state":"closed","locked":false,"title":"Fix session reset for updates from 3.4.8.","user":{"login":"Harmageddon","id":1410135,"avatar_url":"https://avatars.githubusercontent.com/u/1410135?v=3","gravatar_id":"","url":"https://api.github.com/users/Harmageddon","html_url":"https://github.com/Harmageddon","followers_url":"https://api.github.com/users/Harmageddon/followers","following_url":"https://api.github.com/users/Harmageddon/following{/other_user}","gists_url":"https://api.github.com/users/Harmageddon/gists{/gist_id}","starred_url":"https://api.github.com/users/Harmageddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harmageddon/subscriptions","organizations_url":"https://api.github.com/users/Harmageddon/orgs","repos_url":"https://api.github.com/users/Harmageddon/repos","events_url":"https://api.github.com/users/Harmageddon/events{/privacy}","received_events_url":"https://api.github.com/users/Harmageddon/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #9014 .\r\n\r\nCredits for this PR to @zero-24 who investigated this issue and proposed this fix!\r\n\r\n#### Summary of Changes\r\n\r\n* Change 1: Restart the session only, if we have no active session.\r\n* Change 2: Inside the \"truncateTable\" function, the table name is quoted already, so we don't need to quote the argument, which would lead to a double quoted table name and thus to a MySQL error.\r\n\r\n#### Testing Instructions\r\nAn update package including this change (modified version of the beta 2 package) can be found [here](http://www.zweiiconkram.de/upload/Joomla_3.5.0-beta2-Beta-Update_Package.zip). Please note that the only change included in this package is the one from this PR. So you might encounter other issues which were already fixed since the release of beta2.\r\n\r\nPlease test this update package (or an own one including these changes) for the following cases:\r\n\r\n1. Update from 3.4.5 or older versions.\r\n  * Expected behavior: You should be logged out, because the session in the old format from 3.4.5 or older has to be deleted and a new session in the new, safer format has to be started.\r\n2. Update from 3.4.8\r\n  * Expected behavior: You should **not** be logged out, because you already have a session in the new format.\r\n3. Update from beta2\r\n  * Expected behavior: Same as for 3.4.8.\r\n\r\n@nikosdion As the first change of this PR will mostly affect updates via Akeeba CLI, could you please check if this introduces any issues?","created_at":"2016-02-27T13:09:41Z","updated_at":"2016-02-27T14:40:45Z","closed_at":"2016-02-27T14:40:45Z","merged_at":"2016-02-27T14:40:45Z","merge_commit_sha":"4f56387bf9889451640332883e8f2167332062ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9230/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/d83e73f1e2ee07db92ab62a6836e10ee7de572f8","head":{"label":"Harmageddon:update_session_fix","ref":"update_session_fix","sha":"d83e73f1e2ee07db92ab62a6836e10ee7de572f8","user":{"login":"Harmageddon","id":1410135,"avatar_url":"https://avatars.githubusercontent.com/u/1410135?v=3","gravatar_id":"","url":"https://api.github.com/users/Harmageddon","html_url":"https://github.com/Harmageddon","followers_url":"https://api.github.com/users/Harmageddon/followers","following_url":"https://api.github.com/users/Harmageddon/following{/other_user}","gists_url":"https://api.github.com/users/Harmageddon/gists{/gist_id}","starred_url":"https://api.github.com/users/Harmageddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harmageddon/subscriptions","organizations_url":"https://api.github.com/users/Harmageddon/orgs","repos_url":"https://api.github.com/users/Harmageddon/repos","events_url":"https://api.github.com/users/Harmageddon/events{/privacy}","received_events_url":"https://api.github.com/users/Harmageddon/received_events","type":"User","site_admin":false},"repo":{"id":17594657,"name":"joomla-cms","full_name":"Harmageddon/joomla-cms","owner":{"login":"Harmageddon","id":1410135,"avatar_url":"https://avatars.githubusercontent.com/u/1410135?v=3","gravatar_id":"","url":"https://api.github.com/users/Harmageddon","html_url":"https://github.com/Harmageddon","followers_url":"https://api.github.com/users/Harmageddon/followers","following_url":"https://api.github.com/users/Harmageddon/following{/other_user}","gists_url":"https://api.github.com/users/Harmageddon/gists{/gist_id}","starred_url":"https://api.github.com/users/Harmageddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harmageddon/subscriptions","organizations_url":"https://api.github.com/users/Harmageddon/orgs","repos_url":"https://api.github.com/users/Harmageddon/repos","events_url":"https://api.github.com/users/Harmageddon/events{/privacy}","received_events_url":"https://api.github.com/users/Harmageddon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Harmageddon/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Harmageddon/joomla-cms","forks_url":"https://api.github.com/repos/Harmageddon/joomla-cms/forks","keys_url":"https://api.github.com/repos/Harmageddon/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harmageddon/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harmageddon/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Harmageddon/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Harmageddon/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Harmageddon/joomla-cms/events","assignees_url":"https://api.github.com/repos/Harmageddon/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Harmageddon/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Harmageddon/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Harmageddon/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harmageddon/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harmageddon/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harmageddon/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harmageddon/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Harmageddon/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Harmageddon/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Harmageddon/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Harmageddon/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Harmageddon/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Harmageddon/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harmageddon/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harmageddon/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harmageddon/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harmageddon/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Harmageddon/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harmageddon/joomla-cms/merges","archive_url":"https://api.github.com/repos/Harmageddon/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harmageddon/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Harmageddon/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Harmageddon/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Harmageddon/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Harmageddon/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harmageddon/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Harmageddon/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Harmageddon/joomla-cms/deployments","created_at":"2014-03-10T14:03:29Z","updated_at":"2016-01-24T20:30:01Z","pushed_at":"2016-02-27T12:53:52Z","git_url":"git://github.com/Harmageddon/joomla-cms.git","ssh_url":"git@github.com:Harmageddon/joomla-cms.git","clone_url":"https://github.com/Harmageddon/joomla-cms.git","svn_url":"https://github.com/Harmageddon/joomla-cms","homepage":"http://joomla.org","size":141960,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"025fbe23070d2dbb05109f96327e178a56e54fd2","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-02-27T08:53:10Z","pushed_at":"2016-02-27T14:40:45Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":247769,"stargazers_count":1844,"watchers_count":1844,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2048,"mirror_url":null,"open_issues_count":605,"forks":2048,"open_issues":605,"watchers":1844,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/9230"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9230"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9230/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9230/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/d83e73f1e2ee07db92ab62a6836e10ee7de572f8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}