{"action":"created","issue":{"url":"https://api.github.com/repos/cahirwpz/mimiker/issues/134","repository_url":"https://api.github.com/repos/cahirwpz/mimiker","labels_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/134/comments","events_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/134/events","html_url":"https://github.com/cahirwpz/mimiker/pull/134","id":189010904,"number":134,"title":"Major makefile cleanup","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-14T01:27:37Z","updated_at":"2016-11-14T09:32:32Z","closed_at":"2016-11-14T09:32:29Z","pull_request":{"url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/134","html_url":"https://github.com/cahirwpz/mimiker/pull/134","diff_url":"https://github.com/cahirwpz/mimiker/pull/134.diff","patch_url":"https://github.com/cahirwpz/mimiker/pull/134.patch"},"body":"I finally got down to cleaning up the main Makefile. My changes include:\r\n- Correcting dependencies so that they point to files and not their parent directories\r\n- Simplifying frequently edited variables\r\n- Automatically generating as much as possible to reduce human-error risk (for example, creating a new test `*.c` required adding the file in two places in `Makefile`, and as some tests were present in only one of these places, the success of build varied with the order of dependency evaluation...)\r\n- Providing slightly more documentation, as makefiles tend to get difficult to read. Minor formatting fixes.\r\n\r\nAs a pleasant effects of these changes:\r\n- `make` no longer pointlessly rebuilds kernel `.elf`s and some other files when nothing was changed\r\n- Fixed dependencies finally allow for parallelized building.\r\n\r\nI've tested this new `Makefile` by manually touching each `*.{c,h,S}` file and verifying whether all targets rebuild correctly and in order, both with `make` and `make -j32`, so I am fairly confident everything works well."},"comment":{"url":"https://api.github.com/repos/cahirwpz/mimiker/issues/comments/260287989","html_url":"https://github.com/cahirwpz/mimiker/pull/134#issuecomment-260287989","issue_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/134","id":260287989,"user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T09:32:32Z","updated_at":"2016-11-14T09:32:32Z","body":"Make metaprogramming FTW! It looks way better, thanks!"}}
{"actor":{"display_login":"cahirwpz"}}