{"action":"created","issue":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/341","repository_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl","labels_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/341/comments","events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/341/events","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/341","id":148393385,"number":341,"title":"Don't step in to clojure.core functions","user":{"login":"grammati","id":94716,"avatar_url":"https://avatars.githubusercontent.com/u/94716?v=3","gravatar_id":"","url":"https://api.github.com/users/grammati","html_url":"https://github.com/grammati","followers_url":"https://api.github.com/users/grammati/followers","following_url":"https://api.github.com/users/grammati/following{/other_user}","gists_url":"https://api.github.com/users/grammati/gists{/gist_id}","starred_url":"https://api.github.com/users/grammati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grammati/subscriptions","organizations_url":"https://api.github.com/users/grammati/orgs","repos_url":"https://api.github.com/users/grammati/repos","events_url":"https://api.github.com/users/grammati/events{/privacy}","received_events_url":"https://api.github.com/users/grammati/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-14T15:12:47Z","updated_at":"2016-04-14T18:07:53Z","closed_at":"2016-04-14T16:44:16Z","pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/341","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/341","diff_url":"https://github.com/clojure-emacs/cider-nrepl/pull/341.diff","patch_url":"https://github.com/clojure-emacs/cider-nrepl/pull/341.patch"},"body":"The new step-in command makes it easy to step in (often accidentally) to\r\na function in clojure.core. But instrumenting clojure core functions is\r\ndangerous, and can result in a stack overflow that crashes the nrepl\r\nprocess. In fact, just instrumenting `clojure.core/symbol?` (without\r\neven debugging it) causes a stack overflow. I'm not entirely sure yet\r\nhow this happens, but it seems safest to just prevent stepping in to all\r\ncore functions."},"comment":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/comments/210080564","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/341#issuecomment-210080564","issue_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/341","id":210080564,"user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T18:07:53Z","updated_at":"2016-04-14T18:07:53Z","body":"> If that's the case, we don't need to make this customizable, we only need to exclude all namespaces that debug.clj depends on (be it directly or indeirectly).\r\n\r\nSure. I originally thought the purpose of this PR was to just skip stepping into boring functions, which definitely seems useful to me. \r\n\r\nGuess we should mention those peculiarities in the manual, as some people might wonder why they can't step into certain functions. "}}