{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/90918421","pull_request_review_id":11431922,"id":90918421,"diff_hunk":"@@ -88,29 +88,29 @@ export class CoffeeCompiler extends CachingCompiler {\n       inputFile.getDeclaredExports().map(e => e.name)\n     );\n \n-    if (/`|\\b(?:import|export|yield)\\b/.test(source)) {\n-      // If source contains backticks or features that output as ES2015+,\n-      // pass the coffee output through babel-compiler\n-      const doubleRoastedCoffee =\n-        this.babelCompiler.processOneFileForTarget(inputFile, output.js);\n-\n-      if (doubleRoastedCoffee != null &&\n-          doubleRoastedCoffee.data != null) {\n-        output.js = doubleRoastedCoffee.data;\n-\n-        if (doubleRoastedCoffee.sourceMap) {\n-          // Combine the original CoffeeScript source map with the one\n-          // produced by this.babelCompiler.processOneFileForTarget.\n-          const smg = new SourceMapGenerator(\n-            new SourceMapConsumer(doubleRoastedCoffee.sourceMap));\n-          smg.applySourceMap(new SourceMapConsumer(sourceMap));\n-          sourceMap = smg.toJSON();\n-        } else {\n-          // If the .coffee file is contained by a node_modules directory,\n-          // then BabelCompiler will not transpile it, and there will be\n-          // no sourceMap, but that's fine because the original\n-          // CoffeeScript sourceMap will still be valid.\n-        }\n+    // CoffeeScript contains a handful of features that output as ES2015+,\n+    // such as modules, generator functions, for…of, and tagged template\n+    // literals. Because they’re too varied to detect, pass all CoffeeScript\n+    // compiler output through the Babel compiler.\n+    const doubleRoastedCoffee =\n+      this.babelCompiler.processOneFileForTarget(inputFile, output.js);","path":"packages/coffeescript/plugin/compile-coffeescript.js","position":32,"original_position":32,"commit_id":"f4dbab623ba45dfb903c1de3a446d79426630ecf","original_commit_id":"f4dbab623ba45dfb903c1de3a446d79426630ecf","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"How would I be able to test that this works?","created_at":"2016-12-05T17:51:04Z","updated_at":"2016-12-05T17:51:04Z","html_url":"https://github.com/meteor/meteor/pull/8133#discussion_r90918421","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/8133","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/90918421"},"html":{"href":"https://github.com/meteor/meteor/pull/8133#discussion_r90918421"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/8133"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/8133","id":96448625,"html_url":"https://github.com/meteor/meteor/pull/8133","diff_url":"https://github.com/meteor/meteor/pull/8133.diff","patch_url":"https://github.com/meteor/meteor/pull/8133.patch","issue_url":"https://api.github.com/repos/meteor/meteor/issues/8133","number":8133,"state":"open","locked":false,"title":"Use CoffeeScript 1.12.0","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"[CoffeeScript 1.12.0 is out](http://coffeescript.org/#changelog). This updates Meteor’s package to use the new version.\r\n\r\nI removed the `if` check that passed through the CoffeeScript compiler’s output to `ecmascript` only if certain ES2015+ features were recognized in the original source. Now all coffee output is parsed by `ecmascript`. With the addition of tagged template literals and `for…of` in CoffeeScript 1.12.0, I don’t think it’s possible anymore to reliably detect when ES2015+ features are being used. We should just always assume there could be ES2015+ syntax in the CoffeeScript compiler output, unfortunate though that is from a performance perspective.","created_at":"2016-12-04T21:59:41Z","updated_at":"2016-12-05T17:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7cc231261d010afe09845aa6eae87cd1677895b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meteor/meteor/pulls/8133/commits","review_comments_url":"https://api.github.com/repos/meteor/meteor/pulls/8133/comments","review_comment_url":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/8133/comments","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/f4dbab623ba45dfb903c1de3a446d79426630ecf","head":{"label":"GeoffreyBooth:coffeescript-1.12.0","ref":"coffeescript-1.12.0","sha":"f4dbab623ba45dfb903c1de3a446d79426630ecf","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"repo":{"id":52945560,"name":"meteor","full_name":"GeoffreyBooth/meteor","owner":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeoffreyBooth/meteor","description":"Meteor, the JavaScript App Platform","fork":true,"url":"https://api.github.com/repos/GeoffreyBooth/meteor","forks_url":"https://api.github.com/repos/GeoffreyBooth/meteor/forks","keys_url":"https://api.github.com/repos/GeoffreyBooth/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoffreyBooth/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoffreyBooth/meteor/teams","hooks_url":"https://api.github.com/repos/GeoffreyBooth/meteor/hooks","issue_events_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/GeoffreyBooth/meteor/events","assignees_url":"https://api.github.com/repos/GeoffreyBooth/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/GeoffreyBooth/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/GeoffreyBooth/meteor/tags","blobs_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoffreyBooth/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoffreyBooth/meteor/languages","stargazers_url":"https://api.github.com/repos/GeoffreyBooth/meteor/stargazers","contributors_url":"https://api.github.com/repos/GeoffreyBooth/meteor/contributors","subscribers_url":"https://api.github.com/repos/GeoffreyBooth/meteor/subscribers","subscription_url":"https://api.github.com/repos/GeoffreyBooth/meteor/subscription","commits_url":"https://api.github.com/repos/GeoffreyBooth/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoffreyBooth/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoffreyBooth/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/GeoffreyBooth/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoffreyBooth/meteor/merges","archive_url":"https://api.github.com/repos/GeoffreyBooth/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoffreyBooth/meteor/downloads","issues_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/GeoffreyBooth/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoffreyBooth/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoffreyBooth/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoffreyBooth/meteor/labels{/name}","releases_url":"https://api.github.com/repos/GeoffreyBooth/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/GeoffreyBooth/meteor/deployments","created_at":"2016-03-02T08:11:08Z","updated_at":"2016-03-02T08:11:30Z","pushed_at":"2016-12-04T22:27:08Z","git_url":"git://github.com/GeoffreyBooth/meteor.git","ssh_url":"git@github.com:GeoffreyBooth/meteor.git","clone_url":"https://github.com/GeoffreyBooth/meteor.git","svn_url":"https://github.com/GeoffreyBooth/meteor","homepage":"https://www.meteor.com","size":65746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"meteor:devel","ref":"devel","sha":"5d9d06f3bd376a85752bf324ce98706a8cd2baa3","user":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"name":"meteor","full_name":"meteor/meteor","owner":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/meteor","description":"Meteor, the JavaScript App Platform","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/meteor/deployments","created_at":"2012-01-19T01:58:17Z","updated_at":"2016-12-05T16:21:00Z","pushed_at":"2016-12-04T22:27:08Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"https://www.meteor.com","size":150327,"stargazers_count":36113,"watchers_count":36113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4478,"mirror_url":null,"open_issues_count":891,"forks":4478,"open_issues":891,"watchers":36113,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/8133"},"html":{"href":"https://github.com/meteor/meteor/pull/8133"},"issue":{"href":"https://api.github.com/repos/meteor/meteor/issues/8133"},"comments":{"href":"https://api.github.com/repos/meteor/meteor/issues/8133/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/meteor/pulls/8133/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/meteor/pulls/8133/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/meteor/statuses/f4dbab623ba45dfb903c1de3a446d79426630ecf"}}}}
{"actor":{"display_login":"GeoffreyBooth"}}