{"action":"created","issue":{"url":"https://api.github.com/repos/EQEmu/Server/issues/531","repository_url":"https://api.github.com/repos/EQEmu/Server","labels_url":"https://api.github.com/repos/EQEmu/Server/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/EQEmu/Server/issues/531/comments","events_url":"https://api.github.com/repos/EQEmu/Server/issues/531/events","html_url":"https://github.com/EQEmu/Server/pull/531","id":159947861,"number":531,"title":"Fix for detrimental/beneficial spell overwrite and/or block.","user":{"login":"noudess","id":8644833,"avatar_url":"https://avatars.githubusercontent.com/u/8644833?v=3","gravatar_id":"","url":"https://api.github.com/users/noudess","html_url":"https://github.com/noudess","followers_url":"https://api.github.com/users/noudess/followers","following_url":"https://api.github.com/users/noudess/following{/other_user}","gists_url":"https://api.github.com/users/noudess/gists{/gist_id}","starred_url":"https://api.github.com/users/noudess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noudess/subscriptions","organizations_url":"https://api.github.com/users/noudess/orgs","repos_url":"https://api.github.com/users/noudess/repos","events_url":"https://api.github.com/users/noudess/events{/privacy}","received_events_url":"https://api.github.com/users/noudess/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-13T13:17:32Z","updated_at":"2016-06-13T19:18:04Z","closed_at":"2016-06-13T17:27:41Z","pull_request":{"url":"https://api.github.com/repos/EQEmu/Server/pulls/531","html_url":"https://github.com/EQEmu/Server/pull/531","diff_url":"https://github.com/EQEmu/Server/pull/531.diff","patch_url":"https://github.com/EQEmu/Server/pull/531.patch"},"body":"Spells like listless power and dread touch should be taking down/blocking spells like augmentation and strenthen respectively.  The stacking code was being bypassed when a beneficial spell and a detrimental spell for the same effect were being compared.\r\n\r\nWith this code removed, the spells are compared and the stronger of the two spells wins and replaces or blocks the other.\r\n\r\nWithout this change, for example, dread touch takes down strengthen on the\r\nclient, but the server still things strength is up, causing a mismatch.\r\n\r\nWith this change, client/server match.  When a beneficial spell is stronger, it blocks/replaces the detrimental one.  When the beneficial spell is weaker, it is overwritten/blocked by the detrimental.  When they are equal, they can replace one another back and forth.\r\n\r\nI am not the expert here, but this change has been working for me for years.  However, my server is a low level server (level 50 max).\r\n\r\nI posted this thread about it way back in 2013 when I was not even close to being on the same code base on the main line.  I'm just getting around to pushing this change up.\r\n\r\n[(http://www.eqemulator.org/forums/showthread.php?t=36940)]\r\n\r\nDo you approve of this change, or should it be done another way.  It seems to work great for me here."},"comment":{"url":"https://api.github.com/repos/EQEmu/Server/issues/comments/225680285","html_url":"https://github.com/EQEmu/Server/pull/531#issuecomment-225680285","issue_url":"https://api.github.com/repos/EQEmu/Server/issues/531","id":225680285,"user":{"login":"noudess","id":8644833,"avatar_url":"https://avatars.githubusercontent.com/u/8644833?v=3","gravatar_id":"","url":"https://api.github.com/users/noudess","html_url":"https://github.com/noudess","followers_url":"https://api.github.com/users/noudess/followers","following_url":"https://api.github.com/users/noudess/following{/other_user}","gists_url":"https://api.github.com/users/noudess/gists{/gist_id}","starred_url":"https://api.github.com/users/noudess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noudess/subscriptions","organizations_url":"https://api.github.com/users/noudess/orgs","repos_url":"https://api.github.com/users/noudess/repos","events_url":"https://api.github.com/users/noudess/events{/privacy}","received_events_url":"https://api.github.com/users/noudess/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T19:18:04Z","updated_at":"2016-06-13T19:18:04Z","body":"Yeah, and I'm scared, my server is so low level.  I don't see or know much about the really high end game."}}
{"actor":{"display_login":"noudess"}}