{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/router/pulls/comments/80653584","pull_request_review_id":1695752,"id":80653584,"diff_hunk":"@@ -377,16 +377,20 @@ define(['exports', 'aurelia-logging', 'aurelia-route-recognizer', 'aurelia-depen\n     NavigationInstruction.prototype._buildTitle = function _buildTitle() {\n       var separator = arguments.length <= 0 || arguments[0] === undefined ? ' | ' : arguments[0];\n \n-      var title = this.config.navModel.title || '';","path":"dist/amd/aurelia-router.js","position":null,"original_position":4,"commit_id":"2c40ce1897d35f81cc4684fd0cb300053688553a","original_commit_id":"91b10b66105aff95f7a61f3dfd09fc05037e1232","user":{"login":"manuel-guilbault","id":718466,"avatar_url":"https://avatars.githubusercontent.com/u/718466?v=3","gravatar_id":"","url":"https://api.github.com/users/manuel-guilbault","html_url":"https://github.com/manuel-guilbault","followers_url":"https://api.github.com/users/manuel-guilbault/followers","following_url":"https://api.github.com/users/manuel-guilbault/following{/other_user}","gists_url":"https://api.github.com/users/manuel-guilbault/gists{/gist_id}","starred_url":"https://api.github.com/users/manuel-guilbault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuel-guilbault/subscriptions","organizations_url":"https://api.github.com/users/manuel-guilbault/orgs","repos_url":"https://api.github.com/users/manuel-guilbault/repos","events_url":"https://api.github.com/users/manuel-guilbault/events{/privacy}","received_events_url":"https://api.github.com/users/manuel-guilbault/received_events","type":"User","site_admin":false},"body":"@atsu85 sorry, didn't know that. Fixed.","created_at":"2016-09-27T09:33:24Z","updated_at":"2016-09-27T09:33:24Z","html_url":"https://github.com/aurelia/router/pull/409#discussion_r80653584","pull_request_url":"https://api.github.com/repos/aurelia/router/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/aurelia/router/pulls/comments/80653584"},"html":{"href":"https://github.com/aurelia/router/pull/409#discussion_r80653584"},"pull_request":{"href":"https://api.github.com/repos/aurelia/router/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/aurelia/router/pulls/409","id":86321147,"html_url":"https://github.com/aurelia/router/pull/409","diff_url":"https://github.com/aurelia/router/pull/409.diff","patch_url":"https://github.com/aurelia/router/pull/409.patch","issue_url":"https://api.github.com/repos/aurelia/router/issues/409","number":409,"state":"open","locked":false,"title":"feat(router): add extension to transform title when built","user":{"login":"manuel-guilbault","id":718466,"avatar_url":"https://avatars.githubusercontent.com/u/718466?v=3","gravatar_id":"","url":"https://api.github.com/users/manuel-guilbault","html_url":"https://github.com/manuel-guilbault","followers_url":"https://api.github.com/users/manuel-guilbault/followers","following_url":"https://api.github.com/users/manuel-guilbault/following{/other_user}","gists_url":"https://api.github.com/users/manuel-guilbault/gists{/gist_id}","starred_url":"https://api.github.com/users/manuel-guilbault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuel-guilbault/subscriptions","organizations_url":"https://api.github.com/users/manuel-guilbault/orgs","repos_url":"https://api.github.com/users/manuel-guilbault/repos","events_url":"https://api.github.com/users/manuel-guilbault/events{/privacy}","received_events_url":"https://api.github.com/users/manuel-guilbault/received_events","type":"User","site_admin":false},"body":"Add a ```transformTitle: (title: string) => string``` property to the ```Router```. Can be used to connect the router's title generation with a i18n library.\r\n\r\nExample:\r\n```js\r\nimport Backend from 'i18next-xhr-backend';\r\nimport {AppRouter} from 'aurelia-router';\r\n\r\nexport function configure(aurelia) {\r\n  aurelia.use\r\n    .standardConfiguration()\r\n    .plugin('aurelia-i18n', i18n => {\r\n      i18n.i18next.use(Backend);\r\n\r\n      return i18n.setup({\r\n        backend: {\r\n          loadPath: './locales/{{lng}}/{{ns}}.json', \r\n        },\r\n        lng : 'en',\r\n        fallbackLng : 'en',\r\n        attributes : ['t','i18n'],\r\n        debug : false\r\n      }).then(() => {\r\n        aurelia.container.get(AppRouter).transformTitle = title => i18n.tr(title);\r\n      });\r\n    })\r\n    .feature('resources');\r\n\r\n  aurelia.start().then(() => aurelia.setRoot());\r\n}\r\n```\r\n\r\nResolves #343 ","created_at":"2016-09-22T11:36:55Z","updated_at":"2016-09-27T09:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42d674361a020d27f4bc39e805dcee44f3c1f6de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/router/pulls/409/commits","review_comments_url":"https://api.github.com/repos/aurelia/router/pulls/409/comments","review_comment_url":"https://api.github.com/repos/aurelia/router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/router/issues/409/comments","statuses_url":"https://api.github.com/repos/aurelia/router/statuses/2c40ce1897d35f81cc4684fd0cb300053688553a","head":{"label":"manuel-guilbault:master","ref":"master","sha":"2c40ce1897d35f81cc4684fd0cb300053688553a","user":{"login":"manuel-guilbault","id":718466,"avatar_url":"https://avatars.githubusercontent.com/u/718466?v=3","gravatar_id":"","url":"https://api.github.com/users/manuel-guilbault","html_url":"https://github.com/manuel-guilbault","followers_url":"https://api.github.com/users/manuel-guilbault/followers","following_url":"https://api.github.com/users/manuel-guilbault/following{/other_user}","gists_url":"https://api.github.com/users/manuel-guilbault/gists{/gist_id}","starred_url":"https://api.github.com/users/manuel-guilbault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuel-guilbault/subscriptions","organizations_url":"https://api.github.com/users/manuel-guilbault/orgs","repos_url":"https://api.github.com/users/manuel-guilbault/repos","events_url":"https://api.github.com/users/manuel-guilbault/events{/privacy}","received_events_url":"https://api.github.com/users/manuel-guilbault/received_events","type":"User","site_admin":false},"repo":{"id":68906040,"name":"router","full_name":"manuel-guilbault/router","owner":{"login":"manuel-guilbault","id":718466,"avatar_url":"https://avatars.githubusercontent.com/u/718466?v=3","gravatar_id":"","url":"https://api.github.com/users/manuel-guilbault","html_url":"https://github.com/manuel-guilbault","followers_url":"https://api.github.com/users/manuel-guilbault/followers","following_url":"https://api.github.com/users/manuel-guilbault/following{/other_user}","gists_url":"https://api.github.com/users/manuel-guilbault/gists{/gist_id}","starred_url":"https://api.github.com/users/manuel-guilbault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuel-guilbault/subscriptions","organizations_url":"https://api.github.com/users/manuel-guilbault/orgs","repos_url":"https://api.github.com/users/manuel-guilbault/repos","events_url":"https://api.github.com/users/manuel-guilbault/events{/privacy}","received_events_url":"https://api.github.com/users/manuel-guilbault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manuel-guilbault/router","description":"A powerful client-side router.","fork":true,"url":"https://api.github.com/repos/manuel-guilbault/router","forks_url":"https://api.github.com/repos/manuel-guilbault/router/forks","keys_url":"https://api.github.com/repos/manuel-guilbault/router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manuel-guilbault/router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manuel-guilbault/router/teams","hooks_url":"https://api.github.com/repos/manuel-guilbault/router/hooks","issue_events_url":"https://api.github.com/repos/manuel-guilbault/router/issues/events{/number}","events_url":"https://api.github.com/repos/manuel-guilbault/router/events","assignees_url":"https://api.github.com/repos/manuel-guilbault/router/assignees{/user}","branches_url":"https://api.github.com/repos/manuel-guilbault/router/branches{/branch}","tags_url":"https://api.github.com/repos/manuel-guilbault/router/tags","blobs_url":"https://api.github.com/repos/manuel-guilbault/router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manuel-guilbault/router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manuel-guilbault/router/git/refs{/sha}","trees_url":"https://api.github.com/repos/manuel-guilbault/router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manuel-guilbault/router/statuses/{sha}","languages_url":"https://api.github.com/repos/manuel-guilbault/router/languages","stargazers_url":"https://api.github.com/repos/manuel-guilbault/router/stargazers","contributors_url":"https://api.github.com/repos/manuel-guilbault/router/contributors","subscribers_url":"https://api.github.com/repos/manuel-guilbault/router/subscribers","subscription_url":"https://api.github.com/repos/manuel-guilbault/router/subscription","commits_url":"https://api.github.com/repos/manuel-guilbault/router/commits{/sha}","git_commits_url":"https://api.github.com/repos/manuel-guilbault/router/git/commits{/sha}","comments_url":"https://api.github.com/repos/manuel-guilbault/router/comments{/number}","issue_comment_url":"https://api.github.com/repos/manuel-guilbault/router/issues/comments{/number}","contents_url":"https://api.github.com/repos/manuel-guilbault/router/contents/{+path}","compare_url":"https://api.github.com/repos/manuel-guilbault/router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manuel-guilbault/router/merges","archive_url":"https://api.github.com/repos/manuel-guilbault/router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manuel-guilbault/router/downloads","issues_url":"https://api.github.com/repos/manuel-guilbault/router/issues{/number}","pulls_url":"https://api.github.com/repos/manuel-guilbault/router/pulls{/number}","milestones_url":"https://api.github.com/repos/manuel-guilbault/router/milestones{/number}","notifications_url":"https://api.github.com/repos/manuel-guilbault/router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manuel-guilbault/router/labels{/name}","releases_url":"https://api.github.com/repos/manuel-guilbault/router/releases{/id}","deployments_url":"https://api.github.com/repos/manuel-guilbault/router/deployments","created_at":"2016-09-22T09:28:39Z","updated_at":"2016-09-22T09:28:40Z","pushed_at":"2016-09-27T09:32:29Z","git_url":"git://github.com/manuel-guilbault/router.git","ssh_url":"git@github.com:manuel-guilbault/router.git","clone_url":"https://github.com/manuel-guilbault/router.git","svn_url":"https://github.com/manuel-guilbault/router","homepage":null,"size":1618,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"397d6a73cb19fe2411b791b9025871dd5cb2e7c3","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27788951,"name":"router","full_name":"aurelia/router","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/router","description":"A powerful client-side router.","fork":false,"url":"https://api.github.com/repos/aurelia/router","forks_url":"https://api.github.com/repos/aurelia/router/forks","keys_url":"https://api.github.com/repos/aurelia/router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/router/teams","hooks_url":"https://api.github.com/repos/aurelia/router/hooks","issue_events_url":"https://api.github.com/repos/aurelia/router/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/router/events","assignees_url":"https://api.github.com/repos/aurelia/router/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/router/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/router/tags","blobs_url":"https://api.github.com/repos/aurelia/router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/router/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/router/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/router/languages","stargazers_url":"https://api.github.com/repos/aurelia/router/stargazers","contributors_url":"https://api.github.com/repos/aurelia/router/contributors","subscribers_url":"https://api.github.com/repos/aurelia/router/subscribers","subscription_url":"https://api.github.com/repos/aurelia/router/subscription","commits_url":"https://api.github.com/repos/aurelia/router/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/router/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/router/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/router/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/router/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/router/merges","archive_url":"https://api.github.com/repos/aurelia/router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/router/downloads","issues_url":"https://api.github.com/repos/aurelia/router/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/router/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/router/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/router/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/router/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/router/deployments","created_at":"2014-12-09T21:48:59Z","updated_at":"2016-09-20T20:54:22Z","pushed_at":"2016-09-27T09:32:29Z","git_url":"git://github.com/aurelia/router.git","ssh_url":"git@github.com:aurelia/router.git","clone_url":"https://github.com/aurelia/router.git","svn_url":"https://github.com/aurelia/router","homepage":null,"size":1755,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":60,"forks":82,"open_issues":60,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/router/pulls/409"},"html":{"href":"https://github.com/aurelia/router/pull/409"},"issue":{"href":"https://api.github.com/repos/aurelia/router/issues/409"},"comments":{"href":"https://api.github.com/repos/aurelia/router/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/router/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/router/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/router/statuses/2c40ce1897d35f81cc4684fd0cb300053688553a"}}}}
{"actor":{"display_login":"manuel-guilbault"}}