{"action":"closed","number":377,"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/377","id":55582361,"html_url":"https://github.com/arvidn/libtorrent/pull/377","diff_url":"https://github.com/arvidn/libtorrent/pull/377.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/377.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/377","number":377,"state":"closed","locked":false,"title":"DHT nodes can NOT share a receive buffer","user":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"body":"While the simulation is single threaded, because async_receive_from_impl uses\r\npost() to invoke the receive handler it is possible for multiple receive\r\nhandlers to be queued up in the io_service at the same time. If this happens\r\nwith a shared receive buffer, the last packet received will overwrite all the\r\nother packets before they are handled.\r\n\r\nThe use of post() is necessary to avoid unbounded recursion in the read handler\r\nso each node must get its own buffer.","created_at":"2016-01-11T02:31:54Z","updated_at":"2016-01-11T03:42:32Z","closed_at":"2016-01-11T03:42:32Z","merged_at":"2016-01-11T03:42:32Z","merge_commit_sha":"61bec41bb187fba774afaad18e458cda5c04b537","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/377/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/377/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/377/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/7b5bdc3be919c7e722c7161ffdcebcb5a182aae0","head":{"label":"ssiloti:dont-share-rx-buf","ref":"dont-share-rx-buf","sha":"7b5bdc3be919c7e722c7161ffdcebcb5a182aae0","user":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"repo":{"id":37429203,"name":"libtorrent","full_name":"ssiloti/libtorrent","owner":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssiloti/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/ssiloti/libtorrent","forks_url":"https://api.github.com/repos/ssiloti/libtorrent/forks","keys_url":"https://api.github.com/repos/ssiloti/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssiloti/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssiloti/libtorrent/teams","hooks_url":"https://api.github.com/repos/ssiloti/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/ssiloti/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/ssiloti/libtorrent/events","assignees_url":"https://api.github.com/repos/ssiloti/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/ssiloti/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/ssiloti/libtorrent/tags","blobs_url":"https://api.github.com/repos/ssiloti/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssiloti/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssiloti/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssiloti/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssiloti/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/ssiloti/libtorrent/languages","stargazers_url":"https://api.github.com/repos/ssiloti/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/ssiloti/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/ssiloti/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/ssiloti/libtorrent/subscription","commits_url":"https://api.github.com/repos/ssiloti/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssiloti/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssiloti/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssiloti/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssiloti/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/ssiloti/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssiloti/libtorrent/merges","archive_url":"https://api.github.com/repos/ssiloti/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssiloti/libtorrent/downloads","issues_url":"https://api.github.com/repos/ssiloti/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/ssiloti/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/ssiloti/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/ssiloti/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssiloti/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/ssiloti/libtorrent/releases{/id}","created_at":"2015-06-14T20:53:10Z","updated_at":"2015-06-14T20:53:20Z","pushed_at":"2016-01-11T02:31:09Z","git_url":"git://github.com/ssiloti/libtorrent.git","ssh_url":"git@github.com:ssiloti/libtorrent.git","clone_url":"https://github.com/ssiloti/libtorrent.git","svn_url":"https://github.com/ssiloti/libtorrent","homepage":"http://libtorrent.org","size":47109,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"4e86c2257a7256e86f404b0b7c0e49c14c9fc3c4","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","created_at":"2015-06-03T05:22:03Z","updated_at":"2016-01-10T22:51:02Z","pushed_at":"2016-01-11T03:42:32Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":63778,"stargazers_count":271,"watchers_count":271,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":45,"forks":82,"open_issues":45,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/377"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/377"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/377"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/7b5bdc3be919c7e722c7161ffdcebcb5a182aae0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":6,"changed_files":1}}