{"action":"created","issue":{"url":"https://api.github.com/repos/percy/percy-web/issues/61","repository_url":"https://api.github.com/repos/percy/percy-web","labels_url":"https://api.github.com/repos/percy/percy-web/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/percy/percy-web/issues/61/comments","events_url":"https://api.github.com/repos/percy/percy-web/issues/61/events","html_url":"https://github.com/percy/percy-web/pull/61","id":194844066,"number":61,"title":"Link to comparison","user":{"login":"mfazekas","id":52435,"avatar_url":"https://avatars.githubusercontent.com/u/52435?v=3","gravatar_id":"","url":"https://api.github.com/users/mfazekas","html_url":"https://github.com/mfazekas","followers_url":"https://api.github.com/users/mfazekas/followers","following_url":"https://api.github.com/users/mfazekas/following{/other_user}","gists_url":"https://api.github.com/users/mfazekas/gists{/gist_id}","starred_url":"https://api.github.com/users/mfazekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfazekas/subscriptions","organizations_url":"https://api.github.com/users/mfazekas/orgs","repos_url":"https://api.github.com/users/mfazekas/repos","events_url":"https://api.github.com/users/mfazekas/events{/privacy}","received_events_url":"https://api.github.com/users/mfazekas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-11T17:28:04Z","updated_at":"2016-12-15T14:47:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/percy/percy-web/pulls/61","html_url":"https://github.com/percy/percy-web/pull/61","diff_url":"https://github.com/percy/percy-web/pull/61.diff","patch_url":"https://github.com/percy/percy-web/pull/61.patch"},"body":"- added ember-route-action\r\n- ~we do scroll to component at didRender as suggested by [guides](https://guides.emberjs.com/v2.10.0/components/the-component-lifecycle/#toc_making-updates-to-the-rendered-dom-with-code-didrender-code), but on intial render we still need a hack to calculate scrolling position.~ used [Intrinsic Placeholders](http://daverupert.com/2015/12/intrinsic-placeholders-with-picture/) so layout does not change as images are loaded - so we can scroll in Ember's didRender.\r\n- keyboard navigation updates queryParams\r\n\r\nTODO:\r\n- add test where left and right image sizes are different.\r\n- refactor code (probably need an image component)"},"comment":{"url":"https://api.github.com/repos/percy/percy-web/issues/comments/267345052","html_url":"https://github.com/percy/percy-web/pull/61#issuecomment-267345052","issue_url":"https://api.github.com/repos/percy/percy-web/issues/61","id":267345052,"user":{"login":"binhums","id":831043,"avatar_url":"https://avatars.githubusercontent.com/u/831043?v=3","gravatar_id":"","url":"https://api.github.com/users/binhums","html_url":"https://github.com/binhums","followers_url":"https://api.github.com/users/binhums/followers","following_url":"https://api.github.com/users/binhums/following{/other_user}","gists_url":"https://api.github.com/users/binhums/gists{/gist_id}","starred_url":"https://api.github.com/users/binhums/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binhums/subscriptions","organizations_url":"https://api.github.com/users/binhums/orgs","repos_url":"https://api.github.com/users/binhums/repos","events_url":"https://api.github.com/users/binhums/events{/privacy}","received_events_url":"https://api.github.com/users/binhums/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T14:47:24Z","updated_at":"2016-12-15T14:47:24Z","body":"NP. I'm looking forward to this feature :)"}}
{"actor":{"display_login":"binhums"}}