{"action":"created","issue":{"url":"https://api.github.com/repos/greenelab/adage-server/issues/18","repository_url":"https://api.github.com/repos/greenelab/adage-server","labels_url":"https://api.github.com/repos/greenelab/adage-server/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/greenelab/adage-server/issues/18/comments","events_url":"https://api.github.com/repos/greenelab/adage-server/issues/18/events","html_url":"https://github.com/greenelab/adage-server/pull/18","id":184055518,"number":18,"title":"Customize eslint rules based on google coding style, and integrate es…","user":{"login":"dongbohu","id":15133253,"avatar_url":"https://avatars.githubusercontent.com/u/15133253?v=3","gravatar_id":"","url":"https://api.github.com/users/dongbohu","html_url":"https://github.com/dongbohu","followers_url":"https://api.github.com/users/dongbohu/followers","following_url":"https://api.github.com/users/dongbohu/following{/other_user}","gists_url":"https://api.github.com/users/dongbohu/gists{/gist_id}","starred_url":"https://api.github.com/users/dongbohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongbohu/subscriptions","organizations_url":"https://api.github.com/users/dongbohu/orgs","repos_url":"https://api.github.com/users/dongbohu/repos","events_url":"https://api.github.com/users/dongbohu/events{/privacy}","received_events_url":"https://api.github.com/users/dongbohu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-19T19:42:15Z","updated_at":"2016-10-19T19:54:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenelab/adage-server/pulls/18","html_url":"https://github.com/greenelab/adage-server/pull/18","diff_url":"https://github.com/greenelab/adage-server/pull/18.diff","patch_url":"https://github.com/greenelab/adage-server/pull/18.patch"},"body":"This PR includes:\r\n* **eslint.google.js** (new file): a clone of Google's eslint rules at **eslint-config-google**. You do **NOT** need to review this file.\r\n* **eslint.conf.js** (new file): includes a few coding style rules of our own. I added some comments in this file to explain what they mean. For more details, please check: http://eslint.org/docs/rules/\r\n* **Gruntfile.js**: modified to integrate eslint into Grunt. Note that since most of the js files in our codebase don't conform to the rules yet, I didn't include **eslint** task into the default **grunt** command. So typing **grunt** won't run **eslint**. You have to type **grunt eslint** to launch it. (Once we cleaned up our codebase, I will add `eslint` task into `build` so that `grunt` command will launch it automatically.\r\n* **package.json**: Removed **eslint** and **eslint-config-google** dependencies, added `grunt-eslint`.\r\n* **build.config.js**: defined a variable for e2e test files.\r\n* A few corrections of typos in **src/README.md** and **src/app/README.md**.  \r\n* Since we are using grunt to take care of eslint, I removed **.eslintrc.yaml**."},"comment":{"url":"https://api.github.com/repos/greenelab/adage-server/issues/comments/254922077","html_url":"https://github.com/greenelab/adage-server/pull/18#issuecomment-254922077","issue_url":"https://api.github.com/repos/greenelab/adage-server/issues/18","id":254922077,"user":{"login":"dongbohu","id":15133253,"avatar_url":"https://avatars.githubusercontent.com/u/15133253?v=3","gravatar_id":"","url":"https://api.github.com/users/dongbohu","html_url":"https://github.com/dongbohu","followers_url":"https://api.github.com/users/dongbohu/followers","following_url":"https://api.github.com/users/dongbohu/following{/other_user}","gists_url":"https://api.github.com/users/dongbohu/gists{/gist_id}","starred_url":"https://api.github.com/users/dongbohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongbohu/subscriptions","organizations_url":"https://api.github.com/users/dongbohu/orgs","repos_url":"https://api.github.com/users/dongbohu/repos","events_url":"https://api.github.com/users/dongbohu/events{/privacy}","received_events_url":"https://api.github.com/users/dongbohu/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T19:54:03Z","updated_at":"2016-10-19T19:54:03Z","body":"About the new eslint config file **eslint.conf.js**, I avoided the default name **.eslintrc.js** because it would be hidden due to the leading dot character. If you prefer running **eslint** (instead of **grunt eslint**) on command line, you can either use **eslint -c eslint.conf.js** or set a shell alias (which is what I did). I also configured emacs editor so that the real-time check will load this file. I am sure the other editors are able to do something similar. \r\n\r\nThat being said, if you guys prefer **.eslintrc.js**, I can change the name back."}}
{"actor":{"display_login":"dongbohu"}}