{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1472","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1472/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1472/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1472/events","html_url":"https://github.com/Microsoft/ChakraCore/pull/1472","id":172259025,"number":1472,"title":"Add Module Loader runtime objects","user":{"login":"boingoing","id":1569843,"avatar_url":"https://avatars.githubusercontent.com/u/1569843?v=3","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-20T07:35:10Z","updated_at":"2016-09-06T17:10:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1472","html_url":"https://github.com/Microsoft/ChakraCore/pull/1472","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1472.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1472.patch"},"body":"Based on the W3C Module Loader spec:\nhttps://whatwg.github.io/loader\n\nIncludes more or less complete implementations of the runtime objects:\n%Registry%\n%RegistryPrototype%\n%Loader%\n%LoaderPrototype%\n%ModuleStatus%\n%ModuleStatusPrototype%\n\nIncludes a stub implementation of %Module%.\n\nMost of the abstract operations in the spec are implemented completely but\nwe are missing some key ones such as SatisfyInstance. The next step will\nbe to merge the existing ModuleRecord implementation with the ModuleStatus\nobject and set of abstract operations.\n\nIn particular, this pull request does not plug-in any of the dependency\ngraph resolution or export name resolution because a refactor of existing\nModuleRecord code is required.\n\nThere are some open issues with the code in this change. For example, it's\nnot clear from the spec what we should do if transforming a promise object\nwith a fulfillment handler returns a non-promise object. It seems possible\nthat user code could replace the constructor property on the promise\ninstance which could cause the transformed promise to be anything. Should\nwe throw here? Should we just wrap whatever the object is in a resolved\npromise? It's not clear. Most of the machinery in the spec requires\npromise objects so I have taken the approach that we should throw anytime\nan object is not a promise when we expect it should be.\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/245020474","html_url":"https://github.com/Microsoft/ChakraCore/pull/1472#issuecomment-245020474","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1472","id":245020474,"user":{"login":"Yongqu","id":6556530,"avatar_url":"https://avatars.githubusercontent.com/u/6556530?v=3","gravatar_id":"","url":"https://api.github.com/users/Yongqu","html_url":"https://github.com/Yongqu","followers_url":"https://api.github.com/users/Yongqu/followers","following_url":"https://api.github.com/users/Yongqu/following{/other_user}","gists_url":"https://api.github.com/users/Yongqu/gists{/gist_id}","starred_url":"https://api.github.com/users/Yongqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yongqu/subscriptions","organizations_url":"https://api.github.com/users/Yongqu/orgs","repos_url":"https://api.github.com/users/Yongqu/repos","events_url":"https://api.github.com/users/Yongqu/events{/privacy}","received_events_url":"https://api.github.com/users/Yongqu/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T17:10:26Z","updated_at":"2016-09-06T17:10:26Z","body":":shipit:"}}
{"actor":{"display_login":"Yongqu"}}