{"action":"created","issue":{"url":"https://api.github.com/repos/ooxi/violetland/issues/117","repository_url":"https://api.github.com/repos/ooxi/violetland","labels_url":"https://api.github.com/repos/ooxi/violetland/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/ooxi/violetland/issues/117/comments","events_url":"https://api.github.com/repos/ooxi/violetland/issues/117/events","html_url":"https://github.com/ooxi/violetland/pull/117","id":130167810,"number":117,"title":"Change `LifeForm::WeaponRetForceMod`","user":{"login":"ooxi","id":2611835,"avatar_url":"https://avatars.githubusercontent.com/u/2611835?v=3","gravatar_id":"","url":"https://api.github.com/users/ooxi","html_url":"https://github.com/ooxi","followers_url":"https://api.github.com/users/ooxi/followers","following_url":"https://api.github.com/users/ooxi/following{/other_user}","gists_url":"https://api.github.com/users/ooxi/gists{/gist_id}","starred_url":"https://api.github.com/users/ooxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooxi/subscriptions","organizations_url":"https://api.github.com/users/ooxi/orgs","repos_url":"https://api.github.com/users/ooxi/repos","events_url":"https://api.github.com/users/ooxi/events{/privacy}","received_events_url":"https://api.github.com/users/ooxi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-31T18:55:39Z","updated_at":"2016-02-04T11:28:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ooxi/violetland/pulls/117","html_url":"https://github.com/ooxi/violetland/pull/117","diff_url":"https://github.com/ooxi/violetland/pull/117.diff","patch_url":"https://github.com/ooxi/violetland/pull/117.patch"},"body":"Old formula\r\n\r\n\twep-ret_old(str) = if   str > 1 → 1 - (str - 1) * 1.1\r\n                       else         → 1\r\n\r\nNew formula\r\n\r\n\twep-ret_new(str) = 1 - ( str - 1 ) / ( str + 1 )\r\n\r\n![weaponretforcemod](https://cloud.githubusercontent.com/assets/2611835/12704171/e4ee2ed6-c854-11e5-99b5-feabff3f1248.png)\r\n\r\n`wep-ret_old` is blue, `wep-ret_new` is red. x-axis is strength, y-axis is WeaponRetForceMod. The [default strength of a `LifeForm` is one](https://github.com/ooxi/violetland/blob/master/src/game/lifeforms/LifeForm.cpp#L12) and [increases slowly](https://github.com/ooxi/violetland/blob/master/src/windows/CharStatsWindow.cpp#L194)."},"comment":{"url":"https://api.github.com/repos/ooxi/violetland/issues/comments/179781570","html_url":"https://github.com/ooxi/violetland/pull/117#issuecomment-179781570","issue_url":"https://api.github.com/repos/ooxi/violetland/issues/117","id":179781570,"user":{"login":"bla-rs","id":16621384,"avatar_url":"https://avatars.githubusercontent.com/u/16621384?v=3","gravatar_id":"","url":"https://api.github.com/users/bla-rs","html_url":"https://github.com/bla-rs","followers_url":"https://api.github.com/users/bla-rs/followers","following_url":"https://api.github.com/users/bla-rs/following{/other_user}","gists_url":"https://api.github.com/users/bla-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/bla-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bla-rs/subscriptions","organizations_url":"https://api.github.com/users/bla-rs/orgs","repos_url":"https://api.github.com/users/bla-rs/repos","events_url":"https://api.github.com/users/bla-rs/events{/privacy}","received_events_url":"https://api.github.com/users/bla-rs/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T11:28:23Z","updated_at":"2016-02-04T11:28:23Z","body":"Hey,\r\nsorry for letting you wait so long.\r\n\r\nI am very busy for about the next 3 weeks and i have to put VL on hold for that period.\r\n\r\nThe reason why i turned to the ability behavior is, that some skills (esp. MaxSpeed and ChanceToEvade) progress linear and at some point it breaks the gameplay.\r\nWith the old methods, it is possible to get a ChaceToEvade above 100% and the agility influence on MaxSpeed was too high, at some point MaxSpeed is too fast, in my opinion.\r\nSo i decreased the effect not only of agility but of all attributes and made the experience/level progression faster to compensate.\r\nThats why i put divisions everywhere, to make the skills approximate a certain value.\r\n\r\nThe WeaponRetForceMod() ... i just looked in the code and i am not sure now ...\r\nIt plays a role in AccuracyDeviation and once you have Strength > 1.9, every weapon is 100% accurate no matter what weapon and how often you fire.\r\n\r\nAgain, sorry for my chaotic commissions. I better slow it down, comment and test some more and make merge/pull requests for every tiny bit separately (against the right branch).\r\n\r\nThere have to be made some more adjustments.\r\nI believe the angular exchange is incorrect in some situations and also the changes to ReloadSpeedMod() are stupid.\r\nFurther more, these functions return now nasty long floats, which in my case not fit too well in the character stat window and \"return int(foo/bar)\" is too inaccurate.\r\nIll have to take a closer look at all of these things when i can.\r\n\r\nLater Alligator\r\nLars"}}