{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/69732020","id":69732020,"diff_hunk":"@@ -11,14 +11,16 @@\n           </div>\n           <alerts alerts=\"alerts\"></alerts>\n           <div class=\"data-toolbar\">\n-            <ui-select ng-model=\"kindSelector.selected\" theme=\"bootstrap\" search-enabled=\"true\" ng-disabled=\"kindSelector.disabled\" title=\"Choose a resource\" style=\"width: 250px;\">\n-              <ui-select-match placeholder=\"Choose a resource to list...\">{{$select.selected.kind | humanizeKind : true}}</ui-select-match>\n-              <ui-select-choices repeat=\"kind in kinds | filter : {kind: $select.search} : matchKind | orderBy : 'kind'\">\n-                <div ng-bind-html=\"(kind.kind | humanizeKind : true) | highlight: $select.search\"></div>\n-              </ui-select-choices>\n-            </ui-select>\n+            <div class=\"col-xs-4 col-sm-4 col-md-2 pad-left-none pad-right-none\">","path":"app/views/other-resources.html","position":10,"original_position":10,"commit_id":"75d7661873a8b779be3ec596ba59c07cc58ea218","original_commit_id":"75d7661873a8b779be3ec596ba59c07cc58ea218","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"I think this works here, but just a quick note. I tend to avoid mixing bootstrap classes w/classes that also affect margin/padding/float on the same DOM node.  The reason being that its helpful to keep bootstraps class behavior predictable for mobile resize, etc.\r\n\r\nA quick example:\r\n\r\n```html\r\n<div class=\"row\">\r\n  <div class=\"col-md-5\">\r\n     <div class=\"my-class\">Hello</div> <!-- nested 'my-class' can have margin,padding,etc w/o breaking the grid -->\r\n  </div>\r\n  <div class=\"col-md-7\">\r\n    <div class=\"my-other-class\">World</div> <!-- same -->\r\n  </div>\r\n</div>\r\n```\r\n","created_at":"2016-07-06T13:44:35Z","updated_at":"2016-07-06T13:44:35Z","html_url":"https://github.com/openshift/origin-web-console/pull/130#discussion_r69732020","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/69732020"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/130#discussion_r69732020"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/130","id":76035703,"html_url":"https://github.com/openshift/origin-web-console/pull/130","diff_url":"https://github.com/openshift/origin-web-console/pull/130.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/130.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/130","number":130,"state":"open","locked":false,"title":"Issue #123 - Other Resource Page Select 100% Width Bug","user":{"login":"MarkDeMaria","id":19572090,"avatar_url":"https://avatars.githubusercontent.com/u/19572090?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDeMaria","html_url":"https://github.com/MarkDeMaria","followers_url":"https://api.github.com/users/MarkDeMaria/followers","following_url":"https://api.github.com/users/MarkDeMaria/following{/other_user}","gists_url":"https://api.github.com/users/MarkDeMaria/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDeMaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDeMaria/subscriptions","organizations_url":"https://api.github.com/users/MarkDeMaria/orgs","repos_url":"https://api.github.com/users/MarkDeMaria/repos","events_url":"https://api.github.com/users/MarkDeMaria/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDeMaria/received_events","type":"User","site_admin":false},"body":"Fixes #123 \r\n\r\nMoves ui-select tag inside of a constraining div to ensure it never goes beyond its intended bounds.\r\n\r\n@benjaminapetersen ","created_at":"2016-07-01T20:56:25Z","updated_at":"2016-07-06T13:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fecb8797191dc56ea53e7080b063ebee0fa4ed2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/130/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/130/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/130/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/75d7661873a8b779be3ec596ba59c07cc58ea218","head":{"label":"MarkDeMaria:iss123OtherResourcesSelectBug","ref":"iss123OtherResourcesSelectBug","sha":"75d7661873a8b779be3ec596ba59c07cc58ea218","user":{"login":"MarkDeMaria","id":19572090,"avatar_url":"https://avatars.githubusercontent.com/u/19572090?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDeMaria","html_url":"https://github.com/MarkDeMaria","followers_url":"https://api.github.com/users/MarkDeMaria/followers","following_url":"https://api.github.com/users/MarkDeMaria/following{/other_user}","gists_url":"https://api.github.com/users/MarkDeMaria/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDeMaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDeMaria/subscriptions","organizations_url":"https://api.github.com/users/MarkDeMaria/orgs","repos_url":"https://api.github.com/users/MarkDeMaria/repos","events_url":"https://api.github.com/users/MarkDeMaria/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDeMaria/received_events","type":"User","site_admin":false},"repo":{"id":61154770,"name":"origin-web-console","full_name":"MarkDeMaria/origin-web-console","owner":{"login":"MarkDeMaria","id":19572090,"avatar_url":"https://avatars.githubusercontent.com/u/19572090?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDeMaria","html_url":"https://github.com/MarkDeMaria","followers_url":"https://api.github.com/users/MarkDeMaria/followers","following_url":"https://api.github.com/users/MarkDeMaria/following{/other_user}","gists_url":"https://api.github.com/users/MarkDeMaria/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDeMaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDeMaria/subscriptions","organizations_url":"https://api.github.com/users/MarkDeMaria/orgs","repos_url":"https://api.github.com/users/MarkDeMaria/repos","events_url":"https://api.github.com/users/MarkDeMaria/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDeMaria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkDeMaria/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/MarkDeMaria/origin-web-console","forks_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/forks","keys_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/teams","hooks_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/events","assignees_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/tags","blobs_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/subscription","commits_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/merges","archive_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/downloads","issues_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/MarkDeMaria/origin-web-console/deployments","created_at":"2016-06-14T20:48:52Z","updated_at":"2016-06-14T20:48:54Z","pushed_at":"2016-07-06T13:33:15Z","git_url":"git://github.com/MarkDeMaria/origin-web-console.git","ssh_url":"git@github.com:MarkDeMaria/origin-web-console.git","clone_url":"https://github.com/MarkDeMaria/origin-web-console.git","svn_url":"https://github.com/MarkDeMaria/origin-web-console","homepage":null,"size":6776,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"00a4ca00c5b328523d842bca786aaea0aecac10b","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-06-20T16:37:07Z","pushed_at":"2016-07-06T13:33:15Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":7464,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":39,"forks":25,"open_issues":39,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/130"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/130"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/130"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/75d7661873a8b779be3ec596ba59c07cc58ea218"}}}}
{"actor":{"display_login":"benjaminapetersen"}}