{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43","id":92304724,"html_url":"https://github.com/ajkeller34/Unitful.jl/pull/43","diff_url":"https://github.com/ajkeller34/Unitful.jl/pull/43.diff","patch_url":"https://github.com/ajkeller34/Unitful.jl/pull/43.patch","issue_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/43","number":43,"state":"closed","locked":false,"title":"Allow inversion of unitful matrices","user":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"body":"At least in some cases, the pivot step in the matrix inversion requires\r\nscaling one coefficient by another. However this fails when implemented\r\nin terms of two operations: first an inversion which gives an object\r\nwith an inverse unit (rather than a dimensionless quantity), then a\r\n`*=` multiplication. The second step tries (incorrectly) to change the\r\ndimension of the matrix coefficient to dimensionless.\r\n\r\nThe relevant lines in `linalg/lu.jl` are:\r\n\r\n```Julia\r\nAkkinv = inv(A[k,k])\r\nfor i = k+1:m\r\n    A[i,k] *= Akkinv\r\nend\r\n```\r\n\r\nThis commit hacks an `inv` function for the relevant matrices that first\r\nstrips the units from the matrix.","created_at":"2016-11-04T09:10:29Z","updated_at":"2016-11-28T04:12:36Z","closed_at":"2016-11-28T04:12:36Z","merged_at":"2016-11-28T04:12:36Z","merge_commit_sha":"891c0ad828709786060fc7dc37c62ee27c1f2d98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43/commits","review_comments_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43/comments","review_comment_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/43/comments","statuses_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/statuses/891c0ad828709786060fc7dc37c62ee27c1f2d98","head":{"label":"mdavezac:matrix_inversion","ref":"matrix_inversion","sha":"891c0ad828709786060fc7dc37c62ee27c1f2d98","user":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"repo":{"id":69090113,"name":"Unitful.jl","full_name":"mdavezac/Unitful.jl","owner":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdavezac/Unitful.jl","description":"Unitful.jl ","fork":true,"url":"https://api.github.com/repos/mdavezac/Unitful.jl","forks_url":"https://api.github.com/repos/mdavezac/Unitful.jl/forks","keys_url":"https://api.github.com/repos/mdavezac/Unitful.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdavezac/Unitful.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdavezac/Unitful.jl/teams","hooks_url":"https://api.github.com/repos/mdavezac/Unitful.jl/hooks","issue_events_url":"https://api.github.com/repos/mdavezac/Unitful.jl/issues/events{/number}","events_url":"https://api.github.com/repos/mdavezac/Unitful.jl/events","assignees_url":"https://api.github.com/repos/mdavezac/Unitful.jl/assignees{/user}","branches_url":"https://api.github.com/repos/mdavezac/Unitful.jl/branches{/branch}","tags_url":"https://api.github.com/repos/mdavezac/Unitful.jl/tags","blobs_url":"https://api.github.com/repos/mdavezac/Unitful.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdavezac/Unitful.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdavezac/Unitful.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdavezac/Unitful.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdavezac/Unitful.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/mdavezac/Unitful.jl/languages","stargazers_url":"https://api.github.com/repos/mdavezac/Unitful.jl/stargazers","contributors_url":"https://api.github.com/repos/mdavezac/Unitful.jl/contributors","subscribers_url":"https://api.github.com/repos/mdavezac/Unitful.jl/subscribers","subscription_url":"https://api.github.com/repos/mdavezac/Unitful.jl/subscription","commits_url":"https://api.github.com/repos/mdavezac/Unitful.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdavezac/Unitful.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdavezac/Unitful.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdavezac/Unitful.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdavezac/Unitful.jl/contents/{+path}","compare_url":"https://api.github.com/repos/mdavezac/Unitful.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdavezac/Unitful.jl/merges","archive_url":"https://api.github.com/repos/mdavezac/Unitful.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdavezac/Unitful.jl/downloads","issues_url":"https://api.github.com/repos/mdavezac/Unitful.jl/issues{/number}","pulls_url":"https://api.github.com/repos/mdavezac/Unitful.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/mdavezac/Unitful.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/mdavezac/Unitful.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdavezac/Unitful.jl/labels{/name}","releases_url":"https://api.github.com/repos/mdavezac/Unitful.jl/releases{/id}","deployments_url":"https://api.github.com/repos/mdavezac/Unitful.jl/deployments","created_at":"2016-09-24T08:26:02Z","updated_at":"2016-09-24T08:26:03Z","pushed_at":"2016-11-04T09:10:02Z","git_url":"git://github.com/mdavezac/Unitful.jl.git","ssh_url":"git@github.com:mdavezac/Unitful.jl.git","clone_url":"https://github.com/mdavezac/Unitful.jl.git","svn_url":"https://github.com/mdavezac/Unitful.jl","homepage":null,"size":961,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ajkeller34:master","ref":"master","sha":"5e5c040977bdd1276a2b7c91b8f2b3cfd4b5504f","user":{"login":"ajkeller34","id":7145721,"avatar_url":"https://avatars.githubusercontent.com/u/7145721?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkeller34","html_url":"https://github.com/ajkeller34","followers_url":"https://api.github.com/users/ajkeller34/followers","following_url":"https://api.github.com/users/ajkeller34/following{/other_user}","gists_url":"https://api.github.com/users/ajkeller34/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkeller34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkeller34/subscriptions","organizations_url":"https://api.github.com/users/ajkeller34/orgs","repos_url":"https://api.github.com/users/ajkeller34/repos","events_url":"https://api.github.com/users/ajkeller34/events{/privacy}","received_events_url":"https://api.github.com/users/ajkeller34/received_events","type":"User","site_admin":false},"repo":{"id":51609348,"name":"Unitful.jl","full_name":"ajkeller34/Unitful.jl","owner":{"login":"ajkeller34","id":7145721,"avatar_url":"https://avatars.githubusercontent.com/u/7145721?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkeller34","html_url":"https://github.com/ajkeller34","followers_url":"https://api.github.com/users/ajkeller34/followers","following_url":"https://api.github.com/users/ajkeller34/following{/other_user}","gists_url":"https://api.github.com/users/ajkeller34/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkeller34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkeller34/subscriptions","organizations_url":"https://api.github.com/users/ajkeller34/orgs","repos_url":"https://api.github.com/users/ajkeller34/repos","events_url":"https://api.github.com/users/ajkeller34/events{/privacy}","received_events_url":"https://api.github.com/users/ajkeller34/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajkeller34/Unitful.jl","description":"Physical quantities with arbitrary units","fork":false,"url":"https://api.github.com/repos/ajkeller34/Unitful.jl","forks_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/forks","keys_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/teams","hooks_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/hooks","issue_events_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/events","assignees_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/tags","blobs_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/languages","stargazers_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/stargazers","contributors_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/contributors","subscribers_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/subscribers","subscription_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/subscription","commits_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/merges","archive_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/downloads","issues_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/labels{/name}","releases_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/releases{/id}","deployments_url":"https://api.github.com/repos/ajkeller34/Unitful.jl/deployments","created_at":"2016-02-12T18:56:40Z","updated_at":"2016-11-05T13:36:47Z","pushed_at":"2016-11-28T04:12:36Z","git_url":"git://github.com/ajkeller34/Unitful.jl.git","ssh_url":"git@github.com:ajkeller34/Unitful.jl.git","clone_url":"https://github.com/ajkeller34/Unitful.jl.git","svn_url":"https://github.com/ajkeller34/Unitful.jl","homepage":"","size":952,"stargazers_count":24,"watchers_count":24,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43"},"html":{"href":"https://github.com/ajkeller34/Unitful.jl/pull/43"},"issue":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/43"},"comments":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/ajkeller34/Unitful.jl/statuses/891c0ad828709786060fc7dc37c62ee27c1f2d98"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ajkeller34","id":7145721,"avatar_url":"https://avatars.githubusercontent.com/u/7145721?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkeller34","html_url":"https://github.com/ajkeller34","followers_url":"https://api.github.com/users/ajkeller34/followers","following_url":"https://api.github.com/users/ajkeller34/following{/other_user}","gists_url":"https://api.github.com/users/ajkeller34/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkeller34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkeller34/subscriptions","organizations_url":"https://api.github.com/users/ajkeller34/orgs","repos_url":"https://api.github.com/users/ajkeller34/repos","events_url":"https://api.github.com/users/ajkeller34/events{/privacy}","received_events_url":"https://api.github.com/users/ajkeller34/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"ajkeller34"}}