{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/64290325","id":64290325,"diff_hunk":"@@ -21,18 +21,18 @@\n class Repository implements RepositoryInterface\n {\n     /**\n-     * Repository Handler object.\n+     * SignalDispatcher.\n      *\n-     * @var \\eZ\\Publish\\API\\Repository\\Repository\n+     * @var \\eZ\\Publish\\Core\\SignalSlot\\SignalDispatcher\n      */\n-    protected $repository;\n+    protected $signalDispatcher;\n \n     /**\n-     * SignalDispatcher.\n+     * Repository Handler object.\n      *\n-     * @var \\eZ\\Publish\\Core\\SignalSlot\\SignalDispatcher\n+     * @var \\eZ\\Publish\\API\\Repository\\Repository\n      */\n-    protected $signalDispatcher;\n+    protected $repository;","path":"eZ/Publish/Core/SignalSlot/Repository.php","position":31,"original_position":31,"commit_id":"bb8b6fb621683e78d49fcdcfc2b2b76b69936932","original_commit_id":"bb8b6fb621683e78d49fcdcfc2b2b76b69936932","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"this reordering change can be skipped","created_at":"2016-05-23T21:14:05Z","updated_at":"2016-05-23T21:14:05Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1657#discussion_r64290325","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/64290325"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1657#discussion_r64290325"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657","id":71018764,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1657","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1657.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1657.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1657","number":1657,"state":"open","locked":false,"title":"EZP-25679: Decouple SignalSlot services","user":{"login":"Nattfarinn","id":5822569,"avatar_url":"https://avatars.githubusercontent.com/u/5822569?v=3","gravatar_id":"","url":"https://api.github.com/users/Nattfarinn","html_url":"https://github.com/Nattfarinn","followers_url":"https://api.github.com/users/Nattfarinn/followers","following_url":"https://api.github.com/users/Nattfarinn/following{/other_user}","gists_url":"https://api.github.com/users/Nattfarinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattfarinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattfarinn/subscriptions","organizations_url":"https://api.github.com/users/Nattfarinn/orgs","repos_url":"https://api.github.com/users/Nattfarinn/repos","events_url":"https://api.github.com/users/Nattfarinn/events{/privacy}","received_events_url":"https://api.github.com/users/Nattfarinn/received_events","type":"User","site_admin":false},"body":"Todo list:\r\n- [x] Define all services for reuse by others, inner services remains lazy\r\n- [x] Dependency injection of services into Repository\r\n- [x] Alter SignalSlot repository test cases","created_at":"2016-05-23T07:58:35Z","updated_at":"2016-05-23T21:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3d854d4969b339445ea449686129818dc205249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1657/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/bb8b6fb621683e78d49fcdcfc2b2b76b69936932","head":{"label":"Nattfarinn:ezp-25679","ref":"ezp-25679","sha":"bb8b6fb621683e78d49fcdcfc2b2b76b69936932","user":{"login":"Nattfarinn","id":5822569,"avatar_url":"https://avatars.githubusercontent.com/u/5822569?v=3","gravatar_id":"","url":"https://api.github.com/users/Nattfarinn","html_url":"https://github.com/Nattfarinn","followers_url":"https://api.github.com/users/Nattfarinn/followers","following_url":"https://api.github.com/users/Nattfarinn/following{/other_user}","gists_url":"https://api.github.com/users/Nattfarinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattfarinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattfarinn/subscriptions","organizations_url":"https://api.github.com/users/Nattfarinn/orgs","repos_url":"https://api.github.com/users/Nattfarinn/repos","events_url":"https://api.github.com/users/Nattfarinn/events{/privacy}","received_events_url":"https://api.github.com/users/Nattfarinn/received_events","type":"User","site_admin":false},"repo":{"id":52956591,"name":"ezpublish-kernel","full_name":"Nattfarinn/ezpublish-kernel","owner":{"login":"Nattfarinn","id":5822569,"avatar_url":"https://avatars.githubusercontent.com/u/5822569?v=3","gravatar_id":"","url":"https://api.github.com/users/Nattfarinn","html_url":"https://github.com/Nattfarinn","followers_url":"https://api.github.com/users/Nattfarinn/followers","following_url":"https://api.github.com/users/Nattfarinn/following{/other_user}","gists_url":"https://api.github.com/users/Nattfarinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattfarinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattfarinn/subscriptions","organizations_url":"https://api.github.com/users/Nattfarinn/orgs","repos_url":"https://api.github.com/users/Nattfarinn/repos","events_url":"https://api.github.com/users/Nattfarinn/events{/privacy}","received_events_url":"https://api.github.com/users/Nattfarinn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nattfarinn/ezpublish-kernel","description":"eZ Platform (aka eZ Publish 6.x) kernel","fork":true,"url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel","forks_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/Nattfarinn/ezpublish-kernel/deployments","created_at":"2016-03-02T11:07:29Z","updated_at":"2016-03-02T11:07:38Z","pushed_at":"2016-05-23T10:22:18Z","git_url":"git://github.com/Nattfarinn/ezpublish-kernel.git","ssh_url":"git@github.com:Nattfarinn/ezpublish-kernel.git","clone_url":"https://github.com/Nattfarinn/ezpublish-kernel.git","svn_url":"https://github.com/Nattfarinn/ezpublish-kernel","homepage":"http://ezplatform.com/","size":44505,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"96ade9e8894316a0bf789474c1baab89571bedae","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"eZ Platform (aka eZ Publish 6.x) kernel","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/deployments","created_at":"2011-04-26T08:54:24Z","updated_at":"2016-05-23T13:51:21Z","pushed_at":"2016-05-23T10:22:20Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ezplatform.com/","size":49142,"stargazers_count":112,"watchers_count":112,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":60,"forks":152,"open_issues":60,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1657"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1657"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/bb8b6fb621683e78d49fcdcfc2b2b76b69936932"}}}}
{"actor":{"display_login":"andrerom"}}