{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/63881746","id":63881746,"diff_hunk":"@@ -51,114 +51,91 @@\n   preclean_intf:      true,\n   sys_def_switchport: true,\n   manifest_props:     {\n-    # switchport_mode_private_vlan_host:             no default\n-    switchport_mode_private_vlan_host_association:  'default',\n-    switchport_mode_private_vlan_trunk_promiscuous: 'default',\n-    switchport_mode_private_vlan_trunk_secondary:   'default',\n-    # TBD: BROKEN. Should support 'default' but sends literal 'default'\n-    # instead of doing default behavior.\n-    # switchport_private_vlan_trunk_allowed_vlan:     'default',\n-    switchport_private_vlan_association_trunk:      'default',\n-    switchport_private_vlan_mapping_trunk:          'default',\n-    switchport_private_vlan_trunk_native_vlan:      'default',\n+    switchport_pvlan_host:               'default',\n+    switchport_pvlan_host_association:   'default',\n+    switchport_pvlan_mapping:            'default',\n+    switchport_pvlan_mapping_trunk:      'default',\n+    switchport_pvlan_promiscuous:        'default',\n+    switchport_pvlan_trunk_native_vlan:  'default',\n+    switchport_pvlan_trunk_allowed_vlan: 'default',\n+    switchport_pvlan_trunk_association:  'default',\n+    switchport_pvlan_trunk_promiscuous:  'default',\n+    switchport_pvlan_trunk_secondary:    'default',\n   },\n   resource:           {\n-    switchport_mode_private_vlan_host:              'disabled',\n-    # switchport_mode_private_vlan_host_association: nil,\n-    switchport_mode_private_vlan_trunk_promiscuous: 'false',\n-    switchport_mode_private_vlan_trunk_secondary:   'false',\n-    # switchport_private_vlan_trunk_allowed_vlan:    nil,\n-    # switchport_private_vlan_association_trunk:     nil,\n-    # switchport_private_vlan_mapping_trunk:         nil,\n-    switchport_private_vlan_trunk_native_vlan:      '1',\n+    switchport_pvlan_host:               'false',\n+    # switchport_pvlan_host_association:  nil,","path":"tests/beaker_tests/cisco_interface/test_interface_private_vlan.rb","position":44,"original_position":44,"commit_id":"5a16591ad9b5c5ffe0cd4df2d18a64d6cb2d77e4","original_commit_id":"5a16591ad9b5c5ffe0cd4df2d18a64d6cb2d77e4","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"No - these nil properties don't show up with puppet resource. I thought it would be helpful to put them here as comments so that future coders would understand why they're not part of the resource hash.","created_at":"2016-05-19T13:52:57Z","updated_at":"2016-05-19T13:52:57Z","html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/324#discussion_r63881746","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/63881746"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/324#discussion_r63881746"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324","id":70582946,"html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/324","diff_url":"https://github.com/cisco/cisco-network-puppet-module/pull/324.diff","patch_url":"https://github.com/cisco/cisco-network-puppet-module/pull/324.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/324","number":324,"state":"open","locked":false,"title":"cisco_interface: private_vlan refactor","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"* Deprecated the private_vlan properties that were released with 1.3.0 and created new pvlan properties in their place.\r\n\r\n* This is the companion to NU PR: cisco/cisco-network-node-utils#406\r\n\r\n* Updated Type, Provider, Beaker, Demo, README, and CHANGELOG.\r\n\r\n* Currently only tested on N7, N9-i3. Additional testing in prog.\r\n","created_at":"2016-05-18T19:11:54Z","updated_at":"2016-05-19T13:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"768824ef711524ad2a52122680047d650e45b6c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/324/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/5a16591ad9b5c5ffe0cd4df2d18a64d6cb2d77e4","head":{"label":"chrisvanheuveln:intf_pvlan_2","ref":"intf_pvlan_2","sha":"5a16591ad9b5c5ffe0cd4df2d18a64d6cb2d77e4","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"repo":{"id":57979395,"name":"cisco-network-puppet-module","full_name":"chrisvanheuveln/cisco-network-puppet-module","owner":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module","description":"","fork":true,"url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/deployments","created_at":"2016-05-03T15:20:33Z","updated_at":"2016-05-03T15:20:34Z","pushed_at":"2016-05-19T13:32:48Z","git_url":"git://github.com/chrisvanheuveln/cisco-network-puppet-module.git","ssh_url":"git@github.com:chrisvanheuveln/cisco-network-puppet-module.git","clone_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module.git","svn_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module","homepage":null,"size":3614,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:release_1.3.2","ref":"release_1.3.2","sha":"66a0ca73099c3879e0351ffef81c7ea3f0f82081","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565139,"name":"cisco-network-puppet-module","full_name":"cisco/cisco-network-puppet-module","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-puppet-module","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/deployments","created_at":"2015-07-23T12:06:48Z","updated_at":"2016-05-06T02:51:16Z","pushed_at":"2016-05-19T13:32:49Z","git_url":"git://github.com/cisco/cisco-network-puppet-module.git","ssh_url":"git@github.com:cisco/cisco-network-puppet-module.git","clone_url":"https://github.com/cisco/cisco-network-puppet-module.git","svn_url":"https://github.com/cisco/cisco-network-puppet-module","homepage":null,"size":4126,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":4,"forks":37,"open_issues":4,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/324"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/324"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/5a16591ad9b5c5ffe0cd4df2d18a64d6cb2d77e4"}}}}