{"action":"created","comment":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/comments/76733423","id":76733423,"diff_hunk":"@@ -2,30 +2,31 @@ package cluster\n \n import (\n \t\"sort\"\n-\t\"time\"\n )\n \n // Cluster represents a cluster of Nodes.\n type Cluster struct {\n \tstate    *state\n \treqCh    chan interface{}\n-\tch       chan interface{}\n-\tupdateCh chan []NodeUpdate\n+\tupdateCh chan ClusterUpdate\n \tsubs     []chan []NodeUpdate\n }\n \n+// Clusters can be updated in two ways:\n+// *) a new state of the Cluster, which is a []Node\n+// *) updates to specific Nodes, which is a []NodeUpdate\n+type ClusterUpdate interface{}","path":"cloud/cluster/cluster.go","position":20,"original_position":20,"commit_id":"b9a0f3262704c089868c45e69426ef20625e29da","original_commit_id":"dff7da5c95440e692ac2894d2a3ad966b4aee4e0","user":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"body":"chan Nodes is not the same type as chan cluster.ClusterUpdate\r\n\r\nSo just making the Cron wouldn't be possible because it returns a chan cluster.ClusterUpdate","created_at":"2016-08-30T05:44:19Z","updated_at":"2016-08-30T05:44:19Z","html_url":"https://github.com/scootdev/scoot/pull/89#discussion_r76733423","pull_request_url":"https://api.github.com/repos/scootdev/scoot/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments/76733423"},"html":{"href":"https://github.com/scootdev/scoot/pull/89#discussion_r76733423"},"pull_request":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/89","id":83194294,"html_url":"https://github.com/scootdev/scoot/pull/89","diff_url":"https://github.com/scootdev/scoot/pull/89.diff","patch_url":"https://github.com/scootdev/scoot/pull/89.patch","issue_url":"https://api.github.com/repos/scootdev/scoot/issues/89","number":89,"state":"open","locked":false,"title":"cloud/cluster: simplify construction","user":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"body":"I found that I couldn't easily change the duration on the fetch cron because it was pulled in.\r\n\r\nI made a few changes to make things more injected instead of constructed at the same time.\r\n\r\nGot rid of all functions Subcribe(), which don't make sense outside of the context of a Cluster.","created_at":"2016-08-30T01:21:22Z","updated_at":"2016-08-30T05:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfc7f31973299eba53722afe96b8ef88e781d3f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scootdev/scoot/pulls/89/commits","review_comments_url":"https://api.github.com/repos/scootdev/scoot/pulls/89/comments","review_comment_url":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scootdev/scoot/issues/89/comments","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/b9a0f3262704c089868c45e69426ef20625e29da","head":{"label":"dbentley:dbentley/cluster_stuff","ref":"dbentley/cluster_stuff","sha":"b9a0f3262704c089868c45e69426ef20625e29da","user":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"repo":{"id":60234631,"name":"scoot","full_name":"dbentley/scoot","owner":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbentley/scoot","description":"","fork":true,"url":"https://api.github.com/repos/dbentley/scoot","forks_url":"https://api.github.com/repos/dbentley/scoot/forks","keys_url":"https://api.github.com/repos/dbentley/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbentley/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbentley/scoot/teams","hooks_url":"https://api.github.com/repos/dbentley/scoot/hooks","issue_events_url":"https://api.github.com/repos/dbentley/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/dbentley/scoot/events","assignees_url":"https://api.github.com/repos/dbentley/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/dbentley/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/dbentley/scoot/tags","blobs_url":"https://api.github.com/repos/dbentley/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbentley/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbentley/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbentley/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbentley/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/dbentley/scoot/languages","stargazers_url":"https://api.github.com/repos/dbentley/scoot/stargazers","contributors_url":"https://api.github.com/repos/dbentley/scoot/contributors","subscribers_url":"https://api.github.com/repos/dbentley/scoot/subscribers","subscription_url":"https://api.github.com/repos/dbentley/scoot/subscription","commits_url":"https://api.github.com/repos/dbentley/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbentley/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbentley/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbentley/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbentley/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/dbentley/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbentley/scoot/merges","archive_url":"https://api.github.com/repos/dbentley/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbentley/scoot/downloads","issues_url":"https://api.github.com/repos/dbentley/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/dbentley/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/dbentley/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/dbentley/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbentley/scoot/labels{/name}","releases_url":"https://api.github.com/repos/dbentley/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/dbentley/scoot/deployments","created_at":"2016-06-02T05:17:53Z","updated_at":"2016-06-02T05:17:54Z","pushed_at":"2016-08-30T05:01:11Z","git_url":"git://github.com/dbentley/scoot.git","ssh_url":"git@github.com:dbentley/scoot.git","clone_url":"https://github.com/dbentley/scoot.git","svn_url":"https://github.com/dbentley/scoot","homepage":null,"size":7199,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scootdev:master","ref":"master","sha":"dd063b9b59e77bfa8dd413b53dbecda03cdf4d3f","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":"","fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-08-09T23:32:59Z","pushed_at":"2016-08-30T05:01:12Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":null,"size":7347,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/89"},"html":{"href":"https://github.com/scootdev/scoot/pull/89"},"issue":{"href":"https://api.github.com/repos/scootdev/scoot/issues/89"},"comments":{"href":"https://api.github.com/repos/scootdev/scoot/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/scootdev/scoot/statuses/b9a0f3262704c089868c45e69426ef20625e29da"}}}}
{"actor":{"display_login":"dbentley"}}