{"action":"created","comment":{"url":"https://api.github.com/repos/cduff4464/xpdView/pulls/comments/75790421","id":75790421,"diff_hunk":"@@ -50,15 +51,28 @@ def generate_waterfall(self):\n         None\n         \"\"\"\n         self.ax.cla()\n-        # self.ax.hold(True)\n-        for i in range(0, len(self.key_list)):\n-            temp_x = self.normalized_data[self.key_list[i]][0].copy()\n-            temp_y = self.normalized_data[self.key_list[i]][1].copy()\n-            temp_x += self.x_offset * i\n-            temp_y += self.y_offset * i\n-            self.ax.plot(temp_x, temp_y)\n-        self.ax.autoscale()\n-        self.canvas.draw()\n+        if self.is_normalized:\n+            print(\"normy\")\n+            for i in range(0, len(self.key_list)):\n+                temp_x = self.normalized_data[self.key_list[i]][0].copy()\n+                temp_y = self.normalized_data[self.key_list[i]][1].copy()\n+                temp_x += self.x_offset * i\n+                temp_y += self.y_offset * i\n+                self.ax.plot(temp_x, temp_y)\n+            self.ax.title(\"Data Normalized\")\n+            self.ax.autoscale()\n+            self.canvas.draw()\n+        else:\n+            print(\"4chan\")\n+            for i in range(0, len(self.key_list)):\n+                temp_x = self.data_dict[self.key_list[i]][0].copy()\n+                temp_y = self.data_dict[self.key_list[i]][1].copy()\n+                temp_x += self.x_offset * i\n+                temp_y += self.y_offset * i\n+                self.ax.plot(temp_x, temp_y)\n+            self.ax.title(\"Data not normalized\")\n+            self.ax.autoscale()\n+            self.canvas.draw()\n \n     def normalize_data(self):\n         \"\"\"This method normalizes data for plotting","path":"xpdView/waterfall_2d.py","position":45,"original_position":45,"commit_id":"31e3ca3f67732f9b1020647a4d7d35283a2d8683","original_commit_id":"31e3ca3f67732f9b1020647a4d7d35283a2d8683","user":{"login":"CJ-Wright","id":6740689,"avatar_url":"https://avatars.githubusercontent.com/u/6740689?v=3","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"body":"Also you might look into using `np.nanmax` and its associated min, that way you ignore potential `nan`s","created_at":"2016-08-23T01:35:50Z","updated_at":"2016-08-23T01:35:50Z","html_url":"https://github.com/cduff4464/xpdView/pull/31#discussion_r75790421","pull_request_url":"https://api.github.com/repos/cduff4464/xpdView/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/comments/75790421"},"html":{"href":"https://github.com/cduff4464/xpdView/pull/31#discussion_r75790421"},"pull_request":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/cduff4464/xpdView/pulls/31","id":82288558,"html_url":"https://github.com/cduff4464/xpdView/pull/31","diff_url":"https://github.com/cduff4464/xpdView/pull/31.diff","patch_url":"https://github.com/cduff4464/xpdView/pull/31.patch","issue_url":"https://api.github.com/repos/cduff4464/xpdView/issues/31","number":31,"state":"open","locked":false,"title":"Option for normalizing data in waterfall plot","user":{"login":"JKThanassi","id":10533698,"avatar_url":"https://avatars.githubusercontent.com/u/10533698?v=3","gravatar_id":"","url":"https://api.github.com/users/JKThanassi","html_url":"https://github.com/JKThanassi","followers_url":"https://api.github.com/users/JKThanassi/followers","following_url":"https://api.github.com/users/JKThanassi/following{/other_user}","gists_url":"https://api.github.com/users/JKThanassi/gists{/gist_id}","starred_url":"https://api.github.com/users/JKThanassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKThanassi/subscriptions","organizations_url":"https://api.github.com/users/JKThanassi/orgs","repos_url":"https://api.github.com/users/JKThanassi/repos","events_url":"https://api.github.com/users/JKThanassi/events{/privacy}","received_events_url":"https://api.github.com/users/JKThanassi/received_events","type":"User","site_admin":false},"body":"As of right now the button is in place but the graph is not updating. Will finish fixing it tomorrow.","created_at":"2016-08-23T01:06:25Z","updated_at":"2016-08-23T01:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79470af3406925ef23461daf9ddd927c4683e492","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cduff4464/xpdView/pulls/31/commits","review_comments_url":"https://api.github.com/repos/cduff4464/xpdView/pulls/31/comments","review_comment_url":"https://api.github.com/repos/cduff4464/xpdView/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cduff4464/xpdView/issues/31/comments","statuses_url":"https://api.github.com/repos/cduff4464/xpdView/statuses/31e3ca3f67732f9b1020647a4d7d35283a2d8683","head":{"label":"JKThanassi:normalizing_option","ref":"normalizing_option","sha":"31e3ca3f67732f9b1020647a4d7d35283a2d8683","user":{"login":"JKThanassi","id":10533698,"avatar_url":"https://avatars.githubusercontent.com/u/10533698?v=3","gravatar_id":"","url":"https://api.github.com/users/JKThanassi","html_url":"https://github.com/JKThanassi","followers_url":"https://api.github.com/users/JKThanassi/followers","following_url":"https://api.github.com/users/JKThanassi/following{/other_user}","gists_url":"https://api.github.com/users/JKThanassi/gists{/gist_id}","starred_url":"https://api.github.com/users/JKThanassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKThanassi/subscriptions","organizations_url":"https://api.github.com/users/JKThanassi/orgs","repos_url":"https://api.github.com/users/JKThanassi/repos","events_url":"https://api.github.com/users/JKThanassi/events{/privacy}","received_events_url":"https://api.github.com/users/JKThanassi/received_events","type":"User","site_admin":false},"repo":{"id":64398091,"name":"xpdView","full_name":"JKThanassi/xpdView","owner":{"login":"JKThanassi","id":10533698,"avatar_url":"https://avatars.githubusercontent.com/u/10533698?v=3","gravatar_id":"","url":"https://api.github.com/users/JKThanassi","html_url":"https://github.com/JKThanassi","followers_url":"https://api.github.com/users/JKThanassi/followers","following_url":"https://api.github.com/users/JKThanassi/following{/other_user}","gists_url":"https://api.github.com/users/JKThanassi/gists{/gist_id}","starred_url":"https://api.github.com/users/JKThanassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKThanassi/subscriptions","organizations_url":"https://api.github.com/users/JKThanassi/orgs","repos_url":"https://api.github.com/users/JKThanassi/repos","events_url":"https://api.github.com/users/JKThanassi/events{/privacy}","received_events_url":"https://api.github.com/users/JKThanassi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JKThanassi/xpdView","description":null,"fork":true,"url":"https://api.github.com/repos/JKThanassi/xpdView","forks_url":"https://api.github.com/repos/JKThanassi/xpdView/forks","keys_url":"https://api.github.com/repos/JKThanassi/xpdView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JKThanassi/xpdView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JKThanassi/xpdView/teams","hooks_url":"https://api.github.com/repos/JKThanassi/xpdView/hooks","issue_events_url":"https://api.github.com/repos/JKThanassi/xpdView/issues/events{/number}","events_url":"https://api.github.com/repos/JKThanassi/xpdView/events","assignees_url":"https://api.github.com/repos/JKThanassi/xpdView/assignees{/user}","branches_url":"https://api.github.com/repos/JKThanassi/xpdView/branches{/branch}","tags_url":"https://api.github.com/repos/JKThanassi/xpdView/tags","blobs_url":"https://api.github.com/repos/JKThanassi/xpdView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JKThanassi/xpdView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JKThanassi/xpdView/git/refs{/sha}","trees_url":"https://api.github.com/repos/JKThanassi/xpdView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JKThanassi/xpdView/statuses/{sha}","languages_url":"https://api.github.com/repos/JKThanassi/xpdView/languages","stargazers_url":"https://api.github.com/repos/JKThanassi/xpdView/stargazers","contributors_url":"https://api.github.com/repos/JKThanassi/xpdView/contributors","subscribers_url":"https://api.github.com/repos/JKThanassi/xpdView/subscribers","subscription_url":"https://api.github.com/repos/JKThanassi/xpdView/subscription","commits_url":"https://api.github.com/repos/JKThanassi/xpdView/commits{/sha}","git_commits_url":"https://api.github.com/repos/JKThanassi/xpdView/git/commits{/sha}","comments_url":"https://api.github.com/repos/JKThanassi/xpdView/comments{/number}","issue_comment_url":"https://api.github.com/repos/JKThanassi/xpdView/issues/comments{/number}","contents_url":"https://api.github.com/repos/JKThanassi/xpdView/contents/{+path}","compare_url":"https://api.github.com/repos/JKThanassi/xpdView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JKThanassi/xpdView/merges","archive_url":"https://api.github.com/repos/JKThanassi/xpdView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JKThanassi/xpdView/downloads","issues_url":"https://api.github.com/repos/JKThanassi/xpdView/issues{/number}","pulls_url":"https://api.github.com/repos/JKThanassi/xpdView/pulls{/number}","milestones_url":"https://api.github.com/repos/JKThanassi/xpdView/milestones{/number}","notifications_url":"https://api.github.com/repos/JKThanassi/xpdView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JKThanassi/xpdView/labels{/name}","releases_url":"https://api.github.com/repos/JKThanassi/xpdView/releases{/id}","deployments_url":"https://api.github.com/repos/JKThanassi/xpdView/deployments","created_at":"2016-07-28T13:31:39Z","updated_at":"2016-07-28T13:31:40Z","pushed_at":"2016-08-23T00:45:35Z","git_url":"git://github.com/JKThanassi/xpdView.git","ssh_url":"git@github.com:JKThanassi/xpdView.git","clone_url":"https://github.com/JKThanassi/xpdView.git","svn_url":"https://github.com/JKThanassi/xpdView","homepage":null,"size":374,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cduff4464:master","ref":"master","sha":"fb8d22dc0c0008e5877766f1ef345cc409bb3ce6","user":{"login":"cduff4464","id":19697691,"avatar_url":"https://avatars.githubusercontent.com/u/19697691?v=3","gravatar_id":"","url":"https://api.github.com/users/cduff4464","html_url":"https://github.com/cduff4464","followers_url":"https://api.github.com/users/cduff4464/followers","following_url":"https://api.github.com/users/cduff4464/following{/other_user}","gists_url":"https://api.github.com/users/cduff4464/gists{/gist_id}","starred_url":"https://api.github.com/users/cduff4464/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cduff4464/subscriptions","organizations_url":"https://api.github.com/users/cduff4464/orgs","repos_url":"https://api.github.com/users/cduff4464/repos","events_url":"https://api.github.com/users/cduff4464/events{/privacy}","received_events_url":"https://api.github.com/users/cduff4464/received_events","type":"User","site_admin":false},"repo":{"id":64397306,"name":"xpdView","full_name":"cduff4464/xpdView","owner":{"login":"cduff4464","id":19697691,"avatar_url":"https://avatars.githubusercontent.com/u/19697691?v=3","gravatar_id":"","url":"https://api.github.com/users/cduff4464","html_url":"https://github.com/cduff4464","followers_url":"https://api.github.com/users/cduff4464/followers","following_url":"https://api.github.com/users/cduff4464/following{/other_user}","gists_url":"https://api.github.com/users/cduff4464/gists{/gist_id}","starred_url":"https://api.github.com/users/cduff4464/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cduff4464/subscriptions","organizations_url":"https://api.github.com/users/cduff4464/orgs","repos_url":"https://api.github.com/users/cduff4464/repos","events_url":"https://api.github.com/users/cduff4464/events{/privacy}","received_events_url":"https://api.github.com/users/cduff4464/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cduff4464/xpdView","description":"This repository hold the code the viewing software used at the XPD, 28-ID beam line.","fork":false,"url":"https://api.github.com/repos/cduff4464/xpdView","forks_url":"https://api.github.com/repos/cduff4464/xpdView/forks","keys_url":"https://api.github.com/repos/cduff4464/xpdView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cduff4464/xpdView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cduff4464/xpdView/teams","hooks_url":"https://api.github.com/repos/cduff4464/xpdView/hooks","issue_events_url":"https://api.github.com/repos/cduff4464/xpdView/issues/events{/number}","events_url":"https://api.github.com/repos/cduff4464/xpdView/events","assignees_url":"https://api.github.com/repos/cduff4464/xpdView/assignees{/user}","branches_url":"https://api.github.com/repos/cduff4464/xpdView/branches{/branch}","tags_url":"https://api.github.com/repos/cduff4464/xpdView/tags","blobs_url":"https://api.github.com/repos/cduff4464/xpdView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cduff4464/xpdView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cduff4464/xpdView/git/refs{/sha}","trees_url":"https://api.github.com/repos/cduff4464/xpdView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cduff4464/xpdView/statuses/{sha}","languages_url":"https://api.github.com/repos/cduff4464/xpdView/languages","stargazers_url":"https://api.github.com/repos/cduff4464/xpdView/stargazers","contributors_url":"https://api.github.com/repos/cduff4464/xpdView/contributors","subscribers_url":"https://api.github.com/repos/cduff4464/xpdView/subscribers","subscription_url":"https://api.github.com/repos/cduff4464/xpdView/subscription","commits_url":"https://api.github.com/repos/cduff4464/xpdView/commits{/sha}","git_commits_url":"https://api.github.com/repos/cduff4464/xpdView/git/commits{/sha}","comments_url":"https://api.github.com/repos/cduff4464/xpdView/comments{/number}","issue_comment_url":"https://api.github.com/repos/cduff4464/xpdView/issues/comments{/number}","contents_url":"https://api.github.com/repos/cduff4464/xpdView/contents/{+path}","compare_url":"https://api.github.com/repos/cduff4464/xpdView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cduff4464/xpdView/merges","archive_url":"https://api.github.com/repos/cduff4464/xpdView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cduff4464/xpdView/downloads","issues_url":"https://api.github.com/repos/cduff4464/xpdView/issues{/number}","pulls_url":"https://api.github.com/repos/cduff4464/xpdView/pulls{/number}","milestones_url":"https://api.github.com/repos/cduff4464/xpdView/milestones{/number}","notifications_url":"https://api.github.com/repos/cduff4464/xpdView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cduff4464/xpdView/labels{/name}","releases_url":"https://api.github.com/repos/cduff4464/xpdView/releases{/id}","deployments_url":"https://api.github.com/repos/cduff4464/xpdView/deployments","created_at":"2016-07-28T13:20:14Z","updated_at":"2016-08-22T14:12:55Z","pushed_at":"2016-08-23T01:06:25Z","git_url":"git://github.com/cduff4464/xpdView.git","ssh_url":"git@github.com:cduff4464/xpdView.git","clone_url":"https://github.com/cduff4464/xpdView.git","svn_url":"https://github.com/cduff4464/xpdView","homepage":"","size":378,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/31"},"html":{"href":"https://github.com/cduff4464/xpdView/pull/31"},"issue":{"href":"https://api.github.com/repos/cduff4464/xpdView/issues/31"},"comments":{"href":"https://api.github.com/repos/cduff4464/xpdView/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cduff4464/xpdView/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/cduff4464/xpdView/statuses/31e3ca3f67732f9b1020647a4d7d35283a2d8683"}}}}
{"actor":{"display_login":"CJ-Wright"}}