{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/4097","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/4097/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/4097/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/4097/events","html_url":"https://github.com/Automattic/jetpack/pull/4097","id":159290936,"number":4097,"title":"SSO: Better alignment of \"W\" icon","user":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars.githubusercontent.com/u/1126811?v=3","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/jetpack/labels/General","name":"General","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/SSO","name":"SSO","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"c0ffee"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars.githubusercontent.com/u/1126811?v=3","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/35","html_url":"https://github.com/Automattic/jetpack/milestones/4.1","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/35/labels","id":1461071,"number":35,"title":"4.1","description":"","creator":{"login":"jeherve","id":426388,"avatar_url":"https://avatars.githubusercontent.com/u/426388?v=3","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false},"open_issues":270,"closed_issues":87,"state":"open","created_at":"2015-12-15T11:07:52Z","updated_at":"2016-06-09T14:30:15Z","due_on":"2016-06-27T22:00:00Z","closed_at":null},"comments":4,"created_at":"2016-06-08T22:32:55Z","updated_at":"2016-06-09T15:24:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/4097","html_url":"https://github.com/Automattic/jetpack/pull/4097","diff_url":"https://github.com/Automattic/jetpack/pull/4097.diff","patch_url":"https://github.com/Automattic/jetpack/pull/4097.patch"},"body":"This PR fixes the align of the WordPress icon so that it is center with the \"Login with WordPress.com\" text. Also, this PR adds `modules/sso/jetpack-sso-login.css' to the build process so that we create an RTL stylesheet for the SSO CSS that is loaded on `wp-login.php`\r\n\r\ncc @lezama and @dereksmart to test. Pinging @dereksmart since I am changing the `gulpfile.js`, and when blaming, it looked like he was the last to touch a section I changed.\r\n\r\ncc @michaelarestad for design review.\r\n\r\nTo test:\r\n\r\n- Checkout `update/jetpack-sso-styles` branch\r\n- Run `gulp` to build RTL stylehseets\r\n- Ensure that site is connected to WP.com and you have SSO enabled\r\n- Go to `$site/wp-admin`\r\n- You should see something a bit like the first screenshot below (without the logged out notice, of course)\r\n- Once logged in, go to settings and change your site's language to an RTL language (Hebrew, for example\r\n- Log out\r\n- You should now see something like the second screenshot below\r\n  \r\n### After: SSO form\r\n\r\n#### Not RTL\r\n![screen shot 2016-06-08 at 5 14 08 pm](https://cloud.githubusercontent.com/assets/1126811/15913290/aa1af712-2d9e-11e6-9a9f-34f9df43d309.png)\r\n#### RTL\r\n![screen shot 2016-06-08 at 5 14 31 pm](https://cloud.githubusercontent.com/assets/1126811/15913326/e62e4aba-2d9e-11e6-8f2a-d070c19b00f1.png)\r\n\r\n### After: Default login form\r\n\r\n#### Not RTL\r\n![screen shot 2016-06-08 at 5 15 50 pm](https://cloud.githubusercontent.com/assets/1126811/15913353/1bd03c6e-2d9f-11e6-8c90-77b68d4fffa3.png)\r\n\r\n#### RTL\r\n![screen shot 2016-06-08 at 5 14 58 pm](https://cloud.githubusercontent.com/assets/1126811/15913352/1bce1bdc-2d9f-11e6-82d6-fe956de07c44.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/224930573","html_url":"https://github.com/Automattic/jetpack/pull/4097#issuecomment-224930573","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/4097","id":224930573,"user":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars.githubusercontent.com/u/1126811?v=3","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T15:24:23Z","updated_at":"2016-06-09T15:24:23Z","body":"Here are some updated screenshot after making changes:\r\n\r\n![screen shot 2016-06-09 at 10 22 58 am](https://cloud.githubusercontent.com/assets/1126811/15935266/53d8e1aa-2e2c-11e6-80f3-8bd65a0e4fea.png)\r\n![screen shot 2016-06-09 at 10 23 30 am](https://cloud.githubusercontent.com/assets/1126811/15935267/53e82a34-2e2c-11e6-8c45-74e2db0568db.png)\r\n"}}
{"actor":{"display_login":"ebinnion"}}