{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10931","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10931/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10931/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10931/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10931","id":190882531,"number":10931,"title":"storage: send ReplicaState in streaming snapshots","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-11-22T01:19:52Z","updated_at":"2016-11-28T17:39:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10931","html_url":"https://github.com/cockroachdb/cockroach/pull/10931","diff_url":"https://github.com/cockroachdb/cockroach/pull/10931.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10931.patch"},"body":"This removes the need to read ReplicaState from the batch when applying\na snapshot, allowing the use of a write-only RocksDB batch. The\nwrite-only RocksDB batch does not index keys on insertion/deletion which\nis only necessary if those keys are read.\n\nFixes #10783\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10931)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/263339108","html_url":"https://github.com/cockroachdb/cockroach/pull/10931#issuecomment-263339108","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10931","id":263339108,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T17:39:46Z","updated_at":"2016-11-28T17:39:46Z","body":"...that's not an argument - either we make evidence-based decisions, or we\ndo not.\n\nOn Mon, Nov 28, 2016 at 12:29 PM, Peter Mattis <notifications@github.com>\nwrote:\n\n> I'm not saying that growing the stack is never problematic, but without\n> demonstrating that it is problematic in this instance, that argument does\n> not hold water.\n>\n> Justifying every use of pointer vs value via a benchmark will ensure that\n> we'll almost always use values.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cockroachdb/cockroach/pull/10931#issuecomment-263336286>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABdsPG_iR1asMb-0d0vtOoU4Dx1hD8peks5rCw99gaJpZM4K45h->\n> .\n>\n"}}
{"actor":{"display_login":"tamird"}}