{"action":"created","issue":{"url":"https://api.github.com/repos/spf13/hugo/issues/2303","repository_url":"https://api.github.com/repos/spf13/hugo","labels_url":"https://api.github.com/repos/spf13/hugo/issues/2303/labels{/name}","comments_url":"https://api.github.com/repos/spf13/hugo/issues/2303/comments","events_url":"https://api.github.com/repos/spf13/hugo/issues/2303/events","html_url":"https://github.com/spf13/hugo/pull/2303","id":167603432,"number":2303,"title":"Finish the multilingual feature","user":{"login":"bep","id":394382,"avatar_url":"https://avatars.githubusercontent.com/u/394382?v=3","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spf13/hugo/labels/status/pending%20review","name":"status/pending review","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"spf13","id":173412,"avatar_url":"https://avatars.githubusercontent.com/u/173412?v=3","gravatar_id":"","url":"https://api.github.com/users/spf13","html_url":"https://github.com/spf13","followers_url":"https://api.github.com/users/spf13/followers","following_url":"https://api.github.com/users/spf13/following{/other_user}","gists_url":"https://api.github.com/users/spf13/gists{/gist_id}","starred_url":"https://api.github.com/users/spf13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spf13/subscriptions","organizations_url":"https://api.github.com/users/spf13/orgs","repos_url":"https://api.github.com/users/spf13/repos","events_url":"https://api.github.com/users/spf13/events{/privacy}","received_events_url":"https://api.github.com/users/spf13/received_events","type":"User","site_admin":false},"assignees":[{"login":"spf13","id":173412,"avatar_url":"https://avatars.githubusercontent.com/u/173412?v=3","gravatar_id":"","url":"https://api.github.com/users/spf13","html_url":"https://github.com/spf13","followers_url":"https://api.github.com/users/spf13/followers","following_url":"https://api.github.com/users/spf13/following{/other_user}","gists_url":"https://api.github.com/users/spf13/gists{/gist_id}","starred_url":"https://api.github.com/users/spf13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spf13/subscriptions","organizations_url":"https://api.github.com/users/spf13/orgs","repos_url":"https://api.github.com/users/spf13/repos","events_url":"https://api.github.com/users/spf13/events{/privacy}","received_events_url":"https://api.github.com/users/spf13/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spf13/hugo/milestones/10","html_url":"https://github.com/spf13/hugo/milestones/v0.17","labels_url":"https://api.github.com/repos/spf13/hugo/milestones/10/labels","id":1764196,"number":10,"title":"v0.17","description":"","creator":{"login":"anthonyfok","id":1274764,"avatar_url":"https://avatars.githubusercontent.com/u/1274764?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyfok","html_url":"https://github.com/anthonyfok","followers_url":"https://api.github.com/users/anthonyfok/followers","following_url":"https://api.github.com/users/anthonyfok/following{/other_user}","gists_url":"https://api.github.com/users/anthonyfok/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyfok/subscriptions","organizations_url":"https://api.github.com/users/anthonyfok/orgs","repos_url":"https://api.github.com/users/anthonyfok/repos","events_url":"https://api.github.com/users/anthonyfok/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyfok/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":19,"state":"open","created_at":"2016-05-13T09:23:41Z","updated_at":"2016-08-20T19:33:15Z","due_on":null,"closed_at":null},"comments":35,"created_at":"2016-07-26T13:12:02Z","updated_at":"2016-08-31T21:55:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spf13/hugo/pulls/2303","html_url":"https://github.com/spf13/hugo/pull/2303","diff_url":"https://github.com/spf13/hugo/pull/2303.diff","patch_url":"https://github.com/spf13/hugo/pull/2303.patch"},"body":"This is currently slightly slower than master in a bench mark with 4 fairly big sites:\r\n\r\n```\r\nbenchmark           old ns/op      new ns/op      delta\r\nBenchmarkHugo-4     3146033049     3225819889     +2.54%\r\n\r\nbenchmark           old allocs     new allocs     delta\r\nBenchmarkHugo-4     10557704       10850988       +2.78%\r\n\r\nbenchmark           old bytes      new bytes      delta\r\nBenchmarkHugo-4     1628022920     1632976488     +0.30%\r\n```\r\n\r\nI guess this is mostly about doing \"more work\". I have done some general tuning in another PR (see #2378) after some profile work.\r\n\r\n\r\n\r\n* [x] Add `Translations` and `AllTranslations` to Node.\r\n* [x] Rework the site build process. Looping every site/language and doing the same for all of them kind of works, but isn't very effective nor elegant. Needs to extract the common tasks and do it once only.\r\n* [x] Rework the documentation.\r\n* [x] Fix all the `TODO(bep) multilingo` and  `TODO(bep) ml` comments.\r\n* [x] Check the relevant URL funcs, `absURL` etc.\r\n* [x] Add more tests\r\n* [x]  Write redirect page to default lang on / when multilingual\r\n* [x]  Write a global sitemap.xml\r\n* [x]  Check that taxonomies can be configured on a per language basis\r\n* [x] Add YAML config test  \r\n* [x]  Check sitemap per language\r\n* [x]  Check list command etc.\r\n* [x] Move shortcode handling to \"pre render\". The site isn't really ready at the current point where the shortcodes gets rendered, which comes as a surprise to many. This is even more true now with the multilanguage feature (Site.Pages etc. will be empty). So we need to move this handling to a later stage.\r\n* [x]  Watch: Handling adding and removing languages\r\n* [x]  Check Blackfriday config per site\r\n* [x]  Livereload inject\r\n* [x] Check ref, relref  \r\n* [x] implement https://github.com/spf13/hugo/issues/2312\r\n* [x] Improve the default i18n vs missing bundles and translations \r\n* [x] See https://github.com/spf13/hugo/pull/2303/files#diff-d7b04948857565053b55f353ccb2bab2R296 while this is a temporary workaround until we get a proper registry for \"all nodes and pages\", this may be confusing to users expecting the home object in the translations object to be a full blown *home*. Now even the title is kind of wrong when it is set per language. We should fix this if it isn't too hard. A temporary \"node map\" maybe.\r\n* [x] check data in Page.Site.Data from shortcodes + add some data to the ML tests\r\n* [x] fix variables docs section -- there are some old and not valid info there now \r\n* [x] Double check all \"reuse of nodes for RSS etc\"\r\n* [x] Double check the collection transfers\r\n* [x] Check i18n template func in shortcode \r\n* [x]  Check shortcode changes vs livereload\r\n* [x]  Fix Go 1.7 vet issues"},"comment":{"url":"https://api.github.com/repos/spf13/hugo/issues/comments/243915090","html_url":"https://github.com/spf13/hugo/pull/2303#issuecomment-243915090","issue_url":"https://api.github.com/repos/spf13/hugo/issues/2303","id":243915090,"user":{"login":"bep","id":394382,"avatar_url":"https://avatars.githubusercontent.com/u/394382?v=3","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T21:55:52Z","updated_at":"2016-08-31T21:55:52Z","body":"@yitzhakbg please use the forum for questions and marketing."}}
{"actor":{"display_login":"bep"}}