{"action":"created","issue":{"url":"https://api.github.com/repos/bakkerij/notifier/issues/21","repository_url":"https://api.github.com/repos/bakkerij/notifier","labels_url":"https://api.github.com/repos/bakkerij/notifier/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/bakkerij/notifier/issues/21/comments","events_url":"https://api.github.com/repos/bakkerij/notifier/issues/21/events","html_url":"https://github.com/bakkerij/notifier/pull/21","id":183777526,"number":21,"title":"Adds templates config file for managing templates","user":{"login":"suhaboncukcu","id":2428828,"avatar_url":"https://avatars.githubusercontent.com/u/2428828?v=3","gravatar_id":"","url":"https://api.github.com/users/suhaboncukcu","html_url":"https://github.com/suhaboncukcu","followers_url":"https://api.github.com/users/suhaboncukcu/followers","following_url":"https://api.github.com/users/suhaboncukcu/following{/other_user}","gists_url":"https://api.github.com/users/suhaboncukcu/gists{/gist_id}","starred_url":"https://api.github.com/users/suhaboncukcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhaboncukcu/subscriptions","organizations_url":"https://api.github.com/users/suhaboncukcu/orgs","repos_url":"https://api.github.com/users/suhaboncukcu/repos","events_url":"https://api.github.com/users/suhaboncukcu/events{/privacy}","received_events_url":"https://api.github.com/users/suhaboncukcu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bakkerij/notifier/labels/new%20feature","name":"new feature","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"bobmulder","id":5465074,"avatar_url":"https://avatars.githubusercontent.com/u/5465074?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmulder","html_url":"https://github.com/bobmulder","followers_url":"https://api.github.com/users/bobmulder/followers","following_url":"https://api.github.com/users/bobmulder/following{/other_user}","gists_url":"https://api.github.com/users/bobmulder/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmulder/subscriptions","organizations_url":"https://api.github.com/users/bobmulder/orgs","repos_url":"https://api.github.com/users/bobmulder/repos","events_url":"https://api.github.com/users/bobmulder/events{/privacy}","received_events_url":"https://api.github.com/users/bobmulder/received_events","type":"User","site_admin":false},"assignees":[{"login":"bobmulder","id":5465074,"avatar_url":"https://avatars.githubusercontent.com/u/5465074?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmulder","html_url":"https://github.com/bobmulder","followers_url":"https://api.github.com/users/bobmulder/followers","following_url":"https://api.github.com/users/bobmulder/following{/other_user}","gists_url":"https://api.github.com/users/bobmulder/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmulder/subscriptions","organizations_url":"https://api.github.com/users/bobmulder/orgs","repos_url":"https://api.github.com/users/bobmulder/repos","events_url":"https://api.github.com/users/bobmulder/events{/privacy}","received_events_url":"https://api.github.com/users/bobmulder/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-18T19:15:23Z","updated_at":"2016-10-19T17:46:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bakkerij/notifier/pulls/21","html_url":"https://github.com/bakkerij/notifier/pull/21","diff_url":"https://github.com/bakkerij/notifier/pull/21.diff","patch_url":"https://github.com/bakkerij/notifier/pull/21.patch"},"body":"With this improvement;\r\n\r\n- You can use the plugin as it was without changing anything. \r\n- You can create templates in a config file so you don't need to create an instance of utility class if you don't need it. \r\n- Check new ways for templating on readme. "},"comment":{"url":"https://api.github.com/repos/bakkerij/notifier/issues/comments/254888152","html_url":"https://github.com/bakkerij/notifier/pull/21#issuecomment-254888152","issue_url":"https://api.github.com/repos/bakkerij/notifier/issues/21","id":254888152,"user":{"login":"suhaboncukcu","id":2428828,"avatar_url":"https://avatars.githubusercontent.com/u/2428828?v=3","gravatar_id":"","url":"https://api.github.com/users/suhaboncukcu","html_url":"https://github.com/suhaboncukcu","followers_url":"https://api.github.com/users/suhaboncukcu/followers","following_url":"https://api.github.com/users/suhaboncukcu/following{/other_user}","gists_url":"https://api.github.com/users/suhaboncukcu/gists{/gist_id}","starred_url":"https://api.github.com/users/suhaboncukcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhaboncukcu/subscriptions","organizations_url":"https://api.github.com/users/suhaboncukcu/orgs","repos_url":"https://api.github.com/users/suhaboncukcu/repos","events_url":"https://api.github.com/users/suhaboncukcu/events{/privacy}","received_events_url":"https://api.github.com/users/suhaboncukcu/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T17:46:45Z","updated_at":"2016-10-19T17:46:45Z","body":"I'm sorry for my dumbness on this; tests seem to be my weak spot. How can I do that? Would you mind getting in touch on slack/gitter/skype/ etc?\r\n\r\nI can update the docs but then again, shouldn't this be in the \"black box\" for the plugin? I think developers using the plugin shouldn't register the templates themselves via Configure class. There could be an option to -just for an instance- encrypt the templates via a function within the plugin before adding them to Configure. Or let's say we've added an option to be configured to get templates as json objects instead of texts. I think developers should be discouraged to use Configure class to register templates. _It's just my opinion though_  I can add the change in this PR if you are sure about adding Configure description to docs.  :)"}}
{"actor":{"display_login":"suhaboncukcu"}}