{"action":"created","issue":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/607","repository_url":"https://api.github.com/repos/NuGet/NuGet.Client","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/607/comments","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/607/events","html_url":"https://github.com/NuGet/NuGet.Client/pull/607","id":155609173,"number":607,"title":"Properly map package source credentials to corresponding source","user":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NuGet/NuGet.Client/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-05-18T21:46:37Z","updated_at":"2016-07-11T17:42:08Z","closed_at":"2016-05-28T00:21:04Z","pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/607","html_url":"https://github.com/NuGet/NuGet.Client/pull/607","diff_url":"https://github.com/NuGet/NuGet.Client/pull/607.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/607.patch"},"body":"Fixes https://github.com/NuGet/Home/issues/2151.\r\n\r\nThe key idea behind this change was to eliminate use of CredentialStore\r\nresponsible for caching credentials per given host as opposed to the right\r\n\"per source\" mapping. In order to achieve that package source credentials\r\nneeded to be associated with corresponding HttpSource instance.\r\n\r\nFor better clarity and granular testing two new message handlers were\r\nfactored out of HttpSource:\r\n- HttpSourceAuthenticationHandler\r\n- StsAuthenticationHandler\r\n\r\nDecomissioned CredentialStore.\r\n\r\nIntroduced StsTokenStore in place of CredentialStore to maintain per host\r\nmapping for STS tokens.\r\n\r\nRemoved PromptForCredential callback. Authentication handlers invoke\r\ncredential service directly.\r\n\r\nAdded authentication handlers tests\r\n\r\n//cc @rrelyea @joelverhagen @emgarten @yishaigalatzer @zhili1208 "},"comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments/231808694","html_url":"https://github.com/NuGet/NuGet.Client/pull/607#issuecomment-231808694","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/607","id":231808694,"user":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T17:42:08Z","updated_at":"2016-07-11T17:42:08Z","body":"@ygeelen-tb The fix targets v3,6 planned for release in November this year.\r\nIf you want to evaluate it you can download the vsix from NuGet daily (unstable) feed [here](https://www.myget.org/F/nuget-vsix/vsix/NuGet.0d421874-a3b2-4f67-b53a-ecfce878063b-3.5.0.1580.vsix)."}}
{"actor":{"display_login":"alpaix"}}