{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/kubernetes/pulls/comments/56701375","id":56701375,"diff_hunk":"@@ -0,0 +1,86 @@\n+#!/bin/bash\n+\n+# Copyright 2014 The Kubernetes Authors All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+##########################################################\n+#\n+# Common parameters for Kubernetes\n+#\n+##########################################################\n+\n+# Default number of minion nodes to make. You can change this as needed\n+NUM_NODES=2","path":"cluster/photon-controller/config-default.sh","position":24,"original_position":24,"commit_id":"243f497758fa74a6e8d977e456a024648ae2c929","original_commit_id":"243f497758fa74a6e8d977e456a024648ae2c929","user":{"login":"imkin","id":2793249,"avatar_url":"https://avatars.githubusercontent.com/u/2793249?v=3","gravatar_id":"","url":"https://api.github.com/users/imkin","html_url":"https://github.com/imkin","followers_url":"https://api.github.com/users/imkin/followers","following_url":"https://api.github.com/users/imkin/following{/other_user}","gists_url":"https://api.github.com/users/imkin/gists{/gist_id}","starred_url":"https://api.github.com/users/imkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imkin/subscriptions","organizations_url":"https://api.github.com/users/imkin/orgs","repos_url":"https://api.github.com/users/imkin/repos","events_url":"https://api.github.com/users/imkin/events{/privacy}","received_events_url":"https://api.github.com/users/imkin/received_events","type":"User","site_admin":false},"body":"I think it would good to have number of nodes as 3.","created_at":"2016-03-18T18:24:55Z","updated_at":"2016-03-18T18:24:55Z","html_url":"https://github.com/vmware/kubernetes/pull/4#discussion_r56701375","pull_request_url":"https://api.github.com/repos/vmware/kubernetes/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/comments/56701375"},"html":{"href":"https://github.com/vmware/kubernetes/pull/4#discussion_r56701375"},"pull_request":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/kubernetes/pulls/4","id":63274671,"html_url":"https://github.com/vmware/kubernetes/pull/4","diff_url":"https://github.com/vmware/kubernetes/pull/4.diff","patch_url":"https://github.com/vmware/kubernetes/pull/4.patch","issue_url":"https://api.github.com/repos/vmware/kubernetes/issues/4","number":4,"state":"open","locked":false,"title":"First checkin of kube-up support for photon-controller","user":{"login":"AlainRoy","id":887364,"avatar_url":"https://avatars.githubusercontent.com/u/887364?v=3","gravatar_id":"","url":"https://api.github.com/users/AlainRoy","html_url":"https://github.com/AlainRoy","followers_url":"https://api.github.com/users/AlainRoy/followers","following_url":"https://api.github.com/users/AlainRoy/following{/other_user}","gists_url":"https://api.github.com/users/AlainRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/AlainRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlainRoy/subscriptions","organizations_url":"https://api.github.com/users/AlainRoy/orgs","repos_url":"https://api.github.com/users/AlainRoy/repos","events_url":"https://api.github.com/users/AlainRoy/events{/privacy}","received_events_url":"https://api.github.com/users/AlainRoy/received_events","type":"User","site_admin":false},"body":"This supports kube-up as it exists on the release-1.2 branch (not\r\nmaster). It supports kube-up and kube-down, but does not yet support\r\nkube-push or the integrated tests.\r\n\r\nManual tests work well: we can bring up a cluster, create and\r\nmanipulate pods, and bring down the cluster.\r\n\r\nNetworking to public IPs for services has not been tested. That will\r\nbe tested next, and integrated tests will follow shortly thereafter.\r\n\r\nThere is an extra script called setup-prereqs.sh. This configures\r\nPhoton Controller with tenant, project, flavors, and image. It's\r\nunlikely to be useful for production deployments because it includes\r\nan arbitrary resource ticket (quota), but it will be useful for\r\ngetting people up and running quickly.","created_at":"2016-03-17T18:56:24Z","updated_at":"2016-03-18T18:24:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fea635e33b9697b8236a1410e131158220f59fc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vmware/kubernetes/pulls/4/commits","review_comments_url":"https://api.github.com/repos/vmware/kubernetes/pulls/4/comments","review_comment_url":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/kubernetes/issues/4/comments","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/243f497758fa74a6e8d977e456a024648ae2c929","head":{"label":"AlainRoy:photon-controller-1.2","ref":"photon-controller-1.2","sha":"243f497758fa74a6e8d977e456a024648ae2c929","user":{"login":"AlainRoy","id":887364,"avatar_url":"https://avatars.githubusercontent.com/u/887364?v=3","gravatar_id":"","url":"https://api.github.com/users/AlainRoy","html_url":"https://github.com/AlainRoy","followers_url":"https://api.github.com/users/AlainRoy/followers","following_url":"https://api.github.com/users/AlainRoy/following{/other_user}","gists_url":"https://api.github.com/users/AlainRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/AlainRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlainRoy/subscriptions","organizations_url":"https://api.github.com/users/AlainRoy/orgs","repos_url":"https://api.github.com/users/AlainRoy/repos","events_url":"https://api.github.com/users/AlainRoy/events{/privacy}","received_events_url":"https://api.github.com/users/AlainRoy/received_events","type":"User","site_admin":false},"repo":{"id":53170624,"name":"kubernetes","full_name":"AlainRoy/kubernetes","owner":{"login":"AlainRoy","id":887364,"avatar_url":"https://avatars.githubusercontent.com/u/887364?v=3","gravatar_id":"","url":"https://api.github.com/users/AlainRoy","html_url":"https://github.com/AlainRoy","followers_url":"https://api.github.com/users/AlainRoy/followers","following_url":"https://api.github.com/users/AlainRoy/following{/other_user}","gists_url":"https://api.github.com/users/AlainRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/AlainRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlainRoy/subscriptions","organizations_url":"https://api.github.com/users/AlainRoy/orgs","repos_url":"https://api.github.com/users/AlainRoy/repos","events_url":"https://api.github.com/users/AlainRoy/events{/privacy}","received_events_url":"https://api.github.com/users/AlainRoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlainRoy/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/AlainRoy/kubernetes","forks_url":"https://api.github.com/repos/AlainRoy/kubernetes/forks","keys_url":"https://api.github.com/repos/AlainRoy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlainRoy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlainRoy/kubernetes/teams","hooks_url":"https://api.github.com/repos/AlainRoy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/AlainRoy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/AlainRoy/kubernetes/events","assignees_url":"https://api.github.com/repos/AlainRoy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/AlainRoy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/AlainRoy/kubernetes/tags","blobs_url":"https://api.github.com/repos/AlainRoy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlainRoy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlainRoy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlainRoy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlainRoy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/AlainRoy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/AlainRoy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/AlainRoy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/AlainRoy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/AlainRoy/kubernetes/subscription","commits_url":"https://api.github.com/repos/AlainRoy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlainRoy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlainRoy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlainRoy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlainRoy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/AlainRoy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlainRoy/kubernetes/merges","archive_url":"https://api.github.com/repos/AlainRoy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlainRoy/kubernetes/downloads","issues_url":"https://api.github.com/repos/AlainRoy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/AlainRoy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/AlainRoy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/AlainRoy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlainRoy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/AlainRoy/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/AlainRoy/kubernetes/deployments","created_at":"2016-03-04T22:50:58Z","updated_at":"2016-03-04T22:51:10Z","pushed_at":"2016-03-17T18:52:16Z","git_url":"git://github.com/AlainRoy/kubernetes.git","ssh_url":"git@github.com:AlainRoy/kubernetes.git","clone_url":"https://github.com/AlainRoy/kubernetes.git","svn_url":"https://github.com/AlainRoy/kubernetes","homepage":"http://kubernetes.io","size":182470,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:photon-controller-1.2","ref":"photon-controller-1.2","sha":"fd557a2c9f47c655f9c07d9cf9dee2539e935703","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2016-01-21T21:56:12Z","pushed_at":"2016-03-17T18:56:24Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":182460,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/4"},"html":{"href":"https://github.com/vmware/kubernetes/pull/4"},"issue":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/4"},"comments":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/kubernetes/statuses/243f497758fa74a6e8d977e456a024648ae2c929"}}}}