{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/57824515","id":57824515,"diff_hunk":"@@ -303,4 +313,25 @@ SplashScreen createSplashScreen(GVRViewManager viewManager) {\n         onSplashScreenCreated(splashScreen);\n         return splashScreen;\n     }\n+\n+    public void addPlugin(GVRPlugin plugin) {","path":"GVRf/Framework/src/org/gearvrf/GVRScript.java","position":32,"original_position":32,"commit_id":"e804a4b66ad7c0c72bb1a17a4978c811585b3d8c","original_commit_id":"e804a4b66ad7c0c72bb1a17a4978c811585b3d8c","user":{"login":"danke-sra","id":13282142,"avatar_url":"https://avatars.githubusercontent.com/u/13282142?v=3","gravatar_id":"","url":"https://api.github.com/users/danke-sra","html_url":"https://github.com/danke-sra","followers_url":"https://api.github.com/users/danke-sra/followers","following_url":"https://api.github.com/users/danke-sra/following{/other_user}","gists_url":"https://api.github.com/users/danke-sra/gists{/gist_id}","starred_url":"https://api.github.com/users/danke-sra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danke-sra/subscriptions","organizations_url":"https://api.github.com/users/danke-sra/orgs","repos_url":"https://api.github.com/users/danke-sra/repos","events_url":"https://api.github.com/users/danke-sra/events{/privacy}","received_events_url":"https://api.github.com/users/danke-sra/received_events","type":"User","site_admin":false},"body":"@dattanand Do you think there is another way of adding in the plugin? Do you think we can only override onInit() to perform needed initialization?","created_at":"2016-03-30T00:53:07Z","updated_at":"2016-03-30T00:53:07Z","html_url":"https://github.com/Samsung/GearVRf/pull/367#discussion_r57824515","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/57824515"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/367#discussion_r57824515"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/367","id":55310090,"html_url":"https://github.com/Samsung/GearVRf/pull/367","diff_url":"https://github.com/Samsung/GearVRf/pull/367.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/367.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/367","number":367,"state":"open","locked":false,"title":"Adding GVRF widget framework","user":{"login":"dattanand","id":16078528,"avatar_url":"https://avatars.githubusercontent.com/u/16078528?v=3","gravatar_id":"","url":"https://api.github.com/users/dattanand","html_url":"https://github.com/dattanand","followers_url":"https://api.github.com/users/dattanand/followers","following_url":"https://api.github.com/users/dattanand/following{/other_user}","gists_url":"https://api.github.com/users/dattanand/gists{/gist_id}","starred_url":"https://api.github.com/users/dattanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dattanand/subscriptions","organizations_url":"https://api.github.com/users/dattanand/orgs","repos_url":"https://api.github.com/users/dattanand/repos","events_url":"https://api.github.com/users/dattanand/events{/privacy}","received_events_url":"https://api.github.com/users/dattanand/received_events","type":"User","site_admin":false},"body":"this has all the changes for GVRF widget framework including rework done for review comments given in #341. only exception being the unlit shader is not removed since the widget scene object can be created using .obj meshes which have standard texture coordinates, also input dispatch for widget too behaves in the same way, to avoid using this shader would involve additional changes which dont seem right to me and would require swapping at every stage and involve more complication since input dispatch is little complicated","created_at":"2016-01-07T08:07:08Z","updated_at":"2016-03-30T00:53:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fc14ee72e1a0cf9ab0bf8e1359bef46b1424b4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/367/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/367/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/367/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/e804a4b66ad7c0c72bb1a17a4978c811585b3d8c","head":{"label":"dattanand:master","ref":"master","sha":"e804a4b66ad7c0c72bb1a17a4978c811585b3d8c","user":{"login":"dattanand","id":16078528,"avatar_url":"https://avatars.githubusercontent.com/u/16078528?v=3","gravatar_id":"","url":"https://api.github.com/users/dattanand","html_url":"https://github.com/dattanand","followers_url":"https://api.github.com/users/dattanand/followers","following_url":"https://api.github.com/users/dattanand/following{/other_user}","gists_url":"https://api.github.com/users/dattanand/gists{/gist_id}","starred_url":"https://api.github.com/users/dattanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dattanand/subscriptions","organizations_url":"https://api.github.com/users/dattanand/orgs","repos_url":"https://api.github.com/users/dattanand/repos","events_url":"https://api.github.com/users/dattanand/events{/privacy}","received_events_url":"https://api.github.com/users/dattanand/received_events","type":"User","site_admin":false},"repo":{"id":49131756,"name":"GearVRf","full_name":"dattanand/GearVRf","owner":{"login":"dattanand","id":16078528,"avatar_url":"https://avatars.githubusercontent.com/u/16078528?v=3","gravatar_id":"","url":"https://api.github.com/users/dattanand","html_url":"https://github.com/dattanand","followers_url":"https://api.github.com/users/dattanand/followers","following_url":"https://api.github.com/users/dattanand/following{/other_user}","gists_url":"https://api.github.com/users/dattanand/gists{/gist_id}","starred_url":"https://api.github.com/users/dattanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dattanand/subscriptions","organizations_url":"https://api.github.com/users/dattanand/orgs","repos_url":"https://api.github.com/users/dattanand/repos","events_url":"https://api.github.com/users/dattanand/events{/privacy}","received_events_url":"https://api.github.com/users/dattanand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dattanand/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/dattanand/GearVRf","forks_url":"https://api.github.com/repos/dattanand/GearVRf/forks","keys_url":"https://api.github.com/repos/dattanand/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dattanand/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dattanand/GearVRf/teams","hooks_url":"https://api.github.com/repos/dattanand/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/dattanand/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/dattanand/GearVRf/events","assignees_url":"https://api.github.com/repos/dattanand/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/dattanand/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/dattanand/GearVRf/tags","blobs_url":"https://api.github.com/repos/dattanand/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dattanand/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dattanand/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dattanand/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dattanand/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/dattanand/GearVRf/languages","stargazers_url":"https://api.github.com/repos/dattanand/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/dattanand/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/dattanand/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/dattanand/GearVRf/subscription","commits_url":"https://api.github.com/repos/dattanand/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dattanand/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dattanand/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dattanand/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dattanand/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/dattanand/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dattanand/GearVRf/merges","archive_url":"https://api.github.com/repos/dattanand/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dattanand/GearVRf/downloads","issues_url":"https://api.github.com/repos/dattanand/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/dattanand/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/dattanand/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/dattanand/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dattanand/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/dattanand/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/dattanand/GearVRf/deployments","created_at":"2016-01-06T11:41:41Z","updated_at":"2016-01-14T09:36:58Z","pushed_at":"2016-03-29T11:46:11Z","git_url":"git://github.com/dattanand/GearVRf.git","ssh_url":"git@github.com:dattanand/GearVRf.git","clone_url":"https://github.com/dattanand/GearVRf.git","svn_url":"https://github.com/dattanand/GearVRf","homepage":"http://www.gearvrf.org","size":623535,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"5526bd10ee3952f7283546b8353aad1a535f866c","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/GearVRf/deployments","created_at":"2015-03-25T02:02:18Z","updated_at":"2016-03-29T06:02:31Z","pushed_at":"2016-03-29T19:24:14Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":710908,"stargazers_count":104,"watchers_count":104,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":63,"forks":102,"open_issues":63,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/367"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/367"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/367"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/e804a4b66ad7c0c72bb1a17a4978c811585b3d8c"}}}}