{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/657","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/657/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/657/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/657/events","html_url":"https://github.com/solidusio/solidus/pull/657","id":125234692,"number":657,"title":"Fix use of `contains?` in tax_rate.rb","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-06T18:33:59Z","updated_at":"2016-01-08T00:36:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/657","html_url":"https://github.com/solidusio/solidus/pull/657","diff_url":"https://github.com/solidusio/solidus/pull/657.diff","patch_url":"https://github.com/solidusio/solidus/pull/657.patch"},"body":"Previously, when checking a tax rate's applicability for an order, we would do two checks: Is it the same zone? If not: Does the tax rate's zone contain the other zone? Since a zone will always contain itself, I added an early return in `Zone#contains?` for that case, and unified the applicability checks in `TaxRate`. \r\n\r\nThis should ease mergeability of #650 (once this is in, #650 will really only be specs)."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/169851230","html_url":"https://github.com/solidusio/solidus/pull/657#issuecomment-169851230","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/657","id":169851230,"user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T00:36:56Z","updated_at":"2016-01-08T00:36:56Z","body":"I took the liberty of adding an additional spec :)"}}