{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/comments/72025118","id":72025118,"diff_hunk":"@@ -30,14 +30,15 @@\n         \"sonata-project/datagrid-bundle\": \"^2.2\"\n     },\n     \"require-dev\": {\n+        \"core23/classification-media-bundle\": \"^0.1\",\n         \"friendsofsymfony/rest-bundle\": \"^1.1\",\n         \"jms/serializer-bundle\": \"^0.13 || ^1.0\",\n         \"sllh/php-cs-fixer-styleci-bridge\": \"^2.0\",\n         \"sonata-project/media-bundle\": \"^3.0 || ^4.0@dev\",\n         \"symfony/phpunit-bridge\": \"^2.7 || ^3.0\"\n     },\n     \"suggest\": {\n-        \"sonata-project/media-bundle\": \"For media management\"\n+        \"core23/classification-media-bundle\": \"For classifcation media previews.\"","path":"composer.json","position":9,"original_position":13,"commit_id":"e887ff4ac5fdc537ce87a86a57fb60c1f86d8030","original_commit_id":"11a9bc4132c1e8dceb5a52b71e8a0bc475a44463","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"Quite agree. Would be great to have the code extract onto the sonata flag.","created_at":"2016-07-25T08:23:14Z","updated_at":"2016-07-25T08:23:14Z","html_url":"https://github.com/sonata-project/SonataClassificationBundle/pull/196#discussion_r72025118","pull_request_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/comments/72025118"},"html":{"href":"https://github.com/sonata-project/SonataClassificationBundle/pull/196#discussion_r72025118"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196","id":71568945,"html_url":"https://github.com/sonata-project/SonataClassificationBundle/pull/196","diff_url":"https://github.com/sonata-project/SonataClassificationBundle/pull/196.diff","patch_url":"https://github.com/sonata-project/SonataClassificationBundle/pull/196.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/196","number":196,"state":"open","locked":false,"title":"Remove SonataMediaBundle dependency","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataClassificationBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targetting this branch, because this PR removed some essential stuff.\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Removed\r\n - Removed `sonata-project/media-bundle` dependency\r\n - Removed previews in categories and collections\r\n```\r\n\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\n\r\nAdding the `SonataMediaBundle` as a dependency was't a good idea, because we have a cross-dependency between both bundles. This PR removes this dependency completely.\r\n\r\nThe dependency was needed for a category and collection thumb, which should be handled in a custom bundle mplementation. ","created_at":"2016-05-26T14:49:57Z","updated_at":"2016-07-25T08:23:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b29485ef7b350886162a1c298c6d247da2fb2b9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/196/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/statuses/e887ff4ac5fdc537ce87a86a57fb60c1f86d8030","head":{"label":"core23:remove-media","ref":"remove-media","sha":"e887ff4ac5fdc537ce87a86a57fb60c1f86d8030","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"repo":{"id":33734772,"name":"SonataClassificationBundle","full_name":"core23/SonataClassificationBundle","owner":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/core23/SonataClassificationBundle","description":"A classification bundle to help organize your entities: tag, category and taxonomy","fork":true,"url":"https://api.github.com/repos/core23/SonataClassificationBundle","forks_url":"https://api.github.com/repos/core23/SonataClassificationBundle/forks","keys_url":"https://api.github.com/repos/core23/SonataClassificationBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/core23/SonataClassificationBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/core23/SonataClassificationBundle/teams","hooks_url":"https://api.github.com/repos/core23/SonataClassificationBundle/hooks","issue_events_url":"https://api.github.com/repos/core23/SonataClassificationBundle/issues/events{/number}","events_url":"https://api.github.com/repos/core23/SonataClassificationBundle/events","assignees_url":"https://api.github.com/repos/core23/SonataClassificationBundle/assignees{/user}","branches_url":"https://api.github.com/repos/core23/SonataClassificationBundle/branches{/branch}","tags_url":"https://api.github.com/repos/core23/SonataClassificationBundle/tags","blobs_url":"https://api.github.com/repos/core23/SonataClassificationBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/core23/SonataClassificationBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/core23/SonataClassificationBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/core23/SonataClassificationBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/core23/SonataClassificationBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/core23/SonataClassificationBundle/languages","stargazers_url":"https://api.github.com/repos/core23/SonataClassificationBundle/stargazers","contributors_url":"https://api.github.com/repos/core23/SonataClassificationBundle/contributors","subscribers_url":"https://api.github.com/repos/core23/SonataClassificationBundle/subscribers","subscription_url":"https://api.github.com/repos/core23/SonataClassificationBundle/subscription","commits_url":"https://api.github.com/repos/core23/SonataClassificationBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/core23/SonataClassificationBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/core23/SonataClassificationBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/core23/SonataClassificationBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/core23/SonataClassificationBundle/contents/{+path}","compare_url":"https://api.github.com/repos/core23/SonataClassificationBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/core23/SonataClassificationBundle/merges","archive_url":"https://api.github.com/repos/core23/SonataClassificationBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/core23/SonataClassificationBundle/downloads","issues_url":"https://api.github.com/repos/core23/SonataClassificationBundle/issues{/number}","pulls_url":"https://api.github.com/repos/core23/SonataClassificationBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/core23/SonataClassificationBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/core23/SonataClassificationBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/core23/SonataClassificationBundle/labels{/name}","releases_url":"https://api.github.com/repos/core23/SonataClassificationBundle/releases{/id}","deployments_url":"https://api.github.com/repos/core23/SonataClassificationBundle/deployments","created_at":"2015-04-10T15:07:28Z","updated_at":"2015-04-10T15:10:29Z","pushed_at":"2016-07-23T07:48:16Z","git_url":"git://github.com/core23/SonataClassificationBundle.git","ssh_url":"git@github.com:core23/SonataClassificationBundle.git","clone_url":"https://github.com/core23/SonataClassificationBundle.git","svn_url":"https://github.com/core23/SonataClassificationBundle","homepage":"","size":368,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"5e9af17050afcc063445ab73044592b8b4048ac6","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":13283145,"name":"SonataClassificationBundle","full_name":"sonata-project/SonataClassificationBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataClassificationBundle","description":"A classification bundle to help organize your entities: tag, category and taxonomy","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/deployments","created_at":"2013-10-02T21:15:53Z","updated_at":"2016-05-22T17:49:22Z","pushed_at":"2016-07-23T12:47:58Z","git_url":"git://github.com/sonata-project/SonataClassificationBundle.git","ssh_url":"git@github.com:sonata-project/SonataClassificationBundle.git","clone_url":"https://github.com/sonata-project/SonataClassificationBundle.git","svn_url":"https://github.com/sonata-project/SonataClassificationBundle","homepage":"","size":446,"stargazers_count":21,"watchers_count":21,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":25,"forks":93,"open_issues":25,"watchers":21,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196"},"html":{"href":"https://github.com/sonata-project/SonataClassificationBundle/pull/196"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/196"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataClassificationBundle/statuses/e887ff4ac5fdc537ce87a86a57fb60c1f86d8030"}}}}
{"actor":{"display_login":"Soullivaneuh"}}