{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/comments/77422598","id":77422598,"diff_hunk":"@@ -142,9 +143,34 @@ function httpServiceFactory(\n         });\n     };\n \n+    HttpService.prototype.patchYamlConfig =\n+        function(endpoint, swaggerConfig, di) {\n+            di = di && typeof di === 'object' ? di : {}\n+            var _fs = di.fs || fs;\n+                _logger = di.logger || logger;\n+                _Promise = di.Promise || Promise;\n+                _yaml = di.yaml || yaml;","path":"lib/services/http-service.js","position":32,"original_position":32,"commit_id":"d03bd80d6b38fe04a1c1ee8f9a9bddb0c14ff97e","original_commit_id":"d03bd80d6b38fe04a1c1ee8f9a9bddb0c14ff97e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'_yaml' is not defined.","created_at":"2016-09-02T22:54:01Z","updated_at":"2016-09-02T22:54:01Z","html_url":"https://github.com/RackHD/on-http/pull/431#discussion_r77422598","pull_request_url":"https://api.github.com/repos/RackHD/on-http/pulls/431","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments/77422598"},"html":{"href":"https://github.com/RackHD/on-http/pull/431#discussion_r77422598"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/431","id":82273366,"html_url":"https://github.com/RackHD/on-http/pull/431","diff_url":"https://github.com/RackHD/on-http/pull/431.diff","patch_url":"https://github.com/RackHD/on-http/pull/431.patch","issue_url":"https://api.github.com/repos/RackHD/on-http/issues/431","number":431,"state":"open","locked":false,"title":"Fix swagger yaml schemes based on RackHD config","user":{"login":"rolandpoulter","id":51327,"avatar_url":"https://avatars.githubusercontent.com/u/51327?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandpoulter","html_url":"https://github.com/rolandpoulter","followers_url":"https://api.github.com/users/rolandpoulter/followers","following_url":"https://api.github.com/users/rolandpoulter/following{/other_user}","gists_url":"https://api.github.com/users/rolandpoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandpoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandpoulter/subscriptions","organizations_url":"https://api.github.com/users/rolandpoulter/orgs","repos_url":"https://api.github.com/users/rolandpoulter/repos","events_url":"https://api.github.com/users/rolandpoulter/events{/privacy}","received_events_url":"https://api.github.com/users/rolandpoulter/received_events","type":"User","site_admin":false},"body":"This fixes an issue with the swagger-ui failing when `https` is enabled for RackHD. The issue is that our swagger yaml files specify both `http` and `https` as schemes. They should reflect how RackHD is configured.\r\n\r\nIn order to make the swagger yaml schemes reflect what is in the RackHD configuration. The yaml files are preloaded, modified and saved to a temporary location. Then the patched yaml is used to load the swagger server.\r\n\r\n@pscharla ","created_at":"2016-08-22T22:18:55Z","updated_at":"2016-09-02T22:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ddf9006c1db44a0be29955b1727ba38f41ce24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-http/pulls/431/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-http/pulls/431/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-http/issues/431/comments","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/d03bd80d6b38fe04a1c1ee8f9a9bddb0c14ff97e","head":{"label":"rolandpoulter:fix-swagger","ref":"fix-swagger","sha":"d03bd80d6b38fe04a1c1ee8f9a9bddb0c14ff97e","user":{"login":"rolandpoulter","id":51327,"avatar_url":"https://avatars.githubusercontent.com/u/51327?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandpoulter","html_url":"https://github.com/rolandpoulter","followers_url":"https://api.github.com/users/rolandpoulter/followers","following_url":"https://api.github.com/users/rolandpoulter/following{/other_user}","gists_url":"https://api.github.com/users/rolandpoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandpoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandpoulter/subscriptions","organizations_url":"https://api.github.com/users/rolandpoulter/orgs","repos_url":"https://api.github.com/users/rolandpoulter/repos","events_url":"https://api.github.com/users/rolandpoulter/events{/privacy}","received_events_url":"https://api.github.com/users/rolandpoulter/received_events","type":"User","site_admin":false},"repo":{"id":45872104,"name":"on-http","full_name":"rolandpoulter/on-http","owner":{"login":"rolandpoulter","id":51327,"avatar_url":"https://avatars.githubusercontent.com/u/51327?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandpoulter","html_url":"https://github.com/rolandpoulter","followers_url":"https://api.github.com/users/rolandpoulter/followers","following_url":"https://api.github.com/users/rolandpoulter/following{/other_user}","gists_url":"https://api.github.com/users/rolandpoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandpoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandpoulter/subscriptions","organizations_url":"https://api.github.com/users/rolandpoulter/orgs","repos_url":"https://api.github.com/users/rolandpoulter/repos","events_url":"https://api.github.com/users/rolandpoulter/events{/privacy}","received_events_url":"https://api.github.com/users/rolandpoulter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandpoulter/on-http","description":"","fork":true,"url":"https://api.github.com/repos/rolandpoulter/on-http","forks_url":"https://api.github.com/repos/rolandpoulter/on-http/forks","keys_url":"https://api.github.com/repos/rolandpoulter/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandpoulter/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandpoulter/on-http/teams","hooks_url":"https://api.github.com/repos/rolandpoulter/on-http/hooks","issue_events_url":"https://api.github.com/repos/rolandpoulter/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/rolandpoulter/on-http/events","assignees_url":"https://api.github.com/repos/rolandpoulter/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/rolandpoulter/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/rolandpoulter/on-http/tags","blobs_url":"https://api.github.com/repos/rolandpoulter/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandpoulter/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandpoulter/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandpoulter/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandpoulter/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandpoulter/on-http/languages","stargazers_url":"https://api.github.com/repos/rolandpoulter/on-http/stargazers","contributors_url":"https://api.github.com/repos/rolandpoulter/on-http/contributors","subscribers_url":"https://api.github.com/repos/rolandpoulter/on-http/subscribers","subscription_url":"https://api.github.com/repos/rolandpoulter/on-http/subscription","commits_url":"https://api.github.com/repos/rolandpoulter/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandpoulter/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandpoulter/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandpoulter/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolandpoulter/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/rolandpoulter/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandpoulter/on-http/merges","archive_url":"https://api.github.com/repos/rolandpoulter/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandpoulter/on-http/downloads","issues_url":"https://api.github.com/repos/rolandpoulter/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/rolandpoulter/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandpoulter/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandpoulter/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandpoulter/on-http/labels{/name}","releases_url":"https://api.github.com/repos/rolandpoulter/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/rolandpoulter/on-http/deployments","created_at":"2015-11-09T22:50:05Z","updated_at":"2016-01-27T23:29:06Z","pushed_at":"2016-09-02T22:53:53Z","git_url":"git://github.com/rolandpoulter/on-http.git","ssh_url":"git@github.com:rolandpoulter/on-http.git","clone_url":"https://github.com/rolandpoulter/on-http.git","svn_url":"https://github.com/rolandpoulter/on-http","homepage":null,"size":3244,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"98f6655a586ac60ffc560b175cf75cf5855bb080","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690081,"name":"on-http","full_name":"RackHD/on-http","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-http","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-http","forks_url":"https://api.github.com/repos/RackHD/on-http/forks","keys_url":"https://api.github.com/repos/RackHD/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-http/teams","hooks_url":"https://api.github.com/repos/RackHD/on-http/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-http/events","assignees_url":"https://api.github.com/repos/RackHD/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-http/tags","blobs_url":"https://api.github.com/repos/RackHD/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-http/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-http/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-http/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-http/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-http/subscription","commits_url":"https://api.github.com/repos/RackHD/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-http/merges","archive_url":"https://api.github.com/repos/RackHD/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-http/downloads","issues_url":"https://api.github.com/repos/RackHD/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-http/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-http/deployments","created_at":"2015-08-31T17:29:08Z","updated_at":"2016-05-12T01:23:41Z","pushed_at":"2016-09-02T22:53:53Z","git_url":"git://github.com/RackHD/on-http.git","ssh_url":"git@github.com:RackHD/on-http.git","clone_url":"https://github.com/RackHD/on-http.git","svn_url":"https://github.com/RackHD/on-http","homepage":null,"size":3951,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":11,"forks":54,"open_issues":11,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/431"},"html":{"href":"https://github.com/RackHD/on-http/pull/431"},"issue":{"href":"https://api.github.com/repos/RackHD/on-http/issues/431"},"comments":{"href":"https://api.github.com/repos/RackHD/on-http/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-http/statuses/d03bd80d6b38fe04a1c1ee8f9a9bddb0c14ff97e"}}}}
{"actor":{"display_login":"houndci-bot"}}