{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199","id":78640305,"html_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/199","diff_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/199.diff","patch_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/199.patch","issue_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/199","number":199,"state":"closed","locked":false,"title":"Implemented slf4j","user":{"login":"pvanassen","id":4519430,"avatar_url":"https://avatars.githubusercontent.com/u/4519430?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanassen","html_url":"https://github.com/pvanassen","followers_url":"https://api.github.com/users/pvanassen/followers","following_url":"https://api.github.com/users/pvanassen/following{/other_user}","gists_url":"https://api.github.com/users/pvanassen/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanassen/subscriptions","organizations_url":"https://api.github.com/users/pvanassen/orgs","repos_url":"https://api.github.com/users/pvanassen/repos","events_url":"https://api.github.com/users/pvanassen/events{/privacy}","received_events_url":"https://api.github.com/users/pvanassen/received_events","type":"User","site_admin":false},"body":"Implemented SLF4j.\r\n\r\nAt first I attempted to reuse the existing Log class but this added extra information in the stack traces which was unnecessary. With SLF4j people implementing the API can choose which logging framework they want to use and are not stuck to System.out output. Lombok also integrates nicely with it through the @Slf4j annotation.\r\n\r\nAttempt 2, fixed merge conflicts (old pr: https://github.com/Grover-c13/PokeGOAPI-Java/pull/198)","created_at":"2016-07-25T08:01:00Z","updated_at":"2016-07-25T08:21:56Z","closed_at":"2016-07-25T08:21:56Z","merged_at":null,"merge_commit_sha":"2f1e0b7cbc707b74d54f3b8c54fb1540f3f4fbf5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199/commits","review_comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199/comments","review_comment_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/199/comments","statuses_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/6d4ac0a4d678eda8ba8d67413cf05a05a1d44249","head":{"label":"pvanassen:slf4j","ref":"slf4j","sha":"6d4ac0a4d678eda8ba8d67413cf05a05a1d44249","user":{"login":"pvanassen","id":4519430,"avatar_url":"https://avatars.githubusercontent.com/u/4519430?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanassen","html_url":"https://github.com/pvanassen","followers_url":"https://api.github.com/users/pvanassen/followers","following_url":"https://api.github.com/users/pvanassen/following{/other_user}","gists_url":"https://api.github.com/users/pvanassen/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanassen/subscriptions","organizations_url":"https://api.github.com/users/pvanassen/orgs","repos_url":"https://api.github.com/users/pvanassen/repos","events_url":"https://api.github.com/users/pvanassen/events{/privacy}","received_events_url":"https://api.github.com/users/pvanassen/received_events","type":"User","site_admin":false},"repo":{"id":64054660,"name":"PokeGOAPI-Java","full_name":"pvanassen/PokeGOAPI-Java","owner":{"login":"pvanassen","id":4519430,"avatar_url":"https://avatars.githubusercontent.com/u/4519430?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanassen","html_url":"https://github.com/pvanassen","followers_url":"https://api.github.com/users/pvanassen/followers","following_url":"https://api.github.com/users/pvanassen/following{/other_user}","gists_url":"https://api.github.com/users/pvanassen/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanassen/subscriptions","organizations_url":"https://api.github.com/users/pvanassen/orgs","repos_url":"https://api.github.com/users/pvanassen/repos","events_url":"https://api.github.com/users/pvanassen/events{/privacy}","received_events_url":"https://api.github.com/users/pvanassen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvanassen/PokeGOAPI-Java","description":"Pokemon Go API","fork":true,"url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java","forks_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/forks","keys_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/teams","hooks_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/hooks","issue_events_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/issues/events{/number}","events_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/events","assignees_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/assignees{/user}","branches_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/branches{/branch}","tags_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/tags","blobs_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/languages","stargazers_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/stargazers","contributors_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/contributors","subscribers_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/subscribers","subscription_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/subscription","commits_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/contents/{+path}","compare_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/merges","archive_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/downloads","issues_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/issues{/number}","pulls_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/labels{/name}","releases_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/releases{/id}","deployments_url":"https://api.github.com/repos/pvanassen/PokeGOAPI-Java/deployments","created_at":"2016-07-24T07:48:41Z","updated_at":"2016-07-24T07:48:42Z","pushed_at":"2016-07-25T07:59:46Z","git_url":"git://github.com/pvanassen/PokeGOAPI-Java.git","ssh_url":"git@github.com:pvanassen/PokeGOAPI-Java.git","clone_url":"https://github.com/pvanassen/PokeGOAPI-Java.git","svn_url":"https://github.com/pvanassen/PokeGOAPI-Java","homepage":null,"size":8698,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Development"}},"base":{"label":"Grover-c13:Development","ref":"Development","sha":"4831b9f5653a0d7945849ab3dc028b5d728ce488","user":{"login":"Grover-c13","id":1520101,"avatar_url":"https://avatars.githubusercontent.com/u/1520101?v=3","gravatar_id":"","url":"https://api.github.com/users/Grover-c13","html_url":"https://github.com/Grover-c13","followers_url":"https://api.github.com/users/Grover-c13/followers","following_url":"https://api.github.com/users/Grover-c13/following{/other_user}","gists_url":"https://api.github.com/users/Grover-c13/gists{/gist_id}","starred_url":"https://api.github.com/users/Grover-c13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grover-c13/subscriptions","organizations_url":"https://api.github.com/users/Grover-c13/orgs","repos_url":"https://api.github.com/users/Grover-c13/repos","events_url":"https://api.github.com/users/Grover-c13/events{/privacy}","received_events_url":"https://api.github.com/users/Grover-c13/received_events","type":"User","site_admin":false},"repo":{"id":63499395,"name":"PokeGOAPI-Java","full_name":"Grover-c13/PokeGOAPI-Java","owner":{"login":"Grover-c13","id":1520101,"avatar_url":"https://avatars.githubusercontent.com/u/1520101?v=3","gravatar_id":"","url":"https://api.github.com/users/Grover-c13","html_url":"https://github.com/Grover-c13","followers_url":"https://api.github.com/users/Grover-c13/followers","following_url":"https://api.github.com/users/Grover-c13/following{/other_user}","gists_url":"https://api.github.com/users/Grover-c13/gists{/gist_id}","starred_url":"https://api.github.com/users/Grover-c13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grover-c13/subscriptions","organizations_url":"https://api.github.com/users/Grover-c13/orgs","repos_url":"https://api.github.com/users/Grover-c13/repos","events_url":"https://api.github.com/users/Grover-c13/events{/privacy}","received_events_url":"https://api.github.com/users/Grover-c13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grover-c13/PokeGOAPI-Java","description":"Pokemon Go API","fork":false,"url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java","forks_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/forks","keys_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/teams","hooks_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/hooks","issue_events_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/events{/number}","events_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/events","assignees_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/assignees{/user}","branches_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/branches{/branch}","tags_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/tags","blobs_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/languages","stargazers_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/stargazers","contributors_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/contributors","subscribers_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/subscribers","subscription_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/subscription","commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/contents/{+path}","compare_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/merges","archive_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/downloads","issues_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues{/number}","pulls_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/labels{/name}","releases_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/releases{/id}","deployments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/deployments","created_at":"2016-07-16T19:35:42Z","updated_at":"2016-07-25T08:12:26Z","pushed_at":"2016-07-25T08:12:51Z","git_url":"git://github.com/Grover-c13/PokeGOAPI-Java.git","ssh_url":"git@github.com:Grover-c13/PokeGOAPI-Java.git","clone_url":"https://github.com/Grover-c13/PokeGOAPI-Java.git","svn_url":"https://github.com/Grover-c13/PokeGOAPI-Java","homepage":null,"size":11322,"stargazers_count":510,"watchers_count":510,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"open_issues_count":19,"forks":131,"open_issues":19,"watchers":510,"default_branch":"Development"}},"_links":{"self":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199"},"html":{"href":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/199"},"issue":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/199"},"comments":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/6d4ac0a4d678eda8ba8d67413cf05a05a1d44249"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":34,"deletions":330,"changed_files":12}}
{"actor":{"display_login":"pvanassen"}}