{"action":"created","comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/74841099","id":74841099,"diff_hunk":"@@ -148,7 +148,8 @@ def collect_data(geop_result, geojson):\n     z['UrbAreaTotal'] = sum(z['Area'][NRur:])\n     z['PhosConc'] = phosphorus_conc(z['SedPhos'])\n \n-    z['NormalSys'] = normal_sys(z['Area'])\n+    normal_sys_estimate = int(num_normal_sys(z['Area']))","path":"src/mmw/apps/modeling/mapshed/tasks.py","position":null,"original_position":14,"commit_id":"a90c870432ebfa83f8a1dae7686285223fed5bdb","original_commit_id":"c5265a08dc7e5363c84081659edeba1e4425a3db","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"body":"Done! Also updated the docstring for that method to explain why it was returning an array of ints.","created_at":"2016-08-15T21:43:43Z","updated_at":"2016-08-15T21:43:43Z","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420#discussion_r74841099","pull_request_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420","_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/74841099"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1420#discussion_r74841099"},"pull_request":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420"}}},"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420","id":81331060,"html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420.patch","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420","number":1420,"state":"open","locked":false,"title":"Adjust `NormalSys` values in pre-processor","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"body":"This PR updates some of the code by which MMW creates its MapShed dictionary for GWLF-E by changing the names of `NormalSys` values to match GWLF-E's expected key -- `NumNormalSys`. It also changes the value of that key to an array of 12 ints, which is what GWLF-E expects to receive for calculating the \"Total Nitrogen\" value for Septic Systems.\r\n\r\n![screen shot 2016-08-15 at 11 40 37 am](https://cloud.githubusercontent.com/assets/4165523/17669816/28aa736e-62dd-11e6-8486-47aa8b9096d9.png)\r\n\r\nThe result so far only addresses the Total Nitrogen value: \"Sediment\" and \"Total Phosphorus\" remain 0 because we are using hard-coded 0 values for each.\r\n\r\nThe GWLF-E code returns a 0 for Septic/Sediment here: \r\nhttps://github.com/WikiWatershed/gwlf-e/blob/develop/gwlfe/WriteOutputFiles.py#L887\r\n\r\nMMW hard codes the values necessary to generate \"Total Phosphorus\" to an array of 12 zeroes here:\r\nhttps://github.com/WikiWatershed/model-my-watershed/blob/develop/src/mmw/mmw/settings/gwlfe_settings.py#L99\r\n\r\n**Testing**\r\n- grab this branch, `vagrant up`, `./scripts/bundle.sh` then visit `localhost:8000`\r\n- select an area of interest to analyze, then run the MapShed model\r\n- when modeling's done, select the \"Water Quality\" tab and scroll down to verify that there's a value for \"Total Nitrogen\"\r\n- create a new scenario, then export a gms file\r\n- from the command line run `cat <your-gms-file>.gms | sed '85,97!d'` and verify that position 1 at each of the lines after the first has a value\r\n\r\nConnects #1370 ","created_at":"2016-08-15T15:48:14Z","updated_at":"2016-08-15T21:43:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f19283d7c6ccd342f2342d5d72107d1610cb84bf","assignee":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420/commits","review_comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420/comments","review_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420/comments","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/a90c870432ebfa83f8a1dae7686285223fed5bdb","head":{"label":"kellyi:fix/septic-systems","ref":"fix/septic-systems","sha":"a90c870432ebfa83f8a1dae7686285223fed5bdb","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"repo":{"id":53861654,"name":"model-my-watershed","full_name":"kellyi/model-my-watershed","owner":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellyi/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":true,"url":"https://api.github.com/repos/kellyi/model-my-watershed","forks_url":"https://api.github.com/repos/kellyi/model-my-watershed/forks","keys_url":"https://api.github.com/repos/kellyi/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellyi/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellyi/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/kellyi/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/kellyi/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/kellyi/model-my-watershed/events","assignees_url":"https://api.github.com/repos/kellyi/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/kellyi/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/kellyi/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/kellyi/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellyi/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellyi/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellyi/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellyi/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/kellyi/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/kellyi/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/kellyi/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/kellyi/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/kellyi/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/kellyi/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellyi/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellyi/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellyi/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellyi/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/kellyi/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellyi/model-my-watershed/merges","archive_url":"https://api.github.com/repos/kellyi/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellyi/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/kellyi/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/kellyi/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/kellyi/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/kellyi/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellyi/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/kellyi/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/kellyi/model-my-watershed/deployments","created_at":"2016-03-14T14:11:15Z","updated_at":"2016-03-14T14:11:16Z","pushed_at":"2016-08-15T21:41:59Z","git_url":"git://github.com/kellyi/model-my-watershed.git","ssh_url":"git@github.com:kellyi/model-my-watershed.git","clone_url":"https://github.com/kellyi/model-my-watershed.git","svn_url":"https://github.com/kellyi/model-my-watershed","homepage":null,"size":17520,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"WikiWatershed:develop","ref":"develop","sha":"77ca09747886a09dd8d07113d68d63d7dd115727","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/deployments","created_at":"2015-03-23T16:02:55Z","updated_at":"2016-07-12T14:33:59Z","pushed_at":"2016-08-15T21:42:00Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"git@github.com:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":null,"size":18123,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":156,"forks":13,"open_issues":156,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1420"},"issue":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420"},"comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420/commits"},"statuses":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/a90c870432ebfa83f8a1dae7686285223fed5bdb"}}}}
{"actor":{"display_login":"kellyi"}}