{"action":"created","issue":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/710","repository_url":"https://api.github.com/repos/jackhumbert/qmk_firmware","labels_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/710/labels{/name}","comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/710/comments","events_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/710/events","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/710","id":174447788,"number":710,"title":"tap-dance: Do not start a sequence on keyup","user":{"login":"algernon","id":17243,"avatar_url":"https://avatars.githubusercontent.com/u/17243?v=3","gravatar_id":"","url":"https://api.github.com/users/algernon","html_url":"https://github.com/algernon","followers_url":"https://api.github.com/users/algernon/followers","following_url":"https://api.github.com/users/algernon/following{/other_user}","gists_url":"https://api.github.com/users/algernon/gists{/gist_id}","starred_url":"https://api.github.com/users/algernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algernon/subscriptions","organizations_url":"https://api.github.com/users/algernon/orgs","repos_url":"https://api.github.com/users/algernon/repos","events_url":"https://api.github.com/users/algernon/events{/privacy}","received_events_url":"https://api.github.com/users/algernon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-01T06:40:11Z","updated_at":"2016-09-05T17:16:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/710","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/710","diff_url":"https://github.com/jackhumbert/qmk_firmware/pull/710.diff","patch_url":"https://github.com/jackhumbert/qmk_firmware/pull/710.patch"},"body":"There was an odd case, which confused the hell out of tap-dance: suppose you had a number of tap-dance keys, on a layer, and as part of the tap-dance, you turned that layer off - or had it on one-shot to begin with. In this case, the keydown event would trigger the tap-dance key, but the keyup would not. This had two funky consequences:\r\n\r\n- tap-dance did not correctly register that the dance has ended.\r\n- pressing any other tap-dance key would interrupt the previous tap-dance, and potentially input unwanted characters.\r\n\r\nTo fix this, we simply do not start a tap-dance sequence on keyup, only when it is pressed. This way the previous sequence has enough time to time-out and finish properly, and we don't get confused.\r\n\r\nThis fixes algernon/ergodox-layout#107."},"comment":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/comments/244788683","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/710#issuecomment-244788683","issue_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/710","id":244788683,"user":{"login":"jackhumbert","id":141431,"avatar_url":"https://avatars.githubusercontent.com/u/141431?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T17:16:57Z","updated_at":"2016-09-05T17:16:57Z","body":"Cool :)"}}
{"actor":{"display_login":"jackhumbert"}}