{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/88748299","pull_request_review_id":9315650,"id":88748299,"diff_hunk":"@@ -0,0 +1,234 @@\n+---\n+title: Manage sensitive strings (secrets) for Docker services\n+description: How to securely store, retrieve, and use sensitive strings (secrets) in Docker services\n+keywords: swarm, secrets, credentials, sensitive strings, security, encryption, encryption at rest\n+---\n+\n+## About secrets\n+\n+In terms of Docker Swarm services, a _secret_ is a string, such as a password,\n+credit card number, SSH private key, SSL certificate, or another piece of\n+sensitive data that should not be transmitted over a network or stored in a\n+Dockerfile or in your application's source code in plain text. Starting in","path":"engine/swarm/store_sensitive_strings.md","position":12,"original_position":12,"commit_id":"e94df85981d1442040605fe7bb66275e6ba38463","original_commit_id":"e94df85981d1442040605fe7bb66275e6ba38463","user":{"login":"diogomonica","id":55332,"avatar_url":"https://avatars.githubusercontent.com/u/55332?v=3","gravatar_id":"","url":"https://api.github.com/users/diogomonica","html_url":"https://github.com/diogomonica","followers_url":"https://api.github.com/users/diogomonica/followers","following_url":"https://api.github.com/users/diogomonica/following{/other_user}","gists_url":"https://api.github.com/users/diogomonica/gists{/gist_id}","starred_url":"https://api.github.com/users/diogomonica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogomonica/subscriptions","organizations_url":"https://api.github.com/users/diogomonica/orgs","repos_url":"https://api.github.com/users/diogomonica/repos","events_url":"https://api.github.com/users/diogomonica/events{/privacy}","received_events_url":"https://api.github.com/users/diogomonica/received_events","type":"User","site_admin":false},"body":"starting with?","created_at":"2016-11-18T22:02:48Z","updated_at":"2016-11-18T22:02:48Z","html_url":"https://github.com/docker/docker.github.io/pull/568#discussion_r88748299","pull_request_url":"https://api.github.com/repos/docker/docker.github.io/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/88748299"},"html":{"href":"https://github.com/docker/docker.github.io/pull/568#discussion_r88748299"},"pull_request":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/568","id":93683232,"html_url":"https://github.com/docker/docker.github.io/pull/568","diff_url":"https://github.com/docker/docker.github.io/pull/568.diff","patch_url":"https://github.com/docker/docker.github.io/pull/568.patch","issue_url":"https://api.github.com/repos/docker/docker.github.io/issues/568","number":568,"state":"open","locked":false,"title":"Document secrets","user":{"login":"mstanleyjones","id":7674613,"avatar_url":"https://avatars.githubusercontent.com/u/7674613?v=3","gravatar_id":"","url":"https://api.github.com/users/mstanleyjones","html_url":"https://github.com/mstanleyjones","followers_url":"https://api.github.com/users/mstanleyjones/followers","following_url":"https://api.github.com/users/mstanleyjones/following{/other_user}","gists_url":"https://api.github.com/users/mstanleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/mstanleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstanleyjones/subscriptions","organizations_url":"https://api.github.com/users/mstanleyjones/orgs","repos_url":"https://api.github.com/users/mstanleyjones/repos","events_url":"https://api.github.com/users/mstanleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/mstanleyjones/received_events","type":"User","site_admin":false},"body":"### Describe the proposed changes\r\n\r\nAdd docs for using secrets, addresses #529.\r\n\r\n### Unreleased project version\r\n\r\nEngine 1.13\r\n\r\n### Related issue\r\n\r\n#529 \r\n\r\n### Related issue or PR in another project\r\n\r\nsee #529\r\n\r\n### Please take a look\r\n\r\n@ehazlett @thaJeztah @mrjana @stevvooe and please add anyone else who should review.\r\n\r\n\r\n<!-- To improve this template, edit .github/PULL_REQUEST_TEMPLATE.md. -->\r\n","created_at":"2016-11-15T01:22:20Z","updated_at":"2016-11-18T22:22:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ba42a0f5cc6d68cb9b4dfdb39216a8537a18157","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker.github.io/milestones/1","html_url":"https://github.com/docker/docker.github.io/milestones/engine/1.13.0","labels_url":"https://api.github.com/repos/docker/docker.github.io/milestones/1/labels","id":2077797,"number":1,"title":"engine/1.13.0","description":"Docs related to Engine 1.13.0. PR should be against `vnext-engine` branch.","creator":{"login":"mstanleyjones","id":7674613,"avatar_url":"https://avatars.githubusercontent.com/u/7674613?v=3","gravatar_id":"","url":"https://api.github.com/users/mstanleyjones","html_url":"https://github.com/mstanleyjones","followers_url":"https://api.github.com/users/mstanleyjones/followers","following_url":"https://api.github.com/users/mstanleyjones/following{/other_user}","gists_url":"https://api.github.com/users/mstanleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/mstanleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstanleyjones/subscriptions","organizations_url":"https://api.github.com/users/mstanleyjones/orgs","repos_url":"https://api.github.com/users/mstanleyjones/repos","events_url":"https://api.github.com/users/mstanleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/mstanleyjones/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":11,"state":"open","created_at":"2016-10-18T16:54:12Z","updated_at":"2016-11-18T19:17:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker.github.io/pulls/568/commits","review_comments_url":"https://api.github.com/repos/docker/docker.github.io/pulls/568/comments","review_comment_url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker.github.io/issues/568/comments","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/e94df85981d1442040605fe7bb66275e6ba38463","head":{"label":"mstanleyjones:529_secrets","ref":"529_secrets","sha":"e94df85981d1442040605fe7bb66275e6ba38463","user":{"login":"mstanleyjones","id":7674613,"avatar_url":"https://avatars.githubusercontent.com/u/7674613?v=3","gravatar_id":"","url":"https://api.github.com/users/mstanleyjones","html_url":"https://github.com/mstanleyjones","followers_url":"https://api.github.com/users/mstanleyjones/followers","following_url":"https://api.github.com/users/mstanleyjones/following{/other_user}","gists_url":"https://api.github.com/users/mstanleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/mstanleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstanleyjones/subscriptions","organizations_url":"https://api.github.com/users/mstanleyjones/orgs","repos_url":"https://api.github.com/users/mstanleyjones/repos","events_url":"https://api.github.com/users/mstanleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/mstanleyjones/received_events","type":"User","site_admin":false},"repo":{"id":69602763,"name":"docker.github.io","full_name":"mstanleyjones/docker.github.io","owner":{"login":"mstanleyjones","id":7674613,"avatar_url":"https://avatars.githubusercontent.com/u/7674613?v=3","gravatar_id":"","url":"https://api.github.com/users/mstanleyjones","html_url":"https://github.com/mstanleyjones","followers_url":"https://api.github.com/users/mstanleyjones/followers","following_url":"https://api.github.com/users/mstanleyjones/following{/other_user}","gists_url":"https://api.github.com/users/mstanleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/mstanleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstanleyjones/subscriptions","organizations_url":"https://api.github.com/users/mstanleyjones/orgs","repos_url":"https://api.github.com/users/mstanleyjones/repos","events_url":"https://api.github.com/users/mstanleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/mstanleyjones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstanleyjones/docker.github.io","description":"Test repository for Jekyll-based, one-repo docs structure. NOT the source of truth for docs.","fork":true,"url":"https://api.github.com/repos/mstanleyjones/docker.github.io","forks_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/forks","keys_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/teams","hooks_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/events","assignees_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/tags","blobs_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/subscription","commits_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/merges","archive_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/downloads","issues_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/mstanleyjones/docker.github.io/deployments","created_at":"2016-09-29T19:54:49Z","updated_at":"2016-09-29T19:54:54Z","pushed_at":"2016-11-18T21:49:54Z","git_url":"git://github.com/mstanleyjones/docker.github.io.git","ssh_url":"git@github.com:mstanleyjones/docker.github.io.git","clone_url":"https://github.com/mstanleyjones/docker.github.io.git","svn_url":"https://github.com/mstanleyjones/docker.github.io","homepage":"https://docker.github.io","size":356028,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:vnext-engine","ref":"vnext-engine","sha":"5bef5da9befed03fc87054a95116d743a990b1c9","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":65772720,"name":"docker.github.io","full_name":"docker/docker.github.io","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker.github.io","description":"Source repo for Docker's Documentation","fork":false,"url":"https://api.github.com/repos/docker/docker.github.io","forks_url":"https://api.github.com/repos/docker/docker.github.io/forks","keys_url":"https://api.github.com/repos/docker/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker.github.io/teams","hooks_url":"https://api.github.com/repos/docker/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/docker/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker.github.io/events","assignees_url":"https://api.github.com/repos/docker/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker.github.io/tags","blobs_url":"https://api.github.com/repos/docker/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/docker/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/docker/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/docker/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/docker/docker.github.io/subscription","commits_url":"https://api.github.com/repos/docker/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker.github.io/merges","archive_url":"https://api.github.com/repos/docker/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker.github.io/downloads","issues_url":"https://api.github.com/repos/docker/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker.github.io/deployments","created_at":"2016-08-15T23:50:51Z","updated_at":"2016-11-16T15:59:18Z","pushed_at":"2016-11-18T22:14:11Z","git_url":"git://github.com/docker/docker.github.io.git","ssh_url":"git@github.com:docker/docker.github.io.git","clone_url":"https://github.com/docker/docker.github.io.git","svn_url":"https://github.com/docker/docker.github.io","homepage":"https://docs.docker.com","size":356982,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":303,"mirror_url":null,"open_issues_count":115,"forks":303,"open_issues":115,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/568"},"html":{"href":"https://github.com/docker/docker.github.io/pull/568"},"issue":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/568"},"comments":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker.github.io/statuses/e94df85981d1442040605fe7bb66275e6ba38463"}}}}
{"actor":{"display_login":"diogomonica"}}