{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/73106142","id":73106142,"diff_hunk":"@@ -310,6 +310,14 @@ class NetworkStack {\n   virtual void spawn_worker(unsigned i, std::function<void ()> &&) = 0;\n   virtual void join_worker(unsigned i) = 0;\n \n+  virtual void handle_pre_fork() override {","path":"src/msg/async/Stack.h","position":null,"original_position":13,"commit_id":"ea92bdb17741364425b879d03b55dc72fbcd4e97","original_commit_id":"a3250e75dcd1156b72ae717de9c5f6f735be84c2","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"does this hold for simple msgr also?","created_at":"2016-08-02T07:29:43Z","updated_at":"2016-08-02T07:29:43Z","html_url":"https://github.com/ceph/ceph/pull/10264#discussion_r73106142","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10264","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/73106142"},"html":{"href":"https://github.com/ceph/ceph/pull/10264#discussion_r73106142"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10264"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10264","id":77151875,"html_url":"https://github.com/ceph/ceph/pull/10264","diff_url":"https://github.com/ceph/ceph/pull/10264.diff","patch_url":"https://github.com/ceph/ceph/pull/10264.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10264","number":10264,"state":"open","locked":false,"title":"Wip async abstract backend","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars.githubusercontent.com/u/980577?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-12T16:49:32Z","updated_at":"2016-08-02T07:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf268cef12c0ba7f1c59046157abc17e145451cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10264/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10264/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10264/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ea92bdb17741364425b879d03b55dc72fbcd4e97","head":{"label":"yuyuyu101:wip-async-abstract-backend","ref":"wip-async-abstract-backend","sha":"ea92bdb17741364425b879d03b55dc72fbcd4e97","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars.githubusercontent.com/u/980577?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"repo":{"id":13030337,"name":"ceph","full_name":"yuyuyu101/ceph","owner":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars.githubusercontent.com/u/980577?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuyuyu101/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yuyuyu101/ceph","forks_url":"https://api.github.com/repos/yuyuyu101/ceph/forks","keys_url":"https://api.github.com/repos/yuyuyu101/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuyuyu101/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuyuyu101/ceph/teams","hooks_url":"https://api.github.com/repos/yuyuyu101/ceph/hooks","issue_events_url":"https://api.github.com/repos/yuyuyu101/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yuyuyu101/ceph/events","assignees_url":"https://api.github.com/repos/yuyuyu101/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yuyuyu101/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yuyuyu101/ceph/tags","blobs_url":"https://api.github.com/repos/yuyuyu101/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuyuyu101/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuyuyu101/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuyuyu101/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuyuyu101/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yuyuyu101/ceph/languages","stargazers_url":"https://api.github.com/repos/yuyuyu101/ceph/stargazers","contributors_url":"https://api.github.com/repos/yuyuyu101/ceph/contributors","subscribers_url":"https://api.github.com/repos/yuyuyu101/ceph/subscribers","subscription_url":"https://api.github.com/repos/yuyuyu101/ceph/subscription","commits_url":"https://api.github.com/repos/yuyuyu101/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuyuyu101/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuyuyu101/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuyuyu101/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuyuyu101/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yuyuyu101/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuyuyu101/ceph/merges","archive_url":"https://api.github.com/repos/yuyuyu101/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuyuyu101/ceph/downloads","issues_url":"https://api.github.com/repos/yuyuyu101/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yuyuyu101/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yuyuyu101/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yuyuyu101/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuyuyu101/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yuyuyu101/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yuyuyu101/ceph/deployments","created_at":"2013-09-23T08:18:33Z","updated_at":"2016-07-01T02:28:44Z","pushed_at":"2016-08-02T02:20:25Z","git_url":"git://github.com/yuyuyu101/ceph.git","ssh_url":"git@github.com:yuyuyu101/ceph.git","clone_url":"https://github.com/yuyuyu101/ceph.git","svn_url":"https://github.com/yuyuyu101/ceph","homepage":"http://ceph.com","size":188334,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3e5775475baf315885295ae47a0f4a86820bfe0f","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-08-02T03:19:30Z","pushed_at":"2016-08-02T07:21:27Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":230790,"stargazers_count":2342,"watchers_count":2342,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1394,"mirror_url":null,"open_issues_count":488,"forks":1394,"open_issues":488,"watchers":2342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10264"},"html":{"href":"https://github.com/ceph/ceph/pull/10264"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10264"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10264/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10264/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10264/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ea92bdb17741364425b879d03b55dc72fbcd4e97"}}}}
{"actor":{"display_login":"tchaikov"}}