{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/8321","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/8321/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8321/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/8321/events","html_url":"https://github.com/highfidelity/hifi/pull/8321","id":167645596,"number":8321,"title":"Fix depth state caching / resetting","user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved","name":"QA Approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-26T15:58:59Z","updated_at":"2016-07-26T19:19:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8321","html_url":"https://github.com/highfidelity/hifi/pull/8321","diff_url":"https://github.com/highfidelity/hifi/pull/8321.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8321.patch"},"body":"During deferred batch work I discovered a flaw in our caching function.  When resetting the state, if we're disabling the depth test, we fail to reset the write mask and depth function.  However, the do_clearFramebuffer functionality depends on the state properly matching the current cache (in particular, the write mask, which is orthogonal to the depth test setting when doing clears).\r\n\r\n## Testing\r\n\r\nBasic smoke test.  This PR should have no visible change on the application.  It only affects behavior (fixing the depth clear) in my deferred batch branch.  "},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/235375692","html_url":"https://github.com/highfidelity/hifi/pull/8321#issuecomment-235375692","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8321","id":235375692,"user":{"login":"hifi-gustavo","id":4554450,"avatar_url":"https://avatars.githubusercontent.com/u/4554450?v=3","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T19:19:51Z","updated_at":"2016-07-26T19:19:51Z","body":"Build console output for commit: ac743b6acbe20dda7fde4c630a00f1ad2f5cebad available at: https://gist.github.com/4a3d1d693b6b9d396a571380fb5a9ccc<br/><br/>Installers available for download at: <br/>Windows: http://cachefly.highfidelity.com/HighFidelity-Beta-PR8321-ac743b6.exe<br/>OS X: http://cachefly.highfidelity.com/HighFidelity-Beta-PR8321-ac743b6.dmg"}}
{"actor":{"display_login":"hifi-gustavo"}}