{"action":"created","issue":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/69","repository_url":"https://api.github.com/repos/gemini-hlsw/ocs3","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/69/comments","events_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/69/events","html_url":"https://github.com/gemini-hlsw/ocs3/pull/69","id":161765298,"number":69,"title":"Binary encoding","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-22T19:25:50Z","updated_at":"2016-07-01T14:41:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/69","html_url":"https://github.com/gemini-hlsw/ocs3/pull/69","diff_url":"https://github.com/gemini-hlsw/ocs3/pull/69.diff","patch_url":"https://github.com/gemini-hlsw/ocs3/pull/69.patch"},"body":"This PR uses [boopickle](https://github.com/ochrons/boopickle) to convert the messages between client and server from json to binary. This produces an important reduction on the payload size especially due to the repetition of values in sequences\r\n\r\nThe method used here doesn't forbid to have also a json representation if needed for non-scala clients though it wasn't implemented\r\n\r\nGZip is also enabled to gain and even larger more reduction\r\n\r\nGiven the possible incompatibilities of binary websockets and gzip compression this was tested on\r\n\r\n* Chrome/OSX\r\n* Firefox 38/OSX\r\n* Safari/OSX\r\n* Safari/iOS\r\n* Firefox 38/Linux\r\n\r\nFixes #18 "},"comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/comments/229964849","html_url":"https://github.com/gemini-hlsw/ocs3/pull/69#issuecomment-229964849","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/69","id":229964849,"user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T14:41:57Z","updated_at":"2016-07-01T14:41:57Z","body":"Can you point some examples of repeated code to removed? Sometimes when they are very small things I tend to just leave them repeated"}}
{"actor":{"display_login":"cquiroz"}}