{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/1682","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/1682/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/1682/comments","events_url":"https://api.github.com/repos/apple/swift/issues/1682/events","html_url":"https://github.com/apple/swift/pull/1682","id":140801207,"number":1682,"title":"[Compare Perf] Add support for markdown and html","user":{"login":"shahmishal","id":2727770,"avatar_url":"https://avatars.githubusercontent.com/u/2727770?v=3","gravatar_id":"","url":"https://api.github.com/users/shahmishal","html_url":"https://github.com/shahmishal","followers_url":"https://api.github.com/users/shahmishal/followers","following_url":"https://api.github.com/users/shahmishal/following{/other_user}","gists_url":"https://api.github.com/users/shahmishal/gists{/gist_id}","starred_url":"https://api.github.com/users/shahmishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahmishal/subscriptions","organizations_url":"https://api.github.com/users/shahmishal/orgs","repos_url":"https://api.github.com/users/shahmishal/repos","events_url":"https://api.github.com/users/shahmishal/events{/privacy}","received_events_url":"https://api.github.com/users/shahmishal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-14T21:22:52Z","updated_at":"2016-03-14T21:36:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1682","html_url":"https://github.com/apple/swift/pull/1682","diff_url":"https://github.com/apple/swift/pull/1682.diff","patch_url":"https://github.com/apple/swift/pull/1682.patch"},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\nCompare perf results supports following args:\r\n```\r\noptional arguments:\r\n  -h, --help            show this help message and exit\r\n  --old-file OLD_FILE   Baseline performance test suite (csv file)\r\n  --new-file NEW_FILE   New performance test suite (csv file)\r\n  --format FORMAT       Supported format git, html and markdown\r\n  --output OUTPUT       Output file name\r\n  --changes-only        Output only affected tests\r\n  --new-branch NEW_BRANCH\r\n                        Name of the new branch\r\n  --old-branch OLD_BRANCH\r\n                        Name of the old branch\r\n  --delta-threshold DELTA_THRESHOLD\r\n                        delta threshold\r\n```\r\n\r\n#### Resolved bug number: N/A\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/196531151","html_url":"https://github.com/apple/swift/pull/1682#issuecomment-196531151","issue_url":"https://api.github.com/repos/apple/swift/issues/1682","id":196531151,"user":{"login":"practicalswift","id":7826565,"avatar_url":"https://avatars.githubusercontent.com/u/7826565?v=3","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T21:36:10Z","updated_at":"2016-03-14T21:36:10Z","body":"@shahmishal Nice stuff!\r\n\r\nA friendly side note - I think there might be a few `flake8` regressions in there that might be worth looking in to:\r\n\r\n```\r\n$ flake8 | cut -f4- -d: | sort | uniq -c\r\n    126  E111 indentation is not a multiple of four\r\n      3  E122 continuation line missing indentation or outdented\r\n      3  E127 continuation line over-indented for visual indent\r\n      3  E128 continuation line under-indented for visual indent\r\n      1  E131 continuation line unaligned for hanging indent\r\n      1  E203 whitespace before ':'\r\n      3  E222 multiple spaces after operator\r\n      3  E231 missing whitespace after ','\r\n      6  E302 expected 2 blank lines, found 1\r\n     16  E501 line too long (… > 79 characters)\r\n      2  E711 comparison to None should be 'if cond is not None:'\r\n      1  F401 'os' imported but unused\r\n      1  F841 local variable 'geogebra_value' is assigned to but never used\r\n      1  F841 local variable 'normalList' is assigned to but never used\r\n      1  I100 Import statements are in the wrong order. import argparse should be before import csv\r\n      1  I100 Import statements are in the wrong order. import csv should be before import sys\r\n      1  N806 variable in function should be lowercase\r\n```\r\n\r\nI can fix them afterwards but that will cause some unnecessary `git blame` noise :-)"}}