{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/comments/85605320","pull_request_review_id":6314731,"id":85605320,"diff_hunk":"@@ -687,15 +740,32 @@ def get_data_dictionaries(json_files, benchmarks=[], wallclock_only=False,\n                         data_dictionary['cycles_counts'][key] = dict()\n                         data_dictionary['aperf_counts'][key] = dict()\n                         data_dictionary['mperf_counts'][key] = dict()\n+                        if instr_data:\n+                            data_dictionary['instr_data'][key] = dict()\n                     data_dictionary['data'][key][machine] = data['wallclock_times'][key]\n                     if wallclock_only:\n                         data_dictionary['cycles_counts'][key][machine] = None\n                         data_dictionary['aperf_counts'][key][machine] = None\n                         data_dictionary['mperf_counts'][key][machine] = None\n+                        if instr_data:\n+                            data_dictionary['instr_data'][key][machine] = None\n                     else:\n                         data_dictionary['cycles_counts'][key][machine] = data['core_cycle_counts'][key]\n                         data_dictionary['aperf_counts'][key][machine] = data['aperf_counts'][key]\n                         data_dictionary['mperf_counts'][key][machine] = data['mperf_counts'][key]\n+                        if instr_data:\n+                            _, vm, _ = key.split(':')","path":"bin/plot_krun_results","position":212,"original_position":212,"commit_id":"603be8a5709735e9f8ba518f12d5bc149081f0cf","original_commit_id":"603be8a5709735e9f8ba518f12d5bc149081f0cf","user":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"Might be clearer as `vm = key.split(':')[1]`?","created_at":"2016-10-28T20:33:39Z","updated_at":"2016-10-28T20:34:30Z","html_url":"https://github.com/softdevteam/warmup_experiment/pull/212#discussion_r85605320","pull_request_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/comments/85605320"},"html":{"href":"https://github.com/softdevteam/warmup_experiment/pull/212#discussion_r85605320"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212","id":91411598,"html_url":"https://github.com/softdevteam/warmup_experiment/pull/212","diff_url":"https://github.com/softdevteam/warmup_experiment/pull/212.diff","patch_url":"https://github.com/softdevteam/warmup_experiment/pull/212.patch","issue_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/212","number":212,"state":"open","locked":false,"title":"Obtain instr_data from files.","user":{"login":"snim2","id":97674,"avatar_url":"https://avatars.githubusercontent.com/u/97674?v=3","gravatar_id":"","url":"https://api.github.com/users/snim2","html_url":"https://github.com/snim2","followers_url":"https://api.github.com/users/snim2/followers","following_url":"https://api.github.com/users/snim2/following{/other_user}","gists_url":"https://api.github.com/users/snim2/gists{/gist_id}","starred_url":"https://api.github.com/users/snim2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snim2/subscriptions","organizations_url":"https://api.github.com/users/snim2/orgs","repos_url":"https://api.github.com/users/snim2/repos","events_url":"https://api.github.com/users/snim2/events{/privacy}","received_events_url":"https://api.github.com/users/snim2/received_events","type":"User","site_admin":false},"body":"This PR adds all our available instrumentation data to the plots, in the new file format.\r\n\r\nThe PyPy instrumentation parser is based on [this gist](https://gist.github.com/vext01/3b685296d938cd78363dc6cd4e22754d).\r\n\r\nPlease check very carefully (particularly units of measurement, these are definitely wrong for PyPy, but I'm not sure what they should be).\r\n\r\n**Test case**: [test.pdf](https://github.com/softdevteam/warmup_experiment/files/559088/test.pdf)\r\n\r\n\r\nFixes #163\r\nFixes #201 ","created_at":"2016-10-28T16:28:00Z","updated_at":"2016-10-28T20:34:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03dfeb66fb2d31deffe0d5b4e3aaffa19fabb58","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212/commits","review_comments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212/comments","review_comment_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/212/comments","statuses_url":"https://api.github.com/repos/softdevteam/warmup_experiment/statuses/603be8a5709735e9f8ba518f12d5bc149081f0cf","head":{"label":"softdevteam:plot_instrumentation_data","ref":"plot_instrumentation_data","sha":"603be8a5709735e9f8ba518f12d5bc149081f0cf","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36934890,"name":"warmup_experiment","full_name":"softdevteam/warmup_experiment","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/warmup_experiment","description":"Experiment designed to investigate JIT warmup times.","fork":false,"url":"https://api.github.com/repos/softdevteam/warmup_experiment","forks_url":"https://api.github.com/repos/softdevteam/warmup_experiment/forks","keys_url":"https://api.github.com/repos/softdevteam/warmup_experiment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/warmup_experiment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/warmup_experiment/teams","hooks_url":"https://api.github.com/repos/softdevteam/warmup_experiment/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/warmup_experiment/events","assignees_url":"https://api.github.com/repos/softdevteam/warmup_experiment/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/warmup_experiment/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/warmup_experiment/tags","blobs_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/warmup_experiment/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/warmup_experiment/languages","stargazers_url":"https://api.github.com/repos/softdevteam/warmup_experiment/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/warmup_experiment/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/warmup_experiment/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/warmup_experiment/subscription","commits_url":"https://api.github.com/repos/softdevteam/warmup_experiment/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/warmup_experiment/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/warmup_experiment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/warmup_experiment/merges","archive_url":"https://api.github.com/repos/softdevteam/warmup_experiment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/warmup_experiment/downloads","issues_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/warmup_experiment/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/warmup_experiment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/warmup_experiment/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/warmup_experiment/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/deployments","created_at":"2015-06-05T13:44:08Z","updated_at":"2016-01-25T14:57:10Z","pushed_at":"2016-10-28T18:20:50Z","git_url":"git://github.com/softdevteam/warmup_experiment.git","ssh_url":"git@github.com:softdevteam/warmup_experiment.git","clone_url":"https://github.com/softdevteam/warmup_experiment.git","svn_url":"https://github.com/softdevteam/warmup_experiment","homepage":null,"size":566,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"d4dbd163cad62b45749aa51728501d9e2044c880","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36934890,"name":"warmup_experiment","full_name":"softdevteam/warmup_experiment","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/warmup_experiment","description":"Experiment designed to investigate JIT warmup times.","fork":false,"url":"https://api.github.com/repos/softdevteam/warmup_experiment","forks_url":"https://api.github.com/repos/softdevteam/warmup_experiment/forks","keys_url":"https://api.github.com/repos/softdevteam/warmup_experiment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/warmup_experiment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/warmup_experiment/teams","hooks_url":"https://api.github.com/repos/softdevteam/warmup_experiment/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/warmup_experiment/events","assignees_url":"https://api.github.com/repos/softdevteam/warmup_experiment/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/warmup_experiment/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/warmup_experiment/tags","blobs_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/warmup_experiment/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/warmup_experiment/languages","stargazers_url":"https://api.github.com/repos/softdevteam/warmup_experiment/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/warmup_experiment/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/warmup_experiment/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/warmup_experiment/subscription","commits_url":"https://api.github.com/repos/softdevteam/warmup_experiment/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/warmup_experiment/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/warmup_experiment/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/warmup_experiment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/warmup_experiment/merges","archive_url":"https://api.github.com/repos/softdevteam/warmup_experiment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/warmup_experiment/downloads","issues_url":"https://api.github.com/repos/softdevteam/warmup_experiment/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/warmup_experiment/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/warmup_experiment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/warmup_experiment/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/warmup_experiment/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/warmup_experiment/deployments","created_at":"2015-06-05T13:44:08Z","updated_at":"2016-01-25T14:57:10Z","pushed_at":"2016-10-28T18:20:50Z","git_url":"git://github.com/softdevteam/warmup_experiment.git","ssh_url":"git@github.com:softdevteam/warmup_experiment.git","clone_url":"https://github.com/softdevteam/warmup_experiment.git","svn_url":"https://github.com/softdevteam/warmup_experiment","homepage":null,"size":566,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212"},"html":{"href":"https://github.com/softdevteam/warmup_experiment/pull/212"},"issue":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/212"},"comments":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/warmup_experiment/statuses/603be8a5709735e9f8ba518f12d5bc149081f0cf"}}}}
{"actor":{"display_login":"ltratt"}}