{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/61616074","id":61616074,"diff_hunk":"@@ -13,19 +13,21 @@ import { match } from 'react-router';\n import { ReduxAsyncConnect, loadOnServer } from 'redux-async-connect';\n \n import WebpackIsomorphicTools from 'webpack-isomorphic-tools';\n-import WebpackIsomorphicToolsConfig from 'config/webpack-isomorphic-tools';\n+import WebpackIsomorphicToolsConfig from 'webpack-isomorphic-tools-config';\n \n import config from 'config';\n import { setJWT } from 'core/actions';\n \n+const env = config.util.getEnv('NODE_ENV');\n+const isDeployed = ['stage', 'dev', 'production'].indexOf(env) > -1;","path":"src/core/server/base.js","position":11,"original_position":11,"commit_id":"558ffd99cf33aaae39aeb1ac6b682dda3c692511","original_commit_id":"558ffd99cf33aaae39aeb1ac6b682dda3c692511","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"Is this the same as `global.DEVELOPMENT`?","created_at":"2016-04-29T17:32:15Z","updated_at":"2016-04-29T17:32:15Z","html_url":"https://github.com/mozilla/addons-frontend/pull/280#discussion_r61616074","pull_request_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/61616074"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/280#discussion_r61616074"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280","id":68304187,"html_url":"https://github.com/mozilla/addons-frontend/pull/280","diff_url":"https://github.com/mozilla/addons-frontend/pull/280.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/280.patch","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/280","number":280,"state":"open","locked":false,"title":"Refactor configuration for server and client","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"Fixes #272\r\nFixes #260 \r\nFixes #240\r\n\r\n* Clearly separates the client and server config - since on the client the client module is pointing at client-config which is just exposes only the conf keys set as clientConfigKeys in the main config.\r\n* Sets up differences for dev/stage/production and developement\r\n* fixes imports for test helpers \r\n* Moves webpack config out of `/src`\r\n* Fixed up all imports using `../` etc\r\n* Added a catch clause to the server so when the promise blows up we see a stack trace and get a 500 error. Making the 500 nicer will come later.\r\n\r\n@jasonthomas  this will need some modifcations to the deployment since you'll need to specify `NODE_ENV` in the deploy scripts after this lands.\r\n\r\ne.g:\r\n\r\n```\r\nNODE_ENV=dev npm run build:disco \r\nNODE_ENV=dev npm run start:disco\r\n```\r\n\r\nReplacing `dev` with `stage` or `production` for the other cases and `disco` with `search` for the search app deployment.\r\n","created_at":"2016-04-28T23:02:32Z","updated_at":"2016-04-29T17:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f9d0f6ed8f98d23c0e3ad8c85dda7bd0e0bb651","assignee":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/280/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/558ffd99cf33aaae39aeb1ac6b682dda3c692511","head":{"label":"muffinresearch:refactor-config","ref":"refactor-config","sha":"558ffd99cf33aaae39aeb1ac6b682dda3c692511","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":52104378,"name":"addons-frontend","full_name":"muffinresearch/addons-frontend","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/addons-frontend","description":"Front-end infrastructure and code to complement mozilla/addons-server","fork":true,"url":"https://api.github.com/repos/muffinresearch/addons-frontend","forks_url":"https://api.github.com/repos/muffinresearch/addons-frontend/forks","keys_url":"https://api.github.com/repos/muffinresearch/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/addons-frontend/teams","hooks_url":"https://api.github.com/repos/muffinresearch/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/addons-frontend/events","assignees_url":"https://api.github.com/repos/muffinresearch/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/addons-frontend/tags","blobs_url":"https://api.github.com/repos/muffinresearch/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/addons-frontend/subscription","commits_url":"https://api.github.com/repos/muffinresearch/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/muffinresearch/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/addons-frontend/merges","archive_url":"https://api.github.com/repos/muffinresearch/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/addons-frontend/downloads","issues_url":"https://api.github.com/repos/muffinresearch/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/muffinresearch/addons-frontend/deployments","created_at":"2016-02-19T17:26:17Z","updated_at":"2016-03-11T16:08:46Z","pushed_at":"2016-04-29T10:56:36Z","git_url":"git://github.com/muffinresearch/addons-frontend.git","ssh_url":"git@github.com:muffinresearch/addons-frontend.git","clone_url":"https://github.com/muffinresearch/addons-frontend.git","svn_url":"https://github.com/muffinresearch/addons-frontend","homepage":null,"size":235,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"228e1d1eb0432eaa8ba584cdab06f73ff9596741","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":52104368,"name":"addons-frontend","full_name":"mozilla/addons-frontend","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-frontend","description":"Front-end infrastructure and code to complement mozilla/addons-server","fork":false,"url":"https://api.github.com/repos/mozilla/addons-frontend","forks_url":"https://api.github.com/repos/mozilla/addons-frontend/forks","keys_url":"https://api.github.com/repos/mozilla/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-frontend/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-frontend/events","assignees_url":"https://api.github.com/repos/mozilla/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-frontend/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-frontend/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-frontend/merges","archive_url":"https://api.github.com/repos/mozilla/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-frontend/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-frontend/deployments","created_at":"2016-02-19T17:25:57Z","updated_at":"2016-02-23T16:02:34Z","pushed_at":"2016-04-29T17:31:11Z","git_url":"git://github.com/mozilla/addons-frontend.git","ssh_url":"git@github.com:mozilla/addons-frontend.git","clone_url":"https://github.com/mozilla/addons-frontend.git","svn_url":"https://github.com/mozilla/addons-frontend","homepage":null,"size":301,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":34,"forks":4,"open_issues":34,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/280"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/280"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-frontend/statuses/558ffd99cf33aaae39aeb1ac6b682dda3c692511"}}}}