{"action":"created","comment":{"url":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments/63524367","id":63524367,"diff_hunk":"@@ -18,10 +18,15 @@\n <module xmlns=\"urn:jboss:module:1.3\" name=\"org.modeshape.index-provider.lucene\">\n     <resources>\n         <resource-root path=\"modeshape-lucene-index-provider-${project.version}.jar\" />\n+        <resource-root path=\"lucene-analyzers-common-${version.org.apache.lucene}.jar\" />\n+        <resource-root path=\"lucene-core-${version.org.apache.lucene}.jar\" />\n+        <resource-root path=\"lucene-queries-${version.org.apache.lucene}.jar\" />\n+        <resource-root path=\"lucene-queryparser-${version.org.apache.lucene}.jar\" />\n+        <resource-root path=\"lucene-sandbox-${version.org.apache.lucene}.jar\" />\n+        <resource-root path=\"lucene-backward-codecs-${version.org.apache.lucene}.jar\" />","path":"deploy/jbossas/kit/jboss-wf/org/modeshape/index-provider/lucene/main/module.xml","position":9,"original_position":9,"commit_id":"f60ae6ac6e58edad074543b06db9b7ff7d5db388","original_commit_id":"f60ae6ac6e58edad074543b06db9b7ff7d5db388","user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2016-05-17T13:48:55Z","updated_at":"2016-05-17T13:48:55Z","html_url":"https://github.com/ModeShape/modeshape/pull/1557#discussion_r63524367","pull_request_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments/63524367"},"html":{"href":"https://github.com/ModeShape/modeshape/pull/1557#discussion_r63524367"},"pull_request":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557","id":70357940,"html_url":"https://github.com/ModeShape/modeshape/pull/1557","diff_url":"https://github.com/ModeShape/modeshape/pull/1557.diff","patch_url":"https://github.com/ModeShape/modeshape/pull/1557.patch","issue_url":"https://api.github.com/repos/ModeShape/modeshape/issues/1557","number":1557,"state":"open","locked":false,"title":"MODE-2585, MODE-2586 Updates Lucene to 6.0.Final and changes some of the Lucene querying code","user":{"login":"hchiorean","id":995683,"avatar_url":"https://avatars.githubusercontent.com/u/995683?v=3","gravatar_id":"","url":"https://api.github.com/users/hchiorean","html_url":"https://github.com/hchiorean","followers_url":"https://api.github.com/users/hchiorean/followers","following_url":"https://api.github.com/users/hchiorean/following{/other_user}","gists_url":"https://api.github.com/users/hchiorean/gists{/gist_id}","starred_url":"https://api.github.com/users/hchiorean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hchiorean/subscriptions","organizations_url":"https://api.github.com/users/hchiorean/orgs","repos_url":"https://api.github.com/users/hchiorean/repos","events_url":"https://api.github.com/users/hchiorean/events{/privacy}","received_events_url":"https://api.github.com/users/hchiorean/received_events","type":"User","site_admin":false},"body":"The following are contained in this commit:\r\n\r\na) changing the version to 6.0.Final and making it a private dependency of the `lucene-index-provider` in WF means we should now be independent of whatever version of Lucene WF/EAP comes with. ModeShape will no longer install Lucene as a first-class dependency in WF.\r\n\r\nb) with the above change, the ES index provider will use its own separate version (in this case 5.3.1.Final) and from now on can be evolved independently of the `lucene-index-provider`\r\n\r\nc) changing the design around the `Filter#Results` batching mechanism so that index providers can opt for truly lazy index results when SKIP is used. In the case of Lucene this means that the Lucene query is only run once after the first N batches have been skipped.\r\n\r\nd) changing the logic of the Lucene query making use of `BitSets` and bulk-loading documents at the end of the scoring phase as opposed to loading each document during the collection phase.","created_at":"2016-05-17T13:36:45Z","updated_at":"2016-05-17T13:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e94b5427cff07707045bf6ce76db2f1b463c4c58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ModeShape/modeshape/issues/1557/comments","statuses_url":"https://api.github.com/repos/ModeShape/modeshape/statuses/f60ae6ac6e58edad074543b06db9b7ff7d5db388","head":{"label":"hchiorean:MODE-2586","ref":"MODE-2586","sha":"f60ae6ac6e58edad074543b06db9b7ff7d5db388","user":{"login":"hchiorean","id":995683,"avatar_url":"https://avatars.githubusercontent.com/u/995683?v=3","gravatar_id":"","url":"https://api.github.com/users/hchiorean","html_url":"https://github.com/hchiorean","followers_url":"https://api.github.com/users/hchiorean/followers","following_url":"https://api.github.com/users/hchiorean/following{/other_user}","gists_url":"https://api.github.com/users/hchiorean/gists{/gist_id}","starred_url":"https://api.github.com/users/hchiorean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hchiorean/subscriptions","organizations_url":"https://api.github.com/users/hchiorean/orgs","repos_url":"https://api.github.com/users/hchiorean/repos","events_url":"https://api.github.com/users/hchiorean/events{/privacy}","received_events_url":"https://api.github.com/users/hchiorean/received_events","type":"User","site_admin":false},"repo":{"id":2686838,"name":"modeshape","full_name":"hchiorean/modeshape","owner":{"login":"hchiorean","id":995683,"avatar_url":"https://avatars.githubusercontent.com/u/995683?v=3","gravatar_id":"","url":"https://api.github.com/users/hchiorean","html_url":"https://github.com/hchiorean","followers_url":"https://api.github.com/users/hchiorean/followers","following_url":"https://api.github.com/users/hchiorean/following{/other_user}","gists_url":"https://api.github.com/users/hchiorean/gists{/gist_id}","starred_url":"https://api.github.com/users/hchiorean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hchiorean/subscriptions","organizations_url":"https://api.github.com/users/hchiorean/orgs","repos_url":"https://api.github.com/users/hchiorean/repos","events_url":"https://api.github.com/users/hchiorean/events{/privacy}","received_events_url":"https://api.github.com/users/hchiorean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hchiorean/modeshape","description":"ModeShape is a lightweight, fast, pluggable, open-source, federating JCR implementation that can unify content from multiple systems, including files systems, databases, data grids, other repositories, etc.  This is the official source code repository for ModeShape.","fork":true,"url":"https://api.github.com/repos/hchiorean/modeshape","forks_url":"https://api.github.com/repos/hchiorean/modeshape/forks","keys_url":"https://api.github.com/repos/hchiorean/modeshape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hchiorean/modeshape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hchiorean/modeshape/teams","hooks_url":"https://api.github.com/repos/hchiorean/modeshape/hooks","issue_events_url":"https://api.github.com/repos/hchiorean/modeshape/issues/events{/number}","events_url":"https://api.github.com/repos/hchiorean/modeshape/events","assignees_url":"https://api.github.com/repos/hchiorean/modeshape/assignees{/user}","branches_url":"https://api.github.com/repos/hchiorean/modeshape/branches{/branch}","tags_url":"https://api.github.com/repos/hchiorean/modeshape/tags","blobs_url":"https://api.github.com/repos/hchiorean/modeshape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hchiorean/modeshape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hchiorean/modeshape/git/refs{/sha}","trees_url":"https://api.github.com/repos/hchiorean/modeshape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hchiorean/modeshape/statuses/{sha}","languages_url":"https://api.github.com/repos/hchiorean/modeshape/languages","stargazers_url":"https://api.github.com/repos/hchiorean/modeshape/stargazers","contributors_url":"https://api.github.com/repos/hchiorean/modeshape/contributors","subscribers_url":"https://api.github.com/repos/hchiorean/modeshape/subscribers","subscription_url":"https://api.github.com/repos/hchiorean/modeshape/subscription","commits_url":"https://api.github.com/repos/hchiorean/modeshape/commits{/sha}","git_commits_url":"https://api.github.com/repos/hchiorean/modeshape/git/commits{/sha}","comments_url":"https://api.github.com/repos/hchiorean/modeshape/comments{/number}","issue_comment_url":"https://api.github.com/repos/hchiorean/modeshape/issues/comments{/number}","contents_url":"https://api.github.com/repos/hchiorean/modeshape/contents/{+path}","compare_url":"https://api.github.com/repos/hchiorean/modeshape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hchiorean/modeshape/merges","archive_url":"https://api.github.com/repos/hchiorean/modeshape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hchiorean/modeshape/downloads","issues_url":"https://api.github.com/repos/hchiorean/modeshape/issues{/number}","pulls_url":"https://api.github.com/repos/hchiorean/modeshape/pulls{/number}","milestones_url":"https://api.github.com/repos/hchiorean/modeshape/milestones{/number}","notifications_url":"https://api.github.com/repos/hchiorean/modeshape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hchiorean/modeshape/labels{/name}","releases_url":"https://api.github.com/repos/hchiorean/modeshape/releases{/id}","deployments_url":"https://api.github.com/repos/hchiorean/modeshape/deployments","created_at":"2011-11-01T10:30:42Z","updated_at":"2014-07-24T20:12:19Z","pushed_at":"2016-05-17T13:34:12Z","git_url":"git://github.com/hchiorean/modeshape.git","ssh_url":"git@github.com:hchiorean/modeshape.git","clone_url":"https://github.com/hchiorean/modeshape.git","svn_url":"https://github.com/hchiorean/modeshape","homepage":"http://www.modeshape.org","size":127877,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ModeShape:master","ref":"master","sha":"491f43f31c49c14e7532f629854a1623d35871cd","user":{"login":"ModeShape","id":148023,"avatar_url":"https://avatars.githubusercontent.com/u/148023?v=3","gravatar_id":"","url":"https://api.github.com/users/ModeShape","html_url":"https://github.com/ModeShape","followers_url":"https://api.github.com/users/ModeShape/followers","following_url":"https://api.github.com/users/ModeShape/following{/other_user}","gists_url":"https://api.github.com/users/ModeShape/gists{/gist_id}","starred_url":"https://api.github.com/users/ModeShape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModeShape/subscriptions","organizations_url":"https://api.github.com/users/ModeShape/orgs","repos_url":"https://api.github.com/users/ModeShape/repos","events_url":"https://api.github.com/users/ModeShape/events{/privacy}","received_events_url":"https://api.github.com/users/ModeShape/received_events","type":"Organization","site_admin":false},"repo":{"id":1244027,"name":"modeshape","full_name":"ModeShape/modeshape","owner":{"login":"ModeShape","id":148023,"avatar_url":"https://avatars.githubusercontent.com/u/148023?v=3","gravatar_id":"","url":"https://api.github.com/users/ModeShape","html_url":"https://github.com/ModeShape","followers_url":"https://api.github.com/users/ModeShape/followers","following_url":"https://api.github.com/users/ModeShape/following{/other_user}","gists_url":"https://api.github.com/users/ModeShape/gists{/gist_id}","starred_url":"https://api.github.com/users/ModeShape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModeShape/subscriptions","organizations_url":"https://api.github.com/users/ModeShape/orgs","repos_url":"https://api.github.com/users/ModeShape/repos","events_url":"https://api.github.com/users/ModeShape/events{/privacy}","received_events_url":"https://api.github.com/users/ModeShape/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ModeShape/modeshape","description":"ModeShape is a distributed, hierarchical, transactional, and consistent data store with support for queries, full-text search, events, versioning, references, and flexible and dynamic schemas. It is very fast, highly available, extremely scalable, and it is 100% open source and written in Java. Clients use the JSR-283 standard Java API for content repositories (aka, JCR) or ModeShape's REST API, and can query content through JDBC and SQL.","fork":false,"url":"https://api.github.com/repos/ModeShape/modeshape","forks_url":"https://api.github.com/repos/ModeShape/modeshape/forks","keys_url":"https://api.github.com/repos/ModeShape/modeshape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ModeShape/modeshape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ModeShape/modeshape/teams","hooks_url":"https://api.github.com/repos/ModeShape/modeshape/hooks","issue_events_url":"https://api.github.com/repos/ModeShape/modeshape/issues/events{/number}","events_url":"https://api.github.com/repos/ModeShape/modeshape/events","assignees_url":"https://api.github.com/repos/ModeShape/modeshape/assignees{/user}","branches_url":"https://api.github.com/repos/ModeShape/modeshape/branches{/branch}","tags_url":"https://api.github.com/repos/ModeShape/modeshape/tags","blobs_url":"https://api.github.com/repos/ModeShape/modeshape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ModeShape/modeshape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ModeShape/modeshape/git/refs{/sha}","trees_url":"https://api.github.com/repos/ModeShape/modeshape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ModeShape/modeshape/statuses/{sha}","languages_url":"https://api.github.com/repos/ModeShape/modeshape/languages","stargazers_url":"https://api.github.com/repos/ModeShape/modeshape/stargazers","contributors_url":"https://api.github.com/repos/ModeShape/modeshape/contributors","subscribers_url":"https://api.github.com/repos/ModeShape/modeshape/subscribers","subscription_url":"https://api.github.com/repos/ModeShape/modeshape/subscription","commits_url":"https://api.github.com/repos/ModeShape/modeshape/commits{/sha}","git_commits_url":"https://api.github.com/repos/ModeShape/modeshape/git/commits{/sha}","comments_url":"https://api.github.com/repos/ModeShape/modeshape/comments{/number}","issue_comment_url":"https://api.github.com/repos/ModeShape/modeshape/issues/comments{/number}","contents_url":"https://api.github.com/repos/ModeShape/modeshape/contents/{+path}","compare_url":"https://api.github.com/repos/ModeShape/modeshape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ModeShape/modeshape/merges","archive_url":"https://api.github.com/repos/ModeShape/modeshape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ModeShape/modeshape/downloads","issues_url":"https://api.github.com/repos/ModeShape/modeshape/issues{/number}","pulls_url":"https://api.github.com/repos/ModeShape/modeshape/pulls{/number}","milestones_url":"https://api.github.com/repos/ModeShape/modeshape/milestones{/number}","notifications_url":"https://api.github.com/repos/ModeShape/modeshape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ModeShape/modeshape/labels{/name}","releases_url":"https://api.github.com/repos/ModeShape/modeshape/releases{/id}","deployments_url":"https://api.github.com/repos/ModeShape/modeshape/deployments","created_at":"2011-01-12T02:30:46Z","updated_at":"2016-05-07T06:06:33Z","pushed_at":"2016-05-17T13:48:16Z","git_url":"git://github.com/ModeShape/modeshape.git","ssh_url":"git@github.com:ModeShape/modeshape.git","clone_url":"https://github.com/ModeShape/modeshape.git","svn_url":"https://github.com/ModeShape/modeshape","homepage":"http://www.modeshape.org","size":137117,"stargazers_count":155,"watchers_count":155,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":6,"forks":161,"open_issues":6,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557"},"html":{"href":"https://github.com/ModeShape/modeshape/pull/1557"},"issue":{"href":"https://api.github.com/repos/ModeShape/modeshape/issues/1557"},"comments":{"href":"https://api.github.com/repos/ModeShape/modeshape/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/ModeShape/modeshape/statuses/f60ae6ac6e58edad074543b06db9b7ff7d5db388"}}}}