{"push_id":1395752841,"size":1,"distinct_size":1,"ref":"refs/heads/master-2.2","head":"9e70eadc218194334395a602fba8f8061cee6034","before":"a3bc80a340d24ffcbc879707f087509fb78293ca","commits":[{"sha":"9e70eadc218194334395a602fba8f8061cee6034","author":{"name":"Anthony Coddington","email":"54c6826f0d1364dd06c6198f8d3861f3c4571fc6@endace.com"},"message":"ERF: Fix issues with Host ID mapping\n\npacket-erf: Fix Host ID/Source ID showing for all extension header types.\nOnly show generated Host ID/Source ID when there is a Host ID extension header\nor there was not one on the record.\nAssumes there is only one Source ID if multiple Flow ID extension headers (unlikely)\nand that it matches the one in the Host ID header. This is consistent with other tools.\nDoes support multiple Host ID extension headers though.\n\nFix dag_version tag short name. Was clashing with another tag due to typo.\n\nERF wiretap: Don't conflate Host ID 0 with implicit Host ID.\n\nWhile the implicit Host ID defaults to 0, it is not the same thing as seeing\na packet with Host ID explicitly 0 in the extension header which means\nexplicitly unknown source.\nStore the initial (unknown) implicit Host ID interface mapping in it's own\nspecial mapping table entry rather than 0.\n\nNoticed we can currently get duplicate interfaces in the unusual event of mixed\nimplicit and explicit Host ID packet extension headers for the same ID before\nwe discover that mapping.\nConsistently abandon the implicit version for consistency with the dissector\nlinking behaviour and mark the interface as unmatched in the description. In\n2 pass mode (including normal Wireshark file open) the abandoned interface ends\nup with no packets. In the common cases (all Host ID or no Host ID on packet\nrecords) this duplicate interface will not be created in the first place.\n\nChange-Id: Ic5d0b2ce9aae973f1693a247cf240ef1324ff70a\nPing-Bug: 12303\nReviewed-on: https://code.wireshark.org/review/18704\nReviewed-by: Stephen Donnelly\nPetri-Dish: Anders Broman <a.broman58@gmail.com>\nTested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>\nReviewed-by: Anders Broman <a.broman58@gmail.com>\n(cherry picked from commit 7531318e054153fbd5e33624ef30314acd52b6bc)\nReviewed-on: https://code.wireshark.org/review/18717\nPetri-Dish: Michael Mann <mmann78@netscape.net>\nReviewed-by: Michael Mann <mmann78@netscape.net>","distinct":true,"url":"https://api.github.com/repos/wireshark/wireshark/commits/9e70eadc218194334395a602fba8f8061cee6034"}]}
{"actor":{"display_login":"wireshark-gerrit"}}