{"action":"closed","number":1440,"pull_request":{"url":"https://api.github.com/repos/haraka/Haraka/pulls/1440","id":68963949,"html_url":"https://github.com/haraka/Haraka/pull/1440","diff_url":"https://github.com/haraka/Haraka/pull/1440.diff","patch_url":"https://github.com/haraka/Haraka/pull/1440.patch","issue_url":"https://api.github.com/repos/haraka/Haraka/issues/1440","number":1440,"state":"closed","locked":false,"title":"auth_ldap fixes","user":{"login":"gramakri","id":82041,"avatar_url":"https://avatars.githubusercontent.com/u/82041?v=3","gravatar_id":"","url":"https://api.github.com/users/gramakri","html_url":"https://github.com/gramakri","followers_url":"https://api.github.com/users/gramakri/followers","following_url":"https://api.github.com/users/gramakri/following{/other_user}","gists_url":"https://api.github.com/users/gramakri/gists{/gist_id}","starred_url":"https://api.github.com/users/gramakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramakri/subscriptions","organizations_url":"https://api.github.com/users/gramakri/orgs","repos_url":"https://api.github.com/users/gramakri/repos","events_url":"https://api.github.com/users/gramakri/events{/privacy}","received_events_url":"https://api.github.com/users/gramakri/received_events","type":"User","site_admin":false},"body":"Fixes # .\r\n\r\nChanges proposed in this pull request:\r\n- Advertise AUTH without TLS for private ips in auth_ldap . This is similar to auth_flat.\r\n- Handle LDAP client connection failure. When the LDAP server is down, haraka crashes because of missing error handler.\r\n\r\nChecklist:\r\n- [X ] docs updated\r\n- [X ] tests updated\r\n","created_at":"2016-05-05T04:01:14Z","updated_at":"2016-05-05T20:09:43Z","closed_at":"2016-05-05T20:09:43Z","merged_at":null,"merge_commit_sha":"4d7fc2aa15bc2896c4eead53da541b2097413d6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haraka/Haraka/pulls/1440/commits","review_comments_url":"https://api.github.com/repos/haraka/Haraka/pulls/1440/comments","review_comment_url":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haraka/Haraka/issues/1440/comments","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/470bdf2820528ee4e6cace72c0a95f91b897254f","head":{"label":"cloudron-io:ldap_non_private_ip","ref":"ldap_non_private_ip","sha":"470bdf2820528ee4e6cace72c0a95f91b897254f","user":{"login":"cloudron-io","id":12631021,"avatar_url":"https://avatars.githubusercontent.com/u/12631021?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudron-io","html_url":"https://github.com/cloudron-io","followers_url":"https://api.github.com/users/cloudron-io/followers","following_url":"https://api.github.com/users/cloudron-io/following{/other_user}","gists_url":"https://api.github.com/users/cloudron-io/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudron-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudron-io/subscriptions","organizations_url":"https://api.github.com/users/cloudron-io/orgs","repos_url":"https://api.github.com/users/cloudron-io/repos","events_url":"https://api.github.com/users/cloudron-io/events{/privacy}","received_events_url":"https://api.github.com/users/cloudron-io/received_events","type":"Organization","site_admin":false},"repo":{"id":54936851,"name":"Haraka","full_name":"cloudron-io/Haraka","owner":{"login":"cloudron-io","id":12631021,"avatar_url":"https://avatars.githubusercontent.com/u/12631021?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudron-io","html_url":"https://github.com/cloudron-io","followers_url":"https://api.github.com/users/cloudron-io/followers","following_url":"https://api.github.com/users/cloudron-io/following{/other_user}","gists_url":"https://api.github.com/users/cloudron-io/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudron-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudron-io/subscriptions","organizations_url":"https://api.github.com/users/cloudron-io/orgs","repos_url":"https://api.github.com/users/cloudron-io/repos","events_url":"https://api.github.com/users/cloudron-io/events{/privacy}","received_events_url":"https://api.github.com/users/cloudron-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudron-io/Haraka","description":"An event driven SMTP server","fork":true,"url":"https://api.github.com/repos/cloudron-io/Haraka","forks_url":"https://api.github.com/repos/cloudron-io/Haraka/forks","keys_url":"https://api.github.com/repos/cloudron-io/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudron-io/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudron-io/Haraka/teams","hooks_url":"https://api.github.com/repos/cloudron-io/Haraka/hooks","issue_events_url":"https://api.github.com/repos/cloudron-io/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/cloudron-io/Haraka/events","assignees_url":"https://api.github.com/repos/cloudron-io/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/cloudron-io/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/cloudron-io/Haraka/tags","blobs_url":"https://api.github.com/repos/cloudron-io/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudron-io/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudron-io/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudron-io/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudron-io/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudron-io/Haraka/languages","stargazers_url":"https://api.github.com/repos/cloudron-io/Haraka/stargazers","contributors_url":"https://api.github.com/repos/cloudron-io/Haraka/contributors","subscribers_url":"https://api.github.com/repos/cloudron-io/Haraka/subscribers","subscription_url":"https://api.github.com/repos/cloudron-io/Haraka/subscription","commits_url":"https://api.github.com/repos/cloudron-io/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudron-io/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudron-io/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudron-io/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudron-io/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/cloudron-io/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudron-io/Haraka/merges","archive_url":"https://api.github.com/repos/cloudron-io/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudron-io/Haraka/downloads","issues_url":"https://api.github.com/repos/cloudron-io/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/cloudron-io/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudron-io/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudron-io/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudron-io/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/cloudron-io/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/cloudron-io/Haraka/deployments","created_at":"2016-03-29T01:43:14Z","updated_at":"2016-03-29T01:43:15Z","pushed_at":"2016-05-05T05:56:17Z","git_url":"git://github.com/cloudron-io/Haraka.git","ssh_url":"git@github.com:cloudron-io/Haraka.git","clone_url":"https://github.com/cloudron-io/Haraka.git","svn_url":"https://github.com/cloudron-io/Haraka","homepage":"http://haraka.github.io/","size":4735,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haraka:master","ref":"master","sha":"e3cb0c2015597a7a9111a00b34314a6d266703a1","user":{"login":"haraka","id":1111229,"avatar_url":"https://avatars.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"repo":{"id":1464380,"name":"Haraka","full_name":"haraka/Haraka","owner":{"login":"haraka","id":1111229,"avatar_url":"https://avatars.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haraka/Haraka","description":"An event driven SMTP server","fork":false,"url":"https://api.github.com/repos/haraka/Haraka","forks_url":"https://api.github.com/repos/haraka/Haraka/forks","keys_url":"https://api.github.com/repos/haraka/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haraka/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haraka/Haraka/teams","hooks_url":"https://api.github.com/repos/haraka/Haraka/hooks","issue_events_url":"https://api.github.com/repos/haraka/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/haraka/Haraka/events","assignees_url":"https://api.github.com/repos/haraka/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/haraka/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/haraka/Haraka/tags","blobs_url":"https://api.github.com/repos/haraka/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haraka/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haraka/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/haraka/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/haraka/Haraka/languages","stargazers_url":"https://api.github.com/repos/haraka/Haraka/stargazers","contributors_url":"https://api.github.com/repos/haraka/Haraka/contributors","subscribers_url":"https://api.github.com/repos/haraka/Haraka/subscribers","subscription_url":"https://api.github.com/repos/haraka/Haraka/subscription","commits_url":"https://api.github.com/repos/haraka/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/haraka/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/haraka/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/haraka/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/haraka/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/haraka/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haraka/Haraka/merges","archive_url":"https://api.github.com/repos/haraka/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haraka/Haraka/downloads","issues_url":"https://api.github.com/repos/haraka/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/haraka/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/haraka/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/haraka/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haraka/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/haraka/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/haraka/Haraka/deployments","created_at":"2011-03-10T17:00:20Z","updated_at":"2016-05-05T16:15:52Z","pushed_at":"2016-05-05T04:05:05Z","git_url":"git://github.com/haraka/Haraka.git","ssh_url":"git@github.com:haraka/Haraka.git","clone_url":"https://github.com/haraka/Haraka.git","svn_url":"https://github.com/haraka/Haraka","homepage":"http://haraka.github.io/","size":7572,"stargazers_count":2123,"watchers_count":2123,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":35,"forks":285,"open_issues":35,"watchers":2123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1440"},"html":{"href":"https://github.com/haraka/Haraka/pull/1440"},"issue":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1440"},"comments":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1440/comments"},"review_comments":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1440/comments"},"review_comment":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1440/commits"},"statuses":{"href":"https://api.github.com/repos/haraka/Haraka/statuses/470bdf2820528ee4e6cace72c0a95f91b897254f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":13,"deletions":2,"changed_files":2}}