{"action":"created","issue":{"url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/145","repository_url":"https://api.github.com/repos/code-corps/stripity-stripe","labels_url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/145/comments","events_url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/145/events","html_url":"https://github.com/code-corps/stripity-stripe/issues/145","id":191914102,"number":145,"title":"[v2] why Token.create_on_connect_account/0 ?","user":{"login":"tlvenn","id":3340262,"avatar_url":"https://avatars.githubusercontent.com/u/3340262?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvenn","html_url":"https://github.com/tlvenn","followers_url":"https://api.github.com/users/tlvenn/followers","following_url":"https://api.github.com/users/tlvenn/following{/other_user}","gists_url":"https://api.github.com/users/tlvenn/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvenn/subscriptions","organizations_url":"https://api.github.com/users/tlvenn/orgs","repos_url":"https://api.github.com/users/tlvenn/repos","events_url":"https://api.github.com/users/tlvenn/events{/privacy}","received_events_url":"https://api.github.com/users/tlvenn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/code-corps/stripity-stripe/milestones/2","html_url":"https://github.com/code-corps/stripity-stripe/milestones/2.0.0-beta.1","labels_url":"https://api.github.com/repos/code-corps/stripity-stripe/milestones/2/labels","id":2131406,"number":2,"title":"2.0.0-beta.1","description":"Road to a beta version that covers all the surface area of `1.4.0` but with our new approaches.","creator":{"login":"JoshSmith","id":321667,"avatar_url":"https://avatars.githubusercontent.com/u/321667?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshSmith","html_url":"https://github.com/JoshSmith","followers_url":"https://api.github.com/users/JoshSmith/followers","following_url":"https://api.github.com/users/JoshSmith/following{/other_user}","gists_url":"https://api.github.com/users/JoshSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshSmith/subscriptions","organizations_url":"https://api.github.com/users/JoshSmith/orgs","repos_url":"https://api.github.com/users/JoshSmith/repos","events_url":"https://api.github.com/users/JoshSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JoshSmith/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":4,"state":"open","created_at":"2016-11-13T01:25:59Z","updated_at":"2016-11-28T03:56:34Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-11-28T03:50:26Z","updated_at":"2016-11-28T05:36:47Z","closed_at":null,"body":"I don't really understand why there is a `create_on_connect_account` and not a `create` function for  Tokens.\r\n\r\nThere are many reasons why you would want to create a token out of a customer for a given stripe account. That given stripe account could be a connected account but for example, a platform account could also store all customers across all managed accounts as a way to share credit card info across the platform. In that situation, when the platform need to charge a given customer of behalf of a managed account, it will need to first create a token for this customer passing its own account and then use that token to create a charge.\r\n\r\nThis is an actually documented use case\r\n> https://stripe.com/docs/connect/shared-customers\r\n\r\nThis generally also open the question on what should be the philosophy for the lib to map onto the Stripe API. I believe we should first make sure we map on their endpoints, so for example, we should have a general `Token.create` function and then if needed, build on top of it to provide convenience and other things to the end user.\r\n\r\n@JoshSmith @DavidAntaramian What do you think ?"},"comment":{"url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/comments/263187254","html_url":"https://github.com/code-corps/stripity-stripe/issues/145#issuecomment-263187254","issue_url":"https://api.github.com/repos/code-corps/stripity-stripe/issues/145","id":263187254,"user":{"login":"tlvenn","id":3340262,"avatar_url":"https://avatars.githubusercontent.com/u/3340262?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvenn","html_url":"https://github.com/tlvenn","followers_url":"https://api.github.com/users/tlvenn/followers","following_url":"https://api.github.com/users/tlvenn/following{/other_user}","gists_url":"https://api.github.com/users/tlvenn/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvenn/subscriptions","organizations_url":"https://api.github.com/users/tlvenn/orgs","repos_url":"https://api.github.com/users/tlvenn/repos","events_url":"https://api.github.com/users/tlvenn/events{/privacy}","received_events_url":"https://api.github.com/users/tlvenn/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T05:36:47Z","updated_at":"2016-11-28T05:36:47Z","body":"Did we settle on an approach to actually test the lib and the stripe endpoint ?"}}
{"actor":{"display_login":"tlvenn"}}