{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4156","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4156/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4156/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4156/events","html_url":"https://github.com/cockroachdb/cockroach/pull/4156","id":131497575,"number":4156,"title":"Add EventLog, log Create Table events","user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-04T22:50:58Z","updated_at":"2016-02-06T18:28:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4156","html_url":"https://github.com/cockroachdb/cockroach/pull/4156","diff_url":"https://github.com/cockroachdb/cockroach/pull/4156.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4156.patch"},"body":"This commit adds the EventLog table, an additional log structured table which\r\nwill capture various events on the cluster. This is separate from the previously\r\ncreated RangeLog table due to concerns about the volume and value of\r\nrange-related events.\r\n\r\nThe first event being logged to this table is \"Create Table\" - an event is\r\nlogged every time a table is successfully created on the server.\r\n\r\nThere is already an active TODO on the existing RangeLog code in the `storage`\r\npackage to move that code into the sql package; it should be appropriate for all\r\nplanned log messages to be recorded using code in the sql package.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4156)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/180830204","html_url":"https://github.com/cockroachdb/cockroach/pull/4156#issuecomment-180830204","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4156","id":180830204,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T18:28:18Z","updated_at":"2016-02-06T18:28:18Z","body":"LGTM\n\n---\n\nReview status: all files reviewed at latest revision, 12 unresolved discussions.\n\n---\n\n*[sql/event_log.go, line 43 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4156#-K9j8XEraFlubx8rMcWx:-K9rmwOtddlJ6LseHrh2:-509190921) ([raw file](https://github.com/cockroachdb/cockroach/blob/1c72c11e83edd5acb5a1b523896dd0eff0b484f6/sql/event_log.go#L43)):*\nI agree with `targetID` but if you don't make that change, `s/effecting/affecting/`\n\nShould there also be a `targetType` field to aid in interpreting the ID field? \n\n---\n\n*[sql/event_log.go, line 46 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4156#-K9ro7ubukGrAtrzUpbf:-K9ro7ubukGrAtrzUpbg:-704686521) ([raw file](https://github.com/cockroachdb/cockroach/blob/1c72c11e83edd5acb5a1b523896dd0eff0b484f6/sql/event_log.go#L46)):*\nUnless there is a specific reason that the ID needs to be an integer, we should use `experimental_unique_bytes` instead of `experimental_unique_int`. The latter fails when there are too many nodes in the system. \n\n---\n\n*[storage/log.go, line 63 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4156#-K9j9l3A4zvhIyFqCI23:-K9rpYPOFif7FK6qIvN1:657254058) ([raw file](https://github.com/cockroachdb/cockroach/blob/a9e8dfba131cf2b5ab481da6b235ab03a5794f9b/storage/log.go#L63)):*\n+1 on indexing `rangeID` (in a separate change)\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/4156#-:-K9rpqeUiCJbV2z0shDd:676834233)*\n<!-- Sent from Reviewable.io -->\n"}}