{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/desisim/issues/114","repository_url":"https://api.github.com/repos/desihub/desisim","labels_url":"https://api.github.com/repos/desihub/desisim/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/desihub/desisim/issues/114/comments","events_url":"https://api.github.com/repos/desihub/desisim/issues/114/events","html_url":"https://github.com/desihub/desisim/pull/114","id":152564373,"number":114,"title":"clean up of quickbrick to support bright-time survey","user":{"login":"moustakas","id":1431820,"avatar_url":"https://avatars.githubusercontent.com/u/1431820?v=3","gravatar_id":"","url":"https://api.github.com/users/moustakas","html_url":"https://github.com/moustakas","followers_url":"https://api.github.com/users/moustakas/followers","following_url":"https://api.github.com/users/moustakas/following{/other_user}","gists_url":"https://api.github.com/users/moustakas/gists{/gist_id}","starred_url":"https://api.github.com/users/moustakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moustakas/subscriptions","organizations_url":"https://api.github.com/users/moustakas/orgs","repos_url":"https://api.github.com/users/moustakas/repos","events_url":"https://api.github.com/users/moustakas/events{/privacy}","received_events_url":"https://api.github.com/users/moustakas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/desihub/desisim/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"moustakas","id":1431820,"avatar_url":"https://avatars.githubusercontent.com/u/1431820?v=3","gravatar_id":"","url":"https://api.github.com/users/moustakas","html_url":"https://github.com/moustakas","followers_url":"https://api.github.com/users/moustakas/followers","following_url":"https://api.github.com/users/moustakas/following{/other_user}","gists_url":"https://api.github.com/users/moustakas/gists{/gist_id}","starred_url":"https://api.github.com/users/moustakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moustakas/subscriptions","organizations_url":"https://api.github.com/users/moustakas/orgs","repos_url":"https://api.github.com/users/moustakas/repos","events_url":"https://api.github.com/users/moustakas/events{/privacy}","received_events_url":"https://api.github.com/users/moustakas/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/desihub/desisim/milestones/3","html_url":"https://github.com/desihub/desisim/milestones/Bright%20time%20sims","labels_url":"https://api.github.com/repos/desihub/desisim/milestones/3/labels","id":1552324,"number":3,"title":"Bright time sims","description":"Milestone for organizing issues related to performing bright time sims within the DESI pipeline ecosystem.  Finishing these tickets addresses WBS 1.8.6.1 activity 1861_120 \"Create simulations with bright time and bad conditions, appropriate dynamic range of targets and sky exposure time\", which is overdue.  The output is a set of bright time spectra and pixel-level sims of those spectra that can be used as canonical test inputs for pipeline development.","creator":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2016-01-29T23:48:39Z","updated_at":"2016-05-02T14:26:16Z","due_on":"2016-02-26T08:00:00Z","closed_at":null},"comments":3,"created_at":"2016-05-02T14:26:16Z","updated_at":"2016-05-05T14:12:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/desihub/desisim/pulls/114","html_url":"https://github.com/desihub/desisim/pull/114","diff_url":"https://github.com/desihub/desisim/pull/114.diff","patch_url":"https://github.com/desihub/desisim/pull/114.patch"},"body":"I'm opening this PR now so I can get  can get eyes on the code sooner rather than later. Algorithmically I haven't changed anything significant in ```quickbrick```, but I have done a thorough \"cleaning\" of the code (PEP8 style mostly throughout, streamlining of variables and repeat code, some error handling, refactoring into parse() and main() functions, additional optional inputs such as the lunar phase parameters, etc.).  The biggest change is that ```quickbrick``` can now be used to simulate bright-time objects via the BGS, MWS, or BRIGHT_MIX objtype optional input.\r\n\r\nThis PR should close the bug identified in #101 and should move us significantly closer toward generating the bright-time simulations we need (#72).  \r\n\r\nSome outstanding issues I would still like to fix/add:\r\n* Figure out the verbose logging (help on this would be great -- log.info prints output even when the debugging level isn't set to INFO)\r\n* Add additional error checking\r\n* Optionally output spectra with supernova spectra superposed (see #100)\r\n"},"comment":{"url":"https://api.github.com/repos/desihub/desisim/issues/comments/217165063","html_url":"https://github.com/desihub/desisim/pull/114#issuecomment-217165063","issue_url":"https://api.github.com/repos/desihub/desisim/issues/114","id":217165063,"user":{"login":"moustakas","id":1431820,"avatar_url":"https://avatars.githubusercontent.com/u/1431820?v=3","gravatar_id":"","url":"https://api.github.com/users/moustakas","html_url":"https://github.com/moustakas","followers_url":"https://api.github.com/users/moustakas/followers","following_url":"https://api.github.com/users/moustakas/following{/other_user}","gists_url":"https://api.github.com/users/moustakas/gists{/gist_id}","starred_url":"https://api.github.com/users/moustakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moustakas/subscriptions","organizations_url":"https://api.github.com/users/moustakas/orgs","repos_url":"https://api.github.com/users/moustakas/repos","events_url":"https://api.github.com/users/moustakas/events{/privacy}","received_events_url":"https://api.github.com/users/moustakas/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T14:12:32Z","updated_at":"2016-05-05T14:12:32Z","body":"I see that my previous comment was discussed in #96.  I'll work on resolving this issue as part of this PR."}}