{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/66483981","id":66483981,"diff_hunk":"@@ -14175,6 +14215,85 @@ namespace ts {\n             }\r\n         }\r\n \r\n+        function checkSourceFileADefinitionFile(node: Node): boolean {\r\n+            return getSourceFileOfNode(node).fileName.indexOf(\".d.ts\") > 0;\r","path":"src/compiler/checker.ts","position":null,"original_position":117,"commit_id":"dfc920b9a9ccdf9bfac3638a987e10b9e3a818b1","original_commit_id":"2b7f3a704f0abb0d3d1b08abb3a724db36a1789f","user":{"login":"sarangan12","id":602456,"avatar_url":"https://avatars.githubusercontent.com/u/602456?v=3","gravatar_id":"","url":"https://api.github.com/users/sarangan12","html_url":"https://github.com/sarangan12","followers_url":"https://api.github.com/users/sarangan12/followers","following_url":"https://api.github.com/users/sarangan12/following{/other_user}","gists_url":"https://api.github.com/users/sarangan12/gists{/gist_id}","starred_url":"https://api.github.com/users/sarangan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarangan12/subscriptions","organizations_url":"https://api.github.com/users/sarangan12/orgs","repos_url":"https://api.github.com/users/sarangan12/repos","events_url":"https://api.github.com/users/sarangan12/events{/privacy}","received_events_url":"https://api.github.com/users/sarangan12/received_events","type":"User","site_admin":false},"body":"Changed the logic","created_at":"2016-06-09T17:24:40Z","updated_at":"2016-06-09T17:24:40Z","html_url":"https://github.com/Microsoft/TypeScript/pull/8790#discussion_r66483981","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/66483981"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/8790#discussion_r66483981"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790","id":71282902,"html_url":"https://github.com/Microsoft/TypeScript/pull/8790","diff_url":"https://github.com/Microsoft/TypeScript/pull/8790.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/8790.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/8790","number":8790,"state":"open","locked":false,"title":"Code changes to update references of the Identifiers","user":{"login":"sarangan12","id":602456,"avatar_url":"https://avatars.githubusercontent.com/u/602456?v=3","gravatar_id":"","url":"https://api.github.com/users/sarangan12","html_url":"https://github.com/sarangan12","followers_url":"https://api.github.com/users/sarangan12/followers","following_url":"https://api.github.com/users/sarangan12/following{/other_user}","gists_url":"https://api.github.com/users/sarangan12/gists{/gist_id}","starred_url":"https://api.github.com/users/sarangan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarangan12/subscriptions","organizations_url":"https://api.github.com/users/sarangan12/orgs","repos_url":"https://api.github.com/users/sarangan12/repos","events_url":"https://api.github.com/users/sarangan12/events{/privacy}","received_events_url":"https://api.github.com/users/sarangan12/received_events","type":"User","site_admin":false},"body":"@paulvanbrenk @mhegazy Could you please review these code changes? I will update the PR with tests soon. \r\n\r\n<!--\r\nThank you for submitting a pull request!\r\n\r\nHere's a checklist you might find useful.\r\n[ ] There is an associated issue that is labelled\r\n  'Bug' or 'Accepting PRs' or is in the Community milestone\r\n[ ] Code is up-to-date with the `master` branch\r\n[ ] You've successfully run `jake runtests` locally\r\n[ ] You've signed the CLA\r\n[ ] There are new or updated unit tests validating the change\r\n\r\nRefer to CONTRIBUTING.MD for more details.\r\n  https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nFixes #\r\n\r\n","created_at":"2016-05-24T19:59:38Z","updated_at":"2016-06-09T17:24:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cb0bcadf95557cfe4f871519008f431c6f9a500","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/8790/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/dfc920b9a9ccdf9bfac3638a987e10b9e3a818b1","head":{"label":"sarangan12:UpdateReferences","ref":"UpdateReferences","sha":"dfc920b9a9ccdf9bfac3638a987e10b9e3a818b1","user":{"login":"sarangan12","id":602456,"avatar_url":"https://avatars.githubusercontent.com/u/602456?v=3","gravatar_id":"","url":"https://api.github.com/users/sarangan12","html_url":"https://github.com/sarangan12","followers_url":"https://api.github.com/users/sarangan12/followers","following_url":"https://api.github.com/users/sarangan12/following{/other_user}","gists_url":"https://api.github.com/users/sarangan12/gists{/gist_id}","starred_url":"https://api.github.com/users/sarangan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarangan12/subscriptions","organizations_url":"https://api.github.com/users/sarangan12/orgs","repos_url":"https://api.github.com/users/sarangan12/repos","events_url":"https://api.github.com/users/sarangan12/events{/privacy}","received_events_url":"https://api.github.com/users/sarangan12/received_events","type":"User","site_admin":false},"repo":{"id":59599703,"name":"TypeScript","full_name":"sarangan12/TypeScript","owner":{"login":"sarangan12","id":602456,"avatar_url":"https://avatars.githubusercontent.com/u/602456?v=3","gravatar_id":"","url":"https://api.github.com/users/sarangan12","html_url":"https://github.com/sarangan12","followers_url":"https://api.github.com/users/sarangan12/followers","following_url":"https://api.github.com/users/sarangan12/following{/other_user}","gists_url":"https://api.github.com/users/sarangan12/gists{/gist_id}","starred_url":"https://api.github.com/users/sarangan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarangan12/subscriptions","organizations_url":"https://api.github.com/users/sarangan12/orgs","repos_url":"https://api.github.com/users/sarangan12/repos","events_url":"https://api.github.com/users/sarangan12/events{/privacy}","received_events_url":"https://api.github.com/users/sarangan12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarangan12/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/sarangan12/TypeScript","forks_url":"https://api.github.com/repos/sarangan12/TypeScript/forks","keys_url":"https://api.github.com/repos/sarangan12/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarangan12/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarangan12/TypeScript/teams","hooks_url":"https://api.github.com/repos/sarangan12/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/sarangan12/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/sarangan12/TypeScript/events","assignees_url":"https://api.github.com/repos/sarangan12/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/sarangan12/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/sarangan12/TypeScript/tags","blobs_url":"https://api.github.com/repos/sarangan12/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarangan12/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarangan12/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarangan12/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarangan12/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/sarangan12/TypeScript/languages","stargazers_url":"https://api.github.com/repos/sarangan12/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/sarangan12/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/sarangan12/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/sarangan12/TypeScript/subscription","commits_url":"https://api.github.com/repos/sarangan12/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarangan12/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarangan12/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarangan12/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarangan12/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/sarangan12/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarangan12/TypeScript/merges","archive_url":"https://api.github.com/repos/sarangan12/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarangan12/TypeScript/downloads","issues_url":"https://api.github.com/repos/sarangan12/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/sarangan12/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/sarangan12/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/sarangan12/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarangan12/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/sarangan12/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/sarangan12/TypeScript/deployments","created_at":"2016-05-24T18:49:17Z","updated_at":"2016-05-24T18:49:56Z","pushed_at":"2016-06-09T17:24:11Z","git_url":"git://github.com/sarangan12/TypeScript.git","ssh_url":"git@github.com:sarangan12/TypeScript.git","clone_url":"https://github.com/sarangan12/TypeScript.git","svn_url":"https://github.com/sarangan12/TypeScript","homepage":"http://www.typescriptlang.org","size":258124,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"13ddc34607a10e43d611566888885601ac359f3a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2016-06-09T16:39:15Z","pushed_at":"2016-06-09T17:24:12Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":512509,"stargazers_count":12148,"watchers_count":12148,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1590,"mirror_url":null,"open_issues_count":945,"forks":1590,"open_issues":945,"watchers":12148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/8790"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/8790"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/8790/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/8790/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/dfc920b9a9ccdf9bfac3638a987e10b9e3a818b1"}}}}
{"actor":{"display_login":"sarangan12"}}