{"action":"created","comment":{"url":"https://api.github.com/repos/libmoon/libmoon/pulls/comments/83921859","pull_request_review_id":4733255,"id":83921859,"diff_hunk":"@@ -470,11 +489,192 @@ function tcpHeader:getUrgentPointerString()\n \treturn self:getUrgentPointer()\n end\n \n--- TODO how do we want to handle options (problem is tcp header variable length array of uint8[] followed by payload variable length array (uint8[]))\n---[[function tcpHeader:setOptions(int)\n-\tint = int or\n-\tself. = int\n-end--]]\n+\n+------------------------------------------------------------------------------------\n+---- TCP options\n+------------------------------------------------------------------------------------\n+\n+do \n+\tfunction createOptionsDict()\n+\t\tmod.option = {\n+\t\t\terr = -1,\n+\t\t\teol = 0,\n+\t\t\tnop = 1,\n+\t\t\tmss = 2,\n+\t\t\tws = 3,\n+\t\t\tts = 8,\n+\t\t}\n+\t\tfor k, v in pairs(mod.option) do\n+\t\t\tmod.option[v] = k\n+\t\tend\n+\tend\n+\tcreateOptionsDict()","path":"lua/proto/tcp.lua","position":null,"original_position":87,"commit_id":"2775ce6731e4782e2327b5c54fda83d94568eb86","original_commit_id":"7d65f67e414411442449eb84d56f28264ec84dfc","user":{"login":"scholzd","id":9135040,"avatar_url":"https://avatars.githubusercontent.com/u/9135040?v=3","gravatar_id":"","url":"https://api.github.com/users/scholzd","html_url":"https://github.com/scholzd","followers_url":"https://api.github.com/users/scholzd/followers","following_url":"https://api.github.com/users/scholzd/following{/other_user}","gists_url":"https://api.github.com/users/scholzd/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzd/subscriptions","organizations_url":"https://api.github.com/users/scholzd/orgs","repos_url":"https://api.github.com/users/scholzd/repos","events_url":"https://api.github.com/users/scholzd/events{/privacy}","received_events_url":"https://api.github.com/users/scholzd/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-10-18T18:36:43Z","updated_at":"2016-10-18T18:36:43Z","html_url":"https://github.com/libmoon/libmoon/pull/16#discussion_r83921859","pull_request_url":"https://api.github.com/repos/libmoon/libmoon/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/comments/83921859"},"html":{"href":"https://github.com/libmoon/libmoon/pull/16#discussion_r83921859"},"pull_request":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/libmoon/libmoon/pulls/16","id":89834397,"html_url":"https://github.com/libmoon/libmoon/pull/16","diff_url":"https://github.com/libmoon/libmoon/pull/16.diff","patch_url":"https://github.com/libmoon/libmoon/pull/16.patch","issue_url":"https://api.github.com/repos/libmoon/libmoon/issues/16","number":16,"state":"open","locked":false,"title":"Protocol stack rework","user":{"login":"scholzd","id":9135040,"avatar_url":"https://avatars.githubusercontent.com/u/9135040?v=3","gravatar_id":"","url":"https://api.github.com/users/scholzd","html_url":"https://github.com/scholzd","followers_url":"https://api.github.com/users/scholzd/followers","following_url":"https://api.github.com/users/scholzd/following{/other_user}","gists_url":"https://api.github.com/users/scholzd/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzd/subscriptions","organizations_url":"https://api.github.com/users/scholzd/orgs","repos_url":"https://api.github.com/users/scholzd/repos","events_url":"https://api.github.com/users/scholzd/events{/privacy}","received_events_url":"https://api.github.com/users/scholzd/received_events","type":"User","site_admin":false},"body":"Major rework to support variable sized headers (eg for IP/TCP options)\r\n- removed header.lua, done per protocol now\r\n- header template with default functions\r\n- tcp options utility\r\n- ethernet vlan support\r\n- some bug fixes\r\n\r\nAs example, the stack is now able to correctly decode a eth (802.1q) - ip6 - udp - vxlan - eth - ip4 (with options) - udp - sflow buffer.\r\n\r\nProbably breaks a lot of implementations in other forks.","created_at":"2016-10-18T15:03:20Z","updated_at":"2016-10-18T18:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb24c5d02b749d3752cd9fceac0f9e80be0fade4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libmoon/libmoon/pulls/16/commits","review_comments_url":"https://api.github.com/repos/libmoon/libmoon/pulls/16/comments","review_comment_url":"https://api.github.com/repos/libmoon/libmoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libmoon/libmoon/issues/16/comments","statuses_url":"https://api.github.com/repos/libmoon/libmoon/statuses/2775ce6731e4782e2327b5c54fda83d94568eb86","head":{"label":"scholzd:tcp_options_better","ref":"tcp_options_better","sha":"2775ce6731e4782e2327b5c54fda83d94568eb86","user":{"login":"scholzd","id":9135040,"avatar_url":"https://avatars.githubusercontent.com/u/9135040?v=3","gravatar_id":"","url":"https://api.github.com/users/scholzd","html_url":"https://github.com/scholzd","followers_url":"https://api.github.com/users/scholzd/followers","following_url":"https://api.github.com/users/scholzd/following{/other_user}","gists_url":"https://api.github.com/users/scholzd/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzd/subscriptions","organizations_url":"https://api.github.com/users/scholzd/orgs","repos_url":"https://api.github.com/users/scholzd/repos","events_url":"https://api.github.com/users/scholzd/events{/privacy}","received_events_url":"https://api.github.com/users/scholzd/received_events","type":"User","site_admin":false},"repo":{"id":67648983,"name":"libmoon","full_name":"scholzd/libmoon","owner":{"login":"scholzd","id":9135040,"avatar_url":"https://avatars.githubusercontent.com/u/9135040?v=3","gravatar_id":"","url":"https://api.github.com/users/scholzd","html_url":"https://github.com/scholzd","followers_url":"https://api.github.com/users/scholzd/followers","following_url":"https://api.github.com/users/scholzd/following{/other_user}","gists_url":"https://api.github.com/users/scholzd/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzd/subscriptions","organizations_url":"https://api.github.com/users/scholzd/orgs","repos_url":"https://api.github.com/users/scholzd/repos","events_url":"https://api.github.com/users/scholzd/events{/privacy}","received_events_url":"https://api.github.com/users/scholzd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scholzd/libmoon","description":"Phobos is a fast and flexible packet processing framework built on DPDK and LuaJIT. Its main goal is to simplify the initial creation of DPDK applications while maintaining DPDK's high performance.","fork":true,"url":"https://api.github.com/repos/scholzd/libmoon","forks_url":"https://api.github.com/repos/scholzd/libmoon/forks","keys_url":"https://api.github.com/repos/scholzd/libmoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scholzd/libmoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scholzd/libmoon/teams","hooks_url":"https://api.github.com/repos/scholzd/libmoon/hooks","issue_events_url":"https://api.github.com/repos/scholzd/libmoon/issues/events{/number}","events_url":"https://api.github.com/repos/scholzd/libmoon/events","assignees_url":"https://api.github.com/repos/scholzd/libmoon/assignees{/user}","branches_url":"https://api.github.com/repos/scholzd/libmoon/branches{/branch}","tags_url":"https://api.github.com/repos/scholzd/libmoon/tags","blobs_url":"https://api.github.com/repos/scholzd/libmoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scholzd/libmoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scholzd/libmoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/scholzd/libmoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scholzd/libmoon/statuses/{sha}","languages_url":"https://api.github.com/repos/scholzd/libmoon/languages","stargazers_url":"https://api.github.com/repos/scholzd/libmoon/stargazers","contributors_url":"https://api.github.com/repos/scholzd/libmoon/contributors","subscribers_url":"https://api.github.com/repos/scholzd/libmoon/subscribers","subscription_url":"https://api.github.com/repos/scholzd/libmoon/subscription","commits_url":"https://api.github.com/repos/scholzd/libmoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/scholzd/libmoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/scholzd/libmoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/scholzd/libmoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/scholzd/libmoon/contents/{+path}","compare_url":"https://api.github.com/repos/scholzd/libmoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scholzd/libmoon/merges","archive_url":"https://api.github.com/repos/scholzd/libmoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scholzd/libmoon/downloads","issues_url":"https://api.github.com/repos/scholzd/libmoon/issues{/number}","pulls_url":"https://api.github.com/repos/scholzd/libmoon/pulls{/number}","milestones_url":"https://api.github.com/repos/scholzd/libmoon/milestones{/number}","notifications_url":"https://api.github.com/repos/scholzd/libmoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scholzd/libmoon/labels{/name}","releases_url":"https://api.github.com/repos/scholzd/libmoon/releases{/id}","deployments_url":"https://api.github.com/repos/scholzd/libmoon/deployments","created_at":"2016-09-07T22:43:41Z","updated_at":"2016-10-14T16:32:30Z","pushed_at":"2016-10-18T18:36:12Z","git_url":"git://github.com/scholzd/libmoon.git","ssh_url":"git@github.com:scholzd/libmoon.git","clone_url":"https://github.com/scholzd/libmoon.git","svn_url":"https://github.com/scholzd/libmoon","homepage":"","size":443,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libmoon:master","ref":"master","sha":"07c1b142df28a5ba12934296e56166062e0ed94c","user":{"login":"libmoon","id":22795029,"avatar_url":"https://avatars.githubusercontent.com/u/22795029?v=3","gravatar_id":"","url":"https://api.github.com/users/libmoon","html_url":"https://github.com/libmoon","followers_url":"https://api.github.com/users/libmoon/followers","following_url":"https://api.github.com/users/libmoon/following{/other_user}","gists_url":"https://api.github.com/users/libmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/libmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libmoon/subscriptions","organizations_url":"https://api.github.com/users/libmoon/orgs","repos_url":"https://api.github.com/users/libmoon/repos","events_url":"https://api.github.com/users/libmoon/events{/privacy}","received_events_url":"https://api.github.com/users/libmoon/received_events","type":"Organization","site_admin":false},"repo":{"id":65089320,"name":"libmoon","full_name":"libmoon/libmoon","owner":{"login":"libmoon","id":22795029,"avatar_url":"https://avatars.githubusercontent.com/u/22795029?v=3","gravatar_id":"","url":"https://api.github.com/users/libmoon","html_url":"https://github.com/libmoon","followers_url":"https://api.github.com/users/libmoon/followers","following_url":"https://api.github.com/users/libmoon/following{/other_user}","gists_url":"https://api.github.com/users/libmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/libmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libmoon/subscriptions","organizations_url":"https://api.github.com/users/libmoon/orgs","repos_url":"https://api.github.com/users/libmoon/repos","events_url":"https://api.github.com/users/libmoon/events{/privacy}","received_events_url":"https://api.github.com/users/libmoon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libmoon/libmoon","description":"libmoon is a library for fast and flexible packet processing with DPDK and LuaJIT.","fork":false,"url":"https://api.github.com/repos/libmoon/libmoon","forks_url":"https://api.github.com/repos/libmoon/libmoon/forks","keys_url":"https://api.github.com/repos/libmoon/libmoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libmoon/libmoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libmoon/libmoon/teams","hooks_url":"https://api.github.com/repos/libmoon/libmoon/hooks","issue_events_url":"https://api.github.com/repos/libmoon/libmoon/issues/events{/number}","events_url":"https://api.github.com/repos/libmoon/libmoon/events","assignees_url":"https://api.github.com/repos/libmoon/libmoon/assignees{/user}","branches_url":"https://api.github.com/repos/libmoon/libmoon/branches{/branch}","tags_url":"https://api.github.com/repos/libmoon/libmoon/tags","blobs_url":"https://api.github.com/repos/libmoon/libmoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libmoon/libmoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libmoon/libmoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/libmoon/libmoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libmoon/libmoon/statuses/{sha}","languages_url":"https://api.github.com/repos/libmoon/libmoon/languages","stargazers_url":"https://api.github.com/repos/libmoon/libmoon/stargazers","contributors_url":"https://api.github.com/repos/libmoon/libmoon/contributors","subscribers_url":"https://api.github.com/repos/libmoon/libmoon/subscribers","subscription_url":"https://api.github.com/repos/libmoon/libmoon/subscription","commits_url":"https://api.github.com/repos/libmoon/libmoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/libmoon/libmoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/libmoon/libmoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/libmoon/libmoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/libmoon/libmoon/contents/{+path}","compare_url":"https://api.github.com/repos/libmoon/libmoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libmoon/libmoon/merges","archive_url":"https://api.github.com/repos/libmoon/libmoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libmoon/libmoon/downloads","issues_url":"https://api.github.com/repos/libmoon/libmoon/issues{/number}","pulls_url":"https://api.github.com/repos/libmoon/libmoon/pulls{/number}","milestones_url":"https://api.github.com/repos/libmoon/libmoon/milestones{/number}","notifications_url":"https://api.github.com/repos/libmoon/libmoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libmoon/libmoon/labels{/name}","releases_url":"https://api.github.com/repos/libmoon/libmoon/releases{/id}","deployments_url":"https://api.github.com/repos/libmoon/libmoon/deployments","created_at":"2016-08-06T15:37:14Z","updated_at":"2016-10-17T14:13:56Z","pushed_at":"2016-10-18T18:36:13Z","git_url":"git://github.com/libmoon/libmoon.git","ssh_url":"git@github.com:libmoon/libmoon.git","clone_url":"https://github.com/libmoon/libmoon.git","svn_url":"https://github.com/libmoon/libmoon","homepage":"","size":470,"stargazers_count":15,"watchers_count":15,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/16"},"html":{"href":"https://github.com/libmoon/libmoon/pull/16"},"issue":{"href":"https://api.github.com/repos/libmoon/libmoon/issues/16"},"comments":{"href":"https://api.github.com/repos/libmoon/libmoon/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libmoon/libmoon/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/libmoon/libmoon/statuses/2775ce6731e4782e2327b5c54fda83d94568eb86"}}}}
{"actor":{"display_login":"scholzd"}}