{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/91362046","pull_request_review_id":11871299,"id":91362046,"diff_hunk":"@@ -40,15 +37,29 @@ export class IframeMessagingClient {\n   }\n \n   /**\n+   * Make an event listening request to the host window.\n+   *\n+   * @param {string} requestType The type of the request message.\n+   * @param {string} responseType The type of the response message.\n+   * @param {function(object)} callback The callback function to call\n+   *   when a message with type responseType is received.\n+   */\n+  makeRequest(requestType, responseType, callback) {\n+    const unlisten = this.registerCallback(responseType, callback);","path":"3p/iframe-messaging-client.js","position":35,"original_position":35,"commit_id":"f03166b00dfea3b089fbaba083899949dd90d3d2","original_commit_id":"f03166b00dfea3b089fbaba083899949dd90d3d2","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Ahh, yah.","created_at":"2016-12-07T18:58:47Z","updated_at":"2016-12-07T18:58:47Z","html_url":"https://github.com/ampproject/amphtml/pull/6511#discussion_r91362046","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6511","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/91362046"},"html":{"href":"https://github.com/ampproject/amphtml/pull/6511#discussion_r91362046"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6511"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/6511","id":96832291,"html_url":"https://github.com/ampproject/amphtml/pull/6511","diff_url":"https://github.com/ampproject/amphtml/pull/6511.diff","patch_url":"https://github.com/ampproject/amphtml/pull/6511.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/6511","number":6511,"state":"open","locked":false,"title":"Turns AmpContext and IframeMessagingClient into composite pattern","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"body":"It will make the use of IframeMessageClient in amp-inabox easier.\r\n\r\nAdded unit test for IframeMessagingClient.\r\n","created_at":"2016-12-06T23:57:00Z","updated_at":"2016-12-07T18:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e45c76689d0c1ef40c614446ff60f102cfccce0d","assignee":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"assignees":[{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},{"login":"bradfrizzell","id":4276992,"avatar_url":"https://avatars.githubusercontent.com/u/4276992?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfrizzell","html_url":"https://github.com/bradfrizzell","followers_url":"https://api.github.com/users/bradfrizzell/followers","following_url":"https://api.github.com/users/bradfrizzell/following{/other_user}","gists_url":"https://api.github.com/users/bradfrizzell/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfrizzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfrizzell/subscriptions","organizations_url":"https://api.github.com/users/bradfrizzell/orgs","repos_url":"https://api.github.com/users/bradfrizzell/repos","events_url":"https://api.github.com/users/bradfrizzell/events{/privacy}","received_events_url":"https://api.github.com/users/bradfrizzell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6511/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6511/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/6511/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/f03166b00dfea3b089fbaba083899949dd90d3d2","head":{"label":"lannka:refactor_iframe_client","ref":"refactor_iframe_client","sha":"f03166b00dfea3b089fbaba083899949dd90d3d2","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"repo":{"id":60651806,"name":"amphtml","full_name":"lannka/amphtml","owner":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lannka/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/lannka/amphtml","forks_url":"https://api.github.com/repos/lannka/amphtml/forks","keys_url":"https://api.github.com/repos/lannka/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lannka/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lannka/amphtml/teams","hooks_url":"https://api.github.com/repos/lannka/amphtml/hooks","issue_events_url":"https://api.github.com/repos/lannka/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/lannka/amphtml/events","assignees_url":"https://api.github.com/repos/lannka/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/lannka/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/lannka/amphtml/tags","blobs_url":"https://api.github.com/repos/lannka/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lannka/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lannka/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lannka/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lannka/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/lannka/amphtml/languages","stargazers_url":"https://api.github.com/repos/lannka/amphtml/stargazers","contributors_url":"https://api.github.com/repos/lannka/amphtml/contributors","subscribers_url":"https://api.github.com/repos/lannka/amphtml/subscribers","subscription_url":"https://api.github.com/repos/lannka/amphtml/subscription","commits_url":"https://api.github.com/repos/lannka/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lannka/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lannka/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lannka/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lannka/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/lannka/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lannka/amphtml/merges","archive_url":"https://api.github.com/repos/lannka/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lannka/amphtml/downloads","issues_url":"https://api.github.com/repos/lannka/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/lannka/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/lannka/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/lannka/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lannka/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/lannka/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/lannka/amphtml/deployments","created_at":"2016-06-07T22:50:13Z","updated_at":"2016-06-07T22:50:18Z","pushed_at":"2016-12-07T18:14:00Z","git_url":"git://github.com/lannka/amphtml.git","ssh_url":"git@github.com:lannka/amphtml.git","clone_url":"https://github.com/lannka/amphtml.git","svn_url":"https://github.com/lannka/amphtml","homepage":"https://ampproject.org","size":219400,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"4b461e8d62c2cfb84fc423050812a65c43a6a8a0","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-12-07T13:27:04Z","pushed_at":"2016-12-07T18:58:28Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":258263,"stargazers_count":9179,"watchers_count":9179,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1433,"mirror_url":null,"open_issues_count":1011,"forks":1433,"open_issues":1011,"watchers":9179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6511"},"html":{"href":"https://github.com/ampproject/amphtml/pull/6511"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/6511"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/6511/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6511/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6511/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/f03166b00dfea3b089fbaba083899949dd90d3d2"}}}}
{"actor":{"display_login":"jridgewell"}}