{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/75223929","id":75223929,"diff_hunk":"@@ -61,7 +61,7 @@ def test_suggest_smartstack_proxy_port(self):\n             55555,  # bogus out-of-range value\n         ]\n \n-        def get_smarstack_proxy_port_from_file_side_effect(*args):\n+        def get_smarstack_proxy_port_from_file_side_effect():","path":"tests/cli/fsm/autosuggest_test.py","position":5,"original_position":5,"commit_id":"758b9fef04b931e248d9e75caeab3b303b05f14a","original_commit_id":"758b9fef04b931e248d9e75caeab3b303b05f14a","user":{"login":"EvanKrall","id":233961,"avatar_url":"https://avatars.githubusercontent.com/u/233961?v=3","gravatar_id":"","url":"https://api.github.com/users/EvanKrall","html_url":"https://github.com/EvanKrall","followers_url":"https://api.github.com/users/EvanKrall/followers","following_url":"https://api.github.com/users/EvanKrall/following{/other_user}","gists_url":"https://api.github.com/users/EvanKrall/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanKrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanKrall/subscriptions","organizations_url":"https://api.github.com/users/EvanKrall/orgs","repos_url":"https://api.github.com/users/EvanKrall/repos","events_url":"https://api.github.com/users/EvanKrall/events{/privacy}","received_events_url":"https://api.github.com/users/EvanKrall/received_events","type":"User","site_admin":false},"body":"This is important -- this function is standing in for a function that takes arguments, and you've changed the signature. I think this is what's causing the unit test failures.\r\n\r\nHowever, the way we're doing this seems kinda wonky anyway. I don't think we need this function at all - I believe we could just pass `side_effect=get_smartstack_proxy_port_from_file_returns` on line 66.","created_at":"2016-08-17T23:07:19Z","updated_at":"2016-08-17T23:07:19Z","html_url":"https://github.com/Yelp/paasta/pull/677#discussion_r75223929","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/677","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/75223929"},"html":{"href":"https://github.com/Yelp/paasta/pull/677#discussion_r75223929"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/677"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/677","id":81656336,"html_url":"https://github.com/Yelp/paasta/pull/677","diff_url":"https://github.com/Yelp/paasta/pull/677.diff","patch_url":"https://github.com/Yelp/paasta/pull/677.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/677","number":677,"state":"open","locked":false,"title":"code cleanup","user":{"login":"dvska","id":1125170,"avatar_url":"https://avatars.githubusercontent.com/u/1125170?v=3","gravatar_id":"","url":"https://api.github.com/users/dvska","html_url":"https://github.com/dvska","followers_url":"https://api.github.com/users/dvska/followers","following_url":"https://api.github.com/users/dvska/following{/other_user}","gists_url":"https://api.github.com/users/dvska/gists{/gist_id}","starred_url":"https://api.github.com/users/dvska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvska/subscriptions","organizations_url":"https://api.github.com/users/dvska/orgs","repos_url":"https://api.github.com/users/dvska/repos","events_url":"https://api.github.com/users/dvska/events{/privacy}","received_events_url":"https://api.github.com/users/dvska/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-17T14:46:58Z","updated_at":"2016-08-17T23:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7654b2da7975c6666bbb8db4f5079b29ec49efb0","assignee":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"assignees":[{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/677/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/677/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/677/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/758b9fef04b931e248d9e75caeab3b303b05f14a","head":{"label":"dvska:master","ref":"master","sha":"758b9fef04b931e248d9e75caeab3b303b05f14a","user":{"login":"dvska","id":1125170,"avatar_url":"https://avatars.githubusercontent.com/u/1125170?v=3","gravatar_id":"","url":"https://api.github.com/users/dvska","html_url":"https://github.com/dvska","followers_url":"https://api.github.com/users/dvska/followers","following_url":"https://api.github.com/users/dvska/following{/other_user}","gists_url":"https://api.github.com/users/dvska/gists{/gist_id}","starred_url":"https://api.github.com/users/dvska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvska/subscriptions","organizations_url":"https://api.github.com/users/dvska/orgs","repos_url":"https://api.github.com/users/dvska/repos","events_url":"https://api.github.com/users/dvska/events{/privacy}","received_events_url":"https://api.github.com/users/dvska/received_events","type":"User","site_admin":false},"repo":{"id":65915005,"name":"paasta","full_name":"dvska/paasta","owner":{"login":"dvska","id":1125170,"avatar_url":"https://avatars.githubusercontent.com/u/1125170?v=3","gravatar_id":"","url":"https://api.github.com/users/dvska","html_url":"https://github.com/dvska","followers_url":"https://api.github.com/users/dvska/followers","following_url":"https://api.github.com/users/dvska/following{/other_user}","gists_url":"https://api.github.com/users/dvska/gists{/gist_id}","starred_url":"https://api.github.com/users/dvska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvska/subscriptions","organizations_url":"https://api.github.com/users/dvska/orgs","repos_url":"https://api.github.com/users/dvska/repos","events_url":"https://api.github.com/users/dvska/events{/privacy}","received_events_url":"https://api.github.com/users/dvska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvska/paasta","description":"An open, distributed platform as a service","fork":true,"url":"https://api.github.com/repos/dvska/paasta","forks_url":"https://api.github.com/repos/dvska/paasta/forks","keys_url":"https://api.github.com/repos/dvska/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvska/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvska/paasta/teams","hooks_url":"https://api.github.com/repos/dvska/paasta/hooks","issue_events_url":"https://api.github.com/repos/dvska/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/dvska/paasta/events","assignees_url":"https://api.github.com/repos/dvska/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/dvska/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/dvska/paasta/tags","blobs_url":"https://api.github.com/repos/dvska/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvska/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvska/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvska/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvska/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/dvska/paasta/languages","stargazers_url":"https://api.github.com/repos/dvska/paasta/stargazers","contributors_url":"https://api.github.com/repos/dvska/paasta/contributors","subscribers_url":"https://api.github.com/repos/dvska/paasta/subscribers","subscription_url":"https://api.github.com/repos/dvska/paasta/subscription","commits_url":"https://api.github.com/repos/dvska/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvska/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvska/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvska/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvska/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/dvska/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvska/paasta/merges","archive_url":"https://api.github.com/repos/dvska/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvska/paasta/downloads","issues_url":"https://api.github.com/repos/dvska/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/dvska/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/dvska/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/dvska/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvska/paasta/labels{/name}","releases_url":"https://api.github.com/repos/dvska/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/dvska/paasta/deployments","created_at":"2016-08-17T14:38:59Z","updated_at":"2016-08-17T14:39:01Z","pushed_at":"2016-08-17T14:46:17Z","git_url":"git://github.com/dvska/paasta.git","ssh_url":"git@github.com:dvska/paasta.git","clone_url":"https://github.com/dvska/paasta.git","svn_url":"https://github.com/dvska/paasta","homepage":"","size":11559,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"ea577abc35a1e7aa222f617dc4de165e881a043c","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2016-08-17T11:57:55Z","pushed_at":"2016-08-17T22:52:31Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":11724,"stargazers_count":875,"watchers_count":875,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":63,"forks":82,"open_issues":63,"watchers":875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/677"},"html":{"href":"https://github.com/Yelp/paasta/pull/677"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/677"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/677/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/677/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/677/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/758b9fef04b931e248d9e75caeab3b303b05f14a"}}}}
{"actor":{"display_login":"EvanKrall"}}