{"action":"created","issue":{"url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/5","repository_url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps","labels_url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/5/comments","events_url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/5/events","html_url":"https://github.com/openprocurement/robot_tests.broker.aps/pull/5","id":164317813,"number":5,"title":"SingleItemTende final","user":{"login":"VadimShurhal","id":15789987,"avatar_url":"https://avatars.githubusercontent.com/u/15789987?v=3","gravatar_id":"","url":"https://api.github.com/users/VadimShurhal","html_url":"https://github.com/VadimShurhal","followers_url":"https://api.github.com/users/VadimShurhal/followers","following_url":"https://api.github.com/users/VadimShurhal/following{/other_user}","gists_url":"https://api.github.com/users/VadimShurhal/gists{/gist_id}","starred_url":"https://api.github.com/users/VadimShurhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VadimShurhal/subscriptions","organizations_url":"https://api.github.com/users/VadimShurhal/orgs","repos_url":"https://api.github.com/users/VadimShurhal/repos","events_url":"https://api.github.com/users/VadimShurhal/events{/privacy}","received_events_url":"https://api.github.com/users/VadimShurhal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-07T14:08:43Z","updated_at":"2016-07-12T09:32:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/pulls/5","html_url":"https://github.com/openprocurement/robot_tests.broker.aps/pull/5","diff_url":"https://github.com/openprocurement/robot_tests.broker.aps/pull/5.diff","patch_url":"https://github.com/openprocurement/robot_tests.broker.aps/pull/5.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/openprocurement/robot_tests.broker.aps/5)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/comments/231987568","html_url":"https://github.com/openprocurement/robot_tests.broker.aps/pull/5#issuecomment-231987568","issue_url":"https://api.github.com/repos/openprocurement/robot_tests.broker.aps/issues/5","id":231987568,"user":{"login":"mykhaly","id":13147752,"avatar_url":"https://avatars.githubusercontent.com/u/13147752?v=3","gravatar_id":"","url":"https://api.github.com/users/mykhaly","html_url":"https://github.com/mykhaly","followers_url":"https://api.github.com/users/mykhaly/followers","following_url":"https://api.github.com/users/mykhaly/following{/other_user}","gists_url":"https://api.github.com/users/mykhaly/gists{/gist_id}","starred_url":"https://api.github.com/users/mykhaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykhaly/subscriptions","organizations_url":"https://api.github.com/users/mykhaly/orgs","repos_url":"https://api.github.com/users/mykhaly/repos","events_url":"https://api.github.com/users/mykhaly/events{/privacy}","received_events_url":"https://api.github.com/users/mykhaly/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T09:32:20Z","updated_at":"2016-07-12T09:32:20Z","body":"\n\n\n\nReviewed 3 of 3 files at r2.\nReview status: all files reviewed at latest revision, 16 unresolved discussions.\n\n---\n\n*[aps.robot, line 91 \\[r1\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KM4jkxayUQflqnjXQLx:-KMTNKRknnBNUjqAuwn-:-783779084) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/7d61986329c5222c7aec20bb882813ad3e174c72/aps.robot#L91)):*\n<details><summary><i>Previously, mykhaly (Yurii Mykhalchuk) wrote…</i></summary>\n> Навіщо це тут?\n</details>\nЯ про `Адаптувати дані для оголошення тендера`. Ви не можете викликати це ключове слово тут. Адаптація даних під майданчик відбувається в включовому слові `Підготувати дані для оголошення тендера`, яке викликається в `Адаптувати дані для оголошення тендера`.\n\n---\n\n*[aps.robot, line 140 \\[r1\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KM4sHUOVgJdbqe4rBGP:-KMTN9ohU4CUzV2jHR7e:1884707993) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/7d61986329c5222c7aec20bb882813ad3e174c72/aps.robot#L140)):*\n<details><summary><i>Previously, mykhaly (Yurii Mykhalchuk) wrote…</i></summary>\n> Здається, тут не треба префіксу `aps.`\n</details>\nНічого не змінилося...\n\n---\n\n*[aps.robot, line 92 \\[r2\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KMTOJFLGlVuU_ujGzQG:-KMTOJFLGlVuU_ujGzQH:-1020962117) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/18b78886202d5f973dde004a708f5a41580dd0dc/aps.robot#L92)):*\n> ```RobotFramework\n>     Set To Dictionary    ${procuringEntity}    name    QA\n>     ${tender_data}=    Адаптувати дані для оголошення тендера    ${ARGUMENTS[0]}    ${tender_data}\n>     #\n> ```\n\nНавіщо `#` посеред ключового слова? Робот фреймворк дозволяє залишати порожній рядок, наскільки я пам'ятаю.  \n\n---\n\n*[aps.robot, line 260 \\[r2\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KMTN1wfa6Fbkui193_Q:-KMTN1wgVa5mu2WR37LN:1884707993) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/18b78886202d5f973dde004a708f5a41580dd0dc/aps.robot#L260)):*\n> ```RobotFramework\n> Отримати інформацію про value.valueAddedTaxIncluded\n>     ${return_value}=    Отримати текст із поля і показати на сторінці    value.valueAddedTaxIncluded\n>     ${return_value}=    Convert To Boolean    з ПДВ.\n> ```\n\nНічого не змінилося...\n\n---\n\n*[aps.robot, line 549 \\[r2\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KMTMb5uon9YhbShyczD:-KMTMb5uon9YhbShyczE:-1388309296) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/18b78886202d5f973dde004a708f5a41580dd0dc/aps.robot#L549)):*\n> ```RobotFramework\n> Active.tendering_provider\n>     [Arguments]    ${value}\n>     #\n> ```\n\nНавіщо тут `#`?\n\n---\n\n*[aps_service.py, line 41 \\[r1\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KM4quSuwqTrr_qun3Ea:-KMTMRP32skWqiaGFzJh:-415296178) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/7d61986329c5222c7aec20bb882813ad3e174c72/aps_service.py#L41)):*\n<details><summary><i>Previously, mykhaly (Yurii Mykhalchuk) wrote…</i></summary>\n> Добре було би забрати ці непотрібні рядки вкінці файлу і залишити на останній стрічці символ eol.\n</details>\nНавіщо Ви видалили два рядки функції? Вона тепер не робить нічого корисного. Я говорив про рядки в кінці файлу, які не по-`pep`у\n\n---\n\n*[APStender_subkeywords.robot, line 9 \\[r1\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KMTLseSyapJOt_RAzr7:-KMTLseSyapJOt_RAzr8:377126051) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/7d61986329c5222c7aec20bb882813ad3e174c72/APStender_subkeywords.robot#L9)):*\n> ```RobotFramework\n> Resource          aps.robot\n> Library           aps_service.py\n> Library           aps_date_utils.py\n> ```\n\nВи забрали звідси `aps_date_utils.py` і більше цей файл ніде не імпортується, наскільки я бачу. Чому Ви його не видалили?\n\n---\n\n*[APStender_subkeywords.robot, line 19 \\[r1\\]](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5#-KM4wuk-PyHJgTf0mo6P:-KMTRfPCeFHrmOklD0KN:1884707993) ([raw file](https://github.com/openprocurement/robot_tests.broker.aps/blob/7d61986329c5222c7aec20bb882813ad3e174c72/APStender_subkeywords.robot#L19)):*\n<details><summary><i>Previously, mykhaly (Yurii Mykhalchuk) wrote…</i></summary>\n> `${tender_date}` -> `${tender_data}`\n</details>\nНічого не змінилося...\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/openprocurement/robot_tests.broker.aps/5)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mykhaly"}}