{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/Shopify/record_store/pulls/15","id":82736446,"html_url":"https://github.com/Shopify/record_store/pull/15","diff_url":"https://github.com/Shopify/record_store/pull/15.diff","patch_url":"https://github.com/Shopify/record_store/pull/15.patch","issue_url":"https://api.github.com/repos/Shopify/record_store/issues/15","number":15,"state":"closed","locked":false,"title":"[WIP] Adding ALIAS record support for DynECT in Record Store","user":{"login":"andrewlouis93","id":996681,"avatar_url":"https://avatars.githubusercontent.com/u/996681?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlouis93","html_url":"https://github.com/andrewlouis93","followers_url":"https://api.github.com/users/andrewlouis93/followers","following_url":"https://api.github.com/users/andrewlouis93/following{/other_user}","gists_url":"https://api.github.com/users/andrewlouis93/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlouis93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlouis93/subscriptions","organizations_url":"https://api.github.com/users/andrewlouis93/orgs","repos_url":"https://api.github.com/users/andrewlouis93/repos","events_url":"https://api.github.com/users/andrewlouis93/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlouis93/received_events","type":"User","site_admin":false},"body":"r/ @es\r\n\r\n- This PR allows DynECT zones to use ALIAS dns entries.\r\n- It also uses a vendored version of the `fog-dynect` gem created here: https://github.com/Shopify/fog-dynect that allows ALIAS records to be used when interfacing with DynECT.\r\n\r\nRelated: https://github.com/Shopify/growth_engineering/issues/219\r\n\r\nNote: Hasn't been 🎩-ted yet, our zones need to be granted the ability to use ALIAS records first. ","created_at":"2016-08-25T15:01:52Z","updated_at":"2016-09-20T17:11:00Z","closed_at":"2016-09-20T17:11:00Z","merged_at":null,"merge_commit_sha":"8643bed92c6dfe5f3d8860574f137c7b41370ed0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/record_store/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Shopify/record_store/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/record_store/issues/15/comments","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/7ef98e5263e936ae1e25787d3631667d010fde5e","head":{"label":"Shopify:dynect-alias","ref":"dynect-alias","sha":"7ef98e5263e936ae1e25787d3631667d010fde5e","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-09-15T12:49:44Z","pushed_at":"2016-09-20T15:27:08Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":108,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":17,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"17b05632a13f492048535954eee415638a4ae0c8","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-09-15T12:49:44Z","pushed_at":"2016-09-20T15:27:08Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":108,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/15"},"html":{"href":"https://github.com/Shopify/record_store/pull/15"},"issue":{"href":"https://api.github.com/repos/Shopify/record_store/issues/15"},"comments":{"href":"https://api.github.com/repos/Shopify/record_store/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/record_store/statuses/7ef98e5263e936ae1e25787d3631667d010fde5e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":14,"commits":20,"additions":47,"deletions":20,"changed_files":6}}
{"actor":{"display_login":"sbfaulkner"}}