{"action":"created","comment":{"url":"https://api.github.com/repos/apache/falcon/pulls/comments/90619228","pull_request_review_id":11137593,"id":90619228,"diff_hunk":"@@ -140,19 +141,29 @@ private FileSystem initializeFileSystem() {\n         }\n     }\n \n-    public Map<String, String> getExtensionArtifacts(final String extensionName) throws StoreAccessException {\n+    public Map<String, String> getExtensionArtifacts(final String extensionName) throws\n+             FalconException {\n         Map<String, String> extensionFileMap = new HashMap<>();\n+        Path extensionPath;\n         try {\n-            Path extensionPath = new Path(storePath, extensionName.toLowerCase());\n-            RemoteIterator<LocatedFileStatus> fileStatusListIterator = fs.listFiles(extensionPath, true);\n+            RemoteIterator<LocatedFileStatus> fileStatusListIterator;\n+            if (AbstractExtension.isExtensionTrusted(extensionName)){","path":"extensions/src/main/java/org/apache/falcon/extensions/store/ExtensionStore.java","position":21,"original_position":21,"commit_id":"baeecd92ad8b292eb212b32c3f2d74c30d9d4d76","original_commit_id":"baeecd92ad8b292eb212b32c3f2d74c30d9d4d76","user":{"login":"pallavi-rao","id":9442234,"avatar_url":"https://avatars.githubusercontent.com/u/9442234?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-rao","html_url":"https://github.com/pallavi-rao","followers_url":"https://api.github.com/users/pallavi-rao/followers","following_url":"https://api.github.com/users/pallavi-rao/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-rao/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-rao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-rao/subscriptions","organizations_url":"https://api.github.com/users/pallavi-rao/orgs","repos_url":"https://api.github.com/users/pallavi-rao/repos","events_url":"https://api.github.com/users/pallavi-rao/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-rao/received_events","type":"User","site_admin":false},"body":"I looked at the ExtensionService again:\r\n`List<String> extensions = getExtensions();\r\n            for (String extension : extensions) {`\r\nThis list of extensions is only be trusted, so, won't need that check there. isn't it?","created_at":"2016-12-02T10:30:17Z","updated_at":"2016-12-02T10:34:00Z","html_url":"https://github.com/apache/falcon/pull/312#discussion_r90619228","pull_request_url":"https://api.github.com/repos/apache/falcon/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments/90619228"},"html":{"href":"https://github.com/apache/falcon/pull/312#discussion_r90619228"},"pull_request":{"href":"https://api.github.com/repos/apache/falcon/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/apache/falcon/pulls/312","id":96236683,"html_url":"https://github.com/apache/falcon/pull/312","diff_url":"https://github.com/apache/falcon/pull/312.diff","patch_url":"https://github.com/apache/falcon/pull/312.patch","issue_url":"https://api.github.com/repos/apache/falcon/issues/312","number":312,"state":"open","locked":false,"title":"FALCON-2205 describe for non trusted recipe","user":{"login":"PraveenAdlakha","id":1464653,"avatar_url":"https://avatars.githubusercontent.com/u/1464653?v=3","gravatar_id":"","url":"https://api.github.com/users/PraveenAdlakha","html_url":"https://github.com/PraveenAdlakha","followers_url":"https://api.github.com/users/PraveenAdlakha/followers","following_url":"https://api.github.com/users/PraveenAdlakha/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAdlakha/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAdlakha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAdlakha/subscriptions","organizations_url":"https://api.github.com/users/PraveenAdlakha/orgs","repos_url":"https://api.github.com/users/PraveenAdlakha/repos","events_url":"https://api.github.com/users/PraveenAdlakha/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAdlakha/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-02T08:01:55Z","updated_at":"2016-12-02T10:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee13db7a52d1682016daed4509eac5e909be28de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/falcon/pulls/312/commits","review_comments_url":"https://api.github.com/repos/apache/falcon/pulls/312/comments","review_comment_url":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/falcon/issues/312/comments","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/baeecd92ad8b292eb212b32c3f2d74c30d9d4d76","head":{"label":"PraveenAdlakha:2205","ref":"2205","sha":"baeecd92ad8b292eb212b32c3f2d74c30d9d4d76","user":{"login":"PraveenAdlakha","id":1464653,"avatar_url":"https://avatars.githubusercontent.com/u/1464653?v=3","gravatar_id":"","url":"https://api.github.com/users/PraveenAdlakha","html_url":"https://github.com/PraveenAdlakha","followers_url":"https://api.github.com/users/PraveenAdlakha/followers","following_url":"https://api.github.com/users/PraveenAdlakha/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAdlakha/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAdlakha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAdlakha/subscriptions","organizations_url":"https://api.github.com/users/PraveenAdlakha/orgs","repos_url":"https://api.github.com/users/PraveenAdlakha/repos","events_url":"https://api.github.com/users/PraveenAdlakha/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAdlakha/received_events","type":"User","site_admin":false},"repo":{"id":50416166,"name":"falcon","full_name":"PraveenAdlakha/falcon","owner":{"login":"PraveenAdlakha","id":1464653,"avatar_url":"https://avatars.githubusercontent.com/u/1464653?v=3","gravatar_id":"","url":"https://api.github.com/users/PraveenAdlakha","html_url":"https://github.com/PraveenAdlakha","followers_url":"https://api.github.com/users/PraveenAdlakha/followers","following_url":"https://api.github.com/users/PraveenAdlakha/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAdlakha/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAdlakha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAdlakha/subscriptions","organizations_url":"https://api.github.com/users/PraveenAdlakha/orgs","repos_url":"https://api.github.com/users/PraveenAdlakha/repos","events_url":"https://api.github.com/users/PraveenAdlakha/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAdlakha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PraveenAdlakha/falcon","description":"Mirror of Apache Falcon","fork":true,"url":"https://api.github.com/repos/PraveenAdlakha/falcon","forks_url":"https://api.github.com/repos/PraveenAdlakha/falcon/forks","keys_url":"https://api.github.com/repos/PraveenAdlakha/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PraveenAdlakha/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PraveenAdlakha/falcon/teams","hooks_url":"https://api.github.com/repos/PraveenAdlakha/falcon/hooks","issue_events_url":"https://api.github.com/repos/PraveenAdlakha/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/PraveenAdlakha/falcon/events","assignees_url":"https://api.github.com/repos/PraveenAdlakha/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/PraveenAdlakha/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/PraveenAdlakha/falcon/tags","blobs_url":"https://api.github.com/repos/PraveenAdlakha/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PraveenAdlakha/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PraveenAdlakha/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/PraveenAdlakha/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PraveenAdlakha/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/PraveenAdlakha/falcon/languages","stargazers_url":"https://api.github.com/repos/PraveenAdlakha/falcon/stargazers","contributors_url":"https://api.github.com/repos/PraveenAdlakha/falcon/contributors","subscribers_url":"https://api.github.com/repos/PraveenAdlakha/falcon/subscribers","subscription_url":"https://api.github.com/repos/PraveenAdlakha/falcon/subscription","commits_url":"https://api.github.com/repos/PraveenAdlakha/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/PraveenAdlakha/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/PraveenAdlakha/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/PraveenAdlakha/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/PraveenAdlakha/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/PraveenAdlakha/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PraveenAdlakha/falcon/merges","archive_url":"https://api.github.com/repos/PraveenAdlakha/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PraveenAdlakha/falcon/downloads","issues_url":"https://api.github.com/repos/PraveenAdlakha/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/PraveenAdlakha/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/PraveenAdlakha/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/PraveenAdlakha/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PraveenAdlakha/falcon/labels{/name}","releases_url":"https://api.github.com/repos/PraveenAdlakha/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/PraveenAdlakha/falcon/deployments","created_at":"2016-01-26T08:53:12Z","updated_at":"2016-01-26T08:53:16Z","pushed_at":"2016-12-02T08:01:09Z","git_url":"git://github.com/PraveenAdlakha/falcon.git","ssh_url":"git@github.com:PraveenAdlakha/falcon.git","clone_url":"https://github.com/PraveenAdlakha/falcon.git","svn_url":"https://github.com/PraveenAdlakha/falcon","homepage":null,"size":30456,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"51a09451e9b1438909a1cc0393b05343b6d11714","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11543457,"name":"falcon","full_name":"apache/falcon","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/falcon","description":"Mirror of Apache Falcon","fork":false,"url":"https://api.github.com/repos/apache/falcon","forks_url":"https://api.github.com/repos/apache/falcon/forks","keys_url":"https://api.github.com/repos/apache/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/falcon/teams","hooks_url":"https://api.github.com/repos/apache/falcon/hooks","issue_events_url":"https://api.github.com/repos/apache/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/apache/falcon/events","assignees_url":"https://api.github.com/repos/apache/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/apache/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/apache/falcon/tags","blobs_url":"https://api.github.com/repos/apache/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/falcon/languages","stargazers_url":"https://api.github.com/repos/apache/falcon/stargazers","contributors_url":"https://api.github.com/repos/apache/falcon/contributors","subscribers_url":"https://api.github.com/repos/apache/falcon/subscribers","subscription_url":"https://api.github.com/repos/apache/falcon/subscription","commits_url":"https://api.github.com/repos/apache/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/apache/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/falcon/merges","archive_url":"https://api.github.com/repos/apache/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/falcon/downloads","issues_url":"https://api.github.com/repos/apache/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/apache/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/falcon/labels{/name}","releases_url":"https://api.github.com/repos/apache/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/apache/falcon/deployments","created_at":"2013-07-20T07:00:14Z","updated_at":"2016-11-10T14:30:33Z","pushed_at":"2016-12-02T09:47:39Z","git_url":"git://github.com/apache/falcon.git","ssh_url":"git@github.com:apache/falcon.git","clone_url":"https://github.com/apache/falcon.git","svn_url":"https://github.com/apache/falcon","homepage":null,"size":33735,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":"git://git.apache.org/falcon.git","open_issues_count":11,"forks":85,"open_issues":11,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/312"},"html":{"href":"https://github.com/apache/falcon/pull/312"},"issue":{"href":"https://api.github.com/repos/apache/falcon/issues/312"},"comments":{"href":"https://api.github.com/repos/apache/falcon/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/falcon/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/falcon/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/apache/falcon/statuses/baeecd92ad8b292eb212b32c3f2d74c30d9d4d76"}}}}
{"actor":{"display_login":"pallavi-rao"}}