{"action":"closed","number":119,"pull_request":{"url":"https://api.github.com/repos/hkimura/foedus_code/pulls/119","id":61331240,"html_url":"https://github.com/hkimura/foedus_code/pull/119","diff_url":"https://github.com/hkimura/foedus_code/pull/119.diff","patch_url":"https://github.com/hkimura/foedus_code/pull/119.patch","issue_url":"https://api.github.com/repos/hkimura/foedus_code/issues/119","number":119,"state":"closed","locked":false,"title":"Adding testcase to show opening an empty storage fails","user":{"login":"joetucek","id":1753279,"avatar_url":"https://avatars.githubusercontent.com/u/1753279?v=3","gravatar_id":"","url":"https://api.github.com/users/joetucek","html_url":"https://github.com/joetucek","followers_url":"https://api.github.com/users/joetucek/followers","following_url":"https://api.github.com/users/joetucek/following{/other_user}","gists_url":"https://api.github.com/users/joetucek/gists{/gist_id}","starred_url":"https://api.github.com/users/joetucek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joetucek/subscriptions","organizations_url":"https://api.github.com/users/joetucek/orgs","repos_url":"https://api.github.com/users/joetucek/repos","events_url":"https://api.github.com/users/joetucek/events{/privacy}","received_events_url":"https://api.github.com/users/joetucek/received_events","type":"User","site_admin":false},"body":"<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/hkimura/foedus_code/pull/119%23issuecomment-191465961%22%2C%20%22https%3A//github.com/hkimura/foedus_code/pull/119%23issuecomment-215218353%22%2C%20%22https%3A//github.com/hkimura/foedus_code/pull/119%23issuecomment-215223808%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/hkimura/foedus_code/pull/119%23issuecomment-191465961%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Thx%2C%20will%20merge%20as%20soon%20as%20I%20figure%20out%20a%20fix.%22%2C%20%22created_at%22%3A%20%222016-03-02T22%3A30%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/702382%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/hkimura%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20finally%20got%20time%20to%20test%20this..%20and%20the%20testcase%20passes.%20ummm%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T20%3A30%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/702382%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/hkimura%22%7D%7D%2C%20%7B%22body%22%3A%20%22Because%20it%20just%20passes...%20I%27m%20merging%20this%20PR.%20Need%20to%20do%20some%20aesthetic%20changes%2C%20tho.%22%2C%20%22created_at%22%3A%20%222016-04-27T20%3A47%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/702382%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/hkimura%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/hkimura/foedus_code/pull/119#issuecomment-191465961'>General Comment</a></b>\n- <a href='https://github.com/hkimura'><img border=0 src='https://avatars.githubusercontent.com/u/702382?v=3' height=16 width=16'></a> Thx, will merge as soon as I figure out a fix.\n- <a href='https://github.com/hkimura'><img border=0 src='https://avatars.githubusercontent.com/u/702382?v=3' height=16 width=16'></a> I finally got time to test this.. and the testcase passes. ummm?\n- <a href='https://github.com/hkimura'><img border=0 src='https://avatars.githubusercontent.com/u/702382?v=3' height=16 width=16'></a> Because it just passes... I'm merging this PR. Need to do some aesthetic changes, tho.\n\n\n<a href='https://www.codereviewhub.com/hkimura/foedus_code/pull/119?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/hkimura/foedus_code/pull/119?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/hkimura/foedus_code/pull/119'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-03-02T00:10:33Z","updated_at":"2016-04-27T20:47:40Z","closed_at":"2016-04-27T20:47:40Z","merged_at":"2016-04-27T20:47:40Z","merge_commit_sha":"092b2a9dc5e339063a79d5fa4c370a3d5025156a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hkimura/foedus_code/pulls/119/commits","review_comments_url":"https://api.github.com/repos/hkimura/foedus_code/pulls/119/comments","review_comment_url":"https://api.github.com/repos/hkimura/foedus_code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hkimura/foedus_code/issues/119/comments","statuses_url":"https://api.github.com/repos/hkimura/foedus_code/statuses/276b93e8c16bf796171149c1262d9e0d8fb7a8d7","head":{"label":"joetucek:master","ref":"master","sha":"276b93e8c16bf796171149c1262d9e0d8fb7a8d7","user":{"login":"joetucek","id":1753279,"avatar_url":"https://avatars.githubusercontent.com/u/1753279?v=3","gravatar_id":"","url":"https://api.github.com/users/joetucek","html_url":"https://github.com/joetucek","followers_url":"https://api.github.com/users/joetucek/followers","following_url":"https://api.github.com/users/joetucek/following{/other_user}","gists_url":"https://api.github.com/users/joetucek/gists{/gist_id}","starred_url":"https://api.github.com/users/joetucek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joetucek/subscriptions","organizations_url":"https://api.github.com/users/joetucek/orgs","repos_url":"https://api.github.com/users/joetucek/repos","events_url":"https://api.github.com/users/joetucek/events{/privacy}","received_events_url":"https://api.github.com/users/joetucek/received_events","type":"User","site_admin":false},"repo":{"id":52902680,"name":"foedus_code","full_name":"joetucek/foedus_code","owner":{"login":"joetucek","id":1753279,"avatar_url":"https://avatars.githubusercontent.com/u/1753279?v=3","gravatar_id":"","url":"https://api.github.com/users/joetucek","html_url":"https://github.com/joetucek","followers_url":"https://api.github.com/users/joetucek/followers","following_url":"https://api.github.com/users/joetucek/following{/other_user}","gists_url":"https://api.github.com/users/joetucek/gists{/gist_id}","starred_url":"https://api.github.com/users/joetucek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joetucek/subscriptions","organizations_url":"https://api.github.com/users/joetucek/orgs","repos_url":"https://api.github.com/users/joetucek/repos","events_url":"https://api.github.com/users/joetucek/events{/privacy}","received_events_url":"https://api.github.com/users/joetucek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joetucek/foedus_code","description":"FOEDUS main source code repository","fork":true,"url":"https://api.github.com/repos/joetucek/foedus_code","forks_url":"https://api.github.com/repos/joetucek/foedus_code/forks","keys_url":"https://api.github.com/repos/joetucek/foedus_code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joetucek/foedus_code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joetucek/foedus_code/teams","hooks_url":"https://api.github.com/repos/joetucek/foedus_code/hooks","issue_events_url":"https://api.github.com/repos/joetucek/foedus_code/issues/events{/number}","events_url":"https://api.github.com/repos/joetucek/foedus_code/events","assignees_url":"https://api.github.com/repos/joetucek/foedus_code/assignees{/user}","branches_url":"https://api.github.com/repos/joetucek/foedus_code/branches{/branch}","tags_url":"https://api.github.com/repos/joetucek/foedus_code/tags","blobs_url":"https://api.github.com/repos/joetucek/foedus_code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joetucek/foedus_code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joetucek/foedus_code/git/refs{/sha}","trees_url":"https://api.github.com/repos/joetucek/foedus_code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joetucek/foedus_code/statuses/{sha}","languages_url":"https://api.github.com/repos/joetucek/foedus_code/languages","stargazers_url":"https://api.github.com/repos/joetucek/foedus_code/stargazers","contributors_url":"https://api.github.com/repos/joetucek/foedus_code/contributors","subscribers_url":"https://api.github.com/repos/joetucek/foedus_code/subscribers","subscription_url":"https://api.github.com/repos/joetucek/foedus_code/subscription","commits_url":"https://api.github.com/repos/joetucek/foedus_code/commits{/sha}","git_commits_url":"https://api.github.com/repos/joetucek/foedus_code/git/commits{/sha}","comments_url":"https://api.github.com/repos/joetucek/foedus_code/comments{/number}","issue_comment_url":"https://api.github.com/repos/joetucek/foedus_code/issues/comments{/number}","contents_url":"https://api.github.com/repos/joetucek/foedus_code/contents/{+path}","compare_url":"https://api.github.com/repos/joetucek/foedus_code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joetucek/foedus_code/merges","archive_url":"https://api.github.com/repos/joetucek/foedus_code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joetucek/foedus_code/downloads","issues_url":"https://api.github.com/repos/joetucek/foedus_code/issues{/number}","pulls_url":"https://api.github.com/repos/joetucek/foedus_code/pulls{/number}","milestones_url":"https://api.github.com/repos/joetucek/foedus_code/milestones{/number}","notifications_url":"https://api.github.com/repos/joetucek/foedus_code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joetucek/foedus_code/labels{/name}","releases_url":"https://api.github.com/repos/joetucek/foedus_code/releases{/id}","deployments_url":"https://api.github.com/repos/joetucek/foedus_code/deployments","created_at":"2016-03-01T19:12:22Z","updated_at":"2016-03-01T19:12:25Z","pushed_at":"2016-03-02T00:09:06Z","git_url":"git://github.com/joetucek/foedus_code.git","ssh_url":"git@github.com:joetucek/foedus_code.git","clone_url":"https://github.com/joetucek/foedus_code.git","svn_url":"https://github.com/joetucek/foedus_code","homepage":null,"size":8431,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hkimura:master","ref":"master","sha":"6d44598eb4c4b7e4bdedc92b47e488df675c9ad7","user":{"login":"hkimura","id":702382,"avatar_url":"https://avatars.githubusercontent.com/u/702382?v=3","gravatar_id":"","url":"https://api.github.com/users/hkimura","html_url":"https://github.com/hkimura","followers_url":"https://api.github.com/users/hkimura/followers","following_url":"https://api.github.com/users/hkimura/following{/other_user}","gists_url":"https://api.github.com/users/hkimura/gists{/gist_id}","starred_url":"https://api.github.com/users/hkimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkimura/subscriptions","organizations_url":"https://api.github.com/users/hkimura/orgs","repos_url":"https://api.github.com/users/hkimura/repos","events_url":"https://api.github.com/users/hkimura/events{/privacy}","received_events_url":"https://api.github.com/users/hkimura/received_events","type":"User","site_admin":false},"repo":{"id":34538557,"name":"foedus_code","full_name":"hkimura/foedus_code","owner":{"login":"hkimura","id":702382,"avatar_url":"https://avatars.githubusercontent.com/u/702382?v=3","gravatar_id":"","url":"https://api.github.com/users/hkimura","html_url":"https://github.com/hkimura","followers_url":"https://api.github.com/users/hkimura/followers","following_url":"https://api.github.com/users/hkimura/following{/other_user}","gists_url":"https://api.github.com/users/hkimura/gists{/gist_id}","starred_url":"https://api.github.com/users/hkimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkimura/subscriptions","organizations_url":"https://api.github.com/users/hkimura/orgs","repos_url":"https://api.github.com/users/hkimura/repos","events_url":"https://api.github.com/users/hkimura/events{/privacy}","received_events_url":"https://api.github.com/users/hkimura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkimura/foedus_code","description":"FOEDUS main source code repository","fork":false,"url":"https://api.github.com/repos/hkimura/foedus_code","forks_url":"https://api.github.com/repos/hkimura/foedus_code/forks","keys_url":"https://api.github.com/repos/hkimura/foedus_code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkimura/foedus_code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkimura/foedus_code/teams","hooks_url":"https://api.github.com/repos/hkimura/foedus_code/hooks","issue_events_url":"https://api.github.com/repos/hkimura/foedus_code/issues/events{/number}","events_url":"https://api.github.com/repos/hkimura/foedus_code/events","assignees_url":"https://api.github.com/repos/hkimura/foedus_code/assignees{/user}","branches_url":"https://api.github.com/repos/hkimura/foedus_code/branches{/branch}","tags_url":"https://api.github.com/repos/hkimura/foedus_code/tags","blobs_url":"https://api.github.com/repos/hkimura/foedus_code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkimura/foedus_code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkimura/foedus_code/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkimura/foedus_code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkimura/foedus_code/statuses/{sha}","languages_url":"https://api.github.com/repos/hkimura/foedus_code/languages","stargazers_url":"https://api.github.com/repos/hkimura/foedus_code/stargazers","contributors_url":"https://api.github.com/repos/hkimura/foedus_code/contributors","subscribers_url":"https://api.github.com/repos/hkimura/foedus_code/subscribers","subscription_url":"https://api.github.com/repos/hkimura/foedus_code/subscription","commits_url":"https://api.github.com/repos/hkimura/foedus_code/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkimura/foedus_code/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkimura/foedus_code/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkimura/foedus_code/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkimura/foedus_code/contents/{+path}","compare_url":"https://api.github.com/repos/hkimura/foedus_code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkimura/foedus_code/merges","archive_url":"https://api.github.com/repos/hkimura/foedus_code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkimura/foedus_code/downloads","issues_url":"https://api.github.com/repos/hkimura/foedus_code/issues{/number}","pulls_url":"https://api.github.com/repos/hkimura/foedus_code/pulls{/number}","milestones_url":"https://api.github.com/repos/hkimura/foedus_code/milestones{/number}","notifications_url":"https://api.github.com/repos/hkimura/foedus_code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkimura/foedus_code/labels{/name}","releases_url":"https://api.github.com/repos/hkimura/foedus_code/releases{/id}","deployments_url":"https://api.github.com/repos/hkimura/foedus_code/deployments","created_at":"2015-04-24T19:50:14Z","updated_at":"2016-04-22T09:00:59Z","pushed_at":"2016-04-27T20:47:41Z","git_url":"git://github.com/hkimura/foedus_code.git","ssh_url":"git@github.com:hkimura/foedus_code.git","clone_url":"https://github.com/hkimura/foedus_code.git","svn_url":"https://github.com/hkimura/foedus_code","homepage":null,"size":10547,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hkimura/foedus_code/pulls/119"},"html":{"href":"https://github.com/hkimura/foedus_code/pull/119"},"issue":{"href":"https://api.github.com/repos/hkimura/foedus_code/issues/119"},"comments":{"href":"https://api.github.com/repos/hkimura/foedus_code/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/hkimura/foedus_code/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/hkimura/foedus_code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hkimura/foedus_code/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/hkimura/foedus_code/statuses/276b93e8c16bf796171149c1262d9e0d8fb7a8d7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hkimura","id":702382,"avatar_url":"https://avatars.githubusercontent.com/u/702382?v=3","gravatar_id":"","url":"https://api.github.com/users/hkimura","html_url":"https://github.com/hkimura","followers_url":"https://api.github.com/users/hkimura/followers","following_url":"https://api.github.com/users/hkimura/following{/other_user}","gists_url":"https://api.github.com/users/hkimura/gists{/gist_id}","starred_url":"https://api.github.com/users/hkimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkimura/subscriptions","organizations_url":"https://api.github.com/users/hkimura/orgs","repos_url":"https://api.github.com/users/hkimura/repos","events_url":"https://api.github.com/users/hkimura/events{/privacy}","received_events_url":"https://api.github.com/users/hkimura/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":109,"deletions":0,"changed_files":2}}