{"action":"created","issue":{"url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/399","repository_url":"https://api.github.com/repos/pytest-dev/pytest-django","labels_url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/399/comments","events_url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/399/events","html_url":"https://github.com/pytest-dev/pytest-django/pull/399","id":181926751,"number":399,"title":"Use Django override_settings for settings fixture","user":{"login":"abdulhaq-e","id":2532125,"avatar_url":"https://avatars.githubusercontent.com/u/2532125?v=3","gravatar_id":"","url":"https://api.github.com/users/abdulhaq-e","html_url":"https://github.com/abdulhaq-e","followers_url":"https://api.github.com/users/abdulhaq-e/followers","following_url":"https://api.github.com/users/abdulhaq-e/following{/other_user}","gists_url":"https://api.github.com/users/abdulhaq-e/gists{/gist_id}","starred_url":"https://api.github.com/users/abdulhaq-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdulhaq-e/subscriptions","organizations_url":"https://api.github.com/users/abdulhaq-e/orgs","repos_url":"https://api.github.com/users/abdulhaq-e/repos","events_url":"https://api.github.com/users/abdulhaq-e/events{/privacy}","received_events_url":"https://api.github.com/users/abdulhaq-e/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-10T02:03:50Z","updated_at":"2016-11-04T09:06:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest-django/pulls/399","html_url":"https://github.com/pytest-dev/pytest-django/pull/399","diff_url":"https://github.com/pytest-dev/pytest-django/pull/399.diff","patch_url":"https://github.com/pytest-dev/pytest-django/pull/399.patch"},"body":"This PR uses Django override_settings for the settings fixture.\n\nThe PR is mostly based on the work of PR [#141](https://github.com/pytest-dev/pytest-django/pull/324) and more recently PR [#324](https://github.com/pytest-dev/pytest-django/pull/324).\n\nThe latter attempted to use a different mechanism, but as discussed,\nit's better to use the API provided by Django to ensure future\ncompatibility.\n"},"comment":{"url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/comments/258377049","html_url":"https://github.com/pytest-dev/pytest-django/pull/399#issuecomment-258377049","issue_url":"https://api.github.com/repos/pytest-dev/pytest-django/issues/399","id":258377049,"user":{"login":"asfaltboy","id":321520,"avatar_url":"https://avatars.githubusercontent.com/u/321520?v=3","gravatar_id":"","url":"https://api.github.com/users/asfaltboy","html_url":"https://github.com/asfaltboy","followers_url":"https://api.github.com/users/asfaltboy/followers","following_url":"https://api.github.com/users/asfaltboy/following{/other_user}","gists_url":"https://api.github.com/users/asfaltboy/gists{/gist_id}","starred_url":"https://api.github.com/users/asfaltboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfaltboy/subscriptions","organizations_url":"https://api.github.com/users/asfaltboy/orgs","repos_url":"https://api.github.com/users/asfaltboy/repos","events_url":"https://api.github.com/users/asfaltboy/events{/privacy}","received_events_url":"https://api.github.com/users/asfaltboy/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T09:06:56Z","updated_at":"2016-11-04T09:06:56Z","body":"@pytest-dev anyone had a change to look at this one? The `override_settings` context decorator works fine currently so I would prefer to use it directly, rather than trying to re-implement it.\r\n\r\n@abdulhaq-e you can probably just use [the tests][1] from PR #141 and if they \"should\" pass if all is well.\r\n\r\n[1]: https://github.com/pytest-dev/pytest-django/pull/324/files#diff-94feec110cd1978ad94f58b01ee0c3cd"}}
{"actor":{"display_login":"asfaltboy"}}