{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/finagle/issues/515","repository_url":"https://api.github.com/repos/twitter/finagle","labels_url":"https://api.github.com/repos/twitter/finagle/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/515/comments","events_url":"https://api.github.com/repos/twitter/finagle/issues/515/events","html_url":"https://github.com/twitter/finagle/pull/515","id":158910182,"number":515,"title":"Kafka transport for Zipkin traces","user":{"login":"sveinnfannar","id":751254,"avatar_url":"https://avatars.githubusercontent.com/u/751254?v=3","gravatar_id":"","url":"https://api.github.com/users/sveinnfannar","html_url":"https://github.com/sveinnfannar","followers_url":"https://api.github.com/users/sveinnfannar/followers","following_url":"https://api.github.com/users/sveinnfannar/following{/other_user}","gists_url":"https://api.github.com/users/sveinnfannar/gists{/gist_id}","starred_url":"https://api.github.com/users/sveinnfannar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveinnfannar/subscriptions","organizations_url":"https://api.github.com/users/sveinnfannar/orgs","repos_url":"https://api.github.com/users/sveinnfannar/repos","events_url":"https://api.github.com/users/sveinnfannar/events{/privacy}","received_events_url":"https://api.github.com/users/sveinnfannar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-07T12:26:43Z","updated_at":"2016-06-07T14:10:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/515","html_url":"https://github.com/twitter/finagle/pull/515","diff_url":"https://github.com/twitter/finagle/pull/515.diff","patch_url":"https://github.com/twitter/finagle/pull/515.patch"},"body":"Problem\r\n\r\nZipkin can receive traces via Kafka, HTTP and Scribe. Some Finagle users (including Quizup) already using Kafka would like to avoid adding Scribe to their stack as it is no longer maintained.\r\nThe purpose of this PR is to support Kafka as a transport for Zipkin traces.\r\nPartially addressing issue #465.\r\n\r\n\r\nSolution\r\n\r\nIn #513 I extracted core components of finagle-zipkin into finagle-zipkin-core. Building off that I added a module finagle-zipkin-kafka with kafka specific code and a service loader. It's interface is very similar to [ScribeZipkinTracer] found in finagle-zipkin.\r\n\r\n\r\n**NOTE: The diff also contains changes from #513 because this PR depend on changes from there. All changes in this PR have been squashed into https://github.com/twitter/finagle/pull/515/commits/08b3dd04fc54c84227cf689f7eb4d8403bc885c0**\r\n\r\nPing: @adriancole "},"comment":{"url":"https://api.github.com/repos/twitter/finagle/issues/comments/224292363","html_url":"https://github.com/twitter/finagle/pull/515#issuecomment-224292363","issue_url":"https://api.github.com/repos/twitter/finagle/issues/515","id":224292363,"user":{"login":"eirslett","id":1872593,"avatar_url":"https://avatars.githubusercontent.com/u/1872593?v=3","gravatar_id":"","url":"https://api.github.com/users/eirslett","html_url":"https://github.com/eirslett","followers_url":"https://api.github.com/users/eirslett/followers","following_url":"https://api.github.com/users/eirslett/following{/other_user}","gists_url":"https://api.github.com/users/eirslett/gists{/gist_id}","starred_url":"https://api.github.com/users/eirslett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirslett/subscriptions","organizations_url":"https://api.github.com/users/eirslett/orgs","repos_url":"https://api.github.com/users/eirslett/repos","events_url":"https://api.github.com/users/eirslett/events{/privacy}","received_events_url":"https://api.github.com/users/eirslett/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T14:10:52Z","updated_at":"2016-06-07T14:10:52Z","body":"Is this running in production anywhere yet? (Or isn't that possible?)"}}
{"actor":{"display_login":"eirslett"}}