{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments/88193647","pull_request_review_id":8772994,"id":88193647,"diff_hunk":"@@ -552,6 +555,12 @@ encrypt_worker_thread_func(void *arg)\n \t\tif (thd->cancelled)\n \t\t\tbreak;\n \n+\t\tassert(gcry_md_get_algo_dlen(XB_CRYPT_HASH) ==","path":"storage/innobase/xtrabackup/src/ds_encrypt.c","position":67,"original_position":67,"commit_id":"5bb075ac9241624ebc778fc9ef807ddf77489378","original_commit_id":"5bb075ac9241624ebc778fc9ef807ddf77489378","user":{"login":"Oneiroi","id":478678,"avatar_url":"https://avatars.githubusercontent.com/u/478678?v=3","gravatar_id":"","url":"https://api.github.com/users/Oneiroi","html_url":"https://github.com/Oneiroi","followers_url":"https://api.github.com/users/Oneiroi/followers","following_url":"https://api.github.com/users/Oneiroi/following{/other_user}","gists_url":"https://api.github.com/users/Oneiroi/gists{/gist_id}","starred_url":"https://api.github.com/users/Oneiroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oneiroi/subscriptions","organizations_url":"https://api.github.com/users/Oneiroi/orgs","repos_url":"https://api.github.com/users/Oneiroi/repos","events_url":"https://api.github.com/users/Oneiroi/events{/privacy}","received_events_url":"https://api.github.com/users/Oneiroi/received_events","type":"User","site_admin":false},"body":"Yes I understand that, I just meant that a source code comment would have been appreciated here e.g.\r\n\r\n```c\r\n#Ensure the returned value of gcry_md_get_algo_dlen(XB_CRYPT_HASH) is equal to XB_CRYPT_HASH_LEN or throw an assertion.\r\nassert(gcry_md_get_algo_dlen(XB_CRYPT_HASH) ==\r\n\t\t       XB_CRYPT_HASH_LEN);\r\n```\r\n\r\nEntirely depends on your coding standard though, so feel free to not include something like this.","created_at":"2016-11-16T09:04:27Z","updated_at":"2016-11-16T09:04:27Z","html_url":"https://github.com/percona/percona-xtrabackup/pull/266#discussion_r88193647","pull_request_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments/88193647"},"html":{"href":"https://github.com/percona/percona-xtrabackup/pull/266#discussion_r88193647"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266","id":93274501,"html_url":"https://github.com/percona/percona-xtrabackup/pull/266","diff_url":"https://github.com/percona/percona-xtrabackup/pull/266.diff","patch_url":"https://github.com/percona/percona-xtrabackup/pull/266.patch","issue_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/266","number":266,"state":"open","locked":false,"title":"CVE-2016-6225: xtrabackup encryption is not setting the IV correctly","user":{"login":"gl-sergei","id":371194,"avatar_url":"https://avatars.githubusercontent.com/u/371194?v=3","gravatar_id":"","url":"https://api.github.com/users/gl-sergei","html_url":"https://github.com/gl-sergei","followers_url":"https://api.github.com/users/gl-sergei/followers","following_url":"https://api.github.com/users/gl-sergei/following{/other_user}","gists_url":"https://api.github.com/users/gl-sergei/gists{/gist_id}","starred_url":"https://api.github.com/users/gl-sergei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl-sergei/subscriptions","organizations_url":"https://api.github.com/users/gl-sergei/orgs","repos_url":"https://api.github.com/users/gl-sergei/repos","events_url":"https://api.github.com/users/gl-sergei/events{/privacy}","received_events_url":"https://api.github.com/users/gl-sergei/received_events","type":"User","site_admin":false},"body":"Blueprint checksum-unencrypted-chunk\r\n\r\n[https://blueprints.launchpad.net/percona-xtrabackup/+spec/checksum-unencrypted-chunk]\r\n\r\nThis patch changes xbcrypt format as following:\r\n\r\n1. Bump XBCRYPT header version number, current is \"XBCRYP03\"\r\n\r\n2. Append 32-byte SHA256 hash of the plaintext to the payload of each\r\n   chunk\r\n\r\n3. Encrypt plaintext payload and hash all together\r\n\r\n4. Both original length and encrypted length fields of the chunk header\r\n   are calculated including these extra 32 bytes.","created_at":"2016-11-11T03:38:33Z","updated_at":"2016-11-16T09:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4753a02f3cae53cd433343b7f2b13ea9c8344a59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266/commits","review_comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266/comments","review_comment_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/266/comments","statuses_url":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/5bb075ac9241624ebc778fc9ef807ddf77489378","head":{"label":"gl-sergei:2.3-xb-pxb-186","ref":"2.3-xb-pxb-186","sha":"5bb075ac9241624ebc778fc9ef807ddf77489378","user":{"login":"gl-sergei","id":371194,"avatar_url":"https://avatars.githubusercontent.com/u/371194?v=3","gravatar_id":"","url":"https://api.github.com/users/gl-sergei","html_url":"https://github.com/gl-sergei","followers_url":"https://api.github.com/users/gl-sergei/followers","following_url":"https://api.github.com/users/gl-sergei/following{/other_user}","gists_url":"https://api.github.com/users/gl-sergei/gists{/gist_id}","starred_url":"https://api.github.com/users/gl-sergei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl-sergei/subscriptions","organizations_url":"https://api.github.com/users/gl-sergei/orgs","repos_url":"https://api.github.com/users/gl-sergei/repos","events_url":"https://api.github.com/users/gl-sergei/events{/privacy}","received_events_url":"https://api.github.com/users/gl-sergei/received_events","type":"User","site_admin":false},"repo":{"id":30879429,"name":"percona-xtrabackup","full_name":"gl-sergei/percona-xtrabackup","owner":{"login":"gl-sergei","id":371194,"avatar_url":"https://avatars.githubusercontent.com/u/371194?v=3","gravatar_id":"","url":"https://api.github.com/users/gl-sergei","html_url":"https://github.com/gl-sergei","followers_url":"https://api.github.com/users/gl-sergei/followers","following_url":"https://api.github.com/users/gl-sergei/following{/other_user}","gists_url":"https://api.github.com/users/gl-sergei/gists{/gist_id}","starred_url":"https://api.github.com/users/gl-sergei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl-sergei/subscriptions","organizations_url":"https://api.github.com/users/gl-sergei/orgs","repos_url":"https://api.github.com/users/gl-sergei/repos","events_url":"https://api.github.com/users/gl-sergei/events{/privacy}","received_events_url":"https://api.github.com/users/gl-sergei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gl-sergei/percona-xtrabackup","description":null,"fork":true,"url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup","forks_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/forks","keys_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/teams","hooks_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/hooks","issue_events_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/issues/events{/number}","events_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/events","assignees_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/assignees{/user}","branches_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/branches{/branch}","tags_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/tags","blobs_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/statuses/{sha}","languages_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/languages","stargazers_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/stargazers","contributors_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/contributors","subscribers_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/subscribers","subscription_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/subscription","commits_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/contents/{+path}","compare_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/merges","archive_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/downloads","issues_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/issues{/number}","pulls_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/pulls{/number}","milestones_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/milestones{/number}","notifications_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/labels{/name}","releases_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/releases{/id}","deployments_url":"https://api.github.com/repos/gl-sergei/percona-xtrabackup/deployments","created_at":"2015-02-16T17:28:26Z","updated_at":"2016-02-01T11:10:13Z","pushed_at":"2016-11-15T14:27:35Z","git_url":"git://github.com/gl-sergei/percona-xtrabackup.git","ssh_url":"git@github.com:gl-sergei/percona-xtrabackup.git","clone_url":"https://github.com/gl-sergei/percona-xtrabackup.git","svn_url":"https://github.com/gl-sergei/percona-xtrabackup","homepage":null,"size":511577,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"2.2"}},"base":{"label":"percona:2.3","ref":"2.3","sha":"8e6fe0746ff1d95ee8a5bff1b038af44b0b72370","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753970,"name":"percona-xtrabackup","full_name":"percona/percona-xtrabackup","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtrabackup","description":"Open source hot backup tool for InnoDB and XtraDB databases","fork":false,"url":"https://api.github.com/repos/percona/percona-xtrabackup","forks_url":"https://api.github.com/repos/percona/percona-xtrabackup/forks","keys_url":"https://api.github.com/repos/percona/percona-xtrabackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtrabackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtrabackup/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtrabackup/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtrabackup/events","assignees_url":"https://api.github.com/repos/percona/percona-xtrabackup/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtrabackup/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtrabackup/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtrabackup/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtrabackup/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtrabackup/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtrabackup/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtrabackup/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtrabackup/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtrabackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtrabackup/merges","archive_url":"https://api.github.com/repos/percona/percona-xtrabackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtrabackup/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtrabackup/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtrabackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtrabackup/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtrabackup/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-xtrabackup/deployments","created_at":"2015-02-13T11:40:22Z","updated_at":"2016-11-14T06:33:35Z","pushed_at":"2016-11-15T14:04:24Z","git_url":"git://github.com/percona/percona-xtrabackup.git","ssh_url":"git@github.com:percona/percona-xtrabackup.git","clone_url":"https://github.com/percona/percona-xtrabackup.git","svn_url":"https://github.com/percona/percona-xtrabackup","homepage":"","size":591776,"stargazers_count":117,"watchers_count":117,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":10,"forks":68,"open_issues":10,"watchers":117,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266"},"html":{"href":"https://github.com/percona/percona-xtrabackup/pull/266"},"issue":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/issues/266"},"comments":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/5bb075ac9241624ebc778fc9ef807ddf77489378"}}}}
{"actor":{"display_login":"Oneiroi"}}