{"action":"created","issue":{"url":"https://api.github.com/repos/atom/symbols-view/issues/203","repository_url":"https://api.github.com/repos/atom/symbols-view","labels_url":"https://api.github.com/repos/atom/symbols-view/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/atom/symbols-view/issues/203/comments","events_url":"https://api.github.com/repos/atom/symbols-view/issues/203/events","html_url":"https://github.com/atom/symbols-view/pull/203","id":197750428,"number":203,"title":"Translate package from CoffeeScript to ES6","user":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?v=3","gravatar_id":"","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"labels":[{"id":193725945,"url":"https://api.github.com/repos/atom/symbols-view/labels/work-in-progress","name":"work-in-progress","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?v=3","gravatar_id":"","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"assignees":[{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?v=3","gravatar_id":"","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-27T19:57:42Z","updated_at":"2016-12-28T18:01:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/symbols-view/pulls/203","html_url":"https://github.com/atom/symbols-view/pull/203","diff_url":"https://github.com/atom/symbols-view/pull/203.diff","patch_url":"https://github.com/atom/symbols-view/pull/203.patch"},"body":"This PR translates all CoffeeScript to ES6, and makes use of the `fbjs` eslint preset.\r\n\r\n- [x] file-view.coffee > file-view.js\r\n- [x] get-tags-file.coffee > get-tags-file.js\r\n- [x] go-back-view.coffee > go-back-view.js\r\n- [x] go-to-view.coffee > go-to-view.js\r\n- [x] load-tags-handler.js > load-tags-handjs\r\n- [x] main.coffee > main.js\r\n- [x] project-view.coffee > project-view.js\r\n- [x] symbols-view.coffee > symbols-view.js\r\n- [x] tag-generator.coffee > tag-generator.js\r\n- [x] tag-reader.coffee > tag-reader.js\r\n- [x] symbols-view-spec.coffee > symbols-view-spec.js\r\n- [x] Add `devDependencies` for `eslint` / `fbjs`\r\n- [x] Add .eslintrc.js configuration\r\n- [x] Update package dependencies to latest versions\r\n\r\n/cc @zmb3\r\n\r\n### Translation Procedure\r\n\r\n* Initial setup:\r\n  * `npm install -g decaffeinate`\r\n  * Install `linter-eslint` and enable `--fix` on save\r\n  * Ensure `.eslintrc.js` / `.eslintignore` are configured correctly\r\n* For each file:\r\n  * `decaffeinate <path to the .coffee file`\r\n  * Open `.js` file in atom\r\n  * Save `.js` file\r\n  * Hand edit to remove common issues:\r\n    * Add `'use babel';` at the first line of the file\r\n    * `let` > `const` where possible\r\n    * Comparisons of something with null `if (theThing == null)` become `if (!theThing)`\r\n    * Replace all instances of `guard` / `guardFunc` with plain inline ES6\r\n    * Replace instances of `function () { }` with `() => { }` where appropriate\r\n    * Use carriage return to make single-line statements more readable\r\n    * Remove spurious `return` statements arising from implicit returns in CoffeeScript\r\n  * Delete corresponding `.coffee` file"},"comment":{"url":"https://api.github.com/repos/atom/symbols-view/issues/comments/269514901","html_url":"https://github.com/atom/symbols-view/pull/203#issuecomment-269514901","issue_url":"https://api.github.com/repos/atom/symbols-view/issues/203","id":269514901,"user":{"login":"maxbrunsfeld","id":326587,"avatar_url":"https://avatars.githubusercontent.com/u/326587?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbrunsfeld","html_url":"https://github.com/maxbrunsfeld","followers_url":"https://api.github.com/users/maxbrunsfeld/followers","following_url":"https://api.github.com/users/maxbrunsfeld/following{/other_user}","gists_url":"https://api.github.com/users/maxbrunsfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrunsfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrunsfeld/subscriptions","organizations_url":"https://api.github.com/users/maxbrunsfeld/orgs","repos_url":"https://api.github.com/users/maxbrunsfeld/repos","events_url":"https://api.github.com/users/maxbrunsfeld/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrunsfeld/received_events","type":"User","site_admin":true},"created_at":"2016-12-28T18:01:30Z","updated_at":"2016-12-28T18:01:30Z","body":"I think we can probably get rid of `BaseSymbolsView`, and have `SymbolsView` inherit directly from `atom-space-pen-views`. Other than that, this looks great. Thanks for the great writeup of your conversion procedure."}}
{"actor":{"display_login":"maxbrunsfeld"}}