{"action":"created","comment":{"url":"https://api.github.com/repos/wesm/feather/pulls/comments/58253760","id":58253760,"diff_hunk":"@@ -47,17 +47,55 @@ List metadataFeather(const std::string& path) {\n   return out;\n }\n \n+\n // [[Rcpp::export]]\n-List readFeather(const std::string& path) {\n-  auto table = openFeatherTable(path);\n+XPtr<feather::TableReader> openFeather(const std::string& path) {\n+  return XPtr<TableReader>(openFeatherTable(path).release(), true);\n+}\n \n-  int n = table->num_columns(), p = table->num_rows();\n-  List out(n), names(n);\n+\n+// [[Rcpp::export]]\n+double colsFeather(List feather) {\n+  auto table = Rcpp::as<XPtr<TableReader> >(feather[\"ptr\"]);","path":"R/src/feather-read.cpp","position":39,"original_position":39,"commit_id":"be57c9ff15bcb23e4da6b6718b58724a1ac02de0","original_commit_id":"be57c9ff15bcb23e4da6b6718b58724a1ac02de0","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"body":"I wonder if it would be nicer for these to functions to have input as `XPtr<TableReader>` (i.e. do the extraction on the R side)","created_at":"2016-04-01T19:13:51Z","updated_at":"2016-04-01T19:13:51Z","html_url":"https://github.com/wesm/feather/pull/82#discussion_r58253760","pull_request_url":"https://api.github.com/repos/wesm/feather/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/wesm/feather/pulls/comments/58253760"},"html":{"href":"https://github.com/wesm/feather/pull/82#discussion_r58253760"},"pull_request":{"href":"https://api.github.com/repos/wesm/feather/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/wesm/feather/pulls/82","id":64989615,"html_url":"https://github.com/wesm/feather/pull/82","diff_url":"https://github.com/wesm/feather/pull/82.diff","patch_url":"https://github.com/wesm/feather/pull/82.patch","issue_url":"https://api.github.com/repos/wesm/feather/issues/82","number":82,"state":"open","locked":false,"title":"[R] New arg \"columns\" to read_feather()","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"body":"- With test.\n- Remove now obsolete readFeather().\n\nOn top of #63.","created_at":"2016-04-01T18:58:20Z","updated_at":"2016-04-01T19:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3a4d91a44a79cf5b8e2efcfa6241e21d24b6a42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wesm/feather/pulls/82/commits","review_comments_url":"https://api.github.com/repos/wesm/feather/pulls/82/comments","review_comment_url":"https://api.github.com/repos/wesm/feather/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wesm/feather/issues/82/comments","statuses_url":"https://api.github.com/repos/wesm/feather/statuses/be57c9ff15bcb23e4da6b6718b58724a1ac02de0","head":{"label":"krlmlr:feature/read-subset","ref":"feature/read-subset","sha":"be57c9ff15bcb23e4da6b6718b58724a1ac02de0","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"repo":{"id":55055904,"name":"feather","full_name":"krlmlr/feather","owner":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krlmlr/feather","description":"Feather: fast, interoperable binary data frame storage for Python, R, and more powered by Apache Arrow","fork":true,"url":"https://api.github.com/repos/krlmlr/feather","forks_url":"https://api.github.com/repos/krlmlr/feather/forks","keys_url":"https://api.github.com/repos/krlmlr/feather/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krlmlr/feather/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krlmlr/feather/teams","hooks_url":"https://api.github.com/repos/krlmlr/feather/hooks","issue_events_url":"https://api.github.com/repos/krlmlr/feather/issues/events{/number}","events_url":"https://api.github.com/repos/krlmlr/feather/events","assignees_url":"https://api.github.com/repos/krlmlr/feather/assignees{/user}","branches_url":"https://api.github.com/repos/krlmlr/feather/branches{/branch}","tags_url":"https://api.github.com/repos/krlmlr/feather/tags","blobs_url":"https://api.github.com/repos/krlmlr/feather/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krlmlr/feather/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krlmlr/feather/git/refs{/sha}","trees_url":"https://api.github.com/repos/krlmlr/feather/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krlmlr/feather/statuses/{sha}","languages_url":"https://api.github.com/repos/krlmlr/feather/languages","stargazers_url":"https://api.github.com/repos/krlmlr/feather/stargazers","contributors_url":"https://api.github.com/repos/krlmlr/feather/contributors","subscribers_url":"https://api.github.com/repos/krlmlr/feather/subscribers","subscription_url":"https://api.github.com/repos/krlmlr/feather/subscription","commits_url":"https://api.github.com/repos/krlmlr/feather/commits{/sha}","git_commits_url":"https://api.github.com/repos/krlmlr/feather/git/commits{/sha}","comments_url":"https://api.github.com/repos/krlmlr/feather/comments{/number}","issue_comment_url":"https://api.github.com/repos/krlmlr/feather/issues/comments{/number}","contents_url":"https://api.github.com/repos/krlmlr/feather/contents/{+path}","compare_url":"https://api.github.com/repos/krlmlr/feather/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krlmlr/feather/merges","archive_url":"https://api.github.com/repos/krlmlr/feather/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krlmlr/feather/downloads","issues_url":"https://api.github.com/repos/krlmlr/feather/issues{/number}","pulls_url":"https://api.github.com/repos/krlmlr/feather/pulls{/number}","milestones_url":"https://api.github.com/repos/krlmlr/feather/milestones{/number}","notifications_url":"https://api.github.com/repos/krlmlr/feather/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krlmlr/feather/labels{/name}","releases_url":"https://api.github.com/repos/krlmlr/feather/releases{/id}","deployments_url":"https://api.github.com/repos/krlmlr/feather/deployments","created_at":"2016-03-30T10:57:47Z","updated_at":"2016-03-30T10:57:48Z","pushed_at":"2016-04-01T18:58:30Z","git_url":"git://github.com/krlmlr/feather.git","ssh_url":"git@github.com:krlmlr/feather.git","clone_url":"https://github.com/krlmlr/feather.git","svn_url":"https://github.com/krlmlr/feather","homepage":"","size":236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wesm:master","ref":"master","sha":"fa0d80caf3ea3866586972da26035e3c44d2529e","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":50544166,"name":"feather","full_name":"wesm/feather","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/feather","description":"Feather: fast, interoperable binary data frame storage for Python, R, and more powered by Apache Arrow","fork":false,"url":"https://api.github.com/repos/wesm/feather","forks_url":"https://api.github.com/repos/wesm/feather/forks","keys_url":"https://api.github.com/repos/wesm/feather/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/feather/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/feather/teams","hooks_url":"https://api.github.com/repos/wesm/feather/hooks","issue_events_url":"https://api.github.com/repos/wesm/feather/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/feather/events","assignees_url":"https://api.github.com/repos/wesm/feather/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/feather/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/feather/tags","blobs_url":"https://api.github.com/repos/wesm/feather/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/feather/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/feather/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/feather/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/feather/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/feather/languages","stargazers_url":"https://api.github.com/repos/wesm/feather/stargazers","contributors_url":"https://api.github.com/repos/wesm/feather/contributors","subscribers_url":"https://api.github.com/repos/wesm/feather/subscribers","subscription_url":"https://api.github.com/repos/wesm/feather/subscription","commits_url":"https://api.github.com/repos/wesm/feather/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/feather/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/feather/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/feather/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/feather/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/feather/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/feather/merges","archive_url":"https://api.github.com/repos/wesm/feather/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/feather/downloads","issues_url":"https://api.github.com/repos/wesm/feather/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/feather/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/feather/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/feather/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/feather/labels{/name}","releases_url":"https://api.github.com/repos/wesm/feather/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/feather/deployments","created_at":"2016-01-27T22:59:51Z","updated_at":"2016-04-01T18:47:40Z","pushed_at":"2016-04-01T18:58:30Z","git_url":"git://github.com/wesm/feather.git","ssh_url":"git@github.com:wesm/feather.git","clone_url":"https://github.com/wesm/feather.git","svn_url":"https://github.com/wesm/feather","homepage":"","size":330,"stargazers_count":479,"watchers_count":479,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":38,"forks":25,"open_issues":38,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wesm/feather/pulls/82"},"html":{"href":"https://github.com/wesm/feather/pull/82"},"issue":{"href":"https://api.github.com/repos/wesm/feather/issues/82"},"comments":{"href":"https://api.github.com/repos/wesm/feather/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/wesm/feather/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/wesm/feather/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wesm/feather/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/wesm/feather/statuses/be57c9ff15bcb23e4da6b6718b58724a1ac02de0"}}}}