{"action":"created","comment":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/72685988","id":72685988,"diff_hunk":"@@ -158,8 +157,8 @@ def _provoke_commitlog_failure(self):\n \n         self._change_commitlog_perms(0)\n \n-        with open(os.devnull, 'w') as devnull:\n-            self.node1.stress(['write', 'n=1M', 'no-warmup', '-col', 'size=FIXED(1000)', '-rate', 'threads=25'], stdout=devnull, stderr=subprocess.STDOUT)\n+        p = self.node1.stress_process(['write', 'n=1M', 'no-warmup', '-col', 'size=FIXED(1000)', '-rate', 'threads=25'])","path":"commitlog_test.py","position":14,"original_position":14,"commit_id":"58365814798de6ac35137d601bf4ba2e5301b0fd","original_commit_id":"9992ee1ff26c26c1ca37b7a47c4018905d4cbdb3","user":{"login":"smccarthy788","id":6601281,"avatar_url":"https://avatars.githubusercontent.com/u/6601281?v=3","gravatar_id":"","url":"https://api.github.com/users/smccarthy788","html_url":"https://github.com/smccarthy788","followers_url":"https://api.github.com/users/smccarthy788/followers","following_url":"https://api.github.com/users/smccarthy788/following{/other_user}","gists_url":"https://api.github.com/users/smccarthy788/gists{/gist_id}","starred_url":"https://api.github.com/users/smccarthy788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smccarthy788/subscriptions","organizations_url":"https://api.github.com/users/smccarthy788/orgs","repos_url":"https://api.github.com/users/smccarthy788/repos","events_url":"https://api.github.com/users/smccarthy788/events{/privacy}","received_events_url":"https://api.github.com/users/smccarthy788/received_events","type":"User","site_admin":false},"body":"The change was prompted by failure [1](https://cassci.datastax.com/job/ptnapoleon-trunk-dtest/7/testReport/commitlog_test/TestCommitLog/ignore_failure_policy_test/), [2](https://cassci.datastax.com/job/ptnapoleon-trunk-dtest/7/testReport/commitlog_test/TestCommitLog/stop_failure_policy_test/), [3](https://cassci.datastax.com/job/ptnapoleon-trunk-dtest/7/testReport/commitlog_test/TestCommitLog/die_failure_policy_test/), and [4](https://cassci.datastax.com/job/ptnapoleon-trunk-dtest/7/testReport/commitlog_test/TestCommitLog/stop_commit_failure_policy_test/), which are all the same failure really.\r\n\r\nThe tests using `_provoke_commitlog_failure` want some kind of failure to happen, and check for this failure by grepping a node's log for specific messages. We ignore output from `stress` by routing it to `devnull`, and print `stress`'s errors to stdout.\r\n\r\nWith the new API we were checking to see if `stress` ran into any failures, and raising a `ToolError` when it did. Since the tests grep the logs for errors, I  used `stress_process` to just skip error checking, since we check for the specific error later.","created_at":"2016-07-28T19:25:33Z","updated_at":"2016-07-28T19:25:33Z","html_url":"https://github.com/riptano/cassandra-dtest/pull/1147#discussion_r72685988","pull_request_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147","_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/72685988"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/1147#discussion_r72685988"},"pull_request":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147"}}},"pull_request":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147","id":79100605,"html_url":"https://github.com/riptano/cassandra-dtest/pull/1147","diff_url":"https://github.com/riptano/cassandra-dtest/pull/1147.diff","patch_url":"https://github.com/riptano/cassandra-dtest/pull/1147.patch","issue_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1147","number":1147,"state":"open","locked":false,"title":"Cstar 97","user":{"login":"smccarthy788","id":6601281,"avatar_url":"https://avatars.githubusercontent.com/u/6601281?v=3","gravatar_id":"","url":"https://api.github.com/users/smccarthy788","html_url":"https://github.com/smccarthy788","followers_url":"https://api.github.com/users/smccarthy788/followers","following_url":"https://api.github.com/users/smccarthy788/following{/other_user}","gists_url":"https://api.github.com/users/smccarthy788/gists{/gist_id}","starred_url":"https://api.github.com/users/smccarthy788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smccarthy788/subscriptions","organizations_url":"https://api.github.com/users/smccarthy788/orgs","repos_url":"https://api.github.com/users/smccarthy788/repos","events_url":"https://api.github.com/users/smccarthy788/events{/privacy}","received_events_url":"https://api.github.com/users/smccarthy788/received_events","type":"User","site_admin":false},"body":"@mambocab, for your review.\r\n\r\nIn conjunction with https://github.com/pcmanus/ccm/pull/510\r\n\r\nCI run here: https://cassci.datastax.com/job/ptnapoleon-trunk-dtest/8/testReport/","created_at":"2016-07-27T21:24:56Z","updated_at":"2016-07-28T19:25:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7802b90186a4a2cd3bc8c3de22f1a4f3f37df71","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147/commits","review_comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147/comments","review_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1147/comments","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/58365814798de6ac35137d601bf4ba2e5301b0fd","head":{"label":"riptano:cstar-97","ref":"cstar-97","sha":"58365814798de6ac35137d601bf4ba2e5301b0fd","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/riptano/cassandra-dtest/deployments","created_at":"2011-10-30T11:15:44Z","updated_at":"2016-05-18T15:27:32Z","pushed_at":"2016-07-28T19:12:30Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":17214,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":55,"forks":65,"open_issues":55,"watchers":77,"default_branch":"master"}},"base":{"label":"riptano:master","ref":"master","sha":"4670c9832aff157c50bd5a6fcc1e731388318610","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/riptano/cassandra-dtest/deployments","created_at":"2011-10-30T11:15:44Z","updated_at":"2016-05-18T15:27:32Z","pushed_at":"2016-07-28T19:12:30Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":17214,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":55,"forks":65,"open_issues":55,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/1147"},"issue":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1147"},"comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1147/comments"},"review_comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147/comments"},"review_comment":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1147/commits"},"statuses":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/58365814798de6ac35137d601bf4ba2e5301b0fd"}}}}
{"actor":{"display_login":"smccarthy788"}}