{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/85720444","pull_request_review_id":6411703,"id":85720444,"diff_hunk":"@@ -63,7 +63,7 @@\n </li>\n \n </li>\n-{% if addon.current_version %}\n+{% if addon.is_listed and addon.current_version %}","path":"src/olympia/devhub/templates/devhub/includes/addon_details.html","position":5,"original_position":5,"commit_id":"6ee8e89599c1b1b6b2d637da43d195c327967323","original_commit_id":"6ee8e89599c1b1b6b2d637da43d195c327967323","user":{"login":"eviljeff","id":768592,"avatar_url":"https://avatars.githubusercontent.com/u/768592?v=3","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false},"body":"temporary fix I assume.","created_at":"2016-10-31T11:18:06Z","updated_at":"2016-10-31T11:18:06Z","html_url":"https://github.com/mozilla/addons-server/pull/3892#discussion_r85720444","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3892","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/85720444"},"html":{"href":"https://github.com/mozilla/addons-server/pull/3892#discussion_r85720444"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3892"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/3892","id":91403291,"html_url":"https://github.com/mozilla/addons-server/pull/3892","diff_url":"https://github.com/mozilla/addons-server/pull/3892.diff","patch_url":"https://github.com/mozilla/addons-server/pull/3892.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/3892","number":3892,"state":"open","locked":false,"title":"[WIP] Only use Addon.current_version for listed add-ons","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"This is a prerequisite to #3847. Since the idea of #3847 is the make `current_version` only return listed versions, this PR aims to change all code that expect `current_version` to work in unlisted situations.\n\nIt's a WIP, don't merge yet, but I'd like comments on it. The following will be changed before merging:\n- The exception thrown in `current_version` if `addon.is_listed` is `False`. I'll remove that completely when merging, and in the next PR I'll make `update_versions()` only consider listed versions.\n- Some of the checks on `addon.is_listed` where `current_version` is used will be simply changed to checking if `current_version` exists. I just wanted to make sure the maximum number of tests were passing.\n- The API exposes `current_version` so a decision will need to be made here. See https://github.com/mozilla/addons-server/issues/3847#issuecomment-255747523\n","created_at":"2016-10-28T15:35:35Z","updated_at":"2016-10-31T12:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"165c08d6f8260290ab06ae4683b3de960c8df6e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3892/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/3892/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/3892/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/6ee8e89599c1b1b6b2d637da43d195c327967323","head":{"label":"diox:make-current-version-for-listed-only","ref":"make-current-version-for-listed-only","sha":"6ee8e89599c1b1b6b2d637da43d195c327967323","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":16844921,"name":"olympia","full_name":"diox/olympia","owner":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/diox/olympia","forks_url":"https://api.github.com/repos/diox/olympia/forks","keys_url":"https://api.github.com/repos/diox/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/olympia/teams","hooks_url":"https://api.github.com/repos/diox/olympia/hooks","issue_events_url":"https://api.github.com/repos/diox/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/diox/olympia/events","assignees_url":"https://api.github.com/repos/diox/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/diox/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/diox/olympia/tags","blobs_url":"https://api.github.com/repos/diox/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/olympia/languages","stargazers_url":"https://api.github.com/repos/diox/olympia/stargazers","contributors_url":"https://api.github.com/repos/diox/olympia/contributors","subscribers_url":"https://api.github.com/repos/diox/olympia/subscribers","subscription_url":"https://api.github.com/repos/diox/olympia/subscription","commits_url":"https://api.github.com/repos/diox/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/diox/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/diox/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/olympia/merges","archive_url":"https://api.github.com/repos/diox/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/olympia/downloads","issues_url":"https://api.github.com/repos/diox/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/diox/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/olympia/labels{/name}","releases_url":"https://api.github.com/repos/diox/olympia/releases{/id}","deployments_url":"https://api.github.com/repos/diox/olympia/deployments","created_at":"2014-02-14T17:54:49Z","updated_at":"2014-12-16T18:15:35Z","pushed_at":"2016-10-28T14:38:49Z","git_url":"git://github.com/diox/olympia.git","ssh_url":"git@github.com:diox/olympia.git","clone_url":"https://github.com/diox/olympia.git","svn_url":"https://github.com/diox/olympia","homepage":"","size":657749,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"f27a6204ed1dc484394bbeaa3ada7394e5a25b5c","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-10-31T11:30:40Z","pushed_at":"2016-10-31T11:01:06Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":688403,"stargazers_count":125,"watchers_count":125,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":267,"forks":176,"open_issues":267,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3892"},"html":{"href":"https://github.com/mozilla/addons-server/pull/3892"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/3892"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/3892/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3892/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/3892/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/6ee8e89599c1b1b6b2d637da43d195c327967323"}}}}
{"actor":{"display_login":"eviljeff"}}