{"action":"created","issue":{"url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/15","labels_url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/15/comments","events_url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/15/events","html_url":"https://github.com/nfarina/homebridge-sonos/pull/15","id":128401602,"number":15,"title":"Enhancements 0.0.4","user":{"login":"fwboettger","id":16499484,"avatar_url":"https://avatars.githubusercontent.com/u/16499484?v=3","gravatar_id":"","url":"https://api.github.com/users/fwboettger","html_url":"https://github.com/fwboettger","followers_url":"https://api.github.com/users/fwboettger/followers","following_url":"https://api.github.com/users/fwboettger/following{/other_user}","gists_url":"https://api.github.com/users/fwboettger/gists{/gist_id}","starred_url":"https://api.github.com/users/fwboettger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwboettger/subscriptions","organizations_url":"https://api.github.com/users/fwboettger/orgs","repos_url":"https://api.github.com/users/fwboettger/repos","events_url":"https://api.github.com/users/fwboettger/events{/privacy}","received_events_url":"https://api.github.com/users/fwboettger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-24T14:47:37Z","updated_at":"2016-01-27T23:52:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nfarina/homebridge-sonos/pulls/15","html_url":"https://github.com/nfarina/homebridge-sonos/pull/15","diff_url":"https://github.com/nfarina/homebridge-sonos/pull/15.diff","patch_url":"https://github.com/nfarina/homebridge-sonos/pull/15.patch"},"body":"Dear @nfarina - i’d like to propose this significant improvement to my prior submission (leading to version 0.0.3 and subsequently 0.0.4 with your package dependency correction - no this time didn’t include another new dependency :-)).\n\nThe changes to index.js with this Pull Request include:\n\n- Bugfixes towards asynchronous device discovery (in version 0.0.3, the asynchronous behaviour of the discovery process hadn’t been covered in all aspects, this is fixed now).\n\n- Improved the functionality to discover “coordinator” devices (the code now discovers both paired and grouped devices in all scenarios, including grouping across multiple zones)\n\n- completely new: I implemented event listening to discover dynamic topology changes\ninitiated via Group Management (creating, deleting or changing of zones/groups with Sonos’ desktop/smartphone/tablet apps) and to update the respective previously discovered “coordinator” device for each affected homebridge accessory. A change to the topology now is being handled appropriately by the plugin (previously wasn’t handled at all).\n\n\nRemaining “known issue” (further investigation required, anticipated for next pull request):\n- Group Volume Handling (multiple devices grouped together - changing the volume via homekit currently solely changes the volume of the respective discovered and registered “coordinator” device (or paired set of devices, e.g. Playbar+Sub+Play1/3’s in a 5.1 setup), however doesn’t simultaneously adjust the volume of the complete group if this is beyond zones (called group volume by the sonos community i believe). Requires the implementation of a specific “volume characteristic functionality” in order to reflect the “group volume” experience similar to what one has with the Sonos Apps.  "},"comment":{"url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/comments/175915274","html_url":"https://github.com/nfarina/homebridge-sonos/pull/15#issuecomment-175915274","issue_url":"https://api.github.com/repos/nfarina/homebridge-sonos/issues/15","id":175915274,"user":{"login":"fwboettger","id":16499484,"avatar_url":"https://avatars.githubusercontent.com/u/16499484?v=3","gravatar_id":"","url":"https://api.github.com/users/fwboettger","html_url":"https://github.com/fwboettger","followers_url":"https://api.github.com/users/fwboettger/followers","following_url":"https://api.github.com/users/fwboettger/following{/other_user}","gists_url":"https://api.github.com/users/fwboettger/gists{/gist_id}","starred_url":"https://api.github.com/users/fwboettger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwboettger/subscriptions","organizations_url":"https://api.github.com/users/fwboettger/orgs","repos_url":"https://api.github.com/users/fwboettger/repos","events_url":"https://api.github.com/users/fwboettger/events{/privacy}","received_events_url":"https://api.github.com/users/fwboettger/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T23:52:06Z","updated_at":"2016-01-27T23:52:06Z","body":"@Nousemusic - thanks much for supporting with the verification! Great to hear that it's working flawlessly and stable also in your environment and now also for your \"Wohnzimmer\" connect! \r\nCould you also help to test the 'dynamic grouping' in your environment (besides the 'Wohnzimmer + Küche' group, also add/remove other groups (e.g. \"Bad + Kinderzimmer\" or similar) while HomeBridge is running, and verify that you can properly start/stop music via the homekit app for those groups respectively the individual devices both after adding and again after removing the group? Don't look into steering the volume of the group yet please (that's a known issue - only the volume of the coordinator of the group is affected, not the group volume, need to further look into this)."}}