{"action":"created","issue":{"url":"https://api.github.com/repos/chihaya/chihaya/issues/134","repository_url":"https://api.github.com/repos/chihaya/chihaya","labels_url":"https://api.github.com/repos/chihaya/chihaya/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/chihaya/chihaya/issues/134/comments","events_url":"https://api.github.com/repos/chihaya/chihaya/issues/134/events","html_url":"https://github.com/chihaya/chihaya/pull/134","id":137103603,"number":134,"title":"store: added StringStore","user":{"login":"mrd0ll4r","id":15063379,"avatar_url":"https://avatars.githubusercontent.com/u/15063379?v=3","gravatar_id":"","url":"https://api.github.com/users/mrd0ll4r","html_url":"https://github.com/mrd0ll4r","followers_url":"https://api.github.com/users/mrd0ll4r/followers","following_url":"https://api.github.com/users/mrd0ll4r/following{/other_user}","gists_url":"https://api.github.com/users/mrd0ll4r/gists{/gist_id}","starred_url":"https://api.github.com/users/mrd0ll4r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrd0ll4r/subscriptions","organizations_url":"https://api.github.com/users/mrd0ll4r/orgs","repos_url":"https://api.github.com/users/mrd0ll4r/repos","events_url":"https://api.github.com/users/mrd0ll4r/events{/privacy}","received_events_url":"https://api.github.com/users/mrd0ll4r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-28T22:19:34Z","updated_at":"2016-03-03T17:08:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chihaya/chihaya/pulls/134","html_url":"https://github.com/chihaya/chihaya/pull/134","diff_url":"https://github.com/chihaya/chihaya/pull/134.diff","patch_url":"https://github.com/chihaya/chihaya/pull/134.patch"},"body":"One step at a time, just adding the StringStore for now.\r\n\r\nI thought about adding/checking/removing not the complete string, but rather a prefix plus the data - this would allow us to have smaller locks, if that makes sense..."},"comment":{"url":"https://api.github.com/repos/chihaya/chihaya/issues/comments/191863852","html_url":"https://github.com/chihaya/chihaya/pull/134#issuecomment-191863852","issue_url":"https://api.github.com/repos/chihaya/chihaya/issues/134","id":191863852,"user":{"login":"jzelinskie","id":343539,"avatar_url":"https://avatars.githubusercontent.com/u/343539?v=3","gravatar_id":"","url":"https://api.github.com/users/jzelinskie","html_url":"https://github.com/jzelinskie","followers_url":"https://api.github.com/users/jzelinskie/followers","following_url":"https://api.github.com/users/jzelinskie/following{/other_user}","gists_url":"https://api.github.com/users/jzelinskie/gists{/gist_id}","starred_url":"https://api.github.com/users/jzelinskie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzelinskie/subscriptions","organizations_url":"https://api.github.com/users/jzelinskie/orgs","repos_url":"https://api.github.com/users/jzelinskie/repos","events_url":"https://api.github.com/users/jzelinskie/events{/privacy}","received_events_url":"https://api.github.com/users/jzelinskie/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T17:08:56Z","updated_at":"2016-03-03T17:08:56Z","body":">If we had just one parameter, we'd have to split it into prefix and string and then shard that on every lookup, put and remove/delete.\r\n\r\nThat's not necessarily true. We could just hash the whole thing and ignore the prefix from the shard perspective and simply use it for the separation of namespaces. However, you're suggesting something like `map[prefix]map[string]struct{}`?"}}