{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/73559757","id":73559757,"diff_hunk":"@@ -55,11 +59,19 @@ var (\n \n \tcmdUpdate       = kingpin.Command(CmdUpdate, \"Update a daemon set.\")\n \tupdateID        = cmdUpdate.Arg(\"id\", \"The uuid for the daemon set\").Required().String()\n-\tupdateAZ        = cmdUpdate.Flag(\"az\", \"The availability zone of the pod cluster\").String()\n+\tupdateSelector  = cmdUpdate.Flag(\"selector\", \"The node selector, uses the same syntax as the test-selector command\").Default(SelectorNotSpecified).String()","path":"bin/p2-dsctl/main.go","position":46,"original_position":46,"commit_id":"934340008e6a68ba1d87033b73e6e0d949836c37","original_commit_id":"934340008e6a68ba1d87033b73e6e0d949836c37","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"I think it would be awkward to express an empty string as an arg anyway, maybe we make a `--everywhere` flag and disallow empty selector?","created_at":"2016-08-04T16:51:01Z","updated_at":"2016-08-04T16:51:01Z","html_url":"https://github.com/square/p2/pull/577#discussion_r73559757","pull_request_url":"https://api.github.com/repos/square/p2/pulls/577","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/73559757"},"html":{"href":"https://github.com/square/p2/pull/577#discussion_r73559757"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/577","id":79839997,"html_url":"https://github.com/square/p2/pull/577","diff_url":"https://github.com/square/p2/pull/577.diff","patch_url":"https://github.com/square/p2/pull/577.patch","issue_url":"https://api.github.com/repos/square/p2/issues/577","number":577,"state":"open","locked":false,"title":"Remove the old dsctl's availability zone with a raw selector","user":{"login":"KoishiKomeiji","id":5440350,"avatar_url":"https://avatars.githubusercontent.com/u/5440350?v=3","gravatar_id":"","url":"https://api.github.com/users/KoishiKomeiji","html_url":"https://github.com/KoishiKomeiji","followers_url":"https://api.github.com/users/KoishiKomeiji/followers","following_url":"https://api.github.com/users/KoishiKomeiji/following{/other_user}","gists_url":"https://api.github.com/users/KoishiKomeiji/gists{/gist_id}","starred_url":"https://api.github.com/users/KoishiKomeiji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoishiKomeiji/subscriptions","organizations_url":"https://api.github.com/users/KoishiKomeiji/orgs","repos_url":"https://api.github.com/users/KoishiKomeiji/repos","events_url":"https://api.github.com/users/KoishiKomeiji/events{/privacy}","received_events_url":"https://api.github.com/users/KoishiKomeiji/received_events","type":"User","site_admin":false},"body":"The createAZ and updateAZ has been removed and replaced with createSelector and updateSelector.","created_at":"2016-08-03T02:39:02Z","updated_at":"2016-08-04T16:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38646c5e5634bb0b79a0c219bdbaad6932ccce48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/577/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/577/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/577/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/934340008e6a68ba1d87033b73e6e0d949836c37","head":{"label":"KoishiKomeiji:hzeng.dsctl","ref":"hzeng.dsctl","sha":"934340008e6a68ba1d87033b73e6e0d949836c37","user":{"login":"KoishiKomeiji","id":5440350,"avatar_url":"https://avatars.githubusercontent.com/u/5440350?v=3","gravatar_id":"","url":"https://api.github.com/users/KoishiKomeiji","html_url":"https://github.com/KoishiKomeiji","followers_url":"https://api.github.com/users/KoishiKomeiji/followers","following_url":"https://api.github.com/users/KoishiKomeiji/following{/other_user}","gists_url":"https://api.github.com/users/KoishiKomeiji/gists{/gist_id}","starred_url":"https://api.github.com/users/KoishiKomeiji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoishiKomeiji/subscriptions","organizations_url":"https://api.github.com/users/KoishiKomeiji/orgs","repos_url":"https://api.github.com/users/KoishiKomeiji/repos","events_url":"https://api.github.com/users/KoishiKomeiji/events{/privacy}","received_events_url":"https://api.github.com/users/KoishiKomeiji/received_events","type":"User","site_admin":false},"repo":{"id":58497089,"name":"p2","full_name":"KoishiKomeiji/p2","owner":{"login":"KoishiKomeiji","id":5440350,"avatar_url":"https://avatars.githubusercontent.com/u/5440350?v=3","gravatar_id":"","url":"https://api.github.com/users/KoishiKomeiji","html_url":"https://github.com/KoishiKomeiji","followers_url":"https://api.github.com/users/KoishiKomeiji/followers","following_url":"https://api.github.com/users/KoishiKomeiji/following{/other_user}","gists_url":"https://api.github.com/users/KoishiKomeiji/gists{/gist_id}","starred_url":"https://api.github.com/users/KoishiKomeiji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoishiKomeiji/subscriptions","organizations_url":"https://api.github.com/users/KoishiKomeiji/orgs","repos_url":"https://api.github.com/users/KoishiKomeiji/repos","events_url":"https://api.github.com/users/KoishiKomeiji/events{/privacy}","received_events_url":"https://api.github.com/users/KoishiKomeiji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KoishiKomeiji/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/KoishiKomeiji/p2","forks_url":"https://api.github.com/repos/KoishiKomeiji/p2/forks","keys_url":"https://api.github.com/repos/KoishiKomeiji/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KoishiKomeiji/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KoishiKomeiji/p2/teams","hooks_url":"https://api.github.com/repos/KoishiKomeiji/p2/hooks","issue_events_url":"https://api.github.com/repos/KoishiKomeiji/p2/issues/events{/number}","events_url":"https://api.github.com/repos/KoishiKomeiji/p2/events","assignees_url":"https://api.github.com/repos/KoishiKomeiji/p2/assignees{/user}","branches_url":"https://api.github.com/repos/KoishiKomeiji/p2/branches{/branch}","tags_url":"https://api.github.com/repos/KoishiKomeiji/p2/tags","blobs_url":"https://api.github.com/repos/KoishiKomeiji/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KoishiKomeiji/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KoishiKomeiji/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/KoishiKomeiji/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KoishiKomeiji/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/KoishiKomeiji/p2/languages","stargazers_url":"https://api.github.com/repos/KoishiKomeiji/p2/stargazers","contributors_url":"https://api.github.com/repos/KoishiKomeiji/p2/contributors","subscribers_url":"https://api.github.com/repos/KoishiKomeiji/p2/subscribers","subscription_url":"https://api.github.com/repos/KoishiKomeiji/p2/subscription","commits_url":"https://api.github.com/repos/KoishiKomeiji/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/KoishiKomeiji/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/KoishiKomeiji/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/KoishiKomeiji/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/KoishiKomeiji/p2/contents/{+path}","compare_url":"https://api.github.com/repos/KoishiKomeiji/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KoishiKomeiji/p2/merges","archive_url":"https://api.github.com/repos/KoishiKomeiji/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KoishiKomeiji/p2/downloads","issues_url":"https://api.github.com/repos/KoishiKomeiji/p2/issues{/number}","pulls_url":"https://api.github.com/repos/KoishiKomeiji/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/KoishiKomeiji/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/KoishiKomeiji/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KoishiKomeiji/p2/labels{/name}","releases_url":"https://api.github.com/repos/KoishiKomeiji/p2/releases{/id}","deployments_url":"https://api.github.com/repos/KoishiKomeiji/p2/deployments","created_at":"2016-05-10T22:21:47Z","updated_at":"2016-05-10T22:21:49Z","pushed_at":"2016-08-03T23:41:43Z","git_url":"git://github.com/KoishiKomeiji/p2.git","ssh_url":"git@github.com:KoishiKomeiji/p2.git","clone_url":"https://github.com/KoishiKomeiji/p2.git","svn_url":"https://github.com/KoishiKomeiji/p2","homepage":"","size":40858,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"4ea5a00144bf4e7f4f8e7bc525080144b688a1d4","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","deployments_url":"https://api.github.com/repos/square/p2/deployments","created_at":"2014-10-16T20:31:12Z","updated_at":"2016-08-04T01:57:20Z","pushed_at":"2016-08-04T15:50:10Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":41274,"stargazers_count":119,"watchers_count":119,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/577"},"html":{"href":"https://github.com/square/p2/pull/577"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/577"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/934340008e6a68ba1d87033b73e6e0d949836c37"}}}}
{"actor":{"display_login":"mpuncel"}}