{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1823","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1823/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1823/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1823/events","html_url":"https://github.com/Microsoft/ChakraCore/pull/1823","id":185156956,"number":1823,"title":"Add out of bound error for wasm array access in interpreter","user":{"login":"meg-gupta","id":20177294,"avatar_url":"https://avatars.githubusercontent.com/u/20177294?v=3","gravatar_id":"","url":"https://api.github.com/users/meg-gupta","html_url":"https://github.com/meg-gupta","followers_url":"https://api.github.com/users/meg-gupta/followers","following_url":"https://api.github.com/users/meg-gupta/following{/other_user}","gists_url":"https://api.github.com/users/meg-gupta/gists{/gist_id}","starred_url":"https://api.github.com/users/meg-gupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meg-gupta/subscriptions","organizations_url":"https://api.github.com/users/meg-gupta/orgs","repos_url":"https://api.github.com/users/meg-gupta/repos","events_url":"https://api.github.com/users/meg-gupta/events{/privacy}","received_events_url":"https://api.github.com/users/meg-gupta/received_events","type":"User","site_admin":false},"labels":[{"id":307793006,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false},{"id":335915083,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/WebAssembly","name":"WebAssembly","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-10-25T15:46:47Z","updated_at":"2016-10-29T03:06:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1823","html_url":"https://github.com/Microsoft/ChakraCore/pull/1823","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1823.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1823.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/257067268","html_url":"https://github.com/Microsoft/ChakraCore/pull/1823#issuecomment-257067268","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1823","id":257067268,"user":{"login":"Cellule","id":4157103,"avatar_url":"https://avatars.githubusercontent.com/u/4157103?v=3","gravatar_id":"","url":"https://api.github.com/users/Cellule","html_url":"https://github.com/Cellule","followers_url":"https://api.github.com/users/Cellule/followers","following_url":"https://api.github.com/users/Cellule/following{/other_user}","gists_url":"https://api.github.com/users/Cellule/gists{/gist_id}","starred_url":"https://api.github.com/users/Cellule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cellule/subscriptions","organizations_url":"https://api.github.com/users/Cellule/orgs","repos_url":"https://api.github.com/users/Cellule/repos","events_url":"https://api.github.com/users/Cellule/events{/privacy}","received_events_url":"https://api.github.com/users/Cellule/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T03:06:45Z","updated_at":"2016-10-29T03:06:45Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.\n\n---\n\n*[lib/Runtime/Language/InterpreterStackFrame.cpp, line 8365 at r4](https://reviewable.io:443/reviews/microsoft/chakracore/1823#-KVCW_nY-4pYhKUM8wvN:-KVDOIcRVmk-2F1C0fid:bqdzzht) ([raw file](https://github.com/microsoft/chakracore/blob/e00165d45c8acebefed5e62899ccbc55d8b02bc3/lib/Runtime/Language/InterpreterStackFrame.cpp#L8365)):*\n<details><summary><i>Previously, MikeHolman (Michael Holman) wrote…</i></summary>\n> Eh, maybe I'm wrong. I guess we need to consider case where that overflows uint32. (existing code doesn't work for that either though). as for length 0, we will have to check at runtime, as you can start with no memory or memory of size 0 and using grow memory or have a memory import. therefore, this needs to be a runtime check and cannot be assumed from time of bytecode gen\n</details>\nyeah you're right for length 0.\nthe current check is correct since we check first if the index >= buffer length. We know the buffer cannot reach max uint32 (we would throw out of memory way before that) so it is safe to add a small value for the second check. \nI was just hoping to avoid having 2 checks.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/microsoft/chakracore/1823)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Cellule"}}