{"action":"created","issue":{"url":"https://api.github.com/repos/git-tfs/git-tfs/issues/913","repository_url":"https://api.github.com/repos/git-tfs/git-tfs","labels_url":"https://api.github.com/repos/git-tfs/git-tfs/issues/913/labels{/name}","comments_url":"https://api.github.com/repos/git-tfs/git-tfs/issues/913/comments","events_url":"https://api.github.com/repos/git-tfs/git-tfs/issues/913/events","html_url":"https://github.com/git-tfs/git-tfs/issues/913","id":132173048,"number":913,"title":"support for TFS code-review workflow","user":{"login":"timabell","id":19378,"avatar_url":"https://avatars.githubusercontent.com/u/19378?v=3","gravatar_id":"","url":"https://api.github.com/users/timabell","html_url":"https://github.com/timabell","followers_url":"https://api.github.com/users/timabell/followers","following_url":"https://api.github.com/users/timabell/following{/other_user}","gists_url":"https://api.github.com/users/timabell/gists{/gist_id}","starred_url":"https://api.github.com/users/timabell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabell/subscriptions","organizations_url":"https://api.github.com/users/timabell/orgs","repos_url":"https://api.github.com/users/timabell/repos","events_url":"https://api.github.com/users/timabell/events{/privacy}","received_events_url":"https://api.github.com/users/timabell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-08T15:31:38Z","updated_at":"2016-02-08T15:54:19Z","closed_at":null,"body":"An extension to #908\r\n\r\nJust a wishlist thing but thought I'd write it down while it was in my head.\r\n\r\nI'm currently using git-tfs but having to put every checkin through the review process as enforced by Colin's ALM addon https://visualstudiogallery.msdn.microsoft.com/045730ee-63c0-498e-b972-42b05a2d0857\r\n\r\nIf you use Visual Studio to create a code review request then behind the scenes it creates a shelveset to use for the review. Handily you can create a review from any shelveset using Visual Studio.\r\n\r\nThe workflow I'm currently using is\r\n\r\n1. Prepare commit in git\r\n1. `git tfs shelve some-name -w=1234` to create a shelveset\r\n1. open visual studio, find the shelveset, right-click > \"request review\"\r\n1. note the id of the code-review e.g. `666`\r\n1. amend the commit adding `git-tfs-work-item: 666` to the end\r\n1. await glowing praise and a \"Finished (Looks Good)\" approval\r\n1. close the review (to keep the Colin's ALM happy)\r\n1. get latest, handle conflicts etc, rebase onto `tfs/default`\r\n1. `git tfs rcheckin`\r\n\r\nI reckon a fair bit of that could be automated by using the TFS APIs."},"comment":{"url":"https://api.github.com/repos/git-tfs/git-tfs/issues/comments/181437394","html_url":"https://github.com/git-tfs/git-tfs/issues/913#issuecomment-181437394","issue_url":"https://api.github.com/repos/git-tfs/git-tfs/issues/913","id":181437394,"user":{"login":"NathanLBCooper","id":10466530,"avatar_url":"https://avatars.githubusercontent.com/u/10466530?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanLBCooper","html_url":"https://github.com/NathanLBCooper","followers_url":"https://api.github.com/users/NathanLBCooper/followers","following_url":"https://api.github.com/users/NathanLBCooper/following{/other_user}","gists_url":"https://api.github.com/users/NathanLBCooper/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanLBCooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanLBCooper/subscriptions","organizations_url":"https://api.github.com/users/NathanLBCooper/orgs","repos_url":"https://api.github.com/users/NathanLBCooper/repos","events_url":"https://api.github.com/users/NathanLBCooper/events{/privacy}","received_events_url":"https://api.github.com/users/NathanLBCooper/received_events","type":"User","site_admin":false},"created_at":"2016-02-08T15:54:19Z","updated_at":"2016-02-08T15:54:19Z","body":"The intermediate deliverables, as I see it. This is my personal thoughts and design prejudices of course etc etc.\r\n\r\n - Issue #908, would be nice (but not essential) to make the `-w=1234` in step two redundant for a commit with `git-tfs-work-item: 1234`\r\n - `git tfs codereview some-name-maybe?` or something like that that encapsulates the shelving and reviewing. Deleting step 3.\r\n - `codereview` amends the commit message with the id of the resulting CR `git-tfs-work-item: 666`. Deleting steps 4 and 5."}}