{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/comments/90753712","pull_request_review_id":11274084,"id":90753712,"diff_hunk":"@@ -1,79 +1,165 @@\n module View exposing (view)\n \n import Time exposing (Time)\n-import Html exposing (..)\n-import Html.Events exposing (onClick)\n-import Html.Attributes exposing (id, for, attribute, class, value)\n-import Utils exposing (timeAgo)\n-import Model exposing (Model, Record, Records, Msg(..))\n-import Form\n-import Dict\n+import Html\n+import Html.Events\n+import Html.Attributes\n+import Utils\n+import Model exposing (Model, Record, Msg(..), Sort(..))\n \n \n formatLastModified : Int -> Time -> String\n formatLastModified timestamp currentTime =\n-    timeAgo (toFloat timestamp) currentTime\n+    Utils.timeAgo (toFloat timestamp) currentTime\n \n \n-iconBtn : String -> Msg -> Html Msg\n+iconBtn : String -> Msg -> Html.Html Msg\n iconBtn icon action =\n-    button [ class \"btn btn-xs btn-default\", onClick action ]\n-        [ i [ class (\"glyphicon glyphicon-\" ++ icon) ] [] ]\n+    Html.button\n+        [ Html.Attributes.class \"btn btn-xs btn-default\"\n+        , Html.Events.onClick action\n+        ]\n+        [ Html.i [ Html.Attributes.class (\"glyphicon glyphicon-\" ++ icon) ]\n+            []\n+        ]\n \n \n-recordRow : Time -> Record -> Html Msg\n+recordRow : Time -> Record -> Html.Html Msg\n recordRow currentTime { id, title, description, last_modified } =\n-    tr []\n-        [ td [] [ text id ]\n-        , td [] [ text (Maybe.withDefault \"[empty]\" title) ]\n-        , td [] [ text (Maybe.withDefault \"[empty]\" description) ]\n-        , td [] [ text (formatLastModified last_modified currentTime) ]\n-        , td []\n+    Html.tr []\n+        [ Html.td [] [ Html.text id ]\n+        , Html.td [] [ Html.text (Maybe.withDefault \"[empty]\" title) ]\n+        , Html.td [] [ Html.text (Maybe.withDefault \"[empty]\" description) ]\n+        , Html.td [] [ Html.text (formatLastModified last_modified currentTime) ]\n+        , Html.td []","path":"examples/View.elm","position":52,"original_position":52,"commit_id":"b02458831f5f5588ee0694e24fc2e602b0331458","original_commit_id":"f6b2cbd5b43d8ca232ba9dbab3f4aa3c66de7c32","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"body":"Actually I've never encountered any Elm code prefixing the tag functions. Could this be a sign we're importing too much in this file? It would make sense to mostly have view related imports in views.","created_at":"2016-12-03T08:58:37Z","updated_at":"2016-12-03T08:58:37Z","html_url":"https://github.com/Kinto/elm-kinto/pull/21#discussion_r90753712","pull_request_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/comments/90753712"},"html":{"href":"https://github.com/Kinto/elm-kinto/pull/21#discussion_r90753712"},"pull_request":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21","id":96345668,"html_url":"https://github.com/Kinto/elm-kinto/pull/21","diff_url":"https://github.com/Kinto/elm-kinto/pull/21.diff","patch_url":"https://github.com/Kinto/elm-kinto/pull/21.patch","issue_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/21","number":21,"state":"open","locked":false,"title":"Work on the todolist example","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"To try the column sorting, check https://kinto.github.io/elm-kinto/ (click on\nthe columns headings).\n\n@n1k0 @glasserc @natim r?","created_at":"2016-12-02T20:16:35Z","updated_at":"2016-12-03T08:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"985fe06e0d1c02d4f78da15826ac9aff24f6781e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/21/comments","statuses_url":"https://api.github.com/repos/Kinto/elm-kinto/statuses/b02458831f5f5588ee0694e24fc2e602b0331458","head":{"label":"Kinto:work-on-the-todolist-example","ref":"work-on-the-todolist-example","sha":"b02458831f5f5588ee0694e24fc2e602b0331458","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":68020486,"name":"elm-kinto","full_name":"Kinto/elm-kinto","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/elm-kinto","description":"Experimenting with Elm and the Kinto API","fork":false,"url":"https://api.github.com/repos/Kinto/elm-kinto","forks_url":"https://api.github.com/repos/Kinto/elm-kinto/forks","keys_url":"https://api.github.com/repos/Kinto/elm-kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/elm-kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/elm-kinto/teams","hooks_url":"https://api.github.com/repos/Kinto/elm-kinto/hooks","issue_events_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/elm-kinto/events","assignees_url":"https://api.github.com/repos/Kinto/elm-kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/elm-kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/elm-kinto/tags","blobs_url":"https://api.github.com/repos/Kinto/elm-kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/elm-kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/elm-kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/elm-kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/elm-kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/elm-kinto/languages","stargazers_url":"https://api.github.com/repos/Kinto/elm-kinto/stargazers","contributors_url":"https://api.github.com/repos/Kinto/elm-kinto/contributors","subscribers_url":"https://api.github.com/repos/Kinto/elm-kinto/subscribers","subscription_url":"https://api.github.com/repos/Kinto/elm-kinto/subscription","commits_url":"https://api.github.com/repos/Kinto/elm-kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/elm-kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/elm-kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/elm-kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/elm-kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/elm-kinto/merges","archive_url":"https://api.github.com/repos/Kinto/elm-kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/elm-kinto/downloads","issues_url":"https://api.github.com/repos/Kinto/elm-kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/elm-kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/elm-kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/elm-kinto/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/elm-kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/elm-kinto/deployments","created_at":"2016-09-12T15:13:15Z","updated_at":"2016-12-02T16:50:22Z","pushed_at":"2016-12-03T08:48:28Z","git_url":"git://github.com/Kinto/elm-kinto.git","ssh_url":"git@github.com:Kinto/elm-kinto.git","clone_url":"https://github.com/Kinto/elm-kinto.git","svn_url":"https://github.com/Kinto/elm-kinto","homepage":"https://Kinto.github.io/elm-kinto/","size":273,"stargazers_count":3,"watchers_count":3,"language":"Elm","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"064ef50b99984cc8ec562e8a66ce74dcb799ff49","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":68020486,"name":"elm-kinto","full_name":"Kinto/elm-kinto","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/elm-kinto","description":"Experimenting with Elm and the Kinto API","fork":false,"url":"https://api.github.com/repos/Kinto/elm-kinto","forks_url":"https://api.github.com/repos/Kinto/elm-kinto/forks","keys_url":"https://api.github.com/repos/Kinto/elm-kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/elm-kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/elm-kinto/teams","hooks_url":"https://api.github.com/repos/Kinto/elm-kinto/hooks","issue_events_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/elm-kinto/events","assignees_url":"https://api.github.com/repos/Kinto/elm-kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/elm-kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/elm-kinto/tags","blobs_url":"https://api.github.com/repos/Kinto/elm-kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/elm-kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/elm-kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/elm-kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/elm-kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/elm-kinto/languages","stargazers_url":"https://api.github.com/repos/Kinto/elm-kinto/stargazers","contributors_url":"https://api.github.com/repos/Kinto/elm-kinto/contributors","subscribers_url":"https://api.github.com/repos/Kinto/elm-kinto/subscribers","subscription_url":"https://api.github.com/repos/Kinto/elm-kinto/subscription","commits_url":"https://api.github.com/repos/Kinto/elm-kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/elm-kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/elm-kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/elm-kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/elm-kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/elm-kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/elm-kinto/merges","archive_url":"https://api.github.com/repos/Kinto/elm-kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/elm-kinto/downloads","issues_url":"https://api.github.com/repos/Kinto/elm-kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/elm-kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/elm-kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/elm-kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/elm-kinto/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/elm-kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/elm-kinto/deployments","created_at":"2016-09-12T15:13:15Z","updated_at":"2016-12-02T16:50:22Z","pushed_at":"2016-12-03T08:48:28Z","git_url":"git://github.com/Kinto/elm-kinto.git","ssh_url":"git@github.com:Kinto/elm-kinto.git","clone_url":"https://github.com/Kinto/elm-kinto.git","svn_url":"https://github.com/Kinto/elm-kinto","homepage":"https://Kinto.github.io/elm-kinto/","size":273,"stargazers_count":3,"watchers_count":3,"language":"Elm","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21"},"html":{"href":"https://github.com/Kinto/elm-kinto/pull/21"},"issue":{"href":"https://api.github.com/repos/Kinto/elm-kinto/issues/21"},"comments":{"href":"https://api.github.com/repos/Kinto/elm-kinto/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/elm-kinto/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/elm-kinto/statuses/b02458831f5f5588ee0694e24fc2e602b0331458"}}}}
{"actor":{"display_login":"n1k0"}}