{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/61334418","id":61334418,"diff_hunk":"@@ -29,6 +31,18 @@ define(['okta'], function (Okta) {\n \n     initialize: function () {\n       this.enabled = true;\n+      this.listenTo(this.options.appState, 'change:isSuccessResponse',","path":"src/views/mfa-verify/PushForm.js","position":15,"original_position":15,"commit_id":"b49b58aa4854c87d3218694f280fe38fcb384c7f","original_commit_id":"b49b58aa4854c87d3218694f280fe38fcb384c7f","user":{"login":"rchild-okta","id":2889612,"avatar_url":"https://avatars.githubusercontent.com/u/2889612?v=3","gravatar_id":"","url":"https://api.github.com/users/rchild-okta","html_url":"https://github.com/rchild-okta","followers_url":"https://api.github.com/users/rchild-okta/followers","following_url":"https://api.github.com/users/rchild-okta/following{/other_user}","gists_url":"https://api.github.com/users/rchild-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/rchild-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchild-okta/subscriptions","organizations_url":"https://api.github.com/users/rchild-okta/orgs","repos_url":"https://api.github.com/users/rchild-okta/repos","events_url":"https://api.github.com/users/rchild-okta/events{/privacy}","received_events_url":"https://api.github.com/users/rchild-okta/received_events","type":"User","site_admin":false},"body":"Couple comments:\r\n- This won't work in the general case, i.e. we are hardcoding the idea that we get a SUCCESS response after the verify state (check out this diagram for state transitions: http://developer.okta.com/assets/img/auth-state-model.png)\r\n- In general if we wanted to do something on success, we'd handle it elsewhere (i.e. this view should only have knowledge about its particular authStatus)\r\n\r\nWhy not do it the way that rememberDevice does it, i.e. when the user clicks the checkbox?\r\n\r\n","created_at":"2016-04-27T20:55:53Z","updated_at":"2016-04-27T20:55:53Z","html_url":"https://github.com/okta/okta-signin-widget/pull/57#discussion_r61334418","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/61334418"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/57#discussion_r61334418"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57","id":67961532,"html_url":"https://github.com/okta/okta-signin-widget/pull/57","diff_url":"https://github.com/okta/okta-signin-widget/pull/57.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/57.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/57","number":57,"state":"open","locked":false,"title":"Okta Verify Auto Push","user":{"login":"yumingcao-okta","id":13754731,"avatar_url":"https://avatars.githubusercontent.com/u/13754731?v=3","gravatar_id":"","url":"https://api.github.com/users/yumingcao-okta","html_url":"https://github.com/yumingcao-okta","followers_url":"https://api.github.com/users/yumingcao-okta/followers","following_url":"https://api.github.com/users/yumingcao-okta/following{/other_user}","gists_url":"https://api.github.com/users/yumingcao-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/yumingcao-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumingcao-okta/subscriptions","organizations_url":"https://api.github.com/users/yumingcao-okta/orgs","repos_url":"https://api.github.com/users/yumingcao-okta/repos","events_url":"https://api.github.com/users/yumingcao-okta/events{/privacy}","received_events_url":"https://api.github.com/users/yumingcao-okta/received_events","type":"User","site_admin":false},"body":"Adding auto push checkbox to Okta Verify factor\r\n\r\n[Requirement Doc] (https://oktawiki.atlassian.net/wiki/display/PM/Theme:+Core+MFA+Invest#Theme:CoreMFAInvest-AutoPushforNewSignOnUI)\r\n[Design Doc] (https://oktawiki.atlassian.net/wiki/display/eng/Okta+Verify+Auto+Push+Design)\r\n\r\n![push](https://cloud.githubusercontent.com/assets/13754731/14834359/f648db8e-0bb8-11e6-93c4-00c983d396f7.gif)\r\n\r\nOKTA-86615\r\n\r\nNot included in this PR: consolidate trustDevice, rememberMe, and autoPush into a single cookie, wanted to collect more feedback on benefit of doing this before proceeding\r\n\r\n@rchild-okta @mauriciocastillosilva-okta @srinivasanagandla-okta @Ujjwalreddy-okta","created_at":"2016-04-26T21:29:28Z","updated_at":"2016-04-27T20:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d83f04db3e7437c1b0697ff244a25608a3882563","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/57/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/b49b58aa4854c87d3218694f280fe38fcb384c7f","head":{"label":"yumingcao-okta:hack-verify","ref":"hack-verify","sha":"b49b58aa4854c87d3218694f280fe38fcb384c7f","user":{"login":"yumingcao-okta","id":13754731,"avatar_url":"https://avatars.githubusercontent.com/u/13754731?v=3","gravatar_id":"","url":"https://api.github.com/users/yumingcao-okta","html_url":"https://github.com/yumingcao-okta","followers_url":"https://api.github.com/users/yumingcao-okta/followers","following_url":"https://api.github.com/users/yumingcao-okta/following{/other_user}","gists_url":"https://api.github.com/users/yumingcao-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/yumingcao-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumingcao-okta/subscriptions","organizations_url":"https://api.github.com/users/yumingcao-okta/orgs","repos_url":"https://api.github.com/users/yumingcao-okta/repos","events_url":"https://api.github.com/users/yumingcao-okta/events{/privacy}","received_events_url":"https://api.github.com/users/yumingcao-okta/received_events","type":"User","site_admin":false},"repo":{"id":56888207,"name":"okta-signin-widget","full_name":"yumingcao-okta/okta-signin-widget","owner":{"login":"yumingcao-okta","id":13754731,"avatar_url":"https://avatars.githubusercontent.com/u/13754731?v=3","gravatar_id":"","url":"https://api.github.com/users/yumingcao-okta","html_url":"https://github.com/yumingcao-okta","followers_url":"https://api.github.com/users/yumingcao-okta/followers","following_url":"https://api.github.com/users/yumingcao-okta/following{/other_user}","gists_url":"https://api.github.com/users/yumingcao-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/yumingcao-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumingcao-okta/subscriptions","organizations_url":"https://api.github.com/users/yumingcao-okta/orgs","repos_url":"https://api.github.com/users/yumingcao-okta/repos","events_url":"https://api.github.com/users/yumingcao-okta/events{/privacy}","received_events_url":"https://api.github.com/users/yumingcao-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yumingcao-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/yumingcao-okta/okta-signin-widget/deployments","created_at":"2016-04-22T22:14:49Z","updated_at":"2016-04-22T22:14:51Z","pushed_at":"2016-04-26T21:23:35Z","git_url":"git://github.com/yumingcao-okta/okta-signin-widget.git","ssh_url":"git@github.com:yumingcao-okta/okta-signin-widget.git","clone_url":"https://github.com/yumingcao-okta/okta-signin-widget.git","svn_url":"https://github.com/yumingcao-okta/okta-signin-widget","homepage":null,"size":2568,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"9a090ccdb6f2492b1bac37b81b00325edd978c43","user":{"login":"okta","id":362460,"avatar_url":"https://avatars.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"avatar_url":"https://avatars.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2016-04-19T23:04:21Z","pushed_at":"2016-04-27T19:50:57Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":2565,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/57"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/57"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/b49b58aa4854c87d3218694f280fe38fcb384c7f"}}}}