{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/1504","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/1504/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/1504/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/1504/events","html_url":"https://github.com/oppia/oppia/issues/1504","id":135985639,"number":1504,"title":"Upgrade version of textAngular to 1.4.5.","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oppia/oppia/labels/bug:%20minor","name":"bug: minor","color":"fef2c0"},{"url":"https://api.github.com/repos/oppia/oppia/labels/frontend/rich-text-editor","name":"frontend/rich-text-editor","color":"eeeeee"},{"url":"https://api.github.com/repos/oppia/oppia/labels/starter%20project","name":"starter project","color":"bfe5bf"},{"url":"https://api.github.com/repos/oppia/oppia/labels/TODO:%20code","name":"TODO: code","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"prasanna08","id":8678373,"avatar_url":"https://avatars.githubusercontent.com/u/8678373?v=3","gravatar_id":"","url":"https://api.github.com/users/prasanna08","html_url":"https://github.com/prasanna08","followers_url":"https://api.github.com/users/prasanna08/followers","following_url":"https://api.github.com/users/prasanna08/following{/other_user}","gists_url":"https://api.github.com/users/prasanna08/gists{/gist_id}","starred_url":"https://api.github.com/users/prasanna08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasanna08/subscriptions","organizations_url":"https://api.github.com/users/prasanna08/orgs","repos_url":"https://api.github.com/users/prasanna08/repos","events_url":"https://api.github.com/users/prasanna08/events{/privacy}","received_events_url":"https://api.github.com/users/prasanna08/received_events","type":"User","site_admin":false},"milestone":null,"comments":30,"created_at":"2016-02-24T07:48:14Z","updated_at":"2016-03-23T13:43:15Z","closed_at":null,"body":"If you go to the Oppia gallery page (or most other pages) in Chrome, and open the browser console, you'll see the following warning:\r\n\r\n```\r\n  'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach).\r\n```\r\nThis warning arises because we are using an old version of textAngular (1.3.7) which depends on an old version of Rangy, which is where this warning arises from. textAngular 1.4.0 and above [use Rangy 1.3](https://github.com/fraywing/textAngular/blob/v1.4.5/changelog.md#140-2015-05-24), which [fixes](https://github.com/timdown/rangy/commit/601b80c2bcc8f0c65bf233660f9e3bff5bbe9c18) this problem.\r\n\r\nThe aim of this issue is to upgrade the version of textAngular we are using to something greater than 1.4.0 (preferably the latest version, if it is stable). The change itself is straightforward (it involves replacing a bunch of \"1.3.7\"s with \"1.4.5\"s) but it needs to be done carefully in order to make sure that the update does not break existing RTEs, so some careful testing is needed. The [breaking changes](https://github.com/fraywing/textAngular/blob/v1.4.5/changelog.md#breaking-changes-1) introduced in v1.4.1 of textAngular also need to be addressed."},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/200348861","html_url":"https://github.com/oppia/oppia/issues/1504#issuecomment-200348861","issue_url":"https://api.github.com/repos/oppia/oppia/issues/1504","id":200348861,"user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T13:43:15Z","updated_at":"2016-03-23T13:43:15Z","body":"That sounds good! So, does that mean textAngular's version of rangy doesn't get imported if we include our own?\r\n\r\nIt does sound like a fine solution, so if it works please feel free to submit a PR.\r\n\r\n/cc @AllanYangZhou @kahkhang "}}