{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2034","repository_url":"https://api.github.com/repos/thoughtbot/paperclip","labels_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2034/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2034/comments","events_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2034/events","html_url":"https://github.com/thoughtbot/paperclip/pull/2034","id":113733986,"number":2034,"title":"Delegate #readbyte on the abstract IO adapter, and improve documentation around custom processors","user":{"login":"creature","id":244541,"avatar_url":"https://avatars.githubusercontent.com/u/244541?v=3","gravatar_id":"","url":"https://api.github.com/users/creature","html_url":"https://github.com/creature","followers_url":"https://api.github.com/users/creature/followers","following_url":"https://api.github.com/users/creature/following{/other_user}","gists_url":"https://api.github.com/users/creature/gists{/gist_id}","starred_url":"https://api.github.com/users/creature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creature/subscriptions","organizations_url":"https://api.github.com/users/creature/orgs","repos_url":"https://api.github.com/users/creature/repos","events_url":"https://api.github.com/users/creature/events{/privacy}","received_events_url":"https://api.github.com/users/creature/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-10-28T03:08:10Z","updated_at":"2016-08-03T01:14:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2034","html_url":"https://github.com/thoughtbot/paperclip/pull/2034","diff_url":"https://github.com/thoughtbot/paperclip/pull/2034.diff","patch_url":"https://github.com/thoughtbot/paperclip/pull/2034.patch"},"body":"I recently implemented a custom processor that used [the Exifr gem](https://github.com/remvee/exifr) to extract EXIF information from images uploaded to a Paperclip attachment. Exifr's processor uses `readbyte` to parse the EXIF header, so it hit errors when Paperclip's `File`-like object didn't have one. There's also a test for this delegation. \r\n\r\nI've also tidied up the README documentation for custom processors, hopefully to be more clear than before. There was some duplicated content between the \"Post Processing\" section and the \"Custom Attachment Processing\" section, and those sections were separated in the file. I've dedicated the \"Post Processing\" section to Paperclip's built in thumbnailing processors, and made \"Custom Attachment Processing\" section solely about writing & using your own custom processors. This should be a more understandable progression, as built-in functionality is discussed first & separately from extending Paperclip.\r\n\r\nI've also tidied up a couple of inaccuracies in the `Paperclip::Processor` documentation, and generally applied Strunk & White's \"Omit needless words\" principle in the areas I've touched."},"comment":{"url":"https://api.github.com/repos/thoughtbot/paperclip/issues/comments/237102085","html_url":"https://github.com/thoughtbot/paperclip/pull/2034#issuecomment-237102085","issue_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2034","id":237102085,"user":{"login":"creature","id":244541,"avatar_url":"https://avatars.githubusercontent.com/u/244541?v=3","gravatar_id":"","url":"https://api.github.com/users/creature","html_url":"https://github.com/creature","followers_url":"https://api.github.com/users/creature/followers","following_url":"https://api.github.com/users/creature/following{/other_user}","gists_url":"https://api.github.com/users/creature/gists{/gist_id}","starred_url":"https://api.github.com/users/creature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creature/subscriptions","organizations_url":"https://api.github.com/users/creature/orgs","repos_url":"https://api.github.com/users/creature/repos","events_url":"https://api.github.com/users/creature/events{/privacy}","received_events_url":"https://api.github.com/users/creature/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T01:14:45Z","updated_at":"2016-08-03T01:14:45Z","body":"@tute I've rebased this onto the master branch, squashed it down to a single commit, and included a slightly-abridged form of my PR comment as the commit message. Let me know if there's any further changes you'd like to see to this! :)"}}
{"actor":{"display_login":"creature"}}