{"action":"closed","number":3121,"pull_request":{"url":"https://api.github.com/repos/ckan/ckan/pulls/3121","id":74242153,"html_url":"https://github.com/ckan/ckan/pull/3121","diff_url":"https://github.com/ckan/ckan/pull/3121.diff","patch_url":"https://github.com/ckan/ckan/pull/3121.patch","issue_url":"https://api.github.com/repos/ckan/ckan/issues/3121","number":3121,"state":"closed","locked":false,"title":"Remove `e.message` deprecation warning when running tests","user":{"login":"brew","id":3993,"avatar_url":"https://avatars.githubusercontent.com/u/3993?v=3","gravatar_id":"","url":"https://api.github.com/users/brew","html_url":"https://github.com/brew","followers_url":"https://api.github.com/users/brew/followers","following_url":"https://api.github.com/users/brew/following{/other_user}","gists_url":"https://api.github.com/users/brew/gists{/gist_id}","starred_url":"https://api.github.com/users/brew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brew/subscriptions","organizations_url":"https://api.github.com/users/brew/orgs","repos_url":"https://api.github.com/users/brew/repos","events_url":"https://api.github.com/users/brew/events{/privacy}","received_events_url":"https://api.github.com/users/brew/received_events","type":"User","site_admin":false},"body":"There's a deprecation warning when running tests: \r\n\r\n> DeprecationWarning: BaseException.message has been deprecated as of Python 2.6\r\n  assert_true('/my/prefix/user/logout' in e.message)\r\n\r\nWhich leads to this test in [test_user.py](https://github.com/ckan/ckan/blob/811d8889bf6a49d5eb2f1a833fa26a0d45eec4f2/ckan/tests/controllers/test_user.py#L175).\r\n\r\nWe shouldn't need to follow the redirect to assert that a redirect is returned. Following the redirect returns a 404 in any case, because the test instance isn't mounted at `root_path`, and testing the resulting exception is a bit weird.\r\n\r\nThis PR removes the attempt to follow the redirect and instead tests that the appropriate url is the basis for the redirect when requesting a logout.\r\n","created_at":"2016-06-17T13:27:27Z","updated_at":"2016-06-17T15:06:48Z","closed_at":"2016-06-17T15:06:48Z","merged_at":"2016-06-17T15:06:48Z","merge_commit_sha":"9fb9f576003578674223b57cf9175cb07b27a4d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckan/ckan/pulls/3121/commits","review_comments_url":"https://api.github.com/repos/ckan/ckan/pulls/3121/comments","review_comment_url":"https://api.github.com/repos/ckan/ckan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckan/ckan/issues/3121/comments","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/3d0f8abd511d5f07f9a28c7c478a801cf5fe19fd","head":{"label":"ckan:3121-logout-test","ref":"3121-logout-test","sha":"3d0f8abd511d5f07f9a28c7c478a801cf5fe19fd","user":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"repo":{"id":2750721,"name":"ckan","full_name":"ckan/ckan","owner":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckan/ckan","description":"CKAN is an open-source DMS (data management system) for powering data hubs and data portals. CKAN makes it easy to publish, share and use data. It powers datahub.io, catalog.data.gov and data.gov.uk among many other sites.","fork":false,"url":"https://api.github.com/repos/ckan/ckan","forks_url":"https://api.github.com/repos/ckan/ckan/forks","keys_url":"https://api.github.com/repos/ckan/ckan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckan/ckan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckan/ckan/teams","hooks_url":"https://api.github.com/repos/ckan/ckan/hooks","issue_events_url":"https://api.github.com/repos/ckan/ckan/issues/events{/number}","events_url":"https://api.github.com/repos/ckan/ckan/events","assignees_url":"https://api.github.com/repos/ckan/ckan/assignees{/user}","branches_url":"https://api.github.com/repos/ckan/ckan/branches{/branch}","tags_url":"https://api.github.com/repos/ckan/ckan/tags","blobs_url":"https://api.github.com/repos/ckan/ckan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckan/ckan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckan/ckan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckan/ckan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/{sha}","languages_url":"https://api.github.com/repos/ckan/ckan/languages","stargazers_url":"https://api.github.com/repos/ckan/ckan/stargazers","contributors_url":"https://api.github.com/repos/ckan/ckan/contributors","subscribers_url":"https://api.github.com/repos/ckan/ckan/subscribers","subscription_url":"https://api.github.com/repos/ckan/ckan/subscription","commits_url":"https://api.github.com/repos/ckan/ckan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckan/ckan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckan/ckan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckan/ckan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckan/ckan/contents/{+path}","compare_url":"https://api.github.com/repos/ckan/ckan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckan/ckan/merges","archive_url":"https://api.github.com/repos/ckan/ckan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckan/ckan/downloads","issues_url":"https://api.github.com/repos/ckan/ckan/issues{/number}","pulls_url":"https://api.github.com/repos/ckan/ckan/pulls{/number}","milestones_url":"https://api.github.com/repos/ckan/ckan/milestones{/number}","notifications_url":"https://api.github.com/repos/ckan/ckan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckan/ckan/labels{/name}","releases_url":"https://api.github.com/repos/ckan/ckan/releases{/id}","deployments_url":"https://api.github.com/repos/ckan/ckan/deployments","created_at":"2011-11-10T18:42:17Z","updated_at":"2016-06-17T02:30:59Z","pushed_at":"2016-06-17T15:06:49Z","git_url":"git://github.com/ckan/ckan.git","ssh_url":"git@github.com:ckan/ckan.git","clone_url":"https://github.com/ckan/ckan.git","svn_url":"https://github.com/ckan/ckan","homepage":"http://ckan.org/","size":192705,"stargazers_count":1236,"watchers_count":1236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":696,"mirror_url":null,"open_issues_count":231,"forks":696,"open_issues":231,"watchers":1236,"default_branch":"master"}},"base":{"label":"ckan:master","ref":"master","sha":"9f59e91113a7e129bd4ce801f3fae5835d0baef4","user":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"repo":{"id":2750721,"name":"ckan","full_name":"ckan/ckan","owner":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckan/ckan","description":"CKAN is an open-source DMS (data management system) for powering data hubs and data portals. CKAN makes it easy to publish, share and use data. It powers datahub.io, catalog.data.gov and data.gov.uk among many other sites.","fork":false,"url":"https://api.github.com/repos/ckan/ckan","forks_url":"https://api.github.com/repos/ckan/ckan/forks","keys_url":"https://api.github.com/repos/ckan/ckan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckan/ckan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckan/ckan/teams","hooks_url":"https://api.github.com/repos/ckan/ckan/hooks","issue_events_url":"https://api.github.com/repos/ckan/ckan/issues/events{/number}","events_url":"https://api.github.com/repos/ckan/ckan/events","assignees_url":"https://api.github.com/repos/ckan/ckan/assignees{/user}","branches_url":"https://api.github.com/repos/ckan/ckan/branches{/branch}","tags_url":"https://api.github.com/repos/ckan/ckan/tags","blobs_url":"https://api.github.com/repos/ckan/ckan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckan/ckan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckan/ckan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckan/ckan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/{sha}","languages_url":"https://api.github.com/repos/ckan/ckan/languages","stargazers_url":"https://api.github.com/repos/ckan/ckan/stargazers","contributors_url":"https://api.github.com/repos/ckan/ckan/contributors","subscribers_url":"https://api.github.com/repos/ckan/ckan/subscribers","subscription_url":"https://api.github.com/repos/ckan/ckan/subscription","commits_url":"https://api.github.com/repos/ckan/ckan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckan/ckan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckan/ckan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckan/ckan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckan/ckan/contents/{+path}","compare_url":"https://api.github.com/repos/ckan/ckan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckan/ckan/merges","archive_url":"https://api.github.com/repos/ckan/ckan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckan/ckan/downloads","issues_url":"https://api.github.com/repos/ckan/ckan/issues{/number}","pulls_url":"https://api.github.com/repos/ckan/ckan/pulls{/number}","milestones_url":"https://api.github.com/repos/ckan/ckan/milestones{/number}","notifications_url":"https://api.github.com/repos/ckan/ckan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckan/ckan/labels{/name}","releases_url":"https://api.github.com/repos/ckan/ckan/releases{/id}","deployments_url":"https://api.github.com/repos/ckan/ckan/deployments","created_at":"2011-11-10T18:42:17Z","updated_at":"2016-06-17T02:30:59Z","pushed_at":"2016-06-17T15:06:49Z","git_url":"git://github.com/ckan/ckan.git","ssh_url":"git@github.com:ckan/ckan.git","clone_url":"https://github.com/ckan/ckan.git","svn_url":"https://github.com/ckan/ckan","homepage":"http://ckan.org/","size":192705,"stargazers_count":1236,"watchers_count":1236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":696,"mirror_url":null,"open_issues_count":231,"forks":696,"open_issues":231,"watchers":1236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckan/ckan/pulls/3121"},"html":{"href":"https://github.com/ckan/ckan/pull/3121"},"issue":{"href":"https://api.github.com/repos/ckan/ckan/issues/3121"},"comments":{"href":"https://api.github.com/repos/ckan/ckan/issues/3121/comments"},"review_comments":{"href":"https://api.github.com/repos/ckan/ckan/pulls/3121/comments"},"review_comment":{"href":"https://api.github.com/repos/ckan/ckan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckan/ckan/pulls/3121/commits"},"statuses":{"href":"https://api.github.com/repos/ckan/ckan/statuses/3d0f8abd511d5f07f9a28c7c478a801cf5fe19fd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"amercader","id":200230,"avatar_url":"https://avatars.githubusercontent.com/u/200230?v=3","gravatar_id":"","url":"https://api.github.com/users/amercader","html_url":"https://github.com/amercader","followers_url":"https://api.github.com/users/amercader/followers","following_url":"https://api.github.com/users/amercader/following{/other_user}","gists_url":"https://api.github.com/users/amercader/gists{/gist_id}","starred_url":"https://api.github.com/users/amercader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amercader/subscriptions","organizations_url":"https://api.github.com/users/amercader/orgs","repos_url":"https://api.github.com/users/amercader/repos","events_url":"https://api.github.com/users/amercader/events{/privacy}","received_events_url":"https://api.github.com/users/amercader/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":1,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"amercader"}}