{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/contacts/issues/345","repository_url":"https://api.github.com/repos/owncloud/contacts","labels_url":"https://api.github.com/repos/owncloud/contacts/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/contacts/issues/345/comments","events_url":"https://api.github.com/repos/owncloud/contacts/issues/345/events","html_url":"https://github.com/owncloud/contacts/pull/345","id":146496186,"number":345,"title":"Updated color filter to use the core function","user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars.githubusercontent.com/u/14975046?v=3","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/contacts/labels/3%20-%20to%20review","name":"3 - to review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/contacts/milestones/5","html_url":"https://github.com/owncloud/contacts/milestones/1.2","labels_url":"https://api.github.com/repos/owncloud/contacts/milestones/5/labels","id":1664792,"number":5,"title":"1.2","description":"","creator":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":33,"state":"open","created_at":"2016-03-24T21:40:55Z","updated_at":"2016-04-07T17:46:43Z","due_on":"2016-04-20T22:00:00Z","closed_at":null},"comments":26,"created_at":"2016-04-07T03:06:27Z","updated_at":"2016-04-08T12:08:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/contacts/pulls/345","html_url":"https://github.com/owncloud/contacts/pull/345","diff_url":"https://github.com/owncloud/contacts/pull/345.diff","patch_url":"https://github.com/owncloud/contacts/pull/345.patch"},"body":"All in the title! :)\r\nAfter the merging of https://github.com/owncloud/core/pull/23768, we should now use the core function:\r\n`input.toHsl()`\r\n\r\nFixes #300 #337 and ref #306.\r\n\r\ncc @IwishIcanFLighT @ionum @bohni @macmeck please test with the core function."},"comment":{"url":"https://api.github.com/repos/owncloud/contacts/issues/comments/207402395","html_url":"https://github.com/owncloud/contacts/pull/345#issuecomment-207402395","issue_url":"https://api.github.com/repos/owncloud/contacts/issues/345","id":207402395,"user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars.githubusercontent.com/u/14975046?v=3","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T12:08:32Z","updated_at":"2016-04-08T12:08:32Z","body":"@criegerde no there is a problem, the first one should have terrible colors like this: \r\n![screen](https://cloud.githubusercontent.com/assets/14975046/14383077/ef70e510-fd92-11e5-8224-9ddd959a1c57.png)\r\nAnd with the new generator:\r\n![capture d ecran_2016-04-08_14-03-32](https://cloud.githubusercontent.com/assets/14975046/14383087/fbec74bc-fd92-11e5-903c-4369cf11b0fe.png)\r\n\r\nDid you applied my commit?\r\n\r\n@jancborchardt No, this is normal, the last core update (9.0) does not include the new generator, so we're including the old color gen from core inside contacts. But we also added an alternative when core will have the last generator. Like so, we always have a matching color between core and contacts, regardless of the core version and whatever color generator the user has installed. :) "}}