{"action":"created","issue":{"url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/166","repository_url":"https://api.github.com/repos/ibab/tensorflow-wavenet","labels_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/166/comments","events_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/166/events","html_url":"https://github.com/ibab/tensorflow-wavenet/pull/166","id":185407833,"number":166,"title":"Merging AudioReader, TextReader and ImageReader","user":{"login":"Zeta36","id":17341905,"avatar_url":"https://avatars.githubusercontent.com/u/17341905?v=3","gravatar_id":"","url":"https://api.github.com/users/Zeta36","html_url":"https://github.com/Zeta36","followers_url":"https://api.github.com/users/Zeta36/followers","following_url":"https://api.github.com/users/Zeta36/following{/other_user}","gists_url":"https://api.github.com/users/Zeta36/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeta36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeta36/subscriptions","organizations_url":"https://api.github.com/users/Zeta36/orgs","repos_url":"https://api.github.com/users/Zeta36/repos","events_url":"https://api.github.com/users/Zeta36/events{/privacy}","received_events_url":"https://api.github.com/users/Zeta36/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-26T14:21:15Z","updated_at":"2016-10-26T21:00:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/166","html_url":"https://github.com/ibab/tensorflow-wavenet/pull/166","diff_url":"https://github.com/ibab/tensorflow-wavenet/pull/166.diff","patch_url":"https://github.com/ibab/tensorflow-wavenet/pull/166.patch"},"body":"As asked in #162 and in #117, I've made a merging from the AudioReader, the TextReader and the ImageReader so anybody can train and generate not only wav files but also texts and images (#117 and #129).\r\n\r\nChanges are transparent, so the only thing it has to be done is change two new parameters in the wavenet_params.json:\r\n{\r\n....\r\n    \"raw_type\": \"Audio\",\r\n    \"file_ext\": \"*.wav\"\r\n}\r\n\r\nIn this way, you can decide to train the model in texts by just copying a folder with texts and setting later the params in wavenet_params.json to:\r\n{\r\n....\r\n    \"raw_type\": \"Text\",\r\n    \"file_ext\": \"*.txt\"\r\n}\r\n\r\nFor image testing just:\r\n{\r\n....\r\n    \"raw_type\": \"Image\",\r\n    \"file_ext\": \"*.jpg\"\r\n}\r\n\r\nThe file_ext can be change to any pattern like \"*.gif\", \"*.mp3\", etc.\r\n\r\nIn the generation time the only change is that I've change the args param --wav_out_path to --file_out_path. Nothing else.\r\n\r\nI've tested everything in my machine and it's all fine. I don't know if these changes are going to pass the test cases. Anyway, I think this is a good thing for the team.\r\n\r\nSomebody could help me with this by doing two things:\r\n1) Change test case if this PR doesn't pass it due to an old test case implementation problem.\r\n2) Change the Readme file and explain a little better the new changes and how to set the two new params in wavenet_params.json.\r\n\r\nThank you!!\r\n\r\nRegards,\r\nSamu.\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/comments/256475499","html_url":"https://github.com/ibab/tensorflow-wavenet/pull/166#issuecomment-256475499","issue_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/166","id":256475499,"user":{"login":"lemonzi","id":3180006,"avatar_url":"https://avatars.githubusercontent.com/u/3180006?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonzi","html_url":"https://github.com/lemonzi","followers_url":"https://api.github.com/users/lemonzi/followers","following_url":"https://api.github.com/users/lemonzi/following{/other_user}","gists_url":"https://api.github.com/users/lemonzi/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonzi/subscriptions","organizations_url":"https://api.github.com/users/lemonzi/orgs","repos_url":"https://api.github.com/users/lemonzi/repos","events_url":"https://api.github.com/users/lemonzi/events{/privacy}","received_events_url":"https://api.github.com/users/lemonzi/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T21:00:28Z","updated_at":"2016-10-26T21:00:28Z","body":"This is great, thanks a lot! I had assumed you would have made enough changes to make a merge that supported all cases very difficult.\r\n\r\nRegarding the bug, I found this on StackOverflow: http://stackoverflow.com/questions/12172791/changes-in-import-statement-python3. So, from what people say and if I understood correctly, the safest way to proceed would be to always `import wavenet.whatever`, both in the script and in the internal code. I'm no Python expert though, and using a relative import seemed to work so far."}}
{"actor":{"display_login":"lemonzi"}}