{"action":"created","comment":{"url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/comments/85009864","pull_request_review_id":5752003,"id":85009864,"diff_hunk":"@@ -60,8 +60,9 @@ def test_ca(self):\n         ca_key = self.unit.file_contents(key_path)\n         self.assertTrue(validate_key(ca_key))\n         # Create an absolute path to the installed location of the ca.\n-        installed_path = '/usr/local/share/ca-certificates/ca.crt'\n-        installed_ca = self.unit.file_contents(installed_path)\n+        ca_crt_path = '/usr/local/share/ca-certificates/{service}.crt'.format(","path":"tests/10-deploy.py","position":6,"original_position":6,"commit_id":"6dea9a080cd6f77699fb75a0efcfab2a000394f6","original_commit_id":"6dea9a080cd6f77699fb75a0efcfab2a000394f6","user":{"login":"chuckbutler","id":246944,"avatar_url":"https://avatars.githubusercontent.com/u/246944?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckbutler","html_url":"https://github.com/chuckbutler","followers_url":"https://api.github.com/users/chuckbutler/followers","following_url":"https://api.github.com/users/chuckbutler/following{/other_user}","gists_url":"https://api.github.com/users/chuckbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckbutler/subscriptions","organizations_url":"https://api.github.com/users/chuckbutler/orgs","repos_url":"https://api.github.com/users/chuckbutler/repos","events_url":"https://api.github.com/users/chuckbutler/events{/privacy}","received_events_url":"https://api.github.com/users/chuckbutler/received_events","type":"User","site_admin":false},"body":"good catch 👍 ","created_at":"2016-10-25T21:53:59Z","updated_at":"2016-10-25T21:54:03Z","html_url":"https://github.com/juju-solutions/layer-easyrsa/pull/8#discussion_r85009864","pull_request_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/comments/85009864"},"html":{"href":"https://github.com/juju-solutions/layer-easyrsa/pull/8#discussion_r85009864"},"pull_request":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8","id":90899365,"html_url":"https://github.com/juju-solutions/layer-easyrsa/pull/8","diff_url":"https://github.com/juju-solutions/layer-easyrsa/pull/8.diff","patch_url":"https://github.com/juju-solutions/layer-easyrsa/pull/8.patch","issue_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/8","number":8,"state":"open","locked":false,"title":"Test fix","user":{"login":"mbruzek","id":6385185,"avatar_url":"https://avatars.githubusercontent.com/u/6385185?v=3","gravatar_id":"","url":"https://api.github.com/users/mbruzek","html_url":"https://github.com/mbruzek","followers_url":"https://api.github.com/users/mbruzek/followers","following_url":"https://api.github.com/users/mbruzek/following{/other_user}","gists_url":"https://api.github.com/users/mbruzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruzek/subscriptions","organizations_url":"https://api.github.com/users/mbruzek/orgs","repos_url":"https://api.github.com/users/mbruzek/repos","events_url":"https://api.github.com/users/mbruzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbruzek/received_events","type":"User","site_admin":false},"body":"The code no longer writes ca.crt it uses service names so we can co-locate services on the same system. Changing the test to look for the correct file.","created_at":"2016-10-25T21:53:23Z","updated_at":"2016-10-25T21:54:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ee3fcb65961ef6b5b62560fd5a0a8f35473b5bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8/commits","review_comments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8/comments","review_comment_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/8/comments","statuses_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/statuses/6dea9a080cd6f77699fb75a0efcfab2a000394f6","head":{"label":"juju-solutions:test-fix","ref":"test-fix","sha":"6dea9a080cd6f77699fb75a0efcfab2a000394f6","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":68664873,"name":"layer-easyrsa","full_name":"juju-solutions/layer-easyrsa","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/layer-easyrsa","description":"A Juju layer to build a charm that uses the easyrsa software.","fork":false,"url":"https://api.github.com/repos/juju-solutions/layer-easyrsa","forks_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/forks","keys_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/teams","hooks_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/events","assignees_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/tags","blobs_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/subscription","commits_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/merges","archive_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/downloads","issues_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/deployments","created_at":"2016-09-20T02:14:58Z","updated_at":"2016-10-05T23:42:34Z","pushed_at":"2016-10-25T21:53:23Z","git_url":"git://github.com/juju-solutions/layer-easyrsa.git","ssh_url":"git@github.com:juju-solutions/layer-easyrsa.git","clone_url":"https://github.com/juju-solutions/layer-easyrsa.git","svn_url":"https://github.com/juju-solutions/layer-easyrsa","homepage":null,"size":105,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"juju-solutions:master","ref":"master","sha":"70e5b1136f09d8ccdc47a56817e25cf84c8e34e4","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":68664873,"name":"layer-easyrsa","full_name":"juju-solutions/layer-easyrsa","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/layer-easyrsa","description":"A Juju layer to build a charm that uses the easyrsa software.","fork":false,"url":"https://api.github.com/repos/juju-solutions/layer-easyrsa","forks_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/forks","keys_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/teams","hooks_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/events","assignees_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/tags","blobs_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/subscription","commits_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/merges","archive_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/downloads","issues_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/layer-easyrsa/deployments","created_at":"2016-09-20T02:14:58Z","updated_at":"2016-10-05T23:42:34Z","pushed_at":"2016-10-25T21:53:23Z","git_url":"git://github.com/juju-solutions/layer-easyrsa.git","ssh_url":"git@github.com:juju-solutions/layer-easyrsa.git","clone_url":"https://github.com/juju-solutions/layer-easyrsa.git","svn_url":"https://github.com/juju-solutions/layer-easyrsa","homepage":null,"size":105,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8"},"html":{"href":"https://github.com/juju-solutions/layer-easyrsa/pull/8"},"issue":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/8"},"comments":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/juju-solutions/layer-easyrsa/statuses/6dea9a080cd6f77699fb75a0efcfab2a000394f6"}}}}
{"actor":{"display_login":"chuckbutler"}}