{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/94222955","pull_request_review_id":14753688,"id":94222955,"diff_hunk":"@@ -310,6 +310,31 @@ class CodegenContext {\n       // The UTF8String may came from UnsafeRow, otherwise clone is cheap (re-use the bytes)\n       case StringType => s\"$row.update($ordinal, $value.clone())\"\n       case udt: UserDefinedType[_] => setColumn(row, udt.sqlType, ordinal, value)\n+      case s: StructType if UnsafeRow.isMutable(s) =>\n+        val nestedRow = freshName(\"nestedRow\")\n+        val updateFields = s.zipWithIndex.map { case (field, index) =>\n+          val ev = ExprCode(\n+            code = \"\",\n+            isNull = s\"value.isNullAt($index)\",\n+            value = getValue(\"value\", field.dataType, index.toString))\n+          updateColumn(nestedRow, field.dataType, index, ev, field.nullable)\n+        }\n+        val updateFieldsCode = splitExpressions(\n+          updateFields, \"updateFields\", Seq(\"InternalRow\" -> nestedRow, \"InternalRow\" -> \"value\"))\n+        val setColumnFunc = freshName(\"setColumnFunc\")\n+        val funcCode = s\"\"\"\n+          public void $setColumnFunc(InternalRow row, InternalRow value) {\n+            if (row instanceof UnsafeRow) {\n+              ((UnsafeRow) row).setNotNullAt($ordinal);\n+              final InternalRow $nestedRow = row.getStruct($ordinal, ${s.length});\n+              $updateFieldsCode","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala","position":21,"original_position":21,"commit_id":"8a5fe253215eabc1f2686d02e4787c1fc692866f","original_commit_id":"8a5fe253215eabc1f2686d02e4787c1fc692866f","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"> In that case the value row and the nestedRow should be the same\r\n\r\nyea we should skip updating for this case.\r\n\r\n> we could just copy the bytes from value to nestedRow.\r\n\r\nwell, we can't guarantee the `value` is `UnsafeRow` and fixed-length","created_at":"2016-12-30T12:05:06Z","updated_at":"2016-12-30T12:05:06Z","html_url":"https://github.com/apache/spark/pull/16417#discussion_r94222955","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16417","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/94222955"},"html":{"href":"https://github.com/apache/spark/pull/16417#discussion_r94222955"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16417"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16417","id":99467260,"html_url":"https://github.com/apache/spark/pull/16417","diff_url":"https://github.com/apache/spark/pull/16417.diff","patch_url":"https://github.com/apache/spark/pull/16417.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16417","number":16417,"state":"open","locked":false,"title":"[SPARK-19014][SQL] support complex aggregate buffer in HashAggregateExec","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently we only support aggregate buffer with simple/primitive types for `HashAggregateExec`. Ideally the buffer type should be mutable in an unsafe row, however, logicall struct type with all fixed-length fields is also mutable.\r\n\r\nThis PR fixes this problem, and we can run whole-stage codegen for aggregate function with complex buffer type.\r\n\r\nDid a micro benchmark:\r\n```\r\nval df = spark.range(100000000).select(max(struct($\"id\")))\r\ndf.explain\r\ndf.collect\r\n```\r\n\r\nBefore this PR, the explain result is:\r\n```\r\n== Physical Plan ==\r\nSortAggregate(key=[], functions=[max(named_struct(id, id#0L))])\r\n+- Exchange SinglePartition\r\n   +- SortAggregate(key=[], functions=[partial_max(named_struct(id, id#0L))])\r\n      +- *Range (0, 100000000, step=1, splits=Some(1))\r\n```\r\nand it costs 4800 ms\r\n\r\nAfter this PR, the explain result is:\r\n```\r\n== Physical Plan ==\r\n*HashAggregate(keys=[], functions=[max(named_struct(id, id#11L))], output=[max(named_struct(NamePlaceholder(), id))#15])\r\n+- Exchange SinglePartition\r\n   +- *HashAggregate(keys=[], functions=[partial_max(named_struct(id, id#11L))], output=[max#28])\r\n      +- *Range (0, 10000000, step=1, splits=Some(1))\r\n```\r\nand it costs 1500 ms\r\n\r\n## How was this patch tested?\r\n\r\nN/A","created_at":"2016-12-27T17:34:28Z","updated_at":"2016-12-30T12:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62da7627fe70c81ce06b9a277a189bb5b25fb1de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16417/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16417/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16417/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8a5fe253215eabc1f2686d02e4787c1fc692866f","head":{"label":"cloud-fan:udaf","ref":"udaf","sha":"8a5fe253215eabc1f2686d02e4787c1fc692866f","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"repo":{"id":19689699,"name":"spark","full_name":"cloud-fan/spark","owner":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloud-fan/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/cloud-fan/spark","forks_url":"https://api.github.com/repos/cloud-fan/spark/forks","keys_url":"https://api.github.com/repos/cloud-fan/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloud-fan/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloud-fan/spark/teams","hooks_url":"https://api.github.com/repos/cloud-fan/spark/hooks","issue_events_url":"https://api.github.com/repos/cloud-fan/spark/issues/events{/number}","events_url":"https://api.github.com/repos/cloud-fan/spark/events","assignees_url":"https://api.github.com/repos/cloud-fan/spark/assignees{/user}","branches_url":"https://api.github.com/repos/cloud-fan/spark/branches{/branch}","tags_url":"https://api.github.com/repos/cloud-fan/spark/tags","blobs_url":"https://api.github.com/repos/cloud-fan/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloud-fan/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloud-fan/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloud-fan/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloud-fan/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/cloud-fan/spark/languages","stargazers_url":"https://api.github.com/repos/cloud-fan/spark/stargazers","contributors_url":"https://api.github.com/repos/cloud-fan/spark/contributors","subscribers_url":"https://api.github.com/repos/cloud-fan/spark/subscribers","subscription_url":"https://api.github.com/repos/cloud-fan/spark/subscription","commits_url":"https://api.github.com/repos/cloud-fan/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloud-fan/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloud-fan/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloud-fan/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloud-fan/spark/contents/{+path}","compare_url":"https://api.github.com/repos/cloud-fan/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloud-fan/spark/merges","archive_url":"https://api.github.com/repos/cloud-fan/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloud-fan/spark/downloads","issues_url":"https://api.github.com/repos/cloud-fan/spark/issues{/number}","pulls_url":"https://api.github.com/repos/cloud-fan/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/cloud-fan/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/cloud-fan/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloud-fan/spark/labels{/name}","releases_url":"https://api.github.com/repos/cloud-fan/spark/releases{/id}","deployments_url":"https://api.github.com/repos/cloud-fan/spark/deployments","created_at":"2014-05-12T07:32:26Z","updated_at":"2016-05-26T10:38:18Z","pushed_at":"2016-12-30T08:39:12Z","git_url":"git://github.com/cloud-fan/spark.git","ssh_url":"git@github.com:cloud-fan/spark.git","clone_url":"https://github.com/cloud-fan/spark.git","svn_url":"https://github.com/cloud-fan/spark","homepage":null,"size":254552,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d7bce3bd31ec193274718042dc017706989d7563","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-12-30T10:02:37Z","pushed_at":"2016-12-30T11:36:03Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":259815,"stargazers_count":11254,"watchers_count":11254,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10548,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":452,"forks":10548,"open_issues":452,"watchers":11254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16417"},"html":{"href":"https://github.com/apache/spark/pull/16417"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16417"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16417/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16417/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16417/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8a5fe253215eabc1f2686d02e4787c1fc692866f"}}}}
{"actor":{"display_login":"cloud-fan"}}