{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/patroni/pulls/comments/82365508","pull_request_review_id":3278474,"id":82365508,"diff_hunk":"@@ -192,9 +192,9 @@ def __init__(self, context, mktemp=True):\n     def _is_accessible(self):\n         return self._is_running()\n \n-    def stop_and_remove_work_directory(self, timeout=15):\n+    def stop(self, kill=False, timeout=15):","path":"features/environment.py","position":5,"original_position":5,"commit_id":"37d85c5df97f4a0ae7406b2b9232bf16069395f2","original_commit_id":"37d85c5df97f4a0ae7406b2b9232bf16069395f2","user":{"login":"alexeyklyukin","id":339913,"avatar_url":"https://avatars.githubusercontent.com/u/339913?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeyklyukin","html_url":"https://github.com/alexeyklyukin","followers_url":"https://api.github.com/users/alexeyklyukin/followers","following_url":"https://api.github.com/users/alexeyklyukin/following{/other_user}","gists_url":"https://api.github.com/users/alexeyklyukin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeyklyukin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeyklyukin/subscriptions","organizations_url":"https://api.github.com/users/alexeyklyukin/orgs","repos_url":"https://api.github.com/users/alexeyklyukin/repos","events_url":"https://api.github.com/users/alexeyklyukin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeyklyukin/received_events","type":"User","site_admin":false},"body":"I wonder if we should also pass kill to the AbastractController.","created_at":"2016-10-07T10:31:57Z","updated_at":"2016-10-07T10:31:57Z","html_url":"https://github.com/zalando/patroni/pull/336#discussion_r82365508","pull_request_url":"https://api.github.com/repos/zalando/patroni/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/zalando/patroni/pulls/comments/82365508"},"html":{"href":"https://github.com/zalando/patroni/pull/336#discussion_r82365508"},"pull_request":{"href":"https://api.github.com/repos/zalando/patroni/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/patroni/pulls/336","id":88408111,"html_url":"https://github.com/zalando/patroni/pull/336","diff_url":"https://github.com/zalando/patroni/pull/336.diff","patch_url":"https://github.com/zalando/patroni/pull/336.patch","issue_url":"https://api.github.com/repos/zalando/patroni/issues/336","number":336,"state":"open","locked":false,"title":"Do session/renew when update_leader is called","user":{"login":"CyberDem0n","id":3407345,"avatar_url":"https://avatars.githubusercontent.com/u/3407345?v=3","gravatar_id":"","url":"https://api.github.com/users/CyberDem0n","html_url":"https://github.com/CyberDem0n","followers_url":"https://api.github.com/users/CyberDem0n/followers","following_url":"https://api.github.com/users/CyberDem0n/following{/other_user}","gists_url":"https://api.github.com/users/CyberDem0n/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberDem0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberDem0n/subscriptions","organizations_url":"https://api.github.com/users/CyberDem0n/orgs","repos_url":"https://api.github.com/users/CyberDem0n/repos","events_url":"https://api.github.com/users/CyberDem0n/events{/privacy}","received_events_url":"https://api.github.com/users/CyberDem0n/received_events","type":"User","site_admin":false},"body":"should fix https://github.com/zalando/patroni/issues/329\r\n\r\n\r\nin addition to that make it possible to specify ttl in Consul smaller than 20 (10 seconds).","created_at":"2016-10-07T09:39:47Z","updated_at":"2016-10-07T10:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"590c2df85aab7b69995ef7ac195da50639ca95cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/patroni/pulls/336/commits","review_comments_url":"https://api.github.com/repos/zalando/patroni/pulls/336/comments","review_comment_url":"https://api.github.com/repos/zalando/patroni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/patroni/issues/336/comments","statuses_url":"https://api.github.com/repos/zalando/patroni/statuses/37d85c5df97f4a0ae7406b2b9232bf16069395f2","head":{"label":"zalando:bugfix/consul-touch-leader-race","ref":"bugfix/consul-touch-leader-race","sha":"37d85c5df97f4a0ae7406b2b9232bf16069395f2","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38744670,"name":"patroni","full_name":"zalando/patroni","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/patroni","description":"A template for PostgreSQL High Availability with ZooKeeper, etcd or Consul","fork":false,"url":"https://api.github.com/repos/zalando/patroni","forks_url":"https://api.github.com/repos/zalando/patroni/forks","keys_url":"https://api.github.com/repos/zalando/patroni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/patroni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/patroni/teams","hooks_url":"https://api.github.com/repos/zalando/patroni/hooks","issue_events_url":"https://api.github.com/repos/zalando/patroni/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/patroni/events","assignees_url":"https://api.github.com/repos/zalando/patroni/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/patroni/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/patroni/tags","blobs_url":"https://api.github.com/repos/zalando/patroni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/patroni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/patroni/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/patroni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/patroni/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/patroni/languages","stargazers_url":"https://api.github.com/repos/zalando/patroni/stargazers","contributors_url":"https://api.github.com/repos/zalando/patroni/contributors","subscribers_url":"https://api.github.com/repos/zalando/patroni/subscribers","subscription_url":"https://api.github.com/repos/zalando/patroni/subscription","commits_url":"https://api.github.com/repos/zalando/patroni/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/patroni/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/patroni/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/patroni/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/patroni/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/patroni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/patroni/merges","archive_url":"https://api.github.com/repos/zalando/patroni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/patroni/downloads","issues_url":"https://api.github.com/repos/zalando/patroni/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/patroni/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/patroni/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/patroni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/patroni/labels{/name}","releases_url":"https://api.github.com/repos/zalando/patroni/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/patroni/deployments","created_at":"2015-07-08T09:27:19Z","updated_at":"2016-10-06T20:42:56Z","pushed_at":"2016-10-07T09:39:47Z","git_url":"git://github.com/zalando/patroni.git","ssh_url":"git@github.com:zalando/patroni.git","clone_url":"https://github.com/zalando/patroni.git","svn_url":"https://github.com/zalando/patroni","homepage":"","size":2088,"stargazers_count":316,"watchers_count":316,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":36,"forks":43,"open_issues":36,"watchers":316,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"6c9a870f099173ddc342ba2b26494b51152ba40e","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38744670,"name":"patroni","full_name":"zalando/patroni","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/patroni","description":"A template for PostgreSQL High Availability with ZooKeeper, etcd or Consul","fork":false,"url":"https://api.github.com/repos/zalando/patroni","forks_url":"https://api.github.com/repos/zalando/patroni/forks","keys_url":"https://api.github.com/repos/zalando/patroni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/patroni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/patroni/teams","hooks_url":"https://api.github.com/repos/zalando/patroni/hooks","issue_events_url":"https://api.github.com/repos/zalando/patroni/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/patroni/events","assignees_url":"https://api.github.com/repos/zalando/patroni/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/patroni/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/patroni/tags","blobs_url":"https://api.github.com/repos/zalando/patroni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/patroni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/patroni/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/patroni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/patroni/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/patroni/languages","stargazers_url":"https://api.github.com/repos/zalando/patroni/stargazers","contributors_url":"https://api.github.com/repos/zalando/patroni/contributors","subscribers_url":"https://api.github.com/repos/zalando/patroni/subscribers","subscription_url":"https://api.github.com/repos/zalando/patroni/subscription","commits_url":"https://api.github.com/repos/zalando/patroni/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/patroni/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/patroni/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/patroni/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/patroni/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/patroni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/patroni/merges","archive_url":"https://api.github.com/repos/zalando/patroni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/patroni/downloads","issues_url":"https://api.github.com/repos/zalando/patroni/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/patroni/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/patroni/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/patroni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/patroni/labels{/name}","releases_url":"https://api.github.com/repos/zalando/patroni/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/patroni/deployments","created_at":"2015-07-08T09:27:19Z","updated_at":"2016-10-06T20:42:56Z","pushed_at":"2016-10-07T09:39:47Z","git_url":"git://github.com/zalando/patroni.git","ssh_url":"git@github.com:zalando/patroni.git","clone_url":"https://github.com/zalando/patroni.git","svn_url":"https://github.com/zalando/patroni","homepage":"","size":2088,"stargazers_count":316,"watchers_count":316,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":36,"forks":43,"open_issues":36,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/patroni/pulls/336"},"html":{"href":"https://github.com/zalando/patroni/pull/336"},"issue":{"href":"https://api.github.com/repos/zalando/patroni/issues/336"},"comments":{"href":"https://api.github.com/repos/zalando/patroni/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/patroni/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/patroni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/patroni/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/patroni/statuses/37d85c5df97f4a0ae7406b2b9232bf16069395f2"}}}}
{"actor":{"display_login":"alexeyklyukin"}}