{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3123","repository_url":"https://api.github.com/repos/FreeRDP/FreeRDP","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3123/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3123/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3123/events","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3123","id":133084161,"number":3123,"title":"Several fixes for keyboard type 7 (japanese)","user":{"login":"nfedera","id":670606,"avatar_url":"https://avatars.githubusercontent.com/u/670606?v=3","gravatar_id":"","url":"https://api.github.com/users/nfedera","html_url":"https://github.com/nfedera","followers_url":"https://api.github.com/users/nfedera/followers","following_url":"https://api.github.com/users/nfedera/following{/other_user}","gists_url":"https://api.github.com/users/nfedera/gists{/gist_id}","starred_url":"https://api.github.com/users/nfedera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfedera/subscriptions","organizations_url":"https://api.github.com/users/nfedera/orgs","repos_url":"https://api.github.com/users/nfedera/repos","events_url":"https://api.github.com/users/nfedera/events{/privacy}","received_events_url":"https://api.github.com/users/nfedera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-11T20:48:26Z","updated_at":"2016-02-11T21:37:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3123","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3123","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/3123.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/3123.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/183067966","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3123#issuecomment-183067966","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3123","id":183067966,"user":{"login":"nfedera","id":670606,"avatar_url":"https://avatars.githubusercontent.com/u/670606?v=3","gravatar_id":"","url":"https://api.github.com/users/nfedera","html_url":"https://github.com/nfedera","followers_url":"https://api.github.com/users/nfedera/followers","following_url":"https://api.github.com/users/nfedera/following{/other_user}","gists_url":"https://api.github.com/users/nfedera/gists{/gist_id}","starred_url":"https://api.github.com/users/nfedera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfedera/subscriptions","organizations_url":"https://api.github.com/users/nfedera/orgs","repos_url":"https://api.github.com/users/nfedera/repos","events_url":"https://api.github.com/users/nfedera/events{/privacy}","received_events_url":"https://api.github.com/users/nfedera/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T21:37:04Z","updated_at":"2016-02-11T21:37:04Z","body":"@hardening yes, and at least for freerdp based servers we should replace this VK_ crap anyway with direct mappings between the codes inside the clients' rdp input PDUs and the backend codes (like evdev). There are VK_ collisions and many scancodes don't even have any official VK_ defines because Windows generates different virtual VK_codes. \r\n\r\nA good example is the scancode 0x70 (hiragana/katakana toggle) from the Type 7 (Japanese) Keyboard: X11 has the `Hiragana_Katakana` symbol, evdev has `<HKTG>` but there is no `VK_Hiragana_Katakana`. So we have to either create an unused define or misuse on of the VK_OEM_ defines which can cause collisions.\r\n\r\n\r\n"}}