{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/91976294","pull_request_review_id":12469826,"id":91976294,"diff_hunk":"@@ -174,6 +183,52 @@ if [[ \"${DEPLOY_OA}\" == \"yes\" ]]; then\n \n   cd ${OA_DIR}/playbooks/\n \n+  #Distribute Magnum configuration files\n+  if [[ \"${DEPLOY_MAGNUM}\" == \"yes\" ]]; then\n+    cat > $OA_OVERRIDES <<'EOF'\n+# These configuration entries for Keystone configure some settings for Trusts to\n+# function properly\n+keystone_keystone_conf_overrides:\n+  resource:\n+    admin_project_name: '{{ keystone_admin_tenant_name }}'\n+    admin_project_domain_name: default\n+# This change to the Heat Policy configuration file allows Magnum to list all\n+# stacks, regardless of owner.  This does NOT allow Magnum to have Write access\n+heat_policy_overrides:\n+  \"stacks:global_index\": \"role:admin\"\n+# This configures Magnum to use the MySQL/Galera database to store certificates\n+magnum_config_overrides:\n+  certificates:\n+    cert_manager_type: x509keypair\n+# TODO(chris_hultin):\n+# Remove this line upon transition to Newton\n+ansible_service_mgr: \"upstart\"\n+EOF\n+    cp $OA_DIR/playbooks/roles/os_magnum/extras/env.d/magnum.yml /etc/openstack_deploy/env.d/\n+    cat $OA_DIR/playbooks/roles/os_magnum/extras/haproxy_magnum.yml >> $OA_DIR/playbooks/vars/configs/haproxy_config.yml","path":"scripts/deploy.sh","position":56,"original_position":56,"commit_id":"5fd61ba68c1c3a81a44963e2f8fc02156136821e","original_commit_id":"5fd61ba68c1c3a81a44963e2f8fc02156136821e","user":{"login":"alextricity25","id":4964964,"avatar_url":"https://avatars.githubusercontent.com/u/4964964?v=3","gravatar_id":"","url":"https://api.github.com/users/alextricity25","html_url":"https://github.com/alextricity25","followers_url":"https://api.github.com/users/alextricity25/followers","following_url":"https://api.github.com/users/alextricity25/following{/other_user}","gists_url":"https://api.github.com/users/alextricity25/gists{/gist_id}","starred_url":"https://api.github.com/users/alextricity25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextricity25/subscriptions","organizations_url":"https://api.github.com/users/alextricity25/orgs","repos_url":"https://api.github.com/users/alextricity25/repos","events_url":"https://api.github.com/users/alextricity25/events{/privacy}","received_events_url":"https://api.github.com/users/alextricity25/received_events","type":"User","site_admin":false},"body":"The magnum haproxy configs can be added using the variable [``haproxy_extra_services``](https://github.com/openstack/openstack-ansible/blob/stable/mitaka/playbooks/haproxy-install.yml#L120). You could add this variable into the ``user_osa_variables_overrides.yml`` file conditionally the same way you add the keystone override configurations in line 187. ","created_at":"2016-12-12T16:01:33Z","updated_at":"2016-12-12T16:09:39Z","html_url":"https://github.com/rcbops/rpc-openstack/pull/1610#discussion_r91976294","pull_request_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/91976294"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1610#discussion_r91976294"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610"}}},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610","id":96794197,"html_url":"https://github.com/rcbops/rpc-openstack/pull/1610","diff_url":"https://github.com/rcbops/rpc-openstack/pull/1610.diff","patch_url":"https://github.com/rcbops/rpc-openstack/pull/1610.patch","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1610","number":1610,"state":"open","locked":false,"title":"Adding Magnum support to 'deploy.sh'","user":{"login":"chrishultin","id":599193,"avatar_url":"https://avatars.githubusercontent.com/u/599193?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishultin","html_url":"https://github.com/chrishultin","followers_url":"https://api.github.com/users/chrishultin/followers","following_url":"https://api.github.com/users/chrishultin/following{/other_user}","gists_url":"https://api.github.com/users/chrishultin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishultin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishultin/subscriptions","organizations_url":"https://api.github.com/users/chrishultin/orgs","repos_url":"https://api.github.com/users/chrishultin/repos","events_url":"https://api.github.com/users/chrishultin/events{/privacy}","received_events_url":"https://api.github.com/users/chrishultin/received_events","type":"User","site_admin":false},"body":"Adding Magnum support to 'deploy.sh'. This code is NOT idempotent.\r\n\r\nConnects #1574 \r\nFormerly  #1573","created_at":"2016-12-06T19:56:24Z","updated_at":"2016-12-12T16:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ffe952ce28c24c462ddc578c5a7fe90e44eb2fd","assignee":{"login":"chrishultin","id":599193,"avatar_url":"https://avatars.githubusercontent.com/u/599193?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishultin","html_url":"https://github.com/chrishultin","followers_url":"https://api.github.com/users/chrishultin/followers","following_url":"https://api.github.com/users/chrishultin/following{/other_user}","gists_url":"https://api.github.com/users/chrishultin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishultin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishultin/subscriptions","organizations_url":"https://api.github.com/users/chrishultin/orgs","repos_url":"https://api.github.com/users/chrishultin/repos","events_url":"https://api.github.com/users/chrishultin/events{/privacy}","received_events_url":"https://api.github.com/users/chrishultin/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrishultin","id":599193,"avatar_url":"https://avatars.githubusercontent.com/u/599193?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishultin","html_url":"https://github.com/chrishultin","followers_url":"https://api.github.com/users/chrishultin/followers","following_url":"https://api.github.com/users/chrishultin/following{/other_user}","gists_url":"https://api.github.com/users/chrishultin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishultin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishultin/subscriptions","organizations_url":"https://api.github.com/users/chrishultin/orgs","repos_url":"https://api.github.com/users/chrishultin/repos","events_url":"https://api.github.com/users/chrishultin/events{/privacy}","received_events_url":"https://api.github.com/users/chrishultin/received_events","type":"User","site_admin":false},{"login":"alextricity25","id":4964964,"avatar_url":"https://avatars.githubusercontent.com/u/4964964?v=3","gravatar_id":"","url":"https://api.github.com/users/alextricity25","html_url":"https://github.com/alextricity25","followers_url":"https://api.github.com/users/alextricity25/followers","following_url":"https://api.github.com/users/alextricity25/following{/other_user}","gists_url":"https://api.github.com/users/alextricity25/gists{/gist_id}","starred_url":"https://api.github.com/users/alextricity25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextricity25/subscriptions","organizations_url":"https://api.github.com/users/alextricity25/orgs","repos_url":"https://api.github.com/users/alextricity25/repos","events_url":"https://api.github.com/users/alextricity25/events{/privacy}","received_events_url":"https://api.github.com/users/alextricity25/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1610/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/5fd61ba68c1c3a81a44963e2f8fc02156136821e","head":{"label":"chrishultin:mitaka-13.1","ref":"mitaka-13.1","sha":"5fd61ba68c1c3a81a44963e2f8fc02156136821e","user":{"login":"chrishultin","id":599193,"avatar_url":"https://avatars.githubusercontent.com/u/599193?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishultin","html_url":"https://github.com/chrishultin","followers_url":"https://api.github.com/users/chrishultin/followers","following_url":"https://api.github.com/users/chrishultin/following{/other_user}","gists_url":"https://api.github.com/users/chrishultin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishultin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishultin/subscriptions","organizations_url":"https://api.github.com/users/chrishultin/orgs","repos_url":"https://api.github.com/users/chrishultin/repos","events_url":"https://api.github.com/users/chrishultin/events{/privacy}","received_events_url":"https://api.github.com/users/chrishultin/received_events","type":"User","site_admin":false},"repo":{"id":71391519,"name":"rpc-openstack","full_name":"chrishultin/rpc-openstack","owner":{"login":"chrishultin","id":599193,"avatar_url":"https://avatars.githubusercontent.com/u/599193?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishultin","html_url":"https://github.com/chrishultin","followers_url":"https://api.github.com/users/chrishultin/followers","following_url":"https://api.github.com/users/chrishultin/following{/other_user}","gists_url":"https://api.github.com/users/chrishultin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishultin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishultin/subscriptions","organizations_url":"https://api.github.com/users/chrishultin/orgs","repos_url":"https://api.github.com/users/chrishultin/repos","events_url":"https://api.github.com/users/chrishultin/events{/privacy}","received_events_url":"https://api.github.com/users/chrishultin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrishultin/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":true,"url":"https://api.github.com/repos/chrishultin/rpc-openstack","forks_url":"https://api.github.com/repos/chrishultin/rpc-openstack/forks","keys_url":"https://api.github.com/repos/chrishultin/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrishultin/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrishultin/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/chrishultin/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/chrishultin/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/chrishultin/rpc-openstack/events","assignees_url":"https://api.github.com/repos/chrishultin/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/chrishultin/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/chrishultin/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/chrishultin/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrishultin/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrishultin/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrishultin/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrishultin/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/chrishultin/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/chrishultin/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/chrishultin/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/chrishultin/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/chrishultin/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/chrishultin/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrishultin/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrishultin/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrishultin/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrishultin/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/chrishultin/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrishultin/rpc-openstack/merges","archive_url":"https://api.github.com/repos/chrishultin/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrishultin/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/chrishultin/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/chrishultin/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/chrishultin/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/chrishultin/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrishultin/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/chrishultin/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/chrishultin/rpc-openstack/deployments","created_at":"2016-10-19T19:20:59Z","updated_at":"2016-10-19T19:21:02Z","pushed_at":"2016-12-06T19:55:58Z","git_url":"git://github.com/chrishultin/rpc-openstack.git","ssh_url":"git@github.com:chrishultin/rpc-openstack.git","clone_url":"https://github.com/chrishultin/rpc-openstack.git","svn_url":"https://github.com/chrishultin/rpc-openstack","homepage":"","size":2097,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcbops:mitaka-13.1","ref":"mitaka-13.1","sha":"fd4e1bfbfe0c8e826b1b00b278bd406878a55492","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":30100099,"name":"rpc-openstack","full_name":"rcbops/rpc-openstack","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-openstack","forks_url":"https://api.github.com/repos/rcbops/rpc-openstack/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-openstack/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-openstack/deployments","created_at":"2015-01-31T02:51:12Z","updated_at":"2016-12-11T03:45:44Z","pushed_at":"2016-12-12T15:54:07Z","git_url":"git://github.com/rcbops/rpc-openstack.git","ssh_url":"git@github.com:rcbops/rpc-openstack.git","clone_url":"https://github.com/rcbops/rpc-openstack.git","svn_url":"https://github.com/rcbops/rpc-openstack","homepage":"","size":3230,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":98,"forks":57,"open_issues":98,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1610"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1610"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1610/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1610/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/5fd61ba68c1c3a81a44963e2f8fc02156136821e"}}}}
{"actor":{"display_login":"alextricity25"}}