{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8638","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8638/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8638/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8638/events","html_url":"https://github.com/ManageIQ/manageiq/pull/8638","id":154349423,"number":8638,"title":"Reportable search","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/reporting","name":"reporting","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-05-11T21:40:37Z","updated_at":"2016-05-19T14:45:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8638","html_url":"https://github.com/ManageIQ/manageiq/pull/8638","diff_url":"https://github.com/ManageIQ/manageiq/pull/8638.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/8638.patch"},"body":"8b71482d69bd46035f958456d327466c255cc578 had renamed `search_includes` to `build_search_includes` but this one was not renamed. So this could call an invalid method.\r\n\r\nI couldn't find any references to `search` but it is difficult to grep. So to play on the safe side, I fixed the reference.\r\n\r\ndidn't come up with a solution for the `eval`."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/220346658","html_url":"https://github.com/ManageIQ/manageiq/pull/8638#issuecomment-220346658","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8638","id":220346658,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T14:45:55Z","updated_at":"2016-05-19T14:45:55Z","body":"@kbrock I don't really know this code so it's really up to you whether you think this code is covered by tests, if we should deprecate existing behavior that this PR changes or just change it entirely now.  I don't really know.  If you don't know, I'd say we should be cautious.  If you know it's fine to change this, then let's do it."}}