{"action":"opened","number":266,"pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266","id":62545193,"html_url":"https://github.com/alphagov/notifications-admin/pull/266","diff_url":"https://github.com/alphagov/notifications-admin/pull/266.diff","patch_url":"https://github.com/alphagov/notifications-admin/pull/266.patch","issue_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/266","number":266,"state":"open","locked":false,"title":"Fix bugs and gripes with adding and editing templates","user":{"login":"quis","id":355079,"avatar_url":"https://avatars.githubusercontent.com/u/355079?v=3","gravatar_id":"","url":"https://api.github.com/users/quis","html_url":"https://github.com/quis","followers_url":"https://api.github.com/users/quis/followers","following_url":"https://api.github.com/users/quis/following{/other_user}","gists_url":"https://api.github.com/users/quis/gists{/gist_id}","starred_url":"https://api.github.com/users/quis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quis/subscriptions","organizations_url":"https://api.github.com/users/quis/orgs","repos_url":"https://api.github.com/users/quis/repos","events_url":"https://api.github.com/users/quis/events{/privacy}","received_events_url":"https://api.github.com/users/quis/received_events","type":"User","site_admin":false},"body":"## Remove ‘cancel’ links from edit template pages\r\n\r\nSince cancel just takes you back to the list of templates, which is accessible from the left nav, it’s only adding clutter to the page.\r\n\r\n## Reword the help text about adding placeholders\r\n\r\nIn research we’ve seen users struggle with this. Often they’d type ((Joe Bloggs)) or ((XX/XX/XXXX)) instead of a sensible name.\r\n\r\nLets see if explaining it differently helps.\r\n\r\n<img width=\"680\" alt=\"screen shot 2016-03-11 at 13 38 54\" src=\"https://cloud.githubusercontent.com/assets/355079/13703726/dbd4bc98-e78f-11e5-8460-d84a99a7e915.png\">\r\n\r\n## Fix innaccurate headings on add/edit template page\r\n\r\nThe same `.html` file is shared between adding a template and editing a template.\r\n\r\nThe page heading needs to be contextual to the URL, either ‘add’ or ‘edit’. Somewhere along the way this got lost; this commit reinstates it.\r\n\r\n## Move ‘new thing’ buttons alongside heading\r\n\r\nOn the send messages and manage team pages we have big green buttons for adding/inviting a new template or team member.\r\n\r\nOn the add template page it was at the bottom, and often got missed.\r\n\r\nOn the manage team page it was at the top, but maybe too prominent because it’s big and green.\r\n\r\nThis commit tries putting it in the top right of the page instead (except when the template page is empty, in which case it’s unchanged).\r\n\r\n<img width=\"693\" alt=\"screen shot 2016-03-11 at 11 07 01\" src=\"https://cloud.githubusercontent.com/assets/355079/13703744/02559fd6-e790-11e5-88a6-e6741bdc9454.png\">\r\n\r\n<img width=\"688\" alt=\"screen shot 2016-03-11 at 11 09 50\" src=\"https://cloud.githubusercontent.com/assets/355079/13703745/025a6f70-e790-11e5-90b5-7870c223c0b0.png\">\r\n","created_at":"2016-03-11T13:50:16Z","updated_at":"2016-03-11T13:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d1046c5067dd5b38ea8c305200fd36cb3f4574","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266/commits","review_comments_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266/comments","review_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/266/comments","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/e58eb2442c8c6ba754fcfac4b2e4c8ca2b46058f","head":{"label":"alphagov:better-placeholder-guidance","ref":"better-placeholder-guidance","sha":"e58eb2442c8c6ba754fcfac4b2e4c8ca2b46058f","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46421986,"name":"notifications-admin","full_name":"alphagov/notifications-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-admin","description":"Frontend application for notify admin","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-admin","forks_url":"https://api.github.com/repos/alphagov/notifications-admin/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-admin/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-admin/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-admin/deployments","created_at":"2015-11-18T13:55:17Z","updated_at":"2016-01-11T20:16:17Z","pushed_at":"2016-03-11T13:50:17Z","git_url":"git://github.com/alphagov/notifications-admin.git","ssh_url":"git@github.com:alphagov/notifications-admin.git","clone_url":"https://github.com/alphagov/notifications-admin.git","svn_url":"https://github.com/alphagov/notifications-admin","homepage":null,"size":1686,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f81dccc51384e34f95166f4e16c79ae2e9a77853","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46421986,"name":"notifications-admin","full_name":"alphagov/notifications-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-admin","description":"Frontend application for notify admin","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-admin","forks_url":"https://api.github.com/repos/alphagov/notifications-admin/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-admin/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-admin/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-admin/deployments","created_at":"2015-11-18T13:55:17Z","updated_at":"2016-01-11T20:16:17Z","pushed_at":"2016-03-11T13:50:17Z","git_url":"git://github.com/alphagov/notifications-admin.git","ssh_url":"git@github.com:alphagov/notifications-admin.git","clone_url":"https://github.com/alphagov/notifications-admin.git","svn_url":"https://github.com/alphagov/notifications-admin","homepage":null,"size":1686,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266"},"html":{"href":"https://github.com/alphagov/notifications-admin/pull/266"},"issue":{"href":"https://api.github.com/repos/alphagov/notifications-admin/issues/266"},"comments":{"href":"https://api.github.com/repos/alphagov/notifications-admin/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/notifications-admin/statuses/e58eb2442c8c6ba754fcfac4b2e4c8ca2b46058f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":107,"deletions":71,"changed_files":10}}