{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/87726559","pull_request_review_id":8326500,"id":87726559,"diff_hunk":"@@ -1430,6 +1437,61 @@ bool TrajectoryExecutionManager::executePart(std::size_t part_index)\n   }\n }\n \n+bool TrajectoryExecutionManager::waitForRobotToStop(const TrajectoryExecutionContext &context, double wait_time)\n+{\n+  if (allowed_start_tolerance_ == 0)  // skip validation on this magic number\n+    return true;\n+\n+  ros::WallTime start = ros::WallTime::now();\n+  double time_remaining = wait_time;\n+\n+  robot_state::RobotStatePtr prev_state, cur_state;\n+  prev_state = csm_->getCurrentState();\n+  prev_state->enforceBounds();\n+\n+  // assume robot stopped when 3 consecutive checks yield the same robot state\n+  unsigned int no_motion_count = 0;  // count iterations with no motion","path":"moveit_ros/planning/trajectory_execution_manager/src/trajectory_execution_manager.cpp","position":50,"original_position":50,"commit_id":"edc8da25ab21250a1598e19ce8a3b035ba070d5d","original_commit_id":"edc8da25ab21250a1598e19ce8a3b035ba070d5d","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"this class (and most of moveit) uses ``std::size_t`` rather than ``unsigned int``","created_at":"2016-11-14T00:22:16Z","updated_at":"2016-11-14T00:22:16Z","html_url":"https://github.com/ros-planning/moveit/pull/350#discussion_r87726559","pull_request_url":"https://api.github.com/repos/ros-planning/moveit/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/87726559"},"html":{"href":"https://github.com/ros-planning/moveit/pull/350#discussion_r87726559"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/350","id":93490880,"html_url":"https://github.com/ros-planning/moveit/pull/350","diff_url":"https://github.com/ros-planning/moveit/pull/350.diff","patch_url":"https://github.com/ros-planning/moveit/pull/350.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit/issues/350","number":350,"state":"open","locked":false,"title":"fix race conditions when updating PlanningScene","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"body":"This a new attempt to resolve #232. The core new idea is to wait until the robot has stopped moving before claiming the execution of a trajectory has finished.","created_at":"2016-11-13T22:57:00Z","updated_at":"2016-11-14T00:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b2195e08d13a1cef0a02367df00ba80381cbb8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit/pulls/350/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit/pulls/350/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit/issues/350/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/edc8da25ab21250a1598e19ce8a3b035ba070d5d","head":{"label":"rhaschke:fix-442","ref":"fix-442","sha":"edc8da25ab21250a1598e19ce8a3b035ba070d5d","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"repo":{"id":65847299,"name":"moveit","full_name":"rhaschke/moveit","owner":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhaschke/moveit","description":"The MoveIt! motion planning framework","fork":true,"url":"https://api.github.com/repos/rhaschke/moveit","forks_url":"https://api.github.com/repos/rhaschke/moveit/forks","keys_url":"https://api.github.com/repos/rhaschke/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhaschke/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhaschke/moveit/teams","hooks_url":"https://api.github.com/repos/rhaschke/moveit/hooks","issue_events_url":"https://api.github.com/repos/rhaschke/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/rhaschke/moveit/events","assignees_url":"https://api.github.com/repos/rhaschke/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/rhaschke/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/rhaschke/moveit/tags","blobs_url":"https://api.github.com/repos/rhaschke/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhaschke/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhaschke/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhaschke/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhaschke/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/rhaschke/moveit/languages","stargazers_url":"https://api.github.com/repos/rhaschke/moveit/stargazers","contributors_url":"https://api.github.com/repos/rhaschke/moveit/contributors","subscribers_url":"https://api.github.com/repos/rhaschke/moveit/subscribers","subscription_url":"https://api.github.com/repos/rhaschke/moveit/subscription","commits_url":"https://api.github.com/repos/rhaschke/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhaschke/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhaschke/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhaschke/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhaschke/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/rhaschke/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhaschke/moveit/merges","archive_url":"https://api.github.com/repos/rhaschke/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhaschke/moveit/downloads","issues_url":"https://api.github.com/repos/rhaschke/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/rhaschke/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/rhaschke/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/rhaschke/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhaschke/moveit/labels{/name}","releases_url":"https://api.github.com/repos/rhaschke/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/rhaschke/moveit/deployments","created_at":"2016-08-16T19:22:03Z","updated_at":"2016-08-16T19:22:07Z","pushed_at":"2016-11-13T22:51:42Z","git_url":"git://github.com/rhaschke/moveit.git","ssh_url":"git@github.com:rhaschke/moveit.git","clone_url":"https://github.com/rhaschke/moveit.git","svn_url":"https://github.com/rhaschke/moveit","homepage":"http://moveit.ros.org/","size":52043,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-planning:kinetic-devel","ref":"kinetic-devel","sha":"6347d348d08c68eaf9803bffe9dd08742daaab3f","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":64340188,"name":"moveit","full_name":"ros-planning/moveit","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit","description":"The MoveIt! motion planning framework","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit","forks_url":"https://api.github.com/repos/ros-planning/moveit/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit/deployments","created_at":"2016-07-27T20:38:09Z","updated_at":"2016-11-10T08:34:49Z","pushed_at":"2016-11-13T23:04:13Z","git_url":"git://github.com/ros-planning/moveit.git","ssh_url":"git@github.com:ros-planning/moveit.git","clone_url":"https://github.com/ros-planning/moveit.git","svn_url":"https://github.com/ros-planning/moveit","homepage":"http://moveit.ros.org/","size":55665,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":75,"forks":44,"open_issues":75,"watchers":39,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/350"},"html":{"href":"https://github.com/ros-planning/moveit/pull/350"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/350"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit/statuses/edc8da25ab21250a1598e19ce8a3b035ba070d5d"}}}}
{"actor":{"display_login":"davetcoleman"}}