{"action":"closed","number":2751,"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/2751","id":68703052,"html_url":"https://github.com/keystonejs/keystone/pull/2751","diff_url":"https://github.com/keystonejs/keystone/pull/2751.diff","patch_url":"https://github.com/keystonejs/keystone/pull/2751.patch","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/2751","number":2751,"state":"closed","locked":false,"title":"test(e2e): move utils functions to page object commands","user":{"login":"jstockwin","id":8227759,"avatar_url":"https://avatars.githubusercontent.com/u/8227759?v=3","gravatar_id":"","url":"https://api.github.com/users/jstockwin","html_url":"https://github.com/jstockwin","followers_url":"https://api.github.com/users/jstockwin/followers","following_url":"https://api.github.com/users/jstockwin/following{/other_user}","gists_url":"https://api.github.com/users/jstockwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jstockwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstockwin/subscriptions","organizations_url":"https://api.github.com/users/jstockwin/orgs","repos_url":"https://api.github.com/users/jstockwin/repos","events_url":"https://api.github.com/users/jstockwin/events{/privacy}","received_events_url":"https://api.github.com/users/jstockwin/received_events","type":"User","site_admin":false},"body":"cc: @webteckie \r\nFor #2291 \r\n\r\nAll functions currently in `commonFieldTestUtils` have been moved to their respective page objects as commands, aside from the `before` and `after` functions. This gives a much nicer pattern in the test files themselves, and seems more in keeping with using page objects properly. \r\n\r\nAll fields have been refactored to use this new pattern, with the exception of Boolean, Email and Number, as these are still on the old pattern which doesn't use page objects at all. \r\n\r\nFurther, the `assertUI` functions for code and select don't actually check which field you want them to carry out the assertion on, so the `Code/Select can be filled via the edit form` checks are currently commented out as they fail. \r\n\r\nThis same check for Datetime is also commented out pending a fix for #2715. \r\n\r\nCurrently haven't managed to run through the entire group of tests without firefox popping up and asking to be started in safe mode half way through, which seems to kill it. Will keep trying, and let you know when I get there, but most of them have run and nothing has failed yet. ","created_at":"2016-05-03T13:11:57Z","updated_at":"2016-05-03T14:08:54Z","closed_at":"2016-05-03T14:08:54Z","merged_at":"2016-05-03T14:08:54Z","merge_commit_sha":"1775110a02ff23dbe4e3e422d53fecc6af7eece1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2751/commits","review_comments_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2751/comments","review_comment_url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/2751/comments","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/701ecd03ae67ed76acd035afa89b0ab1fb92e585","head":{"label":"jstockwin:e2e-testing-page-object-commands","ref":"e2e-testing-page-object-commands","sha":"701ecd03ae67ed76acd035afa89b0ab1fb92e585","user":{"login":"jstockwin","id":8227759,"avatar_url":"https://avatars.githubusercontent.com/u/8227759?v=3","gravatar_id":"","url":"https://api.github.com/users/jstockwin","html_url":"https://github.com/jstockwin","followers_url":"https://api.github.com/users/jstockwin/followers","following_url":"https://api.github.com/users/jstockwin/following{/other_user}","gists_url":"https://api.github.com/users/jstockwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jstockwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstockwin/subscriptions","organizations_url":"https://api.github.com/users/jstockwin/orgs","repos_url":"https://api.github.com/users/jstockwin/repos","events_url":"https://api.github.com/users/jstockwin/events{/privacy}","received_events_url":"https://api.github.com/users/jstockwin/received_events","type":"User","site_admin":false},"repo":{"id":57129228,"name":"keystone","full_name":"jstockwin/keystone","owner":{"login":"jstockwin","id":8227759,"avatar_url":"https://avatars.githubusercontent.com/u/8227759?v=3","gravatar_id":"","url":"https://api.github.com/users/jstockwin","html_url":"https://github.com/jstockwin","followers_url":"https://api.github.com/users/jstockwin/followers","following_url":"https://api.github.com/users/jstockwin/following{/other_user}","gists_url":"https://api.github.com/users/jstockwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jstockwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstockwin/subscriptions","organizations_url":"https://api.github.com/users/jstockwin/orgs","repos_url":"https://api.github.com/users/jstockwin/repos","events_url":"https://api.github.com/users/jstockwin/events{/privacy}","received_events_url":"https://api.github.com/users/jstockwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jstockwin/keystone","description":"node.js cms and web app framework","fork":true,"url":"https://api.github.com/repos/jstockwin/keystone","forks_url":"https://api.github.com/repos/jstockwin/keystone/forks","keys_url":"https://api.github.com/repos/jstockwin/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jstockwin/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jstockwin/keystone/teams","hooks_url":"https://api.github.com/repos/jstockwin/keystone/hooks","issue_events_url":"https://api.github.com/repos/jstockwin/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/jstockwin/keystone/events","assignees_url":"https://api.github.com/repos/jstockwin/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/jstockwin/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/jstockwin/keystone/tags","blobs_url":"https://api.github.com/repos/jstockwin/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jstockwin/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jstockwin/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jstockwin/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jstockwin/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/jstockwin/keystone/languages","stargazers_url":"https://api.github.com/repos/jstockwin/keystone/stargazers","contributors_url":"https://api.github.com/repos/jstockwin/keystone/contributors","subscribers_url":"https://api.github.com/repos/jstockwin/keystone/subscribers","subscription_url":"https://api.github.com/repos/jstockwin/keystone/subscription","commits_url":"https://api.github.com/repos/jstockwin/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jstockwin/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jstockwin/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jstockwin/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jstockwin/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/jstockwin/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jstockwin/keystone/merges","archive_url":"https://api.github.com/repos/jstockwin/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jstockwin/keystone/downloads","issues_url":"https://api.github.com/repos/jstockwin/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/jstockwin/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/jstockwin/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/jstockwin/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jstockwin/keystone/labels{/name}","releases_url":"https://api.github.com/repos/jstockwin/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/jstockwin/keystone/deployments","created_at":"2016-04-26T13:12:34Z","updated_at":"2016-04-26T13:12:37Z","pushed_at":"2016-05-03T13:35:09Z","git_url":"git://github.com/jstockwin/keystone.git","ssh_url":"git@github.com:jstockwin/keystone.git","clone_url":"https://github.com/jstockwin/keystone.git","svn_url":"https://github.com/jstockwin/keystone","homepage":"http://www.keystonejs.com","size":93566,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keystonejs:master","ref":"master","sha":"7acaf5e453ff2ad4b7d16704522d949950914e9b","user":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"node.js cms and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/keystonejs/keystone/deployments","created_at":"2013-07-02T05:01:55Z","updated_at":"2016-05-03T11:01:56Z","pushed_at":"2016-05-03T14:08:54Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":102381,"stargazers_count":6289,"watchers_count":6289,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1034,"mirror_url":null,"open_issues_count":141,"forks":1034,"open_issues":141,"watchers":6289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2751"},"html":{"href":"https://github.com/keystonejs/keystone/pull/2751"},"issue":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2751"},"comments":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2751/comments"},"review_comments":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2751/comments"},"review_comment":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2751/commits"},"statuses":{"href":"https://api.github.com/repos/keystonejs/keystone/statuses/701ecd03ae67ed76acd035afa89b0ab1fb92e585"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"webteckie","id":5872515,"avatar_url":"https://avatars.githubusercontent.com/u/5872515?v=3","gravatar_id":"","url":"https://api.github.com/users/webteckie","html_url":"https://github.com/webteckie","followers_url":"https://api.github.com/users/webteckie/followers","following_url":"https://api.github.com/users/webteckie/following{/other_user}","gists_url":"https://api.github.com/users/webteckie/gists{/gist_id}","starred_url":"https://api.github.com/users/webteckie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webteckie/subscriptions","organizations_url":"https://api.github.com/users/webteckie/orgs","repos_url":"https://api.github.com/users/webteckie/repos","events_url":"https://api.github.com/users/webteckie/events{/privacy}","received_events_url":"https://api.github.com/users/webteckie/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":727,"deletions":644,"changed_files":37}}