{"action":"created","issue":{"url":"https://api.github.com/repos/jquery/qunit/issues/1043","repository_url":"https://api.github.com/repos/jquery/qunit","labels_url":"https://api.github.com/repos/jquery/qunit/issues/1043/labels{/name}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/1043/comments","events_url":"https://api.github.com/repos/jquery/qunit/issues/1043/events","html_url":"https://github.com/jquery/qunit/pull/1043","id":177609447,"number":1043,"title":"Test improvements","user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jquery/qunit/labels/CLA:%20Valid","name":"CLA: Valid","color":"007700"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-17T21:13:23Z","updated_at":"2016-09-19T20:40:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/1043","html_url":"https://github.com/jquery/qunit/pull/1043","diff_url":"https://github.com/jquery/qunit/pull/1043.diff","patch_url":"https://github.com/jquery/qunit/pull/1043.patch"},"body":"This improves some various tests. Most notably it adds tests to verify the order of execution for logging callbacks and module hooks (as raised in https://github.com/jquery/api.qunitjs.com/issues/136).\r\n\r\nWhile writing these tests, 2 questions came up:\r\n\r\n1. Should the \"done\" category of callbacks (`done`, `moduleDone`, and `testDone`) be FIFO or LIFO? I know we had a lot of discussion about a similar topic in #977.\r\n2. Should `moduleDone` fire when starting a nested module? I don't believe it should, since the parent module is not technically finished yet."},"comment":{"url":"https://api.github.com/repos/jquery/qunit/issues/comments/248119297","html_url":"https://github.com/jquery/qunit/pull/1043#issuecomment-248119297","issue_url":"https://api.github.com/repos/jquery/qunit/issues/1043","id":248119297,"user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T20:40:46Z","updated_at":"2016-09-19T20:40:46Z","body":"Okay, I think we can merge this test and follow up on improving the `moduleDone` behavior in a separate PR/issue."}}
{"actor":{"display_login":"trentmwillis"}}