{"action":"created","comment":{"url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments/55628244","id":55628244,"diff_hunk":"@@ -855,25 +859,29 @@ def setUp(self):\n \n     @tags('note')\n     def test_em_is_1000(self):\n-        \"\"\" Font em size should be 1000, but doesn't have to be \"\"\"\n-        self.assertEqual(self.font.get_upm_height(), 1000)\n+        \"\"\" Is font em size (ideally) equal to 1000? \"\"\"\n+        self.assertEqual(self.font.get_upm_height(), 1000, 'No')\n \n     @tags('required')\n     def test_font_is_font(self):\n-        \"\"\" File provided as parameter is TTF font file \"\"\"\n+        \"\"\" Is this a valid TTF file? \"\"\"\n         self.assertTrue(magic.from_file(self.operator.path, mime=True),\n                         'application/x-font-ttf')\n \n     @tags('required')\n     def test_latin_file_exists(self):\n-        \"\"\" GF requires a latin subset, so we check that font file exists \"\"\"\n+        \"\"\" GF requires a latin subset, so we check that font file exists? \"\"\"\n+        #If I recall correctly, we should not check for subsets anymore, right?\n+        #TODO: Maybe delete this test?","path":"bakery_lint/fonttests/test_ttf.py","position":395,"original_position":395,"commit_id":"c2d28a548738e86d8c99b863bc1c89b60d97d345","original_commit_id":"1ad31dff4769fc983f5369727704928af2625432","user":{"login":"davelab6","id":261579,"avatar_url":"https://avatars.githubusercontent.com/u/261579?v=3","gravatar_id":"","url":"https://api.github.com/users/davelab6","html_url":"https://github.com/davelab6","followers_url":"https://api.github.com/users/davelab6/followers","following_url":"https://api.github.com/users/davelab6/following{/other_user}","gists_url":"https://api.github.com/users/davelab6/gists{/gist_id}","starred_url":"https://api.github.com/users/davelab6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelab6/subscriptions","organizations_url":"https://api.github.com/users/davelab6/orgs","repos_url":"https://api.github.com/users/davelab6/repos","events_url":"https://api.github.com/users/davelab6/events{/privacy}","received_events_url":"https://api.github.com/users/davelab6/received_events","type":"User","site_admin":false},"body":"@felipesanches yes, we don't need any subsets any more.","created_at":"2016-03-10T02:59:35Z","updated_at":"2016-03-10T02:59:35Z","html_url":"https://github.com/googlefonts/fontbakery/pull/746#discussion_r55628244","pull_request_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746","_links":{"self":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments/55628244"},"html":{"href":"https://github.com/googlefonts/fontbakery/pull/746#discussion_r55628244"},"pull_request":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746"}}},"pull_request":{"url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746","id":62329711,"html_url":"https://github.com/googlefonts/fontbakery/pull/746","diff_url":"https://github.com/googlefonts/fontbakery/pull/746.diff","patch_url":"https://github.com/googlefonts/fontbakery/pull/746.patch","issue_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/746","number":746,"state":"open","locked":false,"title":"Issue 693  several fixes 2016mar09","user":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-10T02:19:31Z","updated_at":"2016-03-10T02:59:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0be4cf068b03cf2a998c3944e89dcad2482f2fcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746/commits","review_comments_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746/comments","review_comment_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/746/comments","statuses_url":"https://api.github.com/repos/googlefonts/fontbakery/statuses/c2d28a548738e86d8c99b863bc1c89b60d97d345","head":{"label":"felipesanches:issue_693__several_fixes_2016mar09","ref":"issue_693__several_fixes_2016mar09","sha":"c2d28a548738e86d8c99b863bc1c89b60d97d345","user":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"repo":{"id":46745560,"name":"fontbakery","full_name":"felipesanches/fontbakery","owner":{"login":"felipesanches","id":213676,"avatar_url":"https://avatars.githubusercontent.com/u/213676?v=3","gravatar_id":"","url":"https://api.github.com/users/felipesanches","html_url":"https://github.com/felipesanches","followers_url":"https://api.github.com/users/felipesanches/followers","following_url":"https://api.github.com/users/felipesanches/following{/other_user}","gists_url":"https://api.github.com/users/felipesanches/gists{/gist_id}","starred_url":"https://api.github.com/users/felipesanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipesanches/subscriptions","organizations_url":"https://api.github.com/users/felipesanches/orgs","repos_url":"https://api.github.com/users/felipesanches/repos","events_url":"https://api.github.com/users/felipesanches/events{/privacy}","received_events_url":"https://api.github.com/users/felipesanches/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felipesanches/fontbakery","description":"Tools to prepare font families for inclusion in github.com/google/fonts","fork":true,"url":"https://api.github.com/repos/felipesanches/fontbakery","forks_url":"https://api.github.com/repos/felipesanches/fontbakery/forks","keys_url":"https://api.github.com/repos/felipesanches/fontbakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felipesanches/fontbakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felipesanches/fontbakery/teams","hooks_url":"https://api.github.com/repos/felipesanches/fontbakery/hooks","issue_events_url":"https://api.github.com/repos/felipesanches/fontbakery/issues/events{/number}","events_url":"https://api.github.com/repos/felipesanches/fontbakery/events","assignees_url":"https://api.github.com/repos/felipesanches/fontbakery/assignees{/user}","branches_url":"https://api.github.com/repos/felipesanches/fontbakery/branches{/branch}","tags_url":"https://api.github.com/repos/felipesanches/fontbakery/tags","blobs_url":"https://api.github.com/repos/felipesanches/fontbakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felipesanches/fontbakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felipesanches/fontbakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/felipesanches/fontbakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felipesanches/fontbakery/statuses/{sha}","languages_url":"https://api.github.com/repos/felipesanches/fontbakery/languages","stargazers_url":"https://api.github.com/repos/felipesanches/fontbakery/stargazers","contributors_url":"https://api.github.com/repos/felipesanches/fontbakery/contributors","subscribers_url":"https://api.github.com/repos/felipesanches/fontbakery/subscribers","subscription_url":"https://api.github.com/repos/felipesanches/fontbakery/subscription","commits_url":"https://api.github.com/repos/felipesanches/fontbakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/felipesanches/fontbakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/felipesanches/fontbakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/felipesanches/fontbakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/felipesanches/fontbakery/contents/{+path}","compare_url":"https://api.github.com/repos/felipesanches/fontbakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felipesanches/fontbakery/merges","archive_url":"https://api.github.com/repos/felipesanches/fontbakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felipesanches/fontbakery/downloads","issues_url":"https://api.github.com/repos/felipesanches/fontbakery/issues{/number}","pulls_url":"https://api.github.com/repos/felipesanches/fontbakery/pulls{/number}","milestones_url":"https://api.github.com/repos/felipesanches/fontbakery/milestones{/number}","notifications_url":"https://api.github.com/repos/felipesanches/fontbakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felipesanches/fontbakery/labels{/name}","releases_url":"https://api.github.com/repos/felipesanches/fontbakery/releases{/id}","deployments_url":"https://api.github.com/repos/felipesanches/fontbakery/deployments","created_at":"2015-11-23T20:17:25Z","updated_at":"2016-01-26T17:52:52Z","pushed_at":"2016-03-10T02:57:01Z","git_url":"git://github.com/felipesanches/fontbakery.git","ssh_url":"git@github.com:felipesanches/fontbakery.git","clone_url":"https://github.com/felipesanches/fontbakery.git","svn_url":"https://github.com/felipesanches/fontbakery","homepage":"http://googlefonts.github.io/fontbakery","size":10847,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlefonts:master","ref":"master","sha":"861e751f4792b29b465d2dd721a8f9d7272258e7","user":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars.githubusercontent.com/u/6466306?v=3","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"repo":{"id":8233105,"name":"fontbakery","full_name":"googlefonts/fontbakery","owner":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars.githubusercontent.com/u/6466306?v=3","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlefonts/fontbakery","description":"Tools to prepare font families for inclusion in github.com/google/fonts","fork":false,"url":"https://api.github.com/repos/googlefonts/fontbakery","forks_url":"https://api.github.com/repos/googlefonts/fontbakery/forks","keys_url":"https://api.github.com/repos/googlefonts/fontbakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlefonts/fontbakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlefonts/fontbakery/teams","hooks_url":"https://api.github.com/repos/googlefonts/fontbakery/hooks","issue_events_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/events{/number}","events_url":"https://api.github.com/repos/googlefonts/fontbakery/events","assignees_url":"https://api.github.com/repos/googlefonts/fontbakery/assignees{/user}","branches_url":"https://api.github.com/repos/googlefonts/fontbakery/branches{/branch}","tags_url":"https://api.github.com/repos/googlefonts/fontbakery/tags","blobs_url":"https://api.github.com/repos/googlefonts/fontbakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlefonts/fontbakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlefonts/fontbakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlefonts/fontbakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlefonts/fontbakery/statuses/{sha}","languages_url":"https://api.github.com/repos/googlefonts/fontbakery/languages","stargazers_url":"https://api.github.com/repos/googlefonts/fontbakery/stargazers","contributors_url":"https://api.github.com/repos/googlefonts/fontbakery/contributors","subscribers_url":"https://api.github.com/repos/googlefonts/fontbakery/subscribers","subscription_url":"https://api.github.com/repos/googlefonts/fontbakery/subscription","commits_url":"https://api.github.com/repos/googlefonts/fontbakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlefonts/fontbakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlefonts/fontbakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlefonts/fontbakery/contents/{+path}","compare_url":"https://api.github.com/repos/googlefonts/fontbakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlefonts/fontbakery/merges","archive_url":"https://api.github.com/repos/googlefonts/fontbakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlefonts/fontbakery/downloads","issues_url":"https://api.github.com/repos/googlefonts/fontbakery/issues{/number}","pulls_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls{/number}","milestones_url":"https://api.github.com/repos/googlefonts/fontbakery/milestones{/number}","notifications_url":"https://api.github.com/repos/googlefonts/fontbakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlefonts/fontbakery/labels{/name}","releases_url":"https://api.github.com/repos/googlefonts/fontbakery/releases{/id}","deployments_url":"https://api.github.com/repos/googlefonts/fontbakery/deployments","created_at":"2013-02-16T07:47:27Z","updated_at":"2016-03-09T04:35:50Z","pushed_at":"2016-03-10T02:57:01Z","git_url":"git://github.com/googlefonts/fontbakery.git","ssh_url":"git@github.com:googlefonts/fontbakery.git","clone_url":"https://github.com/googlefonts/fontbakery.git","svn_url":"https://github.com/googlefonts/fontbakery","homepage":"http://googlefonts.github.io/fontbakery","size":10843,"stargazers_count":92,"watchers_count":92,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":123,"forks":18,"open_issues":123,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746"},"html":{"href":"https://github.com/googlefonts/fontbakery/pull/746"},"issue":{"href":"https://api.github.com/repos/googlefonts/fontbakery/issues/746"},"comments":{"href":"https://api.github.com/repos/googlefonts/fontbakery/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/googlefonts/fontbakery/statuses/c2d28a548738e86d8c99b863bc1c89b60d97d345"}}}}