{"action":"created","comment":{"url":"https://api.github.com/repos/AuburnACM/auacm/pulls/comments/54339991","id":54339991,"diff_hunk":"@@ -85,31 +92,37 @@ app.controller('ScoreboardController', ['$scope', '$http', '$routeParams',\n         var viewed = [];\n         $scope.socket.on('status', function(event) {\n             if (viewed.indexOf(event.submissionId) > -1 ||\n-                    event.status == 'running' ||\n                     !problemIsInComp(event.problemId) ||\n                     event.submitTime > $scope.competition.startTime +\n                         $scope.competition.length) {\n                 // The scoreboard ignores the problem for any of the following\n                 // reasons:\n                 // The submission has already been handled,\n-                // The event's status is running,\n                 // The competition does not contain this problem, or\n-                // The problem was acceptedafter the contest was over.\n+                // The problem was accepted after the contest was over.\n                 return;\n             }\n-            viewed.push(event.submissionId); // note that we've seen this\n+            if (event.status !== 'running') {  // if the verdict isn't \"running\"\n+              viewed.push(event.submissionId); // note that we've seen this","path":"auacm/app/static/js/controllers/ScoreboardController.js","position":37,"original_position":37,"commit_id":"b8ed8f57d996472a46f02ac7fb39da7d524f4009","original_commit_id":"b8ed8f57d996472a46f02ac7fb39da7d524f4009","user":{"login":"BrandonLMorris","id":7709128,"avatar_url":"https://avatars.githubusercontent.com/u/7709128?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonLMorris","html_url":"https://github.com/BrandonLMorris","followers_url":"https://api.github.com/users/BrandonLMorris/followers","following_url":"https://api.github.com/users/BrandonLMorris/following{/other_user}","gists_url":"https://api.github.com/users/BrandonLMorris/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonLMorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonLMorris/subscriptions","organizations_url":"https://api.github.com/users/BrandonLMorris/orgs","repos_url":"https://api.github.com/users/BrandonLMorris/repos","events_url":"https://api.github.com/users/BrandonLMorris/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonLMorris/received_events","type":"User","site_admin":false},"body":"Should be indented 4 spaces, not two.","created_at":"2016-02-27T21:39:37Z","updated_at":"2016-02-27T21:39:37Z","html_url":"https://github.com/AuburnACM/auacm/pull/77#discussion_r54339991","pull_request_url":"https://api.github.com/repos/AuburnACM/auacm/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/comments/54339991"},"html":{"href":"https://github.com/AuburnACM/auacm/pull/77#discussion_r54339991"},"pull_request":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/AuburnACM/auacm/pulls/77","id":60926738,"html_url":"https://github.com/AuburnACM/auacm/pull/77","diff_url":"https://github.com/AuburnACM/auacm/pull/77.diff","patch_url":"https://github.com/AuburnACM/auacm/pull/77.patch","issue_url":"https://api.github.com/repos/AuburnACM/auacm/issues/77","number":77,"state":"open","locked":false,"title":"Update scoreboard","user":{"login":"mcprice30","id":8574496,"avatar_url":"https://avatars.githubusercontent.com/u/8574496?v=3","gravatar_id":"","url":"https://api.github.com/users/mcprice30","html_url":"https://github.com/mcprice30","followers_url":"https://api.github.com/users/mcprice30/followers","following_url":"https://api.github.com/users/mcprice30/following{/other_user}","gists_url":"https://api.github.com/users/mcprice30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcprice30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcprice30/subscriptions","organizations_url":"https://api.github.com/users/mcprice30/orgs","repos_url":"https://api.github.com/users/mcprice30/repos","events_url":"https://api.github.com/users/mcprice30/events{/privacy}","received_events_url":"https://api.github.com/users/mcprice30/received_events","type":"User","site_admin":false},"body":"Scoreboard now shows currently running submissons as \"pending\" and no longer increments the submit count after a correct submit.\r\n\r\nFixes #18 ","created_at":"2016-02-27T00:44:38Z","updated_at":"2016-02-27T21:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed639f609dca126b3e452e86937c6e56b324fe7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AuburnACM/auacm/pulls/77/commits","review_comments_url":"https://api.github.com/repos/AuburnACM/auacm/pulls/77/comments","review_comment_url":"https://api.github.com/repos/AuburnACM/auacm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AuburnACM/auacm/issues/77/comments","statuses_url":"https://api.github.com/repos/AuburnACM/auacm/statuses/b8ed8f57d996472a46f02ac7fb39da7d524f4009","head":{"label":"AuburnACM:scoreboard-pending","ref":"scoreboard-pending","sha":"b8ed8f57d996472a46f02ac7fb39da7d524f4009","user":{"login":"AuburnACM","id":13837893,"avatar_url":"https://avatars.githubusercontent.com/u/13837893?v=3","gravatar_id":"","url":"https://api.github.com/users/AuburnACM","html_url":"https://github.com/AuburnACM","followers_url":"https://api.github.com/users/AuburnACM/followers","following_url":"https://api.github.com/users/AuburnACM/following{/other_user}","gists_url":"https://api.github.com/users/AuburnACM/gists{/gist_id}","starred_url":"https://api.github.com/users/AuburnACM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuburnACM/subscriptions","organizations_url":"https://api.github.com/users/AuburnACM/orgs","repos_url":"https://api.github.com/users/AuburnACM/repos","events_url":"https://api.github.com/users/AuburnACM/events{/privacy}","received_events_url":"https://api.github.com/users/AuburnACM/received_events","type":"Organization","site_admin":false},"repo":{"id":41262723,"name":"auacm","full_name":"AuburnACM/auacm","owner":{"login":"AuburnACM","id":13837893,"avatar_url":"https://avatars.githubusercontent.com/u/13837893?v=3","gravatar_id":"","url":"https://api.github.com/users/AuburnACM","html_url":"https://github.com/AuburnACM","followers_url":"https://api.github.com/users/AuburnACM/followers","following_url":"https://api.github.com/users/AuburnACM/following{/other_user}","gists_url":"https://api.github.com/users/AuburnACM/gists{/gist_id}","starred_url":"https://api.github.com/users/AuburnACM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuburnACM/subscriptions","organizations_url":"https://api.github.com/users/AuburnACM/orgs","repos_url":"https://api.github.com/users/AuburnACM/repos","events_url":"https://api.github.com/users/AuburnACM/events{/privacy}","received_events_url":"https://api.github.com/users/AuburnACM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AuburnACM/auacm","description":"The Auburn ACM Website","fork":false,"url":"https://api.github.com/repos/AuburnACM/auacm","forks_url":"https://api.github.com/repos/AuburnACM/auacm/forks","keys_url":"https://api.github.com/repos/AuburnACM/auacm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AuburnACM/auacm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AuburnACM/auacm/teams","hooks_url":"https://api.github.com/repos/AuburnACM/auacm/hooks","issue_events_url":"https://api.github.com/repos/AuburnACM/auacm/issues/events{/number}","events_url":"https://api.github.com/repos/AuburnACM/auacm/events","assignees_url":"https://api.github.com/repos/AuburnACM/auacm/assignees{/user}","branches_url":"https://api.github.com/repos/AuburnACM/auacm/branches{/branch}","tags_url":"https://api.github.com/repos/AuburnACM/auacm/tags","blobs_url":"https://api.github.com/repos/AuburnACM/auacm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AuburnACM/auacm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AuburnACM/auacm/git/refs{/sha}","trees_url":"https://api.github.com/repos/AuburnACM/auacm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AuburnACM/auacm/statuses/{sha}","languages_url":"https://api.github.com/repos/AuburnACM/auacm/languages","stargazers_url":"https://api.github.com/repos/AuburnACM/auacm/stargazers","contributors_url":"https://api.github.com/repos/AuburnACM/auacm/contributors","subscribers_url":"https://api.github.com/repos/AuburnACM/auacm/subscribers","subscription_url":"https://api.github.com/repos/AuburnACM/auacm/subscription","commits_url":"https://api.github.com/repos/AuburnACM/auacm/commits{/sha}","git_commits_url":"https://api.github.com/repos/AuburnACM/auacm/git/commits{/sha}","comments_url":"https://api.github.com/repos/AuburnACM/auacm/comments{/number}","issue_comment_url":"https://api.github.com/repos/AuburnACM/auacm/issues/comments{/number}","contents_url":"https://api.github.com/repos/AuburnACM/auacm/contents/{+path}","compare_url":"https://api.github.com/repos/AuburnACM/auacm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AuburnACM/auacm/merges","archive_url":"https://api.github.com/repos/AuburnACM/auacm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AuburnACM/auacm/downloads","issues_url":"https://api.github.com/repos/AuburnACM/auacm/issues{/number}","pulls_url":"https://api.github.com/repos/AuburnACM/auacm/pulls{/number}","milestones_url":"https://api.github.com/repos/AuburnACM/auacm/milestones{/number}","notifications_url":"https://api.github.com/repos/AuburnACM/auacm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AuburnACM/auacm/labels{/name}","releases_url":"https://api.github.com/repos/AuburnACM/auacm/releases{/id}","deployments_url":"https://api.github.com/repos/AuburnACM/auacm/deployments","created_at":"2015-08-23T18:56:47Z","updated_at":"2016-02-18T03:45:21Z","pushed_at":"2016-02-27T21:02:23Z","git_url":"git://github.com/AuburnACM/auacm.git","ssh_url":"git@github.com:AuburnACM/auacm.git","clone_url":"https://github.com/AuburnACM/auacm.git","svn_url":"https://github.com/AuburnACM/auacm","homepage":"","size":7096,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":29,"forks":4,"open_issues":29,"watchers":8,"default_branch":"master"}},"base":{"label":"AuburnACM:master","ref":"master","sha":"2ebab3a1b4fc04d3a5b3ab2955e9f17230a5f7e9","user":{"login":"AuburnACM","id":13837893,"avatar_url":"https://avatars.githubusercontent.com/u/13837893?v=3","gravatar_id":"","url":"https://api.github.com/users/AuburnACM","html_url":"https://github.com/AuburnACM","followers_url":"https://api.github.com/users/AuburnACM/followers","following_url":"https://api.github.com/users/AuburnACM/following{/other_user}","gists_url":"https://api.github.com/users/AuburnACM/gists{/gist_id}","starred_url":"https://api.github.com/users/AuburnACM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuburnACM/subscriptions","organizations_url":"https://api.github.com/users/AuburnACM/orgs","repos_url":"https://api.github.com/users/AuburnACM/repos","events_url":"https://api.github.com/users/AuburnACM/events{/privacy}","received_events_url":"https://api.github.com/users/AuburnACM/received_events","type":"Organization","site_admin":false},"repo":{"id":41262723,"name":"auacm","full_name":"AuburnACM/auacm","owner":{"login":"AuburnACM","id":13837893,"avatar_url":"https://avatars.githubusercontent.com/u/13837893?v=3","gravatar_id":"","url":"https://api.github.com/users/AuburnACM","html_url":"https://github.com/AuburnACM","followers_url":"https://api.github.com/users/AuburnACM/followers","following_url":"https://api.github.com/users/AuburnACM/following{/other_user}","gists_url":"https://api.github.com/users/AuburnACM/gists{/gist_id}","starred_url":"https://api.github.com/users/AuburnACM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuburnACM/subscriptions","organizations_url":"https://api.github.com/users/AuburnACM/orgs","repos_url":"https://api.github.com/users/AuburnACM/repos","events_url":"https://api.github.com/users/AuburnACM/events{/privacy}","received_events_url":"https://api.github.com/users/AuburnACM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AuburnACM/auacm","description":"The Auburn ACM Website","fork":false,"url":"https://api.github.com/repos/AuburnACM/auacm","forks_url":"https://api.github.com/repos/AuburnACM/auacm/forks","keys_url":"https://api.github.com/repos/AuburnACM/auacm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AuburnACM/auacm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AuburnACM/auacm/teams","hooks_url":"https://api.github.com/repos/AuburnACM/auacm/hooks","issue_events_url":"https://api.github.com/repos/AuburnACM/auacm/issues/events{/number}","events_url":"https://api.github.com/repos/AuburnACM/auacm/events","assignees_url":"https://api.github.com/repos/AuburnACM/auacm/assignees{/user}","branches_url":"https://api.github.com/repos/AuburnACM/auacm/branches{/branch}","tags_url":"https://api.github.com/repos/AuburnACM/auacm/tags","blobs_url":"https://api.github.com/repos/AuburnACM/auacm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AuburnACM/auacm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AuburnACM/auacm/git/refs{/sha}","trees_url":"https://api.github.com/repos/AuburnACM/auacm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AuburnACM/auacm/statuses/{sha}","languages_url":"https://api.github.com/repos/AuburnACM/auacm/languages","stargazers_url":"https://api.github.com/repos/AuburnACM/auacm/stargazers","contributors_url":"https://api.github.com/repos/AuburnACM/auacm/contributors","subscribers_url":"https://api.github.com/repos/AuburnACM/auacm/subscribers","subscription_url":"https://api.github.com/repos/AuburnACM/auacm/subscription","commits_url":"https://api.github.com/repos/AuburnACM/auacm/commits{/sha}","git_commits_url":"https://api.github.com/repos/AuburnACM/auacm/git/commits{/sha}","comments_url":"https://api.github.com/repos/AuburnACM/auacm/comments{/number}","issue_comment_url":"https://api.github.com/repos/AuburnACM/auacm/issues/comments{/number}","contents_url":"https://api.github.com/repos/AuburnACM/auacm/contents/{+path}","compare_url":"https://api.github.com/repos/AuburnACM/auacm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AuburnACM/auacm/merges","archive_url":"https://api.github.com/repos/AuburnACM/auacm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AuburnACM/auacm/downloads","issues_url":"https://api.github.com/repos/AuburnACM/auacm/issues{/number}","pulls_url":"https://api.github.com/repos/AuburnACM/auacm/pulls{/number}","milestones_url":"https://api.github.com/repos/AuburnACM/auacm/milestones{/number}","notifications_url":"https://api.github.com/repos/AuburnACM/auacm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AuburnACM/auacm/labels{/name}","releases_url":"https://api.github.com/repos/AuburnACM/auacm/releases{/id}","deployments_url":"https://api.github.com/repos/AuburnACM/auacm/deployments","created_at":"2015-08-23T18:56:47Z","updated_at":"2016-02-18T03:45:21Z","pushed_at":"2016-02-27T21:02:23Z","git_url":"git://github.com/AuburnACM/auacm.git","ssh_url":"git@github.com:AuburnACM/auacm.git","clone_url":"https://github.com/AuburnACM/auacm.git","svn_url":"https://github.com/AuburnACM/auacm","homepage":"","size":7096,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":29,"forks":4,"open_issues":29,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/77"},"html":{"href":"https://github.com/AuburnACM/auacm/pull/77"},"issue":{"href":"https://api.github.com/repos/AuburnACM/auacm/issues/77"},"comments":{"href":"https://api.github.com/repos/AuburnACM/auacm/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AuburnACM/auacm/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/AuburnACM/auacm/statuses/b8ed8f57d996472a46f02ac7fb39da7d524f4009"}}}}