{"action":"created","issue":{"url":"https://api.github.com/repos/keske/react-parallax-component/issues/2","repository_url":"https://api.github.com/repos/keske/react-parallax-component","labels_url":"https://api.github.com/repos/keske/react-parallax-component/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/keske/react-parallax-component/issues/2/comments","events_url":"https://api.github.com/repos/keske/react-parallax-component/issues/2/events","html_url":"https://github.com/keske/react-parallax-component/pull/2","id":169236489,"number":2,"title":"fix(Position): simplifies calculation of top position","user":{"login":"Jeremboo","id":6682092,"avatar_url":"https://avatars.githubusercontent.com/u/6682092?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeremboo","html_url":"https://github.com/Jeremboo","followers_url":"https://api.github.com/users/Jeremboo/followers","following_url":"https://api.github.com/users/Jeremboo/following{/other_user}","gists_url":"https://api.github.com/users/Jeremboo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremboo/subscriptions","organizations_url":"https://api.github.com/users/Jeremboo/orgs","repos_url":"https://api.github.com/users/Jeremboo/repos","events_url":"https://api.github.com/users/Jeremboo/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremboo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-03T21:18:05Z","updated_at":"2016-08-03T21:25:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keske/react-parallax-component/pulls/2","html_url":"https://github.com/keske/react-parallax-component/pull/2","diff_url":"https://github.com/keske/react-parallax-component/pull/2.diff","patch_url":"https://github.com/keske/react-parallax-component/pull/2.patch"},"body":"Hi !\r\n\r\nI have found your React component and it is pretty cool !\r\n\r\nHowever, I think it's be possible to simplifie many thing whose the top position calculation.\r\n\r\nFor now, between the initial position and the first scroll event, you have a first uncontrolled gap. This seems to be because of the `elemTop` variable initially different to the top value.\r\n\r\nI propose this calculation who simply make the difference between the initial top position and the scroll move braked by the `speed`. \r\n\r\nThe effect is exactly the same and the gap is deleted. \r\n\r\nHave a nice day !\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/keske/react-parallax-component/issues/comments/237379221","html_url":"https://github.com/keske/react-parallax-component/pull/2#issuecomment-237379221","issue_url":"https://api.github.com/repos/keske/react-parallax-component/issues/2","id":237379221,"user":{"login":"Jeremboo","id":6682092,"avatar_url":"https://avatars.githubusercontent.com/u/6682092?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeremboo","html_url":"https://github.com/Jeremboo","followers_url":"https://api.github.com/users/Jeremboo/followers","following_url":"https://api.github.com/users/Jeremboo/following{/other_user}","gists_url":"https://api.github.com/users/Jeremboo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremboo/subscriptions","organizations_url":"https://api.github.com/users/Jeremboo/orgs","repos_url":"https://api.github.com/users/Jeremboo/repos","events_url":"https://api.github.com/users/Jeremboo/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremboo/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T21:25:34Z","updated_at":"2016-08-03T21:25:34Z","body":"Therefore, the speed value could be called `velocity` because it is the true use. \r\nAnd fix the value to int is also not realy interesting I think.\r\n\r\nIf you will agree, I can share another pull request :)"}}
{"actor":{"display_login":"Jeremboo"}}