{"action":"created","issue":{"url":"https://api.github.com/repos/async-interop/promise/issues/26","repository_url":"https://api.github.com/repos/async-interop/promise","labels_url":"https://api.github.com/repos/async-interop/promise/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/async-interop/promise/issues/26/comments","events_url":"https://api.github.com/repos/async-interop/promise/issues/26/events","html_url":"https://github.com/async-interop/promise/pull/26","id":197417294,"number":26,"title":"Clarify Promise::when docblock","user":{"login":"kelunik","id":2743004,"avatar_url":"https://avatars.githubusercontent.com/u/2743004?v=3","gravatar_id":"","url":"https://api.github.com/users/kelunik","html_url":"https://github.com/kelunik","followers_url":"https://api.github.com/users/kelunik/followers","following_url":"https://api.github.com/users/kelunik/following{/other_user}","gists_url":"https://api.github.com/users/kelunik/gists{/gist_id}","starred_url":"https://api.github.com/users/kelunik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelunik/subscriptions","organizations_url":"https://api.github.com/users/kelunik/orgs","repos_url":"https://api.github.com/users/kelunik/repos","events_url":"https://api.github.com/users/kelunik/events{/privacy}","received_events_url":"https://api.github.com/users/kelunik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-23T19:30:29Z","updated_at":"2016-12-23T21:17:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/async-interop/promise/pulls/26","html_url":"https://github.com/async-interop/promise/pull/26","diff_url":"https://github.com/async-interop/promise/pull/26.diff","patch_url":"https://github.com/async-interop/promise/pull/26.patch"},"body":"It specifies the exact invocation parameter values now and includes a statement about always-sync when callbacks.\n\nCloses #20."},"comment":{"url":"https://api.github.com/repos/async-interop/promise/issues/comments/269046601","html_url":"https://github.com/async-interop/promise/pull/26#issuecomment-269046601","issue_url":"https://api.github.com/repos/async-interop/promise/issues/26","id":269046601,"user":{"login":"joshdifabio","id":5609851,"avatar_url":"https://avatars.githubusercontent.com/u/5609851?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdifabio","html_url":"https://github.com/joshdifabio","followers_url":"https://api.github.com/users/joshdifabio/followers","following_url":"https://api.github.com/users/joshdifabio/following{/other_user}","gists_url":"https://api.github.com/users/joshdifabio/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdifabio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdifabio/subscriptions","organizations_url":"https://api.github.com/users/joshdifabio/orgs","repos_url":"https://api.github.com/users/joshdifabio/repos","events_url":"https://api.github.com/users/joshdifabio/events{/privacy}","received_events_url":"https://api.github.com/users/joshdifabio/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T21:17:37Z","updated_at":"2016-12-23T21:17:37Z","body":"Here's a code example.\r\n\r\n```php\r\nfunction ($promise) {\r\n    $promise->when(function () use ($promise) {\r\n        echo '1';\r\n        $promise->when(function () {\r\n            echo '3';\r\n        });\r\n    });\r\n\r\n    $promise->when(function () {\r\n        echo '2';\r\n    });\r\n\r\n    $promise->resolve('foo');\r\n}\r\n```\r\n\r\nI think this would print _132_ in Amp, even though according to the spec it should print _123_? Always-sync `when()` on resolved promises makes it quite messy to avoid this."}}
{"actor":{"display_login":"joshdifabio"}}