{"action":"closed","number":818,"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/818","id":75417996,"html_url":"https://github.com/convox/rack/pull/818","diff_url":"https://github.com/convox/rack/pull/818.diff","patch_url":"https://github.com/convox/rack/pull/818.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/818","number":818,"state":"closed","locked":false,"title":"Fixing tests","user":{"login":"adamenger","id":1205898,"avatar_url":"https://avatars.githubusercontent.com/u/1205898?v=3","gravatar_id":"","url":"https://api.github.com/users/adamenger","html_url":"https://github.com/adamenger","followers_url":"https://api.github.com/users/adamenger/followers","following_url":"https://api.github.com/users/adamenger/following{/other_user}","gists_url":"https://api.github.com/users/adamenger/gists{/gist_id}","starred_url":"https://api.github.com/users/adamenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamenger/subscriptions","organizations_url":"https://api.github.com/users/adamenger/orgs","repos_url":"https://api.github.com/users/adamenger/repos","events_url":"https://api.github.com/users/adamenger/events{/privacy}","received_events_url":"https://api.github.com/users/adamenger/received_events","type":"User","site_admin":false},"body":"Noticed that some tests were broken and decided to abstract some strings that are being reused in a few places. Passing now locally. \r\n\r\n## Release Playbook\r\n- [ ] Rebase against master\r\n- [ ] Release branch ()\r\n- [ ] Pass CI ()\r\n- [ ] Code review\r\n- [ ] Merge into master\r\n- [ ] Release master ()\r\n- [ ] Pass CI ()\r\n- [ ] Update staging rack\r\n- [ ] Edit [Rack release record](https://github.com/convox/rack/releases) and/or update [docs](https://github.com/convox/convox.github.io)\r\n- [ ] Publish release\r\n- [ ] Release CLI\r\n\r\n","created_at":"2016-06-28T04:49:51Z","updated_at":"2016-06-28T05:10:01Z","closed_at":"2016-06-28T05:10:01Z","merged_at":null,"merge_commit_sha":"4943317516de712601bc767c973034ddc22ed91a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/818/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/818/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/818/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/e5a3cc354a389601d08f10cb656bbc4fe7b2b248","head":{"label":"adamenger:ae/fix-tests","ref":"ae/fix-tests","sha":"e5a3cc354a389601d08f10cb656bbc4fe7b2b248","user":{"login":"adamenger","id":1205898,"avatar_url":"https://avatars.githubusercontent.com/u/1205898?v=3","gravatar_id":"","url":"https://api.github.com/users/adamenger","html_url":"https://github.com/adamenger","followers_url":"https://api.github.com/users/adamenger/followers","following_url":"https://api.github.com/users/adamenger/following{/other_user}","gists_url":"https://api.github.com/users/adamenger/gists{/gist_id}","starred_url":"https://api.github.com/users/adamenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamenger/subscriptions","organizations_url":"https://api.github.com/users/adamenger/orgs","repos_url":"https://api.github.com/users/adamenger/repos","events_url":"https://api.github.com/users/adamenger/events{/privacy}","received_events_url":"https://api.github.com/users/adamenger/received_events","type":"User","site_admin":false},"repo":{"id":62068032,"name":"rack","full_name":"adamenger/rack","owner":{"login":"adamenger","id":1205898,"avatar_url":"https://avatars.githubusercontent.com/u/1205898?v=3","gravatar_id":"","url":"https://api.github.com/users/adamenger","html_url":"https://github.com/adamenger","followers_url":"https://api.github.com/users/adamenger/followers","following_url":"https://api.github.com/users/adamenger/following{/other_user}","gists_url":"https://api.github.com/users/adamenger/gists{/gist_id}","starred_url":"https://api.github.com/users/adamenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamenger/subscriptions","organizations_url":"https://api.github.com/users/adamenger/orgs","repos_url":"https://api.github.com/users/adamenger/repos","events_url":"https://api.github.com/users/adamenger/events{/privacy}","received_events_url":"https://api.github.com/users/adamenger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamenger/rack","description":"Open-source PaaS on AWS","fork":true,"url":"https://api.github.com/repos/adamenger/rack","forks_url":"https://api.github.com/repos/adamenger/rack/forks","keys_url":"https://api.github.com/repos/adamenger/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamenger/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamenger/rack/teams","hooks_url":"https://api.github.com/repos/adamenger/rack/hooks","issue_events_url":"https://api.github.com/repos/adamenger/rack/issues/events{/number}","events_url":"https://api.github.com/repos/adamenger/rack/events","assignees_url":"https://api.github.com/repos/adamenger/rack/assignees{/user}","branches_url":"https://api.github.com/repos/adamenger/rack/branches{/branch}","tags_url":"https://api.github.com/repos/adamenger/rack/tags","blobs_url":"https://api.github.com/repos/adamenger/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamenger/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamenger/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamenger/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamenger/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/adamenger/rack/languages","stargazers_url":"https://api.github.com/repos/adamenger/rack/stargazers","contributors_url":"https://api.github.com/repos/adamenger/rack/contributors","subscribers_url":"https://api.github.com/repos/adamenger/rack/subscribers","subscription_url":"https://api.github.com/repos/adamenger/rack/subscription","commits_url":"https://api.github.com/repos/adamenger/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamenger/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamenger/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamenger/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamenger/rack/contents/{+path}","compare_url":"https://api.github.com/repos/adamenger/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamenger/rack/merges","archive_url":"https://api.github.com/repos/adamenger/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamenger/rack/downloads","issues_url":"https://api.github.com/repos/adamenger/rack/issues{/number}","pulls_url":"https://api.github.com/repos/adamenger/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/adamenger/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/adamenger/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamenger/rack/labels{/name}","releases_url":"https://api.github.com/repos/adamenger/rack/releases{/id}","deployments_url":"https://api.github.com/repos/adamenger/rack/deployments","created_at":"2016-06-27T15:47:01Z","updated_at":"2016-06-27T15:47:03Z","pushed_at":"2016-06-28T04:51:43Z","git_url":"git://github.com/adamenger/rack.git","ssh_url":"git@github.com:adamenger/rack.git","clone_url":"https://github.com/adamenger/rack.git","svn_url":"https://github.com/adamenger/rack","homepage":"https://convox.com","size":51123,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"592c9f5ebb87a3154051c9d229a9d64670ddda63","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-06-27T14:54:39Z","pushed_at":"2016-06-28T04:51:43Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":51651,"stargazers_count":1206,"watchers_count":1206,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":116,"forks":81,"open_issues":116,"watchers":1206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/818"},"html":{"href":"https://github.com/convox/rack/pull/818"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/818"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/818/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/818/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/818/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/e5a3cc354a389601d08f10cb656bbc4fe7b2b248"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":2,"commits":3,"additions":15,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"adamenger"}}