{"action":"created","comment":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/66797434","id":66797434,"diff_hunk":"@@ -51,9 +51,16 @@ VectorList: class <T> extends List<T>{\n \t\tthis _count -= 1\n \t\tresult\n \t}\n-\tremoveAt: override func (index: Int) {\n-\t\tthis _vector copy(index + 1, index)\n-\t\tthis _count -= 1\n+\tremoveAt: override func (index: Int) { this removeAt(index, index + 1) }\n+\tremoveAt: func ~range (range: Range) { this removeAt(range min, range max) }\n+\tremoveAt: func ~indices (start, end: Int) {\n+\t\tcount := end - start\n+\t\tversion(safe) {\n+\t\t\traise(count < 0 || start > this count || end > this count,\n+\t\t\t\t\"Invalid range in VectorList::removeAt: start=%d end=%d (list count=%d)\" format(start, end, this count))","path":"source/system/structs/VectorList.ooc","position":null,"original_position":13,"commit_id":"86fa3e1b20c4edeaebe3169e159c03d7a0d6bf7c","original_commit_id":"787e77cb21f5dead3361c5cbfe8b9fdaf18e0b92","user":{"login":"marcusnaslund","id":14308896,"avatar_url":"https://avatars.githubusercontent.com/u/14308896?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusnaslund","html_url":"https://github.com/marcusnaslund","followers_url":"https://api.github.com/users/marcusnaslund/followers","following_url":"https://api.github.com/users/marcusnaslund/following{/other_user}","gists_url":"https://api.github.com/users/marcusnaslund/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusnaslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusnaslund/subscriptions","organizations_url":"https://api.github.com/users/marcusnaslund/orgs","repos_url":"https://api.github.com/users/marcusnaslund/repos","events_url":"https://api.github.com/users/marcusnaslund/events{/privacy}","received_events_url":"https://api.github.com/users/marcusnaslund/received_events","type":"User","site_admin":false},"body":"Yes, because it creates a new String (which is not a literal).","created_at":"2016-06-13T14:09:10Z","updated_at":"2016-06-13T14:09:10Z","html_url":"https://github.com/magic-lang/ooc-kean/pull/1794#discussion_r66797434","pull_request_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794","_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/66797434"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/1794#discussion_r66797434"},"pull_request":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794"}}},"pull_request":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794","id":73568592,"html_url":"https://github.com/magic-lang/ooc-kean/pull/1794","diff_url":"https://github.com/magic-lang/ooc-kean/pull/1794.diff","patch_url":"https://github.com/magic-lang/ooc-kean/pull/1794.patch","issue_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1794","number":1794,"state":"open","locked":false,"title":"Added removeRange function for VectorList.","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"@sebastianbaginski peer review","created_at":"2016-06-13T12:39:35Z","updated_at":"2016-06-13T14:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21b6e1c85be5c296435dd584f548d536b27ca7c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794/commits","review_comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794/comments","review_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1794/comments","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/86fa3e1b20c4edeaebe3169e159c03d7a0d6bf7c","head":{"label":"emilwestergren:removeRange","ref":"removeRange","sha":"86fa3e1b20c4edeaebe3169e159c03d7a0d6bf7c","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"repo":{"id":25524995,"name":"ooc-kean","full_name":"emilwestergren/ooc-kean","owner":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilwestergren/ooc-kean","description":"OOC port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/emilwestergren/ooc-kean","forks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/forks","keys_url":"https://api.github.com/repos/emilwestergren/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilwestergren/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilwestergren/ooc-kean/teams","hooks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/events","assignees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/emilwestergren/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/tags","blobs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilwestergren/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/emilwestergren/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscription","commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/emilwestergren/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilwestergren/ooc-kean/merges","archive_url":"https://api.github.com/repos/emilwestergren/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilwestergren/ooc-kean/downloads","issues_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/emilwestergren/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/emilwestergren/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/emilwestergren/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilwestergren/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/emilwestergren/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/deployments","created_at":"2014-10-21T13:51:19Z","updated_at":"2016-01-21T11:50:29Z","pushed_at":"2016-06-13T14:07:18Z","git_url":"git://github.com/emilwestergren/ooc-kean.git","ssh_url":"git@github.com:emilwestergren/ooc-kean.git","clone_url":"https://github.com/emilwestergren/ooc-kean.git","svn_url":"https://github.com/emilwestergren/ooc-kean","homepage":null,"size":37356,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magic-lang:primaryFeature1.4","ref":"primaryFeature1.4","sha":"4d34945f086b43d706fdb9d00f5e7c50e79b122e","user":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"magic-lang/ooc-kean","owner":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magic-lang/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/magic-lang/ooc-kean","forks_url":"https://api.github.com/repos/magic-lang/ooc-kean/forks","keys_url":"https://api.github.com/repos/magic-lang/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magic-lang/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magic-lang/ooc-kean/teams","hooks_url":"https://api.github.com/repos/magic-lang/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/magic-lang/ooc-kean/events","assignees_url":"https://api.github.com/repos/magic-lang/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/magic-lang/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/tags","blobs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/magic-lang/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/magic-lang/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/magic-lang/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscription","commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/magic-lang/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/magic-lang/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magic-lang/ooc-kean/merges","archive_url":"https://api.github.com/repos/magic-lang/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magic-lang/ooc-kean/downloads","issues_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/magic-lang/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/magic-lang/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magic-lang/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/magic-lang/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/magic-lang/ooc-kean/deployments","created_at":"2014-10-15T13:42:17Z","updated_at":"2016-03-02T07:55:35Z","pushed_at":"2016-06-13T14:07:18Z","git_url":"git://github.com/magic-lang/ooc-kean.git","ssh_url":"git@github.com:magic-lang/ooc-kean.git","clone_url":"https://github.com/magic-lang/ooc-kean.git","svn_url":"https://github.com/magic-lang/ooc-kean","homepage":"","size":38621,"stargazers_count":4,"watchers_count":4,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":18,"forks":24,"open_issues":18,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/1794"},"issue":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1794"},"comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/1794/comments"},"review_comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794/comments"},"review_comment":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/1794/commits"},"statuses":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/86fa3e1b20c4edeaebe3169e159c03d7a0d6bf7c"}}}}
{"actor":{"display_login":"marcusnaslund"}}