{"action":"created","comment":{"url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/comments/72539070","id":72539070,"diff_hunk":"@@ -81,6 +86,13 @@ def write(self, file_or_path, append=False, timeout=10):\n         multiprocess test environment.\n         \"\"\"\n         if isinstance(file_or_path, six.string_types):\n+            if self.coverage and self.coverage.config.parallel:","path":"smother/control.py","position":40,"original_position":40,"commit_id":"7742e1d3f21d2c570ee9dc376e74ba1b4e15575f","original_commit_id":"7742e1d3f21d2c570ee9dc376e74ba1b4e15575f","user":{"login":"ChrisBeaumont","id":796752,"avatar_url":"https://avatars.githubusercontent.com/u/796752?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBeaumont","html_url":"https://github.com/ChrisBeaumont","followers_url":"https://api.github.com/users/ChrisBeaumont/followers","following_url":"https://api.github.com/users/ChrisBeaumont/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBeaumont/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBeaumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBeaumont/subscriptions","organizations_url":"https://api.github.com/users/ChrisBeaumont/orgs","repos_url":"https://api.github.com/users/ChrisBeaumont/repos","events_url":"https://api.github.com/users/ChrisBeaumont/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBeaumont/received_events","type":"User","site_admin":false},"body":"my first instinct is that `write()` should be \"dumb\" and treat file_or_path as litearally as possible. Can we move this logic up to a helper function invoked by the caller of `write`? Or do you think it makes more sense here?","created_at":"2016-07-27T22:54:24Z","updated_at":"2016-07-27T22:54:24Z","html_url":"https://github.com/ChrisBeaumont/smother/pull/5#discussion_r72539070","pull_request_url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/comments/72539070"},"html":{"href":"https://github.com/ChrisBeaumont/smother/pull/5#discussion_r72539070"},"pull_request":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5","id":79071063,"html_url":"https://github.com/ChrisBeaumont/smother/pull/5","diff_url":"https://github.com/ChrisBeaumont/smother/pull/5.diff","patch_url":"https://github.com/ChrisBeaumont/smother/pull/5.patch","issue_url":"https://api.github.com/repos/ChrisBeaumont/smother/issues/5","number":5,"state":"open","locked":false,"title":"Add parallel mode, Path Aliases, and relative paths","user":{"login":"AlejandroFrias","id":3598338,"avatar_url":"https://avatars.githubusercontent.com/u/3598338?v=3","gravatar_id":"","url":"https://api.github.com/users/AlejandroFrias","html_url":"https://github.com/AlejandroFrias","followers_url":"https://api.github.com/users/AlejandroFrias/followers","following_url":"https://api.github.com/users/AlejandroFrias/following{/other_user}","gists_url":"https://api.github.com/users/AlejandroFrias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlejandroFrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlejandroFrias/subscriptions","organizations_url":"https://api.github.com/users/AlejandroFrias/orgs","repos_url":"https://api.github.com/users/AlejandroFrias/repos","events_url":"https://api.github.com/users/AlejandroFrias/events{/privacy}","received_events_url":"https://api.github.com/users/AlejandroFrias/received_events","type":"User","site_admin":false},"body":"This PR ports coverage's parallel mode and path aliasing. It also adds relative path support.\r\n\r\n## Parallel Mode and [paths] aliasing:\r\nhttp://coverage.readthedocs.io/en/coverage-4.2/cmd.html?highlight=parallel#cmd-combining\r\nAs seen in the docs above, coverage has few nice features for running coverage on multiple machines in parallel. Parallel mode gives unique names to the output coverage file. the `[paths]` config option allows combining coverage files from different machines, aliasing the roots to a common root. This PR ports that behavior to Smother.\r\n\r\n## Relative Paths\r\nHistorically coverage only grabs absolute paths, even when combining data files. When combing files on a different machine than the file will be used on, it makes sense to have relative paths so that no extra steps need to be taken to create nice html coverage files. So I added that as a possible flag. Both on combine and initial run, the paths are converted so that they're relative to the current directory that the command is run from.\r\n\r\n# TODO\r\nCould use more tests. I've only added one basic test that captures one common use case of combining files and using relative paths. That isn't robust enough. Not sure how to test the unique naming when run form different machines, yet.","created_at":"2016-07-27T18:11:08Z","updated_at":"2016-07-27T22:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9724bd65aee199411467e8a4962241d995b6f347","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChrisBeaumont/smother/issues/5/comments","statuses_url":"https://api.github.com/repos/ChrisBeaumont/smother/statuses/7742e1d3f21d2c570ee9dc376e74ba1b4e15575f","head":{"label":"AlejandroFrias:add-parallel-mode","ref":"add-parallel-mode","sha":"7742e1d3f21d2c570ee9dc376e74ba1b4e15575f","user":{"login":"AlejandroFrias","id":3598338,"avatar_url":"https://avatars.githubusercontent.com/u/3598338?v=3","gravatar_id":"","url":"https://api.github.com/users/AlejandroFrias","html_url":"https://github.com/AlejandroFrias","followers_url":"https://api.github.com/users/AlejandroFrias/followers","following_url":"https://api.github.com/users/AlejandroFrias/following{/other_user}","gists_url":"https://api.github.com/users/AlejandroFrias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlejandroFrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlejandroFrias/subscriptions","organizations_url":"https://api.github.com/users/AlejandroFrias/orgs","repos_url":"https://api.github.com/users/AlejandroFrias/repos","events_url":"https://api.github.com/users/AlejandroFrias/events{/privacy}","received_events_url":"https://api.github.com/users/AlejandroFrias/received_events","type":"User","site_admin":false},"repo":{"id":64329941,"name":"smother","full_name":"AlejandroFrias/smother","owner":{"login":"AlejandroFrias","id":3598338,"avatar_url":"https://avatars.githubusercontent.com/u/3598338?v=3","gravatar_id":"","url":"https://api.github.com/users/AlejandroFrias","html_url":"https://github.com/AlejandroFrias","followers_url":"https://api.github.com/users/AlejandroFrias/followers","following_url":"https://api.github.com/users/AlejandroFrias/following{/other_user}","gists_url":"https://api.github.com/users/AlejandroFrias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlejandroFrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlejandroFrias/subscriptions","organizations_url":"https://api.github.com/users/AlejandroFrias/orgs","repos_url":"https://api.github.com/users/AlejandroFrias/repos","events_url":"https://api.github.com/users/AlejandroFrias/events{/privacy}","received_events_url":"https://api.github.com/users/AlejandroFrias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlejandroFrias/smother","description":"coverage, just moreso","fork":true,"url":"https://api.github.com/repos/AlejandroFrias/smother","forks_url":"https://api.github.com/repos/AlejandroFrias/smother/forks","keys_url":"https://api.github.com/repos/AlejandroFrias/smother/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlejandroFrias/smother/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlejandroFrias/smother/teams","hooks_url":"https://api.github.com/repos/AlejandroFrias/smother/hooks","issue_events_url":"https://api.github.com/repos/AlejandroFrias/smother/issues/events{/number}","events_url":"https://api.github.com/repos/AlejandroFrias/smother/events","assignees_url":"https://api.github.com/repos/AlejandroFrias/smother/assignees{/user}","branches_url":"https://api.github.com/repos/AlejandroFrias/smother/branches{/branch}","tags_url":"https://api.github.com/repos/AlejandroFrias/smother/tags","blobs_url":"https://api.github.com/repos/AlejandroFrias/smother/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlejandroFrias/smother/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlejandroFrias/smother/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlejandroFrias/smother/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlejandroFrias/smother/statuses/{sha}","languages_url":"https://api.github.com/repos/AlejandroFrias/smother/languages","stargazers_url":"https://api.github.com/repos/AlejandroFrias/smother/stargazers","contributors_url":"https://api.github.com/repos/AlejandroFrias/smother/contributors","subscribers_url":"https://api.github.com/repos/AlejandroFrias/smother/subscribers","subscription_url":"https://api.github.com/repos/AlejandroFrias/smother/subscription","commits_url":"https://api.github.com/repos/AlejandroFrias/smother/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlejandroFrias/smother/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlejandroFrias/smother/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlejandroFrias/smother/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlejandroFrias/smother/contents/{+path}","compare_url":"https://api.github.com/repos/AlejandroFrias/smother/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlejandroFrias/smother/merges","archive_url":"https://api.github.com/repos/AlejandroFrias/smother/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlejandroFrias/smother/downloads","issues_url":"https://api.github.com/repos/AlejandroFrias/smother/issues{/number}","pulls_url":"https://api.github.com/repos/AlejandroFrias/smother/pulls{/number}","milestones_url":"https://api.github.com/repos/AlejandroFrias/smother/milestones{/number}","notifications_url":"https://api.github.com/repos/AlejandroFrias/smother/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlejandroFrias/smother/labels{/name}","releases_url":"https://api.github.com/repos/AlejandroFrias/smother/releases{/id}","deployments_url":"https://api.github.com/repos/AlejandroFrias/smother/deployments","created_at":"2016-07-27T17:52:33Z","updated_at":"2016-07-27T17:52:34Z","pushed_at":"2016-07-27T18:00:47Z","git_url":"git://github.com/AlejandroFrias/smother.git","ssh_url":"git@github.com:AlejandroFrias/smother.git","clone_url":"https://github.com/AlejandroFrias/smother.git","svn_url":"https://github.com/AlejandroFrias/smother","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChrisBeaumont:master","ref":"master","sha":"83d4e3fdbd0809f5937e3201892678ffd16b9bd7","user":{"login":"ChrisBeaumont","id":796752,"avatar_url":"https://avatars.githubusercontent.com/u/796752?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBeaumont","html_url":"https://github.com/ChrisBeaumont","followers_url":"https://api.github.com/users/ChrisBeaumont/followers","following_url":"https://api.github.com/users/ChrisBeaumont/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBeaumont/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBeaumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBeaumont/subscriptions","organizations_url":"https://api.github.com/users/ChrisBeaumont/orgs","repos_url":"https://api.github.com/users/ChrisBeaumont/repos","events_url":"https://api.github.com/users/ChrisBeaumont/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBeaumont/received_events","type":"User","site_admin":false},"repo":{"id":60883092,"name":"smother","full_name":"ChrisBeaumont/smother","owner":{"login":"ChrisBeaumont","id":796752,"avatar_url":"https://avatars.githubusercontent.com/u/796752?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBeaumont","html_url":"https://github.com/ChrisBeaumont","followers_url":"https://api.github.com/users/ChrisBeaumont/followers","following_url":"https://api.github.com/users/ChrisBeaumont/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBeaumont/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBeaumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBeaumont/subscriptions","organizations_url":"https://api.github.com/users/ChrisBeaumont/orgs","repos_url":"https://api.github.com/users/ChrisBeaumont/repos","events_url":"https://api.github.com/users/ChrisBeaumont/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBeaumont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisBeaumont/smother","description":"coverage, just moreso","fork":false,"url":"https://api.github.com/repos/ChrisBeaumont/smother","forks_url":"https://api.github.com/repos/ChrisBeaumont/smother/forks","keys_url":"https://api.github.com/repos/ChrisBeaumont/smother/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisBeaumont/smother/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisBeaumont/smother/teams","hooks_url":"https://api.github.com/repos/ChrisBeaumont/smother/hooks","issue_events_url":"https://api.github.com/repos/ChrisBeaumont/smother/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisBeaumont/smother/events","assignees_url":"https://api.github.com/repos/ChrisBeaumont/smother/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisBeaumont/smother/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisBeaumont/smother/tags","blobs_url":"https://api.github.com/repos/ChrisBeaumont/smother/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisBeaumont/smother/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisBeaumont/smother/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisBeaumont/smother/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisBeaumont/smother/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisBeaumont/smother/languages","stargazers_url":"https://api.github.com/repos/ChrisBeaumont/smother/stargazers","contributors_url":"https://api.github.com/repos/ChrisBeaumont/smother/contributors","subscribers_url":"https://api.github.com/repos/ChrisBeaumont/smother/subscribers","subscription_url":"https://api.github.com/repos/ChrisBeaumont/smother/subscription","commits_url":"https://api.github.com/repos/ChrisBeaumont/smother/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisBeaumont/smother/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisBeaumont/smother/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisBeaumont/smother/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisBeaumont/smother/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisBeaumont/smother/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisBeaumont/smother/merges","archive_url":"https://api.github.com/repos/ChrisBeaumont/smother/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisBeaumont/smother/downloads","issues_url":"https://api.github.com/repos/ChrisBeaumont/smother/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisBeaumont/smother/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisBeaumont/smother/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisBeaumont/smother/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisBeaumont/smother/labels{/name}","releases_url":"https://api.github.com/repos/ChrisBeaumont/smother/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisBeaumont/smother/deployments","created_at":"2016-06-10T23:52:19Z","updated_at":"2016-07-25T21:37:35Z","pushed_at":"2016-07-27T18:11:08Z","git_url":"git://github.com/ChrisBeaumont/smother.git","ssh_url":"git@github.com:ChrisBeaumont/smother.git","clone_url":"https://github.com/ChrisBeaumont/smother.git","svn_url":"https://github.com/ChrisBeaumont/smother","homepage":null,"size":101,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5"},"html":{"href":"https://github.com/ChrisBeaumont/smother/pull/5"},"issue":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/issues/5"},"comments":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ChrisBeaumont/smother/statuses/7742e1d3f21d2c570ee9dc376e74ba1b4e15575f"}}}}
{"actor":{"display_login":"ChrisBeaumont"}}