{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1088","repository_url":"https://api.github.com/repos/devtools-html/debugger.html","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1088/comments","events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1088/events","html_url":"https://github.com/devtools-html/debugger.html/pull/1088","id":186916692,"number":1088,"title":"Add Search tests","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-02T20:51:29Z","updated_at":"2016-11-04T13:33:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/1088","html_url":"https://github.com/devtools-html/debugger.html/pull/1088","diff_url":"https://github.com/devtools-html/debugger.html/pull/1088.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/1088.patch"},"body":"Associated Issue: #1067 \r\n\r\n### Summary of Changes\r\n\r\n* Adds some mochi tests for source search. I'd like to add some unit tests later as most of this is more suited for that\r\n\r\n* I tried really hard to get file search tests in, but for whatever reason I kept opening the content search bar and not the editor search bar. \r\n\r\nhere's a small patch for the file search tests\r\n```js\r\n// Testing file search\r\nadd_task(function* () {\r\n  const dbg = yield initDebugger(\"doc-script-switching.html\");\r\n  yield selectSource(dbg, \"switching-01\");\r\n\r\n  // window.dbg = dbg;\r\n  // yield pauseTest();\r\n  const el = findElementWithSelector(dbg, \".CodeMirror-line\").focus();\r\n  console.log(\"el\", el);\r\n  pressKey(dbg, \"fileSearch\");\r\n  type(dbg, \"fun\");\r\n  debugger;\r\n});\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments/258431836","html_url":"https://github.com/devtools-html/debugger.html/pull/1088#issuecomment-258431836","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1088","id":258431836,"user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T13:33:26Z","updated_at":"2016-11-04T13:33:26Z","body":"@jlongster the issue was with the modifier for `<cmd>+p`. CI is linux and needs ctrl, which we ran into with Jaideep's work with stepping. \r\n\r\nAfter thinking about it a bit more, I don't think we have to worry about debugger DOM events being async. I believe the mochitests run in the same context as the toolbox and will be able do this work synchronously.\r\n\r\nhere was the fix\r\n```\r\nconst cmdOrCtrl = isLinux ? { ctrlKey: true } : { metaKey: true };\r\n```"}}
{"actor":{"display_login":"jasonLaster"}}