{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/79339679","id":79339679,"diff_hunk":"@@ -182,84 +182,71 @@ public function testHandleLayoutAbTest() {\n \t * @covers WikiaSearchController::handleArticleMatchTracking\n \t */\n \tpublic function testArticleMatchTrackingWithMatch() {\n-\t\t$mockController = $this->searchController->setMethods( array( 'getVal' ) )->getMock();\n-\t\t$searchConfig = $this->getMock( 'Wikia\\Search\\Config', array( 'getQuery', 'getPage', 'hasArticleMatch', 'getArticleMatch' ) );\n-\t\t$mockQuery = $this->getMock( 'Wikia\\Search\\Query', array( 'getSanitizedQuery' ) );\n+\t\t$mockController = $this->searchController->setMethods( [ 'getVal' ] )->getMock();\n+\t\t$searchConfig = $this->getMock( 'Wikia\\Search\\Config', [ 'getQuery', 'getPage', 'hasArticleMatch', 'getArticleMatch' ] );\n+\t\t$mockQuery = $this->getMock( 'Wikia\\Search\\Query', [ 'getSanitizedQuery' ] );\n \t\t$mockTitle = $this->getMockBuilder( 'Title' )\n \t\t                  ->disableOriginalConstructor()\n-\t\t                  ->setMethods( array( 'getFullUrl' ) )\n+\t\t                  ->setMethods( [ 'getFullUrl' ] )\n \t\t                  ->getMock();\n-\t\t$mockResponse = $this->getMock( 'WikiaResponse', array( 'redirect' ), array( 'html' ) );\n+\t\t$mockResponse = $this->getMock( 'WikiaResponse', [ 'redirect' ], [ 'html' ] );\n \t\t$mockMatch = $this->getMockBuilder( 'Wikia\\Search\\Match\\Article' )\n \t\t                  ->disableOriginalConstructor()\n-\t\t                  ->setMethods( array( 'getId' ) )\n+\t\t                  ->setMethods( [ 'getId' ] )\n \t\t                  ->getMock();\n \t\t$mockArticle = $this->getMockBuilder( 'Article' )\n \t\t                    ->disableOriginalConstructor()\n-\t\t                    ->setMethods( array( 'getTitle' ) )\n+\t\t                    ->setMethods( [ 'getTitle' ] )\n \t\t                    ->getMock();\n \t\t$mockRunHooks = $this->getGlobalFunctionMock( 'wfRunHooks' );\n \n \t\t$originalQuery = 'foo';\n \t\t$redirectUrl = 'http://foo.wikia.com/Wiki/foo';\n \n \t\t$searchConfig\n-\t\t\t->expects\t( $this->any() )\n-\t\t\t->method\t( 'getPage' )\n-\t\t\t->will\t\t( $this->returnValue( 1 ) )\n-\t\t;\n+\t\t\t->expects( $this->any() )\n+\t\t\t->method( 'getPage' )\n+\t\t\t->will( $this->returnValue( 1 ) );\n \t\t$searchConfig\n \t\t    ->expects( $this->any() )\n-\t\t    ->method ( 'getQuery' )\n-\t\t    ->will   ( $this->returnValue( $mockQuery ) )\n-\t    ;\n+\t\t    ->method( 'getQuery' )\n+\t\t    ->will( $this->returnValue( $mockQuery ) );\n \t\t$mockQuery\n \t\t    ->expects( $this->once() )\n-\t\t    ->method ( 'getSanitizedQuery' )\n-\t\t    ->will   ( $this->returnValue( 'foo' ) )\n-\t\t;\n+\t\t    ->method( 'getSanitizedQuery' )\n+\t\t    ->will( $this->returnValue( 'foo' ) );\n \t\t$searchConfig\n \t\t    ->expects( $this->any() )\n-\t\t    ->method ( 'getArticleMatch' )\n-\t\t    ->will   ( $this->returnValue( $mockMatch) )\n-\t\t;\n+\t\t    ->method( 'getArticleMatch' )\n+\t\t    ->will( $this->returnValue( $mockMatch) );\n \t\t$mockMatch\n \t\t    ->expects( $this->once() )\n-\t\t    ->method ( 'getId' )\n-\t\t    ->will   ( $this->returnValue( 123 ) )\n-\t\t;\n+\t\t    ->method( 'getId' )\n+\t\t    ->will( $this->returnValue( 123 ) );\n \t\t$mockArticle\n \t\t    ->expects( $this->once() )\n-\t\t    ->method ( 'getTitle' )\n-\t\t    ->will   ( $this->returnValue( $mockTitle ) )\n-\t\t;\n+\t\t    ->method( 'getTitle' )\n+\t\t    ->will( $this->returnValue( $mockTitle ) );\n \t\t$searchConfig\n-\t\t\t->expects\t( $this->any() )\n-\t\t\t->method\t( 'hasArticleMatch' )\n-\t\t\t->will\t\t( $this->returnValue( true ) )\n-\t\t;\n+\t\t\t->expects( $this->any() )\n+\t\t\t->method( 'hasArticleMatch' )\n+\t\t\t->will( $this->returnValue( true ) );\n \t\t$mockController\n-\t\t\t->expects\t( $this->once() )\n-\t\t\t->method\t( 'getVal' )\n-\t\t\t->with\t\t( 'fulltext', '0' )\n-\t\t\t->will\t\t( $this->returnValue( '0' ) )\n-\t\t;\n+\t\t\t->expects( $this->any() )\n+\t\t\t->method( 'getVal' )\n+\t\t\t->will( $this->returnValue( '0' ) );\n \t\t$mockRunHooks\n-\t\t    ->expects( $this->once() )\n-\t\t    ->method ( 'wfRunHooks' )\n-\t\t    ->with   ( 'SpecialSearchIsgomatch', array( $mockTitle, $originalQuery ) )\n-\t\t;\n+\t\t\t->expects( $this->once() )\n+\t\t\t->method( 'wfRunHooks' );\n \t\t$mockTitle\n-\t\t\t->expects\t( $this->any() )\n-\t\t\t->method\t( 'getFullURL' )\n-\t\t\t->will\t\t( $this->returnValue( $redirectUrl ) )\n-\t\t;\n+\t\t\t->expects( $this->any() )\n+\t\t\t->method( 'getFullURL' )\n+\t\t\t->will( $this->returnValue( $redirectUrl ) );\n \t\t$mockResponse\n-\t\t\t->expects\t( $this->once() )\n-\t\t\t->method\t( 'redirect' )\n-\t\t\t->with      ( $redirectUrl )\n-\t\t\t->will\t\t( $this->returnValue( true ) )\n-\t\t;\n+\t\t\t->expects( $this->once() )\n+\t\t\t->method( 'redirect' )\n+\t\t\t->with( $redirectUrl )\n+\t\t\t->will( $this->returnValue( true ) );\n \n \t\t$responserefl = new ReflectionProperty( 'WikiaSearchController', 'response' );","path":"extensions/wikia/Search/classes/Test/Controller/SearchControllerTest.php","position":118,"original_position":118,"commit_id":"07f9d87593305f50907fb2e5ab0e6e3032630da1","original_commit_id":"07f9d87593305f50907fb2e5ab0e6e3032630da1","user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Define a constant instead of duplicating this literal \"response\" 4 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n","created_at":"2016-09-19T07:48:40Z","updated_at":"2016-09-19T07:48:40Z","html_url":"https://github.com/Wikia/app/pull/11241#discussion_r79339679","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/11241","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/79339679"},"html":{"href":"https://github.com/Wikia/app/pull/11241#discussion_r79339679"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/11241"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11241","id":83476385,"html_url":"https://github.com/Wikia/app/pull/11241","diff_url":"https://github.com/Wikia/app/pull/11241.diff","patch_url":"https://github.com/Wikia/app/pull/11241.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/11241","number":11241,"state":"open","locked":false,"title":"XW-1768 | Introduce Global Navigation from Design System","user":{"login":"rogatty","id":7030884,"avatar_url":"https://avatars.githubusercontent.com/u/7030884?v=3","gravatar_id":"","url":"https://api.github.com/users/rogatty","html_url":"https://github.com/rogatty","followers_url":"https://api.github.com/users/rogatty/followers","following_url":"https://api.github.com/users/rogatty/following{/other_user}","gists_url":"https://api.github.com/users/rogatty/gists{/gist_id}","starred_url":"https://api.github.com/users/rogatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogatty/subscriptions","organizations_url":"https://api.github.com/users/rogatty/orgs","repos_url":"https://api.github.com/users/rogatty/repos","events_url":"https://api.github.com/users/rogatty/events{/privacy}","received_events_url":"https://api.github.com/users/rogatty/received_events","type":"User","site_admin":false},"body":"https://wikia-inc.atlassian.net/browse/XW-1768","created_at":"2016-08-31T15:35:18Z","updated_at":"2016-09-19T07:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5fe5de2b62fa526c934ebbe1a4b6d8dedeebb55","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/11241/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/11241/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11241/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/07f9d87593305f50907fb2e5ab0e6e3032630da1","head":{"label":"Wikia:ds-global-navigation","ref":"ds-global-navigation","sha":"07f9d87593305f50907fb2e5ab0e6e3032630da1","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-09-03T16:51:09Z","pushed_at":"2016-09-17T17:35:30Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1429505,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":130,"forks":81,"open_issues":130,"watchers":102,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"e99ddbcc430f25d9018d956525f622a40f5afa36","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-09-03T16:51:09Z","pushed_at":"2016-09-17T17:35:30Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1429505,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":130,"forks":81,"open_issues":130,"watchers":102,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/11241"},"html":{"href":"https://github.com/Wikia/app/pull/11241"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/11241"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/11241/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/11241/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/11241/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/07f9d87593305f50907fb2e5ab0e6e3032630da1"}}}}
{"actor":{"display_login":"WikiaTech"}}