{"action":"created","comment":{"url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/comments/79897186","id":79897186,"diff_hunk":"@@ -756,9 +756,11 @@ public static void Negate(ref Vector2 value, out Vector2 result)\n         /// </summary>\n         public void Normalize()\n         {\n-            float val = 1.0f / (float)Math.Sqrt((X * X) + (Y * Y));\n-            X *= val;\n-            Y *= val;\n+\t\t\tvar magnitude = (float)Math.Sqrt((X * X) + (Y * Y));\n+\t\t\tif(magnitude > 1E-05f)","path":"MonoGame.Framework/Vector2.cs","position":8,"original_position":8,"commit_id":"5969efbd3c5b2fe2c7f2cc3ca4cc878edd98f232","original_commit_id":"5969efbd3c5b2fe2c7f2cc3ca4cc878edd98f232","user":{"login":"prime31","id":60377,"avatar_url":"https://avatars.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"body":"Is adhering to XNA really a top priority at this point? Wouldn't making the best possible framework for people to develop with today and in the future be a more important priority? At the very least it would be nice to have a method that \"does the right thing\" even if it has a slightly odd name. That coupled with a method summary explaining that NaN is a possible return from the method would at least save people some time who aren't coming from XNA and/or haven't run into trying to normalize 0,0 yet.","created_at":"2016-09-21T18:10:48Z","updated_at":"2016-09-21T18:10:48Z","html_url":"https://github.com/MonoGame/MonoGame/pull/5174#discussion_r79897186","pull_request_url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174","_links":{"self":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/comments/79897186"},"html":{"href":"https://github.com/MonoGame/MonoGame/pull/5174#discussion_r79897186"},"pull_request":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174"}}},"pull_request":{"url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174","id":86208236,"html_url":"https://github.com/MonoGame/MonoGame/pull/5174","diff_url":"https://github.com/MonoGame/MonoGame/pull/5174.diff","patch_url":"https://github.com/MonoGame/MonoGame/pull/5174.patch","issue_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5174","number":5174,"state":"open","locked":false,"title":"avoid the case where normalizing 0,0 results in NaN,NaN and instead default to 0,0","user":{"login":"prime31","id":60377,"avatar_url":"https://avatars.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"body":"minor fix for Vector2.Normalize to avoid it returning NaN,NaN when passed 0,0","created_at":"2016-09-21T17:38:45Z","updated_at":"2016-09-21T18:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b91784b3fe9774892f1dabe527fb244ee75b5138","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174/commits","review_comments_url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174/comments","review_comment_url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5174/comments","statuses_url":"https://api.github.com/repos/MonoGame/MonoGame/statuses/5969efbd3c5b2fe2c7f2cc3ca4cc878edd98f232","head":{"label":"prime31:develop","ref":"develop","sha":"5969efbd3c5b2fe2c7f2cc3ca4cc878edd98f232","user":{"login":"prime31","id":60377,"avatar_url":"https://avatars.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"repo":{"id":45496200,"name":"MonoGame","full_name":"prime31/MonoGame","owner":{"login":"prime31","id":60377,"avatar_url":"https://avatars.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prime31/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":true,"url":"https://api.github.com/repos/prime31/MonoGame","forks_url":"https://api.github.com/repos/prime31/MonoGame/forks","keys_url":"https://api.github.com/repos/prime31/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prime31/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prime31/MonoGame/teams","hooks_url":"https://api.github.com/repos/prime31/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/prime31/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/prime31/MonoGame/events","assignees_url":"https://api.github.com/repos/prime31/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/prime31/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/prime31/MonoGame/tags","blobs_url":"https://api.github.com/repos/prime31/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prime31/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prime31/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/prime31/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prime31/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/prime31/MonoGame/languages","stargazers_url":"https://api.github.com/repos/prime31/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/prime31/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/prime31/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/prime31/MonoGame/subscription","commits_url":"https://api.github.com/repos/prime31/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/prime31/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/prime31/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/prime31/MonoGame/issues/comments{/number}","contents_url":"https://api.github.com/repos/prime31/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/prime31/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prime31/MonoGame/merges","archive_url":"https://api.github.com/repos/prime31/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prime31/MonoGame/downloads","issues_url":"https://api.github.com/repos/prime31/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/prime31/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/prime31/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/prime31/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prime31/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/prime31/MonoGame/releases{/id}","deployments_url":"https://api.github.com/repos/prime31/MonoGame/deployments","created_at":"2015-11-03T21:17:29Z","updated_at":"2016-08-04T07:53:45Z","pushed_at":"2016-09-21T17:37:51Z","git_url":"git://github.com/prime31/MonoGame.git","ssh_url":"git@github.com:prime31/MonoGame.git","clone_url":"https://github.com/prime31/MonoGame.git","svn_url":"https://github.com/prime31/MonoGame","homepage":"http://www.monogame.net","size":69370,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CartBlanche-AndroidFullScreenFix"}},"base":{"label":"MonoGame:develop","ref":"develop","sha":"5f50b70e9f11960fd3607c456f3b2d6b66ada9ff","user":{"login":"MonoGame","id":4772066,"avatar_url":"https://avatars.githubusercontent.com/u/4772066?v=3","gravatar_id":"","url":"https://api.github.com/users/MonoGame","html_url":"https://github.com/MonoGame","followers_url":"https://api.github.com/users/MonoGame/followers","following_url":"https://api.github.com/users/MonoGame/following{/other_user}","gists_url":"https://api.github.com/users/MonoGame/gists{/gist_id}","starred_url":"https://api.github.com/users/MonoGame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonoGame/subscriptions","organizations_url":"https://api.github.com/users/MonoGame/orgs","repos_url":"https://api.github.com/users/MonoGame/repos","events_url":"https://api.github.com/users/MonoGame/events{/privacy}","received_events_url":"https://api.github.com/users/MonoGame/received_events","type":"Organization","site_admin":false},"repo":{"id":1579990,"name":"MonoGame","full_name":"MonoGame/MonoGame","owner":{"login":"MonoGame","id":4772066,"avatar_url":"https://avatars.githubusercontent.com/u/4772066?v=3","gravatar_id":"","url":"https://api.github.com/users/MonoGame","html_url":"https://github.com/MonoGame","followers_url":"https://api.github.com/users/MonoGame/followers","following_url":"https://api.github.com/users/MonoGame/following{/other_user}","gists_url":"https://api.github.com/users/MonoGame/gists{/gist_id}","starred_url":"https://api.github.com/users/MonoGame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonoGame/subscriptions","organizations_url":"https://api.github.com/users/MonoGame/orgs","repos_url":"https://api.github.com/users/MonoGame/repos","events_url":"https://api.github.com/users/MonoGame/events{/privacy}","received_events_url":"https://api.github.com/users/MonoGame/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MonoGame/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":false,"url":"https://api.github.com/repos/MonoGame/MonoGame","forks_url":"https://api.github.com/repos/MonoGame/MonoGame/forks","keys_url":"https://api.github.com/repos/MonoGame/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MonoGame/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MonoGame/MonoGame/teams","hooks_url":"https://api.github.com/repos/MonoGame/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/MonoGame/MonoGame/events","assignees_url":"https://api.github.com/repos/MonoGame/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/MonoGame/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/MonoGame/MonoGame/tags","blobs_url":"https://api.github.com/repos/MonoGame/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MonoGame/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MonoGame/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/MonoGame/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MonoGame/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/MonoGame/MonoGame/languages","stargazers_url":"https://api.github.com/repos/MonoGame/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/MonoGame/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/MonoGame/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/MonoGame/MonoGame/subscription","commits_url":"https://api.github.com/repos/MonoGame/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/MonoGame/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/MonoGame/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/comments{/number}","contents_url":"https://api.github.com/repos/MonoGame/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/MonoGame/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MonoGame/MonoGame/merges","archive_url":"https://api.github.com/repos/MonoGame/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MonoGame/MonoGame/downloads","issues_url":"https://api.github.com/repos/MonoGame/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/MonoGame/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/MonoGame/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/MonoGame/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MonoGame/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/MonoGame/MonoGame/releases{/id}","deployments_url":"https://api.github.com/repos/MonoGame/MonoGame/deployments","created_at":"2011-04-07T00:23:40Z","updated_at":"2016-09-21T14:49:05Z","pushed_at":"2016-09-21T17:38:45Z","git_url":"git://github.com/MonoGame/MonoGame.git","ssh_url":"git@github.com:MonoGame/MonoGame.git","clone_url":"https://github.com/MonoGame/MonoGame.git","svn_url":"https://github.com/MonoGame/MonoGame","homepage":"http://www.monogame.net","size":355743,"stargazers_count":3786,"watchers_count":3786,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1829,"mirror_url":null,"open_issues_count":810,"forks":1829,"open_issues":810,"watchers":3786,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174"},"html":{"href":"https://github.com/MonoGame/MonoGame/pull/5174"},"issue":{"href":"https://api.github.com/repos/MonoGame/MonoGame/issues/5174"},"comments":{"href":"https://api.github.com/repos/MonoGame/MonoGame/issues/5174/comments"},"review_comments":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174/comments"},"review_comment":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5174/commits"},"statuses":{"href":"https://api.github.com/repos/MonoGame/MonoGame/statuses/5969efbd3c5b2fe2c7f2cc3ca4cc878edd98f232"}}}}
{"actor":{"display_login":"prime31"}}