{"action":"created","issue":{"url":"https://api.github.com/repos/avocado-framework/avocado/issues/1277","repository_url":"https://api.github.com/repos/avocado-framework/avocado","labels_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1277/labels{/name}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1277/comments","events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1277/events","html_url":"https://github.com/avocado-framework/avocado/pull/1277","id":161932536,"number":1277,"title":"Add expire time for asset fetcher [v3]","user":{"login":"apahim","id":4717757,"avatar_url":"https://avatars.githubusercontent.com/u/4717757?v=3","gravatar_id":"","url":"https://api.github.com/users/apahim","html_url":"https://github.com/apahim","followers_url":"https://api.github.com/users/apahim/followers","following_url":"https://api.github.com/users/apahim/following{/other_user}","gists_url":"https://api.github.com/users/apahim/gists{/gist_id}","starred_url":"https://api.github.com/users/apahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apahim/subscriptions","organizations_url":"https://api.github.com/users/apahim/orgs","repos_url":"https://api.github.com/users/apahim/repos","events_url":"https://api.github.com/users/apahim/events{/privacy}","received_events_url":"https://api.github.com/users/apahim/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/avocado-framework/avocado/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"assignees":[{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-06-23T14:10:29Z","updated_at":"2016-06-24T10:48:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1277","html_url":"https://github.com/avocado-framework/avocado/pull/1277","diff_url":"https://github.com/avocado-framework/avocado/pull/1277.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/1277.patch"},"body":"v3:\r\n- Use specific class in `except` when calling `time_to_seconds()` in `run.py`.\r\n- Improved unittest.\r\n- Improved docs.\r\n- Don't hard code behavior for `0` and negative values in `expire`.\r\n\r\nv2: #1275 \r\n - Move `time_to_seconds()` to `data_structures`.\r\n - Accept zero and negative values.\r\n - Unittest.\r\n\r\nv1: #1266 \r\nNow users can invalidate (download again) a local copy of the asset file if\r\nit has more than a given time since created.\r\n\r\nReference: https://trello.com/c/JLk01wOl"},"comment":{"url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments/228315231","html_url":"https://github.com/avocado-framework/avocado/pull/1277#issuecomment-228315231","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1277","id":228315231,"user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T10:48:41Z","updated_at":"2016-06-24T10:48:41Z","body":"Well yes, it does work properly, because asset fetcher does not check the hash of the `file://` files, which is IMO a huge security issue. Btw you don't need to change the file content, you can check for `os.path.realpath` instead. Anyway we can deal with this when we fix the hash checking for `file://`."}}
{"actor":{"display_login":"ldoktor"}}