{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26","id":66051605,"html_url":"https://github.com/iPlantCollaborativeOpenSource/clank/pull/26","diff_url":"https://github.com/iPlantCollaborativeOpenSource/clank/pull/26.diff","patch_url":"https://github.com/iPlantCollaborativeOpenSource/clank/pull/26.patch","issue_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/26","number":26,"state":"closed","locked":false,"title":"Add feature to properly create empty bundle in case of self signed certs","user":{"login":"amercer1","id":790330,"avatar_url":"https://avatars.githubusercontent.com/u/790330?v=3","gravatar_id":"","url":"https://api.github.com/users/amercer1","html_url":"https://github.com/amercer1","followers_url":"https://api.github.com/users/amercer1/followers","following_url":"https://api.github.com/users/amercer1/following{/other_user}","gists_url":"https://api.github.com/users/amercer1/gists{/gist_id}","starred_url":"https://api.github.com/users/amercer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amercer1/subscriptions","organizations_url":"https://api.github.com/users/amercer1/orgs","repos_url":"https://api.github.com/users/amercer1/repos","events_url":"https://api.github.com/users/amercer1/events{/privacy}","received_events_url":"https://api.github.com/users/amercer1/received_events","type":"User","site_admin":false},"body":"We have a situation in which a user make want clank to generate self signed certs. Thats already taken care. But what do we do in the case of a bundle cert? If a user does not have a cert to begin with, he/she probably won't have a bundle as well. This cause this [line](https://github.com/iPlantCollaborativeOpenSource/atmosphere/blob/master/extras/nginx/Makefile.j2#L54-L55) to break if they don't provide one. \r\n\r\nAs a result, if the pull request is accepted, we need to have our variables.yml that are requesting self signed certs to be created to account for an empyt_bundle.crt to be created. ","created_at":"2016-04-11T19:51:22Z","updated_at":"2016-04-11T19:55:25Z","closed_at":"2016-04-11T19:55:25Z","merged_at":"2016-04-11T19:55:25Z","merge_commit_sha":"9ec6c3c5d5db360cd35f79beecee77e735992902","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26/commits","review_comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26/comments","review_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/26/comments","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/statuses/8c2b4b7a80cf91870fe0a82f4421e32c936eeb0c","head":{"label":"amercer1:master","ref":"master","sha":"8c2b4b7a80cf91870fe0a82f4421e32c936eeb0c","user":{"login":"amercer1","id":790330,"avatar_url":"https://avatars.githubusercontent.com/u/790330?v=3","gravatar_id":"","url":"https://api.github.com/users/amercer1","html_url":"https://github.com/amercer1","followers_url":"https://api.github.com/users/amercer1/followers","following_url":"https://api.github.com/users/amercer1/following{/other_user}","gists_url":"https://api.github.com/users/amercer1/gists{/gist_id}","starred_url":"https://api.github.com/users/amercer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amercer1/subscriptions","organizations_url":"https://api.github.com/users/amercer1/orgs","repos_url":"https://api.github.com/users/amercer1/repos","events_url":"https://api.github.com/users/amercer1/events{/privacy}","received_events_url":"https://api.github.com/users/amercer1/received_events","type":"User","site_admin":false},"repo":{"id":56001915,"name":"clank","full_name":"amercer1/clank","owner":{"login":"amercer1","id":790330,"avatar_url":"https://avatars.githubusercontent.com/u/790330?v=3","gravatar_id":"","url":"https://api.github.com/users/amercer1","html_url":"https://github.com/amercer1","followers_url":"https://api.github.com/users/amercer1/followers","following_url":"https://api.github.com/users/amercer1/following{/other_user}","gists_url":"https://api.github.com/users/amercer1/gists{/gist_id}","starred_url":"https://api.github.com/users/amercer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amercer1/subscriptions","organizations_url":"https://api.github.com/users/amercer1/orgs","repos_url":"https://api.github.com/users/amercer1/repos","events_url":"https://api.github.com/users/amercer1/events{/privacy}","received_events_url":"https://api.github.com/users/amercer1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amercer1/clank","description":"clankity clankity clankity clank","fork":true,"url":"https://api.github.com/repos/amercer1/clank","forks_url":"https://api.github.com/repos/amercer1/clank/forks","keys_url":"https://api.github.com/repos/amercer1/clank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amercer1/clank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amercer1/clank/teams","hooks_url":"https://api.github.com/repos/amercer1/clank/hooks","issue_events_url":"https://api.github.com/repos/amercer1/clank/issues/events{/number}","events_url":"https://api.github.com/repos/amercer1/clank/events","assignees_url":"https://api.github.com/repos/amercer1/clank/assignees{/user}","branches_url":"https://api.github.com/repos/amercer1/clank/branches{/branch}","tags_url":"https://api.github.com/repos/amercer1/clank/tags","blobs_url":"https://api.github.com/repos/amercer1/clank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amercer1/clank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amercer1/clank/git/refs{/sha}","trees_url":"https://api.github.com/repos/amercer1/clank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amercer1/clank/statuses/{sha}","languages_url":"https://api.github.com/repos/amercer1/clank/languages","stargazers_url":"https://api.github.com/repos/amercer1/clank/stargazers","contributors_url":"https://api.github.com/repos/amercer1/clank/contributors","subscribers_url":"https://api.github.com/repos/amercer1/clank/subscribers","subscription_url":"https://api.github.com/repos/amercer1/clank/subscription","commits_url":"https://api.github.com/repos/amercer1/clank/commits{/sha}","git_commits_url":"https://api.github.com/repos/amercer1/clank/git/commits{/sha}","comments_url":"https://api.github.com/repos/amercer1/clank/comments{/number}","issue_comment_url":"https://api.github.com/repos/amercer1/clank/issues/comments{/number}","contents_url":"https://api.github.com/repos/amercer1/clank/contents/{+path}","compare_url":"https://api.github.com/repos/amercer1/clank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amercer1/clank/merges","archive_url":"https://api.github.com/repos/amercer1/clank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amercer1/clank/downloads","issues_url":"https://api.github.com/repos/amercer1/clank/issues{/number}","pulls_url":"https://api.github.com/repos/amercer1/clank/pulls{/number}","milestones_url":"https://api.github.com/repos/amercer1/clank/milestones{/number}","notifications_url":"https://api.github.com/repos/amercer1/clank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amercer1/clank/labels{/name}","releases_url":"https://api.github.com/repos/amercer1/clank/releases{/id}","deployments_url":"https://api.github.com/repos/amercer1/clank/deployments","created_at":"2016-04-11T19:39:25Z","updated_at":"2016-04-11T19:39:27Z","pushed_at":"2016-04-11T19:47:31Z","git_url":"git://github.com/amercer1/clank.git","ssh_url":"git@github.com:amercer1/clank.git","clone_url":"https://github.com/amercer1/clank.git","svn_url":"https://github.com/amercer1/clank","homepage":"","size":235,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iPlantCollaborativeOpenSource:master","ref":"master","sha":"a532f307d2f84eec8a10e200243ecad2a7892cdb","user":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":38850061,"name":"clank","full_name":"iPlantCollaborativeOpenSource/clank","owner":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iPlantCollaborativeOpenSource/clank","description":"clankity clankity clankity clank","fork":false,"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank","forks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/forks","keys_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/teams","hooks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/hooks","issue_events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/events{/number}","events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/events","assignees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/assignees{/user}","branches_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/branches{/branch}","tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/tags","blobs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/git/refs{/sha}","trees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/statuses/{sha}","languages_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/languages","stargazers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/stargazers","contributors_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/contributors","subscribers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/subscribers","subscription_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/subscription","commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/commits{/sha}","git_commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/git/commits{/sha}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/comments{/number}","issue_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/comments{/number}","contents_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/contents/{+path}","compare_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/merges","archive_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/downloads","issues_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues{/number}","pulls_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls{/number}","milestones_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/milestones{/number}","notifications_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/labels{/name}","releases_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/releases{/id}","deployments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/deployments","created_at":"2015-07-09T23:17:52Z","updated_at":"2016-03-12T22:54:02Z","pushed_at":"2016-04-11T19:55:25Z","git_url":"git://github.com/iPlantCollaborativeOpenSource/clank.git","ssh_url":"git@github.com:iPlantCollaborativeOpenSource/clank.git","clone_url":"https://github.com/iPlantCollaborativeOpenSource/clank.git","svn_url":"https://github.com/iPlantCollaborativeOpenSource/clank","homepage":"","size":235,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/clank/pull/26"},"issue":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/26"},"comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/clank/statuses/8c2b4b7a80cf91870fe0a82f4421e32c936eeb0c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"amercer1","id":790330,"avatar_url":"https://avatars.githubusercontent.com/u/790330?v=3","gravatar_id":"","url":"https://api.github.com/users/amercer1","html_url":"https://github.com/amercer1","followers_url":"https://api.github.com/users/amercer1/followers","following_url":"https://api.github.com/users/amercer1/following{/other_user}","gists_url":"https://api.github.com/users/amercer1/gists{/gist_id}","starred_url":"https://api.github.com/users/amercer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amercer1/subscriptions","organizations_url":"https://api.github.com/users/amercer1/orgs","repos_url":"https://api.github.com/users/amercer1/repos","events_url":"https://api.github.com/users/amercer1/events{/privacy}","received_events_url":"https://api.github.com/users/amercer1/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":13,"deletions":4,"changed_files":6}}