{"action":"created","issue":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/7321","repository_url":"https://api.github.com/repos/dmwm/WMCore","labels_url":"https://api.github.com/repos/dmwm/WMCore/issues/7321/labels{/name}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/7321/comments","events_url":"https://api.github.com/repos/dmwm/WMCore/issues/7321/events","html_url":"https://github.com/dmwm/WMCore/pull/7321","id":184804971,"number":7321,"title":"Fix type in DQMHarvest; correct GQ stats accounting","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"labels":[{"id":311378297,"url":"https://api.github.com/repos/dmwm/WMCore/labels/Do%20not%20merge%20yet","name":"Do not merge yet","color":"fbca04","default":false},{"id":429113657,"url":"https://api.github.com/repos/dmwm/WMCore/labels/need%20wmagent%20branch","name":"need wmagent branch","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"assignees":[{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":38,"created_at":"2016-10-24T10:35:37Z","updated_at":"2016-10-28T12:39:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/7321","html_url":"https://github.com/dmwm/WMCore/pull/7321","diff_url":"https://github.com/dmwm/WMCore/pull/7321.diff","patch_url":"https://github.com/dmwm/WMCore/pull/7321.patch"},"body":"Several minor changes to the DQMHarvest spec:\r\n* fixed typo (black_blacklist)\r\n* use the correct splitting algo for the spec and start policy\r\n* gather correct statistics at GQ level (not for events)\r\n* added dataset name to the WMTask attributes (to avoid using PD,ProcStr,Tier all the time)\r\n\r\nDQMHarvesting tests look Ok in my VM, still a wider test missing.\r\n@ticoann please review"},"comment":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/comments/256909969","html_url":"https://github.com/dmwm/WMCore/pull/7321#issuecomment-256909969","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/7321","id":256909969,"user":{"login":"cmsdmwmbot","id":15169205,"avatar_url":"https://avatars.githubusercontent.com/u/15169205?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsdmwmbot","html_url":"https://github.com/cmsdmwmbot","followers_url":"https://api.github.com/users/cmsdmwmbot/followers","following_url":"https://api.github.com/users/cmsdmwmbot/following{/other_user}","gists_url":"https://api.github.com/users/cmsdmwmbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsdmwmbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsdmwmbot/subscriptions","organizations_url":"https://api.github.com/users/cmsdmwmbot/orgs","repos_url":"https://api.github.com/users/cmsdmwmbot/repos","events_url":"https://api.github.com/users/cmsdmwmbot/events{/privacy}","received_events_url":"https://api.github.com/users/cmsdmwmbot/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T12:39:20Z","updated_at":"2016-10-28T12:39:20Z","body":"Summary of pylint changes for pull request 7321:\n* Score for src/python/WMCore/WMSpec/WMTask.py changed from 9.88 to 9.86 with 0 (6) total errors (warnings)\n* Score for src/python/WMCore/WorkQueue/Policy/Start/Block.py changed from 9.87 to 9.85 with 0 (1) total errors (warnings)\n* Score for test/python/WMCore_t/WorkQueue_t/Policy_t/Start_t/Block_t.py changed from 10.00 to 9.97 with 0 (1) total errors (warnings)\n* Score for test/python/WMCore_t/WorkQueue_t/WorkQueue_t.py changed from 9.90 to 9.89 with 0 (7) total errors (warnings)\n\nAbbreviated pylint report for src/python/WMCore/WMSpec/StdSpecs/StdBase.py follows:\n* Line 78 in StdBase.__call__ E0203 Access to member 'multicore' before its definition line 80\n* Line 79 in StdBase.__call__ E0203 Access to member 'multicore' before its definition line 80\n* plus 7 total warnings\n* plus 11 comments on code style\n\nAbbreviated pylint report for src/python/WMCore/WMSpec/StdSpecs/StoreResults.py follows:\n* Line 2 E0012 Bad option value 'W0142'\n* Line 14 W0611 Unused import os\n* plus 1 total warnings\n* plus 26 comments on code style\n\nsrc/python/WMCore/WMSpec/WMTask.py got worse in pylint. Report follows:\n* Line 64 in buildLumiMask W0141 Used builtin function 'map'\n* Line 146 in WMTaskHelper.name W0212 Access to a protected member _internal_name of a client class\n* Line 364 in WMTaskHelper.setInputReference W0106 Expression \"[setattr(self.data.input, key, val) for (key, val) in extras.items()]\" is assigned to nothing\n* Line 404 in WMTaskHelper.setFirstEventAndLumi W0212 Access to a protected member _section of a client class\n* Line 436 in WMTaskHelper.setSplittingParameters W0106 Expression \"[setattr(self.data.input.splitting, key, val) for (key, val) in params.items()]\" is assigned to nothing\n* Line 902 in WMTaskHelper.setSubscriptionInformation R0913 Too many arguments (14/7)\n* Line 1389 in WMTaskHelper.setLumiMask W0102 Dangerous default value {} as argument\n* Line 73 in WMTaskHelper R0904 Too many public methods (97/20)\n* plus 8 comments on code style\n\nsrc/python/WMCore/WorkQueue/Policy/Start/Block.py got worse in pylint. Report follows:\n* Line 40 W0511 TODO this is slow process needs to change in DBS3\n* Line 69 in Block.validBlocks R0914 Too many local variables (31/30)\n* Line 69 in Block.validBlocks R0912 Too many branches (31/12)\n* Line 16 in Block R0923 Interface not implemented\n* plus 1 comments on code style\n\ntest/python/WMCore_t/WorkQueue_t/Policy_t/Start_t/Block_t.py got worse in pylint. Report follows:\n* Line 18 W0611 Unused NOT_EXIST_DATASET imported from WMQuality.Emulators.PhEDExClient.MockPhEDExApi\n* plus 16 comments on code style\n\ntest/python/WMCore_t/WorkQueue_t/WorkQueue_t.py got worse in pylint. Report follows:\n* Line 95 in WorkQueueTest R0902 Too many instance attributes (22/7)\n* Line 601 in WorkQueueTest.testQueueChaining W0106 Expression \"[self.assertTrue(x['SubscriptionId'] > 0) for x in work]\" is assigned to nothing\n* Line 602 in WorkQueueTest.testQueueChaining W0106 Expression \"[self.assertTrue(x['SubscriptionId'] > 0) for x in self.localQueue.status()]\" is assigned to nothing\n* Line 639 in WorkQueueTest.testQueueChainingStatusUpdates W0106 Expression \"[self.localQueue.backend.updateElements(x.id, PercentComplete=100, PercentSuccess=99) for x in work]\" is assigned to nothing\n* Line 832 in WorkQueueTest.testGlobalDatasetSplitting W0612 Unused variable 'totalBlocks'\n* Line 1335 in WorkQueueTest.testSiteStatus W0106 Expression \"[self.fail(('Got new wf %s for draining site') % (x['RequestName'])) for x in self.localQueue.statusInbox() if x['RequestName'] != existing_wf]\" is assigned to nothing\n* Line 1509 in WorkQueueTest.testProcessingWithContinuousSplitting W0612 Unused variable 'work'\n* Line 352 in WorkQueueTest.createResubmitSpec W0201 Attribute 'site' defined outside __init__\n* Line 95 in WorkQueueTest R0904 Too many public methods (47/20)\n* plus 194 comments on code style\n"}}
{"actor":{"display_login":"cmsdmwmbot"}}