{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/608","repository_url":"https://api.github.com/repos/KhronosGroup/glslang","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/608/comments","events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/608/events","html_url":"https://github.com/KhronosGroup/glslang/issues/608","id":193263949,"number":608,"title":"Consistent crash every time HSLS compile fails","user":{"login":"dankbaker","id":3113043,"avatar_url":"https://avatars.githubusercontent.com/u/3113043?v=3","gravatar_id":"","url":"https://api.github.com/users/dankbaker","html_url":"https://github.com/dankbaker","followers_url":"https://api.github.com/users/dankbaker/followers","following_url":"https://api.github.com/users/dankbaker/following{/other_user}","gists_url":"https://api.github.com/users/dankbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dankbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankbaker/subscriptions","organizations_url":"https://api.github.com/users/dankbaker/orgs","repos_url":"https://api.github.com/users/dankbaker/repos","events_url":"https://api.github.com/users/dankbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dankbaker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-03T04:03:08Z","updated_at":"2016-12-03T17:02:53Z","closed_at":"2016-12-03T17:02:53Z","body":"A clear NULL pointer dereference in the link stage at this call stack, where treeRoot is null. I could add skip past the deference, but wasn't sure if that would have other consequances. This happens pretty much everytime the HLSL compilation process fails.\r\n\r\n\r\n```\r\nGet the top-level globals\r\n    TIntermSequence& globals = treeRoot->getAsAggregate()->getSequence();\r\n\r\n\r\n```\r\nthe call stack\r\n```\r\n\r\n\tglslangValidator.exe!glslang::TIntermediate::findLinkerObjects() Line 599\tC++\r\n \tglslangValidator.exe!glslang::TIntermediate::inOutLocationCheck(TInfoSink & infoSink) Line 577\tC++\r\n \tglslangValidator.exe!glslang::TIntermediate::finalCheck(TInfoSink & infoSink) Line 386\tC++\r\n \tglslangValidator.exe!glslang::TProgram::linkStage(EShLanguage stage, EShMessages messages) Line 1693\tC++\r\n \tglslangValidator.exe!glslang::TProgram::link(EShMessages messages) Line 1633\tC++\r\n \tglslangValidator.exe!CompileAndLinkShaderUnits(std::vector<ShaderCompUnit,std::allocator<ShaderCompUnit> > compUnits) Line 596\tC++\r\n \tglslangValidator.exe!CompileAndLinkShaderFiles() Line 702\tC++\r\n"},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments/264651379","html_url":"https://github.com/KhronosGroup/glslang/issues/608#issuecomment-264651379","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/608","id":264651379,"user":{"login":"dankbaker","id":3113043,"avatar_url":"https://avatars.githubusercontent.com/u/3113043?v=3","gravatar_id":"","url":"https://api.github.com/users/dankbaker","html_url":"https://github.com/dankbaker","followers_url":"https://api.github.com/users/dankbaker/followers","following_url":"https://api.github.com/users/dankbaker/following{/other_user}","gists_url":"https://api.github.com/users/dankbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dankbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankbaker/subscriptions","organizations_url":"https://api.github.com/users/dankbaker/orgs","repos_url":"https://api.github.com/users/dankbaker/repos","events_url":"https://api.github.com/users/dankbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dankbaker/received_events","type":"User","site_admin":false},"created_at":"2016-12-03T17:02:53Z","updated_at":"2016-12-03T17:02:53Z","body":"I don't see that code, so I must have merged main in just before it.\r\n"}}
{"actor":{"display_login":"dankbaker"}}