{"action":"created","issue":{"url":"https://api.github.com/repos/Seldaek/monolog/issues/773","repository_url":"https://api.github.com/repos/Seldaek/monolog","labels_url":"https://api.github.com/repos/Seldaek/monolog/issues/773/labels{/name}","comments_url":"https://api.github.com/repos/Seldaek/monolog/issues/773/comments","events_url":"https://api.github.com/repos/Seldaek/monolog/issues/773/events","html_url":"https://github.com/Seldaek/monolog/pull/773","id":149254718,"number":773,"title":"Lock down RotateFileHandler to prevent errors with rotation","user":{"login":"rpkamp","id":1059790,"avatar_url":"https://avatars.githubusercontent.com/u/1059790?v=3","gravatar_id":"","url":"https://api.github.com/users/rpkamp","html_url":"https://github.com/rpkamp","followers_url":"https://api.github.com/users/rpkamp/followers","following_url":"https://api.github.com/users/rpkamp/following{/other_user}","gists_url":"https://api.github.com/users/rpkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkamp/subscriptions","organizations_url":"https://api.github.com/users/rpkamp/orgs","repos_url":"https://api.github.com/users/rpkamp/repos","events_url":"https://api.github.com/users/rpkamp/events{/privacy}","received_events_url":"https://api.github.com/users/rpkamp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-18T19:55:40Z","updated_at":"2016-04-19T08:27:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Seldaek/monolog/pulls/773","html_url":"https://github.com/Seldaek/monolog/pull/773","diff_url":"https://github.com/Seldaek/monolog/pull/773.diff","patch_url":"https://github.com/Seldaek/monolog/pull/773.patch"},"body":"- Require the dateFormat to be one of three presets ('Y-m-d', 'Y-m' or 'Y') to\r\n  ensure that dates can be sorted lexographically\r\n- Require the filenameFormat to contain the (sub)string `{date}` so we will\r\n  actually create new files instead of the same file over and over again.\r\n\r\nFixes https://github.com/Seldaek/monolog/issues/771\r\n\r\nThis PR breaks BC in a major way so should be set for 2.0\r\nIf accepted, the checks added to `setFilenameFormat` could be added to the 1.x branch as well, but raise `E_USER_DEPRECATED` errors instead of throwing `InvalidArgumentException`s as @stof pointed out in https://github.com/Seldaek/monolog/issues/771"},"comment":{"url":"https://api.github.com/repos/Seldaek/monolog/issues/comments/211792860","html_url":"https://github.com/Seldaek/monolog/pull/773#issuecomment-211792860","issue_url":"https://api.github.com/repos/Seldaek/monolog/issues/773","id":211792860,"user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T08:27:52Z","updated_at":"2016-04-19T08:27:52Z","body":"Well, I think it would be worth adding this in 1.x first with the deprecation. It will allow warning the users earlier."}}