{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12539","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12539/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12539/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12539/events","html_url":"https://github.com/ManageIQ/manageiq/pull/12539","id":188337795,"number":12539,"title":"Delete the repo directory for Git based domains","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"labels":[{"id":182908415,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/automate","name":"automate","color":"5319e7","default":false},{"id":382968361,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/blocker","name":"blocker","color":"000000","default":false},{"id":106615676,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929","default":true},{"id":447068054,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/euwe/yes","name":"euwe/yes","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-11-09T19:56:13Z","updated_at":"2016-11-16T17:48:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12539","html_url":"https://github.com/ManageIQ/manageiq/pull/12539","diff_url":"https://github.com/ManageIQ/manageiq/pull/12539.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12539.patch"},"body":"Each Git domain has a downloaded bare repository on the appliance with the git owner role.\r\nWhen a domain is being deleted the bare repository directory should be deleted.\r\n\r\nLinks\r\n-----\r\n\r\n* https://bugzilla.redhat.com/show_bug.cgi?id=1392981\r\n* \r\n* PR #12192 (depends on)\r\n\r\nSteps for Testing/QA \r\n-------------------------------\r\n\r\nDescribed in \r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1392981"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/261018658","html_url":"https://github.com/ManageIQ/manageiq/pull/12539#issuecomment-261018658","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12539","id":261018658,"user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T17:48:52Z","updated_at":"2016-11-16T17:48:52Z","body":"I'm ok with merging as is, but there is some inconsistencies with the existing queueing (or task) pattern.\r\n\r\n- The model's `destroy` method should do the actual destroy (not on the queue)\r\n- The model should have a `destroy_queue` that calls `destroy` but through the queue.\r\n- The API and UI code should call `destroy_queue`\r\n- The external facing API endpoint should just be `destroy` (that is the User has no idea it's running off of the queue other than the fact that they get a task back)\r\n\r\nThis PR does it the opposite where https://github.com/ManageIQ/manageiq/pull/12539/files#diff-ae3d5f6a1e6dbd3e414354dca1789255R2589 is calling \"destroy\" but from a method naming it's backwards and the caller has no idea that's queue based.\r\n\r\n@gmcculloug If you are good merging as is, let's do that, and then open an issue to correct the naming."}}
{"actor":{"display_login":"Fryguy"}}