{"action":"created","comment":{"url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/comments/53382968","id":53382968,"diff_hunk":"@@ -29,9 +29,10 @@\n  */\n \n const _ = require('lodash');\n-const Bluebird = require('bluebird');\n-const fs = Bluebird.promisifyAll(require('fs'));\n-const rimraf = Bluebird.promisify(require('rimraf'));\n+const async = require('async');\n+const fs = require('fs');","path":"lib/storage.js","position":8,"original_position":8,"commit_id":"d6e72127353c592d08768bccadaea87b04d0cb3b","original_commit_id":"d6e72127353c592d08768bccadaea87b04d0cb3b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'const' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).","created_at":"2016-02-18T21:11:52Z","updated_at":"2016-02-18T21:11:52Z","html_url":"https://github.com/jviotti/electron-json-storage/pull/9#discussion_r53382968","pull_request_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/comments/53382968"},"html":{"href":"https://github.com/jviotti/electron-json-storage/pull/9#discussion_r53382968"},"pull_request":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9","id":59863745,"html_url":"https://github.com/jviotti/electron-json-storage/pull/9","diff_url":"https://github.com/jviotti/electron-json-storage/pull/9.diff","patch_url":"https://github.com/jviotti/electron-json-storage/pull/9.patch","issue_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/9","number":9,"state":"open","locked":false,"title":"Drop promises support","user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"body":"Bluebird promises collide with ES6 Promises and break the module when\nrunning in the renderer process.\n\nThis commit drops all support for promises, leaving the decision of\npromisiying the module to the end user.\n\nFixes: https://github.com/jviotti/electron-json-storage/issues/5","created_at":"2016-02-18T21:10:57Z","updated_at":"2016-02-18T21:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89f9d334a447c0de7026782eb72a8698693b9c57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9/commits","review_comments_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9/comments","review_comment_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/9/comments","statuses_url":"https://api.github.com/repos/jviotti/electron-json-storage/statuses/d6e72127353c592d08768bccadaea87b04d0cb3b","head":{"label":"jviotti:refactor/no-promises","ref":"refactor/no-promises","sha":"d6e72127353c592d08768bccadaea87b04d0cb3b","user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"repo":{"id":50390586,"name":"electron-json-storage","full_name":"jviotti/electron-json-storage","owner":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jviotti/electron-json-storage","description":"Easily write and read user settings in Electron apps","fork":false,"url":"https://api.github.com/repos/jviotti/electron-json-storage","forks_url":"https://api.github.com/repos/jviotti/electron-json-storage/forks","keys_url":"https://api.github.com/repos/jviotti/electron-json-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jviotti/electron-json-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jviotti/electron-json-storage/teams","hooks_url":"https://api.github.com/repos/jviotti/electron-json-storage/hooks","issue_events_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/events{/number}","events_url":"https://api.github.com/repos/jviotti/electron-json-storage/events","assignees_url":"https://api.github.com/repos/jviotti/electron-json-storage/assignees{/user}","branches_url":"https://api.github.com/repos/jviotti/electron-json-storage/branches{/branch}","tags_url":"https://api.github.com/repos/jviotti/electron-json-storage/tags","blobs_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jviotti/electron-json-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/jviotti/electron-json-storage/languages","stargazers_url":"https://api.github.com/repos/jviotti/electron-json-storage/stargazers","contributors_url":"https://api.github.com/repos/jviotti/electron-json-storage/contributors","subscribers_url":"https://api.github.com/repos/jviotti/electron-json-storage/subscribers","subscription_url":"https://api.github.com/repos/jviotti/electron-json-storage/subscription","commits_url":"https://api.github.com/repos/jviotti/electron-json-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/jviotti/electron-json-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/jviotti/electron-json-storage/contents/{+path}","compare_url":"https://api.github.com/repos/jviotti/electron-json-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jviotti/electron-json-storage/merges","archive_url":"https://api.github.com/repos/jviotti/electron-json-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jviotti/electron-json-storage/downloads","issues_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues{/number}","pulls_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/jviotti/electron-json-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/jviotti/electron-json-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jviotti/electron-json-storage/labels{/name}","releases_url":"https://api.github.com/repos/jviotti/electron-json-storage/releases{/id}","deployments_url":"https://api.github.com/repos/jviotti/electron-json-storage/deployments","created_at":"2016-01-26T00:15:27Z","updated_at":"2016-02-16T22:34:13Z","pushed_at":"2016-02-18T21:10:58Z","git_url":"git://github.com/jviotti/electron-json-storage.git","ssh_url":"git@github.com:jviotti/electron-json-storage.git","clone_url":"https://github.com/jviotti/electron-json-storage.git","svn_url":"https://github.com/jviotti/electron-json-storage","homepage":null,"size":26,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":30,"default_branch":"master"}},"base":{"label":"jviotti:master","ref":"master","sha":"97843ff68157ac23d8a5cc50276b07f9bcd07fa0","user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"repo":{"id":50390586,"name":"electron-json-storage","full_name":"jviotti/electron-json-storage","owner":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jviotti/electron-json-storage","description":"Easily write and read user settings in Electron apps","fork":false,"url":"https://api.github.com/repos/jviotti/electron-json-storage","forks_url":"https://api.github.com/repos/jviotti/electron-json-storage/forks","keys_url":"https://api.github.com/repos/jviotti/electron-json-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jviotti/electron-json-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jviotti/electron-json-storage/teams","hooks_url":"https://api.github.com/repos/jviotti/electron-json-storage/hooks","issue_events_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/events{/number}","events_url":"https://api.github.com/repos/jviotti/electron-json-storage/events","assignees_url":"https://api.github.com/repos/jviotti/electron-json-storage/assignees{/user}","branches_url":"https://api.github.com/repos/jviotti/electron-json-storage/branches{/branch}","tags_url":"https://api.github.com/repos/jviotti/electron-json-storage/tags","blobs_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jviotti/electron-json-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/jviotti/electron-json-storage/languages","stargazers_url":"https://api.github.com/repos/jviotti/electron-json-storage/stargazers","contributors_url":"https://api.github.com/repos/jviotti/electron-json-storage/contributors","subscribers_url":"https://api.github.com/repos/jviotti/electron-json-storage/subscribers","subscription_url":"https://api.github.com/repos/jviotti/electron-json-storage/subscription","commits_url":"https://api.github.com/repos/jviotti/electron-json-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/jviotti/electron-json-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/jviotti/electron-json-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/jviotti/electron-json-storage/contents/{+path}","compare_url":"https://api.github.com/repos/jviotti/electron-json-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jviotti/electron-json-storage/merges","archive_url":"https://api.github.com/repos/jviotti/electron-json-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jviotti/electron-json-storage/downloads","issues_url":"https://api.github.com/repos/jviotti/electron-json-storage/issues{/number}","pulls_url":"https://api.github.com/repos/jviotti/electron-json-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/jviotti/electron-json-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/jviotti/electron-json-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jviotti/electron-json-storage/labels{/name}","releases_url":"https://api.github.com/repos/jviotti/electron-json-storage/releases{/id}","deployments_url":"https://api.github.com/repos/jviotti/electron-json-storage/deployments","created_at":"2016-01-26T00:15:27Z","updated_at":"2016-02-16T22:34:13Z","pushed_at":"2016-02-18T21:10:58Z","git_url":"git://github.com/jviotti/electron-json-storage.git","ssh_url":"git@github.com:jviotti/electron-json-storage.git","clone_url":"https://github.com/jviotti/electron-json-storage.git","svn_url":"https://github.com/jviotti/electron-json-storage","homepage":null,"size":26,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9"},"html":{"href":"https://github.com/jviotti/electron-json-storage/pull/9"},"issue":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/issues/9"},"comments":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/jviotti/electron-json-storage/statuses/d6e72127353c592d08768bccadaea87b04d0cb3b"}}}}