{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/49376939","id":49376939,"diff_hunk":"@@ -47,7 +47,7 @@ class ListingContainer extends BaseComponent {\n     let pagination;\n \n     // Default paging to `true`\n-    if (shouldPage || typeof shouldPage === 'undefined') {\n+    if ((shouldPage || typeof shouldPage === 'undefined') && listings.length) {","path":"src/views/components/ListingContainer.jsx","position":5,"original_position":5,"commit_id":"2e57876408c9f7a8d81c79d94b0434546f669e1e","original_commit_id":"2e57876408c9f7a8d81c79d94b0434546f669e1e","user":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"body":"While you're at it, maybe set `shouldPage = true` in the `const { ... } = this.props` above and remove the `undefined` check","created_at":"2016-01-11T20:53:24Z","updated_at":"2016-01-11T20:53:24Z","html_url":"https://github.com/reddit/reddit-mobile/pull/437#discussion_r49376939","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/49376939"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/437#discussion_r49376939"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437","id":55676037,"html_url":"https://github.com/reddit/reddit-mobile/pull/437","diff_url":"https://github.com/reddit/reddit-mobile/pull/437.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/437.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/437","number":437,"state":"open","locked":false,"title":"Don't render pagination buttons when there are no listings","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"body":"I've been seeing errors for 'name' of undefined in `ListingPaginationButtons.jsx`. This fix bails out of rendering pagination buttons when there are no listings as the buttons component relies on having them. Doesn't make sense to show them when there are no listings either.\r\n\r\n:eyeglasses: @ajacksified @curioussavage ","created_at":"2016-01-11T20:51:57Z","updated_at":"2016-01-11T20:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97859d257b89c467d83bc6e54e48823ff5109586","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/437/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/2e57876408c9f7a8d81c79d94b0434546f669e1e","head":{"label":"schwers:undefined_name","ref":"undefined_name","sha":"2e57876408c9f7a8d81c79d94b0434546f669e1e","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"repo":{"id":46595984,"name":"reddit-mobile","full_name":"schwers/reddit-mobile","owner":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schwers/reddit-mobile","description":"","fork":true,"url":"https://api.github.com/repos/schwers/reddit-mobile","forks_url":"https://api.github.com/repos/schwers/reddit-mobile/forks","keys_url":"https://api.github.com/repos/schwers/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schwers/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schwers/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/schwers/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/schwers/reddit-mobile/events","assignees_url":"https://api.github.com/repos/schwers/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/schwers/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/schwers/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schwers/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/schwers/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schwers/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/schwers/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/schwers/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/schwers/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/schwers/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/schwers/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/schwers/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/schwers/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/schwers/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/schwers/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/schwers/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schwers/reddit-mobile/merges","archive_url":"https://api.github.com/repos/schwers/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schwers/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/schwers/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/schwers/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/schwers/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/schwers/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schwers/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/schwers/reddit-mobile/releases{/id}","created_at":"2015-11-21T01:25:16Z","updated_at":"2015-11-21T01:25:18Z","pushed_at":"2016-01-11T20:49:54Z","git_url":"git://github.com/schwers/reddit-mobile.git","ssh_url":"git@github.com:schwers/reddit-mobile.git","clone_url":"https://github.com/schwers/reddit-mobile.git","svn_url":"https://github.com/schwers/reddit-mobile","homepage":null,"size":2826,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"491c6aa7f7f99dfd163ebba50f07f46584f0d0c1","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","created_at":"2014-08-18T21:42:05Z","updated_at":"2016-01-11T10:28:53Z","pushed_at":"2016-01-11T20:53:19Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":6229,"stargazers_count":656,"watchers_count":656,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":19,"forks":94,"open_issues":19,"watchers":656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/437"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/437"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/2e57876408c9f7a8d81c79d94b0434546f669e1e"}}}}