{"action":"created","comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/comments/84799826","pull_request_review_id":5554559,"id":84799826,"diff_hunk":"@@ -13,5 +13,8 @@ if(UNIX AND NOT APPLE)\n endif()\n \n if(WITH_TESTS)\n-  add_subdirectory(test)\n-endif()\n+  # autotype non supported on Windows right now\n+  if(UNIX)","path":"src/autotype/CMakeLists.txt","position":7,"original_position":7,"commit_id":"24a17c05abdef3204d208cd9414ff3dcd201eb2f","original_commit_id":"24a17c05abdef3204d208cd9414ff3dcd201eb2f","user":{"login":"TheZ3ro","id":686894,"avatar_url":"https://avatars.githubusercontent.com/u/686894?v=3","gravatar_id":"","url":"https://api.github.com/users/TheZ3ro","html_url":"https://github.com/TheZ3ro","followers_url":"https://api.github.com/users/TheZ3ro/followers","following_url":"https://api.github.com/users/TheZ3ro/following{/other_user}","gists_url":"https://api.github.com/users/TheZ3ro/gists{/gist_id}","starred_url":"https://api.github.com/users/TheZ3ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheZ3ro/subscriptions","organizations_url":"https://api.github.com/users/TheZ3ro/orgs","repos_url":"https://api.github.com/users/TheZ3ro/repos","events_url":"https://api.github.com/users/TheZ3ro/events{/privacy}","received_events_url":"https://api.github.com/users/TheZ3ro/received_events","type":"User","site_admin":false},"body":"That file regulates only the X11 Autotype tests, that are only supported on the UNIX (not APPLE) platform right now.\r\nThis was only an \"hotfix\" to be able to build for Windows.\r\n\r\nAnyway it's better to have a folder for each platform with tests inside for various feature or each feature have it's tests done on each platform (like right now)? \r\nMaybe you are right but we need to discuss about tests because those (x11 autotype) are inside **src/autotype/** folder and they should be in the **tests/** folder","created_at":"2016-10-24T22:44:49Z","updated_at":"2016-10-24T22:44:49Z","html_url":"https://github.com/keepassxreboot/keepassx/pull/53#discussion_r84799826","pull_request_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/comments/84799826"},"html":{"href":"https://github.com/keepassxreboot/keepassx/pull/53#discussion_r84799826"},"pull_request":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53","id":90660967,"html_url":"https://github.com/keepassxreboot/keepassx/pull/53","diff_url":"https://github.com/keepassxreboot/keepassx/pull/53.diff","patch_url":"https://github.com/keepassxreboot/keepassx/pull/53.patch","issue_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/53","number":53,"state":"open","locked":false,"title":"Fix winsock and autotype error when compiling on Windows","user":{"login":"TheZ3ro","id":686894,"avatar_url":"https://avatars.githubusercontent.com/u/686894?v=3","gravatar_id":"","url":"https://api.github.com/users/TheZ3ro","html_url":"https://github.com/TheZ3ro","followers_url":"https://api.github.com/users/TheZ3ro/followers","following_url":"https://api.github.com/users/TheZ3ro/following{/other_user}","gists_url":"https://api.github.com/users/TheZ3ro/gists{/gist_id}","starred_url":"https://api.github.com/users/TheZ3ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheZ3ro/subscriptions","organizations_url":"https://api.github.com/users/TheZ3ro/orgs","repos_url":"https://api.github.com/users/TheZ3ro/repos","events_url":"https://api.github.com/users/TheZ3ro/events{/privacy}","received_events_url":"https://api.github.com/users/TheZ3ro/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nWhen compiling on Windows, the build fails for 2 motive:\r\n\r\n* Autotype on Windows isn't implemented yet but Cmake tries to build its tests anyway\r\n* keepassxhttp uses **netinet/in.h** header file for **sockaddr_in** struct. <br/>This file is not available on Windows, where instead the struct is defined in the **winsock2.h** header\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\non Windows:\r\n * Building KeePassXR was broken due to keepassxhttp.\r\n * Tests were broken due to Autotype.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2016-10-24T17:53:55Z","updated_at":"2016-10-24T22:44:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0741b61b983e0b23e37a68f8b677806ff9bfe8c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53/commits","review_comments_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53/comments","review_comment_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/53/comments","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassx/statuses/24a17c05abdef3204d208cd9414ff3dcd201eb2f","head":{"label":"keepassxreboot:feature/fix-win-build","ref":"feature/fix-win-build","sha":"24a17c05abdef3204d208cd9414ff3dcd201eb2f","user":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars.githubusercontent.com/u/22534815?v=3","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"name":"keepassx","full_name":"keepassxreboot/keepassx","owner":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars.githubusercontent.com/u/22534815?v=3","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassx","description":"KeePassX Reboot is a cross platform port of the windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassx","forks_url":"https://api.github.com/repos/keepassxreboot/keepassx/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassx/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassx/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassx/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassx/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassx/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassx/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassx/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassx/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassx/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassx/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassx/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassx/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassx/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassx/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassx/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassx/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassx/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassx/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassx/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassx/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassx/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2016-10-24T02:07:53Z","pushed_at":"2016-10-24T22:15:41Z","git_url":"git://github.com/keepassxreboot/keepassx.git","ssh_url":"git@github.com:keepassxreboot/keepassx.git","clone_url":"https://github.com/keepassxreboot/keepassx.git","svn_url":"https://github.com/keepassxreboot/keepassx","homepage":"http://www.keepassx.org/","size":4980,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":28,"forks":11,"open_issues":28,"watchers":103,"default_branch":"develop"}},"base":{"label":"keepassxreboot:develop","ref":"develop","sha":"7c4129033a804316ec5f1e3cba08f5d8a992a522","user":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars.githubusercontent.com/u/22534815?v=3","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"name":"keepassx","full_name":"keepassxreboot/keepassx","owner":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars.githubusercontent.com/u/22534815?v=3","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassx","description":"KeePassX Reboot is a cross platform port of the windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassx","forks_url":"https://api.github.com/repos/keepassxreboot/keepassx/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassx/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassx/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassx/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassx/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassx/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassx/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassx/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassx/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassx/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassx/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassx/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassx/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassx/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassx/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassx/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassx/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassx/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassx/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassx/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassx/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassx/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassx/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassx/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassx/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2016-10-24T02:07:53Z","pushed_at":"2016-10-24T22:15:41Z","git_url":"git://github.com/keepassxreboot/keepassx.git","ssh_url":"git@github.com:keepassxreboot/keepassx.git","clone_url":"https://github.com/keepassxreboot/keepassx.git","svn_url":"https://github.com/keepassxreboot/keepassx","homepage":"http://www.keepassx.org/","size":4980,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":28,"forks":11,"open_issues":28,"watchers":103,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53"},"html":{"href":"https://github.com/keepassxreboot/keepassx/pull/53"},"issue":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/issues/53"},"comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/keepassxreboot/keepassx/statuses/24a17c05abdef3204d208cd9414ff3dcd201eb2f"}}}}
{"actor":{"display_login":"TheZ3ro"}}