{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/83347812","pull_request_review_id":4198224,"id":83347812,"diff_hunk":"@@ -353,7 +353,7 @@ bool FontAtlas::prepareLetterDefinitions(const std::u16string& utf16Text)\n             tempDef.validDefinition = true;\n             tempDef.width = tempRect.size.width + _letterPadding + _letterEdgeExtend;\n             tempDef.height = tempRect.size.height + _letterPadding + _letterEdgeExtend;\n-            tempDef.offsetX = tempRect.origin.x + adjustForDistanceMap + adjustForExtend;\n+            tempDef.offsetX = tempRect.origin.x + adjustForDistanceMap - adjustForExtend;","path":"cocos/2d/CCFontAtlas.cpp","position":5,"original_position":5,"commit_id":"f05053329bcf6a295d6dcad2398bb7409615695b","original_commit_id":"f05053329bcf6a295d6dcad2398bb7409615695b","user":{"login":"dumganhar","id":493372,"avatar_url":"https://avatars.githubusercontent.com/u/493372?v=3","gravatar_id":"","url":"https://api.github.com/users/dumganhar","html_url":"https://github.com/dumganhar","followers_url":"https://api.github.com/users/dumganhar/followers","following_url":"https://api.github.com/users/dumganhar/following{/other_user}","gists_url":"https://api.github.com/users/dumganhar/gists{/gist_id}","starred_url":"https://api.github.com/users/dumganhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumganhar/subscriptions","organizations_url":"https://api.github.com/users/dumganhar/orgs","repos_url":"https://api.github.com/users/dumganhar/repos","events_url":"https://api.github.com/users/dumganhar/events{/privacy}","received_events_url":"https://api.github.com/users/dumganhar/received_events","type":"User","site_admin":false},"body":"@newnon, could you reply to my question?\r\nShould adjustForDistanceMap also be negative?","created_at":"2016-10-14T02:04:48Z","updated_at":"2016-10-14T02:04:49Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/16689#discussion_r83347812","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/83347812"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/16689#discussion_r83347812"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689","id":89018547,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/16689","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/16689.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/16689.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16689","number":16689,"state":"open","locked":false,"title":"fix font rendering position","user":{"login":"newnon","id":5040118,"avatar_url":"https://avatars.githubusercontent.com/u/5040118?v=3","gravatar_id":"","url":"https://api.github.com/users/newnon","html_url":"https://github.com/newnon","followers_url":"https://api.github.com/users/newnon/followers","following_url":"https://api.github.com/users/newnon/following{/other_user}","gists_url":"https://api.github.com/users/newnon/gists{/gist_id}","starred_url":"https://api.github.com/users/newnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newnon/subscriptions","organizations_url":"https://api.github.com/users/newnon/orgs","repos_url":"https://api.github.com/users/newnon/repos","events_url":"https://api.github.com/users/newnon/events{/privacy}","received_events_url":"https://api.github.com/users/newnon/received_events","type":"User","site_admin":false},"body":"fix font always padded on 2 pixels left","created_at":"2016-10-12T13:44:21Z","updated_at":"2016-10-14T02:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14953a755add1cac66aab14ede05e1344c273201","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16689/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/f05053329bcf6a295d6dcad2398bb7409615695b","head":{"label":"newnon:v3_font_fix","ref":"v3_font_fix","sha":"f05053329bcf6a295d6dcad2398bb7409615695b","user":{"login":"newnon","id":5040118,"avatar_url":"https://avatars.githubusercontent.com/u/5040118?v=3","gravatar_id":"","url":"https://api.github.com/users/newnon","html_url":"https://github.com/newnon","followers_url":"https://api.github.com/users/newnon/followers","following_url":"https://api.github.com/users/newnon/following{/other_user}","gists_url":"https://api.github.com/users/newnon/gists{/gist_id}","starred_url":"https://api.github.com/users/newnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newnon/subscriptions","organizations_url":"https://api.github.com/users/newnon/orgs","repos_url":"https://api.github.com/users/newnon/repos","events_url":"https://api.github.com/users/newnon/events{/privacy}","received_events_url":"https://api.github.com/users/newnon/received_events","type":"User","site_admin":false},"repo":{"id":15003647,"name":"cocos2d-x","full_name":"newnon/cocos2d-x","owner":{"login":"newnon","id":5040118,"avatar_url":"https://avatars.githubusercontent.com/u/5040118?v=3","gravatar_id":"","url":"https://api.github.com/users/newnon","html_url":"https://github.com/newnon","followers_url":"https://api.github.com/users/newnon/followers","following_url":"https://api.github.com/users/newnon/following{/other_user}","gists_url":"https://api.github.com/users/newnon/gists{/gist_id}","starred_url":"https://api.github.com/users/newnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newnon/subscriptions","organizations_url":"https://api.github.com/users/newnon/orgs","repos_url":"https://api.github.com/users/newnon/repos","events_url":"https://api.github.com/users/newnon/events{/privacy}","received_events_url":"https://api.github.com/users/newnon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/newnon/cocos2d-x","description":"cocos2d for iOS, Android, Win32 and OS X. Built using C++","fork":true,"url":"https://api.github.com/repos/newnon/cocos2d-x","forks_url":"https://api.github.com/repos/newnon/cocos2d-x/forks","keys_url":"https://api.github.com/repos/newnon/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newnon/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newnon/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/newnon/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/newnon/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/newnon/cocos2d-x/events","assignees_url":"https://api.github.com/repos/newnon/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/newnon/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/newnon/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/newnon/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newnon/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newnon/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/newnon/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newnon/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/newnon/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/newnon/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/newnon/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/newnon/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/newnon/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/newnon/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/newnon/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/newnon/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/newnon/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/newnon/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/newnon/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newnon/cocos2d-x/merges","archive_url":"https://api.github.com/repos/newnon/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newnon/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/newnon/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/newnon/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/newnon/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/newnon/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newnon/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/newnon/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/newnon/cocos2d-x/deployments","created_at":"2013-12-07T10:07:15Z","updated_at":"2014-07-17T23:49:04Z","pushed_at":"2016-10-13T12:51:56Z","git_url":"git://github.com/newnon/cocos2d-x.git","ssh_url":"git@github.com:newnon/cocos2d-x.git","clone_url":"https://github.com/newnon/cocos2d-x.git","svn_url":"https://github.com/newnon/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1014756,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"3.1-hotfix"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"93609ff586da4e284bf973ef4c2bec9088fc11ba","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2016-10-13T21:43:27Z","pushed_at":"2016-10-13T21:37:25Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1533315,"stargazers_count":8904,"watchers_count":8904,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5733,"mirror_url":null,"open_issues_count":969,"forks":5733,"open_issues":969,"watchers":8904,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/16689"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16689"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16689/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16689/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/f05053329bcf6a295d6dcad2398bb7409615695b"}}}}
{"actor":{"display_login":"dumganhar"}}