{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/15333","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/15333/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/15333/comments","events_url":"https://api.github.com/repos/apache/spark/issues/15333/events","html_url":"https://github.com/apache/spark/pull/15333","id":180712167,"number":15333,"title":"[SPARK-17761][SQL] Remove MutableRow","user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars.githubusercontent.com/u/9616802?v=3","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-03T18:31:56Z","updated_at":"2016-10-04T02:38:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15333","html_url":"https://github.com/apache/spark/pull/15333","diff_url":"https://github.com/apache/spark/pull/15333.diff","patch_url":"https://github.com/apache/spark/pull/15333.patch"},"body":"## What changes were proposed in this pull request?\r\nIn practice we cannot guarantee that an `InternalRow` is immutable. This makes the `MutableRow` almost redundant. This PR folds `MutableRow` into `InternalRow`.\r\n\r\nThis might be somewhat controversial, so feedback is appreciated.\r\n\r\n## How was this patch tested?\r\nExisting tests."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/251281172","html_url":"https://github.com/apache/spark/pull/15333#issuecomment-251281172","issue_url":"https://api.github.com/repos/apache/spark/issues/15333","id":251281172,"user":{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=3","gravatar_id":"","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T02:38:33Z","updated_at":"2016-10-04T02:38:33Z","body":"Would be nice to add a simple example to illustrate why we can't ensure that a `GenericInternalRow` is immutable. For example, for a `GenericInternalRow` with a `StructType` field, it's legal to put a `MutableRow` into the cell. This essentially makes the outer `GenericInternalRow` mutable. (In fact, we are already doing this in Spark, either intentionally or unintentionally.)"}}
{"actor":{"display_login":"liancheng"}}