{"push_id":1325555894,"size":4,"distinct_size":1,"ref":"refs/heads/la-milestone-2","head":"20e1b871a2455129ff0b22b4d49e9f858dc9b34e","before":"ef2249b91a32aa2f73255be5ee4e3771c654336f","commits":[{"sha":"a199949f6e907fcf15d166ee4f4359d215a87c09","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1601: Extract helper methods to a separate trait","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/a199949f6e907fcf15d166ee4f4359d215a87c09"},{"sha":"af142bd19f55d5fd153066e5c398e6f810ec5d67","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1600: Add the getStartAndEndDates methods to the LeavePeriodEntitlement","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/af142bd19f55d5fd153066e5c398e6f810ec5d67"},{"sha":"b72a40b08895e6f5cbb69a366cfec54fd78740c3","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1601: Remove entitlement_id from LeaveRequest\n\nWith this change, the LeaveRequest won't be linked to\nthe LeavePeriodEntitlement anymore. Now, in order to\nknow which LeaveRequest was taken during a period, we\njust fetch the LeaveRequest between the LeavePeriodEntitlement\ndates (which are based on the AbsencePeriod and Contract\ndates). This gives us some flexibility to change the\ncontract or period dates and \"move\" the LeaveRequest\nto another period.\n\nTwo new fields where added to the LeaveRequest entity:\ntype_id, which is a FK to an AbsenceType; and contact_id,\nwhich is a FK to Contact and represents the use who will\nbe taking the leave. All the methods (and related tests)\nused to fetch the the leave balance during an leave period\nwere updated to use these new fields. So, basically, to get\nthe number of leaves taken during a period we now do something\nlike: get all leave balance changes from leave requests where\nthe type_id is equal to the leave period entitlement type_id\nand contact_id is equals to the leave period entitlement\ncontract contact_id and which the dates are in between the\nleave period entitlement dates.\n\nNote: On LeaveBalanceChangeTest, I commented out a few tests\nabout expiring records. These tests started failing after\nthis change, but there's another ticket to change their logic,\nso there's no point to spend time fixing something that will\nchange soon.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/b72a40b08895e6f5cbb69a366cfec54fd78740c3"},{"sha":"20e1b871a2455129ff0b22b4d49e9f858dc9b34e","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"Merge pull request #1191 from civicrm/PCHR-1601-change-leave-request-to-no-depend-on-leave-period-entitlement\n\nPCHR-1601: Change LeaveRequest to no depend on LeavePeriodEntitlement","distinct":true,"url":"https://api.github.com/repos/civicrm/civihr/commits/20e1b871a2455129ff0b22b4d49e9f858dc9b34e"}]}
{"actor":{"display_login":"davialexandre"}}