{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/81701712","pull_request_review_id":2661773,"id":81701712,"diff_hunk":"@@ -25,13 +25,15 @@ namespace pool_enum {\n enum PoolingOpInputs {kData};\n enum PoolingOpOutputs {kOut};\n enum PoolingOpType {kMaxPooling, kAvgPooling, kSumPooling};\n+enum PoolingOpPadConventionType {kValid, kFull};\n }  // namespace pool_enum\n \n struct PoolingParam : public dmlc::Parameter<PoolingParam> {\n   TShape kernel;\n   TShape stride;\n   TShape pad;\n   int pool_type;\n+  int pooling_convention;","path":"src/operator/pooling-inl.h","position":12,"original_position":12,"commit_id":"fb12d0bed1c8461aad9f9bc2c4d3f6db15a81371","original_commit_id":"abda31c8767175e6e7cadfe86262c551ede02f4b","user":{"login":"Darwin2011","id":5976561,"avatar_url":"https://avatars.githubusercontent.com/u/5976561?v=3","gravatar_id":"","url":"https://api.github.com/users/Darwin2011","html_url":"https://github.com/Darwin2011","followers_url":"https://api.github.com/users/Darwin2011/followers","following_url":"https://api.github.com/users/Darwin2011/following{/other_user}","gists_url":"https://api.github.com/users/Darwin2011/gists{/gist_id}","starred_url":"https://api.github.com/users/Darwin2011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darwin2011/subscriptions","organizations_url":"https://api.github.com/users/Darwin2011/orgs","repos_url":"https://api.github.com/users/Darwin2011/repos","events_url":"https://api.github.com/users/Darwin2011/events{/privacy}","received_events_url":"https://api.github.com/users/Darwin2011/received_events","type":"User","site_admin":false},"body":"Okay","created_at":"2016-10-04T07:49:23Z","updated_at":"2016-10-04T07:49:23Z","html_url":"https://github.com/dmlc/mxnet/pull/3438#discussion_r81701712","pull_request_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3438","_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/81701712"},"html":{"href":"https://github.com/dmlc/mxnet/pull/3438#discussion_r81701712"},"pull_request":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3438"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/3438","id":87832447,"html_url":"https://github.com/dmlc/mxnet/pull/3438","diff_url":"https://github.com/dmlc/mxnet/pull/3438.diff","patch_url":"https://github.com/dmlc/mxnet/pull/3438.patch","issue_url":"https://api.github.com/repos/dmlc/mxnet/issues/3438","number":3438,"state":"open","locked":false,"title":"MKLdnn Integration Support Patch for mxnet","user":{"login":"Darwin2011","id":5976561,"avatar_url":"https://avatars.githubusercontent.com/u/5976561?v=3","gravatar_id":"","url":"https://api.github.com/users/Darwin2011","html_url":"https://github.com/Darwin2011","followers_url":"https://api.github.com/users/Darwin2011/followers","following_url":"https://api.github.com/users/Darwin2011/following{/other_user}","gists_url":"https://api.github.com/users/Darwin2011/gists{/gist_id}","starred_url":"https://api.github.com/users/Darwin2011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darwin2011/subscriptions","organizations_url":"https://api.github.com/users/Darwin2011/orgs","repos_url":"https://api.github.com/users/Darwin2011/repos","events_url":"https://api.github.com/users/Darwin2011/events{/privacy}","received_events_url":"https://api.github.com/users/Darwin2011/received_events","type":"User","site_admin":false},"body":"Hi, @piiswrong \r\n\r\nThis PR integrates MKLDNN into mxnet including all the major operations(conv, pool, lrn, bn and fc).\r\nIt turns out we can achieve 750+ fps for alexnet scoring and 280+ fps for Googlenet-v1 scoring with this patch in two-socket broadwell server and the backward also can benefit greatly from this patch. \r\n\r\nPlease review the patches then give us feedbacks.\r\nThanks.","created_at":"2016-10-04T04:37:40Z","updated_at":"2016-10-04T07:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"739084a803f91311941351ff8b2972c7a5eb2bce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3438/commits","review_comments_url":"https://api.github.com/repos/dmlc/mxnet/pulls/3438/comments","review_comment_url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/mxnet/issues/3438/comments","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/fb12d0bed1c8461aad9f9bc2c4d3f6db15a81371","head":{"label":"Darwin2011:mkldnn","ref":"mkldnn","sha":"fb12d0bed1c8461aad9f9bc2c4d3f6db15a81371","user":{"login":"Darwin2011","id":5976561,"avatar_url":"https://avatars.githubusercontent.com/u/5976561?v=3","gravatar_id":"","url":"https://api.github.com/users/Darwin2011","html_url":"https://github.com/Darwin2011","followers_url":"https://api.github.com/users/Darwin2011/followers","following_url":"https://api.github.com/users/Darwin2011/following{/other_user}","gists_url":"https://api.github.com/users/Darwin2011/gists{/gist_id}","starred_url":"https://api.github.com/users/Darwin2011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darwin2011/subscriptions","organizations_url":"https://api.github.com/users/Darwin2011/orgs","repos_url":"https://api.github.com/users/Darwin2011/repos","events_url":"https://api.github.com/users/Darwin2011/events{/privacy}","received_events_url":"https://api.github.com/users/Darwin2011/received_events","type":"User","site_admin":false},"repo":{"id":69428307,"name":"mxnet","full_name":"Darwin2011/mxnet","owner":{"login":"Darwin2011","id":5976561,"avatar_url":"https://avatars.githubusercontent.com/u/5976561?v=3","gravatar_id":"","url":"https://api.github.com/users/Darwin2011","html_url":"https://github.com/Darwin2011","followers_url":"https://api.github.com/users/Darwin2011/followers","following_url":"https://api.github.com/users/Darwin2011/following{/other_user}","gists_url":"https://api.github.com/users/Darwin2011/gists{/gist_id}","starred_url":"https://api.github.com/users/Darwin2011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darwin2011/subscriptions","organizations_url":"https://api.github.com/users/Darwin2011/orgs","repos_url":"https://api.github.com/users/Darwin2011/repos","events_url":"https://api.github.com/users/Darwin2011/events{/privacy}","received_events_url":"https://api.github.com/users/Darwin2011/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Darwin2011/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/Darwin2011/mxnet","forks_url":"https://api.github.com/repos/Darwin2011/mxnet/forks","keys_url":"https://api.github.com/repos/Darwin2011/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Darwin2011/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Darwin2011/mxnet/teams","hooks_url":"https://api.github.com/repos/Darwin2011/mxnet/hooks","issue_events_url":"https://api.github.com/repos/Darwin2011/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/Darwin2011/mxnet/events","assignees_url":"https://api.github.com/repos/Darwin2011/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/Darwin2011/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/Darwin2011/mxnet/tags","blobs_url":"https://api.github.com/repos/Darwin2011/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Darwin2011/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Darwin2011/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Darwin2011/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Darwin2011/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Darwin2011/mxnet/languages","stargazers_url":"https://api.github.com/repos/Darwin2011/mxnet/stargazers","contributors_url":"https://api.github.com/repos/Darwin2011/mxnet/contributors","subscribers_url":"https://api.github.com/repos/Darwin2011/mxnet/subscribers","subscription_url":"https://api.github.com/repos/Darwin2011/mxnet/subscription","commits_url":"https://api.github.com/repos/Darwin2011/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Darwin2011/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Darwin2011/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Darwin2011/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Darwin2011/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/Darwin2011/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Darwin2011/mxnet/merges","archive_url":"https://api.github.com/repos/Darwin2011/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Darwin2011/mxnet/downloads","issues_url":"https://api.github.com/repos/Darwin2011/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/Darwin2011/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Darwin2011/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Darwin2011/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Darwin2011/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/Darwin2011/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/Darwin2011/mxnet/deployments","created_at":"2016-09-28T05:20:02Z","updated_at":"2016-09-28T05:20:05Z","pushed_at":"2016-10-04T04:58:22Z","git_url":"git://github.com/Darwin2011/mxnet.git","ssh_url":"git@github.com:Darwin2011/mxnet.git","clone_url":"https://github.com/Darwin2011/mxnet.git","svn_url":"https://github.com/Darwin2011/mxnet","homepage":"http://mxnet.io","size":9185,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"1d06b81f200ec7b9a3d8cf8b45ba5b4e1ed7843a","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"mxnet","full_name":"dmlc/mxnet","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/dmlc/mxnet","forks_url":"https://api.github.com/repos/dmlc/mxnet/forks","keys_url":"https://api.github.com/repos/dmlc/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/mxnet/teams","hooks_url":"https://api.github.com/repos/dmlc/mxnet/hooks","issue_events_url":"https://api.github.com/repos/dmlc/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/mxnet/events","assignees_url":"https://api.github.com/repos/dmlc/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/mxnet/tags","blobs_url":"https://api.github.com/repos/dmlc/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/mxnet/languages","stargazers_url":"https://api.github.com/repos/dmlc/mxnet/stargazers","contributors_url":"https://api.github.com/repos/dmlc/mxnet/contributors","subscribers_url":"https://api.github.com/repos/dmlc/mxnet/subscribers","subscription_url":"https://api.github.com/repos/dmlc/mxnet/subscription","commits_url":"https://api.github.com/repos/dmlc/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/mxnet/merges","archive_url":"https://api.github.com/repos/dmlc/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/mxnet/downloads","issues_url":"https://api.github.com/repos/dmlc/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2016-10-04T06:54:14Z","pushed_at":"2016-10-04T04:58:22Z","git_url":"git://github.com/dmlc/mxnet.git","ssh_url":"git@github.com:dmlc/mxnet.git","clone_url":"https://github.com/dmlc/mxnet.git","svn_url":"https://github.com/dmlc/mxnet","homepage":"http://mxnet.io","size":13532,"stargazers_count":5309,"watchers_count":5309,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2015,"mirror_url":null,"open_issues_count":700,"forks":2015,"open_issues":700,"watchers":5309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3438"},"html":{"href":"https://github.com/dmlc/mxnet/pull/3438"},"issue":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/3438"},"comments":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/3438/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3438/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/3438/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/mxnet/statuses/fb12d0bed1c8461aad9f9bc2c4d3f6db15a81371"}}}}
{"actor":{"display_login":"Darwin2011"}}