{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/2633","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/2633/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/2633/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/2633/events","html_url":"https://github.com/zulip/zulip/pull/2633","id":193986111,"number":2633,"title":"WIP: Reactions frontend","user":{"login":"arpith","id":62899,"avatar_url":"https://avatars.githubusercontent.com/u/62899?v=3","gravatar_id":"","url":"https://api.github.com/users/arpith","html_url":"https://github.com/arpith","followers_url":"https://api.github.com/users/arpith/followers","following_url":"https://api.github.com/users/arpith/following{/other_user}","gists_url":"https://api.github.com/users/arpith/gists{/gist_id}","starred_url":"https://api.github.com/users/arpith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpith/subscriptions","organizations_url":"https://api.github.com/users/arpith/orgs","repos_url":"https://api.github.com/users/arpith/repos","events_url":"https://api.github.com/users/arpith/events{/privacy}","received_events_url":"https://api.github.com/users/arpith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-07T08:25:52Z","updated_at":"2016-12-21T17:14:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/2633","html_url":"https://github.com/zulip/zulip/pull/2633","diff_url":"https://github.com/zulip/zulip/pull/2633.diff","patch_url":"https://github.com/zulip/zulip/pull/2633.patch"},"body":"This PR replaces the placeholder \"clipboard\" button with a reaction button.\r\nWhen clicked, a popover with a search bar and a list of emojis is displayed.\r\nTyping in the search bar filters emojis.\r\n\r\nClicking on an emoji sends a request to the add reaction API endpoint.\r\n\r\nThe frontend also listens for reaction events. When an add-reaction event is\r\nreceived, the emoji is displayed at the bottom of the message with a\r\ncount initialized to 1. If there was an existing reaction to the message with\r\nthe same emoji, the count is incremented.\r\n\r\nWhen clicking the emoji reaction at the bottom of the message, if the\r\nuser has already reacted with that emoji to this message, the reaction\r\nis removed and the count is decremented. Otherwise, a reaction is added\r\nand the count is incremented.\r\n"},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/268579673","html_url":"https://github.com/zulip/zulip/pull/2633#issuecomment-268579673","issue_url":"https://api.github.com/repos/zulip/zulip/issues/2633","id":268579673,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T17:14:50Z","updated_at":"2016-12-21T17:14:50Z","body":"Cool!  This looks great from a functionality perspective!  A few notes on little UI polish issues:\r\n* The emoji symbol in the message body doesn't highlight on hover like the caret does.\r\n* Clicking on an emoji reaction to delete it pops open the compose box; I think you're missing a preventDefault or stopPropagation there.\r\n* When hovering over an emoji reaction, the message should include both who reacted and what the reaction was.  Slack's formatting for this seems pretty reasonable to copy.\r\n* The emoji reactions should probably be intended to align with the start of message bodies, not with the sender name.\r\n* It appears with this CSS, every message has a space under it for emoji reactions.  That vertical space should only be present if there are actual emoji reactions in the current message.\r\n* There should probably be a visible-on-hover-over-the-emoji-reactions-row offer to add your own (Slack does this well).\r\n* The emoji picker scrollbar should probably stay on the right (or maybe just be invisible) in the case that there aren't enough emoji to pick in this screenshot:\r\n![image](https://cloud.githubusercontent.com/assets/2746074/21398711/28d04942-c75d-11e6-80d5-ca99081b9a06.png)\r\n\r\nIf you have limited time, I'd focus on the Javascript/logic items; @brockwhittaker will probably be faster on the CSS optimizations.  \r\n\r\nNow going to take a quick look at the code as well."}}
{"actor":{"display_login":"timabbott"}}