{"action":"created","comment":{"url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/comments/51662073","id":51662073,"diff_hunk":"@@ -57,21 +56,74 @@ describe('EC2Store', () => {\n \t\t\t\t\texpect(snapList.length).to.be(2);\n \t\t\t\t\texpect(snapList).to.eql([\n \t\t\t\t\t\t{\n-\t\t\t\t\t\t  ExpiryDate: 201601271120,\n-\t\t\t\t\t\t  Name: \"web-xvdf-backup-2015-12-27-00-19\",\n-\t\t\t\t\t\t  SnapshotId: \"snap-6c9f5062\",\n-\t\t\t\t\t\t  StartTime: \"Sun Dec 27 2015 00:19:31 GMT+1100 (AEDT)\"\n+\t\t\t\t\t\t\tExpiryDate: \"20160127112018\",\n+\t\t\t\t\t\t\tName: \"web-xvdf-backup-2015-12-27-00-19\",\n+\t\t\t\t\t\t\tSnapshotId: \"snap-6c9f5062\",\n+\t\t\t\t\t\t\tStartTime: \"Sun Dec 27 2015 00:19:31 GMT+1100 (AEDT)\",\n+\t\t\t\t\t\t\tTags: {\n+\t\t\t\t\t\t\t\tName: \"web-xvdf-backup-2015-12-27-00-19\",\n+\t\t\t\t\t\t\t\t\"backups:config-v0\": \"ExpiryDate:20160127112018\"\n+\t\t\t\t\t\t\t}\n \t\t\t\t\t\t},\n \t\t\t\t\t\t{\n-\t\t\t\t\t\t  ExpiryDate: 201605271121,\n-\t\t\t\t\t\t  Name: \"web-xvdf-backup-2016-01-02-06-58\",\n-\t\t\t\t\t\t  SnapshotId: \"snap-d9d374d7\",\n-\t\t\t\t\t\t  StartTime: \"Sat Jan 02 2016 06:58:55 GMT+1100 (AEDT)\"\n+\t\t\t\t\t\t\tExpiryDate: \"20160527112111\",\n+\t\t\t\t\t\t\tName: \"web-xvdf-backup-2016-01-02-06-58\",\n+\t\t\t\t\t\t\tSnapshotId: \"snap-d9d374d7\",\n+\t\t\t\t\t\t\tStartTime: \"Sat Jan 02 2016 06:58:55 GMT+1100 (AEDT)\",\n+\t\t\t\t\t\t\tTags: {\n+\t\t\t\t\t\t\t\tName: \"web-xvdf-backup-2016-01-02-06-58\",\n+\t\t\t\t\t\t\t\t\"backups:config-v0\": \"OtherMetadata:some_random_junk,ExpiryDate:20160527112111\"\n+\t\t\t\t\t\t\t}\n \t\t\t\t\t\t}\n \t\t\t\t\t]);\n \t\t\t\t\treturn;\n \t\t\t\t});\n \t\t});\n+\n+\t\tit('should gracefully handle bad tags on snapshots', () => {\n+\t\t\tmockEC2.describeSnapshots = sinon.stub().yields(null, ec2Responses.snapshots2);\n+\n+\t\t\treturn ec2Store.listSnapshots()\n+\t\t\t\t.then(snapList => {","path":"test/_TestEC2Store.js","position":48,"original_position":48,"commit_id":"e6de1ed4301f722f1ec16907be7f3971e2495e1f","original_commit_id":"e6de1ed4301f722f1ec16907be7f3971e2495e1f","user":{"login":"Dermah","id":2516806,"avatar_url":"https://avatars.githubusercontent.com/u/2516806?v=3","gravatar_id":"","url":"https://api.github.com/users/Dermah","html_url":"https://github.com/Dermah","followers_url":"https://api.github.com/users/Dermah/followers","following_url":"https://api.github.com/users/Dermah/following{/other_user}","gists_url":"https://api.github.com/users/Dermah/gists{/gist_id}","starred_url":"https://api.github.com/users/Dermah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dermah/subscriptions","organizations_url":"https://api.github.com/users/Dermah/orgs","repos_url":"https://api.github.com/users/Dermah/repos","events_url":"https://api.github.com/users/Dermah/events{/privacy}","received_events_url":"https://api.github.com/users/Dermah/received_events","type":"User","site_admin":false},"body":"No, it doesn't ignore the snapshot completely. \r\n\r\nAt the moment I'm thinking, if it has a `backups:config-v0` tag in any form then the backup manager should take a look at it, but I'm open to debate. ","created_at":"2016-02-03T00:38:55Z","updated_at":"2016-02-03T00:38:55Z","html_url":"https://github.com/Trioxis/aws-backup-manager/pull/24#discussion_r51662073","pull_request_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/comments/51662073"},"html":{"href":"https://github.com/Trioxis/aws-backup-manager/pull/24#discussion_r51662073"},"pull_request":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24","id":58061047,"html_url":"https://github.com/Trioxis/aws-backup-manager/pull/24","diff_url":"https://github.com/Trioxis/aws-backup-manager/pull/24.diff","patch_url":"https://github.com/Trioxis/aws-backup-manager/pull/24.patch","issue_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/24","number":24,"state":"open","locked":false,"title":"Improve listSnapshots","user":{"login":"Dermah","id":2516806,"avatar_url":"https://avatars.githubusercontent.com/u/2516806?v=3","gravatar_id":"","url":"https://api.github.com/users/Dermah","html_url":"https://github.com/Dermah","followers_url":"https://api.github.com/users/Dermah/followers","following_url":"https://api.github.com/users/Dermah/following{/other_user}","gists_url":"https://api.github.com/users/Dermah/gists{/gist_id}","starred_url":"https://api.github.com/users/Dermah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dermah/subscriptions","organizations_url":"https://api.github.com/users/Dermah/orgs","repos_url":"https://api.github.com/users/Dermah/repos","events_url":"https://api.github.com/users/Dermah/events{/privacy}","received_events_url":"https://api.github.com/users/Dermah/received_events","type":"User","site_admin":false},"body":"Make listSnapshots more robust. Can handle invalid values for `backups:config-v0` and warns about them.","created_at":"2016-02-02T22:30:02Z","updated_at":"2016-02-03T00:38:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"111a5a4dc4cbda5c9baa22394184ae6aeaeff273","assignee":{"login":"mrjackdavis","id":1670700,"avatar_url":"https://avatars.githubusercontent.com/u/1670700?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjackdavis","html_url":"https://github.com/mrjackdavis","followers_url":"https://api.github.com/users/mrjackdavis/followers","following_url":"https://api.github.com/users/mrjackdavis/following{/other_user}","gists_url":"https://api.github.com/users/mrjackdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjackdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjackdavis/subscriptions","organizations_url":"https://api.github.com/users/mrjackdavis/orgs","repos_url":"https://api.github.com/users/mrjackdavis/repos","events_url":"https://api.github.com/users/mrjackdavis/events{/privacy}","received_events_url":"https://api.github.com/users/mrjackdavis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Trioxis/aws-backup-manager/milestones/1","html_url":"https://github.com/Trioxis/aws-backup-manager/milestones/(v0.1.1)%20EC2Store%20Works","labels_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/milestones/1/labels","id":1488838,"number":1,"title":"(v0.1.1) EC2Store Works","description":"As of now, this app does almost nothing. The very first step to having something useful is to make it get some useful info from EC2.\r\n\r\n**Requirements:**\r\nThe `EC2Store` class successfully connects to EC2 (using the provided and/or externally set AWS credentials) and\r\n* gets all relevant snapshot information,\r\n* gets all relevant EBS volume information\r\n\r\nand returns them in a nice useable format.","creator":{"login":"Dermah","id":2516806,"avatar_url":"https://avatars.githubusercontent.com/u/2516806?v=3","gravatar_id":"","url":"https://api.github.com/users/Dermah","html_url":"https://github.com/Dermah","followers_url":"https://api.github.com/users/Dermah/followers","following_url":"https://api.github.com/users/Dermah/following{/other_user}","gists_url":"https://api.github.com/users/Dermah/gists{/gist_id}","starred_url":"https://api.github.com/users/Dermah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dermah/subscriptions","organizations_url":"https://api.github.com/users/Dermah/orgs","repos_url":"https://api.github.com/users/Dermah/repos","events_url":"https://api.github.com/users/Dermah/events{/privacy}","received_events_url":"https://api.github.com/users/Dermah/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":5,"state":"open","created_at":"2016-01-07T04:50:40Z","updated_at":"2016-02-02T22:30:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/24/comments","statuses_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/statuses/e6de1ed4301f722f1ec16907be7f3971e2495e1f","head":{"label":"Trioxis:fix/listSnapshots-input-#22","ref":"fix/listSnapshots-input-#22","sha":"e6de1ed4301f722f1ec16907be7f3971e2495e1f","user":{"login":"Trioxis","id":8978304,"avatar_url":"https://avatars.githubusercontent.com/u/8978304?v=3","gravatar_id":"","url":"https://api.github.com/users/Trioxis","html_url":"https://github.com/Trioxis","followers_url":"https://api.github.com/users/Trioxis/followers","following_url":"https://api.github.com/users/Trioxis/following{/other_user}","gists_url":"https://api.github.com/users/Trioxis/gists{/gist_id}","starred_url":"https://api.github.com/users/Trioxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trioxis/subscriptions","organizations_url":"https://api.github.com/users/Trioxis/orgs","repos_url":"https://api.github.com/users/Trioxis/repos","events_url":"https://api.github.com/users/Trioxis/events{/privacy}","received_events_url":"https://api.github.com/users/Trioxis/received_events","type":"Organization","site_admin":false},"repo":{"id":48353764,"name":"aws-backup-manager","full_name":"Trioxis/aws-backup-manager","owner":{"login":"Trioxis","id":8978304,"avatar_url":"https://avatars.githubusercontent.com/u/8978304?v=3","gravatar_id":"","url":"https://api.github.com/users/Trioxis","html_url":"https://github.com/Trioxis","followers_url":"https://api.github.com/users/Trioxis/followers","following_url":"https://api.github.com/users/Trioxis/following{/other_user}","gists_url":"https://api.github.com/users/Trioxis/gists{/gist_id}","starred_url":"https://api.github.com/users/Trioxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trioxis/subscriptions","organizations_url":"https://api.github.com/users/Trioxis/orgs","repos_url":"https://api.github.com/users/Trioxis/repos","events_url":"https://api.github.com/users/Trioxis/events{/privacy}","received_events_url":"https://api.github.com/users/Trioxis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Trioxis/aws-backup-manager","description":"Automatically back up EBS volumes using tags","fork":false,"url":"https://api.github.com/repos/Trioxis/aws-backup-manager","forks_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/forks","keys_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/teams","hooks_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/hooks","issue_events_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/events","assignees_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/tags","blobs_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/languages","stargazers_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/stargazers","contributors_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/contributors","subscribers_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/subscribers","subscription_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/subscription","commits_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/merges","archive_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/downloads","issues_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/labels{/name}","releases_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/deployments","created_at":"2015-12-21T06:01:30Z","updated_at":"2016-01-13T02:52:04Z","pushed_at":"2016-02-03T00:24:45Z","git_url":"git://github.com/Trioxis/aws-backup-manager.git","ssh_url":"git@github.com:Trioxis/aws-backup-manager.git","clone_url":"https://github.com/Trioxis/aws-backup-manager.git","svn_url":"https://github.com/Trioxis/aws-backup-manager","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"Trioxis:master","ref":"master","sha":"f2002ede1ab51b7f280f8ff2da24ad406a513d8f","user":{"login":"Trioxis","id":8978304,"avatar_url":"https://avatars.githubusercontent.com/u/8978304?v=3","gravatar_id":"","url":"https://api.github.com/users/Trioxis","html_url":"https://github.com/Trioxis","followers_url":"https://api.github.com/users/Trioxis/followers","following_url":"https://api.github.com/users/Trioxis/following{/other_user}","gists_url":"https://api.github.com/users/Trioxis/gists{/gist_id}","starred_url":"https://api.github.com/users/Trioxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trioxis/subscriptions","organizations_url":"https://api.github.com/users/Trioxis/orgs","repos_url":"https://api.github.com/users/Trioxis/repos","events_url":"https://api.github.com/users/Trioxis/events{/privacy}","received_events_url":"https://api.github.com/users/Trioxis/received_events","type":"Organization","site_admin":false},"repo":{"id":48353764,"name":"aws-backup-manager","full_name":"Trioxis/aws-backup-manager","owner":{"login":"Trioxis","id":8978304,"avatar_url":"https://avatars.githubusercontent.com/u/8978304?v=3","gravatar_id":"","url":"https://api.github.com/users/Trioxis","html_url":"https://github.com/Trioxis","followers_url":"https://api.github.com/users/Trioxis/followers","following_url":"https://api.github.com/users/Trioxis/following{/other_user}","gists_url":"https://api.github.com/users/Trioxis/gists{/gist_id}","starred_url":"https://api.github.com/users/Trioxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trioxis/subscriptions","organizations_url":"https://api.github.com/users/Trioxis/orgs","repos_url":"https://api.github.com/users/Trioxis/repos","events_url":"https://api.github.com/users/Trioxis/events{/privacy}","received_events_url":"https://api.github.com/users/Trioxis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Trioxis/aws-backup-manager","description":"Automatically back up EBS volumes using tags","fork":false,"url":"https://api.github.com/repos/Trioxis/aws-backup-manager","forks_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/forks","keys_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/teams","hooks_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/hooks","issue_events_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/events","assignees_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/tags","blobs_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/languages","stargazers_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/stargazers","contributors_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/contributors","subscribers_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/subscribers","subscription_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/subscription","commits_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/merges","archive_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/downloads","issues_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/labels{/name}","releases_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Trioxis/aws-backup-manager/deployments","created_at":"2015-12-21T06:01:30Z","updated_at":"2016-01-13T02:52:04Z","pushed_at":"2016-02-03T00:24:45Z","git_url":"git://github.com/Trioxis/aws-backup-manager.git","ssh_url":"git@github.com:Trioxis/aws-backup-manager.git","clone_url":"https://github.com/Trioxis/aws-backup-manager.git","svn_url":"https://github.com/Trioxis/aws-backup-manager","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24"},"html":{"href":"https://github.com/Trioxis/aws-backup-manager/pull/24"},"issue":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/24"},"comments":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Trioxis/aws-backup-manager/statuses/e6de1ed4301f722f1ec16907be7f3971e2495e1f"}}}}