{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/81251076","pull_request_review_id":2234240,"id":81251076,"diff_hunk":"@@ -396,7 +406,7 @@ def deploy_marathon_app(self, app_definition, timeout=120, check_health=True, ig\n             applications. I.E:\n                 [Endpoint(host='172.17.10.202', port=10464), Endpoint(host='172.17.10.201', port=1630)]\n         \"\"\"\n-        r = self.post('/marathon/v2/apps', app_definition, headers=self._marathon_req_headers())\n+        r = self.post('/marathon/v2/apps', json=app_definition, headers=self._marathon_req_headers())","path":"test_util/cluster_api.py","position":140,"original_position":140,"commit_id":"c281c86f816c13b091ac039a97071c126acb1232","original_commit_id":"c281c86f816c13b091ac039a97071c126acb1232","user":{"login":"cmaloney","id":751088,"avatar_url":"https://avatars.githubusercontent.com/u/751088?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaloney","html_url":"https://github.com/cmaloney","followers_url":"https://api.github.com/users/cmaloney/followers","following_url":"https://api.github.com/users/cmaloney/following{/other_user}","gists_url":"https://api.github.com/users/cmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaloney/subscriptions","organizations_url":"https://api.github.com/users/cmaloney/orgs","repos_url":"https://api.github.com/users/cmaloney/repos","events_url":"https://api.github.com/users/cmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/cmaloney/received_events","type":"User","site_admin":false},"body":"future thought: Ideally eventually it might be nice to move this to a `Marathon` API wrapper that we shared with the DC/OS CLI to have native Marathon API calling. Have to balance that a little bit with \"want to make sure the Marathon API doesn't change unexpectedly\"","created_at":"2016-09-29T22:50:41Z","updated_at":"2016-09-29T22:51:33Z","html_url":"https://github.com/dcos/dcos/pull/773#discussion_r81251076","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/773","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/81251076"},"html":{"href":"https://github.com/dcos/dcos/pull/773#discussion_r81251076"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/773"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/773","id":86679987,"html_url":"https://github.com/dcos/dcos/pull/773","diff_url":"https://github.com/dcos/dcos/pull/773.diff","patch_url":"https://github.com/dcos/dcos/pull/773.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/773","number":773,"state":"open","locked":false,"title":"Consolidated request methods","user":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"body":"Builds on work from https://github.com/dcos/dcos/pull/772\r\nNote: 0e8cbec987d89dbf3dd59b8683f2027d8b11ae96 is taking advantage of this change to have adminrouter URL construction in only one place","created_at":"2016-09-26T04:23:50Z","updated_at":"2016-09-29T22:51:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9ac34babb31e41c00ee06ecd8eadd94455d978","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/773/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/773/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/773/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/c281c86f816c13b091ac039a97071c126acb1232","head":{"label":"mellenburg:consolidated_request_methods","ref":"consolidated_request_methods","sha":"c281c86f816c13b091ac039a97071c126acb1232","user":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"repo":{"id":56731971,"name":"dcos","full_name":"mellenburg/dcos","owner":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellenburg/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mellenburg/dcos","forks_url":"https://api.github.com/repos/mellenburg/dcos/forks","keys_url":"https://api.github.com/repos/mellenburg/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellenburg/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellenburg/dcos/teams","hooks_url":"https://api.github.com/repos/mellenburg/dcos/hooks","issue_events_url":"https://api.github.com/repos/mellenburg/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mellenburg/dcos/events","assignees_url":"https://api.github.com/repos/mellenburg/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mellenburg/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mellenburg/dcos/tags","blobs_url":"https://api.github.com/repos/mellenburg/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellenburg/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellenburg/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellenburg/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellenburg/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mellenburg/dcos/languages","stargazers_url":"https://api.github.com/repos/mellenburg/dcos/stargazers","contributors_url":"https://api.github.com/repos/mellenburg/dcos/contributors","subscribers_url":"https://api.github.com/repos/mellenburg/dcos/subscribers","subscription_url":"https://api.github.com/repos/mellenburg/dcos/subscription","commits_url":"https://api.github.com/repos/mellenburg/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellenburg/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellenburg/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellenburg/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellenburg/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mellenburg/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellenburg/dcos/merges","archive_url":"https://api.github.com/repos/mellenburg/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellenburg/dcos/downloads","issues_url":"https://api.github.com/repos/mellenburg/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mellenburg/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mellenburg/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mellenburg/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellenburg/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mellenburg/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mellenburg/dcos/deployments","created_at":"2016-04-21T01:13:27Z","updated_at":"2016-04-29T20:59:42Z","pushed_at":"2016-09-29T19:18:22Z","git_url":"git://github.com/mellenburg/dcos.git","ssh_url":"git@github.com:mellenburg/dcos.git","clone_url":"https://github.com/mellenburg/dcos.git","svn_url":"https://github.com/mellenburg/dcos","homepage":"https://dcos.io","size":1899,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"46d4cd18d25fbe7f853fb8835451289b5e9518ed","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-09-29T16:55:58Z","pushed_at":"2016-09-29T20:31:00Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":2811,"stargazers_count":917,"watchers_count":917,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":40,"forks":160,"open_issues":40,"watchers":917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/773"},"html":{"href":"https://github.com/dcos/dcos/pull/773"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/773"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/c281c86f816c13b091ac039a97071c126acb1232"}}}}
{"actor":{"display_login":"cmaloney"}}