{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snap-confine/pulls/comments/78741320","id":78741320,"diff_hunk":"@@ -18,4 +18,3 @@ restore: |\n     umount /run/snapd/ns\n     rm /run/snapd/ns/foo.mnt\n     rm /run/snapd/ns/foo.lock\n-    rmdir /run/snapd/ns","path":"spread-tests/main/discard-ns/task.yaml","position":4,"original_position":4,"commit_id":"9d0e81fef89e3d6438c22c5fbd96bc15cdaf540f","original_commit_id":"9d0e81fef89e3d6438c22c5fbd96bc15cdaf540f","user":{"login":"jdstrand","id":1663079,"avatar_url":"https://avatars.githubusercontent.com/u/1663079?v=3","gravatar_id":"","url":"https://api.github.com/users/jdstrand","html_url":"https://github.com/jdstrand","followers_url":"https://api.github.com/users/jdstrand/followers","following_url":"https://api.github.com/users/jdstrand/following{/other_user}","gists_url":"https://api.github.com/users/jdstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstrand/subscriptions","organizations_url":"https://api.github.com/users/jdstrand/orgs","repos_url":"https://api.github.com/users/jdstrand/repos","events_url":"https://api.github.com/users/jdstrand/events{/privacy}","received_events_url":"https://api.github.com/users/jdstrand/received_events","type":"User","site_admin":false},"body":"What about \"rmdir /run/snapd/ns || true\" instead (with a comment that it is ok when it can't be removed). This way we get the cleanup if it can be done.","created_at":"2016-09-14T12:49:52Z","updated_at":"2016-09-14T12:49:52Z","html_url":"https://github.com/snapcore/snap-confine/pull/143#discussion_r78741320","pull_request_url":"https://api.github.com/repos/snapcore/snap-confine/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/comments/78741320"},"html":{"href":"https://github.com/snapcore/snap-confine/pull/143#discussion_r78741320"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snap-confine/pulls/143","id":85210614,"html_url":"https://github.com/snapcore/snap-confine/pull/143","diff_url":"https://github.com/snapcore/snap-confine/pull/143.diff","patch_url":"https://github.com/snapcore/snap-confine/pull/143.patch","issue_url":"https://api.github.com/repos/snapcore/snap-confine/issues/143","number":143,"state":"open","locked":false,"title":"Don't assume /run/snapd/ns can be removed","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"This patch fixes a test case that is overzealous in the assumption that\r\n/run/snapd/ns can be removed. That directory can contain additional\r\nmount and lock files from any snaps present on the system that have run\r\nearlier.\r\n\r\nSigned-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>","created_at":"2016-09-14T11:27:59Z","updated_at":"2016-09-14T12:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"562fb919c621526ce674889a95bed781716cd142","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snap-confine/pulls/143/commits","review_comments_url":"https://api.github.com/repos/snapcore/snap-confine/pulls/143/comments","review_comment_url":"https://api.github.com/repos/snapcore/snap-confine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snap-confine/issues/143/comments","statuses_url":"https://api.github.com/repos/snapcore/snap-confine/statuses/9d0e81fef89e3d6438c22c5fbd96bc15cdaf540f","head":{"label":"snapcore:tweak-tests","ref":"tweak-tests","sha":"9d0e81fef89e3d6438c22c5fbd96bc15cdaf540f","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":59485230,"name":"snap-confine","full_name":"snapcore/snap-confine","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snap-confine","description":"Runner for snaps","fork":false,"url":"https://api.github.com/repos/snapcore/snap-confine","forks_url":"https://api.github.com/repos/snapcore/snap-confine/forks","keys_url":"https://api.github.com/repos/snapcore/snap-confine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snap-confine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snap-confine/teams","hooks_url":"https://api.github.com/repos/snapcore/snap-confine/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snap-confine/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snap-confine/events","assignees_url":"https://api.github.com/repos/snapcore/snap-confine/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snap-confine/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snap-confine/tags","blobs_url":"https://api.github.com/repos/snapcore/snap-confine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snap-confine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snap-confine/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snap-confine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snap-confine/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snap-confine/languages","stargazers_url":"https://api.github.com/repos/snapcore/snap-confine/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snap-confine/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snap-confine/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snap-confine/subscription","commits_url":"https://api.github.com/repos/snapcore/snap-confine/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snap-confine/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snap-confine/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snap-confine/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snap-confine/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snap-confine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snap-confine/merges","archive_url":"https://api.github.com/repos/snapcore/snap-confine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snap-confine/downloads","issues_url":"https://api.github.com/repos/snapcore/snap-confine/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snap-confine/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snap-confine/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snap-confine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snap-confine/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snap-confine/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snap-confine/deployments","created_at":"2016-05-23T13:29:44Z","updated_at":"2016-09-02T06:06:15Z","pushed_at":"2016-09-14T11:29:38Z","git_url":"git://github.com/snapcore/snap-confine.git","ssh_url":"git@github.com:snapcore/snap-confine.git","clone_url":"https://github.com/snapcore/snap-confine.git","svn_url":"https://github.com/snapcore/snap-confine","homepage":"","size":1240,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":7,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"9fcd150fb3b3c8b84f57905066e88cf466729e57","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":59485230,"name":"snap-confine","full_name":"snapcore/snap-confine","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snap-confine","description":"Runner for snaps","fork":false,"url":"https://api.github.com/repos/snapcore/snap-confine","forks_url":"https://api.github.com/repos/snapcore/snap-confine/forks","keys_url":"https://api.github.com/repos/snapcore/snap-confine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snap-confine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snap-confine/teams","hooks_url":"https://api.github.com/repos/snapcore/snap-confine/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snap-confine/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snap-confine/events","assignees_url":"https://api.github.com/repos/snapcore/snap-confine/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snap-confine/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snap-confine/tags","blobs_url":"https://api.github.com/repos/snapcore/snap-confine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snap-confine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snap-confine/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snap-confine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snap-confine/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snap-confine/languages","stargazers_url":"https://api.github.com/repos/snapcore/snap-confine/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snap-confine/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snap-confine/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snap-confine/subscription","commits_url":"https://api.github.com/repos/snapcore/snap-confine/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snap-confine/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snap-confine/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snap-confine/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snap-confine/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snap-confine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snap-confine/merges","archive_url":"https://api.github.com/repos/snapcore/snap-confine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snap-confine/downloads","issues_url":"https://api.github.com/repos/snapcore/snap-confine/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snap-confine/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snap-confine/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snap-confine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snap-confine/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snap-confine/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snap-confine/deployments","created_at":"2016-05-23T13:29:44Z","updated_at":"2016-09-02T06:06:15Z","pushed_at":"2016-09-14T11:29:38Z","git_url":"git://github.com/snapcore/snap-confine.git","ssh_url":"git@github.com:snapcore/snap-confine.git","clone_url":"https://github.com/snapcore/snap-confine.git","svn_url":"https://github.com/snapcore/snap-confine","homepage":"","size":1240,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/143"},"html":{"href":"https://github.com/snapcore/snap-confine/pull/143"},"issue":{"href":"https://api.github.com/repos/snapcore/snap-confine/issues/143"},"comments":{"href":"https://api.github.com/repos/snapcore/snap-confine/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snap-confine/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snap-confine/statuses/9d0e81fef89e3d6438c22c5fbd96bc15cdaf540f"}}}}
{"actor":{"display_login":"jdstrand"}}