{"action":"created","comment":{"url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/comments/61949037","id":61949037,"diff_hunk":"@@ -140,62 +141,72 @@ public boolean updateProviders(String jsonString, boolean save) {\n \n \n \t}\n-\n+\tprivate static final Object locker = new Object();\n \tprivate void updateProviders(JSONArray jsonArray) {\n-\t\tproviders.clear();\n-\t\tg.domain_image_hash=new HashMap<String, Uri>();\n-\t\tProvider tmp;\n-\t\tfor (int i = 0; i < jsonArray.length(); i++) {\n-\t\t\ttmp = new Provider();\n-\t\t\ttry {\n-\n-\t\t\t\t//change domains to valid domains, if not listed on the server that way\n-\t\t\t\tif(((JSONObject) jsonArray.get(i)).getString(\"domain\").equals(\"zvrs.vatrp.net\")){\n-\t\t\t\t\ttmp.domain=\"208.94.16.87\";\n-\t\t\t\t}else if(((JSONObject) jsonArray.get(i)).getString(\"domain\").equals(\"psip-lb.staging.purple.us\")){\n-\t\t\t\t\ttmp.domain=\"psip-lb.test.purple.us\";\n-\t\t\t\t}else {\n-\t\t\t\t\ttmp.domain = ((JSONObject) jsonArray.get(i)).getString(\"domain\");\n-\t\t\t\t}\n+\t\tsynchronized (locker) {\n+\t\t\tproviders.clear();\n+\t\t\tg.domain_image_hash = new HashMap<String, Uri>();\n+\t\t\tProvider tmp;\n+\t\t\tfor (int i = 0; i < jsonArray.length(); i++) {\n+\t\t\t\ttmp = new Provider();\n+\t\t\t\ttry {\n \n-\t\t\t\ttmp.name = ((JSONObject) jsonArray.get(i)).getString(\"name\");\n-\t\t\t\ttmp.icon = ((JSONObject) jsonArray.get(i)).getString(\"icon\");\n-\t\t\t\ttmp.icon2x = ((JSONObject) jsonArray.get(i)).getString(\"icon2x\");\n-\t\t\t\t//tmp.port=srvLookup\n+\t\t\t\t\t//change domains to valid domains, if not listed on the server that way\n+\t\t\t\t\tif (((JSONObject) jsonArray.get(i)).getString(\"domain\").equals(\"zvrs.vatrp.net\")) {\n+\t\t\t\t\t\ttmp.domain = \"208.94.16.87\";\n+\t\t\t\t\t} else if (((JSONObject) jsonArray.get(i)).getString(\"domain\").equals(\"psip-lb.staging.purple.us\")) {\n+\t\t\t\t\t\ttmp.domain = \"psip-lb.test.purple.us\";\n+\t\t\t\t\t} else {","path":"src/org/linphone/setup/CDNProviders.java","position":47,"original_position":47,"commit_id":"3a5a2e97ff44c470512217056284310b122ec3d4","original_commit_id":"3a5a2e97ff44c470512217056284310b122ec3d4","user":{"login":"shareefalis","id":1189805,"avatar_url":"https://avatars.githubusercontent.com/u/1189805?v=3","gravatar_id":"","url":"https://api.github.com/users/shareefalis","html_url":"https://github.com/shareefalis","followers_url":"https://api.github.com/users/shareefalis/followers","following_url":"https://api.github.com/users/shareefalis/following{/other_user}","gists_url":"https://api.github.com/users/shareefalis/gists{/gist_id}","starred_url":"https://api.github.com/users/shareefalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shareefalis/subscriptions","organizations_url":"https://api.github.com/users/shareefalis/orgs","repos_url":"https://api.github.com/users/shareefalis/repos","events_url":"https://api.github.com/users/shareefalis/events{/privacy}","received_events_url":"https://api.github.com/users/shareefalis/received_events","type":"User","site_admin":false},"body":"Looks fine to me","created_at":"2016-05-03T20:22:34Z","updated_at":"2016-05-03T20:22:34Z","html_url":"https://github.com/VTCSecureLLC/ace-android/pull/544#discussion_r61949037","pull_request_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544","_links":{"self":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/comments/61949037"},"html":{"href":"https://github.com/VTCSecureLLC/ace-android/pull/544#discussion_r61949037"},"pull_request":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544"}}},"pull_request":{"url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544","id":68474335,"html_url":"https://github.com/VTCSecureLLC/ace-android/pull/544","diff_url":"https://github.com/VTCSecureLLC/ace-android/pull/544.diff","patch_url":"https://github.com/VTCSecureLLC/ace-android/pull/544.patch","issue_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/544","number":544,"state":"open","locked":false,"title":"VATRP-3991: Tablet contact crash fix","user":{"login":"samson-accontech","id":18174478,"avatar_url":"https://avatars.githubusercontent.com/u/18174478?v=3","gravatar_id":"","url":"https://api.github.com/users/samson-accontech","html_url":"https://github.com/samson-accontech","followers_url":"https://api.github.com/users/samson-accontech/followers","following_url":"https://api.github.com/users/samson-accontech/following{/other_user}","gists_url":"https://api.github.com/users/samson-accontech/gists{/gist_id}","starred_url":"https://api.github.com/users/samson-accontech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samson-accontech/subscriptions","organizations_url":"https://api.github.com/users/samson-accontech/orgs","repos_url":"https://api.github.com/users/samson-accontech/repos","events_url":"https://api.github.com/users/samson-accontech/events{/privacy}","received_events_url":"https://api.github.com/users/samson-accontech/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-30T17:52:44Z","updated_at":"2016-05-03T20:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f30e839a28b1fa2122ef0653eb1d2d5874a8503","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544/commits","review_comments_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544/comments","review_comment_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/544/comments","statuses_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/statuses/3a5a2e97ff44c470512217056284310b122ec3d4","head":{"label":"Accontech:tablet_contact_crash_fix","ref":"tablet_contact_crash_fix","sha":"3a5a2e97ff44c470512217056284310b122ec3d4","user":{"login":"Accontech","id":17147397,"avatar_url":"https://avatars.githubusercontent.com/u/17147397?v=3","gravatar_id":"","url":"https://api.github.com/users/Accontech","html_url":"https://github.com/Accontech","followers_url":"https://api.github.com/users/Accontech/followers","following_url":"https://api.github.com/users/Accontech/following{/other_user}","gists_url":"https://api.github.com/users/Accontech/gists{/gist_id}","starred_url":"https://api.github.com/users/Accontech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Accontech/subscriptions","organizations_url":"https://api.github.com/users/Accontech/orgs","repos_url":"https://api.github.com/users/Accontech/repos","events_url":"https://api.github.com/users/Accontech/events{/privacy}","received_events_url":"https://api.github.com/users/Accontech/received_events","type":"Organization","site_admin":false},"repo":{"id":55077991,"name":"ace-android","full_name":"Accontech/ace-android","owner":{"login":"Accontech","id":17147397,"avatar_url":"https://avatars.githubusercontent.com/u/17147397?v=3","gravatar_id":"","url":"https://api.github.com/users/Accontech","html_url":"https://github.com/Accontech","followers_url":"https://api.github.com/users/Accontech/followers","following_url":"https://api.github.com/users/Accontech/following{/other_user}","gists_url":"https://api.github.com/users/Accontech/gists{/gist_id}","starred_url":"https://api.github.com/users/Accontech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Accontech/subscriptions","organizations_url":"https://api.github.com/users/Accontech/orgs","repos_url":"https://api.github.com/users/Accontech/repos","events_url":"https://api.github.com/users/Accontech/events{/privacy}","received_events_url":"https://api.github.com/users/Accontech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Accontech/ace-android","description":"Accessible Communications for Everyone on Android","fork":true,"url":"https://api.github.com/repos/Accontech/ace-android","forks_url":"https://api.github.com/repos/Accontech/ace-android/forks","keys_url":"https://api.github.com/repos/Accontech/ace-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Accontech/ace-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Accontech/ace-android/teams","hooks_url":"https://api.github.com/repos/Accontech/ace-android/hooks","issue_events_url":"https://api.github.com/repos/Accontech/ace-android/issues/events{/number}","events_url":"https://api.github.com/repos/Accontech/ace-android/events","assignees_url":"https://api.github.com/repos/Accontech/ace-android/assignees{/user}","branches_url":"https://api.github.com/repos/Accontech/ace-android/branches{/branch}","tags_url":"https://api.github.com/repos/Accontech/ace-android/tags","blobs_url":"https://api.github.com/repos/Accontech/ace-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Accontech/ace-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Accontech/ace-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Accontech/ace-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Accontech/ace-android/statuses/{sha}","languages_url":"https://api.github.com/repos/Accontech/ace-android/languages","stargazers_url":"https://api.github.com/repos/Accontech/ace-android/stargazers","contributors_url":"https://api.github.com/repos/Accontech/ace-android/contributors","subscribers_url":"https://api.github.com/repos/Accontech/ace-android/subscribers","subscription_url":"https://api.github.com/repos/Accontech/ace-android/subscription","commits_url":"https://api.github.com/repos/Accontech/ace-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Accontech/ace-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Accontech/ace-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Accontech/ace-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Accontech/ace-android/contents/{+path}","compare_url":"https://api.github.com/repos/Accontech/ace-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Accontech/ace-android/merges","archive_url":"https://api.github.com/repos/Accontech/ace-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Accontech/ace-android/downloads","issues_url":"https://api.github.com/repos/Accontech/ace-android/issues{/number}","pulls_url":"https://api.github.com/repos/Accontech/ace-android/pulls{/number}","milestones_url":"https://api.github.com/repos/Accontech/ace-android/milestones{/number}","notifications_url":"https://api.github.com/repos/Accontech/ace-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Accontech/ace-android/labels{/name}","releases_url":"https://api.github.com/repos/Accontech/ace-android/releases{/id}","deployments_url":"https://api.github.com/repos/Accontech/ace-android/deployments","created_at":"2016-03-30T16:13:53Z","updated_at":"2016-03-30T16:13:55Z","pushed_at":"2016-05-03T14:10:46Z","git_url":"git://github.com/Accontech/ace-android.git","ssh_url":"git@github.com:Accontech/ace-android.git","clone_url":"https://github.com/Accontech/ace-android.git","svn_url":"https://github.com/Accontech/ace-android","homepage":"https://travis-ci.org/VTCSecureLLC/ace-android","size":69651,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VTCSecureLLC:master","ref":"master","sha":"7b32afeebd98f530a7fb4baae8b0d5bf2de3952b","user":{"login":"VTCSecureLLC","id":13278542,"avatar_url":"https://avatars.githubusercontent.com/u/13278542?v=3","gravatar_id":"","url":"https://api.github.com/users/VTCSecureLLC","html_url":"https://github.com/VTCSecureLLC","followers_url":"https://api.github.com/users/VTCSecureLLC/followers","following_url":"https://api.github.com/users/VTCSecureLLC/following{/other_user}","gists_url":"https://api.github.com/users/VTCSecureLLC/gists{/gist_id}","starred_url":"https://api.github.com/users/VTCSecureLLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VTCSecureLLC/subscriptions","organizations_url":"https://api.github.com/users/VTCSecureLLC/orgs","repos_url":"https://api.github.com/users/VTCSecureLLC/repos","events_url":"https://api.github.com/users/VTCSecureLLC/events{/privacy}","received_events_url":"https://api.github.com/users/VTCSecureLLC/received_events","type":"Organization","site_admin":false},"repo":{"id":40663531,"name":"ace-android","full_name":"VTCSecureLLC/ace-android","owner":{"login":"VTCSecureLLC","id":13278542,"avatar_url":"https://avatars.githubusercontent.com/u/13278542?v=3","gravatar_id":"","url":"https://api.github.com/users/VTCSecureLLC","html_url":"https://github.com/VTCSecureLLC","followers_url":"https://api.github.com/users/VTCSecureLLC/followers","following_url":"https://api.github.com/users/VTCSecureLLC/following{/other_user}","gists_url":"https://api.github.com/users/VTCSecureLLC/gists{/gist_id}","starred_url":"https://api.github.com/users/VTCSecureLLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VTCSecureLLC/subscriptions","organizations_url":"https://api.github.com/users/VTCSecureLLC/orgs","repos_url":"https://api.github.com/users/VTCSecureLLC/repos","events_url":"https://api.github.com/users/VTCSecureLLC/events{/privacy}","received_events_url":"https://api.github.com/users/VTCSecureLLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VTCSecureLLC/ace-android","description":"Accessible Communications for Everyone on Android","fork":false,"url":"https://api.github.com/repos/VTCSecureLLC/ace-android","forks_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/forks","keys_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/teams","hooks_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/hooks","issue_events_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/events{/number}","events_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/events","assignees_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/assignees{/user}","branches_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/branches{/branch}","tags_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/tags","blobs_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/statuses/{sha}","languages_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/languages","stargazers_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/stargazers","contributors_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/contributors","subscribers_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/subscribers","subscription_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/subscription","commits_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/contents/{+path}","compare_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/merges","archive_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/downloads","issues_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues{/number}","pulls_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls{/number}","milestones_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/milestones{/number}","notifications_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/labels{/name}","releases_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/releases{/id}","deployments_url":"https://api.github.com/repos/VTCSecureLLC/ace-android/deployments","created_at":"2015-08-13T14:35:18Z","updated_at":"2016-01-16T16:30:29Z","pushed_at":"2016-05-03T17:08:19Z","git_url":"git://github.com/VTCSecureLLC/ace-android.git","ssh_url":"git@github.com:VTCSecureLLC/ace-android.git","clone_url":"https://github.com/VTCSecureLLC/ace-android.git","svn_url":"https://github.com/VTCSecureLLC/ace-android","homepage":"https://travis-ci.org/VTCSecureLLC/ace-android","size":70873,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544"},"html":{"href":"https://github.com/VTCSecureLLC/ace-android/pull/544"},"issue":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/544"},"comments":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/VTCSecureLLC/ace-android/statuses/3a5a2e97ff44c470512217056284310b122ec3d4"}}}}