{"action":"created","comment":{"url":"https://api.github.com/repos/mosra/magnum/pulls/comments/89303857","pull_request_review_id":9848981,"id":89303857,"diff_hunk":"@@ -162,6 +162,34 @@ class Distance {\n          * the square root.\n          */\n         template<class T> static T lineSegmentPointSquared(const Vector3<T>& a, const Vector3<T>& b, const Vector3<T>& point);\n+\n+        /**\n+         * @brief Distance of point from plane, scaled by the length of the planes normal.\n+         * @param point the point\n+         * @param plane the plane\n+         * @returns a value `> 0` if point is on positive half space,\n+         *                  `< 0` if point is on negative half space,\n+         *                  `0` if point is on the plane.\n+         *\n+         * More efficient than @ref pointPlane() when the planes normal is already\n+         * normalized or when testing on which half space the point lies.\n+         */\n+        template<class T> static T pointPlane(const Vector3<T>& point, const Vector4<T>& plane) {\n+            return (plane.xyz()*point).sum() + plane.w();","path":"src/Magnum/Math/Geometry/Distance.h","position":17,"original_position":17,"commit_id":"0c6c27573f20ed41c1afd66d0288d182109df575","original_commit_id":"0c6c27573f20ed41c1afd66d0288d182109df575","user":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"body":"I would name this `pointPlaneNormalized()` and the other just `pointPlane()` and then add an assertion for normalizedness here. (To make the correct-though-slower the default.)","created_at":"2016-11-23T12:12:50Z","updated_at":"2016-11-23T12:56:09Z","html_url":"https://github.com/mosra/magnum/pull/185#discussion_r89303857","pull_request_url":"https://api.github.com/repos/mosra/magnum/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/mosra/magnum/pulls/comments/89303857"},"html":{"href":"https://github.com/mosra/magnum/pull/185#discussion_r89303857"},"pull_request":{"href":"https://api.github.com/repos/mosra/magnum/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/mosra/magnum/pulls/185","id":94895191,"html_url":"https://github.com/mosra/magnum/pull/185","diff_url":"https://github.com/mosra/magnum/pull/185.diff","patch_url":"https://github.com/mosra/magnum/pull/185.patch","issue_url":"https://api.github.com/repos/mosra/magnum/issues/185","number":185,"state":"open","locked":false,"title":"[WIP] Math: Add rangeFrustum and pointFrustum intersection implementions","user":{"login":"Squareys","id":1889284,"avatar_url":"https://avatars.githubusercontent.com/u/1889284?v=3","gravatar_id":"","url":"https://api.github.com/users/Squareys","html_url":"https://github.com/Squareys","followers_url":"https://api.github.com/users/Squareys/followers","following_url":"https://api.github.com/users/Squareys/following{/other_user}","gists_url":"https://api.github.com/users/Squareys/gists{/gist_id}","starred_url":"https://api.github.com/users/Squareys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squareys/subscriptions","organizations_url":"https://api.github.com/users/Squareys/orgs","repos_url":"https://api.github.com/users/Squareys/repos","events_url":"https://api.github.com/users/Squareys/events{/privacy}","received_events_url":"https://api.github.com/users/Squareys/received_events","type":"User","site_admin":false},"body":"Hi @mosra !\r\n\r\nI finally got around to extracting the `Math::Geometry::Intersection::*` code from the magnum-extras/octree pullrequest. This is a initial sketch, I will finish it up in the next few minutes (before I let it lying around for half a year again) or tomorrow.\r\n\r\nRegards, Squareys.\r\n\r\n**TODOs**:\r\n - [ ] Tests for new functions in `Intersection`\r\n - [ ] Latex formulas","created_at":"2016-11-22T20:48:34Z","updated_at":"2016-11-23T12:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e048f515cc7e4720da80f1c0fed7963ccdce2ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mosra/magnum/pulls/185/commits","review_comments_url":"https://api.github.com/repos/mosra/magnum/pulls/185/comments","review_comment_url":"https://api.github.com/repos/mosra/magnum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mosra/magnum/issues/185/comments","statuses_url":"https://api.github.com/repos/mosra/magnum/statuses/0c6c27573f20ed41c1afd66d0288d182109df575","head":{"label":"Squareys:frustum-intersection","ref":"frustum-intersection","sha":"0c6c27573f20ed41c1afd66d0288d182109df575","user":{"login":"Squareys","id":1889284,"avatar_url":"https://avatars.githubusercontent.com/u/1889284?v=3","gravatar_id":"","url":"https://api.github.com/users/Squareys","html_url":"https://github.com/Squareys","followers_url":"https://api.github.com/users/Squareys/followers","following_url":"https://api.github.com/users/Squareys/following{/other_user}","gists_url":"https://api.github.com/users/Squareys/gists{/gist_id}","starred_url":"https://api.github.com/users/Squareys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squareys/subscriptions","organizations_url":"https://api.github.com/users/Squareys/orgs","repos_url":"https://api.github.com/users/Squareys/repos","events_url":"https://api.github.com/users/Squareys/events{/privacy}","received_events_url":"https://api.github.com/users/Squareys/received_events","type":"User","site_admin":false},"repo":{"id":33696624,"name":"magnum","full_name":"Squareys/magnum","owner":{"login":"Squareys","id":1889284,"avatar_url":"https://avatars.githubusercontent.com/u/1889284?v=3","gravatar_id":"","url":"https://api.github.com/users/Squareys","html_url":"https://github.com/Squareys","followers_url":"https://api.github.com/users/Squareys/followers","following_url":"https://api.github.com/users/Squareys/following{/other_user}","gists_url":"https://api.github.com/users/Squareys/gists{/gist_id}","starred_url":"https://api.github.com/users/Squareys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squareys/subscriptions","organizations_url":"https://api.github.com/users/Squareys/orgs","repos_url":"https://api.github.com/users/Squareys/repos","events_url":"https://api.github.com/users/Squareys/events{/privacy}","received_events_url":"https://api.github.com/users/Squareys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Squareys/magnum","description":"C++11/C++14 and OpenGL graphics engine","fork":true,"url":"https://api.github.com/repos/Squareys/magnum","forks_url":"https://api.github.com/repos/Squareys/magnum/forks","keys_url":"https://api.github.com/repos/Squareys/magnum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Squareys/magnum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Squareys/magnum/teams","hooks_url":"https://api.github.com/repos/Squareys/magnum/hooks","issue_events_url":"https://api.github.com/repos/Squareys/magnum/issues/events{/number}","events_url":"https://api.github.com/repos/Squareys/magnum/events","assignees_url":"https://api.github.com/repos/Squareys/magnum/assignees{/user}","branches_url":"https://api.github.com/repos/Squareys/magnum/branches{/branch}","tags_url":"https://api.github.com/repos/Squareys/magnum/tags","blobs_url":"https://api.github.com/repos/Squareys/magnum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Squareys/magnum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Squareys/magnum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Squareys/magnum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Squareys/magnum/statuses/{sha}","languages_url":"https://api.github.com/repos/Squareys/magnum/languages","stargazers_url":"https://api.github.com/repos/Squareys/magnum/stargazers","contributors_url":"https://api.github.com/repos/Squareys/magnum/contributors","subscribers_url":"https://api.github.com/repos/Squareys/magnum/subscribers","subscription_url":"https://api.github.com/repos/Squareys/magnum/subscription","commits_url":"https://api.github.com/repos/Squareys/magnum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Squareys/magnum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Squareys/magnum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Squareys/magnum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Squareys/magnum/contents/{+path}","compare_url":"https://api.github.com/repos/Squareys/magnum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Squareys/magnum/merges","archive_url":"https://api.github.com/repos/Squareys/magnum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Squareys/magnum/downloads","issues_url":"https://api.github.com/repos/Squareys/magnum/issues{/number}","pulls_url":"https://api.github.com/repos/Squareys/magnum/pulls{/number}","milestones_url":"https://api.github.com/repos/Squareys/magnum/milestones{/number}","notifications_url":"https://api.github.com/repos/Squareys/magnum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Squareys/magnum/labels{/name}","releases_url":"https://api.github.com/repos/Squareys/magnum/releases{/id}","deployments_url":"https://api.github.com/repos/Squareys/magnum/deployments","created_at":"2015-04-09T22:49:56Z","updated_at":"2016-03-14T07:53:21Z","pushed_at":"2016-11-22T21:26:54Z","git_url":"git://github.com/Squareys/magnum.git","ssh_url":"git@github.com:Squareys/magnum.git","clone_url":"https://github.com/Squareys/magnum.git","svn_url":"https://github.com/Squareys/magnum","homepage":"http://mosra.cz/blog/magnum.php","size":24446,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mosra:master","ref":"master","sha":"ae24ddd39048c6ef7c6b06f9f70bee9d93f999c1","user":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"repo":{"id":1182756,"name":"magnum","full_name":"mosra/magnum","owner":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mosra/magnum","description":"C++11/C++14 and OpenGL graphics engine","fork":false,"url":"https://api.github.com/repos/mosra/magnum","forks_url":"https://api.github.com/repos/mosra/magnum/forks","keys_url":"https://api.github.com/repos/mosra/magnum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosra/magnum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosra/magnum/teams","hooks_url":"https://api.github.com/repos/mosra/magnum/hooks","issue_events_url":"https://api.github.com/repos/mosra/magnum/issues/events{/number}","events_url":"https://api.github.com/repos/mosra/magnum/events","assignees_url":"https://api.github.com/repos/mosra/magnum/assignees{/user}","branches_url":"https://api.github.com/repos/mosra/magnum/branches{/branch}","tags_url":"https://api.github.com/repos/mosra/magnum/tags","blobs_url":"https://api.github.com/repos/mosra/magnum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosra/magnum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosra/magnum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosra/magnum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosra/magnum/statuses/{sha}","languages_url":"https://api.github.com/repos/mosra/magnum/languages","stargazers_url":"https://api.github.com/repos/mosra/magnum/stargazers","contributors_url":"https://api.github.com/repos/mosra/magnum/contributors","subscribers_url":"https://api.github.com/repos/mosra/magnum/subscribers","subscription_url":"https://api.github.com/repos/mosra/magnum/subscription","commits_url":"https://api.github.com/repos/mosra/magnum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosra/magnum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosra/magnum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosra/magnum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosra/magnum/contents/{+path}","compare_url":"https://api.github.com/repos/mosra/magnum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosra/magnum/merges","archive_url":"https://api.github.com/repos/mosra/magnum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosra/magnum/downloads","issues_url":"https://api.github.com/repos/mosra/magnum/issues{/number}","pulls_url":"https://api.github.com/repos/mosra/magnum/pulls{/number}","milestones_url":"https://api.github.com/repos/mosra/magnum/milestones{/number}","notifications_url":"https://api.github.com/repos/mosra/magnum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosra/magnum/labels{/name}","releases_url":"https://api.github.com/repos/mosra/magnum/releases{/id}","deployments_url":"https://api.github.com/repos/mosra/magnum/deployments","created_at":"2010-12-19T22:19:59Z","updated_at":"2016-11-22T10:06:29Z","pushed_at":"2016-11-22T21:26:54Z","git_url":"git://github.com/mosra/magnum.git","ssh_url":"git@github.com:mosra/magnum.git","clone_url":"https://github.com/mosra/magnum.git","svn_url":"https://github.com/mosra/magnum","homepage":"http://mosra.cz/blog/magnum.php","size":28459,"stargazers_count":1229,"watchers_count":1229,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":27,"forks":132,"open_issues":27,"watchers":1229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mosra/magnum/pulls/185"},"html":{"href":"https://github.com/mosra/magnum/pull/185"},"issue":{"href":"https://api.github.com/repos/mosra/magnum/issues/185"},"comments":{"href":"https://api.github.com/repos/mosra/magnum/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/mosra/magnum/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/mosra/magnum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mosra/magnum/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/mosra/magnum/statuses/0c6c27573f20ed41c1afd66d0288d182109df575"}}}}
{"actor":{"display_login":"mosra"}}