{"action":"created","issue":{"url":"https://api.github.com/repos/facebookincubator/react-vr/issues/4","repository_url":"https://api.github.com/repos/facebookincubator/react-vr","labels_url":"https://api.github.com/repos/facebookincubator/react-vr/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/facebookincubator/react-vr/issues/4/comments","events_url":"https://api.github.com/repos/facebookincubator/react-vr/issues/4/events","html_url":"https://github.com/facebookincubator/react-vr/issues/4","id":195537651,"number":4,"title":"Pano with cubemap is flipped","user":{"login":"Ninerian","id":117885,"avatar_url":"https://avatars.githubusercontent.com/u/117885?v=3","gravatar_id":"","url":"https://api.github.com/users/Ninerian","html_url":"https://github.com/Ninerian","followers_url":"https://api.github.com/users/Ninerian/followers","following_url":"https://api.github.com/users/Ninerian/following{/other_user}","gists_url":"https://api.github.com/users/Ninerian/gists{/gist_id}","starred_url":"https://api.github.com/users/Ninerian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ninerian/subscriptions","organizations_url":"https://api.github.com/users/Ninerian/orgs","repos_url":"https://api.github.com/users/Ninerian/repos","events_url":"https://api.github.com/users/Ninerian/events{/privacy}","received_events_url":"https://api.github.com/users/Ninerian/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mikearmstrong001","id":4076190,"avatar_url":"https://avatars.githubusercontent.com/u/4076190?v=3","gravatar_id":"","url":"https://api.github.com/users/mikearmstrong001","html_url":"https://github.com/mikearmstrong001","followers_url":"https://api.github.com/users/mikearmstrong001/followers","following_url":"https://api.github.com/users/mikearmstrong001/following{/other_user}","gists_url":"https://api.github.com/users/mikearmstrong001/gists{/gist_id}","starred_url":"https://api.github.com/users/mikearmstrong001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikearmstrong001/subscriptions","organizations_url":"https://api.github.com/users/mikearmstrong001/orgs","repos_url":"https://api.github.com/users/mikearmstrong001/repos","events_url":"https://api.github.com/users/mikearmstrong001/events{/privacy}","received_events_url":"https://api.github.com/users/mikearmstrong001/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikearmstrong001","id":4076190,"avatar_url":"https://avatars.githubusercontent.com/u/4076190?v=3","gravatar_id":"","url":"https://api.github.com/users/mikearmstrong001","html_url":"https://github.com/mikearmstrong001","followers_url":"https://api.github.com/users/mikearmstrong001/followers","following_url":"https://api.github.com/users/mikearmstrong001/following{/other_user}","gists_url":"https://api.github.com/users/mikearmstrong001/gists{/gist_id}","starred_url":"https://api.github.com/users/mikearmstrong001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikearmstrong001/subscriptions","organizations_url":"https://api.github.com/users/mikearmstrong001/orgs","repos_url":"https://api.github.com/users/mikearmstrong001/repos","events_url":"https://api.github.com/users/mikearmstrong001/events{/privacy}","received_events_url":"https://api.github.com/users/mikearmstrong001/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-14T13:59:32Z","updated_at":"2016-12-15T11:03:41Z","closed_at":"2016-12-14T17:55:54Z","body":"### Description\r\nWhen creating a pano component with an array of cubic images as input, the textures are flipped on the y axis. This is caused by the THREE.cubeTexture which sets the flipY property to false. \r\n\r\n#### Expected behavior\r\nthe cubic images should be shown with the correct orientation\r\n\r\n#### Actual behavior\r\nthe cubic images are shown upside down\r\n\r\n### Reproduction\r\nCreate a View Component with a pano component in it:\r\n```\r\n<View\r\n              <Pano source={{uri: ['image_r.jpg', 'image_l.jpg', 'image_d.jpg', 'image_u.jpg', 'image_f.jpg', 'image_b.jpg']}}/>\r\n</View>\r\n```\r\nOn rendering the error should be seen.\r\n\r\n### Solution\r\nIn the class `RCTPano`, the callback of the loading function should be changed at line 124. Adding the line \r\n\r\n```\r\ntexture.flipY = true;\r\n```\r\n\r\nwill solve the problem.\r\n\r\n### Additional Information\r\n\r\n* React VR version: react-vr-web\r\n* Operating System: MacOS\r\n* Graphics Card: Nvidia\r\n* Browser: Chromium 44.0.2383.0, Carmel\r\n* VR Device: GearVR\r\n"},"comment":{"url":"https://api.github.com/repos/facebookincubator/react-vr/issues/comments/267300940","html_url":"https://github.com/facebookincubator/react-vr/issues/4#issuecomment-267300940","issue_url":"https://api.github.com/repos/facebookincubator/react-vr/issues/4","id":267300940,"user":{"login":"mikearmstrong001","id":4076190,"avatar_url":"https://avatars.githubusercontent.com/u/4076190?v=3","gravatar_id":"","url":"https://api.github.com/users/mikearmstrong001","html_url":"https://github.com/mikearmstrong001","followers_url":"https://api.github.com/users/mikearmstrong001/followers","following_url":"https://api.github.com/users/mikearmstrong001/following{/other_user}","gists_url":"https://api.github.com/users/mikearmstrong001/gists{/gist_id}","starred_url":"https://api.github.com/users/mikearmstrong001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikearmstrong001/subscriptions","organizations_url":"https://api.github.com/users/mikearmstrong001/orgs","repos_url":"https://api.github.com/users/mikearmstrong001/repos","events_url":"https://api.github.com/users/mikearmstrong001/events{/privacy}","received_events_url":"https://api.github.com/users/mikearmstrong001/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T11:03:41Z","updated_at":"2016-12-15T11:03:41Z","body":"applied in react-vr-web-0.1.1 and react-vr-0.1.1"}}
{"actor":{"display_login":"mikearmstrong001"}}