{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/31587","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/31587/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/31587/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/31587/events","html_url":"https://github.com/saltstack/salt/pull/31587","id":137647774,"number":31587,"title":"provided more flexibility for the lookup of lambda functions","user":{"login":"winstonliu1111","id":7718149,"avatar_url":"https://avatars.githubusercontent.com/u/7718149?v=3","gravatar_id":"","url":"https://api.github.com/users/winstonliu1111","html_url":"https://github.com/winstonliu1111","followers_url":"https://api.github.com/users/winstonliu1111/followers","following_url":"https://api.github.com/users/winstonliu1111/following{/other_user}","gists_url":"https://api.github.com/users/winstonliu1111/gists{/gist_id}","starred_url":"https://api.github.com/users/winstonliu1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winstonliu1111/subscriptions","organizations_url":"https://api.github.com/users/winstonliu1111/orgs","repos_url":"https://api.github.com/users/winstonliu1111/repos","events_url":"https://api.github.com/users/winstonliu1111/events{/privacy}","received_events_url":"https://api.github.com/users/winstonliu1111/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-01T18:15:08Z","updated_at":"2016-03-01T20:53:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/31587","html_url":"https://github.com/saltstack/salt/pull/31587","diff_url":"https://github.com/saltstack/salt/pull/31587.diff","patch_url":"https://github.com/saltstack/salt/pull/31587.patch"},"body":"### What does this PR do?\r\nit offered a little more flexibility than previously on how the lambda name is derived for lookup.  we now take in a format string as input into the present state, and allow the user to use the following substitutable kwargs: api, stage, resource, method\r\n\r\n### What issues does this PR fix or reference?\r\nNone\r\n### Previous Behavior\r\nlambda function name is derived as stage_name+api_name+resource_path+httpmethod (hard coded)\r\n### New Behavior\r\nthe default behavior is still same as the previous behavior since the default lambda_funcname_format is set to be `\"{stage}_{api}_{resource}_{method}\"`\r\n\r\nthe user now is able to organize his lambda naming differently if desired.  for example, he can use the following format instead, `\"myuserid_{api}_{stage}_{resource}_{method}\"`\r\n\r\n### Tests written?\r\n- [ ] Yes\r\n- [x] No\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/190898724","html_url":"https://github.com/saltstack/salt/pull/31587#issuecomment-190898724","issue_url":"https://api.github.com/repos/saltstack/salt/issues/31587","id":190898724,"user":{"login":"kraney","id":5760081,"avatar_url":"https://avatars.githubusercontent.com/u/5760081?v=3","gravatar_id":"","url":"https://api.github.com/users/kraney","html_url":"https://github.com/kraney","followers_url":"https://api.github.com/users/kraney/followers","following_url":"https://api.github.com/users/kraney/following{/other_user}","gists_url":"https://api.github.com/users/kraney/gists{/gist_id}","starred_url":"https://api.github.com/users/kraney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraney/subscriptions","organizations_url":"https://api.github.com/users/kraney/orgs","repos_url":"https://api.github.com/users/kraney/repos","events_url":"https://api.github.com/users/kraney/events{/privacy}","received_events_url":"https://api.github.com/users/kraney/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T20:53:32Z","updated_at":"2016-03-01T20:53:32Z","body":"Actually, it's my git repo but the change is in winstonliu1111's original code. We've been working together. I looked over the change and it looks good, aside from the risk from kwargs ordering you mention."}}