{"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190","id":65749599,"html_url":"https://github.com/PlagueHO/LabBuilder/pull/190","diff_url":"https://github.com/PlagueHO/LabBuilder/pull/190.diff","patch_url":"https://github.com/PlagueHO/LabBuilder/pull/190.patch","issue_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/190","number":190,"state":"closed","locked":false,"title":"Improve handling of External Virtual Switch adapter binding - Fixes #189","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"body":"* Added BindingAdapterName and BindingAdapterMac attribute to switch element to allow control over bound adapter.\r\n\r\nThe BindingAdapterName and BindingAdapterMac attributes should not be used on the same switch - either specify the name of the adapter or the MAC address. If both are specified only the MAC address is used.\r\n\r\nIf the Binding Adapter is found but is used by another external switch then an exception is thrown reporting this.\r\n\r\nIf no Binding Adapter attributes are specified then the first Physical adapter with an 'Up' status will be used. If it is already used the an exception will be thrown reporting this.\r\n\r\n@m0rgenthau - if you get a chance, could you see if this change solves things for you? I've updated the Schema documentation with details of the new Attributes:\r\nBindingAdapterName\r\nBindingAdapterMac\r\n\r\nThank you!\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/plagueho/labbuilder/190)\n<!-- Reviewable:end -->\n","created_at":"2016-04-08T07:59:39Z","updated_at":"2016-04-08T09:17:06Z","closed_at":"2016-04-08T09:17:06Z","merged_at":"2016-04-08T09:17:06Z","merge_commit_sha":"7727d7b64237bb2ca516e319fa6d8d402051f263","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190/commits","review_comments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190/comments","review_comment_url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/190/comments","statuses_url":"https://api.github.com/repos/PlagueHO/LabBuilder/statuses/4549badfd9a22dc488e369ae0d8907a61d0c3dec","head":{"label":"PlagueHO:Issue-189-Improve-External-Swtich-Adapter-Assignment","ref":"Issue-189-Improve-External-Swtich-Adapter-Assignment","sha":"4549badfd9a22dc488e369ae0d8907a61d0c3dec","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"repo":{"id":41079260,"name":"LabBuilder","full_name":"PlagueHO/LabBuilder","owner":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PlagueHO/LabBuilder","description":"PowerShell Module for building a Hyper-V Lab environment from a simple XML configuration file.","fork":false,"url":"https://api.github.com/repos/PlagueHO/LabBuilder","forks_url":"https://api.github.com/repos/PlagueHO/LabBuilder/forks","keys_url":"https://api.github.com/repos/PlagueHO/LabBuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PlagueHO/LabBuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PlagueHO/LabBuilder/teams","hooks_url":"https://api.github.com/repos/PlagueHO/LabBuilder/hooks","issue_events_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/events{/number}","events_url":"https://api.github.com/repos/PlagueHO/LabBuilder/events","assignees_url":"https://api.github.com/repos/PlagueHO/LabBuilder/assignees{/user}","branches_url":"https://api.github.com/repos/PlagueHO/LabBuilder/branches{/branch}","tags_url":"https://api.github.com/repos/PlagueHO/LabBuilder/tags","blobs_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PlagueHO/LabBuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/PlagueHO/LabBuilder/languages","stargazers_url":"https://api.github.com/repos/PlagueHO/LabBuilder/stargazers","contributors_url":"https://api.github.com/repos/PlagueHO/LabBuilder/contributors","subscribers_url":"https://api.github.com/repos/PlagueHO/LabBuilder/subscribers","subscription_url":"https://api.github.com/repos/PlagueHO/LabBuilder/subscription","commits_url":"https://api.github.com/repos/PlagueHO/LabBuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/PlagueHO/LabBuilder/contents/{+path}","compare_url":"https://api.github.com/repos/PlagueHO/LabBuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PlagueHO/LabBuilder/merges","archive_url":"https://api.github.com/repos/PlagueHO/LabBuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PlagueHO/LabBuilder/downloads","issues_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues{/number}","pulls_url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/PlagueHO/LabBuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/PlagueHO/LabBuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PlagueHO/LabBuilder/labels{/name}","releases_url":"https://api.github.com/repos/PlagueHO/LabBuilder/releases{/id}","deployments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/deployments","created_at":"2015-08-20T06:25:14Z","updated_at":"2016-04-07T14:44:06Z","pushed_at":"2016-04-08T09:17:06Z","git_url":"git://github.com/PlagueHO/LabBuilder.git","ssh_url":"git@github.com:PlagueHO/LabBuilder.git","clone_url":"https://github.com/PlagueHO/LabBuilder.git","svn_url":"https://github.com/PlagueHO/LabBuilder","homepage":"","size":1953,"stargazers_count":21,"watchers_count":21,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":21,"default_branch":"dev"}},"base":{"label":"PlagueHO:dev","ref":"dev","sha":"a21a0cc73fb4c3d07c18b24b4696fd85da190051","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"repo":{"id":41079260,"name":"LabBuilder","full_name":"PlagueHO/LabBuilder","owner":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PlagueHO/LabBuilder","description":"PowerShell Module for building a Hyper-V Lab environment from a simple XML configuration file.","fork":false,"url":"https://api.github.com/repos/PlagueHO/LabBuilder","forks_url":"https://api.github.com/repos/PlagueHO/LabBuilder/forks","keys_url":"https://api.github.com/repos/PlagueHO/LabBuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PlagueHO/LabBuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PlagueHO/LabBuilder/teams","hooks_url":"https://api.github.com/repos/PlagueHO/LabBuilder/hooks","issue_events_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/events{/number}","events_url":"https://api.github.com/repos/PlagueHO/LabBuilder/events","assignees_url":"https://api.github.com/repos/PlagueHO/LabBuilder/assignees{/user}","branches_url":"https://api.github.com/repos/PlagueHO/LabBuilder/branches{/branch}","tags_url":"https://api.github.com/repos/PlagueHO/LabBuilder/tags","blobs_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PlagueHO/LabBuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/PlagueHO/LabBuilder/languages","stargazers_url":"https://api.github.com/repos/PlagueHO/LabBuilder/stargazers","contributors_url":"https://api.github.com/repos/PlagueHO/LabBuilder/contributors","subscribers_url":"https://api.github.com/repos/PlagueHO/LabBuilder/subscribers","subscription_url":"https://api.github.com/repos/PlagueHO/LabBuilder/subscription","commits_url":"https://api.github.com/repos/PlagueHO/LabBuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/PlagueHO/LabBuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/PlagueHO/LabBuilder/contents/{+path}","compare_url":"https://api.github.com/repos/PlagueHO/LabBuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PlagueHO/LabBuilder/merges","archive_url":"https://api.github.com/repos/PlagueHO/LabBuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PlagueHO/LabBuilder/downloads","issues_url":"https://api.github.com/repos/PlagueHO/LabBuilder/issues{/number}","pulls_url":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/PlagueHO/LabBuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/PlagueHO/LabBuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PlagueHO/LabBuilder/labels{/name}","releases_url":"https://api.github.com/repos/PlagueHO/LabBuilder/releases{/id}","deployments_url":"https://api.github.com/repos/PlagueHO/LabBuilder/deployments","created_at":"2015-08-20T06:25:14Z","updated_at":"2016-04-07T14:44:06Z","pushed_at":"2016-04-08T09:17:06Z","git_url":"git://github.com/PlagueHO/LabBuilder.git","ssh_url":"git@github.com:PlagueHO/LabBuilder.git","clone_url":"https://github.com/PlagueHO/LabBuilder.git","svn_url":"https://github.com/PlagueHO/LabBuilder","homepage":"","size":1953,"stargazers_count":21,"watchers_count":21,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":21,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190"},"html":{"href":"https://github.com/PlagueHO/LabBuilder/pull/190"},"issue":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/190"},"comments":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/PlagueHO/LabBuilder/statuses/4549badfd9a22dc488e369ae0d8907a61d0c3dec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":200,"deletions":17,"changed_files":8}}