{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/5923","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/5923/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5923/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/5923/events","html_url":"https://github.com/playframework/playframework/pull/5923","id":142267221,"number":5923,"title":"Make CacheApi use futures","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-21T06:10:25Z","updated_at":"2016-03-21T08:39:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5923","html_url":"https://github.com/playframework/playframework/pull/5923","diff_url":"https://github.com/playframework/playframework/pull/5923.diff","patch_url":"https://github.com/playframework/playframework/pull/5923.patch"},"body":"Rewrite the `CacheApi` to use `Future`/`CompletionStage` where appropriate.\r\n\r\nSince making blocking calls can sometimes be more convenient when using a fast in-memory cache, I've also created a `BlockingCacheApi` that can be accessed either by injecting it directly or calling `cache.sync` on an existing `CacheApi`. This should also make migration straightforward for existing users."},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/199176846","html_url":"https://github.com/playframework/playframework/pull/5923#issuecomment-199176846","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5923","id":199176846,"user":{"login":"julienrf","id":332812,"avatar_url":"https://avatars.githubusercontent.com/u/332812?v=3","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T08:39:56Z","updated_at":"2016-03-21T08:39:56Z","body":"BTW, I’ve just had a look at ehcache and it seems that their implementation is blocking, so you should probably define a dedicated execution context for ehcache calls, instead of using `Future.successful`."}}