{"action":"created","comment":{"url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/comments/80883172","pull_request_review_id":1903934,"id":80883172,"diff_hunk":"@@ -54,20 +54,21 @@\n         repo_name => $repo_name,\n       }\n     }\n-    'deb': {\n-      $osname = downcase($::operatingsystem)\n-      case $osname {\n-        'debian', 'ubuntu': {\n-\n-          $component = 'main'\n-          $repo_url = \"${base_url}/${repo_name}/${osname}\"\n-          $distribution =  $::lsbdistcodename\n-\n-          file { $normalized_name:\n-            ensure  => file,\n-            path    => \"/etc/apt/sources.list.d/${normalized_name}.list\",\n-            mode    => '0644',\n-            content => template('packagecloud/apt.erb'),\n+  } elsif $type == 'deb' {","path":"manifests/repo.pp","position":null,"original_position":18,"commit_id":"54b06a48106a6181b057f442632afba38cdae4f9","original_commit_id":"2e6081ab62fb80797195af09214d78b118e929c6","user":{"login":"stevenrombauts","id":77368,"avatar_url":"https://avatars.githubusercontent.com/u/77368?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenrombauts","html_url":"https://github.com/stevenrombauts","followers_url":"https://api.github.com/users/stevenrombauts/followers","following_url":"https://api.github.com/users/stevenrombauts/following{/other_user}","gists_url":"https://api.github.com/users/stevenrombauts/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenrombauts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenrombauts/subscriptions","organizations_url":"https://api.github.com/users/stevenrombauts/orgs","repos_url":"https://api.github.com/users/stevenrombauts/repos","events_url":"https://api.github.com/users/stevenrombauts/events{/privacy}","received_events_url":"https://api.github.com/users/stevenrombauts/received_events","type":"User","site_admin":false},"body":"This line should be changed back to `'deb': {` because we're in `case` statement here, not an if/else block. :)","created_at":"2016-09-28T10:09:31Z","updated_at":"2016-09-28T10:09:31Z","html_url":"https://github.com/computology/computology-packagecloud/pull/18#discussion_r80883172","pull_request_url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/comments/80883172"},"html":{"href":"https://github.com/computology/computology-packagecloud/pull/18#discussion_r80883172"},"pull_request":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18","id":54997572,"html_url":"https://github.com/computology/computology-packagecloud/pull/18","diff_url":"https://github.com/computology/computology-packagecloud/pull/18.diff","patch_url":"https://github.com/computology/computology-packagecloud/pull/18.patch","issue_url":"https://api.github.com/repos/computology/computology-packagecloud/issues/18","number":18,"state":"open","locked":false,"title":"Use puppetlabs-apt & require_packages()","user":{"login":"poolski","id":1942093,"avatar_url":"https://avatars.githubusercontent.com/u/1942093?v=3","gravatar_id":"","url":"https://api.github.com/users/poolski","html_url":"https://github.com/poolski","followers_url":"https://api.github.com/users/poolski/followers","following_url":"https://api.github.com/users/poolski/following{/other_user}","gists_url":"https://api.github.com/users/poolski/gists{/gist_id}","starred_url":"https://api.github.com/users/poolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolski/subscriptions","organizations_url":"https://api.github.com/users/poolski/orgs","repos_url":"https://api.github.com/users/poolski/repos","events_url":"https://api.github.com/users/poolski/events{/privacy}","received_events_url":"https://api.github.com/users/poolski/received_events","type":"User","site_admin":false},"body":"Refactored:\r\n* using `ensure_packages( ... )` in place of `package{ ... }` type to avoid collisions with other modules using `apt-transport-https`\r\n* using puppetlabs-apt module to manage Apt repo keys in place of running the apt-key command on each puppet run. ","created_at":"2016-01-04T17:06:52Z","updated_at":"2016-09-28T10:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c671efdd5a07caef628f76310b82ec4a93c2b24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18/commits","review_comments_url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18/comments","review_comment_url":"https://api.github.com/repos/computology/computology-packagecloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/computology/computology-packagecloud/issues/18/comments","statuses_url":"https://api.github.com/repos/computology/computology-packagecloud/statuses/54b06a48106a6181b057f442632afba38cdae4f9","head":{"label":"poolski:beta","ref":"beta","sha":"54b06a48106a6181b057f442632afba38cdae4f9","user":{"login":"poolski","id":1942093,"avatar_url":"https://avatars.githubusercontent.com/u/1942093?v=3","gravatar_id":"","url":"https://api.github.com/users/poolski","html_url":"https://github.com/poolski","followers_url":"https://api.github.com/users/poolski/followers","following_url":"https://api.github.com/users/poolski/following{/other_user}","gists_url":"https://api.github.com/users/poolski/gists{/gist_id}","starred_url":"https://api.github.com/users/poolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolski/subscriptions","organizations_url":"https://api.github.com/users/poolski/orgs","repos_url":"https://api.github.com/users/poolski/repos","events_url":"https://api.github.com/users/poolski/events{/privacy}","received_events_url":"https://api.github.com/users/poolski/received_events","type":"User","site_admin":false},"repo":{"id":49007925,"name":"computology-packagecloud","full_name":"poolski/computology-packagecloud","owner":{"login":"poolski","id":1942093,"avatar_url":"https://avatars.githubusercontent.com/u/1942093?v=3","gravatar_id":"","url":"https://api.github.com/users/poolski","html_url":"https://github.com/poolski","followers_url":"https://api.github.com/users/poolski/followers","following_url":"https://api.github.com/users/poolski/following{/other_user}","gists_url":"https://api.github.com/users/poolski/gists{/gist_id}","starred_url":"https://api.github.com/users/poolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolski/subscriptions","organizations_url":"https://api.github.com/users/poolski/orgs","repos_url":"https://api.github.com/users/poolski/repos","events_url":"https://api.github.com/users/poolski/events{/privacy}","received_events_url":"https://api.github.com/users/poolski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poolski/computology-packagecloud","description":"Puppet module for packagecloud.io","fork":true,"url":"https://api.github.com/repos/poolski/computology-packagecloud","forks_url":"https://api.github.com/repos/poolski/computology-packagecloud/forks","keys_url":"https://api.github.com/repos/poolski/computology-packagecloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poolski/computology-packagecloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poolski/computology-packagecloud/teams","hooks_url":"https://api.github.com/repos/poolski/computology-packagecloud/hooks","issue_events_url":"https://api.github.com/repos/poolski/computology-packagecloud/issues/events{/number}","events_url":"https://api.github.com/repos/poolski/computology-packagecloud/events","assignees_url":"https://api.github.com/repos/poolski/computology-packagecloud/assignees{/user}","branches_url":"https://api.github.com/repos/poolski/computology-packagecloud/branches{/branch}","tags_url":"https://api.github.com/repos/poolski/computology-packagecloud/tags","blobs_url":"https://api.github.com/repos/poolski/computology-packagecloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poolski/computology-packagecloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poolski/computology-packagecloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/poolski/computology-packagecloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poolski/computology-packagecloud/statuses/{sha}","languages_url":"https://api.github.com/repos/poolski/computology-packagecloud/languages","stargazers_url":"https://api.github.com/repos/poolski/computology-packagecloud/stargazers","contributors_url":"https://api.github.com/repos/poolski/computology-packagecloud/contributors","subscribers_url":"https://api.github.com/repos/poolski/computology-packagecloud/subscribers","subscription_url":"https://api.github.com/repos/poolski/computology-packagecloud/subscription","commits_url":"https://api.github.com/repos/poolski/computology-packagecloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/poolski/computology-packagecloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/poolski/computology-packagecloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/poolski/computology-packagecloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/poolski/computology-packagecloud/contents/{+path}","compare_url":"https://api.github.com/repos/poolski/computology-packagecloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poolski/computology-packagecloud/merges","archive_url":"https://api.github.com/repos/poolski/computology-packagecloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poolski/computology-packagecloud/downloads","issues_url":"https://api.github.com/repos/poolski/computology-packagecloud/issues{/number}","pulls_url":"https://api.github.com/repos/poolski/computology-packagecloud/pulls{/number}","milestones_url":"https://api.github.com/repos/poolski/computology-packagecloud/milestones{/number}","notifications_url":"https://api.github.com/repos/poolski/computology-packagecloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poolski/computology-packagecloud/labels{/name}","releases_url":"https://api.github.com/repos/poolski/computology-packagecloud/releases{/id}","deployments_url":"https://api.github.com/repos/poolski/computology-packagecloud/deployments","created_at":"2016-01-04T16:11:28Z","updated_at":"2016-01-04T16:11:29Z","pushed_at":"2016-04-12T14:30:20Z","git_url":"git://github.com/poolski/computology-packagecloud.git","ssh_url":"git@github.com:poolski/computology-packagecloud.git","clone_url":"https://github.com/poolski/computology-packagecloud.git","svn_url":"https://github.com/poolski/computology-packagecloud","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"computology:master","ref":"master","sha":"42ae13e59894517f8688e536fbc54d6d9e66e3e2","user":{"login":"computology","id":6362906,"avatar_url":"https://avatars.githubusercontent.com/u/6362906?v=3","gravatar_id":"","url":"https://api.github.com/users/computology","html_url":"https://github.com/computology","followers_url":"https://api.github.com/users/computology/followers","following_url":"https://api.github.com/users/computology/following{/other_user}","gists_url":"https://api.github.com/users/computology/gists{/gist_id}","starred_url":"https://api.github.com/users/computology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computology/subscriptions","organizations_url":"https://api.github.com/users/computology/orgs","repos_url":"https://api.github.com/users/computology/repos","events_url":"https://api.github.com/users/computology/events{/privacy}","received_events_url":"https://api.github.com/users/computology/received_events","type":"Organization","site_admin":false},"repo":{"id":21589882,"name":"computology-packagecloud","full_name":"computology/computology-packagecloud","owner":{"login":"computology","id":6362906,"avatar_url":"https://avatars.githubusercontent.com/u/6362906?v=3","gravatar_id":"","url":"https://api.github.com/users/computology","html_url":"https://github.com/computology","followers_url":"https://api.github.com/users/computology/followers","following_url":"https://api.github.com/users/computology/following{/other_user}","gists_url":"https://api.github.com/users/computology/gists{/gist_id}","starred_url":"https://api.github.com/users/computology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computology/subscriptions","organizations_url":"https://api.github.com/users/computology/orgs","repos_url":"https://api.github.com/users/computology/repos","events_url":"https://api.github.com/users/computology/events{/privacy}","received_events_url":"https://api.github.com/users/computology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/computology/computology-packagecloud","description":"Puppet module for packagecloud.io","fork":false,"url":"https://api.github.com/repos/computology/computology-packagecloud","forks_url":"https://api.github.com/repos/computology/computology-packagecloud/forks","keys_url":"https://api.github.com/repos/computology/computology-packagecloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/computology/computology-packagecloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/computology/computology-packagecloud/teams","hooks_url":"https://api.github.com/repos/computology/computology-packagecloud/hooks","issue_events_url":"https://api.github.com/repos/computology/computology-packagecloud/issues/events{/number}","events_url":"https://api.github.com/repos/computology/computology-packagecloud/events","assignees_url":"https://api.github.com/repos/computology/computology-packagecloud/assignees{/user}","branches_url":"https://api.github.com/repos/computology/computology-packagecloud/branches{/branch}","tags_url":"https://api.github.com/repos/computology/computology-packagecloud/tags","blobs_url":"https://api.github.com/repos/computology/computology-packagecloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/computology/computology-packagecloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/computology/computology-packagecloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/computology/computology-packagecloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/computology/computology-packagecloud/statuses/{sha}","languages_url":"https://api.github.com/repos/computology/computology-packagecloud/languages","stargazers_url":"https://api.github.com/repos/computology/computology-packagecloud/stargazers","contributors_url":"https://api.github.com/repos/computology/computology-packagecloud/contributors","subscribers_url":"https://api.github.com/repos/computology/computology-packagecloud/subscribers","subscription_url":"https://api.github.com/repos/computology/computology-packagecloud/subscription","commits_url":"https://api.github.com/repos/computology/computology-packagecloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/computology/computology-packagecloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/computology/computology-packagecloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/computology/computology-packagecloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/computology/computology-packagecloud/contents/{+path}","compare_url":"https://api.github.com/repos/computology/computology-packagecloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/computology/computology-packagecloud/merges","archive_url":"https://api.github.com/repos/computology/computology-packagecloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/computology/computology-packagecloud/downloads","issues_url":"https://api.github.com/repos/computology/computology-packagecloud/issues{/number}","pulls_url":"https://api.github.com/repos/computology/computology-packagecloud/pulls{/number}","milestones_url":"https://api.github.com/repos/computology/computology-packagecloud/milestones{/number}","notifications_url":"https://api.github.com/repos/computology/computology-packagecloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/computology/computology-packagecloud/labels{/name}","releases_url":"https://api.github.com/repos/computology/computology-packagecloud/releases{/id}","deployments_url":"https://api.github.com/repos/computology/computology-packagecloud/deployments","created_at":"2014-07-07T23:05:53Z","updated_at":"2016-04-08T17:56:47Z","pushed_at":"2016-05-31T21:03:57Z","git_url":"git://github.com/computology/computology-packagecloud.git","ssh_url":"git@github.com:computology/computology-packagecloud.git","clone_url":"https://github.com/computology/computology-packagecloud.git","svn_url":"https://github.com/computology/computology-packagecloud","homepage":null,"size":67,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18"},"html":{"href":"https://github.com/computology/computology-packagecloud/pull/18"},"issue":{"href":"https://api.github.com/repos/computology/computology-packagecloud/issues/18"},"comments":{"href":"https://api.github.com/repos/computology/computology-packagecloud/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/computology/computology-packagecloud/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/computology/computology-packagecloud/statuses/54b06a48106a6181b057f442632afba38cdae4f9"}}}}
{"actor":{"display_login":"stevenrombauts"}}