{"action":"created","issue":{"url":"https://api.github.com/repos/ucb-bar/firrtl/issues/111","repository_url":"https://api.github.com/repos/ucb-bar/firrtl","labels_url":"https://api.github.com/repos/ucb-bar/firrtl/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/ucb-bar/firrtl/issues/111/comments","events_url":"https://api.github.com/repos/ucb-bar/firrtl/issues/111/events","html_url":"https://github.com/ucb-bar/firrtl/pull/111","id":146742959,"number":111,"title":"Add basic constant propagation for logical operators","user":{"login":"aswaterman","id":1031106,"avatar_url":"https://avatars.githubusercontent.com/u/1031106?v=3","gravatar_id":"","url":"https://api.github.com/users/aswaterman","html_url":"https://github.com/aswaterman","followers_url":"https://api.github.com/users/aswaterman/followers","following_url":"https://api.github.com/users/aswaterman/following{/other_user}","gists_url":"https://api.github.com/users/aswaterman/gists{/gist_id}","starred_url":"https://api.github.com/users/aswaterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aswaterman/subscriptions","organizations_url":"https://api.github.com/users/aswaterman/orgs","repos_url":"https://api.github.com/users/aswaterman/repos","events_url":"https://api.github.com/users/aswaterman/events{/privacy}","received_events_url":"https://api.github.com/users/aswaterman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-04-07T21:09:09Z","updated_at":"2016-04-08T22:25:40Z","closed_at":"2016-04-08T20:15:23Z","pull_request":{"url":"https://api.github.com/repos/ucb-bar/firrtl/pulls/111","html_url":"https://github.com/ucb-bar/firrtl/pull/111","diff_url":"https://github.com/ucb-bar/firrtl/pull/111.diff","patch_url":"https://github.com/ucb-bar/firrtl/pull/111.patch"},"body":"This is deliberately incomplete because I wanted to get feedback before\nplowing ahead.  These passes handle constant propagation for bitwise\nand equality operators on UInt only, usually only when the widths match."},"comment":{"url":"https://api.github.com/repos/ucb-bar/firrtl/issues/comments/207631493","html_url":"https://github.com/ucb-bar/firrtl/pull/111#issuecomment-207631493","issue_url":"https://api.github.com/repos/ucb-bar/firrtl/issues/111","id":207631493,"user":{"login":"aswaterman","id":1031106,"avatar_url":"https://avatars.githubusercontent.com/u/1031106?v=3","gravatar_id":"","url":"https://api.github.com/users/aswaterman","html_url":"https://github.com/aswaterman","followers_url":"https://api.github.com/users/aswaterman/followers","following_url":"https://api.github.com/users/aswaterman/following{/other_user}","gists_url":"https://api.github.com/users/aswaterman/gists{/gist_id}","starred_url":"https://api.github.com/users/aswaterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aswaterman/subscriptions","organizations_url":"https://api.github.com/users/aswaterman/orgs","repos_url":"https://api.github.com/users/aswaterman/repos","events_url":"https://api.github.com/users/aswaterman/events{/privacy}","received_events_url":"https://api.github.com/users/aswaterman/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T22:25:40Z","updated_at":"2016-04-08T22:25:40Z","body":"Yeah, makes sense.  Are there any examples of tests written in that manner?\n\nOn Fri, Apr 8, 2016 at 1:35 PM, Adam Izraelevitz <notifications@github.com>\nwrote:\n\n> I think the only way is string comparison (or a slightly fancier string\n> comparison) of the FIRRTL output. If each test is written with the minimal\n> amount of FIRRTL to produce the specific result, it should be pretty robust\n> to other changes in the compiler (other than the parser/emitter, which\n> hopefully shouldn't change that much any more).\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ucb-bar/firrtl/pull/111#issuecomment-207592633>\n>\n"}}