{"action":"created","comment":{"url":"https://api.github.com/repos/qminer/qminer/pulls/comments/78380353","id":78380353,"diff_hunk":"@@ -381,9 +381,9 @@ void TVec<TVal, TSizeTy>::GetSubValV(const TSizeTy& _BValN, const TSizeTy& _EVal\n   const TSizeTy BValN=TInt::GetInRng(_BValN, 0, Len()-1);\n   const TSizeTy EValN=TInt::GetInRng(_EValN, 0, Len()-1);\n   const TSizeTy SubVals=TInt::GetMx(0, EValN-BValN+1);\n-  SubValV.Gen(SubVals, 0);\n-  for (TSizeTy ValN=BValN; ValN<=EValN; ValN++){\n-    SubValV.Add(GetVal(ValN));}\n+  SubValV.Resize(SubVals);\n+  memcpy(SubValV.ValT, ValT + BValN, SubVals * sizeof(TVal));","path":"src/glib/base/ds.hpp","position":8,"original_position":8,"commit_id":"c86109fc9db326630403ac19fd9aafaf249fd131","original_commit_id":"f52c4f7650cc78bbbfae827c413703b391b6f4ba","user":{"login":"blazf","id":775988,"avatar_url":"https://avatars.githubusercontent.com/u/775988?v=3","gravatar_id":"","url":"https://api.github.com/users/blazf","html_url":"https://github.com/blazf","followers_url":"https://api.github.com/users/blazf/followers","following_url":"https://api.github.com/users/blazf/following{/other_user}","gists_url":"https://api.github.com/users/blazf/gists{/gist_id}","starred_url":"https://api.github.com/users/blazf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blazf/subscriptions","organizations_url":"https://api.github.com/users/blazf/orgs","repos_url":"https://api.github.com/users/blazf/repos","events_url":"https://api.github.com/users/blazf/events{/privacy}","received_events_url":"https://api.github.com/users/blazf/received_events","type":"User","site_admin":false},"body":"How does this work for vector with elements that have more complex constructors and/or destructors? My guess is this is problematic for stuff like `TStr` where `memcpy` would copy the `char*` pointer, resulting in two `TStr` objects owning same `char*` pointer.","created_at":"2016-09-12T14:15:55Z","updated_at":"2016-09-12T14:15:55Z","html_url":"https://github.com/qminer/qminer/pull/469#discussion_r78380353","pull_request_url":"https://api.github.com/repos/qminer/qminer/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/qminer/qminer/pulls/comments/78380353"},"html":{"href":"https://github.com/qminer/qminer/pull/469#discussion_r78380353"},"pull_request":{"href":"https://api.github.com/repos/qminer/qminer/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/qminer/qminer/pulls/469","id":84603467,"html_url":"https://github.com/qminer/qminer/pull/469","diff_url":"https://github.com/qminer/qminer/pull/469.diff","patch_url":"https://github.com/qminer/qminer/pull/469.patch","issue_url":"https://api.github.com/repos/qminer/qminer/issues/469","number":469,"state":"open","locked":false,"title":"bug fixes for TStorePbBlob + various updates","user":{"login":"gregorleban","id":809658,"avatar_url":"https://avatars.githubusercontent.com/u/809658?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorleban","html_url":"https://github.com/gregorleban","followers_url":"https://api.github.com/users/gregorleban/followers","following_url":"https://api.github.com/users/gregorleban/following{/other_user}","gists_url":"https://api.github.com/users/gregorleban/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorleban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorleban/subscriptions","organizations_url":"https://api.github.com/users/gregorleban/orgs","repos_url":"https://api.github.com/users/gregorleban/repos","events_url":"https://api.github.com/users/gregorleban/events{/privacy}","received_events_url":"https://api.github.com/users/gregorleban/received_events","type":"User","site_admin":false},"body":"a larger pull request. mostly about fixes needed for making TStorePbBlob work properly like TStoreImpl. Also some changes in glib that it would be welcomed if somebody can validate","created_at":"2016-09-09T07:08:05Z","updated_at":"2016-09-12T14:15:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"489f3a09476e475abda794003aab81b7df9df83d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qminer/qminer/pulls/469/commits","review_comments_url":"https://api.github.com/repos/qminer/qminer/pulls/469/comments","review_comment_url":"https://api.github.com/repos/qminer/qminer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qminer/qminer/issues/469/comments","statuses_url":"https://api.github.com/repos/qminer/qminer/statuses/c86109fc9db326630403ac19fd9aafaf249fd131","head":{"label":"gregorleban:master","ref":"master","sha":"c86109fc9db326630403ac19fd9aafaf249fd131","user":{"login":"gregorleban","id":809658,"avatar_url":"https://avatars.githubusercontent.com/u/809658?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorleban","html_url":"https://github.com/gregorleban","followers_url":"https://api.github.com/users/gregorleban/followers","following_url":"https://api.github.com/users/gregorleban/following{/other_user}","gists_url":"https://api.github.com/users/gregorleban/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorleban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorleban/subscriptions","organizations_url":"https://api.github.com/users/gregorleban/orgs","repos_url":"https://api.github.com/users/gregorleban/repos","events_url":"https://api.github.com/users/gregorleban/events{/privacy}","received_events_url":"https://api.github.com/users/gregorleban/received_events","type":"User","site_admin":false},"repo":{"id":21094466,"name":"Qminer","full_name":"gregorleban/Qminer","owner":{"login":"gregorleban","id":809658,"avatar_url":"https://avatars.githubusercontent.com/u/809658?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorleban","html_url":"https://github.com/gregorleban","followers_url":"https://api.github.com/users/gregorleban/followers","following_url":"https://api.github.com/users/gregorleban/following{/other_user}","gists_url":"https://api.github.com/users/gregorleban/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorleban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorleban/subscriptions","organizations_url":"https://api.github.com/users/gregorleban/orgs","repos_url":"https://api.github.com/users/gregorleban/repos","events_url":"https://api.github.com/users/gregorleban/events{/privacy}","received_events_url":"https://api.github.com/users/gregorleban/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregorleban/Qminer","description":"Analytic platform for real-time large-scale streams containing structured and unstructured data.","fork":true,"url":"https://api.github.com/repos/gregorleban/Qminer","forks_url":"https://api.github.com/repos/gregorleban/Qminer/forks","keys_url":"https://api.github.com/repos/gregorleban/Qminer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorleban/Qminer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorleban/Qminer/teams","hooks_url":"https://api.github.com/repos/gregorleban/Qminer/hooks","issue_events_url":"https://api.github.com/repos/gregorleban/Qminer/issues/events{/number}","events_url":"https://api.github.com/repos/gregorleban/Qminer/events","assignees_url":"https://api.github.com/repos/gregorleban/Qminer/assignees{/user}","branches_url":"https://api.github.com/repos/gregorleban/Qminer/branches{/branch}","tags_url":"https://api.github.com/repos/gregorleban/Qminer/tags","blobs_url":"https://api.github.com/repos/gregorleban/Qminer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorleban/Qminer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorleban/Qminer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorleban/Qminer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorleban/Qminer/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorleban/Qminer/languages","stargazers_url":"https://api.github.com/repos/gregorleban/Qminer/stargazers","contributors_url":"https://api.github.com/repos/gregorleban/Qminer/contributors","subscribers_url":"https://api.github.com/repos/gregorleban/Qminer/subscribers","subscription_url":"https://api.github.com/repos/gregorleban/Qminer/subscription","commits_url":"https://api.github.com/repos/gregorleban/Qminer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorleban/Qminer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorleban/Qminer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorleban/Qminer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorleban/Qminer/contents/{+path}","compare_url":"https://api.github.com/repos/gregorleban/Qminer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorleban/Qminer/merges","archive_url":"https://api.github.com/repos/gregorleban/Qminer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorleban/Qminer/downloads","issues_url":"https://api.github.com/repos/gregorleban/Qminer/issues{/number}","pulls_url":"https://api.github.com/repos/gregorleban/Qminer/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorleban/Qminer/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorleban/Qminer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorleban/Qminer/labels{/name}","releases_url":"https://api.github.com/repos/gregorleban/Qminer/releases{/id}","deployments_url":"https://api.github.com/repos/gregorleban/Qminer/deployments","created_at":"2014-06-22T13:32:51Z","updated_at":"2016-05-19T09:47:04Z","pushed_at":"2016-09-11T09:30:48Z","git_url":"git://github.com/gregorleban/Qminer.git","ssh_url":"git@github.com:gregorleban/Qminer.git","clone_url":"https://github.com/gregorleban/Qminer.git","svn_url":"https://github.com/gregorleban/Qminer","homepage":"http://qminer.ijs.si/","size":31568,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qminer:master","ref":"master","sha":"b6836cee3fced939936371e8b519a2eb48437f39","user":{"login":"qminer","id":6430148,"avatar_url":"https://avatars.githubusercontent.com/u/6430148?v=3","gravatar_id":"","url":"https://api.github.com/users/qminer","html_url":"https://github.com/qminer","followers_url":"https://api.github.com/users/qminer/followers","following_url":"https://api.github.com/users/qminer/following{/other_user}","gists_url":"https://api.github.com/users/qminer/gists{/gist_id}","starred_url":"https://api.github.com/users/qminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qminer/subscriptions","organizations_url":"https://api.github.com/users/qminer/orgs","repos_url":"https://api.github.com/users/qminer/repos","events_url":"https://api.github.com/users/qminer/events{/privacy}","received_events_url":"https://api.github.com/users/qminer/received_events","type":"Organization","site_admin":false},"repo":{"id":16001682,"name":"qminer","full_name":"qminer/qminer","owner":{"login":"qminer","id":6430148,"avatar_url":"https://avatars.githubusercontent.com/u/6430148?v=3","gravatar_id":"","url":"https://api.github.com/users/qminer","html_url":"https://github.com/qminer","followers_url":"https://api.github.com/users/qminer/followers","following_url":"https://api.github.com/users/qminer/following{/other_user}","gists_url":"https://api.github.com/users/qminer/gists{/gist_id}","starred_url":"https://api.github.com/users/qminer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qminer/subscriptions","organizations_url":"https://api.github.com/users/qminer/orgs","repos_url":"https://api.github.com/users/qminer/repos","events_url":"https://api.github.com/users/qminer/events{/privacy}","received_events_url":"https://api.github.com/users/qminer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qminer/qminer","description":"Analytic platform for real-time large-scale streams containing structured and unstructured data.","fork":false,"url":"https://api.github.com/repos/qminer/qminer","forks_url":"https://api.github.com/repos/qminer/qminer/forks","keys_url":"https://api.github.com/repos/qminer/qminer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qminer/qminer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qminer/qminer/teams","hooks_url":"https://api.github.com/repos/qminer/qminer/hooks","issue_events_url":"https://api.github.com/repos/qminer/qminer/issues/events{/number}","events_url":"https://api.github.com/repos/qminer/qminer/events","assignees_url":"https://api.github.com/repos/qminer/qminer/assignees{/user}","branches_url":"https://api.github.com/repos/qminer/qminer/branches{/branch}","tags_url":"https://api.github.com/repos/qminer/qminer/tags","blobs_url":"https://api.github.com/repos/qminer/qminer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qminer/qminer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qminer/qminer/git/refs{/sha}","trees_url":"https://api.github.com/repos/qminer/qminer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qminer/qminer/statuses/{sha}","languages_url":"https://api.github.com/repos/qminer/qminer/languages","stargazers_url":"https://api.github.com/repos/qminer/qminer/stargazers","contributors_url":"https://api.github.com/repos/qminer/qminer/contributors","subscribers_url":"https://api.github.com/repos/qminer/qminer/subscribers","subscription_url":"https://api.github.com/repos/qminer/qminer/subscription","commits_url":"https://api.github.com/repos/qminer/qminer/commits{/sha}","git_commits_url":"https://api.github.com/repos/qminer/qminer/git/commits{/sha}","comments_url":"https://api.github.com/repos/qminer/qminer/comments{/number}","issue_comment_url":"https://api.github.com/repos/qminer/qminer/issues/comments{/number}","contents_url":"https://api.github.com/repos/qminer/qminer/contents/{+path}","compare_url":"https://api.github.com/repos/qminer/qminer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qminer/qminer/merges","archive_url":"https://api.github.com/repos/qminer/qminer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qminer/qminer/downloads","issues_url":"https://api.github.com/repos/qminer/qminer/issues{/number}","pulls_url":"https://api.github.com/repos/qminer/qminer/pulls{/number}","milestones_url":"https://api.github.com/repos/qminer/qminer/milestones{/number}","notifications_url":"https://api.github.com/repos/qminer/qminer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qminer/qminer/labels{/name}","releases_url":"https://api.github.com/repos/qminer/qminer/releases{/id}","deployments_url":"https://api.github.com/repos/qminer/qminer/deployments","created_at":"2014-01-17T14:26:52Z","updated_at":"2016-09-08T22:13:37Z","pushed_at":"2016-09-11T09:30:49Z","git_url":"git://github.com/qminer/qminer.git","ssh_url":"git@github.com:qminer/qminer.git","clone_url":"https://github.com/qminer/qminer.git","svn_url":"https://github.com/qminer/qminer","homepage":"http://qminer.ijs.si/","size":33403,"stargazers_count":115,"watchers_count":115,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":29,"forks":39,"open_issues":29,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qminer/qminer/pulls/469"},"html":{"href":"https://github.com/qminer/qminer/pull/469"},"issue":{"href":"https://api.github.com/repos/qminer/qminer/issues/469"},"comments":{"href":"https://api.github.com/repos/qminer/qminer/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/qminer/qminer/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/qminer/qminer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qminer/qminer/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/qminer/qminer/statuses/c86109fc9db326630403ac19fd9aafaf249fd131"}}}}
{"actor":{"display_login":"blazf"}}