{"action":"opened","number":84,"pull_request":{"url":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84","id":67899641,"html_url":"https://github.com/tinfoil/devise-two-factor/pull/84","diff_url":"https://github.com/tinfoil/devise-two-factor/pull/84.diff","patch_url":"https://github.com/tinfoil/devise-two-factor/pull/84.patch","issue_url":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/84","number":84,"state":"open","locked":false,"title":"Use 128 bits, not 1024, as a secret key length","user":{"login":"mattcg","id":282964,"avatar_url":"https://avatars.githubusercontent.com/u/282964?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcg","html_url":"https://github.com/mattcg","followers_url":"https://api.github.com/users/mattcg/followers","following_url":"https://api.github.com/users/mattcg/following{/other_user}","gists_url":"https://api.github.com/users/mattcg/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcg/subscriptions","organizations_url":"https://api.github.com/users/mattcg/orgs","repos_url":"https://api.github.com/users/mattcg/repos","events_url":"https://api.github.com/users/mattcg/events{/privacy}","received_events_url":"https://api.github.com/users/mattcg/received_events","type":"User","site_admin":false},"body":"`ROTP::Base32.random_base32` accepts a length in bytes, not bits, as a parameter. `otp_secret_length` seems to be mistakenly set to 128 bytes, rather than 128 bits, by default.\r\n\r\nWhile 1024 bits results in a more secure key, it is impossible for users who are unable to scan a QR code to enter it into Google Authenticator.\r\n\r\nRFC 4226 recommends a minimum of 128 bits: https://tools.ietf.org/html/rfc4226.html#section-4.","created_at":"2016-04-26T14:49:47Z","updated_at":"2016-04-26T14:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84/commits","review_comments_url":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84/comments","review_comment_url":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/84/comments","statuses_url":"https://api.github.com/repos/tinfoil/devise-two-factor/statuses/7ff1dabb452adfdfd502f31ae5189d8da832280f","head":{"label":"mattcg:patch-1","ref":"patch-1","sha":"7ff1dabb452adfdfd502f31ae5189d8da832280f","user":{"login":"mattcg","id":282964,"avatar_url":"https://avatars.githubusercontent.com/u/282964?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcg","html_url":"https://github.com/mattcg","followers_url":"https://api.github.com/users/mattcg/followers","following_url":"https://api.github.com/users/mattcg/following{/other_user}","gists_url":"https://api.github.com/users/mattcg/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcg/subscriptions","organizations_url":"https://api.github.com/users/mattcg/orgs","repos_url":"https://api.github.com/users/mattcg/repos","events_url":"https://api.github.com/users/mattcg/events{/privacy}","received_events_url":"https://api.github.com/users/mattcg/received_events","type":"User","site_admin":false},"repo":{"id":57136346,"name":"devise-two-factor","full_name":"mattcg/devise-two-factor","owner":{"login":"mattcg","id":282964,"avatar_url":"https://avatars.githubusercontent.com/u/282964?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcg","html_url":"https://github.com/mattcg","followers_url":"https://api.github.com/users/mattcg/followers","following_url":"https://api.github.com/users/mattcg/following{/other_user}","gists_url":"https://api.github.com/users/mattcg/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcg/subscriptions","organizations_url":"https://api.github.com/users/mattcg/orgs","repos_url":"https://api.github.com/users/mattcg/repos","events_url":"https://api.github.com/users/mattcg/events{/privacy}","received_events_url":"https://api.github.com/users/mattcg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattcg/devise-two-factor","description":"Barebones two-factor authentication with Devise","fork":true,"url":"https://api.github.com/repos/mattcg/devise-two-factor","forks_url":"https://api.github.com/repos/mattcg/devise-two-factor/forks","keys_url":"https://api.github.com/repos/mattcg/devise-two-factor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattcg/devise-two-factor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattcg/devise-two-factor/teams","hooks_url":"https://api.github.com/repos/mattcg/devise-two-factor/hooks","issue_events_url":"https://api.github.com/repos/mattcg/devise-two-factor/issues/events{/number}","events_url":"https://api.github.com/repos/mattcg/devise-two-factor/events","assignees_url":"https://api.github.com/repos/mattcg/devise-two-factor/assignees{/user}","branches_url":"https://api.github.com/repos/mattcg/devise-two-factor/branches{/branch}","tags_url":"https://api.github.com/repos/mattcg/devise-two-factor/tags","blobs_url":"https://api.github.com/repos/mattcg/devise-two-factor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattcg/devise-two-factor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattcg/devise-two-factor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattcg/devise-two-factor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattcg/devise-two-factor/statuses/{sha}","languages_url":"https://api.github.com/repos/mattcg/devise-two-factor/languages","stargazers_url":"https://api.github.com/repos/mattcg/devise-two-factor/stargazers","contributors_url":"https://api.github.com/repos/mattcg/devise-two-factor/contributors","subscribers_url":"https://api.github.com/repos/mattcg/devise-two-factor/subscribers","subscription_url":"https://api.github.com/repos/mattcg/devise-two-factor/subscription","commits_url":"https://api.github.com/repos/mattcg/devise-two-factor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattcg/devise-two-factor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattcg/devise-two-factor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattcg/devise-two-factor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattcg/devise-two-factor/contents/{+path}","compare_url":"https://api.github.com/repos/mattcg/devise-two-factor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattcg/devise-two-factor/merges","archive_url":"https://api.github.com/repos/mattcg/devise-two-factor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattcg/devise-two-factor/downloads","issues_url":"https://api.github.com/repos/mattcg/devise-two-factor/issues{/number}","pulls_url":"https://api.github.com/repos/mattcg/devise-two-factor/pulls{/number}","milestones_url":"https://api.github.com/repos/mattcg/devise-two-factor/milestones{/number}","notifications_url":"https://api.github.com/repos/mattcg/devise-two-factor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattcg/devise-two-factor/labels{/name}","releases_url":"https://api.github.com/repos/mattcg/devise-two-factor/releases{/id}","deployments_url":"https://api.github.com/repos/mattcg/devise-two-factor/deployments","created_at":"2016-04-26T14:45:23Z","updated_at":"2016-04-26T14:45:24Z","pushed_at":"2016-04-26T14:47:51Z","git_url":"git://github.com/mattcg/devise-two-factor.git","ssh_url":"git@github.com:mattcg/devise-two-factor.git","clone_url":"https://github.com/mattcg/devise-two-factor.git","svn_url":"https://github.com/mattcg/devise-two-factor","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tinfoil:master","ref":"master","sha":"604a6a5bb0bf79aa6f89537698aec2fc10fb85dc","user":{"login":"tinfoil","id":1316472,"avatar_url":"https://avatars.githubusercontent.com/u/1316472?v=3","gravatar_id":"","url":"https://api.github.com/users/tinfoil","html_url":"https://github.com/tinfoil","followers_url":"https://api.github.com/users/tinfoil/followers","following_url":"https://api.github.com/users/tinfoil/following{/other_user}","gists_url":"https://api.github.com/users/tinfoil/gists{/gist_id}","starred_url":"https://api.github.com/users/tinfoil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinfoil/subscriptions","organizations_url":"https://api.github.com/users/tinfoil/orgs","repos_url":"https://api.github.com/users/tinfoil/repos","events_url":"https://api.github.com/users/tinfoil/events{/privacy}","received_events_url":"https://api.github.com/users/tinfoil/received_events","type":"Organization","site_admin":false},"repo":{"id":19710915,"name":"devise-two-factor","full_name":"tinfoil/devise-two-factor","owner":{"login":"tinfoil","id":1316472,"avatar_url":"https://avatars.githubusercontent.com/u/1316472?v=3","gravatar_id":"","url":"https://api.github.com/users/tinfoil","html_url":"https://github.com/tinfoil","followers_url":"https://api.github.com/users/tinfoil/followers","following_url":"https://api.github.com/users/tinfoil/following{/other_user}","gists_url":"https://api.github.com/users/tinfoil/gists{/gist_id}","starred_url":"https://api.github.com/users/tinfoil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinfoil/subscriptions","organizations_url":"https://api.github.com/users/tinfoil/orgs","repos_url":"https://api.github.com/users/tinfoil/repos","events_url":"https://api.github.com/users/tinfoil/events{/privacy}","received_events_url":"https://api.github.com/users/tinfoil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tinfoil/devise-two-factor","description":"Barebones two-factor authentication with Devise","fork":false,"url":"https://api.github.com/repos/tinfoil/devise-two-factor","forks_url":"https://api.github.com/repos/tinfoil/devise-two-factor/forks","keys_url":"https://api.github.com/repos/tinfoil/devise-two-factor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinfoil/devise-two-factor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinfoil/devise-two-factor/teams","hooks_url":"https://api.github.com/repos/tinfoil/devise-two-factor/hooks","issue_events_url":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/events{/number}","events_url":"https://api.github.com/repos/tinfoil/devise-two-factor/events","assignees_url":"https://api.github.com/repos/tinfoil/devise-two-factor/assignees{/user}","branches_url":"https://api.github.com/repos/tinfoil/devise-two-factor/branches{/branch}","tags_url":"https://api.github.com/repos/tinfoil/devise-two-factor/tags","blobs_url":"https://api.github.com/repos/tinfoil/devise-two-factor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinfoil/devise-two-factor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinfoil/devise-two-factor/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinfoil/devise-two-factor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinfoil/devise-two-factor/statuses/{sha}","languages_url":"https://api.github.com/repos/tinfoil/devise-two-factor/languages","stargazers_url":"https://api.github.com/repos/tinfoil/devise-two-factor/stargazers","contributors_url":"https://api.github.com/repos/tinfoil/devise-two-factor/contributors","subscribers_url":"https://api.github.com/repos/tinfoil/devise-two-factor/subscribers","subscription_url":"https://api.github.com/repos/tinfoil/devise-two-factor/subscription","commits_url":"https://api.github.com/repos/tinfoil/devise-two-factor/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinfoil/devise-two-factor/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinfoil/devise-two-factor/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinfoil/devise-two-factor/contents/{+path}","compare_url":"https://api.github.com/repos/tinfoil/devise-two-factor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinfoil/devise-two-factor/merges","archive_url":"https://api.github.com/repos/tinfoil/devise-two-factor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinfoil/devise-two-factor/downloads","issues_url":"https://api.github.com/repos/tinfoil/devise-two-factor/issues{/number}","pulls_url":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls{/number}","milestones_url":"https://api.github.com/repos/tinfoil/devise-two-factor/milestones{/number}","notifications_url":"https://api.github.com/repos/tinfoil/devise-two-factor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinfoil/devise-two-factor/labels{/name}","releases_url":"https://api.github.com/repos/tinfoil/devise-two-factor/releases{/id}","deployments_url":"https://api.github.com/repos/tinfoil/devise-two-factor/deployments","created_at":"2014-05-12T18:46:54Z","updated_at":"2016-04-24T21:43:43Z","pushed_at":"2016-04-08T19:41:31Z","git_url":"git://github.com/tinfoil/devise-two-factor.git","ssh_url":"git@github.com:tinfoil/devise-two-factor.git","clone_url":"https://github.com/tinfoil/devise-two-factor.git","svn_url":"https://github.com/tinfoil/devise-two-factor","homepage":"","size":146,"stargazers_count":431,"watchers_count":431,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":17,"forks":49,"open_issues":17,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84"},"html":{"href":"https://github.com/tinfoil/devise-two-factor/pull/84"},"issue":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/84"},"comments":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/tinfoil/devise-two-factor/statuses/7ff1dabb452adfdfd502f31ae5189d8da832280f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}