{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/71812636","id":71812636,"diff_hunk":"@@ -325,7 +325,8 @@ GrpcService.prototype.requestStream = function(protoOpts, reqOpts) {\n \n     request: function() {\n       return service[protoOpts.method](reqOpts, grpcOpts)\n-        .on('status', function(status) {\n+        .on('metadata', function() {\n+          var status = this.received_status || { code: 0 };","path":"lib/common/grpc-service.js","position":6,"original_position":6,"commit_id":"4032b4315dbac9bd2e7b3c672bc28ceb2e54d846","original_commit_id":"e56bdbf34b9ac95f49c3b299182c502d9f43b721","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"body":"You should listen for the `status` event from the grpc call to get the grpc status. But that event is emitted when the call completes, so you shouldn't be expecting it at the beginning of a call.","created_at":"2016-07-22T00:47:46Z","updated_at":"2016-07-22T00:47:46Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444#discussion_r71812636","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/71812636"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444#discussion_r71812636"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444","id":78404963,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1444","number":1444,"state":"open","locked":false,"title":"grpc: listen for metadata event instead of status","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"Closes #1443 \r\n\r\nThis fixes an issue where a grpc readable stream would hang indefinitely because we weren't draining it. Instead of listening for a status event, which occurs after results have been processed, we're now going to listen instead for a metadata event. ","created_at":"2016-07-21T23:39:20Z","updated_at":"2016-07-22T00:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e02dafbcdcab78b5901bd2821518d74fc1d877e7","assignee":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1444/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/4032b4315dbac9bd2e7b3c672bc28ceb2e54d846","head":{"label":"callmehiphop:bigtable-stream-bug","ref":"bigtable-stream-bug","sha":"4032b4315dbac9bd2e7b3c672bc28ceb2e54d846","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"repo":{"id":39030018,"name":"gcloud-node","full_name":"callmehiphop/gcloud-node","owner":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callmehiphop/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":true,"url":"https://api.github.com/repos/callmehiphop/gcloud-node","forks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/forks","keys_url":"https://api.github.com/repos/callmehiphop/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callmehiphop/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callmehiphop/gcloud-node/teams","hooks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/events","assignees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/callmehiphop/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/tags","blobs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callmehiphop/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/callmehiphop/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscription","commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/callmehiphop/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callmehiphop/gcloud-node/merges","archive_url":"https://api.github.com/repos/callmehiphop/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callmehiphop/gcloud-node/downloads","issues_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/callmehiphop/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/callmehiphop/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/callmehiphop/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callmehiphop/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/callmehiphop/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/deployments","created_at":"2015-07-13T18:32:45Z","updated_at":"2016-06-24T15:31:14Z","pushed_at":"2016-07-21T23:42:30Z","git_url":"git://github.com/callmehiphop/gcloud-node.git","ssh_url":"git@github.com:callmehiphop/gcloud-node.git","clone_url":"https://github.com/callmehiphop/gcloud-node.git","svn_url":"https://github.com/callmehiphop/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":15127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"5689f968d1a53a2ca6a17938390b12c6e283b004","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19483273,"name":"gcloud-node","full_name":"GoogleCloudPlatform/gcloud-node","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/deployments","created_at":"2014-05-06T06:18:00Z","updated_at":"2016-07-20T08:44:42Z","pushed_at":"2016-07-21T23:42:31Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-node.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-node.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-node.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":17139,"stargazers_count":845,"watchers_count":845,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":183,"mirror_url":null,"open_issues_count":52,"forks":183,"open_issues":52,"watchers":845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1444"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1444"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/4032b4315dbac9bd2e7b3c672bc28ceb2e54d846"}}}}
{"actor":{"display_login":"murgatroid99"}}