{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/57839472","id":57839472,"diff_hunk":"@@ -140,6 +153,13 @@\n       <FilesToPackage Condition=\"'%(FilesToPackage.SubFolder)' != ''\">\n         <TargetPath>%(TargetPath)%(FilesToPackage.SubFolder)</TargetPath>\n       </FilesToPackage>\n+\n+      <!-- Include source files for symbol packages. -->\n+      <FilesToPackage Include=\"@(Compile->'%(FullPath)')\">\n+        <TargetPath>src</TargetPath>","path":"src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageFiles/PackageLibs.targets","position":37,"original_position":37,"commit_id":"59f9783b3e378021f3d32fe5afa9c6fdba740810","original_commit_id":"59f9783b3e378021f3d32fe5afa9c6fdba740810","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Is there ever any case where a source file isn't somewhere under ProjectRoot? If there are is my assumption that they just end up in the root src target folder? Will the pdb indexing of the source code actually be affected by that?","created_at":"2016-03-30T05:48:48Z","updated_at":"2016-03-30T05:48:48Z","html_url":"https://github.com/dotnet/buildtools/pull/581#discussion_r57839472","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/57839472"},"html":{"href":"https://github.com/dotnet/buildtools/pull/581#discussion_r57839472"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/581","id":64185790,"html_url":"https://github.com/dotnet/buildtools/pull/581","diff_url":"https://github.com/dotnet/buildtools/pull/581.diff","patch_url":"https://github.com/dotnet/buildtools/pull/581.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/581","number":581,"state":"open","locked":false,"title":"Add symbol package creation","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"Symbol packages include pdb files for each dll and any source files inside the project root that are referenced in `<Compile>` items. The nuspec contains all these files and the `NuGetPack` task filters using the same logic as the `nuget pack` command.\r\n\r\nThis is enabled by default in corefx and wcf but will require a change in TFS to turn on (and a change to add a placeholder to a manually-created nuspec that has symbols but no source.)\r\n\r\nTested successfully on Windows with corefx, wcf, and TFS.\r\n\r\nOn OSX with corefx no symbol packages are created, presumably because the source file paths aren't handled correctly. Looking into it. I might create an issue and get to it later because getting symbols published from TFS to MyGet seems like the higher priority.\r\n\r\nFor an example of source and symbol indexing at work, check out https://www.myget.org/feed/dagood-test-dotnet-core/package/nuget/System.Linq.Parallel. (You will need to log in to see it, but you shouldn't need any special permissions.) MyGet should have a symbol source for the feed that can be used from VS--I don't have the newest dotnet core VS tooling set up so I'm still working on testing that out.\r\n\r\n/cc @weshaggard @ericstj @gkhanna79 \r\n\r\n(Sorry about the NuGetPack diff--I moved some code out into another method and unindented as part of my changes. :cry:)","created_at":"2016-03-25T17:29:45Z","updated_at":"2016-03-30T05:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b53a1023e4a570925e4ca32ae40397224ec02f8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/581/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/581/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/581/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/59f9783b3e378021f3d32fe5afa9c6fdba740810","head":{"label":"dagood:create-symbol-packages","ref":"create-symbol-packages","sha":"59f9783b3e378021f3d32fe5afa9c6fdba740810","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"repo":{"id":46803860,"name":"buildtools","full_name":"dagood/buildtools","owner":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dagood/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/dagood/buildtools","forks_url":"https://api.github.com/repos/dagood/buildtools/forks","keys_url":"https://api.github.com/repos/dagood/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagood/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagood/buildtools/teams","hooks_url":"https://api.github.com/repos/dagood/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dagood/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dagood/buildtools/events","assignees_url":"https://api.github.com/repos/dagood/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dagood/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dagood/buildtools/tags","blobs_url":"https://api.github.com/repos/dagood/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagood/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagood/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagood/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagood/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dagood/buildtools/languages","stargazers_url":"https://api.github.com/repos/dagood/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dagood/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dagood/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dagood/buildtools/subscription","commits_url":"https://api.github.com/repos/dagood/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagood/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagood/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagood/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagood/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dagood/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagood/buildtools/merges","archive_url":"https://api.github.com/repos/dagood/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagood/buildtools/downloads","issues_url":"https://api.github.com/repos/dagood/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dagood/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dagood/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dagood/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagood/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dagood/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dagood/buildtools/deployments","created_at":"2015-11-24T16:24:26Z","updated_at":"2015-11-24T16:24:28Z","pushed_at":"2016-03-25T22:28:07Z","git_url":"git://github.com/dagood/buildtools.git","ssh_url":"git@github.com:dagood/buildtools.git","clone_url":"https://github.com/dagood/buildtools.git","svn_url":"https://github.com/dagood/buildtools","homepage":"","size":2617,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"dotnet:master","ref":"master","sha":"c82326a709e0cac3b503dc76b60a2d446ed8eacc","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-03-25T21:45:35Z","pushed_at":"2016-03-30T04:35:22Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":3270,"stargazers_count":394,"watchers_count":394,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":57,"forks":178,"open_issues":57,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/581"},"html":{"href":"https://github.com/dotnet/buildtools/pull/581"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/581"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/59f9783b3e378021f3d32fe5afa9c6fdba740810"}}}}