{"action":"created","issue":{"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/369","repository_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable","labels_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/369/labels{/name}","comments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/369/comments","events_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/369/events","html_url":"https://github.com/IBAnimatable/IBAnimatable/pull/369","id":192497369,"number":369,"title":"Bump SwiftLint 0.13.1","user":{"login":"tbaranes","id":1402212,"avatar_url":"https://avatars.githubusercontent.com/u/1402212?v=3","gravatar_id":"","url":"https://api.github.com/users/tbaranes","html_url":"https://github.com/tbaranes","followers_url":"https://api.github.com/users/tbaranes/followers","following_url":"https://api.github.com/users/tbaranes/following{/other_user}","gists_url":"https://api.github.com/users/tbaranes/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaranes/subscriptions","organizations_url":"https://api.github.com/users/tbaranes/orgs","repos_url":"https://api.github.com/users/tbaranes/repos","events_url":"https://api.github.com/users/tbaranes/events{/privacy}","received_events_url":"https://api.github.com/users/tbaranes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T07:48:52Z","updated_at":"2016-11-30T08:01:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/369","html_url":"https://github.com/IBAnimatable/IBAnimatable/pull/369","diff_url":"https://github.com/IBAnimatable/IBAnimatable/pull/369.diff","patch_url":"https://github.com/IBAnimatable/IBAnimatable/pull/369.patch"},"body":"SwiftLint 0.13.1 is out! I used that occasion to review a bit the rules we are using. Since, we are getting more and more to contribute in this project (that's awesome!), it's even more important now to have a strict coding style.\r\n\r\nThat's why I added a few `opt_in_rules` that have meanings for IBAnimatable:\r\n - closure_spacing\r\n - conditional_returns_on_newline\r\n - empty_count\r\n - explicit_init\r\n - overridden_super_call\r\n - redundant_nil_coalescing\r\n - nimble_operator (that one will be useful only if we write tests one day 😬)\r\n\r\nI'd like also use do a reminder of the disabled rules that I think they can /  should be enabled:\r\n  - **trailing_whitespace**: that one has been disabled because we have a lot of warnings. I will fix that soon\r\n  - **line_length** (88 warnings): We have quiet long lines in IBAnimatable, I think it will be worth to reduce them\r\n  - **cyclomatic_complexity** (3 warnings, 2 errors): That one is hard to fix without changing IBAnimatable core. I don't really mind since it's our core is build like that, but it's worth a reminder: _Do we really want that?_\r\n  - **function_body_length** (7 warnings): mostly due to the huge switch. Same speech as `cyclomatic_complexity` rule, the project is build on enums so we have huge switch. Just a reminder.\r\n  - **type_name** (14 warnings): mostly due to `AnimatableActivityIndicator*`. I already though that our names are long, very long (we basically have a long prefix (`Animatable*`) and suffix (`Designable`), but right now, I have no idea how to reduce them.\r\n\r\nThat last part can be a full issue, so I will open one if any of you wants to talk more about this. For now, that PR is ready to go 😬"},"comment":{"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/comments/263807983","html_url":"https://github.com/IBAnimatable/IBAnimatable/pull/369#issuecomment-263807983","issue_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/369","id":263807983,"user":{"login":"Panajev","id":562991,"avatar_url":"https://avatars.githubusercontent.com/u/562991?v=3","gravatar_id":"","url":"https://api.github.com/users/Panajev","html_url":"https://github.com/Panajev","followers_url":"https://api.github.com/users/Panajev/followers","following_url":"https://api.github.com/users/Panajev/following{/other_user}","gists_url":"https://api.github.com/users/Panajev/gists{/gist_id}","starred_url":"https://api.github.com/users/Panajev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Panajev/subscriptions","organizations_url":"https://api.github.com/users/Panajev/orgs","repos_url":"https://api.github.com/users/Panajev/repos","events_url":"https://api.github.com/users/Panajev/events{/privacy}","received_events_url":"https://api.github.com/users/Panajev/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T08:01:57Z","updated_at":"2016-11-30T08:01:57Z","body":"Only two points stick out for me: line length, depending on the value and type name length.\n\nFor the former, today's screens are far wider than they used to be, but a reasonable cap could be put in place (although line wrapping gets the job done) and clarity should still be king... which leads me to the length of type names. We do have fuzzy matches autocomplete, do we really have an issue there?\n\nSent from my iPhone\n\n> On 30 Nov 2016, at 07:48, Tom Baranes <notifications@github.com> wrote:\n> \n> SwiftLint 0.13.1 is out! I used that occasion to review a bit the rules we are using. Since, we are getting more and more to contribute in this project (that's awesome!), it's even more important now to have a strict coding style.\n> \n> Added a few opt_in_rules:\n> \n> closure_spacing\n> conditional_returns_on_newline\n> empty_count\n> explicit_init\n> overridden_super_call\n> redundant_nil_coalescing\n> nimble_operator (that one will be useful only if we write tests one day 😬)\n> I'd like also use do a reminder of the disabled rules that I think they can / should be enabled:\n> \n> trailing_whitespace: that one has been disabled because we have a lot of warnings. I will fix that soon\n> line_length (88 warnings): We have quiet long lines in IBAnimatable, I think it will be worth to reduce them\n> cyclomatic_complexity (3 warnings, 2 errors): That one is hard to fix without changing IBAnimatable core. I don't really mind since it's our core is build like that, but it's worth a reminder: Do we really want that?\n> function_body_length (7 warnings): mostly due to the huge switch. Same speech as cyclomatic_complexity rule, the project is build on enums so we have huge switch. Just a reminder.\n> type_name (14 warnings): mostly due to AnimatableActivityIndicator*. I already though that our names are long, very long (we basically have a long prefix (Animatable*) and suffix (Designable), but right now, I have no idea how to reduce them.\n> That last part can be a full issue, so I will open one if any of you wants to talk more about this. For now, that PR is ready to go 😬\n> \n> You can view, comment on, or merge this pull request online at:\n> \n>   https://github.com/IBAnimatable/IBAnimatable/pull/369\n> \n> Commit Summary\n> \n> Add few swiftlint opt_in_rules\n> Fix lint warnings\n> Reenable file_length rule\n> File Changes\n> \n> M .swiftlint.yml (15)\n> M IBAnimatable/Animatable.swift (1)\n> M IBAnimatable/ColorType.swift (84)\n> M IBAnimatable/ContainerTransition.swift (2)\n> M IBAnimatable/GradientType.swift (689)\n> M IBAnimatable/PresentationAnimationType.swift (6)\n> M IBAnimatable/PresentationModalSize.swift (6)\n> M IBAnimatable/Utils.swift (2)\n> M IBAnimatableApp/GradientViewController.swift (6)\n> M IBAnimatableApp/MaskViewController.swift (2)\n> M IBAnimatableApp/ParamType.swift (2)\n> M Scripts/GradientsTypeScript.swift (2)\n> Patch Links:\n> \n> https://github.com/IBAnimatable/IBAnimatable/pull/369.patch\n> https://github.com/IBAnimatable/IBAnimatable/pull/369.diff\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"Panajev"}}