{"action":"created","comment":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/84169583","pull_request_review_id":4963903,"id":84169583,"diff_hunk":"@@ -1258,9 +1258,11 @@ def _monitor(self, msg):\n                                              obj))\n         descriptor_uid = new_uid()\n         data_keys = obj.describe()\n-        config = obj.read_configuration()\n-        for key, val in list(config.items()):\n-            val['value'] = sanitize_np(val['value'])\n+        config = {obj.name: {'data': {}, 'timestamps': {}}}\n+        config[obj.name]['data_keys'] = obj.describe_configuration()\n+        for key, val in list(obj.read_configuration().items()):\n+            config[obj.name]['data'][key] = sanitize_np(val['value'])\n+            config[obj.name]['data'][key] = val['timestamp']","path":"bluesky/run_engine.py","position":11,"original_position":11,"commit_id":"b1ae9ef3a9917361f06a3cec55a4ded185b33d5e","original_commit_id":"b1ae9ef3a9917361f06a3cec55a4ded185b33d5e","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":":sheep:.","created_at":"2016-10-19T21:19:37Z","updated_at":"2016-10-19T21:19:37Z","html_url":"https://github.com/NSLS-II/bluesky/pull/577#discussion_r84169583","pull_request_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577","_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/84169583"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/577#discussion_r84169583"},"pull_request":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577","id":90058818,"html_url":"https://github.com/NSLS-II/bluesky/pull/577","diff_url":"https://github.com/NSLS-II/bluesky/pull/577.diff","patch_url":"https://github.com/NSLS-II/bluesky/pull/577.patch","issue_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/577","number":577,"state":"open","locked":false,"title":"FIX: _monitor was packing configuration wrong.","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":"Stop-stopping bug in the RunEngine monitoring code organized the configuration into the descriptor with the wrong layout. The currently-deployed code acquired data without complaint but the databroker errors (rightly) when it can't find the keys it expects.\r\n\r\nIn addition to this PR, which should probably be merged and deployed ASAP, we should:\r\n\r\n* add more tests that exercise configuration (I will add at least one to this PR later today, but I have to teach first.)\r\n* make the event_model stricter (mentioned way back in https://github.com/NSLS-II/bluesky/issues/134) -- this should have produced an error at acquisition time!\r\n\r\nCan you look into this next, @licode? Reference for how the Event Descriptor is organized: http://nsls-ii.github.io/bluesky/event_descriptors.html","created_at":"2016-10-19T17:51:17Z","updated_at":"2016-10-19T21:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f1894fab187a076db76c147d7456c3d8d5c3544","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577/commits","review_comments_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577/comments","review_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/577/comments","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/b1ae9ef3a9917361f06a3cec55a4ded185b33d5e","head":{"label":"danielballan:fix-monitor","ref":"fix-monitor","sha":"b1ae9ef3a9917361f06a3cec55a4ded185b33d5e","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"repo":{"id":39904738,"name":"bluesky","full_name":"danielballan/bluesky","owner":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielballan/bluesky","description":"a data collection interface","fork":true,"url":"https://api.github.com/repos/danielballan/bluesky","forks_url":"https://api.github.com/repos/danielballan/bluesky/forks","keys_url":"https://api.github.com/repos/danielballan/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielballan/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielballan/bluesky/teams","hooks_url":"https://api.github.com/repos/danielballan/bluesky/hooks","issue_events_url":"https://api.github.com/repos/danielballan/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/danielballan/bluesky/events","assignees_url":"https://api.github.com/repos/danielballan/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/danielballan/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/danielballan/bluesky/tags","blobs_url":"https://api.github.com/repos/danielballan/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielballan/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielballan/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielballan/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielballan/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/danielballan/bluesky/languages","stargazers_url":"https://api.github.com/repos/danielballan/bluesky/stargazers","contributors_url":"https://api.github.com/repos/danielballan/bluesky/contributors","subscribers_url":"https://api.github.com/repos/danielballan/bluesky/subscribers","subscription_url":"https://api.github.com/repos/danielballan/bluesky/subscription","commits_url":"https://api.github.com/repos/danielballan/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielballan/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielballan/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielballan/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielballan/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/danielballan/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielballan/bluesky/merges","archive_url":"https://api.github.com/repos/danielballan/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielballan/bluesky/downloads","issues_url":"https://api.github.com/repos/danielballan/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/danielballan/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/danielballan/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/danielballan/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielballan/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/danielballan/bluesky/releases{/id}","deployments_url":"https://api.github.com/repos/danielballan/bluesky/deployments","created_at":"2015-07-29T16:42:41Z","updated_at":"2016-01-27T22:18:04Z","pushed_at":"2016-10-19T17:47:06Z","git_url":"git://github.com/danielballan/bluesky.git","ssh_url":"git@github.com:danielballan/bluesky.git","clone_url":"https://github.com/danielballan/bluesky.git","svn_url":"https://github.com/danielballan/bluesky","homepage":"http://danielballan.github.io/bluesky","size":3601,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NSLS-II:master","ref":"master","sha":"09f6d19d3826d42f9275542b9ab7aa4b1b6be1d0","user":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"repo":{"id":36754446,"name":"bluesky","full_name":"NSLS-II/bluesky","owner":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NSLS-II/bluesky","description":"a data collection interface","fork":false,"url":"https://api.github.com/repos/NSLS-II/bluesky","forks_url":"https://api.github.com/repos/NSLS-II/bluesky/forks","keys_url":"https://api.github.com/repos/NSLS-II/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NSLS-II/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NSLS-II/bluesky/teams","hooks_url":"https://api.github.com/repos/NSLS-II/bluesky/hooks","issue_events_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/NSLS-II/bluesky/events","assignees_url":"https://api.github.com/repos/NSLS-II/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/NSLS-II/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/NSLS-II/bluesky/tags","blobs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NSLS-II/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/NSLS-II/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/NSLS-II/bluesky/languages","stargazers_url":"https://api.github.com/repos/NSLS-II/bluesky/stargazers","contributors_url":"https://api.github.com/repos/NSLS-II/bluesky/contributors","subscribers_url":"https://api.github.com/repos/NSLS-II/bluesky/subscribers","subscription_url":"https://api.github.com/repos/NSLS-II/bluesky/subscription","commits_url":"https://api.github.com/repos/NSLS-II/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/NSLS-II/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/NSLS-II/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/NSLS-II/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NSLS-II/bluesky/merges","archive_url":"https://api.github.com/repos/NSLS-II/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NSLS-II/bluesky/downloads","issues_url":"https://api.github.com/repos/NSLS-II/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/NSLS-II/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/NSLS-II/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NSLS-II/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/NSLS-II/bluesky/releases{/id}","deployments_url":"https://api.github.com/repos/NSLS-II/bluesky/deployments","created_at":"2015-06-02T18:50:18Z","updated_at":"2016-09-14T14:33:06Z","pushed_at":"2016-10-19T17:55:38Z","git_url":"git://github.com/NSLS-II/bluesky.git","ssh_url":"git@github.com:NSLS-II/bluesky.git","clone_url":"https://github.com/NSLS-II/bluesky.git","svn_url":"https://github.com/NSLS-II/bluesky","homepage":"http://nsls-ii.github.io/bluesky","size":2942,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":36,"forks":12,"open_issues":36,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/577"},"issue":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/577"},"comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/NSLS-II/bluesky/statuses/b1ae9ef3a9917361f06a3cec55a4ded185b33d5e"}}}}
{"actor":{"display_login":"danielballan"}}