{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/88089985","pull_request_review_id":8674042,"id":88089985,"diff_hunk":"@@ -0,0 +1,184 @@\n+{\n+  \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\n+  \"contentVersion\": \"1.0.0.0\",\n+  \"parameters\": {\n+    \"clusterName\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"The name of the HDInsight cluster to create.\"\n+      }\n+    },\n+    \"clusterLoginUserName\": {\n+      \"type\": \"string\",\n+      \"defaultValue\": \"admin\",\n+      \"metadata\": {\n+        \"description\": \"These credentials can be used to submit jobs to the cluster and to log into cluster dashboards.\"\n+      }\n+    },\n+    \"clusterLoginPassword\": {\n+      \"type\": \"securestring\",\n+      \"metadata\": {\n+        \"description\": \"The password must be at least 10 characters in length and must contain at least one digit, one non-alphanumeric character, and one upper or lower case letter.\"\n+      }\n+    },\n+    \"sshUserName\": {\n+      \"type\": \"string\",\n+      \"defaultValue\": \"sshuser\",\n+      \"metadata\": {\n+        \"description\": \"These credentials can be used to remotely access the cluster.\"\n+      }\n+    },\n+    \"sshPassword\": {\n+      \"type\": \"securestring\",\n+      \"metadata\": {\n+        \"description\": \"The password must be at least 10 characters in length and must contain at least one digit, one non-alphanumeric character, and one upper or lower case letter.\"\n+      }\n+    }\n+  },\n+  \"variables\": {\n+    \"defaultStorageAccount\":{\n+      \"name\": \"[concat(parameters('clusterName'),'store')]\",","path":"101-hdinsight-hbase-linux-vnet/azuredeploy.json","position":40,"original_position":40,"commit_id":"62b9777028bbac623f86066f872c897fd2fe26a1","original_commit_id":"df95d6ba0a453c61f4bc5606e53499c59c18e54d","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars.githubusercontent.com/u/10090014?v=3","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"It's more about whether the name of the storageAccount is relevant in the sample - if it's just used as storage for the VHD then the name isn't really relevant.  That increases the likelihood of success for the deployment.  Also, the clusterName allows chars that are not allow in a storageAccount name, which is another opportunity for failure.  We want to give the best shot at being successful with these...\r\n","created_at":"2016-11-15T19:10:01Z","updated_at":"2016-11-15T19:10:01Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2747#discussion_r88089985","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/88089985"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2747#discussion_r88089985"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747","id":93229431,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2747","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/2747.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/2747.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2747","number":2747,"state":"open","locked":false,"title":"first draft","user":{"login":"mumian","id":2213767,"avatar_url":"https://avatars.githubusercontent.com/u/2213767?v=3","gravatar_id":"","url":"https://api.github.com/users/mumian","html_url":"https://github.com/mumian","followers_url":"https://api.github.com/users/mumian/followers","following_url":"https://api.github.com/users/mumian/following{/other_user}","gists_url":"https://api.github.com/users/mumian/gists{/gist_id}","starred_url":"https://api.github.com/users/mumian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumian/subscriptions","organizations_url":"https://api.github.com/users/mumian/orgs","repos_url":"https://api.github.com/users/mumian/repos","events_url":"https://api.github.com/users/mumian/events{/privacy}","received_events_url":"https://api.github.com/users/mumian/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n\r\n","created_at":"2016-11-10T20:58:43Z","updated_at":"2016-11-15T19:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef6f9f589405f253eb5eb61a98bc02966fbbc188","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2747/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/62b9777028bbac623f86066f872c897fd2fe26a1","head":{"label":"mumian:hbaseinvnet1110","ref":"hbaseinvnet1110","sha":"62b9777028bbac623f86066f872c897fd2fe26a1","user":{"login":"mumian","id":2213767,"avatar_url":"https://avatars.githubusercontent.com/u/2213767?v=3","gravatar_id":"","url":"https://api.github.com/users/mumian","html_url":"https://github.com/mumian","followers_url":"https://api.github.com/users/mumian/followers","following_url":"https://api.github.com/users/mumian/following{/other_user}","gists_url":"https://api.github.com/users/mumian/gists{/gist_id}","starred_url":"https://api.github.com/users/mumian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumian/subscriptions","organizations_url":"https://api.github.com/users/mumian/orgs","repos_url":"https://api.github.com/users/mumian/repos","events_url":"https://api.github.com/users/mumian/events{/privacy}","received_events_url":"https://api.github.com/users/mumian/received_events","type":"User","site_admin":false},"repo":{"id":68136710,"name":"azure-quickstart-templates","full_name":"mumian/azure-quickstart-templates","owner":{"login":"mumian","id":2213767,"avatar_url":"https://avatars.githubusercontent.com/u/2213767?v=3","gravatar_id":"","url":"https://api.github.com/users/mumian","html_url":"https://github.com/mumian","followers_url":"https://api.github.com/users/mumian/followers","following_url":"https://api.github.com/users/mumian/following{/other_user}","gists_url":"https://api.github.com/users/mumian/gists{/gist_id}","starred_url":"https://api.github.com/users/mumian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumian/subscriptions","organizations_url":"https://api.github.com/users/mumian/orgs","repos_url":"https://api.github.com/users/mumian/repos","events_url":"https://api.github.com/users/mumian/events{/privacy}","received_events_url":"https://api.github.com/users/mumian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mumian/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/mumian/azure-quickstart-templates","forks_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/mumian/azure-quickstart-templates/deployments","created_at":"2016-09-13T18:39:11Z","updated_at":"2016-09-13T18:39:17Z","pushed_at":"2016-11-15T17:21:50Z","git_url":"git://github.com/mumian/azure-quickstart-templates.git","ssh_url":"git@github.com:mumian/azure-quickstart-templates.git","clone_url":"https://github.com/mumian/azure-quickstart-templates.git","svn_url":"https://github.com/mumian/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":144599,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"2340d1eab3c40845e10ac56ea058aa29e2860bdc","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2016-11-15T17:59:21Z","pushed_at":"2016-11-15T17:21:51Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":185839,"stargazers_count":1582,"watchers_count":1582,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2239,"mirror_url":null,"open_issues_count":231,"forks":2239,"open_issues":231,"watchers":1582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2747"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2747"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2747/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2747/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/62b9777028bbac623f86066f872c897fd2fe26a1"}}}}
{"actor":{"display_login":"bmoore-msft"}}