{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/comments/56885182","id":56885182,"diff_hunk":"@@ -8,7 +8,7 @@\n  *\n  */\n \n-#import <ComponentSnapshotTestCase/CKComponentSnapshotTestCase.h>\n+#import <ComponentKit/CKComponentSnapshotTestCase.h>","path":"ComponentSnapshotTestCase/CKComponentSnapshotTestCase.mm","position":5,"original_position":5,"commit_id":"ac55a5b5c9cd2ff0a1d633e022c3bb7499da2d30","original_commit_id":"ac55a5b5c9cd2ff0a1d633e022c3bb7499da2d30","user":{"login":"adamjernst","id":97944,"avatar_url":"https://avatars.githubusercontent.com/u/97944?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjernst","html_url":"https://github.com/adamjernst","followers_url":"https://api.github.com/users/adamjernst/followers","following_url":"https://api.github.com/users/adamjernst/following{/other_user}","gists_url":"https://api.github.com/users/adamjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjernst/subscriptions","organizations_url":"https://api.github.com/users/adamjernst/orgs","repos_url":"https://api.github.com/users/adamjernst/repos","events_url":"https://api.github.com/users/adamjernst/events{/privacy}","received_events_url":"https://api.github.com/users/adamjernst/received_events","type":"User","site_admin":false},"body":"Hm, this won't work with our internal build process (which isn't cocoapods based).\r\n\r\nHow is it that `CKComponentSnapshotTestCase` lives in ComponentKit proper, as opposed to a separate sub-library? We specifically want to avoid linking it into production builds.\r\n\r\nCan you explain this a little more? I don't know a lot about Cocoapods.","created_at":"2016-03-21T19:51:40Z","updated_at":"2016-03-21T19:51:40Z","html_url":"https://github.com/facebook/componentkit/pull/506#discussion_r56885182","pull_request_url":"https://api.github.com/repos/facebook/componentkit/pulls/506","_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments/56885182"},"html":{"href":"https://github.com/facebook/componentkit/pull/506#discussion_r56885182"},"pull_request":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/506"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/506","id":63617236,"html_url":"https://github.com/facebook/componentkit/pull/506","diff_url":"https://github.com/facebook/componentkit/pull/506.diff","patch_url":"https://github.com/facebook/componentkit/pull/506.patch","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/506","number":506,"state":"open","locked":false,"title":"Use Subspec for static libs","user":{"login":"dbworku","id":2839631,"avatar_url":"https://avatars.githubusercontent.com/u/2839631?v=3","gravatar_id":"","url":"https://api.github.com/users/dbworku","html_url":"https://github.com/dbworku","followers_url":"https://api.github.com/users/dbworku/followers","following_url":"https://api.github.com/users/dbworku/following{/other_user}","gists_url":"https://api.github.com/users/dbworku/gists{/gist_id}","starred_url":"https://api.github.com/users/dbworku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbworku/subscriptions","organizations_url":"https://api.github.com/users/dbworku/orgs","repos_url":"https://api.github.com/users/dbworku/repos","events_url":"https://api.github.com/users/dbworku/events{/privacy}","received_events_url":"https://api.github.com/users/dbworku/received_events","type":"User","site_admin":false},"body":"#496 builds were failing. Repeated tested build script locally for this PR. The Travis build should succeed.\r\n\r\n- Migrate ComponentKitTestLib and ComponentSnapshotTestCase podspec to\r\nsubspecs on the ComponentKit.podspec.\r\n- Migrate ComponentKitTestHelpers static lib to subspec.\r\n- Migrate podspec to pod_target_xcconfig and os.deployment_target.\r\n(Support introduce 0.38.2)\r\n- Use Cocoapods v0.38.2 with Travis CI builds","created_at":"2016-03-21T19:16:55Z","updated_at":"2016-03-21T19:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa001d9ecfc1ae99fe1e25d19b9f23148df61996","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/componentkit/pulls/506/commits","review_comments_url":"https://api.github.com/repos/facebook/componentkit/pulls/506/comments","review_comment_url":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/506/comments","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/ac55a5b5c9cd2ff0a1d633e022c3bb7499da2d30","head":{"label":"dbworku:Subspec-Migration","ref":"Subspec-Migration","sha":"ac55a5b5c9cd2ff0a1d633e022c3bb7499da2d30","user":{"login":"dbworku","id":2839631,"avatar_url":"https://avatars.githubusercontent.com/u/2839631?v=3","gravatar_id":"","url":"https://api.github.com/users/dbworku","html_url":"https://github.com/dbworku","followers_url":"https://api.github.com/users/dbworku/followers","following_url":"https://api.github.com/users/dbworku/following{/other_user}","gists_url":"https://api.github.com/users/dbworku/gists{/gist_id}","starred_url":"https://api.github.com/users/dbworku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbworku/subscriptions","organizations_url":"https://api.github.com/users/dbworku/orgs","repos_url":"https://api.github.com/users/dbworku/repos","events_url":"https://api.github.com/users/dbworku/events{/privacy}","received_events_url":"https://api.github.com/users/dbworku/received_events","type":"User","site_admin":false},"repo":{"id":44873791,"name":"componentkit","full_name":"dbworku/componentkit","owner":{"login":"dbworku","id":2839631,"avatar_url":"https://avatars.githubusercontent.com/u/2839631?v=3","gravatar_id":"","url":"https://api.github.com/users/dbworku","html_url":"https://github.com/dbworku","followers_url":"https://api.github.com/users/dbworku/followers","following_url":"https://api.github.com/users/dbworku/following{/other_user}","gists_url":"https://api.github.com/users/dbworku/gists{/gist_id}","starred_url":"https://api.github.com/users/dbworku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbworku/subscriptions","organizations_url":"https://api.github.com/users/dbworku/orgs","repos_url":"https://api.github.com/users/dbworku/repos","events_url":"https://api.github.com/users/dbworku/events{/privacy}","received_events_url":"https://api.github.com/users/dbworku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbworku/componentkit","description":"A React-inspired view framework for iOS.","fork":true,"url":"https://api.github.com/repos/dbworku/componentkit","forks_url":"https://api.github.com/repos/dbworku/componentkit/forks","keys_url":"https://api.github.com/repos/dbworku/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbworku/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbworku/componentkit/teams","hooks_url":"https://api.github.com/repos/dbworku/componentkit/hooks","issue_events_url":"https://api.github.com/repos/dbworku/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/dbworku/componentkit/events","assignees_url":"https://api.github.com/repos/dbworku/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/dbworku/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/dbworku/componentkit/tags","blobs_url":"https://api.github.com/repos/dbworku/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbworku/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbworku/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbworku/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbworku/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dbworku/componentkit/languages","stargazers_url":"https://api.github.com/repos/dbworku/componentkit/stargazers","contributors_url":"https://api.github.com/repos/dbworku/componentkit/contributors","subscribers_url":"https://api.github.com/repos/dbworku/componentkit/subscribers","subscription_url":"https://api.github.com/repos/dbworku/componentkit/subscription","commits_url":"https://api.github.com/repos/dbworku/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbworku/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbworku/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbworku/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbworku/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/dbworku/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbworku/componentkit/merges","archive_url":"https://api.github.com/repos/dbworku/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbworku/componentkit/downloads","issues_url":"https://api.github.com/repos/dbworku/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/dbworku/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dbworku/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dbworku/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbworku/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/dbworku/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/dbworku/componentkit/deployments","created_at":"2015-10-24T16:10:32Z","updated_at":"2016-02-16T15:48:30Z","pushed_at":"2016-03-21T19:15:00Z","git_url":"git://github.com/dbworku/componentkit.git","ssh_url":"git@github.com:dbworku/componentkit.git","clone_url":"https://github.com/dbworku/componentkit.git","svn_url":"https://github.com/dbworku/componentkit","homepage":"http://www.componentkit.org/","size":8078,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9670646b2c887cd000f8fcb44f8d90cb341b2450","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":32600951,"name":"componentkit","full_name":"facebook/componentkit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/componentkit","description":"A React-inspired view framework for iOS.","fork":false,"url":"https://api.github.com/repos/facebook/componentkit","forks_url":"https://api.github.com/repos/facebook/componentkit/forks","keys_url":"https://api.github.com/repos/facebook/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/componentkit/teams","hooks_url":"https://api.github.com/repos/facebook/componentkit/hooks","issue_events_url":"https://api.github.com/repos/facebook/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/componentkit/events","assignees_url":"https://api.github.com/repos/facebook/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/componentkit/tags","blobs_url":"https://api.github.com/repos/facebook/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/componentkit/languages","stargazers_url":"https://api.github.com/repos/facebook/componentkit/stargazers","contributors_url":"https://api.github.com/repos/facebook/componentkit/contributors","subscribers_url":"https://api.github.com/repos/facebook/componentkit/subscribers","subscription_url":"https://api.github.com/repos/facebook/componentkit/subscription","commits_url":"https://api.github.com/repos/facebook/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/componentkit/merges","archive_url":"https://api.github.com/repos/facebook/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/componentkit/downloads","issues_url":"https://api.github.com/repos/facebook/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/componentkit/deployments","created_at":"2015-03-20T18:42:47Z","updated_at":"2016-03-21T08:59:56Z","pushed_at":"2016-03-21T19:16:55Z","git_url":"git://github.com/facebook/componentkit.git","ssh_url":"git@github.com:facebook/componentkit.git","clone_url":"https://github.com/facebook/componentkit.git","svn_url":"https://github.com/facebook/componentkit","homepage":"http://www.componentkit.org/","size":8716,"stargazers_count":2879,"watchers_count":2879,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":285,"mirror_url":null,"open_issues_count":44,"forks":285,"open_issues":44,"watchers":2879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/506"},"html":{"href":"https://github.com/facebook/componentkit/pull/506"},"issue":{"href":"https://api.github.com/repos/facebook/componentkit/issues/506"},"comments":{"href":"https://api.github.com/repos/facebook/componentkit/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/componentkit/statuses/ac55a5b5c9cd2ff0a1d633e022c3bb7499da2d30"}}}}