{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/80304689","id":80304689,"diff_hunk":"@@ -50,12 +61,12 @@ public IEnumerable<ProjectDependency> ResolveProjectDependencies(ProjectContext\n \n         private Dictionary<string, ProjectDependency> FindPossibleProjectDependencies(string projectJsonFilePath)\n         {\n-            var projectDirectory = Path.GetDirectoryName(projectJsonFilePath);\n+            var projectRootDirectory = GetRootFromProjectJson(projectJsonFilePath);\n \n             var projectSearchPaths = new List<string>();\n-            projectSearchPaths.Add(projectDirectory);","path":"src/Microsoft.DotNet.ProjectJsonMigration/ProjectDependencyFinder.cs","position":26,"original_position":26,"commit_id":"cde5c658a18c1f459e2af04d4a860a062ac73502","original_commit_id":"cde5c658a18c1f459e2af04d4a860a062ac73502","user":{"login":"Sridhar-MS","id":9423246,"avatar_url":"https://avatars.githubusercontent.com/u/9423246?v=3","gravatar_id":"","url":"https://api.github.com/users/Sridhar-MS","html_url":"https://github.com/Sridhar-MS","followers_url":"https://api.github.com/users/Sridhar-MS/followers","following_url":"https://api.github.com/users/Sridhar-MS/following{/other_user}","gists_url":"https://api.github.com/users/Sridhar-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/Sridhar-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sridhar-MS/subscriptions","organizations_url":"https://api.github.com/users/Sridhar-MS/orgs","repos_url":"https://api.github.com/users/Sridhar-MS/repos","events_url":"https://api.github.com/users/Sridhar-MS/events{/privacy}","received_events_url":"https://api.github.com/users/Sridhar-MS/received_events","type":"User","site_admin":false},"body":"So @brthor there is no need to add the current directory of the project to search paths?","created_at":"2016-09-23T18:50:28Z","updated_at":"2016-09-23T18:50:28Z","html_url":"https://github.com/dotnet/cli/pull/4221#discussion_r80304689","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/4221","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/80304689"},"html":{"href":"https://github.com/dotnet/cli/pull/4221#discussion_r80304689"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4221"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/4221","id":86266487,"html_url":"https://github.com/dotnet/cli/pull/4221","diff_url":"https://github.com/dotnet/cli/pull/4221.diff","patch_url":"https://github.com/dotnet/cli/pull/4221.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/4221","number":4221,"state":"open","locked":false,"title":"Migrate P2P references","user":{"login":"Sridhar-MS","id":9423246,"avatar_url":"https://avatars.githubusercontent.com/u/9423246?v=3","gravatar_id":"","url":"https://api.github.com/users/Sridhar-MS","html_url":"https://github.com/Sridhar-MS","followers_url":"https://api.github.com/users/Sridhar-MS/followers","following_url":"https://api.github.com/users/Sridhar-MS/following{/other_user}","gists_url":"https://api.github.com/users/Sridhar-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/Sridhar-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sridhar-MS/subscriptions","organizations_url":"https://api.github.com/users/Sridhar-MS/orgs","repos_url":"https://api.github.com/users/Sridhar-MS/repos","events_url":"https://api.github.com/users/Sridhar-MS/events{/privacy}","received_events_url":"https://api.github.com/users/Sridhar-MS/received_events","type":"User","site_admin":false},"body":"Fixes item 2 and 5 in https://github.com/dotnet/cli/issues/4167\r\n\r\n- Given a project migrate all the project references recursively.\r\n- Add a boolean option '--skip-project-references' to skip migrating P2P references. By default P2P references are migrated.\r\n- Remove the '--output' since it is not used heavily and makes migrating multiple projects easier.\r\n- Add tests\r\n\r\ncc @brthor @eerhardt @livarcocc ","created_at":"2016-09-22T01:04:16Z","updated_at":"2016-09-23T18:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef04dcc6a8991c3371e9b2ae297bf46bf6fabd87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/4221/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/4221/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/4221/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/cde5c658a18c1f459e2af04d4a860a062ac73502","head":{"label":"dotnet:sridhar-ms/multiple-proj-migrate","ref":"sridhar-ms/multiple-proj-migrate","sha":"cde5c658a18c1f459e2af04d4a860a062ac73502","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-09-22T21:01:20Z","pushed_at":"2016-09-23T18:48:02Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":120220,"stargazers_count":1440,"watchers_count":1440,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":739,"forks":367,"open_issues":739,"watchers":1440,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"a04194c0f76f99a9bb3508bebfd9744f7375350d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-09-22T21:01:20Z","pushed_at":"2016-09-23T18:48:02Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":120220,"stargazers_count":1440,"watchers_count":1440,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":739,"forks":367,"open_issues":739,"watchers":1440,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4221"},"html":{"href":"https://github.com/dotnet/cli/pull/4221"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/4221"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/4221/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4221/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4221/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/cde5c658a18c1f459e2af04d4a860a062ac73502"}}}}
{"actor":{"display_login":"Sridhar-MS"}}