{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/comments/63757121","id":63757121,"diff_hunk":"@@ -20,4 +29,29 @@ public void hasFailuresDescriptionReflectsInput(int i) {\n         assertThat(ResultMatchers.failureCountIs(i).toString(),\n                 containsString(\"\" + i));\n     }\n+\n+    @Test\n+    public void testFailureCountIsTakingMatcher_givenResultWithOneFailure() {\n+        PrintableResult resultWithOneFailure = new PrintableResult(Collections.singletonList(\n+                new Failure(Description.createTestDescription(\"class\", \"name\"), new RuntimeException(\"failure 1\"))));\n+\n+        assertThat(ResultMatchers.failureCountIs(equalTo(3)).matches(resultWithOneFailure), is(false));\n+        assertThat(ResultMatchers.failureCountIs(equalTo(1)).matches(resultWithOneFailure), is(true));\n+    }\n+\n+    @Test\n+    public void failureCountIsTakingMatcherShouldHaveGoodDescription() {\n+        Matcher<Integer> matcherTestStub = new BaseMatcher<Integer>() {","path":"src/test/java/org/junit/tests/experimental/results/ResultMatchersTest.java","position":40,"original_position":40,"commit_id":"054b73c61f9fb82d1d97dc717adddd9f67861e0b","original_commit_id":"054b73c61f9fb82d1d97dc717adddd9f67861e0b","user":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"body":"What's wrong?\r\nCompilation looks fine to me:\r\nhttps://travis-ci.org/junit-team/junit4/builds/131156153\r\n","created_at":"2016-05-18T18:32:11Z","updated_at":"2016-05-18T18:32:11Z","html_url":"https://github.com/junit-team/junit4/pull/1302#discussion_r63757121","pull_request_url":"https://api.github.com/repos/junit-team/junit4/pulls/1302","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments/63757121"},"html":{"href":"https://github.com/junit-team/junit4/pull/1302#discussion_r63757121"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1302"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/1302","id":70541224,"html_url":"https://github.com/junit-team/junit4/pull/1302","diff_url":"https://github.com/junit-team/junit4/pull/1302.diff","patch_url":"https://github.com/junit-team/junit4/pull/1302.patch","issue_url":"https://api.github.com/repos/junit-team/junit4/issues/1302","number":1302,"state":"open","locked":false,"title":"Overload ResultMatchers.failureCountIs: take a Matcher of integer","user":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"body":"This allows clients to assert that the failure count is greaterThan, lessThan, etc.","created_at":"2016-05-18T14:46:41Z","updated_at":"2016-05-18T18:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"432efa76757e0ff8c041d04394cf494a9c68bf94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit4/pulls/1302/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit4/pulls/1302/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit4/issues/1302/comments","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/054b73c61f9fb82d1d97dc717adddd9f67861e0b","head":{"label":"alb-i986:overload-ResultMatchers-failureCountIs","ref":"overload-ResultMatchers-failureCountIs","sha":"054b73c61f9fb82d1d97dc717adddd9f67861e0b","user":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"repo":{"id":25947132,"name":"junit","full_name":"alb-i986/junit","owner":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alb-i986/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/alb-i986/junit","forks_url":"https://api.github.com/repos/alb-i986/junit/forks","keys_url":"https://api.github.com/repos/alb-i986/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alb-i986/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alb-i986/junit/teams","hooks_url":"https://api.github.com/repos/alb-i986/junit/hooks","issue_events_url":"https://api.github.com/repos/alb-i986/junit/issues/events{/number}","events_url":"https://api.github.com/repos/alb-i986/junit/events","assignees_url":"https://api.github.com/repos/alb-i986/junit/assignees{/user}","branches_url":"https://api.github.com/repos/alb-i986/junit/branches{/branch}","tags_url":"https://api.github.com/repos/alb-i986/junit/tags","blobs_url":"https://api.github.com/repos/alb-i986/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alb-i986/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alb-i986/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alb-i986/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alb-i986/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/alb-i986/junit/languages","stargazers_url":"https://api.github.com/repos/alb-i986/junit/stargazers","contributors_url":"https://api.github.com/repos/alb-i986/junit/contributors","subscribers_url":"https://api.github.com/repos/alb-i986/junit/subscribers","subscription_url":"https://api.github.com/repos/alb-i986/junit/subscription","commits_url":"https://api.github.com/repos/alb-i986/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alb-i986/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alb-i986/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alb-i986/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alb-i986/junit/contents/{+path}","compare_url":"https://api.github.com/repos/alb-i986/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alb-i986/junit/merges","archive_url":"https://api.github.com/repos/alb-i986/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alb-i986/junit/downloads","issues_url":"https://api.github.com/repos/alb-i986/junit/issues{/number}","pulls_url":"https://api.github.com/repos/alb-i986/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/alb-i986/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/alb-i986/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alb-i986/junit/labels{/name}","releases_url":"https://api.github.com/repos/alb-i986/junit/releases{/id}","deployments_url":"https://api.github.com/repos/alb-i986/junit/deployments","created_at":"2014-10-30T00:07:33Z","updated_at":"2016-02-10T13:08:04Z","pushed_at":"2016-05-18T16:31:14Z","git_url":"git://github.com/alb-i986/junit.git","ssh_url":"git@github.com:alb-i986/junit.git","clone_url":"https://github.com/alb-i986/junit.git","svn_url":"https://github.com/alb-i986/junit","homepage":"","size":11717,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"2bf3509dfe58fcf768a5f3b624284df8cdb61e5c","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit4","full_name":"junit-team/junit4","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit4","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit4","forks_url":"https://api.github.com/repos/junit-team/junit4/forks","keys_url":"https://api.github.com/repos/junit-team/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit4/teams","hooks_url":"https://api.github.com/repos/junit-team/junit4/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit4/events","assignees_url":"https://api.github.com/repos/junit-team/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit4/tags","blobs_url":"https://api.github.com/repos/junit-team/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit4/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit4/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit4/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit4/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit4/subscription","commits_url":"https://api.github.com/repos/junit-team/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit4/merges","archive_url":"https://api.github.com/repos/junit-team/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit4/downloads","issues_url":"https://api.github.com/repos/junit-team/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit4/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit4/deployments","created_at":"2009-01-13T03:41:26Z","updated_at":"2016-05-18T05:19:09Z","pushed_at":"2016-05-18T14:46:41Z","git_url":"git://github.com/junit-team/junit4.git","ssh_url":"git@github.com:junit-team/junit4.git","clone_url":"https://github.com/junit-team/junit4.git","svn_url":"https://github.com/junit-team/junit4","homepage":"http://junit.org/junit4/","size":36677,"stargazers_count":4859,"watchers_count":4859,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1909,"mirror_url":null,"open_issues_count":175,"forks":1909,"open_issues":175,"watchers":4859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1302"},"html":{"href":"https://github.com/junit-team/junit4/pull/1302"},"issue":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1302"},"comments":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1302/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1302/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1302/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit4/statuses/054b73c61f9fb82d1d97dc717adddd9f67861e0b"}}}}