{"action":"created","issue":{"url":"https://api.github.com/repos/Scille/umongo/issues/75","repository_url":"https://api.github.com/repos/Scille/umongo","labels_url":"https://api.github.com/repos/Scille/umongo/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/Scille/umongo/issues/75/comments","events_url":"https://api.github.com/repos/Scille/umongo/issues/75/events","html_url":"https://github.com/Scille/umongo/pull/75","id":192979100,"number":75,"title":"Fix StrictDateTime issue when using aware datetime as input","user":{"login":"lafrech","id":1767010,"avatar_url":"https://avatars.githubusercontent.com/u/1767010?v=3","gravatar_id":"","url":"https://api.github.com/users/lafrech","html_url":"https://github.com/lafrech","followers_url":"https://api.github.com/users/lafrech/followers","following_url":"https://api.github.com/users/lafrech/following{/other_user}","gists_url":"https://api.github.com/users/lafrech/gists{/gist_id}","starred_url":"https://api.github.com/users/lafrech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafrech/subscriptions","organizations_url":"https://api.github.com/users/lafrech/orgs","repos_url":"https://api.github.com/users/lafrech/repos","events_url":"https://api.github.com/users/lafrech/events{/privacy}","received_events_url":"https://api.github.com/users/lafrech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T22:21:33Z","updated_at":"2016-12-01T22:24:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Scille/umongo/pulls/75","html_url":"https://github.com/Scille/umongo/pull/75","diff_url":"https://github.com/Scille/umongo/pull/75.diff","patch_url":"https://github.com/Scille/umongo/pull/75.patch"},"body":"There was an issue in `StrictDateTime`. I wrote\r\n\r\n```py\r\n    date.astimezone(tzutc())\r\n```\r\n\r\nwhich does nothing because astimezone does not modify `date` (a datetime is immutable anyway).\r\n\r\nI changed it into\r\n\r\n```py\r\n    date = date.astimezone(tzutc())\r\n```\r\n\r\nThis commit also adds corresponding tests.\r\n\r\nNote that I manage the case where we get datetimes from Mongo that are aware and not UTC. This is currently not possible with PyMongo and I doubt it will change anytime soon. I didn't check the other drivers and I guess it is the same there, so we could safely remove those two lines: https://github.com/Nobatek/umongo/blob/fix_strictdatetime_issue/umongo/fields.py#L227-L228."},"comment":{"url":"https://api.github.com/repos/Scille/umongo/issues/comments/264314616","html_url":"https://github.com/Scille/umongo/pull/75#issuecomment-264314616","issue_url":"https://api.github.com/repos/Scille/umongo/issues/75","id":264314616,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T22:24:49Z","updated_at":"2016-12-01T22:24:49Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9090896/badge)](https://coveralls.io/builds/9090896)\n\nCoverage remained the same at 95.599% when pulling **39938fda6937a6340d21e494d682e3d931322935 on Nobatek:fix_strictdatetime_issue** into **3ff679647de67c25f0d2a18ce1d42abeb1d91be8 on Scille:master**.\n"}}
{"actor":{"display_login":"coveralls"}}