{"action":"closed","number":18327,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/18327","id":92108912,"html_url":"https://github.com/ansible/ansible/pull/18327","diff_url":"https://github.com/ansible/ansible/pull/18327.diff","patch_url":"https://github.com/ansible/ansible/pull/18327.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/18327","number":18327,"state":"closed","locked":false,"title":"Exclude floppy disks from lsblk call for uuids","user":{"login":"robinro","id":107032,"avatar_url":"https://avatars.githubusercontent.com/u/107032?v=3","gravatar_id":"","url":"https://api.github.com/users/robinro","html_url":"https://github.com/robinro","followers_url":"https://api.github.com/users/robinro/followers","following_url":"https://api.github.com/users/robinro/following{/other_user}","gists_url":"https://api.github.com/users/robinro/gists{/gist_id}","starred_url":"https://api.github.com/users/robinro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinro/subscriptions","organizations_url":"https://api.github.com/users/robinro/orgs","repos_url":"https://api.github.com/users/robinro/repos","events_url":"https://api.github.com/users/robinro/events{/privacy}","received_events_url":"https://api.github.com/users/robinro/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nsetup\r\n lib/ansible/module_utils/facts.py \r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.2.0.0\r\n```\r\n\r\n##### SUMMARY\r\nFixes #18326\r\n\r\nSince #17036 `lsblk` first collects uuids from all devices and then connects those to the active mounts. This also includes floppy drives, which are a lot slower to answer than HDD/SSD/network.\r\n\r\nThis patch adds the option `--exclude 2`, that excludes floppy drives from the lsblk command.\r\n\r\nConsequences:\r\n1. runtime of lsblk goes from 12 seconds to 0.1 seconds in our use case\r\n2. floppy mounts are listed with `uuid: N/A`\r\n\r\nDoes anyone care for the uuid of floppy discs? If not I would favor 1. over 2. and ask you to merge this in also in 2.2 stable.","created_at":"2016-11-03T08:06:32Z","updated_at":"2016-11-03T17:52:07Z","closed_at":"2016-11-03T17:52:07Z","merged_at":"2016-11-03T17:52:07Z","merge_commit_sha":"6ca6a9a2919d03bd5935472d4f0c3e3ab5b3c28b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/18327/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/18327/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/18327/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/75c018338a64ff1f89d012129a658f218010bd6c","head":{"label":"robinro:exclude-floppy-lsblk","ref":"exclude-floppy-lsblk","sha":"75c018338a64ff1f89d012129a658f218010bd6c","user":{"login":"robinro","id":107032,"avatar_url":"https://avatars.githubusercontent.com/u/107032?v=3","gravatar_id":"","url":"https://api.github.com/users/robinro","html_url":"https://github.com/robinro","followers_url":"https://api.github.com/users/robinro/followers","following_url":"https://api.github.com/users/robinro/following{/other_user}","gists_url":"https://api.github.com/users/robinro/gists{/gist_id}","starred_url":"https://api.github.com/users/robinro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinro/subscriptions","organizations_url":"https://api.github.com/users/robinro/orgs","repos_url":"https://api.github.com/users/robinro/repos","events_url":"https://api.github.com/users/robinro/events{/privacy}","received_events_url":"https://api.github.com/users/robinro/received_events","type":"User","site_admin":false},"repo":{"id":22343096,"name":"ansible","full_name":"robinro/ansible","owner":{"login":"robinro","id":107032,"avatar_url":"https://avatars.githubusercontent.com/u/107032?v=3","gravatar_id":"","url":"https://api.github.com/users/robinro","html_url":"https://github.com/robinro","followers_url":"https://api.github.com/users/robinro/followers","following_url":"https://api.github.com/users/robinro/following{/other_user}","gists_url":"https://api.github.com/users/robinro/gists{/gist_id}","starred_url":"https://api.github.com/users/robinro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinro/subscriptions","organizations_url":"https://api.github.com/users/robinro/orgs","repos_url":"https://api.github.com/users/robinro/repos","events_url":"https://api.github.com/users/robinro/events{/privacy}","received_events_url":"https://api.github.com/users/robinro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robinro/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/robinro/ansible","forks_url":"https://api.github.com/repos/robinro/ansible/forks","keys_url":"https://api.github.com/repos/robinro/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robinro/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robinro/ansible/teams","hooks_url":"https://api.github.com/repos/robinro/ansible/hooks","issue_events_url":"https://api.github.com/repos/robinro/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/robinro/ansible/events","assignees_url":"https://api.github.com/repos/robinro/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/robinro/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/robinro/ansible/tags","blobs_url":"https://api.github.com/repos/robinro/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robinro/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robinro/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/robinro/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robinro/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/robinro/ansible/languages","stargazers_url":"https://api.github.com/repos/robinro/ansible/stargazers","contributors_url":"https://api.github.com/repos/robinro/ansible/contributors","subscribers_url":"https://api.github.com/repos/robinro/ansible/subscribers","subscription_url":"https://api.github.com/repos/robinro/ansible/subscription","commits_url":"https://api.github.com/repos/robinro/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/robinro/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/robinro/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/robinro/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/robinro/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/robinro/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robinro/ansible/merges","archive_url":"https://api.github.com/repos/robinro/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robinro/ansible/downloads","issues_url":"https://api.github.com/repos/robinro/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/robinro/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/robinro/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/robinro/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robinro/ansible/labels{/name}","releases_url":"https://api.github.com/repos/robinro/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/robinro/ansible/deployments","created_at":"2014-07-28T13:18:15Z","updated_at":"2016-02-01T14:35:50Z","pushed_at":"2016-11-03T07:55:15Z","git_url":"git://github.com/robinro/ansible.git","ssh_url":"git@github.com:robinro/ansible.git","clone_url":"https://github.com/robinro/ansible.git","svn_url":"https://github.com/robinro/ansible","homepage":"http://ansible.com/","size":37036,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"368a837481f0e6af13fb64476d3f928147589704","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2016-11-03T17:26:04Z","pushed_at":"2016-11-03T17:52:07Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":76077,"stargazers_count":19585,"watchers_count":19585,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5967,"mirror_url":null,"open_issues_count":1602,"forks":5967,"open_issues":1602,"watchers":19585,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/18327"},"html":{"href":"https://github.com/ansible/ansible/pull/18327"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/18327"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/18327/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/18327/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/18327/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/75c018338a64ff1f89d012129a658f218010bd6c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"abadger"}}