{"action":"created","issue":{"url":"https://api.github.com/repos/intelsdi-x/snap/issues/803","repository_url":"https://api.github.com/repos/intelsdi-x/snap","labels_url":"https://api.github.com/repos/intelsdi-x/snap/issues/803/labels{/name}","comments_url":"https://api.github.com/repos/intelsdi-x/snap/issues/803/comments","events_url":"https://api.github.com/repos/intelsdi-x/snap/issues/803/events","html_url":"https://github.com/intelsdi-x/snap/pull/803","id":143264627,"number":803,"title":"First implementation of dynamic query support","user":{"login":"IzabellaRaulin","id":11335874,"avatar_url":"https://avatars.githubusercontent.com/u/11335874?v=3","gravatar_id":"","url":"https://api.github.com/users/IzabellaRaulin","html_url":"https://github.com/IzabellaRaulin","followers_url":"https://api.github.com/users/IzabellaRaulin/followers","following_url":"https://api.github.com/users/IzabellaRaulin/following{/other_user}","gists_url":"https://api.github.com/users/IzabellaRaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/IzabellaRaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IzabellaRaulin/subscriptions","organizations_url":"https://api.github.com/users/IzabellaRaulin/orgs","repos_url":"https://api.github.com/users/IzabellaRaulin/repos","events_url":"https://api.github.com/users/IzabellaRaulin/events{/privacy}","received_events_url":"https://api.github.com/users/IzabellaRaulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-24T14:39:28Z","updated_at":"2016-03-30T14:58:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap/pulls/803","html_url":"https://github.com/intelsdi-x/snap/pull/803","diff_url":"https://github.com/intelsdi-x/snap/pull/803.diff","patch_url":"https://github.com/intelsdi-x/snap/pull/803.patch"},"body":"Related to #676 \r\n\r\nSummary of changes:\r\n- adding dynamic query support (wildcard and tuple)\r\n- adding validation of metric's namespace:\r\n - (part 1) not allowed characters, especially that ones which can be invalid interpreted as regexp tokens\r\n - (part 2) a wildcard in the end of namespace - that has NOT been implemented yet. It will be added in another pull request, after revising of all existing collector plugins and refactoring that ones which have such like metrics. \r\n   Why: Already even plugin has metrics which ends with a wildcard, it works properly and can be used by snap users\r\n\r\nTesting done:\r\n-  checking a query support for plugin with no-dynamic metrics \r\n-  checking a query support for plugin with dynamic metrics (if plugin accepts wildcards in this location the framework does not attempt to evaluate that)\r\n\r\n@intelsdi-x/snap-maintainers\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/intelsdi-x/snap/issues/comments/203475390","html_url":"https://github.com/intelsdi-x/snap/pull/803#issuecomment-203475390","issue_url":"https://api.github.com/repos/intelsdi-x/snap/issues/803","id":203475390,"user":{"login":"IzabellaRaulin","id":11335874,"avatar_url":"https://avatars.githubusercontent.com/u/11335874?v=3","gravatar_id":"","url":"https://api.github.com/users/IzabellaRaulin","html_url":"https://github.com/IzabellaRaulin","followers_url":"https://api.github.com/users/IzabellaRaulin/followers","following_url":"https://api.github.com/users/IzabellaRaulin/following{/other_user}","gists_url":"https://api.github.com/users/IzabellaRaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/IzabellaRaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IzabellaRaulin/subscriptions","organizations_url":"https://api.github.com/users/IzabellaRaulin/orgs","repos_url":"https://api.github.com/users/IzabellaRaulin/repos","events_url":"https://api.github.com/users/IzabellaRaulin/events{/privacy}","received_events_url":"https://api.github.com/users/IzabellaRaulin/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T14:58:36Z","updated_at":"2016-03-30T14:58:36Z","body":"@candysmurf - already there is only that: [docs/TASKS.md](https://github.com/IzabellaRaulin/snap/blob/dynamic_query_support/docs/TASKS.md#collect)\r\n\r\nBut did you mean a doc for this pull request or generally more detailed section in snap/doc?"}}