{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/70798405","id":70798405,"diff_hunk":"@@ -384,5 +387,34 @@ public static WeightedParameter getFieldConfig(ConfigKey<?> config, Field config\n         }\n     }\n \n+    /**\n+     * Adds the given list of {@link SpecParameter parameters} to the provided\n+     * {@link AbstractBrooklynObjectSpec spec}. Inherits parent parameters except\n+     * where there is an existing {@link ConfigKey config key}.\n+     * <p>\n+     * Implemented by explicitly replacing the existing parameters with an\n+     * updated list.\n+     *\n+     * @see EntitySpec#parameters(List)\n+     */\n+    public static void addParameters(AbstractBrooklynObjectSpec<?, ?> spec, List<? extends SpecParameter<?>> explicitParams, BrooklynClassLoadingContext loader) {\n+        if (explicitParams.size() > 0) {","path":"core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java","position":58,"original_position":58,"commit_id":"5378fbce2c3bdb8270b9993e6d3d8e5e0e7c13f3","original_commit_id":"5378fbce2c3bdb8270b9993e6d3d8e5e0e7c13f3","user":{"login":"neykov","id":3612111,"avatar_url":"https://avatars.githubusercontent.com/u/3612111?v=3","gravatar_id":"","url":"https://api.github.com/users/neykov","html_url":"https://github.com/neykov","followers_url":"https://api.github.com/users/neykov/followers","following_url":"https://api.github.com/users/neykov/following{/other_user}","gists_url":"https://api.github.com/users/neykov/gists{/gist_id}","starred_url":"https://api.github.com/users/neykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neykov/subscriptions","organizations_url":"https://api.github.com/users/neykov/orgs","repos_url":"https://api.github.com/users/neykov/repos","events_url":"https://api.github.com/users/neykov/events{/privacy}","received_events_url":"https://api.github.com/users/neykov/received_events","type":"User","site_admin":false},"body":"Shouldn't be one or the other, but both instead. First add from spec (if no spec parameters), then merge with explicit parameters.\r\n","created_at":"2016-07-14T12:47:28Z","updated_at":"2016-07-14T12:47:28Z","html_url":"https://github.com/apache/brooklyn-server/pull/229#discussion_r70798405","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/70798405"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/229#discussion_r70798405"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/229","id":76081619,"html_url":"https://github.com/apache/brooklyn-server/pull/229","diff_url":"https://github.com/apache/brooklyn-server/pull/229.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/229.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/229","number":229,"state":"open","locked":false,"title":"Merge brooklyn.parameters in YAML files","user":{"login":"grkvlt","id":214870,"avatar_url":"https://avatars.githubusercontent.com/u/214870?v=3","gravatar_id":"","url":"https://api.github.com/users/grkvlt","html_url":"https://github.com/grkvlt","followers_url":"https://api.github.com/users/grkvlt/followers","following_url":"https://api.github.com/users/grkvlt/following{/other_user}","gists_url":"https://api.github.com/users/grkvlt/gists{/gist_id}","starred_url":"https://api.github.com/users/grkvlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grkvlt/subscriptions","organizations_url":"https://api.github.com/users/grkvlt/orgs","repos_url":"https://api.github.com/users/grkvlt/repos","events_url":"https://api.github.com/users/grkvlt/events{/privacy}","received_events_url":"https://api.github.com/users/grkvlt/received_events","type":"User","site_admin":false},"body":"Implements behaviour required to merge `brooklyn.parameters` sections of specifications in YAML files, allowing addition of new parameters to entities without having to specify the complete list again.","created_at":"2016-07-03T05:50:28Z","updated_at":"2016-07-14T12:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e95531e4219d9cbaade677d60026b66c0c29bf69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/229/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/229/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/229/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/5378fbce2c3bdb8270b9993e6d3d8e5e0e7c13f3","head":{"label":"grkvlt:merge-brooklyn-parameters","ref":"merge-brooklyn-parameters","sha":"5378fbce2c3bdb8270b9993e6d3d8e5e0e7c13f3","user":{"login":"grkvlt","id":214870,"avatar_url":"https://avatars.githubusercontent.com/u/214870?v=3","gravatar_id":"","url":"https://api.github.com/users/grkvlt","html_url":"https://github.com/grkvlt","followers_url":"https://api.github.com/users/grkvlt/followers","following_url":"https://api.github.com/users/grkvlt/following{/other_user}","gists_url":"https://api.github.com/users/grkvlt/gists{/gist_id}","starred_url":"https://api.github.com/users/grkvlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grkvlt/subscriptions","organizations_url":"https://api.github.com/users/grkvlt/orgs","repos_url":"https://api.github.com/users/grkvlt/repos","events_url":"https://api.github.com/users/grkvlt/events{/privacy}","received_events_url":"https://api.github.com/users/grkvlt/received_events","type":"User","site_admin":false},"repo":{"id":50933566,"name":"brooklyn-server","full_name":"grkvlt/brooklyn-server","owner":{"login":"grkvlt","id":214870,"avatar_url":"https://avatars.githubusercontent.com/u/214870?v=3","gravatar_id":"","url":"https://api.github.com/users/grkvlt","html_url":"https://github.com/grkvlt","followers_url":"https://api.github.com/users/grkvlt/followers","following_url":"https://api.github.com/users/grkvlt/following{/other_user}","gists_url":"https://api.github.com/users/grkvlt/gists{/gist_id}","starred_url":"https://api.github.com/users/grkvlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grkvlt/subscriptions","organizations_url":"https://api.github.com/users/grkvlt/orgs","repos_url":"https://api.github.com/users/grkvlt/repos","events_url":"https://api.github.com/users/grkvlt/events{/privacy}","received_events_url":"https://api.github.com/users/grkvlt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grkvlt/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/grkvlt/brooklyn-server","forks_url":"https://api.github.com/repos/grkvlt/brooklyn-server/forks","keys_url":"https://api.github.com/repos/grkvlt/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grkvlt/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grkvlt/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/grkvlt/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/grkvlt/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/grkvlt/brooklyn-server/events","assignees_url":"https://api.github.com/repos/grkvlt/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/grkvlt/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/grkvlt/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/grkvlt/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grkvlt/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grkvlt/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/grkvlt/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grkvlt/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/grkvlt/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/grkvlt/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/grkvlt/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/grkvlt/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/grkvlt/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/grkvlt/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/grkvlt/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/grkvlt/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/grkvlt/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/grkvlt/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/grkvlt/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grkvlt/brooklyn-server/merges","archive_url":"https://api.github.com/repos/grkvlt/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grkvlt/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/grkvlt/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/grkvlt/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/grkvlt/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/grkvlt/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grkvlt/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/grkvlt/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/grkvlt/brooklyn-server/deployments","created_at":"2016-02-02T16:17:45Z","updated_at":"2016-02-02T16:17:53Z","pushed_at":"2016-07-13T20:55:23Z","git_url":"git://github.com/grkvlt/brooklyn-server.git","ssh_url":"git@github.com:grkvlt/brooklyn-server.git","clone_url":"https://github.com/grkvlt/brooklyn-server.git","svn_url":"https://github.com/grkvlt/brooklyn-server","homepage":null,"size":30435,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a58ba05c7b7e621b22a6fa83410b4cea8f1a7f7e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-05-30T11:46:29Z","pushed_at":"2016-07-13T20:56:23Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":30649,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":15,"forks":35,"open_issues":15,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/229"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/229"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/229"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/5378fbce2c3bdb8270b9993e6d3d8e5e0e7c13f3"}}}}
{"actor":{"display_login":"neykov"}}