{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/71818179","id":71818179,"diff_hunk":"@@ -28,84 +28,21 @@ class CustomAttributeParser {\n         LIMITED_METHOD_CONTRACT;\n     }\n \n-private:\n-    signed __int8    GetI1()\n-    {\n-        LIMITED_METHOD_CONTRACT;\n-        signed __int8 tmp = *reinterpret_cast<const signed __int8*>(m_pbCur);\n-        m_pbCur += sizeof(signed __int8);\n-        return tmp;\n-    }\n-    unsigned __int8  GetU1()\n-    {\n-        LIMITED_METHOD_CONTRACT;\n-        unsigned __int8 tmp = *reinterpret_cast<const unsigned __int8*>(m_pbCur);\n-        m_pbCur += sizeof(unsigned __int8);\n-        return tmp;\n-    }\n-\n-    signed __int16   GetI2()\n-    {\n-        LIMITED_METHOD_CONTRACT;\n-        signed __int16 tmp = GET_UNALIGNED_VAL16(m_pbCur);","path":"src/inc/caparser.h","position":23,"original_position":23,"commit_id":"02cf3690d0212906f31fce07c6eca112403daa2f","original_commit_id":"02cf3690d0212906f31fce07c6eca112403daa2f","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"Thanks for your comment. The main issue may be the code at line 35 (which directly access each byte). It seems that GET_UNALIGNED_VAL8 is missing currently. Is it intended?","created_at":"2016-07-22T02:14:23Z","updated_at":"2016-07-22T02:14:23Z","html_url":"https://github.com/dotnet/coreclr/pull/6403#discussion_r71818179","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6403","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/71818179"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6403#discussion_r71818179"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6403"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6403","id":78413234,"html_url":"https://github.com/dotnet/coreclr/pull/6403","diff_url":"https://github.com/dotnet/coreclr/pull/6403.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6403.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6403","number":6403,"state":"open","locked":false,"title":"[WIP] Uses memcpy in CustomAttributeParser to avoid SIGBUS in ARM","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"This commit attempts to replace explicit assignment in CustomAttributeParser with memcpy to avoid SIGBUS during loading xunit testcases (discussed in #6378)\r\n\r\nThis PR is under testing. Please do NOT merge this.","created_at":"2016-07-22T01:37:59Z","updated_at":"2016-07-22T02:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7d64cb590297b845324654a892db3c4d6b61294","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6403/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6403/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6403/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/02cf3690d0212906f31fce07c6eca112403daa2f","head":{"label":"parjong:wip/corefx_debugging","ref":"wip/corefx_debugging","sha":"02cf3690d0212906f31fce07c6eca112403daa2f","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"repo":{"id":55585145,"name":"coreclr","full_name":"parjong/coreclr","owner":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parjong/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/parjong/coreclr","forks_url":"https://api.github.com/repos/parjong/coreclr/forks","keys_url":"https://api.github.com/repos/parjong/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parjong/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parjong/coreclr/teams","hooks_url":"https://api.github.com/repos/parjong/coreclr/hooks","issue_events_url":"https://api.github.com/repos/parjong/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/parjong/coreclr/events","assignees_url":"https://api.github.com/repos/parjong/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/parjong/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/parjong/coreclr/tags","blobs_url":"https://api.github.com/repos/parjong/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parjong/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parjong/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/parjong/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parjong/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/parjong/coreclr/languages","stargazers_url":"https://api.github.com/repos/parjong/coreclr/stargazers","contributors_url":"https://api.github.com/repos/parjong/coreclr/contributors","subscribers_url":"https://api.github.com/repos/parjong/coreclr/subscribers","subscription_url":"https://api.github.com/repos/parjong/coreclr/subscription","commits_url":"https://api.github.com/repos/parjong/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/parjong/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/parjong/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/parjong/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/parjong/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/parjong/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parjong/coreclr/merges","archive_url":"https://api.github.com/repos/parjong/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parjong/coreclr/downloads","issues_url":"https://api.github.com/repos/parjong/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/parjong/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/parjong/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/parjong/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parjong/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/parjong/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/parjong/coreclr/deployments","created_at":"2016-04-06T07:32:51Z","updated_at":"2016-04-26T00:03:39Z","pushed_at":"2016-07-22T01:35:26Z","git_url":"git://github.com/parjong/coreclr.git","ssh_url":"git@github.com:parjong/coreclr.git","clone_url":"https://github.com/parjong/coreclr.git","svn_url":"https://github.com/parjong/coreclr","homepage":"http://dotnet.github.io/","size":93152,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9f74aff5752c03aab5f03c1b529f6faf6648cb90","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-07-22T01:47:49Z","pushed_at":"2016-07-22T01:54:28Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://dotnet.github.io/","size":102349,"stargazers_count":6697,"watchers_count":6697,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1553,"mirror_url":null,"open_issues_count":912,"forks":1553,"open_issues":912,"watchers":6697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6403"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6403"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6403"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6403/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6403/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6403/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/02cf3690d0212906f31fce07c6eca112403daa2f"}}}}
{"actor":{"display_login":"parjong"}}