{"action":"created","issue":{"url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/74","repository_url":"https://api.github.com/repos/FolioReader/FolioReaderKit","labels_url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/74/comments","events_url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/74/events","html_url":"https://github.com/FolioReader/FolioReaderKit/pull/74","id":158527610,"number":74,"title":"Carthage Support","user":{"login":"alexpopov","id":903856,"avatar_url":"https://avatars.githubusercontent.com/u/903856?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpopov","html_url":"https://github.com/alexpopov","followers_url":"https://api.github.com/users/alexpopov/followers","following_url":"https://api.github.com/users/alexpopov/following{/other_user}","gists_url":"https://api.github.com/users/alexpopov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpopov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpopov/subscriptions","organizations_url":"https://api.github.com/users/alexpopov/orgs","repos_url":"https://api.github.com/users/alexpopov/repos","events_url":"https://api.github.com/users/alexpopov/events{/privacy}","received_events_url":"https://api.github.com/users/alexpopov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-04T22:39:57Z","updated_at":"2016-06-07T13:34:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FolioReader/FolioReaderKit/pulls/74","html_url":"https://github.com/FolioReader/FolioReaderKit/pull/74","diff_url":"https://github.com/FolioReader/FolioReaderKit/pull/74.diff","patch_url":"https://github.com/FolioReader/FolioReaderKit/pull/74.patch"},"body":"I had to restructure the directory structure a little bit, and tested both creating a new CocoaPods project and a new Carthage project with my fork. \r\n\r\nI had to add a pair of compiler directives for `SSZipArchive` and `UIMenuItem_CXAImageSupport`;\r\n- `SSZipArchive` drops the module prefix when installed through Carthage\r\n- `UIMenuItem_CXAImageSupport` doesn't seem to be the same between CocoaPods and Carthage so I changed the initializer depending on whether CocoaPods or Carthage is used. \r\n\r\nThere is one final caveat: I had to add Carthage support to `UIMenuItem` and `ZFDragableModalTransition`, but my pull requests have not been accepted yet. When (if) they're accepted we'll need to update the FolioReader Cartfile to reference them instead of my forks (so we can keep getting upstream updates). \r\n\r\nThat said, UIMenuItem is deprecated, so it may also be wise to update to the latest version of that (I added Carthage support to that one as well, also not merged yet). "},"comment":{"url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/comments/224281712","html_url":"https://github.com/FolioReader/FolioReaderKit/pull/74#issuecomment-224281712","issue_url":"https://api.github.com/repos/FolioReader/FolioReaderKit/issues/74","id":224281712,"user":{"login":"hebertialmeida","id":103670,"avatar_url":"https://avatars.githubusercontent.com/u/103670?v=3","gravatar_id":"","url":"https://api.github.com/users/hebertialmeida","html_url":"https://github.com/hebertialmeida","followers_url":"https://api.github.com/users/hebertialmeida/followers","following_url":"https://api.github.com/users/hebertialmeida/following{/other_user}","gists_url":"https://api.github.com/users/hebertialmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/hebertialmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebertialmeida/subscriptions","organizations_url":"https://api.github.com/users/hebertialmeida/orgs","repos_url":"https://api.github.com/users/hebertialmeida/repos","events_url":"https://api.github.com/users/hebertialmeida/events{/privacy}","received_events_url":"https://api.github.com/users/hebertialmeida/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T13:34:57Z","updated_at":"2016-06-07T13:34:57Z","body":"About the menu have you checked this https://github.com/cxa/MenuItemKit \r\nIt is the same menu written in Swift, and now it has Cocoapods support, the issue #41 is about a migration."}}
{"actor":{"display_login":"hebertialmeida"}}