{"action":"created","comment":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/85497334","pull_request_review_id":6201750,"id":85497334,"diff_hunk":"@@ -92,36 +92,43 @@ NodeProcess.prototype.subdivideNode = function(node, camera, params) {\n                 var j;\n \n                 child.matrixSet = [];\n-\n+                var tileMatrixSet,nTextures;\n \n                 // update wmts\n                 var colorLayers = params.layersConfig.getColorLayers();\n+\n+                // update Imagery wmts\n                 for (j = 0; j < colorLayers.length; j++) {\n                     layer = colorLayers[j];\n-                    var tileMatrixSet = layer.options.tileMatrixSet;\n+                     tileMatrixSet = layer.options.tileMatrixSet;\n \n                     if (tileMatrixSet && !child.matrixSet[tileMatrixSet]) {\n                         child.matrixSet[tileMatrixSet] = this.projection.getCoordWMTS_WGS84(child.tileCoord, child.bbox, tileMatrixSet);\n                     }\n \n                     if (layer.tileInsideLimit(child, layer)) {\n+\n+                        if(tileMatrixSet) {\n+                            var bcoord = child.matrixSet[tileMatrixSet];\n+                            nTextures = bcoord[1].row - bcoord[0].row + 1;\n+                        } else {\n+                            nTextures = 1;\n+                        }\n+\n                         paramMaterial.push({\n                             tileMT: tileMatrixSet,\n-                            layerTexturesOffset: colorTextureCount,\n+                            nTextures: nTextures,","path":"src/Scene/NodeProcess.js","position":32,"original_position":32,"commit_id":"c905f4ee1d6e4e016ed3c240689f7f43c2fc8fe6","original_commit_id":"704d4150cca62e918a8f7aeb99a393e52a02a778","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"body":"`nTextures` could be replaced with `textureCount`","created_at":"2016-10-28T09:18:20Z","updated_at":"2016-10-28T09:23:08Z","html_url":"https://github.com/iTowns/itowns2/pull/198#discussion_r85497334","pull_request_url":"https://api.github.com/repos/iTowns/itowns2/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/85497334"},"html":{"href":"https://github.com/iTowns/itowns2/pull/198#discussion_r85497334"},"pull_request":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/198","id":91164335,"html_url":"https://github.com/iTowns/itowns2/pull/198","diff_url":"https://github.com/iTowns/itowns2/pull/198.diff","patch_url":"https://github.com/iTowns/itowns2/pull/198.patch","issue_url":"https://api.github.com/repos/iTowns/itowns2/issues/198","number":198,"state":"open","locked":false,"title":"Rework LayeredMaterial and Add Style","user":{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false},"body":"- **Add `Style` object to WFS**\r\n\r\n- **Rework LayeredMaterial**\r\n  * All textures and parameters are ordered by display order.\r\n  * `this.Layers` contains all layers by display order\r\n  * The slots's texture management is done internally, now, to set texture uses `layerId`\r\n  * Fix bug : Remove color layer doesn't dispose textures colors\r\n\r\n- **Uniform changes** (`LayeredMaterial` and `BasicMaterial`)\r\n * use`THREE.Uniform` in material\r\n * `int RTC`          becomes `bool useRTC`\r\n * `int lightingOn` becomes `bool lightingOn`\r\n * `int debug`       becomes `bool debug`\r\n * `int lightingOn` becomes `bool lightingOn`\r\n * `int selected`    becomes `bool selected`\r\n\r\n- **Remove slot texture** in `NodeProcess` is replaced by `layerId`\r\n\r\n- **Change Skirt size** influence performance rendering, minimize pixel shader pass\r\n\r\n- **Fix typos and add Binary Tools**\r\n","created_at":"2016-10-27T09:33:49Z","updated_at":"2016-10-28T09:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f42d5b375a46ad2ca41178eec964df84c567e0e8","assignee":{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false},"assignees":[{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/iTowns/itowns2/milestones/1","html_url":"https://github.com/iTowns/itowns2/milestones/2.0","labels_url":"https://api.github.com/repos/iTowns/itowns2/milestones/1/labels","id":1977044,"number":1,"title":"2.0","description":"First release of major version iTowns 2.0 ","creator":{"login":"vpicavet","id":76112,"avatar_url":"https://avatars.githubusercontent.com/u/76112?v=3","gravatar_id":"","url":"https://api.github.com/users/vpicavet","html_url":"https://github.com/vpicavet","followers_url":"https://api.github.com/users/vpicavet/followers","following_url":"https://api.github.com/users/vpicavet/following{/other_user}","gists_url":"https://api.github.com/users/vpicavet/gists{/gist_id}","starred_url":"https://api.github.com/users/vpicavet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpicavet/subscriptions","organizations_url":"https://api.github.com/users/vpicavet/orgs","repos_url":"https://api.github.com/users/vpicavet/repos","events_url":"https://api.github.com/users/vpicavet/events{/privacy}","received_events_url":"https://api.github.com/users/vpicavet/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":2,"state":"open","created_at":"2016-09-01T08:37:19Z","updated_at":"2016-10-27T09:33:49Z","due_on":"2016-12-25T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/iTowns/itowns2/pulls/198/commits","review_comments_url":"https://api.github.com/repos/iTowns/itowns2/pulls/198/comments","review_comment_url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iTowns/itowns2/issues/198/comments","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/c905f4ee1d6e4e016ed3c240689f7f43c2fc8fe6","head":{"label":"iTowns:Style","ref":"Style","sha":"c905f4ee1d6e4e016ed3c240689f7f43c2fc8fe6","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-10-25T15:07:13Z","pushed_at":"2016-10-28T08:25:55Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":68568,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":87,"forks":15,"open_issues":87,"watchers":20,"default_branch":"master"}},"base":{"label":"iTowns:ApiZoomScale","ref":"ApiZoomScale","sha":"11d36c51a7d381df7e9bed12b9b9575235d226b9","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-10-25T15:07:13Z","pushed_at":"2016-10-28T08:25:55Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":68568,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":87,"forks":15,"open_issues":87,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/198"},"html":{"href":"https://github.com/iTowns/itowns2/pull/198"},"issue":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/198"},"comments":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/iTowns/itowns2/statuses/c905f4ee1d6e4e016ed3c240689f7f43c2fc8fe6"}}}}
{"actor":{"display_login":"peppsac"}}