{"action":"created","issue":{"url":"https://api.github.com/repos/sass/sassc/issues/202","repository_url":"https://api.github.com/repos/sass/sassc","labels_url":"https://api.github.com/repos/sass/sassc/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/sass/sassc/issues/202/comments","events_url":"https://api.github.com/repos/sass/sassc/issues/202/events","html_url":"https://github.com/sass/sassc/issues/202","id":194981151,"number":202,"title":"Sourcemap file not generated","user":{"login":"daanvosdewael","id":734181,"avatar_url":"https://avatars.githubusercontent.com/u/734181?v=3","gravatar_id":"","url":"https://api.github.com/users/daanvosdewael","html_url":"https://github.com/daanvosdewael","followers_url":"https://api.github.com/users/daanvosdewael/followers","following_url":"https://api.github.com/users/daanvosdewael/following{/other_user}","gists_url":"https://api.github.com/users/daanvosdewael/gists{/gist_id}","starred_url":"https://api.github.com/users/daanvosdewael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daanvosdewael/subscriptions","organizations_url":"https://api.github.com/users/daanvosdewael/orgs","repos_url":"https://api.github.com/users/daanvosdewael/repos","events_url":"https://api.github.com/users/daanvosdewael/events{/privacy}","received_events_url":"https://api.github.com/users/daanvosdewael/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-12T14:00:24Z","updated_at":"2016-12-12T15:40:15Z","closed_at":null,"body":"When compiling with the `--sourcemap` flag, only the `sourceMappingURL` is added to the output file. The `.css.map` file is not generated.\r\n\r\n```bash\r\n$ sassc -v\r\nsassc: 3.4.0\r\nlibsass: 3.4.0\r\nsass2scss: 1.1.0\r\nsass: 3.4\r\n```"},"comment":{"url":"https://api.github.com/repos/sass/sassc/issues/comments/266463325","html_url":"https://github.com/sass/sassc/issues/202#issuecomment-266463325","issue_url":"https://api.github.com/repos/sass/sassc/issues/202","id":266463325,"user":{"login":"am11","id":3840695,"avatar_url":"https://avatars.githubusercontent.com/u/3840695?v=3","gravatar_id":"","url":"https://api.github.com/users/am11","html_url":"https://github.com/am11","followers_url":"https://api.github.com/users/am11/followers","following_url":"https://api.github.com/users/am11/following{/other_user}","gists_url":"https://api.github.com/users/am11/gists{/gist_id}","starred_url":"https://api.github.com/users/am11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/am11/subscriptions","organizations_url":"https://api.github.com/users/am11/orgs","repos_url":"https://api.github.com/users/am11/repos","events_url":"https://api.github.com/users/am11/events{/privacy}","received_events_url":"https://api.github.com/users/am11/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T15:40:15Z","updated_at":"2016-12-12T15:40:15Z","body":"Thanks for the report @daanvosdewael. I can reproduce this issue.\r\n\r\n@mgreter, with this patch:\r\n\r\n```diff\r\ndiff --git a/sassc.c b/sassc.c\r\nindex 9e75945..ff1aa24 100644\r\n--- a/sassc.c\r\n+++ b/sassc.c\r\n@@ -150,12 +150,12 @@ int compile_file(struct Sass_Options* options, char* input_path, char* outfile)\r\n         outfile\r\n     );\r\n\r\n-    if (ret == 0 && sass_option_get_source_map_file(options)) {\r\n+    if (ret == 0 && sass_option_get_source_map_file(ctx_out)) {\r\n         ret = output(\r\n             sass_context_get_error_status(ctx_out),\r\n             sass_context_get_error_message(ctx_out),\r\n             sass_context_get_source_map_string(ctx_out),\r\n-            sass_option_get_source_map_file(options)\r\n+            sass_option_get_source_map_file(ctx_out)\r\n         );\r\n     }\r\n```\r\n\r\nthis issue gets fixed, but instead shouldn't all the `sass_option_get_*` methods work with `options` object instead of context?\r\n\r\nAlso, we should probably avoid calling `sass_option_get_source_map_file` twice (`char* map_file =  sass_option_get_source_map_file(ctx_out);` before the `if` block)."}}
{"actor":{"display_login":"am11"}}