{"action":"created","issue":{"url":"https://api.github.com/repos/resin-io/etcher/issues/747","repository_url":"https://api.github.com/repos/resin-io/etcher","labels_url":"https://api.github.com/repos/resin-io/etcher/issues/747/labels{/name}","comments_url":"https://api.github.com/repos/resin-io/etcher/issues/747/comments","events_url":"https://api.github.com/repos/resin-io/etcher/issues/747/events","html_url":"https://github.com/resin-io/etcher/pull/747","id":180734371,"number":747,"title":"chore: add debian packaging","user":{"login":"dlech","id":963645,"avatar_url":"https://avatars.githubusercontent.com/u/963645?v=3","gravatar_id":"","url":"https://api.github.com/users/dlech","html_url":"https://github.com/dlech","followers_url":"https://api.github.com/users/dlech/followers","following_url":"https://api.github.com/users/dlech/following{/other_user}","gists_url":"https://api.github.com/users/dlech/gists{/gist_id}","starred_url":"https://api.github.com/users/dlech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlech/subscriptions","organizations_url":"https://api.github.com/users/dlech/orgs","repos_url":"https://api.github.com/users/dlech/repos","events_url":"https://api.github.com/users/dlech/events{/privacy}","received_events_url":"https://api.github.com/users/dlech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-03T20:09:56Z","updated_at":"2016-10-05T16:24:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/747","html_url":"https://github.com/resin-io/etcher/pull/747","diff_url":"https://github.com/resin-io/etcher/pull/747.diff","patch_url":"https://github.com/resin-io/etcher/pull/747.patch"},"body":"This adds a \"debian\" command to the linux build script. It uses\r\nelectron-installer-debian to create a debian package."},"comment":{"url":"https://api.github.com/repos/resin-io/etcher/issues/comments/251725265","html_url":"https://github.com/resin-io/etcher/pull/747#issuecomment-251725265","issue_url":"https://api.github.com/repos/resin-io/etcher/issues/747","id":251725265,"user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars.githubusercontent.com/u/2192773?v=3","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T16:24:47Z","updated_at":"2016-10-05T16:24:47Z","body":"This PR looks amazing! I've noticed that the `debian` build command doesn't package things by itself, therefore if you run it without having ran `package` first, you get errors like these ones:\r\n\r\n```sh\r\n+ cp scripts/build/debian/etcher-electron.sh etcher-release/Etcher-linux-x64/\r\ncp: cannot create regular file 'etcher-release/Etcher-linux-x64/': No such file or directory\r\n```\r\n\r\nMaking sure the packaging section runs of `command == debian` seems to be the way to go:\r\n\r\n```diff\r\ndiff --git a/scripts/build/linux.sh b/scripts/build/linux.sh\r\nindex 514f136..492b571 100755\r\n--- a/scripts/build/linux.sh\r\n+++ b/scripts/build/linux.sh\r\n@@ -169,7 +169,7 @@ if [ \"$COMMAND\" == \"install\" ] || [ \"$COMMAND\" == \"all\" ]; then\r\n   fi\r\n fi\r\n \r\n-if [ \"$COMMAND\" == \"package\" ] || [ \"$COMMAND\" == \"all\" ]; then\r\n+if [ \"$COMMAND\" == \"package\" ] || [ \"$COMMAND\" == \"debian\" ] || [ \"$COMMAND\" == \"all\" ]; then\r\n   if [ \"$ARCH\" == \"x86\" ]; then\r\n     package_x86 etcher-release\r\n   fi\r\n```\r\n\r\nAs a side note, this scripts are getting very hairy now that there are multiple distribution methods, but don't worry about it, I'll allocate some time to clean it up next week!"}}
{"actor":{"display_login":"jviotti"}}