{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/79445432","id":79445432,"diff_hunk":"@@ -54,35 +62,39 @@ struct inspector_socket_s {\n   bool ws_mode;\n   bool shutting_down;\n   bool connection_eof;\n+ private:\n+  DISALLOW_COPY_AND_ASSIGN(InspectorSocket);\n };\n \n-typedef struct inspector_socket_s inspector_socket_t;\n-\n-int inspector_accept(uv_stream_t* server, struct inspector_socket_s* inspector,\n+int inspector_accept(uv_stream_t* server, struct InspectorSocket* inspector,\n                      handshake_cb callback);\n \n-void inspector_close(struct inspector_socket_s* inspector,\n+void inspector_close(struct InspectorSocket* inspector,","path":"src/inspector_socket.h","position":null,"original_position":56,"commit_id":"634ac408423666a111fff50a11c8b1f1d70db159","original_commit_id":"1efbb9862223c4d56adc84908bb8b34be2aac8ad","user":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-09-19T17:34:49Z","updated_at":"2016-09-19T17:34:50Z","html_url":"https://github.com/nodejs/node/pull/8536#discussion_r79445432","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/8536","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/79445432"},"html":{"href":"https://github.com/nodejs/node/pull/8536#discussion_r79445432"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/8536"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8536","id":85270546,"html_url":"https://github.com/nodejs/node/pull/8536","diff_url":"https://github.com/nodejs/node/pull/8536.diff","patch_url":"https://github.com/nodejs/node/pull/8536.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8536","number":8536,"state":"open","locked":false,"title":"inspector: zero out structure members","user":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nChange is internal to inspector.\r\n\r\n\r\n##### Description of change\r\nCtor has to be added as memset to 0 is no longer an option, since\r\nthe structure now has std::vector member.\r\n\r\nThis is an attempt at guessing a fix for nodejs/node#8155 - so far I was not able to repro it.","created_at":"2016-09-14T17:25:40Z","updated_at":"2016-09-19T17:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0f7ce4c0a617efd2f8e45c05e0c64c062c32621","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8536/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8536/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8536/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/634ac408423666a111fff50a11c8b1f1d70db159","head":{"label":"eugeneo:zero_out","ref":"zero_out","sha":"634ac408423666a111fff50a11c8b1f1d70db159","user":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"repo":{"id":54138097,"name":"node","full_name":"eugeneo/node","owner":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eugeneo/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/eugeneo/node","forks_url":"https://api.github.com/repos/eugeneo/node/forks","keys_url":"https://api.github.com/repos/eugeneo/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eugeneo/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eugeneo/node/teams","hooks_url":"https://api.github.com/repos/eugeneo/node/hooks","issue_events_url":"https://api.github.com/repos/eugeneo/node/issues/events{/number}","events_url":"https://api.github.com/repos/eugeneo/node/events","assignees_url":"https://api.github.com/repos/eugeneo/node/assignees{/user}","branches_url":"https://api.github.com/repos/eugeneo/node/branches{/branch}","tags_url":"https://api.github.com/repos/eugeneo/node/tags","blobs_url":"https://api.github.com/repos/eugeneo/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eugeneo/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eugeneo/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/eugeneo/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eugeneo/node/statuses/{sha}","languages_url":"https://api.github.com/repos/eugeneo/node/languages","stargazers_url":"https://api.github.com/repos/eugeneo/node/stargazers","contributors_url":"https://api.github.com/repos/eugeneo/node/contributors","subscribers_url":"https://api.github.com/repos/eugeneo/node/subscribers","subscription_url":"https://api.github.com/repos/eugeneo/node/subscription","commits_url":"https://api.github.com/repos/eugeneo/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/eugeneo/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/eugeneo/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/eugeneo/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/eugeneo/node/contents/{+path}","compare_url":"https://api.github.com/repos/eugeneo/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eugeneo/node/merges","archive_url":"https://api.github.com/repos/eugeneo/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eugeneo/node/downloads","issues_url":"https://api.github.com/repos/eugeneo/node/issues{/number}","pulls_url":"https://api.github.com/repos/eugeneo/node/pulls{/number}","milestones_url":"https://api.github.com/repos/eugeneo/node/milestones{/number}","notifications_url":"https://api.github.com/repos/eugeneo/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eugeneo/node/labels{/name}","releases_url":"https://api.github.com/repos/eugeneo/node/releases{/id}","deployments_url":"https://api.github.com/repos/eugeneo/node/deployments","created_at":"2016-03-17T17:30:32Z","updated_at":"2016-04-18T17:50:02Z","pushed_at":"2016-09-19T17:27:59Z","git_url":"git://github.com/eugeneo/node.git","ssh_url":"git@github.com:eugeneo/node.git","clone_url":"https://github.com/eugeneo/node.git","svn_url":"https://github.com/eugeneo/node","homepage":"https://nodejs.org","size":213858,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"autoroll"}},"base":{"label":"nodejs:master","ref":"master","sha":"c5545f2c63fe30b0cfcdafab18c26df8286881d0","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-19T17:33:36Z","pushed_at":"2016-09-19T17:28:00Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":303977,"stargazers_count":26835,"watchers_count":26835,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4304,"mirror_url":null,"open_issues_count":842,"forks":4304,"open_issues":842,"watchers":26835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8536"},"html":{"href":"https://github.com/nodejs/node/pull/8536"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8536"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8536/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8536/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8536/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/634ac408423666a111fff50a11c8b1f1d70db159"}}}}
{"actor":{"display_login":"eugeneo"}}