{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/92927095","pull_request_review_id":13451325,"id":92927095,"diff_hunk":"@@ -48,10 +51,22 @@ class EQ3BTSmartThermostat(ClimateDevice):\n \n     def __init__(self, _mac, _name):\n         \"\"\"Initialize the thermostat.\"\"\"\n-        from bluepy_devices.devices import eq3btsmart\n+        # we want to avoid name clash with this module..\n+        from bluepy_devices.devices import eq3btsmart as eq3\n+\n+        self.modes = { eq3.EQ3BTSMART_UNKOWN: STATE_UNKNOWN,\n+                 eq3.EQ3BTSMART_AUTO: STATE_AUTO,\n+                 # away mode is handled separately, leaving here just for commentary\n+                 eq3.EQ3BTSMART_AWAY: STATE_AWAY,\n+                 eq3.EQ3BTSMART_CLOSED: STATE_OFF,","path":"homeassistant/components/climate/eq3btsmart.py","position":37,"original_position":37,"commit_id":"7f749e2a9cb63216e376b418745f234b49d4b876","original_commit_id":"7f749e2a9cb63216e376b418745f234b49d4b876","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"continuation line under-indented for visual indent","created_at":"2016-12-17T19:04:56Z","updated_at":"2016-12-17T19:04:56Z","html_url":"https://github.com/home-assistant/home-assistant/pull/4959#discussion_r92927095","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/92927095"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/4959#discussion_r92927095"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959","id":98452560,"html_url":"https://github.com/home-assistant/home-assistant/pull/4959","diff_url":"https://github.com/home-assistant/home-assistant/pull/4959.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/4959.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4959","number":4959,"state":"open","locked":false,"title":"WIP: eq3btsmart: support modes and clean up the code to use climatedevice's features","user":{"login":"rytilahti","id":3705853,"avatar_url":"https://avatars.githubusercontent.com/u/3705853?v=3","gravatar_id":"","url":"https://api.github.com/users/rytilahti","html_url":"https://github.com/rytilahti","followers_url":"https://api.github.com/users/rytilahti/followers","following_url":"https://api.github.com/users/rytilahti/following{/other_user}","gists_url":"https://api.github.com/users/rytilahti/gists{/gist_id}","starred_url":"https://api.github.com/users/rytilahti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytilahti/subscriptions","organizations_url":"https://api.github.com/users/rytilahti/orgs","repos_url":"https://api.github.com/users/rytilahti/repos","events_url":"https://api.github.com/users/rytilahti/events{/privacy}","received_events_url":"https://api.github.com/users/rytilahti/received_events","type":"User","site_admin":false},"body":"**Description:** This patch adds support for modes of eq3 bluetooth smart thermostat.\r\n\r\nNote: this requires an updated fork of the backend lib (PR https://github.com/bimbar/bluepy_devices/pull/6). The upstream hasn't yet responded.\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#1618\r\n\r\n\r\n**Checklist:**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [?] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [-] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [?] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [-] New files were added to `.coveragerc`.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n","created_at":"2016-12-17T19:04:47Z","updated_at":"2016-12-17T19:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17c8227784430eedb5f77d793b4c115bb9267ab9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4959/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7f749e2a9cb63216e376b418745f234b49d4b876","head":{"label":"rytilahti:eq3btsmart_modes","ref":"eq3btsmart_modes","sha":"7f749e2a9cb63216e376b418745f234b49d4b876","user":{"login":"rytilahti","id":3705853,"avatar_url":"https://avatars.githubusercontent.com/u/3705853?v=3","gravatar_id":"","url":"https://api.github.com/users/rytilahti","html_url":"https://github.com/rytilahti","followers_url":"https://api.github.com/users/rytilahti/followers","following_url":"https://api.github.com/users/rytilahti/following{/other_user}","gists_url":"https://api.github.com/users/rytilahti/gists{/gist_id}","starred_url":"https://api.github.com/users/rytilahti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytilahti/subscriptions","organizations_url":"https://api.github.com/users/rytilahti/orgs","repos_url":"https://api.github.com/users/rytilahti/repos","events_url":"https://api.github.com/users/rytilahti/events{/privacy}","received_events_url":"https://api.github.com/users/rytilahti/received_events","type":"User","site_admin":false},"repo":{"id":76131733,"name":"home-assistant","full_name":"rytilahti/home-assistant","owner":{"login":"rytilahti","id":3705853,"avatar_url":"https://avatars.githubusercontent.com/u/3705853?v=3","gravatar_id":"","url":"https://api.github.com/users/rytilahti","html_url":"https://github.com/rytilahti","followers_url":"https://api.github.com/users/rytilahti/followers","following_url":"https://api.github.com/users/rytilahti/following{/other_user}","gists_url":"https://api.github.com/users/rytilahti/gists{/gist_id}","starred_url":"https://api.github.com/users/rytilahti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytilahti/subscriptions","organizations_url":"https://api.github.com/users/rytilahti/orgs","repos_url":"https://api.github.com/users/rytilahti/repos","events_url":"https://api.github.com/users/rytilahti/events{/privacy}","received_events_url":"https://api.github.com/users/rytilahti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rytilahti/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/rytilahti/home-assistant","forks_url":"https://api.github.com/repos/rytilahti/home-assistant/forks","keys_url":"https://api.github.com/repos/rytilahti/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rytilahti/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rytilahti/home-assistant/teams","hooks_url":"https://api.github.com/repos/rytilahti/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/rytilahti/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/rytilahti/home-assistant/events","assignees_url":"https://api.github.com/repos/rytilahti/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/rytilahti/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/rytilahti/home-assistant/tags","blobs_url":"https://api.github.com/repos/rytilahti/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rytilahti/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rytilahti/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/rytilahti/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rytilahti/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/rytilahti/home-assistant/languages","stargazers_url":"https://api.github.com/repos/rytilahti/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/rytilahti/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/rytilahti/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/rytilahti/home-assistant/subscription","commits_url":"https://api.github.com/repos/rytilahti/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/rytilahti/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/rytilahti/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/rytilahti/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/rytilahti/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/rytilahti/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rytilahti/home-assistant/merges","archive_url":"https://api.github.com/repos/rytilahti/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rytilahti/home-assistant/downloads","issues_url":"https://api.github.com/repos/rytilahti/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/rytilahti/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/rytilahti/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/rytilahti/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rytilahti/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/rytilahti/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/rytilahti/home-assistant/deployments","created_at":"2016-12-10T19:01:16Z","updated_at":"2016-12-10T19:01:21Z","pushed_at":"2016-12-17T17:59:11Z","git_url":"git://github.com/rytilahti/home-assistant.git","ssh_url":"git@github.com:rytilahti/home-assistant.git","clone_url":"https://github.com/rytilahti/home-assistant.git","svn_url":"https://github.com/rytilahti/home-assistant","homepage":"https://home-assistant.io","size":45892,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"60ef0153a29828b6880fe7f7828ae4f9f7b67ac8","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-12-17T19:01:22Z","pushed_at":"2016-12-17T19:04:48Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":45888,"stargazers_count":5043,"watchers_count":5043,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1342,"mirror_url":null,"open_issues_count":353,"forks":1342,"open_issues":353,"watchers":5043,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/4959"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/4959"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/4959/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4959/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7f749e2a9cb63216e376b418745f234b49d4b876"}}}}
{"actor":{"display_login":"houndci-bot"}}