{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/53404405","id":53404405,"diff_hunk":"@@ -179,8 +179,8 @@\n         <artifactId>maven-compiler-plugin</artifactId>\n         <version>3.1</version>\n         <configuration>\n-          <source>1.6</source>\n-          <target>1.6</target>\n+          <source>1.7</source>\n+          <target>1.7</target>","path":"src/pom.xml","position":7,"original_position":7,"commit_id":"7a4fee76cf1256c7aa659e009e03f430be9bd692","original_commit_id":"7a4fee76cf1256c7aa659e009e03f430be9bd692","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"body":"test comment from Codeflow","created_at":"2016-02-19T00:08:36Z","updated_at":"2016-02-19T00:08:36Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495#discussion_r53404405","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/53404405"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495#discussion_r53404405"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495","id":58857835,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/495","number":495,"state":"open","locked":false,"title":"remove catching generic Exception and catch only expected ones","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"body":"+bump up target version to support multi catch statement\r\nRecreated pull request against dev branch (instead of master).\r\nCurrently all Runtime exceptions are swallowed and if they happen it's hard to trace the reason why token is not obtained.\r\n Instead it's better to catch only excepted exceptions, because if unexpected exception happens mobile app should crash and give a stack trace what went wrong, that way it's easy to fix the problem.\r\n Sample: You have button but when you click nothing happens. Or button that crashes you app and you see NPE in you logs...From user stand point - nothing changes because button doesn't work, from dev standpoint - much more info from second case.","created_at":"2016-02-10T07:58:26Z","updated_at":"2016-02-19T00:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f48e739f2deed021771f79556d7229b7a3ef2e8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/495/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/7a4fee76cf1256c7aa659e009e03f430be9bd692","head":{"label":"imakhalova:removeExceptions","ref":"removeExceptions","sha":"7a4fee76cf1256c7aa659e009e03f430be9bd692","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"repo":{"id":51237079,"name":"azure-activedirectory-library-for-android","full_name":"imakhalova/azure-activedirectory-library-for-android","owner":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":true,"url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/deployments","created_at":"2016-02-07T05:42:06Z","updated_at":"2016-02-07T05:42:07Z","pushed_at":"2016-02-18T08:53:12Z","git_url":"git://github.com/imakhalova/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:imakhalova/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":9117,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"f8bd4b97b09f953bc6f6a093e4a5d843c7df53ca","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703238,"name":"azure-activedirectory-library-for-android","full_name":"AzureAD/azure-activedirectory-library-for-android","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/deployments","created_at":"2013-11-26T00:59:05Z","updated_at":"2016-01-19T04:28:58Z","pushed_at":"2016-02-18T23:15:17Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":23143,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":68,"forks":46,"open_issues":68,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/495"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/495"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/7a4fee76cf1256c7aa659e009e03f430be9bd692"}}}}