{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/7415","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/7415/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7415/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/7415/events","html_url":"https://github.com/eslint/eslint/pull/7415","id":184306937,"number":7415,"title":"New: capitalized-comments rule (fixes #6055)","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"labels":[{"id":131106229,"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc","default":false},{"id":253473350,"url":"https://api.github.com/repos/eslint/eslint/labels/feature","name":"feature","color":"bfd4f2","default":false},{"id":45798639,"url":"https://api.github.com/repos/eslint/eslint/labels/rule","name":"rule","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-20T18:35:07Z","updated_at":"2016-11-07T02:04:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/7415","html_url":"https://github.com/eslint/eslint/pull/7415","diff_url":"https://github.com/eslint/eslint/pull/7415.diff","patch_url":"https://github.com/eslint/eslint/pull/7415.patch"},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\n\n[ ] Documentation update\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\n[x] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\n[ ] Add autofixing to a rule\n[ ] Add a CLI option\n[ ] Add something to the core\n[ ] Other, please explain:\n\n<!--\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\n-->\n\nSee issue #6055.\n\n<!--\n    Please ensure your pull request is ready:\n\n    - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)\n    - Include tests for this change\n    - Update documentation for this change (if appropriate)\n-->\n\n<!--\n    The following is required for all pull requests:\n-->\n\n**What changes did you make? (Give an overview)**\n\nAdded new rule \"capitalized-comments\".\n\n**Is there anything you'd like reviewers to focus on?**\n\nI've tried to implement the tests cases from [the JSCS tests](https://github.com/jscs-dev/node-jscs/blob/master/test/specs/rules/require-capitalized-comments.js). It'd be great to confirm I haven't missed any :smile:\n\nI intentionally did not implement \"markers\" because (1) it's still not clear exactly how they would work in this rule (though it is clear to me that they would need to behave differently than `spaced-comment`); and (2) it's not necessary for JSCS compatibility.\n\nI had to make some decisions regarding a few JSCS rule features and whether they should be default behavior or behind an option.\n- Comments that start with URLs are not reported: I made this default behavior.\n- Consecutive comments (\"textblocks\" in JSCS-speak) are not warned if the first comment in the group is valid: I've implemented that as a `tolerateConsecutiveComments` option, off by default.\n- Ignoring inline comments: This option was called `inlined` in JSCS, but I'm calling it `ignoreInlineComments` here for clarity.\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/258731480","html_url":"https://github.com/eslint/eslint/pull/7415#issuecomment-258731480","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7415","id":258731480,"user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T02:04:02Z","updated_at":"2016-11-07T02:04:02Z","body":"@not-an-aardvark @nzakas Schema has been modified per your recommendations. I've also renamed the file that needed to be renamed. Except for the license needed in the pattern file, this should be good for another round of review. Thanks!"}}
{"actor":{"display_login":"platinumazure"}}