{"action":"created","comment":{"url":"https://api.github.com/repos/conda/conda-env/pulls/comments/76468962","id":76468962,"diff_hunk":"@@ -117,4 +127,18 @@ def packagename(self):\n \n     def parse(self):\n         \"\"\"Parse environment definition handle\"\"\"\n-        return self.name.split('/', 1)\n+        split_name = self.name.split('/')\n+\n+        if len(split_name) == 3:\n+            #We have a version\n+            self.version = split_name[2]\n+            return split_name[0:2]\n+        elif len(split_name) == 2:\n+            #No version should be user/package\n+            return split_name","path":"conda_env/specs/binstar.py","position":48,"original_position":49,"commit_id":"78426c1dd4528a1cf7a443b67a7f941799f9c17b","original_commit_id":"4a5e34cd985ef5a0ca5f199ae523c38b66c3c3ed","user":{"login":"jerowe","id":5555526,"avatar_url":"https://avatars.githubusercontent.com/u/5555526?v=3","gravatar_id":"","url":"https://api.github.com/users/jerowe","html_url":"https://github.com/jerowe","followers_url":"https://api.github.com/users/jerowe/followers","following_url":"https://api.github.com/users/jerowe/following{/other_user}","gists_url":"https://api.github.com/users/jerowe/gists{/gist_id}","starred_url":"https://api.github.com/users/jerowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerowe/subscriptions","organizations_url":"https://api.github.com/users/jerowe/orgs","repos_url":"https://api.github.com/users/jerowe/repos","events_url":"https://api.github.com/users/jerowe/events{/privacy}","received_events_url":"https://api.github.com/users/jerowe/received_events","type":"User","site_admin":false},"body":"If we have a limited number of splits potentially users could throw something in there like\r\n\r\n\r\n```\r\ndarth/deathstar/1.0/someotherthing\r\n```\r\nand it would get split as \r\n\r\n```\r\ndarth, deathstar, 1.0/thing\r\n```\r\n\r\nWhich is obviously wrong because the length of the split doesn't correspond to anything. There should be some sort of limit that it can't split as more than 2 (user, package) or 3 (user, package, version). \r\n\r\nBut yes, split('/', 2) would work for either case. It just wouldn't catch errors in having too many things supplied by the user. If you prefer I will do that.","created_at":"2016-08-26T18:49:58Z","updated_at":"2016-08-26T18:49:58Z","html_url":"https://github.com/conda/conda-env/pull/271#discussion_r76468962","pull_request_url":"https://api.github.com/repos/conda/conda-env/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/conda/conda-env/pulls/comments/76468962"},"html":{"href":"https://github.com/conda/conda-env/pull/271#discussion_r76468962"},"pull_request":{"href":"https://api.github.com/repos/conda/conda-env/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/conda/conda-env/pulls/271","id":82531360,"html_url":"https://github.com/conda/conda-env/pull/271","diff_url":"https://github.com/conda/conda-env/pull/271.diff","patch_url":"https://github.com/conda/conda-env/pull/271.patch","issue_url":"https://api.github.com/repos/conda/conda-env/issues/271","number":271,"state":"open","locked":false,"title":"Add versioning to conda envs","user":{"login":"jerowe","id":5555526,"avatar_url":"https://avatars.githubusercontent.com/u/5555526?v=3","gravatar_id":"","url":"https://api.github.com/users/jerowe","html_url":"https://github.com/jerowe","followers_url":"https://api.github.com/users/jerowe/followers","following_url":"https://api.github.com/users/jerowe/following{/other_user}","gists_url":"https://api.github.com/users/jerowe/gists{/gist_id}","starred_url":"https://api.github.com/users/jerowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerowe/subscriptions","organizations_url":"https://api.github.com/users/jerowe/orgs","repos_url":"https://api.github.com/users/jerowe/repos","events_url":"https://api.github.com/users/jerowe/events{/privacy}","received_events_url":"https://api.github.com/users/jerowe/received_events","type":"User","site_admin":false},"body":"[270](https://github.com/conda/conda-env/issues/270)\r\n\r\nI would like to add user controlled versioning to conda envs. I've got the uploader part done, but I still need to do some checks for creating. Here is my initial effort.\r\n\r\nBest,\r\nJillian ","created_at":"2016-08-24T12:17:36Z","updated_at":"2016-08-26T18:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"784a9aab140ac3687e208e71f971404e83d120ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda/conda-env/pulls/271/commits","review_comments_url":"https://api.github.com/repos/conda/conda-env/pulls/271/comments","review_comment_url":"https://api.github.com/repos/conda/conda-env/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda/conda-env/issues/271/comments","statuses_url":"https://api.github.com/repos/conda/conda-env/statuses/78426c1dd4528a1cf7a443b67a7f941799f9c17b","head":{"label":"jerowe:develop","ref":"develop","sha":"78426c1dd4528a1cf7a443b67a7f941799f9c17b","user":{"login":"jerowe","id":5555526,"avatar_url":"https://avatars.githubusercontent.com/u/5555526?v=3","gravatar_id":"","url":"https://api.github.com/users/jerowe","html_url":"https://github.com/jerowe","followers_url":"https://api.github.com/users/jerowe/followers","following_url":"https://api.github.com/users/jerowe/following{/other_user}","gists_url":"https://api.github.com/users/jerowe/gists{/gist_id}","starred_url":"https://api.github.com/users/jerowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerowe/subscriptions","organizations_url":"https://api.github.com/users/jerowe/orgs","repos_url":"https://api.github.com/users/jerowe/repos","events_url":"https://api.github.com/users/jerowe/events{/privacy}","received_events_url":"https://api.github.com/users/jerowe/received_events","type":"User","site_admin":false},"repo":{"id":60069718,"name":"conda-env","full_name":"jerowe/conda-env","owner":{"login":"jerowe","id":5555526,"avatar_url":"https://avatars.githubusercontent.com/u/5555526?v=3","gravatar_id":"","url":"https://api.github.com/users/jerowe","html_url":"https://github.com/jerowe","followers_url":"https://api.github.com/users/jerowe/followers","following_url":"https://api.github.com/users/jerowe/following{/other_user}","gists_url":"https://api.github.com/users/jerowe/gists{/gist_id}","starred_url":"https://api.github.com/users/jerowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerowe/subscriptions","organizations_url":"https://api.github.com/users/jerowe/orgs","repos_url":"https://api.github.com/users/jerowe/repos","events_url":"https://api.github.com/users/jerowe/events{/privacy}","received_events_url":"https://api.github.com/users/jerowe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerowe/conda-env","description":"Provides a unified interface to dealing with Conda environments.","fork":true,"url":"https://api.github.com/repos/jerowe/conda-env","forks_url":"https://api.github.com/repos/jerowe/conda-env/forks","keys_url":"https://api.github.com/repos/jerowe/conda-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerowe/conda-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerowe/conda-env/teams","hooks_url":"https://api.github.com/repos/jerowe/conda-env/hooks","issue_events_url":"https://api.github.com/repos/jerowe/conda-env/issues/events{/number}","events_url":"https://api.github.com/repos/jerowe/conda-env/events","assignees_url":"https://api.github.com/repos/jerowe/conda-env/assignees{/user}","branches_url":"https://api.github.com/repos/jerowe/conda-env/branches{/branch}","tags_url":"https://api.github.com/repos/jerowe/conda-env/tags","blobs_url":"https://api.github.com/repos/jerowe/conda-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerowe/conda-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerowe/conda-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerowe/conda-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerowe/conda-env/statuses/{sha}","languages_url":"https://api.github.com/repos/jerowe/conda-env/languages","stargazers_url":"https://api.github.com/repos/jerowe/conda-env/stargazers","contributors_url":"https://api.github.com/repos/jerowe/conda-env/contributors","subscribers_url":"https://api.github.com/repos/jerowe/conda-env/subscribers","subscription_url":"https://api.github.com/repos/jerowe/conda-env/subscription","commits_url":"https://api.github.com/repos/jerowe/conda-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerowe/conda-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerowe/conda-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerowe/conda-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerowe/conda-env/contents/{+path}","compare_url":"https://api.github.com/repos/jerowe/conda-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerowe/conda-env/merges","archive_url":"https://api.github.com/repos/jerowe/conda-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerowe/conda-env/downloads","issues_url":"https://api.github.com/repos/jerowe/conda-env/issues{/number}","pulls_url":"https://api.github.com/repos/jerowe/conda-env/pulls{/number}","milestones_url":"https://api.github.com/repos/jerowe/conda-env/milestones{/number}","notifications_url":"https://api.github.com/repos/jerowe/conda-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerowe/conda-env/labels{/name}","releases_url":"https://api.github.com/repos/jerowe/conda-env/releases{/id}","deployments_url":"https://api.github.com/repos/jerowe/conda-env/deployments","created_at":"2016-05-31T08:01:00Z","updated_at":"2016-05-31T08:01:02Z","pushed_at":"2016-08-26T18:45:26Z","git_url":"git://github.com/jerowe/conda-env.git","ssh_url":"git@github.com:jerowe/conda-env.git","clone_url":"https://github.com/jerowe/conda-env.git","svn_url":"https://github.com/jerowe/conda-env","homepage":"","size":359,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conda:develop","ref":"develop","sha":"094dd27b1abef3b9468af7aa9767fbe5bd765465","user":{"login":"conda","id":6392739,"avatar_url":"https://avatars.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"repo":{"id":18802640,"name":"conda-env","full_name":"conda/conda-env","owner":{"login":"conda","id":6392739,"avatar_url":"https://avatars.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conda/conda-env","description":"Provides a unified interface to dealing with Conda environments.","fork":false,"url":"https://api.github.com/repos/conda/conda-env","forks_url":"https://api.github.com/repos/conda/conda-env/forks","keys_url":"https://api.github.com/repos/conda/conda-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda/conda-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda/conda-env/teams","hooks_url":"https://api.github.com/repos/conda/conda-env/hooks","issue_events_url":"https://api.github.com/repos/conda/conda-env/issues/events{/number}","events_url":"https://api.github.com/repos/conda/conda-env/events","assignees_url":"https://api.github.com/repos/conda/conda-env/assignees{/user}","branches_url":"https://api.github.com/repos/conda/conda-env/branches{/branch}","tags_url":"https://api.github.com/repos/conda/conda-env/tags","blobs_url":"https://api.github.com/repos/conda/conda-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda/conda-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda/conda-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda/conda-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda/conda-env/statuses/{sha}","languages_url":"https://api.github.com/repos/conda/conda-env/languages","stargazers_url":"https://api.github.com/repos/conda/conda-env/stargazers","contributors_url":"https://api.github.com/repos/conda/conda-env/contributors","subscribers_url":"https://api.github.com/repos/conda/conda-env/subscribers","subscription_url":"https://api.github.com/repos/conda/conda-env/subscription","commits_url":"https://api.github.com/repos/conda/conda-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda/conda-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda/conda-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda/conda-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda/conda-env/contents/{+path}","compare_url":"https://api.github.com/repos/conda/conda-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda/conda-env/merges","archive_url":"https://api.github.com/repos/conda/conda-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda/conda-env/downloads","issues_url":"https://api.github.com/repos/conda/conda-env/issues{/number}","pulls_url":"https://api.github.com/repos/conda/conda-env/pulls{/number}","milestones_url":"https://api.github.com/repos/conda/conda-env/milestones{/number}","notifications_url":"https://api.github.com/repos/conda/conda-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda/conda-env/labels{/name}","releases_url":"https://api.github.com/repos/conda/conda-env/releases{/id}","deployments_url":"https://api.github.com/repos/conda/conda-env/deployments","created_at":"2014-04-15T14:16:17Z","updated_at":"2016-08-08T22:18:50Z","pushed_at":"2016-08-26T18:45:27Z","git_url":"git://github.com/conda/conda-env.git","ssh_url":"git@github.com:conda/conda-env.git","clone_url":"https://github.com/conda/conda-env.git","svn_url":"https://github.com/conda/conda-env","homepage":"","size":430,"stargazers_count":60,"watchers_count":60,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":65,"forks":40,"open_issues":65,"watchers":60,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conda/conda-env/pulls/271"},"html":{"href":"https://github.com/conda/conda-env/pull/271"},"issue":{"href":"https://api.github.com/repos/conda/conda-env/issues/271"},"comments":{"href":"https://api.github.com/repos/conda/conda-env/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/conda/conda-env/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/conda/conda-env/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda/conda-env/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/conda/conda-env/statuses/78426c1dd4528a1cf7a443b67a7f941799f9c17b"}}}}
{"actor":{"display_login":"jerowe"}}