{"action":"created","issue":{"url":"https://api.github.com/repos/citra-emu/citra/issues/2185","repository_url":"https://api.github.com/repos/citra-emu/citra","labels_url":"https://api.github.com/repos/citra-emu/citra/issues/2185/labels{/name}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/2185/comments","events_url":"https://api.github.com/repos/citra-emu/citra/issues/2185/events","html_url":"https://github.com/citra-emu/citra/pull/2185","id":189974911,"number":2185,"title":"Change \"user\" folder default location to AppData/Roaming/ on Windows systems","user":{"login":"freiro","id":23333079,"avatar_url":"https://avatars.githubusercontent.com/u/23333079?v=3","gravatar_id":"","url":"https://api.github.com/users/freiro","html_url":"https://github.com/freiro","followers_url":"https://api.github.com/users/freiro/followers","following_url":"https://api.github.com/users/freiro/following{/other_user}","gists_url":"https://api.github.com/users/freiro/gists{/gist_id}","starred_url":"https://api.github.com/users/freiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freiro/subscriptions","organizations_url":"https://api.github.com/users/freiro/orgs","repos_url":"https://api.github.com/users/freiro/repos","events_url":"https://api.github.com/users/freiro/events{/privacy}","received_events_url":"https://api.github.com/users/freiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-11-17T08:31:06Z","updated_at":"2016-11-25T17:09:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/2185","html_url":"https://github.com/citra-emu/citra/pull/2185","diff_url":"https://github.com/citra-emu/citra/pull/2185.diff","patch_url":"https://github.com/citra-emu/citra/pull/2185.patch"},"body":"Hello, this is my first PR, I tried to address #2177 and move the default location of the \"user\" folder to AppData/Roaming/Citra Emulator/(*).\r\nIf there is a \"user\" folder next to citra executable, that folder will take priority (portable mode).\r\n\r\nConfiguration changes should be handled with care to avoid problems between different versions.\r\n\r\nAlso note that SHGetKnownFolderPath works only on Windows Vista and later.\r\n\r\nThanks to @linkmauve for the suggestions he gave me yesterday.\r\n\r\nLet me know what you think.\r\n\r\n(*) After a bit of discussion we decided for Roaming instead of Local."},"comment":{"url":"https://api.github.com/repos/citra-emu/citra/issues/comments/262999550","html_url":"https://github.com/citra-emu/citra/pull/2185#issuecomment-262999550","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/2185","id":262999550,"user":{"login":"jroweboy","id":952515,"avatar_url":"https://avatars.githubusercontent.com/u/952515?v=3","gravatar_id":"","url":"https://api.github.com/users/jroweboy","html_url":"https://github.com/jroweboy","followers_url":"https://api.github.com/users/jroweboy/followers","following_url":"https://api.github.com/users/jroweboy/following{/other_user}","gists_url":"https://api.github.com/users/jroweboy/gists{/gist_id}","starred_url":"https://api.github.com/users/jroweboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroweboy/subscriptions","organizations_url":"https://api.github.com/users/jroweboy/orgs","repos_url":"https://api.github.com/users/jroweboy/repos","events_url":"https://api.github.com/users/jroweboy/events{/privacy}","received_events_url":"https://api.github.com/users/jroweboy/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T17:09:25Z","updated_at":"2016-11-25T17:09:25Z","body":"Has this been tested in mingw builds yet? I looked up and saw that they were in the headers, but it'd be nice to know that it was tested in mingw64 first\r\n\r\nhttps://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-headers/include/combaseapi.h#L363\r\nhttps://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-headers/include/shlobj.h#L755\r\n\r\nOther than that LGTM"}}
{"actor":{"display_login":"jroweboy"}}