{"action":"created","comment":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/74463598","id":74463598,"diff_hunk":"@@ -170,41 +172,75 @@\n     }\n   </style>\n   <template>\n-    <div id=\"reg-area\">\n-      <!-- Cursor Controls -->\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"up down\"\n-                      on-keys-pressed=\"cursorMove\"></iron-a11y-keys>\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"right enter\"\n-                      on-keys-pressed=\"cursorTraverse\"></iron-a11y-keys>\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"left backspace\"\n-                      on-keys-pressed=\"cursorBack\"></iron-a11y-keys>\n-      <!-- Dialog Controls -->\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"esc\"\n-                      on-keys-pressed=\"dialogCancel\"></iron-a11y-keys>\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"shift+enter\"\n-                      on-keys-pressed=\"dialogSubmit\"></iron-a11y-keys>\n-      <!-- Search Controls -->\n-      <iron-a11y-keys target=\"[[target]]\" keys=\"enter\"\n-                      on-keys-pressed=\"searchSubmit\"></iron-a11y-keys>\n-      <table>\n-        <tbody is=\"selectable-table\" id=\"combinedList\" selected=\"{{selectedIdx}}\">\n-          <template id=\"fullList\" is=\"dom-repeat\" items=\"{{listItems}}\" filter=\"filterFunc\">\n-            <tr name=\"{{item.name}}\"\n+  <div id=\"outer\">\n+    <!-- Dialog Controls -->\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"esc\"\n+                    on-keys-pressed=\"dialogCancel\"></iron-a11y-keys>\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"shift+enter enter\"\n+                    on-keys-pressed=\"dialogSubmit\"></iron-a11y-keys>\n+    <!-- Cursor Controls -->\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"up down\"\n+                    on-keys-pressed=\"cursorMove\"></iron-a11y-keys>\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"right enter\"\n+                    on-keys-pressed=\"cursorTraverse\"></iron-a11y-keys>\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"left backspace\"\n+                    on-keys-pressed=\"cursorBack\"></iron-a11y-keys>\n+    <!-- Search Controls -->\n+    <iron-a11y-keys target=\"[[target]]\" keys=\"enter\"\n+                    on-keys-pressed=\"searchSubmit\"></iron-a11y-keys>\n+    <paper-header-panel id=\"left-column\">\n+      <div class=\"paper-header\" id=\"buttons\">\n+        <paper-toolbar>\n+          <paper-button on-click=\"newKeyClicked\">\n+            <iron-icon icon=\"create\"></iron-icon>\n+            new key\n+          </paper-button>\n+          <paper-button on-click=\"newFolderClicked\">\n+            <iron-icon icon=\"folder-open\"></iron-icon>\n+            new dir\n+          </paper-button>\n+          <paper-button on-click=\"copyClicked\" disabled=\"[[!selected]]\">\n+            <iron-icon icon=\"content-copy\"></iron-icon>\n+            copy\n+          </paper-button>\n+          <paper-button on-click=\"renameClicked\" disabled=\"[[!selected]]\">\n+            <iron-icon icon=\"code\"></iron-icon>\n+            rename\n+          </paper-button>\n+          <paper-button on-click=\"deleteClicked\" disabled=\"[[!selected]]\">\n+            <iron-icon icon=\"delete\"></iron-icon>\n+            delete\n+          </paper-button>\n+          <div id=\"search-bar\">\n+            <paper-input id=\"search\" value=\"{{filterText::input}}\"\n+              noLabelFloat>","path":"client-js/app/elements/labrad-registry.html","position":228,"original_position":228,"commit_id":"8e4f65523e9b2af0c78a715c66b86e127e5843c1","original_commit_id":"8e4f65523e9b2af0c78a715c66b86e127e5843c1","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"The hanging indents here are a bit inconsistent, sometimes using 4 spaces, here 2, and sometimes aligning with attribute on the first line. I think 4 spaces or aligned would be fine, but we should be consistent (at least within a single .html if not throughout the codebase).","created_at":"2016-08-11T17:17:31Z","updated_at":"2016-08-11T17:17:31Z","html_url":"https://github.com/labrad/scalabrad-web/pull/280#discussion_r74463598","pull_request_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280","_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/74463598"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/280#discussion_r74463598"},"pull_request":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280","id":80890328,"html_url":"https://github.com/labrad/scalabrad-web/pull/280","diff_url":"https://github.com/labrad/scalabrad-web/pull/280.diff","patch_url":"https://github.com/labrad/scalabrad-web/pull/280.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/280","number":280,"state":"open","locked":false,"title":"[#278] Change Registry to use iron-list.","user":{"login":"adamcw","id":153444,"avatar_url":"https://avatars.githubusercontent.com/u/153444?v=3","gravatar_id":"","url":"https://api.github.com/users/adamcw","html_url":"https://github.com/adamcw","followers_url":"https://api.github.com/users/adamcw/followers","following_url":"https://api.github.com/users/adamcw/following{/other_user}","gists_url":"https://api.github.com/users/adamcw/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcw/subscriptions","organizations_url":"https://api.github.com/users/adamcw/orgs","repos_url":"https://api.github.com/users/adamcw/repos","events_url":"https://api.github.com/users/adamcw/events{/privacy}","received_events_url":"https://api.github.com/users/adamcw/received_events","type":"User","site_admin":false},"body":"Implements #278. Updated/Refactored the Registry to use an `iron-list` instead of a `table` with `dom-repeat`. This allows for smooth scrolling on the registry when using keyboard controls.\r\n\r\nThis also refactored the code to get rid of all computed properties, as well as the last instance of the `kick` hack. Also fixed problems with submitting forms via hitting enter in text fields, or while OK is selected. In addition, various style guide compliance changes.","created_at":"2016-08-11T00:34:41Z","updated_at":"2016-08-11T17:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1a81416d46f3e282e63721369be0a8f8a7af78c","assignee":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"assignees":[{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/labrad/scalabrad-web/milestones/2","html_url":"https://github.com/labrad/scalabrad-web/milestones/v2.0","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones/2/labels","id":1856380,"number":2,"title":"v2.0","description":"Version 2.0 of Scalabrad-Web will have full feature parity with the Delphi grapher, as well as have all usability breaking bugs resolved.","creator":{"login":"adamcw","id":153444,"avatar_url":"https://avatars.githubusercontent.com/u/153444?v=3","gravatar_id":"","url":"https://api.github.com/users/adamcw","html_url":"https://github.com/adamcw","followers_url":"https://api.github.com/users/adamcw/followers","following_url":"https://api.github.com/users/adamcw/following{/other_user}","gists_url":"https://api.github.com/users/adamcw/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcw/subscriptions","organizations_url":"https://api.github.com/users/adamcw/orgs","repos_url":"https://api.github.com/users/adamcw/repos","events_url":"https://api.github.com/users/adamcw/events{/privacy}","received_events_url":"https://api.github.com/users/adamcw/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":28,"state":"open","created_at":"2016-06-29T23:38:47Z","updated_at":"2016-08-11T16:21:48Z","due_on":"2016-08-12T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/280/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/8e4f65523e9b2af0c78a715c66b86e127e5843c1","head":{"label":"labrad:278-registry-iron-list","ref":"278-registry-iron-list","sha":"8e4f65523e9b2af0c78a715c66b86e127e5843c1","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad-web/deployments","created_at":"2015-03-18T05:34:53Z","updated_at":"2016-08-01T21:37:48Z","pushed_at":"2016-08-11T16:21:51Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":1026,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":3,"default_branch":"master"}},"base":{"label":"labrad:master","ref":"master","sha":"09be71d7d90ffd4448104bf7671fb2bd42f5b381","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad-web/deployments","created_at":"2015-03-18T05:34:53Z","updated_at":"2016-08-01T21:37:48Z","pushed_at":"2016-08-11T16:21:51Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":1026,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/280"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/280"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad-web/statuses/8e4f65523e9b2af0c78a715c66b86e127e5843c1"}}}}
{"actor":{"display_login":"maffoo"}}