{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/skipper/pulls/comments/67671190","id":67671190,"diff_hunk":"@@ -213,6 +221,12 @@ func mapRequest(r *http.Request, rt *routing.Route, host string) (*http.Request,\n \tu.Scheme = rt.Scheme\n \tu.Host = rt.Host\n \n+\tbackendURL, err := url.Parse(rt.Backend)","path":"proxy/proxy.go","position":61,"original_position":45,"commit_id":"3cf2c35b0d762eb9ec79f974093a43056b556c25","original_commit_id":"ef68511cf81947a7d16ecb377b3f748d7c6650d8","user":{"login":"szuecs","id":50872,"avatar_url":"https://avatars.githubusercontent.com/u/50872?v=3","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"body":"I checked it again and you are right. We have not to copy the User from URL. I can drop the backendURL from mapRequest.","created_at":"2016-06-20T10:59:09Z","updated_at":"2016-06-20T10:59:09Z","html_url":"https://github.com/zalando/skipper/pull/167#discussion_r67671190","pull_request_url":"https://api.github.com/repos/zalando/skipper/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments/67671190"},"html":{"href":"https://github.com/zalando/skipper/pull/167#discussion_r67671190"},"pull_request":{"href":"https://api.github.com/repos/zalando/skipper/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/skipper/pulls/167","id":74264627,"html_url":"https://github.com/zalando/skipper/pull/167","diff_url":"https://github.com/zalando/skipper/pull/167.diff","patch_url":"https://github.com/zalando/skipper/pull/167.patch","issue_url":"https://api.github.com/repos/zalando/skipper/issues/167","number":167,"state":"open","locked":false,"title":"Feature handle upgrade requests","user":{"login":"szuecs","id":50872,"avatar_url":"https://avatars.githubusercontent.com/u/50872?v=3","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"body":"This PR adds feature from issue #159 ","created_at":"2016-06-17T15:51:40Z","updated_at":"2016-06-20T10:59:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cb6075c9ae7730fb4cd738c0355898dfc727b58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando/skipper/pulls/167/commits","review_comments_url":"https://api.github.com/repos/zalando/skipper/pulls/167/comments","review_comment_url":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/skipper/issues/167/comments","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/3cf2c35b0d762eb9ec79f974093a43056b556c25","head":{"label":"szuecs:feature/handle-spdy-upgrade-requests","ref":"feature/handle-spdy-upgrade-requests","sha":"3cf2c35b0d762eb9ec79f974093a43056b556c25","user":{"login":"szuecs","id":50872,"avatar_url":"https://avatars.githubusercontent.com/u/50872?v=3","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"repo":{"id":60361974,"name":"skipper","full_name":"szuecs/skipper","owner":{"login":"szuecs","id":50872,"avatar_url":"https://avatars.githubusercontent.com/u/50872?v=3","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szuecs/skipper","description":"An HTTP router, built with Go, that acts as a reverse proxy with support for custom route definitions","fork":true,"url":"https://api.github.com/repos/szuecs/skipper","forks_url":"https://api.github.com/repos/szuecs/skipper/forks","keys_url":"https://api.github.com/repos/szuecs/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szuecs/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szuecs/skipper/teams","hooks_url":"https://api.github.com/repos/szuecs/skipper/hooks","issue_events_url":"https://api.github.com/repos/szuecs/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/szuecs/skipper/events","assignees_url":"https://api.github.com/repos/szuecs/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/szuecs/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/szuecs/skipper/tags","blobs_url":"https://api.github.com/repos/szuecs/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szuecs/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szuecs/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/szuecs/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szuecs/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/szuecs/skipper/languages","stargazers_url":"https://api.github.com/repos/szuecs/skipper/stargazers","contributors_url":"https://api.github.com/repos/szuecs/skipper/contributors","subscribers_url":"https://api.github.com/repos/szuecs/skipper/subscribers","subscription_url":"https://api.github.com/repos/szuecs/skipper/subscription","commits_url":"https://api.github.com/repos/szuecs/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/szuecs/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/szuecs/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/szuecs/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/szuecs/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/szuecs/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szuecs/skipper/merges","archive_url":"https://api.github.com/repos/szuecs/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szuecs/skipper/downloads","issues_url":"https://api.github.com/repos/szuecs/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/szuecs/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/szuecs/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/szuecs/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szuecs/skipper/labels{/name}","releases_url":"https://api.github.com/repos/szuecs/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/szuecs/skipper/deployments","created_at":"2016-06-03T16:25:57Z","updated_at":"2016-06-03T16:25:58Z","pushed_at":"2016-06-20T10:37:29Z","git_url":"git://github.com/szuecs/skipper.git","ssh_url":"git@github.com:szuecs/skipper.git","clone_url":"https://github.com/szuecs/skipper.git","svn_url":"https://github.com/szuecs/skipper","homepage":"","size":4544,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"a671bbefd9603f120ce7ee5e5b00474e72f574ce","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38812664,"name":"skipper","full_name":"zalando/skipper","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/skipper","description":"An HTTP router, built with Go, that acts as a reverse proxy with support for custom route definitions","fork":false,"url":"https://api.github.com/repos/zalando/skipper","forks_url":"https://api.github.com/repos/zalando/skipper/forks","keys_url":"https://api.github.com/repos/zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/skipper/teams","hooks_url":"https://api.github.com/repos/zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/skipper/events","assignees_url":"https://api.github.com/repos/zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/skipper/tags","blobs_url":"https://api.github.com/repos/zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/zalando/skipper/subscription","commits_url":"https://api.github.com/repos/zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/skipper/merges","archive_url":"https://api.github.com/repos/zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/skipper/downloads","issues_url":"https://api.github.com/repos/zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/skipper/deployments","created_at":"2015-07-09T09:54:40Z","updated_at":"2016-06-20T08:25:59Z","pushed_at":"2016-06-20T10:37:30Z","git_url":"git://github.com/zalando/skipper.git","ssh_url":"git@github.com:zalando/skipper.git","clone_url":"https://github.com/zalando/skipper.git","svn_url":"https://github.com/zalando/skipper","homepage":"","size":4643,"stargazers_count":159,"watchers_count":159,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":35,"forks":18,"open_issues":35,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/167"},"html":{"href":"https://github.com/zalando/skipper/pull/167"},"issue":{"href":"https://api.github.com/repos/zalando/skipper/issues/167"},"comments":{"href":"https://api.github.com/repos/zalando/skipper/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/skipper/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/skipper/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/skipper/statuses/3cf2c35b0d762eb9ec79f974093a43056b556c25"}}}}
{"actor":{"display_login":"szuecs"}}