{"action":"opened","number":55,"pull_request":{"url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55","id":66704365,"html_url":"https://github.com/18F/concourse-compliance-testing/pull/55","diff_url":"https://github.com/18F/concourse-compliance-testing/pull/55.diff","patch_url":"https://github.com/18F/concourse-compliance-testing/pull/55.patch","issue_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/55","number":55,"state":"open","locked":false,"title":"[wip] Slack on change only","user":{"login":"ctro","id":11878,"avatar_url":"https://avatars.githubusercontent.com/u/11878?v=3","gravatar_id":"","url":"https://api.github.com/users/ctro","html_url":"https://github.com/ctro","followers_url":"https://api.github.com/users/ctro/followers","following_url":"https://api.github.com/users/ctro/following{/other_user}","gists_url":"https://api.github.com/users/ctro/gists{/gist_id}","starred_url":"https://api.github.com/users/ctro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctro/subscriptions","organizations_url":"https://api.github.com/users/ctro/orgs","repos_url":"https://api.github.com/users/ctro/repos","events_url":"https://api.github.com/users/ctro/events{/privacy}","received_events_url":"https://api.github.com/users/ctro/received_events","type":"User","site_admin":false},"body":"OK, I did a thing.\r\n\r\nI wanted to see how much more readable the summary code would be if I class-ified it.  Turns out it's way more readable :)  Need to stop watching Rich Hickey talks.\r\n\r\nThen I made Slack notify on change only, which was as simple as NOT writing a summary.txt file if there was no change.  This is not (yet?) configurable at all.\r\n\r\nTHEN I ran into the \"NO CHANGE\" bug and realized it was related to OpenOpps not having any zap issues.  So I changed the way that is handled.  I'm still not sure if OpenOpps _really does_ have 0 zap issues, or if zap is zapping out.\r\n\r\n\r\nTons of RED/GREEN here :(  But not really huge changes.\r\n\r\nRelates to \r\nhttps://trello.com/c/UnfzMVR9/111-a-user-should-be-able-to-configure-slack-notification-presence-frequency-and-options\r\nand\r\nhttps://trello.com/c/y63dRvhw/133-investigate-c2-scans-always-showing-as-new-results\r\n\r\nPosting for feedback now, I can get back to this next week.\r\nAlso, could merge Aidan's S3 thing first and I could deal with whatever merge needs to be done here.","created_at":"2016-04-15T21:01:34Z","updated_at":"2016-04-15T21:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55/commits","review_comments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55/comments","review_comment_url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/55/comments","statuses_url":"https://api.github.com/repos/18F/concourse-compliance-testing/statuses/6e5372b4db250bc8ed7eab722d6c022eba8f6ba3","head":{"label":"18F:slack-on-change","ref":"slack-on-change","sha":"6e5372b4db250bc8ed7eab722d6c022eba8f6ba3","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":48853336,"name":"concourse-compliance-testing","full_name":"18F/concourse-compliance-testing","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/concourse-compliance-testing","description":"Concourse.CI assets for compliance toolkit.","fork":false,"url":"https://api.github.com/repos/18F/concourse-compliance-testing","forks_url":"https://api.github.com/repos/18F/concourse-compliance-testing/forks","keys_url":"https://api.github.com/repos/18F/concourse-compliance-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/concourse-compliance-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/concourse-compliance-testing/teams","hooks_url":"https://api.github.com/repos/18F/concourse-compliance-testing/hooks","issue_events_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/events{/number}","events_url":"https://api.github.com/repos/18F/concourse-compliance-testing/events","assignees_url":"https://api.github.com/repos/18F/concourse-compliance-testing/assignees{/user}","branches_url":"https://api.github.com/repos/18F/concourse-compliance-testing/branches{/branch}","tags_url":"https://api.github.com/repos/18F/concourse-compliance-testing/tags","blobs_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/concourse-compliance-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/concourse-compliance-testing/languages","stargazers_url":"https://api.github.com/repos/18F/concourse-compliance-testing/stargazers","contributors_url":"https://api.github.com/repos/18F/concourse-compliance-testing/contributors","subscribers_url":"https://api.github.com/repos/18F/concourse-compliance-testing/subscribers","subscription_url":"https://api.github.com/repos/18F/concourse-compliance-testing/subscription","commits_url":"https://api.github.com/repos/18F/concourse-compliance-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/concourse-compliance-testing/contents/{+path}","compare_url":"https://api.github.com/repos/18F/concourse-compliance-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/concourse-compliance-testing/merges","archive_url":"https://api.github.com/repos/18F/concourse-compliance-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/concourse-compliance-testing/downloads","issues_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues{/number}","pulls_url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/concourse-compliance-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/concourse-compliance-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/concourse-compliance-testing/labels{/name}","releases_url":"https://api.github.com/repos/18F/concourse-compliance-testing/releases{/id}","deployments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/deployments","created_at":"2015-12-31T15:15:03Z","updated_at":"2016-03-28T19:27:19Z","pushed_at":"2016-04-15T20:58:27Z","git_url":"git://github.com/18F/concourse-compliance-testing.git","ssh_url":"git@github.com:18F/concourse-compliance-testing.git","clone_url":"https://github.com/18F/concourse-compliance-testing.git","svn_url":"https://github.com/18F/concourse-compliance-testing","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"9bd27272a014eaa4ee08a0810fe43074c97c5ce4","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":48853336,"name":"concourse-compliance-testing","full_name":"18F/concourse-compliance-testing","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/concourse-compliance-testing","description":"Concourse.CI assets for compliance toolkit.","fork":false,"url":"https://api.github.com/repos/18F/concourse-compliance-testing","forks_url":"https://api.github.com/repos/18F/concourse-compliance-testing/forks","keys_url":"https://api.github.com/repos/18F/concourse-compliance-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/concourse-compliance-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/concourse-compliance-testing/teams","hooks_url":"https://api.github.com/repos/18F/concourse-compliance-testing/hooks","issue_events_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/events{/number}","events_url":"https://api.github.com/repos/18F/concourse-compliance-testing/events","assignees_url":"https://api.github.com/repos/18F/concourse-compliance-testing/assignees{/user}","branches_url":"https://api.github.com/repos/18F/concourse-compliance-testing/branches{/branch}","tags_url":"https://api.github.com/repos/18F/concourse-compliance-testing/tags","blobs_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/concourse-compliance-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/concourse-compliance-testing/languages","stargazers_url":"https://api.github.com/repos/18F/concourse-compliance-testing/stargazers","contributors_url":"https://api.github.com/repos/18F/concourse-compliance-testing/contributors","subscribers_url":"https://api.github.com/repos/18F/concourse-compliance-testing/subscribers","subscription_url":"https://api.github.com/repos/18F/concourse-compliance-testing/subscription","commits_url":"https://api.github.com/repos/18F/concourse-compliance-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/concourse-compliance-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/concourse-compliance-testing/contents/{+path}","compare_url":"https://api.github.com/repos/18F/concourse-compliance-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/concourse-compliance-testing/merges","archive_url":"https://api.github.com/repos/18F/concourse-compliance-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/concourse-compliance-testing/downloads","issues_url":"https://api.github.com/repos/18F/concourse-compliance-testing/issues{/number}","pulls_url":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/concourse-compliance-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/concourse-compliance-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/concourse-compliance-testing/labels{/name}","releases_url":"https://api.github.com/repos/18F/concourse-compliance-testing/releases{/id}","deployments_url":"https://api.github.com/repos/18F/concourse-compliance-testing/deployments","created_at":"2015-12-31T15:15:03Z","updated_at":"2016-03-28T19:27:19Z","pushed_at":"2016-04-15T20:58:27Z","git_url":"git://github.com/18F/concourse-compliance-testing.git","ssh_url":"git@github.com:18F/concourse-compliance-testing.git","clone_url":"https://github.com/18F/concourse-compliance-testing.git","svn_url":"https://github.com/18F/concourse-compliance-testing","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55"},"html":{"href":"https://github.com/18F/concourse-compliance-testing/pull/55"},"issue":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/55"},"comments":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/18F/concourse-compliance-testing/statuses/6e5372b4db250bc8ed7eab722d6c022eba8f6ba3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":190,"deletions":117,"changed_files":14}}