{"push_id":1218996975,"size":8,"distinct_size":8,"ref":"refs/heads/master","head":"82fda58bc3fbe21e0ff609e84d625a38e8f6cca3","before":"c8091d92d5258afee017506ebac086da2f99ee91","commits":[{"sha":"a733551846bcb2c7f46cc68bbc2e5741e653fbef","author":{"name":"Zbigniew Jędrzejewski-Szmek","email":"77dc704bc81310147658033dcc63fa6fb3a4d704@in.waw.pl"},"message":"systemctl: use cleanup function for UnitStatusInfo\n\nThere is no functional change, but clarity of the code is increased\nby splitting out the cleanup part and putting it next to the structure\ndefinition.","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/a733551846bcb2c7f46cc68bbc2e5741e653fbef"},{"sha":"662bea6729d4147dfdd1501f81335adf5a2a6012","author":{"name":"Zbigniew Jędrzejewski-Szmek","email":"77dc704bc81310147658033dcc63fa6fb3a4d704@in.waw.pl"},"message":"systemctl: avoid \"leaking\" some strings in UnitStatusInfo\n\n% valgrind --leak-check=full systemctl status multipathd.service --no-pager -n0\n...\n==431== 16 bytes in 2 blocks are definitely lost in loss record 1 of 2\n==431==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)\n==431==    by 0x534AF19: strdup (in /usr/lib64/libc-2.23.so)\n==431==    by 0x4E81AEE: free_and_strdup (string-util.c:794)\n==431==    by 0x4EF66C1: map_basic (bus-util.c:1030)\n==431==    by 0x4EF6A8E: bus_message_map_all_properties (bus-util.c:1153)\n==431==    by 0x120487: show_one (systemctl.c:4672)\n==431==    by 0x1218F3: show (systemctl.c:4990)\n==431==    by 0x4EC359E: dispatch_verb (verbs.c:92)\n==431==    by 0x12A3AE: systemctl_main (systemctl.c:7742)\n==431==    by 0x12B1A8: main (systemctl.c:8011)\n==431==\n==431== LEAK SUMMARY:\n==431==    definitely lost: 16 bytes in 2 blocks\n\nThis happens because map_basic() strdups the strings. Other code in systemctl\nassigns strings to UnitStatusInfo without copying them, relying on the fact\nthat the message is longer lived than UnitStatusInfo. Add a helper function\nthat is similar to map_basic, but only accepts strings and does not copy them.\nThe alternative of continuing to use map_basic() but adding proper cleanup\nto free fields in UnitStatusInfo seems less attractive because it'd require\nchanging a lot of code and doing a lot of more allocations for little gain.\n\n(I put \"leaking\" in quotes, because systemctl is short lived anyway.)","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/662bea6729d4147dfdd1501f81335adf5a2a6012"},{"sha":"f8654baa084e8888bc5ba11e8ef3d9784f955cff","author":{"name":"Zbigniew Jędrzejewski-Szmek","email":"77dc704bc81310147658033dcc63fa6fb3a4d704@in.waw.pl"},"message":"systemctl: simplify machine_info_clear\n\nIt is only used with info allocated on the stack, so the pointer cannot be\nNULL.","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/f8654baa084e8888bc5ba11e8ef3d9784f955cff"},{"sha":"9bb7194019ab62b85f76df2be207d3dac58ed726","author":{"name":"Zbigniew Jędrzejewski-Szmek","email":"77dc704bc81310147658033dcc63fa6fb3a4d704@in.waw.pl"},"message":"systemctl: use _cleanup_ for UnitCondition","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/9bb7194019ab62b85f76df2be207d3dac58ed726"},{"sha":"2de0b9e913823d6e564ea82d80d014451c238f20","author":{"name":"Michael Olbrich","email":"b115ee42ae0b566c855cdfcbba944b18d6b96798@pengutronix.de"},"message":"transaction: don't cancel jobs for units with IgnoreOnIsolate=true (#3671)\n\nThis is important if a job was queued for a unit but not yet started.\r\nWithout this, the job will be canceled and is never executed even though\r\nIgnoreOnIsolate it set to 'true'.","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/2de0b9e913823d6e564ea82d80d014451c238f20"},{"sha":"87d41d6244f1eaf441769f7f6216a606c52b8e89","author":{"name":"Michael Olbrich","email":"b115ee42ae0b566c855cdfcbba944b18d6b96798@pengutronix.de"},"message":"automount: don't cancel mount/umount request on reload/reexec (#3670)\n\nAll pending tokens are already serialized correctly and will be handled\r\nwhen the mount unit is done.\r\n\r\nWithout this a 'daemon-reload' cancels all pending tokens. Any process\r\nwaiting for the mount will continue with EHOSTDOWN.\r\nThis can happen when the mount unit waits for it's dependencies, e.g.\r\nnetwork, devices, fsck, etc.","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/87d41d6244f1eaf441769f7f6216a606c52b8e89"},{"sha":"91c8861526816be8e19c52f8ef5339a4eca5573e","author":{"name":"Lennart Poettering","email":"2baa8fca698523d252842633f852b9ab3cfeddbc@poettering.net"},"message":"man: extend documentation on the SplitMode= setting (#3801)\n\nAdressing https://github.com/systemd/systemd/issues/3755#issuecomment-234214273","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/91c8861526816be8e19c52f8ef5339a4eca5573e"},{"sha":"82fda58bc3fbe21e0ff609e84d625a38e8f6cca3","author":{"name":"Lennart Poettering","email":"2baa8fca698523d252842633f852b9ab3cfeddbc@poettering.net"},"message":"Merge pull request #3800 from keszybz/systemctl-more-cleanup\n\nSystemctl more cleanup","distinct":true,"url":"https://api.github.com/repos/systemd-mailing-devs/systemd-mailing-list/commits/82fda58bc3fbe21e0ff609e84d625a38e8f6cca3"}]}
{"actor":{"display_login":"surfsite-github-bot"}}