{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/83156640","pull_request_review_id":4015524,"id":83156640,"diff_hunk":"@@ -229,12 +231,12 @@ double PDFFourierTransform::determineRho0() {\n void PDFFourierTransform::exec() {\n   // get input data\n   API::MatrixWorkspace_const_sptr inputWS = getProperty(\"InputWorkspace\");\n-  MantidVec inputQ = inputWS->dataX(0);                   //  x for input\n+  auto inputQ = inputWS->x(0).rawData();                    //  x for input\n   HistogramData::HistogramDx inputDQ(inputQ.size(), 0.0); // dx for input\n   if (inputWS->sharedDx(0))\n     inputDQ = inputWS->dx(0);\n-  MantidVec inputFOfQ = inputWS->dataY(0);  //  y for input\n-  MantidVec inputDfOfQ = inputWS->dataE(0); // dy for input\n+  auto inputFOfQ = inputWS->y(0).rawData();  //  y for input\n+  auto inputDfOfQ = inputWS->e(0).rawData(); // dy for input","path":"Framework/Algorithms/src/PDFFourierTransform.cpp","position":28,"original_position":28,"commit_id":"af487e6a9610c87095538d45d32815cc09ba0b36","original_commit_id":"6c63885c14dbd0d29ec5c0d8aa57558c0e0b49a4","user":{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars.githubusercontent.com/u/15360272?v=3","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false},"body":"If it would be helpful I can try running both your changes on my machine to see if I come up with the same issue\r\n","created_at":"2016-10-13T07:24:18Z","updated_at":"2016-10-13T07:24:18Z","html_url":"https://github.com/mantidproject/mantid/pull/17724#discussion_r83156640","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17724","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/83156640"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17724#discussion_r83156640"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17724"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17724","id":88263151,"html_url":"https://github.com/mantidproject/mantid/pull/17724","diff_url":"https://github.com/mantidproject/mantid/pull/17724.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17724.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17724","number":17724,"state":"open","locked":false,"title":"HistogramData rollout: algorithms 1 to 5","user":{"login":"PranavBahuguna","id":10980962,"avatar_url":"https://avatars.githubusercontent.com/u/10980962?v=3","gravatar_id":"","url":"https://api.github.com/users/PranavBahuguna","html_url":"https://github.com/PranavBahuguna","followers_url":"https://api.github.com/users/PranavBahuguna/followers","following_url":"https://api.github.com/users/PranavBahuguna/following{/other_user}","gists_url":"https://api.github.com/users/PranavBahuguna/gists{/gist_id}","starred_url":"https://api.github.com/users/PranavBahuguna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PranavBahuguna/subscriptions","organizations_url":"https://api.github.com/users/PranavBahuguna/orgs","repos_url":"https://api.github.com/users/PranavBahuguna/repos","events_url":"https://api.github.com/users/PranavBahuguna/events{/privacy}","received_events_url":"https://api.github.com/users/PranavBahuguna/received_events","type":"User","site_admin":false},"body":"## Description of work.\r\n\r\nThis PR is part of refactoring effort to use the new interface of the HistogramData module.\r\nSee https://github.com/mantidproject/mantid/issues/17641 for details.\r\n\r\nThe following algorithms were refactored to use HistogramData:\r\n- Framework/Algorithms/src/PDCalibration.cpp\r\n- Framework/Algorithms/src/PDFFourierTransform.cpp\r\n- Framework/Algorithms/src/PhaseQuadMuon.cpp\r\n- Framework/Algorithms/src/PlotAsymmetryByLogValue.cpp\r\n- Framework/Algorithms/src/PointByPointVCorrection.cpp\r\n\r\nPerformance tests were added for:\r\n- Framework/Algorithms/test/PDCalibrationTest.h\r\n- Framework/Algorithms/test/PDFFourierTransformTest.h\r\n- Framework/Algorithms/test/PhaseQuadMuonTest.h\r\n- Framework/Algorithms/test/PlotAsymmetryByLogValueTest.h\r\n- Framework/Algorithms/test/PointByPointVCorrectionTest.h\r\n\r\nNone of the algorithms have significantly improved performance. Unfortunately for PDFFourierTransform, the performance actually decreased when variables `inputQ`, `inputFOfQ` and `inputDfOfQ` were replaced with their HistogramData equivalents. Any insight into why their performance decreased would be well appreciated.\r\n\r\n## To test.\r\n\r\nCode review.\r\n\r\nFixes #17644.\r\nInternal change, no release notes (potential performance improvements will be added to release notes as part of the umbrella issue).\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-10-06T13:37:09Z","updated_at":"2016-10-13T07:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ad4371bfb33c18ffa0015cedaa3b8812507ae59","assignee":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17724/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17724/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17724/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/af487e6a9610c87095538d45d32815cc09ba0b36","head":{"label":"mantidproject:17644_HistogramData_Rollout_algs_1_to_5","ref":"17644_HistogramData_Rollout_algs_1_to_5","sha":"af487e6a9610c87095538d45d32815cc09ba0b36","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-09-22T17:47:32Z","pushed_at":"2016-10-13T01:37:06Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":444891,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":1644,"forks":37,"open_issues":1644,"watchers":46,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"210ce337c26131e52c1a529db5ea1250cebb18cd","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-09-22T17:47:32Z","pushed_at":"2016-10-13T01:37:06Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":444891,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":1644,"forks":37,"open_issues":1644,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17724"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17724"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17724"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17724/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17724/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17724/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/af487e6a9610c87095538d45d32815cc09ba0b36"}}}}
{"actor":{"display_login":"LamarMoore"}}