{"action":"created","comment":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/74282705","id":74282705,"diff_hunk":"@@ -192,10 +193,13 @@ def annotate_frame(i):\n             axes.set_ylabel(ylabel)\n \n         if resample:\n-            # This assumes that the maps are homogeneous!\n-            # TODO: Update this!\n-            resample = np.array(len(self.maps)-1) * np.array(resample)\n-            ani_data = [x.resample(resample) for x in self.maps]\n+            if self.all_maps_same_shape():\n+                resample = u.Quantity(self.maps[0].dimensions) * np.array(resample)\n+                ani_data = []\n+                for amap in self.maps:\n+                    ani_data.append(amap.resample(resample))","path":"sunpy/map/mapcube.py","position":32,"original_position":32,"commit_id":"d410dea71b15982f77f1c76e22f5364de68c5f44","original_commit_id":"d410dea71b15982f77f1c76e22f5364de68c5f44","user":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"body":"Think I adapted it from below with the `.append`","created_at":"2016-08-10T16:46:30Z","updated_at":"2016-08-10T16:46:30Z","html_url":"https://github.com/sunpy/sunpy/pull/1867#discussion_r74282705","pull_request_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1867","_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/74282705"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1867#discussion_r74282705"},"pull_request":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1867"}}},"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1867","id":80081656,"html_url":"https://github.com/sunpy/sunpy/pull/1867","diff_url":"https://github.com/sunpy/sunpy/pull/1867.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1867.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1867","number":1867,"state":"open","locked":false,"title":"Correctly calculate resample for mapcube plotting.","user":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-04T13:50:55Z","updated_at":"2016-08-10T16:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47a62a8501a28afb5f38ff6654c0dcf19b1c05c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1867/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1867/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1867/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/d410dea71b15982f77f1c76e22f5364de68c5f44","head":{"label":"Cadair:mapcube_resample","ref":"mapcube_resample","sha":"d410dea71b15982f77f1c76e22f5364de68c5f44","user":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"repo":{"id":4972804,"name":"sunpy","full_name":"Cadair/sunpy","owner":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cadair/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/Cadair/sunpy","forks_url":"https://api.github.com/repos/Cadair/sunpy/forks","keys_url":"https://api.github.com/repos/Cadair/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadair/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadair/sunpy/teams","hooks_url":"https://api.github.com/repos/Cadair/sunpy/hooks","issue_events_url":"https://api.github.com/repos/Cadair/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/Cadair/sunpy/events","assignees_url":"https://api.github.com/repos/Cadair/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/Cadair/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/Cadair/sunpy/tags","blobs_url":"https://api.github.com/repos/Cadair/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadair/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadair/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadair/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadair/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadair/sunpy/languages","stargazers_url":"https://api.github.com/repos/Cadair/sunpy/stargazers","contributors_url":"https://api.github.com/repos/Cadair/sunpy/contributors","subscribers_url":"https://api.github.com/repos/Cadair/sunpy/subscribers","subscription_url":"https://api.github.com/repos/Cadair/sunpy/subscription","commits_url":"https://api.github.com/repos/Cadair/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadair/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadair/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadair/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadair/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/Cadair/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadair/sunpy/merges","archive_url":"https://api.github.com/repos/Cadair/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadair/sunpy/downloads","issues_url":"https://api.github.com/repos/Cadair/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/Cadair/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadair/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadair/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadair/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/Cadair/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/Cadair/sunpy/deployments","created_at":"2012-07-10T11:15:45Z","updated_at":"2015-04-30T16:12:04Z","pushed_at":"2016-08-10T16:20:06Z","git_url":"git://github.com/Cadair/sunpy.git","ssh_url":"git@github.com:Cadair/sunpy.git","clone_url":"https://github.com/Cadair/sunpy.git","svn_url":"https://github.com/Cadair/sunpy","homepage":"http://www.sunpy.org","size":50902,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"a17ae21d1b97900c7c20daa3eb902fd08a22d653","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for Solar Physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/sunpy/sunpy/deployments","created_at":"2011-08-06T15:34:08Z","updated_at":"2016-08-07T04:39:58Z","pushed_at":"2016-08-10T16:37:19Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":145195,"stargazers_count":233,"watchers_count":233,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":278,"forks":163,"open_issues":278,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1867"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1867"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1867"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1867/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1867/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1867/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/d410dea71b15982f77f1c76e22f5364de68c5f44"}}}}
{"actor":{"display_login":"Cadair"}}