{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/57907422","id":57907422,"diff_hunk":"@@ -380,6 +380,30 @@ RCP<const Basic> mul(const RCP<const Basic> &a, const RCP<const Basic> &b)\n     return Mul::from_dict(coef, std::move(d));\n }\n \n+RCP<const Basic> mul(const vec_basic &a)\n+{\n+    SymEngine::map_basic_basic d;\n+    RCP<const Number> coef = one;\n+    for(const auto &i: a) {\n+        if (is_a<Mul>(*i)) {\n+            RCP<const Basic> exp;\n+            RCP<const Basic> t;","path":"symengine/mul.cpp","position":11,"original_position":11,"commit_id":"2183fbf917b2857aca2aec35edba8b2d78e38e82","original_commit_id":"2183fbf917b2857aca2aec35edba8b2d78e38e82","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"These variables are not used","created_at":"2016-03-30T15:22:28Z","updated_at":"2016-03-30T15:22:28Z","html_url":"https://github.com/symengine/symengine/pull/892#discussion_r57907422","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/892","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/57907422"},"html":{"href":"https://github.com/symengine/symengine/pull/892#discussion_r57907422"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/892","id":64539475,"html_url":"https://github.com/symengine/symengine/pull/892","diff_url":"https://github.com/symengine/symengine/pull/892.diff","patch_url":"https://github.com/symengine/symengine/pull/892.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/892","number":892,"state":"open","locked":false,"title":"Added add and mul of vec_basic","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"body":"Addresses #885 \r\nAlong with *Method to add a vector of basic together*, I extended it to `mul` also. \r\nPing @abinashmeher999 @isuruf ","created_at":"2016-03-29T21:46:32Z","updated_at":"2016-03-30T15:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a7198c346b132590cf6375f862f1c8057bd638b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/892/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/892/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/892/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/2183fbf917b2857aca2aec35edba8b2d78e38e82","head":{"label":"nishnik:add_vec","ref":"add_vec","sha":"2183fbf917b2857aca2aec35edba8b2d78e38e82","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"repo":{"id":51446468,"name":"symengine","full_name":"nishnik/symengine","owner":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nishnik/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/nishnik/symengine","forks_url":"https://api.github.com/repos/nishnik/symengine/forks","keys_url":"https://api.github.com/repos/nishnik/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishnik/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishnik/symengine/teams","hooks_url":"https://api.github.com/repos/nishnik/symengine/hooks","issue_events_url":"https://api.github.com/repos/nishnik/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/nishnik/symengine/events","assignees_url":"https://api.github.com/repos/nishnik/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/nishnik/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/nishnik/symengine/tags","blobs_url":"https://api.github.com/repos/nishnik/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishnik/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishnik/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishnik/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishnik/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/nishnik/symengine/languages","stargazers_url":"https://api.github.com/repos/nishnik/symengine/stargazers","contributors_url":"https://api.github.com/repos/nishnik/symengine/contributors","subscribers_url":"https://api.github.com/repos/nishnik/symengine/subscribers","subscription_url":"https://api.github.com/repos/nishnik/symengine/subscription","commits_url":"https://api.github.com/repos/nishnik/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishnik/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishnik/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishnik/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishnik/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/nishnik/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishnik/symengine/merges","archive_url":"https://api.github.com/repos/nishnik/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishnik/symengine/downloads","issues_url":"https://api.github.com/repos/nishnik/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/nishnik/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/nishnik/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/nishnik/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishnik/symengine/labels{/name}","releases_url":"https://api.github.com/repos/nishnik/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/nishnik/symengine/deployments","created_at":"2016-02-10T14:35:30Z","updated_at":"2016-02-10T14:35:32Z","pushed_at":"2016-03-30T12:49:05Z","git_url":"git://github.com/nishnik/symengine.git","ssh_url":"git@github.com:nishnik/symengine.git","clone_url":"https://github.com/nishnik/symengine.git","svn_url":"https://github.com/nishnik/symengine","homepage":"http://sympy.org","size":4539,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"ad7cfccb2c10076cfe713c5b39695df98d9c0f42","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-03-26T23:00:07Z","pushed_at":"2016-03-30T12:49:06Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":34260,"stargazers_count":129,"watchers_count":129,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":96,"forks":100,"open_issues":96,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/892"},"html":{"href":"https://github.com/symengine/symengine/pull/892"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/892"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/2183fbf917b2857aca2aec35edba8b2d78e38e82"}}}}