{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16990","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16990/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16990/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16990/events","html_url":"https://github.com/mantidproject/mantid/pull/16990","id":167057628,"number":16990,"title":"Indirect Simulations SimulatedDensityOfStates - Allow algorithm to parse isotopes","user":{"login":"ElliotAOram","id":13132128,"avatar_url":"https://avatars.githubusercontent.com/u/13132128?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliotAOram","html_url":"https://github.com/ElliotAOram","followers_url":"https://api.github.com/users/ElliotAOram/followers","following_url":"https://api.github.com/users/ElliotAOram/following{/other_user}","gists_url":"https://api.github.com/users/ElliotAOram/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliotAOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliotAOram/subscriptions","organizations_url":"https://api.github.com/users/ElliotAOram/orgs","repos_url":"https://api.github.com/users/ElliotAOram/repos","events_url":"https://api.github.com/users/ElliotAOram/events{/privacy}","received_events_url":"https://api.github.com/users/ElliotAOram/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Indirect%20Inelastic","name":"Component: Indirect Inelastic","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"assignees":[{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},{"login":"samueljackson92","id":2487781,"avatar_url":"https://avatars.githubusercontent.com/u/2487781?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljackson92","html_url":"https://github.com/samueljackson92","followers_url":"https://api.github.com/users/samueljackson92/followers","following_url":"https://api.github.com/users/samueljackson92/following{/other_user}","gists_url":"https://api.github.com/users/samueljackson92/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljackson92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljackson92/subscriptions","organizations_url":"https://api.github.com/users/samueljackson92/orgs","repos_url":"https://api.github.com/users/samueljackson92/repos","events_url":"https://api.github.com/users/samueljackson92/events{/privacy}","received_events_url":"https://api.github.com/users/samueljackson92/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":706,"closed_issues":475,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-02T08:23:07Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":4,"created_at":"2016-07-22T14:28:48Z","updated_at":"2016-08-02T08:38:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16990","html_url":"https://github.com/mantidproject/mantid/pull/16990","diff_url":"https://github.com/mantidproject/mantid/pull/16990.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16990.patch"},"body":"The SimulatedDensityOfStates algorithm should now be able to parse isotopes in the format `element:isotope` correctly. A new test case for this has been added to the unit test and a new test file has also been added. \r\n\r\n**To test:**\r\n\r\n* Download the new test file from by building the unit test data\r\n* Run the following script:\r\n```\r\nisotope_phonon = 'test_isotopes.phonon'\r\nwks_group = SimulatedDensityOfStates(PHONONFile=isotope_phonon, SpectrumType='DOS', Ions='H:P,C:P,O')\r\n```\r\n* Ensure that the output workspace group contains three workspaces named `H(2)`, `C(13)` and `O`\r\n* Each workspace should have 2 spectra (Workspace index 0 = `Guassian`, Workspace index 1 = `Stick`)\r\n* Check the sample materials on each workspace to ensure the sample material has been correctly set to the isotope of the element *you can use the [NIST table](https://www.ncnr.nist.gov/resources/n-lengths/list.html) to ensure scatter cross section are correct*\r\n\r\nFixes #16981\r\n\r\n[RELEASE NOTES](https://github.com/mantidproject/mantid/blob/40c0e9c6f35db398a25a2566d2cf7fd7d1f868c4/docs/source/release/v3.8.0/indirect_inelastic.rst)\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/236840595","html_url":"https://github.com/mantidproject/mantid/pull/16990#issuecomment-236840595","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16990","id":236840595,"user":{"login":"samueljackson92","id":2487781,"avatar_url":"https://avatars.githubusercontent.com/u/2487781?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljackson92","html_url":"https://github.com/samueljackson92","followers_url":"https://api.github.com/users/samueljackson92/followers","following_url":"https://api.github.com/users/samueljackson92/following{/other_user}","gists_url":"https://api.github.com/users/samueljackson92/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljackson92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljackson92/subscriptions","organizations_url":"https://api.github.com/users/samueljackson92/orgs","repos_url":"https://api.github.com/users/samueljackson92/repos","events_url":"https://api.github.com/users/samueljackson92/events{/privacy}","received_events_url":"https://api.github.com/users/samueljackson92/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T08:38:09Z","updated_at":"2016-08-02T08:38:09Z","body":"Perhaps a little picky, but the ```pyexec``` method for this is getting long. Perhaps each of the sections inside the if statement could be moved to separate functions? I would maybe add that as a separate refactor ticket though."}}
{"actor":{"display_login":"samueljackson92"}}