{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/87126464","pull_request_review_id":7750589,"id":87126464,"diff_hunk":"@@ -71,17 +73,22 @@ RECOVERY_ISO_IMAGE=${11}\n     exit 1\n }\n if [ \"$UEFI_ENABLE\" = \"yes\" ] ; then\n-    [ -r \"${GRUB_HOST_LIB_UEFI_DIR}/efinet.mod\" ] || {\n-        echo \"ERROR: Does not look like valid GRUB x86_64-efi library directory: $GRUB_HOST_LIB_UEFI_DIR\"\n+    [ -r \"${GRUB_TARGET_LIB_UEFI_DIR}/efinet.mod\" ] || {\n+        echo \"ERROR: Does not look like valid GRUB ${ARCH}-efi library directory: $GRUB_TARGET_LIB_UEFI_DIR\"\n         exit 1\n     }\n     [ -x \"${GRUB_HOST_BIN_UEFI_DIR}/grub-mkimage\" ] || {\n-        echo \"ERROR: Does not look like valid GRUB x86_64-efi bin directory: $GRUB_HOST_BIN_UEFI_DIR\"\n+        echo \"ERROR: Does not look like valid GRUB ${ARCH}-efi bin directory: $GRUB_HOST_BIN_UEFI_DIR\"","path":"build-config/scripts/onie-mk-iso.sh","position":55,"original_position":55,"commit_id":"bdfbb50fb8ee99232774bea9d58d739a47431769","original_commit_id":"9fcba9c8f34a4657c66d2c22a19332a7253dbda9","user":{"login":"david56","id":8021507,"avatar_url":"https://avatars.githubusercontent.com/u/8021507?v=3","gravatar_id":"","url":"https://api.github.com/users/david56","html_url":"https://github.com/david56","followers_url":"https://api.github.com/users/david56/followers","following_url":"https://api.github.com/users/david56/following{/other_user}","gists_url":"https://api.github.com/users/david56/gists{/gist_id}","starred_url":"https://api.github.com/users/david56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david56/subscriptions","organizations_url":"https://api.github.com/users/david56/orgs","repos_url":"https://api.github.com/users/david56/repos","events_url":"https://api.github.com/users/david56/events{/privacy}","received_events_url":"https://api.github.com/users/david56/received_events","type":"User","site_admin":false},"body":"What I meant is the `grub-mkimage` should be always the binary file running on x86_64 build environment.  So that it should keep `x86_64` in the error message rather than `${ARCH}`.  Right?","created_at":"2016-11-09T02:45:18Z","updated_at":"2016-11-09T02:45:18Z","html_url":"https://github.com/opencomputeproject/onie/pull/440#discussion_r87126464","pull_request_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/440","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/87126464"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/440#discussion_r87126464"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/440","id":92528580,"html_url":"https://github.com/opencomputeproject/onie/pull/440","diff_url":"https://github.com/opencomputeproject/onie/pull/440.diff","patch_url":"https://github.com/opencomputeproject/onie/pull/440.patch","issue_url":"https://api.github.com/repos/opencomputeproject/onie/issues/440","number":440,"state":"open","locked":false,"title":"Adding armv8a (aarch64) support to ONIE","user":{"login":"pankajbansal3073","id":19341518,"avatar_url":"https://avatars.githubusercontent.com/u/19341518?v=3","gravatar_id":"","url":"https://api.github.com/users/pankajbansal3073","html_url":"https://github.com/pankajbansal3073","followers_url":"https://api.github.com/users/pankajbansal3073/followers","following_url":"https://api.github.com/users/pankajbansal3073/following{/other_user}","gists_url":"https://api.github.com/users/pankajbansal3073/gists{/gist_id}","starred_url":"https://api.github.com/users/pankajbansal3073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankajbansal3073/subscriptions","organizations_url":"https://api.github.com/users/pankajbansal3073/orgs","repos_url":"https://api.github.com/users/pankajbansal3073/repos","events_url":"https://api.github.com/users/pankajbansal3073/events{/privacy}","received_events_url":"https://api.github.com/users/pankajbansal3073/received_events","type":"User","site_admin":false},"body":"These concerns from previous pull request has been addressed \r\n\r\n1. in crosstool config forbid downloading has been enabled. For this to work, these packages need to be uploaded to ONIE mirror \r\n\r\n- expat-2.1.0.tar.gz\r\n- gdb-7.11.tar.xz\r\n- gettext-0.19.6.tar.xz\r\n- glibc-2.24.tar.xz\r\n- libiconv-1.14.tar.gz\r\n- libtool-2.4.6.tar.gz\r\n- ncurses-6.0.tar.gz\r\n\r\n2. The busybox configuration has been modified to use same options in 1.25.1 that were used in 1.20.2\r\n\r\n3. The busybox patches that have been applied in 1.25.1, have been removed","created_at":"2016-11-07T06:10:28Z","updated_at":"2016-11-09T02:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de64fbdaed09f8fe0f786e3a23e2aaa2000ed03d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/440/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/440/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/issues/440/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/bdfbb50fb8ee99232774bea9d58d739a47431769","head":{"label":"pankajbansal3073:upstream","ref":"upstream","sha":"bdfbb50fb8ee99232774bea9d58d739a47431769","user":{"login":"pankajbansal3073","id":19341518,"avatar_url":"https://avatars.githubusercontent.com/u/19341518?v=3","gravatar_id":"","url":"https://api.github.com/users/pankajbansal3073","html_url":"https://github.com/pankajbansal3073","followers_url":"https://api.github.com/users/pankajbansal3073/followers","following_url":"https://api.github.com/users/pankajbansal3073/following{/other_user}","gists_url":"https://api.github.com/users/pankajbansal3073/gists{/gist_id}","starred_url":"https://api.github.com/users/pankajbansal3073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankajbansal3073/subscriptions","organizations_url":"https://api.github.com/users/pankajbansal3073/orgs","repos_url":"https://api.github.com/users/pankajbansal3073/repos","events_url":"https://api.github.com/users/pankajbansal3073/events{/privacy}","received_events_url":"https://api.github.com/users/pankajbansal3073/received_events","type":"User","site_admin":false},"repo":{"id":59177958,"name":"onie","full_name":"pankajbansal3073/onie","owner":{"login":"pankajbansal3073","id":19341518,"avatar_url":"https://avatars.githubusercontent.com/u/19341518?v=3","gravatar_id":"","url":"https://api.github.com/users/pankajbansal3073","html_url":"https://github.com/pankajbansal3073","followers_url":"https://api.github.com/users/pankajbansal3073/followers","following_url":"https://api.github.com/users/pankajbansal3073/following{/other_user}","gists_url":"https://api.github.com/users/pankajbansal3073/gists{/gist_id}","starred_url":"https://api.github.com/users/pankajbansal3073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankajbansal3073/subscriptions","organizations_url":"https://api.github.com/users/pankajbansal3073/orgs","repos_url":"https://api.github.com/users/pankajbansal3073/repos","events_url":"https://api.github.com/users/pankajbansal3073/events{/privacy}","received_events_url":"https://api.github.com/users/pankajbansal3073/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pankajbansal3073/onie","description":"Open Network Install Environment","fork":true,"url":"https://api.github.com/repos/pankajbansal3073/onie","forks_url":"https://api.github.com/repos/pankajbansal3073/onie/forks","keys_url":"https://api.github.com/repos/pankajbansal3073/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pankajbansal3073/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pankajbansal3073/onie/teams","hooks_url":"https://api.github.com/repos/pankajbansal3073/onie/hooks","issue_events_url":"https://api.github.com/repos/pankajbansal3073/onie/issues/events{/number}","events_url":"https://api.github.com/repos/pankajbansal3073/onie/events","assignees_url":"https://api.github.com/repos/pankajbansal3073/onie/assignees{/user}","branches_url":"https://api.github.com/repos/pankajbansal3073/onie/branches{/branch}","tags_url":"https://api.github.com/repos/pankajbansal3073/onie/tags","blobs_url":"https://api.github.com/repos/pankajbansal3073/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pankajbansal3073/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pankajbansal3073/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/pankajbansal3073/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pankajbansal3073/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/pankajbansal3073/onie/languages","stargazers_url":"https://api.github.com/repos/pankajbansal3073/onie/stargazers","contributors_url":"https://api.github.com/repos/pankajbansal3073/onie/contributors","subscribers_url":"https://api.github.com/repos/pankajbansal3073/onie/subscribers","subscription_url":"https://api.github.com/repos/pankajbansal3073/onie/subscription","commits_url":"https://api.github.com/repos/pankajbansal3073/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/pankajbansal3073/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/pankajbansal3073/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/pankajbansal3073/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/pankajbansal3073/onie/contents/{+path}","compare_url":"https://api.github.com/repos/pankajbansal3073/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pankajbansal3073/onie/merges","archive_url":"https://api.github.com/repos/pankajbansal3073/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pankajbansal3073/onie/downloads","issues_url":"https://api.github.com/repos/pankajbansal3073/onie/issues{/number}","pulls_url":"https://api.github.com/repos/pankajbansal3073/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/pankajbansal3073/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/pankajbansal3073/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pankajbansal3073/onie/labels{/name}","releases_url":"https://api.github.com/repos/pankajbansal3073/onie/releases{/id}","deployments_url":"https://api.github.com/repos/pankajbansal3073/onie/deployments","created_at":"2016-05-19T05:58:14Z","updated_at":"2016-05-19T05:58:17Z","pushed_at":"2016-11-09T02:31:38Z","git_url":"git://github.com/pankajbansal3073/onie.git","ssh_url":"git@github.com:pankajbansal3073/onie.git","clone_url":"https://github.com/pankajbansal3073/onie.git","svn_url":"https://github.com/pankajbansal3073/onie","homepage":"http://onie.org","size":103570,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"48224da2f5cbad2a712a81ef0e4866e982f0184a","user":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":21219871,"name":"onie","full_name":"opencomputeproject/onie","owner":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/onie","description":"Open Network Install Environment","fork":false,"url":"https://api.github.com/repos/opencomputeproject/onie","forks_url":"https://api.github.com/repos/opencomputeproject/onie/forks","keys_url":"https://api.github.com/repos/opencomputeproject/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/onie/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/onie/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/onie/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/onie/events","assignees_url":"https://api.github.com/repos/opencomputeproject/onie/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/onie/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/onie/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/onie/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/onie/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/onie/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/onie/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/onie/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/onie/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/onie/merges","archive_url":"https://api.github.com/repos/opencomputeproject/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/onie/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/onie/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/onie/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/onie/releases{/id}","deployments_url":"https://api.github.com/repos/opencomputeproject/onie/deployments","created_at":"2014-06-25T21:52:35Z","updated_at":"2016-11-08T14:29:06Z","pushed_at":"2016-11-09T02:31:38Z","git_url":"git://github.com/opencomputeproject/onie.git","ssh_url":"git@github.com:opencomputeproject/onie.git","clone_url":"https://github.com/opencomputeproject/onie.git","svn_url":"https://github.com/opencomputeproject/onie","homepage":"http://onie.org","size":114328,"stargazers_count":160,"watchers_count":160,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":38,"forks":112,"open_issues":38,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/440"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/440"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/440"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/onie/statuses/bdfbb50fb8ee99232774bea9d58d739a47431769"}}}}
{"actor":{"display_login":"david56"}}