{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-documentation/pulls/comments/65567043","id":65567043,"diff_hunk":"@@ -0,0 +1,114 @@\n+    ..  _edx_javascript_guidelines:\n+\n+##########################\n+EdX JavaScript Style Guide\n+##########################\n+\n+This section describes the requirements and conventions used to contribute\n+JavaScript programming to the edX platform.\n+\n+.. contents::\n+ :local:\n+ :depth: 2\n+\n+****************\n+Google Standards\n+****************\n+\n+In general, edX JavaScript style follows the `Google JavaScript Style Guide`_.\n+In particular, the section `JavaScript Language Rules`_ includes useful advice.\n+\n+EdX JavaScript style is defined by the linters for JavaScript code in each\n+repository. Following Google JavaScript style will bring your code close to the\n+standards set by edX linters.\n+\n+**********\n+Code Style\n+**********\n+\n+Use four spaces for indenting. An example follows.","path":"en_us/developers/source/style_guides/javascript_guidelines.rst","position":29,"original_position":29,"commit_id":"7078955b7fddc2ec4c42fa890ae5dbd350a3843d","original_commit_id":"7078955b7fddc2ec4c42fa890ae5dbd350a3843d","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"Agreed. This was one of many major gaps in the original wiki that Peter drew from:\r\n\r\nhttps://github.com/edx/edx-platform/wiki/Javascript-standards-for-the-edx-platform","created_at":"2016-06-02T15:54:00Z","updated_at":"2016-06-02T15:54:00Z","html_url":"https://github.com/edx/edx-documentation/pull/906#discussion_r65567043","pull_request_url":"https://api.github.com/repos/edx/edx-documentation/pulls/906","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/comments/65567043"},"html":{"href":"https://github.com/edx/edx-documentation/pull/906#discussion_r65567043"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-documentation/pulls/906","id":62176015,"html_url":"https://github.com/edx/edx-documentation/pull/906","diff_url":"https://github.com/edx/edx-documentation/pull/906.diff","patch_url":"https://github.com/edx/edx-documentation/pull/906.patch","issue_url":"https://api.github.com/repos/edx/edx-documentation/issues/906","number":906,"state":"open","locked":false,"title":"Added a stub section about user interface development to the developers' guide","user":{"login":"pdesjardins","id":6510839,"avatar_url":"https://avatars.githubusercontent.com/u/6510839?v=3","gravatar_id":"","url":"https://api.github.com/users/pdesjardins","html_url":"https://github.com/pdesjardins","followers_url":"https://api.github.com/users/pdesjardins/followers","following_url":"https://api.github.com/users/pdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/pdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/pdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdesjardins/subscriptions","organizations_url":"https://api.github.com/users/pdesjardins/orgs","repos_url":"https://api.github.com/users/pdesjardins/repos","events_url":"https://api.github.com/users/pdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/pdesjardins/received_events","type":"User","site_admin":false},"body":"## [DOC-2755](https://openedx.atlassian.net/browse/DOC-2755)\r\n\r\nThis PR adds a top-level section about edX UI development to the developers' guide. It is intended to be the central location for UI development information, for use by internal and external developers.\r\n\r\n### Reviewers\r\nPossible roles follow. PR submitter checks the boxes after each reviewer finishes and gives :+1:. \r\n\r\n- [x] Subject matter expert: @andy-armstrong \r\n- [ ] Subject matter expert: @dsjen \r\n- [ ] Subject matter expert: @AlasdairSwan \r\n- [x] Doc team review (sanity check/copy edit/dev edit): @lamagnifica @srpearce @catong \r\n\r\n### Testing\r\n- [x] Ran ./run_tests.sh without warnings or errors\r\n \r\n### HTML Version (optional)\r\n- [x] http://draft-fedx-dev-doc.readthedocs.org/\r\n\r\n### Post-review\r\n- [x] Squash commits","created_at":"2016-03-09T03:42:41Z","updated_at":"2016-06-02T15:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b0e70d474a38ffeb9ab6d9f05a3a7cdb01ca204","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-documentation/pulls/906/commits","review_comments_url":"https://api.github.com/repos/edx/edx-documentation/pulls/906/comments","review_comment_url":"https://api.github.com/repos/edx/edx-documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-documentation/issues/906/comments","statuses_url":"https://api.github.com/repos/edx/edx-documentation/statuses/7078955b7fddc2ec4c42fa890ae5dbd350a3843d","head":{"label":"edx:pdesjardins/DOC-2755","ref":"pdesjardins/DOC-2755","sha":"7078955b7fddc2ec4c42fa890ae5dbd350a3843d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":23839256,"name":"edx-documentation","full_name":"edx/edx-documentation","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-documentation","description":"For published versions of the edX documentation, visit:","fork":false,"url":"https://api.github.com/repos/edx/edx-documentation","forks_url":"https://api.github.com/repos/edx/edx-documentation/forks","keys_url":"https://api.github.com/repos/edx/edx-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-documentation/teams","hooks_url":"https://api.github.com/repos/edx/edx-documentation/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-documentation/events","assignees_url":"https://api.github.com/repos/edx/edx-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-documentation/tags","blobs_url":"https://api.github.com/repos/edx/edx-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-documentation/languages","stargazers_url":"https://api.github.com/repos/edx/edx-documentation/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-documentation/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-documentation/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-documentation/subscription","commits_url":"https://api.github.com/repos/edx/edx-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-documentation/merges","archive_url":"https://api.github.com/repos/edx/edx-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-documentation/downloads","issues_url":"https://api.github.com/repos/edx/edx-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-documentation/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-documentation/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-documentation/deployments","created_at":"2014-09-09T15:29:04Z","updated_at":"2016-05-20T16:06:43Z","pushed_at":"2016-06-02T15:50:12Z","git_url":"git://github.com/edx/edx-documentation.git","ssh_url":"git@github.com:edx/edx-documentation.git","clone_url":"https://github.com/edx/edx-documentation.git","svn_url":"https://github.com/edx/edx-documentation","homepage":" http://docs.edx.org","size":103794,"stargazers_count":39,"watchers_count":39,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":25,"forks":135,"open_issues":25,"watchers":39,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"d65cbb5cf7f4bdb4f9735a139fa0201827b1f1e8","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":23839256,"name":"edx-documentation","full_name":"edx/edx-documentation","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-documentation","description":"For published versions of the edX documentation, visit:","fork":false,"url":"https://api.github.com/repos/edx/edx-documentation","forks_url":"https://api.github.com/repos/edx/edx-documentation/forks","keys_url":"https://api.github.com/repos/edx/edx-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-documentation/teams","hooks_url":"https://api.github.com/repos/edx/edx-documentation/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-documentation/events","assignees_url":"https://api.github.com/repos/edx/edx-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-documentation/tags","blobs_url":"https://api.github.com/repos/edx/edx-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-documentation/languages","stargazers_url":"https://api.github.com/repos/edx/edx-documentation/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-documentation/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-documentation/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-documentation/subscription","commits_url":"https://api.github.com/repos/edx/edx-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-documentation/merges","archive_url":"https://api.github.com/repos/edx/edx-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-documentation/downloads","issues_url":"https://api.github.com/repos/edx/edx-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-documentation/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-documentation/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-documentation/deployments","created_at":"2014-09-09T15:29:04Z","updated_at":"2016-05-20T16:06:43Z","pushed_at":"2016-06-02T15:50:12Z","git_url":"git://github.com/edx/edx-documentation.git","ssh_url":"git@github.com:edx/edx-documentation.git","clone_url":"https://github.com/edx/edx-documentation.git","svn_url":"https://github.com/edx/edx-documentation","homepage":" http://docs.edx.org","size":103794,"stargazers_count":39,"watchers_count":39,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":25,"forks":135,"open_issues":25,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/906"},"html":{"href":"https://github.com/edx/edx-documentation/pull/906"},"issue":{"href":"https://api.github.com/repos/edx/edx-documentation/issues/906"},"comments":{"href":"https://api.github.com/repos/edx/edx-documentation/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-documentation/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-documentation/statuses/7078955b7fddc2ec4c42fa890ae5dbd350a3843d"}}}}
{"actor":{"display_login":"andy-armstrong"}}