{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments/60360365","id":60360365,"diff_hunk":"@@ -2318,6 +2343,9 @@ int cardmod_use_reader(sc_context_t *ctx, void * pcsc_context_handle, void * pcs\n \t\t}\n \t\tpriv->gpriv = gpriv;\n \n+\t\treader->max_send_size = PCSC_SHORT_APDU_MAX_SEND_SIZE;","path":"src/libopensc/reader-pcsc.c","position":145,"original_position":145,"commit_id":"248b56f6575b5d6ad416fe6c8661d834ad6911a6","original_commit_id":"248b56f6575b5d6ad416fe6c8661d834ad6911a6","user":{"login":"viktorTarasov","id":250674,"avatar_url":"https://avatars.githubusercontent.com/u/250674?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorTarasov","html_url":"https://github.com/viktorTarasov","followers_url":"https://api.github.com/users/viktorTarasov/followers","following_url":"https://api.github.com/users/viktorTarasov/following{/other_user}","gists_url":"https://api.github.com/users/viktorTarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorTarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorTarasov/subscriptions","organizations_url":"https://api.github.com/users/viktorTarasov/orgs","repos_url":"https://api.github.com/users/viktorTarasov/repos","events_url":"https://api.github.com/users/viktorTarasov/events{/privacy}","received_events_url":"https://api.github.com/users/viktorTarasov/received_events","type":"User","site_admin":false},"body":"Agree, it should be done.","created_at":"2016-04-20T07:24:45Z","updated_at":"2016-04-20T07:24:45Z","html_url":"https://github.com/OpenSC/OpenSC/pull/739#discussion_r60360365","pull_request_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739","_links":{"self":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments/60360365"},"html":{"href":"https://github.com/OpenSC/OpenSC/pull/739#discussion_r60360365"},"pull_request":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739","id":67003326,"html_url":"https://github.com/OpenSC/OpenSC/pull/739","diff_url":"https://github.com/OpenSC/OpenSC/pull/739.diff","patch_url":"https://github.com/OpenSC/OpenSC/pull/739.patch","issue_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/739","number":739,"state":"open","locked":false,"title":"reader: by default only short APDU supported","user":{"login":"viktorTarasov","id":250674,"avatar_url":"https://avatars.githubusercontent.com/u/250674?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorTarasov","html_url":"https://github.com/viktorTarasov","followers_url":"https://api.github.com/users/viktorTarasov/followers","following_url":"https://api.github.com/users/viktorTarasov/following{/other_user}","gists_url":"https://api.github.com/users/viktorTarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorTarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorTarasov/subscriptions","organizations_url":"https://api.github.com/users/viktorTarasov/orgs","repos_url":"https://api.github.com/users/viktorTarasov/repos","events_url":"https://api.github.com/users/viktorTarasov/events{/privacy}","received_events_url":"https://api.github.com/users/viktorTarasov/received_events","type":"User","site_admin":false},"body":"default values of reader's max send/receive sizes correspond to only short APDU supported;\r\nthese values can be overwritten by reader itself with the proper value of dwMaxAPDUDataSize from TLV properties,\r\nor with the corresponding options in OpenSC configuration.\r\n\r\nresolves issue #735","created_at":"2016-04-19T11:39:34Z","updated_at":"2016-04-20T07:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faf9a5dec121079420fc77ff5ab7065e8f26d3db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739/commits","review_comments_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739/comments","review_comment_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/739/comments","statuses_url":"https://api.github.com/repos/OpenSC/OpenSC/statuses/248b56f6575b5d6ad416fe6c8661d834ad6911a6","head":{"label":"viktorTarasov:fix/default-reader-max-apdu-size","ref":"fix/default-reader-max-apdu-size","sha":"248b56f6575b5d6ad416fe6c8661d834ad6911a6","user":{"login":"viktorTarasov","id":250674,"avatar_url":"https://avatars.githubusercontent.com/u/250674?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorTarasov","html_url":"https://github.com/viktorTarasov","followers_url":"https://api.github.com/users/viktorTarasov/followers","following_url":"https://api.github.com/users/viktorTarasov/following{/other_user}","gists_url":"https://api.github.com/users/viktorTarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorTarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorTarasov/subscriptions","organizations_url":"https://api.github.com/users/viktorTarasov/orgs","repos_url":"https://api.github.com/users/viktorTarasov/repos","events_url":"https://api.github.com/users/viktorTarasov/events{/privacy}","received_events_url":"https://api.github.com/users/viktorTarasov/received_events","type":"User","site_admin":false},"repo":{"id":3488960,"name":"OpenSC-SM","full_name":"viktorTarasov/OpenSC-SM","owner":{"login":"viktorTarasov","id":250674,"avatar_url":"https://avatars.githubusercontent.com/u/250674?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorTarasov","html_url":"https://github.com/viktorTarasov","followers_url":"https://api.github.com/users/viktorTarasov/followers","following_url":"https://api.github.com/users/viktorTarasov/following{/other_user}","gists_url":"https://api.github.com/users/viktorTarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorTarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorTarasov/subscriptions","organizations_url":"https://api.github.com/users/viktorTarasov/orgs","repos_url":"https://api.github.com/users/viktorTarasov/repos","events_url":"https://api.github.com/users/viktorTarasov/events{/privacy}","received_events_url":"https://api.github.com/users/viktorTarasov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viktorTarasov/OpenSC-SM","description":"Open source smart card tools and middleware. PKCS#11/MiniDriver/Tokend","fork":true,"url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM","forks_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/forks","keys_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/teams","hooks_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/hooks","issue_events_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/issues/events{/number}","events_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/events","assignees_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/assignees{/user}","branches_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/branches{/branch}","tags_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/tags","blobs_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/git/refs{/sha}","trees_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/statuses/{sha}","languages_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/languages","stargazers_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/stargazers","contributors_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/contributors","subscribers_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/subscribers","subscription_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/subscription","commits_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/commits{/sha}","git_commits_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/git/commits{/sha}","comments_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/comments{/number}","issue_comment_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/issues/comments{/number}","contents_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/contents/{+path}","compare_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/merges","archive_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/downloads","issues_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/issues{/number}","pulls_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/pulls{/number}","milestones_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/milestones{/number}","notifications_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/labels{/name}","releases_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/releases{/id}","deployments_url":"https://api.github.com/repos/viktorTarasov/OpenSC-SM/deployments","created_at":"2012-02-19T22:35:21Z","updated_at":"2016-03-13T16:37:34Z","pushed_at":"2016-04-19T11:35:28Z","git_url":"git://github.com/viktorTarasov/OpenSC-SM.git","ssh_url":"git@github.com:viktorTarasov/OpenSC-SM.git","clone_url":"https://github.com/viktorTarasov/OpenSC-SM.git","svn_url":"https://github.com/viktorTarasov/OpenSC-SM","homepage":"https://www.opensc-project.org/","size":12896,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"OpenSC:opensc-0.16.0","ref":"opensc-0.16.0","sha":"41f34fdbcf85673abc044c98a1685116f60e67d4","user":{"login":"OpenSC","id":895249,"avatar_url":"https://avatars.githubusercontent.com/u/895249?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSC","html_url":"https://github.com/OpenSC","followers_url":"https://api.github.com/users/OpenSC/followers","following_url":"https://api.github.com/users/OpenSC/following{/other_user}","gists_url":"https://api.github.com/users/OpenSC/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSC/subscriptions","organizations_url":"https://api.github.com/users/OpenSC/orgs","repos_url":"https://api.github.com/users/OpenSC/repos","events_url":"https://api.github.com/users/OpenSC/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSC/received_events","type":"Organization","site_admin":false},"repo":{"id":1999692,"name":"OpenSC","full_name":"OpenSC/OpenSC","owner":{"login":"OpenSC","id":895249,"avatar_url":"https://avatars.githubusercontent.com/u/895249?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSC","html_url":"https://github.com/OpenSC","followers_url":"https://api.github.com/users/OpenSC/followers","following_url":"https://api.github.com/users/OpenSC/following{/other_user}","gists_url":"https://api.github.com/users/OpenSC/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSC/subscriptions","organizations_url":"https://api.github.com/users/OpenSC/orgs","repos_url":"https://api.github.com/users/OpenSC/repos","events_url":"https://api.github.com/users/OpenSC/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSC/OpenSC","description":"Open source smart card tools and middleware. PKCS#11/MiniDriver/Tokend","fork":false,"url":"https://api.github.com/repos/OpenSC/OpenSC","forks_url":"https://api.github.com/repos/OpenSC/OpenSC/forks","keys_url":"https://api.github.com/repos/OpenSC/OpenSC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSC/OpenSC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSC/OpenSC/teams","hooks_url":"https://api.github.com/repos/OpenSC/OpenSC/hooks","issue_events_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSC/OpenSC/events","assignees_url":"https://api.github.com/repos/OpenSC/OpenSC/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSC/OpenSC/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSC/OpenSC/tags","blobs_url":"https://api.github.com/repos/OpenSC/OpenSC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSC/OpenSC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSC/OpenSC/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSC/OpenSC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSC/OpenSC/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSC/OpenSC/languages","stargazers_url":"https://api.github.com/repos/OpenSC/OpenSC/stargazers","contributors_url":"https://api.github.com/repos/OpenSC/OpenSC/contributors","subscribers_url":"https://api.github.com/repos/OpenSC/OpenSC/subscribers","subscription_url":"https://api.github.com/repos/OpenSC/OpenSC/subscription","commits_url":"https://api.github.com/repos/OpenSC/OpenSC/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSC/OpenSC/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSC/OpenSC/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSC/OpenSC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSC/OpenSC/merges","archive_url":"https://api.github.com/repos/OpenSC/OpenSC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSC/OpenSC/downloads","issues_url":"https://api.github.com/repos/OpenSC/OpenSC/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSC/OpenSC/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSC/OpenSC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSC/OpenSC/labels{/name}","releases_url":"https://api.github.com/repos/OpenSC/OpenSC/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSC/OpenSC/deployments","created_at":"2011-07-05T09:45:08Z","updated_at":"2016-04-18T14:59:02Z","pushed_at":"2016-04-19T11:39:34Z","git_url":"git://github.com/OpenSC/OpenSC.git","ssh_url":"git@github.com:OpenSC/OpenSC.git","clone_url":"https://github.com/OpenSC/OpenSC.git","svn_url":"https://github.com/OpenSC/OpenSC","homepage":"https://github.com/OpenSC/OpenSC/wiki","size":15740,"stargazers_count":427,"watchers_count":427,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":31,"forks":242,"open_issues":31,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739"},"html":{"href":"https://github.com/OpenSC/OpenSC/pull/739"},"issue":{"href":"https://api.github.com/repos/OpenSC/OpenSC/issues/739"},"comments":{"href":"https://api.github.com/repos/OpenSC/OpenSC/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSC/OpenSC/statuses/248b56f6575b5d6ad416fe6c8661d834ad6911a6"}}}}