{"action":"created","issue":{"url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/94","repository_url":"https://api.github.com/repos/swarrot/SwarrotBundle","labels_url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/94/comments","events_url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/94/events","html_url":"https://github.com/swarrot/SwarrotBundle/pull/94","id":198061432,"number":94,"title":"RPC responses have to be publish on (AMQP default) exchange","user":{"login":"olaurendeau","id":1516110,"avatar_url":"https://avatars.githubusercontent.com/u/1516110?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurendeau","html_url":"https://github.com/olaurendeau","followers_url":"https://api.github.com/users/olaurendeau/followers","following_url":"https://api.github.com/users/olaurendeau/following{/other_user}","gists_url":"https://api.github.com/users/olaurendeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurendeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurendeau/subscriptions","organizations_url":"https://api.github.com/users/olaurendeau/orgs","repos_url":"https://api.github.com/users/olaurendeau/repos","events_url":"https://api.github.com/users/olaurendeau/events{/privacy}","received_events_url":"https://api.github.com/users/olaurendeau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-29T20:05:45Z","updated_at":"2016-12-30T17:50:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/swarrot/SwarrotBundle/pulls/94","html_url":"https://github.com/swarrot/SwarrotBundle/pull/94","diff_url":"https://github.com/swarrot/SwarrotBundle/pull/94.diff","patch_url":"https://github.com/swarrot/SwarrotBundle/pull/94.patch"},"body":"While trying to use the `RpcServerProcessor` I run into the following issue\r\n\r\n<img width=\"688\" alt=\"capture d ecran 2016-12-29 a 20 19 14\" src=\"https://cloud.githubusercontent.com/assets/1516110/21552758/1cf5ebf6-ce04-11e6-88b8-b61e280d9e4c.png\">\r\n\r\nReturning `[]` instead of `$this->getExtras();` in\r\n[RpcServerProcessorConfigurator](https://github.com/swarrot/SwarrotBundle/blob/master/Processor/RPC/RpcServerProcessorConfigurator.php)  fixed the issue\r\n```php\r\nnamespace Swarrot\\SwarrotBundle\\Processor\\RPC;\r\n\r\nclass RpcServerProcessorConfigurator implements ProcessorConfiguratorInterface\r\n{\r\n    public function resolveOptions(InputInterface $input)\r\n    {\r\n        return [];\r\n    }\r\n}\r\n```\r\n\r\n[RabbitMQ example of RPC pattern](https://www.rabbitmq.com/tutorials/tutorial-six-python.html) \r\n![image](https://cloud.githubusercontent.com/assets/1516110/21552484/1f509970-ce02-11e6-949e-ad67510c76b7.png)\r\n\r\n[AMQP 0.9.1 RFC](https://www.rabbitmq.com/resources/specs/amqp0-9-1.pdf) define that \"To publish to a reply queue a producer sends a message to the default exchange\"\r\n<img width=\"686\" alt=\"capture d ecran 2016-12-29 a 20 35 58\" src=\"https://cloud.githubusercontent.com/assets/1516110/21553613/84b80c74-ce09-11e6-83b5-97cdeb9be331.png\">\r\n<img width=\"660\" alt=\"capture d ecran 2016-12-30 a 11 20 04\" src=\"https://cloud.githubusercontent.com/assets/1516110/21563375/1196c3c4-ce82-11e6-8db8-05e137f37ec6.png\">\r\n\r\nSo RPC exchange should never be defined by configuration, it should always be empty.\r\n"},"comment":{"url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/comments/269800925","html_url":"https://github.com/swarrot/SwarrotBundle/pull/94#issuecomment-269800925","issue_url":"https://api.github.com/repos/swarrot/SwarrotBundle/issues/94","id":269800925,"user":{"login":"olaurendeau","id":1516110,"avatar_url":"https://avatars.githubusercontent.com/u/1516110?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurendeau","html_url":"https://github.com/olaurendeau","followers_url":"https://api.github.com/users/olaurendeau/followers","following_url":"https://api.github.com/users/olaurendeau/following{/other_user}","gists_url":"https://api.github.com/users/olaurendeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurendeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurendeau/subscriptions","organizations_url":"https://api.github.com/users/olaurendeau/orgs","repos_url":"https://api.github.com/users/olaurendeau/repos","events_url":"https://api.github.com/users/olaurendeau/events{/privacy}","received_events_url":"https://api.github.com/users/olaurendeau/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T17:50:25Z","updated_at":"2016-12-30T17:50:25Z","body":"Yes it MUST be empty, elsewhere even using a direct exchange it would just produce a message with a routing_key and Client would have to define a binding between exchange and temporary queue. Which is useless :)"}}
{"actor":{"display_login":"olaurendeau"}}