{"action":"created","issue":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3909","repository_url":"https://api.github.com/repos/crosswalk-project/crosswalk","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3909/labels{/name}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3909/comments","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3909/events","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3909","id":178553398,"number":3909,"title":"[Android] Directly depend on the .so's we want to strip","user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-22T08:45:08Z","updated_at":"2016-09-22T08:46:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3909","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3909","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3909.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3909.patch"},"body":"This fixes a regression introduced in commit 8f3c7d3 (\"[Android] Stop\ndepending on xwalk_core_shell from xwalk_core_library\"), where\n`libxwalkdummy.so` and `libxwalkcore.so` were not being stripped and\nadded to `xwalk_core_library/` (which is then used for the AAR and\n`xwalk_app_template`) in incremental builds, leading to outdated,\nexisting versions being used instead.\n\nThe bug was caused by us not explicitly depending on both unstripped\nshared libraries in the action that includes\n`strip_native_libraries.gypi`: we were previously only depending on\n`native_libraries.json` being updated whenever those shared libraries\nchanged, but `write_ordered_libraries.py` only updates the JSON file if\nits contents are actually different (if we started depending on other\nshared libraries, for example).\n\nBUG=XWALK-7335"},"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments/248845186","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3909#issuecomment-248845186","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3909","id":248845186,"user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T08:46:59Z","updated_at":"2016-09-22T08:46:59Z","body":"@xzhan96 @lincsoon @heke123 "}}
{"actor":{"display_login":"rakuco"}}