{"action":"created","issue":{"url":"https://api.github.com/repos/contao/core-bundle/issues/510","repository_url":"https://api.github.com/repos/contao/core-bundle","labels_url":"https://api.github.com/repos/contao/core-bundle/issues/510/labels{/name}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/510/comments","events_url":"https://api.github.com/repos/contao/core-bundle/issues/510/events","html_url":"https://github.com/contao/core-bundle/issues/510","id":156993798,"number":510,"title":"INFO: Contao incompatible change in Symfony v2.8.5 - _locale param in urls","user":{"login":"DanielSchwiperich","id":2045722,"avatar_url":"https://avatars.githubusercontent.com/u/2045722?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielSchwiperich","html_url":"https://github.com/DanielSchwiperich","followers_url":"https://api.github.com/users/DanielSchwiperich/followers","following_url":"https://api.github.com/users/DanielSchwiperich/following{/other_user}","gists_url":"https://api.github.com/users/DanielSchwiperich/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSchwiperich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSchwiperich/subscriptions","organizations_url":"https://api.github.com/users/DanielSchwiperich/orgs","repos_url":"https://api.github.com/users/DanielSchwiperich/repos","events_url":"https://api.github.com/users/DanielSchwiperich/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSchwiperich/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/contao/core-bundle/labels/duplicate","name":"duplicate","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-26T14:15:05Z","updated_at":"2016-05-30T06:45:33Z","closed_at":"2016-05-28T20:25:17Z","body":"take care if you update your contao installation via composer.\r\nIn **symfony/symfony:v2.8.5** there was a change made resulting in urls to have always the **_locale** param attached for contao. \r\n\r\n@leofeyer Don't want an want to open to much issues for that. Maybe we could lock *contao/standard-edition* in the *composer.json* to **v2.8.4** insteald  until it's resolved. The .lock file uses *v2.8.4* but every composer update will break it. \r\n\r\nSee: https://github.com/symfony/symfony/pull/18280\r\n\r\nI think we should leave this open here as warning / info, to save other some / much time. :smile: \r\nMost people do look here, that's why I opened it here, not at the standard edition.\r\n\r\n---\r\n**How did I get here for those wo're interested.**\r\n\r\nAfter upgrading a system from 4.1.0 to 4.1.3 I noticed that all urls had the _locale param attached. \r\nThe system uses our phpbb bridge which hooks into routing, has a custom page type etc and was also updated. \r\nSo I first thought it was related to this. Found nothing and so checked the contao changelog. \r\nThe changelog for 4.1.1 mentioned this:\r\n> Always fix the domain and language when generating URLs (see contao/core#8238).\r\nSo I thought that's it.\r\n\r\nDid setup a clean 4.1.3 installation for comparison, installed our theme to have some demo content...\r\nBut there it did work, without problems. \r\n\r\nhmm ok, maybe some regressions in config files. Still nothing. \r\nAfter way more digging around I compared the other installed packages.\r\n\r\nThe clean contao install had symfony/symfony 2.8.4, our app had 2.8.6\r\n\r\nSo I went to the symfony repository and checked the changelog:\r\n> * bug #18280 [Routing] add query param if value is different from default (Tobion)\r\n\r\nNow that's looking interesting. So i opened the issue / pr and was sure I found the answer in here.\r\nNot only did I found the answer in there. I also found that @leofeyer has been in there before.\r\n\r\nI was crying :sob: and laughing  :laughing: the same time. \r\nTook me 6 hours...\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/contao/core-bundle/issues/comments/222422771","html_url":"https://github.com/contao/core-bundle/issues/510#issuecomment-222422771","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/510","id":222422771,"user":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T06:45:33Z","updated_at":"2016-05-30T06:45:33Z","body":"What about to release a new 4.1.x (which contains the fix) with a requirement of Symfony 2.8.6? Symfony < 2.8.6 has at least two ([ldap](http://symfony.com/blog/cve-2016-2403-unauthorized-access-on-a-misconfigured-ldap-server-when-using-an-empty-password) and [session](http://symfony.com/blog/cve-2016-4423-large-username-storage-in-session)) security issues."}}
{"actor":{"display_login":"bytehead"}}