{"action":"created","issue":{"url":"https://api.github.com/repos/mhan810/liferay-portal/issues/1084","repository_url":"https://api.github.com/repos/mhan810/liferay-portal","labels_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/1084/labels{/name}","comments_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/1084/comments","events_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/1084/events","html_url":"https://github.com/mhan810/liferay-portal/pull/1084","id":135522584,"number":1084,"title":"LPS-63269 Elasticsearch 2.2 upgrade","user":{"login":"arboliveira","id":859765,"avatar_url":"https://avatars.githubusercontent.com/u/859765?v=3","gravatar_id":"","url":"https://api.github.com/users/arboliveira","html_url":"https://github.com/arboliveira","followers_url":"https://api.github.com/users/arboliveira/followers","following_url":"https://api.github.com/users/arboliveira/following{/other_user}","gists_url":"https://api.github.com/users/arboliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/arboliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arboliveira/subscriptions","organizations_url":"https://api.github.com/users/arboliveira/orgs","repos_url":"https://api.github.com/users/arboliveira/repos","events_url":"https://api.github.com/users/arboliveira/events{/privacy}","received_events_url":"https://api.github.com/users/arboliveira/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-22T19:47:27Z","updated_at":"2016-02-24T01:07:01Z","closed_at":"2016-02-24T01:07:01Z","pull_request":{"url":"https://api.github.com/repos/mhan810/liferay-portal/pulls/1084","html_url":"https://github.com/mhan810/liferay-portal/pull/1084","diff_url":"https://github.com/mhan810/liferay-portal/pull/1084.diff","patch_url":"https://github.com/mhan810/liferay-portal/pull/1084.patch"},"body":"Hey Mike, \r\n\r\n* created a new module `third-party/elasticsearch` for the patched JarHell class\r\n* installed it with `gradlew clean patch deploy install`\r\n* modified `portal-search-elasticsearch/build.gradle` to depend on the new patched jar.\r\n\r\nI can confirm Gradle uses the patched jar for bulding the classpath for `gradlew test`, and all unit tests pass. (They would break jar hell check with the original dependency.)\r\n\r\nHowever, `gradlew deploy` apparently isn't shipping the patched dependency into the generated OSGi bundle; integration tests fail with jar hell. Inspection of in-bundle `elasticsearch.jar`, as well as `lib/elasticsearch.jar` contents, show .class timestamps from the original dependency, not the patched one.\r\n\r\nThe patched jar is present at `.m2/repository/com/liferay/elasticsearch/2.2.0.LIFERAY-PATCHED-1`. However, I can't find it under `liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay` -- `gradlew deploy` does not break nevertheless.\r\n\r\nWhat am I missing?\r\n"},"comment":{"url":"https://api.github.com/repos/mhan810/liferay-portal/issues/comments/187996070","html_url":"https://github.com/mhan810/liferay-portal/pull/1084#issuecomment-187996070","issue_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/1084","id":187996070,"user":{"login":"arboliveira","id":859765,"avatar_url":"https://avatars.githubusercontent.com/u/859765?v=3","gravatar_id":"","url":"https://api.github.com/users/arboliveira","html_url":"https://github.com/arboliveira","followers_url":"https://api.github.com/users/arboliveira/followers","following_url":"https://api.github.com/users/arboliveira/following{/other_user}","gists_url":"https://api.github.com/users/arboliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/arboliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arboliveira/subscriptions","organizations_url":"https://api.github.com/users/arboliveira/orgs","repos_url":"https://api.github.com/users/arboliveira/repos","events_url":"https://api.github.com/users/arboliveira/events{/privacy}","received_events_url":"https://api.github.com/users/arboliveira/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T01:07:01Z","updated_at":"2016-02-24T01:07:01Z","body":"Closing temporarily. Will rename patched Elasticsearch to `org.elasticsearch`, then reopen."}}