{"action":"opened","number":176,"pull_request":{"url":"https://api.github.com/repos/laravel/passport/pulls/176","id":93255529,"html_url":"https://github.com/laravel/passport/pull/176","diff_url":"https://github.com/laravel/passport/pull/176.diff","patch_url":"https://github.com/laravel/passport/pull/176.patch","issue_url":"https://api.github.com/repos/laravel/passport/issues/176","number":176,"state":"open","locked":false,"title":"re-enable revoking access tokens","user":{"login":"bhosie","id":346376,"avatar_url":"https://avatars.githubusercontent.com/u/346376?v=3","gravatar_id":"","url":"https://api.github.com/users/bhosie","html_url":"https://github.com/bhosie","followers_url":"https://api.github.com/users/bhosie/followers","following_url":"https://api.github.com/users/bhosie/following{/other_user}","gists_url":"https://api.github.com/users/bhosie/gists{/gist_id}","starred_url":"https://api.github.com/users/bhosie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhosie/subscriptions","organizations_url":"https://api.github.com/users/bhosie/orgs","repos_url":"https://api.github.com/users/bhosie/repos","events_url":"https://api.github.com/users/bhosie/events{/privacy}","received_events_url":"https://api.github.com/users/bhosie/received_events","type":"User","site_admin":false},"body":"\r\nHaving this line commented out creates 2 problems: the datastore can potentially fill up with many live tokens, and it breaks pruning revoked tokens.\r\n\r\nTo reproduce (before including this patch):\r\n\r\n- [ ] in AuthServiceProvider.php\r\n\r\n```php\r\n Passport::routes();\r\n Passport::pruneRevokedTokens();\r\n```\r\n\r\n- [ ] now, make a call to `/oauth/token`\r\n- [ ] verify that tokens are not getting pruned from the db\r\n- [ ] manually change a token to `revoked=1` in the db. Call `/oauth/token` again and confirm that  the revoked token did not get pruned\r\n\r\nclosing https://github.com/laravel/passport/issues/166 in lieu of this PR","created_at":"2016-11-10T23:57:24Z","updated_at":"2016-11-10T23:57:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/passport/pulls/176/commits","review_comments_url":"https://api.github.com/repos/laravel/passport/pulls/176/comments","review_comment_url":"https://api.github.com/repos/laravel/passport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/passport/issues/176/comments","statuses_url":"https://api.github.com/repos/laravel/passport/statuses/9dc4301f3b473820cc5f0700a7acd782a525f561","head":{"label":"bhosie:bhosie-patch-prune-tokens","ref":"bhosie-patch-prune-tokens","sha":"9dc4301f3b473820cc5f0700a7acd782a525f561","user":{"login":"bhosie","id":346376,"avatar_url":"https://avatars.githubusercontent.com/u/346376?v=3","gravatar_id":"","url":"https://api.github.com/users/bhosie","html_url":"https://github.com/bhosie","followers_url":"https://api.github.com/users/bhosie/followers","following_url":"https://api.github.com/users/bhosie/following{/other_user}","gists_url":"https://api.github.com/users/bhosie/gists{/gist_id}","starred_url":"https://api.github.com/users/bhosie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhosie/subscriptions","organizations_url":"https://api.github.com/users/bhosie/orgs","repos_url":"https://api.github.com/users/bhosie/repos","events_url":"https://api.github.com/users/bhosie/events{/privacy}","received_events_url":"https://api.github.com/users/bhosie/received_events","type":"User","site_admin":false},"repo":{"id":69605468,"name":"passport","full_name":"bhosie/passport","owner":{"login":"bhosie","id":346376,"avatar_url":"https://avatars.githubusercontent.com/u/346376?v=3","gravatar_id":"","url":"https://api.github.com/users/bhosie","html_url":"https://github.com/bhosie","followers_url":"https://api.github.com/users/bhosie/followers","following_url":"https://api.github.com/users/bhosie/following{/other_user}","gists_url":"https://api.github.com/users/bhosie/gists{/gist_id}","starred_url":"https://api.github.com/users/bhosie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhosie/subscriptions","organizations_url":"https://api.github.com/users/bhosie/orgs","repos_url":"https://api.github.com/users/bhosie/repos","events_url":"https://api.github.com/users/bhosie/events{/privacy}","received_events_url":"https://api.github.com/users/bhosie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhosie/passport","description":null,"fork":true,"url":"https://api.github.com/repos/bhosie/passport","forks_url":"https://api.github.com/repos/bhosie/passport/forks","keys_url":"https://api.github.com/repos/bhosie/passport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhosie/passport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhosie/passport/teams","hooks_url":"https://api.github.com/repos/bhosie/passport/hooks","issue_events_url":"https://api.github.com/repos/bhosie/passport/issues/events{/number}","events_url":"https://api.github.com/repos/bhosie/passport/events","assignees_url":"https://api.github.com/repos/bhosie/passport/assignees{/user}","branches_url":"https://api.github.com/repos/bhosie/passport/branches{/branch}","tags_url":"https://api.github.com/repos/bhosie/passport/tags","blobs_url":"https://api.github.com/repos/bhosie/passport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhosie/passport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhosie/passport/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhosie/passport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhosie/passport/statuses/{sha}","languages_url":"https://api.github.com/repos/bhosie/passport/languages","stargazers_url":"https://api.github.com/repos/bhosie/passport/stargazers","contributors_url":"https://api.github.com/repos/bhosie/passport/contributors","subscribers_url":"https://api.github.com/repos/bhosie/passport/subscribers","subscription_url":"https://api.github.com/repos/bhosie/passport/subscription","commits_url":"https://api.github.com/repos/bhosie/passport/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhosie/passport/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhosie/passport/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhosie/passport/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhosie/passport/contents/{+path}","compare_url":"https://api.github.com/repos/bhosie/passport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhosie/passport/merges","archive_url":"https://api.github.com/repos/bhosie/passport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhosie/passport/downloads","issues_url":"https://api.github.com/repos/bhosie/passport/issues{/number}","pulls_url":"https://api.github.com/repos/bhosie/passport/pulls{/number}","milestones_url":"https://api.github.com/repos/bhosie/passport/milestones{/number}","notifications_url":"https://api.github.com/repos/bhosie/passport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhosie/passport/labels{/name}","releases_url":"https://api.github.com/repos/bhosie/passport/releases{/id}","deployments_url":"https://api.github.com/repos/bhosie/passport/deployments","created_at":"2016-09-29T20:31:54Z","updated_at":"2016-09-29T20:31:55Z","pushed_at":"2016-11-10T23:51:33Z","git_url":"git://github.com/bhosie/passport.git","ssh_url":"git@github.com:bhosie/passport.git","clone_url":"https://github.com/bhosie/passport.git","svn_url":"https://github.com/bhosie/passport","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.0"}},"base":{"label":"laravel:1.0","ref":"1.0","sha":"0c5b9a51426a2d8bb08a186126dbd8532cf1a126","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":63073734,"name":"passport","full_name":"laravel/passport","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/passport","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/passport","forks_url":"https://api.github.com/repos/laravel/passport/forks","keys_url":"https://api.github.com/repos/laravel/passport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/passport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/passport/teams","hooks_url":"https://api.github.com/repos/laravel/passport/hooks","issue_events_url":"https://api.github.com/repos/laravel/passport/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/passport/events","assignees_url":"https://api.github.com/repos/laravel/passport/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/passport/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/passport/tags","blobs_url":"https://api.github.com/repos/laravel/passport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/passport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/passport/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/passport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/passport/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/passport/languages","stargazers_url":"https://api.github.com/repos/laravel/passport/stargazers","contributors_url":"https://api.github.com/repos/laravel/passport/contributors","subscribers_url":"https://api.github.com/repos/laravel/passport/subscribers","subscription_url":"https://api.github.com/repos/laravel/passport/subscription","commits_url":"https://api.github.com/repos/laravel/passport/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/passport/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/passport/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/passport/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/passport/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/passport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/passport/merges","archive_url":"https://api.github.com/repos/laravel/passport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/passport/downloads","issues_url":"https://api.github.com/repos/laravel/passport/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/passport/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/passport/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/passport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/passport/labels{/name}","releases_url":"https://api.github.com/repos/laravel/passport/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/passport/deployments","created_at":"2016-07-11T14:13:09Z","updated_at":"2016-11-09T15:18:01Z","pushed_at":"2016-11-09T16:11:52Z","git_url":"git://github.com/laravel/passport.git","ssh_url":"git@github.com:laravel/passport.git","clone_url":"https://github.com/laravel/passport.git","svn_url":"https://github.com/laravel/passport","homepage":null,"size":231,"stargazers_count":319,"watchers_count":319,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":49,"forks":98,"open_issues":49,"watchers":319,"default_branch":"1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/passport/pulls/176"},"html":{"href":"https://github.com/laravel/passport/pull/176"},"issue":{"href":"https://api.github.com/repos/laravel/passport/issues/176"},"comments":{"href":"https://api.github.com/repos/laravel/passport/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/passport/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/passport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/passport/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/passport/statuses/9dc4301f3b473820cc5f0700a7acd782a525f561"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bhosie"}}