{"action":"opened","issue":{"url":"https://api.github.com/repos/robinhundt/schiffe-versenken/issues/2","repository_url":"https://api.github.com/repos/robinhundt/schiffe-versenken","labels_url":"https://api.github.com/repos/robinhundt/schiffe-versenken/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/robinhundt/schiffe-versenken/issues/2/comments","events_url":"https://api.github.com/repos/robinhundt/schiffe-versenken/issues/2/events","html_url":"https://github.com/robinhundt/schiffe-versenken/issues/2","id":196303003,"number":2,"title":"overall comment on code","user":{"login":"PhillipSz","id":4458478,"avatar_url":"https://avatars.githubusercontent.com/u/4458478?v=3","gravatar_id":"","url":"https://api.github.com/users/PhillipSz","html_url":"https://github.com/PhillipSz","followers_url":"https://api.github.com/users/PhillipSz/followers","following_url":"https://api.github.com/users/PhillipSz/following{/other_user}","gists_url":"https://api.github.com/users/PhillipSz/gists{/gist_id}","starred_url":"https://api.github.com/users/PhillipSz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhillipSz/subscriptions","organizations_url":"https://api.github.com/users/PhillipSz/orgs","repos_url":"https://api.github.com/users/PhillipSz/repos","events_url":"https://api.github.com/users/PhillipSz/events{/privacy}","received_events_url":"https://api.github.com/users/PhillipSz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-18T22:17:06Z","updated_at":"2016-12-18T22:17:06Z","closed_at":null,"body":"Hey, great game!\r\nHowever I have noticed a few things, which would highly improve your code.\r\n\r\n- use meaningful commit massages, even if it's annoying. It does help a lot later, if the code is more complex.\r\n\r\n- write commends. How am I suppose to understand your code? Specifically explaine what a certaine method/class does. Sometimes it's also usefull to explain what a variable is for, if it's not obvious from the name.\r\n\r\n- in getShipsPos is a lot a complexity, since you have nested a lot of code. It would be much better if you would use a few more shorter methods. Specially when you have copy/pasted large parts.\r\n\r\nSorry, if you think that above things are just a bit exaggerated. But I think good coding style is important even in small projects like this :-)"}}
{"actor":{"display_login":"PhillipSz"}}