{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/70471858","id":70471858,"diff_hunk":"@@ -205,15 +204,14 @@ public void enterIdleModeAfterForceExit() throws Exception {\n     newTransports.drainTo(transports);\n     assertEquals(addressGroupList.size(), transports.size());\n \n-    InterimTransport<ClientTransport> interimTransport = channel.tm.createInterimTransport();\n+    channel.tm.createInterimTransport();","path":"core/src/test/java/io/grpc/internal/ManagedChannelImplIdlenessTest.java","position":13,"original_position":13,"commit_id":"2d23fae81540abde90919d4034e4ee85618a5f06","original_commit_id":"b635490f0fd147157fc367c6760ed85f2d762772","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"Looking at InterimTransport, wouldn't be better to keep the ref and close it at the end of this method?","created_at":"2016-07-12T16:23:50Z","updated_at":"2016-07-12T16:23:50Z","html_url":"https://github.com/grpc/grpc-java/pull/2032#discussion_r70471858","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2032","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/70471858"},"html":{"href":"https://github.com/grpc/grpc-java/pull/2032#discussion_r70471858"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2032"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/2032","id":77025029,"html_url":"https://github.com/grpc/grpc-java/pull/2032","diff_url":"https://github.com/grpc/grpc-java/pull/2032.diff","patch_url":"https://github.com/grpc/grpc-java/pull/2032.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/2032","number":2032,"state":"open","locked":false,"title":"Fix issues found by static checkers","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"body":"Unused variables, improper GuardedBy, places where static could be\r\nadded.","created_at":"2016-07-11T21:18:33Z","updated_at":"2016-07-12T16:23:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"848e5e40bc828a537a55e7f2c5e47f4cfc683614","assignee":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"assignees":[{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2032/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2032/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/2032/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/2d23fae81540abde90919d4034e4ee85618a5f06","head":{"label":"ejona86:errorprone","ref":"errorprone","sha":"2d23fae81540abde90919d4034e4ee85618a5f06","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"repo":{"id":31378968,"name":"grpc-java","full_name":"ejona86/grpc-java","owner":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ejona86/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/ejona86/grpc-java","forks_url":"https://api.github.com/repos/ejona86/grpc-java/forks","keys_url":"https://api.github.com/repos/ejona86/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ejona86/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ejona86/grpc-java/teams","hooks_url":"https://api.github.com/repos/ejona86/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/ejona86/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/ejona86/grpc-java/events","assignees_url":"https://api.github.com/repos/ejona86/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/ejona86/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/ejona86/grpc-java/tags","blobs_url":"https://api.github.com/repos/ejona86/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ejona86/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ejona86/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ejona86/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ejona86/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ejona86/grpc-java/languages","stargazers_url":"https://api.github.com/repos/ejona86/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/ejona86/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/ejona86/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/ejona86/grpc-java/subscription","commits_url":"https://api.github.com/repos/ejona86/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ejona86/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ejona86/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ejona86/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ejona86/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/ejona86/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ejona86/grpc-java/merges","archive_url":"https://api.github.com/repos/ejona86/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ejona86/grpc-java/downloads","issues_url":"https://api.github.com/repos/ejona86/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/ejona86/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ejona86/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ejona86/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ejona86/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/ejona86/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/ejona86/grpc-java/deployments","created_at":"2015-02-26T17:23:03Z","updated_at":"2016-01-12T00:09:03Z","pushed_at":"2016-07-12T00:12:34Z","git_url":"git://github.com/ejona86/grpc-java.git","ssh_url":"git@github.com:ejona86/grpc-java.git","clone_url":"https://github.com/ejona86/grpc-java.git","svn_url":"https://github.com/ejona86/grpc-java","homepage":"","size":7472,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"bfcb04c19681f117df06151cdc4f3f3343f83676","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2016-07-12T11:24:38Z","pushed_at":"2016-07-12T06:06:21Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"http://grpc.io","size":25739,"stargazers_count":1487,"watchers_count":1487,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":402,"mirror_url":null,"open_issues_count":178,"forks":402,"open_issues":178,"watchers":1487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2032"},"html":{"href":"https://github.com/grpc/grpc-java/pull/2032"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/2032"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/2032/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2032/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2032/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/2d23fae81540abde90919d4034e4ee85618a5f06"}}}}
{"actor":{"display_login":"carl-mastrangelo"}}