{"action":"closed","number":588,"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/588","id":85372776,"html_url":"https://github.com/kubernetes/minikube/pull/588","diff_url":"https://github.com/kubernetes/minikube/pull/588.diff","patch_url":"https://github.com/kubernetes/minikube/pull/588.patch","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/588","number":588,"state":"closed","locked":false,"title":"Make soft link of minikube into $GOPATH/bin","user":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"body":"As I found that minikube binary is created at `./out/minikube` path on `make` command which forces developer to run as `./out/minikube <command>`, creating a soft link would be good approach to get it directly after `make`  command.\r\n\r\nMy workflow now:\r\n```\r\n➜  minikube git:(master) ✗ make\r\nif [ ! -e /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io ]; then mkdir -p /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io && ln -s -f /home/budhram/gowork/src/k8s.io/minikube /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io; fi\r\nCGO_ENABLED=0 go build -ldflags=\"-X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitCommit=b0deb2eb8f4037421077f77cb163dbb4c0a2a9f5 -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitVersion=v1.3.5 -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitTreeState=dirty -X k8s.io/minikube/pkg/version.version=v0.9.0 -s -w -extldflags '-static'\" -o ./out/localkube ./cmd/localkube\r\nif [ ! -e /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io ]; then mkdir -p /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io && ln -s -f /home/budhram/gowork/src/k8s.io/minikube /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io; fi\r\nGOBIN=/home/budhram/gowork/src/k8s.io/minikube/_gopath/bin go get github.com/jteeuwen/go-bindata/...\r\n/home/budhram/gowork/src/k8s.io/minikube/_gopath/bin/go-bindata -nomemcopy -o pkg/minikube/cluster/assets.go -pkg cluster ./out/localkube deploy/iso/addon-manager.yaml deploy/addons/dashboard-rc.yaml deploy/addons/dashboard-svc.yaml\r\nif [ ! -e /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io ]; then mkdir -p /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io && ln -s -f /home/budhram/gowork/src/k8s.io/minikube /home/budhram/gowork/src/k8s.io/minikube/_gopath/src/k8s.io; fi\r\nCGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build --installsuffix cgo -ldflags=\"-X k8s.io/minikube/pkg/version.version=v0.9.0\" -a -o ./out/minikube-linux-amd64 ./cmd/minikube\r\ncp ./out/minikube-linux-amd64 ./out/minikube\r\nln -s ./out/minikube /home/budhram/gowork/src/k8s.io/minikube/_gopath/bin/minikube\r\n\r\n➜  minikube git:(master) ✗ which minikube\r\n~/gowork/bin/minikube\r\n\r\n➜  minikube git:(master) ✗ minikube version\r\nminikube version: v0.9.0\r\n```","created_at":"2016-09-15T09:41:29Z","updated_at":"2016-10-18T18:09:19Z","closed_at":"2016-10-18T18:09:19Z","merged_at":null,"merge_commit_sha":"5bc59d3f657d95320d44c9964a70313fdcc3b0a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/minikube/pulls/588/commits","review_comments_url":"https://api.github.com/repos/kubernetes/minikube/pulls/588/comments","review_comment_url":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/588/comments","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/2a067d7f488699197f85d875d999ddb776eb69a1","head":{"label":"budhrg:minikube-executable","ref":"minikube-executable","sha":"2a067d7f488699197f85d875d999ddb776eb69a1","user":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"repo":{"id":62860129,"name":"minikube","full_name":"budhrg/minikube","owner":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/budhrg/minikube","description":"Run Kubernetes locally","fork":true,"url":"https://api.github.com/repos/budhrg/minikube","forks_url":"https://api.github.com/repos/budhrg/minikube/forks","keys_url":"https://api.github.com/repos/budhrg/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/budhrg/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/budhrg/minikube/teams","hooks_url":"https://api.github.com/repos/budhrg/minikube/hooks","issue_events_url":"https://api.github.com/repos/budhrg/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/budhrg/minikube/events","assignees_url":"https://api.github.com/repos/budhrg/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/budhrg/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/budhrg/minikube/tags","blobs_url":"https://api.github.com/repos/budhrg/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/budhrg/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/budhrg/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/budhrg/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/budhrg/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/budhrg/minikube/languages","stargazers_url":"https://api.github.com/repos/budhrg/minikube/stargazers","contributors_url":"https://api.github.com/repos/budhrg/minikube/contributors","subscribers_url":"https://api.github.com/repos/budhrg/minikube/subscribers","subscription_url":"https://api.github.com/repos/budhrg/minikube/subscription","commits_url":"https://api.github.com/repos/budhrg/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/budhrg/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/budhrg/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/budhrg/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/budhrg/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/budhrg/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/budhrg/minikube/merges","archive_url":"https://api.github.com/repos/budhrg/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/budhrg/minikube/downloads","issues_url":"https://api.github.com/repos/budhrg/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/budhrg/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/budhrg/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/budhrg/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/budhrg/minikube/labels{/name}","releases_url":"https://api.github.com/repos/budhrg/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/budhrg/minikube/deployments","created_at":"2016-07-08T05:04:55Z","updated_at":"2016-07-08T05:04:56Z","pushed_at":"2016-09-15T09:38:21Z","git_url":"git://github.com/budhrg/minikube.git","ssh_url":"git@github.com:budhrg/minikube.git","clone_url":"https://github.com/budhrg/minikube.git","svn_url":"https://github.com/budhrg/minikube","homepage":null,"size":17501,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3b2fce49e245c1e661b19763c053d91a82b859ff","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":56353740,"name":"minikube","full_name":"kubernetes/minikube","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/minikube","description":"Run Kubernetes locally","fork":false,"url":"https://api.github.com/repos/kubernetes/minikube","forks_url":"https://api.github.com/repos/kubernetes/minikube/forks","keys_url":"https://api.github.com/repos/kubernetes/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/minikube/teams","hooks_url":"https://api.github.com/repos/kubernetes/minikube/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/minikube/events","assignees_url":"https://api.github.com/repos/kubernetes/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/minikube/tags","blobs_url":"https://api.github.com/repos/kubernetes/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/minikube/languages","stargazers_url":"https://api.github.com/repos/kubernetes/minikube/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/minikube/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/minikube/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/minikube/subscription","commits_url":"https://api.github.com/repos/kubernetes/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/minikube/merges","archive_url":"https://api.github.com/repos/kubernetes/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/minikube/downloads","issues_url":"https://api.github.com/repos/kubernetes/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/minikube/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/minikube/deployments","created_at":"2016-04-15T22:38:35Z","updated_at":"2016-10-18T17:51:56Z","pushed_at":"2016-10-18T08:30:33Z","git_url":"git://github.com/kubernetes/minikube.git","ssh_url":"git@github.com:kubernetes/minikube.git","clone_url":"https://github.com/kubernetes/minikube.git","svn_url":"https://github.com/kubernetes/minikube","homepage":null,"size":67416,"stargazers_count":1727,"watchers_count":1727,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":84,"forks":166,"open_issues":84,"watchers":1727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/588"},"html":{"href":"https://github.com/kubernetes/minikube/pull/588"},"issue":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/588"},"comments":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/minikube/statuses/2a067d7f488699197f85d875d999ddb776eb69a1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"dlorenc"}}