{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/72882108","id":72882108,"diff_hunk":"@@ -1489,4 +1489,47 @@ moduleFor('Helpers test: element action', class extends RenderingTest {\n     this.assert.ok(outerActionCalled, 'the action fired on the proper target');\n     this.assert.ok(innerClickCalled, 'the click was triggered');\n   }\n+\n+  ['@glimmer element action with (mut undefinedThing) works properly']() {\n+    let component;\n+\n+    let ExampleComponent = Component.extend({\n+      member: undefined,\n+      init() {\n+        this._super(...arguments);\n+        component = this;\n+      }\n+    });\n+\n+    this.registerComponent('example-component', {\n+      ComponentClass: ExampleComponent,\n+      template: '<button {{action (mut member) \"foo\"}}>Click me</button>'\n+    });\n+\n+    this.render('{{example-component}}');\n+\n+    this.assert.equal(component.get('member'), undefined, 'value is initially undefined');\n+\n+    this.runTask(() => {\n+      this.$('button').click();\n+    });\n+\n+    this.assert.equal(component.get('member'), 'foo', 'value is updated');\n+\n+    this.runTask(() => {\n+      component.set('member', 'b');\n+    });\n+\n+    this.assert.equal(component.get('member'), 'b', 'precond - value is updated');\n+\n+    this.runTask(() => {\n+      this.$('button').click();\n+    });\n+\n+    this.assert.equal(component.get('member'), 'foo', 'value is updated');\n+\n+    this.runTask(() => {\n+      component.set('member', undefined);\n+    });","path":"packages/ember-glimmer/tests/integration/helpers/element-action-test.js","position":45,"original_position":45,"commit_id":"9debd043c5db2aae7510dd32087e46334df7ee94","original_commit_id":"a0fe90091cc6d1b99a2557489914ffa15ad23f9b","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"I see. It seemed a bit odd to have that followed by nothing. Would it make sense to rewrite the tests as something like:\r\n\r\n`+      template: '<button {{action (mut label) \"foo\"}}>{{if label label \"Click me\"}}</button>'`\r\n\r\nSo we could assert the value by checking the rendered values?","created_at":"2016-07-30T05:04:22Z","updated_at":"2016-07-30T05:04:22Z","html_url":"https://github.com/emberjs/ember.js/pull/13971#discussion_r72882108","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13971","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/72882108"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13971#discussion_r72882108"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13971"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13971","id":79447896,"html_url":"https://github.com/emberjs/ember.js/pull/13971","diff_url":"https://github.com/emberjs/ember.js/pull/13971.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13971.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13971","number":13971,"state":"open","locked":false,"title":"[GLIMMER] Fix issues with actions with the `(mut` helper.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Fixes #13959.","created_at":"2016-07-30T04:32:31Z","updated_at":"2016-07-30T05:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b99fed45a353755e2ce9a8b8fb099d20cda95814","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13971/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13971/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13971/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/9debd043c5db2aae7510dd32087e46334df7ee94","head":{"label":"rwjblue:fix-glimmer-mut-actions","ref":"fix-glimmer-mut-actions","sha":"9debd043c5db2aae7510dd32087e46334df7ee94","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":12009595,"name":"ember.js","full_name":"rwjblue/ember.js","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/rwjblue/ember.js","forks_url":"https://api.github.com/repos/rwjblue/ember.js/forks","keys_url":"https://api.github.com/repos/rwjblue/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/ember.js/teams","hooks_url":"https://api.github.com/repos/rwjblue/ember.js/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/ember.js/events","assignees_url":"https://api.github.com/repos/rwjblue/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/ember.js/tags","blobs_url":"https://api.github.com/repos/rwjblue/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/ember.js/languages","stargazers_url":"https://api.github.com/repos/rwjblue/ember.js/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/ember.js/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/ember.js/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/ember.js/subscription","commits_url":"https://api.github.com/repos/rwjblue/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwjblue/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/ember.js/merges","archive_url":"https://api.github.com/repos/rwjblue/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/ember.js/downloads","issues_url":"https://api.github.com/repos/rwjblue/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/rwjblue/ember.js/deployments","created_at":"2013-08-09T20:05:11Z","updated_at":"2014-07-18T12:44:07Z","pushed_at":"2016-07-30T05:02:10Z","git_url":"git://github.com/rwjblue/ember.js.git","ssh_url":"git@github.com:rwjblue/ember.js.git","clone_url":"https://github.com/rwjblue/ember.js.git","svn_url":"https://github.com/rwjblue/ember.js","homepage":"http://www.emberjs.com","size":30001,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"1fdfb44bdbc6fbe7084350e706bcfd86210546b8","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-07-30T04:20:55Z","pushed_at":"2016-07-30T05:04:08Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":73811,"stargazers_count":16560,"watchers_count":16560,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3538,"mirror_url":null,"open_issues_count":266,"forks":3538,"open_issues":266,"watchers":16560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13971"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13971"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13971"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13971/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13971/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13971/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/9debd043c5db2aae7510dd32087e46334df7ee94"}}}}
{"actor":{"display_login":"chancancode"}}