{"action":"created","issue":{"url":"https://api.github.com/repos/isc-projects/kea/issues/24","repository_url":"https://api.github.com/repos/isc-projects/kea","labels_url":"https://api.github.com/repos/isc-projects/kea/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/isc-projects/kea/issues/24/comments","events_url":"https://api.github.com/repos/isc-projects/kea/issues/24/events","html_url":"https://github.com/isc-projects/kea/pull/24","id":160861235,"number":24,"title":"[RFCs 6334, 6603, 7598] Additional native option support","user":{"login":"andreipavelQ","id":19644805,"avatar_url":"https://avatars.githubusercontent.com/u/19644805?v=3","gravatar_id":"","url":"https://api.github.com/users/andreipavelQ","html_url":"https://github.com/andreipavelQ","followers_url":"https://api.github.com/users/andreipavelQ/followers","following_url":"https://api.github.com/users/andreipavelQ/following{/other_user}","gists_url":"https://api.github.com/users/andreipavelQ/gists{/gist_id}","starred_url":"https://api.github.com/users/andreipavelQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreipavelQ/subscriptions","organizations_url":"https://api.github.com/users/andreipavelQ/orgs","repos_url":"https://api.github.com/users/andreipavelQ/repos","events_url":"https://api.github.com/users/andreipavelQ/events{/privacy}","received_events_url":"https://api.github.com/users/andreipavelQ/received_events","type":"User","site_admin":false},"labels":[{"id":115952262,"url":"https://api.github.com/repos/isc-projects/kea/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"msiodelski","id":1763583,"avatar_url":"https://avatars.githubusercontent.com/u/1763583?v=3","gravatar_id":"","url":"https://api.github.com/users/msiodelski","html_url":"https://github.com/msiodelski","followers_url":"https://api.github.com/users/msiodelski/followers","following_url":"https://api.github.com/users/msiodelski/following{/other_user}","gists_url":"https://api.github.com/users/msiodelski/gists{/gist_id}","starred_url":"https://api.github.com/users/msiodelski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiodelski/subscriptions","organizations_url":"https://api.github.com/users/msiodelski/orgs","repos_url":"https://api.github.com/users/msiodelski/repos","events_url":"https://api.github.com/users/msiodelski/events{/privacy}","received_events_url":"https://api.github.com/users/msiodelski/received_events","type":"User","site_admin":false},"assignees":[{"login":"msiodelski","id":1763583,"avatar_url":"https://avatars.githubusercontent.com/u/1763583?v=3","gravatar_id":"","url":"https://api.github.com/users/msiodelski","html_url":"https://github.com/msiodelski","followers_url":"https://api.github.com/users/msiodelski/followers","following_url":"https://api.github.com/users/msiodelski/following{/other_user}","gists_url":"https://api.github.com/users/msiodelski/gists{/gist_id}","starred_url":"https://api.github.com/users/msiodelski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiodelski/subscriptions","organizations_url":"https://api.github.com/users/msiodelski/orgs","repos_url":"https://api.github.com/users/msiodelski/repos","events_url":"https://api.github.com/users/msiodelski/events{/privacy}","received_events_url":"https://api.github.com/users/msiodelski/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-06-17T10:45:35Z","updated_at":"2016-11-04T21:04:50Z","closed_at":"2016-11-04T21:04:50Z","pull_request":{"url":"https://api.github.com/repos/isc-projects/kea/pulls/24","html_url":"https://github.com/isc-projects/kea/pull/24","diff_url":"https://github.com/isc-projects/kea/pull/24.diff","patch_url":"https://github.com/isc-projects/kea/pull/24.patch"},"body":"Hello,\n\nI work for Qualitance and I've been working on implementing RFCs 6334, 6603, 7598 and refactored the option engine to natively support option definitions previously specified in kea.conf.\n\nI've also added support for recursive encapsulations of options. I've stumbled upon a problem with encapsulated options created with default global option spaces ( \"dhcp4\", \"dhcp6\" ). It seems like [Option::getEncapsulatedSpace())](https://github.com/isc-projects/kea/blob/ad8881db1c09c40831303f05507bc6b3929315e1/src/lib/dhcp/option.h#L334) is used to reference the option's own space and this causes it to try to encapsulate all global options. This was not an issue before because there was only one level of encapsulation. I've provided a temporary workaround in [CfgOption::encapsulateOptions()](https://github.com/andreipavelQ/isc-kea-option-definitions/blob/master/src/lib/dhcpsrv/cfg_option.cc#L100), but the actual fix should be a separation between option space and encapsulated space.\n"},"comment":{"url":"https://api.github.com/repos/isc-projects/kea/issues/comments/258547136","html_url":"https://github.com/isc-projects/kea/pull/24#issuecomment-258547136","issue_url":"https://api.github.com/repos/isc-projects/kea/issues/24","id":258547136,"user":{"login":"msiodelski","id":1763583,"avatar_url":"https://avatars.githubusercontent.com/u/1763583?v=3","gravatar_id":"","url":"https://api.github.com/users/msiodelski","html_url":"https://github.com/msiodelski","followers_url":"https://api.github.com/users/msiodelski/followers","following_url":"https://api.github.com/users/msiodelski/following{/other_user}","gists_url":"https://api.github.com/users/msiodelski/gists{/gist_id}","starred_url":"https://api.github.com/users/msiodelski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiodelski/subscriptions","organizations_url":"https://api.github.com/users/msiodelski/orgs","repos_url":"https://api.github.com/users/msiodelski/repos","events_url":"https://api.github.com/users/msiodelski/events{/privacy}","received_events_url":"https://api.github.com/users/msiodelski/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T21:04:50Z","updated_at":"2016-11-04T21:04:50Z","body":"Guys,\r\nOnce again thanks for submitting the patch. Your changes and my further changes have now been merged to the master branch. Closing the pull request. Please give it a try.\r\nMarcin"}}
{"actor":{"display_login":"msiodelski"}}