{"action":"created","issue":{"url":"https://api.github.com/repos/andryou/scriptsafe/issues/9","repository_url":"https://api.github.com/repos/andryou/scriptsafe","labels_url":"https://api.github.com/repos/andryou/scriptsafe/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/andryou/scriptsafe/issues/9/comments","events_url":"https://api.github.com/repos/andryou/scriptsafe/issues/9/events","html_url":"https://github.com/andryou/scriptsafe/issues/9","id":157569948,"number":9,"title":"Trusted domains turning into allowed only after update to 1.0.7.0","user":{"login":"ROpdebee","id":15186467,"avatar_url":"https://avatars.githubusercontent.com/u/15186467?v=3","gravatar_id":"","url":"https://api.github.com/users/ROpdebee","html_url":"https://github.com/ROpdebee","followers_url":"https://api.github.com/users/ROpdebee/followers","following_url":"https://api.github.com/users/ROpdebee/following{/other_user}","gists_url":"https://api.github.com/users/ROpdebee/gists{/gist_id}","starred_url":"https://api.github.com/users/ROpdebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROpdebee/subscriptions","organizations_url":"https://api.github.com/users/ROpdebee/orgs","repos_url":"https://api.github.com/users/ROpdebee/repos","events_url":"https://api.github.com/users/ROpdebee/events{/privacy}","received_events_url":"https://api.github.com/users/ROpdebee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-31T00:33:41Z","updated_at":"2016-05-31T00:53:37Z","closed_at":null,"body":"I've noticed you've revamped the domain matching logic, great work. However, the migration from the previous version to the new domain matching logic didn't seem to go all too smooth, as all my previously trusted domains have now been turned into just \"allowed\" domains.\r\n\r\nNow, this doesn't cause too much issues, but it does cause some:\r\n- localhost was a previously trusted domain because I have a few apps with web interfaces running on them, now its pattern `*.localhost` doesn't allow any script to run on localhost (as it's not `www.localhost`)\r\n- Whenever I visit a site that load scripts with URLs such as `subdomain-of-subdomain.subdomain.example.com` and I had the pattern `*.example.com`, previously I'd expect the script to be loaded, but since 1.0.7.0 it won't because of the new pattern matching system.\r\n\r\nOf course, the above are rather rare issues, but in the panel these previously trusted domains also show up as just allowed.  For me, it's not a big issue as I've just purged my whitelist completely since the previous update because it was cluttered with old rules and now it's relatively empty, so it's reasonably easy to just update all patterns, but for other users this might be an issue.\r\n\r\nFor the majority of the users, it's already too late by now to fix this, but I advise to set up some kind of migration from old patterns to new ones if you update the pattern matching system again in the future.\r\n\r\nThanks for the efforts, been using this extension for ages now and I really like the new matching system 😄 "},"comment":{"url":"https://api.github.com/repos/andryou/scriptsafe/issues/comments/222570994","html_url":"https://github.com/andryou/scriptsafe/issues/9#issuecomment-222570994","issue_url":"https://api.github.com/repos/andryou/scriptsafe/issues/9","id":222570994,"user":{"login":"ROpdebee","id":15186467,"avatar_url":"https://avatars.githubusercontent.com/u/15186467?v=3","gravatar_id":"","url":"https://api.github.com/users/ROpdebee","html_url":"https://github.com/ROpdebee","followers_url":"https://api.github.com/users/ROpdebee/followers","following_url":"https://api.github.com/users/ROpdebee/following{/other_user}","gists_url":"https://api.github.com/users/ROpdebee/gists{/gist_id}","starred_url":"https://api.github.com/users/ROpdebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROpdebee/subscriptions","organizations_url":"https://api.github.com/users/ROpdebee/orgs","repos_url":"https://api.github.com/users/ROpdebee/repos","events_url":"https://api.github.com/users/ROpdebee/events{/privacy}","received_events_url":"https://api.github.com/users/ROpdebee/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T00:53:37Z","updated_at":"2016-05-31T00:53:37Z","body":"Additionally, this may or may not be related: \r\n![screen shot 2016-05-31 at 02 51 54](https://cloud.githubusercontent.com/assets/15186467/15660307/d2b54652-26da-11e6-9bcf-fde8ec924dd4.png)\r\nShouldn't the icon be green in this case?"}}
{"actor":{"display_login":"ROpdebee"}}