{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/89028144","pull_request_review_id":9580894,"id":89028144,"diff_hunk":"@@ -140,5 +140,125 @@ - (void)dealloc {\n }\n \n \n+@end#import \"AppController.h\"","path":"templates/js-template-default/frameworks/runtime-src/proj.ios_mac/ios/AppController.mm","position":4,"original_position":4,"commit_id":"9ed38a489a3285ff27bd5e1739d701d1a2d6d1ee","original_commit_id":"9ed38a489a3285ff27bd5e1739d701d1a2d6d1ee","user":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"body":"should remove old codes then add new codes?","created_at":"2016-11-22T01:35:41Z","updated_at":"2016-11-22T01:35:41Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/16879#discussion_r89028144","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/89028144"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/16879#discussion_r89028144"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879","id":94525930,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/16879","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/16879.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/16879.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16879","number":16879,"state":"open","locked":false,"title":"fixes for iOS 7 and earlier","user":{"login":"MrCapone","id":5929042,"avatar_url":"https://avatars.githubusercontent.com/u/5929042?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCapone","html_url":"https://github.com/MrCapone","followers_url":"https://api.github.com/users/MrCapone/followers","following_url":"https://api.github.com/users/MrCapone/following{/other_user}","gists_url":"https://api.github.com/users/MrCapone/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCapone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCapone/subscriptions","organizations_url":"https://api.github.com/users/MrCapone/orgs","repos_url":"https://api.github.com/users/MrCapone/repos","events_url":"https://api.github.com/users/MrCapone/events{/privacy}","received_events_url":"https://api.github.com/users/MrCapone/received_events","type":"User","site_admin":false},"body":"1. `cocos2d::Director` `_invalid` variable must be set to `false` on first init to prevent unwanted return on `CCEAGLView-ios::layoutSubviews` when it called first time.\r\nImproves pull request: https://github.com/cocos2d/cocos2d-x/pull/16394\r\nFixes issue: https://github.com/cocos2d/cocos2d-x/issues/16876\r\nAlso tested that case: https://github.com/cocos2d/cocos2d-x/issues/14276 to prevert regression.\r\n\r\n\r\n2. Creation and setting the `GLView` should be done after creating the `RootViewController` and after `CCEAGLView` was added to view hierarchy. Otherwise, it can cause a problem when using the landscape orientation, because view will return wrong bounds size.\r\nImproves pull request: https://github.com/cocos2d/cocos2d-x/pull/15792\r\nFixes issue: https://github.com/cocos2d/cocos2d-x/issues/16565\r\n\r\nTested on:\r\niPod 4th gen iOS 6.1.6\r\niPod 5th gen iOS 7.1\r\niPad mini 2th gen iOS 9.3.5\r\niPhone 6 iOS 10.1.1","created_at":"2016-11-20T17:48:45Z","updated_at":"2016-11-22T01:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeec781e72a39087bb0b41451bff5c527113cb7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16879/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/9ed38a489a3285ff27bd5e1739d701d1a2d6d1ee","head":{"label":"MrCapone:iOS7_fix","ref":"iOS7_fix","sha":"9ed38a489a3285ff27bd5e1739d701d1a2d6d1ee","user":{"login":"MrCapone","id":5929042,"avatar_url":"https://avatars.githubusercontent.com/u/5929042?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCapone","html_url":"https://github.com/MrCapone","followers_url":"https://api.github.com/users/MrCapone/followers","following_url":"https://api.github.com/users/MrCapone/following{/other_user}","gists_url":"https://api.github.com/users/MrCapone/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCapone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCapone/subscriptions","organizations_url":"https://api.github.com/users/MrCapone/orgs","repos_url":"https://api.github.com/users/MrCapone/repos","events_url":"https://api.github.com/users/MrCapone/events{/privacy}","received_events_url":"https://api.github.com/users/MrCapone/received_events","type":"User","site_admin":false},"repo":{"id":59741681,"name":"cocos2d-x","full_name":"MrCapone/cocos2d-x","owner":{"login":"MrCapone","id":5929042,"avatar_url":"https://avatars.githubusercontent.com/u/5929042?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCapone","html_url":"https://github.com/MrCapone","followers_url":"https://api.github.com/users/MrCapone/followers","following_url":"https://api.github.com/users/MrCapone/following{/other_user}","gists_url":"https://api.github.com/users/MrCapone/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCapone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCapone/subscriptions","organizations_url":"https://api.github.com/users/MrCapone/orgs","repos_url":"https://api.github.com/users/MrCapone/repos","events_url":"https://api.github.com/users/MrCapone/events{/privacy}","received_events_url":"https://api.github.com/users/MrCapone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrCapone/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/MrCapone/cocos2d-x","forks_url":"https://api.github.com/repos/MrCapone/cocos2d-x/forks","keys_url":"https://api.github.com/repos/MrCapone/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrCapone/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrCapone/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/MrCapone/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/MrCapone/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/MrCapone/cocos2d-x/events","assignees_url":"https://api.github.com/repos/MrCapone/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/MrCapone/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/MrCapone/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/MrCapone/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrCapone/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrCapone/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrCapone/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrCapone/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/MrCapone/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/MrCapone/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/MrCapone/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/MrCapone/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/MrCapone/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/MrCapone/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrCapone/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrCapone/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrCapone/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrCapone/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/MrCapone/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrCapone/cocos2d-x/merges","archive_url":"https://api.github.com/repos/MrCapone/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrCapone/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/MrCapone/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/MrCapone/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/MrCapone/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/MrCapone/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrCapone/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/MrCapone/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/MrCapone/cocos2d-x/deployments","created_at":"2016-05-26T10:30:22Z","updated_at":"2016-05-26T10:30:45Z","pushed_at":"2016-11-21T12:56:52Z","git_url":"git://github.com/MrCapone/cocos2d-x.git","ssh_url":"git@github.com:MrCapone/cocos2d-x.git","clone_url":"https://github.com/MrCapone/cocos2d-x.git","svn_url":"https://github.com/MrCapone/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":895226,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"0c664ebc993966f1cc2d3d6c8350431a3f104a9d","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2016-11-21T16:14:03Z","pushed_at":"2016-11-22T01:11:23Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1537100,"stargazers_count":9190,"watchers_count":9190,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5842,"mirror_url":null,"open_issues_count":988,"forks":5842,"open_issues":988,"watchers":9190,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/16879"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16879"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16879/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16879/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/9ed38a489a3285ff27bd5e1739d701d1a2d6d1ee"}}}}
{"actor":{"display_login":"minggo"}}