{"action":"created","issue":{"url":"https://api.github.com/repos/flowplayer/flowplayer/issues/1055","repository_url":"https://api.github.com/repos/flowplayer/flowplayer","labels_url":"https://api.github.com/repos/flowplayer/flowplayer/issues/1055/labels{/name}","comments_url":"https://api.github.com/repos/flowplayer/flowplayer/issues/1055/comments","events_url":"https://api.github.com/repos/flowplayer/flowplayer/issues/1055/events","html_url":"https://github.com/flowplayer/flowplayer/issues/1055","id":180128225,"number":1055,"title":"embed: offer config option for custom embed codes","user":{"login":"bbbo","id":1395672,"avatar_url":"https://avatars.githubusercontent.com/u/1395672?v=3","gravatar_id":"","url":"https://api.github.com/users/bbbo","html_url":"https://github.com/bbbo","followers_url":"https://api.github.com/users/bbbo/followers","following_url":"https://api.github.com/users/bbbo/following{/other_user}","gists_url":"https://api.github.com/users/bbbo/gists{/gist_id}","starred_url":"https://api.github.com/users/bbbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbbo/subscriptions","organizations_url":"https://api.github.com/users/bbbo/orgs","repos_url":"https://api.github.com/users/bbbo/repos","events_url":"https://api.github.com/users/bbbo/events{/privacy}","received_events_url":"https://api.github.com/users/bbbo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flowplayer/flowplayer/labels/new%20feature","name":"new feature","color":"02e10c"}],"state":"closed","locked":false,"assignee":{"login":"blacktrash","id":168338,"avatar_url":"https://avatars.githubusercontent.com/u/168338?v=3","gravatar_id":"","url":"https://api.github.com/users/blacktrash","html_url":"https://github.com/blacktrash","followers_url":"https://api.github.com/users/blacktrash/followers","following_url":"https://api.github.com/users/blacktrash/following{/other_user}","gists_url":"https://api.github.com/users/blacktrash/gists{/gist_id}","starred_url":"https://api.github.com/users/blacktrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacktrash/subscriptions","organizations_url":"https://api.github.com/users/blacktrash/orgs","repos_url":"https://api.github.com/users/blacktrash/repos","events_url":"https://api.github.com/users/blacktrash/events{/privacy}","received_events_url":"https://api.github.com/users/blacktrash/received_events","type":"User","site_admin":false},"assignees":[{"login":"blacktrash","id":168338,"avatar_url":"https://avatars.githubusercontent.com/u/168338?v=3","gravatar_id":"","url":"https://api.github.com/users/blacktrash","html_url":"https://github.com/blacktrash","followers_url":"https://api.github.com/users/blacktrash/followers","following_url":"https://api.github.com/users/blacktrash/following{/other_user}","gists_url":"https://api.github.com/users/blacktrash/gists{/gist_id}","starred_url":"https://api.github.com/users/blacktrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacktrash/subscriptions","organizations_url":"https://api.github.com/users/blacktrash/orgs","repos_url":"https://api.github.com/users/blacktrash/repos","events_url":"https://api.github.com/users/blacktrash/events{/privacy}","received_events_url":"https://api.github.com/users/blacktrash/received_events","type":"User","site_admin":false},{"login":"nnarhinen","id":265438,"avatar_url":"https://avatars.githubusercontent.com/u/265438?v=3","gravatar_id":"","url":"https://api.github.com/users/nnarhinen","html_url":"https://github.com/nnarhinen","followers_url":"https://api.github.com/users/nnarhinen/followers","following_url":"https://api.github.com/users/nnarhinen/following{/other_user}","gists_url":"https://api.github.com/users/nnarhinen/gists{/gist_id}","starred_url":"https://api.github.com/users/nnarhinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnarhinen/subscriptions","organizations_url":"https://api.github.com/users/nnarhinen/orgs","repos_url":"https://api.github.com/users/nnarhinen/repos","events_url":"https://api.github.com/users/nnarhinen/events{/privacy}","received_events_url":"https://api.github.com/users/nnarhinen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-29T18:37:08Z","updated_at":"2016-09-30T04:31:52Z","closed_at":"2016-09-29T18:53:56Z","body":"by user demand, consider offering an option\r\n\r\n   ` embedCode: \"somehtml\"`\r\n\r\nin the clip/sources configuration\r\nwhich can contain a custom embed html like a `<script>` tag instead of `<iframe>`, showing whatever the user deems needful in the `<>` embed button of the player.\r\n\r\n(quoting user)\r\n\r\nin the player code we have\r\n\r\n    if (embedConf.iframe) {\r\n        var src = player.conf.embed.iframe,\r\n           width = embedConf.width || video.width || common.width(root),\r\n            height = embedConf.height || video.height || common.height(root);\r\n         return '<iframe src=\"' + player.conf.embed.iframe + '\" allowfullscreen style=\"width:' + width +     ';height:' + height + ';border:none;\"></iframe>';\r\n      }\r\n   \r\nIt should be pretty easy to add:\r\n\r\n    else if (embedConf.code) {\r\n           return embedConf.code;\r\n    }\r\n\r\nwhich reads the embedCode string/varchar from the configuration."},"comment":{"url":"https://api.github.com/repos/flowplayer/flowplayer/issues/comments/250656369","html_url":"https://github.com/flowplayer/flowplayer/issues/1055#issuecomment-250656369","issue_url":"https://api.github.com/repos/flowplayer/flowplayer/issues/1055","id":250656369,"user":{"login":"nnarhinen","id":265438,"avatar_url":"https://avatars.githubusercontent.com/u/265438?v=3","gravatar_id":"","url":"https://api.github.com/users/nnarhinen","html_url":"https://github.com/nnarhinen","followers_url":"https://api.github.com/users/nnarhinen/followers","following_url":"https://api.github.com/users/nnarhinen/following{/other_user}","gists_url":"https://api.github.com/users/nnarhinen/gists{/gist_id}","starred_url":"https://api.github.com/users/nnarhinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnarhinen/subscriptions","organizations_url":"https://api.github.com/users/nnarhinen/orgs","repos_url":"https://api.github.com/users/nnarhinen/repos","events_url":"https://api.github.com/users/nnarhinen/events{/privacy}","received_events_url":"https://api.github.com/users/nnarhinen/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T04:31:52Z","updated_at":"2016-09-30T04:31:52Z","body":"also:\r\n\r\n```js\r\nflowplayer('#player', {\r\n  clip: { ... }\r\n}).embedCode = function() {\r\n  return '<div>My custom embed code</div>';\r\n};\r\n```\r\n\r\nas core as it gets - the embed code (without some templating mechanism) could not be configured in global configuration anyway."}}
{"actor":{"display_login":"nnarhinen"}}