{"comment":{"url":"https://api.github.com/repos/aciidb0mb3r/swift-package-manager/comments/16609811","html_url":"https://github.com/aciidb0mb3r/swift-package-manager/commit/230af3c120baa2b7b3ff4d455cd12d0e801d8910#commitcomment-16609811","id":16609811,"user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"position":59,"line":105,"path":"Sources/Transmute/Package+modules.swift","commit_id":"230af3c120baa2b7b3ff4d455cd12d0e801d8910","created_at":"2016-03-10T07:37:33Z","updated_at":"2016-03-10T07:37:33Z","body":"Nitty performance thing, but it would be nice if this just grabbing the extension then checked membership in validExtensions.\r\n\r\nAlso, I think it probably makes more sense to define the \"swift\" and \"C family\" extension sets, then collect \"swift\" and \"C family\" sources separately. This will make the `MixedSources` error handling more straightforward, and avoid hardcoding the `.swift` extension in a separate place from the other extensions."}}