{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/krun/pulls/comments/83395617","pull_request_review_id":4242839,"id":83395617,"diff_hunk":"@@ -93,10 +93,41 @@ def read_from_file(self, results_file):\n                 self.config.check_config_consistency(config, results_file)\n             self.audit = results[\"audit\"]\n \n+    def integrity_check(self):\n+        \"\"\"Check the results make sense\"\"\"\n+\n+        for key, execs in self.wallclock_times.iteritems():\n+            if len(self.eta_estimates[key]) != len(execs):\n+               fatal(\"inconsistent results: eta_estimates length\")\n+\n+            # Check the length of the in-process interations in results\n+            # XXX Check all core counts are the same\n+            # XXX Check all exec counts are the same\n+            expect_len = None\n+            for exec_idx in xrange(len(execs)):\n+                one_exec = execs[exec_idx]\n+                if expect_len is None:\n+                    expect_len = len(one_exec)\n+\n+                #if not all([len(x) == expect_len for x in self.core_cycle_counts[key][exec_idx]]):\n+                for core in self.core_cycle_counts[key][exec_idx]:\n+                    if len(core) != expect_len:\n+                        fatal(\"inconsistent results: core_cycle_counts length\")\n+","path":"krun/results.py","position":null,"original_position":24,"commit_id":"bc6e6a8369e00192d04e2496ed4c1cbce62bb20f","original_commit_id":"f7f6c2374490ca4a0e1a4c434deb1ee930275c89","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"fixed in a later commit.","created_at":"2016-10-14T10:21:57Z","updated_at":"2016-10-14T10:21:57Z","html_url":"https://github.com/softdevteam/krun/pull/256#discussion_r83395617","pull_request_url":"https://api.github.com/repos/softdevteam/krun/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/comments/83395617"},"html":{"href":"https://github.com/softdevteam/krun/pull/256#discussion_r83395617"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/krun/pulls/256","id":88112536,"html_url":"https://github.com/softdevteam/krun/pull/256","diff_url":"https://github.com/softdevteam/krun/pull/256.diff","patch_url":"https://github.com/softdevteam/krun/pull/256.patch","issue_url":"https://api.github.com/repos/softdevteam/krun/issues/256","number":256,"state":"open","locked":false,"title":"Use a manifest file so as to not have results in memory during benchmarking.","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"NOT EVEN CLOSE TO BEING READY :)\r\n\r\nI suppose cookie support looks a bit like this. Please comment on the rough approach.\r\n\r\nI've realised that anyone wishing to use --resume manually, will have to make sure the right cookie is in place.\r\n\r\nI also need to try to detect a stale cookie. I guess it could happen.","created_at":"2016-10-05T16:30:39Z","updated_at":"2016-10-14T10:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff5f5f2f20813df970fe1e30228fd8b745a912a3","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/krun/pulls/256/commits","review_comments_url":"https://api.github.com/repos/softdevteam/krun/pulls/256/comments","review_comment_url":"https://api.github.com/repos/softdevteam/krun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/krun/issues/256/comments","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/bc6e6a8369e00192d04e2496ed4c1cbce62bb20f","head":{"label":"softdevteam:cookie","ref":"cookie","sha":"bc6e6a8369e00192d04e2496ed4c1cbce62bb20f","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36661834,"name":"krun","full_name":"softdevteam/krun","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/krun","description":"Soft-dev benchmark runner in Python.","fork":false,"url":"https://api.github.com/repos/softdevteam/krun","forks_url":"https://api.github.com/repos/softdevteam/krun/forks","keys_url":"https://api.github.com/repos/softdevteam/krun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/krun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/krun/teams","hooks_url":"https://api.github.com/repos/softdevteam/krun/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/krun/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/krun/events","assignees_url":"https://api.github.com/repos/softdevteam/krun/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/krun/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/krun/tags","blobs_url":"https://api.github.com/repos/softdevteam/krun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/krun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/krun/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/krun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/krun/languages","stargazers_url":"https://api.github.com/repos/softdevteam/krun/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/krun/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/krun/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/krun/subscription","commits_url":"https://api.github.com/repos/softdevteam/krun/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/krun/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/krun/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/krun/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/krun/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/krun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/krun/merges","archive_url":"https://api.github.com/repos/softdevteam/krun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/krun/downloads","issues_url":"https://api.github.com/repos/softdevteam/krun/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/krun/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/krun/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/krun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/krun/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/krun/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/krun/deployments","created_at":"2015-06-01T13:17:06Z","updated_at":"2016-08-04T18:35:56Z","pushed_at":"2016-10-14T09:19:46Z","git_url":"git://github.com/softdevteam/krun.git","ssh_url":"git@github.com:softdevteam/krun.git","clone_url":"https://github.com/softdevteam/krun.git","svn_url":"https://github.com/softdevteam/krun","homepage":"","size":1640,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":4,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"9a75bc0e9cc3022740c10ec89a93af1aac010f73","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36661834,"name":"krun","full_name":"softdevteam/krun","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/krun","description":"Soft-dev benchmark runner in Python.","fork":false,"url":"https://api.github.com/repos/softdevteam/krun","forks_url":"https://api.github.com/repos/softdevteam/krun/forks","keys_url":"https://api.github.com/repos/softdevteam/krun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/krun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/krun/teams","hooks_url":"https://api.github.com/repos/softdevteam/krun/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/krun/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/krun/events","assignees_url":"https://api.github.com/repos/softdevteam/krun/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/krun/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/krun/tags","blobs_url":"https://api.github.com/repos/softdevteam/krun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/krun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/krun/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/krun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/krun/languages","stargazers_url":"https://api.github.com/repos/softdevteam/krun/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/krun/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/krun/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/krun/subscription","commits_url":"https://api.github.com/repos/softdevteam/krun/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/krun/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/krun/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/krun/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/krun/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/krun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/krun/merges","archive_url":"https://api.github.com/repos/softdevteam/krun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/krun/downloads","issues_url":"https://api.github.com/repos/softdevteam/krun/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/krun/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/krun/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/krun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/krun/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/krun/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/krun/deployments","created_at":"2015-06-01T13:17:06Z","updated_at":"2016-08-04T18:35:56Z","pushed_at":"2016-10-14T09:19:46Z","git_url":"git://github.com/softdevteam/krun.git","ssh_url":"git@github.com:softdevteam/krun.git","clone_url":"https://github.com/softdevteam/krun.git","svn_url":"https://github.com/softdevteam/krun","homepage":"","size":1640,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/256"},"html":{"href":"https://github.com/softdevteam/krun/pull/256"},"issue":{"href":"https://api.github.com/repos/softdevteam/krun/issues/256"},"comments":{"href":"https://api.github.com/repos/softdevteam/krun/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/krun/statuses/bc6e6a8369e00192d04e2496ed4c1cbce62bb20f"}}}}
{"actor":{"display_login":"vext01"}}