{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/loopback/issues/3053","repository_url":"https://api.github.com/repos/strongloop/loopback","labels_url":"https://api.github.com/repos/strongloop/loopback/issues/3053/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/loopback/issues/3053/comments","events_url":"https://api.github.com/repos/strongloop/loopback/issues/3053/events","html_url":"https://github.com/strongloop/loopback/pull/3053","id":197313685,"number":3053,"title":"Fix false emailVerified on user model update","user":{"login":"yumenohosi","id":586317,"avatar_url":"https://avatars.githubusercontent.com/u/586317?v=3","gravatar_id":"","url":"https://api.github.com/users/yumenohosi","html_url":"https://github.com/yumenohosi","followers_url":"https://api.github.com/users/yumenohosi/followers","following_url":"https://api.github.com/users/yumenohosi/following{/other_user}","gists_url":"https://api.github.com/users/yumenohosi/gists{/gist_id}","starred_url":"https://api.github.com/users/yumenohosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumenohosi/subscriptions","organizations_url":"https://api.github.com/users/yumenohosi/orgs","repos_url":"https://api.github.com/users/yumenohosi/repos","events_url":"https://api.github.com/users/yumenohosi/events{/privacy}","received_events_url":"https://api.github.com/users/yumenohosi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-23T05:05:42Z","updated_at":"2016-12-23T05:05:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback/pulls/3053","html_url":"https://github.com/strongloop/loopback/pull/3053","diff_url":"https://github.com/strongloop/loopback/pull/3053.diff","patch_url":"https://github.com/strongloop/loopback/pull/3053.patch"},"body":"Yesterday, the loopback we are using in our system was upgraded\r\nvia npm, and since the upgrade, we noticed that every time\r\nthe user model updates, the emailVerified column would change to false.\r\n\r\nI took a look and realized there might be an error in\r\nhttps://github.com/strongloop/loopback/commit/eb640d8\r\n\r\nThe intent of the commit just mention is to make emailVerified false\r\nwhen the email gets changed, but notice that ctx.data.email is null\r\non updates, so the condition is always met and emailVerified always\r\nbecomes false.\r\n\r\nThis commit fixes the issue just mentioned."},"comment":{"url":"https://api.github.com/repos/strongloop/loopback/issues/comments/268941339","html_url":"https://github.com/strongloop/loopback/pull/3053#issuecomment-268941339","issue_url":"https://api.github.com/repos/strongloop/loopback/issues/3053","id":268941339,"user":{"login":"slnode","id":3865961,"avatar_url":"https://avatars.githubusercontent.com/u/3865961?v=3","gravatar_id":"","url":"https://api.github.com/users/slnode","html_url":"https://github.com/slnode","followers_url":"https://api.github.com/users/slnode/followers","following_url":"https://api.github.com/users/slnode/following{/other_user}","gists_url":"https://api.github.com/users/slnode/gists{/gist_id}","starred_url":"https://api.github.com/users/slnode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slnode/subscriptions","organizations_url":"https://api.github.com/users/slnode/orgs","repos_url":"https://api.github.com/users/slnode/repos","events_url":"https://api.github.com/users/slnode/events{/privacy}","received_events_url":"https://api.github.com/users/slnode/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T05:05:44Z","updated_at":"2016-12-23T05:05:44Z","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"slnode"}}