{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/87186701","pull_request_review_id":7806686,"id":87186701,"diff_hunk":"@@ -875,6 +875,8 @@ of key-value pairs::\n \n Like ``cache.set()``, ``set_many()`` takes an optional ``timeout`` parameter.\n \n+if insertion fails for some keys, invalid keys will be returned by ``set_many``.","path":"docs/topics/cache.txt","position":4,"original_position":4,"commit_id":"b19f89701a2eb559b6f6f6c1bbe99054f9886c66","original_commit_id":"b19f89701a2eb559b6f6f6c1bbe99054f9886c66","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"if -> If\r\n\"..., `set_many()` returns the invalid keys.\"","created_at":"2016-11-09T12:54:59Z","updated_at":"2016-11-09T12:57:41Z","html_url":"https://github.com/django/django/pull/7520#discussion_r87186701","pull_request_url":"https://api.github.com/repos/django/django/pulls/7520","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/87186701"},"html":{"href":"https://github.com/django/django/pull/7520#discussion_r87186701"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/7520"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/7520","id":92485227,"html_url":"https://github.com/django/django/pull/7520","diff_url":"https://github.com/django/django/pull/7520.diff","patch_url":"https://github.com/django/django/pull/7520.patch","issue_url":"https://api.github.com/repos/django/django/issues/7520","number":7520,"state":"open","locked":false,"title":"Fixed #27318 -- Made cache.set_many() return a list of failing keys.","user":{"login":"olibook","id":353345,"avatar_url":"https://avatars.githubusercontent.com/u/353345?v=3","gravatar_id":"","url":"https://api.github.com/users/olibook","html_url":"https://github.com/olibook","followers_url":"https://api.github.com/users/olibook/followers","following_url":"https://api.github.com/users/olibook/following{/other_user}","gists_url":"https://api.github.com/users/olibook/gists{/gist_id}","starred_url":"https://api.github.com/users/olibook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olibook/subscriptions","organizations_url":"https://api.github.com/users/olibook/orgs","repos_url":"https://api.github.com/users/olibook/repos","events_url":"https://api.github.com/users/olibook/events{/privacy}","received_events_url":"https://api.github.com/users/olibook/received_events","type":"User","site_admin":false},"body":"https://code.djangoproject.com/ticket/27318\r\n\r\nimplemented a test that inserts an invalid value in memcached\r\nother backends (Dummy, Locmem)  never fails inserts thus do not need special testing\r\nadded documentation\r\n\r\nHowever I wonder how useful returning keys could be, as the keys provided by the cache user are transformed by the make_key function, which could be user defined, and can't be reversed.\r\n\r\n","created_at":"2016-11-06T12:06:10Z","updated_at":"2016-11-09T12:57:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d534b6b83fae3c2226b7ba7b1306e1b1f41339e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/7520/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/7520/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/7520/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/b19f89701a2eb559b6f6f6c1bbe99054f9886c66","head":{"label":"olibook:27318_set_multi_returns_failing_keys","ref":"27318_set_multi_returns_failing_keys","sha":"b19f89701a2eb559b6f6f6c1bbe99054f9886c66","user":{"login":"olibook","id":353345,"avatar_url":"https://avatars.githubusercontent.com/u/353345?v=3","gravatar_id":"","url":"https://api.github.com/users/olibook","html_url":"https://github.com/olibook","followers_url":"https://api.github.com/users/olibook/followers","following_url":"https://api.github.com/users/olibook/following{/other_user}","gists_url":"https://api.github.com/users/olibook/gists{/gist_id}","starred_url":"https://api.github.com/users/olibook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olibook/subscriptions","organizations_url":"https://api.github.com/users/olibook/orgs","repos_url":"https://api.github.com/users/olibook/repos","events_url":"https://api.github.com/users/olibook/events{/privacy}","received_events_url":"https://api.github.com/users/olibook/received_events","type":"User","site_admin":false},"repo":{"id":72926019,"name":"django","full_name":"olibook/django","owner":{"login":"olibook","id":353345,"avatar_url":"https://avatars.githubusercontent.com/u/353345?v=3","gravatar_id":"","url":"https://api.github.com/users/olibook","html_url":"https://github.com/olibook","followers_url":"https://api.github.com/users/olibook/followers","following_url":"https://api.github.com/users/olibook/following{/other_user}","gists_url":"https://api.github.com/users/olibook/gists{/gist_id}","starred_url":"https://api.github.com/users/olibook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olibook/subscriptions","organizations_url":"https://api.github.com/users/olibook/orgs","repos_url":"https://api.github.com/users/olibook/repos","events_url":"https://api.github.com/users/olibook/events{/privacy}","received_events_url":"https://api.github.com/users/olibook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olibook/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/olibook/django","forks_url":"https://api.github.com/repos/olibook/django/forks","keys_url":"https://api.github.com/repos/olibook/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olibook/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olibook/django/teams","hooks_url":"https://api.github.com/repos/olibook/django/hooks","issue_events_url":"https://api.github.com/repos/olibook/django/issues/events{/number}","events_url":"https://api.github.com/repos/olibook/django/events","assignees_url":"https://api.github.com/repos/olibook/django/assignees{/user}","branches_url":"https://api.github.com/repos/olibook/django/branches{/branch}","tags_url":"https://api.github.com/repos/olibook/django/tags","blobs_url":"https://api.github.com/repos/olibook/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olibook/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olibook/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/olibook/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olibook/django/statuses/{sha}","languages_url":"https://api.github.com/repos/olibook/django/languages","stargazers_url":"https://api.github.com/repos/olibook/django/stargazers","contributors_url":"https://api.github.com/repos/olibook/django/contributors","subscribers_url":"https://api.github.com/repos/olibook/django/subscribers","subscription_url":"https://api.github.com/repos/olibook/django/subscription","commits_url":"https://api.github.com/repos/olibook/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/olibook/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/olibook/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/olibook/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/olibook/django/contents/{+path}","compare_url":"https://api.github.com/repos/olibook/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olibook/django/merges","archive_url":"https://api.github.com/repos/olibook/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olibook/django/downloads","issues_url":"https://api.github.com/repos/olibook/django/issues{/number}","pulls_url":"https://api.github.com/repos/olibook/django/pulls{/number}","milestones_url":"https://api.github.com/repos/olibook/django/milestones{/number}","notifications_url":"https://api.github.com/repos/olibook/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olibook/django/labels{/name}","releases_url":"https://api.github.com/repos/olibook/django/releases{/id}","deployments_url":"https://api.github.com/repos/olibook/django/deployments","created_at":"2016-11-05T12:55:21Z","updated_at":"2016-11-05T12:55:41Z","pushed_at":"2016-11-06T12:04:10Z","git_url":"git://github.com/olibook/django.git","ssh_url":"git@github.com:olibook/django.git","clone_url":"https://github.com/olibook/django.git","svn_url":"https://github.com/olibook/django","homepage":"https://www.djangoproject.com/","size":151445,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"eaa6ea2f37509f2e54de5268f32469deeff89eb9","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-11-09T11:36:49Z","pushed_at":"2016-11-09T12:36:01Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":215179,"stargazers_count":22064,"watchers_count":22064,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8872,"mirror_url":null,"open_issues_count":128,"forks":8872,"open_issues":128,"watchers":22064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/7520"},"html":{"href":"https://github.com/django/django/pull/7520"},"issue":{"href":"https://api.github.com/repos/django/django/issues/7520"},"comments":{"href":"https://api.github.com/repos/django/django/issues/7520/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/7520/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/7520/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/b19f89701a2eb559b6f6f6c1bbe99054f9886c66"}}}}
{"actor":{"display_login":"timgraham"}}