{"action":"created","issue":{"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/105","repository_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit","labels_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/105/comments","events_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/105/events","html_url":"https://github.com/ORNL-CEES/DataTransferKit/issues/105","id":184051752,"number":105,"title":"Github labels and [WIP] semantics","user":{"login":"aprokop","id":7297887,"avatar_url":"https://avatars.githubusercontent.com/u/7297887?v=3","gravatar_id":"","url":"https://api.github.com/users/aprokop","html_url":"https://github.com/aprokop","followers_url":"https://api.github.com/users/aprokop/followers","following_url":"https://api.github.com/users/aprokop/following{/other_user}","gists_url":"https://api.github.com/users/aprokop/gists{/gist_id}","starred_url":"https://api.github.com/users/aprokop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprokop/subscriptions","organizations_url":"https://api.github.com/users/aprokop/orgs","repos_url":"https://api.github.com/users/aprokop/repos","events_url":"https://api.github.com/users/aprokop/events{/privacy}","received_events_url":"https://api.github.com/users/aprokop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-19T19:24:37Z","updated_at":"2016-10-19T19:27:04Z","closed_at":null,"body":"The conversation was started in #104. The conversation so far:\r\n\r\nsslattery: @aprokop is this WIP? isn't it being actively reviewed?\r\naprokop: It is [WIP] because it is not a final state of patches. Unless I understand WIP incorrectly.\r\nsslattery: I interpreted WIP as something that is still being actively developed. Once removed it is ready for review and fixes per the reviewer comments\r\naprokop: Then I think we need three states:\r\n1. Work has been started but not finished\r\n2. Work has been finished and patches are ready for review, but they may need more work\r\n3. Work got review approval and satisfies all criteria. Merge.\r\n\r\nThe issue I see with missing 2 is that there is no clear indication whether the patches have been cleaned up. So, somebody may see that a PR has been reviewed and go ahead and merge while an authors is rebasing and cleaning up.\r\nsslattery:I think if the patches haven't been fixed then it simply isn't merged yet. So if the reviewer thinks 2 is done and the PR can move to 3 then it is merged and closed\r\nsslatery: Thats also what the need review tag is for\r\n"},"comment":{"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/comments/254915460","html_url":"https://github.com/ORNL-CEES/DataTransferKit/issues/105#issuecomment-254915460","issue_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/105","id":254915460,"user":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T19:27:04Z","updated_at":"2016-10-19T19:27:04Z","body":"i would say it needs review until it is merged. i guess we don't have a multiple reviewer policy"}}
{"actor":{"display_login":"sslattery"}}