{"action":"created","issue":{"url":"https://api.github.com/repos/processing/p5.js-sound/issues/103","repository_url":"https://api.github.com/repos/processing/p5.js-sound","labels_url":"https://api.github.com/repos/processing/p5.js-sound/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/processing/p5.js-sound/issues/103/comments","events_url":"https://api.github.com/repos/processing/p5.js-sound/issues/103/events","html_url":"https://github.com/processing/p5.js-sound/pull/103","id":139070022,"number":103,"title":"Synths definitions and polyphony","user":{"login":"b2renger","id":1818874,"avatar_url":"https://avatars.githubusercontent.com/u/1818874?v=3","gravatar_id":"","url":"https://api.github.com/users/b2renger","html_url":"https://github.com/b2renger","followers_url":"https://api.github.com/users/b2renger/followers","following_url":"https://api.github.com/users/b2renger/following{/other_user}","gists_url":"https://api.github.com/users/b2renger/gists{/gist_id}","starred_url":"https://api.github.com/users/b2renger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b2renger/subscriptions","organizations_url":"https://api.github.com/users/b2renger/orgs","repos_url":"https://api.github.com/users/b2renger/repos","events_url":"https://api.github.com/users/b2renger/events{/privacy}","received_events_url":"https://api.github.com/users/b2renger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-07T19:28:09Z","updated_at":"2016-03-18T23:03:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/processing/p5.js-sound/pulls/103","html_url":"https://github.com/processing/p5.js-sound/pull/103","diff_url":"https://github.com/processing/p5.js-sound/pull/103.diff","patch_url":"https://github.com/processing/p5.js-sound/pull/103.patch"},"body":"This PR brings in reference to #47 :\r\n- a way to design synth inheriting methods from the new  audiovoice.js class.\r\n- a way to handle polyphony with the polysynth.js class.\r\n\r\nan example is in the example folder and added in the inline documentation. We can start discuss if this implementation is solid and what are its limits, and we could probably improve comments."},"comment":{"url":"https://api.github.com/repos/processing/p5.js-sound/issues/comments/198572862","html_url":"https://github.com/processing/p5.js-sound/pull/103#issuecomment-198572862","issue_url":"https://api.github.com/repos/processing/p5.js-sound/issues/103","id":198572862,"user":{"login":"therewasaguy","id":504124,"avatar_url":"https://avatars.githubusercontent.com/u/504124?v=3","gravatar_id":"","url":"https://api.github.com/users/therewasaguy","html_url":"https://github.com/therewasaguy","followers_url":"https://api.github.com/users/therewasaguy/followers","following_url":"https://api.github.com/users/therewasaguy/following{/other_user}","gists_url":"https://api.github.com/users/therewasaguy/gists{/gist_id}","starred_url":"https://api.github.com/users/therewasaguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therewasaguy/subscriptions","organizations_url":"https://api.github.com/users/therewasaguy/orgs","repos_url":"https://api.github.com/users/therewasaguy/repos","events_url":"https://api.github.com/users/therewasaguy/events{/privacy}","received_events_url":"https://api.github.com/users/therewasaguy/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T23:03:52Z","updated_at":"2016-03-18T23:03:52Z","body":"Ok, I think this is coming together really well! Thanks for all you've done on this so far, it's gonna be really useful and lead to a lot of good-sounding p5 projects!\r\n\r\nI just sent a pull request (and feel free to ignore if you've already done these things), but I wanted to make sure methods like play, triggerAttack and triggerRelease can be scheduled for precision. I also changed AudioVoice to MonoSynth.\r\n\r\nI think it's good to set aside the Sampler idea for now to focus on the synths and to call them \"Synths\".\r\n\r\nFor PolySynth, should setNote, setParams and setADSR apply only to the current synth (using this.poly_counter), or to all synths? I would think all synths.\r\n\r\nI'm not sure about setParams, there aren't options objects in other places in p5, so this really just seems useful for the more advanced examples. I'm thinking about the best way to get the word out about the examples...\r\n"}}