{"action":"opened","number":619,"pull_request":{"url":"https://api.github.com/repos/popcodeorg/popcode/pulls/619","id":98871783,"html_url":"https://github.com/popcodeorg/popcode/pull/619","diff_url":"https://github.com/popcodeorg/popcode/pull/619.diff","patch_url":"https://github.com/popcodeorg/popcode/pull/619.patch","issue_url":"https://api.github.com/repos/popcodeorg/popcode/issues/619","number":619,"state":"open","locked":false,"title":"Allow undefined variables if external script exists","user":{"login":"alexpelan","id":817402,"avatar_url":"https://avatars.githubusercontent.com/u/817402?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpelan","html_url":"https://github.com/alexpelan","followers_url":"https://api.github.com/users/alexpelan/followers","following_url":"https://api.github.com/users/alexpelan/following{/other_user}","gists_url":"https://api.github.com/users/alexpelan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpelan/subscriptions","organizations_url":"https://api.github.com/users/alexpelan/orgs","repos_url":"https://api.github.com/users/alexpelan/repos","events_url":"https://api.github.com/users/alexpelan/events{/privacy}","received_events_url":"https://api.github.com/users/alexpelan/received_events","type":"User","site_admin":false},"body":"Guessing we are going to go back and forth on this a little bit so figured might as well send it your way for some feedback. Big changes:\r\n\r\n1) Analyzers, modules that look a lot like validations but are meant for differing application behavior at runtime based on the contents of the Popcode source. It seemed like there are enough variations for custom parsing that we would want this to be generic, I know there's the ticket about changing Popcode title based on HTML document title, plus with this we could allow ignoring certain rules/lines like some linters do (//jshint ignore:line, etc). \r\n2) validationOverrides - now, we store a list of validation rules that might be on or might be off, and defer to this part of the state when validating, dropping the error if the rule is disabled\r\n\r\nFixes: #544","created_at":"2016-12-21T04:54:00Z","updated_at":"2016-12-21T04:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/619/commits","review_comments_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/619/comments","review_comment_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/popcodeorg/popcode/issues/619/comments","statuses_url":"https://api.github.com/repos/popcodeorg/popcode/statuses/e2778f3b90cf010f98fa7784d56e2005ccc46de0","head":{"label":"alexpelan:alexpelan/544","ref":"alexpelan/544","sha":"e2778f3b90cf010f98fa7784d56e2005ccc46de0","user":{"login":"alexpelan","id":817402,"avatar_url":"https://avatars.githubusercontent.com/u/817402?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpelan","html_url":"https://github.com/alexpelan","followers_url":"https://api.github.com/users/alexpelan/followers","following_url":"https://api.github.com/users/alexpelan/following{/other_user}","gists_url":"https://api.github.com/users/alexpelan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpelan/subscriptions","organizations_url":"https://api.github.com/users/alexpelan/orgs","repos_url":"https://api.github.com/users/alexpelan/repos","events_url":"https://api.github.com/users/alexpelan/events{/privacy}","received_events_url":"https://api.github.com/users/alexpelan/received_events","type":"User","site_admin":false},"repo":{"id":66173035,"name":"popcode","full_name":"alexpelan/popcode","owner":{"login":"alexpelan","id":817402,"avatar_url":"https://avatars.githubusercontent.com/u/817402?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpelan","html_url":"https://github.com/alexpelan","followers_url":"https://api.github.com/users/alexpelan/followers","following_url":"https://api.github.com/users/alexpelan/following{/other_user}","gists_url":"https://api.github.com/users/alexpelan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpelan/subscriptions","organizations_url":"https://api.github.com/users/alexpelan/orgs","repos_url":"https://api.github.com/users/alexpelan/repos","events_url":"https://api.github.com/users/alexpelan/events{/privacy}","received_events_url":"https://api.github.com/users/alexpelan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexpelan/popcode","description":"An HTML/CSS/JavaScript editor for use in the classroom","fork":true,"url":"https://api.github.com/repos/alexpelan/popcode","forks_url":"https://api.github.com/repos/alexpelan/popcode/forks","keys_url":"https://api.github.com/repos/alexpelan/popcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexpelan/popcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexpelan/popcode/teams","hooks_url":"https://api.github.com/repos/alexpelan/popcode/hooks","issue_events_url":"https://api.github.com/repos/alexpelan/popcode/issues/events{/number}","events_url":"https://api.github.com/repos/alexpelan/popcode/events","assignees_url":"https://api.github.com/repos/alexpelan/popcode/assignees{/user}","branches_url":"https://api.github.com/repos/alexpelan/popcode/branches{/branch}","tags_url":"https://api.github.com/repos/alexpelan/popcode/tags","blobs_url":"https://api.github.com/repos/alexpelan/popcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexpelan/popcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexpelan/popcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexpelan/popcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexpelan/popcode/statuses/{sha}","languages_url":"https://api.github.com/repos/alexpelan/popcode/languages","stargazers_url":"https://api.github.com/repos/alexpelan/popcode/stargazers","contributors_url":"https://api.github.com/repos/alexpelan/popcode/contributors","subscribers_url":"https://api.github.com/repos/alexpelan/popcode/subscribers","subscription_url":"https://api.github.com/repos/alexpelan/popcode/subscription","commits_url":"https://api.github.com/repos/alexpelan/popcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexpelan/popcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexpelan/popcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexpelan/popcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexpelan/popcode/contents/{+path}","compare_url":"https://api.github.com/repos/alexpelan/popcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexpelan/popcode/merges","archive_url":"https://api.github.com/repos/alexpelan/popcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexpelan/popcode/downloads","issues_url":"https://api.github.com/repos/alexpelan/popcode/issues{/number}","pulls_url":"https://api.github.com/repos/alexpelan/popcode/pulls{/number}","milestones_url":"https://api.github.com/repos/alexpelan/popcode/milestones{/number}","notifications_url":"https://api.github.com/repos/alexpelan/popcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexpelan/popcode/labels{/name}","releases_url":"https://api.github.com/repos/alexpelan/popcode/releases{/id}","deployments_url":"https://api.github.com/repos/alexpelan/popcode/deployments","created_at":"2016-08-20T23:52:30Z","updated_at":"2016-08-20T23:52:31Z","pushed_at":"2016-12-21T04:48:45Z","git_url":"git://github.com/alexpelan/popcode.git","ssh_url":"git@github.com:alexpelan/popcode.git","clone_url":"https://github.com/alexpelan/popcode.git","svn_url":"https://github.com/alexpelan/popcode","homepage":null,"size":1421,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"popcodeorg:master","ref":"master","sha":"634c0daf9221a2306b12f0c6a12278b5dffa92a3","user":{"login":"popcodeorg","id":15622831,"avatar_url":"https://avatars.githubusercontent.com/u/15622831?v=3","gravatar_id":"","url":"https://api.github.com/users/popcodeorg","html_url":"https://github.com/popcodeorg","followers_url":"https://api.github.com/users/popcodeorg/followers","following_url":"https://api.github.com/users/popcodeorg/following{/other_user}","gists_url":"https://api.github.com/users/popcodeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/popcodeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcodeorg/subscriptions","organizations_url":"https://api.github.com/users/popcodeorg/orgs","repos_url":"https://api.github.com/users/popcodeorg/repos","events_url":"https://api.github.com/users/popcodeorg/events{/privacy}","received_events_url":"https://api.github.com/users/popcodeorg/received_events","type":"Organization","site_admin":false},"repo":{"id":39417599,"name":"popcode","full_name":"popcodeorg/popcode","owner":{"login":"popcodeorg","id":15622831,"avatar_url":"https://avatars.githubusercontent.com/u/15622831?v=3","gravatar_id":"","url":"https://api.github.com/users/popcodeorg","html_url":"https://github.com/popcodeorg","followers_url":"https://api.github.com/users/popcodeorg/followers","following_url":"https://api.github.com/users/popcodeorg/following{/other_user}","gists_url":"https://api.github.com/users/popcodeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/popcodeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcodeorg/subscriptions","organizations_url":"https://api.github.com/users/popcodeorg/orgs","repos_url":"https://api.github.com/users/popcodeorg/repos","events_url":"https://api.github.com/users/popcodeorg/events{/privacy}","received_events_url":"https://api.github.com/users/popcodeorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/popcodeorg/popcode","description":"An HTML/CSS/JavaScript editor for use in the classroom","fork":false,"url":"https://api.github.com/repos/popcodeorg/popcode","forks_url":"https://api.github.com/repos/popcodeorg/popcode/forks","keys_url":"https://api.github.com/repos/popcodeorg/popcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popcodeorg/popcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popcodeorg/popcode/teams","hooks_url":"https://api.github.com/repos/popcodeorg/popcode/hooks","issue_events_url":"https://api.github.com/repos/popcodeorg/popcode/issues/events{/number}","events_url":"https://api.github.com/repos/popcodeorg/popcode/events","assignees_url":"https://api.github.com/repos/popcodeorg/popcode/assignees{/user}","branches_url":"https://api.github.com/repos/popcodeorg/popcode/branches{/branch}","tags_url":"https://api.github.com/repos/popcodeorg/popcode/tags","blobs_url":"https://api.github.com/repos/popcodeorg/popcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popcodeorg/popcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popcodeorg/popcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/popcodeorg/popcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popcodeorg/popcode/statuses/{sha}","languages_url":"https://api.github.com/repos/popcodeorg/popcode/languages","stargazers_url":"https://api.github.com/repos/popcodeorg/popcode/stargazers","contributors_url":"https://api.github.com/repos/popcodeorg/popcode/contributors","subscribers_url":"https://api.github.com/repos/popcodeorg/popcode/subscribers","subscription_url":"https://api.github.com/repos/popcodeorg/popcode/subscription","commits_url":"https://api.github.com/repos/popcodeorg/popcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/popcodeorg/popcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/popcodeorg/popcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/popcodeorg/popcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/popcodeorg/popcode/contents/{+path}","compare_url":"https://api.github.com/repos/popcodeorg/popcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popcodeorg/popcode/merges","archive_url":"https://api.github.com/repos/popcodeorg/popcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popcodeorg/popcode/downloads","issues_url":"https://api.github.com/repos/popcodeorg/popcode/issues{/number}","pulls_url":"https://api.github.com/repos/popcodeorg/popcode/pulls{/number}","milestones_url":"https://api.github.com/repos/popcodeorg/popcode/milestones{/number}","notifications_url":"https://api.github.com/repos/popcodeorg/popcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popcodeorg/popcode/labels{/name}","releases_url":"https://api.github.com/repos/popcodeorg/popcode/releases{/id}","deployments_url":"https://api.github.com/repos/popcodeorg/popcode/deployments","created_at":"2015-07-21T01:40:09Z","updated_at":"2016-11-19T20:20:18Z","pushed_at":"2016-12-15T02:13:27Z","git_url":"git://github.com/popcodeorg/popcode.git","ssh_url":"git@github.com:popcodeorg/popcode.git","clone_url":"https://github.com/popcodeorg/popcode.git","svn_url":"https://github.com/popcodeorg/popcode","homepage":null,"size":1429,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":111,"forks":22,"open_issues":111,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/619"},"html":{"href":"https://github.com/popcodeorg/popcode/pull/619"},"issue":{"href":"https://api.github.com/repos/popcodeorg/popcode/issues/619"},"comments":{"href":"https://api.github.com/repos/popcodeorg/popcode/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/popcodeorg/popcode/statuses/e2778f3b90cf010f98fa7784d56e2005ccc46de0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":224,"deletions":25,"changed_files":12}}
{"actor":{"display_login":"alexpelan"}}