{"action":"created","comment":{"url":"https://api.github.com/repos/decebals/pippo/pulls/comments/92457893","pull_request_review_id":12974010,"id":92457893,"diff_hunk":"@@ -65,18 +65,19 @@ public void testCreate() {\n      */\n     @Test\n     public void testSave() {\n-        HazelcastInstance hazelcastInstance2 = Hazelcast.newHazelcastInstance();\n+//        HazelcastInstance hazelcastInstance2 = Hazelcast.newHazelcastInstance();","path":"pippo-session-parent/pippo-session-hazelcast/src/test/java/ro/pippo/session/hazelcast/HazelcastSessionDataStorageTest.java","position":5,"original_position":5,"commit_id":"418e9ef72b599787fad4332a182ec3add541a857","original_commit_id":"418e9ef72b599787fad4332a182ec3add541a857","user":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"body":"@barrantesgerman `git checkput -b gzip origin/gzip`\r\nA PR is a possible merge from a branch (`gzip` in this case).","created_at":"2016-12-14T18:31:00Z","updated_at":"2016-12-14T18:31:00Z","html_url":"https://github.com/decebals/pippo/pull/333#discussion_r92457893","pull_request_url":"https://api.github.com/repos/decebals/pippo/pulls/333","_links":{"self":{"href":"https://api.github.com/repos/decebals/pippo/pulls/comments/92457893"},"html":{"href":"https://github.com/decebals/pippo/pull/333#discussion_r92457893"},"pull_request":{"href":"https://api.github.com/repos/decebals/pippo/pulls/333"}}},"pull_request":{"url":"https://api.github.com/repos/decebals/pippo/pulls/333","id":97853251,"html_url":"https://github.com/decebals/pippo/pull/333","diff_url":"https://github.com/decebals/pippo/pull/333.diff","patch_url":"https://github.com/decebals/pippo/pull/333.patch","issue_url":"https://api.github.com/repos/decebals/pippo/issues/333","number":333,"state":"open","locked":false,"title":"Use gzip compression where it's possible; see #331","user":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"body":"See #31 for more details.\r\n\r\nI made some tests and everything is OK. \r\nSo, this compression is used out of the box (you as developer do nothing) if the client (the browser - I tested on Chrome) accept \"gzip\" as encoding.\r\nI made a little refactoring, `RequestResponseFactory` contains only a method `createRequestResponse(HttpServletRequest, HttpServletResponse):RequestResponse`. Practically I merged  `createRequest` and `createResponse` methods in one method `createRequestResponse` because are multiple situation when I need to have access from response to request and vice versa. I hope that this modification doesn't affect you.\r\n\r\nOf course any advice, question is welcome. ","created_at":"2016-12-13T22:55:12Z","updated_at":"2016-12-14T18:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ba17f794afe85b64834f234bebec7292401a822","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/decebals/pippo/pulls/333/commits","review_comments_url":"https://api.github.com/repos/decebals/pippo/pulls/333/comments","review_comment_url":"https://api.github.com/repos/decebals/pippo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decebals/pippo/issues/333/comments","statuses_url":"https://api.github.com/repos/decebals/pippo/statuses/418e9ef72b599787fad4332a182ec3add541a857","head":{"label":"decebals:gzip","ref":"gzip","sha":"418e9ef72b599787fad4332a182ec3add541a857","user":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"repo":{"id":25979437,"name":"pippo","full_name":"decebals/pippo","owner":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/decebals/pippo","description":"Micro Java Web Framework","fork":false,"url":"https://api.github.com/repos/decebals/pippo","forks_url":"https://api.github.com/repos/decebals/pippo/forks","keys_url":"https://api.github.com/repos/decebals/pippo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decebals/pippo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decebals/pippo/teams","hooks_url":"https://api.github.com/repos/decebals/pippo/hooks","issue_events_url":"https://api.github.com/repos/decebals/pippo/issues/events{/number}","events_url":"https://api.github.com/repos/decebals/pippo/events","assignees_url":"https://api.github.com/repos/decebals/pippo/assignees{/user}","branches_url":"https://api.github.com/repos/decebals/pippo/branches{/branch}","tags_url":"https://api.github.com/repos/decebals/pippo/tags","blobs_url":"https://api.github.com/repos/decebals/pippo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decebals/pippo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decebals/pippo/git/refs{/sha}","trees_url":"https://api.github.com/repos/decebals/pippo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decebals/pippo/statuses/{sha}","languages_url":"https://api.github.com/repos/decebals/pippo/languages","stargazers_url":"https://api.github.com/repos/decebals/pippo/stargazers","contributors_url":"https://api.github.com/repos/decebals/pippo/contributors","subscribers_url":"https://api.github.com/repos/decebals/pippo/subscribers","subscription_url":"https://api.github.com/repos/decebals/pippo/subscription","commits_url":"https://api.github.com/repos/decebals/pippo/commits{/sha}","git_commits_url":"https://api.github.com/repos/decebals/pippo/git/commits{/sha}","comments_url":"https://api.github.com/repos/decebals/pippo/comments{/number}","issue_comment_url":"https://api.github.com/repos/decebals/pippo/issues/comments{/number}","contents_url":"https://api.github.com/repos/decebals/pippo/contents/{+path}","compare_url":"https://api.github.com/repos/decebals/pippo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decebals/pippo/merges","archive_url":"https://api.github.com/repos/decebals/pippo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decebals/pippo/downloads","issues_url":"https://api.github.com/repos/decebals/pippo/issues{/number}","pulls_url":"https://api.github.com/repos/decebals/pippo/pulls{/number}","milestones_url":"https://api.github.com/repos/decebals/pippo/milestones{/number}","notifications_url":"https://api.github.com/repos/decebals/pippo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decebals/pippo/labels{/name}","releases_url":"https://api.github.com/repos/decebals/pippo/releases{/id}","deployments_url":"https://api.github.com/repos/decebals/pippo/deployments","created_at":"2014-10-30T16:23:30Z","updated_at":"2016-12-13T23:52:33Z","pushed_at":"2016-12-14T16:32:20Z","git_url":"git://github.com/decebals/pippo.git","ssh_url":"git@github.com:decebals/pippo.git","clone_url":"https://github.com/decebals/pippo.git","svn_url":"https://github.com/decebals/pippo","homepage":null,"size":2513,"stargazers_count":546,"watchers_count":546,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":23,"forks":65,"open_issues":23,"watchers":546,"default_branch":"master"}},"base":{"label":"decebals:master","ref":"master","sha":"413bd3d394a2559dbeeadc7125c9bde19c1a4c96","user":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"repo":{"id":25979437,"name":"pippo","full_name":"decebals/pippo","owner":{"login":"decebals","id":1248311,"avatar_url":"https://avatars.githubusercontent.com/u/1248311?v=3","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/decebals/pippo","description":"Micro Java Web Framework","fork":false,"url":"https://api.github.com/repos/decebals/pippo","forks_url":"https://api.github.com/repos/decebals/pippo/forks","keys_url":"https://api.github.com/repos/decebals/pippo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decebals/pippo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decebals/pippo/teams","hooks_url":"https://api.github.com/repos/decebals/pippo/hooks","issue_events_url":"https://api.github.com/repos/decebals/pippo/issues/events{/number}","events_url":"https://api.github.com/repos/decebals/pippo/events","assignees_url":"https://api.github.com/repos/decebals/pippo/assignees{/user}","branches_url":"https://api.github.com/repos/decebals/pippo/branches{/branch}","tags_url":"https://api.github.com/repos/decebals/pippo/tags","blobs_url":"https://api.github.com/repos/decebals/pippo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decebals/pippo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decebals/pippo/git/refs{/sha}","trees_url":"https://api.github.com/repos/decebals/pippo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decebals/pippo/statuses/{sha}","languages_url":"https://api.github.com/repos/decebals/pippo/languages","stargazers_url":"https://api.github.com/repos/decebals/pippo/stargazers","contributors_url":"https://api.github.com/repos/decebals/pippo/contributors","subscribers_url":"https://api.github.com/repos/decebals/pippo/subscribers","subscription_url":"https://api.github.com/repos/decebals/pippo/subscription","commits_url":"https://api.github.com/repos/decebals/pippo/commits{/sha}","git_commits_url":"https://api.github.com/repos/decebals/pippo/git/commits{/sha}","comments_url":"https://api.github.com/repos/decebals/pippo/comments{/number}","issue_comment_url":"https://api.github.com/repos/decebals/pippo/issues/comments{/number}","contents_url":"https://api.github.com/repos/decebals/pippo/contents/{+path}","compare_url":"https://api.github.com/repos/decebals/pippo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decebals/pippo/merges","archive_url":"https://api.github.com/repos/decebals/pippo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decebals/pippo/downloads","issues_url":"https://api.github.com/repos/decebals/pippo/issues{/number}","pulls_url":"https://api.github.com/repos/decebals/pippo/pulls{/number}","milestones_url":"https://api.github.com/repos/decebals/pippo/milestones{/number}","notifications_url":"https://api.github.com/repos/decebals/pippo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decebals/pippo/labels{/name}","releases_url":"https://api.github.com/repos/decebals/pippo/releases{/id}","deployments_url":"https://api.github.com/repos/decebals/pippo/deployments","created_at":"2014-10-30T16:23:30Z","updated_at":"2016-12-13T23:52:33Z","pushed_at":"2016-12-14T16:32:20Z","git_url":"git://github.com/decebals/pippo.git","ssh_url":"git@github.com:decebals/pippo.git","clone_url":"https://github.com/decebals/pippo.git","svn_url":"https://github.com/decebals/pippo","homepage":null,"size":2513,"stargazers_count":546,"watchers_count":546,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":23,"forks":65,"open_issues":23,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decebals/pippo/pulls/333"},"html":{"href":"https://github.com/decebals/pippo/pull/333"},"issue":{"href":"https://api.github.com/repos/decebals/pippo/issues/333"},"comments":{"href":"https://api.github.com/repos/decebals/pippo/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/decebals/pippo/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/decebals/pippo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decebals/pippo/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/decebals/pippo/statuses/418e9ef72b599787fad4332a182ec3add541a857"}}}}
{"actor":{"display_login":"decebals"}}