{"action":"closed","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/3737","repository_url":"https://api.github.com/repos/emberjs/data","labels_url":"https://api.github.com/repos/emberjs/data/issues/3737/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3737/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/3737/events","html_url":"https://github.com/emberjs/data/issues/3737","id":105563196,"number":3737,"title":"CP based on model.hasDirtyAttributes not firing in ED 1.13.11 / E 1.13.10","user":{"login":"zyllorion","id":10155785,"avatar_url":"https://avatars.githubusercontent.com/u/10155785?v=3","gravatar_id":"","url":"https://api.github.com/users/zyllorion","html_url":"https://github.com/zyllorion","followers_url":"https://api.github.com/users/zyllorion/followers","following_url":"https://api.github.com/users/zyllorion/following{/other_user}","gists_url":"https://api.github.com/users/zyllorion/gists{/gist_id}","starred_url":"https://api.github.com/users/zyllorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyllorion/subscriptions","organizations_url":"https://api.github.com/users/zyllorion/orgs","repos_url":"https://api.github.com/users/zyllorion/repos","events_url":"https://api.github.com/users/zyllorion/events{/privacy}","received_events_url":"https://api.github.com/users/zyllorion/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-09T09:52:07Z","updated_at":"2016-05-26T16:50:41Z","closed_at":"2016-05-26T16:50:41Z","body":"Currently have a model with numerous hasMany's, e.g.\r\n```\r\nmyModel\r\n--otherModel1\r\n--otherModel2\r\n--otherModel3\r\n```\r\nIt is initialised in the pod route, and `controller.set('model', model);` so it is visible in the controller and template, which it is through the usual model.myModel.\r\n\r\nWhen I create a CP with the structure;\r\n```\r\nisTreeDirty: Ember.computed([the conditions],\r\n        function() {[return t or f based on status of related entities]\r\n```\r\nor\r\n```\r\nisTreeDirty: function() {\r\n[return t or f]\r\n    }.property([conditions])\r\n```\r\nwhere conditions are all combinations of;\r\n```\r\nmodel.myModel.hasDirtyAttributes\r\nmodel.myModel.otherModel1.hasDirtyAttributes\r\nmodel.myModel.otherModel1.[].hasDirtyAttributes\r\nmodel.myModel.otherModel1.@each.hasDirtyAttributes\r\n...\r\n```\r\nthe CP does not fire when there is a change to the model or nested models.  The change is visible in Ember Inspector.\r\n\r\nThis worked with the same ED 1.13 but Ember v1.12, and for the upgrade of this CP initially I added [] references which caused things to break, then on reverting to just the @each (first and last lines in list above) it worked again.\r\n\r\nThere doesnt seem to be an explanation of [] on http://guides.emberjs.com/v1.13.0/object-model/computed-properties-and-aggregate-data/\r\n\r\nAny ideas? Thanks"}}
{"actor":{"display_login":"bmac"}}