{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments/91372773","pull_request_review_id":11881780,"id":91372773,"diff_hunk":"@@ -76,7 +78,13 @@ export class SassTask extends GulpTask<ISassTaskConfig> {\n \n     if (this.taskConfig.useCSSModules) {\n       this.logVerbose('Generating css modules.');\n-      return this._processFiles(gulp, srcPattern, completeCallback, modulePostCssPlugins);\n+      return this._processFiles(gulp, srcPattern, completeCallback, modulePostCssPlugins,\n+        (file: gulpUtil.File) => {\n+          if (!path.basename(file.path).match(/module\\.css$/)) {","path":"gulp-core-build-sass/src/SassTask.ts","position":25,"original_position":25,"commit_id":"634ae79f7814383697a6f7938e8ca46ac968bbc0","original_commit_id":"634ae79f7814383697a6f7938e8ca46ac968bbc0","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"Yes, we do treat module.scss and scss files differently... And this warning is only written if we have \"shouldUseModuleCss\" turned on, but then don't use module.scss. I can introduce a flag to turn this on or off, if you'd like.","created_at":"2016-12-07T19:50:50Z","updated_at":"2016-12-07T19:50:50Z","html_url":"https://github.com/Microsoft/web-build-tools/pull/32#discussion_r91372773","pull_request_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments/91372773"},"html":{"href":"https://github.com/Microsoft/web-build-tools/pull/32#discussion_r91372773"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32","id":96844644,"html_url":"https://github.com/Microsoft/web-build-tools/pull/32","diff_url":"https://github.com/Microsoft/web-build-tools/pull/32.diff","patch_url":"https://github.com/Microsoft/web-build-tools/pull/32.patch","issue_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/32","number":32,"state":"open","locked":false,"title":"SASS should write a warning if a regular .scss file is used  when useCSSModules=true","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars.githubusercontent.com/u/17131271?v=3","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"SASS should write a warning if a regular .scss file is used  when useCSSModules=true","created_at":"2016-12-07T01:57:26Z","updated_at":"2016-12-07T19:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d0af3488ac17b269a6415e47a72ae8cace83e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32/commits","review_comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32/comments","review_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/32/comments","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/634ae79f7814383697a6f7938e8ca46ac968bbc0","head":{"label":"Microsoft:nickpape/tslint-should-warn-when-using-regular-css","ref":"nickpape/tslint-should-warn-when-using-regular-css","sha":"634ae79f7814383697a6f7938e8ca46ac968bbc0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":69618902,"name":"web-build-tools","full_name":"Microsoft/web-build-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/web-build-tools","description":"Various build packages used for building web libraries","fork":false,"url":"https://api.github.com/repos/Microsoft/web-build-tools","forks_url":"https://api.github.com/repos/Microsoft/web-build-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/web-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/web-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/web-build-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/web-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/web-build-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/web-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/web-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/web-build-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/web-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/web-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/web-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/web-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/web-build-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/web-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/web-build-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/web-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/web-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/web-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/web-build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/web-build-tools/deployments","created_at":"2016-09-30T00:28:20Z","updated_at":"2016-12-04T16:21:50Z","pushed_at":"2016-12-07T01:57:26Z","git_url":"git://github.com/Microsoft/web-build-tools.git","ssh_url":"git@github.com:Microsoft/web-build-tools.git","clone_url":"https://github.com/Microsoft/web-build-tools.git","svn_url":"https://github.com/Microsoft/web-build-tools","homepage":"","size":1329,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":8,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a9a82a2e5d8126c46705457ae925318933ee9b27","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":69618902,"name":"web-build-tools","full_name":"Microsoft/web-build-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/web-build-tools","description":"Various build packages used for building web libraries","fork":false,"url":"https://api.github.com/repos/Microsoft/web-build-tools","forks_url":"https://api.github.com/repos/Microsoft/web-build-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/web-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/web-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/web-build-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/web-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/web-build-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/web-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/web-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/web-build-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/web-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/web-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/web-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/web-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/web-build-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/web-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/web-build-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/web-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/web-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/web-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/web-build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/web-build-tools/deployments","created_at":"2016-09-30T00:28:20Z","updated_at":"2016-12-04T16:21:50Z","pushed_at":"2016-12-07T01:57:26Z","git_url":"git://github.com/Microsoft/web-build-tools.git","ssh_url":"git@github.com:Microsoft/web-build-tools.git","clone_url":"https://github.com/Microsoft/web-build-tools.git","svn_url":"https://github.com/Microsoft/web-build-tools","homepage":"","size":1329,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32"},"html":{"href":"https://github.com/Microsoft/web-build-tools/pull/32"},"issue":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/issues/32"},"comments":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/634ae79f7814383697a6f7938e8ca46ac968bbc0"}}}}
{"actor":{"display_login":"nickpape-msft"}}