{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/596","repository_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle","labels_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/596/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/596/comments","events_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/596/events","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/596","id":155726496,"number":596,"title":"Fix EZP-25705: Can't add anything between 2 embeds","user":{"login":"dpobel","id":305563,"avatar_url":"https://avatars.githubusercontent.com/u/305563?v=3","gravatar_id":"","url":"https://api.github.com/users/dpobel","html_url":"https://github.com/dpobel","followers_url":"https://api.github.com/users/dpobel/followers","following_url":"https://api.github.com/users/dpobel/following{/other_user}","gists_url":"https://api.github.com/users/dpobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dpobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpobel/subscriptions","organizations_url":"https://api.github.com/users/dpobel/orgs","repos_url":"https://api.github.com/users/dpobel/repos","events_url":"https://api.github.com/users/dpobel/events{/privacy}","received_events_url":"https://api.github.com/users/dpobel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-19T12:37:46Z","updated_at":"2016-05-30T11:23:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/596","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/596","diff_url":"https://github.com/ezsystems/PlatformUIBundle/pull/596.diff","patch_url":"https://github.com/ezsystems/PlatformUIBundle/pull/596.patch"},"body":"JIRA: https://jira.ez.no/browse/EZP-25705\r\n\r\n# Description\r\n\r\nThe JIRA issue is actually about two issues:\r\n\r\n1. it's not possible to add anything between 2 embeds\r\n2. it's not possible to complete an unordered list if you put an embed in the last list item.\r\n\r\nThis patch only fixes the first issue for now and this can be seen as 3 steps:\r\n\r\n1. make sure the *add* toolbar (the plus button on the left) is available and correctly positioned when an embed receives the focus. This was not the case previously because an embed is represented in the editor by a CKEditor widget and this widget is not editable (`contenteditable` set to false) so the default AlloyEditor `add` toolbar assumes we can't add anything. To avoid that, we now use an `ezadd` toolbar which basically extend the default one to not check the content editable property.\r\n1. When adding a simple element after an embed (paragraph, heading, ...) we have to make sure the element added after the embed\r\n1. When adding another embed after an existing one, we also have to make sure the new embed is added in the right place. By default, the CKEditor engine was running the *editing process* of the widget.\r\n\r\nThis can be seen in the following screencast:\r\n\r\n[![](https://img.youtube.com/vi/mRAJcITt6yY/0.jpg)](http://www.youtube.com/watch?v=mRAJcITt6yY \"Click to play on Youtube.com\")\r\n\r\n# Tests\r\n\r\nmanual tests + unit tests"},"comment":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/comments/222471627","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/596#issuecomment-222471627","issue_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/596","id":222471627,"user":{"login":"dpobel","id":305563,"avatar_url":"https://avatars.githubusercontent.com/u/305563?v=3","gravatar_id":"","url":"https://api.github.com/users/dpobel","html_url":"https://github.com/dpobel","followers_url":"https://api.github.com/users/dpobel/followers","following_url":"https://api.github.com/users/dpobel/following{/other_user}","gists_url":"https://api.github.com/users/dpobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dpobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpobel/subscriptions","organizations_url":"https://api.github.com/users/dpobel/orgs","repos_url":"https://api.github.com/users/dpobel/repos","events_url":"https://api.github.com/users/dpobel/events{/privacy}","received_events_url":"https://api.github.com/users/dpobel/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T11:23:14Z","updated_at":"2016-05-30T11:23:14Z","body":"echo ping @StephaneDiot ;-)"}}
{"actor":{"display_login":"dpobel"}}