{"action":"created","issue":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/378","repository_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/378/labels{/name}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/378/comments","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/378/events","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/378","id":153033725,"number":378,"title":"chore(login): complete login page","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/refactor","name":"refactor","color":"fbca04"},{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/review","name":"review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-04T14:59:14Z","updated_at":"2016-05-06T08:40:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/378","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/378","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/378.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/378.patch"},"body":"This Pull Request addresses all the criteria in #222 and will close it when it lands in `master`.\r\n\r\nIt includes numerous bug fixes that prevent the user to bypassing the login page via url or $state manipulation.  It also prevents the user from getting back to the `/login` page by the same mechanism.  End-to-end tests prove all these cases work.  This should make our login interface bullet-proof.\r\n\r\nBugs have been fixed with the tree.  You can't open the tree or access the settings page when the user does not have a session.\r\n\r\nThe login page now uses the excellent `NotifyService` introduced in #370 for all server errors.  Form errors have been translated into more meaningful English, but are still displayed at the bottom of the form.  Any attempts over 3 will trigger a \"fatal\" error that informs the user to check with a sysadmin to reset their password.\r\n\r\nThe `SessionService` now notifies on login/logout with a welcome and goodbye message.  These can either be removed entirely if they seem tacky, or improved with interesting information like session duration, a personalized welcome citing the user's name, last login date, etc...\r\n\r\nFinally, the user interface has been cleaned up to address issues on small screens and tested on all the chrome dev tool's responsive settings.\r\n\r\nFor a more detailed analysis, see the commit logs.\r\n\r\nCloses #222.\r\n\r\n\r\n---\r\nThank you for contributing!\r\n\r\nBefore submitting this pull request, please verify that you have:\r\n - [x] Run your code through JSHint.  [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md).\r\n - [x] Run integration tests.\r\n - [x] Run end-to-end tests.\r\n - [x] Accurately described the changes your are making in this pull request.\r\n\r\nFor a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against.\r\n\r\nEnsuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!"},"comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments/217384212","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/378#issuecomment-217384212","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/378","id":217384212,"user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T08:40:08Z","updated_at":"2016-05-06T08:40:08Z","body":"@sfount changes have landed."}}