{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/530","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/530/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/530/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/530/events","html_url":"https://github.com/Valloric/ycmd/pull/530","id":162284763,"number":530,"title":"[READY] Check if Rust sources path exists at completer initialization","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-25T14:56:06Z","updated_at":"2016-06-26T10:19:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/530","html_url":"https://github.com/Valloric/ycmd/pull/530","diff_url":"https://github.com/Valloric/ycmd/pull/530.diff","patch_url":"https://github.com/Valloric/ycmd/pull/530.patch"},"body":"This PR is a proof that the changes introduced in PR #528 are not working as expected. By waiting for the racerd server to be ready at the start of the tests instead of waiting in the `IsolatedYcmd` decorator, the `GetCompletions_RustSrcPathSetButDoesntExist` test does not pass the CI runs. The reason is that when calling the `WaitUntilRacerdServerReady` function, the Rust completer is initialized and thus patching the `RUST_SRC_PATH` environment variable has no effect (the `_GetRustSrcPath` method is already called). In other words, the `GetCompletions_RustSrcPathSetButDoesntExist` test in its current state is identical to the `GetCompletions_WhenStandardLibraryCompletionFails_MentionRustSrcPath` one.\r\n\r\nWhen patching `RUST_SRC_PATH` before waiting for racerd, the server will not return an HTTP error but an empty list of completions. I can confirm this by setting the `RUST_SRC_PATH` variable before running Vim, editing the [`std_completions.rs` file from the test](https://github.com/Valloric/ycmd/blob/master/ycmd/tests/rust/testdata/std_completions.rs) and trying to complete the line 5. No error message appears in the status line.\r\n\r\nFrom this, I am suggesting to either revert commit e75ff91fbbeb58cf488bb189815b86def6d995b5 or check for the existence of the Rust sources path when initializing the Rust completer (we could even check if some file exists). I can make these changes in this PR.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/530)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/228594204","html_url":"https://github.com/Valloric/ycmd/pull/530#issuecomment-228594204","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/530","id":228594204,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T10:19:26Z","updated_at":"2016-06-26T10:19:26Z","body":"## [Current coverage][cc-pull] is **86.88%**\n> Merging [#530][cc-pull] into [master][cc-base-branch] will increase coverage by **0.06%**\n\n```diff\n@@             master       #530   diff @@\n==========================================\n  Files            40         40          \n  Lines          3702       3706     +4   \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n+ Hits           3214       3220     +6   \n+ Misses          488        486     -2   \n  Partials          0          0          \n```\n\n\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [9106fcb...c6a57d6][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/Valloric/ycmd/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/Valloric/ycmd/compare/9106fcb98a82ab15173c9b9872e2068fcd645a01...c6a57d64e115edea8c5116705d353322d3e95562\n[cc-pull]: https://codecov.io/gh/Valloric/ycmd/pull/530?src=pr"}}
{"actor":{"display_login":"codecov-io"}}