{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/76887646","id":76887646,"diff_hunk":"@@ -0,0 +1,108 @@\n+﻿// ----------------------------------------------------------------------------------\n+//\n+// Copyright Microsoft Corporation\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+// http://www.apache.org/licenses/LICENSE-2.0\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+// ----------------------------------------------------------------------------------\n+\n+using Microsoft.Azure.Commands.KeyVault.Models;\n+using Microsoft.Azure.KeyVault.Models;\n+using System;\n+using System.Globalization;\n+using System.Management.Automation;\n+using System.Net;\n+using System.Security;\n+\n+namespace Microsoft.Azure.Commands.KeyVault\n+{\n+    /// <summary>\n+    /// Adds a given certificate issuer to Key Vault for certificate management\n+    /// </summary>\n+    [Cmdlet(VerbsCommon.Add, CmdletNoun.AzureKeyVaultCertificateIssuer,","path":"src/ResourceManager/KeyVault/Commands.KeyVault/Commands/AddAzureKeyVaultCertificateIssuer.cs","position":28,"original_position":28,"commit_id":"f78910fbd9058b4bea6038c9ba08113e091f4588","original_commit_id":"5563780ae31aaa85ba9a74e6008b88b66536b6ed","user":{"login":"markcowl","id":1054056,"avatar_url":"https://avatars.githubusercontent.com/u/1054056?v=3","gravatar_id":"","url":"https://api.github.com/users/markcowl","html_url":"https://github.com/markcowl","followers_url":"https://api.github.com/users/markcowl/followers","following_url":"https://api.github.com/users/markcowl/following{/other_user}","gists_url":"https://api.github.com/users/markcowl/gists{/gist_id}","starred_url":"https://api.github.com/users/markcowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcowl/subscriptions","organizations_url":"https://api.github.com/users/markcowl/orgs","repos_url":"https://api.github.com/users/markcowl/repos","events_url":"https://api.github.com/users/markcowl/events{/privacy}","received_events_url":"https://api.github.com/users/markcowl/received_events","type":"User","site_admin":false},"body":"Same comments on ShouldProcess and OutputType","created_at":"2016-08-30T21:58:29Z","updated_at":"2016-08-30T21:58:29Z","html_url":"https://github.com/Azure/azure-powershell/pull/2855#discussion_r76887646","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/76887646"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/2855#discussion_r76887646"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855","id":83199678,"html_url":"https://github.com/Azure/azure-powershell/pull/2855","diff_url":"https://github.com/Azure/azure-powershell/pull/2855.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/2855.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/2855","number":2855,"state":"open","locked":false,"title":"Key Vault: Add support for certificates, move to auto-rest based net SDK","user":{"login":"rohmano","id":11966623,"avatar_url":"https://avatars.githubusercontent.com/u/11966623?v=3","gravatar_id":"","url":"https://api.github.com/users/rohmano","html_url":"https://github.com/rohmano","followers_url":"https://api.github.com/users/rohmano/followers","following_url":"https://api.github.com/users/rohmano/following{/other_user}","gists_url":"https://api.github.com/users/rohmano/gists{/gist_id}","starred_url":"https://api.github.com/users/rohmano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohmano/subscriptions","organizations_url":"https://api.github.com/users/rohmano/orgs","repos_url":"https://api.github.com/users/rohmano/repos","events_url":"https://api.github.com/users/rohmano/events{/privacy}","received_events_url":"https://api.github.com/users/rohmano/received_events","type":"User","site_admin":false},"body":"This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).\r\n\r\nBelow in **Overall Changes**, check off the boxes that apply to your PR. Within each of the categories that you select, make sure that you can check off **all** of the boxes.\r\n\r\n## Overall Changes \r\n- [Y] [**MANDATORY** - General changes](#general)\r\n- [Y] [**MANDATORY** - Add/remove/edit test(s)](#tests)\r\n- [Y] [Add/remove/edit cmdlet(s)](#cmdlet-signature)\r\n- [Y] [Add/remove/edit parameter(s)](#parameters)\r\n- [N] [Edit pipeline parameters](#parameters-and-the-pipeline)\r\n\r\n### General\r\n- [Y] Title of the PR is clear and informative\r\n- [N] There are a small number of commits that each have an informative message\r\n- [N] If it applies, references the bug/issue that the PR fixes\r\n- [Y] All files have the Microsoft copyright header\r\n- [Y] Cmdlets refer to management libraries through nuget references - no dlls are checked in\r\n- [N] The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)\r\n\r\n### Tests\r\n- [N] PR includes test coverage for the included changes\r\n- [Y] Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework\r\n- [x] PowerShell scripts used in tests must not use hard-coded values for location\r\n- [x] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources\r\n- [x] Tests should not use App.config files for settings\r\n- [x] Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording\r\n- [x] Tests should use Start-Sleep to pause rather than Thread.Sleep\r\n\r\n### Cmdlet Signature\r\n- [x] Cmdlet name uses an approved PowerShell verb - use the enums for `VerbsCommon`, `VerbsCommunication`, `VerbsLifecycle`, `VerbsOther` whenever possible\r\n- [x] Cmdlet noun name uses the AzureRm prefix for management cmdlets, and the Azure prefix for data plane cmdlets\r\n- [x] Cmdlet specifies the `OutputType` attribute if any output is produced; if the cmdlet produces no output, it should implement a `PassThrough` parameter\r\n- [x] If the cmdlet makes changes or has side effects, it should implement `ShouldProcess` and have `SupportShouldProcess = true` specified in the cmdlet attribute. See a discussion about correct `ShouldProcess` implementation [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change)\r\n- [x] Cmdlets should derive from AzureRmCmdlet for management cmdlets, and AzureDataCmdlet for data cmdlets\r\n- [x] If multiple parameter sets are implemented, the cmdlet should specify a `DefaultParameterSetName` in its cmdlet attribute\r\n\r\n### Parameters\r\n- [x] Cmdlets should have no more than four positional parameters\r\n- [x] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets\r\n- [ ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module\r\n- [x] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet\r\n- [x] Parameters should be explicitly marked as Mandatory or not, and should contain a HelpMessage\r\n- [x] No parameter is of type `object`.\r\n    - Management cmdlets should have the following parameters and aliases:\r\n        - ResourceGroupName with (optional) alias to `ResourceGroup` type string marked as [ValueFromPipelineByPropertyName]\r\n        - Name with alias to `ResourceName` type string marked as [ValueFromPipelineByPropertyName]\r\n        - Location (if appropriate) type string\r\n        - Tag, type `HashTable`\r\n\r\n### Parameters and the Pipeline\r\n- [x] Complex parameters should take values from the pipeline when possible, and certainly when they match the output type of another cmdlet\r\n- [x] Only one parameter should use ValueFromPipeline per parameter set; parameters from different parameter sets may have this attribute, but should not be convertible\r\n- [x] No parameter is of type `object`\r\n- [x] Each management cmdlet should have a parameter set that takes `ResourceGroupName` and `Name` from the pipeline by property value\r\n- [x] For a given resource type, it should be possible to pipe the output of `Get` and `New` cmdlets to the input of `Set`, `Update`, `Remove` and other action cmdlets for that resource\r\n","created_at":"2016-08-30T02:37:34Z","updated_at":"2016-08-30T21:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5166a49d69cde6f5ed82a312e1a6871439a7bcd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/2855/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/f78910fbd9058b4bea6038c9ba08113e091f4588","head":{"label":"rohmano:feature/keyvault-certificates-autorest","ref":"feature/keyvault-certificates-autorest","sha":"f78910fbd9058b4bea6038c9ba08113e091f4588","user":{"login":"rohmano","id":11966623,"avatar_url":"https://avatars.githubusercontent.com/u/11966623?v=3","gravatar_id":"","url":"https://api.github.com/users/rohmano","html_url":"https://github.com/rohmano","followers_url":"https://api.github.com/users/rohmano/followers","following_url":"https://api.github.com/users/rohmano/following{/other_user}","gists_url":"https://api.github.com/users/rohmano/gists{/gist_id}","starred_url":"https://api.github.com/users/rohmano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohmano/subscriptions","organizations_url":"https://api.github.com/users/rohmano/orgs","repos_url":"https://api.github.com/users/rohmano/repos","events_url":"https://api.github.com/users/rohmano/events{/privacy}","received_events_url":"https://api.github.com/users/rohmano/received_events","type":"User","site_admin":false},"repo":{"id":42610953,"name":"azure-powershell","full_name":"rohmano/azure-powershell","owner":{"login":"rohmano","id":11966623,"avatar_url":"https://avatars.githubusercontent.com/u/11966623?v=3","gravatar_id":"","url":"https://api.github.com/users/rohmano","html_url":"https://github.com/rohmano","followers_url":"https://api.github.com/users/rohmano/followers","following_url":"https://api.github.com/users/rohmano/following{/other_user}","gists_url":"https://api.github.com/users/rohmano/gists{/gist_id}","starred_url":"https://api.github.com/users/rohmano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohmano/subscriptions","organizations_url":"https://api.github.com/users/rohmano/orgs","repos_url":"https://api.github.com/users/rohmano/repos","events_url":"https://api.github.com/users/rohmano/events{/privacy}","received_events_url":"https://api.github.com/users/rohmano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohmano/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/rohmano/azure-powershell","forks_url":"https://api.github.com/repos/rohmano/azure-powershell/forks","keys_url":"https://api.github.com/repos/rohmano/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohmano/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohmano/azure-powershell/teams","hooks_url":"https://api.github.com/repos/rohmano/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/rohmano/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/rohmano/azure-powershell/events","assignees_url":"https://api.github.com/repos/rohmano/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/rohmano/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/rohmano/azure-powershell/tags","blobs_url":"https://api.github.com/repos/rohmano/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohmano/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohmano/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohmano/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohmano/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/rohmano/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/rohmano/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/rohmano/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/rohmano/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/rohmano/azure-powershell/subscription","commits_url":"https://api.github.com/repos/rohmano/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohmano/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohmano/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohmano/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohmano/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/rohmano/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohmano/azure-powershell/merges","archive_url":"https://api.github.com/repos/rohmano/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohmano/azure-powershell/downloads","issues_url":"https://api.github.com/repos/rohmano/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/rohmano/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/rohmano/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/rohmano/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohmano/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/rohmano/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/rohmano/azure-powershell/deployments","created_at":"2015-09-16T20:15:16Z","updated_at":"2016-03-07T21:46:10Z","pushed_at":"2016-08-30T21:53:59Z","git_url":"git://github.com/rohmano/azure-powershell.git","ssh_url":"git@github.com:rohmano/azure-powershell.git","clone_url":"https://github.com/rohmano/azure-powershell.git","svn_url":"https://github.com/rohmano/azure-powershell","homepage":null,"size":184809,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"eefe2ec87220a142b0ffec50a019e2d753f449f5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2016-08-30T20:47:27Z","pushed_at":"2016-08-30T21:54:00Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":320042,"stargazers_count":533,"watchers_count":533,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":446,"forks":503,"open_issues":446,"watchers":533,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/2855"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/2855"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/2855/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/2855/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/f78910fbd9058b4bea6038c9ba08113e091f4588"}}}}
{"actor":{"display_login":"markcowl"}}