{"action":"created","comment":{"url":"https://api.github.com/repos/njoy/unit/pulls/comments/66149687","id":66149687,"diff_hunk":"@@ -0,0 +1,128 @@\n+#ifndef UNIT_LENGTH_HPP\n+#define UNIT_LENGTH_HPP\n+\n+#include <istream>\n+\n+#include \"unit/scale.hpp\"\n+\n+namespace unit {\n+namespace length {\n+\n+enum class Unit {\n+  meter,\n+  centimeter,\n+  millimeter,\n+  micrometer,\n+  nanometer\n+};\n+\n+template< Unit length >\n+const std::string name;\n+\n+/** \n+ * @brief \n+ * A macro defining a constant string describing the name a argument unit \n+ */\n+#define DEFINE_NAME( unit, unitName)\\","path":"length.hpp.in","position":26,"original_position":26,"commit_id":"dfd0f67f69b1c265eb4fb4b028310a7142147e42","original_commit_id":"dfd0f67f69b1c265eb4fb4b028310a7142147e42","user":{"login":"whaeck","id":18539456,"avatar_url":"https://avatars.githubusercontent.com/u/18539456?v=3","gravatar_id":"","url":"https://api.github.com/users/whaeck","html_url":"https://github.com/whaeck","followers_url":"https://api.github.com/users/whaeck/followers","following_url":"https://api.github.com/users/whaeck/following{/other_user}","gists_url":"https://api.github.com/users/whaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/whaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whaeck/subscriptions","organizations_url":"https://api.github.com/users/whaeck/orgs","repos_url":"https://api.github.com/users/whaeck/repos","events_url":"https://api.github.com/users/whaeck/events{/privacy}","received_events_url":"https://api.github.com/users/whaeck/received_events","type":"User","site_admin":false},"body":"I agree, single responsibility should be a standard. Let's just leave this as is.","created_at":"2016-06-07T20:48:03Z","updated_at":"2016-06-07T20:48:03Z","html_url":"https://github.com/njoy/unit/pull/2#discussion_r66149687","pull_request_url":"https://api.github.com/repos/njoy/unit/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/njoy/unit/pulls/comments/66149687"},"html":{"href":"https://github.com/njoy/unit/pull/2#discussion_r66149687"},"pull_request":{"href":"https://api.github.com/repos/njoy/unit/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/njoy/unit/pulls/2","id":71479370,"html_url":"https://github.com/njoy/unit/pull/2","diff_url":"https://github.com/njoy/unit/pull/2.diff","patch_url":"https://github.com/njoy/unit/pull/2.patch","issue_url":"https://api.github.com/repos/njoy/unit/issues/2","number":2,"state":"open","locked":false,"title":"Feature/refactor","user":{"login":"apmccartney","id":3707548,"avatar_url":"https://avatars.githubusercontent.com/u/3707548?v=3","gravatar_id":"","url":"https://api.github.com/users/apmccartney","html_url":"https://github.com/apmccartney","followers_url":"https://api.github.com/users/apmccartney/followers","following_url":"https://api.github.com/users/apmccartney/following{/other_user}","gists_url":"https://api.github.com/users/apmccartney/gists{/gist_id}","starred_url":"https://api.github.com/users/apmccartney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apmccartney/subscriptions","organizations_url":"https://api.github.com/users/apmccartney/orgs","repos_url":"https://api.github.com/users/apmccartney/repos","events_url":"https://api.github.com/users/apmccartney/events{/privacy}","received_events_url":"https://api.github.com/users/apmccartney/received_events","type":"User","site_admin":false},"body":"squashed commit history =(","created_at":"2016-05-25T23:31:06Z","updated_at":"2016-06-07T20:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e552b7d84bafe320efac4762ae61d2fb3c9df7a","assignee":{"login":"whaeck","id":18539456,"avatar_url":"https://avatars.githubusercontent.com/u/18539456?v=3","gravatar_id":"","url":"https://api.github.com/users/whaeck","html_url":"https://github.com/whaeck","followers_url":"https://api.github.com/users/whaeck/followers","following_url":"https://api.github.com/users/whaeck/following{/other_user}","gists_url":"https://api.github.com/users/whaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/whaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whaeck/subscriptions","organizations_url":"https://api.github.com/users/whaeck/orgs","repos_url":"https://api.github.com/users/whaeck/repos","events_url":"https://api.github.com/users/whaeck/events{/privacy}","received_events_url":"https://api.github.com/users/whaeck/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/njoy/unit/pulls/2/commits","review_comments_url":"https://api.github.com/repos/njoy/unit/pulls/2/comments","review_comment_url":"https://api.github.com/repos/njoy/unit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/njoy/unit/issues/2/comments","statuses_url":"https://api.github.com/repos/njoy/unit/statuses/dfd0f67f69b1c265eb4fb4b028310a7142147e42","head":{"label":"njoy:feature/refactor","ref":"feature/refactor","sha":"dfd0f67f69b1c265eb4fb4b028310a7142147e42","user":{"login":"njoy","id":17747175,"avatar_url":"https://avatars.githubusercontent.com/u/17747175?v=3","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"repo":{"id":57335706,"name":"unit","full_name":"njoy/unit","owner":{"login":"njoy","id":17747175,"avatar_url":"https://avatars.githubusercontent.com/u/17747175?v=3","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/njoy/unit","description":"A library for dimensional analysis and physical quantities with underlying units","fork":false,"url":"https://api.github.com/repos/njoy/unit","forks_url":"https://api.github.com/repos/njoy/unit/forks","keys_url":"https://api.github.com/repos/njoy/unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njoy/unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njoy/unit/teams","hooks_url":"https://api.github.com/repos/njoy/unit/hooks","issue_events_url":"https://api.github.com/repos/njoy/unit/issues/events{/number}","events_url":"https://api.github.com/repos/njoy/unit/events","assignees_url":"https://api.github.com/repos/njoy/unit/assignees{/user}","branches_url":"https://api.github.com/repos/njoy/unit/branches{/branch}","tags_url":"https://api.github.com/repos/njoy/unit/tags","blobs_url":"https://api.github.com/repos/njoy/unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njoy/unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njoy/unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/njoy/unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njoy/unit/statuses/{sha}","languages_url":"https://api.github.com/repos/njoy/unit/languages","stargazers_url":"https://api.github.com/repos/njoy/unit/stargazers","contributors_url":"https://api.github.com/repos/njoy/unit/contributors","subscribers_url":"https://api.github.com/repos/njoy/unit/subscribers","subscription_url":"https://api.github.com/repos/njoy/unit/subscription","commits_url":"https://api.github.com/repos/njoy/unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/njoy/unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/njoy/unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/njoy/unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/njoy/unit/contents/{+path}","compare_url":"https://api.github.com/repos/njoy/unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njoy/unit/merges","archive_url":"https://api.github.com/repos/njoy/unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njoy/unit/downloads","issues_url":"https://api.github.com/repos/njoy/unit/issues{/number}","pulls_url":"https://api.github.com/repos/njoy/unit/pulls{/number}","milestones_url":"https://api.github.com/repos/njoy/unit/milestones{/number}","notifications_url":"https://api.github.com/repos/njoy/unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njoy/unit/labels{/name}","releases_url":"https://api.github.com/repos/njoy/unit/releases{/id}","deployments_url":"https://api.github.com/repos/njoy/unit/deployments","created_at":"2016-04-28T21:43:15Z","updated_at":"2016-04-29T17:39:42Z","pushed_at":"2016-06-01T22:12:10Z","git_url":"git://github.com/njoy/unit.git","ssh_url":"git@github.com:njoy/unit.git","clone_url":"https://github.com/njoy/unit.git","svn_url":"https://github.com/njoy/unit","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"njoy:master","ref":"master","sha":"59bff64966019b3f0dcbae75675088972aea7cdc","user":{"login":"njoy","id":17747175,"avatar_url":"https://avatars.githubusercontent.com/u/17747175?v=3","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"repo":{"id":57335706,"name":"unit","full_name":"njoy/unit","owner":{"login":"njoy","id":17747175,"avatar_url":"https://avatars.githubusercontent.com/u/17747175?v=3","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/njoy/unit","description":"A library for dimensional analysis and physical quantities with underlying units","fork":false,"url":"https://api.github.com/repos/njoy/unit","forks_url":"https://api.github.com/repos/njoy/unit/forks","keys_url":"https://api.github.com/repos/njoy/unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njoy/unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njoy/unit/teams","hooks_url":"https://api.github.com/repos/njoy/unit/hooks","issue_events_url":"https://api.github.com/repos/njoy/unit/issues/events{/number}","events_url":"https://api.github.com/repos/njoy/unit/events","assignees_url":"https://api.github.com/repos/njoy/unit/assignees{/user}","branches_url":"https://api.github.com/repos/njoy/unit/branches{/branch}","tags_url":"https://api.github.com/repos/njoy/unit/tags","blobs_url":"https://api.github.com/repos/njoy/unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njoy/unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njoy/unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/njoy/unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njoy/unit/statuses/{sha}","languages_url":"https://api.github.com/repos/njoy/unit/languages","stargazers_url":"https://api.github.com/repos/njoy/unit/stargazers","contributors_url":"https://api.github.com/repos/njoy/unit/contributors","subscribers_url":"https://api.github.com/repos/njoy/unit/subscribers","subscription_url":"https://api.github.com/repos/njoy/unit/subscription","commits_url":"https://api.github.com/repos/njoy/unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/njoy/unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/njoy/unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/njoy/unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/njoy/unit/contents/{+path}","compare_url":"https://api.github.com/repos/njoy/unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njoy/unit/merges","archive_url":"https://api.github.com/repos/njoy/unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njoy/unit/downloads","issues_url":"https://api.github.com/repos/njoy/unit/issues{/number}","pulls_url":"https://api.github.com/repos/njoy/unit/pulls{/number}","milestones_url":"https://api.github.com/repos/njoy/unit/milestones{/number}","notifications_url":"https://api.github.com/repos/njoy/unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njoy/unit/labels{/name}","releases_url":"https://api.github.com/repos/njoy/unit/releases{/id}","deployments_url":"https://api.github.com/repos/njoy/unit/deployments","created_at":"2016-04-28T21:43:15Z","updated_at":"2016-04-29T17:39:42Z","pushed_at":"2016-06-01T22:12:10Z","git_url":"git://github.com/njoy/unit.git","ssh_url":"git@github.com:njoy/unit.git","clone_url":"https://github.com/njoy/unit.git","svn_url":"https://github.com/njoy/unit","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/njoy/unit/pulls/2"},"html":{"href":"https://github.com/njoy/unit/pull/2"},"issue":{"href":"https://api.github.com/repos/njoy/unit/issues/2"},"comments":{"href":"https://api.github.com/repos/njoy/unit/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/njoy/unit/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/njoy/unit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/njoy/unit/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/njoy/unit/statuses/dfd0f67f69b1c265eb4fb4b028310a7142147e42"}}}}
{"actor":{"display_login":"whaeck"}}