{"action":"created","comment":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/comments/83940393","pull_request_review_id":4750443,"id":83940393,"diff_hunk":"@@ -13,8 +13,24 @@ import (\n \t\"github.com/scootdev/scoot/workerapi/gen-go/worker\"\n )\n \n+// Creates a Worker Server\n+func MakeServer(\n+\thandler worker.Worker,\n+\ttransport thrift.TServerTransport,\n+\ttransportFactory thrift.TTransportFactory,\n+\tprotocolFactory thrift.TProtocolFactory) thrift.TServer {\n+\treturn thrift.NewTSimpleServer4(\n+\t\tworker.NewWorkerProcessor(handler),\n+\t\ttransport,\n+\t\ttransportFactory,\n+\t\tprotocolFactory)\n+}\n+\n // Called by a main binary. Blocks until the connection is terminated.\n-func Serve(handler worker.Worker, addr string, transportFactory thrift.TTransportFactory, protocolFactory thrift.TProtocolFactory) error {\n+func Serve(","path":"workerapi/server/server.go","position":19,"original_position":19,"commit_id":"d5784b70e3bba2e878d779f318ff8ae7fd3f285e","original_commit_id":"c3ec2c5b4f038b0b01f38d181da280bd06d6863f","user":{"login":"CaitieM20","id":3310141,"avatar_url":"https://avatars.githubusercontent.com/u/3310141?v=3","gravatar_id":"","url":"https://api.github.com/users/CaitieM20","html_url":"https://github.com/CaitieM20","followers_url":"https://api.github.com/users/CaitieM20/followers","following_url":"https://api.github.com/users/CaitieM20/following{/other_user}","gists_url":"https://api.github.com/users/CaitieM20/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitieM20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitieM20/subscriptions","organizations_url":"https://api.github.com/users/CaitieM20/orgs","repos_url":"https://api.github.com/users/CaitieM20/repos","events_url":"https://api.github.com/users/CaitieM20/events{/privacy}","received_events_url":"https://api.github.com/users/CaitieM20/received_events","type":"User","site_admin":false},"body":"its not right now, but removing this would cause a breaking change in Twitter Source.  \r\n\r\nMy plan is to merge this, then update Twitter Source.  Then submit a final OSS pull request removing this method.  That way we don't have to expertly time merges. ","created_at":"2016-10-18T20:12:51Z","updated_at":"2016-10-18T20:13:47Z","html_url":"https://github.com/scootdev/scoot/pull/139#discussion_r83940393","pull_request_url":"https://api.github.com/repos/scootdev/scoot/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments/83940393"},"html":{"href":"https://github.com/scootdev/scoot/pull/139#discussion_r83940393"},"pull_request":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/139","id":89728687,"html_url":"https://github.com/scootdev/scoot/pull/139","diff_url":"https://github.com/scootdev/scoot/pull/139.diff","patch_url":"https://github.com/scootdev/scoot/pull/139.patch","issue_url":"https://api.github.com/repos/scootdev/scoot/issues/139","number":139,"state":"open","locked":false,"title":"[WorkerServer] Refactor Common Startup Code & Add Config","user":{"login":"CaitieM20","id":3310141,"avatar_url":"https://avatars.githubusercontent.com/u/3310141?v=3","gravatar_id":"","url":"https://api.github.com/users/CaitieM20","html_url":"https://github.com/CaitieM20","followers_url":"https://api.github.com/users/CaitieM20/followers","following_url":"https://api.github.com/users/CaitieM20/following{/other_user}","gists_url":"https://api.github.com/users/CaitieM20/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitieM20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitieM20/subscriptions","organizations_url":"https://api.github.com/users/CaitieM20/orgs","repos_url":"https://api.github.com/users/CaitieM20/repos","events_url":"https://api.github.com/users/CaitieM20/events{/privacy}","received_events_url":"https://api.github.com/users/CaitieM20/received_events","type":"User","site_admin":false},"body":"Config and WorkerServer Refactor to mimic [Scheduler](https://github.com/scootdev/scoot/commit/bafe23b1cc396762b297f2cd6233a04d82e9ce69)\r\n- Added config file to ./binaries/workerserver/main.go, we don't have config now but will\r\n- Refactored common startup code out of ./binaries/workerserver/main.go and put it into workerserver/setup.go\r\n- Made WorkerServer use the Magic Bag to initialize services so that we don't have to pass http_addr and thrift_addr through as individual params\r\n\r\ntested via \r\ngo run ./binaries/setup-cloud-scoot/main.go --strategy local.local\r\ngo run ./binaries/scootapi/main.go run_smoke_test\r\n","created_at":"2016-10-18T00:41:56Z","updated_at":"2016-10-18T20:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a385d742a8906b37595b23e0ed0eb787dbf0ec1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scootdev/scoot/pulls/139/commits","review_comments_url":"https://api.github.com/repos/scootdev/scoot/pulls/139/comments","review_comment_url":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scootdev/scoot/issues/139/comments","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/d5784b70e3bba2e878d779f318ff8ae7fd3f285e","head":{"label":"scootdev:caitie/workerConfig","ref":"caitie/workerConfig","sha":"d5784b70e3bba2e878d779f318ff8ae7fd3f285e","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":null,"fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-09-22T11:36:11Z","pushed_at":"2016-10-18T20:13:20Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":"","size":7682,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":10,"default_branch":"master"}},"base":{"label":"scootdev:master","ref":"master","sha":"f45186d82a2eacb2f93bc2509b1e534a7a614946","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":null,"fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-09-22T11:36:11Z","pushed_at":"2016-10-18T20:13:20Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":"","size":7682,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/139"},"html":{"href":"https://github.com/scootdev/scoot/pull/139"},"issue":{"href":"https://api.github.com/repos/scootdev/scoot/issues/139"},"comments":{"href":"https://api.github.com/repos/scootdev/scoot/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/scootdev/scoot/statuses/d5784b70e3bba2e878d779f318ff8ae7fd3f285e"}}}}
{"actor":{"display_login":"CaitieM20"}}