{"comment":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/comments/18435233","html_url":"https://github.com/01org/TPM2.0-TSS/commit/be669f5c79a9436c63ec29808967fe62679dc2df#commitcomment-18435233","id":18435233,"user":{"login":"wcarthur1","id":4679032,"avatar_url":"https://avatars.githubusercontent.com/u/4679032?v=3","gravatar_id":"","url":"https://api.github.com/users/wcarthur1","html_url":"https://github.com/wcarthur1","followers_url":"https://api.github.com/users/wcarthur1/followers","following_url":"https://api.github.com/users/wcarthur1/following{/other_user}","gists_url":"https://api.github.com/users/wcarthur1/gists{/gist_id}","starred_url":"https://api.github.com/users/wcarthur1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcarthur1/subscriptions","organizations_url":"https://api.github.com/users/wcarthur1/orgs","repos_url":"https://api.github.com/users/wcarthur1/repos","events_url":"https://api.github.com/users/wcarthur1/events{/privacy}","received_events_url":"https://api.github.com/users/wcarthur1/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"be669f5c79a9436c63ec29808967fe62679dc2df","created_at":"2016-07-28T17:04:37Z","updated_at":"2016-07-28T17:04:37Z","body":"Philip,\r\n\r\nA couple issues with this:\r\n1.  sysContext == NULL could never occur because I always check for NULL before calling CommonPreparePrologue.\r\n2.  You fix doesn't really fix the problem, since any follow on functions in _Prepare calls will also try to access the sysContext structure.  You've just pushed the NULL pointer dereference problem down the road to the next function that tries to use the context.\r\n\r\nI agree that my original code was bad if it ever got a NULL sysContext pointer, but that will never happen.  The real fix here is to remove the check in CommonPreparePrologue.  It was probably in there as an artifact of earlier development before I added a test case, found this issue, and added the check in all the _Prepare functions."}}
{"actor":{"display_login":"wcarthur1"}}