{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/68861739","id":68861739,"diff_hunk":"@@ -33,11 +34,12 @@ def get(self):\n       cluster = self.get_argument_cluster()\n       environ = self.get_argument_environ()\n       topology_name = self.get_argument_topology()\n+      role = self.get_argument(constants.PARAM_ROLE, default=None)","path":"heron/tracker/src/python/handlers/containerfilehandler.py","position":12,"original_position":12,"commit_id":"974e4dc616d5ca3e4faf18b9734da473e9de0476","original_commit_id":"974e4dc616d5ca3e4faf18b9734da473e9de0476","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"body":"why other parameters have very specific method but not this one?\r\n\r\nis there any method like `self.get_argumemt_role()`?","created_at":"2016-06-28T23:23:42Z","updated_at":"2016-06-28T23:23:42Z","html_url":"https://github.com/twitter/heron/pull/979#discussion_r68861739","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/68861739"},"html":{"href":"https://github.com/twitter/heron/pull/979#discussion_r68861739"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/979","id":75039988,"html_url":"https://github.com/twitter/heron/pull/979","diff_url":"https://github.com/twitter/heron/pull/979.diff","patch_url":"https://github.com/twitter/heron/pull/979.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/979","number":979,"state":"open","locked":false,"title":"Tracker with role","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"body":"1. Extend tracker APIs with ``role`` parameter so that tracker can provide APIs that queries topologies with role/submission_user matching specified ``role`` parameter\r\n\r\n2. Move Tracker API call wrappers to ``heron/common`` since both ``heron-ui`` and ``heron-explorer`` have them as dependency.\r\n\r\nRelated to #972 ","created_at":"2016-06-23T22:47:16Z","updated_at":"2016-06-28T23:23:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5184157a11aab7a530f6a51358207b950d5b04f","assignee":{"login":"kramasamy","id":367684,"avatar_url":"https://avatars.githubusercontent.com/u/367684?v=3","gravatar_id":"","url":"https://api.github.com/users/kramasamy","html_url":"https://github.com/kramasamy","followers_url":"https://api.github.com/users/kramasamy/followers","following_url":"https://api.github.com/users/kramasamy/following{/other_user}","gists_url":"https://api.github.com/users/kramasamy/gists{/gist_id}","starred_url":"https://api.github.com/users/kramasamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kramasamy/subscriptions","organizations_url":"https://api.github.com/users/kramasamy/orgs","repos_url":"https://api.github.com/users/kramasamy/repos","events_url":"https://api.github.com/users/kramasamy/events{/privacy}","received_events_url":"https://api.github.com/users/kramasamy/received_events","type":"User","site_admin":false},"assignees":[{"login":"kramasamy","id":367684,"avatar_url":"https://avatars.githubusercontent.com/u/367684?v=3","gravatar_id":"","url":"https://api.github.com/users/kramasamy","html_url":"https://github.com/kramasamy","followers_url":"https://api.github.com/users/kramasamy/followers","following_url":"https://api.github.com/users/kramasamy/following{/other_user}","gists_url":"https://api.github.com/users/kramasamy/gists{/gist_id}","starred_url":"https://api.github.com/users/kramasamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kramasamy/subscriptions","organizations_url":"https://api.github.com/users/kramasamy/orgs","repos_url":"https://api.github.com/users/kramasamy/repos","events_url":"https://api.github.com/users/kramasamy/events{/privacy}","received_events_url":"https://api.github.com/users/kramasamy/received_events","type":"User","site_admin":false},{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/979/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/979/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/979/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/974e4dc616d5ca3e4faf18b9734da473e9de0476","head":{"label":"objmagic:tracker-with-role","ref":"tracker-with-role","sha":"974e4dc616d5ca3e4faf18b9734da473e9de0476","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"repo":{"id":59701078,"name":"heron","full_name":"objmagic/heron","owner":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objmagic/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/objmagic/heron","forks_url":"https://api.github.com/repos/objmagic/heron/forks","keys_url":"https://api.github.com/repos/objmagic/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objmagic/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objmagic/heron/teams","hooks_url":"https://api.github.com/repos/objmagic/heron/hooks","issue_events_url":"https://api.github.com/repos/objmagic/heron/issues/events{/number}","events_url":"https://api.github.com/repos/objmagic/heron/events","assignees_url":"https://api.github.com/repos/objmagic/heron/assignees{/user}","branches_url":"https://api.github.com/repos/objmagic/heron/branches{/branch}","tags_url":"https://api.github.com/repos/objmagic/heron/tags","blobs_url":"https://api.github.com/repos/objmagic/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objmagic/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objmagic/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/objmagic/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objmagic/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/objmagic/heron/languages","stargazers_url":"https://api.github.com/repos/objmagic/heron/stargazers","contributors_url":"https://api.github.com/repos/objmagic/heron/contributors","subscribers_url":"https://api.github.com/repos/objmagic/heron/subscribers","subscription_url":"https://api.github.com/repos/objmagic/heron/subscription","commits_url":"https://api.github.com/repos/objmagic/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/objmagic/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/objmagic/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/objmagic/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/objmagic/heron/contents/{+path}","compare_url":"https://api.github.com/repos/objmagic/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objmagic/heron/merges","archive_url":"https://api.github.com/repos/objmagic/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objmagic/heron/downloads","issues_url":"https://api.github.com/repos/objmagic/heron/issues{/number}","pulls_url":"https://api.github.com/repos/objmagic/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/objmagic/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/objmagic/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objmagic/heron/labels{/name}","releases_url":"https://api.github.com/repos/objmagic/heron/releases{/id}","deployments_url":"https://api.github.com/repos/objmagic/heron/deployments","created_at":"2016-05-25T22:08:44Z","updated_at":"2016-05-25T22:08:47Z","pushed_at":"2016-06-28T21:04:35Z","git_url":"git://github.com/objmagic/heron.git","ssh_url":"git@github.com:objmagic/heron.git","clone_url":"https://github.com/objmagic/heron.git","svn_url":"https://github.com/objmagic/heron","homepage":"http://heronstreaming.io","size":108475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"f9882b325e3f5d257693f087d13263192016c075","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2016-06-28T10:55:44Z","pushed_at":"2016-06-28T22:59:18Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":130968,"stargazers_count":2073,"watchers_count":2073,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":314,"mirror_url":null,"open_issues_count":146,"forks":314,"open_issues":146,"watchers":2073,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/979"},"html":{"href":"https://github.com/twitter/heron/pull/979"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/979"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/974e4dc616d5ca3e4faf18b9734da473e9de0476"}}}}
{"actor":{"display_login":"nlu90"}}