{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75692942","id":75692942,"diff_hunk":"@@ -120,20 +120,19 @@ type Request struct {\n }\n \n // NewRequest creates a new request helper object for accessing runtime.Objects on a server.\n-func NewRequest(client HTTPClient, verb string, baseURL *url.URL, versionedAPIPath string, content ContentConfig, serializers Serializers, backoff BackoffManager, throttle flowcontrol.RateLimiter) *Request {\n+func NewRequest(client HTTPClient, verb string, urlProvider URLProvider, versionedAPIPath string, content ContentConfig, serializers Serializers, backoff BackoffManager, throttle flowcontrol.RateLimiter) *Request {\n \tif backoff == nil {\n \t\tglog.V(2).Infof(\"Not implementing request backoff strategy.\")\n \t\tbackoff = &NoBackoff{}\n \t}\n-\n \tpathPrefix := \"/\"\n-\tif baseURL != nil {\n-\t\tpathPrefix = path.Join(pathPrefix, baseURL.Path)\n+\tif u := urlProvider.Get(); u != nil {","path":"pkg/client/restclient/request.go","position":23,"original_position":23,"commit_id":"12c65cf1a454d0595e0fc4fefb68c221c1f07eba","original_commit_id":"12c65cf1a454d0595e0fc4fefb68c221c1f07eba","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"body":"thanks, looks like simple change in URL method","created_at":"2016-08-22T14:56:22Z","updated_at":"2016-08-22T14:56:22Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30588#discussion_r75692942","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75692942"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30588#discussion_r75692942"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588","id":81243189,"html_url":"https://github.com/kubernetes/kubernetes/pull/30588","diff_url":"https://github.com/kubernetes/kubernetes/pull/30588.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30588.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30588","number":30588,"state":"open","locked":false,"title":"Use multiple hosts in restclient","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"body":"The goal of this change is not to provide load balancing, but rely on multiple masters in clients and remove single point of failure\r\n\r\n**Release note**:\r\n```\r\nTo configure additional api servers for kube-proxy/kubelet use servers variable in kubeconfig or --api-servers command line flag. \r\nIf both will be provided - --api-servers flag will overwrite servers.\r\nAdditionally if --master flag or server variable in kubeconfig are provided - they will be used as a first api server to connect with.\r\nIn kubectl additional api servers can be specified using kubeconfig.\r\n\r\nIn 1.4 release no load-balancing, in client, between multiple-servers will be available. In case of connection failure rest client will try to connect to all provided api servers once.\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30588)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-14T13:21:39Z","updated_at":"2016-08-22T14:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7359b7c9cb6d52376c8cf3da804be5c95859f76","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30588/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/12c65cf1a454d0595e0fc4fefb68c221c1f07eba","head":{"label":"dshulyak:multihosts","ref":"multihosts","sha":"12c65cf1a454d0595e0fc4fefb68c221c1f07eba","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"repo":{"id":30866948,"name":"kubernetes","full_name":"dshulyak/kubernetes","owner":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dshulyak/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/dshulyak/kubernetes","forks_url":"https://api.github.com/repos/dshulyak/kubernetes/forks","keys_url":"https://api.github.com/repos/dshulyak/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dshulyak/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dshulyak/kubernetes/teams","hooks_url":"https://api.github.com/repos/dshulyak/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dshulyak/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dshulyak/kubernetes/events","assignees_url":"https://api.github.com/repos/dshulyak/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dshulyak/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dshulyak/kubernetes/tags","blobs_url":"https://api.github.com/repos/dshulyak/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dshulyak/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dshulyak/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dshulyak/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dshulyak/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dshulyak/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dshulyak/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dshulyak/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dshulyak/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dshulyak/kubernetes/subscription","commits_url":"https://api.github.com/repos/dshulyak/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dshulyak/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dshulyak/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dshulyak/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dshulyak/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dshulyak/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dshulyak/kubernetes/merges","archive_url":"https://api.github.com/repos/dshulyak/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dshulyak/kubernetes/downloads","issues_url":"https://api.github.com/repos/dshulyak/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dshulyak/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dshulyak/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dshulyak/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dshulyak/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dshulyak/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dshulyak/kubernetes/deployments","created_at":"2015-02-16T12:16:17Z","updated_at":"2015-02-16T12:16:21Z","pushed_at":"2016-08-22T13:42:54Z","git_url":"git://github.com/dshulyak/kubernetes.git","ssh_url":"git@github.com:dshulyak/kubernetes.git","clone_url":"https://github.com/dshulyak/kubernetes.git","svn_url":"https://github.com/dshulyak/kubernetes","homepage":"http://kubernetes.io","size":305102,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"cfe7a4391a22a071f0eaf9e3a2d491e18020ceb9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-22T13:49:20Z","pushed_at":"2016-08-22T14:47:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":534907,"stargazers_count":16254,"watchers_count":16254,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5220,"mirror_url":null,"open_issues_count":4205,"forks":5220,"open_issues":4205,"watchers":16254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30588"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30588"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30588/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30588/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/12c65cf1a454d0595e0fc4fefb68c221c1f07eba"}}}}
{"actor":{"display_login":"dshulyak"}}