{"action":"created","issue":{"url":"https://api.github.com/repos/soc/threetenbp/issues/24","repository_url":"https://api.github.com/repos/soc/threetenbp","labels_url":"https://api.github.com/repos/soc/threetenbp/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/soc/threetenbp/issues/24/comments","events_url":"https://api.github.com/repos/soc/threetenbp/issues/24/events","html_url":"https://github.com/soc/threetenbp/pull/24","id":162244604,"number":24,"title":"scalajs and locales tests","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-24T22:48:31Z","updated_at":"2016-06-29T19:30:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/soc/threetenbp/pulls/24","html_url":"https://github.com/soc/threetenbp/pull/24","diff_url":"https://github.com/soc/threetenbp/pull/24.diff","patch_url":"https://github.com/soc/threetenbp/pull/24.patch"},"body":"I'm sending this PR to discuss how to get `threetenbp` running in `scala.js`, filling some missing bits and adapting the tests. This PR is exploratory, it shouldn't be merged yet.\r\n\r\nIt includes\r\n* Use a snapshot of the port of java locales: [scalajs-locales](https://github.com/cquiroz/scalajs-locales). For now, the `scalajs-locales` just supports  the `Locale` and `DecimalFormatSymbols` classes, and loading of data from CLDR.\r\n* Convert `TestDecimalStyle` to junit\r\n* Update the build to run the js tests using junit\r\n\r\nSome important notes\r\n\r\n- `TestDecimalStyle` was moved from `jvm/src/test` to `shared/src/test` to make it run in both environments JVM/JS\r\n- For some reason I cannot access some `jUnit` functions that you can with the setup used in `scalajs-java-time` or `scalajs-locales`, in particular I get a linking error calling a function `assertEquals` where the arguments are primitives. I tried all kind of ways to get it to work, the dependencies are the same comparing projects, but still it breaks. So I replaced the `assertEquals` calls with `assertTrue(...)`, far from ideal\r\n- I disabled the coverage tasks on travis, apparently they are not supported in scala.js\r\n- `scalajs-locales` is still a work in progress, hence the snapshot, in the near future it should support the rest needed for `threetenbp`\r\n\r\nAny comments are welcome. Do you think the project could be converted to be more like the `scalajs-java-time` project?"},"comment":{"url":"https://api.github.com/repos/soc/threetenbp/issues/comments/229462956","html_url":"https://github.com/soc/threetenbp/pull/24#issuecomment-229462956","issue_url":"https://api.github.com/repos/soc/threetenbp/issues/24","id":229462956,"user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T19:30:42Z","updated_at":"2016-06-29T19:30:42Z","body":"I found the issue removing the transitive jUnit instance brought by the novocode junit adapter. Now I can reuse the test code"}}
{"actor":{"display_login":"cquiroz"}}