{"action":"created","issue":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1045","repository_url":"https://api.github.com/repos/Smoothieware/Smoothieware","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1045/labels{/name}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1045/comments","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1045/events","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1045","id":183555695,"number":1045,"title":"fixed the runaway temperature monitor.","user":{"login":"michael-moore0","id":22661780,"avatar_url":"https://avatars.githubusercontent.com/u/22661780?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-moore0","html_url":"https://github.com/michael-moore0","followers_url":"https://api.github.com/users/michael-moore0/followers","following_url":"https://api.github.com/users/michael-moore0/following{/other_user}","gists_url":"https://api.github.com/users/michael-moore0/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-moore0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-moore0/subscriptions","organizations_url":"https://api.github.com/users/michael-moore0/orgs","repos_url":"https://api.github.com/users/michael-moore0/repos","events_url":"https://api.github.com/users/michael-moore0/events{/privacy}","received_events_url":"https://api.github.com/users/michael-moore0/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-17T23:39:14Z","updated_at":"2016-10-18T04:19:48Z","closed_at":"2016-10-18T04:19:48Z","pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/1045","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1045","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/1045.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/1045.patch"},"body":"@arthurwolf asked that I fix a runaway temperature bug.  The original runaway monitor was added in https://github.com/Smoothieware/Smoothieware/pull/782.  There has been a bug described as follows:\r\n\r\n>If you are at a given temperature, and ask the firmware ( via a Gcode ) to change the target temperature, and the difference between the two is higher than the detection offset, it will erroneously trigger the error even though the action was legitimate.\r\n\r\nI modified the monitoring states a bit, adding a state where the target temperature is lower than the current temperature.  I modified the `HEATING_UP` and `COOLING_DOWN` states to monitor increase and decrease from the previously checked value.  The `MAINTAIN_TEMPERATURE` state still monitors a range around the target.\r\n\r\nI modified my config file as follows:\r\n>\\# runaway temperature parameters.\r\nrunaway_range                                  20             # maintain temp within +/- 20C.\r\nrunaway_heating_timeout                        20             # halt if temperature stalls for 20 seconds (heating or cooling).\r\n\r\nThis should result in the following behavior:\r\n1.  If the temperature must be raised to attain the target and the temperature fails to increase for 20 seconds, the `HALT` condition is set.\r\n2.  If the temperature must be lowered to attain the target and the temperature fails to decrease for 20 seconds, the `HALT` condition is set.\r\n3.  If the target is attained and the temperature is being maintained, the `HALT` condition is set if the temperature is outside the range of +/- 20C from the target."},"comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/254402894","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1045#issuecomment-254402894","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1045","id":254402894,"user":{"login":"wolfmanjm","id":22263,"avatar_url":"https://avatars.githubusercontent.com/u/22263?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfmanjm","html_url":"https://github.com/wolfmanjm","followers_url":"https://api.github.com/users/wolfmanjm/followers","following_url":"https://api.github.com/users/wolfmanjm/following{/other_user}","gists_url":"https://api.github.com/users/wolfmanjm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfmanjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfmanjm/subscriptions","organizations_url":"https://api.github.com/users/wolfmanjm/orgs","repos_url":"https://api.github.com/users/wolfmanjm/repos","events_url":"https://api.github.com/users/wolfmanjm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfmanjm/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T04:19:48Z","updated_at":"2016-10-18T04:19:48Z","body":"Sorry I am rejecting this as there was a simple one line fix that did not add extra memory usage for this issue. (Although the one line fix would not fix the new temp being set 20° lower but that does not seem to be a use case we need to concern ourselves with).\r\nAlso increasing the memory usage by removing bytes from the packed structure was a pure waste of memory, multiplied by the number of temperature instances created and totally unnecessary,"}}
{"actor":{"display_login":"wolfmanjm"}}