{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/84198268","pull_request_review_id":4990069,"id":84198268,"diff_hunk":"@@ -55,77 +56,132 @@ object ConsumerGroupCommand {\n \n     val consumerGroupService = {\n       if (opts.useOldConsumer) {\n+        println(\"Note: This will only show information about consumers that use ZooKeeper (not those using the Java consumer API).\\n\")\n         new ZkConsumerGroupService(opts)\n       } else {\n+        println(\"Note: This will only show information about consumers that use the Java consumer API (non-ZooKeeper-based consumers).\\n\")\n         new KafkaConsumerGroupService(opts)\n       }\n     }\n \n     try {\n       if (opts.options.has(opts.listOpt))\n-        consumerGroupService.list()\n-      else if (opts.options.has(opts.describeOpt))\n-        consumerGroupService.describe()\n+        consumerGroupService.listGroups().foreach { printMessage(_) }\n+      else if (opts.options.has(opts.describeOpt)) {\n+        val describeGroupResult = consumerGroupService.describeGroup()","path":"core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala","position":36,"original_position":36,"commit_id":"857cf29a0f2d39061390ed3217679a8023273be1","original_commit_id":"857cf29a0f2d39061390ed3217679a8023273be1","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"body":"Good suggestion.","created_at":"2016-10-20T01:08:24Z","updated_at":"2016-10-20T01:08:24Z","html_url":"https://github.com/apache/kafka/pull/1336#discussion_r84198268","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1336","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/84198268"},"html":{"href":"https://github.com/apache/kafka/pull/1336#discussion_r84198268"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1336"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1336","id":69218845,"html_url":"https://github.com/apache/kafka/pull/1336","diff_url":"https://github.com/apache/kafka/pull/1336.diff","patch_url":"https://github.com/apache/kafka/pull/1336.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1336","number":1336,"state":"open","locked":false,"title":"KAFKA-3144: Report members with no assigned partitions in ConsumerGroupCommand","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"body":"This PR makes a couple of enhancements to the `--describe` option of `ConsumerGroupCommand`:\r\n1. Listing members with no assigned partitions.\r\n2. Showing the member id along with the owner of each partition (owner is supposed to be the logical application id and all members in the same group are supposed to set the same owner).\r\n3. Reporting broker id of the group coordinator when `--new-consumer` is used.\r\n4. Printing a warning indicating whether ZooKeeper based or new consumer API based information is being reported.\r\n\r\nIt also adds unit tests to verify the added functionality.\r\n\r\nNote: The third request on the corresponding JIRA (listing active offsets for empty groups of new consumers) is not implemented as part of this PR, and has been moved to its own JIRA (KAFKA-3853).","created_at":"2016-05-06T22:26:24Z","updated_at":"2016-10-20T01:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e52a2333277d71442a4ce3b358912092128c8993","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1336/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1336/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1336/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/857cf29a0f2d39061390ed3217679a8023273be1","head":{"label":"vahidhashemian:KAFKA-3144","ref":"KAFKA-3144","sha":"857cf29a0f2d39061390ed3217679a8023273be1","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"repo":{"id":47428717,"name":"kafka","full_name":"vahidhashemian/kafka","owner":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vahidhashemian/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/vahidhashemian/kafka","forks_url":"https://api.github.com/repos/vahidhashemian/kafka/forks","keys_url":"https://api.github.com/repos/vahidhashemian/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vahidhashemian/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vahidhashemian/kafka/teams","hooks_url":"https://api.github.com/repos/vahidhashemian/kafka/hooks","issue_events_url":"https://api.github.com/repos/vahidhashemian/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/vahidhashemian/kafka/events","assignees_url":"https://api.github.com/repos/vahidhashemian/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/vahidhashemian/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/vahidhashemian/kafka/tags","blobs_url":"https://api.github.com/repos/vahidhashemian/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vahidhashemian/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vahidhashemian/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/vahidhashemian/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vahidhashemian/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/vahidhashemian/kafka/languages","stargazers_url":"https://api.github.com/repos/vahidhashemian/kafka/stargazers","contributors_url":"https://api.github.com/repos/vahidhashemian/kafka/contributors","subscribers_url":"https://api.github.com/repos/vahidhashemian/kafka/subscribers","subscription_url":"https://api.github.com/repos/vahidhashemian/kafka/subscription","commits_url":"https://api.github.com/repos/vahidhashemian/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/vahidhashemian/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/vahidhashemian/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/vahidhashemian/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/vahidhashemian/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/vahidhashemian/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vahidhashemian/kafka/merges","archive_url":"https://api.github.com/repos/vahidhashemian/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vahidhashemian/kafka/downloads","issues_url":"https://api.github.com/repos/vahidhashemian/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/vahidhashemian/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/vahidhashemian/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/vahidhashemian/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vahidhashemian/kafka/labels{/name}","releases_url":"https://api.github.com/repos/vahidhashemian/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/vahidhashemian/kafka/deployments","created_at":"2015-12-04T21:04:22Z","updated_at":"2016-01-14T22:16:55Z","pushed_at":"2016-10-19T23:28:09Z","git_url":"git://github.com/vahidhashemian/kafka.git","ssh_url":"git@github.com:vahidhashemian/kafka.git","clone_url":"https://github.com/vahidhashemian/kafka.git","svn_url":"https://github.com/vahidhashemian/kafka","homepage":null,"size":34667,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"c2a8b86117ede2ffda4cc4a8800b46f65ef9922d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-10-20T00:39:07Z","pushed_at":"2016-10-19T23:35:36Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":51566,"stargazers_count":3945,"watchers_count":3945,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2438,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":275,"forks":2438,"open_issues":275,"watchers":3945,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1336"},"html":{"href":"https://github.com/apache/kafka/pull/1336"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1336"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1336/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1336/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1336/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/857cf29a0f2d39061390ed3217679a8023273be1"}}}}
{"actor":{"display_login":"vahidhashemian"}}