{"action":"created","issue":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/114","repository_url":"https://api.github.com/repos/AtheMathmo/rulinalg","labels_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/114/comments","events_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/114/events","html_url":"https://github.com/AtheMathmo/rulinalg/pull/114","id":197434714,"number":114,"title":"Splitting out the slice module","user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/milestones/1","html_url":"https://github.com/AtheMathmo/rulinalg/milestone/1","labels_url":"https://api.github.com/repos/AtheMathmo/rulinalg/milestones/1/labels","id":2030118,"number":1,"title":"0.4","description":null,"creator":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":11,"state":"open","created_at":"2016-09-26T21:33:30Z","updated_at":"2016-12-26T07:47:01Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-12-23T22:52:48Z","updated_at":"2016-12-27T08:56:36Z","closed_at":"2016-12-26T07:47:01Z","pull_request":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/pulls/114","html_url":"https://github.com/AtheMathmo/rulinalg/pull/114","diff_url":"https://github.com/AtheMathmo/rulinalg/pull/114.diff","patch_url":"https://github.com/AtheMathmo/rulinalg/pull/114.patch"},"body":"This PR replaces #111 - the merge conflict was too tricky.\r\n\r\nTomorrow morning I'll check through to make sure that I haven't accidentally dropped any unit tests. Then I'll merge this and get a PR in for the 0.4 release.\r\n\r\n----\r\n\r\nCopied from previous PR:\r\n\r\nIn this PR I've shuffled around some of the larger modules. In particular I've tackled the `slice` module and the `matrix/mod` module. I've tried to complete the following changes:\r\n\r\n- New `base` module for the `BaseMatrix` traits.\r\n- Moved `BaseMatrix` implementations into new sub module\r\n- Moved `impl Matrix` blocks to new module\r\n\r\nThis means that the `matrix/mod` module contains only declarations of structs that we use throughout the matrix module. The slice module contains only `impl MatrixSlice(Mut)` blocks.\r\n\r\nThe `base` mod is still fairly large but there is not much that can be done about this. The `BaseMatrix` traits are just pretty huge."},"comment":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/comments/269296335","html_url":"https://github.com/AtheMathmo/rulinalg/pull/114#issuecomment-269296335","issue_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/114","id":269296335,"user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T08:56:36Z","updated_at":"2016-12-27T08:56:36Z","body":"I just checked and you are correct!\r\n\r\nI agree that this is an obvious improvement. I'll push the one-line change directly to master."}}
{"actor":{"display_login":"AtheMathmo"}}