{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3984","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3984/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3984/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3984/events","html_url":"https://github.com/Particular/NServiceBus/pull/3984","id":168116227,"number":3984,"title":"Reduce contention on UnfinishedFailedMessages dictionary","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-28T14:54:04Z","updated_at":"2016-07-28T14:54:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3984","html_url":"https://github.com/Particular/NServiceBus/pull/3984","diff_url":"https://github.com/Particular/NServiceBus/pull/3984.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3984.patch"},"body":" and align check logic with when done condition check\r\n\r\n@MarcinHoppe and I found a bug with contentions on the UnfinishedFailedMessages dictionary. When a test shuts down quicker than the CatchExceptionBehavior added by the acceptance test framework then the tight while loop on the dictionary will prevent the AddOrUpdate method call from succeeding. Therefore the tests will fail with an indication that there were unfinished failed messages (which is a obviously false)."},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/235919515","html_url":"https://github.com/Particular/NServiceBus/pull/3984#issuecomment-235919515","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3984","id":235919515,"user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T14:54:14Z","updated_at":"2016-07-28T14:54:14Z","body":"@Particular/nservicebus-maintainers please review and merge"}}
{"actor":{"display_login":"danielmarbach"}}