{"action":"created","comment":{"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments/89702351","pull_request_review_id":10240208,"id":89702351,"diff_hunk":"@@ -0,0 +1,115 @@\n+////////////////////////////////////////////////////////////////////////////\n+//\n+// Quad Velocity controller\n+//\n+// Implements details involving the throttle controller\n+//\n+////////////////////////////////////////////////////////////////////////////\n+\n+#include \"QuadVelocityController.hpp\"\n+#include \"iarc7_msgs/OrientationThrottleStamped.h\"\n+\n+using namespace Iarc7Motion;\n+\n+QuadVelocityController::QuadVelocityController(ros::NodeHandle& nh) :\n+nh_(nh),  \n+throttle_pid_(0.0, 0.0, 0.0),\n+pitch_pid_(0.0, 0.0, 0.0) ,\n+roll_pid_(0.0, 0.0, 0.0) ,\n+yaw_pid_(0.0, 0.0, 0.0) ,\n+tfBuffer_(),\n+tfListener_(tfBuffer_)\n+{\n+\n+}\n+\n+void QuadVelocityController::init()\n+{\n+    uav_control_ = nh_.advertise<iarc7_msgs::OrientationThrottleStamped>(\"uav_direction_command\", 50);","path":"src/QuadVelocityController.cpp","position":28,"original_position":28,"commit_id":"1179c0fa079aeb11f90fc34066967da793e9bd0e","original_commit_id":"1179c0fa079aeb11f90fc34066967da793e9bd0e","user":{"login":"amiller27","id":4535296,"avatar_url":"https://avatars.githubusercontent.com/u/4535296?v=3","gravatar_id":"","url":"https://api.github.com/users/amiller27","html_url":"https://github.com/amiller27","followers_url":"https://api.github.com/users/amiller27/followers","following_url":"https://api.github.com/users/amiller27/following{/other_user}","gists_url":"https://api.github.com/users/amiller27/gists{/gist_id}","starred_url":"https://api.github.com/users/amiller27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiller27/subscriptions","organizations_url":"https://api.github.com/users/amiller27/orgs","repos_url":"https://api.github.com/users/amiller27/repos","events_url":"https://api.github.com/users/amiller27/events{/privacy}","received_events_url":"https://api.github.com/users/amiller27/received_events","type":"User","site_admin":false},"body":"I'm assuming this isn't in the constructor because it can throw exceptions, and it isn't in a factory method because that would require dynamic allocation?","created_at":"2016-11-27T22:57:08Z","updated_at":"2016-11-27T22:57:53Z","html_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/2#discussion_r89702351","pull_request_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments/89702351"},"html":{"href":"https://github.com/Pitt-RAS/iarc7_motion/pull/2#discussion_r89702351"},"pull_request":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2","id":95419870,"html_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/2","diff_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/2.diff","patch_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/2.patch","issue_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/2","number":2,"state":"open","locked":false,"title":"Initial structure","user":{"login":"aftersomemath","id":6125615,"avatar_url":"https://avatars.githubusercontent.com/u/6125615?v=3","gravatar_id":"","url":"https://api.github.com/users/aftersomemath","html_url":"https://github.com/aftersomemath","followers_url":"https://api.github.com/users/aftersomemath/followers","following_url":"https://api.github.com/users/aftersomemath/following{/other_user}","gists_url":"https://api.github.com/users/aftersomemath/gists{/gist_id}","starred_url":"https://api.github.com/users/aftersomemath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aftersomemath/subscriptions","organizations_url":"https://api.github.com/users/aftersomemath/orgs","repos_url":"https://api.github.com/users/aftersomemath/repos","events_url":"https://api.github.com/users/aftersomemath/events{/privacy}","received_events_url":"https://api.github.com/users/aftersomemath/received_events","type":"User","site_admin":false},"body":"This node is still a WIP. However the initial structure for development is here and proof of concept has been demonstrated. Thus initial structure should be considered done.","created_at":"2016-11-27T22:40:42Z","updated_at":"2016-11-27T22:57:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9c8d7f266f0fc685e98a724e6bab28bb1745a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/2/comments","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/1179c0fa079aeb11f90fc34066967da793e9bd0e","head":{"label":"Pitt-RAS:initial_structure","ref":"initial_structure","sha":"1179c0fa079aeb11f90fc34066967da793e9bd0e","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":67438943,"name":"iarc7_motion","full_name":"Pitt-RAS/iarc7_motion","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/iarc7_motion","description":null,"fork":false,"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion","forks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/deployments","created_at":"2016-09-05T17:23:18Z","updated_at":"2016-09-10T18:15:52Z","pushed_at":"2016-11-27T22:40:42Z","git_url":"git://github.com/Pitt-RAS/iarc7_motion.git","ssh_url":"git@github.com:Pitt-RAS/iarc7_motion.git","clone_url":"https://github.com/Pitt-RAS/iarc7_motion.git","svn_url":"https://github.com/Pitt-RAS/iarc7_motion","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Pitt-RAS:master","ref":"master","sha":"e9610f783eccbf6d5439018b7c98da49011908ef","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":67438943,"name":"iarc7_motion","full_name":"Pitt-RAS/iarc7_motion","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/iarc7_motion","description":null,"fork":false,"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion","forks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/deployments","created_at":"2016-09-05T17:23:18Z","updated_at":"2016-09-10T18:15:52Z","pushed_at":"2016-11-27T22:40:42Z","git_url":"git://github.com/Pitt-RAS/iarc7_motion.git","ssh_url":"git@github.com:Pitt-RAS/iarc7_motion.git","clone_url":"https://github.com/Pitt-RAS/iarc7_motion.git","svn_url":"https://github.com/Pitt-RAS/iarc7_motion","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2"},"html":{"href":"https://github.com/Pitt-RAS/iarc7_motion/pull/2"},"issue":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/2"},"comments":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/1179c0fa079aeb11f90fc34066967da793e9bd0e"}}}}
{"actor":{"display_login":"amiller27"}}