{"action":"created","comment":{"url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/comments/81133922","pull_request_review_id":2135082,"id":81133922,"diff_hunk":"@@ -29,4 +39,46 @@ public OkHttpClient provideOkHttpClient(Cache cache) {\n                 .cache(cache)\n                 .build();\n     }\n+\n+    @Singleton\n+    @Api(\"github\")\n+    @Provides\n+    public String provideBaseUrl(Settings settings) {\n+        return settings.getBaseUrl();\n+    }\n+\n+    @Singleton\n+    @Api(\"github\")\n+    @Provides\n+    public Converter.Factory provideConverter() {\n+        Gson gson = new Gson();\n+        return GsonConverterFactory.create(gson);\n+    }\n+\n+    @Singleton\n+    @Api(\"github\")\n+    @Provides\n+    public Retrofit provideRetrofit(\n+            OkHttpClient client,\n+            @Api(\"github\") String baseUrl,\n+            @Api(\"github\") Converter.Factory converterFactory) {\n+        return new Retrofit.Builder()\n+                .client(client)\n+                .baseUrl(baseUrl)\n+                .addConverterFactory(converterFactory)\n+                .addCallAdapterFactory(RxJavaCallAdapterFactory.create())\n+                .build();\n+    }\n+\n+    @Singleton\n+    @Provides\n+    public GitHubApiService provideGitHubApiService(@Api(\"github\") Retrofit retrofit) {","path":"app/src/main/java/com/mycompany/myapp/data/DataModule.java","position":61,"original_position":61,"commit_id":"938f0ed836112eb87d903b77a08468068a0c36c0","original_commit_id":"938f0ed836112eb87d903b77a08468068a0c36c0","user":{"login":"atoennis","id":2256671,"avatar_url":"https://avatars.githubusercontent.com/u/2256671?v=3","gravatar_id":"","url":"https://api.github.com/users/atoennis","html_url":"https://github.com/atoennis","followers_url":"https://api.github.com/users/atoennis/followers","following_url":"https://api.github.com/users/atoennis/following{/other_user}","gists_url":"https://api.github.com/users/atoennis/gists{/gist_id}","starred_url":"https://api.github.com/users/atoennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atoennis/subscriptions","organizations_url":"https://api.github.com/users/atoennis/orgs","repos_url":"https://api.github.com/users/atoennis/repos","events_url":"https://api.github.com/users/atoennis/events{/privacy}","received_events_url":"https://api.github.com/users/atoennis/received_events","type":"User","site_admin":false},"body":"Just to answer where it's coming from, it's defined under `com.getfinal.android.data.api` in main.  It's basically just saying this Retrofit instance is for github.  For instance, there could be another Retrofit instance with `@Api(\"bitbucket\")` and that instance would be for bitbucket.","created_at":"2016-09-29T13:20:03Z","updated_at":"2016-09-29T13:22:19Z","html_url":"https://github.com/madebyatomicrobot/android-starter-project/pull/7#discussion_r81133922","pull_request_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/comments/81133922"},"html":{"href":"https://github.com/madebyatomicrobot/android-starter-project/pull/7#discussion_r81133922"},"pull_request":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7","id":87237069,"html_url":"https://github.com/madebyatomicrobot/android-starter-project/pull/7","diff_url":"https://github.com/madebyatomicrobot/android-starter-project/pull/7.diff","patch_url":"https://github.com/madebyatomicrobot/android-starter-project/pull/7.patch","issue_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/7","number":7,"state":"open","locked":false,"title":"Updates","user":{"login":"patrickhammond","id":424944,"avatar_url":"https://avatars.githubusercontent.com/u/424944?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhammond","html_url":"https://github.com/patrickhammond","followers_url":"https://api.github.com/users/patrickhammond/followers","following_url":"https://api.github.com/users/patrickhammond/following{/other_user}","gists_url":"https://api.github.com/users/patrickhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhammond/subscriptions","organizations_url":"https://api.github.com/users/patrickhammond/orgs","repos_url":"https://api.github.com/users/patrickhammond/repos","events_url":"https://api.github.com/users/patrickhammond/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhammond/received_events","type":"User","site_admin":false},"body":"Pulling in a handful of items listed here:\r\nhttps://trello.com/c/ah4hvfwh/21-android-starter-project-updates","created_at":"2016-09-29T02:41:11Z","updated_at":"2016-09-29T13:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f97e8740a157ac957cd7474d753c672eee2a11f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7/commits","review_comments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7/comments","review_comment_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/7/comments","statuses_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/statuses/938f0ed836112eb87d903b77a08468068a0c36c0","head":{"label":"madebyatomicrobot:updates","ref":"updates","sha":"938f0ed836112eb87d903b77a08468068a0c36c0","user":{"login":"madebyatomicrobot","id":4171565,"avatar_url":"https://avatars.githubusercontent.com/u/4171565?v=3","gravatar_id":"","url":"https://api.github.com/users/madebyatomicrobot","html_url":"https://github.com/madebyatomicrobot","followers_url":"https://api.github.com/users/madebyatomicrobot/followers","following_url":"https://api.github.com/users/madebyatomicrobot/following{/other_user}","gists_url":"https://api.github.com/users/madebyatomicrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/madebyatomicrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebyatomicrobot/subscriptions","organizations_url":"https://api.github.com/users/madebyatomicrobot/orgs","repos_url":"https://api.github.com/users/madebyatomicrobot/repos","events_url":"https://api.github.com/users/madebyatomicrobot/events{/privacy}","received_events_url":"https://api.github.com/users/madebyatomicrobot/received_events","type":"Organization","site_admin":false},"repo":{"id":16126427,"name":"android-starter-project","full_name":"madebyatomicrobot/android-starter-project","owner":{"login":"madebyatomicrobot","id":4171565,"avatar_url":"https://avatars.githubusercontent.com/u/4171565?v=3","gravatar_id":"","url":"https://api.github.com/users/madebyatomicrobot","html_url":"https://github.com/madebyatomicrobot","followers_url":"https://api.github.com/users/madebyatomicrobot/followers","following_url":"https://api.github.com/users/madebyatomicrobot/following{/other_user}","gists_url":"https://api.github.com/users/madebyatomicrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/madebyatomicrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebyatomicrobot/subscriptions","organizations_url":"https://api.github.com/users/madebyatomicrobot/orgs","repos_url":"https://api.github.com/users/madebyatomicrobot/repos","events_url":"https://api.github.com/users/madebyatomicrobot/events{/privacy}","received_events_url":"https://api.github.com/users/madebyatomicrobot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/madebyatomicrobot/android-starter-project","description":"","fork":false,"url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project","forks_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/forks","keys_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/teams","hooks_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/hooks","issue_events_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/events{/number}","events_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/events","assignees_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/assignees{/user}","branches_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/branches{/branch}","tags_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/tags","blobs_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/statuses/{sha}","languages_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/languages","stargazers_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/stargazers","contributors_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/contributors","subscribers_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/subscribers","subscription_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/subscription","commits_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/contents/{+path}","compare_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/merges","archive_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/downloads","issues_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues{/number}","pulls_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls{/number}","milestones_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/milestones{/number}","notifications_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/labels{/name}","releases_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/releases{/id}","deployments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/deployments","created_at":"2014-01-22T02:40:08Z","updated_at":"2016-05-30T02:54:18Z","pushed_at":"2016-09-29T02:55:09Z","git_url":"git://github.com/madebyatomicrobot/android-starter-project.git","ssh_url":"git@github.com:madebyatomicrobot/android-starter-project.git","clone_url":"https://github.com/madebyatomicrobot/android-starter-project.git","svn_url":"https://github.com/madebyatomicrobot/android-starter-project","homepage":null,"size":329,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"madebyatomicrobot:master","ref":"master","sha":"8006b92363e795aee95ea57fb6c5303b491cec3b","user":{"login":"madebyatomicrobot","id":4171565,"avatar_url":"https://avatars.githubusercontent.com/u/4171565?v=3","gravatar_id":"","url":"https://api.github.com/users/madebyatomicrobot","html_url":"https://github.com/madebyatomicrobot","followers_url":"https://api.github.com/users/madebyatomicrobot/followers","following_url":"https://api.github.com/users/madebyatomicrobot/following{/other_user}","gists_url":"https://api.github.com/users/madebyatomicrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/madebyatomicrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebyatomicrobot/subscriptions","organizations_url":"https://api.github.com/users/madebyatomicrobot/orgs","repos_url":"https://api.github.com/users/madebyatomicrobot/repos","events_url":"https://api.github.com/users/madebyatomicrobot/events{/privacy}","received_events_url":"https://api.github.com/users/madebyatomicrobot/received_events","type":"Organization","site_admin":false},"repo":{"id":16126427,"name":"android-starter-project","full_name":"madebyatomicrobot/android-starter-project","owner":{"login":"madebyatomicrobot","id":4171565,"avatar_url":"https://avatars.githubusercontent.com/u/4171565?v=3","gravatar_id":"","url":"https://api.github.com/users/madebyatomicrobot","html_url":"https://github.com/madebyatomicrobot","followers_url":"https://api.github.com/users/madebyatomicrobot/followers","following_url":"https://api.github.com/users/madebyatomicrobot/following{/other_user}","gists_url":"https://api.github.com/users/madebyatomicrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/madebyatomicrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebyatomicrobot/subscriptions","organizations_url":"https://api.github.com/users/madebyatomicrobot/orgs","repos_url":"https://api.github.com/users/madebyatomicrobot/repos","events_url":"https://api.github.com/users/madebyatomicrobot/events{/privacy}","received_events_url":"https://api.github.com/users/madebyatomicrobot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/madebyatomicrobot/android-starter-project","description":"","fork":false,"url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project","forks_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/forks","keys_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/teams","hooks_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/hooks","issue_events_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/events{/number}","events_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/events","assignees_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/assignees{/user}","branches_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/branches{/branch}","tags_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/tags","blobs_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/statuses/{sha}","languages_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/languages","stargazers_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/stargazers","contributors_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/contributors","subscribers_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/subscribers","subscription_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/subscription","commits_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/contents/{+path}","compare_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/merges","archive_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/downloads","issues_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues{/number}","pulls_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls{/number}","milestones_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/milestones{/number}","notifications_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/labels{/name}","releases_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/releases{/id}","deployments_url":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/deployments","created_at":"2014-01-22T02:40:08Z","updated_at":"2016-05-30T02:54:18Z","pushed_at":"2016-09-29T02:55:09Z","git_url":"git://github.com/madebyatomicrobot/android-starter-project.git","ssh_url":"git@github.com:madebyatomicrobot/android-starter-project.git","clone_url":"https://github.com/madebyatomicrobot/android-starter-project.git","svn_url":"https://github.com/madebyatomicrobot/android-starter-project","homepage":null,"size":329,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7"},"html":{"href":"https://github.com/madebyatomicrobot/android-starter-project/pull/7"},"issue":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/7"},"comments":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/madebyatomicrobot/android-starter-project/statuses/938f0ed836112eb87d903b77a08468068a0c36c0"}}}}
{"actor":{"display_login":"atoennis"}}