{"action":"created","comment":{"url":"https://api.github.com/repos/querydsl/querydsl/pulls/comments/62126028","id":62126028,"diff_hunk":"@@ -112,4 +117,27 @@ public void various() {\n         entity.getTime(\"time\", Time.class);\n     }\n \n+    @Test\n+    public void attempting_to_overwrite_an_existing_path_with_one_of_the_same_type_succeeds() {\n+        try {\n+            PathBuilder<User> entity = new PathBuilder<User>(User.class, \"entity\");\n+            String pathName = \"some_path\";\n+            entity.get(pathName);\n+            entity.get(pathName, Object.class);\n+        } catch (Exception e) {\n+            fail();\n+        }\n+    }\n+\n+    @Test\n+    public void attempting_to_overwrite_an_existing_path_with_one_of_a_different_type_throws_a_RuntimeException() {\n+        expectedException.expect(RuntimeException.class);\n+        expectedException.expectMessage(\n+                \"Property name [some_path] of type [class java.lang.Object] cannot be overwritten with type [class java.lang.Integer] due to thread safety\");\n+        PathBuilder<User> entity = new PathBuilder<User>(User.class, \"entity\");\n+        String pathName = \"some_path\";\n+        entity.get(pathName);\n+        entity.get(pathName, Integer.class);","path":"querydsl-core/src/test/java/com/querydsl/core/types/dsl/PathBuilderTest.java","position":60,"original_position":60,"commit_id":"426856985e90e84da2fd9be5050f0f18fc8dfdc1","original_commit_id":"426856985e90e84da2fd9be5050f0f18fc8dfdc1","user":{"login":"Shredder121","id":4105066,"avatar_url":"https://avatars.githubusercontent.com/u/4105066?v=3","gravatar_id":"","url":"https://api.github.com/users/Shredder121","html_url":"https://github.com/Shredder121","followers_url":"https://api.github.com/users/Shredder121/followers","following_url":"https://api.github.com/users/Shredder121/following{/other_user}","gists_url":"https://api.github.com/users/Shredder121/gists{/gist_id}","starred_url":"https://api.github.com/users/Shredder121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shredder121/subscriptions","organizations_url":"https://api.github.com/users/Shredder121/orgs","repos_url":"https://api.github.com/users/Shredder121/repos","events_url":"https://api.github.com/users/Shredder121/events{/privacy}","received_events_url":"https://api.github.com/users/Shredder121/received_events","type":"User","site_admin":false},"body":"I'd really like that it doesn't throw actually.\r\nWe have generic filtering that uses `.get(path)` and sorting that uses `.getComparable(path)`.\r\nSo it's perfectly valid for it to remake path objects with a more specific type :(","created_at":"2016-05-04T22:30:56Z","updated_at":"2016-05-04T22:30:56Z","html_url":"https://github.com/querydsl/querydsl/pull/1872#discussion_r62126028","pull_request_url":"https://api.github.com/repos/querydsl/querydsl/pulls/1872","_links":{"self":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/comments/62126028"},"html":{"href":"https://github.com/querydsl/querydsl/pull/1872#discussion_r62126028"},"pull_request":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/1872"}}},"pull_request":{"url":"https://api.github.com/repos/querydsl/querydsl/pulls/1872","id":68925919,"html_url":"https://github.com/querydsl/querydsl/pull/1872","diff_url":"https://github.com/querydsl/querydsl/pull/1872.diff","patch_url":"https://github.com/querydsl/querydsl/pull/1872.patch","issue_url":"https://api.github.com/repos/querydsl/querydsl/issues/1872","number":1872,"state":"open","locked":false,"title":"Make PathBuilder thread safe","user":{"login":"robertandrewbain","id":3799239,"avatar_url":"https://avatars.githubusercontent.com/u/3799239?v=3","gravatar_id":"","url":"https://api.github.com/users/robertandrewbain","html_url":"https://github.com/robertandrewbain","followers_url":"https://api.github.com/users/robertandrewbain/followers","following_url":"https://api.github.com/users/robertandrewbain/following{/other_user}","gists_url":"https://api.github.com/users/robertandrewbain/gists{/gist_id}","starred_url":"https://api.github.com/users/robertandrewbain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertandrewbain/subscriptions","organizations_url":"https://api.github.com/users/robertandrewbain/orgs","repos_url":"https://api.github.com/users/robertandrewbain/repos","events_url":"https://api.github.com/users/robertandrewbain/events{/privacy}","received_events_url":"https://api.github.com/users/robertandrewbain/received_events","type":"User","site_admin":false},"body":"#1869 ","created_at":"2016-05-04T20:25:10Z","updated_at":"2016-05-04T22:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8d46de2c19d0480ce705dc3c57efd5ef769bd66","assignee":{"login":"robertandrewbain","id":3799239,"avatar_url":"https://avatars.githubusercontent.com/u/3799239?v=3","gravatar_id":"","url":"https://api.github.com/users/robertandrewbain","html_url":"https://github.com/robertandrewbain","followers_url":"https://api.github.com/users/robertandrewbain/followers","following_url":"https://api.github.com/users/robertandrewbain/following{/other_user}","gists_url":"https://api.github.com/users/robertandrewbain/gists{/gist_id}","starred_url":"https://api.github.com/users/robertandrewbain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertandrewbain/subscriptions","organizations_url":"https://api.github.com/users/robertandrewbain/orgs","repos_url":"https://api.github.com/users/robertandrewbain/repos","events_url":"https://api.github.com/users/robertandrewbain/events{/privacy}","received_events_url":"https://api.github.com/users/robertandrewbain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/querydsl/querydsl/pulls/1872/commits","review_comments_url":"https://api.github.com/repos/querydsl/querydsl/pulls/1872/comments","review_comment_url":"https://api.github.com/repos/querydsl/querydsl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/querydsl/querydsl/issues/1872/comments","statuses_url":"https://api.github.com/repos/querydsl/querydsl/statuses/426856985e90e84da2fd9be5050f0f18fc8dfdc1","head":{"label":"querydsl:i1869","ref":"i1869","sha":"426856985e90e84da2fd9be5050f0f18fc8dfdc1","user":{"login":"querydsl","id":7044479,"avatar_url":"https://avatars.githubusercontent.com/u/7044479?v=3","gravatar_id":"","url":"https://api.github.com/users/querydsl","html_url":"https://github.com/querydsl","followers_url":"https://api.github.com/users/querydsl/followers","following_url":"https://api.github.com/users/querydsl/following{/other_user}","gists_url":"https://api.github.com/users/querydsl/gists{/gist_id}","starred_url":"https://api.github.com/users/querydsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/querydsl/subscriptions","organizations_url":"https://api.github.com/users/querydsl/orgs","repos_url":"https://api.github.com/users/querydsl/repos","events_url":"https://api.github.com/users/querydsl/events{/privacy}","received_events_url":"https://api.github.com/users/querydsl/received_events","type":"Organization","site_admin":false},"repo":{"id":2158982,"name":"querydsl","full_name":"querydsl/querydsl","owner":{"login":"querydsl","id":7044479,"avatar_url":"https://avatars.githubusercontent.com/u/7044479?v=3","gravatar_id":"","url":"https://api.github.com/users/querydsl","html_url":"https://github.com/querydsl","followers_url":"https://api.github.com/users/querydsl/followers","following_url":"https://api.github.com/users/querydsl/following{/other_user}","gists_url":"https://api.github.com/users/querydsl/gists{/gist_id}","starred_url":"https://api.github.com/users/querydsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/querydsl/subscriptions","organizations_url":"https://api.github.com/users/querydsl/orgs","repos_url":"https://api.github.com/users/querydsl/repos","events_url":"https://api.github.com/users/querydsl/events{/privacy}","received_events_url":"https://api.github.com/users/querydsl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/querydsl/querydsl","description":"Unified Queries for Java","fork":false,"url":"https://api.github.com/repos/querydsl/querydsl","forks_url":"https://api.github.com/repos/querydsl/querydsl/forks","keys_url":"https://api.github.com/repos/querydsl/querydsl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/querydsl/querydsl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/querydsl/querydsl/teams","hooks_url":"https://api.github.com/repos/querydsl/querydsl/hooks","issue_events_url":"https://api.github.com/repos/querydsl/querydsl/issues/events{/number}","events_url":"https://api.github.com/repos/querydsl/querydsl/events","assignees_url":"https://api.github.com/repos/querydsl/querydsl/assignees{/user}","branches_url":"https://api.github.com/repos/querydsl/querydsl/branches{/branch}","tags_url":"https://api.github.com/repos/querydsl/querydsl/tags","blobs_url":"https://api.github.com/repos/querydsl/querydsl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/querydsl/querydsl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/querydsl/querydsl/git/refs{/sha}","trees_url":"https://api.github.com/repos/querydsl/querydsl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/querydsl/querydsl/statuses/{sha}","languages_url":"https://api.github.com/repos/querydsl/querydsl/languages","stargazers_url":"https://api.github.com/repos/querydsl/querydsl/stargazers","contributors_url":"https://api.github.com/repos/querydsl/querydsl/contributors","subscribers_url":"https://api.github.com/repos/querydsl/querydsl/subscribers","subscription_url":"https://api.github.com/repos/querydsl/querydsl/subscription","commits_url":"https://api.github.com/repos/querydsl/querydsl/commits{/sha}","git_commits_url":"https://api.github.com/repos/querydsl/querydsl/git/commits{/sha}","comments_url":"https://api.github.com/repos/querydsl/querydsl/comments{/number}","issue_comment_url":"https://api.github.com/repos/querydsl/querydsl/issues/comments{/number}","contents_url":"https://api.github.com/repos/querydsl/querydsl/contents/{+path}","compare_url":"https://api.github.com/repos/querydsl/querydsl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/querydsl/querydsl/merges","archive_url":"https://api.github.com/repos/querydsl/querydsl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/querydsl/querydsl/downloads","issues_url":"https://api.github.com/repos/querydsl/querydsl/issues{/number}","pulls_url":"https://api.github.com/repos/querydsl/querydsl/pulls{/number}","milestones_url":"https://api.github.com/repos/querydsl/querydsl/milestones{/number}","notifications_url":"https://api.github.com/repos/querydsl/querydsl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/querydsl/querydsl/labels{/name}","releases_url":"https://api.github.com/repos/querydsl/querydsl/releases{/id}","deployments_url":"https://api.github.com/repos/querydsl/querydsl/deployments","created_at":"2011-08-05T06:46:32Z","updated_at":"2016-05-03T18:15:15Z","pushed_at":"2016-05-04T21:37:50Z","git_url":"git://github.com/querydsl/querydsl.git","ssh_url":"git@github.com:querydsl/querydsl.git","clone_url":"https://github.com/querydsl/querydsl.git","svn_url":"https://github.com/querydsl/querydsl","homepage":"http://www.querydsl.com","size":57875,"stargazers_count":857,"watchers_count":857,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"open_issues_count":146,"forks":229,"open_issues":146,"watchers":857,"default_branch":"master"}},"base":{"label":"querydsl:master","ref":"master","sha":"4dd7d5f44675c276c258daaec3fcab121bb7357c","user":{"login":"querydsl","id":7044479,"avatar_url":"https://avatars.githubusercontent.com/u/7044479?v=3","gravatar_id":"","url":"https://api.github.com/users/querydsl","html_url":"https://github.com/querydsl","followers_url":"https://api.github.com/users/querydsl/followers","following_url":"https://api.github.com/users/querydsl/following{/other_user}","gists_url":"https://api.github.com/users/querydsl/gists{/gist_id}","starred_url":"https://api.github.com/users/querydsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/querydsl/subscriptions","organizations_url":"https://api.github.com/users/querydsl/orgs","repos_url":"https://api.github.com/users/querydsl/repos","events_url":"https://api.github.com/users/querydsl/events{/privacy}","received_events_url":"https://api.github.com/users/querydsl/received_events","type":"Organization","site_admin":false},"repo":{"id":2158982,"name":"querydsl","full_name":"querydsl/querydsl","owner":{"login":"querydsl","id":7044479,"avatar_url":"https://avatars.githubusercontent.com/u/7044479?v=3","gravatar_id":"","url":"https://api.github.com/users/querydsl","html_url":"https://github.com/querydsl","followers_url":"https://api.github.com/users/querydsl/followers","following_url":"https://api.github.com/users/querydsl/following{/other_user}","gists_url":"https://api.github.com/users/querydsl/gists{/gist_id}","starred_url":"https://api.github.com/users/querydsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/querydsl/subscriptions","organizations_url":"https://api.github.com/users/querydsl/orgs","repos_url":"https://api.github.com/users/querydsl/repos","events_url":"https://api.github.com/users/querydsl/events{/privacy}","received_events_url":"https://api.github.com/users/querydsl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/querydsl/querydsl","description":"Unified Queries for Java","fork":false,"url":"https://api.github.com/repos/querydsl/querydsl","forks_url":"https://api.github.com/repos/querydsl/querydsl/forks","keys_url":"https://api.github.com/repos/querydsl/querydsl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/querydsl/querydsl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/querydsl/querydsl/teams","hooks_url":"https://api.github.com/repos/querydsl/querydsl/hooks","issue_events_url":"https://api.github.com/repos/querydsl/querydsl/issues/events{/number}","events_url":"https://api.github.com/repos/querydsl/querydsl/events","assignees_url":"https://api.github.com/repos/querydsl/querydsl/assignees{/user}","branches_url":"https://api.github.com/repos/querydsl/querydsl/branches{/branch}","tags_url":"https://api.github.com/repos/querydsl/querydsl/tags","blobs_url":"https://api.github.com/repos/querydsl/querydsl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/querydsl/querydsl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/querydsl/querydsl/git/refs{/sha}","trees_url":"https://api.github.com/repos/querydsl/querydsl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/querydsl/querydsl/statuses/{sha}","languages_url":"https://api.github.com/repos/querydsl/querydsl/languages","stargazers_url":"https://api.github.com/repos/querydsl/querydsl/stargazers","contributors_url":"https://api.github.com/repos/querydsl/querydsl/contributors","subscribers_url":"https://api.github.com/repos/querydsl/querydsl/subscribers","subscription_url":"https://api.github.com/repos/querydsl/querydsl/subscription","commits_url":"https://api.github.com/repos/querydsl/querydsl/commits{/sha}","git_commits_url":"https://api.github.com/repos/querydsl/querydsl/git/commits{/sha}","comments_url":"https://api.github.com/repos/querydsl/querydsl/comments{/number}","issue_comment_url":"https://api.github.com/repos/querydsl/querydsl/issues/comments{/number}","contents_url":"https://api.github.com/repos/querydsl/querydsl/contents/{+path}","compare_url":"https://api.github.com/repos/querydsl/querydsl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/querydsl/querydsl/merges","archive_url":"https://api.github.com/repos/querydsl/querydsl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/querydsl/querydsl/downloads","issues_url":"https://api.github.com/repos/querydsl/querydsl/issues{/number}","pulls_url":"https://api.github.com/repos/querydsl/querydsl/pulls{/number}","milestones_url":"https://api.github.com/repos/querydsl/querydsl/milestones{/number}","notifications_url":"https://api.github.com/repos/querydsl/querydsl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/querydsl/querydsl/labels{/name}","releases_url":"https://api.github.com/repos/querydsl/querydsl/releases{/id}","deployments_url":"https://api.github.com/repos/querydsl/querydsl/deployments","created_at":"2011-08-05T06:46:32Z","updated_at":"2016-05-03T18:15:15Z","pushed_at":"2016-05-04T21:37:50Z","git_url":"git://github.com/querydsl/querydsl.git","ssh_url":"git@github.com:querydsl/querydsl.git","clone_url":"https://github.com/querydsl/querydsl.git","svn_url":"https://github.com/querydsl/querydsl","homepage":"http://www.querydsl.com","size":57875,"stargazers_count":857,"watchers_count":857,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"open_issues_count":146,"forks":229,"open_issues":146,"watchers":857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/1872"},"html":{"href":"https://github.com/querydsl/querydsl/pull/1872"},"issue":{"href":"https://api.github.com/repos/querydsl/querydsl/issues/1872"},"comments":{"href":"https://api.github.com/repos/querydsl/querydsl/issues/1872/comments"},"review_comments":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/1872/comments"},"review_comment":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/querydsl/querydsl/pulls/1872/commits"},"statuses":{"href":"https://api.github.com/repos/querydsl/querydsl/statuses/426856985e90e84da2fd9be5050f0f18fc8dfdc1"}}}}