{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/77955788","id":77955788,"diff_hunk":"@@ -396,60 +432,66 @@ namespace VC1 {\n     }\n \n     /* 8.7.3.6 Row-skip mode*/\n-    void Parser::decodeRowskipMode(BitReader* br, uint8_t* data, uint32_t width, uint32_t height)\n+    bool Parser::decodeRowskipMode(BitReader* br, uint8_t* data, uint32_t width, uint32_t height)\n     {\n         uint32_t i, j;\n         for (j = 0; j < height; j++) {\n-            if (br->read(1)) {\n+            bool tmp;\n+            READ(tmp);\n+            if (tmp) {\n                 for (i = 0; i < width; i++)\n-                    data[i] = br->read(1);\n+                    READ_BITS(data[i], 1);\n             }\n             else {\n                 memset(data, 0, width);\n             }\n             data += m_mbWidth;\n         }\n+        return true;\n     }\n \n     /* 8.7.3.7 Column-skip mode*/\n-    void Parser::decodeColskipMode(BitReader* br, uint8_t* data, uint32_t width, uint32_t height)\n+    bool Parser::decodeColskipMode(BitReader* br, uint8_t* data, uint32_t width, uint32_t height)\n     {\n         uint32_t i, j;\n         for (i = 0; i < width; i++) {\n-            if (br->read(1)) {\n+            bool tmp;\n+            READ(tmp);\n+            if (tmp) {\n                 for (j = 0; j < height; j++)\n-                    data[j * m_mbWidth] = br->read(1);\n+                    READ_BITS(data[j * m_mbWidth], 1);\n             }\n             else {\n                 for (j = 0; j < height; j++)\n                     data[j * m_mbWidth] = 0;\n             }\n             data++;\n         }\n+        return true;\n     }\n \n     /* Table 80: Norm-2/Diff-2 Code Table */\n     bool Parser::decodeNorm2Mode(BitReader* br, uint8_t* data, uint32_t width, uint32_t height)\n     {\n         uint32_t i;\n-        uint16_t temp;\n+        bool temp;\n         uint8_t* out = data;\n         if ((height * width) & 1)\n-            *out++ = br->read(1);\n+            READ_BITS(*out++, 1);","path":"codecparsers/vc1Parser.cpp","position":319,"original_position":319,"commit_id":"5e9b269d3f9f6a2cf5802059dd3c59bdda00003f","original_commit_id":"5e9b269d3f9f6a2cf5802059dd3c59bdda00003f","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"body":"this will depends on macro unroll, please change it to \r\n```\r\nif ((height * width) & 1) {\r\n     READ_BITS(*out, 1);\r\n     out++;\r\n}\r\n\r\n\r\n```","created_at":"2016-09-08T07:13:18Z","updated_at":"2016-09-08T07:13:18Z","html_url":"https://github.com/01org/libyami/pull/566#discussion_r77955788","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/566","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/77955788"},"html":{"href":"https://github.com/01org/libyami/pull/566#discussion_r77955788"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/566","id":84421540,"html_url":"https://github.com/01org/libyami/pull/566","diff_url":"https://github.com/01org/libyami/pull/566.diff","patch_url":"https://github.com/01org/libyami/pull/566.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/566","number":566,"state":"open","locked":false,"title":"vc1parser: add boundary check for every read bits","user":{"login":"yizhouwei","id":21072199,"avatar_url":"https://avatars.githubusercontent.com/u/21072199?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhouwei","html_url":"https://github.com/yizhouwei","followers_url":"https://api.github.com/users/yizhouwei/followers","following_url":"https://api.github.com/users/yizhouwei/following{/other_user}","gists_url":"https://api.github.com/users/yizhouwei/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhouwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhouwei/subscriptions","organizations_url":"https://api.github.com/users/yizhouwei/orgs","repos_url":"https://api.github.com/users/yizhouwei/repos","events_url":"https://api.github.com/users/yizhouwei/events{/privacy}","received_events_url":"https://api.github.com/users/yizhouwei/received_events","type":"User","site_admin":false},"body":"fix #527 ","created_at":"2016-09-08T06:31:03Z","updated_at":"2016-09-08T07:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ffaa5fd964a9444d92a5bb709ed20a7d03a38b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/566/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/566/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/566/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/5e9b269d3f9f6a2cf5802059dd3c59bdda00003f","head":{"label":"yizhouwei:apache","ref":"apache","sha":"5e9b269d3f9f6a2cf5802059dd3c59bdda00003f","user":{"login":"yizhouwei","id":21072199,"avatar_url":"https://avatars.githubusercontent.com/u/21072199?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhouwei","html_url":"https://github.com/yizhouwei","followers_url":"https://api.github.com/users/yizhouwei/followers","following_url":"https://api.github.com/users/yizhouwei/following{/other_user}","gists_url":"https://api.github.com/users/yizhouwei/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhouwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhouwei/subscriptions","organizations_url":"https://api.github.com/users/yizhouwei/orgs","repos_url":"https://api.github.com/users/yizhouwei/repos","events_url":"https://api.github.com/users/yizhouwei/events{/privacy}","received_events_url":"https://api.github.com/users/yizhouwei/received_events","type":"User","site_admin":false},"repo":{"id":67674821,"name":"libyami","full_name":"yizhouwei/libyami","owner":{"login":"yizhouwei","id":21072199,"avatar_url":"https://avatars.githubusercontent.com/u/21072199?v=3","gravatar_id":"","url":"https://api.github.com/users/yizhouwei","html_url":"https://github.com/yizhouwei","followers_url":"https://api.github.com/users/yizhouwei/followers","following_url":"https://api.github.com/users/yizhouwei/following{/other_user}","gists_url":"https://api.github.com/users/yizhouwei/gists{/gist_id}","starred_url":"https://api.github.com/users/yizhouwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizhouwei/subscriptions","organizations_url":"https://api.github.com/users/yizhouwei/orgs","repos_url":"https://api.github.com/users/yizhouwei/repos","events_url":"https://api.github.com/users/yizhouwei/events{/privacy}","received_events_url":"https://api.github.com/users/yizhouwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yizhouwei/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/yizhouwei/libyami","forks_url":"https://api.github.com/repos/yizhouwei/libyami/forks","keys_url":"https://api.github.com/repos/yizhouwei/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yizhouwei/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yizhouwei/libyami/teams","hooks_url":"https://api.github.com/repos/yizhouwei/libyami/hooks","issue_events_url":"https://api.github.com/repos/yizhouwei/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/yizhouwei/libyami/events","assignees_url":"https://api.github.com/repos/yizhouwei/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/yizhouwei/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/yizhouwei/libyami/tags","blobs_url":"https://api.github.com/repos/yizhouwei/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yizhouwei/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yizhouwei/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/yizhouwei/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yizhouwei/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/yizhouwei/libyami/languages","stargazers_url":"https://api.github.com/repos/yizhouwei/libyami/stargazers","contributors_url":"https://api.github.com/repos/yizhouwei/libyami/contributors","subscribers_url":"https://api.github.com/repos/yizhouwei/libyami/subscribers","subscription_url":"https://api.github.com/repos/yizhouwei/libyami/subscription","commits_url":"https://api.github.com/repos/yizhouwei/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/yizhouwei/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/yizhouwei/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/yizhouwei/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/yizhouwei/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/yizhouwei/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yizhouwei/libyami/merges","archive_url":"https://api.github.com/repos/yizhouwei/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yizhouwei/libyami/downloads","issues_url":"https://api.github.com/repos/yizhouwei/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/yizhouwei/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/yizhouwei/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/yizhouwei/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yizhouwei/libyami/labels{/name}","releases_url":"https://api.github.com/repos/yizhouwei/libyami/releases{/id}","deployments_url":"https://api.github.com/repos/yizhouwei/libyami/deployments","created_at":"2016-09-08T06:24:15Z","updated_at":"2016-09-08T06:24:17Z","pushed_at":"2016-09-08T06:30:36Z","git_url":"git://github.com/yizhouwei/libyami.git","ssh_url":"git@github.com:yizhouwei/libyami.git","clone_url":"https://github.com/yizhouwei/libyami.git","svn_url":"https://github.com/yizhouwei/libyami","homepage":null,"size":4973,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"apache"}},"base":{"label":"01org:apache","ref":"apache","sha":"332fc9fe8e7a7db12bb501c4163a5d6a0d553bb4","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","deployments_url":"https://api.github.com/repos/01org/libyami/deployments","created_at":"2014-04-01T06:44:19Z","updated_at":"2016-09-02T03:40:37Z","pushed_at":"2016-09-08T06:31:03Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":4973,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":31,"forks":58,"open_issues":31,"watchers":40,"default_branch":"apache"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/566"},"html":{"href":"https://github.com/01org/libyami/pull/566"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/566"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/5e9b269d3f9f6a2cf5802059dd3c59bdda00003f"}}}}
{"actor":{"display_login":"xuguangxin"}}