{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/70488762","id":70488762,"diff_hunk":"@@ -146,11 +146,16 @@ private void addMetadataListener() {\n         this.metadata.addListener(new Metadata.Listener() {\n             @Override\n             public void onMetadataUpdate(Cluster cluster) {\n-                // if we encounter any unauthorized topics, raise an exception to the user\n-                if (!cluster.unauthorizedTopics().isEmpty())\n-                    throw new TopicAuthorizationException(new HashSet<>(cluster.unauthorizedTopics()));\n \n                 if (subscriptions.hasPatternSubscription()) {\n+\n+                    for (String topic : cluster.unauthorizedTopics()) {\n+                        if (subscriptions.getSubscribedPattern().matcher(topic).matches())\n+                            throw new TopicAuthorizationException(topic);\n+                        else\n+                            log.debug(\"Ignoring unauthorized topic {}, which not matches with subscribed pattern\", topic);","path":"clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java","position":14,"original_position":14,"commit_id":"f2a6e806c8c3d181dc3d16ab90548bdffde404af","original_commit_id":"f2a6e806c8c3d181dc3d16ab90548bdffde404af","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"Not sure if we want to provide information on a topic on which user does not have permissions.","created_at":"2016-07-12T18:01:35Z","updated_at":"2016-07-12T18:01:35Z","html_url":"https://github.com/apache/kafka/pull/1615#discussion_r70488762","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1615","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/70488762"},"html":{"href":"https://github.com/apache/kafka/pull/1615#discussion_r70488762"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1615"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1615","id":77159196,"html_url":"https://github.com/apache/kafka/pull/1615","diff_url":"https://github.com/apache/kafka/pull/1615.diff","patch_url":"https://github.com/apache/kafka/pull/1615.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1615","number":1615,"state":"open","locked":false,"title":"KAFKA-3950: kafka mirror maker tool is not respecting whitelist option","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-12T17:35:38Z","updated_at":"2016-07-12T18:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce808eeed4e86c2a489eec683a539a3260fed525","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1615/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1615/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1615/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/f2a6e806c8c3d181dc3d16ab90548bdffde404af","head":{"label":"omkreddy:KAFKA-3950-CONSUMER-PATTREN","ref":"KAFKA-3950-CONSUMER-PATTREN","sha":"f2a6e806c8c3d181dc3d16ab90548bdffde404af","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"repo":{"id":51066257,"name":"kafka","full_name":"omkreddy/kafka","owner":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omkreddy/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/omkreddy/kafka","forks_url":"https://api.github.com/repos/omkreddy/kafka/forks","keys_url":"https://api.github.com/repos/omkreddy/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omkreddy/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omkreddy/kafka/teams","hooks_url":"https://api.github.com/repos/omkreddy/kafka/hooks","issue_events_url":"https://api.github.com/repos/omkreddy/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/omkreddy/kafka/events","assignees_url":"https://api.github.com/repos/omkreddy/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/omkreddy/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/omkreddy/kafka/tags","blobs_url":"https://api.github.com/repos/omkreddy/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omkreddy/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omkreddy/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/omkreddy/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omkreddy/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/omkreddy/kafka/languages","stargazers_url":"https://api.github.com/repos/omkreddy/kafka/stargazers","contributors_url":"https://api.github.com/repos/omkreddy/kafka/contributors","subscribers_url":"https://api.github.com/repos/omkreddy/kafka/subscribers","subscription_url":"https://api.github.com/repos/omkreddy/kafka/subscription","commits_url":"https://api.github.com/repos/omkreddy/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/omkreddy/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/omkreddy/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/omkreddy/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/omkreddy/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/omkreddy/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omkreddy/kafka/merges","archive_url":"https://api.github.com/repos/omkreddy/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omkreddy/kafka/downloads","issues_url":"https://api.github.com/repos/omkreddy/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/omkreddy/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/omkreddy/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/omkreddy/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omkreddy/kafka/labels{/name}","releases_url":"https://api.github.com/repos/omkreddy/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/omkreddy/kafka/deployments","created_at":"2016-02-04T09:42:20Z","updated_at":"2016-02-04T09:42:24Z","pushed_at":"2016-07-12T17:34:22Z","git_url":"git://github.com/omkreddy/kafka.git","ssh_url":"git@github.com:omkreddy/kafka.git","clone_url":"https://github.com/omkreddy/kafka.git","svn_url":"https://github.com/omkreddy/kafka","homepage":null,"size":32306,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"fc47b9fa6b89a612cd0f79dfc689ee3813fd405a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-07-12T13:45:23Z","pushed_at":"2016-07-12T17:35:38Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":45287,"stargazers_count":3428,"watchers_count":3428,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2098,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":212,"forks":2098,"open_issues":212,"watchers":3428,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1615"},"html":{"href":"https://github.com/apache/kafka/pull/1615"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1615"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1615/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1615/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1615/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/f2a6e806c8c3d181dc3d16ab90548bdffde404af"}}}}
{"actor":{"display_login":"SinghAsDev"}}