{"action":"created","comment":{"url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/comments/81315586","pull_request_review_id":2303931,"id":81315586,"diff_hunk":"@@ -70,7 +70,7 @@ module.exports = function (context) {\n             } else {\n                 allowed = false;\n             }\n-        } else if (expression.type === \"CallExpression\") {\n+        } else if ((expression.type === \"CallExpression\") && (expression.callee.property)) {\n             var funcName = expression.callee.name || expression.callee.property.name;","path":"lib/rules/no-unsafe-innerhtml.js","position":6,"original_position":6,"commit_id":"79a33b4cfeb2835221dbc9eaad83e8c9a1f825a0","original_commit_id":"79a33b4cfeb2835221dbc9eaad83e8c9a1f825a0","user":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"body":"If expression.callee.property doesn't exist, we can use expression.callee.name (see line 74).","created_at":"2016-09-30T10:32:04Z","updated_at":"2016-09-30T10:32:04Z","html_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8#discussion_r81315586","pull_request_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/comments/81315586"},"html":{"href":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8#discussion_r81315586"},"pull_request":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8","id":87469489,"html_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8","diff_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8.diff","patch_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8.patch","issue_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/8","number":8,"state":"open","locked":false,"title":"check that expression.callee.property exists","user":{"login":"LockeLamora","id":8144347,"avatar_url":"https://avatars.githubusercontent.com/u/8144347?v=3","gravatar_id":"","url":"https://api.github.com/users/LockeLamora","html_url":"https://github.com/LockeLamora","followers_url":"https://api.github.com/users/LockeLamora/followers","following_url":"https://api.github.com/users/LockeLamora/following{/other_user}","gists_url":"https://api.github.com/users/LockeLamora/gists{/gist_id}","starred_url":"https://api.github.com/users/LockeLamora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LockeLamora/subscriptions","organizations_url":"https://api.github.com/users/LockeLamora/orgs","repos_url":"https://api.github.com/users/LockeLamora/repos","events_url":"https://api.github.com/users/LockeLamora/events{/privacy}","received_events_url":"https://api.github.com/users/LockeLamora/received_events","type":"User","site_admin":false},"body":"added the following check to line 73 to ensure expression.callee.property exists before referencing it:\r\n\r\n} else if ((expression.type === \"CallExpression\") **&& (expression.callee.property**)) {\r\n            var funcName = expression.callee.name || expression.callee.property.name;\r\n            if (VALID_UNWRAPPERS.indexOf(funcName) !== -1) {\r\n                allowed = true;\r\n            }","created_at":"2016-09-30T10:24:54Z","updated_at":"2016-09-30T10:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f0cb373bf4e1921b6ad87fdd056fc451937d7cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/8/comments","statuses_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/statuses/79a33b4cfeb2835221dbc9eaad83e8c9a1f825a0","head":{"label":"LockeLamora:bug-expression.callee","ref":"bug-expression.callee","sha":"79a33b4cfeb2835221dbc9eaad83e8c9a1f825a0","user":{"login":"LockeLamora","id":8144347,"avatar_url":"https://avatars.githubusercontent.com/u/8144347?v=3","gravatar_id":"","url":"https://api.github.com/users/LockeLamora","html_url":"https://github.com/LockeLamora","followers_url":"https://api.github.com/users/LockeLamora/followers","following_url":"https://api.github.com/users/LockeLamora/following{/other_user}","gists_url":"https://api.github.com/users/LockeLamora/gists{/gist_id}","starred_url":"https://api.github.com/users/LockeLamora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LockeLamora/subscriptions","organizations_url":"https://api.github.com/users/LockeLamora/orgs","repos_url":"https://api.github.com/users/LockeLamora/repos","events_url":"https://api.github.com/users/LockeLamora/events{/privacy}","received_events_url":"https://api.github.com/users/LockeLamora/received_events","type":"User","site_admin":false},"repo":{"id":69657102,"name":"eslint-plugin-no-unsafe-innerhtml","full_name":"LockeLamora/eslint-plugin-no-unsafe-innerhtml","owner":{"login":"LockeLamora","id":8144347,"avatar_url":"https://avatars.githubusercontent.com/u/8144347?v=3","gravatar_id":"","url":"https://api.github.com/users/LockeLamora","html_url":"https://github.com/LockeLamora","followers_url":"https://api.github.com/users/LockeLamora/followers","following_url":"https://api.github.com/users/LockeLamora/following{/other_user}","gists_url":"https://api.github.com/users/LockeLamora/gists{/gist_id}","starred_url":"https://api.github.com/users/LockeLamora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LockeLamora/subscriptions","organizations_url":"https://api.github.com/users/LockeLamora/orgs","repos_url":"https://api.github.com/users/LockeLamora/repos","events_url":"https://api.github.com/users/LockeLamora/events{/privacy}","received_events_url":"https://api.github.com/users/LockeLamora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LockeLamora/eslint-plugin-no-unsafe-innerhtml","description":"custom ESLint rule to disallows unsafe innerHTML, outerHTML and insertAdjacentHTML","fork":true,"url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml","forks_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/forks","keys_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/teams","hooks_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/hooks","issue_events_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/issues/events{/number}","events_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/events","assignees_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/assignees{/user}","branches_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/branches{/branch}","tags_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/tags","blobs_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/statuses/{sha}","languages_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/languages","stargazers_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/stargazers","contributors_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/contributors","subscribers_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/subscribers","subscription_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/subscription","commits_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/contents/{+path}","compare_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/merges","archive_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/downloads","issues_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/issues{/number}","pulls_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/pulls{/number}","milestones_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/milestones{/number}","notifications_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/labels{/name}","releases_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/releases{/id}","deployments_url":"https://api.github.com/repos/LockeLamora/eslint-plugin-no-unsafe-innerhtml/deployments","created_at":"2016-09-30T10:20:12Z","updated_at":"2016-09-30T10:20:13Z","pushed_at":"2016-09-30T10:23:38Z","git_url":"git://github.com/LockeLamora/eslint-plugin-no-unsafe-innerhtml.git","ssh_url":"git@github.com:LockeLamora/eslint-plugin-no-unsafe-innerhtml.git","clone_url":"https://github.com/LockeLamora/eslint-plugin-no-unsafe-innerhtml.git","svn_url":"https://github.com/LockeLamora/eslint-plugin-no-unsafe-innerhtml","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozfreddyb:master","ref":"master","sha":"cf8039a19a8a2af2039f26467e3f641ee5168194","user":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"repo":{"id":35539361,"name":"eslint-plugin-no-unsafe-innerhtml","full_name":"mozfreddyb/eslint-plugin-no-unsafe-innerhtml","owner":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml","description":"custom ESLint rule to disallows unsafe innerHTML, outerHTML and insertAdjacentHTML","fork":false,"url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml","forks_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/forks","keys_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/teams","hooks_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/hooks","issue_events_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/events{/number}","events_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/events","assignees_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/assignees{/user}","branches_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/branches{/branch}","tags_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/tags","blobs_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/statuses/{sha}","languages_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/languages","stargazers_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/stargazers","contributors_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/contributors","subscribers_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/subscribers","subscription_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/subscription","commits_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/contents/{+path}","compare_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/merges","archive_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/downloads","issues_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues{/number}","pulls_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls{/number}","milestones_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/milestones{/number}","notifications_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/labels{/name}","releases_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/releases{/id}","deployments_url":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/deployments","created_at":"2015-05-13T09:12:59Z","updated_at":"2016-09-24T15:24:22Z","pushed_at":"2016-09-30T10:24:54Z","git_url":"git://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml.git","ssh_url":"git@github.com:mozfreddyb/eslint-plugin-no-unsafe-innerhtml.git","clone_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml.git","svn_url":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml","homepage":null,"size":22,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8"},"html":{"href":"https://github.com/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pull/8"},"issue":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/8"},"comments":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mozfreddyb/eslint-plugin-no-unsafe-innerhtml/statuses/79a33b4cfeb2835221dbc9eaad83e8c9a1f825a0"}}}}
{"actor":{"display_login":"mozfreddyb"}}