{"action":"opened","number":8204,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/8204","id":68482314,"html_url":"https://github.com/dotnet/corefx/pull/8204","diff_url":"https://github.com/dotnet/corefx/pull/8204.diff","patch_url":"https://github.com/dotnet/corefx/pull/8204.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/8204","number":8204,"state":"open","locked":false,"title":"Remove Hungarian notation from TypeKind","user":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"body":"This is the first of my attempts to make the Microsoft.CSharp codebase more readable, as part of #7458. A lot of enums in the assembly have their values unnecessarily prefixed with the initials of the enum; for example, `PredefinedName` has all its values prefixed with `PN_`, `PredefinedType` with `PT_`, and so on. This PR removes such notation for `TypeKind`, which is prefixed with `TK_`. (As these types are used in a bunch of different locations throughout the codebase, I'm going to be submitting separate PRs for each type to make code review easier.)\r\n\r\ncc @VSadov ","created_at":"2016-04-30T23:41:41Z","updated_at":"2016-04-30T23:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/8204/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/8204/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/8204/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/dd1161aed6ac8e416be79846d54b1340c7233664","head":{"label":"jamesqo:csharp-1","ref":"csharp-1","sha":"dd1161aed6ac8e416be79846d54b1340c7233664","user":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"repo":{"id":37746383,"name":"corefx","full_name":"jamesqo/corefx","owner":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesqo/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/jamesqo/corefx","forks_url":"https://api.github.com/repos/jamesqo/corefx/forks","keys_url":"https://api.github.com/repos/jamesqo/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesqo/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesqo/corefx/teams","hooks_url":"https://api.github.com/repos/jamesqo/corefx/hooks","issue_events_url":"https://api.github.com/repos/jamesqo/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/jamesqo/corefx/events","assignees_url":"https://api.github.com/repos/jamesqo/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/jamesqo/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/jamesqo/corefx/tags","blobs_url":"https://api.github.com/repos/jamesqo/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesqo/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesqo/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesqo/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesqo/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesqo/corefx/languages","stargazers_url":"https://api.github.com/repos/jamesqo/corefx/stargazers","contributors_url":"https://api.github.com/repos/jamesqo/corefx/contributors","subscribers_url":"https://api.github.com/repos/jamesqo/corefx/subscribers","subscription_url":"https://api.github.com/repos/jamesqo/corefx/subscription","commits_url":"https://api.github.com/repos/jamesqo/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesqo/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesqo/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesqo/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesqo/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/jamesqo/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesqo/corefx/merges","archive_url":"https://api.github.com/repos/jamesqo/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesqo/corefx/downloads","issues_url":"https://api.github.com/repos/jamesqo/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/jamesqo/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesqo/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesqo/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesqo/corefx/labels{/name}","releases_url":"https://api.github.com/repos/jamesqo/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/jamesqo/corefx/deployments","created_at":"2015-06-19T21:17:21Z","updated_at":"2016-02-16T16:19:27Z","pushed_at":"2016-04-30T23:36:56Z","git_url":"git://github.com/jamesqo/corefx.git","ssh_url":"git@github.com:jamesqo/corefx.git","clone_url":"https://github.com/jamesqo/corefx.git","svn_url":"https://github.com/jamesqo/corefx","homepage":"http://dotnet.github.io/core/","size":66114,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ba6b648de127c929f632b47f81e2d3ff16d74587","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-30T20:43:04Z","pushed_at":"2016-04-30T22:48:46Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":90539,"stargazers_count":9605,"watchers_count":9605,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2287,"mirror_url":null,"open_issues_count":960,"forks":2287,"open_issues":960,"watchers":9605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8204"},"html":{"href":"https://github.com/dotnet/corefx/pull/8204"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8204"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8204/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8204/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8204/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/dd1161aed6ac8e416be79846d54b1340c7233664"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":210,"deletions":210,"changed_files":12}}