{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1","id":67602883,"html_url":"https://github.com/pulsarx58/pimcore/pull/1","diff_url":"https://github.com/pulsarx58/pimcore/pull/1.diff","patch_url":"https://github.com/pulsarx58/pimcore/pull/1.patch","issue_url":"https://api.github.com/repos/pulsarx58/pimcore/issues/1","number":1,"state":"closed","locked":false,"title":"Fix language fallback for localized field value","user":{"login":"pulsarx58","id":7124617,"avatar_url":"https://avatars.githubusercontent.com/u/7124617?v=3","gravatar_id":"","url":"https://api.github.com/users/pulsarx58","html_url":"https://github.com/pulsarx58","followers_url":"https://api.github.com/users/pulsarx58/followers","following_url":"https://api.github.com/users/pulsarx58/following{/other_user}","gists_url":"https://api.github.com/users/pulsarx58/gists{/gist_id}","starred_url":"https://api.github.com/users/pulsarx58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulsarx58/subscriptions","organizations_url":"https://api.github.com/users/pulsarx58/orgs","repos_url":"https://api.github.com/users/pulsarx58/repos","events_url":"https://api.github.com/users/pulsarx58/events{/privacy}","received_events_url":"https://api.github.com/users/pulsarx58/received_events","type":"User","site_admin":false},"body":"For now it returns the latest localized version from fallback list regardless of value. \r\n\r\nExample: For now, if I have object with localized field \"text\", and three locales specified in System Settings: en_US, de_DE and en_150. Fallback specified for de_DE is en_150, en_US.\r\n$obj->text:en_US = \"Some text for US\"\r\n$obj->text:en_150 = \"Some text for EU\"\r\n$obj->text:de_DE = \"\"\r\n\r\n$obj->localizedfields->getLocalizedValue('text', 'de_DE')  will always return \"Some text for US\" if de_DE value not specified.\r\n\r\nAfter fix it will return first not empty value from fallback list.","created_at":"2016-04-23T10:24:15Z","updated_at":"2016-06-16T14:01:06Z","closed_at":"2016-06-16T14:01:06Z","merged_at":null,"merge_commit_sha":"342e0a95228a44bbb4ed384b3b89a48aee87518a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1/commits","review_comments_url":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1/comments","review_comment_url":"https://api.github.com/repos/pulsarx58/pimcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulsarx58/pimcore/issues/1/comments","statuses_url":"https://api.github.com/repos/pulsarx58/pimcore/statuses/16b3e8bbde3b3367b24103be15f6703f784e33dc","head":{"label":"pimcore:master","ref":"master","sha":"16b3e8bbde3b3367b24103be15f6703f784e33dc","user":{"login":"pimcore","id":686745,"avatar_url":"https://avatars.githubusercontent.com/u/686745?v=3","gravatar_id":"","url":"https://api.github.com/users/pimcore","html_url":"https://github.com/pimcore","followers_url":"https://api.github.com/users/pimcore/followers","following_url":"https://api.github.com/users/pimcore/following{/other_user}","gists_url":"https://api.github.com/users/pimcore/gists{/gist_id}","starred_url":"https://api.github.com/users/pimcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimcore/subscriptions","organizations_url":"https://api.github.com/users/pimcore/orgs","repos_url":"https://api.github.com/users/pimcore/repos","events_url":"https://api.github.com/users/pimcore/events{/privacy}","received_events_url":"https://api.github.com/users/pimcore/received_events","type":"Organization","site_admin":false},"repo":{"id":2686502,"name":"pimcore","full_name":"pimcore/pimcore","owner":{"login":"pimcore","id":686745,"avatar_url":"https://avatars.githubusercontent.com/u/686745?v=3","gravatar_id":"","url":"https://api.github.com/users/pimcore","html_url":"https://github.com/pimcore","followers_url":"https://api.github.com/users/pimcore/followers","following_url":"https://api.github.com/users/pimcore/following{/other_user}","gists_url":"https://api.github.com/users/pimcore/gists{/gist_id}","starred_url":"https://api.github.com/users/pimcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimcore/subscriptions","organizations_url":"https://api.github.com/users/pimcore/orgs","repos_url":"https://api.github.com/users/pimcore/repos","events_url":"https://api.github.com/users/pimcore/events{/privacy}","received_events_url":"https://api.github.com/users/pimcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pimcore/pimcore","description":"Content & Product Management Framework (CMS/PIM/E-Commerce)","fork":false,"url":"https://api.github.com/repos/pimcore/pimcore","forks_url":"https://api.github.com/repos/pimcore/pimcore/forks","keys_url":"https://api.github.com/repos/pimcore/pimcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pimcore/pimcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pimcore/pimcore/teams","hooks_url":"https://api.github.com/repos/pimcore/pimcore/hooks","issue_events_url":"https://api.github.com/repos/pimcore/pimcore/issues/events{/number}","events_url":"https://api.github.com/repos/pimcore/pimcore/events","assignees_url":"https://api.github.com/repos/pimcore/pimcore/assignees{/user}","branches_url":"https://api.github.com/repos/pimcore/pimcore/branches{/branch}","tags_url":"https://api.github.com/repos/pimcore/pimcore/tags","blobs_url":"https://api.github.com/repos/pimcore/pimcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pimcore/pimcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pimcore/pimcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/pimcore/pimcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pimcore/pimcore/statuses/{sha}","languages_url":"https://api.github.com/repos/pimcore/pimcore/languages","stargazers_url":"https://api.github.com/repos/pimcore/pimcore/stargazers","contributors_url":"https://api.github.com/repos/pimcore/pimcore/contributors","subscribers_url":"https://api.github.com/repos/pimcore/pimcore/subscribers","subscription_url":"https://api.github.com/repos/pimcore/pimcore/subscription","commits_url":"https://api.github.com/repos/pimcore/pimcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/pimcore/pimcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/pimcore/pimcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/pimcore/pimcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/pimcore/pimcore/contents/{+path}","compare_url":"https://api.github.com/repos/pimcore/pimcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pimcore/pimcore/merges","archive_url":"https://api.github.com/repos/pimcore/pimcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pimcore/pimcore/downloads","issues_url":"https://api.github.com/repos/pimcore/pimcore/issues{/number}","pulls_url":"https://api.github.com/repos/pimcore/pimcore/pulls{/number}","milestones_url":"https://api.github.com/repos/pimcore/pimcore/milestones{/number}","notifications_url":"https://api.github.com/repos/pimcore/pimcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pimcore/pimcore/labels{/name}","releases_url":"https://api.github.com/repos/pimcore/pimcore/releases{/id}","deployments_url":"https://api.github.com/repos/pimcore/pimcore/deployments","created_at":"2011-11-01T09:16:14Z","updated_at":"2016-06-15T17:56:28Z","pushed_at":"2016-06-16T13:25:25Z","git_url":"git://github.com/pimcore/pimcore.git","ssh_url":"git@github.com:pimcore/pimcore.git","clone_url":"https://github.com/pimcore/pimcore.git","svn_url":"https://github.com/pimcore/pimcore","homepage":"http://www.pimcore.org/","size":303755,"stargazers_count":545,"watchers_count":545,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":71,"forks":265,"open_issues":71,"watchers":545,"default_branch":"master"}},"base":{"label":"pulsarx58:master","ref":"master","sha":"c3a4cece673b19a413ad636c4d01693e31b3afb7","user":{"login":"pulsarx58","id":7124617,"avatar_url":"https://avatars.githubusercontent.com/u/7124617?v=3","gravatar_id":"","url":"https://api.github.com/users/pulsarx58","html_url":"https://github.com/pulsarx58","followers_url":"https://api.github.com/users/pulsarx58/followers","following_url":"https://api.github.com/users/pulsarx58/following{/other_user}","gists_url":"https://api.github.com/users/pulsarx58/gists{/gist_id}","starred_url":"https://api.github.com/users/pulsarx58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulsarx58/subscriptions","organizations_url":"https://api.github.com/users/pulsarx58/orgs","repos_url":"https://api.github.com/users/pulsarx58/repos","events_url":"https://api.github.com/users/pulsarx58/events{/privacy}","received_events_url":"https://api.github.com/users/pulsarx58/received_events","type":"User","site_admin":false},"repo":{"id":55086770,"name":"pimcore","full_name":"pulsarx58/pimcore","owner":{"login":"pulsarx58","id":7124617,"avatar_url":"https://avatars.githubusercontent.com/u/7124617?v=3","gravatar_id":"","url":"https://api.github.com/users/pulsarx58","html_url":"https://github.com/pulsarx58","followers_url":"https://api.github.com/users/pulsarx58/followers","following_url":"https://api.github.com/users/pulsarx58/following{/other_user}","gists_url":"https://api.github.com/users/pulsarx58/gists{/gist_id}","starred_url":"https://api.github.com/users/pulsarx58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulsarx58/subscriptions","organizations_url":"https://api.github.com/users/pulsarx58/orgs","repos_url":"https://api.github.com/users/pulsarx58/repos","events_url":"https://api.github.com/users/pulsarx58/events{/privacy}","received_events_url":"https://api.github.com/users/pulsarx58/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pulsarx58/pimcore","description":"Content & Product Management Framework (CMS/PIM/E-Commerce)","fork":true,"url":"https://api.github.com/repos/pulsarx58/pimcore","forks_url":"https://api.github.com/repos/pulsarx58/pimcore/forks","keys_url":"https://api.github.com/repos/pulsarx58/pimcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulsarx58/pimcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulsarx58/pimcore/teams","hooks_url":"https://api.github.com/repos/pulsarx58/pimcore/hooks","issue_events_url":"https://api.github.com/repos/pulsarx58/pimcore/issues/events{/number}","events_url":"https://api.github.com/repos/pulsarx58/pimcore/events","assignees_url":"https://api.github.com/repos/pulsarx58/pimcore/assignees{/user}","branches_url":"https://api.github.com/repos/pulsarx58/pimcore/branches{/branch}","tags_url":"https://api.github.com/repos/pulsarx58/pimcore/tags","blobs_url":"https://api.github.com/repos/pulsarx58/pimcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulsarx58/pimcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulsarx58/pimcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulsarx58/pimcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulsarx58/pimcore/statuses/{sha}","languages_url":"https://api.github.com/repos/pulsarx58/pimcore/languages","stargazers_url":"https://api.github.com/repos/pulsarx58/pimcore/stargazers","contributors_url":"https://api.github.com/repos/pulsarx58/pimcore/contributors","subscribers_url":"https://api.github.com/repos/pulsarx58/pimcore/subscribers","subscription_url":"https://api.github.com/repos/pulsarx58/pimcore/subscription","commits_url":"https://api.github.com/repos/pulsarx58/pimcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulsarx58/pimcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulsarx58/pimcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulsarx58/pimcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulsarx58/pimcore/contents/{+path}","compare_url":"https://api.github.com/repos/pulsarx58/pimcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulsarx58/pimcore/merges","archive_url":"https://api.github.com/repos/pulsarx58/pimcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulsarx58/pimcore/downloads","issues_url":"https://api.github.com/repos/pulsarx58/pimcore/issues{/number}","pulls_url":"https://api.github.com/repos/pulsarx58/pimcore/pulls{/number}","milestones_url":"https://api.github.com/repos/pulsarx58/pimcore/milestones{/number}","notifications_url":"https://api.github.com/repos/pulsarx58/pimcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulsarx58/pimcore/labels{/name}","releases_url":"https://api.github.com/repos/pulsarx58/pimcore/releases{/id}","deployments_url":"https://api.github.com/repos/pulsarx58/pimcore/deployments","created_at":"2016-03-30T18:23:38Z","updated_at":"2016-03-30T18:23:49Z","pushed_at":"2016-06-16T13:25:27Z","git_url":"git://github.com/pulsarx58/pimcore.git","ssh_url":"git@github.com:pulsarx58/pimcore.git","clone_url":"https://github.com/pulsarx58/pimcore.git","svn_url":"https://github.com/pulsarx58/pimcore","homepage":"http://www.pimcore.org/","size":288498,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1"},"html":{"href":"https://github.com/pulsarx58/pimcore/pull/1"},"issue":{"href":"https://api.github.com/repos/pulsarx58/pimcore/issues/1"},"comments":{"href":"https://api.github.com/repos/pulsarx58/pimcore/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/pulsarx58/pimcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulsarx58/pimcore/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/pulsarx58/pimcore/statuses/16b3e8bbde3b3367b24103be15f6703f784e33dc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":724,"additions":12333,"deletions":15932,"changed_files":2132}}
{"actor":{"display_login":"pulsarx58"}}