{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/comments/88185642","pull_request_review_id":8765576,"id":88185642,"diff_hunk":"@@ -0,0 +1,16 @@\n+.modal-header {\n+\tborder-top-left-radius: 4px;","path":"src/theme/_modals.scss","position":2,"original_position":2,"commit_id":"f5ba3fba684aee1762cc62882f19958bcfec2b82","original_commit_id":"f5ba3fba684aee1762cc62882f19958bcfec2b82","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars.githubusercontent.com/u/19857479?v=3","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"I will let @talend-sromain answer","created_at":"2016-11-16T08:06:47Z","updated_at":"2016-11-16T08:06:47Z","html_url":"https://github.com/Talend/bootstrap-theme/pull/71#discussion_r88185642","pull_request_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/comments/88185642"},"html":{"href":"https://github.com/Talend/bootstrap-theme/pull/71#discussion_r88185642"},"pull_request":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71","id":93561374,"html_url":"https://github.com/Talend/bootstrap-theme/pull/71","diff_url":"https://github.com/Talend/bootstrap-theme/pull/71.diff","patch_url":"https://github.com/Talend/bootstrap-theme/pull/71.patch","issue_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/71","number":71,"state":"open","locked":false,"title":"fix(modal): add style for modal","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars.githubusercontent.com/u/19857479?v=3","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [x] The commit(s) message(s) follows our [guidelines](https://github.com/Talend/bootstrap-theme/blob/master/CONTRIBUTING.md#commit-message-format)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [x] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nThe modal don't follow the style guide of 'dialog box'\r\n\r\n**What is the new behavior?**\r\n\r\nThe modal follow part of the style guide of 'dialog box'\r\n\r\n<img width=\"604\" alt=\"screen shot 2016-11-14 at 13 54 07\" src=\"https://cloud.githubusercontent.com/assets/19857479/20265526/d313eafc-aa71-11e6-98be-9c2b1ae17598.png\">\r\n","created_at":"2016-11-14T12:54:15Z","updated_at":"2016-11-16T08:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf8a1b82a3b13cb3afa67ef11a7496bf846d505","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/71/comments","statuses_url":"https://api.github.com/repos/Talend/bootstrap-theme/statuses/f5ba3fba684aee1762cc62882f19958bcfec2b82","head":{"label":"Talend:fix/modal","ref":"fix/modal","sha":"f5ba3fba684aee1762cc62882f19958bcfec2b82","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":65370758,"name":"bootstrap-theme","full_name":"Talend/bootstrap-theme","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/bootstrap-theme","description":"Talend Bootstrap theme","fork":false,"url":"https://api.github.com/repos/Talend/bootstrap-theme","forks_url":"https://api.github.com/repos/Talend/bootstrap-theme/forks","keys_url":"https://api.github.com/repos/Talend/bootstrap-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/bootstrap-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/bootstrap-theme/teams","hooks_url":"https://api.github.com/repos/Talend/bootstrap-theme/hooks","issue_events_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/bootstrap-theme/events","assignees_url":"https://api.github.com/repos/Talend/bootstrap-theme/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/bootstrap-theme/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/bootstrap-theme/tags","blobs_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/bootstrap-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/bootstrap-theme/languages","stargazers_url":"https://api.github.com/repos/Talend/bootstrap-theme/stargazers","contributors_url":"https://api.github.com/repos/Talend/bootstrap-theme/contributors","subscribers_url":"https://api.github.com/repos/Talend/bootstrap-theme/subscribers","subscription_url":"https://api.github.com/repos/Talend/bootstrap-theme/subscription","commits_url":"https://api.github.com/repos/Talend/bootstrap-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/bootstrap-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/bootstrap-theme/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/bootstrap-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/bootstrap-theme/merges","archive_url":"https://api.github.com/repos/Talend/bootstrap-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/bootstrap-theme/downloads","issues_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/bootstrap-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/bootstrap-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/bootstrap-theme/labels{/name}","releases_url":"https://api.github.com/repos/Talend/bootstrap-theme/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/bootstrap-theme/deployments","created_at":"2016-08-10T09:46:47Z","updated_at":"2016-10-23T15:08:49Z","pushed_at":"2016-11-15T17:29:58Z","git_url":"git://github.com/Talend/bootstrap-theme.git","ssh_url":"git@github.com:Talend/bootstrap-theme.git","clone_url":"https://github.com/Talend/bootstrap-theme.git","svn_url":"https://github.com/Talend/bootstrap-theme","homepage":"https://talend.github.io/bootstrap-theme","size":3104,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":7,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"c5756cc4dead07c61feabc5ea1f15a34027d24a1","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":65370758,"name":"bootstrap-theme","full_name":"Talend/bootstrap-theme","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/bootstrap-theme","description":"Talend Bootstrap theme","fork":false,"url":"https://api.github.com/repos/Talend/bootstrap-theme","forks_url":"https://api.github.com/repos/Talend/bootstrap-theme/forks","keys_url":"https://api.github.com/repos/Talend/bootstrap-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/bootstrap-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/bootstrap-theme/teams","hooks_url":"https://api.github.com/repos/Talend/bootstrap-theme/hooks","issue_events_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/bootstrap-theme/events","assignees_url":"https://api.github.com/repos/Talend/bootstrap-theme/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/bootstrap-theme/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/bootstrap-theme/tags","blobs_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/bootstrap-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/bootstrap-theme/languages","stargazers_url":"https://api.github.com/repos/Talend/bootstrap-theme/stargazers","contributors_url":"https://api.github.com/repos/Talend/bootstrap-theme/contributors","subscribers_url":"https://api.github.com/repos/Talend/bootstrap-theme/subscribers","subscription_url":"https://api.github.com/repos/Talend/bootstrap-theme/subscription","commits_url":"https://api.github.com/repos/Talend/bootstrap-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/bootstrap-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/bootstrap-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/bootstrap-theme/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/bootstrap-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/bootstrap-theme/merges","archive_url":"https://api.github.com/repos/Talend/bootstrap-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/bootstrap-theme/downloads","issues_url":"https://api.github.com/repos/Talend/bootstrap-theme/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/bootstrap-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/bootstrap-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/bootstrap-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/bootstrap-theme/labels{/name}","releases_url":"https://api.github.com/repos/Talend/bootstrap-theme/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/bootstrap-theme/deployments","created_at":"2016-08-10T09:46:47Z","updated_at":"2016-10-23T15:08:49Z","pushed_at":"2016-11-15T17:29:58Z","git_url":"git://github.com/Talend/bootstrap-theme.git","ssh_url":"git@github.com:Talend/bootstrap-theme.git","clone_url":"https://github.com/Talend/bootstrap-theme.git","svn_url":"https://github.com/Talend/bootstrap-theme","homepage":"https://talend.github.io/bootstrap-theme","size":3104,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71"},"html":{"href":"https://github.com/Talend/bootstrap-theme/pull/71"},"issue":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/issues/71"},"comments":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/bootstrap-theme/statuses/f5ba3fba684aee1762cc62882f19958bcfec2b82"}}}}
{"actor":{"display_login":"jmfrancois"}}