{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/83965361","pull_request_review_id":4773906,"id":83965361,"diff_hunk":"@@ -453,14 +459,68 @@ private static void verifyUnsplittableMethods(ErrorReporter errors, DoFnSignatur\n             DoFn.OutputReceiver.class.getSimpleName(),\n             formatType(paramT),\n             formatType(expectedOutputReceiverT));\n-        extraParameters.add(DoFnSignature.Parameter.OUTPUT_RECEIVER);\n+        extraParameters.add(DoFnSignature.Parameter.outputReceiver());\n       } else if (RestrictionTracker.class.isAssignableFrom(rawType)) {\n         errors.checkArgument(\n-            !extraParameters.contains(DoFnSignature.Parameter.RESTRICTION_TRACKER),\n+            !extraParameters.contains(DoFnSignature.Parameter.restrictionTracker()),\n             \"Multiple %s parameters\",\n             RestrictionTracker.class.getSimpleName());\n-        extraParameters.add(DoFnSignature.Parameter.RESTRICTION_TRACKER);\n+        extraParameters.add(DoFnSignature.Parameter.restrictionTracker());\n         trackerT = paramT;\n+      } else if (State.class.isAssignableFrom(rawType)) {\n+        // m.getParameters() is not available until Java 8\n+        Annotation[] annotations = m.getParameterAnnotations()[i];\n+        String id = null;\n+        for (Annotation anno : annotations) {\n+          if (anno.annotationType().equals(DoFn.StateId.class)) {\n+            id = ((DoFn.StateId) anno).value();\n+            break;\n+          }\n+        }\n+        errors.checkArgument(\n+            id != null,\n+            \"%s parameter of type %s at index %s missing %s annotation\",\n+            fnClass.getRawType().getName(),\n+            params[i],\n+            i,\n+            DoFn.StateId.class.getSimpleName());\n+\n+        errors.checkArgument(","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java","position":126,"original_position":126,"commit_id":"81b6994bf8162bfc3aaba40a708ce8385be76d80","original_commit_id":"81b6994bf8162bfc3aaba40a708ce8385be76d80","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"body":"TODO: check that the declaration and use occur in the same lexical scope.","created_at":"2016-10-18T22:35:02Z","updated_at":"2016-10-18T22:35:03Z","html_url":"https://github.com/apache/incubator-beam/pull/1130#discussion_r83965361","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1130","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/83965361"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1130#discussion_r83965361"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1130"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1130","id":89910740,"html_url":"https://github.com/apache/incubator-beam/pull/1130","diff_url":"https://github.com/apache/incubator-beam/pull/1130.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1130.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1130","number":1130,"state":"open","locked":false,"title":"[BEAM-27] Add parsing and validation of @StateId params to @ProcessElement","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [x] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nR: @bjchambers @jkff \r\n\r\nThis is an initial draft to discuss some design decisions along the way.","created_at":"2016-10-18T22:29:23Z","updated_at":"2016-10-18T22:35:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9619f92a6ef226eccfea25ec53c991541638b12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1130/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1130/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1130/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/81b6994bf8162bfc3aaba40a708ce8385be76d80","head":{"label":"kennknowles:State-params","ref":"State-params","sha":"81b6994bf8162bfc3aaba40a708ce8385be76d80","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"repo":{"id":52646147,"name":"incubator-beam","full_name":"kennknowles/incubator-beam","owner":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennknowles/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/kennknowles/incubator-beam","forks_url":"https://api.github.com/repos/kennknowles/incubator-beam/forks","keys_url":"https://api.github.com/repos/kennknowles/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennknowles/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennknowles/incubator-beam/teams","hooks_url":"https://api.github.com/repos/kennknowles/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/kennknowles/incubator-beam/events","assignees_url":"https://api.github.com/repos/kennknowles/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/kennknowles/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/kennknowles/incubator-beam/tags","blobs_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennknowles/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/kennknowles/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/kennknowles/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/kennknowles/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/kennknowles/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/kennknowles/incubator-beam/subscription","commits_url":"https://api.github.com/repos/kennknowles/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennknowles/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennknowles/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennknowles/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/kennknowles/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennknowles/incubator-beam/merges","archive_url":"https://api.github.com/repos/kennknowles/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennknowles/incubator-beam/downloads","issues_url":"https://api.github.com/repos/kennknowles/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/kennknowles/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/kennknowles/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/kennknowles/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennknowles/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/kennknowles/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/kennknowles/incubator-beam/deployments","created_at":"2016-02-27T02:37:09Z","updated_at":"2016-02-27T02:37:12Z","pushed_at":"2016-10-18T22:28:02Z","git_url":"git://github.com/kennknowles/incubator-beam.git","ssh_url":"git@github.com:kennknowles/incubator-beam.git","clone_url":"https://github.com/kennknowles/incubator-beam.git","svn_url":"https://github.com/kennknowles/incubator-beam","homepage":null,"size":20419,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3b1c2a3cf46f79657f0e010868188abe44d708c8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-10-17T09:55:30Z","pushed_at":"2016-10-18T22:29:23Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":32268,"stargazers_count":388,"watchers_count":388,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":248,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":45,"forks":248,"open_issues":45,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1130"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1130"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1130"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1130/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1130/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1130/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/81b6994bf8162bfc3aaba40a708ce8385be76d80"}}}}
{"actor":{"display_login":"kennknowles"}}