{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/92691716","pull_request_review_id":13212100,"id":92691716,"diff_hunk":"@@ -224,9 +225,11 @@ function _read(size) {\n     } catch (e) {\n       self._readsDone({code: grpc.status.INTERNAL,\n                        details: 'Failed to parse server response'});\n+      return;","path":"src/node/src/client.js","position":23,"original_position":23,"commit_id":"5eebc93b1d7bf0f1e878ce2193c6e58d9e637211","original_commit_id":"5eebc93b1d7bf0f1e878ce2193c6e58d9e637211","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"body":"Returning here just makes sure that we don't fall through to `self.push(deserialized)`, which we don't want because this is the case where deserialization failed.","created_at":"2016-12-15T20:18:13Z","updated_at":"2016-12-15T20:18:13Z","html_url":"https://github.com/grpc/grpc/pull/9101#discussion_r92691716","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/9101","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/92691716"},"html":{"href":"https://github.com/grpc/grpc/pull/9101#discussion_r92691716"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/9101"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/9101","id":97875139,"html_url":"https://github.com/grpc/grpc/pull/9101","diff_url":"https://github.com/grpc/grpc/pull/9101.diff","patch_url":"https://github.com/grpc/grpc/pull/9101.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/9101","number":9101,"state":"open","locked":false,"title":"Make event order consistent, and make 'end' and 'error' mutually exclusive","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"body":"This PR has two different but related changes. The first makes the order in which events are emitted consistent across call types: first the `metadata` event is emitted, then later the `error` event is emitted if there is an error, and finally the `status` event is emitted. This has the effect of ensuring that the same event, `status` is consistently emitted after everything else in every call. This fixes #7705.\r\n\r\nThe second change ensures that the `end` and the `error` events are mutually exclusive. Since `error` events could already happen at any time, it was already theoretically possible to have `error` events without `end` events. But when handling completed calls that finished with non-OK status, we were always emitting both. According to #8954, some common libraries expect the former behavior, and this change ensures that that is always the case.","created_at":"2016-12-14T02:16:26Z","updated_at":"2016-12-15T20:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"944e679a68f495bfd14dfbaa662da9fbba8290e2","assignee":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars.githubusercontent.com/u/9566254?v=3","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"assignees":[{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars.githubusercontent.com/u/9566254?v=3","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/9101/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/9101/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/9101/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/5eebc93b1d7bf0f1e878ce2193c6e58d9e637211","head":{"label":"murgatroid99:node_event_changes","ref":"node_event_changes","sha":"5eebc93b1d7bf0f1e878ce2193c6e58d9e637211","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"repo":{"id":31379612,"name":"grpc","full_name":"murgatroid99/grpc","owner":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murgatroid99/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/murgatroid99/grpc","forks_url":"https://api.github.com/repos/murgatroid99/grpc/forks","keys_url":"https://api.github.com/repos/murgatroid99/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murgatroid99/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murgatroid99/grpc/teams","hooks_url":"https://api.github.com/repos/murgatroid99/grpc/hooks","issue_events_url":"https://api.github.com/repos/murgatroid99/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/murgatroid99/grpc/events","assignees_url":"https://api.github.com/repos/murgatroid99/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/murgatroid99/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/murgatroid99/grpc/tags","blobs_url":"https://api.github.com/repos/murgatroid99/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murgatroid99/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murgatroid99/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/murgatroid99/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murgatroid99/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/murgatroid99/grpc/languages","stargazers_url":"https://api.github.com/repos/murgatroid99/grpc/stargazers","contributors_url":"https://api.github.com/repos/murgatroid99/grpc/contributors","subscribers_url":"https://api.github.com/repos/murgatroid99/grpc/subscribers","subscription_url":"https://api.github.com/repos/murgatroid99/grpc/subscription","commits_url":"https://api.github.com/repos/murgatroid99/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/murgatroid99/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/murgatroid99/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/murgatroid99/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/murgatroid99/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/murgatroid99/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murgatroid99/grpc/merges","archive_url":"https://api.github.com/repos/murgatroid99/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murgatroid99/grpc/downloads","issues_url":"https://api.github.com/repos/murgatroid99/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/murgatroid99/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/murgatroid99/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/murgatroid99/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murgatroid99/grpc/labels{/name}","releases_url":"https://api.github.com/repos/murgatroid99/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/murgatroid99/grpc/deployments","created_at":"2015-02-26T17:35:55Z","updated_at":"2016-10-25T19:33:46Z","pushed_at":"2016-12-14T02:05:42Z","git_url":"git://github.com/murgatroid99/grpc.git","ssh_url":"git@github.com:murgatroid99/grpc.git","clone_url":"https://github.com/murgatroid99/grpc.git","svn_url":"https://github.com/murgatroid99/grpc","homepage":"","size":94922,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"7b1b2cc2aad07238afc95273c783cda8426856aa","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-12-15T20:13:25Z","pushed_at":"2016-12-15T20:14:45Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":96608,"stargazers_count":8037,"watchers_count":8037,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1583,"mirror_url":null,"open_issues_count":885,"forks":1583,"open_issues":885,"watchers":8037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/9101"},"html":{"href":"https://github.com/grpc/grpc/pull/9101"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/9101"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/9101/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/9101/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/9101/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/5eebc93b1d7bf0f1e878ce2193c6e58d9e637211"}}}}
{"actor":{"display_login":"murgatroid99"}}