{"action":"closed","issue":{"url":"https://api.github.com/repos/zendframework/zend-expressive/issues/390","repository_url":"https://api.github.com/repos/zendframework/zend-expressive","labels_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/390/comments","events_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/390/events","html_url":"https://github.com/zendframework/zend-expressive/issues/390","id":188731912,"number":390,"title":"Application::run incompatible with zend-stratigility 1.3","user":{"login":"mryvlin","id":3071413,"avatar_url":"https://avatars.githubusercontent.com/u/3071413?v=3","gravatar_id":"","url":"https://api.github.com/users/mryvlin","html_url":"https://github.com/mryvlin","followers_url":"https://api.github.com/users/mryvlin/followers","following_url":"https://api.github.com/users/mryvlin/following{/other_user}","gists_url":"https://api.github.com/users/mryvlin/gists{/gist_id}","starred_url":"https://api.github.com/users/mryvlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mryvlin/subscriptions","organizations_url":"https://api.github.com/users/mryvlin/orgs","repos_url":"https://api.github.com/users/mryvlin/repos","events_url":"https://api.github.com/users/mryvlin/events{/privacy}","received_events_url":"https://api.github.com/users/mryvlin/received_events","type":"User","site_admin":false},"labels":[{"id":242836264,"url":"https://api.github.com/repos/zendframework/zend-expressive/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"assignees":[{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/zendframework/zend-expressive/milestones/18","html_url":"https://github.com/zendframework/zend-expressive/milestones/1.0.1","labels_url":"https://api.github.com/repos/zendframework/zend-expressive/milestones/18/labels","id":1556788,"number":18,"title":"1.0.1","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":5,"state":"open","created_at":"2016-02-01T21:09:15Z","updated_at":"2016-11-11T13:34:37Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-11-11T10:39:07Z","updated_at":"2016-11-11T13:34:37Z","closed_at":"2016-11-11T13:34:36Z","body":"When invoking the Application, the third param is missing in the request, but as of zend-stratigility 1.3 the third param is now required.\r\nHere ist the error message:\r\n\r\n```\r\n[Fri Nov 11 11:30:33 2016] PHP Deprecated:  The third argument to Zend\\Stratigility\\MiddlewarePipe() ($out) will be required starting with Stratigility version 2; please see https://docs.zendframework.com/zend-stratigility/migration/to-v2/ for more details on how to update your application to remove this message. in /tmp/test-app/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php on line 101\r\n[Fri Nov 11 11:30:33 2016] PHP Stack trace:\r\n[Fri Nov 11 11:30:33 2016] PHP   1. {main}() /tmp/test-app/public/index.php:0\r\n[Fri Nov 11 11:30:33 2016] PHP   2. Zend\\Expressive\\Application->run() /tmp/test-app/public/index.php:21\r\n[Fri Nov 11 11:30:33 2016] PHP   3. Zend\\Expressive\\Application->__invoke() /tmp/test-app/vendor/zendframework/zend-expressive/src/Application.php:558\r\n[Fri Nov 11 11:30:33 2016] PHP   4. Zend\\Stratigility\\MiddlewarePipe->__invoke() /tmp/test-app/vendor/zendframework/zend-expressive/src/Application.php:141\r\n[Fri Nov 11 11:30:33 2016] PHP   5. trigger_error() /tmp/test-app/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php:101\r\n[Fri Nov 11 11:30:33 2016] PHP Deprecated:  The third argument to Zend\\Stratigility\\MiddlewarePipe() ($out) will be required starting with Stratigility version 2; please see https://docs.zendframework.com/zend-stratigility/migration/to-v2/ for more details on how to update your application to remove this message. in /tmp/test-app/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php on line 101\r\n[Fri Nov 11 11:30:33 2016] PHP Stack trace:\r\n[Fri Nov 11 11:30:33 2016] PHP   1. {main}() /tmp/test-app/public/index.php:0\r\n[Fri Nov 11 11:30:33 2016] PHP   2. Zend\\Expressive\\Application->run() /tmp/test-app/public/index.php:21\r\n[Fri Nov 11 11:30:33 2016] PHP   3. Zend\\Expressive\\Application->__invoke() /tmp/test-app/vendor/zendframework/zend-expressive/src/Application.php:558\r\n[Fri Nov 11 11:30:33 2016] PHP   4. Zend\\Stratigility\\MiddlewarePipe->__invoke() /tmp/test-app/vendor/zendframework/zend-expressive/src/Application.php:141\r\n[Fri Nov 11 11:30:33 2016] PHP   5. trigger_error() /tmp/test-app/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php:101\r\n```\r\n\r\nFor now the easiest solution I've found is to pass ```new NoopFinalHandler()``` as the third parameter, so that the method looks like following:\r\n\r\n```\r\n    public function run(ServerRequestInterface $request = null, ResponseInterface $response = null)\r\n    {\r\n        $request  = $request ?: ServerRequestFactory::fromGlobals();\r\n        $response = $response ?: new Response();\r\n\r\n        $response = $this($request, $response, new NoopFinalHandler());\r\n\r\n        $emitter = $this->getEmitter();\r\n        $emitter->emit($response);\r\n    }\r\n```"}}
{"actor":{"display_login":"weierophinney"}}