{"action":"created","issue":{"url":"https://api.github.com/repos/lagom/lagom/issues/138","repository_url":"https://api.github.com/repos/lagom/lagom","labels_url":"https://api.github.com/repos/lagom/lagom/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/138/comments","events_url":"https://api.github.com/repos/lagom/lagom/issues/138/events","html_url":"https://github.com/lagom/lagom/pull/138","id":168993787,"number":138,"title":"Fix : Better error message when application.conf is missing #100","user":{"login":"Fabszn","id":375706,"avatar_url":"https://avatars.githubusercontent.com/u/375706?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabszn","html_url":"https://github.com/Fabszn","followers_url":"https://api.github.com/users/Fabszn/followers","following_url":"https://api.github.com/users/Fabszn/following{/other_user}","gists_url":"https://api.github.com/users/Fabszn/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabszn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabszn/subscriptions","organizations_url":"https://api.github.com/users/Fabszn/orgs","repos_url":"https://api.github.com/users/Fabszn/repos","events_url":"https://api.github.com/users/Fabszn/events{/privacy}","received_events_url":"https://api.github.com/users/Fabszn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-02T21:32:11Z","updated_at":"2016-08-05T11:48:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/138","html_url":"https://github.com/lagom/lagom/pull/138","diff_url":"https://github.com/lagom/lagom/pull/138.diff","patch_url":"https://github.com/lagom/lagom/pull/138.patch"},"body":"# Pull Request Checklist\r\n\r\n* [x] Have you read through the [contributor guidelines](https://github.com/lagom/lagom/tree/master/CONTRIBUTING.md)?\r\n* [x] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [x] Have you [squashed your commits](https://github.com/lagom/lagom/tree/master/WorkingWithGit.md)?\r\n* [x] Have you added copyright headers to new files?\r\n* [x] Have you updated the documentation?\r\n* [x] Have you added tests for any changed functionality?\r\n\r\n## Fixes\r\n\r\nFixes #xxxx\r\n\r\n## Purpose\r\n\r\nWhat does this PR do?\r\n\r\n## Background Context\r\n\r\nWhy did you take this approach?\r\n\r\n## References\r\n\r\nAre there any relevant issues / PRs / mailing lists discussions?\r\n\r\nWith this fix, if the application.conf file misses in the serice directory then the service won't started with one explicit error message"},"comment":{"url":"https://api.github.com/repos/lagom/lagom/issues/comments/237830994","html_url":"https://github.com/lagom/lagom/pull/138#issuecomment-237830994","issue_url":"https://api.github.com/repos/lagom/lagom/issues/138","id":237830994,"user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T11:48:48Z","updated_at":"2016-08-05T11:48:48Z","body":"@Fabszn There are some compilation errors in the scripted tests. Have a look at the travis log, e.g.,\r\n\r\n```\r\n[info] [info] Compiling 1 Java source to /tmp/sbt_bae9eecb/run-all/b/impl/target/scala-2.11/classes...\r\n[info] [error] /tmp/sbt_bae9eecb/run-all/b/impl/src/main/java/impl/BarServiceImpl.java:16: not a statement\r\n[info] [error]       breakCompilation // <-- this produces a compilation error\r\n[info] [error] /tmp/sbt_bae9eecb/run-all/b/impl/src/main/java/impl/BarServiceImpl.java:16: ';' expected\r\n[info] [error]       breakCompilation // <-- this produces a compilation error\r\n[info] [error] (b-impl/compile:compileIncremental) javac returned nonzero exit code\r\n[info] [info] Compiling 1 Java source to /tmp/sbt_bae9eecb/run-all/b/impl/target/scala-2.11/classes...\r\n[info] [error] /tmp/sbt_bae9eecb/run-all/b/impl/src/main/java/impl/BarServiceImpl.java:16: not a statement\r\n[info] [error]       breakCompilation // <-- this produces a compilation error\r\n[info] [error] /tmp/sbt_bae9eecb/run-all/b/impl/src/main/java/impl/BarServiceImpl.java:16: ';' expected\r\n[info] [error]       breakCompilation // <-- this produces a compilation error\r\n[info] [error] (b-impl/compile:compileIncremental) javac returned nonzero exit code\r\n[info] [success] Total time: 0 s, completed Aug 2, 2016 9:45:24 PM\r\n[info] [info] Compiling 1 Java source to /tmp/sbt_bae9eecb/run-all/b/impl/target/scala-2.11/classes...\r\n```"}}
{"actor":{"display_login":"dotta"}}