{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/90772830","pull_request_review_id":11290613,"id":90772830,"diff_hunk":"@@ -1223,7 +1223,7 @@ added: v6.0.0\n -->\n \n * `value` {String | Buffer | Integer} What to search for\n-* `byteOffset` {Integer} Where to begin searching in `buf` (not inclusive).\n+* `byteOffset` {Integer} Where to begin searching in `buf`.\n   **Default:** [`buf.length`]","path":"doc/api/buffer.md","position":87,"original_position":87,"commit_id":"55449d393cb14f77f9a2b71f5b538753fcf5445e","original_commit_id":"55449d393cb14f77f9a2b71f5b538753fcf5445e","user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"body":"@silverwind Should I preserve the link? Should it be\r\n```\r\n[`buf.length - 1`][`buf.length`]\r\n```","created_at":"2016-12-04T08:15:28Z","updated_at":"2016-12-04T08:15:28Z","html_url":"https://github.com/nodejs/node/pull/9795#discussion_r90772830","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9795","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/90772830"},"html":{"href":"https://github.com/nodejs/node/pull/9795#discussion_r90772830"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9795"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9795","id":95248415,"html_url":"https://github.com/nodejs/node/pull/9795","diff_url":"https://github.com/nodejs/node/pull/9795.diff","patch_url":"https://github.com/nodejs/node/pull/9795.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9795","number":9795,"state":"open","locked":false,"title":"doc: small fixes in the buffer.md","user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ndoc, buffer\r\n\r\n##### Description of change\r\n\r\n1. `var` => `const` / `let`.\r\n2. Fix a syntax error.\r\n3. Fix wrong arguments in function calls*.\r\n4. Fix some copy-paste artifacts.\r\n5. Repeat the remark about buffer module property where it is needed.\r\n6. Add a missing variable declaration.\r\n7. Remove a wrong remark in the buffer.md\r\n8.  Fix examples in buffer.md to avoid confusion (fixes #9786)\r\n9.  Remove an extraneous word in the buffer.md\r\n\r\n*As to `null` => `undefined` in point 3, it is a temporary fix untill #9801 is addressed.\r\n","created_at":"2016-11-25T04:16:54Z","updated_at":"2016-12-04T08:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69e7cd433952cb8172cb47272555fd4fa9c77ce0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9795/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9795/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9795/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/55449d393cb14f77f9a2b71f5b538753fcf5445e","head":{"label":"vsemozhetbyt:patch-1","ref":"patch-1","sha":"55449d393cb14f77f9a2b71f5b538753fcf5445e","user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"repo":{"id":74723857,"name":"node","full_name":"vsemozhetbyt/node","owner":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vsemozhetbyt/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/vsemozhetbyt/node","forks_url":"https://api.github.com/repos/vsemozhetbyt/node/forks","keys_url":"https://api.github.com/repos/vsemozhetbyt/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsemozhetbyt/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsemozhetbyt/node/teams","hooks_url":"https://api.github.com/repos/vsemozhetbyt/node/hooks","issue_events_url":"https://api.github.com/repos/vsemozhetbyt/node/issues/events{/number}","events_url":"https://api.github.com/repos/vsemozhetbyt/node/events","assignees_url":"https://api.github.com/repos/vsemozhetbyt/node/assignees{/user}","branches_url":"https://api.github.com/repos/vsemozhetbyt/node/branches{/branch}","tags_url":"https://api.github.com/repos/vsemozhetbyt/node/tags","blobs_url":"https://api.github.com/repos/vsemozhetbyt/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsemozhetbyt/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsemozhetbyt/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsemozhetbyt/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsemozhetbyt/node/statuses/{sha}","languages_url":"https://api.github.com/repos/vsemozhetbyt/node/languages","stargazers_url":"https://api.github.com/repos/vsemozhetbyt/node/stargazers","contributors_url":"https://api.github.com/repos/vsemozhetbyt/node/contributors","subscribers_url":"https://api.github.com/repos/vsemozhetbyt/node/subscribers","subscription_url":"https://api.github.com/repos/vsemozhetbyt/node/subscription","commits_url":"https://api.github.com/repos/vsemozhetbyt/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsemozhetbyt/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsemozhetbyt/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsemozhetbyt/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/vsemozhetbyt/node/contents/{+path}","compare_url":"https://api.github.com/repos/vsemozhetbyt/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsemozhetbyt/node/merges","archive_url":"https://api.github.com/repos/vsemozhetbyt/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsemozhetbyt/node/downloads","issues_url":"https://api.github.com/repos/vsemozhetbyt/node/issues{/number}","pulls_url":"https://api.github.com/repos/vsemozhetbyt/node/pulls{/number}","milestones_url":"https://api.github.com/repos/vsemozhetbyt/node/milestones{/number}","notifications_url":"https://api.github.com/repos/vsemozhetbyt/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsemozhetbyt/node/labels{/name}","releases_url":"https://api.github.com/repos/vsemozhetbyt/node/releases{/id}","deployments_url":"https://api.github.com/repos/vsemozhetbyt/node/deployments","created_at":"2016-11-25T03:50:41Z","updated_at":"2016-11-25T03:51:04Z","pushed_at":"2016-12-03T05:42:19Z","git_url":"git://github.com/vsemozhetbyt/node.git","ssh_url":"git@github.com:vsemozhetbyt/node.git","clone_url":"https://github.com/vsemozhetbyt/node.git","svn_url":"https://github.com/vsemozhetbyt/node","homepage":"https://nodejs.org","size":246874,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8a959107c0da7fe61ba0c54edc931a4a96144526","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-04T08:00:47Z","pushed_at":"2016-12-04T07:47:23Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":373309,"stargazers_count":29542,"watchers_count":29542,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5261,"mirror_url":null,"open_issues_count":1153,"forks":5261,"open_issues":1153,"watchers":29542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9795"},"html":{"href":"https://github.com/nodejs/node/pull/9795"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9795"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9795/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9795/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9795/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/55449d393cb14f77f9a2b71f5b538753fcf5445e"}}}}
{"actor":{"display_login":"vsemozhetbyt"}}