{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/62336251","id":62336251,"diff_hunk":"@@ -66,18 +89,66 @@ public void testNoPlugins() throws Exception {\n \n     public void testOnePlugin() throws Exception {\n         Environment env = createEnv();\n-        Files.createDirectory(env.pluginsFile().resolve(\"fake\"));\n+        buildFakePlugin(env, \"fake desc\", \"fake\", \"org.fake\");\n         MockTerminal terminal = listPlugins(env);\n-        assertTrue(terminal.getOutput(), terminal.getOutput().contains(\"fake\"));\n+        assertEquals(terminal.getOutput(), buildMultiline(\"fake\"));\n     }\n \n     public void testTwoPlugins() throws Exception {\n         Environment env = createEnv();\n-        Files.createDirectory(env.pluginsFile().resolve(\"fake1\"));\n-        Files.createDirectory(env.pluginsFile().resolve(\"fake2\"));\n+        buildFakePlugin(env, \"fake desc\", \"fake1\", \"org.fake\");\n+        buildFakePlugin(env, \"fake desc 2\", \"fake2\", \"org.fake\");\n         MockTerminal terminal = listPlugins(env);\n+        assertEquals(terminal.getOutput(), buildMultiline(\"fake1\", \"fake2\"));\n+    }\n+    \n+    public void testPluginWithVerbose() throws Exception {\n+        Environment env = createEnv();\n+        buildFakePlugin(env, \"fake desc\", \"fake_plugin\", \"org.fake\");\n+        String[] params = { \"-v\" };\n+        MockTerminal terminal = listPlugins(env, params);\n+        assertEquals(terminal.getOutput(), buildMultiline(\"Plugins directory: \" + env.pluginsFile(), \"fake_plugin\",\n+        \t\t\"- Plugin information:\", \"Name: fake_plugin\", \"Description: fake desc\", \"Version: 1.0\", \" * Classname: org.fake\"));\n+    }\n+    \n+    public void testPluginWithVerboseMultiplePlugins() throws Exception {\n+        Environment env = createEnv();\n+        buildFakePlugin(env, \"fake desc 1\", \"fake_plugin1\", \"org.fake\");\n+        buildFakePlugin(env, \"fake desc 2\", \"fake_plugin2\", \"org.fake2\");\n+        String[] params = { \"-v\" };\n+        MockTerminal terminal = listPlugins(env, params);\n+        assertEquals(terminal.getOutput(), buildMultiline(\"Plugins directory: \" + env.pluginsFile(),\n+        \t\t\"fake_plugin1\", \"- Plugin information:\", \"Name: fake_plugin1\", \"Description: fake desc 1\", \"Version: 1.0\",\n+        \t\t\" * Classname: org.fake\", \"fake_plugin2\", \"- Plugin information:\", \"Name: fake_plugin2\",\n+        \t\t\"Description: fake desc 2\", \"Version: 1.0\", \" * Classname: org.fake2\"));\n+    }\n+        \n+    public void testPluginWithoutVerboseMultiplePlugins() throws Exception {\n+        Environment env = createEnv();\n+        buildFakePlugin(env, \"fake desc 1\", \"fake_plugin1\", \"org.fake\");\n+        buildFakePlugin(env, \"fake desc 2\", \"fake_plugin2\", \"org.fake2\");\n+        MockTerminal terminal = listPlugins(env, new String[0]);\n         String output = terminal.getOutput();\n-        assertTrue(output, output.contains(\"fake1\"));\n-        assertTrue(output, output.contains(\"fake2\"));\n+        assertEquals(output, buildMultiline(\"fake_plugin1\", \"fake_plugin2\"));\n+    }\n+    \n+    public void testPluginWithoutDescriptionFile() throws Exception{","path":"qa/evil-tests/src/test/java/org/elasticsearch/plugins/ListPluginsCommandTests.java","position":116,"original_position":116,"commit_id":"234bc6818ed2523fa3e8367c4890d7fc0594a37b","original_commit_id":"234bc6818ed2523fa3e8367c4890d7fc0594a37b","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"body":"`Description` -> `Descriptor`","created_at":"2016-05-06T14:25:08Z","updated_at":"2016-05-06T14:25:08Z","html_url":"https://github.com/elastic/elasticsearch/pull/18051#discussion_r62336251","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/62336251"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/18051#discussion_r62336251"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051","id":68280381,"html_url":"https://github.com/elastic/elasticsearch/pull/18051","diff_url":"https://github.com/elastic/elasticsearch/pull/18051.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/18051.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18051","number":18051,"state":"open","locked":false,"title":"Add plugin information for Verbose mode","user":{"login":"gmoskovicz","id":1675411,"avatar_url":"https://avatars.githubusercontent.com/u/1675411?v=3","gravatar_id":"","url":"https://api.github.com/users/gmoskovicz","html_url":"https://github.com/gmoskovicz","followers_url":"https://api.github.com/users/gmoskovicz/followers","following_url":"https://api.github.com/users/gmoskovicz/following{/other_user}","gists_url":"https://api.github.com/users/gmoskovicz/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoskovicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoskovicz/subscriptions","organizations_url":"https://api.github.com/users/gmoskovicz/orgs","repos_url":"https://api.github.com/users/gmoskovicz/repos","events_url":"https://api.github.com/users/gmoskovicz/events{/privacy}","received_events_url":"https://api.github.com/users/gmoskovicz/received_events","type":"User","site_admin":false},"body":"Fix for #16375 \r\n\r\nWith this Pull Request, we will show extra information about plugins running the `bin/elasticsearch-plugin` command under `verbose` mode.","created_at":"2016-04-28T19:56:52Z","updated_at":"2016-05-06T14:25:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"995af1d5cf9fc50efcdca75a87af78f4aa7e0e7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18051/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/234bc6818ed2523fa3e8367c4890d7fc0594a37b","head":{"label":"gmoskovicz:master","ref":"master","sha":"234bc6818ed2523fa3e8367c4890d7fc0594a37b","user":{"login":"gmoskovicz","id":1675411,"avatar_url":"https://avatars.githubusercontent.com/u/1675411?v=3","gravatar_id":"","url":"https://api.github.com/users/gmoskovicz","html_url":"https://github.com/gmoskovicz","followers_url":"https://api.github.com/users/gmoskovicz/followers","following_url":"https://api.github.com/users/gmoskovicz/following{/other_user}","gists_url":"https://api.github.com/users/gmoskovicz/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoskovicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoskovicz/subscriptions","organizations_url":"https://api.github.com/users/gmoskovicz/orgs","repos_url":"https://api.github.com/users/gmoskovicz/repos","events_url":"https://api.github.com/users/gmoskovicz/events{/privacy}","received_events_url":"https://api.github.com/users/gmoskovicz/received_events","type":"User","site_admin":false},"repo":{"id":57301358,"name":"elasticsearch","full_name":"gmoskovicz/elasticsearch","owner":{"login":"gmoskovicz","id":1675411,"avatar_url":"https://avatars.githubusercontent.com/u/1675411?v=3","gravatar_id":"","url":"https://api.github.com/users/gmoskovicz","html_url":"https://github.com/gmoskovicz","followers_url":"https://api.github.com/users/gmoskovicz/followers","following_url":"https://api.github.com/users/gmoskovicz/following{/other_user}","gists_url":"https://api.github.com/users/gmoskovicz/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoskovicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoskovicz/subscriptions","organizations_url":"https://api.github.com/users/gmoskovicz/orgs","repos_url":"https://api.github.com/users/gmoskovicz/repos","events_url":"https://api.github.com/users/gmoskovicz/events{/privacy}","received_events_url":"https://api.github.com/users/gmoskovicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmoskovicz/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/gmoskovicz/elasticsearch","forks_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/forks","keys_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/teams","hooks_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/events","assignees_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/tags","blobs_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/subscription","commits_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/merges","archive_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/downloads","issues_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/gmoskovicz/elasticsearch/deployments","created_at":"2016-04-28T12:47:27Z","updated_at":"2016-04-28T12:47:53Z","pushed_at":"2016-05-02T18:15:35Z","git_url":"git://github.com/gmoskovicz/elasticsearch.git","ssh_url":"git@github.com:gmoskovicz/elasticsearch.git","clone_url":"https://github.com/gmoskovicz/elasticsearch.git","svn_url":"https://github.com/gmoskovicz/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":217309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"946c7e47faa7311afeece51fb1d73c541b8728c8","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-05-06T14:17:41Z","pushed_at":"2016-05-06T14:17:18Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":313023,"stargazers_count":16303,"watchers_count":16303,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5496,"mirror_url":null,"open_issues_count":1102,"forks":5496,"open_issues":1102,"watchers":16303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/18051"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/18051"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/18051/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/18051/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/234bc6818ed2523fa3e8367c4890d7fc0594a37b"}}}}