{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/84337215","pull_request_review_id":5121432,"id":84337215,"diff_hunk":"@@ -3842,10 +3842,13 @@ PyUFunc_GenericReduction(PyUFuncObject *ufunc, PyObject *args,\n     PyArray_Descr *otype = NULL;\n     PyArrayObject *out = NULL;\n     int keepdims = 0;\n-    static char *kwlist1[] = {\"array\", \"axis\", \"dtype\",\n-                                \"out\", \"keepdims\", NULL};\n-    static char *kwlist2[] = {\"array\", \"indices\", \"axis\",\n-                                \"dtype\", \"out\", NULL};\n+    static char *reduce_kwlist[] = {\n+        \"array\",            \"axis\", \"dtype\", \"out\", \"keepdims\", NULL};","path":"numpy/core/src/umath/ufunc_object.c","position":9,"original_position":9,"commit_id":"82a9c677b9a7f31336da840ab4a30cf0b672d58f","original_commit_id":"82a9c677b9a7f31336da840ab4a30cf0b672d58f","user":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"Umm, looks like you may have a hard tab in here. I preferred to previous format to tell the truth, although the alignment was a bit of on the second line.","created_at":"2016-10-20T17:40:27Z","updated_at":"2016-10-20T17:40:27Z","html_url":"https://github.com/numpy/numpy/pull/8187#discussion_r84337215","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/8187","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/84337215"},"html":{"href":"https://github.com/numpy/numpy/pull/8187#discussion_r84337215"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8187"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/8187","id":90220091,"html_url":"https://github.com/numpy/numpy/pull/8187","diff_url":"https://github.com/numpy/numpy/pull/8187.diff","patch_url":"https://github.com/numpy/numpy/pull/8187.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/8187","number":8187,"state":"open","locked":false,"title":"Remove the unused keepdim argument from np.ufunc.accumulate","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-20T15:08:47Z","updated_at":"2016-10-20T17:40:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6116f99816d98e577068e85c5b685b1394172683","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/8187/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/8187/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/8187/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/82a9c677b9a7f31336da840ab4a30cf0b672d58f","head":{"label":"eric-wieser:accumulate-no-keepdim","ref":"accumulate-no-keepdim","sha":"82a9c677b9a7f31336da840ab4a30cf0b672d58f","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"repo":{"id":57262933,"name":"numpy","full_name":"eric-wieser/numpy","owner":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eric-wieser/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/eric-wieser/numpy","forks_url":"https://api.github.com/repos/eric-wieser/numpy/forks","keys_url":"https://api.github.com/repos/eric-wieser/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eric-wieser/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eric-wieser/numpy/teams","hooks_url":"https://api.github.com/repos/eric-wieser/numpy/hooks","issue_events_url":"https://api.github.com/repos/eric-wieser/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/eric-wieser/numpy/events","assignees_url":"https://api.github.com/repos/eric-wieser/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/eric-wieser/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/eric-wieser/numpy/tags","blobs_url":"https://api.github.com/repos/eric-wieser/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eric-wieser/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eric-wieser/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/eric-wieser/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eric-wieser/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/eric-wieser/numpy/languages","stargazers_url":"https://api.github.com/repos/eric-wieser/numpy/stargazers","contributors_url":"https://api.github.com/repos/eric-wieser/numpy/contributors","subscribers_url":"https://api.github.com/repos/eric-wieser/numpy/subscribers","subscription_url":"https://api.github.com/repos/eric-wieser/numpy/subscription","commits_url":"https://api.github.com/repos/eric-wieser/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/eric-wieser/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/eric-wieser/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/eric-wieser/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/eric-wieser/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/eric-wieser/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eric-wieser/numpy/merges","archive_url":"https://api.github.com/repos/eric-wieser/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eric-wieser/numpy/downloads","issues_url":"https://api.github.com/repos/eric-wieser/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/eric-wieser/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/eric-wieser/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/eric-wieser/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eric-wieser/numpy/labels{/name}","releases_url":"https://api.github.com/repos/eric-wieser/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/eric-wieser/numpy/deployments","created_at":"2016-04-28T02:09:21Z","updated_at":"2016-04-28T02:09:26Z","pushed_at":"2016-10-20T15:07:38Z","git_url":"git://github.com/eric-wieser/numpy.git","ssh_url":"git@github.com:eric-wieser/numpy.git","clone_url":"https://github.com/eric-wieser/numpy.git","svn_url":"https://github.com/eric-wieser/numpy","homepage":"http://www.numpy.org/","size":43465,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"d6f48249847f96d986377fc196dfdf629cd331d5","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2016-10-20T16:43:39Z","pushed_at":"2016-10-20T17:28:45Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":81567,"stargazers_count":3458,"watchers_count":3458,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1750,"mirror_url":null,"open_issues_count":1323,"forks":1750,"open_issues":1323,"watchers":3458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8187"},"html":{"href":"https://github.com/numpy/numpy/pull/8187"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/8187"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/8187/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8187/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8187/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/82a9c677b9a7f31336da840ab4a30cf0b672d58f"}}}}
{"actor":{"display_login":"charris"}}