{"action":"opened","number":76,"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76","id":85433757,"html_url":"https://github.com/ISISComputingGroup/EPICS-ioc/pull/76","diff_url":"https://github.com/ISISComputingGroup/EPICS-ioc/pull/76.diff","patch_url":"https://github.com/ISISComputingGroup/EPICS-ioc/pull/76.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/76","number":76,"state":"open","locked":false,"title":"Changes to improve the display and interaction for current and voltage","user":{"login":"KathrynBaker","id":10552381,"avatar_url":"https://avatars.githubusercontent.com/u/10552381?v=3","gravatar_id":"","url":"https://api.github.com/users/KathrynBaker","html_url":"https://github.com/KathrynBaker","followers_url":"https://api.github.com/users/KathrynBaker/followers","following_url":"https://api.github.com/users/KathrynBaker/following{/other_user}","gists_url":"https://api.github.com/users/KathrynBaker/gists{/gist_id}","starred_url":"https://api.github.com/users/KathrynBaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KathrynBaker/subscriptions","organizations_url":"https://api.github.com/users/KathrynBaker/orgs","repos_url":"https://api.github.com/users/KathrynBaker/repos","events_url":"https://api.github.com/users/KathrynBaker/events{/privacy}","received_events_url":"https://api.github.com/users/KathrynBaker/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nUpdates to the current and voltage display to allow users to see what the expect to see\r\n\r\n### To test\r\n\r\nNeeds a change to the Danfysik support module, and danfysiks of various types, or check out NDEMUONFE where this changes are already in place\r\n\r\nPart of https://github.com/ISISComputingGroup/IBEX/issues/1597\r\n\r\n### Acceptance criteria\r\n\r\nThese changes are already in place and working, so are covering the appropriate acceptance criteria, which is basically that instead of showing for example a CURR of 3009 and voltage of 63 from a Danfysik 9100 it can instead be shown as 30.09 and 6.3 using the macros, and the current can be set in the same units. The change for the 8800 relating to the command for the current means that a suitable value can be obtained.\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Are the PVs named according to the [naming standards](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/PV-Naming).\r\n- [ ] Have suitable [disable records](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Disable-records) been added?\r\n- [ ] Have suitable [simulation records](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Record-Simulation) been added?\r\n- [ ] Have the [finishing touches](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/IOC-Finishing-Touches) been applied?\r\n- [ ] Is there an [emulator](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Emulating-Devices) for the device? - Note there is currently no emulator, and given the complexities and that these are fixes for a live system I have not put the time in as part of this ticket\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev). If so, do they describe the changes appropriately?\r\n\r\n### Functional Tests\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed.\r\n- [ ] Does the IOC respond correctly both in full and simulation mode, where it's possible to test both?\r\n- [ ] If there are multiple _0n IOCs, do they run correctly?\r\n\r\n### Final steps\r\n\r\n- [ ] Reviewer has updated the submodule in the main EPICS repo? See **Reviewing work for the subModules of EPICS** in the [Git workflow](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Git-workflow) page for details.\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n","created_at":"2016-09-15T16:09:36Z","updated_at":"2016-09-15T16:09:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/76/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/statuses/9b602f7abbfe76fda4c86269a8750190bb1b809b","head":{"label":"ISISComputingGroup:Ticket1507_CURR_and_VOLT_Corrections","ref":"Ticket1507_CURR_and_VOLT_Corrections","sha":"9b602f7abbfe76fda4c86269a8750190bb1b809b","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":40836714,"name":"EPICS-ioc","full_name":"ISISComputingGroup/EPICS-ioc","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/EPICS-ioc","description":null,"fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc","forks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/deployments","created_at":"2015-08-16T19:48:31Z","updated_at":"2016-01-21T11:33:48Z","pushed_at":"2016-09-15T16:09:36Z","git_url":"git://github.com/ISISComputingGroup/EPICS-ioc.git","ssh_url":"git@github.com:ISISComputingGroup/EPICS-ioc.git","clone_url":"https://github.com/ISISComputingGroup/EPICS-ioc.git","svn_url":"https://github.com/ISISComputingGroup/EPICS-ioc","homepage":null,"size":3427,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"200743b8692e78a769cd6f9500afcb6092c25596","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":40836714,"name":"EPICS-ioc","full_name":"ISISComputingGroup/EPICS-ioc","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/EPICS-ioc","description":null,"fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc","forks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/deployments","created_at":"2015-08-16T19:48:31Z","updated_at":"2016-01-21T11:33:48Z","pushed_at":"2016-09-15T16:09:36Z","git_url":"git://github.com/ISISComputingGroup/EPICS-ioc.git","ssh_url":"git@github.com:ISISComputingGroup/EPICS-ioc.git","clone_url":"https://github.com/ISISComputingGroup/EPICS-ioc.git","svn_url":"https://github.com/ISISComputingGroup/EPICS-ioc","homepage":null,"size":3427,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76"},"html":{"href":"https://github.com/ISISComputingGroup/EPICS-ioc/pull/76"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/76"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-ioc/statuses/9b602f7abbfe76fda4c86269a8750190bb1b809b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":98,"deletions":28,"changed_files":6}}
{"actor":{"display_login":"KathrynBaker"}}