{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/91742817","pull_request_review_id":12253933,"id":91742817,"diff_hunk":"@@ -62,45 +63,45 @@ viewcover:\n # Conditional virtualenv building strategy taken from this great post\n # by Marcel Hellkamp:\n # http://blog.bottlepy.org/2012/07/16/virtualenv-and-makefiles.html\n-venv: oo-installenv/bin/activate\n-oo-installenv/bin/activate: test-requirements.txt\n+$(VENV): $(VENV)/bin/activate\n+$(VENV)/bin/activate: test-requirements.txt\n \t@echo \"#############################################\"\n \t@echo \"# Creating a virtualenv\"\n \t@echo \"#############################################\"\n-\ttest -d venv || virtualenv $(NAME)env\n-\t. $(NAME)env/bin/activate && pip install setuptools==17.1.1\n-\t. $(NAME)env/bin/activate && pip install -r test-requirements.txt\n-\ttouch $(NAME)env/bin/activate\n+\ttest -d $(VENV) || virtualenv $(VENV)\n+\t. $(VENV)/bin/activate && pip install setuptools==17.1.1\n+\t. $(VENV)/bin/activate && pip install -r test-requirements.txt\n+\ttouch $(VENV)/bin/activate\n #       If there are any special things to install do it here\n-#       . $(NAME)env/bin/activate && INSTALL STUFF\n+#       . $(VENV)/bin/activate && INSTALL STUFF\n \n-ci-unittests:\n+ci-unittests: $(VENV)","path":"utils/Makefile","position":41,"original_position":41,"commit_id":"b66a5a667d89f73a9bccdeb0822a85c131340246","original_commit_id":"b66a5a667d89f73a9bccdeb0822a85c131340246","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":":cry:  this means that if I want to use `make ci-unittests` I cannot manage my own env/virtualenv...\r\nFor my Python projects I use `virtualenvwrapper`, and my envs are not a subdirectory of the repo. I wish I could still use that :)\r\n\r\n(the fact that we activate the env in every target already prevents me from managing my own env)","created_at":"2016-12-09T16:03:19Z","updated_at":"2016-12-09T16:06:24Z","html_url":"https://github.com/openshift/openshift-ansible/pull/2955#discussion_r91742817","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/91742817"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2955#discussion_r91742817"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955","id":97191205,"html_url":"https://github.com/openshift/openshift-ansible/pull/2955","diff_url":"https://github.com/openshift/openshift-ansible/pull/2955.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2955.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2955","number":2955,"state":"open","locked":false,"title":"Fixes to 'make ci'","user":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"body":"* Fixed: A grep filter was capturing the actual pylint check rc's\r\n\r\n* Changed: pylint used to print out messages for locally-disabled and\r\n  file-ignored items\r\n\r\n* Changed: pylint output format is now 'parseable'\r\n\r\n* Cleaned up: Pylint was emitting deprecation messages for\r\n  'required-attributes' and 'ignore-iface-methods'. They have been\r\n  removed from the pylintrc file","created_at":"2016-12-08T20:06:29Z","updated_at":"2016-12-09T16:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86d51feb7d98d2896490bd5ab81892b8ec50637a","assignee":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"assignees":[{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2955/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b66a5a667d89f73a9bccdeb0822a85c131340246","head":{"label":"tbielawa:fix-pooched-ci","ref":"fix-pooched-ci","sha":"b66a5a667d89f73a9bccdeb0822a85c131340246","user":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"repo":{"id":61655058,"name":"openshift-ansible","full_name":"tbielawa/openshift-ansible","owner":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbielawa/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/tbielawa/openshift-ansible","forks_url":"https://api.github.com/repos/tbielawa/openshift-ansible/forks","keys_url":"https://api.github.com/repos/tbielawa/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbielawa/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbielawa/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/tbielawa/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/tbielawa/openshift-ansible/events","assignees_url":"https://api.github.com/repos/tbielawa/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/tbielawa/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/tbielawa/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbielawa/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/tbielawa/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/tbielawa/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/tbielawa/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/tbielawa/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/tbielawa/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/tbielawa/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbielawa/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbielawa/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/tbielawa/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbielawa/openshift-ansible/merges","archive_url":"https://api.github.com/repos/tbielawa/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbielawa/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/tbielawa/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/tbielawa/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/tbielawa/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbielawa/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/tbielawa/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/tbielawa/openshift-ansible/deployments","created_at":"2016-06-21T17:54:56Z","updated_at":"2016-06-21T17:55:00Z","pushed_at":"2016-12-09T15:32:18Z","git_url":"git://github.com/tbielawa/openshift-ansible.git","ssh_url":"git@github.com:tbielawa/openshift-ansible.git","clone_url":"https://github.com/tbielawa/openshift-ansible.git","svn_url":"https://github.com/tbielawa/openshift-ansible","homepage":"install.openshift.com","size":7600,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ce39c9084bc20df242bbbef3a2a5b1c8060cbe9d","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-12-07T23:04:47Z","pushed_at":"2016-12-09T15:59:29Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":12071,"stargazers_count":293,"watchers_count":293,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":470,"mirror_url":null,"open_issues_count":229,"forks":470,"open_issues":229,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2955"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2955"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2955/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2955/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b66a5a667d89f73a9bccdeb0822a85c131340246"}}}}
{"actor":{"display_login":"rhcarvalho"}}