{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/66468117","id":66468117,"diff_hunk":"@@ -0,0 +1,86 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.storm.metric;\n+\n+import org.apache.storm.metric.api.DataPoint;\n+import org.apache.storm.metric.api.IClusterMetricsConsumer;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.util.Collection;\n+\n+/**\n+ * Listens for cluster related metrics, dumps them to log\n+ *\n+ * To use, edit the storm.yaml config file:\n+ *\n+ * ```yaml\n+ *   storm.cluster.metrics.register:\n+ *     - class: \"org.apache.storm.metrics.LoggingClusterMetricsConsumer\"\n+ * ```\n+ *\n+ */\n+public class LoggingClusterMetricsConsumer implements IClusterMetricsConsumer {\n+    public static final Logger LOG = LoggerFactory.getLogger(LoggingClusterMetricsConsumer.class);\n+\n+    static private String padding = \"                       \";\n+\n+    @Override\n+    public void prepare(Object registrationArgument) {\n+    }\n+\n+    @Override\n+    public void handleDataPoints(ClusterInfo clusterInfo, Collection<DataPoint> dataPoints) {\n+        StringBuilder sb = new StringBuilder();\n+        String header = String.format(\"%d\\t%15s\\t%40s\\t\",\n+                clusterInfo.getTimestamp(), \"<cluster>\", \"<cluster>\");\n+        sb.append(header);\n+        logDataPoints(dataPoints, sb, header);\n+    }\n+\n+    @Override\n+    public void handleDataPoints(SupervisorInfo supervisorInfo, Collection<DataPoint> dataPoints) {\n+        StringBuilder sb = new StringBuilder();\n+        String header = String.format(\"%d\\t%15s\\t%40s\\t\",\n+                supervisorInfo.getTimestamp(),\n+                supervisorInfo.getSrcSupervisorHost(),\n+                supervisorInfo.getSrcSupervisorId());\n+        sb.append(header);\n+        for (DataPoint p : dataPoints) {\n+            sb.delete(header.length(), sb.length());\n+            sb.append(p.getName())\n+                    .append(padding).delete(header.length()+23,sb.length()).append(\"\\t\")\n+                    .append(p.getValue());\n+            LOG.info(sb.toString());\n+        }\n+    }\n+\n+    @Override\n+    public void cleanup() {\n+    }\n+\n+    private void logDataPoints(Collection<DataPoint> dataPoints, StringBuilder sb, String header) {\n+        for (DataPoint p : dataPoints) {\n+            sb.delete(header.length(), sb.length());\n+            sb.append(p.getName())\n+                    .append(padding).delete(header.length()+23,sb.length()).append(\"\\t\")\n+                    .append(p.getValue());\n+            LOG.info(sb.toString());","path":"storm-core/src/jvm/org/apache/storm/metric/LoggingClusterMetricsConsumer.java","position":69,"original_position":83,"commit_id":"96fe42df2ccf5c5f6ffee69d1578590c70a8bcc8","original_commit_id":"96fe42df2ccf5c5f6ffee69d1578590c70a8bcc8","user":{"login":"harshach","id":38649,"avatar_url":"https://avatars.githubusercontent.com/u/38649?v=3","gravatar_id":"","url":"https://api.github.com/users/harshach","html_url":"https://github.com/harshach","followers_url":"https://api.github.com/users/harshach/followers","following_url":"https://api.github.com/users/harshach/following{/other_user}","gists_url":"https://api.github.com/users/harshach/gists{/gist_id}","starred_url":"https://api.github.com/users/harshach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshach/subscriptions","organizations_url":"https://api.github.com/users/harshach/orgs","repos_url":"https://api.github.com/users/harshach/repos","events_url":"https://api.github.com/users/harshach/events{/privacy}","received_events_url":"https://api.github.com/users/harshach/received_events","type":"User","site_admin":false},"body":"LGTM.","created_at":"2016-06-09T15:52:54Z","updated_at":"2016-06-09T15:52:54Z","html_url":"https://github.com/apache/storm/pull/1460#discussion_r66468117","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1460","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/66468117"},"html":{"href":"https://github.com/apache/storm/pull/1460#discussion_r66468117"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1460"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1460","id":72452591,"html_url":"https://github.com/apache/storm/pull/1460","diff_url":"https://github.com/apache/storm/pull/1460.diff","patch_url":"https://github.com/apache/storm/pull/1460.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1460","number":1460,"state":"open","locked":false,"title":"STORM-1723 Introduce ClusterMetricsConsumer","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"body":"Pull request for 1.x is here: #1352 \r\n\r\n* ClusterMetricsConsumer publishes cluster-side related metrics into consumers\r\n  * like MetricsConsumer for topology metrics\r\n* Users can implement IClusterMetricsConsumer and configure to cluster conf. file to take effect\r\n  * Please refer conf/storm.yaml.example for more details on configuring\r\n  * Nimbus should be launched with additional jars which are needed for IClusterMetricsConsumer\r\n* Also did some refactor to nimbus.clj\r\n\r\n","created_at":"2016-06-03T04:30:06Z","updated_at":"2016-06-09T15:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97aa7717aa1cd0f1666313c305e5e28f892f3ee6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1460/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/96fe42df2ccf5c5f6ffee69d1578590c70a8bcc8","head":{"label":"HeartSaVioR:STORM-1723","ref":"STORM-1723","sha":"96fe42df2ccf5c5f6ffee69d1578590c70a8bcc8","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"repo":{"id":24730103,"name":"storm","full_name":"HeartSaVioR/storm","owner":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeartSaVioR/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/HeartSaVioR/storm","forks_url":"https://api.github.com/repos/HeartSaVioR/storm/forks","keys_url":"https://api.github.com/repos/HeartSaVioR/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeartSaVioR/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeartSaVioR/storm/teams","hooks_url":"https://api.github.com/repos/HeartSaVioR/storm/hooks","issue_events_url":"https://api.github.com/repos/HeartSaVioR/storm/issues/events{/number}","events_url":"https://api.github.com/repos/HeartSaVioR/storm/events","assignees_url":"https://api.github.com/repos/HeartSaVioR/storm/assignees{/user}","branches_url":"https://api.github.com/repos/HeartSaVioR/storm/branches{/branch}","tags_url":"https://api.github.com/repos/HeartSaVioR/storm/tags","blobs_url":"https://api.github.com/repos/HeartSaVioR/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeartSaVioR/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeartSaVioR/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeartSaVioR/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeartSaVioR/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/HeartSaVioR/storm/languages","stargazers_url":"https://api.github.com/repos/HeartSaVioR/storm/stargazers","contributors_url":"https://api.github.com/repos/HeartSaVioR/storm/contributors","subscribers_url":"https://api.github.com/repos/HeartSaVioR/storm/subscribers","subscription_url":"https://api.github.com/repos/HeartSaVioR/storm/subscription","commits_url":"https://api.github.com/repos/HeartSaVioR/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeartSaVioR/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeartSaVioR/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeartSaVioR/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeartSaVioR/storm/contents/{+path}","compare_url":"https://api.github.com/repos/HeartSaVioR/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeartSaVioR/storm/merges","archive_url":"https://api.github.com/repos/HeartSaVioR/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeartSaVioR/storm/downloads","issues_url":"https://api.github.com/repos/HeartSaVioR/storm/issues{/number}","pulls_url":"https://api.github.com/repos/HeartSaVioR/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/HeartSaVioR/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/HeartSaVioR/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeartSaVioR/storm/labels{/name}","releases_url":"https://api.github.com/repos/HeartSaVioR/storm/releases{/id}","deployments_url":"https://api.github.com/repos/HeartSaVioR/storm/deployments","created_at":"2014-10-02T18:00:01Z","updated_at":"2016-01-13T23:55:58Z","pushed_at":"2016-06-09T05:42:10Z","git_url":"git://github.com/HeartSaVioR/storm.git","ssh_url":"git@github.com:HeartSaVioR/storm.git","clone_url":"https://github.com/HeartSaVioR/storm.git","svn_url":"https://github.com/HeartSaVioR/storm","homepage":null,"size":104482,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a9ef86d00c74ae9b2ca22f7fbef523ca154b5458","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-06-09T15:21:52Z","pushed_at":"2016-06-09T15:02:44Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":170287,"stargazers_count":3227,"watchers_count":3227,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2422,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":128,"forks":2422,"open_issues":128,"watchers":3227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1460"},"html":{"href":"https://github.com/apache/storm/pull/1460"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1460"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/96fe42df2ccf5c5f6ffee69d1578590c70a8bcc8"}}}}
{"actor":{"display_login":"harshach"}}