{"action":"closed","number":3876,"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/3876","id":53997677,"html_url":"https://github.com/dlang/phobos/pull/3876","diff_url":"https://github.com/dlang/phobos/pull/3876.diff","patch_url":"https://github.com/dlang/phobos/pull/3876.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/3876","number":3876,"state":"closed","locked":false,"title":"[issue 15229] Range-ified BigInt's Ctor to Accept Ranges of Characters","user":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"body":"* ~~This contains the commit from https://github.com/D-Programming-Language/phobos/pull/3874 which this PR requires and was separated out for convenience~~\r\n* ~~This is technically a breaking change because the ctor no longer errors on parsing problems, but throws~~\r\n* The decimal path requires only a forward range, but the hex path requires a bidirectional range. I would like to make it possible for people to pass in forward ranges if they are just using decimals, as bidirectional ranges are less common than forward ranges. But, I couldn't figure out how to make the signiture accept any forward range and only accept bidriectional ranges for hexs at run time.\r\n* For some reason I get a out of memory error on my machine for a specific unittest block. The error message is very unhelpful, so any guidance in this area would be appreciated.\r\n* If said unittest block is commented out, all other tests pass.","created_at":"2015-12-17T16:23:59Z","updated_at":"2016-04-29T11:18:54Z","closed_at":"2016-04-29T11:18:54Z","merged_at":"2016-04-29T11:18:54Z","merge_commit_sha":"8c3f3432370a33ce826f150231800e04fb6f2dfd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/3876/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/3876/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/3876/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/dd0d1398317af539787b92ad68c84c1091d11f24","head":{"label":"JackStouffer:bigint2","ref":"bigint2","sha":"dd0d1398317af539787b92ad68c84c1091d11f24","user":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"repo":{"id":41213554,"name":"phobos","full_name":"JackStouffer/phobos","owner":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JackStouffer/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/JackStouffer/phobos","forks_url":"https://api.github.com/repos/JackStouffer/phobos/forks","keys_url":"https://api.github.com/repos/JackStouffer/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JackStouffer/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JackStouffer/phobos/teams","hooks_url":"https://api.github.com/repos/JackStouffer/phobos/hooks","issue_events_url":"https://api.github.com/repos/JackStouffer/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/JackStouffer/phobos/events","assignees_url":"https://api.github.com/repos/JackStouffer/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/JackStouffer/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/JackStouffer/phobos/tags","blobs_url":"https://api.github.com/repos/JackStouffer/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JackStouffer/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JackStouffer/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/JackStouffer/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JackStouffer/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/JackStouffer/phobos/languages","stargazers_url":"https://api.github.com/repos/JackStouffer/phobos/stargazers","contributors_url":"https://api.github.com/repos/JackStouffer/phobos/contributors","subscribers_url":"https://api.github.com/repos/JackStouffer/phobos/subscribers","subscription_url":"https://api.github.com/repos/JackStouffer/phobos/subscription","commits_url":"https://api.github.com/repos/JackStouffer/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/JackStouffer/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/JackStouffer/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/JackStouffer/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/JackStouffer/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/JackStouffer/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JackStouffer/phobos/merges","archive_url":"https://api.github.com/repos/JackStouffer/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JackStouffer/phobos/downloads","issues_url":"https://api.github.com/repos/JackStouffer/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/JackStouffer/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/JackStouffer/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/JackStouffer/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JackStouffer/phobos/labels{/name}","releases_url":"https://api.github.com/repos/JackStouffer/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/JackStouffer/phobos/deployments","created_at":"2015-08-22T15:33:19Z","updated_at":"2016-01-13T20:23:30Z","pushed_at":"2016-04-28T19:01:22Z","git_url":"git://github.com/JackStouffer/phobos.git","ssh_url":"git@github.com:JackStouffer/phobos.git","clone_url":"https://github.com/JackStouffer/phobos.git","svn_url":"https://github.com/JackStouffer/phobos","homepage":"dlang.org/phobos","size":48724,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"18dfffa07daed8a02094de5d0dfa55482957650b","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-04-27T21:40:35Z","pushed_at":"2016-04-29T11:18:54Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":76048,"stargazers_count":705,"watchers_count":705,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":77,"forks":477,"open_issues":77,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3876"},"html":{"href":"https://github.com/dlang/phobos/pull/3876"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/3876"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/3876/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3876/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3876/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/dd0d1398317af539787b92ad68c84c1091d11f24"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"DmitryOlshansky","id":281770,"avatar_url":"https://avatars.githubusercontent.com/u/281770?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryOlshansky","html_url":"https://github.com/DmitryOlshansky","followers_url":"https://api.github.com/users/DmitryOlshansky/followers","following_url":"https://api.github.com/users/DmitryOlshansky/following{/other_user}","gists_url":"https://api.github.com/users/DmitryOlshansky/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryOlshansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryOlshansky/subscriptions","organizations_url":"https://api.github.com/users/DmitryOlshansky/orgs","repos_url":"https://api.github.com/users/DmitryOlshansky/repos","events_url":"https://api.github.com/users/DmitryOlshansky/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryOlshansky/received_events","type":"User","site_admin":false},"comments":40,"review_comments":25,"commits":1,"additions":140,"deletions":66,"changed_files":2}}