{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/13773","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/13773/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/13773/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/13773/events","html_url":"https://github.com/dotnet/roslyn/pull/13773","id":176784469,"number":13773,"title":"first unit tests to test that .next unit tests are working.","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-14T00:24:36Z","updated_at":"2016-09-28T00:27:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/13773","html_url":"https://github.com/dotnet/roslyn/pull/13773","diff_url":"https://github.com/dotnet/roslyn/pull/13773.diff","patch_url":"https://github.com/dotnet/roslyn/pull/13773.patch"},"body":"following up unit tests will add more tests and add proper listener to remove explicit delay"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/250038197","html_url":"https://github.com/dotnet/roslyn/pull/13773#issuecomment-250038197","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/13773","id":250038197,"user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T00:27:31Z","updated_at":"2016-09-28T00:27:31Z","body":"> and become very hard to figure out what actually went wrong.\r\n\r\nYes.  But, importantly, it found a bug in our system.  One we would likely not have found otherwise.\r\n\r\n> I am not sure how unit test having shared state with other unit test in very implicit way is good thing.\r\n\r\nBecause the point of the tests is to exercise the system and help us discover things that are wrong.  This include tests that specifically want to verify some precise bit of functionality, as well as tests that cover huge swaths of code to exercise them effectively.\r\n\r\nThis is why, for example, we do things like actually using the diagnostic service when verifying our code action tests.  We could just mock it out, but we actually want to test the entire stack.  This is also why we still do things like use a shared assembly manager across all our tests (which helped find bugs there too in highly concurrent scenarios).  It's also why we use the real compilers (with whatever shared state they do under the covers) and we use our real IDE systems, with whatever shared state tehy may have.\r\n\r\nIt's super hard to come up with stress tests that actually cover the widespread usage of how our code will hit the system.  I'm not against that.  But i certainly believe that we should utilize the existing test bed we have to stress test OOP is *very desirable*.\r\n\r\nYes, it may lead to hard to track down bugs.  But better we then find those bugs because of this versus not knowing they existed in the first place.\r\n\r\n"}}
{"actor":{"display_login":"CyrusNajmabadi"}}