{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/comments/69355809","id":69355809,"diff_hunk":"@@ -51,13 +56,15 @@ public Scheduler(AlertRepository alertRepo, CheckRepository checkRepo, EntityRep\n         this.entityRepo = entityRepository;\n         this.queueSelector = queueSelector;\n         this.schedulerConfig = schedulerConfig;\n-        this.metrics = metrics;\n         this.schedulerMetrics = new SchedulerMetrics(metrics);\n \n         taskSerializer = new JavaCommandSerializer(schedulerConfig.getTaskSerializer());\n \n-        service = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"scheduler-pool\"));\n-        shortIntervalService = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"scheduler-pool-fast\"));\n+        service = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"sc-pool-\"));\n+        service.setRemoveOnCancelPolicy(true);","path":"src/main/java/de/zalando/zmon/scheduler/ng/scheduler/Scheduler.java","position":62,"original_position":62,"commit_id":"6d177f277783377ed855be1278aba194665c9a25","original_commit_id":"6d177f277783377ed855be1278aba194665c9a25","user":{"login":"Jan-M","id":1443395,"avatar_url":"https://avatars.githubusercontent.com/u/1443395?v=3","gravatar_id":"","url":"https://api.github.com/users/Jan-M","html_url":"https://github.com/Jan-M","followers_url":"https://api.github.com/users/Jan-M/followers","following_url":"https://api.github.com/users/Jan-M/following{/other_user}","gists_url":"https://api.github.com/users/Jan-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Jan-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jan-M/subscriptions","organizations_url":"https://api.github.com/users/Jan-M/orgs","repos_url":"https://api.github.com/users/Jan-M/repos","events_url":"https://api.github.com/users/Jan-M/events{/privacy}","received_events_url":"https://api.github.com/users/Jan-M/received_events","type":"User","site_admin":false},"body":"This dequeues before end of interval and not on next execution which is in\ntheory more what we want.\n\nBut it is hard to find from manual how to correctly unschedule as .cancel()\nis confusing not 100% clear.\n\nOn Friday, 1 July 2016, Henning Jacobs <notifications@github.com> wrote:\n\n> In src/main/java/de/zalando/zmon/scheduler/ng/scheduler/Scheduler.java\n> <https://github.com/zalando-zmon/zmon-scheduler/pull/49#discussion_r69355455>\n> :\n>\n> >          this.schedulerMetrics = new SchedulerMetrics(metrics);\n> >\n> >          taskSerializer = new JavaCommandSerializer(schedulerConfig.getTaskSerializer());\n> >\n> > -        service = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"scheduler-pool\"));\n> > -        shortIntervalService = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"scheduler-pool-fast\"));\n> > +        service = new ScheduledThreadPoolExecutor(schedulerConfig.getThreadCount(), new CustomizableThreadFactory(\"sc-pool-\"));\n> > +        service.setRemoveOnCancelPolicy(true);\n>\n> what is this change doing?\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/zalando-zmon/zmon-scheduler/pull/49/files/6d177f277783377ed855be1278aba194665c9a25#r69355455>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ABYGQ_MQ9xxB91LYgNVDSr__S03VO0Ydks5qRYCIgaJpZM4JDQ4c>\n> .\n>\n","created_at":"2016-07-01T21:06:19Z","updated_at":"2016-07-01T21:06:19Z","html_url":"https://github.com/zalando-zmon/zmon-scheduler/pull/49#discussion_r69355809","pull_request_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/comments/69355809"},"html":{"href":"https://github.com/zalando-zmon/zmon-scheduler/pull/49#discussion_r69355809"},"pull_request":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49","id":76000159,"html_url":"https://github.com/zalando-zmon/zmon-scheduler/pull/49","diff_url":"https://github.com/zalando-zmon/zmon-scheduler/pull/49.diff","patch_url":"https://github.com/zalando-zmon/zmon-scheduler/pull/49.patch","issue_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/49","number":49,"state":"open","locked":false,"title":"Remove compiler-warnings where possible","user":{"login":"jbellmann","id":58709,"avatar_url":"https://avatars.githubusercontent.com/u/58709?v=3","gravatar_id":"","url":"https://api.github.com/users/jbellmann","html_url":"https://github.com/jbellmann","followers_url":"https://api.github.com/users/jbellmann/followers","following_url":"https://api.github.com/users/jbellmann/following{/other_user}","gists_url":"https://api.github.com/users/jbellmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jbellmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbellmann/subscriptions","organizations_url":"https://api.github.com/users/jbellmann/orgs","repos_url":"https://api.github.com/users/jbellmann/repos","events_url":"https://api.github.com/users/jbellmann/events{/privacy}","received_events_url":"https://api.github.com/users/jbellmann/received_events","type":"User","site_admin":false},"body":"fixes #48 ","created_at":"2016-07-01T15:49:43Z","updated_at":"2016-07-01T21:06:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e16b378fd7043a1b053fc9e0cc38eb13f9e72cab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49/commits","review_comments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49/comments","review_comment_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/49/comments","statuses_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/statuses/6d177f277783377ed855be1278aba194665c9a25","head":{"label":"zalando-zmon:gh_48","ref":"gh_48","sha":"6d177f277783377ed855be1278aba194665c9a25","user":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"repo":{"id":32993678,"name":"zmon-scheduler","full_name":"zalando-zmon/zmon-scheduler","owner":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-zmon/zmon-scheduler","description":"ZMON Scheduler","fork":false,"url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler","forks_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/forks","keys_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/teams","hooks_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/hooks","issue_events_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/events","assignees_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/tags","blobs_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/languages","stargazers_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/stargazers","contributors_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/contributors","subscribers_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/subscribers","subscription_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/subscription","commits_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/merges","archive_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/downloads","issues_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/deployments","created_at":"2015-03-27T15:25:51Z","updated_at":"2016-05-23T16:40:25Z","pushed_at":"2016-07-01T19:56:19Z","git_url":"git://github.com/zalando-zmon/zmon-scheduler.git","ssh_url":"git@github.com:zalando-zmon/zmon-scheduler.git","clone_url":"https://github.com/zalando-zmon/zmon-scheduler.git","svn_url":"https://github.com/zalando-zmon/zmon-scheduler","homepage":"","size":548,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"zalando-zmon:master","ref":"master","sha":"2ad6b3fa2153fe703e10a406aa8459969696a464","user":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"repo":{"id":32993678,"name":"zmon-scheduler","full_name":"zalando-zmon/zmon-scheduler","owner":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-zmon/zmon-scheduler","description":"ZMON Scheduler","fork":false,"url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler","forks_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/forks","keys_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/teams","hooks_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/hooks","issue_events_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/events","assignees_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/tags","blobs_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/languages","stargazers_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/stargazers","contributors_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/contributors","subscribers_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/subscribers","subscription_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/subscription","commits_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/merges","archive_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/downloads","issues_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/deployments","created_at":"2015-03-27T15:25:51Z","updated_at":"2016-05-23T16:40:25Z","pushed_at":"2016-07-01T19:56:19Z","git_url":"git://github.com/zalando-zmon/zmon-scheduler.git","ssh_url":"git@github.com:zalando-zmon/zmon-scheduler.git","clone_url":"https://github.com/zalando-zmon/zmon-scheduler.git","svn_url":"https://github.com/zalando-zmon/zmon-scheduler","homepage":"","size":548,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49"},"html":{"href":"https://github.com/zalando-zmon/zmon-scheduler/pull/49"},"issue":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/49"},"comments":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-zmon/zmon-scheduler/statuses/6d177f277783377ed855be1278aba194665c9a25"}}}}
{"actor":{"display_login":"Jan-M"}}