{"action":"created","issue":{"url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/659","repository_url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon","labels_url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/659/labels{/name}","comments_url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/659/comments","events_url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/659/events","html_url":"https://github.com/MoonchildProductions/Pale-Moon/pull/659","id":187845629,"number":659,"title":"Media decoder fixes","user":{"login":"trav90","id":10595410,"avatar_url":"https://avatars.githubusercontent.com/u/10595410?v=3","gravatar_id":"","url":"https://api.github.com/users/trav90","html_url":"https://github.com/trav90","followers_url":"https://api.github.com/users/trav90/followers","following_url":"https://api.github.com/users/trav90/following{/other_user}","gists_url":"https://api.github.com/users/trav90/gists{/gist_id}","starred_url":"https://api.github.com/users/trav90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trav90/subscriptions","organizations_url":"https://api.github.com/users/trav90/orgs","repos_url":"https://api.github.com/users/trav90/repos","events_url":"https://api.github.com/users/trav90/events{/privacy}","received_events_url":"https://api.github.com/users/trav90/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-11-07T22:18:16Z","updated_at":"2016-11-11T02:52:58Z","closed_at":"2016-11-08T15:53:55Z","pull_request":{"url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/pulls/659","html_url":"https://github.com/MoonchildProductions/Pale-Moon/pull/659","diff_url":"https://github.com/MoonchildProductions/Pale-Moon/pull/659.diff","patch_url":"https://github.com/MoonchildProductions/Pale-Moon/pull/659.patch"},"body":"This PR improves our MSE support by preventing MSE from notifying that a resource is ready even if it is not. This PR lets the decoders manage their own readiness. These fixes will also prevent double-work later and make it easier for me to get the MediaFormatReader ported over. Other changes:\r\n\r\nCleans up some code.\r\nEnables media.decoder.heuristic.dormant.enabled across all platforms\r\nAdded some more async code to OMX MediaCodecProxy\r\nVarious crash fixes in OMX and MP4Reader\r\n\r\nTested Youtube and a couple other test sites and all appears to be working as intended."},"comment":{"url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/comments/259868463","html_url":"https://github.com/MoonchildProductions/Pale-Moon/pull/659#issuecomment-259868463","issue_url":"https://api.github.com/repos/MoonchildProductions/Pale-Moon/issues/659","id":259868463,"user":{"login":"trav90","id":10595410,"avatar_url":"https://avatars.githubusercontent.com/u/10595410?v=3","gravatar_id":"","url":"https://api.github.com/users/trav90","html_url":"https://github.com/trav90","followers_url":"https://api.github.com/users/trav90/followers","following_url":"https://api.github.com/users/trav90/following{/other_user}","gists_url":"https://api.github.com/users/trav90/gists{/gist_id}","starred_url":"https://api.github.com/users/trav90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trav90/subscriptions","organizations_url":"https://api.github.com/users/trav90/orgs","repos_url":"https://api.github.com/users/trav90/repos","events_url":"https://api.github.com/users/trav90/events{/privacy}","received_events_url":"https://api.github.com/users/trav90/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T02:52:58Z","updated_at":"2016-11-11T02:52:58Z","body":"Background is that at this point Moz was making preparations to move from using the MP4Reader to MediaFormatReader (as we are), so that's what the end goals were. This particular issue was to improve YouTube/MSE/dormant compatibility, and enable mDormantEnabled across all platforms. While they were at it, they decided they needed to remove a bunch of other code (of course), which resulted in a regression for them that was fixed in the problem commit.\r\n\r\nSince I did not remove/make every single change Moz has (especially in WIndows-land), I think the additional check that this commit made doesn't play nice with some of our existing code."}}
{"actor":{"display_login":"trav90"}}