{"action":"created","issue":{"url":"https://api.github.com/repos/mgechev/angular-seed/issues/1714","repository_url":"https://api.github.com/repos/mgechev/angular-seed","labels_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1714/labels{/name}","comments_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1714/comments","events_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1714/events","html_url":"https://github.com/mgechev/angular-seed/pull/1714","id":195308439,"number":1714,"title":"Lazy loading support with Aot","user":{"login":"dfaglioni","id":11754336,"avatar_url":"https://avatars.githubusercontent.com/u/11754336?v=3","gravatar_id":"","url":"https://api.github.com/users/dfaglioni","html_url":"https://github.com/dfaglioni","followers_url":"https://api.github.com/users/dfaglioni/followers","following_url":"https://api.github.com/users/dfaglioni/following{/other_user}","gists_url":"https://api.github.com/users/dfaglioni/gists{/gist_id}","starred_url":"https://api.github.com/users/dfaglioni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfaglioni/subscriptions","organizations_url":"https://api.github.com/users/dfaglioni/orgs","repos_url":"https://api.github.com/users/dfaglioni/repos","events_url":"https://api.github.com/users/dfaglioni/events{/privacy}","received_events_url":"https://api.github.com/users/dfaglioni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":87,"created_at":"2016-12-13T16:56:29Z","updated_at":"2016-12-20T17:21:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mgechev/angular-seed/pulls/1714","html_url":"https://github.com/mgechev/angular-seed/pull/1714","diff_url":"https://github.com/mgechev/angular-seed/pull/1714.diff","patch_url":"https://github.com/mgechev/angular-seed/pull/1714.patch"},"body":"I had to change two major things. First:  The SYSTEM_BUILDER_CONFIG to get working the build.bundles.app.ts with bundle (to expose the dependencies), in the previous version the dependencies  had a loading error. Two: Included  the SystemJS in production, to use on index to load the main app, and exposes for angular to load and compile the lazy module. I removed the app.js from the index.\r\nI created a task to build the lazy bundle, only with theirs  dependencies (build.bundles.app.lazy). All folders with + prefix will be considerate lazy modules.\r\nI created two lazy modules, lazy-about and lazy,  both has e2e tests to proof the solution.\r\n"},"comment":{"url":"https://api.github.com/repos/mgechev/angular-seed/issues/comments/268302901","html_url":"https://github.com/mgechev/angular-seed/pull/1714#issuecomment-268302901","issue_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1714","id":268302901,"user":{"login":"markoddi01","id":2556223,"avatar_url":"https://avatars.githubusercontent.com/u/2556223?v=3","gravatar_id":"","url":"https://api.github.com/users/markoddi01","html_url":"https://github.com/markoddi01","followers_url":"https://api.github.com/users/markoddi01/followers","following_url":"https://api.github.com/users/markoddi01/following{/other_user}","gists_url":"https://api.github.com/users/markoddi01/gists{/gist_id}","starred_url":"https://api.github.com/users/markoddi01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoddi01/subscriptions","organizations_url":"https://api.github.com/users/markoddi01/orgs","repos_url":"https://api.github.com/users/markoddi01/repos","events_url":"https://api.github.com/users/markoddi01/events{/privacy}","received_events_url":"https://api.github.com/users/markoddi01/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T17:21:29Z","updated_at":"2016-12-20T17:21:29Z","body":"@dfaglioni I've updated the dependencies like above.\r\n\r\nI now get the header component error again when I do npm run serve.prod (Works fine when I do npm run start though):\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2556223/21360648/b3b3264a-c6d8-11e6-9241-5fe6076385e4.png)\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"markoddi01"}}