{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/62288844","id":62288844,"diff_hunk":"@@ -140,6 +143,42 @@ public JsonElement getActualHighWatermark() {\n   }\n \n   /**\n+   * Get the actual high {@link Watermark}. If the {@code WorkUnitState} does not contain the actual high watermark\n+   * (which may be caused by task failures), the low watermark in the corresponding {@link WorkUnit} will be returned.\n+   *\n+   * @param watermarkClass the watermark class for this {@code WorkUnitState}.\n+   * @param gson a {@link Gson} object used to deserialize the watermark.\n+   * @return the actual high watermark in this {@code WorkUnitState}. null is returned if this {@code WorkUnitState}\n+   * does not contain an actual high watermark, and the corresponding {@code WorkUnit} does not contain a low\n+   * watermark.\n+   */\n+  public <T extends Watermark> T getActualHighWatermark(Class<T> watermarkClass, Gson gson) {","path":"gobblin-api/src/main/java/gobblin/configuration/WorkUnitState.java","position":30,"original_position":30,"commit_id":"b1a022b95c17c71fab75c948b8e7ceffe51e50c4","original_commit_id":"b1a022b95c17c71fab75c948b8e7ceffe51e50c4","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"body":"Previously since `getActualHighWatermark` returns a `JsonElement`, each `Source` class that uses the new watermark needs to deserialize it using a `Gson` object. It is more convenient to provide these methods that directly return `Watermark`.","created_at":"2016-05-06T04:58:14Z","updated_at":"2016-05-06T04:58:14Z","html_url":"https://github.com/linkedin/gobblin/pull/957#discussion_r62288844","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/957","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/62288844"},"html":{"href":"https://github.com/linkedin/gobblin/pull/957#discussion_r62288844"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/957"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/957","id":68778490,"html_url":"https://github.com/linkedin/gobblin/pull/957","diff_url":"https://github.com/linkedin/gobblin/pull/957.diff","patch_url":"https://github.com/linkedin/gobblin/pull/957.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/957","number":957,"state":"open","locked":false,"title":"Modify QueryBasedSource to allow pulling multiple tables in the same job","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"body":"This PR modifies `QueryBasedSource` so that it is possible to specify multiple table names in the same job.\r\n\r\nPreviously a job can only specify a single table name via `source.entity` or `extract.table.name`. Now two new properties are added: `source.entities` and `extract.table.names`.\r\n\r\nRelated changes:\r\n- Moved the method to obtain topic-specific properties from `KafkaSource` to `DatasetUtils` so that it can be used by `QueryBasedSource` as well.\r\n- Removed the usage of the deprecated watermark methods in `QueryBasedSource` and `QueryBasedExtractor`, and replaced them with the new JSON-based `Watermark`.\r\n- Use a simple round robin method in `QueryBasedSource` to pack `WorkUnit`s into `MultiWorkUnit`s. More sophisticated bin packing methods can be added later if there's a need to do so.","created_at":"2016-05-03T21:30:25Z","updated_at":"2016-05-06T04:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0861126adc65a8ea835c39a1905bc94c5a6775b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/957/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/957/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/957/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/b1a022b95c17c71fab75c948b8e7ceffe51e50c4","head":{"label":"zliu41:sf","ref":"sf","sha":"b1a022b95c17c71fab75c948b8e7ceffe51e50c4","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"repo":{"id":32048123,"name":"gobblin","full_name":"zliu41/gobblin","owner":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zliu41/gobblin","description":"","fork":true,"url":"https://api.github.com/repos/zliu41/gobblin","forks_url":"https://api.github.com/repos/zliu41/gobblin/forks","keys_url":"https://api.github.com/repos/zliu41/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zliu41/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zliu41/gobblin/teams","hooks_url":"https://api.github.com/repos/zliu41/gobblin/hooks","issue_events_url":"https://api.github.com/repos/zliu41/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/zliu41/gobblin/events","assignees_url":"https://api.github.com/repos/zliu41/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/zliu41/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/zliu41/gobblin/tags","blobs_url":"https://api.github.com/repos/zliu41/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zliu41/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zliu41/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zliu41/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zliu41/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/zliu41/gobblin/languages","stargazers_url":"https://api.github.com/repos/zliu41/gobblin/stargazers","contributors_url":"https://api.github.com/repos/zliu41/gobblin/contributors","subscribers_url":"https://api.github.com/repos/zliu41/gobblin/subscribers","subscription_url":"https://api.github.com/repos/zliu41/gobblin/subscription","commits_url":"https://api.github.com/repos/zliu41/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zliu41/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zliu41/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zliu41/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zliu41/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/zliu41/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zliu41/gobblin/merges","archive_url":"https://api.github.com/repos/zliu41/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zliu41/gobblin/downloads","issues_url":"https://api.github.com/repos/zliu41/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/zliu41/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/zliu41/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/zliu41/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zliu41/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/zliu41/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/zliu41/gobblin/deployments","created_at":"2015-03-12T00:17:48Z","updated_at":"2016-01-12T18:04:27Z","pushed_at":"2016-05-04T23:53:16Z","git_url":"git://github.com/zliu41/gobblin.git","ssh_url":"git@github.com:zliu41/gobblin.git","clone_url":"https://github.com/zliu41/gobblin.git","svn_url":"https://github.com/zliu41/gobblin","homepage":null,"size":85681,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"cf7c251d419a4e45e52439c09e706e210f636345","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-05-05T15:30:41Z","pushed_at":"2016-05-06T02:31:45Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":165949,"stargazers_count":553,"watchers_count":553,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":212,"mirror_url":null,"open_issues_count":79,"forks":212,"open_issues":79,"watchers":553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/957"},"html":{"href":"https://github.com/linkedin/gobblin/pull/957"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/957"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/b1a022b95c17c71fab75c948b8e7ceffe51e50c4"}}}}