{"action":"created","issue":{"url":"https://api.github.com/repos/Polymer/polymer/issues/4090","repository_url":"https://api.github.com/repos/Polymer/polymer","labels_url":"https://api.github.com/repos/Polymer/polymer/issues/4090/labels{/name}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/4090/comments","events_url":"https://api.github.com/repos/Polymer/polymer/issues/4090/events","html_url":"https://github.com/Polymer/polymer/pull/4090","id":184990344,"number":4090,"title":"Move resolveUrl to Polymer.Element, get `is` from ctor. Fixes #3992","user":{"login":"kevinpschaaf","id":1354932,"avatar_url":"https://avatars.githubusercontent.com/u/1354932?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinpschaaf","html_url":"https://github.com/kevinpschaaf","followers_url":"https://api.github.com/users/kevinpschaaf/followers","following_url":"https://api.github.com/users/kevinpschaaf/following{/other_user}","gists_url":"https://api.github.com/users/kevinpschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinpschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinpschaaf/subscriptions","organizations_url":"https://api.github.com/users/kevinpschaaf/orgs","repos_url":"https://api.github.com/users/kevinpschaaf/repos","events_url":"https://api.github.com/users/kevinpschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/kevinpschaaf/received_events","type":"User","site_admin":false},"labels":[{"id":88354526,"url":"https://api.github.com/repos/Polymer/polymer/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-25T00:38:32Z","updated_at":"2016-10-27T20:29:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/4090","html_url":"https://github.com/Polymer/polymer/pull/4090","diff_url":"https://github.com/Polymer/polymer/pull/4090.diff","patch_url":"https://github.com/Polymer/polymer/pull/4090.patch"},"body":"### Reference Issue\r\nFixes #3992\r\n\r\n### Details\r\nThe reason `resolveUrl` didn't work even on `class extend LegacyElement` is because in the class-based syntax the `static get is()` getter is only on the constructor, and never gets put on the prototype/instance.\r\n\r\nFor this change, I just made `resolveUrl` look at `this.constructor.is` instead of `this.is`.  However, we might want to re-consider if we really want to lose `is` from the prototype/instance or not (was this an intentional change?).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Polymer/polymer/issues/comments/256759863","html_url":"https://github.com/Polymer/polymer/pull/4090#issuecomment-256759863","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/4090","id":256759863,"user":{"login":"kevinpschaaf","id":1354932,"avatar_url":"https://avatars.githubusercontent.com/u/1354932?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinpschaaf","html_url":"https://github.com/kevinpschaaf","followers_url":"https://api.github.com/users/kevinpschaaf/followers","following_url":"https://api.github.com/users/kevinpschaaf/following{/other_user}","gists_url":"https://api.github.com/users/kevinpschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinpschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinpschaaf/subscriptions","organizations_url":"https://api.github.com/users/kevinpschaaf/orgs","repos_url":"https://api.github.com/users/kevinpschaaf/repos","events_url":"https://api.github.com/users/kevinpschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/kevinpschaaf/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T20:29:42Z","updated_at":"2016-10-27T20:29:42Z","body":"Rebasing against `2.0-preview`, which should fix test issues."}}
{"actor":{"display_login":"kevinpschaaf"}}