{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/1516","repository_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/1516/labels{/name}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/1516/comments","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/1516/events","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/1516","id":184055436,"number":1516,"title":"Get rid of attestation references","user":{"login":"mpreisler","id":753153,"avatar_url":"https://avatars.githubusercontent.com/u/753153?v=3","gravatar_id":"","url":"https://api.github.com/users/mpreisler","html_url":"https://github.com/mpreisler","followers_url":"https://api.github.com/users/mpreisler/followers","following_url":"https://api.github.com/users/mpreisler/following{/other_user}","gists_url":"https://api.github.com/users/mpreisler/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreisler/subscriptions","organizations_url":"https://api.github.com/users/mpreisler/orgs","repos_url":"https://api.github.com/users/mpreisler/repos","events_url":"https://api.github.com/users/mpreisler/events{/privacy}","received_events_url":"https://api.github.com/users/mpreisler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels/Infrastructure","name":"Infrastructure","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"redhatrises","id":8398836,"avatar_url":"https://avatars.githubusercontent.com/u/8398836?v=3","gravatar_id":"","url":"https://api.github.com/users/redhatrises","html_url":"https://github.com/redhatrises","followers_url":"https://api.github.com/users/redhatrises/followers","following_url":"https://api.github.com/users/redhatrises/following{/other_user}","gists_url":"https://api.github.com/users/redhatrises/gists{/gist_id}","starred_url":"https://api.github.com/users/redhatrises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhatrises/subscriptions","organizations_url":"https://api.github.com/users/redhatrises/orgs","repos_url":"https://api.github.com/users/redhatrises/repos","events_url":"https://api.github.com/users/redhatrises/events{/privacy}","received_events_url":"https://api.github.com/users/redhatrises/received_events","type":"User","site_admin":false},"assignees":[{"login":"redhatrises","id":8398836,"avatar_url":"https://avatars.githubusercontent.com/u/8398836?v=3","gravatar_id":"","url":"https://api.github.com/users/redhatrises","html_url":"https://github.com/redhatrises","followers_url":"https://api.github.com/users/redhatrises/followers","following_url":"https://api.github.com/users/redhatrises/following{/other_user}","gists_url":"https://api.github.com/users/redhatrises/gists{/gist_id}","starred_url":"https://api.github.com/users/redhatrises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhatrises/subscriptions","organizations_url":"https://api.github.com/users/redhatrises/orgs","repos_url":"https://api.github.com/users/redhatrises/repos","events_url":"https://api.github.com/users/redhatrises/events{/privacy}","received_events_url":"https://api.github.com/users/redhatrises/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/23","html_url":"https://github.com/OpenSCAP/scap-security-guide/milestones/0.1.31","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/23/labels","id":1842543,"number":23,"title":"0.1.31","description":null,"creator":{"login":"iankko","id":8414918,"avatar_url":"https://avatars.githubusercontent.com/u/8414918?v=3","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":173,"state":"open","created_at":"2016-06-22T08:39:18Z","updated_at":"2016-10-19T21:00:41Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-10-19T19:41:49Z","updated_at":"2016-10-19T21:00:55Z","closed_at":"2016-10-19T20:59:28Z","pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/1516","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/1516","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/1516.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/1516.patch"},"body":"This pull request removes \"test_attestation\" references from OVAL and XCCDF. These references are a pain to keep up to date. As a result they are not up to date at all. In fact we have test attestation in XCCDF and OVAL generated from templates and those attestations don't even apply! Some attestations are super old (2012) and since then the code has changed drastically. Overall I think all of this code just complicates the build process and provides very little value to users.\r\n\r\nIf somebody wants to see who is responsible for XCCDF or OVAL code they have to use `git blame -u` in the end. I believe all of us do that when we need some code explained.\r\n\r\nPlus this removes the test attestation refs from HTML guides.\r\n\r\nNot sure which version of SSG I should target, personally I would love to push this out in 0.1.31 but I realize it's a big change and the release will happen quite soon. Give me your thoughts :-)"},"comment":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments/254939443","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/1516#issuecomment-254939443","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/1516","id":254939443,"user":{"login":"mpreisler","id":753153,"avatar_url":"https://avatars.githubusercontent.com/u/753153?v=3","gravatar_id":"","url":"https://api.github.com/users/mpreisler","html_url":"https://github.com/mpreisler","followers_url":"https://api.github.com/users/mpreisler/followers","following_url":"https://api.github.com/users/mpreisler/following{/other_user}","gists_url":"https://api.github.com/users/mpreisler/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreisler/subscriptions","organizations_url":"https://api.github.com/users/mpreisler/orgs","repos_url":"https://api.github.com/users/mpreisler/repos","events_url":"https://api.github.com/users/mpreisler/events{/privacy}","received_events_url":"https://api.github.com/users/mpreisler/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T21:00:55Z","updated_at":"2016-10-19T21:00:55Z","body":"Holy crap, this was easier to get through than I thought ;-D Thx for the review, @redhatrises !"}}
{"actor":{"display_login":"mpreisler"}}