{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/88449307","pull_request_review_id":9021855,"id":88449307,"diff_hunk":"@@ -36,7 +36,14 @@ def results\n         release_clause = \"(#{convert(:version_sortable)} = #{convert(':version')} AND \" \\\n             \"#{convert(:release_sortable)} #{operator} #{convert(':release')})\"\n \n-        version_clause = \"#{version_clause} OR #{release_clause}\" unless release.blank?\n+        if release.present?\n+          if self.operator == EQUAL\n+            version_clause = \"#{release_clause}\" ","path":"app/lib/katello/util/package_filter.rb","position":7,"original_position":7,"commit_id":"d93d015d47ecafa8a76ed779c0ba058c98b00f29","original_commit_id":"d93d015d47ecafa8a76ed779c0ba058c98b00f29","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing whitespace detected.","created_at":"2016-11-17T13:18:38Z","updated_at":"2016-11-17T13:18:38Z","html_url":"https://github.com/Katello/katello/pull/6456#discussion_r88449307","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/6456","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/88449307"},"html":{"href":"https://github.com/Katello/katello/pull/6456#discussion_r88449307"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/6456"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/6456","id":93976045,"html_url":"https://github.com/Katello/katello/pull/6456","diff_url":"https://github.com/Katello/katello/pull/6456.diff","patch_url":"https://github.com/Katello/katello/pull/6456.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/6456","number":6456,"state":"open","locked":false,"title":"Fixes #17362 EQUAL operator equation was modified from <SQL>version_s…","user":{"login":"xgazdi","id":5259990,"avatar_url":"https://avatars.githubusercontent.com/u/5259990?v=3","gravatar_id":"","url":"https://api.github.com/users/xgazdi","html_url":"https://github.com/xgazdi","followers_url":"https://api.github.com/users/xgazdi/followers","following_url":"https://api.github.com/users/xgazdi/following{/other_user}","gists_url":"https://api.github.com/users/xgazdi/gists{/gist_id}","starred_url":"https://api.github.com/users/xgazdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgazdi/subscriptions","organizations_url":"https://api.github.com/users/xgazdi/orgs","repos_url":"https://api.github.com/users/xgazdi/repos","events_url":"https://api.github.com/users/xgazdi/events{/privacy}","received_events_url":"https://api.github.com/users/xgazdi/received_events","type":"User","site_admin":false},"body":"…ortable = version OR (version_sortable = version AND release_sortable)</SQL> to <SQL>version_sortable = version AND release_sortable</SQL> because accordint to boolean algebra A + (AB) = A, so the condition was always true for the version and was completele ignoring release version","created_at":"2016-11-16T14:30:33Z","updated_at":"2016-11-17T13:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95a7adc1e5ba3a5383c71e29fe8c5784db75993d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/6456/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/6456/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/6456/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/d93d015d47ecafa8a76ed779c0ba058c98b00f29","head":{"label":"xgazdi:master","ref":"master","sha":"d93d015d47ecafa8a76ed779c0ba058c98b00f29","user":{"login":"xgazdi","id":5259990,"avatar_url":"https://avatars.githubusercontent.com/u/5259990?v=3","gravatar_id":"","url":"https://api.github.com/users/xgazdi","html_url":"https://github.com/xgazdi","followers_url":"https://api.github.com/users/xgazdi/followers","following_url":"https://api.github.com/users/xgazdi/following{/other_user}","gists_url":"https://api.github.com/users/xgazdi/gists{/gist_id}","starred_url":"https://api.github.com/users/xgazdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgazdi/subscriptions","organizations_url":"https://api.github.com/users/xgazdi/orgs","repos_url":"https://api.github.com/users/xgazdi/repos","events_url":"https://api.github.com/users/xgazdi/events{/privacy}","received_events_url":"https://api.github.com/users/xgazdi/received_events","type":"User","site_admin":false},"repo":{"id":70138402,"name":"katello","full_name":"xgazdi/katello","owner":{"login":"xgazdi","id":5259990,"avatar_url":"https://avatars.githubusercontent.com/u/5259990?v=3","gravatar_id":"","url":"https://api.github.com/users/xgazdi","html_url":"https://github.com/xgazdi","followers_url":"https://api.github.com/users/xgazdi/followers","following_url":"https://api.github.com/users/xgazdi/following{/other_user}","gists_url":"https://api.github.com/users/xgazdi/gists{/gist_id}","starred_url":"https://api.github.com/users/xgazdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgazdi/subscriptions","organizations_url":"https://api.github.com/users/xgazdi/orgs","repos_url":"https://api.github.com/users/xgazdi/repos","events_url":"https://api.github.com/users/xgazdi/events{/privacy}","received_events_url":"https://api.github.com/users/xgazdi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xgazdi/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/xgazdi/katello","forks_url":"https://api.github.com/repos/xgazdi/katello/forks","keys_url":"https://api.github.com/repos/xgazdi/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xgazdi/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xgazdi/katello/teams","hooks_url":"https://api.github.com/repos/xgazdi/katello/hooks","issue_events_url":"https://api.github.com/repos/xgazdi/katello/issues/events{/number}","events_url":"https://api.github.com/repos/xgazdi/katello/events","assignees_url":"https://api.github.com/repos/xgazdi/katello/assignees{/user}","branches_url":"https://api.github.com/repos/xgazdi/katello/branches{/branch}","tags_url":"https://api.github.com/repos/xgazdi/katello/tags","blobs_url":"https://api.github.com/repos/xgazdi/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xgazdi/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xgazdi/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/xgazdi/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xgazdi/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/xgazdi/katello/languages","stargazers_url":"https://api.github.com/repos/xgazdi/katello/stargazers","contributors_url":"https://api.github.com/repos/xgazdi/katello/contributors","subscribers_url":"https://api.github.com/repos/xgazdi/katello/subscribers","subscription_url":"https://api.github.com/repos/xgazdi/katello/subscription","commits_url":"https://api.github.com/repos/xgazdi/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/xgazdi/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/xgazdi/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/xgazdi/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/xgazdi/katello/contents/{+path}","compare_url":"https://api.github.com/repos/xgazdi/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xgazdi/katello/merges","archive_url":"https://api.github.com/repos/xgazdi/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xgazdi/katello/downloads","issues_url":"https://api.github.com/repos/xgazdi/katello/issues{/number}","pulls_url":"https://api.github.com/repos/xgazdi/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/xgazdi/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/xgazdi/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xgazdi/katello/labels{/name}","releases_url":"https://api.github.com/repos/xgazdi/katello/releases{/id}","deployments_url":"https://api.github.com/repos/xgazdi/katello/deployments","created_at":"2016-10-06T09:00:44Z","updated_at":"2016-10-06T09:00:51Z","pushed_at":"2016-11-17T13:18:28Z","git_url":"git://github.com/xgazdi/katello.git","ssh_url":"git@github.com:xgazdi/katello.git","clone_url":"https://github.com/xgazdi/katello.git","svn_url":"https://github.com/xgazdi/katello","homepage":"katello.org","size":87990,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"5b542b2f5d6e49736cbdca8c53efec82b149bc8e","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2016-11-10T21:14:44Z","pushed_at":"2016-11-17T13:18:30Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":128282,"stargazers_count":206,"watchers_count":206,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":114,"forks":141,"open_issues":114,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/6456"},"html":{"href":"https://github.com/Katello/katello/pull/6456"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/6456"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/6456/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/6456/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/6456/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/d93d015d47ecafa8a76ed779c0ba058c98b00f29"}}}}
{"actor":{"display_login":"houndci-bot"}}