{"action":"created","issue":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/600","repository_url":"https://api.github.com/repos/savoirfairelinux/sous-chef","labels_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/600/labels{/name}","comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/600/comments","events_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/600/events","html_url":"https://github.com/savoirfairelinux/sous-chef/pull/600","id":196957072,"number":600,"title":"Fix #601","user":{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false},"labels":[{"id":354858853,"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/labels/needs-review","name":"needs-review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false},"assignees":[{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-21T15:15:23Z","updated_at":"2016-12-21T20:31:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/600","html_url":"https://github.com/savoirfairelinux/sous-chef/pull/600","diff_url":"https://github.com/savoirfairelinux/sous-chef/pull/600.diff","patch_url":"https://github.com/savoirfairelinux/sous-chef/pull/600.patch"},"body":"## Fix #601 by lingxiaoyang\r\n\r\n### Changes proposed in this pull request:\r\n\r\n* Consider when `client.route is None`, when sorting the generated orders.\r\n* If a client has null route, the corresponding field will show a warning sign, linking to client update form, and disable the steps and \"OK, I'm ready\" button to prevent proceeding to next step. It also works when a client is not geolocalized (no latitude/longitude).\r\n![image](https://cloud.githubusercontent.com/assets/8630726/21404544/afea38fc-c78f-11e6-9936-1daf3f881a02.png)\r\n![image](https://cloud.githubusercontent.com/assets/8630726/21404713/82f013f2-c790-11e6-829a-15d6fb474db5.png)\r\n\r\n* Unit tests to ensure the display of warning signs (these signs are used to trigger JavaScript manipulations to disable elements).\r\n\r\n### Status\r\n\r\n- [x] READY\r\n- [ ] HOLD\r\n- [ ] WIP (Work-In-Progress)\r\n\r\n### How to verify this change\r\n\r\n1. Generate today's delivery orders.\r\n2. Choose a client, go to Django admin, set route to null.\r\n3. Refresh the page or click \"Generate orders\" button. The red warning sign should display, and the steps and button are then disabled.\r\n4. Follow the red warning sign, assign a route, save the client. Refresh the page or click \"Generate orders\" button, and the route information should be then updated, and it is possible now to proceed to next step.\r\n5. The same for geolocalized (client.member.address.latitude/longitude).\r\n\r\n### Deployment notes and migration\r\n\r\nnone\r\n\r\n### New translatable strings\r\n\r\nnone\r\n\r\n### Additional notes\r\n\r\nnone\r\n"},"comment":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/comments/268631459","html_url":"https://github.com/savoirfairelinux/sous-chef/pull/600#issuecomment-268631459","issue_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/600","id":268631459,"user":{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T20:31:40Z","updated_at":"2016-12-21T20:31:40Z","body":"@manumilou  updated."}}
{"actor":{"display_login":"lingxiaoyang"}}