{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6085","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6085/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6085/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6085/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6085","id":172076517,"number":6085,"title":"[android] #6077 - keep rules for Signature and Annotation","user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"000000"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/%E2%9C%93%20ready%20for%20review","name":"✓ ready for review","color":"b60205"}],"state":"closed","locked":false,"assignee":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/38","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/android-v4.2.0","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/38/labels","id":1808393,"number":38,"title":"android-v4.2.0","description":"","creator":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":118,"state":"open","created_at":"2016-06-04T11:55:28Z","updated_at":"2016-08-22T12:49:47Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-08-19T08:05:42Z","updated_at":"2016-08-22T14:19:36Z","closed_at":"2016-08-22T12:49:47Z","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6085","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6085","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/6085.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/6085.patch"},"body":"Closes #6077 \r\n\r\nI was able to proguard the testapp with this configuration. Would love some 👀 . \r\n\r\nYou can retest this with adding the following in our build.gradle of the testapp:\r\n\r\n```\r\n    buildTypes {\r\n        debug {\r\n            // run code coverage reports\r\n            testCoverageEnabled = true\r\n            minifyEnabled true\r\n            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'\r\n        }\r\n```\r\n\r\nReview @cammace, @bleege "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/241427568","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6085#issuecomment-241427568","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6085","id":241427568,"user":{"login":"zugaldia","id":6964,"avatar_url":"https://avatars.githubusercontent.com/u/6964?v=3","gravatar_id":"","url":"https://api.github.com/users/zugaldia","html_url":"https://github.com/zugaldia","followers_url":"https://api.github.com/users/zugaldia/followers","following_url":"https://api.github.com/users/zugaldia/following{/other_user}","gists_url":"https://api.github.com/users/zugaldia/gists{/gist_id}","starred_url":"https://api.github.com/users/zugaldia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zugaldia/subscriptions","organizations_url":"https://api.github.com/users/zugaldia/orgs","repos_url":"https://api.github.com/users/zugaldia/repos","events_url":"https://api.github.com/users/zugaldia/events{/privacy}","received_events_url":"https://api.github.com/users/zugaldia/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T14:19:35Z","updated_at":"2016-08-22T14:19:35Z","body":"@tobrun @cammace Why are we doing `com.mapbox.mapboxsdk.<package>.*` for each package in the SDK, instead of doing `com.mapbox.mapboxsdk.*` to cover them all and keep the rules shorter. Any particular advantages?"}}
{"actor":{"display_login":"zugaldia"}}