{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/959","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/959/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/959/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/959/events","html_url":"https://github.com/openzipkin/zipkin/pull/959","id":132883036,"number":959,"title":"Prefers client when deriving duration","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-11T04:11:21Z","updated_at":"2016-02-11T04:11:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/959","html_url":"https://github.com/openzipkin/zipkin/pull/959","diff_url":"https://github.com/openzipkin/zipkin/pull/959.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/959.patch"},"body":"Previously, the clock skew corrector incorrectly derived duration. This\r\nwas inaccurate as the distance between annotations on the span's host is\r\nnot subject to skew.\r\n\r\nWhen zipkin spans cross multiple hosts, it is usually due to a client+\r\nserver span. By preferring the client's duration, we avoid having to\r\nconsider skew when deriving duration from annotations. Regardless, we\r\nonly derive duration when it isn't explicitly set.\r\n\r\nFixes #955"},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/182694198","html_url":"https://github.com/openzipkin/zipkin/pull/959#issuecomment-182694198","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/959","id":182694198,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T04:11:28Z","updated_at":"2016-02-11T04:11:28Z","body":"cc @yurishkuro "}}