{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/60281180","id":60281180,"diff_hunk":"@@ -120,7 +119,13 @@ Please follow [test.sh](https://github.com/bprashanth/Ingress/blob/master/exampl\n \n Check the [example](examples/tls/README.md)\n \n+### HTTP Strict Transport Security\n \n+HTTP Strict Transport Security (HSTS) is an opt-in security enhancement specified through the use of a special response header. Once a supported browser receives this header that browser will prevent any communications from being sent over HTTP to the specified domain and will instead send all communications over HTTPS.\n+\n+By default the controller redirects (301) to HTTPS if there is a TLS Ingress rule. \n+\n+To disable this behavior use `force-hsts=false` in the NGINX ConfigMap.","path":"ingress/controllers/nginx/README.md","position":18,"original_position":18,"commit_id":"4a8a8a4a3b71c2efb85c0c731fb011a86e122b32","original_commit_id":"4a8a8a4a3b71c2efb85c0c731fb011a86e122b32","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"can we call this just hsts=true/false? since hsts is supposed to force https it feels redundant to say force hsts.","created_at":"2016-04-19T18:08:34Z","updated_at":"2016-04-19T18:08:34Z","html_url":"https://github.com/kubernetes/contrib/pull/766#discussion_r60281180","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/766","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/60281180"},"html":{"href":"https://github.com/kubernetes/contrib/pull/766#discussion_r60281180"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/766"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/766","id":66256801,"html_url":"https://github.com/kubernetes/contrib/pull/766","diff_url":"https://github.com/kubernetes/contrib/pull/766.diff","patch_url":"https://github.com/kubernetes/contrib/pull/766.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/766","number":766,"state":"open","locked":false,"title":"Add support for named port, better docs for TLS nginx Ingress","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"fixes #743\r\nfixes #781","created_at":"2016-04-13T02:20:39Z","updated_at":"2016-04-19T18:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54e255daab906a334f45fb4ab7465f6b6c2892f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/766/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/766/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/766/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/4a8a8a4a3b71c2efb85c0c731fb011a86e122b32","head":{"label":"aledbf:nginx-tls","ref":"nginx-tls","sha":"4a8a8a4a3b71c2efb85c0c731fb011a86e122b32","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":42607552,"name":"contrib","full_name":"aledbf/contrib","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/aledbf/contrib","forks_url":"https://api.github.com/repos/aledbf/contrib/forks","keys_url":"https://api.github.com/repos/aledbf/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/contrib/teams","hooks_url":"https://api.github.com/repos/aledbf/contrib/hooks","issue_events_url":"https://api.github.com/repos/aledbf/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/contrib/events","assignees_url":"https://api.github.com/repos/aledbf/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/contrib/tags","blobs_url":"https://api.github.com/repos/aledbf/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/contrib/languages","stargazers_url":"https://api.github.com/repos/aledbf/contrib/stargazers","contributors_url":"https://api.github.com/repos/aledbf/contrib/contributors","subscribers_url":"https://api.github.com/repos/aledbf/contrib/subscribers","subscription_url":"https://api.github.com/repos/aledbf/contrib/subscription","commits_url":"https://api.github.com/repos/aledbf/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/contrib/merges","archive_url":"https://api.github.com/repos/aledbf/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/contrib/downloads","issues_url":"https://api.github.com/repos/aledbf/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/contrib/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/contrib/deployments","created_at":"2015-09-16T19:04:49Z","updated_at":"2016-01-11T19:27:11Z","pushed_at":"2016-04-19T17:45:15Z","git_url":"git://github.com/aledbf/contrib.git","ssh_url":"git@github.com:aledbf/contrib.git","clone_url":"https://github.com/aledbf/contrib.git","svn_url":"https://github.com/aledbf/contrib","homepage":"","size":24856,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"be6823e94001d6f256f1d8ff64e5ef2af7b144a7","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-04-19T12:52:31Z","pushed_at":"2016-04-19T17:45:16Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":44813,"stargazers_count":244,"watchers_count":244,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":174,"forks":222,"open_issues":174,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/766"},"html":{"href":"https://github.com/kubernetes/contrib/pull/766"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/766"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/4a8a8a4a3b71c2efb85c0c731fb011a86e122b32"}}}}