{"action":"created","issue":{"url":"https://api.github.com/repos/mity/md4c/issues/1","repository_url":"https://api.github.com/repos/mity/md4c","labels_url":"https://api.github.com/repos/mity/md4c/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mity/md4c/issues/1/comments","events_url":"https://api.github.com/repos/mity/md4c/issues/1/events","html_url":"https://github.com/mity/md4c/pull/1","id":193393310,"number":1,"title":"Some proposed code improvements","user":{"login":"tin-pot","id":1289260,"avatar_url":"https://avatars.githubusercontent.com/u/1289260?v=3","gravatar_id":"","url":"https://api.github.com/users/tin-pot","html_url":"https://github.com/tin-pot","followers_url":"https://api.github.com/users/tin-pot/followers","following_url":"https://api.github.com/users/tin-pot/following{/other_user}","gists_url":"https://api.github.com/users/tin-pot/gists{/gist_id}","starred_url":"https://api.github.com/users/tin-pot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tin-pot/subscriptions","organizations_url":"https://api.github.com/users/tin-pot/orgs","repos_url":"https://api.github.com/users/tin-pot/repos","events_url":"https://api.github.com/users/tin-pot/events{/privacy}","received_events_url":"https://api.github.com/users/tin-pot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-05T01:36:57Z","updated_at":"2016-12-05T01:38:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mity/md4c/pulls/1","html_url":"https://github.com/mity/md4c/pull/1","diff_url":"https://github.com/mity/md4c/pull/1.diff","patch_url":"https://github.com/mity/md4c/pull/1.patch"},"body":"You might want to consider (mostly) the commits 3202553 and 2af7f0a, and safely ignore what is going on in the `msvc` and `VC9` directories ...\r\n\r\nThese changes concern for the most part \"signed vs unsigned\" conflicts, and some minor oddities. See the comments in the latest commit 2af7f0a.\r\n\r\nI still had to introduce some `(unsigned)` casts - the explicitly signed index type for `mark->next` et al and the unsigned counter types for `ctx->n_marks` etc don't mix well.\r\n\r\nThe build with `MD4C_WIN_USE_UNICODE` seems broken right now: in `md4html.c`, pointers to `char` and `MD_CHAR` get mixed up, among similar issues. I don't care about Window's UTF-16 (or is it UCS-2?) flavor of Unicode, so this is fine with me for the time being.\r\n\r\nThank you, and keep up the good work!"},"comment":{"url":"https://api.github.com/repos/mity/md4c/issues/comments/264749560","html_url":"https://github.com/mity/md4c/pull/1#issuecomment-264749560","issue_url":"https://api.github.com/repos/mity/md4c/issues/1","id":264749560,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T01:38:36Z","updated_at":"2016-12-05T01:38:36Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9123997/badge)](https://coveralls.io/builds/9123997)\n\nCoverage decreased (-0.4%) to 91.326% when pulling **2af7f0a9e5c9a9e31eb2198faae21d367e142b71 on tin-pot:master** into **c5fa9a70947e7742876622bb6d7ce0b1252b8d06 on mity:master**.\n"}}
{"actor":{"display_login":"coveralls"}}