{"action":"created","comment":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments/88879326","pull_request_review_id":9437283,"id":88879326,"diff_hunk":"@@ -82,6 +82,9 @@\n    */\n   private static final long BIG_TIFF_CUTOFF = (long) 1024 * 1024 * 3990;\n \n+  /** TIFF tiles must be of a height and width divisible by 16. */","path":"components/formats-bsd/src/loci/formats/out/TiffWriter.java","position":4,"original_position":4,"commit_id":"11f16728bf0730f6fa4007f8d20851a01823c05f","original_commit_id":"11f16728bf0730f6fa4007f8d20851a01823c05f","user":{"login":"rleigh-codelibre","id":9640520,"avatar_url":"https://avatars.githubusercontent.com/u/9640520?v=3","gravatar_id":"","url":"https://api.github.com/users/rleigh-codelibre","html_url":"https://github.com/rleigh-codelibre","followers_url":"https://api.github.com/users/rleigh-codelibre/followers","following_url":"https://api.github.com/users/rleigh-codelibre/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-codelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-codelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-codelibre/subscriptions","organizations_url":"https://api.github.com/users/rleigh-codelibre/orgs","repos_url":"https://api.github.com/users/rleigh-codelibre/repos","events_url":"https://api.github.com/users/rleigh-codelibre/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-codelibre/received_events","type":"User","site_admin":false},"body":"Yes, you're right.  Please ignore this, I was thinking of something else which doesn't have the restriction.","created_at":"2016-11-21T11:53:07Z","updated_at":"2016-11-21T11:53:08Z","html_url":"https://github.com/openmicroscopy/bioformats/pull/2663#discussion_r88879326","pull_request_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments/88879326"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/2663#discussion_r88879326"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663"}}},"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663","id":94146939,"html_url":"https://github.com/openmicroscopy/bioformats/pull/2663","diff_url":"https://github.com/openmicroscopy/bioformats/pull/2663.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/2663.patch","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2663","number":2663,"state":"open","locked":false,"title":"Tiling API and Tiff Writer implementation","user":{"login":"dgault","id":1628865,"avatar_url":"https://avatars.githubusercontent.com/u/1628865?v=3","gravatar_id":"","url":"https://api.github.com/users/dgault","html_url":"https://github.com/dgault","followers_url":"https://api.github.com/users/dgault/followers","following_url":"https://api.github.com/users/dgault/following{/other_user}","gists_url":"https://api.github.com/users/dgault/gists{/gist_id}","starred_url":"https://api.github.com/users/dgault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgault/subscriptions","organizations_url":"https://api.github.com/users/dgault/orgs","repos_url":"https://api.github.com/users/dgault/repos","events_url":"https://api.github.com/users/dgault/events{/privacy}","received_events_url":"https://api.github.com/users/dgault/received_events","type":"User","site_admin":false},"body":"Adds the following new API functions:\r\npublic int getTileSizeX()\r\npublic int getTileSizeY()\r\nint setTileSizeX(int tileSize) throws FormatException\r\nint setTileSizeY(int tileSize) throws FormatException \r\n\r\nThe base implemenattion of these functions will default to full image height and width and return these values when you try to set to any other tiling size.\r\n\r\nAny writer that uses the TiffWriter will have its own implementation which will allow any multiple of 16 to be used as a tile size. If a non multiple of 16 is provided then the tileSize will round to the nearest 16 and return this value to the caller.\r\n\r\nFor the TiffWriter, if a tile size has been set when saveBytes is called then the provided byte array will be written out in tiles of this size.\r\n\r\nFor testing the following combinations of Tiff images should be written out and verify that the tile sizes are correct using \"tiffinfo -s\" (should display for example '3072 Tiles, as opposed to '3072 strips') and verifying that the images display correctly:\r\n\r\n- Single channel, multi time and z frames\r\n- Single channel\r\n- Multi channel interleaved image\r\n- Multi channel non interleaved image\r\n- Varying pixel formats\r\n- Existing tiled image, verify that it can be resaved with different tile size\r\n- Images with height and width which are not a multiple of 16\r\n\r\nUnit test contains framework for using mock writers to allow for unit testing of format writers withoutout outputting large filesets. I have included tests for basic TiffWriter functionality as well as the new API functions included for getting and setting tiling sizes. I have removed the incomplete tests for saveBytes which had been in progress, this functionality could be re-added later or covered with test-suite coverage.","created_at":"2016-11-17T11:11:50Z","updated_at":"2016-11-21T11:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46d074333094d072d991deeff8f110a8a5618fd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2663/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/11f16728bf0730f6fa4007f8d20851a01823c05f","head":{"label":"dgault:tiling-api","ref":"tiling-api","sha":"11f16728bf0730f6fa4007f8d20851a01823c05f","user":{"login":"dgault","id":1628865,"avatar_url":"https://avatars.githubusercontent.com/u/1628865?v=3","gravatar_id":"","url":"https://api.github.com/users/dgault","html_url":"https://github.com/dgault","followers_url":"https://api.github.com/users/dgault/followers","following_url":"https://api.github.com/users/dgault/following{/other_user}","gists_url":"https://api.github.com/users/dgault/gists{/gist_id}","starred_url":"https://api.github.com/users/dgault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgault/subscriptions","organizations_url":"https://api.github.com/users/dgault/orgs","repos_url":"https://api.github.com/users/dgault/repos","events_url":"https://api.github.com/users/dgault/events{/privacy}","received_events_url":"https://api.github.com/users/dgault/received_events","type":"User","site_admin":false},"repo":{"id":42044740,"name":"bioformats","full_name":"dgault/bioformats","owner":{"login":"dgault","id":1628865,"avatar_url":"https://avatars.githubusercontent.com/u/1628865?v=3","gravatar_id":"","url":"https://api.github.com/users/dgault","html_url":"https://github.com/dgault","followers_url":"https://api.github.com/users/dgault/followers","following_url":"https://api.github.com/users/dgault/following{/other_user}","gists_url":"https://api.github.com/users/dgault/gists{/gist_id}","starred_url":"https://api.github.com/users/dgault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgault/subscriptions","organizations_url":"https://api.github.com/users/dgault/orgs","repos_url":"https://api.github.com/users/dgault/repos","events_url":"https://api.github.com/users/dgault/events{/privacy}","received_events_url":"https://api.github.com/users/dgault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgault/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":true,"url":"https://api.github.com/repos/dgault/bioformats","forks_url":"https://api.github.com/repos/dgault/bioformats/forks","keys_url":"https://api.github.com/repos/dgault/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgault/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgault/bioformats/teams","hooks_url":"https://api.github.com/repos/dgault/bioformats/hooks","issue_events_url":"https://api.github.com/repos/dgault/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/dgault/bioformats/events","assignees_url":"https://api.github.com/repos/dgault/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/dgault/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/dgault/bioformats/tags","blobs_url":"https://api.github.com/repos/dgault/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgault/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgault/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgault/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgault/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/dgault/bioformats/languages","stargazers_url":"https://api.github.com/repos/dgault/bioformats/stargazers","contributors_url":"https://api.github.com/repos/dgault/bioformats/contributors","subscribers_url":"https://api.github.com/repos/dgault/bioformats/subscribers","subscription_url":"https://api.github.com/repos/dgault/bioformats/subscription","commits_url":"https://api.github.com/repos/dgault/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgault/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgault/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgault/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgault/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/dgault/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgault/bioformats/merges","archive_url":"https://api.github.com/repos/dgault/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgault/bioformats/downloads","issues_url":"https://api.github.com/repos/dgault/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/dgault/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/dgault/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/dgault/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgault/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/dgault/bioformats/releases{/id}","deployments_url":"https://api.github.com/repos/dgault/bioformats/deployments","created_at":"2015-09-07T09:44:20Z","updated_at":"2015-09-07T09:44:33Z","pushed_at":"2016-11-18T17:06:29Z","git_url":"git://github.com/dgault/bioformats.git","ssh_url":"git@github.com:dgault/bioformats.git","clone_url":"https://github.com/dgault/bioformats.git","svn_url":"https://github.com/dgault/bioformats","homepage":"http://www.openmicroscopy.org/site/products/bio-formats","size":265650,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"7315eaed3a6161faa2c81a73bdb79454b9d01644","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2510503,"name":"bioformats","full_name":"openmicroscopy/bioformats","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly UW-Madison LOCI and Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":false,"url":"https://api.github.com/repos/openmicroscopy/bioformats","forks_url":"https://api.github.com/repos/openmicroscopy/bioformats/forks","keys_url":"https://api.github.com/repos/openmicroscopy/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/bioformats/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/bioformats/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/events","assignees_url":"https://api.github.com/repos/openmicroscopy/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/bioformats/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/bioformats/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/bioformats/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/bioformats/merges","archive_url":"https://api.github.com/repos/openmicroscopy/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/bioformats/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/bioformats/releases{/id}","deployments_url":"https://api.github.com/repos/openmicroscopy/bioformats/deployments","created_at":"2011-10-04T08:06:14Z","updated_at":"2016-11-08T07:55:48Z","pushed_at":"2016-11-21T11:09:45Z","git_url":"git://github.com/openmicroscopy/bioformats.git","ssh_url":"git@github.com:openmicroscopy/bioformats.git","clone_url":"https://github.com/openmicroscopy/bioformats.git","svn_url":"https://github.com/openmicroscopy/bioformats","homepage":"http://www.openmicroscopy.org/site/products/bio-formats","size":291369,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":18,"forks":136,"open_issues":18,"watchers":111,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/2663"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2663"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2663/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2663/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/11f16728bf0730f6fa4007f8d20851a01823c05f"}}}}
{"actor":{"display_login":"rleigh-codelibre"}}