{"action":"closed","number":369,"pull_request":{"url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369","id":74666962,"html_url":"https://github.com/doctrine/DoctrineMongoDBBundle/pull/369","diff_url":"https://github.com/doctrine/DoctrineMongoDBBundle/pull/369.diff","patch_url":"https://github.com/doctrine/DoctrineMongoDBBundle/pull/369.patch","issue_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/369","number":369,"state":"closed","locked":false,"title":"Return the parent return value to keep the proper exit code","user":{"login":"damienalexandre","id":225704,"avatar_url":"https://avatars.githubusercontent.com/u/225704?v=3","gravatar_id":"","url":"https://api.github.com/users/damienalexandre","html_url":"https://github.com/damienalexandre","followers_url":"https://api.github.com/users/damienalexandre/followers","following_url":"https://api.github.com/users/damienalexandre/following{/other_user}","gists_url":"https://api.github.com/users/damienalexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/damienalexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienalexandre/subscriptions","organizations_url":"https://api.github.com/users/damienalexandre/orgs","repos_url":"https://api.github.com/users/damienalexandre/repos","events_url":"https://api.github.com/users/damienalexandre/events{/privacy}","received_events_url":"https://api.github.com/users/damienalexandre/received_events","type":"User","site_admin":false},"body":"I got quit a surprise in my deploy process when I found out the `doctrine:mongodb:schema:update` was always returning a success error code even when everything went wrong.\r\nFor exemple sometimes creating an index on a huge collection can reach my socket timeout ; so the indexes are deleted, not re-created, and I go live with a Mongo server going full CPU because some indexes are missing. \r\n\r\nLong story short, the issue is only in this bundle code. ODM return 255 when something goes bad: https://github.com/doctrine/mongodb-odm/blob/72ea5c74e7e4df6f22de14e8af71927db5110ae4/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/UpdateCommand.php#L69 but this bundle does not always return the parent return value: https://github.com/doctrine/DoctrineMongoDBBundle/blob/97ac93c6058d53eb1dd59a1c296bbc8c94ea4d4b/Command/UpdateSchemaDoctrineODMCommand.php#L48\r\n\r\nThe PR fix that for all commands where the return was missing.","created_at":"2016-06-21T19:00:38Z","updated_at":"2016-06-21T19:24:06Z","closed_at":"2016-06-21T19:24:06Z","merged_at":"2016-06-21T19:24:06Z","merge_commit_sha":"6b8c376fe002611bffce19418b82c8fd228e3928","assignee":null,"milestone":{"url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/milestones/7","html_url":"https://github.com/doctrine/DoctrineMongoDBBundle/milestones/3.2","labels_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/milestones/7/labels","id":1696028,"number":7,"title":"3.2","description":null,"creator":{"login":"malarzm","id":4947711,"avatar_url":"https://avatars.githubusercontent.com/u/4947711?v=3","gravatar_id":"","url":"https://api.github.com/users/malarzm","html_url":"https://github.com/malarzm","followers_url":"https://api.github.com/users/malarzm/followers","following_url":"https://api.github.com/users/malarzm/following{/other_user}","gists_url":"https://api.github.com/users/malarzm/gists{/gist_id}","starred_url":"https://api.github.com/users/malarzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malarzm/subscriptions","organizations_url":"https://api.github.com/users/malarzm/orgs","repos_url":"https://api.github.com/users/malarzm/repos","events_url":"https://api.github.com/users/malarzm/events{/privacy}","received_events_url":"https://api.github.com/users/malarzm/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2016-04-10T15:00:58Z","updated_at":"2016-06-21T19:24:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369/commits","review_comments_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369/comments","review_comment_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/369/comments","statuses_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/statuses/746e74a13946a9a252a823b0730ccca126f8d01c","head":{"label":"damienalexandre:returnExitCode","ref":"returnExitCode","sha":"746e74a13946a9a252a823b0730ccca126f8d01c","user":{"login":"damienalexandre","id":225704,"avatar_url":"https://avatars.githubusercontent.com/u/225704?v=3","gravatar_id":"","url":"https://api.github.com/users/damienalexandre","html_url":"https://github.com/damienalexandre","followers_url":"https://api.github.com/users/damienalexandre/followers","following_url":"https://api.github.com/users/damienalexandre/following{/other_user}","gists_url":"https://api.github.com/users/damienalexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/damienalexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienalexandre/subscriptions","organizations_url":"https://api.github.com/users/damienalexandre/orgs","repos_url":"https://api.github.com/users/damienalexandre/repos","events_url":"https://api.github.com/users/damienalexandre/events{/privacy}","received_events_url":"https://api.github.com/users/damienalexandre/received_events","type":"User","site_admin":false},"repo":{"id":61658854,"name":"DoctrineMongoDBBundle","full_name":"damienalexandre/DoctrineMongoDBBundle","owner":{"login":"damienalexandre","id":225704,"avatar_url":"https://avatars.githubusercontent.com/u/225704?v=3","gravatar_id":"","url":"https://api.github.com/users/damienalexandre","html_url":"https://github.com/damienalexandre","followers_url":"https://api.github.com/users/damienalexandre/followers","following_url":"https://api.github.com/users/damienalexandre/following{/other_user}","gists_url":"https://api.github.com/users/damienalexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/damienalexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienalexandre/subscriptions","organizations_url":"https://api.github.com/users/damienalexandre/orgs","repos_url":"https://api.github.com/users/damienalexandre/repos","events_url":"https://api.github.com/users/damienalexandre/events{/privacy}","received_events_url":"https://api.github.com/users/damienalexandre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damienalexandre/DoctrineMongoDBBundle","description":"Integrates Doctrine MongoDB ODM with Symfony2","fork":true,"url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle","forks_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/forks","keys_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/teams","hooks_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/hooks","issue_events_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/issues/events{/number}","events_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/events","assignees_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/assignees{/user}","branches_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/branches{/branch}","tags_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/tags","blobs_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/languages","stargazers_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/stargazers","contributors_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/contributors","subscribers_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/subscribers","subscription_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/subscription","commits_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/contents/{+path}","compare_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/merges","archive_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/downloads","issues_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/issues{/number}","pulls_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/labels{/name}","releases_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/releases{/id}","deployments_url":"https://api.github.com/repos/damienalexandre/DoctrineMongoDBBundle/deployments","created_at":"2016-06-21T18:51:27Z","updated_at":"2016-06-21T18:51:28Z","pushed_at":"2016-06-21T18:54:23Z","git_url":"git://github.com/damienalexandre/DoctrineMongoDBBundle.git","ssh_url":"git@github.com:damienalexandre/DoctrineMongoDBBundle.git","clone_url":"https://github.com/damienalexandre/DoctrineMongoDBBundle.git","svn_url":"https://github.com/damienalexandre/DoctrineMongoDBBundle","homepage":"http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html","size":961,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"97ac93c6058d53eb1dd59a1c296bbc8c94ea4d4b","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":1647240,"name":"DoctrineMongoDBBundle","full_name":"doctrine/DoctrineMongoDBBundle","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/DoctrineMongoDBBundle","description":"Integrates Doctrine MongoDB ODM with Symfony2","fork":false,"url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle","forks_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/forks","keys_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/teams","hooks_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/hooks","issue_events_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/events","assignees_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/tags","blobs_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/languages","stargazers_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/stargazers","contributors_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/contributors","subscribers_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/subscribers","subscription_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/subscription","commits_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/merges","archive_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/downloads","issues_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/deployments","created_at":"2011-04-21T21:01:02Z","updated_at":"2016-04-26T19:37:27Z","pushed_at":"2016-06-21T19:24:06Z","git_url":"git://github.com/doctrine/DoctrineMongoDBBundle.git","ssh_url":"git@github.com:doctrine/DoctrineMongoDBBundle.git","clone_url":"https://github.com/doctrine/DoctrineMongoDBBundle.git","svn_url":"https://github.com/doctrine/DoctrineMongoDBBundle","homepage":"http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html","size":1500,"stargazers_count":188,"watchers_count":188,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":19,"forks":136,"open_issues":19,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369"},"html":{"href":"https://github.com/doctrine/DoctrineMongoDBBundle/pull/369"},"issue":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/369"},"comments":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/DoctrineMongoDBBundle/statuses/746e74a13946a9a252a823b0730ccca126f8d01c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"malarzm","id":4947711,"avatar_url":"https://avatars.githubusercontent.com/u/4947711?v=3","gravatar_id":"","url":"https://api.github.com/users/malarzm","html_url":"https://github.com/malarzm","followers_url":"https://api.github.com/users/malarzm/followers","following_url":"https://api.github.com/users/malarzm/following{/other_user}","gists_url":"https://api.github.com/users/malarzm/gists{/gist_id}","starred_url":"https://api.github.com/users/malarzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malarzm/subscriptions","organizations_url":"https://api.github.com/users/malarzm/orgs","repos_url":"https://api.github.com/users/malarzm/repos","events_url":"https://api.github.com/users/malarzm/events{/privacy}","received_events_url":"https://api.github.com/users/malarzm/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"malarzm"}}