{"comment":{"url":"https://api.github.com/repos/iyanuobidele/spark/comments/20204388","html_url":"https://github.com/iyanuobidele/spark/commit/529907af8cc046c023e658c8f0efd132505d4a64#commitcomment-20204388","id":20204388,"user":{"login":"jainh","id":10890082,"avatar_url":"https://avatars.githubusercontent.com/u/10890082?v=3","gravatar_id":"","url":"https://api.github.com/users/jainh","html_url":"https://github.com/jainh","followers_url":"https://api.github.com/users/jainh/followers","following_url":"https://api.github.com/users/jainh/following{/other_user}","gists_url":"https://api.github.com/users/jainh/gists{/gist_id}","starred_url":"https://api.github.com/users/jainh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainh/subscriptions","organizations_url":"https://api.github.com/users/jainh/orgs","repos_url":"https://api.github.com/users/jainh/repos","events_url":"https://api.github.com/users/jainh/events{/privacy}","received_events_url":"https://api.github.com/users/jainh/received_events","type":"User","site_admin":false},"position":102,"line":195,"path":"resource-managers/kubernetes/src/main/scala/org/apache/spark/deploy/kubernetes/SparkJobResource.scala","commit_id":"529907af8cc046c023e658c8f0efd132505d4a64","created_at":"2016-12-15T18:22:04Z","updated_at":"2016-12-15T18:22:04Z","body":"Should use separate threadpool or dispatcher for blocking I/O something this line\r\n\r\n```\r\ndef executeBlockingIO[T](cb: => T): Future[T] = {\r\n  val p = Promise[T]()\r\n\r\n  ioThreadPool.execute(new Runnable {\r\n    def run() = try {\r\n      p.success(blocking(cb))\r\n    }\r\n    catch {\r\n      case NonFatal(ex) =>\r\n        logger.error(s\"Uncaught I/O exception\", ex)\r\n        p.failure(ex)\r\n    }\r\n  })\r\n\r\n  p.future\r\n}\r\n```"}}
{"actor":{"display_login":"jainh"}}