{"push_id":1124628828,"size":18,"distinct_size":1,"ref":"refs/heads/feature/ndt","head":"8e07d1a9329f68ad9139b35cbfa70acca5f054a5","before":"abef51ef6fa5defb078e9c81266eb4bc005150bd","commits":[{"sha":"d835fd49378bf82e749f1e732fd867a66879880c","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"error: improve usability and add regress tests (#621)","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/d835fd49378bf82e749f1e732fd867a66879880c"},{"sha":"b9d795bad41757d166283a016c278d7cfeddeeb0","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Revert \"configure: add -pthread to flags only when needed (#607)\" (#622)\n\nThis reverts commit 6ceb9e875741b1cd18f92cf520a6e9ab82e749d8 because it\r\nwas the wrong way to address the issue, unfortunately.\r\n\r\nThe warning was still present. Then, I further investigated and understood\r\nthat the way in which clang for OSX deals with -pthread is different from the\r\nway in which the same flag is dealt with on Linux systems.\r\n\r\nGiven than the matter is more complex than I thought and that the warning\r\nfor the -pthread flag only provides some annoyance, I am reverting to before\r\npull request #607. We will perhaps give another stab at it, but for now\r\nlet's ignore the problem, because it's not so important.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/b9d795bad41757d166283a016c278d7cfeddeeb0"},{"sha":"ed0d60e2707e5df86178e5fb48683b2845050e65","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"OONI errors now public and deriving from Error (#623)\n\nThis diff changes the way in which we declare OONI errors such that\r\nnow they are in public headers and they derive from `Error`.\r\n\r\nThis is a preparatory change for tackling #614, when we will need\r\nto delay emitting errors related to missing/empty/invalid files.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/ed0d60e2707e5df86178e5fb48683b2845050e65"},{"sha":"a200404135e1d13b029f2c820d2608c604ee2a24","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"validate_input_filepath() doesn't need arguments (#624)\n\n* validate_input_filepath() doesn't need arguments\r\n\r\nSince it is a class method that shall operate on the attribute\r\ncalled `input_filepath_`, so need to pass such attribute explicitly\r\nas argument, since it can already access it using `this`.\r\n\r\n* fix previous","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/a200404135e1d13b029f2c820d2608c604ee2a24"},{"sha":"2605f803de90957759eb6239933b2b7e049799a3","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Cleanup report implementation (#625)\n\n0) recognize that it's not easily possible to make the report public\r\n   without adding nlohmann/json to the public API [*]\r\n\r\n1) give headers private include guards since they are private\r\n\r\n2) rename writeEntry as write_entry for consistency\r\n\r\n[*] This does not appear in the diff. But think about the changes you do\r\nnot see in this diff. They are because of that.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/2605f803de90957759eb6239933b2b7e049799a3"},{"sha":"6c63504b2e4841cde8cb4077f1c01fd846cbfe56","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Fix compiler warnings (#626)","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/6c63504b2e4841cde8cb4077f1c01fd846cbfe56"},{"sha":"516c0bd74290040d1f46eda1e31f079f68cffdec","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Error: do not call reason `ooni_error` (#629)\n\nOkay, currently we have the reason which is equal to `ooni_error` but\r\nthat would not necessarily be the case in future.\r\n\r\nSo, leave `as_ooni_error()` as the preferred way to know the OONI error\r\nstring and use `reason` (more neutral) for the attribute.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/516c0bd74290040d1f46eda1e31f079f68cffdec"},{"sha":"735a000d2583b23720c9c4f50f7ee13ef42caa62","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Delegate: add syntactic sugar (#628)\n\n* Delegate: add syntactic sugar\r\n\r\n* Fix previous","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/735a000d2583b23720c9c4f50f7ee13ef42caa62"},{"sha":"3ab2c8b871749f56fe4f65345b514d9a686c318b","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"error_or: remove unused constructors (#630)\n\nThe empty constructor and the constructor with both error and value are\r\nboth scarcely if not used. Hence, remove them.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/3ab2c8b871749f56fe4f65345b514d9a686c318b"},{"sha":"d4d9306139d5eb220668fe10c3273bcaded96498","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Start updating documentation for common (#631)\n\n* Create callback.md\r\n\r\n* Update callback.md\r\n\r\n* Update callback.md\r\n\r\n* Update callback.md\r\n\r\n* Update callback.md\r\n\r\n* Update callback.md\r\n\r\n* Create continuation.md\r\n\r\n* Update callback.md\r\n\r\n* Update continuation.md\r\n\r\n* Update continuation.md\r\n\r\n* Update callback.md\r\n\r\n* Rename async.md to runner.md\r\n\r\n* Rename constraints.md to non_copyable.md\r\n\r\n* Update continuation.md\r\n\r\n* Create delegate.md\r\n\r\n* Update delegate.md\r\n\r\n* Update delegate.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Update error.md\r\n\r\n* Create error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Update error_or.md\r\n\r\n* Create lexical_cast.md\r\n\r\n* Delete libs.md\r\n\r\n* Update error.md","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/d4d9306139d5eb220668fe10c3273bcaded96498"},{"sha":"56493f23136a6ef963562dcd45d7667fdb88b5dc","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"http: start cleanup by removing doxygen style docs (#632)\n\nI have experimented a bit with doxygen but increasingly feel like\r\nit adds noise to the signal / noise ratio.\r\n\r\nI'd rather spend time to maintain documentation in `doc/`.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/56493f23136a6ef963562dcd45d7667fdb88b5dc"},{"sha":"abe820758073245ebd56fc63cf1762123561378e","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Continue cleanup removing unneeded typedefs (#633)","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/abe820758073245ebd56fc63cf1762123561378e"},{"sha":"0a975e9a562ef8245cf8779e2042b1776390b454","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"merge http/client.cpp into http/request.cpp (#634)","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/0a975e9a562ef8245cf8779e2042b1776390b454"},{"sha":"d7b7e577c7c58183ca8cf0592f687c88d62929b0","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"http: reimplement request() using request_cycle() (#635)\n\n* http: reimplement request() using request_cycle()\r\n\r\n* Fix regress","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/d7b7e577c7c58183ca8cf0592f687c88d62929b0"},{"sha":"c93271d81311a5dd5cc9bcba22e4d4982eed34b3","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"http: make sure reactor argument is before logger (#636)\n\nFrom the #consistency dept. Another diff is due to make sure\r\nthe same holds in net. But not now.","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/c93271d81311a5dd5cc9bcba22e4d4982eed34b3"},{"sha":"df99b6bd1491aee0ac8d9532cdd4fefaf6113c8d","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"http: reduce variety of available APIs (#637)\n\n* http: reduce variaty of available APIs\r\n\r\n* Fix regress","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/df99b6bd1491aee0ac8d9532cdd4fefaf6113c8d"},{"sha":"7bd6424a22b7536cc49ee29e69dc3e00ac3f45bb","author":{"email":"f29ad1c43d6e24ab863bcf5eb886cdeef200167f@gmail.com","name":"Simone Basso"},"message":"Implement entry as private child of nlohmann::json (#627)\n\n* Implement entry as private child of nlohmann::json\r\n\r\nWe already discussed in the past that we would not like to expose\r\ndirectly nlohmann::json as part of our API, because it would be\r\nunpractical to bind us (and other users) so tightly do a dependency.\r\n\r\nYet, for exporting src/report headers, as well as for passing tests\r\nresults in a manipulable format to users, it would be nice to have\r\na type describing an entry.\r\n\r\nAt the same time, writing such type from scratch is not easy and\r\nmocking nlohmann/json without exposing it is overcomplicated, since\r\nin the latter case you need to do magic and use Var<T>.\r\n\r\nThus, I've come to the conclusion that it would be acceptable to\r\ninclude nlohmann/json to our public headers and to use it to implement\r\nthe entry type by means of private inheritance.\r\n\r\nThis way, consumers of our API use our interface for accessing an\r\nentry, which currently happens to be based on nlohmann/json but in\r\nthe future could possibly be based on any other JSON library.\r\n\r\n* More accurate regress tests\r\n\r\n* Stop auto-fetching nlohmann/json since it's committed\r\n\r\nSuggested by @hellais, thanks!\r\n\r\n* Fix previous","distinct":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/7bd6424a22b7536cc49ee29e69dc3e00ac3f45bb"},{"sha":"8e07d1a9329f68ad9139b35cbfa70acca5f054a5","author":{"email":"e8bc682de39f8160e26870ce75968bfd56ccc87b@filasto.net","name":"Arturo Filastò"},"message":"Merge branch 'master' into feature/ndt","distinct":true,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits/8e07d1a9329f68ad9139b35cbfa70acca5f054a5"}]}
{"actor":{"display_login":"hellais"}}