{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civihr/issues/1003","repository_url":"https://api.github.com/repos/civicrm/civihr","labels_url":"https://api.github.com/repos/civicrm/civihr/issues/1003/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civihr/issues/1003/comments","events_url":"https://api.github.com/repos/civicrm/civihr/issues/1003/events","html_url":"https://github.com/civicrm/civihr/pull/1003","id":163947593,"number":1003,"title":"PCHR-1062: Improvements to the Add/Edit Job Contract modal","user":{"login":"davialexandre","id":388373,"avatar_url":"https://avatars.githubusercontent.com/u/388373?v=3","gravatar_id":"","url":"https://api.github.com/users/davialexandre","html_url":"https://github.com/davialexandre","followers_url":"https://api.github.com/users/davialexandre/followers","following_url":"https://api.github.com/users/davialexandre/following{/other_user}","gists_url":"https://api.github.com/users/davialexandre/gists{/gist_id}","starred_url":"https://api.github.com/users/davialexandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davialexandre/subscriptions","organizations_url":"https://api.github.com/users/davialexandre/orgs","repos_url":"https://api.github.com/users/davialexandre/repos","events_url":"https://api.github.com/users/davialexandre/events{/privacy}","received_events_url":"https://api.github.com/users/davialexandre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-05T21:09:45Z","updated_at":"2016-07-06T13:06:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/1003","html_url":"https://github.com/civicrm/civihr/pull/1003","diff_url":"https://github.com/civicrm/civihr/pull/1003.diff","patch_url":"https://github.com/civicrm/civihr/pull/1003.patch"},"body":"This modal was updated to reflect the changes introduced by the new\r\nLeave and Absences extension:\r\n\r\n- The list of Leave types is now populated with data from the new\r\nAbsenceType entity\r\n- When adding a new Contract, the form shows the default entitlement\r\nand if the AbsenceType requires public holidays to be added to the\r\nentitlement\r\n- It's now possible to set in the modal if the entitlement for a specific\r\ncontract will include public holidays\r\n- Only one leave entitlement should have \"Add public holidays\" set\r\n\r\nThis is the screen before the changes:\r\n![captura de tela 2016-07-05 as 18 05 07](https://cloud.githubusercontent.com/assets/388373/16599948/305ec1d6-42db-11e6-9132-e97302803400.png)\r\n\r\nThis is the screen after the changes:\r\n![captura de tela 2016-07-05 as 18 06 35](https://cloud.githubusercontent.com/assets/388373/16599967/4550dcc8-42db-11e6-91fc-404f1d8ee9da.png)\r\n\r\nHere you can see how only one type can have \"Add Public Holidays\" set and how the \"Estimated Leave Entitlement\"  is updated to include/remove the number of public holidays accordingly:\r\n![job_contract](https://cloud.githubusercontent.com/assets/388373/16600020/94f86db8-42db-11e6-97ce-691679b47ed7.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civihr/issues/comments/230765431","html_url":"https://github.com/civicrm/civihr/pull/1003#issuecomment-230765431","issue_url":"https://api.github.com/repos/civicrm/civihr/issues/1003","id":230765431,"user":{"login":"AkA84","id":6400898,"avatar_url":"https://avatars.githubusercontent.com/u/6400898?v=3","gravatar_id":"","url":"https://api.github.com/users/AkA84","html_url":"https://github.com/AkA84","followers_url":"https://api.github.com/users/AkA84/followers","following_url":"https://api.github.com/users/AkA84/following{/other_user}","gists_url":"https://api.github.com/users/AkA84/gists{/gist_id}","starred_url":"https://api.github.com/users/AkA84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkA84/subscriptions","organizations_url":"https://api.github.com/users/AkA84/orgs","repos_url":"https://api.github.com/users/AkA84/repos","events_url":"https://api.github.com/users/AkA84/events{/privacy}","received_events_url":"https://api.github.com/users/AkA84/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T13:06:40Z","updated_at":"2016-07-06T13:06:40Z","body":"What about when editing an already existing contract? Is that scenario covered in this PR?"}}
{"actor":{"display_login":"AkA84"}}