{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/7516","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/7516/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7516/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/7516/events","html_url":"https://github.com/eslint/eslint/pull/7516","id":186660599,"number":7516,"title":"WIP - Breaking: Calculate leading/trailing comments in sourceCode.getComments()","user":{"login":"kaicataldo","id":7041728,"avatar_url":"https://avatars.githubusercontent.com/u/7041728?v=3","gravatar_id":"","url":"https://api.github.com/users/kaicataldo","html_url":"https://github.com/kaicataldo","followers_url":"https://api.github.com/users/kaicataldo/followers","following_url":"https://api.github.com/users/kaicataldo/following{/other_user}","gists_url":"https://api.github.com/users/kaicataldo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaicataldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaicataldo/subscriptions","organizations_url":"https://api.github.com/users/kaicataldo/orgs","repos_url":"https://api.github.com/users/kaicataldo/repos","events_url":"https://api.github.com/users/kaicataldo/events{/privacy}","received_events_url":"https://api.github.com/users/kaicataldo/received_events","type":"User","site_admin":false},"labels":[{"id":131106229,"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc","default":false},{"id":185518888,"url":"https://api.github.com/repos/eslint/eslint/labels/breaking","name":"breaking","color":"e11d21","default":false},{"id":82922548,"url":"https://api.github.com/repos/eslint/eslint/labels/core","name":"core","color":"c7def8","default":false},{"id":261840582,"url":"https://api.github.com/repos/eslint/eslint/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false},{"id":45711352,"url":"https://api.github.com/repos/eslint/eslint/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-01T22:03:35Z","updated_at":"2016-11-01T22:55:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/7516","html_url":"https://github.com/eslint/eslint/pull/7516","diff_url":"https://github.com/eslint/eslint/pull/7516.diff","patch_url":"https://github.com/eslint/eslint/pull/7516.patch"},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[X] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n<!--\r\n    Please ensure your pull request is ready:\r\n\r\n    - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n    - Include tests for this change\r\n    - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n    The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\nThis PR turns off comment attachment in Espree and moves comment getting logic into `sourceCode.getComments()`. This is a breaking change.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nWould love suggestions for how else we might be able to handle shebang comments.\r\n\r\nAs discussed on the [corresponding issue](https://github.com/eslint/eslint/issues/6724), we should discuss if we want to continue thinking about comments the same way now that we're not attaching at the parser level. This PR mimics the current attachment strategy in Espree as close as it can, though it's not possible (nor do I think we want it to be) exactly the same as it is in Espree, because there are some unpredictable edge cases and bugs in that.\r\n\r\nThe version in this PR should essentially work the same for our users and ecosystem (unless they rely on some of the really weird edge cases mentioned before).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/257723577","html_url":"https://github.com/eslint/eslint/pull/7516#issuecomment-257723577","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7516","id":257723577,"user":{"login":"eslintbot","id":13383618,"avatar_url":"https://avatars.githubusercontent.com/u/13383618?v=3","gravatar_id":"","url":"https://api.github.com/users/eslintbot","html_url":"https://github.com/eslintbot","followers_url":"https://api.github.com/users/eslintbot/followers","following_url":"https://api.github.com/users/eslintbot/following{/other_user}","gists_url":"https://api.github.com/users/eslintbot/gists{/gist_id}","starred_url":"https://api.github.com/users/eslintbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslintbot/subscriptions","organizations_url":"https://api.github.com/users/eslintbot/orgs","repos_url":"https://api.github.com/users/eslintbot/repos","events_url":"https://api.github.com/users/eslintbot/events{/privacy}","received_events_url":"https://api.github.com/users/eslintbot/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T22:55:12Z","updated_at":"2016-11-01T22:55:12Z","body":"Thanks for the pull request, @kaicataldo! I took a look to make sure it's ready for merging and found some changes are needed:\n\n\n* The commit summary needs to begin with a tag (such as `Fix:` or `Update:`). Please check out our [guide](http://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes) for how to properly format your commit summary and [update](http://eslint.org/docs/developer-guide/contributing/pull-requests#updating-the-commit-message) it on this pull request.\n\n\nCan you please update the pull request to address these?\n\n(More information can be found in our [pull request guide](http://eslint.org/docs/developer-guide/contributing/pull-requests).)"}}
{"actor":{"display_login":"eslintbot"}}