{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15934","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15934/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15934/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15934/events","html_url":"https://github.com/mantidproject/mantid/pull/15934","id":149450517,"number":15934,"title":"Dereference tcmalloc symlink at build time","user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":593,"closed_issues":579,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-04-20T07:37:49Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":0,"created_at":"2016-04-19T12:44:55Z","updated_at":"2016-04-20T07:48:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15934","html_url":"https://github.com/mantidproject/mantid/pull/15934","diff_url":"https://github.com/mantidproject/mantid/pull/15934.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15934.patch"},"body":"This changes the launch scripts for Linux systems so that the `tcmalloc` library is found at build time. This removes the requirement that the plain `.so` symlink be present on the user system as this is only installed with the `-dev` or `-devel` packages.\r\n\r\n**To test:**\r\n\r\nRun cmake and check the contents of both `bin/launch_mantidplot.sh` & `bin/mantidpython`. The LD_PRELOAD line should point a versioned tcmalloc library that exists on the system \r\n\r\n*Does not need to be in the release notes.*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/212306939","html_url":"https://github.com/mantidproject/mantid/pull/15934#issuecomment-212306939","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15934","id":212306939,"user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T07:48:51Z","updated_at":"2016-04-20T07:48:51Z","body":"The `pylint` error was an error on the node and not on the code."}}