{"action":"created","comment":{"url":"https://api.github.com/repos/ushahidi/platform/pulls/comments/58318489","id":58318489,"diff_hunk":"@@ -28,6 +28,33 @@ Feature: Testing OAuth2 endpoints\n         And the \"error_description\" property contains \"credentials\"\n         Then the guzzle status code should be 400\n \n+    Scenario: Requesting access token with password where 2fa required without authentication code","path":"application/tests/features/api.oauth.feature","position":4,"original_position":4,"commit_id":"b58d9b9a1efae0e67135cdba00db1c8afcc01fbd","original_commit_id":"b58d9b9a1efae0e67135cdba00db1c8afcc01fbd","user":{"login":"willdoran","id":2694405,"avatar_url":"https://avatars.githubusercontent.com/u/2694405?v=3","gravatar_id":"","url":"https://api.github.com/users/willdoran","html_url":"https://github.com/willdoran","followers_url":"https://api.github.com/users/willdoran/followers","following_url":"https://api.github.com/users/willdoran/following{/other_user}","gists_url":"https://api.github.com/users/willdoran/gists{/gist_id}","starred_url":"https://api.github.com/users/willdoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdoran/subscriptions","organizations_url":"https://api.github.com/users/willdoran/orgs","repos_url":"https://api.github.com/users/willdoran/repos","events_url":"https://api.github.com/users/willdoran/events{/privacy}","received_events_url":"https://api.github.com/users/willdoran/received_events","type":"User","site_admin":false},"body":"Yep!","created_at":"2016-04-03T22:06:44Z","updated_at":"2016-04-03T22:06:44Z","html_url":"https://github.com/ushahidi/platform/pull/1001#discussion_r58318489","pull_request_url":"https://api.github.com/repos/ushahidi/platform/pulls/1001","_links":{"self":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/comments/58318489"},"html":{"href":"https://github.com/ushahidi/platform/pull/1001#discussion_r58318489"},"pull_request":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/1001"}}},"pull_request":{"url":"https://api.github.com/repos/ushahidi/platform/pulls/1001","id":65075192,"html_url":"https://github.com/ushahidi/platform/pull/1001","diff_url":"https://github.com/ushahidi/platform/pull/1001.diff","patch_url":"https://github.com/ushahidi/platform/pull/1001.patch","issue_url":"https://api.github.com/repos/ushahidi/platform/issues/1001","number":1001,"state":"open","locked":false,"title":"Feature/2fa","user":{"login":"willdoran","id":2694405,"avatar_url":"https://avatars.githubusercontent.com/u/2694405?v=3","gravatar_id":"","url":"https://api.github.com/users/willdoran","html_url":"https://github.com/willdoran","followers_url":"https://api.github.com/users/willdoran/followers","following_url":"https://api.github.com/users/willdoran/following{/other_user}","gists_url":"https://api.github.com/users/willdoran/gists{/gist_id}","starred_url":"https://api.github.com/users/willdoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdoran/subscriptions","organizations_url":"https://api.github.com/users/willdoran/orgs","repos_url":"https://api.github.com/users/willdoran/repos","events_url":"https://api.github.com/users/willdoran/events{/privacy}","received_events_url":"https://api.github.com/users/willdoran/received_events","type":"User","site_admin":false},"body":"This pull request makes the following changes:\r\n- Adds two factor authentication via google authenticator one time passwords\r\n- Provides a means to enable/disable 2fa\r\n- Verifies 2fa setup\r\n- Verifies 2fa verification\r\n\r\nTest these changes by:\r\n-Via 2fa features\r\n...to be expanded\r\n\r\nFixes ushahidi/platform# .\r\n\r\nPing @ushahidi/platform\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ushahidi/platform/1001)\n<!-- Reviewable:end -->\n","created_at":"2016-04-03T17:55:21Z","updated_at":"2016-04-03T22:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ddcb9265599ab93d26686d2d7737aabbfb1f04f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ushahidi/platform/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/ushahidi/platform/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/ushahidi/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ushahidi/platform/issues/1001/comments","statuses_url":"https://api.github.com/repos/ushahidi/platform/statuses/b58d9b9a1efae0e67135cdba00db1c8afcc01fbd","head":{"label":"ushahidi:feature/2fa","ref":"feature/2fa","sha":"b58d9b9a1efae0e67135cdba00db1c8afcc01fbd","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":6126775,"name":"platform","full_name":"ushahidi/platform","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform","description":"Ushahidi Platform v3 API","fork":false,"url":"https://api.github.com/repos/ushahidi/platform","forks_url":"https://api.github.com/repos/ushahidi/platform/forks","keys_url":"https://api.github.com/repos/ushahidi/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform/events","assignees_url":"https://api.github.com/repos/ushahidi/platform/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform/merges","archive_url":"https://api.github.com/repos/ushahidi/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform/releases{/id}","deployments_url":"https://api.github.com/repos/ushahidi/platform/deployments","created_at":"2012-10-08T15:40:14Z","updated_at":"2016-04-01T13:39:52Z","pushed_at":"2016-04-03T22:02:50Z","git_url":"git://github.com/ushahidi/platform.git","ssh_url":"git@github.com:ushahidi/platform.git","clone_url":"https://github.com/ushahidi/platform.git","svn_url":"https://github.com/ushahidi/platform","homepage":"http://ushahidi.com","size":22589,"stargazers_count":201,"watchers_count":201,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":338,"forks":140,"open_issues":338,"watchers":201,"default_branch":"master"}},"base":{"label":"ushahidi:master","ref":"master","sha":"5a3f2ec7e285cbb3a32ae7308ccab2d0dc7430e6","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":6126775,"name":"platform","full_name":"ushahidi/platform","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform","description":"Ushahidi Platform v3 API","fork":false,"url":"https://api.github.com/repos/ushahidi/platform","forks_url":"https://api.github.com/repos/ushahidi/platform/forks","keys_url":"https://api.github.com/repos/ushahidi/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform/events","assignees_url":"https://api.github.com/repos/ushahidi/platform/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform/merges","archive_url":"https://api.github.com/repos/ushahidi/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform/releases{/id}","deployments_url":"https://api.github.com/repos/ushahidi/platform/deployments","created_at":"2012-10-08T15:40:14Z","updated_at":"2016-04-01T13:39:52Z","pushed_at":"2016-04-03T22:02:50Z","git_url":"git://github.com/ushahidi/platform.git","ssh_url":"git@github.com:ushahidi/platform.git","clone_url":"https://github.com/ushahidi/platform.git","svn_url":"https://github.com/ushahidi/platform","homepage":"http://ushahidi.com","size":22589,"stargazers_count":201,"watchers_count":201,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":338,"forks":140,"open_issues":338,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/1001"},"html":{"href":"https://github.com/ushahidi/platform/pull/1001"},"issue":{"href":"https://api.github.com/repos/ushahidi/platform/issues/1001"},"comments":{"href":"https://api.github.com/repos/ushahidi/platform/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ushahidi/platform/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/ushahidi/platform/statuses/b58d9b9a1efae0e67135cdba00db1c8afcc01fbd"}}}}