{"push_id":1205074688,"size":7,"distinct_size":7,"ref":"refs/heads/master","head":"e465d1aa4b16d7392950b2b682f99eb0c58c1ffd","before":"e75d9befca13c2f74706e5eb7874a27bdc1928f1","commits":[{"sha":"4f0fd3db556652f961710c64b9806512a491a7d3","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Drop raw connection if login fails\n\nraw_connection was not behaving correctly if an invalid string was\npassed or a login failed.\nIt was not checking that the login succeeded ( it checked that account\nexisted not that it contained data and it existed even if login failed)\nand so failed logins instead of aborting immediately fell through into\nthe sip_protocol_loop, forcing that to timeout invalid connections.\nIt now checks that account has id set and returns if not.\n\nThe timeout alarm is now set on the while loop, in normal running this\nshould not be triggered as the socket is opened and the first data\nshould be a login message and the while loop should only iterate once,\nbut lets not go into an infinite loop due to unforeseen circumstances.\n\nI have reindented the routine as the flow was not clear (the while was\nnot indented at all.\n\nAlso if using Net::Server::PreFork when a new connection comes in you\nmay be handed the the successful login parameters from a preceding call.\nBecause of this you could successfully transmit transactions and Koha\nwould carry them out without having received a valid login ( and\npossibly with the wrong account details!) We now delete any existing\naccount for new connections.\n\nNB: This patch requires that the patch for bug 13807 has been applied\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/4f0fd3db556652f961710c64b9806512a491a7d3"},{"sha":"2b725b6728ea4156562aa6225b2323861f616885","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Remove tabs from sip_protocol_loop\n\nRemove the tabs causing inconsistent indentation\nof sip_protocol_loop and replace with spaces\n\nReimplements the renaining parts of Marcel de Rooy's\noriginal QA patch\n\nNo logic changes in this patch - layout only\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/2b725b6728ea4156562aa6225b2323861f616885"},{"sha":"b27da7e0ce25c806612743100609255ace48257c","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006: Introduce client_timeout in SIPconfig.xml\n\nMost selfchecks have persistent connections and send a\nperiodic status request at intervals (approx every 5mins appears\nthe norm) The timeout was dropping connections by default every 30secs\nwhich for the client appears as a very flakey network.\n\nThis patch adds a separate parameter client_timeout that can be\nused if you do want to force a disconnect if the client sends\nno requests for a period. The sample config sets it to 600, but you\ncan also define a 0 value meaning no timeout. If the parameter is not\ndefined, it will fallback to service timeout.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nRestored this patch from Colin in order to separate it from the\nget_timeout patch. Adjusted the commit message slightly.\nThe original value of 600 from Colin's earlier patch may give less\ndiscussion than setting to 0 (no timeout) in a later proposal.\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/b27da7e0ce25c806612743100609255ace48257c"},{"sha":"eb8666357ce72e910569843f8acce674a332f4b0","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: Centralize timeout logic and allow zero client timeout\n\nMoving timeout logic to one routine (with unit test).\n\nThis further implements two suggestions from Kyle and Larry:\n\n[1] You could use a client_timeout of 0 to specify no timeout at all.\n[2] Have the client_timeout default to the timeout if not defined.\n\nTest plan:\n[1] Run t/db_dependent/SIP/SIPServer.t.\n[2] Test login timeout for raw and telnet.\n[3] Check ACS status message for timeout value. Should match policy\n    timeout from institution.\n[4] Test client timeout (zero and non-zero).\n[5] Remove client timeout. Test fallback to service.\n[6] Remove service timeout too. Test fallback to 30 at login.\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nAmended to incorporate Srdjan's suggestion to move get_timeout to\nSIPServer.pm; this requires some additional mocking in the unit test.\nAnd even makes the test db dependent, as documented.\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/eb8666357ce72e910569843f8acce674a332f4b0"},{"sha":"4ad4ab6396af26bed9dceb442adf4aad6687f362","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Correct indentation of EXPORTs in Sip.pm\n\nRemoved tabs and used spaces consistently\nUsed 'use base' to remove unnecessary BEGIN sub and\nexplicit setting of ISA at application level\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/4ad4ab6396af26bed9dceb442adf4aad6687f362"},{"sha":"64fe6e350074db48cf337dcf1794b40a58d7e606","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/64fe6e350074db48cf337dcf1794b40a58d7e606"},{"sha":"e465d1aa4b16d7392950b2b682f99eb0c58c1ffd","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: [QA Follow-up] Only handle login requests in raw_transport\n\nAlthough mainly hypothetical, it would still be possible to get\nresponse from the server for an acs resend request. (This exception\nis allowed in MsgType::handle.)\nI also noticed that the response may well be a message from an older\nsession still.\nThis patch just removes that exception by only passing login requests\nto sub handle in the raw_transport loop.\n\nTest plan:\n[1] Verify normal login procedure for raw.\n[2] Check a few acs resend requests in raw. They should terminate without\n    a response.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/e465d1aa4b16d7392950b2b682f99eb0c58c1ffd"}]}
{"actor":{"display_login":"gmcharlt"}}