{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/75764307","id":75764307,"diff_hunk":"@@ -634,18 +635,38 @@ func (d *Dispatcher) ensureComponentsInitialize(conf *config.VirtualContainerHos\n \t}\n \n \tdockerInfoURL := fmt.Sprintf(\"%s://%s:%s/info\", proto, d.HostIP, d.DockerPort)\n-\tmaxRetries := 10\n-\tfor i := 0; i < maxRetries; i++ {\n-\t\tres, err = client.Get(dockerInfoURL)\n+\treq, err = http.NewRequest(\"GET\", dockerInfoURL, nil)\n+\tif err != nil {\n+\t\treturn errors.New(\"invalid HTTP request for docker info\")\n+\t}\n+\treq = req.WithContext(d.ctx)\n+\n+\ttimer := time.NewTimer(time.Second)\n+\tif !timer.Stop() {\n+\t\t<-timer.C\n+\t}","path":"lib/install/management/appliance.go","position":24,"original_position":24,"commit_id":"bb6e047eef314a8abc18c7eb95bd85a0e90f5f6c","original_commit_id":"b3c3544d1e06e37c26b800eca07aeeacc1851ecb","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"[Hit send too early]\r\n\r\nthat way you don't need  reset","created_at":"2016-08-22T21:39:58Z","updated_at":"2016-08-22T21:39:58Z","html_url":"https://github.com/vmware/vic/pull/2084#discussion_r75764307","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2084","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/75764307"},"html":{"href":"https://github.com/vmware/vic/pull/2084#discussion_r75764307"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2084"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2084","id":82267784,"html_url":"https://github.com/vmware/vic/pull/2084","diff_url":"https://github.com/vmware/vic/pull/2084.diff","patch_url":"https://github.com/vmware/vic/pull/2084.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2084","number":2084,"state":"open","locked":false,"title":"Use ctx timeout in portlayer init","user":{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false},"body":"Changes logic in  `vic-machine`'s `ensureComponentsInitialize` to use the context timeout.\r\n\r\nFixes #2059 \r\n\r\n","created_at":"2016-08-22T21:36:22Z","updated_at":"2016-08-22T21:39:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3ececf834271f46e2ec50054bc1d18e69bb39dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2084/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2084/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2084/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/bb6e047eef314a8abc18c7eb95bd85a0e90f5f6c","head":{"label":"anchal-agrawal:installer-timeout","ref":"installer-timeout","sha":"bb6e047eef314a8abc18c7eb95bd85a0e90f5f6c","user":{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false},"repo":{"id":55529805,"name":"vic","full_name":"anchal-agrawal/vic","owner":{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anchal-agrawal/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/anchal-agrawal/vic","forks_url":"https://api.github.com/repos/anchal-agrawal/vic/forks","keys_url":"https://api.github.com/repos/anchal-agrawal/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anchal-agrawal/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anchal-agrawal/vic/teams","hooks_url":"https://api.github.com/repos/anchal-agrawal/vic/hooks","issue_events_url":"https://api.github.com/repos/anchal-agrawal/vic/issues/events{/number}","events_url":"https://api.github.com/repos/anchal-agrawal/vic/events","assignees_url":"https://api.github.com/repos/anchal-agrawal/vic/assignees{/user}","branches_url":"https://api.github.com/repos/anchal-agrawal/vic/branches{/branch}","tags_url":"https://api.github.com/repos/anchal-agrawal/vic/tags","blobs_url":"https://api.github.com/repos/anchal-agrawal/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anchal-agrawal/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anchal-agrawal/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/anchal-agrawal/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anchal-agrawal/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/anchal-agrawal/vic/languages","stargazers_url":"https://api.github.com/repos/anchal-agrawal/vic/stargazers","contributors_url":"https://api.github.com/repos/anchal-agrawal/vic/contributors","subscribers_url":"https://api.github.com/repos/anchal-agrawal/vic/subscribers","subscription_url":"https://api.github.com/repos/anchal-agrawal/vic/subscription","commits_url":"https://api.github.com/repos/anchal-agrawal/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/anchal-agrawal/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/anchal-agrawal/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/anchal-agrawal/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/anchal-agrawal/vic/contents/{+path}","compare_url":"https://api.github.com/repos/anchal-agrawal/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anchal-agrawal/vic/merges","archive_url":"https://api.github.com/repos/anchal-agrawal/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anchal-agrawal/vic/downloads","issues_url":"https://api.github.com/repos/anchal-agrawal/vic/issues{/number}","pulls_url":"https://api.github.com/repos/anchal-agrawal/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/anchal-agrawal/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/anchal-agrawal/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anchal-agrawal/vic/labels{/name}","releases_url":"https://api.github.com/repos/anchal-agrawal/vic/releases{/id}","deployments_url":"https://api.github.com/repos/anchal-agrawal/vic/deployments","created_at":"2016-04-05T17:53:37Z","updated_at":"2016-04-05T17:53:38Z","pushed_at":"2016-08-22T21:39:08Z","git_url":"git://github.com/anchal-agrawal/vic.git","ssh_url":"git@github.com:anchal-agrawal/vic.git","clone_url":"https://github.com/anchal-agrawal/vic.git","svn_url":"https://github.com/anchal-agrawal/vic","homepage":null,"size":27601,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"efb474892e2fec8f27ac61702efbc2f1796e6b14","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-08-18T05:28:20Z","pushed_at":"2016-08-22T21:39:09Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":76501,"stargazers_count":111,"watchers_count":111,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":515,"forks":42,"open_issues":515,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2084"},"html":{"href":"https://github.com/vmware/vic/pull/2084"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2084"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2084/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2084/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2084/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/bb6e047eef314a8abc18c7eb95bd85a0e90f5f6c"}}}}
{"actor":{"display_login":"caglar10ur"}}