{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1611","repository_url":"https://api.github.com/repos/facebook/AsyncDisplayKit","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1611/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1611/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1611/events","html_url":"https://github.com/facebook/AsyncDisplayKit/issues/1611","id":152467108,"number":1611,"title":"[ASLayoutSpec] In an unconstrained stack, should layout be invalid if items return Inf. dimension?","user":{"login":"adamastern","id":4900872,"avatar_url":"https://avatars.githubusercontent.com/u/4900872?v=3","gravatar_id":"","url":"https://api.github.com/users/adamastern","html_url":"https://github.com/adamastern","followers_url":"https://api.github.com/users/adamastern/followers","following_url":"https://api.github.com/users/adamastern/following{/other_user}","gists_url":"https://api.github.com/users/adamastern/gists{/gist_id}","starred_url":"https://api.github.com/users/adamastern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamastern/subscriptions","organizations_url":"https://api.github.com/users/adamastern/orgs","repos_url":"https://api.github.com/users/adamastern/repos","events_url":"https://api.github.com/users/adamastern/events{/privacy}","received_events_url":"https://api.github.com/users/adamastern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/ASLayoutSpec","name":"ASLayoutSpec","color":"d4c5f9"},{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/discussion","name":"discussion","color":"cc317c"},{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/documentation","name":"documentation","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/7","html_url":"https://github.com/facebook/AsyncDisplayKit/milestones/2.0","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/7/labels","id":1164099,"number":7,"title":"2.0","description":null,"creator":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":48,"state":"open","created_at":"2015-06-15T00:41:47Z","updated_at":"2016-06-06T06:21:14Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-05-02T01:06:03Z","updated_at":"2016-06-12T00:26:12Z","closed_at":null,"body":"When a node with an unconstrained flex basis is added to a ASStackLayoutSpec, the layout process calls its calculateSizeThatFits: method with a constrained size where the value for the main axis is +Infinity (makes sense, as it is being asked to return its unconstrained intrinsic size along the main axis). The issue is that if the node simply returns the constrained width or height that was passed to it, then ASDK is unable to complete the layout pass because the calculated size includes an infinite value (This is detected here: https://github.com/facebook/AsyncDisplayKit/blob/master/AsyncDisplayKit/Layout/ASLayout.mm#L44)\r\n\r\nThis issue occurs with at least one built-in node, ASEditableTextNode, where its implementation of calculateSizeThatFits returns the width from the constrainedSize parameter - https://github.com/facebook/AsyncDisplayKit/blob/master/AsyncDisplayKit/ASEditableTextNode.mm#L194\r\n\r\nShould nodes be responsible for checking that they don't return an infinite width or height from calculateSizeThatFits?"},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/225402023","html_url":"https://github.com/facebook/AsyncDisplayKit/issues/1611#issuecomment-225402023","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1611","id":225402023,"user":{"login":"adamastern","id":4900872,"avatar_url":"https://avatars.githubusercontent.com/u/4900872?v=3","gravatar_id":"","url":"https://api.github.com/users/adamastern","html_url":"https://github.com/adamastern","followers_url":"https://api.github.com/users/adamastern/followers","following_url":"https://api.github.com/users/adamastern/following{/other_user}","gists_url":"https://api.github.com/users/adamastern/gists{/gist_id}","starred_url":"https://api.github.com/users/adamastern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamastern/subscriptions","organizations_url":"https://api.github.com/users/adamastern/orgs","repos_url":"https://api.github.com/users/adamastern/repos","events_url":"https://api.github.com/users/adamastern/events{/privacy}","received_events_url":"https://api.github.com/users/adamastern/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T00:26:12Z","updated_at":"2016-06-12T00:26:12Z","body":"Thanks @maicki looks great! This resolves the issue for me."}}
{"actor":{"display_login":"adamastern"}}