{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/6399","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/6399/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6399/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/6399/events","html_url":"https://github.com/facebook/react-native/pull/6399","id":139794035,"number":6399,"title":"Allow building UIExplorer with Buck","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-10T05:54:31Z","updated_at":"2016-03-11T20:01:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6399","html_url":"https://github.com/facebook/react-native/pull/6399","diff_url":"https://github.com/facebook/react-native/pull/6399.diff","patch_url":"https://github.com/facebook/react-native/pull/6399.patch"},"body":"This adds a BUCK file to UIExplorer to allow building it with buck. It is based on the one in the movies app but I removed the extra deps that were not needed in both files. \r\n\r\nAlso add build version number and target sdk version in the Android manifest so Buck can use it since it was only specified in the gradle build and caused the app to run on a super old target sdk.\r\n\r\n@bestander @mkonicek Would it be simple to also build the ndk part with Buck? Right now it is built with gradle and packaged after. I suppose it is already being done internally at facebook. The BUCK files for building the cpp code are already there but I couldn't figure out what was missing to make it work :(\r\n\r\nThat is pretty much the only missing part to have first class support for building RN apps with Buck in OSS. We could eventually include BUCK files with the generated project.\r\n\r\n**Test plan (required)**\r\nBuild and run UIExplorer and Movies examples using Buck.\r\n\r\nEdited:\r\n```\r\n./gradlew ReactAndroid:packageReactNdkLibsForBuck\r\n\r\nbuck fetch movies\r\nbuck install -r movies\r\n\r\nbuck fetch uiexplorer\r\nbuck install -r uiexplorer\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/195524304","html_url":"https://github.com/facebook/react-native/pull/6399#issuecomment-195524304","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6399","id":195524304,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T20:01:35Z","updated_at":"2016-03-11T20:01:35Z","body":"Thanks for importing. If you are an FB employee go to [Phabricator](https://our.intern.facebook.com/intern/opensource/github/pull_request/1685897698347118/int_phab) to review."}}