{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments/69926015","id":69926015,"diff_hunk":"@@ -140,6 +142,28 @@ trait MethodConfigurationComponent {\n       }\n     }\n \n+    object DeleteMethodConfiguration extends RawSqlQuery {\n+      val driver: JdbcDriver = MethodConfigurationComponent.this.driver\n+\n+      def deleteAction(workspaceId: UUID) = {\n+        val tables: Seq[SQLActionBuilder] = Seq(sql\"METHOD_CONFIG_INPUT\", sql\"METHOD_CONFIG_OUTPUT\",\n+          sql\"METHOD_CONFIG_PREREQ\")\n+\n+        def baseQuery(table: SQLActionBuilder) = {","path":"src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/MethodConfigurationComponent.scala","position":20,"original_position":20,"commit_id":"b5537ae9a6f0ad99fd94f290b7664377270623af","original_commit_id":"b5537ae9a6f0ad99fd94f290b7664377270623af","user":{"login":"skwalker","id":4933056,"avatar_url":"https://avatars.githubusercontent.com/u/4933056?v=3","gravatar_id":"","url":"https://api.github.com/users/skwalker","html_url":"https://github.com/skwalker","followers_url":"https://api.github.com/users/skwalker/followers","following_url":"https://api.github.com/users/skwalker/following{/other_user}","gists_url":"https://api.github.com/users/skwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/skwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwalker/subscriptions","organizations_url":"https://api.github.com/users/skwalker/orgs","repos_url":"https://api.github.com/users/skwalker/repos","events_url":"https://api.github.com/users/skwalker/events{/privacy}","received_events_url":"https://api.github.com/users/skwalker/received_events","type":"User","site_admin":false},"body":"```\r\nMySQL [rawls]> explain delete t from METHOD_CONFIG_INPUT as t inner join METHOD_CONFIG as mc on mc.id=t.method_config_id\r\n    ->                  where mc.workspace_id='';\r\n+----+-------------+-------+------+------------------------------------+--------------+---------+-------------+------+--------------------------+\r\n| id | select_type | table | type | possible_keys                      | key          | key_len | ref         | rows | Extra                    |\r\n+----+-------------+-------+------+------------------------------------+--------------+---------+-------------+------+--------------------------+\r\n|  1 | SIMPLE      | mc    | ref  | PRIMARY,IDX_CONFIG,FK_MC_WORKSPACE | IDX_CONFIG   | 16      | const       |    1 | Using where; Using index |\r\n|  1 | SIMPLE      | t     | ref  | IDX_MC_INPUT                       | IDX_MC_INPUT | 8       | rawls.mc.ID |    3 | NULL                     |\r\n+----+-------------+-------+------+------------------------------------+--------------+---------+-------------+------+--------------------------+\r\n2 rows in set (0.18 sec)\r\n```","created_at":"2016-07-07T15:17:22Z","updated_at":"2016-07-07T15:17:22Z","html_url":"https://github.com/broadinstitute/rawls/pull/471#discussion_r69926015","pull_request_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments/69926015"},"html":{"href":"https://github.com/broadinstitute/rawls/pull/471#discussion_r69926015"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/471","id":75694077,"html_url":"https://github.com/broadinstitute/rawls/pull/471","diff_url":"https://github.com/broadinstitute/rawls/pull/471.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/471.patch","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/471","number":471,"state":"open","locked":false,"title":"gawb733","user":{"login":"skwalker","id":4933056,"avatar_url":"https://avatars.githubusercontent.com/u/4933056?v=3","gravatar_id":"","url":"https://api.github.com/users/skwalker","html_url":"https://github.com/skwalker","followers_url":"https://api.github.com/users/skwalker/followers","following_url":"https://api.github.com/users/skwalker/following{/other_user}","gists_url":"https://api.github.com/users/skwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/skwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwalker/subscriptions","organizations_url":"https://api.github.com/users/skwalker/orgs","repos_url":"https://api.github.com/users/skwalker/repos","events_url":"https://api.github.com/users/skwalker/events{/privacy}","received_events_url":"https://api.github.com/users/skwalker/received_events","type":"User","site_admin":false},"body":"- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Make sure liquibase is updated if appropriate\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [ ] **Submitter**: If PR includes new or changed db queries, include the explain plans in the description\r\n- [x] Tell ![](http://i.imgur.com/9dLzbPd.png) that the PR exists if he wants to look at it **(apply requires_doge label)**\r\n- [x] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [ ] **LR**: Initial review by LR and others.\r\n- [ ] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] ![](http://i.imgur.com/9dLzbPd.png) sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n","created_at":"2016-06-29T18:04:34Z","updated_at":"2016-07-07T15:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23036f8a39f9a2d4e713f1b32cefca5deb5934f0","assignee":{"login":"dvoet","id":1521333,"avatar_url":"https://avatars.githubusercontent.com/u/1521333?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoet","html_url":"https://github.com/dvoet","followers_url":"https://api.github.com/users/dvoet/followers","following_url":"https://api.github.com/users/dvoet/following{/other_user}","gists_url":"https://api.github.com/users/dvoet/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoet/subscriptions","organizations_url":"https://api.github.com/users/dvoet/orgs","repos_url":"https://api.github.com/users/dvoet/repos","events_url":"https://api.github.com/users/dvoet/events{/privacy}","received_events_url":"https://api.github.com/users/dvoet/received_events","type":"User","site_admin":false},"assignees":[{"login":"dvoet","id":1521333,"avatar_url":"https://avatars.githubusercontent.com/u/1521333?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoet","html_url":"https://github.com/dvoet","followers_url":"https://api.github.com/users/dvoet/followers","following_url":"https://api.github.com/users/dvoet/following{/other_user}","gists_url":"https://api.github.com/users/dvoet/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoet/subscriptions","organizations_url":"https://api.github.com/users/dvoet/orgs","repos_url":"https://api.github.com/users/dvoet/repos","events_url":"https://api.github.com/users/dvoet/events{/privacy}","received_events_url":"https://api.github.com/users/dvoet/received_events","type":"User","site_admin":false},{"login":"jmthibault79","id":2701406,"avatar_url":"https://avatars.githubusercontent.com/u/2701406?v=3","gravatar_id":"","url":"https://api.github.com/users/jmthibault79","html_url":"https://github.com/jmthibault79","followers_url":"https://api.github.com/users/jmthibault79/followers","following_url":"https://api.github.com/users/jmthibault79/following{/other_user}","gists_url":"https://api.github.com/users/jmthibault79/gists{/gist_id}","starred_url":"https://api.github.com/users/jmthibault79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmthibault79/subscriptions","organizations_url":"https://api.github.com/users/jmthibault79/orgs","repos_url":"https://api.github.com/users/jmthibault79/repos","events_url":"https://api.github.com/users/jmthibault79/events{/privacy}","received_events_url":"https://api.github.com/users/jmthibault79/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/471/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/471/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/471/comments","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/b5537ae9a6f0ad99fd94f290b7664377270623af","head":{"label":"broadinstitute:skw_gawb733","ref":"skw_gawb733","sha":"b5537ae9a6f0ad99fd94f290b7664377270623af","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34129770,"name":"rawls","full_name":"broadinstitute/rawls","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/rawls","description":"Rawls service for DSDE","fork":false,"url":"https://api.github.com/repos/broadinstitute/rawls","forks_url":"https://api.github.com/repos/broadinstitute/rawls/forks","keys_url":"https://api.github.com/repos/broadinstitute/rawls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/rawls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/rawls/teams","hooks_url":"https://api.github.com/repos/broadinstitute/rawls/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/rawls/events","assignees_url":"https://api.github.com/repos/broadinstitute/rawls/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/rawls/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/rawls/tags","blobs_url":"https://api.github.com/repos/broadinstitute/rawls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/rawls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/rawls/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/rawls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/rawls/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/rawls/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/rawls/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/rawls/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/rawls/subscription","commits_url":"https://api.github.com/repos/broadinstitute/rawls/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/rawls/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/rawls/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/rawls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/rawls/merges","archive_url":"https://api.github.com/repos/broadinstitute/rawls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/rawls/downloads","issues_url":"https://api.github.com/repos/broadinstitute/rawls/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/rawls/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/rawls/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/rawls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/rawls/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/rawls/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/rawls/deployments","created_at":"2015-04-17T17:16:07Z","updated_at":"2016-03-04T19:30:59Z","pushed_at":"2016-07-07T14:56:01Z","git_url":"git://github.com/broadinstitute/rawls.git","ssh_url":"git@github.com:broadinstitute/rawls.git","clone_url":"https://github.com/broadinstitute/rawls.git","svn_url":"https://github.com/broadinstitute/rawls","homepage":null,"size":4496,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":5,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"25089781275b6c081806e3311e4d3980c89b75a0","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34129770,"name":"rawls","full_name":"broadinstitute/rawls","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/rawls","description":"Rawls service for DSDE","fork":false,"url":"https://api.github.com/repos/broadinstitute/rawls","forks_url":"https://api.github.com/repos/broadinstitute/rawls/forks","keys_url":"https://api.github.com/repos/broadinstitute/rawls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/rawls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/rawls/teams","hooks_url":"https://api.github.com/repos/broadinstitute/rawls/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/rawls/events","assignees_url":"https://api.github.com/repos/broadinstitute/rawls/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/rawls/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/rawls/tags","blobs_url":"https://api.github.com/repos/broadinstitute/rawls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/rawls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/rawls/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/rawls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/rawls/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/rawls/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/rawls/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/rawls/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/rawls/subscription","commits_url":"https://api.github.com/repos/broadinstitute/rawls/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/rawls/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/rawls/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/rawls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/rawls/merges","archive_url":"https://api.github.com/repos/broadinstitute/rawls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/rawls/downloads","issues_url":"https://api.github.com/repos/broadinstitute/rawls/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/rawls/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/rawls/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/rawls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/rawls/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/rawls/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/rawls/deployments","created_at":"2015-04-17T17:16:07Z","updated_at":"2016-03-04T19:30:59Z","pushed_at":"2016-07-07T14:56:01Z","git_url":"git://github.com/broadinstitute/rawls.git","ssh_url":"git@github.com:broadinstitute/rawls.git","clone_url":"https://github.com/broadinstitute/rawls.git","svn_url":"https://github.com/broadinstitute/rawls","homepage":null,"size":4496,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/471"},"html":{"href":"https://github.com/broadinstitute/rawls/pull/471"},"issue":{"href":"https://api.github.com/repos/broadinstitute/rawls/issues/471"},"comments":{"href":"https://api.github.com/repos/broadinstitute/rawls/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/rawls/statuses/b5537ae9a6f0ad99fd94f290b7664377270623af"}}}}
{"actor":{"display_login":"skwalker"}}