{"action":"created","issue":{"url":"https://api.github.com/repos/tgalal/yowsup/issues/1264","labels_url":"https://api.github.com/repos/tgalal/yowsup/issues/1264/labels{/name}","comments_url":"https://api.github.com/repos/tgalal/yowsup/issues/1264/comments","events_url":"https://api.github.com/repos/tgalal/yowsup/issues/1264/events","html_url":"https://github.com/tgalal/yowsup/pull/1264","id":128195050,"number":1264,"title":"Complete Iq request callbacks for group protocol.","user":{"login":"blr246","id":1091758,"avatar_url":"https://avatars.githubusercontent.com/u/1091758?v=3","gravatar_id":"","url":"https://api.github.com/users/blr246","html_url":"https://github.com/blr246","followers_url":"https://api.github.com/users/blr246/followers","following_url":"https://api.github.com/users/blr246/following{/other_user}","gists_url":"https://api.github.com/users/blr246/gists{/gist_id}","starred_url":"https://api.github.com/users/blr246/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blr246/subscriptions","organizations_url":"https://api.github.com/users/blr246/orgs","repos_url":"https://api.github.com/users/blr246/repos","events_url":"https://api.github.com/users/blr246/events{/privacy}","received_events_url":"https://api.github.com/users/blr246/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-22T16:43:58Z","updated_at":"2016-01-22T17:36:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgalal/yowsup/pulls/1264","html_url":"https://github.com/tgalal/yowsup/pull/1264","diff_url":"https://github.com/tgalal/yowsup/pull/1264.diff","patch_url":"https://github.com/tgalal/yowsup/pull/1264.patch"},"body":"The group protocol layer appears to be the only remaining layer that\r\ndoes not call `toUpper()` with an entity for every incoming iq request\r\nnode. This will cause two bad things to happen:\r\n\r\n  1. Interface clients will not get callbacks for these Iq\r\n     request sequences in certain cases or success/error.\r\n  2. Any attempts to use registered callbacks with these incomplete Iq\r\n     request sequences will be leaked.\r\n\r\nThere's still a much larger memory management issue in Yowsup, assuming\r\nthat I'm correct that there's no periodic sweeping of unanswered\r\nregistry callbacks. I've reported more about that in Issue\r\nhttps://github.com/tgalal/yowsup/issues/1263."},"comment":{"url":"https://api.github.com/repos/tgalal/yowsup/issues/comments/173987631","html_url":"https://github.com/tgalal/yowsup/pull/1264#issuecomment-173987631","issue_url":"https://api.github.com/repos/tgalal/yowsup/issues/1264","id":173987631,"user":{"login":"blr246","id":1091758,"avatar_url":"https://avatars.githubusercontent.com/u/1091758?v=3","gravatar_id":"","url":"https://api.github.com/users/blr246","html_url":"https://github.com/blr246","followers_url":"https://api.github.com/users/blr246/followers","following_url":"https://api.github.com/users/blr246/following{/other_user}","gists_url":"https://api.github.com/users/blr246/gists{/gist_id}","starred_url":"https://api.github.com/users/blr246/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blr246/subscriptions","organizations_url":"https://api.github.com/users/blr246/orgs","repos_url":"https://api.github.com/users/blr246/repos","events_url":"https://api.github.com/users/blr246/events{/privacy}","received_events_url":"https://api.github.com/users/blr246/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T17:36:18Z","updated_at":"2016-01-22T17:36:18Z","body":"Failure of CI appears to be related to download of the `Pillow` dependency:\r\n\r\n```\r\nProcessing dependencies for yowsup2==2.4.48\r\nSearching for pillow\r\nReading https://pypi.python.org/simple/pillow/\r\n/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/pkg_resources/__init__.py:2510: PEP440Warning: 'Pillow-3.1.0 (rc1)' is being parsed as a legacy, non PEP 440, version. You may find odd behavior and sort order. In particular it will be sorted as less than 0.0. It is recommend to migrate to PEP 440 compatible versions.\r\n  PEP440Warning,\r\nBest match: Pillow 3.1.0\r\nDownloading https://pypi.python.org/packages/source/P/Pillow/Pillow-3.1.0.zip#md5=d70bd4cf57409f785662e221a345ef4b\r\nerror: md5 validation failed for Pillow-3.1.0.zip; possible download problem?\r\nThe command \"python setup.py install\" failed and exited with 1 during .\r\nYour build has been stopped.\r\n```"}}