{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/86052280","pull_request_review_id":6730475,"id":86052280,"diff_hunk":"@@ -0,0 +1,22 @@\n+//===--- Statistic.h - Helpers for Lllvm::Statistic ---------*- C++ -*-===//\n+//\n+// This source file is part of the Swift.org open source project\n+//\n+// Copyright (c) 2016 Apple Inc. and the Swift project authors\n+// Licensed under Apache License v2.0 with Runtime Library Exception\n+//\n+// See http://swift.org/LICENSE.txt for license information\n+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors\n+//\n+//===----------------------------------------------------------------------===//\n+\n+#ifndef SWIFT_BASIC_STATISTIC_H\n+#define SWIFT_BASIC_STATISTIC_H\n+\n+#include \"llvm/ADT/Statistic.h\"\n+\n+#define SWIFT_FUNC_STAT \\","path":"include/swift/Basic/Statistic.h","position":18,"original_position":18,"commit_id":"948fa2b5e7394eb9be4298e9d4b2d3411b35590b","original_commit_id":"948fa2b5e7394eb9be4298e9d4b2d3411b35590b","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"Does this need a `do { ... } while (0)` given how often braceless control flow is used, or are macro hacks like that not Swift/LLVM style?","created_at":"2016-11-02T00:11:52Z","updated_at":"2016-11-02T00:12:00Z","html_url":"https://github.com/apple/swift/pull/5588#discussion_r86052280","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5588","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/86052280"},"html":{"href":"https://github.com/apple/swift/pull/5588#discussion_r86052280"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5588"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5588","id":91888314,"html_url":"https://github.com/apple/swift/pull/5588","diff_url":"https://github.com/apple/swift/pull/5588.diff","patch_url":"https://github.com/apple/swift/pull/5588.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5588","number":5588,"state":"open","locked":false,"title":"Rdar 27397701 synthesized get set typechecking","user":{"login":"graydon","id":14097,"avatar_url":"https://avatars.githubusercontent.com/u/14097?v=3","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"body":"Addresses redundant typechecking of getter/setter function bodies outside of the primary file.\r\nThis is responsible for unnecessary quadratic work when doing a multi-file compilation.\r\nPR also includes more scale-testing machinery, and a regression test that uses it.\r\n\r\nResolves [SR-2901](https://bugs.swift.org/browse/SR-2901).\r\nResolves rdar://27397701\r\n","created_at":"2016-11-02T00:09:03Z","updated_at":"2016-11-02T00:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5d6bf829f078b67d65dfe19390adcfa9d20714","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5588/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5588/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5588/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/948fa2b5e7394eb9be4298e9d4b2d3411b35590b","head":{"label":"graydon:rdar-27397701-synthesized-get-set-typechecking-redux","ref":"rdar-27397701-synthesized-get-set-typechecking-redux","sha":"948fa2b5e7394eb9be4298e9d4b2d3411b35590b","user":{"login":"graydon","id":14097,"avatar_url":"https://avatars.githubusercontent.com/u/14097?v=3","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"repo":{"id":66865548,"name":"swift","full_name":"graydon/swift","owner":{"login":"graydon","id":14097,"avatar_url":"https://avatars.githubusercontent.com/u/14097?v=3","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graydon/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/graydon/swift","forks_url":"https://api.github.com/repos/graydon/swift/forks","keys_url":"https://api.github.com/repos/graydon/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graydon/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graydon/swift/teams","hooks_url":"https://api.github.com/repos/graydon/swift/hooks","issue_events_url":"https://api.github.com/repos/graydon/swift/issues/events{/number}","events_url":"https://api.github.com/repos/graydon/swift/events","assignees_url":"https://api.github.com/repos/graydon/swift/assignees{/user}","branches_url":"https://api.github.com/repos/graydon/swift/branches{/branch}","tags_url":"https://api.github.com/repos/graydon/swift/tags","blobs_url":"https://api.github.com/repos/graydon/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graydon/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graydon/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/graydon/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graydon/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/graydon/swift/languages","stargazers_url":"https://api.github.com/repos/graydon/swift/stargazers","contributors_url":"https://api.github.com/repos/graydon/swift/contributors","subscribers_url":"https://api.github.com/repos/graydon/swift/subscribers","subscription_url":"https://api.github.com/repos/graydon/swift/subscription","commits_url":"https://api.github.com/repos/graydon/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/graydon/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/graydon/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/graydon/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/graydon/swift/contents/{+path}","compare_url":"https://api.github.com/repos/graydon/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graydon/swift/merges","archive_url":"https://api.github.com/repos/graydon/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graydon/swift/downloads","issues_url":"https://api.github.com/repos/graydon/swift/issues{/number}","pulls_url":"https://api.github.com/repos/graydon/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/graydon/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/graydon/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graydon/swift/labels{/name}","releases_url":"https://api.github.com/repos/graydon/swift/releases{/id}","deployments_url":"https://api.github.com/repos/graydon/swift/deployments","created_at":"2016-08-29T17:37:10Z","updated_at":"2016-08-29T17:37:35Z","pushed_at":"2016-11-02T00:04:23Z","git_url":"git://github.com/graydon/swift.git","ssh_url":"git@github.com:graydon/swift.git","clone_url":"https://github.com/graydon/swift.git","svn_url":"https://github.com/graydon/swift","homepage":"https://swift.org/","size":126222,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0471e10cb854d1b91d02996b16c91e039a187fc7","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-11-01T22:54:39Z","pushed_at":"2016-11-02T00:09:03Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":194205,"stargazers_count":34952,"watchers_count":34952,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5018,"mirror_url":null,"open_issues_count":113,"forks":5018,"open_issues":113,"watchers":34952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5588"},"html":{"href":"https://github.com/apple/swift/pull/5588"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5588"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5588/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5588/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5588/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/948fa2b5e7394eb9be4298e9d4b2d3411b35590b"}}}}
{"actor":{"display_login":"huonw"}}