{"action":"opened","number":3020,"pull_request":{"url":"https://api.github.com/repos/libretro/RetroArch/pulls/3020","id":70997311,"html_url":"https://github.com/libretro/RetroArch/pull/3020","diff_url":"https://github.com/libretro/RetroArch/pull/3020.diff","patch_url":"https://github.com/libretro/RetroArch/pull/3020.patch","issue_url":"https://api.github.com/repos/libretro/RetroArch/issues/3020","number":3020,"state":"open","locked":false,"title":"Memory leak-related fixes","user":{"login":"sronsse","id":6821415,"avatar_url":"https://avatars.githubusercontent.com/u/6821415?v=3","gravatar_id":"","url":"https://api.github.com/users/sronsse","html_url":"https://github.com/sronsse","followers_url":"https://api.github.com/users/sronsse/followers","following_url":"https://api.github.com/users/sronsse/following{/other_user}","gists_url":"https://api.github.com/users/sronsse/gists{/gist_id}","starred_url":"https://api.github.com/users/sronsse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sronsse/subscriptions","organizations_url":"https://api.github.com/users/sronsse/orgs","repos_url":"https://api.github.com/users/sronsse/repos","events_url":"https://api.github.com/users/sronsse/events{/privacy}","received_events_url":"https://api.github.com/users/sronsse/received_events","type":"User","site_admin":false},"body":"The first commit fixes a memory leak occurring on exit. The menu driver in this case refused to deinitialize, which was due to an ownership flag not properly reset when RetroArch was requested to quit. This flag remained true due to \"content not being loaded yet\". Even though I don't fully grasp the logic behind why the two were related, I don't believe this check belongs in the menu driver so this PR just removes this check.\r\n\r\nThe remaining 3 commits introduce the concept of free flags for settings data. When creating a new menu setting, some data is expected to be freed later on, and some special cases were handled for ST_BIND and ST_STRING_OPTIONS, leaving an ST_BOOL setting with a leak. This PR just removes this handling and relies on \"free flags\" to be set upon setting creation, which are later parsed and automatically free tagged data. The CONFIG_BIND and CONFIG_STRING_OPTIONS functions automatically tag the data to be freed, so there is no extra code required when using these helper functions.","created_at":"2016-05-23T02:16:02Z","updated_at":"2016-05-23T02:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libretro/RetroArch/pulls/3020/commits","review_comments_url":"https://api.github.com/repos/libretro/RetroArch/pulls/3020/comments","review_comment_url":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/RetroArch/issues/3020/comments","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/18bff0401b2bab2fd515635006f53d8efce0296a","head":{"label":"sronsse:fixes_for_team","ref":"fixes_for_team","sha":"18bff0401b2bab2fd515635006f53d8efce0296a","user":{"login":"sronsse","id":6821415,"avatar_url":"https://avatars.githubusercontent.com/u/6821415?v=3","gravatar_id":"","url":"https://api.github.com/users/sronsse","html_url":"https://github.com/sronsse","followers_url":"https://api.github.com/users/sronsse/followers","following_url":"https://api.github.com/users/sronsse/following{/other_user}","gists_url":"https://api.github.com/users/sronsse/gists{/gist_id}","starred_url":"https://api.github.com/users/sronsse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sronsse/subscriptions","organizations_url":"https://api.github.com/users/sronsse/orgs","repos_url":"https://api.github.com/users/sronsse/repos","events_url":"https://api.github.com/users/sronsse/events{/privacy}","received_events_url":"https://api.github.com/users/sronsse/received_events","type":"User","site_admin":false},"repo":{"id":58023180,"name":"RetroArch","full_name":"sronsse/RetroArch","owner":{"login":"sronsse","id":6821415,"avatar_url":"https://avatars.githubusercontent.com/u/6821415?v=3","gravatar_id":"","url":"https://api.github.com/users/sronsse","html_url":"https://github.com/sronsse","followers_url":"https://api.github.com/users/sronsse/followers","following_url":"https://api.github.com/users/sronsse/following{/other_user}","gists_url":"https://api.github.com/users/sronsse/gists{/gist_id}","starred_url":"https://api.github.com/users/sronsse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sronsse/subscriptions","organizations_url":"https://api.github.com/users/sronsse/orgs","repos_url":"https://api.github.com/users/sronsse/repos","events_url":"https://api.github.com/users/sronsse/events{/privacy}","received_events_url":"https://api.github.com/users/sronsse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sronsse/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API.","fork":true,"url":"https://api.github.com/repos/sronsse/RetroArch","forks_url":"https://api.github.com/repos/sronsse/RetroArch/forks","keys_url":"https://api.github.com/repos/sronsse/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sronsse/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sronsse/RetroArch/teams","hooks_url":"https://api.github.com/repos/sronsse/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/sronsse/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/sronsse/RetroArch/events","assignees_url":"https://api.github.com/repos/sronsse/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/sronsse/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/sronsse/RetroArch/tags","blobs_url":"https://api.github.com/repos/sronsse/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sronsse/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sronsse/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/sronsse/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sronsse/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/sronsse/RetroArch/languages","stargazers_url":"https://api.github.com/repos/sronsse/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/sronsse/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/sronsse/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/sronsse/RetroArch/subscription","commits_url":"https://api.github.com/repos/sronsse/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/sronsse/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/sronsse/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/sronsse/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/sronsse/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/sronsse/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sronsse/RetroArch/merges","archive_url":"https://api.github.com/repos/sronsse/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sronsse/RetroArch/downloads","issues_url":"https://api.github.com/repos/sronsse/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/sronsse/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/sronsse/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/sronsse/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sronsse/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/sronsse/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/sronsse/RetroArch/deployments","created_at":"2016-05-04T04:39:06Z","updated_at":"2016-05-04T04:39:12Z","pushed_at":"2016-05-23T02:10:41Z","git_url":"git://github.com/sronsse/RetroArch.git","ssh_url":"git@github.com:sronsse/RetroArch.git","clone_url":"https://github.com/sronsse/RetroArch.git","svn_url":"https://github.com/sronsse/RetroArch","homepage":"http://www.libretro.com","size":104680,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"06aa001b824ea81ac358699423eb8173cc895933","user":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":689344,"name":"RetroArch","full_name":"libretro/RetroArch","owner":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libretro/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API.","fork":false,"url":"https://api.github.com/repos/libretro/RetroArch","forks_url":"https://api.github.com/repos/libretro/RetroArch/forks","keys_url":"https://api.github.com/repos/libretro/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/RetroArch/teams","hooks_url":"https://api.github.com/repos/libretro/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/libretro/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/RetroArch/events","assignees_url":"https://api.github.com/repos/libretro/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/RetroArch/tags","blobs_url":"https://api.github.com/repos/libretro/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/RetroArch/languages","stargazers_url":"https://api.github.com/repos/libretro/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/libretro/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/libretro/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/libretro/RetroArch/subscription","commits_url":"https://api.github.com/repos/libretro/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/RetroArch/merges","archive_url":"https://api.github.com/repos/libretro/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/RetroArch/downloads","issues_url":"https://api.github.com/repos/libretro/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/libretro/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/RetroArch/deployments","created_at":"2010-05-27T14:47:40Z","updated_at":"2016-05-21T17:02:11Z","pushed_at":"2016-05-23T02:16:02Z","git_url":"git://github.com/libretro/RetroArch.git","ssh_url":"git@github.com:libretro/RetroArch.git","clone_url":"https://github.com/libretro/RetroArch.git","svn_url":"https://github.com/libretro/RetroArch","homepage":"http://www.libretro.com","size":118414,"stargazers_count":1104,"watchers_count":1104,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":345,"mirror_url":null,"open_issues_count":218,"forks":345,"open_issues":218,"watchers":1104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3020"},"html":{"href":"https://github.com/libretro/RetroArch/pull/3020"},"issue":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/3020"},"comments":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/3020/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3020/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/3020/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/RetroArch/statuses/18bff0401b2bab2fd515635006f53d8efce0296a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":52,"deletions":22,"changed_files":3}}
{"actor":{"display_login":"sronsse"}}