{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/12889","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/12889/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12889/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/12889/events","html_url":"https://github.com/edx/edx-platform/pull/12889","id":162753917,"number":12889,"title":"Fixed CCX coach dashboard access issues","user":{"login":"amir-qayyum-khan","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-khan","html_url":"https://github.com/amir-qayyum-khan","followers_url":"https://api.github.com/users/amir-qayyum-khan/followers","following_url":"https://api.github.com/users/amir-qayyum-khan/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-khan/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-khan/orgs","repos_url":"https://api.github.com/users/amir-qayyum-khan/repos","events_url":"https://api.github.com/users/amir-qayyum-khan/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-khan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/awaiting%20prioritization","name":"awaiting prioritization","color":"fad8c7"},{"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-06-28T18:27:51Z","updated_at":"2016-07-11T19:33:03Z","closed_at":"2016-07-08T00:29:24Z","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12889","html_url":"https://github.com/edx/edx-platform/pull/12889","diff_url":"https://github.com/edx/edx-platform/pull/12889.diff","patch_url":"https://github.com/edx/edx-platform/pull/12889.patch"},"body":"### Background\r\nfixes https://github.com/mitocw/edx-platform/issues/245, https://github.com/mitocw/edx-platform/issues/246\r\n\r\n### What is done in this PR\r\n**Studio Updates:** None.\r\n**LMS Updates:** \r\n - 404 if user access coach dashboard with invalid CCX id in url.\r\n - 404 if enable_ccx flag is set to false in studio course settings.\r\n\r\n@pdpinch @giocalitri \r\n\r\n### How to test manually:\r\n##### In case of ccx is disable for course: \r\n- If you have valid ccx then disable enable_ccx settings from advance settings in studio then use url and try to access ccx coach dashboard. you will get 404 exception.\r\n\r\n##### In case of ccx id in url is invalid:\r\n- Modify ccx coach dashboard URL in browser change ccx id (number) to invalid number let say 700 and hit, you will get 404 error.\r\n\r\n#### IF enable_ccx flag is set to false:\r\n<img width=\"703\" alt=\"screen shot 2016-06-26 at 11 05 26 pm\" src=\"https://cloud.githubusercontent.com/assets/10431250/16364231/a0c23b92-3bfb-11e6-8b86-201d3f557701.png\">\r\n\r\n#### IF coach dashboard access with invalid ccx id in url:\r\n<img width=\"700\" alt=\"screen shot 2016-06-26 at 11 05 59 pm\" src=\"https://cloud.githubusercontent.com/assets/10431250/16364230/a0c2049c-3bfb-11e6-8ea2-682561e69ab7.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/231839880","html_url":"https://github.com/edx/edx-platform/pull/12889#issuecomment-231839880","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12889","id":231839880,"user":{"login":"amir-qayyum-khan","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-khan","html_url":"https://github.com/amir-qayyum-khan","followers_url":"https://api.github.com/users/amir-qayyum-khan/followers","following_url":"https://api.github.com/users/amir-qayyum-khan/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-khan/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-khan/orgs","repos_url":"https://api.github.com/users/amir-qayyum-khan/repos","events_url":"https://api.github.com/users/amir-qayyum-khan/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-khan/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T19:33:03Z","updated_at":"2016-07-11T19:33:03Z","body":"thanks"}}
{"actor":{"display_login":"amir-qayyum-khan"}}