{"action":"created","comment":{"url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/comments/92011620","pull_request_review_id":12520916,"id":92011620,"diff_hunk":"@@ -259,7 +259,7 @@ def get(self):\n \n # there is almost no text that is invalid, but no hyphens up front, please\n # neither all these suspicious but valid caracthers...\n-_env_regex = r\"(?P<env>[^/&+$?@<>%*-][^/&+$?@<>%*]*)$\"\n+_env_regex = r\"(?P<env>[^/&+$?@<>%*-][^/&+$?@<>%*]*)\"","path":"nb_conda/handlers.py","position":null,"original_position":5,"commit_id":"178d0aa0b29f82a1a53fa61556ea334f5a74d888","original_commit_id":"178d0aa0b29f82a1a53fa61556ea334f5a74d888","user":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?v=3","gravatar_id":"","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"body":"I tried to create an environment with the name `myenv%two` and it failed to create it, which I think is appropriate... and the same with `%myenv` so I think is working properly...","created_at":"2016-12-12T18:44:55Z","updated_at":"2016-12-12T18:44:55Z","html_url":"https://github.com/Anaconda-Platform/nb_conda/pull/37#discussion_r92011620","pull_request_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/comments/92011620"},"html":{"href":"https://github.com/Anaconda-Platform/nb_conda/pull/37#discussion_r92011620"},"pull_request":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37","id":97600773,"html_url":"https://github.com/Anaconda-Platform/nb_conda/pull/37","diff_url":"https://github.com/Anaconda-Platform/nb_conda/pull/37.diff","patch_url":"https://github.com/Anaconda-Platform/nb_conda/pull/37.patch","issue_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/37","number":37,"state":"open","locked":false,"title":"Allow environment names with one letter ","user":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?v=3","gravatar_id":"","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"body":"But also get rid of suspicious characters...\r\n\r\n@martindurant provided this regex after some discussion at https://github.com/ContinuumIO/aen-issues/issues/680","created_at":"2016-12-12T17:50:18Z","updated_at":"2016-12-12T18:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4208777f9f4621c81a8640bd11a1c9c81aea2260","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/37/comments","statuses_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/statuses/178d0aa0b29f82a1a53fa61556ea334f5a74d888","head":{"label":"Anaconda-Platform:fix_regex_env","ref":"fix_regex_env","sha":"178d0aa0b29f82a1a53fa61556ea334f5a74d888","user":{"login":"Anaconda-Platform","id":3571983,"avatar_url":"https://avatars.githubusercontent.com/u/3571983?v=3","gravatar_id":"","url":"https://api.github.com/users/Anaconda-Platform","html_url":"https://github.com/Anaconda-Platform","followers_url":"https://api.github.com/users/Anaconda-Platform/followers","following_url":"https://api.github.com/users/Anaconda-Platform/following{/other_user}","gists_url":"https://api.github.com/users/Anaconda-Platform/gists{/gist_id}","starred_url":"https://api.github.com/users/Anaconda-Platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anaconda-Platform/subscriptions","organizations_url":"https://api.github.com/users/Anaconda-Platform/orgs","repos_url":"https://api.github.com/users/Anaconda-Platform/repos","events_url":"https://api.github.com/users/Anaconda-Platform/events{/privacy}","received_events_url":"https://api.github.com/users/Anaconda-Platform/received_events","type":"Organization","site_admin":false},"repo":{"id":47725040,"name":"nb_conda","full_name":"Anaconda-Platform/nb_conda","owner":{"login":"Anaconda-Platform","id":3571983,"avatar_url":"https://avatars.githubusercontent.com/u/3571983?v=3","gravatar_id":"","url":"https://api.github.com/users/Anaconda-Platform","html_url":"https://github.com/Anaconda-Platform","followers_url":"https://api.github.com/users/Anaconda-Platform/followers","following_url":"https://api.github.com/users/Anaconda-Platform/following{/other_user}","gists_url":"https://api.github.com/users/Anaconda-Platform/gists{/gist_id}","starred_url":"https://api.github.com/users/Anaconda-Platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anaconda-Platform/subscriptions","organizations_url":"https://api.github.com/users/Anaconda-Platform/orgs","repos_url":"https://api.github.com/users/Anaconda-Platform/repos","events_url":"https://api.github.com/users/Anaconda-Platform/events{/privacy}","received_events_url":"https://api.github.com/users/Anaconda-Platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Anaconda-Platform/nb_conda","description":"Conda environment and package access extension from within Jupyter","fork":false,"url":"https://api.github.com/repos/Anaconda-Platform/nb_conda","forks_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/forks","keys_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/teams","hooks_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/hooks","issue_events_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/events{/number}","events_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/events","assignees_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/assignees{/user}","branches_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/branches{/branch}","tags_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/tags","blobs_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/statuses/{sha}","languages_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/languages","stargazers_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/stargazers","contributors_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/contributors","subscribers_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/subscribers","subscription_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/subscription","commits_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/contents/{+path}","compare_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/merges","archive_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/downloads","issues_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues{/number}","pulls_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls{/number}","milestones_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/milestones{/number}","notifications_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/labels{/name}","releases_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/releases{/id}","deployments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/deployments","created_at":"2015-12-09T23:12:58Z","updated_at":"2016-12-05T18:30:44Z","pushed_at":"2016-12-12T18:36:30Z","git_url":"git://github.com/Anaconda-Platform/nb_conda.git","ssh_url":"git@github.com:Anaconda-Platform/nb_conda.git","clone_url":"https://github.com/Anaconda-Platform/nb_conda.git","svn_url":"https://github.com/Anaconda-Platform/nb_conda","homepage":null,"size":102,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":6,"default_branch":"master"}},"base":{"label":"Anaconda-Platform:master","ref":"master","sha":"3364053f09f07d77bc3c97a84f853d7c2986f7cb","user":{"login":"Anaconda-Platform","id":3571983,"avatar_url":"https://avatars.githubusercontent.com/u/3571983?v=3","gravatar_id":"","url":"https://api.github.com/users/Anaconda-Platform","html_url":"https://github.com/Anaconda-Platform","followers_url":"https://api.github.com/users/Anaconda-Platform/followers","following_url":"https://api.github.com/users/Anaconda-Platform/following{/other_user}","gists_url":"https://api.github.com/users/Anaconda-Platform/gists{/gist_id}","starred_url":"https://api.github.com/users/Anaconda-Platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anaconda-Platform/subscriptions","organizations_url":"https://api.github.com/users/Anaconda-Platform/orgs","repos_url":"https://api.github.com/users/Anaconda-Platform/repos","events_url":"https://api.github.com/users/Anaconda-Platform/events{/privacy}","received_events_url":"https://api.github.com/users/Anaconda-Platform/received_events","type":"Organization","site_admin":false},"repo":{"id":47725040,"name":"nb_conda","full_name":"Anaconda-Platform/nb_conda","owner":{"login":"Anaconda-Platform","id":3571983,"avatar_url":"https://avatars.githubusercontent.com/u/3571983?v=3","gravatar_id":"","url":"https://api.github.com/users/Anaconda-Platform","html_url":"https://github.com/Anaconda-Platform","followers_url":"https://api.github.com/users/Anaconda-Platform/followers","following_url":"https://api.github.com/users/Anaconda-Platform/following{/other_user}","gists_url":"https://api.github.com/users/Anaconda-Platform/gists{/gist_id}","starred_url":"https://api.github.com/users/Anaconda-Platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anaconda-Platform/subscriptions","organizations_url":"https://api.github.com/users/Anaconda-Platform/orgs","repos_url":"https://api.github.com/users/Anaconda-Platform/repos","events_url":"https://api.github.com/users/Anaconda-Platform/events{/privacy}","received_events_url":"https://api.github.com/users/Anaconda-Platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Anaconda-Platform/nb_conda","description":"Conda environment and package access extension from within Jupyter","fork":false,"url":"https://api.github.com/repos/Anaconda-Platform/nb_conda","forks_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/forks","keys_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/teams","hooks_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/hooks","issue_events_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/events{/number}","events_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/events","assignees_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/assignees{/user}","branches_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/branches{/branch}","tags_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/tags","blobs_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/statuses/{sha}","languages_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/languages","stargazers_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/stargazers","contributors_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/contributors","subscribers_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/subscribers","subscription_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/subscription","commits_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/contents/{+path}","compare_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/merges","archive_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/downloads","issues_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues{/number}","pulls_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls{/number}","milestones_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/milestones{/number}","notifications_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/labels{/name}","releases_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/releases{/id}","deployments_url":"https://api.github.com/repos/Anaconda-Platform/nb_conda/deployments","created_at":"2015-12-09T23:12:58Z","updated_at":"2016-12-05T18:30:44Z","pushed_at":"2016-12-12T18:36:30Z","git_url":"git://github.com/Anaconda-Platform/nb_conda.git","ssh_url":"git@github.com:Anaconda-Platform/nb_conda.git","clone_url":"https://github.com/Anaconda-Platform/nb_conda.git","svn_url":"https://github.com/Anaconda-Platform/nb_conda","homepage":null,"size":102,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37"},"html":{"href":"https://github.com/Anaconda-Platform/nb_conda/pull/37"},"issue":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/37"},"comments":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Anaconda-Platform/nb_conda/statuses/178d0aa0b29f82a1a53fa61556ea334f5a74d888"}}}}
{"actor":{"display_login":"damianavila"}}