{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/57047399","id":57047399,"diff_hunk":"@@ -25,11 +25,13 @@\n class CHtpasswdSecurityManager : public CBaseSecurityManager\n {\n public:\n-    CHtpasswdSecurityManager(const char *serviceName, IPropertyTree *authconfig) : CBaseSecurityManager(serviceName, (IPropertyTree *)NULL)\n+    CHtpasswdSecurityManager(const char *serviceName, IPropertyTree *secMgrCfg, IPropertyTree *authconfig) : CBaseSecurityManager(serviceName, (IPropertyTree *)NULL)","path":"system/security/plugins/htpasswdSecurity/htpasswdSecurity.cpp","position":5,"original_position":5,"commit_id":"924f8478affd16b00a93efa44a1791b449da0d03","original_commit_id":"924f8478affd16b00a93efa44a1791b449da0d03","user":{"login":"rpastrana","id":915949,"avatar_url":"https://avatars.githubusercontent.com/u/915949?v=3","gravatar_id":"","url":"https://api.github.com/users/rpastrana","html_url":"https://github.com/rpastrana","followers_url":"https://api.github.com/users/rpastrana/followers","following_url":"https://api.github.com/users/rpastrana/following{/other_user}","gists_url":"https://api.github.com/users/rpastrana/gists{/gist_id}","starred_url":"https://api.github.com/users/rpastrana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpastrana/subscriptions","organizations_url":"https://api.github.com/users/rpastrana/orgs","repos_url":"https://api.github.com/users/rpastrana/repos","events_url":"https://api.github.com/users/rpastrana/events{/privacy}","received_events_url":"https://api.github.com/users/rpastrana/received_events","type":"User","site_admin":false},"body":"nitpick but some arguments use camel, one all lowers...","created_at":"2016-03-22T18:54:56Z","updated_at":"2016-03-22T18:54:56Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381#discussion_r57047399","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/57047399"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381#discussion_r57047399"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381","id":63770409,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8381","number":8381,"state":"open","locked":false,"title":"HPCC-15047 Refactor HTPass into an embedded SecManager plugin","user":{"login":"RussWhitehead","id":903145,"avatar_url":"https://avatars.githubusercontent.com/u/903145?v=3","gravatar_id":"","url":"https://api.github.com/users/RussWhitehead","html_url":"https://github.com/RussWhitehead","followers_url":"https://api.github.com/users/RussWhitehead/followers","following_url":"https://api.github.com/users/RussWhitehead/following{/other_user}","gists_url":"https://api.github.com/users/RussWhitehead/gists{/gist_id}","starred_url":"https://api.github.com/users/RussWhitehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussWhitehead/subscriptions","organizations_url":"https://api.github.com/users/RussWhitehead/orgs","repos_url":"https://api.github.com/users/RussWhitehead/repos","events_url":"https://api.github.com/users/RussWhitehead/events{/privacy}","received_events_url":"https://api.github.com/users/RussWhitehead/received_events","type":"User","site_admin":false},"body":"Refactor HTPasswrd security manager to be a true plugin. Add files for\r\nconfigmanager to gather common plugin artifacts and custom HTPassword\r\nspecific\r\n\r\nSigned-off-by: Russ Whitehead <william.whitehead@lexisnexis.com>\r\n\r\nSigned-off-by: Russ Whitehead <william.whitehead@lexisnexis.com>","created_at":"2016-03-22T18:33:14Z","updated_at":"2016-03-22T18:54:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70f7ec76d098db4fb5b3711d58e41bc371363c1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8381/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/924f8478affd16b00a93efa44a1791b449da0d03","head":{"label":"RussWhitehead:pluggableHTPwd","ref":"pluggableHTPwd","sha":"924f8478affd16b00a93efa44a1791b449da0d03","user":{"login":"RussWhitehead","id":903145,"avatar_url":"https://avatars.githubusercontent.com/u/903145?v=3","gravatar_id":"","url":"https://api.github.com/users/RussWhitehead","html_url":"https://github.com/RussWhitehead","followers_url":"https://api.github.com/users/RussWhitehead/followers","following_url":"https://api.github.com/users/RussWhitehead/following{/other_user}","gists_url":"https://api.github.com/users/RussWhitehead/gists{/gist_id}","starred_url":"https://api.github.com/users/RussWhitehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussWhitehead/subscriptions","organizations_url":"https://api.github.com/users/RussWhitehead/orgs","repos_url":"https://api.github.com/users/RussWhitehead/repos","events_url":"https://api.github.com/users/RussWhitehead/events{/privacy}","received_events_url":"https://api.github.com/users/RussWhitehead/received_events","type":"User","site_admin":false},"repo":{"id":3787938,"name":"HPCC-Platform","full_name":"RussWhitehead/HPCC-Platform","owner":{"login":"RussWhitehead","id":903145,"avatar_url":"https://avatars.githubusercontent.com/u/903145?v=3","gravatar_id":"","url":"https://api.github.com/users/RussWhitehead","html_url":"https://github.com/RussWhitehead","followers_url":"https://api.github.com/users/RussWhitehead/followers","following_url":"https://api.github.com/users/RussWhitehead/following{/other_user}","gists_url":"https://api.github.com/users/RussWhitehead/gists{/gist_id}","starred_url":"https://api.github.com/users/RussWhitehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussWhitehead/subscriptions","organizations_url":"https://api.github.com/users/RussWhitehead/orgs","repos_url":"https://api.github.com/users/RussWhitehead/repos","events_url":"https://api.github.com/users/RussWhitehead/events{/privacy}","received_events_url":"https://api.github.com/users/RussWhitehead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RussWhitehead/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform","forks_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/RussWhitehead/HPCC-Platform/deployments","created_at":"2012-03-21T15:21:21Z","updated_at":"2015-05-06T12:47:37Z","pushed_at":"2016-03-22T18:54:37Z","git_url":"git://github.com/RussWhitehead/HPCC-Platform.git","ssh_url":"git@github.com:RussWhitehead/HPCC-Platform.git","clone_url":"https://github.com/RussWhitehead/HPCC-Platform.git","svn_url":"https://github.com/RussWhitehead/HPCC-Platform","homepage":"hpccsystems.com","size":164328,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"candidate-3.2.x"}},"base":{"label":"hpcc-systems:candidate-6.0.0","ref":"candidate-6.0.0","sha":"8d36c353e9a412789a2c1be826055362a9e6936f","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-03-15T12:22:23Z","pushed_at":"2016-03-22T18:33:15Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":194227,"stargazers_count":271,"watchers_count":271,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":434,"forks":136,"open_issues":434,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8381"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8381"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8381/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8381/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/924f8478affd16b00a93efa44a1791b449da0d03"}}}}