{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/52048262","id":52048262,"diff_hunk":"@@ -35,8 +35,10 @@ TESTFLAGS    :=\n STRESSFLAGS  :=\n DUPLFLAGS    := -t 100\n BUILDMODE    := install\n+GOPATH       := $(realpath ../../../..)","path":"Makefile","position":4,"original_position":4,"commit_id":"72290dfcd258b89c79ecd8a2ee4cb2d56c49079f","original_commit_id":"72290dfcd258b89c79ecd8a2ee4cb2d56c49079f","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"I agree for vendoring the important thing is that it builds correctly through go. But people might still find it useful to e.g. run `make test` to make sure what they are using is not broken.\r\n\r\nBut making the Makefile detect this is not very easy. I think what is reasonable is to do some effort to check that ../../../.. is indeed the root of a go path; if it is not just don't set GOPATH and assume it is already set correctly. I'll try that\r\n","created_at":"2016-02-05T17:46:42Z","updated_at":"2016-02-05T17:46:42Z","html_url":"https://github.com/cockroachdb/cockroach/pull/4141#discussion_r52048262","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/52048262"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/4141#discussion_r52048262"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141","id":58331719,"html_url":"https://github.com/cockroachdb/cockroach/pull/4141","diff_url":"https://github.com/cockroachdb/cockroach/pull/4141.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4141.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4141","number":4141,"state":"open","locked":false,"title":"Makefile check if GOPATH is correctly set","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"The change adds a bit of logic in Makefile to check that GOPATH resolves to a\r\nprefix of the cockroach directory. This is useful when using multiple GOPATHs.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4141)\n<!-- Reviewable:end -->\n","created_at":"2016-02-04T18:56:29Z","updated_at":"2016-02-05T17:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f30888e73cbcd91da27661400e986ac21999aec7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4141/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/72290dfcd258b89c79ecd8a2ee4cb2d56c49079f","head":{"label":"RaduBerinde:make-gopath","ref":"make-gopath","sha":"72290dfcd258b89c79ecd8a2ee4cb2d56c49079f","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"repo":{"id":49111463,"name":"cockroach","full_name":"RaduBerinde/cockroach","owner":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaduBerinde/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/RaduBerinde/cockroach","forks_url":"https://api.github.com/repos/RaduBerinde/cockroach/forks","keys_url":"https://api.github.com/repos/RaduBerinde/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaduBerinde/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaduBerinde/cockroach/teams","hooks_url":"https://api.github.com/repos/RaduBerinde/cockroach/hooks","issue_events_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/RaduBerinde/cockroach/events","assignees_url":"https://api.github.com/repos/RaduBerinde/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/RaduBerinde/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/tags","blobs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaduBerinde/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/RaduBerinde/cockroach/languages","stargazers_url":"https://api.github.com/repos/RaduBerinde/cockroach/stargazers","contributors_url":"https://api.github.com/repos/RaduBerinde/cockroach/contributors","subscribers_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscribers","subscription_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscription","commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaduBerinde/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaduBerinde/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/RaduBerinde/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaduBerinde/cockroach/merges","archive_url":"https://api.github.com/repos/RaduBerinde/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaduBerinde/cockroach/downloads","issues_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/RaduBerinde/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/RaduBerinde/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/RaduBerinde/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaduBerinde/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/RaduBerinde/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/RaduBerinde/cockroach/deployments","created_at":"2016-01-06T04:07:30Z","updated_at":"2016-01-14T02:30:27Z","pushed_at":"2016-02-04T23:10:44Z","git_url":"git://github.com/RaduBerinde/cockroach.git","ssh_url":"git@github.com:RaduBerinde/cockroach.git","clone_url":"https://github.com/RaduBerinde/cockroach.git","svn_url":"https://github.com/RaduBerinde/cockroach","homepage":"http://www.cockroachlabs.com","size":55955,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"a9e8dfba131cf2b5ab481da6b235ab03a5794f9b","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-02-05T14:56:05Z","pushed_at":"2016-02-05T17:31:02Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"http://www.cockroachlabs.com","size":64846,"stargazers_count":6147,"watchers_count":6147,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":555,"mirror_url":null,"open_issues_count":269,"forks":555,"open_issues":269,"watchers":6147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/4141"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/4141"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/4141/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4141/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/72290dfcd258b89c79ecd8a2ee4cb2d56c49079f"}}}}