{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-packager/pulls/comments/51280141","id":51280141,"diff_hunk":"@@ -788,30 +788,29 @@ def ForceFullRepropose\n       nil\n     end\n \n-    # Reset package selection, but keep objects of specified type\n-    # @param [Array<Symbol>] keep a list of symbols specifying type of objects to be kept\n+    # Reset package selection, but keep the selected objects of the specified type\n+    # @param [Array<Symbol>] keep a list of symbols specifying type of objects to be kept selected\n     def Reset(keep)\n-      keep = deep_copy(keep)\n       restore = []\n-      Builtins.foreach(keep) do |type|\n-        selected = Pkg.ResolvableProperties(\"\", type, \"\")\n-        Builtins.foreach(selected) do |s|\n-          restore = Builtins.add(\n-            restore,\n-            { \"type\" => type, \"name\" => Ops.get_string(s, \"name\", \"\") }\n-          )\n+\n+      # collect the currently selected resolvables\n+      keep.each do |type|","path":"src/modules/Packages.rb","position":20,"original_position":20,"commit_id":"f7ad54ff22662abd8dabff3e23e0326118651d9c","original_commit_id":"f7ad54ff22662abd8dabff3e23e0326118651d9c","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?v=3","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"But we need to run this loop for each `keep` value, we would need to merge the results....\r\n\r\n```ruby\r\nrestore.merge(resolvables.each_object ....)\r\n```\r\n\r\nI'm not sure if that would better readable than the current code... :worried: ","created_at":"2016-01-29T16:20:16Z","updated_at":"2016-01-29T16:20:16Z","html_url":"https://github.com/yast/yast-packager/pull/147#discussion_r51280141","pull_request_url":"https://api.github.com/repos/yast/yast-packager/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/comments/51280141"},"html":{"href":"https://github.com/yast/yast-packager/pull/147#discussion_r51280141"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-packager/pulls/147","id":57649783,"html_url":"https://github.com/yast/yast-packager/pull/147","diff_url":"https://github.com/yast/yast-packager/pull/147.diff","patch_url":"https://github.com/yast/yast-packager/pull/147.patch","issue_url":"https://api.github.com/repos/yast/yast-packager/issues/147","number":147,"state":"open","locked":false,"title":"Merge the SP1 product selection fix to master","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?v=3","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-29T13:53:56Z","updated_at":"2016-01-29T16:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd2709d93c54328ece3915c80afcd721212728bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-packager/pulls/147/commits","review_comments_url":"https://api.github.com/repos/yast/yast-packager/pulls/147/comments","review_comment_url":"https://api.github.com/repos/yast/yast-packager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-packager/issues/147/comments","statuses_url":"https://api.github.com/repos/yast/yast-packager/statuses/f7ad54ff22662abd8dabff3e23e0326118651d9c","head":{"label":"yast:merge_SP1","ref":"merge_SP1","sha":"f7ad54ff22662abd8dabff3e23e0326118651d9c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368179,"name":"yast-packager","full_name":"yast/yast-packager","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-packager","description":"YaST module packager","fork":false,"url":"https://api.github.com/repos/yast/yast-packager","forks_url":"https://api.github.com/repos/yast/yast-packager/forks","keys_url":"https://api.github.com/repos/yast/yast-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-packager/teams","hooks_url":"https://api.github.com/repos/yast/yast-packager/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-packager/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-packager/events","assignees_url":"https://api.github.com/repos/yast/yast-packager/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-packager/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-packager/tags","blobs_url":"https://api.github.com/repos/yast/yast-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-packager/languages","stargazers_url":"https://api.github.com/repos/yast/yast-packager/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-packager/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-packager/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-packager/subscription","commits_url":"https://api.github.com/repos/yast/yast-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-packager/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-packager/merges","archive_url":"https://api.github.com/repos/yast/yast-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-packager/downloads","issues_url":"https://api.github.com/repos/yast/yast-packager/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-packager/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-packager/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-packager/deployments","created_at":"2012-05-18T10:25:23Z","updated_at":"2015-05-07T14:53:47Z","pushed_at":"2016-01-29T15:18:22Z","git_url":"git://github.com/yast/yast-packager.git","ssh_url":"git@github.com:yast/yast-packager.git","clone_url":"https://github.com/yast/yast-packager.git","svn_url":"https://github.com/yast/yast-packager","homepage":"http://en.opensuse.org/Portal:YaST","size":29923,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"09d86d67e6c49b86498390e8f918b2cf28861638","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368179,"name":"yast-packager","full_name":"yast/yast-packager","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-packager","description":"YaST module packager","fork":false,"url":"https://api.github.com/repos/yast/yast-packager","forks_url":"https://api.github.com/repos/yast/yast-packager/forks","keys_url":"https://api.github.com/repos/yast/yast-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-packager/teams","hooks_url":"https://api.github.com/repos/yast/yast-packager/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-packager/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-packager/events","assignees_url":"https://api.github.com/repos/yast/yast-packager/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-packager/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-packager/tags","blobs_url":"https://api.github.com/repos/yast/yast-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-packager/languages","stargazers_url":"https://api.github.com/repos/yast/yast-packager/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-packager/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-packager/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-packager/subscription","commits_url":"https://api.github.com/repos/yast/yast-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-packager/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-packager/merges","archive_url":"https://api.github.com/repos/yast/yast-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-packager/downloads","issues_url":"https://api.github.com/repos/yast/yast-packager/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-packager/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-packager/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-packager/deployments","created_at":"2012-05-18T10:25:23Z","updated_at":"2015-05-07T14:53:47Z","pushed_at":"2016-01-29T15:18:22Z","git_url":"git://github.com/yast/yast-packager.git","ssh_url":"git@github.com:yast/yast-packager.git","clone_url":"https://github.com/yast/yast-packager.git","svn_url":"https://github.com/yast/yast-packager","homepage":"http://en.opensuse.org/Portal:YaST","size":29923,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/147"},"html":{"href":"https://github.com/yast/yast-packager/pull/147"},"issue":{"href":"https://api.github.com/repos/yast/yast-packager/issues/147"},"comments":{"href":"https://api.github.com/repos/yast/yast-packager/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-packager/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-packager/statuses/f7ad54ff22662abd8dabff3e23e0326118651d9c"}}}}