{"action":"closed","issue":{"url":"https://api.github.com/repos/astropy/pyregion/issues/89","repository_url":"https://api.github.com/repos/astropy/pyregion","labels_url":"https://api.github.com/repos/astropy/pyregion/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/astropy/pyregion/issues/89/comments","events_url":"https://api.github.com/repos/astropy/pyregion/issues/89/events","html_url":"https://github.com/astropy/pyregion/issues/89","id":169091687,"number":89,"title":"Change rot_wrt_axis default?","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/pyregion/labels/question","name":"question","color":"0e8a16"}],"state":"closed","locked":false,"assignee":{"login":"leejjoon","id":95962,"avatar_url":"https://avatars.githubusercontent.com/u/95962?v=3","gravatar_id":"","url":"https://api.github.com/users/leejjoon","html_url":"https://github.com/leejjoon","followers_url":"https://api.github.com/users/leejjoon/followers","following_url":"https://api.github.com/users/leejjoon/following{/other_user}","gists_url":"https://api.github.com/users/leejjoon/gists{/gist_id}","starred_url":"https://api.github.com/users/leejjoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leejjoon/subscriptions","organizations_url":"https://api.github.com/users/leejjoon/orgs","repos_url":"https://api.github.com/users/leejjoon/repos","events_url":"https://api.github.com/users/leejjoon/events{/privacy}","received_events_url":"https://api.github.com/users/leejjoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"leejjoon","id":95962,"avatar_url":"https://avatars.githubusercontent.com/u/95962?v=3","gravatar_id":"","url":"https://api.github.com/users/leejjoon","html_url":"https://github.com/leejjoon","followers_url":"https://api.github.com/users/leejjoon/followers","following_url":"https://api.github.com/users/leejjoon/following{/other_user}","gists_url":"https://api.github.com/users/leejjoon/gists{/gist_id}","starred_url":"https://api.github.com/users/leejjoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leejjoon/subscriptions","organizations_url":"https://api.github.com/users/leejjoon/orgs","repos_url":"https://api.github.com/users/leejjoon/repos","events_url":"https://api.github.com/users/leejjoon/events{/privacy}","received_events_url":"https://api.github.com/users/leejjoon/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/astropy/pyregion/milestones/4","html_url":"https://github.com/astropy/pyregion/milestones/2.0","labels_url":"https://api.github.com/repos/astropy/pyregion/milestones/4/labels","id":1923113,"number":4,"title":"2.0","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2016-08-04T08:25:11Z","updated_at":"2016-09-05T15:10:14Z","due_on":"2016-10-06T00:00:00Z","closed_at":null},"comments":8,"created_at":"2016-08-03T09:50:46Z","updated_at":"2016-09-05T15:10:14Z","closed_at":"2016-09-05T15:10:13Z","body":"In #84 I documented the `rot_wrt_axis` parameter as suggested by @leejjoon and @mcara .\r\n\r\nWhile doing this I read the following comment by @mcara in PR #34 where he introduced the parameter:\r\n> pyregion computes the image rotation angle using as the angle between North and X-axis instead of typically adopted convention of using Y-axis for image orientation computations. This produces regions that are rotated compared to the regions produced by DS9 when image axes are non-orthogonal (at least for HST images).\r\n\r\nThis sounds to me like the default should have been 2 (y-axis), to be consistent with what `ds9` does (always or by default). Currently the default is 1 (x-axis), and if a user doesn't know about or set this option, they get a result different from what DS9 gives?\r\n\r\n@mcara @leejjoon @keflavich  - Is that correct?\r\n\r\nIf yes, should we treat this as a bug and change the default for the upcoming 1.2 release (or call that version 2.0 to allow for such braking changes).\r\n\r\nFor now, I'm putting this under the \"whishlist\" milestone and tag it \"question\", i.e. if I don't hear back here or there's no consensus what to do, I'll just release v1.2 as-is and leave this to the future."}}
{"actor":{"display_login":"sargas"}}