{"push_id":1002938561,"size":130,"distinct_size":130,"ref":"refs/heads/map_download_ux","head":"85f2e276b8bb3235451d9cfd86d596bb0b17cd3c","before":"74adefa9f0281cf60143aa5b9e6074bf0a6f932a","commits":[{"sha":"2a6fb2fc63645d2476f7fa888e6960b5703ba1e9","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Cleanup] Small refactor, move private method 'sortAAHighToLow'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/2a6fb2fc63645d2476f7fa888e6960b5703ba1e9"},{"sha":"1cd12f091bb29651f77fa8f9448f7dcf9e4ee0eb","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Cleanup] Remove unused GameData parameter in method: 'getTotalAAattacks'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/1cd12f091bb29651f77fa8f9448f7dcf9e4ee0eb"},{"sha":"a4cd453c77a1b9d1243695c93a4f6c4588fa1b4c","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove unused Territory parameter in BattleCalculator private static method: 'IndividuallyFiredAACasualties'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/a4cd453c77a1b9d1243695c93a4f6c4588fa1b4c"},{"sha":"002fa63d43305858ec095cc358ceda7878453a6d","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove unused GameData parameter in a public static method: 'sortPreBattle'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/002fa63d43305858ec095cc358ceda7878453a6d"},{"sha":"c3d69c4e41050a0265c1a67fd00fe2b0e38fc0f9","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove two unused args in a private static method: 'categorizeLowLuckAirUnits'.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/c3d69c4e41050a0265c1a67fd00fe2b0e38fc0f9"},{"sha":"0d7437a4711b1286c44bd5286dd6dc6f29725490","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove unused arg in private static method 'categorizeLowLuckAirUnits'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/0d7437a4711b1286c44bd5286dd6dc6f29725490"},{"sha":"a787b26d44fef86602b3dbed89ec357cf43140c8","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove unused territory arg in public static method: 'getRolls', and remove further unused args that were required to support the previous getRolls API.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/a787b26d44fef86602b3dbed89ec357cf43140c8"},{"sha":"deb451a71d2764f6d2fd235ae17dfa6d814215dd","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove unused args from private static method: 'sortUnitsForCasualtiesWithSupportNewWithCaching'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/deb451a71d2764f6d2fd235ae17dfa6d814215dd"},{"sha":"c2920eec5d7236339f318f35b1353e18b196d403","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] Remove friendlyUnits unused arg","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/c2920eec5d7236339f318f35b1353e18b196d403"},{"sha":"7a0fcc84b9f5acc41f9b5c5d4eecf975a6f95be1","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll getTotalPowerAndRolls Cleanup] Add two new methods: 'getTotalPower' and 'getTotalRolls', next commits will break up calls from 'getTotalPowerAndRolls' to those two methods instead.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/7a0fcc84b9f5acc41f9b5c5d4eecf975a6f95be1"},{"sha":"23bb6a9c240bab94ec21b47fa8d0610ca80fd2c1","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":" [DiceRoll getTotalPowerAndRolls Cleanup] Break up client usages of calls to DiceRoll method 'getTotalPowerAndRolls' to instead one of the new methods: 'getTotalPower' or 'getTotalRolls'. After this commit, all such breaks are fixed. It does turn out the 'getTotalRolls' method is never actually used outside of the DiceRoll class.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/23bb6a9c240bab94ec21b47fa8d0610ca80fd2c1"},{"sha":"44047c13432210fafc76d8b9e0596ecf819e981f","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll getTotalPowerAndRolls Cleanup] - Finish breaking up usages of previous methods calls to 'getTotalPowerAndRolls'. Calls to 'getTotalRolls' are private, so we can call the old implementation method that returns a tuple, and otherwise remove the unused 'getTotalRolls()' method. Turns out client classes only need 'getTotalPower()' only.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/44047c13432210fafc76d8b9e0596ecf819e981f"},{"sha":"e31f47d41d1b41a11fa223af24015e62b47b843c","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Cleanup] DiceRoll, remove empty javadocs","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/e31f47d41d1b41a11fa223af24015e62b47b843c"},{"sha":"6bfa5b73f1f9b0668048df4b630fd666c137c774","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Cleanup] Remove unused Player arg from method getUnitPowerAndRollsForNormalBattles, and mark it as protected from public.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/6bfa5b73f1f9b0668048df4b630fd666c137c774"},{"sha":"ccaeef9240955561456bfccf4da113f370530674","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Cleanup] Remove newly unused player arg from DiceRoll method 'getUnitPowerAndRollsForNormalBattles()'. A few other methods forwarded the same player arg value, so remove those as well since they were newly unused as well. Last, small cleanup fix in ProBattleUtils to avoid calling 'new ArrayList<...>', in favor of calling 'Lists.newArrayList()'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/ccaeef9240955561456bfccf4da113f370530674"},{"sha":"2245d704758181d9242728fb75ac34905a861262","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Simplify] Code cleanup/simplifications in method 'rollNDice'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/2245d704758181d9242728fb75ac34905a861262"},{"sha":"6ea6a7dd020dd714b7a14f286788a58d1111974a","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Dup Arg Cleanup] In method 'getUnitPowerAndRollsForNormalBattles', the first two args are always duplicated by each caller of the method. Simplify the method so the duplicated arg is dropped.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/6ea6a7dd020dd714b7a14f286788a58d1111974a"},{"sha":"d421158d25ed5923d73f44f6b0e396a5ce726477","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRoll Dup Arg Cleanup] Finish getting rid of the duplicate parameter value for DiceRoll method 'getUnitPowerAndRollsForNormalBattles'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/d421158d25ed5923d73f44f6b0e396a5ce726477"},{"sha":"4da7d6a951c066c5df91698a7a34d81260b3d40a","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[BattleCalculator Cleanup] BattleCalculator remove unused 'enemyPlayer' arg.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/4da7d6a951c066c5df91698a7a34d81260b3d40a"},{"sha":"feb3e6c4fae54d2aa922f7a9506afe943b75b1fd","author":{"email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com","name":"DanVanAtta"},"message":"[DiceRollTest Cleanup] Remove calls to deprecated method 'loadGame(String,String)' and replace with 'loadTestGame(String)'","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/feb3e6c4fae54d2aa922f7a9506afe943b75b1fd"}]}