{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/87588736","pull_request_review_id":8197004,"id":87588736,"diff_hunk":"@@ -62,14 +62,14 @@ public static void createTables(KeyValueService kvs, Map<TableReference, TableDe\n         kvs.createTables(tableRefToMetadata);\n     }\n \n-    public static String getFullTableName(String tableName, Namespace namespace) {\n+    public static String getTableReferenceString(String tableName, Namespace namespace) {\n         Preconditions.checkArgument(isTableNameValid(tableName), \"%s is not a valid table name\", tableName);\n         String namespaceName = namespace.getName();\n         // Hacks for schemas that were created before namespaces were created.\n         if (namespace.isEmptyNamespace() || namespaceName.equals(\"met\")) {\n-            return tableName;\n+            return \"TableReference.createWithEmptyNamespace(\\\"\" + tableName + \"\\\")\";\n         } else {\n-            return namespace.getName() + \".\" + tableName;\n+            return \"TableReference.createFromFullyQualifiedName(\\\"\" + namespace.getName() + \".\" + tableName + \"\\\")\";","path":"atlasdb-client/src/main/java/com/palantir/atlasdb/table/description/Schemas.java","position":14,"original_position":14,"commit_id":"c5c1ec945a91d1b444f10c5a3d1259ea079bc26a","original_commit_id":"16d3e863c6dd50904b8aae4629c70989acaee619","user":{"login":"gsheasby","id":15610492,"avatar_url":"https://avatars.githubusercontent.com/u/15610492?v=3","gravatar_id":"","url":"https://api.github.com/users/gsheasby","html_url":"https://github.com/gsheasby","followers_url":"https://api.github.com/users/gsheasby/followers","following_url":"https://api.github.com/users/gsheasby/following{/other_user}","gists_url":"https://api.github.com/users/gsheasby/gists{/gist_id}","starred_url":"https://api.github.com/users/gsheasby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsheasby/subscriptions","organizations_url":"https://api.github.com/users/gsheasby/orgs","repos_url":"https://api.github.com/users/gsheasby/repos","events_url":"https://api.github.com/users/gsheasby/events{/privacy}","received_events_url":"https://api.github.com/users/gsheasby/received_events","type":"User","site_admin":false},"body":"This is a public method that we're changing here, and the change will be breaking for anyone who used `getFullTableName`. Did you check that this method is unused?","created_at":"2016-11-11T13:39:15Z","updated_at":"2016-11-11T13:39:15Z","html_url":"https://github.com/palantir/atlasdb/pull/1194#discussion_r87588736","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1194","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/87588736"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1194#discussion_r87588736"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1194"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/1194","id":93230682,"html_url":"https://github.com/palantir/atlasdb/pull/1194","diff_url":"https://github.com/palantir/atlasdb/pull/1194.diff","patch_url":"https://github.com/palantir/atlasdb/pull/1194.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/1194","number":1194,"state":"open","locked":false,"title":"Fix/remove create unsafe from gen code","user":{"login":"hsaraogi","id":20421615,"avatar_url":"https://avatars.githubusercontent.com/u/20421615?v=3","gravatar_id":"","url":"https://api.github.com/users/hsaraogi","html_url":"https://github.com/hsaraogi","followers_url":"https://api.github.com/users/hsaraogi/followers","following_url":"https://api.github.com/users/hsaraogi/following{/other_user}","gists_url":"https://api.github.com/users/hsaraogi/gists{/gist_id}","starred_url":"https://api.github.com/users/hsaraogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsaraogi/subscriptions","organizations_url":"https://api.github.com/users/hsaraogi/orgs","repos_url":"https://api.github.com/users/hsaraogi/repos","events_url":"https://api.github.com/users/hsaraogi/events{/privacy}","received_events_url":"https://api.github.com/users/hsaraogi/received_events","type":"User","site_admin":false},"body":"This closes #1172.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/1194)\n<!-- Reviewable:end -->\n","created_at":"2016-11-10T21:06:43Z","updated_at":"2016-11-11T13:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34abcdbc33312abb26bdd140ba15c18592f5570d","assignee":{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},"assignees":[{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},{"login":"gsheasby","id":15610492,"avatar_url":"https://avatars.githubusercontent.com/u/15610492?v=3","gravatar_id":"","url":"https://api.github.com/users/gsheasby","html_url":"https://github.com/gsheasby","followers_url":"https://api.github.com/users/gsheasby/followers","following_url":"https://api.github.com/users/gsheasby/following{/other_user}","gists_url":"https://api.github.com/users/gsheasby/gists{/gist_id}","starred_url":"https://api.github.com/users/gsheasby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsheasby/subscriptions","organizations_url":"https://api.github.com/users/gsheasby/orgs","repos_url":"https://api.github.com/users/gsheasby/repos","events_url":"https://api.github.com/users/gsheasby/events{/privacy}","received_events_url":"https://api.github.com/users/gsheasby/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/1194/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/c5c1ec945a91d1b444f10c5a3d1259ea079bc26a","head":{"label":"palantir:fix/remove-create-unsafe-from-gen-code","ref":"fix/remove-create-unsafe-from-gen-code","sha":"c5c1ec945a91d1b444f10c5a3d1259ea079bc26a","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-11T07:29:34Z","pushed_at":"2016-11-11T13:36:45Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28249,"stargazers_count":399,"watchers_count":399,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":97,"forks":62,"open_issues":97,"watchers":399,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"505fe0ffd1328548cc5b340b9e4c013ab2072896","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-11T07:29:34Z","pushed_at":"2016-11-11T13:36:45Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28249,"stargazers_count":399,"watchers_count":399,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":97,"forks":62,"open_issues":97,"watchers":399,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1194"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1194"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1194"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/c5c1ec945a91d1b444f10c5a3d1259ea079bc26a"}}}}
{"actor":{"display_login":"gsheasby"}}