{"action":"created","comment":{"url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/comments/93214074","pull_request_review_id":13735541,"id":93214074,"diff_hunk":"@@ -976,7 +976,7 @@ pub enum rd_kafka_queue_s { }\n pub type rd_kafka_queue_t = rd_kafka_queue_s;\n #[derive(Copy, Clone)]\n #[repr(i32)]\n-#[derive(Debug)]\n+#[derive(Debug,PartialEq)]","path":"rdkafka-sys/src/bindings.rs","position":5,"original_position":5,"commit_id":"6b8be6d5fb30fa710248244385bd4a6e64491180","original_commit_id":"b5c3445ae004017c9310ab639c22d5cd8f00d6a4","user":{"login":"fede1024","id":1543631,"avatar_url":"https://avatars.githubusercontent.com/u/1543631?v=3","gravatar_id":"","url":"https://api.github.com/users/fede1024","html_url":"https://github.com/fede1024","followers_url":"https://api.github.com/users/fede1024/followers","following_url":"https://api.github.com/users/fede1024/following{/other_user}","gists_url":"https://api.github.com/users/fede1024/gists{/gist_id}","starred_url":"https://api.github.com/users/fede1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fede1024/subscriptions","organizations_url":"https://api.github.com/users/fede1024/orgs","repos_url":"https://api.github.com/users/fede1024/repos","events_url":"https://api.github.com/users/fede1024/events{/privacy}","received_events_url":"https://api.github.com/users/fede1024/received_events","type":"User","site_admin":false},"body":"I don't think there is any option to add it automatically via bindgen (command i used: `bindgen --builtins --convert-macros librdkafka-sys/librdkafka/src/rdkafka.h > outout.rs`).\r\n\r\nWe should be able to implement it directly, and we could add the implementation in src/types.rs. I've tried with the following snippet of code and the compiler doesn't complain:\r\n\r\n```rust\r\nimpl PartialEq for RDKafkaRespErr {                                                                                                                                                                                                             \r\n    fn eq(&self, other: &RDKafkaRespErr) -> bool {\r\n        self == other\r\n    }\r\n}\r\n```","created_at":"2016-12-20T10:56:15Z","updated_at":"2016-12-20T10:57:45Z","html_url":"https://github.com/fede1024/rust-rdkafka/pull/16#discussion_r93214074","pull_request_url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/comments/93214074"},"html":{"href":"https://github.com/fede1024/rust-rdkafka/pull/16#discussion_r93214074"},"pull_request":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16","id":98579871,"html_url":"https://github.com/fede1024/rust-rdkafka/pull/16","diff_url":"https://github.com/fede1024/rust-rdkafka/pull/16.diff","patch_url":"https://github.com/fede1024/rust-rdkafka/pull/16.patch","issue_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/16","number":16,"state":"open","locked":false,"title":"Add pause and resume to consumer","user":{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},"body":"Add pause and resume so you can pause consuming messages without triggering a rebalance.","created_at":"2016-12-19T14:59:54Z","updated_at":"2016-12-20T10:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8204183ded850480a848788607a3d9e2d48ca011","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16/commits","review_comments_url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16/comments","review_comment_url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/16/comments","statuses_url":"https://api.github.com/repos/fede1024/rust-rdkafka/statuses/6b8be6d5fb30fa710248244385bd4a6e64491180","head":{"label":"thijsc:pause_resume","ref":"pause_resume","sha":"6b8be6d5fb30fa710248244385bd4a6e64491180","user":{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},"repo":{"id":74666821,"name":"rust-rdkafka","full_name":"thijsc/rust-rdkafka","owner":{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thijsc/rust-rdkafka","description":"Kafka client library for Rust based on librdkafka","fork":true,"url":"https://api.github.com/repos/thijsc/rust-rdkafka","forks_url":"https://api.github.com/repos/thijsc/rust-rdkafka/forks","keys_url":"https://api.github.com/repos/thijsc/rust-rdkafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thijsc/rust-rdkafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thijsc/rust-rdkafka/teams","hooks_url":"https://api.github.com/repos/thijsc/rust-rdkafka/hooks","issue_events_url":"https://api.github.com/repos/thijsc/rust-rdkafka/issues/events{/number}","events_url":"https://api.github.com/repos/thijsc/rust-rdkafka/events","assignees_url":"https://api.github.com/repos/thijsc/rust-rdkafka/assignees{/user}","branches_url":"https://api.github.com/repos/thijsc/rust-rdkafka/branches{/branch}","tags_url":"https://api.github.com/repos/thijsc/rust-rdkafka/tags","blobs_url":"https://api.github.com/repos/thijsc/rust-rdkafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thijsc/rust-rdkafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thijsc/rust-rdkafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/thijsc/rust-rdkafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thijsc/rust-rdkafka/statuses/{sha}","languages_url":"https://api.github.com/repos/thijsc/rust-rdkafka/languages","stargazers_url":"https://api.github.com/repos/thijsc/rust-rdkafka/stargazers","contributors_url":"https://api.github.com/repos/thijsc/rust-rdkafka/contributors","subscribers_url":"https://api.github.com/repos/thijsc/rust-rdkafka/subscribers","subscription_url":"https://api.github.com/repos/thijsc/rust-rdkafka/subscription","commits_url":"https://api.github.com/repos/thijsc/rust-rdkafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/thijsc/rust-rdkafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/thijsc/rust-rdkafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/thijsc/rust-rdkafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/thijsc/rust-rdkafka/contents/{+path}","compare_url":"https://api.github.com/repos/thijsc/rust-rdkafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thijsc/rust-rdkafka/merges","archive_url":"https://api.github.com/repos/thijsc/rust-rdkafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thijsc/rust-rdkafka/downloads","issues_url":"https://api.github.com/repos/thijsc/rust-rdkafka/issues{/number}","pulls_url":"https://api.github.com/repos/thijsc/rust-rdkafka/pulls{/number}","milestones_url":"https://api.github.com/repos/thijsc/rust-rdkafka/milestones{/number}","notifications_url":"https://api.github.com/repos/thijsc/rust-rdkafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thijsc/rust-rdkafka/labels{/name}","releases_url":"https://api.github.com/repos/thijsc/rust-rdkafka/releases{/id}","deployments_url":"https://api.github.com/repos/thijsc/rust-rdkafka/deployments","created_at":"2016-11-24T11:25:43Z","updated_at":"2016-11-24T11:25:44Z","pushed_at":"2016-12-19T20:34:47Z","git_url":"git://github.com/thijsc/rust-rdkafka.git","ssh_url":"git@github.com:thijsc/rust-rdkafka.git","clone_url":"https://github.com/thijsc/rust-rdkafka.git","svn_url":"https://github.com/thijsc/rust-rdkafka","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fede1024:master","ref":"master","sha":"d23cfe399cd09194e741ba4e338f6843743a7f65","user":{"login":"fede1024","id":1543631,"avatar_url":"https://avatars.githubusercontent.com/u/1543631?v=3","gravatar_id":"","url":"https://api.github.com/users/fede1024","html_url":"https://github.com/fede1024","followers_url":"https://api.github.com/users/fede1024/followers","following_url":"https://api.github.com/users/fede1024/following{/other_user}","gists_url":"https://api.github.com/users/fede1024/gists{/gist_id}","starred_url":"https://api.github.com/users/fede1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fede1024/subscriptions","organizations_url":"https://api.github.com/users/fede1024/orgs","repos_url":"https://api.github.com/users/fede1024/repos","events_url":"https://api.github.com/users/fede1024/events{/privacy}","received_events_url":"https://api.github.com/users/fede1024/received_events","type":"User","site_admin":false},"repo":{"id":72286208,"name":"rust-rdkafka","full_name":"fede1024/rust-rdkafka","owner":{"login":"fede1024","id":1543631,"avatar_url":"https://avatars.githubusercontent.com/u/1543631?v=3","gravatar_id":"","url":"https://api.github.com/users/fede1024","html_url":"https://github.com/fede1024","followers_url":"https://api.github.com/users/fede1024/followers","following_url":"https://api.github.com/users/fede1024/following{/other_user}","gists_url":"https://api.github.com/users/fede1024/gists{/gist_id}","starred_url":"https://api.github.com/users/fede1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fede1024/subscriptions","organizations_url":"https://api.github.com/users/fede1024/orgs","repos_url":"https://api.github.com/users/fede1024/repos","events_url":"https://api.github.com/users/fede1024/events{/privacy}","received_events_url":"https://api.github.com/users/fede1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fede1024/rust-rdkafka","description":"Kafka client library for Rust based on librdkafka","fork":false,"url":"https://api.github.com/repos/fede1024/rust-rdkafka","forks_url":"https://api.github.com/repos/fede1024/rust-rdkafka/forks","keys_url":"https://api.github.com/repos/fede1024/rust-rdkafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fede1024/rust-rdkafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fede1024/rust-rdkafka/teams","hooks_url":"https://api.github.com/repos/fede1024/rust-rdkafka/hooks","issue_events_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/events{/number}","events_url":"https://api.github.com/repos/fede1024/rust-rdkafka/events","assignees_url":"https://api.github.com/repos/fede1024/rust-rdkafka/assignees{/user}","branches_url":"https://api.github.com/repos/fede1024/rust-rdkafka/branches{/branch}","tags_url":"https://api.github.com/repos/fede1024/rust-rdkafka/tags","blobs_url":"https://api.github.com/repos/fede1024/rust-rdkafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fede1024/rust-rdkafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fede1024/rust-rdkafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/fede1024/rust-rdkafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fede1024/rust-rdkafka/statuses/{sha}","languages_url":"https://api.github.com/repos/fede1024/rust-rdkafka/languages","stargazers_url":"https://api.github.com/repos/fede1024/rust-rdkafka/stargazers","contributors_url":"https://api.github.com/repos/fede1024/rust-rdkafka/contributors","subscribers_url":"https://api.github.com/repos/fede1024/rust-rdkafka/subscribers","subscription_url":"https://api.github.com/repos/fede1024/rust-rdkafka/subscription","commits_url":"https://api.github.com/repos/fede1024/rust-rdkafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/fede1024/rust-rdkafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/fede1024/rust-rdkafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/fede1024/rust-rdkafka/contents/{+path}","compare_url":"https://api.github.com/repos/fede1024/rust-rdkafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fede1024/rust-rdkafka/merges","archive_url":"https://api.github.com/repos/fede1024/rust-rdkafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fede1024/rust-rdkafka/downloads","issues_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues{/number}","pulls_url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls{/number}","milestones_url":"https://api.github.com/repos/fede1024/rust-rdkafka/milestones{/number}","notifications_url":"https://api.github.com/repos/fede1024/rust-rdkafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fede1024/rust-rdkafka/labels{/name}","releases_url":"https://api.github.com/repos/fede1024/rust-rdkafka/releases{/id}","deployments_url":"https://api.github.com/repos/fede1024/rust-rdkafka/deployments","created_at":"2016-10-29T13:23:35Z","updated_at":"2016-12-19T09:25:35Z","pushed_at":"2016-12-19T20:34:48Z","git_url":"git://github.com/fede1024/rust-rdkafka.git","ssh_url":"git@github.com:fede1024/rust-rdkafka.git","clone_url":"https://github.com/fede1024/rust-rdkafka.git","svn_url":"https://github.com/fede1024/rust-rdkafka","homepage":null,"size":162,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16"},"html":{"href":"https://github.com/fede1024/rust-rdkafka/pull/16"},"issue":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/16"},"comments":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/fede1024/rust-rdkafka/statuses/6b8be6d5fb30fa710248244385bd4a6e64491180"}}}}
{"actor":{"display_login":"fede1024"}}