{"action":"created","comment":{"url":"https://api.github.com/repos/google/openhtf/pulls/comments/80347920","id":80347920,"diff_hunk":"@@ -238,7 +238,7 @@ def _extract_parameters(record, testrun, used_parameter_names):\n         # Just a plain ol' value.\n         if isinstance(value, numbers.Number):\n           testrun_param.numeric_value = float(value)\n-        else:\n+        elif measurement.measured_value.is_value_set:","path":"openhtf/output/callbacks/mfg_inspector.py","position":5,"original_position":5,"commit_id":"6cdc875907c3fc893a3615844ac751592cf628f3","original_commit_id":"6cdc875907c3fc893a3615844ac751592cf628f3","user":{"login":"grybmadsci","id":14081283,"avatar_url":"https://avatars.githubusercontent.com/u/14081283?v=3","gravatar_id":"","url":"https://api.github.com/users/grybmadsci","html_url":"https://github.com/grybmadsci","followers_url":"https://api.github.com/users/grybmadsci/followers","following_url":"https://api.github.com/users/grybmadsci/following{/other_user}","gists_url":"https://api.github.com/users/grybmadsci/gists{/gist_id}","starred_url":"https://api.github.com/users/grybmadsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grybmadsci/subscriptions","organizations_url":"https://api.github.com/users/grybmadsci/orgs","repos_url":"https://api.github.com/users/grybmadsci/repos","events_url":"https://api.github.com/users/grybmadsci/events{/privacy}","received_events_url":"https://api.github.com/users/grybmadsci/received_events","type":"User","site_admin":false},"body":"Hm, I think I prefer to tweak this a little farther up, around line 231:\r\n```py\r\nif not measurement.measured_value:\r\n  testrun_param.status = test_runs_pb2.ERROR\r\n  continue\r\nif not measurement.measured_value.is_value_set:\r\n  testrun_param.status = test_runs_pb2.FAIL\r\n  # Don't continue here, we'll generate an 'Unset' detail code below.\r\nelse:\r\n  value = measurement.measured_value.value\r\n  if measurement.dimensions is None:\r\n    # ...\r\n    # Indent all the way to line 270.\r\nif testrun_param.status == test_runs_pb2.FAIL:\r\n```\r\nAnd if you're bored while you're here, you might pull some of these guts out into a helper function, this function is a bit too long to be easily digestible (my fault, sorry :( ).","created_at":"2016-09-24T00:35:43Z","updated_at":"2016-09-24T00:41:40Z","html_url":"https://github.com/google/openhtf/pull/405#discussion_r80347920","pull_request_url":"https://api.github.com/repos/google/openhtf/pulls/405","_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments/80347920"},"html":{"href":"https://github.com/google/openhtf/pull/405#discussion_r80347920"},"pull_request":{"href":"https://api.github.com/repos/google/openhtf/pulls/405"}}},"pull_request":{"url":"https://api.github.com/repos/google/openhtf/pulls/405","id":81739906,"html_url":"https://github.com/google/openhtf/pull/405","diff_url":"https://github.com/google/openhtf/pull/405.diff","patch_url":"https://github.com/google/openhtf/pull/405.patch","issue_url":"https://api.github.com/repos/google/openhtf/issues/405","number":405,"state":"open","locked":false,"title":"Fix a bug in mfg-inspector output.","user":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"body":"Specifically, prevent the text_value field on measurements from being set when\r\nthe measurement itself remains UNSET.\r\n\r\nFixes #404","created_at":"2016-08-18T00:29:37Z","updated_at":"2016-09-24T00:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6af8ad0649b6079ede162178911d48be5e29e1b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/openhtf/pulls/405/commits","review_comments_url":"https://api.github.com/repos/google/openhtf/pulls/405/comments","review_comment_url":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/openhtf/issues/405/comments","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/6cdc875907c3fc893a3615844ac751592cf628f3","head":{"label":"jettisonjoe:inspector_bug","ref":"inspector_bug","sha":"6cdc875907c3fc893a3615844ac751592cf628f3","user":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"repo":{"id":41824189,"name":"openhtf","full_name":"jettisonjoe/openhtf","owner":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jettisonjoe/openhtf","description":null,"fork":true,"url":"https://api.github.com/repos/jettisonjoe/openhtf","forks_url":"https://api.github.com/repos/jettisonjoe/openhtf/forks","keys_url":"https://api.github.com/repos/jettisonjoe/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jettisonjoe/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jettisonjoe/openhtf/teams","hooks_url":"https://api.github.com/repos/jettisonjoe/openhtf/hooks","issue_events_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/jettisonjoe/openhtf/events","assignees_url":"https://api.github.com/repos/jettisonjoe/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/jettisonjoe/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/jettisonjoe/openhtf/tags","blobs_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jettisonjoe/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/jettisonjoe/openhtf/languages","stargazers_url":"https://api.github.com/repos/jettisonjoe/openhtf/stargazers","contributors_url":"https://api.github.com/repos/jettisonjoe/openhtf/contributors","subscribers_url":"https://api.github.com/repos/jettisonjoe/openhtf/subscribers","subscription_url":"https://api.github.com/repos/jettisonjoe/openhtf/subscription","commits_url":"https://api.github.com/repos/jettisonjoe/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jettisonjoe/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jettisonjoe/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/jettisonjoe/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jettisonjoe/openhtf/merges","archive_url":"https://api.github.com/repos/jettisonjoe/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jettisonjoe/openhtf/downloads","issues_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/jettisonjoe/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/jettisonjoe/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/jettisonjoe/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jettisonjoe/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/jettisonjoe/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/jettisonjoe/openhtf/deployments","created_at":"2015-09-02T19:50:25Z","updated_at":"2016-06-28T20:41:12Z","pushed_at":"2016-09-23T23:07:51Z","git_url":"git://github.com/jettisonjoe/openhtf.git","ssh_url":"git@github.com:jettisonjoe/openhtf.git","clone_url":"https://github.com/jettisonjoe/openhtf.git","svn_url":"https://github.com/jettisonjoe/openhtf","homepage":null,"size":24703,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"25390b2a334986a7838d6c2b9fbdbddb7d9bd789","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":41519483,"name":"openhtf","full_name":"google/openhtf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/openhtf","description":null,"fork":false,"url":"https://api.github.com/repos/google/openhtf","forks_url":"https://api.github.com/repos/google/openhtf/forks","keys_url":"https://api.github.com/repos/google/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/openhtf/teams","hooks_url":"https://api.github.com/repos/google/openhtf/hooks","issue_events_url":"https://api.github.com/repos/google/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/google/openhtf/events","assignees_url":"https://api.github.com/repos/google/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/google/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/google/openhtf/tags","blobs_url":"https://api.github.com/repos/google/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/openhtf/languages","stargazers_url":"https://api.github.com/repos/google/openhtf/stargazers","contributors_url":"https://api.github.com/repos/google/openhtf/contributors","subscribers_url":"https://api.github.com/repos/google/openhtf/subscribers","subscription_url":"https://api.github.com/repos/google/openhtf/subscription","commits_url":"https://api.github.com/repos/google/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/google/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/openhtf/merges","archive_url":"https://api.github.com/repos/google/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/openhtf/downloads","issues_url":"https://api.github.com/repos/google/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/google/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/google/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/google/openhtf/deployments","created_at":"2015-08-28T01:14:17Z","updated_at":"2016-09-13T10:38:26Z","pushed_at":"2016-09-23T23:25:27Z","git_url":"git://github.com/google/openhtf.git","ssh_url":"git@github.com:google/openhtf.git","clone_url":"https://github.com/google/openhtf.git","svn_url":"https://github.com/google/openhtf","homepage":null,"size":26194,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":78,"forks":24,"open_issues":78,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/405"},"html":{"href":"https://github.com/google/openhtf/pull/405"},"issue":{"href":"https://api.github.com/repos/google/openhtf/issues/405"},"comments":{"href":"https://api.github.com/repos/google/openhtf/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/google/openhtf/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/openhtf/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/google/openhtf/statuses/6cdc875907c3fc893a3615844ac751592cf628f3"}}}}
{"actor":{"display_login":"grybmadsci"}}