{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/63612277","id":63612277,"diff_hunk":"@@ -1245,7 +1269,7 @@ - (NSArray *)queryWithQuerySpec:(SFQuerySpec *)querySpec pageIndex:(NSUInteger)p\n     // SQL\n     NSString* sql = [self convertSmartSql: querySpec.smartSql withDb:db];\n     NSString* limitSql = [@[@\"SELECT * FROM (\", sql, @\") LIMIT \", limit] componentsJoinedByString:@\"\"];\n-    [self log:SFLogLevelDebug format:@\"queryWithQuerySpec: \\nlimitSql:%@ \\npageIndex:%d \\n\", limitSql, pageIndex];\n+    // [self log:SFLogLevelDebug format:@\"queryWithQuerySpec: \\nlimitSql:%@ \\npageIndex:%d \\n\", limitSql, pageIndex];","path":"libs/SmartStore/SmartStore/Classes/SFSmartStore.m","position":79,"original_position":79,"commit_id":"8946a0caf2e9394cd4bdc1a45e0a9f3d3a9e3ad1","original_commit_id":"8946a0caf2e9394cd4bdc1a45e0a9f3d3a9e3ad1","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars.githubusercontent.com/u/1820287?v=3","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"I don't feel strongly either way. We could just delete this log line. It's just the query, so it would be a dev time debugging thing anyway.","created_at":"2016-05-17T22:01:32Z","updated_at":"2016-05-17T22:01:32Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545#discussion_r63612277","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/63612277"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545#discussion_r63612277"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545","id":70411584,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1545","number":1545,"state":"open","locked":false,"title":"Support for json1 indexes ","user":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars.githubusercontent.com/u/1012459?v=3","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"body":"New tests in SFSmartStoreTests.m and SFSmartStoreAlterTests.m\r\nNew test suite: SFSmartStoreLoadTests.m","created_at":"2016-05-17T19:01:46Z","updated_at":"2016-05-17T22:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8d6c57c2950f35b989d105bdcf829bb82a01ba9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1545/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/8946a0caf2e9394cd4bdc1a45e0a9f3d3a9e3ad1","head":{"label":"wmathurin:json1","ref":"json1","sha":"8946a0caf2e9394cd4bdc1a45e0a9f3d3a9e3ad1","user":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars.githubusercontent.com/u/1012459?v=3","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"repo":{"id":5184198,"name":"SalesforceMobileSDK-iOS","full_name":"wmathurin/SalesforceMobileSDK-iOS","owner":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars.githubusercontent.com/u/1012459?v=3","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmathurin/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-iOS/deployments","created_at":"2012-07-25T20:31:23Z","updated_at":"2015-04-27T23:06:59Z","pushed_at":"2016-05-17T18:38:51Z","git_url":"git://github.com/wmathurin/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:wmathurin/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/wmathurin/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/wmathurin/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":308807,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"forcedotcom:unstable","ref":"unstable","sha":"9029f10fdda13385f58fd832afaa7a9548a478cb","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2016-05-13T10:21:43Z","pushed_at":"2016-05-17T21:07:09Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":328674,"stargazers_count":326,"watchers_count":326,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"open_issues_count":25,"forks":240,"open_issues":25,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1545"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1545"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/8946a0caf2e9394cd4bdc1a45e0a9f3d3a9e3ad1"}}}}