{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10148","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10148/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10148/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10148/events","html_url":"https://github.com/joomla/joomla-cms/pull/10148","id":152041941,"number":10148,"title":"[com_templates] styles/templates views: Site/Admin and other changes","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-30T17:23:35Z","updated_at":"2016-04-30T18:30:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10148","html_url":"https://github.com/joomla/joomla-cms/pull/10148","diff_url":"https://github.com/joomla/joomla-cms/pull/10148.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10148.patch"},"body":"#### Summary of Changes\r\n\r\nThis PR makes some changes to com_templates list views (styles and templates):\r\n\r\n1. For consistency, align com_templates list views with other views that have a location selector (modules, cache, installed languages) by adding the client selector (Site/Administrator) and removing the location (client) from ordering, columns and filters.\r\n\r\n2. Adds a new filter `menuitem` (Pages) in styles view to show the template styles assigned to a particular menu item.\r\n\r\n3. Improves the \"Assigned\" column (now \"Pages\") so it will give more information and be more aligned with modules list view.\r\n\r\n4. Improves mobile view.\r\n\r\n5. Other minor code style and code improvements.\r\n\r\n##### Styles view\r\n\r\nBefore PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14937372/68a6f520-0efd-11e6-999d-9441d254e316.png)\r\n\r\nAfter PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14937359/fb6eec2e-0efc-11e6-9873-a5706279752c.png)\r\n\r\n##### Templates view\r\n\r\nBefore PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14937378/8867e72a-0efd-11e6-9871-47bae4202135.png)\r\n\r\nAfter PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14937362/14a0633a-0efd-11e6-8087-56981fb7d440.png)\r\n\r\n#### Testing Instructions\r\n\r\n1. Apply patch\r\n2. Go to Extensions -> Templates -> Styles, and do a general test of all options and filters. Test also mobile views. Test the new `menuitem` (Pages) filter\r\n3. Go to Extensions -> Templates -> Templates, and do a general test of all options and filters. Test also mobile views.\r\n4. Test also if works properly with 3º party templates.\r\n5. Test the two views in hathor to.\r\n\r\n#### Observations\r\n\r\nCode reviews, comments and/or suggestions are welcomed."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/215985538","html_url":"https://github.com/joomla/joomla-cms/pull/10148#issuecomment-215985538","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10148","id":215985538,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T18:30:05Z","updated_at":"2016-04-30T18:30:05Z","body":"\"2.\" solved"}}