{"action":"created","issue":{"url":"https://api.github.com/repos/sgotti/glide-vc/issues/2","repository_url":"https://api.github.com/repos/sgotti/glide-vc","labels_url":"https://api.github.com/repos/sgotti/glide-vc/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/sgotti/glide-vc/issues/2/comments","events_url":"https://api.github.com/repos/sgotti/glide-vc/issues/2/events","html_url":"https://github.com/sgotti/glide-vc/issues/2","id":138585148,"number":2,"title":"A few ideas","user":{"login":"mattfarina","id":62991,"avatar_url":"https://avatars.githubusercontent.com/u/62991?v=3","gravatar_id":"","url":"https://api.github.com/users/mattfarina","html_url":"https://github.com/mattfarina","followers_url":"https://api.github.com/users/mattfarina/followers","following_url":"https://api.github.com/users/mattfarina/following{/other_user}","gists_url":"https://api.github.com/users/mattfarina/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfarina/subscriptions","organizations_url":"https://api.github.com/users/mattfarina/orgs","repos_url":"https://api.github.com/users/mattfarina/repos","events_url":"https://api.github.com/users/mattfarina/events{/privacy}","received_events_url":"https://api.github.com/users/mattfarina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-04T21:01:01Z","updated_at":"2016-03-10T14:19:21Z","closed_at":null,"body":"Thanks for putting this together. I know it will be useful.\r\n\r\nI have a few thoughts that may help you along.\r\n\r\n1) Don't strip non-Go files by default. Instead opt-in to that with a flag. The reason is those documents can contain license information. Sometimes it's in a license file. Sometimes it's in a readme. You never can be sure.\r\n\r\nA good default for licenses is important. Take the BSD license. If someone removes the license and someone redistributes the parent project on GitHub that person is in violation of the BSD license. There are a bunch of things like that.\r\n\r\nWould you be open to opting in on that rather than opting out? That way those who can do it, such as a proprietary codebase, can opt-in. It spares accidents for open source projects.\r\n\r\n2) This project deletes things. So, can you add some testing in? Maybe a testdata directory and some tests. Maybe even cross platform (POSIX and Windows)? If you're looking for an example you can see what I did on [rmvcsdir](https://github.com/Masterminds/rmvcsdir). I'm happy to talk more about this.\r\n\r\nIt's reassuring to know the tests make sure it works right and for those looking to use it.\r\n\r\n3) If you're not going to keep the dependencies in the `vendor/` folder, consider adding `vendor/` to the `.gitignore` file. I was considering a pull request but I ran out of time when I was in my dev environment.\r\n\r\n4) This is entirely optional but, glide has a plugin system like git. If this were named `glide-vc` (or something else) you could use the command `glide vc` when the plugin is installed. Just a thought. I'm not all that opinionated on this. I just like to raise awareness.\r\n\r\nNice work. I'm happy to see you working on this."},"comment":{"url":"https://api.github.com/repos/sgotti/glide-vc/issues/comments/194867929","html_url":"https://github.com/sgotti/glide-vc/issues/2#issuecomment-194867929","issue_url":"https://api.github.com/repos/sgotti/glide-vc/issues/2","id":194867929,"user":{"login":"mattfarina","id":62991,"avatar_url":"https://avatars.githubusercontent.com/u/62991?v=3","gravatar_id":"","url":"https://api.github.com/users/mattfarina","html_url":"https://github.com/mattfarina","followers_url":"https://api.github.com/users/mattfarina/followers","following_url":"https://api.github.com/users/mattfarina/following{/other_user}","gists_url":"https://api.github.com/users/mattfarina/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfarina/subscriptions","organizations_url":"https://api.github.com/users/mattfarina/orgs","repos_url":"https://api.github.com/users/mattfarina/repos","events_url":"https://api.github.com/users/mattfarina/events{/privacy}","received_events_url":"https://api.github.com/users/mattfarina/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T14:19:21Z","updated_at":"2016-03-10T14:19:21Z","body":"@sgotti sorry I've not been more responsive. Been a little busy. I like where you're taking this.\r\n\r\nIn Glide 0.10 we're going to add the base ability to strip VCS directories from the vendor directory. That's the only part of this. For those who would like to prune further I'd like to list this project as a method to do that. I'm expecting the release of 0.10 to be a couple weeks away."}}