{"action":"created","comment":{"url":"https://api.github.com/repos/rs2k/raceflight/pulls/comments/56759539","id":56759539,"diff_hunk":"@@ -36,10 +36,10 @@\n #define MAX_INPUTS  8\n \n #define PWM_TIMER_MHZ 1\n-//these three have to be the same because of the ppmAvoidPWMTimerClash functions\n-#define ONESHOT_TIMER_MHZ 12\n+#define ONESHOT125_TIMER_MHZ 8\n+#define ONESHOT42_TIMER_MHZ 24","path":"src/main/drivers/pwm_mapping.h","position":7,"original_position":7,"commit_id":"f3fbf5856ebf6514d48834ca1ba007700f9b631f","original_commit_id":"b2464d006afc14e7fcc46cbc4c71c83b646216af","user":{"login":"blckmn","id":6168871,"avatar_url":"https://avatars.githubusercontent.com/u/6168871?v=3","gravatar_id":"","url":"https://api.github.com/users/blckmn","html_url":"https://github.com/blckmn","followers_url":"https://api.github.com/users/blckmn/followers","following_url":"https://api.github.com/users/blckmn/following{/other_user}","gists_url":"https://api.github.com/users/blckmn/gists{/gist_id}","starred_url":"https://api.github.com/users/blckmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blckmn/subscriptions","organizations_url":"https://api.github.com/users/blckmn/orgs","repos_url":"https://api.github.com/users/blckmn/repos","events_url":"https://api.github.com/users/blckmn/events{/privacy}","received_events_url":"https://api.github.com/users/blckmn/received_events","type":"User","site_admin":false},"body":"Doesn't the 411 on the revo run at 100mhz? it would need to be 10mhz to work in that case.","created_at":"2016-03-20T05:38:47Z","updated_at":"2016-03-20T05:38:47Z","html_url":"https://github.com/rs2k/raceflight/pull/117#discussion_r56759539","pull_request_url":"https://api.github.com/repos/rs2k/raceflight/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/comments/56759539"},"html":{"href":"https://github.com/rs2k/raceflight/pull/117#discussion_r56759539"},"pull_request":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/rs2k/raceflight/pulls/117","id":63310064,"html_url":"https://github.com/rs2k/raceflight/pull/117","diff_url":"https://github.com/rs2k/raceflight/pull/117.diff","patch_url":"https://github.com/rs2k/raceflight/pull/117.patch","issue_url":"https://api.github.com/repos/rs2k/raceflight/issues/117","number":117,"state":"open","locked":false,"title":"Updates to PWM code","user":{"login":"MJ666","id":8107952,"avatar_url":"https://avatars.githubusercontent.com/u/8107952?v=3","gravatar_id":"","url":"https://api.github.com/users/MJ666","html_url":"https://github.com/MJ666","followers_url":"https://api.github.com/users/MJ666/followers","following_url":"https://api.github.com/users/MJ666/following{/other_user}","gists_url":"https://api.github.com/users/MJ666/gists{/gist_id}","starred_url":"https://api.github.com/users/MJ666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJ666/subscriptions","organizations_url":"https://api.github.com/users/MJ666/orgs","repos_url":"https://api.github.com/users/MJ666/repos","events_url":"https://api.github.com/users/MJ666/events{/privacy}","received_events_url":"https://api.github.com/users/MJ666/received_events","type":"User","site_admin":false},"body":"Fix oneshot 125\r\ngeneral code cleanup\r\n\r\nPlease take a look at this. We still testing this here and our brushless build with KISS esc and oneshot is not really flying well. Al least oneshot is working again and motors running normally and smooth over the full range from motor tab. But in flight mode we have very heavy oscillations. Motors get hot quite fast. This brushless build is the best flying copter of this size with an firmware build from January. An brushed build in the same size if flying quite well with the same PID settings. I have seen this heavy oscillation's also with some other build during the last 3-4 weeks. \r\n\r\nHere are a two pictures.\r\nbrushless:\r\n![f4bl_1](https://cloud.githubusercontent.com/assets/8107952/13864358/20cd5c18-eca1-11e5-9164-16072168b888.jpg)\r\n\r\nbrushed:\r\n![quadf4_1](https://cloud.githubusercontent.com/assets/8107952/13864343/f9467ba2-eca0-11e5-8449-8dec1bf73cbb.jpg)\r\n\r\nThe idle pulse is not really needed during initialization in PWM_RATE mode. I also eliminate the many scaling during motor output and the timers running with the native speeds again. The PWM RX code is now taking care on scaling. The ppmAvoidPWMTimerClash() call is likely not really required for most of the F4 target sine at least 2/3 of them don't share timers between PWM and motors. Many of this calls can be eliminated in my view.\r\n\r\nIf there is someone out there with kiss and oneshot125 and can give this an try. This would be quite helpful. We don't get the Kiss to work with RC8 at all. Also if somebody can test the code with Multishot it would be helpful.","created_at":"2016-03-17T23:49:15Z","updated_at":"2016-03-20T05:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"786ba24b43dd722ae9ad115e86a1988304ad39f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rs2k/raceflight/pulls/117/commits","review_comments_url":"https://api.github.com/repos/rs2k/raceflight/pulls/117/comments","review_comment_url":"https://api.github.com/repos/rs2k/raceflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rs2k/raceflight/issues/117/comments","statuses_url":"https://api.github.com/repos/rs2k/raceflight/statuses/f3fbf5856ebf6514d48834ca1ba007700f9b631f","head":{"label":"MJ666:pwm_test","ref":"pwm_test","sha":"f3fbf5856ebf6514d48834ca1ba007700f9b631f","user":{"login":"MJ666","id":8107952,"avatar_url":"https://avatars.githubusercontent.com/u/8107952?v=3","gravatar_id":"","url":"https://api.github.com/users/MJ666","html_url":"https://github.com/MJ666","followers_url":"https://api.github.com/users/MJ666/followers","following_url":"https://api.github.com/users/MJ666/following{/other_user}","gists_url":"https://api.github.com/users/MJ666/gists{/gist_id}","starred_url":"https://api.github.com/users/MJ666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJ666/subscriptions","organizations_url":"https://api.github.com/users/MJ666/orgs","repos_url":"https://api.github.com/users/MJ666/repos","events_url":"https://api.github.com/users/MJ666/events{/privacy}","received_events_url":"https://api.github.com/users/MJ666/received_events","type":"User","site_admin":false},"repo":{"id":47252044,"name":"raceflight","full_name":"MJ666/raceflight","owner":{"login":"MJ666","id":8107952,"avatar_url":"https://avatars.githubusercontent.com/u/8107952?v=3","gravatar_id":"","url":"https://api.github.com/users/MJ666","html_url":"https://github.com/MJ666","followers_url":"https://api.github.com/users/MJ666/followers","following_url":"https://api.github.com/users/MJ666/following{/other_user}","gists_url":"https://api.github.com/users/MJ666/gists{/gist_id}","starred_url":"https://api.github.com/users/MJ666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJ666/subscriptions","organizations_url":"https://api.github.com/users/MJ666/orgs","repos_url":"https://api.github.com/users/MJ666/repos","events_url":"https://api.github.com/users/MJ666/events{/privacy}","received_events_url":"https://api.github.com/users/MJ666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MJ666/raceflight","description":"STM32F4 port of Betaflight with emphasis on racing performance.","fork":true,"url":"https://api.github.com/repos/MJ666/raceflight","forks_url":"https://api.github.com/repos/MJ666/raceflight/forks","keys_url":"https://api.github.com/repos/MJ666/raceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MJ666/raceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MJ666/raceflight/teams","hooks_url":"https://api.github.com/repos/MJ666/raceflight/hooks","issue_events_url":"https://api.github.com/repos/MJ666/raceflight/issues/events{/number}","events_url":"https://api.github.com/repos/MJ666/raceflight/events","assignees_url":"https://api.github.com/repos/MJ666/raceflight/assignees{/user}","branches_url":"https://api.github.com/repos/MJ666/raceflight/branches{/branch}","tags_url":"https://api.github.com/repos/MJ666/raceflight/tags","blobs_url":"https://api.github.com/repos/MJ666/raceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MJ666/raceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MJ666/raceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/MJ666/raceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MJ666/raceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/MJ666/raceflight/languages","stargazers_url":"https://api.github.com/repos/MJ666/raceflight/stargazers","contributors_url":"https://api.github.com/repos/MJ666/raceflight/contributors","subscribers_url":"https://api.github.com/repos/MJ666/raceflight/subscribers","subscription_url":"https://api.github.com/repos/MJ666/raceflight/subscription","commits_url":"https://api.github.com/repos/MJ666/raceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/MJ666/raceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/MJ666/raceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/MJ666/raceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/MJ666/raceflight/contents/{+path}","compare_url":"https://api.github.com/repos/MJ666/raceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MJ666/raceflight/merges","archive_url":"https://api.github.com/repos/MJ666/raceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MJ666/raceflight/downloads","issues_url":"https://api.github.com/repos/MJ666/raceflight/issues{/number}","pulls_url":"https://api.github.com/repos/MJ666/raceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/MJ666/raceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/MJ666/raceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MJ666/raceflight/labels{/name}","releases_url":"https://api.github.com/repos/MJ666/raceflight/releases{/id}","deployments_url":"https://api.github.com/repos/MJ666/raceflight/deployments","created_at":"2015-12-02T09:51:02Z","updated_at":"2016-03-15T06:43:24Z","pushed_at":"2016-03-19T07:34:08Z","git_url":"git://github.com/MJ666/raceflight.git","ssh_url":"git@github.com:MJ666/raceflight.git","clone_url":"https://github.com/MJ666/raceflight.git","svn_url":"https://github.com/MJ666/raceflight","homepage":null,"size":71945,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"rs2k:raceflight","ref":"raceflight","sha":"a5a70d6e10b537375c3b6135af6f28732c467bd9","user":{"login":"rs2k","id":9113146,"avatar_url":"https://avatars.githubusercontent.com/u/9113146?v=3","gravatar_id":"","url":"https://api.github.com/users/rs2k","html_url":"https://github.com/rs2k","followers_url":"https://api.github.com/users/rs2k/followers","following_url":"https://api.github.com/users/rs2k/following{/other_user}","gists_url":"https://api.github.com/users/rs2k/gists{/gist_id}","starred_url":"https://api.github.com/users/rs2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs2k/subscriptions","organizations_url":"https://api.github.com/users/rs2k/orgs","repos_url":"https://api.github.com/users/rs2k/repos","events_url":"https://api.github.com/users/rs2k/events{/privacy}","received_events_url":"https://api.github.com/users/rs2k/received_events","type":"User","site_admin":false},"repo":{"id":45860771,"name":"raceflight","full_name":"rs2k/raceflight","owner":{"login":"rs2k","id":9113146,"avatar_url":"https://avatars.githubusercontent.com/u/9113146?v=3","gravatar_id":"","url":"https://api.github.com/users/rs2k","html_url":"https://github.com/rs2k","followers_url":"https://api.github.com/users/rs2k/followers","following_url":"https://api.github.com/users/rs2k/following{/other_user}","gists_url":"https://api.github.com/users/rs2k/gists{/gist_id}","starred_url":"https://api.github.com/users/rs2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs2k/subscriptions","organizations_url":"https://api.github.com/users/rs2k/orgs","repos_url":"https://api.github.com/users/rs2k/repos","events_url":"https://api.github.com/users/rs2k/events{/privacy}","received_events_url":"https://api.github.com/users/rs2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs2k/raceflight","description":"STM32F4 port of Betaflight with emphasis on racing performance.","fork":false,"url":"https://api.github.com/repos/rs2k/raceflight","forks_url":"https://api.github.com/repos/rs2k/raceflight/forks","keys_url":"https://api.github.com/repos/rs2k/raceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs2k/raceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs2k/raceflight/teams","hooks_url":"https://api.github.com/repos/rs2k/raceflight/hooks","issue_events_url":"https://api.github.com/repos/rs2k/raceflight/issues/events{/number}","events_url":"https://api.github.com/repos/rs2k/raceflight/events","assignees_url":"https://api.github.com/repos/rs2k/raceflight/assignees{/user}","branches_url":"https://api.github.com/repos/rs2k/raceflight/branches{/branch}","tags_url":"https://api.github.com/repos/rs2k/raceflight/tags","blobs_url":"https://api.github.com/repos/rs2k/raceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs2k/raceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs2k/raceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs2k/raceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs2k/raceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/rs2k/raceflight/languages","stargazers_url":"https://api.github.com/repos/rs2k/raceflight/stargazers","contributors_url":"https://api.github.com/repos/rs2k/raceflight/contributors","subscribers_url":"https://api.github.com/repos/rs2k/raceflight/subscribers","subscription_url":"https://api.github.com/repos/rs2k/raceflight/subscription","commits_url":"https://api.github.com/repos/rs2k/raceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs2k/raceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs2k/raceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs2k/raceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs2k/raceflight/contents/{+path}","compare_url":"https://api.github.com/repos/rs2k/raceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs2k/raceflight/merges","archive_url":"https://api.github.com/repos/rs2k/raceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs2k/raceflight/downloads","issues_url":"https://api.github.com/repos/rs2k/raceflight/issues{/number}","pulls_url":"https://api.github.com/repos/rs2k/raceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/rs2k/raceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/rs2k/raceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs2k/raceflight/labels{/name}","releases_url":"https://api.github.com/repos/rs2k/raceflight/releases{/id}","deployments_url":"https://api.github.com/repos/rs2k/raceflight/deployments","created_at":"2015-11-09T19:16:44Z","updated_at":"2016-03-17T13:55:14Z","pushed_at":"2016-03-19T07:34:08Z","git_url":"git://github.com/rs2k/raceflight.git","ssh_url":"git@github.com:rs2k/raceflight.git","clone_url":"https://github.com/rs2k/raceflight.git","svn_url":"https://github.com/rs2k/raceflight","homepage":null,"size":75972,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":17,"forks":25,"open_issues":17,"watchers":43,"default_branch":"raceflight"}},"_links":{"self":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/117"},"html":{"href":"https://github.com/rs2k/raceflight/pull/117"},"issue":{"href":"https://api.github.com/repos/rs2k/raceflight/issues/117"},"comments":{"href":"https://api.github.com/repos/rs2k/raceflight/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rs2k/raceflight/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/rs2k/raceflight/statuses/f3fbf5856ebf6514d48834ca1ba007700f9b631f"}}}}