{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/commons/issues/425","repository_url":"https://api.github.com/repos/twitter/commons","labels_url":"https://api.github.com/repos/twitter/commons/issues/425/labels{/name}","comments_url":"https://api.github.com/repos/twitter/commons/issues/425/comments","events_url":"https://api.github.com/repos/twitter/commons/issues/425/events","html_url":"https://github.com/twitter/commons/pull/425","id":152843768,"number":425,"title":"[python zookeeper] Add member_id to ServiceInstance object if provided.","user":{"login":"brutkin","id":18426604,"avatar_url":"https://avatars.githubusercontent.com/u/18426604?v=3","gravatar_id":"","url":"https://api.github.com/users/brutkin","html_url":"https://github.com/brutkin","followers_url":"https://api.github.com/users/brutkin/followers","following_url":"https://api.github.com/users/brutkin/following{/other_user}","gists_url":"https://api.github.com/users/brutkin/gists{/gist_id}","starred_url":"https://api.github.com/users/brutkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutkin/subscriptions","organizations_url":"https://api.github.com/users/brutkin/orgs","repos_url":"https://api.github.com/users/brutkin/repos","events_url":"https://api.github.com/users/brutkin/events{/privacy}","received_events_url":"https://api.github.com/users/brutkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-03T18:33:06Z","updated_at":"2016-05-04T21:15:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/commons/pulls/425","html_url":"https://github.com/twitter/commons/pull/425","diff_url":"https://github.com/twitter/commons/pull/425.diff","patch_url":"https://github.com/twitter/commons/pull/425.patch"},"body":"Add member_id to ServiceInstance object if supplied when creating it and make that the default action when creating a serverset list. This is mostly useful for reconciling issues with the serverset e.g. duplicate registration.\r\n\r\n\r\nTests all pass:\r\n$ ./pants test tests/python/twitter/common/zookeeper:all\r\n11:22:40 00:02         [chroot]============== test session starts ===============\r\n                     platform darwin -- Python 2.7.10 -- py-1.4.31 -- pytest-2.6.4\r\n                     plugins: cov, timeout\r\n                     collected 85 items\r\n\r\n                     tests/python/twitter/common/zookeeper/kazoo_client_test.py .\r\n                     tests/python/twitter/common/zookeeper/group/test_active_kazoo_group.py ................................................\r\n                     tests/python/twitter/common/zookeeper/group/test_kazoo_group.py ..................\r\n                     tests/python/twitter/common/zookeeper/serverset/test_endpoint.py ............\r\n                     tests/python/twitter/common/zookeeper/serverset/test_kazoo_serverset.py .....\r\n                     tests/python/twitter/common/zookeeper/serverset/test_serverset_unit.py .\r\n\r\n                     =========== 85 passed in 23.80 seconds ==========="},"comment":{"url":"https://api.github.com/repos/twitter/commons/issues/comments/217005047","html_url":"https://github.com/twitter/commons/pull/425#issuecomment-217005047","issue_url":"https://api.github.com/repos/twitter/commons/issues/425","id":217005047,"user":{"login":"brutkin","id":18426604,"avatar_url":"https://avatars.githubusercontent.com/u/18426604?v=3","gravatar_id":"","url":"https://api.github.com/users/brutkin","html_url":"https://github.com/brutkin","followers_url":"https://api.github.com/users/brutkin/followers","following_url":"https://api.github.com/users/brutkin/following{/other_user}","gists_url":"https://api.github.com/users/brutkin/gists{/gist_id}","starred_url":"https://api.github.com/users/brutkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brutkin/subscriptions","organizations_url":"https://api.github.com/users/brutkin/orgs","repos_url":"https://api.github.com/users/brutkin/repos","events_url":"https://api.github.com/users/brutkin/events{/privacy}","received_events_url":"https://api.github.com/users/brutkin/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T21:15:23Z","updated_at":"2016-05-04T21:15:23Z","body":"Are you suggestion I add it in twitter.common.zookeeper.group.group and twitter.common.zookeeper.group.kazoo_group instead?\r\nI think I'd still need most of these changes as well but that would likely work.\r\n\r\n"}}