{"action":"created","comment":{"url":"https://api.github.com/repos/ragnor-rs/visum/pulls/comments/64231418","id":64231418,"diff_hunk":"@@ -78,32 +135,96 @@ public final void setView(V view) {\n         );\n     }\n \n-    protected final <T> void subscribe(Single<T> single, Action1<T> observer) {\n-        subscriptions.add(\n+    public final <T> void subscribe(int viewId, Single<T> single, Action1<T> action) {\n+        findViewHolderByViewIdOrThrow(viewId).subscriptions.add(\n                 single\n                         .subscribeOn(Schedulers.io())\n                         .observeOn(AndroidSchedulers.mainThread())\n-                        .subscribe(observer)\n+                        .subscribe(action)\n         );\n     }\n \n-    protected final <T> void subscribe(Single<T> single, SingleSubscriber<T> observer) {\n-        subscriptions.add(\n+    public final <T> void subscribe(int viewId, Single<T> single, SingleSubscriber<T> subscriber) {\n+        findViewHolderByViewIdOrThrow(viewId).subscriptions.add(\n                 single\n                         .subscribeOn(Schedulers.io())\n                         .observeOn(AndroidSchedulers.mainThread())\n-                        .subscribe(observer)\n+                        .subscribe(subscriber)\n         );\n     }\n \n+    @SuppressWarnings({\"unused\", \"deprecation\"})\n+    protected void onViewAttached(int id, @NonNull V view) {\n+        onViewAttached();\n+    }\n+\n+    @SuppressWarnings({\"unused\", \"deprecation\"})\n+    protected void onViewDetached(int id, @NonNull V view) {\n+        onViewDetached();\n+    }\n \n-    protected abstract void onViewAttached();\n+    @NonNull\n+    public final V view(int id) {\n+        return findViewHolderByViewIdOrThrow(id).view;\n+    }\n \n-    protected void onViewDetached() {\n+    /**\n+     * @deprecated use {@link #setView(int, VisumView)} instead\n+     */\n+    @Deprecated\n+    @SuppressWarnings({\"unused\", \"deprecation\"})\n+    public final void setView(V view) {\n+        setView(VIEW_ID_DEFAULT, view);","path":"src/main/java/io/reist/visum/presenter/VisumPresenter.java","position":190,"original_position":190,"commit_id":"9bb4ed5d06a3f8f6fc7d9050c98ae9c6b86a2c66","original_commit_id":"9bb4ed5d06a3f8f6fc7d9050c98ae9c6b86a2c66","user":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"body":"+1 https://dreams.atlassian.net/browse/ZAN-490","created_at":"2016-05-23T14:25:30Z","updated_at":"2016-05-23T14:25:30Z","html_url":"https://github.com/ragnor-rs/visum/pull/34#discussion_r64231418","pull_request_url":"https://api.github.com/repos/ragnor-rs/visum/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/comments/64231418"},"html":{"href":"https://github.com/ragnor-rs/visum/pull/34#discussion_r64231418"},"pull_request":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/ragnor-rs/visum/pulls/34","id":70729025,"html_url":"https://github.com/ragnor-rs/visum/pull/34","diff_url":"https://github.com/ragnor-rs/visum/pull/34.diff","patch_url":"https://github.com/ragnor-rs/visum/pull/34.patch","issue_url":"https://api.github.com/repos/ragnor-rs/visum/issues/34","number":34,"state":"open","locked":false,"title":"Task/zan 418 notifications","user":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-19T16:55:59Z","updated_at":"2016-05-23T14:25:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe40f7aad5294baed06f4b0153c94c8d39d6e273","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ragnor-rs/visum/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ragnor-rs/visum/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ragnor-rs/visum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ragnor-rs/visum/issues/34/comments","statuses_url":"https://api.github.com/repos/ragnor-rs/visum/statuses/9bb4ed5d06a3f8f6fc7d9050c98ae9c6b86a2c66","head":{"label":"ragnor-rs:task/ZAN-418_notifications","ref":"task/ZAN-418_notifications","sha":"9bb4ed5d06a3f8f6fc7d9050c98ae9c6b86a2c66","user":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"repo":{"id":46714751,"name":"visum","full_name":"ragnor-rs/visum","owner":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ragnor-rs/visum","description":"Android reactive MVP stack","fork":false,"url":"https://api.github.com/repos/ragnor-rs/visum","forks_url":"https://api.github.com/repos/ragnor-rs/visum/forks","keys_url":"https://api.github.com/repos/ragnor-rs/visum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ragnor-rs/visum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ragnor-rs/visum/teams","hooks_url":"https://api.github.com/repos/ragnor-rs/visum/hooks","issue_events_url":"https://api.github.com/repos/ragnor-rs/visum/issues/events{/number}","events_url":"https://api.github.com/repos/ragnor-rs/visum/events","assignees_url":"https://api.github.com/repos/ragnor-rs/visum/assignees{/user}","branches_url":"https://api.github.com/repos/ragnor-rs/visum/branches{/branch}","tags_url":"https://api.github.com/repos/ragnor-rs/visum/tags","blobs_url":"https://api.github.com/repos/ragnor-rs/visum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ragnor-rs/visum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ragnor-rs/visum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ragnor-rs/visum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ragnor-rs/visum/statuses/{sha}","languages_url":"https://api.github.com/repos/ragnor-rs/visum/languages","stargazers_url":"https://api.github.com/repos/ragnor-rs/visum/stargazers","contributors_url":"https://api.github.com/repos/ragnor-rs/visum/contributors","subscribers_url":"https://api.github.com/repos/ragnor-rs/visum/subscribers","subscription_url":"https://api.github.com/repos/ragnor-rs/visum/subscription","commits_url":"https://api.github.com/repos/ragnor-rs/visum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ragnor-rs/visum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ragnor-rs/visum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ragnor-rs/visum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ragnor-rs/visum/contents/{+path}","compare_url":"https://api.github.com/repos/ragnor-rs/visum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ragnor-rs/visum/merges","archive_url":"https://api.github.com/repos/ragnor-rs/visum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ragnor-rs/visum/downloads","issues_url":"https://api.github.com/repos/ragnor-rs/visum/issues{/number}","pulls_url":"https://api.github.com/repos/ragnor-rs/visum/pulls{/number}","milestones_url":"https://api.github.com/repos/ragnor-rs/visum/milestones{/number}","notifications_url":"https://api.github.com/repos/ragnor-rs/visum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ragnor-rs/visum/labels{/name}","releases_url":"https://api.github.com/repos/ragnor-rs/visum/releases{/id}","deployments_url":"https://api.github.com/repos/ragnor-rs/visum/deployments","created_at":"2015-11-23T11:03:46Z","updated_at":"2016-04-08T13:30:51Z","pushed_at":"2016-05-20T17:01:01Z","git_url":"git://github.com/ragnor-rs/visum.git","ssh_url":"git@github.com:ragnor-rs/visum.git","clone_url":"https://github.com/ragnor-rs/visum.git","svn_url":"https://github.com/ragnor-rs/visum","homepage":"","size":567,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"ragnor-rs:develop","ref":"develop","sha":"8614d36deac764b817ba14446d479e46f6ce9974","user":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"repo":{"id":46714751,"name":"visum","full_name":"ragnor-rs/visum","owner":{"login":"ragnor-rs","id":3357827,"avatar_url":"https://avatars.githubusercontent.com/u/3357827?v=3","gravatar_id":"","url":"https://api.github.com/users/ragnor-rs","html_url":"https://github.com/ragnor-rs","followers_url":"https://api.github.com/users/ragnor-rs/followers","following_url":"https://api.github.com/users/ragnor-rs/following{/other_user}","gists_url":"https://api.github.com/users/ragnor-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/ragnor-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragnor-rs/subscriptions","organizations_url":"https://api.github.com/users/ragnor-rs/orgs","repos_url":"https://api.github.com/users/ragnor-rs/repos","events_url":"https://api.github.com/users/ragnor-rs/events{/privacy}","received_events_url":"https://api.github.com/users/ragnor-rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ragnor-rs/visum","description":"Android reactive MVP stack","fork":false,"url":"https://api.github.com/repos/ragnor-rs/visum","forks_url":"https://api.github.com/repos/ragnor-rs/visum/forks","keys_url":"https://api.github.com/repos/ragnor-rs/visum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ragnor-rs/visum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ragnor-rs/visum/teams","hooks_url":"https://api.github.com/repos/ragnor-rs/visum/hooks","issue_events_url":"https://api.github.com/repos/ragnor-rs/visum/issues/events{/number}","events_url":"https://api.github.com/repos/ragnor-rs/visum/events","assignees_url":"https://api.github.com/repos/ragnor-rs/visum/assignees{/user}","branches_url":"https://api.github.com/repos/ragnor-rs/visum/branches{/branch}","tags_url":"https://api.github.com/repos/ragnor-rs/visum/tags","blobs_url":"https://api.github.com/repos/ragnor-rs/visum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ragnor-rs/visum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ragnor-rs/visum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ragnor-rs/visum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ragnor-rs/visum/statuses/{sha}","languages_url":"https://api.github.com/repos/ragnor-rs/visum/languages","stargazers_url":"https://api.github.com/repos/ragnor-rs/visum/stargazers","contributors_url":"https://api.github.com/repos/ragnor-rs/visum/contributors","subscribers_url":"https://api.github.com/repos/ragnor-rs/visum/subscribers","subscription_url":"https://api.github.com/repos/ragnor-rs/visum/subscription","commits_url":"https://api.github.com/repos/ragnor-rs/visum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ragnor-rs/visum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ragnor-rs/visum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ragnor-rs/visum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ragnor-rs/visum/contents/{+path}","compare_url":"https://api.github.com/repos/ragnor-rs/visum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ragnor-rs/visum/merges","archive_url":"https://api.github.com/repos/ragnor-rs/visum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ragnor-rs/visum/downloads","issues_url":"https://api.github.com/repos/ragnor-rs/visum/issues{/number}","pulls_url":"https://api.github.com/repos/ragnor-rs/visum/pulls{/number}","milestones_url":"https://api.github.com/repos/ragnor-rs/visum/milestones{/number}","notifications_url":"https://api.github.com/repos/ragnor-rs/visum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ragnor-rs/visum/labels{/name}","releases_url":"https://api.github.com/repos/ragnor-rs/visum/releases{/id}","deployments_url":"https://api.github.com/repos/ragnor-rs/visum/deployments","created_at":"2015-11-23T11:03:46Z","updated_at":"2016-04-08T13:30:51Z","pushed_at":"2016-05-20T17:01:01Z","git_url":"git://github.com/ragnor-rs/visum.git","ssh_url":"git@github.com:ragnor-rs/visum.git","clone_url":"https://github.com/ragnor-rs/visum.git","svn_url":"https://github.com/ragnor-rs/visum","homepage":"","size":567,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/34"},"html":{"href":"https://github.com/ragnor-rs/visum/pull/34"},"issue":{"href":"https://api.github.com/repos/ragnor-rs/visum/issues/34"},"comments":{"href":"https://api.github.com/repos/ragnor-rs/visum/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ragnor-rs/visum/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ragnor-rs/visum/statuses/9bb4ed5d06a3f8f6fc7d9050c98ae9c6b86a2c66"}}}}
{"actor":{"display_login":"ragnor-rs"}}