{"action":"closed","number":839,"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839","id":83512057,"html_url":"https://github.com/videojs/videojs-contrib-hls/pull/839","diff_url":"https://github.com/videojs/videojs-contrib-hls/pull/839.diff","patch_url":"https://github.com/videojs/videojs-contrib-hls/pull/839.patch","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/839","number":839,"state":"closed","locked":false,"title":"Prevent loading first segment of live manifest - seek to and load segment at current time","user":{"login":"marguinbc","id":7116728,"avatar_url":"https://avatars.githubusercontent.com/u/7116728?v=3","gravatar_id":"","url":"https://api.github.com/users/marguinbc","html_url":"https://github.com/marguinbc","followers_url":"https://api.github.com/users/marguinbc/followers","following_url":"https://api.github.com/users/marguinbc/following{/other_user}","gists_url":"https://api.github.com/users/marguinbc/gists{/gist_id}","starred_url":"https://api.github.com/users/marguinbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marguinbc/subscriptions","organizations_url":"https://api.github.com/users/marguinbc/orgs","repos_url":"https://api.github.com/users/marguinbc/repos","events_url":"https://api.github.com/users/marguinbc/events{/privacy}","received_events_url":"https://api.github.com/users/marguinbc/received_events","type":"User","site_admin":false},"body":"## Description\r\nCurrently in setupFirstPlay() we are performing a load() followed by a seek to the current live point in the manifest. The first segment is never played, resulting in wasted bandwidth as the segment is downloaded and ignored. Speaking to core contributors, this logic appears to be left over from when earlier versions of FF could not seek without first loading some segment and has since been fixed.\r\n\r\nThis suggested fix moves the load() call to immediately after setting the seekable range to the current Time to avoid loading the first segment. This results in loading the first segment at the current point in time.\r\n\r\nTests were also adjusted to reflect this new behavior. \r\n\r\n## Specific Changes proposed\r\nMoving load() after seeking in setupFirstPlay()\r\n\r\n## Requirements Checklist\r\n- [ x ]  Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [ x ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](http://jsbin.com/liwecukasi/edit?html,output))\r\n- [ x] Reviewed by Two Core Contributors\r\n","created_at":"2016-08-31T19:15:45Z","updated_at":"2016-09-16T19:34:29Z","closed_at":"2016-09-16T19:34:29Z","merged_at":"2016-09-16T19:34:29Z","merge_commit_sha":"5371ba24c87dd4f1b292fa1a98bf33497c07c658","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/839/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/b5321705defe7edeb0f0dc094992ca882279d201","head":{"label":"marguinbc:load-last-segment","ref":"load-last-segment","sha":"b5321705defe7edeb0f0dc094992ca882279d201","user":{"login":"marguinbc","id":7116728,"avatar_url":"https://avatars.githubusercontent.com/u/7116728?v=3","gravatar_id":"","url":"https://api.github.com/users/marguinbc","html_url":"https://github.com/marguinbc","followers_url":"https://api.github.com/users/marguinbc/followers","following_url":"https://api.github.com/users/marguinbc/following{/other_user}","gists_url":"https://api.github.com/users/marguinbc/gists{/gist_id}","starred_url":"https://api.github.com/users/marguinbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marguinbc/subscriptions","organizations_url":"https://api.github.com/users/marguinbc/orgs","repos_url":"https://api.github.com/users/marguinbc/repos","events_url":"https://api.github.com/users/marguinbc/events{/privacy}","received_events_url":"https://api.github.com/users/marguinbc/received_events","type":"User","site_admin":false},"repo":{"id":62837327,"name":"videojs-contrib-hls","full_name":"marguinbc/videojs-contrib-hls","owner":{"login":"marguinbc","id":7116728,"avatar_url":"https://avatars.githubusercontent.com/u/7116728?v=3","gravatar_id":"","url":"https://api.github.com/users/marguinbc","html_url":"https://github.com/marguinbc","followers_url":"https://api.github.com/users/marguinbc/followers","following_url":"https://api.github.com/users/marguinbc/following{/other_user}","gists_url":"https://api.github.com/users/marguinbc/gists{/gist_id}","starred_url":"https://api.github.com/users/marguinbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marguinbc/subscriptions","organizations_url":"https://api.github.com/users/marguinbc/orgs","repos_url":"https://api.github.com/users/marguinbc/repos","events_url":"https://api.github.com/users/marguinbc/events{/privacy}","received_events_url":"https://api.github.com/users/marguinbc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marguinbc/videojs-contrib-hls","description":"HLS library for video.js","fork":true,"url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls","forks_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/releases{/id}","deployments_url":"https://api.github.com/repos/marguinbc/videojs-contrib-hls/deployments","created_at":"2016-07-07T20:50:22Z","updated_at":"2016-07-07T20:50:24Z","pushed_at":"2016-08-31T19:14:32Z","git_url":"git://github.com/marguinbc/videojs-contrib-hls.git","ssh_url":"git@github.com:marguinbc/videojs-contrib-hls.git","clone_url":"https://github.com/marguinbc/videojs-contrib-hls.git","svn_url":"https://github.com/marguinbc/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":14763,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"e4e9d157542dc2abc6dcc70467f08e7e21dfa8e7","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":14029328,"name":"videojs-contrib-hls","full_name":"videojs/videojs-contrib-hls","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-hls","description":"HLS library for video.js","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-hls","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/deployments","created_at":"2013-10-31T21:55:21Z","updated_at":"2016-09-15T16:31:44Z","pushed_at":"2016-09-16T19:34:29Z","git_url":"git://github.com/videojs/videojs-contrib-hls.git","ssh_url":"git@github.com:videojs/videojs-contrib-hls.git","clone_url":"https://github.com/videojs/videojs-contrib-hls.git","svn_url":"https://github.com/videojs/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":25025,"stargazers_count":823,"watchers_count":823,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":364,"mirror_url":null,"open_issues_count":121,"forks":364,"open_issues":121,"watchers":823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839"},"html":{"href":"https://github.com/videojs/videojs-contrib-hls/pull/839"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/839"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/839/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/839/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/b5321705defe7edeb0f0dc094992ca882279d201"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"imbcmdth","id":162465,"avatar_url":"https://avatars.githubusercontent.com/u/162465?v=3","gravatar_id":"","url":"https://api.github.com/users/imbcmdth","html_url":"https://github.com/imbcmdth","followers_url":"https://api.github.com/users/imbcmdth/followers","following_url":"https://api.github.com/users/imbcmdth/following{/other_user}","gists_url":"https://api.github.com/users/imbcmdth/gists{/gist_id}","starred_url":"https://api.github.com/users/imbcmdth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imbcmdth/subscriptions","organizations_url":"https://api.github.com/users/imbcmdth/orgs","repos_url":"https://api.github.com/users/imbcmdth/repos","events_url":"https://api.github.com/users/imbcmdth/events{/privacy}","received_events_url":"https://api.github.com/users/imbcmdth/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":9,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"imbcmdth"}}