{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/4396","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/4396/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/4396/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/4396/events","html_url":"https://github.com/brave/browser-laptop/pull/4396","id":180229962,"number":4396,"title":"ledger backup and recovery","user":{"login":"jkup","id":490294,"avatar_url":"https://avatars.githubusercontent.com/u/490294?v=3","gravatar_id":"","url":"https://api.github.com/users/jkup","html_url":"https://github.com/jkup","followers_url":"https://api.github.com/users/jkup/followers","following_url":"https://api.github.com/users/jkup/following{/other_user}","gists_url":"https://api.github.com/users/jkup/gists{/gist_id}","starred_url":"https://api.github.com/users/jkup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkup/subscriptions","organizations_url":"https://api.github.com/users/jkup/orgs","repos_url":"https://api.github.com/users/jkup/repos","events_url":"https://api.github.com/users/jkup/events{/privacy}","received_events_url":"https://api.github.com/users/jkup/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brave/browser-laptop/labels/design","name":"design","color":"207de5"},{"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ledger","name":"feature/ledger","color":"ff5000"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/38","html_url":"https://github.com/brave/browser-laptop/milestones/0.12.5dev","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/38/labels","id":2027099,"number":38,"title":"0.12.5dev","description":"","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":2,"state":"open","created_at":"2016-09-25T17:57:04Z","updated_at":"2016-10-07T22:16:41Z","due_on":"2016-10-12T00:00:00Z","closed_at":null},"comments":9,"created_at":"2016-09-30T06:28:45Z","updated_at":"2016-10-07T23:19:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/4396","html_url":"https://github.com/brave/browser-laptop/pull/4396","diff_url":"https://github.com/brave/browser-laptop/pull/4396.diff","patch_url":"https://github.com/brave/browser-laptop/pull/4396.patch"},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nFixes #3350\r\n\r\nAuditors @bbondy @bradleyrichter \r\n\r\nStill remaining\r\n\r\n- [x] Modals still need some custom CSS\r\n- [x] Generate a new file with fs.writeStream for printing / saving\r\n  - [x] Either ignore generated file or delete after printing or saving\r\n- [x] Re-implement printing and saving with the new file\r\n- [x] Send data from recovery form to ledger.js\r\n  - [x] Send response back to UI and display message to user\r\n- [x] Link through settings like minimum page time and minimum visits\r\n- [ ] At least write automated tests proving backup and recover flow"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/252382906","html_url":"https://github.com/brave/browser-laptop/pull/4396#issuecomment-252382906","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/4396","id":252382906,"user":{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars.githubusercontent.com/u/549654?v=3","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T23:19:40Z","updated_at":"2016-10-07T23:19:40Z","body":"the `Print keys` and `Save recovery file..` functionality isn't working. Just says LEDGERBACKUPTEXT right now.\r\n![screen shot 2016-10-07 at 4 17 49 pm](https://cloud.githubusercontent.com/assets/549654/19207962/d8796804-8ca9-11e6-9bd4-1223d40cf661.png)\r\n"}}
{"actor":{"display_login":"diracdeltas"}}