{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/61188658","id":61188658,"diff_hunk":"@@ -0,0 +1,35 @@\n+/*\n+ * Copyright 2015-2016 Red Hat, Inc. and/or its affiliates\n+ * and other contributors as indicated by the @author tags.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.hawkular.wildfly.agent.installer;\n+\n+public interface TargetConfigInfo {\n+    /**\n+     * The root that all other xpaths are relative to.\n+     */\n+    String getRootXPath();\n+\n+    /**\n+     * @return the XPath that refers to the security-realms element in the config file.\n+     */\n+    String getSecurityRealmsXPath();\n+\n+    /**\n+     * @return the XPath that refers to the profile element in the config file.\n+     */\n+    String getProfileXPath();\n+\n+}","path":"hawkular-wildfly-agent-installer/src/main/java/org/hawkular/wildfly/agent/installer/TargetConfigInfo.java","position":35,"original_position":35,"commit_id":"f73039b464508df526e7ca77c4276db123a89054","original_commit_id":"f73039b464508df526e7ca77c4276db123a89054","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=3","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"body":"if you were interested in using java8 default methods this might be a decent place to do it since the overriding impls are often the same.","created_at":"2016-04-27T00:46:21Z","updated_at":"2016-04-27T00:46:21Z","html_url":"https://github.com/hawkular/hawkular-agent/pull/169#discussion_r61188658","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/61188658"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/169#discussion_r61188658"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169","id":67974020,"html_url":"https://github.com/hawkular/hawkular-agent/pull/169","diff_url":"https://github.com/hawkular/hawkular-agent/pull/169.diff","patch_url":"https://github.com/hawkular/hawkular-agent/pull/169.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/169","number":169,"state":"open","locked":false,"title":"HWKAGENT-71 Get agent to be installable and runnable inside host controller","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"body":"this simply allows the agent to be installed in a host controller and run in a host controller.\r\n\r\nIt runs, but because some DMR resources are missing or in different paths when in host controller vs. standalone, the monitoring fails. We'd just have to figure out what, if anything, we want to monitor in here. But I think that's a separate issue we can work on later. This simply gets the installation correct so it can at least run in the different container environments.","created_at":"2016-04-26T23:22:22Z","updated_at":"2016-04-27T00:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b397757c9b512a9ad128986ce46a4aaf2dc01ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/169/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/f73039b464508df526e7ca77c4276db123a89054","head":{"label":"jmazzitelli:mazz/hwkagent-71-host-controller","ref":"mazz/hwkagent-71-host-controller","sha":"f73039b464508df526e7ca77c4276db123a89054","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"repo":{"id":56713053,"name":"hawkular-agent","full_name":"jmazzitelli/hawkular-agent","owner":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmazzitelli/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":true,"url":"https://api.github.com/repos/jmazzitelli/hawkular-agent","forks_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/forks","keys_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/events","assignees_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/merges","archive_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/releases{/id}","deployments_url":"https://api.github.com/repos/jmazzitelli/hawkular-agent/deployments","created_at":"2016-04-20T18:54:20Z","updated_at":"2016-04-20T18:54:22Z","pushed_at":"2016-04-26T23:04:48Z","git_url":"git://github.com/jmazzitelli/hawkular-agent.git","ssh_url":"git@github.com:jmazzitelli/hawkular-agent.git","clone_url":"https://github.com/jmazzitelli/hawkular-agent.git","svn_url":"https://github.com/jmazzitelli/hawkular-agent","homepage":null,"size":2657,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"b789b39d9fb8a9e770925d4789eea51ed7542db9","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":33185377,"name":"hawkular-agent","full_name":"hawkular/hawkular-agent","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-agent","forks_url":"https://api.github.com/repos/hawkular/hawkular-agent/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-agent/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-agent/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-agent/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-agent/deployments","created_at":"2015-03-31T12:56:14Z","updated_at":"2016-04-18T15:57:36Z","pushed_at":"2016-04-26T23:22:23Z","git_url":"git://github.com/hawkular/hawkular-agent.git","ssh_url":"git@github.com:hawkular/hawkular-agent.git","clone_url":"https://github.com/hawkular/hawkular-agent.git","svn_url":"https://github.com/hawkular/hawkular-agent","homepage":null,"size":2675,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/169"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/169"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/f73039b464508df526e7ca77c4276db123a89054"}}}}