{"action":"created","comment":{"url":"https://api.github.com/repos/appnexus/lucid/pulls/comments/80520805","id":80520805,"diff_hunk":"@@ -286,7 +286,11 @@ const Bars = createClass({\n \t\t\t\t\t\t\t\t\t\t\t\tpointKind={1}\n \t\t\t\t\t\t\t\t\t\t\t\tcolor={_.get(colorMap, field, palette[(fieldIndex + colorOffset ) % palette.length])}\n \t\t\t\t\t\t\t\t\t\t\t>\n-\t\t\t\t\t\t\t\t\t\t\t\t{yTooltipFormatter(_.get(legend, field, field), yFormatter(data[seriesIndex][field]))}\n+\t\t\t\t\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\t\t\t\t\tyTooltipFormatter(_.get(legend, field, field),\n+\t\t\t\t\t\t\t\t\t\t\t\t\tyFormatter(data[seriesIndex][field])),\n+\t\t\t\t\t\t\t\t\t\t\t\t\t(data[seriesIndex][field])","path":"src/components/Bars/Bars.jsx","position":17,"original_position":17,"commit_id":"fab987c8083e488b88ea340bafa00d2e7588f519","original_commit_id":"fab987c8083e488b88ea340bafa00d2e7588f519","user":{"login":"reddyesha","id":4751583,"avatar_url":"https://avatars.githubusercontent.com/u/4751583?v=3","gravatar_id":"","url":"https://api.github.com/users/reddyesha","html_url":"https://github.com/reddyesha","followers_url":"https://api.github.com/users/reddyesha/followers","following_url":"https://api.github.com/users/reddyesha/following{/other_user}","gists_url":"https://api.github.com/users/reddyesha/gists{/gist_id}","starred_url":"https://api.github.com/users/reddyesha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddyesha/subscriptions","organizations_url":"https://api.github.com/users/reddyesha/orgs","repos_url":"https://api.github.com/users/reddyesha/repos","events_url":"https://api.github.com/users/reddyesha/events{/privacy}","received_events_url":"https://api.github.com/users/reddyesha/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2016-09-26T16:56:52Z","updated_at":"2016-09-26T16:56:52Z","html_url":"https://github.com/appnexus/lucid/pull/532#discussion_r80520805","pull_request_url":"https://api.github.com/repos/appnexus/lucid/pulls/532","_links":{"self":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/comments/80520805"},"html":{"href":"https://github.com/appnexus/lucid/pull/532#discussion_r80520805"},"pull_request":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/532"}}},"pull_request":{"url":"https://api.github.com/repos/appnexus/lucid/pulls/532","id":86548214,"html_url":"https://github.com/appnexus/lucid/pull/532","diff_url":"https://github.com/appnexus/lucid/pull/532.diff","patch_url":"https://github.com/appnexus/lucid/pull/532.patch","issue_url":"https://api.github.com/repos/appnexus/lucid/issues/532","number":532,"state":"open","locked":false,"title":"524: Add Number Formatters, 519: Add yValue to yAxisTooltipFormatter signature","user":{"login":"reddyesha","id":4751583,"avatar_url":"https://avatars.githubusercontent.com/u/4751583?v=3","gravatar_id":"","url":"https://api.github.com/users/reddyesha","html_url":"https://github.com/reddyesha","followers_url":"https://api.github.com/users/reddyesha/followers","following_url":"https://api.github.com/users/reddyesha/following{/other_user}","gists_url":"https://api.github.com/users/reddyesha/gists{/gist_id}","starred_url":"https://api.github.com/users/reddyesha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddyesha/subscriptions","organizations_url":"https://api.github.com/users/reddyesha/orgs","repos_url":"https://api.github.com/users/reddyesha/repos","events_url":"https://api.github.com/users/reddyesha/events{/privacy}","received_events_url":"https://api.github.com/users/reddyesha/received_events","type":"User","site_admin":false},"body":"## Details\n\nWIP. Would like feedback on how to handle allowing users to pass in different formatters to format axes and tooltips differently.\n\n<img width=\"996\" alt=\"screen shot 2016-09-22 at 10 39 51 am\" src=\"https://cloud.githubusercontent.com/assets/4751583/18795639/4df8b1f6-817a-11e6-9b77-f336e97d1022.png\">\n\n## PR Checklist\n\n- Manually tested across supported browsers\n  - [x] Chrome\n  - [x] Firefox\n  - [x] Safari\n  - [x] IE11 (Win 7)\n  - [x] Edge (Win 10)\n- [ ] Unit tests written (`common` at minimum)\n- [x] PR has one of the `semver-` labels\n- [ ] Two core team engineer approvals\n- [ ] One core team UX approval\n\nFixes #519\nFixes #524","created_at":"2016-09-23T17:09:50Z","updated_at":"2016-09-26T16:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a10a31e090ac4b09c6af8de84f113e2ae06a1a1c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appnexus/lucid/pulls/532/commits","review_comments_url":"https://api.github.com/repos/appnexus/lucid/pulls/532/comments","review_comment_url":"https://api.github.com/repos/appnexus/lucid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appnexus/lucid/issues/532/comments","statuses_url":"https://api.github.com/repos/appnexus/lucid/statuses/fab987c8083e488b88ea340bafa00d2e7588f519","head":{"label":"appnexus:feature/524-add-number-formatters","ref":"feature/524-add-number-formatters","sha":"fab987c8083e488b88ea340bafa00d2e7588f519","user":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"repo":{"id":51951143,"name":"lucid","full_name":"appnexus/lucid","owner":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appnexus/lucid","description":"A UI component library from AppNexus.","fork":false,"url":"https://api.github.com/repos/appnexus/lucid","forks_url":"https://api.github.com/repos/appnexus/lucid/forks","keys_url":"https://api.github.com/repos/appnexus/lucid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appnexus/lucid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appnexus/lucid/teams","hooks_url":"https://api.github.com/repos/appnexus/lucid/hooks","issue_events_url":"https://api.github.com/repos/appnexus/lucid/issues/events{/number}","events_url":"https://api.github.com/repos/appnexus/lucid/events","assignees_url":"https://api.github.com/repos/appnexus/lucid/assignees{/user}","branches_url":"https://api.github.com/repos/appnexus/lucid/branches{/branch}","tags_url":"https://api.github.com/repos/appnexus/lucid/tags","blobs_url":"https://api.github.com/repos/appnexus/lucid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appnexus/lucid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appnexus/lucid/git/refs{/sha}","trees_url":"https://api.github.com/repos/appnexus/lucid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appnexus/lucid/statuses/{sha}","languages_url":"https://api.github.com/repos/appnexus/lucid/languages","stargazers_url":"https://api.github.com/repos/appnexus/lucid/stargazers","contributors_url":"https://api.github.com/repos/appnexus/lucid/contributors","subscribers_url":"https://api.github.com/repos/appnexus/lucid/subscribers","subscription_url":"https://api.github.com/repos/appnexus/lucid/subscription","commits_url":"https://api.github.com/repos/appnexus/lucid/commits{/sha}","git_commits_url":"https://api.github.com/repos/appnexus/lucid/git/commits{/sha}","comments_url":"https://api.github.com/repos/appnexus/lucid/comments{/number}","issue_comment_url":"https://api.github.com/repos/appnexus/lucid/issues/comments{/number}","contents_url":"https://api.github.com/repos/appnexus/lucid/contents/{+path}","compare_url":"https://api.github.com/repos/appnexus/lucid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appnexus/lucid/merges","archive_url":"https://api.github.com/repos/appnexus/lucid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appnexus/lucid/downloads","issues_url":"https://api.github.com/repos/appnexus/lucid/issues{/number}","pulls_url":"https://api.github.com/repos/appnexus/lucid/pulls{/number}","milestones_url":"https://api.github.com/repos/appnexus/lucid/milestones{/number}","notifications_url":"https://api.github.com/repos/appnexus/lucid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appnexus/lucid/labels{/name}","releases_url":"https://api.github.com/repos/appnexus/lucid/releases{/id}","deployments_url":"https://api.github.com/repos/appnexus/lucid/deployments","created_at":"2016-02-17T19:59:27Z","updated_at":"2016-09-25T20:38:25Z","pushed_at":"2016-09-23T20:44:35Z","git_url":"git://github.com/appnexus/lucid.git","ssh_url":"git@github.com:appnexus/lucid.git","clone_url":"https://github.com/appnexus/lucid.git","svn_url":"https://github.com/appnexus/lucid","homepage":"http://appnexus.github.io/lucid","size":4161,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":61,"forks":14,"open_issues":61,"watchers":42,"default_branch":"master"}},"base":{"label":"appnexus:master","ref":"master","sha":"bdfab2df70aa6f1c1b34716a4c4f9019f541289b","user":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"repo":{"id":51951143,"name":"lucid","full_name":"appnexus/lucid","owner":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appnexus/lucid","description":"A UI component library from AppNexus.","fork":false,"url":"https://api.github.com/repos/appnexus/lucid","forks_url":"https://api.github.com/repos/appnexus/lucid/forks","keys_url":"https://api.github.com/repos/appnexus/lucid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appnexus/lucid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appnexus/lucid/teams","hooks_url":"https://api.github.com/repos/appnexus/lucid/hooks","issue_events_url":"https://api.github.com/repos/appnexus/lucid/issues/events{/number}","events_url":"https://api.github.com/repos/appnexus/lucid/events","assignees_url":"https://api.github.com/repos/appnexus/lucid/assignees{/user}","branches_url":"https://api.github.com/repos/appnexus/lucid/branches{/branch}","tags_url":"https://api.github.com/repos/appnexus/lucid/tags","blobs_url":"https://api.github.com/repos/appnexus/lucid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appnexus/lucid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appnexus/lucid/git/refs{/sha}","trees_url":"https://api.github.com/repos/appnexus/lucid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appnexus/lucid/statuses/{sha}","languages_url":"https://api.github.com/repos/appnexus/lucid/languages","stargazers_url":"https://api.github.com/repos/appnexus/lucid/stargazers","contributors_url":"https://api.github.com/repos/appnexus/lucid/contributors","subscribers_url":"https://api.github.com/repos/appnexus/lucid/subscribers","subscription_url":"https://api.github.com/repos/appnexus/lucid/subscription","commits_url":"https://api.github.com/repos/appnexus/lucid/commits{/sha}","git_commits_url":"https://api.github.com/repos/appnexus/lucid/git/commits{/sha}","comments_url":"https://api.github.com/repos/appnexus/lucid/comments{/number}","issue_comment_url":"https://api.github.com/repos/appnexus/lucid/issues/comments{/number}","contents_url":"https://api.github.com/repos/appnexus/lucid/contents/{+path}","compare_url":"https://api.github.com/repos/appnexus/lucid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appnexus/lucid/merges","archive_url":"https://api.github.com/repos/appnexus/lucid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appnexus/lucid/downloads","issues_url":"https://api.github.com/repos/appnexus/lucid/issues{/number}","pulls_url":"https://api.github.com/repos/appnexus/lucid/pulls{/number}","milestones_url":"https://api.github.com/repos/appnexus/lucid/milestones{/number}","notifications_url":"https://api.github.com/repos/appnexus/lucid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appnexus/lucid/labels{/name}","releases_url":"https://api.github.com/repos/appnexus/lucid/releases{/id}","deployments_url":"https://api.github.com/repos/appnexus/lucid/deployments","created_at":"2016-02-17T19:59:27Z","updated_at":"2016-09-25T20:38:25Z","pushed_at":"2016-09-23T20:44:35Z","git_url":"git://github.com/appnexus/lucid.git","ssh_url":"git@github.com:appnexus/lucid.git","clone_url":"https://github.com/appnexus/lucid.git","svn_url":"https://github.com/appnexus/lucid","homepage":"http://appnexus.github.io/lucid","size":4161,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":61,"forks":14,"open_issues":61,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/532"},"html":{"href":"https://github.com/appnexus/lucid/pull/532"},"issue":{"href":"https://api.github.com/repos/appnexus/lucid/issues/532"},"comments":{"href":"https://api.github.com/repos/appnexus/lucid/issues/532/comments"},"review_comments":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/532/comments"},"review_comment":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appnexus/lucid/pulls/532/commits"},"statuses":{"href":"https://api.github.com/repos/appnexus/lucid/statuses/fab987c8083e488b88ea340bafa00d2e7588f519"}}}}
{"actor":{"display_login":"reddyesha"}}