{"action":"created","issue":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/57","repository_url":"https://api.github.com/repos/AtheMathmo/rusty-machine","labels_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/57/comments","events_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/57/events","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/57","id":151543816,"number":57,"title":"clean up compiler warnings","user":{"login":"zackmdavis","id":1076988,"avatar_url":"https://avatars.githubusercontent.com/u/1076988?v=3","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-28T03:52:34Z","updated_at":"2016-04-28T03:59:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/pulls/57","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/57","diff_url":"https://github.com/AtheMathmo/rusty-machine/pull/57.diff","patch_url":"https://github.com/AtheMathmo/rusty-machine/pull/57.patch"},"body":"The augmented-assignment tests in particular generated a lot of\r\nunused-variable and unused-assignment warnings, which are undesirable\r\nnot only on æsthetic developer-experience grounds but, more importantly,\r\nbecause genuinely useful warnings inadvertently set off by future\r\ndevelopment efforts could get lost in the noise. Typically one would\r\nindicate an intentionally-unused variable by choosing an identifier\r\nstarting with an underscore, but in the case of the augmented-assignment\r\ntests, the `allow`-directive attributes seem more appropriate: the\r\n`a_slice` variables weren't _really_ unused; it's just that `rustc`\r\nisn't smart enough to notice that they're views into an underlying\r\nmatrix which is being used."},"comment":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/comments/215303738","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/57#issuecomment-215303738","issue_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/57","id":215303738,"user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T03:59:10Z","updated_at":"2016-04-28T03:59:10Z","body":"I haven't been getting these compiler warnings that you're seeing on the op assignment tests. I do however see the `output` warning which I have been meaning to fix...\r\n\r\nI'm happy to accept this fix but want to try and figure out the reason why it is occurring first!\r\n\r\nCould you confirm which version of Rust you're using? I'm on 1.8.0."}}