{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/1049","labels_url":"https://api.github.com/repos/octokit/octokit.net/issues/1049/labels{/name}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1049/comments","events_url":"https://api.github.com/repos/octokit/octokit.net/issues/1049/events","html_url":"https://github.com/octokit/octokit.net/pull/1049","id":123934803,"number":1049,"title":"Implement Enterprise Admin Stats API","user":{"login":"ryangribble","id":5425163,"avatar_url":"https://avatars.githubusercontent.com/u/5425163?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble","html_url":"https://github.com/ryangribble","followers_url":"https://api.github.com/users/ryangribble/followers","following_url":"https://api.github.com/users/ryangribble/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble/subscriptions","organizations_url":"https://api.github.com/users/ryangribble/orgs","repos_url":"https://api.github.com/users/ryangribble/repos","events_url":"https://api.github.com/users/ryangribble/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-26T15:26:21Z","updated_at":"2016-01-17T23:26:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1049","html_url":"https://github.com/octokit/octokit.net/pull/1049","diff_url":"https://github.com/octokit/octokit.net/pull/1049.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1049.patch"},"body":"Closes #1021 \r\n\r\nAdded base Enterprise Client\r\nImplemented EnterpriseAdminStats client and response objects\r\nAdded Observable implementations\r\nAdded unit tests and integration tests\r\nAdded new [GitHubEnterpriseTest] marker for integration tests that require GitHub Enterprise, only discoverable when the integration test variable for GHE is setup\r\n\r\nAll convention tests, unit tests and integration tests are passing.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/comments/172395130","html_url":"https://github.com/octokit/octokit.net/pull/1049#issuecomment-172395130","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1049","id":172395130,"user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"created_at":"2016-01-17T23:26:09Z","updated_at":"2016-01-17T23:26:09Z","body":"@ryangribble excellent questions!\r\n\r\n> Out of interest with octokit.net contributions, is there a preference between rebase on master vs merging master?\r\n\r\nI'm not fussed by either approach, but merging master does help keep make the code review process easier to follow on my end.\r\n\r\n> Similarly is there a preference to squash the commits down once it's ready to go in, or you aren't bothered by the larger number of in progress commits etc?\r\n\r\nI'm really not a fan of squashing together dozens of commits when it's done - but you're right about those scenarios where people just want to commit stuff before it's ready. I know I *should* care about ensuring each commit in each PR builds and passes all tests, but I don't. As long as the history is readable and easy to follow, I'm happy."}}