{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/80673229","pull_request_review_id":1714087,"id":80673229,"diff_hunk":"@@ -240,6 +236,7 @@ static void window_track_manage_invalidate(rct_window *w)\n  */\n static void window_track_manage_paint(rct_window *w, rct_drawpixelinfo *dpi)\n {\n+\tset_format_arg(0, char *, _trackDesignFileReference->name);","path":"src/windows/track_manage.c","position":15,"original_position":15,"commit_id":"3344a908773b2eac7f43dd8d4b73e64ae24f04d8","original_commit_id":"3344a908773b2eac7f43dd8d4b73e64ae24f04d8","user":{"login":"duncanspumpkin","id":1277401,"avatar_url":"https://avatars.githubusercontent.com/u/1277401?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanspumpkin","html_url":"https://github.com/duncanspumpkin","followers_url":"https://api.github.com/users/duncanspumpkin/followers","following_url":"https://api.github.com/users/duncanspumpkin/following{/other_user}","gists_url":"https://api.github.com/users/duncanspumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanspumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanspumpkin/subscriptions","organizations_url":"https://api.github.com/users/duncanspumpkin/orgs","repos_url":"https://api.github.com/users/duncanspumpkin/repos","events_url":"https://api.github.com/users/duncanspumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/duncanspumpkin/received_events","type":"User","site_admin":false},"body":"You've forgotten to change the 3155 here.","created_at":"2016-09-27T11:43:54Z","updated_at":"2016-09-27T11:43:54Z","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4490#discussion_r80673229","pull_request_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490","_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/80673229"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/4490#discussion_r80673229"},"pull_request":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490","id":86673558,"html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4490","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4490.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4490.patch","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4490","number":4490,"state":"open","locked":false,"title":"[WIP] Refactor/Improve String and Path Handling","user":{"login":"LRFLEW","id":607715,"avatar_url":"https://avatars.githubusercontent.com/u/607715?v=3","gravatar_id":"","url":"https://api.github.com/users/LRFLEW","html_url":"https://github.com/LRFLEW","followers_url":"https://api.github.com/users/LRFLEW/followers","following_url":"https://api.github.com/users/LRFLEW/following{/other_user}","gists_url":"https://api.github.com/users/LRFLEW/gists{/gist_id}","starred_url":"https://api.github.com/users/LRFLEW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRFLEW/subscriptions","organizations_url":"https://api.github.com/users/LRFLEW/orgs","repos_url":"https://api.github.com/users/LRFLEW/repos","events_url":"https://api.github.com/users/LRFLEW/events{/privacy}","received_events_url":"https://api.github.com/users/LRFLEW/received_events","type":"User","site_admin":false},"body":"I made this after figuring out the crash on macOS (which I initially fixed in #4485) and realized that having both the macro and function for the path separator was redundant. After noticing that the error I fixed priviously was in other parts of the code, I decided to just replace all the usage of `platform_get_path_separator` with `PATH_SEPARATOR`. I also noticed that `platform_get_new_line` served a similar purpose, so I separated it out into a macro as well. This PR includes the fix in #4485.","created_at":"2016-09-26T02:34:13Z","updated_at":"2016-09-27T11:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"679b9318610f9fe5c5643cd823acd89a731de036","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490/commits","review_comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490/comments","review_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4490/comments","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/3344a908773b2eac7f43dd8d4b73e64ae24f04d8","head":{"label":"LRFLEW:char_macros","ref":"char_macros","sha":"3344a908773b2eac7f43dd8d4b73e64ae24f04d8","user":{"login":"LRFLEW","id":607715,"avatar_url":"https://avatars.githubusercontent.com/u/607715?v=3","gravatar_id":"","url":"https://api.github.com/users/LRFLEW","html_url":"https://github.com/LRFLEW","followers_url":"https://api.github.com/users/LRFLEW/followers","following_url":"https://api.github.com/users/LRFLEW/following{/other_user}","gists_url":"https://api.github.com/users/LRFLEW/gists{/gist_id}","starred_url":"https://api.github.com/users/LRFLEW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRFLEW/subscriptions","organizations_url":"https://api.github.com/users/LRFLEW/orgs","repos_url":"https://api.github.com/users/LRFLEW/repos","events_url":"https://api.github.com/users/LRFLEW/events{/privacy}","received_events_url":"https://api.github.com/users/LRFLEW/received_events","type":"User","site_admin":false},"repo":{"id":36997679,"name":"OpenRCT2","full_name":"LRFLEW/OpenRCT2","owner":{"login":"LRFLEW","id":607715,"avatar_url":"https://avatars.githubusercontent.com/u/607715?v=3","gravatar_id":"","url":"https://api.github.com/users/LRFLEW","html_url":"https://github.com/LRFLEW","followers_url":"https://api.github.com/users/LRFLEW/followers","following_url":"https://api.github.com/users/LRFLEW/following{/other_user}","gists_url":"https://api.github.com/users/LRFLEW/gists{/gist_id}","starred_url":"https://api.github.com/users/LRFLEW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRFLEW/subscriptions","organizations_url":"https://api.github.com/users/LRFLEW/orgs","repos_url":"https://api.github.com/users/LRFLEW/repos","events_url":"https://api.github.com/users/LRFLEW/events{/privacy}","received_events_url":"https://api.github.com/users/LRFLEW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LRFLEW/OpenRCT2","description":"An open source clone of Roller Coaster Tycoon 2 built by decompiling the original game one bit at a time.","fork":true,"url":"https://api.github.com/repos/LRFLEW/OpenRCT2","forks_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/forks","keys_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/events","assignees_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/merges","archive_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/LRFLEW/OpenRCT2/deployments","created_at":"2015-06-06T22:54:16Z","updated_at":"2016-01-12T23:00:27Z","pushed_at":"2016-09-27T08:12:11Z","git_url":"git://github.com/LRFLEW/OpenRCT2.git","ssh_url":"git@github.com:LRFLEW/OpenRCT2.git","clone_url":"https://github.com/LRFLEW/OpenRCT2.git","svn_url":"https://github.com/LRFLEW/OpenRCT2","homepage":null,"size":41964,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenRCT2:develop","ref":"develop","sha":"d6e13a38e1a05bcfddd2c42af6b2007e479b034d","user":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"repo":{"id":18348651,"name":"OpenRCT2","full_name":"OpenRCT2/OpenRCT2","owner":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRCT2/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2.","fork":false,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","forks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/forks","keys_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/events","assignees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/merges","archive_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/deployments","created_at":"2014-04-01T23:32:25Z","updated_at":"2016-09-27T11:33:11Z","pushed_at":"2016-09-27T08:12:12Z","git_url":"git://github.com/OpenRCT2/OpenRCT2.git","ssh_url":"git@github.com:OpenRCT2/OpenRCT2.git","clone_url":"https://github.com/OpenRCT2/OpenRCT2.git","svn_url":"https://github.com/OpenRCT2/OpenRCT2","homepage":"http://openrct2.website","size":70872,"stargazers_count":2105,"watchers_count":2105,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":378,"mirror_url":null,"open_issues_count":590,"forks":378,"open_issues":590,"watchers":2105,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/4490"},"issue":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4490"},"comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4490/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4490/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/3344a908773b2eac7f43dd8d4b73e64ae24f04d8"}}}}
{"actor":{"display_login":"duncanspumpkin"}}