{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17844","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17844/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17844/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17844/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17844","id":172356582,"number":17844,"title":"Core/Scripts: set correct unit_flags on npc_scarlet_miner_cart","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-C++Script","name":"Comp-C++Script","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-PatchFix","name":"Feedback-PatchFix","color":"d7e102"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Quests","name":"Sub-Quests","color":"e10c02"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Spawns","name":"Sub-Spawns","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-22T02:03:10Z","updated_at":"2016-08-23T17:04:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17844","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17844","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17844.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17844.patch"},"body":"**Changes proposed:**\r\n\r\nAfter recent changes to the source, `npc_scarlet_miner_cart` gets attacked\r\nright after player enters the GO/NPC to be towed down to Light's Point.\r\nThis PR fixes the issue by making it non-attackable for NPCs.\r\n- remove the `UNIT_FLAG_IMMUNE_TO_PC` line used in this script.\r\n- add correct `unit_flags` to the DB entry/NPC ID 28817 Mine Car\r\n\r\nBased on the information provided by r00ty-tc in https://github.com/TrinityCore/TrinityCore/issues/17816#issuecomment-241528244 :\r\n```\r\n[1] UpdateType: CreateObject1\r\n[1] GUID: Full: 0xF1507091001852C8 Type: Vehicle Entry: 28817 Low: 1594056\r\n[1] Object Type: Unit (3) (0x0003)\r\n[1] Update Flags: Living, StationaryObject, Vehicle (224) (0x00E0)\r\n[1] Movement Flags: None (0) (0x0000)\r\n[1] Extra Movement Flags: None (0) (0x0000)\r\n.........\r\n[1] UNIT_FIELD_FLAGS: 520/7.286752E-43\r\n[1] UNIT_FIELD_FLAGS_2: 2048/2.869859E-42\r\n```\r\n\r\nFrom https://trinitycore.atlassian.net/wiki/display/tc/creature_template#creature_template-unit_flags :\r\n\r\n| Flag  | Hex    | Name                     | Comment                                                                              |\r\n| ----- | ------ |:------------------------ |:------------------------------------------------------------------------------------ |\r\n| 8     | 0x0008 | UNIT_FLAG_PVP_ATTACKABLE | Allows to apply PvP rules to attackable state in addition to faction dependent state |\r\n| 512   | 0x0200 | UNIT_FLAG_IMMUNE_TO_NPC  | Disables combat/assistance with NonPlayerCharacters (NPC)                            |\r\n\r\nCombined, this makes the `unit_flags` value 520 instead of 512 as I first suggested.\r\n\r\n**Target branch(es):** 3.3.5 and 6.x\r\n\r\n**Issues addressed:** Closes issue  #17816 (Core/Scripts/Quest: Massacre at Light's Point)\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc) Builds OK, tested by the issue participants.\r\n\r\n**Known issues and ToDo list:**\r\n\r\n- [X] remove wrong flag set in the core script\r\n- [X] set correct correct `unit_flags` on the DB entry/NPC ID 28817 'Mine Car'"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/241802743","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17844#issuecomment-241802743","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17844","id":241802743,"user":{"login":"DDuarte","id":530940,"avatar_url":"https://avatars.githubusercontent.com/u/530940?v=3","gravatar_id":"","url":"https://api.github.com/users/DDuarte","html_url":"https://github.com/DDuarte","followers_url":"https://api.github.com/users/DDuarte/followers","following_url":"https://api.github.com/users/DDuarte/following{/other_user}","gists_url":"https://api.github.com/users/DDuarte/gists{/gist_id}","starred_url":"https://api.github.com/users/DDuarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDuarte/subscriptions","organizations_url":"https://api.github.com/users/DDuarte/orgs","repos_url":"https://api.github.com/users/DDuarte/repos","events_url":"https://api.github.com/users/DDuarte/events{/privacy}","received_events_url":"https://api.github.com/users/DDuarte/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T17:04:38Z","updated_at":"2016-08-23T17:04:38Z","body":"Since summoned creatures and vehicle inherit the faction of their masters, WPP sort of ignores factions of players in creatures: https://github.com/TrinityCore/WowPacketParser/blob/master/WowPacketParser/SQL/Builders/WDBTemplates.cs#L96"}}
{"actor":{"display_login":"DDuarte"}}