{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/88","repository_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask","labels_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/88/comments","events_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/88/events","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/88","id":144420332,"number":88,"title":"Functional Tests to the Settings Component","user":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"blueandgold","id":6977544,"avatar_url":"https://avatars.githubusercontent.com/u/6977544?v=3","gravatar_id":"","url":"https://api.github.com/users/blueandgold","html_url":"https://github.com/blueandgold","followers_url":"https://api.github.com/users/blueandgold/followers","following_url":"https://api.github.com/users/blueandgold/following{/other_user}","gists_url":"https://api.github.com/users/blueandgold/gists{/gist_id}","starred_url":"https://api.github.com/users/blueandgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueandgold/subscriptions","organizations_url":"https://api.github.com/users/blueandgold/orgs","repos_url":"https://api.github.com/users/blueandgold/repos","events_url":"https://api.github.com/users/blueandgold/events{/privacy}","received_events_url":"https://api.github.com/users/blueandgold/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-29T23:44:12Z","updated_at":"2016-04-01T19:51:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/pulls/88","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/88","diff_url":"https://github.com/uProxy/ufo-management-server-flask/pull/88.diff","patch_url":"https://github.com/uProxy/ufo-management-server-flask/pull/88.patch"},"body":"This new set of functional tests verifies that the links to the settings component are in fact valid and that changing a settings and saving it will in fact be respected. The test necessitated a means to easily change a given setting and reset it back. Those pieces will likely prove very useful in the future as more settings are added. This new test should follow the page object model as previously fixed in the other tests.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/ufo-management-server-flask/88)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/comments/204541632","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/88#issuecomment-204541632","issue_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/88","id":204541632,"user":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T19:51:01Z","updated_at":"2016-04-01T19:51:01Z","body":"\n\n\n\nReviewed 8 of 8 files at r1, 5 of 5 files at r2.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[tests/ui/layout.py, line 53 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/88#-KEHz0R8PmiXOghzWJzi:-KEI81KmHrKUSYGfBUxA:755545747) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/2011296ca31e037eb10550441c1347987a23a226/tests/ui/layout.py#L53)):*\nFor the settings ones specifically, yes. However, since we reuse the ID for the proxy server display template, user display template, and chrome policy display template, those don't make as much sense. I was following the same approach here in the event that we end up displaying the settings on the landing page at some point in the future. However, it isn't now so I've went ahead with moving it. Done.\n\n---\n\n*[tests/ui/settings_component_test.py, line 60 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/88#-KEI11NWWT0R8jQa_7i4:-KEI8xA-xkKDdFQoQ5N5:-499146009) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/2011296ca31e037eb10550441c1347987a23a226/tests/ui/settings_component_test.py#L60)):*\nDone.\n\n---\n\n*[tests/ui/settings_component_test.py, line 65 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/88#-KEI1LxjqTSjChbCD9iG:-KEI8zMINC3k43pM15EY:1969229276) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/2011296ca31e037eb10550441c1347987a23a226/tests/ui/settings_component_test.py#L65)):*\nYes, but I held off on writing them for now. I tried to make it very easy to add those in later once we have more settings. Obviously, it would be fairly trivial to test the enforce network jail settings using this same code, but that didn't seem all that useful.\n\nI left a todo in the other file for adding ways to change future settings (whatever they may be) since they likely won't be just toggle switches, but potentially something more complex, like an input field that is more configurable. I'll add the necessary test for whatever those settings may be once we implement them.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/88)*\n<!-- Sent from Reviewable.io -->\n"}}