{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/92999630","pull_request_review_id":13506285,"id":92999630,"diff_hunk":"@@ -490,77 +503,87 @@ public Properties trackSingleVideoDownload(String videoId, String courseId,\n      * @return A {@link Properties} object populated with analytics-event info\n      */\n     @Override\n-    public Properties trackVideoOrientation(String videoId, Double currentTime,\n-                                            boolean isLandscape, String courseId, String unitUrl) {\n+    public void trackVideoOrientation(String videoId, Double currentTime,\n+                                      boolean isLandscape, String courseId, String unitUrl) {\n         SegmentAnalyticsEvent aEvent = getCommonPropertiesWithCurrentTime(currentTime,\n                 videoId, Values.FULLSREEN_TOGGLED);\n         aEvent.data.putValue(Keys.FULLSCREEN, isLandscape);\n         aEvent.setCourseContext(courseId, unitUrl, Values.VIDEOPLAYER);\n \n         tracker.track(Events.SCREEN_TOGGLED, aEvent.properties);\n-        return aEvent.properties;\n     }\n \n     @Override\n-    public Properties trackDiscoverCoursesClicked() {\n+    public void trackDiscoverCoursesClicked() {\n         SegmentAnalyticsEvent aEvent = new SegmentAnalyticsEvent();\n         aEvent.properties.putValue(Keys.NAME, Values.DISCOVER_COURSES_CLICK);\n         aEvent.setAppNameContext();\n         tracker.track(Events.DISCOVER_COURSES, aEvent.properties);\n-        return aEvent.properties;\n     }\n \n     @Override\n-    public Properties trackExploreSubjectsClicked() {\n+    public void trackExploreSubjectsClicked() {\n         SegmentAnalyticsEvent aEvent = new SegmentAnalyticsEvent();\n         aEvent.properties.putValue(Keys.NAME, Values.EXPLORE_SUBJECTS_CLICK);\n         aEvent.setAppNameContext();\n         tracker.track(Events.EXPLORE_SUBJECTS, aEvent.properties);\n-        return aEvent.properties;\n     }\n \n     /**\n      * This function is used to track User Login activity\n      * Method will take the following inputs “Password”|”Google”|”Facebook”\n      */\n     @Override\n-    public Properties trackUserLogin(String method) {\n+    public void trackUserLogin(String method, boolean didSucceed) {\n         SegmentAnalyticsEvent aEvent = new SegmentAnalyticsEvent();\n         aEvent.properties.putValue(Keys.NAME, Values.USERLOGIN);\n         //More information regarding a track event should be under 'data'\n         if (method != null) {\n             aEvent.data.putValue(Keys.METHOD, method);\n         }\n \n-\n+        aEvent.data.putValue(Keys.SUCCEED, didSucceed);\n         aEvent.setAppNameContext();\n         tracker.track(Events.USER_LOGIN, aEvent.properties);\n-        return aEvent.properties;\n     }\n \n+    /**\n+     * This function is used to track User Registration\n+     *\n+     * @param method     - will take the following inputs “Password”|”Google”|”Facebook”\n+     * @param didSucceed - Indicates whether the user succeed in the login or not\n+     */\n+    @Override\n+    public void trackUserRegister(String method, boolean didSucceed) {","path":"OpenEdXMobile/src/main/java/org/edx/mobile/module/analytics/SegmentAnalytics.java","position":544,"original_position":544,"commit_id":"c4342b4771d6726e63f026df0e02427b131bd462","original_commit_id":"c4342b4771d6726e63f026df0e02427b131bd462","user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"body":"Is this event documented?","created_at":"2016-12-19T09:58:53Z","updated_at":"2016-12-19T10:03:21Z","html_url":"https://github.com/edx/edx-app-android/pull/893#discussion_r92999630","pull_request_url":"https://api.github.com/repos/edx/edx-app-android/pulls/893","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/92999630"},"html":{"href":"https://github.com/edx/edx-app-android/pull/893#discussion_r92999630"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/893","id":97107271,"html_url":"https://github.com/edx/edx-app-android/pull/893","diff_url":"https://github.com/edx/edx-app-android/pull/893.diff","patch_url":"https://github.com/edx/edx-app-android/pull/893.patch","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/893","number":893,"state":"open","locked":false,"title":"Introduce generic framework for Analytics","user":{"login":"miankhalid","id":1710804,"avatar_url":"https://avatars.githubusercontent.com/u/1710804?v=3","gravatar_id":"","url":"https://api.github.com/users/miankhalid","html_url":"https://github.com/miankhalid","followers_url":"https://api.github.com/users/miankhalid/followers","following_url":"https://api.github.com/users/miankhalid/following{/other_user}","gists_url":"https://api.github.com/users/miankhalid/gists{/gist_id}","starred_url":"https://api.github.com/users/miankhalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miankhalid/subscriptions","organizations_url":"https://api.github.com/users/miankhalid/orgs","repos_url":"https://api.github.com/users/miankhalid/repos","events_url":"https://api.github.com/users/miankhalid/events{/privacy}","received_events_url":"https://api.github.com/users/miankhalid/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n[MA-2981](https://openedx.atlassian.net/browse/MA-2981)\r\n\r\nIntroducing `AnalyticsProvider` class which encapsulates all our analytics provider services and relays analytics events to all of them.\r\n\r\np.s. Each commit message contains detailed info on what its doing.\r\n\r\nFYI @ahmedaljazzar ","created_at":"2016-12-08T11:46:46Z","updated_at":"2016-12-19T10:03:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e94ea991e92b28b835b3f24b182328b8a2d12023","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-android/pulls/893/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-android/pulls/893/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/893/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/c4342b4771d6726e63f026df0e02427b131bd462","head":{"label":"edx:khalid/MA-2981","ref":"khalid/MA-2981","sha":"c4342b4771d6726e63f026df0e02427b131bd462","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-12-07T13:52:36Z","pushed_at":"2016-12-19T06:48:16Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":20960,"stargazers_count":102,"watchers_count":102,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"open_issues_count":15,"forks":117,"open_issues":15,"watchers":102,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"be83ec4dc07d6dbae3483853036f87f4c4e95434","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-12-07T13:52:36Z","pushed_at":"2016-12-19T06:48:16Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":20960,"stargazers_count":102,"watchers_count":102,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"open_issues_count":15,"forks":117,"open_issues":15,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/893"},"html":{"href":"https://github.com/edx/edx-app-android/pull/893"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/893"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-android/statuses/c4342b4771d6726e63f026df0e02427b131bd462"}}}}
{"actor":{"display_login":"1zaman"}}