{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/64204810","id":64204810,"diff_hunk":"@@ -166,7 +168,8 @@ define([\n \n         fastdom.read(function () {\n             $('.js-gu-media--enhance').each(function (el) {\n-                enhanceVideo(el, false, withPreroll);\n+                var enhancedPlayer = enhanceVideo(el, false, withPreroll);","path":"static/src/javascripts/bootstraps/enhanced/media/main.js","position":16,"original_position":16,"commit_id":"61222781c15cded170622bf10e701231c475a316","original_commit_id":"61222781c15cded170622bf10e701231c475a316","user":{"login":"akash1810","id":836140,"avatar_url":"https://avatars.githubusercontent.com/u/836140?v=3","gravatar_id":"","url":"https://api.github.com/users/akash1810","html_url":"https://github.com/akash1810","followers_url":"https://api.github.com/users/akash1810/followers","following_url":"https://api.github.com/users/akash1810/following{/other_user}","gists_url":"https://api.github.com/users/akash1810/gists{/gist_id}","starred_url":"https://api.github.com/users/akash1810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash1810/subscriptions","organizations_url":"https://api.github.com/users/akash1810/orgs","repos_url":"https://api.github.com/users/akash1810/repos","events_url":"https://api.github.com/users/akash1810/events{/privacy}","received_events_url":"https://api.github.com/users/akash1810/received_events","type":"User","site_admin":false},"body":"ah! 👍 ","created_at":"2016-05-23T11:08:15Z","updated_at":"2016-05-23T11:08:15Z","html_url":"https://github.com/guardian/frontend/pull/13014#discussion_r64204810","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/13014","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/64204810"},"html":{"href":"https://github.com/guardian/frontend/pull/13014#discussion_r64204810"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13014"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/13014","id":70872195,"html_url":"https://github.com/guardian/frontend/pull/13014","diff_url":"https://github.com/guardian/frontend/pull/13014.diff","patch_url":"https://github.com/guardian/frontend/pull/13014.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/13014","number":13014,"state":"open","locked":false,"title":"add test for playing videos on fronts","user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nAdding the test to play videos in article rather than on the front when an article has video main media.\r\n\r\nThere's a few changes to our main codebase, but just events being emitted to keep the code in the test.\r\n\r\nWhat we are testing is: If we send you to the article and play the video there, are you more likely to get to 25%?\r\n\r\n## What is the value of this and can you measure success?\r\nSuccess is construct.\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo\r\n\r\n## Screenshots\r\nNot-so-good:\r\n![plomp](https://cloud.githubusercontent.com/assets/31692/15432607/dfb6bb7e-1ea6-11e6-8335-6866c8d4016a.gif)\r\n\r\n## Request for comment\r\n@akash1810 @harrysalmon @dominickendrick \r\n\r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->\r\n\r\n","created_at":"2016-05-20T15:21:29Z","updated_at":"2016-05-23T11:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d0f17f5c3b9787bc269aadf43a7075f4cbeb06f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/13014/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/13014/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/13014/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/61222781c15cded170622bf10e701231c475a316","head":{"label":"guardian:play-video-on-fronts-tets","ref":"play-video-on-fronts-tets","sha":"61222781c15cded170622bf10e701231c475a316","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-23T08:38:44Z","pushed_at":"2016-05-23T11:03:15Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":478733,"stargazers_count":3204,"watchers_count":3204,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":52,"forks":335,"open_issues":52,"watchers":3204,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"766e7b5d18657d41e079eb7908d7740bd03ab721","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-23T08:38:44Z","pushed_at":"2016-05-23T11:03:15Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":478733,"stargazers_count":3204,"watchers_count":3204,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":52,"forks":335,"open_issues":52,"watchers":3204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13014"},"html":{"href":"https://github.com/guardian/frontend/pull/13014"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/13014"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/13014/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13014/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13014/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/61222781c15cded170622bf10e701231c475a316"}}}}
{"actor":{"display_login":"akash1810"}}