{"action":"opened","number":1473,"pull_request":{"url":"https://api.github.com/repos/magefree/mage/pulls/1473","id":56073337,"html_url":"https://github.com/magefree/mage/pull/1473","diff_url":"https://github.com/magefree/mage/pull/1473.diff","patch_url":"https://github.com/magefree/mage/pull/1473.patch","issue_url":"https://api.github.com/repos/magefree/mage/issues/1473","number":1473,"state":"open","locked":false,"title":"Create MagePreferences class for managing preferences. We should move…","user":{"login":"menocar","id":16038091,"avatar_url":"https://avatars.githubusercontent.com/u/16038091?v=3","gravatar_id":"","url":"https://api.github.com/users/menocar","html_url":"https://github.com/menocar","followers_url":"https://api.github.com/users/menocar/followers","following_url":"https://api.github.com/users/menocar/following{/other_user}","gists_url":"https://api.github.com/users/menocar/gists{/gist_id}","starred_url":"https://api.github.com/users/menocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menocar/subscriptions","organizations_url":"https://api.github.com/users/menocar/orgs","repos_url":"https://api.github.com/users/menocar/repos","events_url":"https://api.github.com/users/menocar/events{/privacy}","received_events_url":"https://api.github.com/users/menocar/received_events","type":"User","site_admin":false},"body":"… preference related code from MageFrame and PreferencesDialog to the class. Push all raw string preference key manipulations for serverAddress, serverPort, userName, password and email into the class.\r\n\r\n% for K in serverAddress serverPort userName password email; do echo Checking for $K; grep -r \\\"$K\\\" Mage.Client; done\r\nChecking for serverAddress\r\nMage.Client/src/main/java/mage/client/preference/MagePreferences.java:    private static final String KEY_SERVER_ADDRESS = \"serverAddress\";\r\nChecking for serverPort\r\nMage.Client/src/main/java/mage/client/preference/MagePreferences.java:    private static final String KEY_SERVER_PORT = \"serverPort\";\r\nChecking for userName\r\nMage.Client/src/main/java/mage/client/preference/MagePreferences.java:    private static final String KEY_USER_NAME = \"userName\";\r\nChecking for password\r\nMage.Client/src/main/java/mage/client/dialog/JoinTableDialog.form:        <Property name=\"text\" type=\"java.lang.String\" value=\"password\"/>\r\nMage.Client/src/main/java/mage/client/dialog/JoinTableDialog.java:        txtPassword.setText(\"password\");\r\nMage.Client/src/main/java/mage/client/preference/MagePreferences.java:    private static final String KEY_PASSWORD = \"password\";\r\nChecking for email\r\nMage.Client/src/main/java/mage/client/preference/MagePreferences.java:    private static final String KEY_EMAIL = \"email\";","created_at":"2016-01-14T18:20:57Z","updated_at":"2016-01-14T18:20:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0606658c656c609a2cedb07031b7c372bef1e8d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magefree/mage/pulls/1473/commits","review_comments_url":"https://api.github.com/repos/magefree/mage/pulls/1473/comments","review_comment_url":"https://api.github.com/repos/magefree/mage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magefree/mage/issues/1473/comments","statuses_url":"https://api.github.com/repos/magefree/mage/statuses/ea480a659377b020f308af5ecd009ddc25d66358","head":{"label":"menocar:preferences","ref":"preferences","sha":"ea480a659377b020f308af5ecd009ddc25d66358","user":{"login":"menocar","id":16038091,"avatar_url":"https://avatars.githubusercontent.com/u/16038091?v=3","gravatar_id":"","url":"https://api.github.com/users/menocar","html_url":"https://github.com/menocar","followers_url":"https://api.github.com/users/menocar/followers","following_url":"https://api.github.com/users/menocar/following{/other_user}","gists_url":"https://api.github.com/users/menocar/gists{/gist_id}","starred_url":"https://api.github.com/users/menocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menocar/subscriptions","organizations_url":"https://api.github.com/users/menocar/orgs","repos_url":"https://api.github.com/users/menocar/repos","events_url":"https://api.github.com/users/menocar/events{/privacy}","received_events_url":"https://api.github.com/users/menocar/received_events","type":"User","site_admin":false},"repo":{"id":48752605,"name":"mage","full_name":"menocar/mage","owner":{"login":"menocar","id":16038091,"avatar_url":"https://avatars.githubusercontent.com/u/16038091?v=3","gravatar_id":"","url":"https://api.github.com/users/menocar","html_url":"https://github.com/menocar","followers_url":"https://api.github.com/users/menocar/followers","following_url":"https://api.github.com/users/menocar/following{/other_user}","gists_url":"https://api.github.com/users/menocar/gists{/gist_id}","starred_url":"https://api.github.com/users/menocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menocar/subscriptions","organizations_url":"https://api.github.com/users/menocar/orgs","repos_url":"https://api.github.com/users/menocar/repos","events_url":"https://api.github.com/users/menocar/events{/privacy}","received_events_url":"https://api.github.com/users/menocar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menocar/mage","description":"Magic Another Game Engine","fork":true,"url":"https://api.github.com/repos/menocar/mage","forks_url":"https://api.github.com/repos/menocar/mage/forks","keys_url":"https://api.github.com/repos/menocar/mage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menocar/mage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menocar/mage/teams","hooks_url":"https://api.github.com/repos/menocar/mage/hooks","issue_events_url":"https://api.github.com/repos/menocar/mage/issues/events{/number}","events_url":"https://api.github.com/repos/menocar/mage/events","assignees_url":"https://api.github.com/repos/menocar/mage/assignees{/user}","branches_url":"https://api.github.com/repos/menocar/mage/branches{/branch}","tags_url":"https://api.github.com/repos/menocar/mage/tags","blobs_url":"https://api.github.com/repos/menocar/mage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menocar/mage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menocar/mage/git/refs{/sha}","trees_url":"https://api.github.com/repos/menocar/mage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menocar/mage/statuses/{sha}","languages_url":"https://api.github.com/repos/menocar/mage/languages","stargazers_url":"https://api.github.com/repos/menocar/mage/stargazers","contributors_url":"https://api.github.com/repos/menocar/mage/contributors","subscribers_url":"https://api.github.com/repos/menocar/mage/subscribers","subscription_url":"https://api.github.com/repos/menocar/mage/subscription","commits_url":"https://api.github.com/repos/menocar/mage/commits{/sha}","git_commits_url":"https://api.github.com/repos/menocar/mage/git/commits{/sha}","comments_url":"https://api.github.com/repos/menocar/mage/comments{/number}","issue_comment_url":"https://api.github.com/repos/menocar/mage/issues/comments{/number}","contents_url":"https://api.github.com/repos/menocar/mage/contents/{+path}","compare_url":"https://api.github.com/repos/menocar/mage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menocar/mage/merges","archive_url":"https://api.github.com/repos/menocar/mage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menocar/mage/downloads","issues_url":"https://api.github.com/repos/menocar/mage/issues{/number}","pulls_url":"https://api.github.com/repos/menocar/mage/pulls{/number}","milestones_url":"https://api.github.com/repos/menocar/mage/milestones{/number}","notifications_url":"https://api.github.com/repos/menocar/mage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menocar/mage/labels{/name}","releases_url":"https://api.github.com/repos/menocar/mage/releases{/id}","created_at":"2015-12-29T15:02:38Z","updated_at":"2016-01-11T12:00:13Z","pushed_at":"2016-01-14T18:15:50Z","git_url":"git://github.com/menocar/mage.git","ssh_url":"git@github.com:menocar/mage.git","clone_url":"https://github.com/menocar/mage.git","svn_url":"https://github.com/menocar/mage","homepage":"http://xmage.de","size":409782,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magefree:master","ref":"master","sha":"bdbeffab7b8a7038c63930dd06c2852b65bfe824","user":{"login":"magefree","id":1705456,"avatar_url":"https://avatars.githubusercontent.com/u/1705456?v=3","gravatar_id":"","url":"https://api.github.com/users/magefree","html_url":"https://github.com/magefree","followers_url":"https://api.github.com/users/magefree/followers","following_url":"https://api.github.com/users/magefree/following{/other_user}","gists_url":"https://api.github.com/users/magefree/gists{/gist_id}","starred_url":"https://api.github.com/users/magefree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magefree/subscriptions","organizations_url":"https://api.github.com/users/magefree/orgs","repos_url":"https://api.github.com/users/magefree/repos","events_url":"https://api.github.com/users/magefree/events{/privacy}","received_events_url":"https://api.github.com/users/magefree/received_events","type":"Organization","site_admin":false},"repo":{"id":4158448,"name":"mage","full_name":"magefree/mage","owner":{"login":"magefree","id":1705456,"avatar_url":"https://avatars.githubusercontent.com/u/1705456?v=3","gravatar_id":"","url":"https://api.github.com/users/magefree","html_url":"https://github.com/magefree","followers_url":"https://api.github.com/users/magefree/followers","following_url":"https://api.github.com/users/magefree/following{/other_user}","gists_url":"https://api.github.com/users/magefree/gists{/gist_id}","starred_url":"https://api.github.com/users/magefree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magefree/subscriptions","organizations_url":"https://api.github.com/users/magefree/orgs","repos_url":"https://api.github.com/users/magefree/repos","events_url":"https://api.github.com/users/magefree/events{/privacy}","received_events_url":"https://api.github.com/users/magefree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magefree/mage","description":"Magic Another Game Engine","fork":false,"url":"https://api.github.com/repos/magefree/mage","forks_url":"https://api.github.com/repos/magefree/mage/forks","keys_url":"https://api.github.com/repos/magefree/mage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magefree/mage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magefree/mage/teams","hooks_url":"https://api.github.com/repos/magefree/mage/hooks","issue_events_url":"https://api.github.com/repos/magefree/mage/issues/events{/number}","events_url":"https://api.github.com/repos/magefree/mage/events","assignees_url":"https://api.github.com/repos/magefree/mage/assignees{/user}","branches_url":"https://api.github.com/repos/magefree/mage/branches{/branch}","tags_url":"https://api.github.com/repos/magefree/mage/tags","blobs_url":"https://api.github.com/repos/magefree/mage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magefree/mage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magefree/mage/git/refs{/sha}","trees_url":"https://api.github.com/repos/magefree/mage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magefree/mage/statuses/{sha}","languages_url":"https://api.github.com/repos/magefree/mage/languages","stargazers_url":"https://api.github.com/repos/magefree/mage/stargazers","contributors_url":"https://api.github.com/repos/magefree/mage/contributors","subscribers_url":"https://api.github.com/repos/magefree/mage/subscribers","subscription_url":"https://api.github.com/repos/magefree/mage/subscription","commits_url":"https://api.github.com/repos/magefree/mage/commits{/sha}","git_commits_url":"https://api.github.com/repos/magefree/mage/git/commits{/sha}","comments_url":"https://api.github.com/repos/magefree/mage/comments{/number}","issue_comment_url":"https://api.github.com/repos/magefree/mage/issues/comments{/number}","contents_url":"https://api.github.com/repos/magefree/mage/contents/{+path}","compare_url":"https://api.github.com/repos/magefree/mage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magefree/mage/merges","archive_url":"https://api.github.com/repos/magefree/mage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magefree/mage/downloads","issues_url":"https://api.github.com/repos/magefree/mage/issues{/number}","pulls_url":"https://api.github.com/repos/magefree/mage/pulls{/number}","milestones_url":"https://api.github.com/repos/magefree/mage/milestones{/number}","notifications_url":"https://api.github.com/repos/magefree/mage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magefree/mage/labels{/name}","releases_url":"https://api.github.com/repos/magefree/mage/releases{/id}","created_at":"2012-04-27T13:18:34Z","updated_at":"2016-01-12T17:50:17Z","pushed_at":"2016-01-14T18:20:57Z","git_url":"git://github.com/magefree/mage.git","ssh_url":"git@github.com:magefree/mage.git","clone_url":"https://github.com/magefree/mage.git","svn_url":"https://github.com/magefree/mage","homepage":"http://xmage.de","size":410710,"stargazers_count":237,"watchers_count":237,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"open_issues_count":230,"forks":173,"open_issues":230,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magefree/mage/pulls/1473"},"html":{"href":"https://github.com/magefree/mage/pull/1473"},"issue":{"href":"https://api.github.com/repos/magefree/mage/issues/1473"},"comments":{"href":"https://api.github.com/repos/magefree/mage/issues/1473/comments"},"review_comments":{"href":"https://api.github.com/repos/magefree/mage/pulls/1473/comments"},"review_comment":{"href":"https://api.github.com/repos/magefree/mage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magefree/mage/pulls/1473/commits"},"statuses":{"href":"https://api.github.com/repos/magefree/mage/statuses/ea480a659377b020f308af5ecd009ddc25d66358"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":116,"deletions":46,"changed_files":5}}