{"action":"created","issue":{"url":"https://api.github.com/repos/uber/react-map-gl/issues/162","repository_url":"https://api.github.com/repos/uber/react-map-gl","labels_url":"https://api.github.com/repos/uber/react-map-gl/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/uber/react-map-gl/issues/162/comments","events_url":"https://api.github.com/repos/uber/react-map-gl/issues/162/events","html_url":"https://github.com/uber/react-map-gl/pull/162","id":196816081,"number":162,"title":"Split map into static-map and interactive-map. Inversion of control to enable customized control schemes.","user":{"login":"ibgreen","id":7025232,"avatar_url":"https://avatars.githubusercontent.com/u/7025232?v=3","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-21T00:26:50Z","updated_at":"2016-12-30T00:24:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/react-map-gl/pulls/162","html_url":"https://github.com/uber/react-map-gl/pull/162","diff_url":"https://github.com/uber/react-map-gl/pull/162.diff","patch_url":"https://github.com/uber/react-map-gl/pull/162.patch"},"body":"@abmai - this is a non-functional PR, for exposition/early review.\r\n\r\nNotably, it shows how `map.react.js` is being split into two components: `map-display` and `mercator-interactions` (tentative names, happy to take suggestions).\r\n\r\nThe old map-interactions has been renamed `event-manager`.\r\n\r\nIf looks ok, the trick will now be to get all the details right and the code working again."},"comment":{"url":"https://api.github.com/repos/uber/react-map-gl/issues/comments/269714486","html_url":"https://github.com/uber/react-map-gl/pull/162#issuecomment-269714486","issue_url":"https://api.github.com/repos/uber/react-map-gl/issues/162","id":269714486,"user":{"login":"abmai","id":2263443,"avatar_url":"https://avatars.githubusercontent.com/u/2263443?v=3","gravatar_id":"","url":"https://api.github.com/users/abmai","html_url":"https://github.com/abmai","followers_url":"https://api.github.com/users/abmai/followers","following_url":"https://api.github.com/users/abmai/following{/other_user}","gists_url":"https://api.github.com/users/abmai/gists{/gist_id}","starred_url":"https://api.github.com/users/abmai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abmai/subscriptions","organizations_url":"https://api.github.com/users/abmai/orgs","repos_url":"https://api.github.com/users/abmai/repos","events_url":"https://api.github.com/users/abmai/events{/privacy}","received_events_url":"https://api.github.com/users/abmai/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T00:24:43Z","updated_at":"2016-12-30T00:24:43Z","body":"Thanks, Ib! This is an awesome start!! I think having this code to chat about is going to be super helpful. I like that we're trying to provide smaller components that have explicit responsibilities.\r\n\r\nTowards that end though, I think we could better define the roles of these 3 separate components:\r\n\r\n`StaticMap`\r\n`MapControls`\r\n`EventManager`\r\n\r\nRight now it seems at least like they're still quite coupled together (both `StaticMap` and `MapControls` are dependent on `EventManager`). And a single render of `InteractiveMap` requires 4 container divs whereas before it only required 2."}}
{"actor":{"display_login":"abmai"}}