{"action":"created","comment":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/comments/75913069","id":75913069,"diff_hunk":"@@ -151,12 +151,14 @@ public string wrap_script_with_module(string script, ChocolateyConfiguration con\n \r\n         private string get_script_arguments(string script, ChocolateyConfiguration config)\r\n         {\r\n-            return \"-packageScript '{0}' -installArguments '{1}' -packageParameters '{2}'{3}{4}\".format_with(\r\n+            return \"-packageScript '{0}' -installArguments '{1}' -packageParameters '{2}'{3}{4}{5}{6}\".format_with(\r\n                 script,\r\n                 prepare_powershell_arguments(config.InstallArguments),\r\n                 prepare_powershell_arguments(config.PackageParameters),\r\n                 config.ForceX86 ? \" -forceX86\" : string.Empty,\r\n-                config.OverrideArguments ? \" -overrideArgs\" : string.Empty\r\n+                config.OverrideArguments ? \" -overrideArgs\" : string.Empty,\r\n+                config.ApplyPackageParametersToDependencies ? \" -apply-package-parameters-to-dependencies\" : string.Empty,\r\n+                config.ApplyInstallArgumentsToDependencies ? \" -apply-install-arguments-to-dependencies\" : string.Empty\r","path":"src/chocolatey/infrastructure.app/services/PowershellService.cs","position":13,"original_position":13,"commit_id":"ec7bc88934c947aae255c3a0c3a6681e6bef0cc0","original_commit_id":"ec7bc88934c947aae255c3a0c3a6681e6bef0cc0","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"I'm not sure this section is necessary.","created_at":"2016-08-23T17:28:55Z","updated_at":"2016-08-23T17:28:55Z","html_url":"https://github.com/chocolatey/choco/pull/915#discussion_r75913069","pull_request_url":"https://api.github.com/repos/chocolatey/choco/pulls/915","_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments/75913069"},"html":{"href":"https://github.com/chocolatey/choco/pull/915#discussion_r75913069"},"pull_request":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/915"}}},"pull_request":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/915","id":81793974,"html_url":"https://github.com/chocolatey/choco/pull/915","diff_url":"https://github.com/chocolatey/choco/pull/915.diff","patch_url":"https://github.com/chocolatey/choco/pull/915.patch","issue_url":"https://api.github.com/repos/chocolatey/choco/issues/915","number":915,"state":"open","locked":false,"title":"(GH-839) Switch to apply package parameters to dependent packages","user":{"login":"eirikatdips","id":8962896,"avatar_url":"https://avatars.githubusercontent.com/u/8962896?v=3","gravatar_id":"","url":"https://api.github.com/users/eirikatdips","html_url":"https://github.com/eirikatdips","followers_url":"https://api.github.com/users/eirikatdips/followers","following_url":"https://api.github.com/users/eirikatdips/following{/other_user}","gists_url":"https://api.github.com/users/eirikatdips/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikatdips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikatdips/subscriptions","organizations_url":"https://api.github.com/users/eirikatdips/orgs","repos_url":"https://api.github.com/users/eirikatdips/repos","events_url":"https://api.github.com/users/eirikatdips/events{/privacy}","received_events_url":"https://api.github.com/users/eirikatdips/received_events","type":"User","site_admin":false},"body":"<!--\r\nBEFORE YOU CREATE A PULL REQUEST:\r\n\r\nEnsure you have read over CONTRIBUTING - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md. We provide VERY defined guidance (as such, we strongly adhere to it).\r\n\r\nA summary of our expectations:\r\n - You are not submitting a pull request from your MASTER branch.\r\n - You are able to sign the Contributor License Agreement (CLA).\r\n - YOUR GIT COMMIT MESSAGE FORMAT IS EXTREMELY IMPORTANT. We have a very defined expectation for this format and are sticklers about it. Really, READ the entire Contributing document. It will save you and us pain.\r\n - Do not reformat code, it makes it hard to see what has changed. Leave the formatting to us.\r\n\r\nTHANKS! We appreciate you reading the entire Contributing document and not just scanning through it.\r\n\r\nDELETE EVERYTHING IN THIS COMMENT BLOCK\r\n-->\r\n\r\nIn version 0.9.9.8 and earlier, package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that package-parameters would only be applied to the specified package.\r\nSometimes it will be useful to pass the package parameters further to dependent packages. This can be controlled by using a cmdline switch.","created_at":"2016-08-18T10:40:25Z","updated_at":"2016-08-23T17:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e1956e60aeaf604e62f772ba3eb5c339956cbb2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolatey/choco/pulls/915/commits","review_comments_url":"https://api.github.com/repos/chocolatey/choco/pulls/915/comments","review_comment_url":"https://api.github.com/repos/chocolatey/choco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolatey/choco/issues/915/comments","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/ec7bc88934c947aae255c3a0c3a6681e6bef0cc0","head":{"label":"eirikatdips:feature/eiratdips-GH-839-apply-parameters-to-dependent-packages","ref":"feature/eiratdips-GH-839-apply-parameters-to-dependent-packages","sha":"ec7bc88934c947aae255c3a0c3a6681e6bef0cc0","user":{"login":"eirikatdips","id":8962896,"avatar_url":"https://avatars.githubusercontent.com/u/8962896?v=3","gravatar_id":"","url":"https://api.github.com/users/eirikatdips","html_url":"https://github.com/eirikatdips","followers_url":"https://api.github.com/users/eirikatdips/followers","following_url":"https://api.github.com/users/eirikatdips/following{/other_user}","gists_url":"https://api.github.com/users/eirikatdips/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikatdips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikatdips/subscriptions","organizations_url":"https://api.github.com/users/eirikatdips/orgs","repos_url":"https://api.github.com/users/eirikatdips/repos","events_url":"https://api.github.com/users/eirikatdips/events{/privacy}","received_events_url":"https://api.github.com/users/eirikatdips/received_events","type":"User","site_admin":false},"repo":{"id":65930678,"name":"choco","full_name":"eirikatdips/choco","owner":{"login":"eirikatdips","id":8962896,"avatar_url":"https://avatars.githubusercontent.com/u/8962896?v=3","gravatar_id":"","url":"https://api.github.com/users/eirikatdips","html_url":"https://github.com/eirikatdips","followers_url":"https://api.github.com/users/eirikatdips/followers","following_url":"https://api.github.com/users/eirikatdips/following{/other_user}","gists_url":"https://api.github.com/users/eirikatdips/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikatdips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikatdips/subscriptions","organizations_url":"https://api.github.com/users/eirikatdips/orgs","repos_url":"https://api.github.com/users/eirikatdips/repos","events_url":"https://api.github.com/users/eirikatdips/events{/privacy}","received_events_url":"https://api.github.com/users/eirikatdips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eirikatdips/choco","description":"Chocolatey CLI","fork":true,"url":"https://api.github.com/repos/eirikatdips/choco","forks_url":"https://api.github.com/repos/eirikatdips/choco/forks","keys_url":"https://api.github.com/repos/eirikatdips/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eirikatdips/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eirikatdips/choco/teams","hooks_url":"https://api.github.com/repos/eirikatdips/choco/hooks","issue_events_url":"https://api.github.com/repos/eirikatdips/choco/issues/events{/number}","events_url":"https://api.github.com/repos/eirikatdips/choco/events","assignees_url":"https://api.github.com/repos/eirikatdips/choco/assignees{/user}","branches_url":"https://api.github.com/repos/eirikatdips/choco/branches{/branch}","tags_url":"https://api.github.com/repos/eirikatdips/choco/tags","blobs_url":"https://api.github.com/repos/eirikatdips/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eirikatdips/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eirikatdips/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/eirikatdips/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eirikatdips/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/eirikatdips/choco/languages","stargazers_url":"https://api.github.com/repos/eirikatdips/choco/stargazers","contributors_url":"https://api.github.com/repos/eirikatdips/choco/contributors","subscribers_url":"https://api.github.com/repos/eirikatdips/choco/subscribers","subscription_url":"https://api.github.com/repos/eirikatdips/choco/subscription","commits_url":"https://api.github.com/repos/eirikatdips/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/eirikatdips/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/eirikatdips/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/eirikatdips/choco/issues/comments{/number}","contents_url":"https://api.github.com/repos/eirikatdips/choco/contents/{+path}","compare_url":"https://api.github.com/repos/eirikatdips/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eirikatdips/choco/merges","archive_url":"https://api.github.com/repos/eirikatdips/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eirikatdips/choco/downloads","issues_url":"https://api.github.com/repos/eirikatdips/choco/issues{/number}","pulls_url":"https://api.github.com/repos/eirikatdips/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/eirikatdips/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/eirikatdips/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eirikatdips/choco/labels{/name}","releases_url":"https://api.github.com/repos/eirikatdips/choco/releases{/id}","deployments_url":"https://api.github.com/repos/eirikatdips/choco/deployments","created_at":"2016-08-17T18:05:37Z","updated_at":"2016-08-17T18:05:39Z","pushed_at":"2016-08-22T11:29:05Z","git_url":"git://github.com/eirikatdips/choco.git","ssh_url":"git@github.com:eirikatdips/choco.git","clone_url":"https://github.com/eirikatdips/choco.git","svn_url":"https://github.com/eirikatdips/choco","homepage":"https://chocolatey.org","size":16197,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolatey:master","ref":"master","sha":"4171c8880ba678be364ca6cc36a64dc70633cae9","user":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"repo":{"id":28647218,"name":"choco","full_name":"chocolatey/choco","owner":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolatey/choco","description":"Chocolatey CLI","fork":false,"url":"https://api.github.com/repos/chocolatey/choco","forks_url":"https://api.github.com/repos/chocolatey/choco/forks","keys_url":"https://api.github.com/repos/chocolatey/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolatey/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolatey/choco/teams","hooks_url":"https://api.github.com/repos/chocolatey/choco/hooks","issue_events_url":"https://api.github.com/repos/chocolatey/choco/issues/events{/number}","events_url":"https://api.github.com/repos/chocolatey/choco/events","assignees_url":"https://api.github.com/repos/chocolatey/choco/assignees{/user}","branches_url":"https://api.github.com/repos/chocolatey/choco/branches{/branch}","tags_url":"https://api.github.com/repos/chocolatey/choco/tags","blobs_url":"https://api.github.com/repos/chocolatey/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolatey/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolatey/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolatey/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolatey/choco/languages","stargazers_url":"https://api.github.com/repos/chocolatey/choco/stargazers","contributors_url":"https://api.github.com/repos/chocolatey/choco/contributors","subscribers_url":"https://api.github.com/repos/chocolatey/choco/subscribers","subscription_url":"https://api.github.com/repos/chocolatey/choco/subscription","commits_url":"https://api.github.com/repos/chocolatey/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolatey/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolatey/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolatey/choco/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolatey/choco/contents/{+path}","compare_url":"https://api.github.com/repos/chocolatey/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolatey/choco/merges","archive_url":"https://api.github.com/repos/chocolatey/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolatey/choco/downloads","issues_url":"https://api.github.com/repos/chocolatey/choco/issues{/number}","pulls_url":"https://api.github.com/repos/chocolatey/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolatey/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolatey/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolatey/choco/labels{/name}","releases_url":"https://api.github.com/repos/chocolatey/choco/releases{/id}","deployments_url":"https://api.github.com/repos/chocolatey/choco/deployments","created_at":"2014-12-30T22:12:11Z","updated_at":"2016-08-23T10:58:31Z","pushed_at":"2016-08-23T16:08:43Z","git_url":"git://github.com/chocolatey/choco.git","ssh_url":"git@github.com:chocolatey/choco.git","clone_url":"https://github.com/chocolatey/choco.git","svn_url":"https://github.com/chocolatey/choco","homepage":"https://chocolatey.org","size":18536,"stargazers_count":2223,"watchers_count":2223,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":269,"mirror_url":null,"open_issues_count":300,"forks":269,"open_issues":300,"watchers":2223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/915"},"html":{"href":"https://github.com/chocolatey/choco/pull/915"},"issue":{"href":"https://api.github.com/repos/chocolatey/choco/issues/915"},"comments":{"href":"https://api.github.com/repos/chocolatey/choco/issues/915/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/915/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/915/commits"},"statuses":{"href":"https://api.github.com/repos/chocolatey/choco/statuses/ec7bc88934c947aae255c3a0c3a6681e6bef0cc0"}}}}
{"actor":{"display_login":"ferventcoder"}}