{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/3477","repository_url":"https://api.github.com/repos/acemod/ACE3","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/3477/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/3477/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/3477/events","html_url":"https://github.com/acemod/ACE3/pull/3477","id":137382784,"number":3477,"title":"Add Advanced Throwing","user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/acemod/ACE3/labels/feature%20request","name":"feature request","color":"0052cc"},{"url":"https://api.github.com/repos/acemod/ACE3/labels/WIP","name":"WIP","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/18","html_url":"https://github.com/acemod/ACE3/milestones/%203.7.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/18/labels","id":1753245,"number":18,"title":" 3.7.0","description":"","creator":{"login":"PabstMirror","id":9376747,"avatar_url":"https://avatars.githubusercontent.com/u/9376747?v=3","gravatar_id":"","url":"https://api.github.com/users/PabstMirror","html_url":"https://github.com/PabstMirror","followers_url":"https://api.github.com/users/PabstMirror/followers","following_url":"https://api.github.com/users/PabstMirror/following{/other_user}","gists_url":"https://api.github.com/users/PabstMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/PabstMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PabstMirror/subscriptions","organizations_url":"https://api.github.com/users/PabstMirror/orgs","repos_url":"https://api.github.com/users/PabstMirror/repos","events_url":"https://api.github.com/users/PabstMirror/events{/privacy}","received_events_url":"https://api.github.com/users/PabstMirror/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":17,"state":"open","created_at":"2016-05-07T19:29:09Z","updated_at":"2016-07-24T04:11:06Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2016-02-29T21:32:28Z","updated_at":"2016-07-24T10:52:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/3477","html_url":"https://github.com/acemod/ACE3/pull/3477","diff_url":"https://github.com/acemod/ACE3/pull/3477.diff","patch_url":"https://github.com/acemod/ACE3/pull/3477.patch"},"body":"**When merged this pull request will:**\r\n\r\n- Integrate (90% rewritten) grenade throwing system by @Dslyecxi\r\n- Close #1628\r\n- Add settings to draw throw arc, show mouse hints, enable pick up, enabe attached pick up\r\n- Improve and optimize rendering and handling of throwables\r\n- Add support for scripted throwables (eg. flashbang, handheld flares)\r\n- Improve 3rd person support\r\n- Use CBA DisplayLoad and keybinds\r\n- Add toggle lean support\r\n- Add pick up ability (including attached)\r\n\r\nTodo:\r\n- [x] Fix init failing on first game load (after loading from Eden)\r\n- [x] Convert KeyDown EH to XEH DisplayLoad (once fixed in CBA) and DisplayLoad XEH to `CBA_fnc_addDisplayHandler` postInit\r\n- [x] Throw `fired` event\r\n- [x] Cleanup `waitUntilAndExecute`s and `waitAndExecute`s where possible (`FUNC(throw)` needs serious work on that)\r\n- [x] Add button icons (like when carrying) showing controls - when #3551 merged\r\n- [x] Add \"double right click to drop when cooked\" to mouse hint\r\n- [x] `player` -> `ACE_player`/passed `_unit`\r\n- [x] ~~Use grenade throw key (requires intercepting that key so it doesn't do its default action)~~ - Use custom CBA key instead of \"Cycle Throw Items\" instead.\r\n- [x] Cancel throw when !canInteract (e.g. unconsciousness)\r\n- [x] Cancel throw when player switch\r\n- [x] If you pull out a throwable and throw it when your magazine is partially full, and in doing so, exhaust all of your throwables, the next time you press the 'cycle throwables' key (with no throwables available to throw) it will reset your ammo count to whatever it was during your last valid throw\r\n- [x] Adjust position when locked in lean mode and side stances\r\n- [x] Allow throwing with weapon down from FFV\r\n- [x] Add better notification when unable to throw from inside vehicle\r\n- [x] Disable leaning addition in vehicle\r\n- [x] Fix scroll wheel up not working every second restart\r\n- [x] 3rd person support\r\n- [x] Improve 3rd person support\r\n- [x] ~~`DefaultAction` doesn't get executed when in FFV with lowered weapon, so throw requires 2 LMB presses to actually throw~~ design decision to leave it like that, simpler for end-user to understand and not make mistakes because of it (can't change direction of player in FFV slot, raising weapon changes look direction to where weapon is pointing)\r\n- [x] ~~`KeyUp` isn't guaranteed to fire (for some reason) - for example holding it down for short amount of time - apparently vanilla issue~~ fixed by changing it to \"toggle drop mode\" instead of holding a button\r\n- [x] `DefaultAction` doesn't fire when `driver vehicle == unit` - fixed by changing to `mouseButtonDown` event and leaving `DefaultAction` for \"fire\" suppression only\r\n- [x] Flashbang and handheld flares support\r\n- [x] Fix \"exploded in hand\" not exiting throw mode\r\n- [x] Make `weaponselect` change throwable keys compatible with from inside vehicle throwing.\r\n- [x] Arc and mouse hint client settings\r\n- [x] Editor module\r\n- [x] Rename to \"advancedthrowing\"\r\n- [x] Fix throw orientation being different than holding orientation\r\n- [x] Moving (flying) rendering\r\n- [x] Picking up primed throwables\r\n- [x] ~~Replace animation with gesture to properly fix the moving mistakes (current fix makes grenade be thrown from behind you if you walk or run)~~ no suitable gesture, current fix will have to do\r\n- [x] Change `GVAR`s to `setVariable`s\r\n- [x] Convert to CBA events (required #3815)\r\n- [x] Module icon\r\n- [x] Fix #3939 \r\n- [x] Use #4096 for throw gesture\r\n- [x] Beautified component name\r\n- [x] Fix walking sideways jiggle when weapon on back or lowered\r\n- [x] Disable debug\r\n- [x] Limit throwing power over shoulder\r\n- [ ] Cool-down between throws (mimic vanilla behaviour, also to prevent issues #issuecomment-234720437)\r\n- [ ] Disallow selecting throwable if reloading\r\n- [ ] Improve pick-up action performance in multiplayer\r\n\r\nFuture:\r\n- [ ] Add setting to follow head direction or not (body direction)\r\n- [ ] Improve throwable rendering position (mainly moves too much while looking up/down)\r\n- [ ] Improve in-vehicle `canThrow` check to make throwing from non-FFV seats work well (required for below)\r\n- [ ] Allow throwing from inside vehicles (eg. copilot and back seats of little bird) - `lineIntersectsSurfaces`\r\n\r\nExperimentation:\r\n- [x] ~~Rolling throwables~~ Arma 3 physics allow you to throw into the floor and it will be almost the exact same effect as ACE2 grenade rolling, not much point implementing\r\n- [x] ~~Custom pin sound instead of regular throw sound~~ -> `ace_grenades` separate component if ever\r\n\r\nTo decide:\r\n- ~~Remove grenade modes from `ace_grenades`?~~ Leave for anyone who wants to use it\r\n- ~~Make Advanced Throwing mandatory or keep it optional (default enabled)? (connects with above, if we keep it it might be nice to keep old modes as well? if removed rename to `ace_throwing`?)~~ Leaving optional\r\n- ~~Add support for picking up primed throwables to vanilla throwing? (if yes, move to `ace_grenades`?)~~ No, due to no nice way of holding them, apart from delay from pick up to throw"},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/234770619","html_url":"https://github.com/acemod/ACE3/pull/3477#issuecomment-234770619","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/3477","id":234770619,"user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"created_at":"2016-07-24T10:52:38Z","updated_at":"2016-07-24T10:52:38Z","body":"Interesting, the delay may fix that, but I don't know what the cause could be."}}
{"actor":{"display_login":"jonpas"}}