{"action":"created","comment":{"url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/comments/81635382","pull_request_review_id":2601353,"id":81635382,"diff_hunk":"@@ -0,0 +1,42 @@\n+package config","path":"src/stackdriver-nozzle/config/config.go","position":1,"original_position":1,"commit_id":"b73a014c4596c149217c3e8a758b240e9802bc49","original_commit_id":"b73a014c4596c149217c3e8a758b240e9802bc49","user":{"login":"evandbrown","id":656941,"avatar_url":"https://avatars.githubusercontent.com/u/656941?v=3","gravatar_id":"","url":"https://api.github.com/users/evandbrown","html_url":"https://github.com/evandbrown","followers_url":"https://api.github.com/users/evandbrown/followers","following_url":"https://api.github.com/users/evandbrown/following{/other_user}","gists_url":"https://api.github.com/users/evandbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/evandbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandbrown/subscriptions","organizations_url":"https://api.github.com/users/evandbrown/orgs","repos_url":"https://api.github.com/users/evandbrown/repos","events_url":"https://api.github.com/users/evandbrown/events{/privacy}","received_events_url":"https://api.github.com/users/evandbrown/received_events","type":"User","site_admin":false},"body":"I'd generally prefer flag parsing to happen inside main(). That makes sure anything that needs a flag/config value has to declare it in its method signature, and can't go grabbing initialized package-public vars.","created_at":"2016-10-03T20:41:43Z","updated_at":"2016-10-03T20:41:43Z","html_url":"https://github.com/evandbrown/gcp-tools-release/pull/12#discussion_r81635382","pull_request_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/comments/81635382"},"html":{"href":"https://github.com/evandbrown/gcp-tools-release/pull/12#discussion_r81635382"},"pull_request":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12","id":87762736,"html_url":"https://github.com/evandbrown/gcp-tools-release/pull/12","diff_url":"https://github.com/evandbrown/gcp-tools-release/pull/12.diff","patch_url":"https://github.com/evandbrown/gcp-tools-release/pull/12.patch","issue_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/12","number":12,"state":"open","locked":false,"title":"Adding labels from envelope fields","user":{"login":"nrxus","id":2774084,"avatar_url":"https://avatars.githubusercontent.com/u/2774084?v=3","gravatar_id":"","url":"https://api.github.com/users/nrxus","html_url":"https://github.com/nrxus","followers_url":"https://api.github.com/users/nrxus/followers","following_url":"https://api.github.com/users/nrxus/following{/other_user}","gists_url":"https://api.github.com/users/nrxus/gists{/gist_id}","starred_url":"https://api.github.com/users/nrxus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrxus/subscriptions","organizations_url":"https://api.github.com/users/nrxus/orgs","repos_url":"https://api.github.com/users/nrxus/repos","events_url":"https://api.github.com/users/nrxus/events{/privacy}","received_events_url":"https://api.github.com/users/nrxus/received_events","type":"User","site_admin":false},"body":"We also moved the dev functions into runnable go scripts (print firehose to stdout, clear SD metrics, send mock metric to SD every x seconds)","created_at":"2016-10-03T18:05:32Z","updated_at":"2016-10-03T20:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d15cbeed339d016f6c2df87a8f4a260324147dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12/commits","review_comments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12/comments","review_comment_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/12/comments","statuses_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/statuses/b73a014c4596c149217c3e8a758b240e9802bc49","head":{"label":"evandbrown:pr-labels","ref":"pr-labels","sha":"b73a014c4596c149217c3e8a758b240e9802bc49","user":{"login":"evandbrown","id":656941,"avatar_url":"https://avatars.githubusercontent.com/u/656941?v=3","gravatar_id":"","url":"https://api.github.com/users/evandbrown","html_url":"https://github.com/evandbrown","followers_url":"https://api.github.com/users/evandbrown/followers","following_url":"https://api.github.com/users/evandbrown/following{/other_user}","gists_url":"https://api.github.com/users/evandbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/evandbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandbrown/subscriptions","organizations_url":"https://api.github.com/users/evandbrown/orgs","repos_url":"https://api.github.com/users/evandbrown/repos","events_url":"https://api.github.com/users/evandbrown/events{/privacy}","received_events_url":"https://api.github.com/users/evandbrown/received_events","type":"User","site_admin":false},"repo":{"id":55039483,"name":"gcp-tools-release","full_name":"evandbrown/gcp-tools-release","owner":{"login":"evandbrown","id":656941,"avatar_url":"https://avatars.githubusercontent.com/u/656941?v=3","gravatar_id":"","url":"https://api.github.com/users/evandbrown","html_url":"https://github.com/evandbrown","followers_url":"https://api.github.com/users/evandbrown/followers","following_url":"https://api.github.com/users/evandbrown/following{/other_user}","gists_url":"https://api.github.com/users/evandbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/evandbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandbrown/subscriptions","organizations_url":"https://api.github.com/users/evandbrown/orgs","repos_url":"https://api.github.com/users/evandbrown/repos","events_url":"https://api.github.com/users/evandbrown/events{/privacy}","received_events_url":"https://api.github.com/users/evandbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evandbrown/gcp-tools-release","description":"Google Cloud Platform Tools BOSH Release","fork":false,"url":"https://api.github.com/repos/evandbrown/gcp-tools-release","forks_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/forks","keys_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/teams","hooks_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/hooks","issue_events_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/events{/number}","events_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/events","assignees_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/assignees{/user}","branches_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/branches{/branch}","tags_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/tags","blobs_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/statuses/{sha}","languages_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/languages","stargazers_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/stargazers","contributors_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/contributors","subscribers_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/subscribers","subscription_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/subscription","commits_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/contents/{+path}","compare_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/merges","archive_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/downloads","issues_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues{/number}","pulls_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls{/number}","milestones_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/milestones{/number}","notifications_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/labels{/name}","releases_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/releases{/id}","deployments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/deployments","created_at":"2016-03-30T06:48:22Z","updated_at":"2016-09-30T20:50:14Z","pushed_at":"2016-10-03T20:33:37Z","git_url":"git://github.com/evandbrown/gcp-tools-release.git","ssh_url":"git@github.com:evandbrown/gcp-tools-release.git","clone_url":"https://github.com/evandbrown/gcp-tools-release.git","svn_url":"https://github.com/evandbrown/gcp-tools-release","homepage":null,"size":8919,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"evandbrown:master","ref":"master","sha":"a049943e42763692e61f7b891237354063aaaad4","user":{"login":"evandbrown","id":656941,"avatar_url":"https://avatars.githubusercontent.com/u/656941?v=3","gravatar_id":"","url":"https://api.github.com/users/evandbrown","html_url":"https://github.com/evandbrown","followers_url":"https://api.github.com/users/evandbrown/followers","following_url":"https://api.github.com/users/evandbrown/following{/other_user}","gists_url":"https://api.github.com/users/evandbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/evandbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandbrown/subscriptions","organizations_url":"https://api.github.com/users/evandbrown/orgs","repos_url":"https://api.github.com/users/evandbrown/repos","events_url":"https://api.github.com/users/evandbrown/events{/privacy}","received_events_url":"https://api.github.com/users/evandbrown/received_events","type":"User","site_admin":false},"repo":{"id":55039483,"name":"gcp-tools-release","full_name":"evandbrown/gcp-tools-release","owner":{"login":"evandbrown","id":656941,"avatar_url":"https://avatars.githubusercontent.com/u/656941?v=3","gravatar_id":"","url":"https://api.github.com/users/evandbrown","html_url":"https://github.com/evandbrown","followers_url":"https://api.github.com/users/evandbrown/followers","following_url":"https://api.github.com/users/evandbrown/following{/other_user}","gists_url":"https://api.github.com/users/evandbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/evandbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandbrown/subscriptions","organizations_url":"https://api.github.com/users/evandbrown/orgs","repos_url":"https://api.github.com/users/evandbrown/repos","events_url":"https://api.github.com/users/evandbrown/events{/privacy}","received_events_url":"https://api.github.com/users/evandbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evandbrown/gcp-tools-release","description":"Google Cloud Platform Tools BOSH Release","fork":false,"url":"https://api.github.com/repos/evandbrown/gcp-tools-release","forks_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/forks","keys_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/teams","hooks_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/hooks","issue_events_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/events{/number}","events_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/events","assignees_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/assignees{/user}","branches_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/branches{/branch}","tags_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/tags","blobs_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/statuses/{sha}","languages_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/languages","stargazers_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/stargazers","contributors_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/contributors","subscribers_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/subscribers","subscription_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/subscription","commits_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/contents/{+path}","compare_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/merges","archive_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/downloads","issues_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues{/number}","pulls_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls{/number}","milestones_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/milestones{/number}","notifications_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/labels{/name}","releases_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/releases{/id}","deployments_url":"https://api.github.com/repos/evandbrown/gcp-tools-release/deployments","created_at":"2016-03-30T06:48:22Z","updated_at":"2016-09-30T20:50:14Z","pushed_at":"2016-10-03T20:33:37Z","git_url":"git://github.com/evandbrown/gcp-tools-release.git","ssh_url":"git@github.com:evandbrown/gcp-tools-release.git","clone_url":"https://github.com/evandbrown/gcp-tools-release.git","svn_url":"https://github.com/evandbrown/gcp-tools-release","homepage":null,"size":8919,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12"},"html":{"href":"https://github.com/evandbrown/gcp-tools-release/pull/12"},"issue":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/12"},"comments":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/evandbrown/gcp-tools-release/statuses/b73a014c4596c149217c3e8a758b240e9802bc49"}}}}
{"actor":{"display_login":"evandbrown"}}