{"action":"created","issue":{"url":"https://api.github.com/repos/itchingpixels/talks/issues/4","repository_url":"https://api.github.com/repos/itchingpixels/talks","labels_url":"https://api.github.com/repos/itchingpixels/talks/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/itchingpixels/talks/issues/4/comments","events_url":"https://api.github.com/repos/itchingpixels/talks/issues/4/events","html_url":"https://github.com/itchingpixels/talks/pull/4","id":133280294,"number":4,"title":"Unit tests","user":{"login":"fabb","id":153960,"avatar_url":"https://avatars.githubusercontent.com/u/153960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabb","html_url":"https://github.com/fabb","followers_url":"https://api.github.com/users/fabb/followers","following_url":"https://api.github.com/users/fabb/following{/other_user}","gists_url":"https://api.github.com/users/fabb/gists{/gist_id}","starred_url":"https://api.github.com/users/fabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabb/subscriptions","organizations_url":"https://api.github.com/users/fabb/orgs","repos_url":"https://api.github.com/users/fabb/repos","events_url":"https://api.github.com/users/fabb/events{/privacy}","received_events_url":"https://api.github.com/users/fabb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-12T16:15:21Z","updated_at":"2016-02-15T09:11:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/itchingpixels/talks/pulls/4","html_url":"https://github.com/itchingpixels/talks/pull/4","diff_url":"https://github.com/itchingpixels/talks/pull/4.diff","patch_url":"https://github.com/itchingpixels/talks/pull/4.patch"},"body":":warning: This is not meant for merging, just to serve as a discussion thread on GitHub.\r\n\r\nThis is still work in progress, the tests for the reactive part are still to do, I'm on it.\r\n\r\nMy motivation was that the reactive version contained some bugs (#3), and as a learning project I wanted to write some tests to compare the imperative and reactive versions. This needed a **lot** of refactoring in order to abstract the gesture recognizer and timer interaction away.\r\nUnfortunately now the implementation has become quite big. I guess that is the price to pay for having proof that the implementation works as expected?\r\n\r\nI'd love to hear suggestions and feedback/contributions. I didn't merge in the latest changes from #2 for now, as it would complicate things more. Currently I'm starting to write the tests for the reactive part."},"comment":{"url":"https://api.github.com/repos/itchingpixels/talks/issues/comments/184123828","html_url":"https://github.com/itchingpixels/talks/pull/4#issuecomment-184123828","issue_url":"https://api.github.com/repos/itchingpixels/talks/issues/4","id":184123828,"user":{"login":"fabb","id":153960,"avatar_url":"https://avatars.githubusercontent.com/u/153960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabb","html_url":"https://github.com/fabb","followers_url":"https://api.github.com/users/fabb/followers","following_url":"https://api.github.com/users/fabb/following{/other_user}","gists_url":"https://api.github.com/users/fabb/gists{/gist_id}","starred_url":"https://api.github.com/users/fabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabb/subscriptions","organizations_url":"https://api.github.com/users/fabb/orgs","repos_url":"https://api.github.com/users/fabb/repos","events_url":"https://api.github.com/users/fabb/events{/privacy}","received_events_url":"https://api.github.com/users/fabb/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T09:11:06Z","updated_at":"2016-02-15T09:11:06Z","body":"ok, i merged the changes from master in, but i still have to use the ReactiveGestureReactor for the ReactiveViewController"}}