{"action":"created","issue":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/334","repository_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish","labels_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/334/comments","events_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/334/events","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/334","id":158278846,"number":334,"title":"Fix theme key bindings","user":{"login":"derekstavis","id":1611639,"avatar_url":"https://avatars.githubusercontent.com/u/1611639?v=3","gravatar_id":"","url":"https://api.github.com/users/derekstavis","html_url":"https://github.com/derekstavis","followers_url":"https://api.github.com/users/derekstavis/followers","following_url":"https://api.github.com/users/derekstavis/following{/other_user}","gists_url":"https://api.github.com/users/derekstavis/gists{/gist_id}","starred_url":"https://api.github.com/users/derekstavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekstavis/subscriptions","organizations_url":"https://api.github.com/users/derekstavis/orgs","repos_url":"https://api.github.com/users/derekstavis/repos","events_url":"https://api.github.com/users/derekstavis/events{/privacy}","received_events_url":"https://api.github.com/users/derekstavis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/labels/area:themes","name":"area:themes","color":"009688"},{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/labels/priority:high","name":"priority:high","color":"F44336"},{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/labels/type:bug","name":"type:bug","color":"F44336"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-03T02:27:17Z","updated_at":"2016-06-03T21:13:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/pulls/334","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/334","diff_url":"https://github.com/oh-my-fish/oh-my-fish/pull/334.diff","patch_url":"https://github.com/oh-my-fish/oh-my-fish/pull/334.patch"},"body":"This PR fixes the way themes key bindings are treated.\r\n\r\nPrevious to this PR all installed themes key bindings would be loaded. This PR makes startup code load only current theme key bindings, when existent. \r\n\r\nAlso, previously, key bindings wouldn't be reloaded on theme change. This reloads key bindings file when it's found on the theme.\r\n\r\n----\r\n\r\n@tannhuber, I see your themes use key bindings. Would you like to help us test this PR?\r\n\r\nTo enable automatic key binding load on themes, move all `bind` calls to `key_bindings.fish` file in theme's repository root directory.\r\n\r\nThis PR should make `omf t dangerous; omf t budspencer` use `budspencer` key bindings."},"comment":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/comments/223695911","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/334#issuecomment-223695911","issue_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/334","id":223695911,"user":{"login":"derekstavis","id":1611639,"avatar_url":"https://avatars.githubusercontent.com/u/1611639?v=3","gravatar_id":"","url":"https://api.github.com/users/derekstavis","html_url":"https://github.com/derekstavis","followers_url":"https://api.github.com/users/derekstavis/followers","following_url":"https://api.github.com/users/derekstavis/following{/other_user}","gists_url":"https://api.github.com/users/derekstavis/gists{/gist_id}","starred_url":"https://api.github.com/users/derekstavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekstavis/subscriptions","organizations_url":"https://api.github.com/users/derekstavis/orgs","repos_url":"https://api.github.com/users/derekstavis/repos","events_url":"https://api.github.com/users/derekstavis/events{/privacy}","received_events_url":"https://api.github.com/users/derekstavis/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T21:13:03Z","updated_at":"2016-06-03T21:13:03Z","body":"Thanks for the testing @tannhuber "}}
{"actor":{"display_login":"derekstavis"}}