{"action":"created","issue":{"url":"https://api.github.com/repos/stoicflame/enunciate/issues/501","repository_url":"https://api.github.com/repos/stoicflame/enunciate","labels_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501/labels{/name}","comments_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501/comments","events_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501/events","html_url":"https://github.com/stoicflame/enunciate/pull/501","id":177506393,"number":501,"title":"Initial support for Lombok annotations","user":{"login":"SpOOnman","id":449529,"avatar_url":"https://avatars.githubusercontent.com/u/449529?v=3","gravatar_id":"","url":"https://api.github.com/users/SpOOnman","html_url":"https://github.com/SpOOnman","followers_url":"https://api.github.com/users/SpOOnman/followers","following_url":"https://api.github.com/users/SpOOnman/following{/other_user}","gists_url":"https://api.github.com/users/SpOOnman/gists{/gist_id}","starred_url":"https://api.github.com/users/SpOOnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpOOnman/subscriptions","organizations_url":"https://api.github.com/users/SpOOnman/orgs","repos_url":"https://api.github.com/users/SpOOnman/repos","events_url":"https://api.github.com/users/SpOOnman/events{/privacy}","received_events_url":"https://api.github.com/users/SpOOnman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stoicflame/enunciate/labels/enhancement","name":"enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stoicflame/enunciate/milestones/14","html_url":"https://github.com/stoicflame/enunciate/milestones/2.7.0","labels_url":"https://api.github.com/repos/stoicflame/enunciate/milestones/14/labels","id":1961095,"number":14,"title":"2.7.0","description":"","creator":{"login":"stoicflame","id":145838,"avatar_url":"https://avatars.githubusercontent.com/u/145838?v=3","gravatar_id":"","url":"https://api.github.com/users/stoicflame","html_url":"https://github.com/stoicflame","followers_url":"https://api.github.com/users/stoicflame/followers","following_url":"https://api.github.com/users/stoicflame/following{/other_user}","gists_url":"https://api.github.com/users/stoicflame/gists{/gist_id}","starred_url":"https://api.github.com/users/stoicflame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoicflame/subscriptions","organizations_url":"https://api.github.com/users/stoicflame/orgs","repos_url":"https://api.github.com/users/stoicflame/repos","events_url":"https://api.github.com/users/stoicflame/events{/privacy}","received_events_url":"https://api.github.com/users/stoicflame/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":5,"state":"open","created_at":"2016-08-24T17:26:33Z","updated_at":"2016-09-20T01:34:04Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-09-16T19:50:19Z","updated_at":"2016-09-20T21:23:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stoicflame/enunciate/pulls/501","html_url":"https://github.com/stoicflame/enunciate/pull/501","diff_url":"https://github.com/stoicflame/enunciate/pull/501.diff","patch_url":"https://github.com/stoicflame/enunciate/pull/501.patch"},"body":"I've followed Lombok implementation for IntelliJ IDEA plugin. This plugin generates missing getters and setters on thy fly based on source code analysis and Lombok annotations. These mehods are not visible in the source code, but they are available for code completion, navigation, searching etc. IDEA sees these methods as present, beacuse they're present in PsiClass - their AST representation of a source code you work on.\r\n\r\nFor enunciate I propose to do the same. At the moment of getting original methods from Java source code I check if Lombok annotations are present and generate missing ones. I create fake DecoratedExecutableElements that behave like a real getters and setters.\r\n\r\nI have a doubt about tests. Do you expect any? I've tested manually and it was fine.\r\n\r\nI couldn't build mvn clean install, because JBoss example was failing, I only succeeded with skipping tests."},"comment":{"url":"https://api.github.com/repos/stoicflame/enunciate/issues/comments/248438775","html_url":"https://github.com/stoicflame/enunciate/pull/501#issuecomment-248438775","issue_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501","id":248438775,"user":{"login":"SpOOnman","id":449529,"avatar_url":"https://avatars.githubusercontent.com/u/449529?v=3","gravatar_id":"","url":"https://api.github.com/users/SpOOnman","html_url":"https://github.com/SpOOnman","followers_url":"https://api.github.com/users/SpOOnman/followers","following_url":"https://api.github.com/users/SpOOnman/following{/other_user}","gists_url":"https://api.github.com/users/SpOOnman/gists{/gist_id}","starred_url":"https://api.github.com/users/SpOOnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpOOnman/subscriptions","organizations_url":"https://api.github.com/users/SpOOnman/orgs","repos_url":"https://api.github.com/users/SpOOnman/repos","events_url":"https://api.github.com/users/SpOOnman/events{/privacy}","received_events_url":"https://api.github.com/users/SpOOnman/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T21:23:16Z","updated_at":"2016-09-20T21:23:16Z","body":"Thank you, I'll look around and try to move new code to this module.\r\n\r\nad. 1. that seems fine, I will use it for testing\r\nad. 2. are other modules included by default? for example Jersey? I think it should be consistent - either include all or separate each one\r\nad. 3. ok."}}
{"actor":{"display_login":"SpOOnman"}}