{"action":"created","issue":{"url":"https://api.github.com/repos/cerati/mictest/issues/59","repository_url":"https://api.github.com/repos/cerati/mictest","labels_url":"https://api.github.com/repos/cerati/mictest/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/cerati/mictest/issues/59/comments","events_url":"https://api.github.com/repos/cerati/mictest/issues/59/events","html_url":"https://github.com/cerati/mictest/pull/59","id":168219547,"number":59,"title":"Seeding with TBB + Fixes to Validation","user":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-28T23:25:36Z","updated_at":"2016-08-05T12:54:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cerati/mictest/pulls/59","html_url":"https://github.com/cerati/mictest/pull/59","diff_url":"https://github.com/cerati/mictest/pull/59.diff","patch_url":"https://github.com/cerati/mictest/pull/59.patch"},"body":"I will run the benchmarking tomorrow, although it should be delta = zero.  \r\n\r\nThis PR includes a first attempt at seeding with TBB.  The parallelization performance improves by a factor of 2 from 1 thread to 3 threads for 20k tracks, but then regresses beyond that.  The pragma simd also does not vectorize... I need to play with this more.\r\n\r\nHowever, the main reason for this PR is a fix to the validation.  The TrackExtra's were not aligned properly, and on the off chance that a seed is not input into any of the building routines because the posEta is a NaN or Inf, this screws up the validation.  So I added some extra protection to the validation with a realigning of the track extras (which was already done previously in the SMatrix version after a sort on the tracks in phi).\r\n\r\nI will update with the benchmarking tomorrow."},"comment":{"url":"https://api.github.com/repos/cerati/mictest/issues/comments/237842675","html_url":"https://github.com/cerati/mictest/pull/59#issuecomment-237842675","issue_url":"https://api.github.com/repos/cerati/mictest/issues/59","id":237842675,"user":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T12:54:06Z","updated_at":"2016-08-05T12:54:06Z","body":"Ugh.  So I have (most of) the benchmarks here: https://kmcdermo.web.cern.ch/kmcdermo/pr59/\r\n\r\nConspicuously, the endcap building plots are totally empty.  This is not entirely surprising (and something I am working on now quickly), as the validation was prepared for barrel only and not endcap (even just the text dump validation).  \r\n\r\nThe rest of the plots are within the noise of the tests (cmssw/toymc, mic/host, fit (barrel and endcap), vu/th, speedup/time)."}}
{"actor":{"display_login":"kmcdermo"}}