{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/comments/78321935","id":78321935,"diff_hunk":"@@ -35,19 +40,59 @@ typedef struct sys_timer_struct_s {\n     ns_list_link_t link;\n } sys_timer_struct_s;\n \n+#define TIMER_SLOTS_PER_MS\t\t\t20\n #define TIMER_SYS_TICK_PERIOD       10 // milliseconds\n-#define TIMER_SYS_TICK_SLOTS        (TIMER_SYS_TICK_PERIOD * 20) // 50us slots\n+#define TIMER_SYS_TICK_SLOTS        (TIMER_SYS_TICK_PERIOD * TIMER_SLOTS_PER_SECOND) // 50us slots\n \n static uint32_t run_time_tick_ticks = 0;\n static NS_LIST_DEFINE(system_timer_free, sys_timer_struct_s, link);\n static NS_LIST_DEFINE(system_timer_list, sys_timer_struct_s, link);\n-static int8_t sys_timer_id = -1;\n \n \n static sys_timer_struct_s *sys_timer_dynamically_allocate(void);\n-static void timer_sys_interrupt(int8_t timer_id, uint16_t slots);\n+static void timer_sys_interrupt(void);\n+\n+#ifndef EVENTLOOP_USE_TICK_TIMER","path":"bare-metal/system_timer.c","position":38,"original_position":38,"commit_id":"1aa50184cee5de03aa8ce51f4127ece75caba9b6","original_commit_id":"1aa50184cee5de03aa8ce51f4127ece75caba9b6","user":{"login":"kuggenhoffen","id":7490041,"avatar_url":"https://avatars.githubusercontent.com/u/7490041?v=3","gravatar_id":"","url":"https://api.github.com/users/kuggenhoffen","html_url":"https://github.com/kuggenhoffen","followers_url":"https://api.github.com/users/kuggenhoffen/followers","following_url":"https://api.github.com/users/kuggenhoffen/following{/other_user}","gists_url":"https://api.github.com/users/kuggenhoffen/gists{/gist_id}","starred_url":"https://api.github.com/users/kuggenhoffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuggenhoffen/subscriptions","organizations_url":"https://api.github.com/users/kuggenhoffen/orgs","repos_url":"https://api.github.com/users/kuggenhoffen/repos","events_url":"https://api.github.com/users/kuggenhoffen/events{/privacy}","received_events_url":"https://api.github.com/users/kuggenhoffen/received_events","type":"User","site_admin":false},"body":"true","created_at":"2016-09-12T06:54:21Z","updated_at":"2016-09-12T06:54:21Z","html_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22#discussion_r78321935","pull_request_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/comments/78321935"},"html":{"href":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22#discussion_r78321935"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22","id":84466166,"html_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22","diff_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22.diff","patch_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22.patch","issue_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/22","number":22,"state":"open","locked":false,"title":"Systimer using platform tick timer","user":{"login":"kuggenhoffen","id":7490041,"avatar_url":"https://avatars.githubusercontent.com/u/7490041?v=3","gravatar_id":"","url":"https://api.github.com/users/kuggenhoffen","html_url":"https://github.com/kuggenhoffen","followers_url":"https://api.github.com/users/kuggenhoffen/followers","following_url":"https://api.github.com/users/kuggenhoffen/following{/other_user}","gists_url":"https://api.github.com/users/kuggenhoffen/gists{/gist_id}","starred_url":"https://api.github.com/users/kuggenhoffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuggenhoffen/subscriptions","organizations_url":"https://api.github.com/users/kuggenhoffen/orgs","repos_url":"https://api.github.com/users/kuggenhoffen/repos","events_url":"https://api.github.com/users/kuggenhoffen/events{/privacy}","received_events_url":"https://api.github.com/users/kuggenhoffen/received_events","type":"User","site_admin":false},"body":"@kjbracey-arm ","created_at":"2016-09-08T12:15:49Z","updated_at":"2016-09-12T06:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9534fc4afd5830f19f2726ea75bacb2a0f684ed7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/22/comments","statuses_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/statuses/1aa50184cee5de03aa8ce51f4127ece75caba9b6","head":{"label":"ARMmbed:systimer-using-platform-tick-timer","ref":"systimer-using-platform-tick-timer","sha":"1aa50184cee5de03aa8ce51f4127ece75caba9b6","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":32084582,"name":"sal-stack-nanostack-eventloop","full_name":"ARMmbed/sal-stack-nanostack-eventloop","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop","description":"Event-loop for 6LoWPAN stack","fork":false,"url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop","forks_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/forks","keys_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/teams","hooks_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/events","assignees_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/tags","blobs_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/subscription","commits_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/merges","archive_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/downloads","issues_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/deployments","created_at":"2015-03-12T15:28:38Z","updated_at":"2016-09-08T21:56:20Z","pushed_at":"2016-09-09T13:47:27Z","git_url":"git://github.com/ARMmbed/sal-stack-nanostack-eventloop.git","ssh_url":"git@github.com:ARMmbed/sal-stack-nanostack-eventloop.git","clone_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop.git","svn_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop","homepage":null,"size":174,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"c163be9183b09d7513532c50f2bc9ac52d3e580c","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":32084582,"name":"sal-stack-nanostack-eventloop","full_name":"ARMmbed/sal-stack-nanostack-eventloop","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop","description":"Event-loop for 6LoWPAN stack","fork":false,"url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop","forks_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/forks","keys_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/teams","hooks_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/events","assignees_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/tags","blobs_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/subscription","commits_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/merges","archive_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/downloads","issues_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/deployments","created_at":"2015-03-12T15:28:38Z","updated_at":"2016-09-08T21:56:20Z","pushed_at":"2016-09-09T13:47:27Z","git_url":"git://github.com/ARMmbed/sal-stack-nanostack-eventloop.git","ssh_url":"git@github.com:ARMmbed/sal-stack-nanostack-eventloop.git","clone_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop.git","svn_url":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop","homepage":null,"size":174,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22"},"html":{"href":"https://github.com/ARMmbed/sal-stack-nanostack-eventloop/pull/22"},"issue":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/22"},"comments":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/sal-stack-nanostack-eventloop/statuses/1aa50184cee5de03aa8ce51f4127ece75caba9b6"}}}}
{"actor":{"display_login":"kuggenhoffen"}}