{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/http-api-spec/issues/29","repository_url":"https://api.github.com/repos/ipfs/http-api-spec","labels_url":"https://api.github.com/repos/ipfs/http-api-spec/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/http-api-spec/issues/29/comments","events_url":"https://api.github.com/repos/ipfs/http-api-spec/issues/29/events","html_url":"https://github.com/ipfs/http-api-spec/pull/29","id":130829768,"number":29,"title":"Added Group `config`","user":{"login":"RichardLitt","id":910753,"avatar_url":"https://avatars.githubusercontent.com/u/910753?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardLitt","html_url":"https://github.com/RichardLitt","followers_url":"https://api.github.com/users/RichardLitt/followers","following_url":"https://api.github.com/users/RichardLitt/following{/other_user}","gists_url":"https://api.github.com/users/RichardLitt/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardLitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardLitt/subscriptions","organizations_url":"https://api.github.com/users/RichardLitt/orgs","repos_url":"https://api.github.com/users/RichardLitt/repos","events_url":"https://api.github.com/users/RichardLitt/events{/privacy}","received_events_url":"https://api.github.com/users/RichardLitt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/http-api-spec/labels/needs%20review","name":"needs review","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-02T21:52:17Z","updated_at":"2016-02-19T19:55:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/http-api-spec/pulls/29","html_url":"https://github.com/ipfs/http-api-spec/pull/29","diff_url":"https://github.com/ipfs/http-api-spec/pull/29.diff","patch_url":"https://github.com/ipfs/http-api-spec/pull/29.patch"},"body":"Some issues:\r\n\r\n- ~~I was unable to get the second argument working, so it is currently not documented how to patch a config entry. I also was unable to meaningfully get `bool` and `json` flags working.~~ Wireshark says that `encoding=json` is added to each command normally run by the CLI, as well as `stream-channels=true`, but neither of these are mentioned in the CLI mans, which is odd. I'm not sure what they are doing. \r\n- 'ipfs config edit' opens up a second terminal window - over the running daemon -  when requested using curl on the commandline, so I'm not actually sure what that should be doing in the API. I had it originally set as content-type buffer in the request, too, but I'm not sure where I got that; probably Postman. It wasn't shown in Wireshark. \r\n- Some of the commands returned no body in the CLI when curled, but returned malformed JSON in Wireshark. Not sure what to make of that. "},"comment":{"url":"https://api.github.com/repos/ipfs/http-api-spec/issues/comments/186378491","html_url":"https://github.com/ipfs/http-api-spec/pull/29#issuecomment-186378491","issue_url":"https://api.github.com/repos/ipfs/http-api-spec/issues/29","id":186378491,"user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T19:55:36Z","updated_at":"2016-02-19T19:55:36Z","body":"> Wireshark says that encoding=json is added to each command normally run by the CLI, as well as stream-channels=true, but neither of these are mentioned in the CLI mans, which is odd. I'm not sure what they are doing.\r\n\r\nI think these are just default. //cc @whyrusleeping \r\n\r\n@RichardLitt Other than the last comment above, it seems this PR was reviewed twice, could you post a item list with things you would still like feedback?"}}