{"action":"created","issue":{"url":"https://api.github.com/repos/systemjs/builder/issues/264","repository_url":"https://api.github.com/repos/systemjs/builder","labels_url":"https://api.github.com/repos/systemjs/builder/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/systemjs/builder/issues/264/comments","events_url":"https://api.github.com/repos/systemjs/builder/issues/264/events","html_url":"https://github.com/systemjs/builder/issues/264","id":98958463,"number":264,"title":"Full System.register AMD wrapping","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars.githubusercontent.com/u/598730?v=3","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemjs/builder/labels/feature","name":"feature","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2015-08-04T12:41:10Z","updated_at":"2016-10-16T15:07:56Z","closed_at":null,"body":"It would be possible to make AMD a full wrapped format when bundled like the others as `System.register` by applying transforms similar to the global transforms we have for handling globally-scoped assignments.\r\n\r\nA fully-wrapped `System.register` output would simplify the meaning of an AMD bundle and unify the ability to subtract bundles, which currently needs some exceptions to work."},"comment":{"url":"https://api.github.com/repos/systemjs/builder/issues/comments/254052348","html_url":"https://github.com/systemjs/builder/issues/264#issuecomment-254052348","issue_url":"https://api.github.com/repos/systemjs/builder/issues/264","id":254052348,"user":{"login":"jrauschenbusch","id":2499843,"avatar_url":"https://avatars.githubusercontent.com/u/2499843?v=3","gravatar_id":"","url":"https://api.github.com/users/jrauschenbusch","html_url":"https://github.com/jrauschenbusch","followers_url":"https://api.github.com/users/jrauschenbusch/followers","following_url":"https://api.github.com/users/jrauschenbusch/following{/other_user}","gists_url":"https://api.github.com/users/jrauschenbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jrauschenbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrauschenbusch/subscriptions","organizations_url":"https://api.github.com/users/jrauschenbusch/orgs","repos_url":"https://api.github.com/users/jrauschenbusch/repos","events_url":"https://api.github.com/users/jrauschenbusch/events{/privacy}","received_events_url":"https://api.github.com/users/jrauschenbusch/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T15:07:56Z","updated_at":"2016-10-16T15:07:56Z","body":"I've tracked down the problematic part in the sfx.js output. But I've currently noe clue which modification of the merge is responsible for the changed output.\r\n\r\n```diff\r\ndiff --git \"a/.\\\\sfx-working.js\" \"b/.\\\\sfx-not-working.js\"\r\nindex 4d03f68..8d1d819 100644\r\n--- \"a/.\\\\sfx-working.js\"\r\n+++ \"b/.\\\\sfx-not-working.js\"\r\n@@ -114,7 +114,7 @@\r\n                     if (b.deps[c] == a) return i(b.normalizedDeps[c]);\r\n                 throw new TypeError(\"Module \" + a + \" not declared as a dependency.\")\r\n             }, c, d);\r\n-            l && (d.exports = l), c = d.exports, c && c.__esModule ? b.esModule = c : b.esModule = k(c)\r\n+            void 0 !== typeof l && (d.exports = l), c = d.exports, c && c.__esModule ? b.esModule = c : b.esModule = k(c)\r\n         }\r\n     }\r\n ```\r\n"}}
{"actor":{"display_login":"jrauschenbusch"}}