{"action":"created","issue":{"url":"https://api.github.com/repos/juju/juju/issues/5346","repository_url":"https://api.github.com/repos/juju/juju","labels_url":"https://api.github.com/repos/juju/juju/issues/5346/labels{/name}","comments_url":"https://api.github.com/repos/juju/juju/issues/5346/comments","events_url":"https://api.github.com/repos/juju/juju/issues/5346/events","html_url":"https://github.com/juju/juju/pull/5346","id":153170949,"number":5346,"title":"cmd/pprof: inject the socket path into Start","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-05T05:36:45Z","updated_at":"2016-05-25T01:07:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/5346","html_url":"https://github.com/juju/juju/pull/5346","diff_url":"https://github.com/juju/juju/pull/5346.diff","patch_url":"https://github.com/juju/juju/pull/5346.patch"},"body":"Rather than using os.TempDir() from within the\ncode, inject the socket path into the Start\nfunction and leave it to the caller to decide\nwhere to put it.\n\nWithout doing this, there is a small chance\nthat two tests in the same package will collide.\nThe tests are run sequentially, but there is a\ngoroutine started by the Start method that may\nremove the socket after the stop function is\ncalled, and after the proceeding test has\nstarted listening on the socket.\n\nFixes https://bugs.launchpad.net/juju-core/+bug/1553292\n\n(Review request: http://reviews.vapour.ws/r/4774/)"},"comment":{"url":"https://api.github.com/repos/juju/juju/issues/comments/221446909","html_url":"https://github.com/juju/juju/pull/5346#issuecomment-221446909","issue_url":"https://api.github.com/repos/juju/juju/issues/5346","id":221446909,"user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T01:07:58Z","updated_at":"2016-05-25T01:07:58Z","body":"$$merge$$"}}
{"actor":{"display_login":"axw"}}