{"action":"created","comment":{"url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/comments/86012215","pull_request_review_id":6693106,"id":86012215,"diff_hunk":"@@ -96,12 +96,17 @@ func createCredentialGraph(ctx context.Context, credBody *PlaintextCredential,\n \t\treturn nil, err\n \t}\n \n-\tteam, err := findMembersTeam(teams)\n+\tmembersTeam, machinesTeam, err := findSystemTeams(teams)\n \tif err != nil {\n \t\treturn nil, err\n \t}\n \n-\tmemberships, err := client.Memberships.List(ctx, credBody.OrgID, team.ID, nil)\n+\tuserMembers, err := client.Memberships.List(ctx, credBody.OrgID, membersTeam.ID, nil)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tmachineMembers, err := client.Memberships.List(ctx, credBody.OrgID, machinesTeam.ID, nil)","path":"daemon/logic/utils.go","position":16,"original_position":16,"commit_id":"66049669a602ec67a33d7139507164673a35921f","original_commit_id":"66049669a602ec67a33d7139507164673a35921f","user":{"login":"jbowes","id":12997,"avatar_url":"https://avatars.githubusercontent.com/u/12997?v=3","gravatar_id":"","url":"https://api.github.com/users/jbowes","html_url":"https://github.com/jbowes","followers_url":"https://api.github.com/users/jbowes/followers","following_url":"https://api.github.com/users/jbowes/following{/other_user}","gists_url":"https://api.github.com/users/jbowes/gists{/gist_id}","starred_url":"https://api.github.com/users/jbowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbowes/subscriptions","organizations_url":"https://api.github.com/users/jbowes/orgs","repos_url":"https://api.github.com/users/jbowes/repos","events_url":"https://api.github.com/users/jbowes/events{/privacy}","received_events_url":"https://api.github.com/users/jbowes/received_events","type":"User","site_admin":false},"body":"their token is destroyed though, so finding the subject for encryption key selection will filter it out :)","created_at":"2016-11-01T20:03:57Z","updated_at":"2016-11-01T20:03:57Z","html_url":"https://github.com/manifoldco/torus-cli/pull/19#discussion_r86012215","pull_request_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/comments/86012215"},"html":{"href":"https://github.com/manifoldco/torus-cli/pull/19#discussion_r86012215"},"pull_request":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19","id":91852030,"html_url":"https://github.com/manifoldco/torus-cli/pull/19","diff_url":"https://github.com/manifoldco/torus-cli/pull/19.diff","patch_url":"https://github.com/manifoldco/torus-cli/pull/19.patch","issue_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/19","number":19,"state":"open","locked":false,"title":"Add machines into newly created keyrings","user":{"login":"jbowes","id":12997,"avatar_url":"https://avatars.githubusercontent.com/u/12997?v=3","gravatar_id":"","url":"https://api.github.com/users/jbowes","html_url":"https://github.com/jbowes","followers_url":"https://api.github.com/users/jbowes/followers","following_url":"https://api.github.com/users/jbowes/following{/other_user}","gists_url":"https://api.github.com/users/jbowes/gists{/gist_id}","starred_url":"https://api.github.com/users/jbowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbowes/subscriptions","organizations_url":"https://api.github.com/users/jbowes/orgs","repos_url":"https://api.github.com/users/jbowes/repos","events_url":"https://api.github.com/users/jbowes/events{/privacy}","received_events_url":"https://api.github.com/users/jbowes/received_events","type":"User","site_admin":false},"body":"Just like for users, when we need to create a new keyring, ensure that\r\nall machines that should have access to the keyring do in fact have\r\naccess.\r\n\r\nAs we do for users, for now, add *all* machines in the org, and rely on\r\nserver-side ACL blocking for access restriction.","created_at":"2016-11-01T19:57:17Z","updated_at":"2016-11-01T20:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f521ff2a6bffa9adc555d217322373bec1d59632","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19/commits","review_comments_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19/comments","review_comment_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/19/comments","statuses_url":"https://api.github.com/repos/manifoldco/torus-cli/statuses/66049669a602ec67a33d7139507164673a35921f","head":{"label":"manifoldco:add-machines-to-new-keyrings","ref":"add-machines-to-new-keyrings","sha":"66049669a602ec67a33d7139507164673a35921f","user":{"login":"manifoldco","id":16501525,"avatar_url":"https://avatars.githubusercontent.com/u/16501525?v=3","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":72035075,"name":"torus-cli","full_name":"manifoldco/torus-cli","owner":{"login":"manifoldco","id":16501525,"avatar_url":"https://avatars.githubusercontent.com/u/16501525?v=3","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/manifoldco/torus-cli","description":"A secure, shared workspace for secrets","fork":false,"url":"https://api.github.com/repos/manifoldco/torus-cli","forks_url":"https://api.github.com/repos/manifoldco/torus-cli/forks","keys_url":"https://api.github.com/repos/manifoldco/torus-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/torus-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/torus-cli/teams","hooks_url":"https://api.github.com/repos/manifoldco/torus-cli/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/torus-cli/events","assignees_url":"https://api.github.com/repos/manifoldco/torus-cli/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/torus-cli/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/torus-cli/tags","blobs_url":"https://api.github.com/repos/manifoldco/torus-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/torus-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/torus-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/torus-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/torus-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/torus-cli/languages","stargazers_url":"https://api.github.com/repos/manifoldco/torus-cli/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/torus-cli/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/torus-cli/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/torus-cli/subscription","commits_url":"https://api.github.com/repos/manifoldco/torus-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/torus-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/torus-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/torus-cli/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/torus-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/torus-cli/merges","archive_url":"https://api.github.com/repos/manifoldco/torus-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/torus-cli/downloads","issues_url":"https://api.github.com/repos/manifoldco/torus-cli/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/torus-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/torus-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/torus-cli/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/torus-cli/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/torus-cli/deployments","created_at":"2016-10-26T19:00:16Z","updated_at":"2016-10-31T12:13:04Z","pushed_at":"2016-11-01T19:57:47Z","git_url":"git://github.com/manifoldco/torus-cli.git","ssh_url":"git@github.com:manifoldco/torus-cli.git","clone_url":"https://github.com/manifoldco/torus-cli.git","svn_url":"https://github.com/manifoldco/torus-cli","homepage":null,"size":1390,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"manifoldco:master","ref":"master","sha":"4bf97798eb7675ac946900e7db2067dd51732839","user":{"login":"manifoldco","id":16501525,"avatar_url":"https://avatars.githubusercontent.com/u/16501525?v=3","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":72035075,"name":"torus-cli","full_name":"manifoldco/torus-cli","owner":{"login":"manifoldco","id":16501525,"avatar_url":"https://avatars.githubusercontent.com/u/16501525?v=3","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/manifoldco/torus-cli","description":"A secure, shared workspace for secrets","fork":false,"url":"https://api.github.com/repos/manifoldco/torus-cli","forks_url":"https://api.github.com/repos/manifoldco/torus-cli/forks","keys_url":"https://api.github.com/repos/manifoldco/torus-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/torus-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/torus-cli/teams","hooks_url":"https://api.github.com/repos/manifoldco/torus-cli/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/torus-cli/events","assignees_url":"https://api.github.com/repos/manifoldco/torus-cli/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/torus-cli/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/torus-cli/tags","blobs_url":"https://api.github.com/repos/manifoldco/torus-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/torus-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/torus-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/torus-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/torus-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/torus-cli/languages","stargazers_url":"https://api.github.com/repos/manifoldco/torus-cli/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/torus-cli/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/torus-cli/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/torus-cli/subscription","commits_url":"https://api.github.com/repos/manifoldco/torus-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/torus-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/torus-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/torus-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/torus-cli/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/torus-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/torus-cli/merges","archive_url":"https://api.github.com/repos/manifoldco/torus-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/torus-cli/downloads","issues_url":"https://api.github.com/repos/manifoldco/torus-cli/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/torus-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/torus-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/torus-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/torus-cli/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/torus-cli/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/torus-cli/deployments","created_at":"2016-10-26T19:00:16Z","updated_at":"2016-10-31T12:13:04Z","pushed_at":"2016-11-01T19:57:47Z","git_url":"git://github.com/manifoldco/torus-cli.git","ssh_url":"git@github.com:manifoldco/torus-cli.git","clone_url":"https://github.com/manifoldco/torus-cli.git","svn_url":"https://github.com/manifoldco/torus-cli","homepage":null,"size":1390,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19"},"html":{"href":"https://github.com/manifoldco/torus-cli/pull/19"},"issue":{"href":"https://api.github.com/repos/manifoldco/torus-cli/issues/19"},"comments":{"href":"https://api.github.com/repos/manifoldco/torus-cli/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manifoldco/torus-cli/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/manifoldco/torus-cli/statuses/66049669a602ec67a33d7139507164673a35921f"}}}}
{"actor":{"display_login":"jbowes"}}