{"action":"created","issue":{"url":"https://api.github.com/repos/inikulin/parse5/issues/92","labels_url":"https://api.github.com/repos/inikulin/parse5/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/inikulin/parse5/issues/92/comments","events_url":"https://api.github.com/repos/inikulin/parse5/issues/92/events","html_url":"https://github.com/inikulin/parse5/pull/92","id":124881273,"number":92,"title":"Location info for Attributes (2.0)","user":{"login":"yyx990803","id":499550,"avatar_url":"https://avatars.githubusercontent.com/u/499550?v=3","gravatar_id":"","url":"https://api.github.com/users/yyx990803","html_url":"https://github.com/yyx990803","followers_url":"https://api.github.com/users/yyx990803/followers","following_url":"https://api.github.com/users/yyx990803/following{/other_user}","gists_url":"https://api.github.com/users/yyx990803/gists{/gist_id}","starred_url":"https://api.github.com/users/yyx990803/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyx990803/subscriptions","organizations_url":"https://api.github.com/users/yyx990803/orgs","repos_url":"https://api.github.com/users/yyx990803/repos","events_url":"https://api.github.com/users/yyx990803/events{/privacy}","received_events_url":"https://api.github.com/users/yyx990803/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-05T02:17:31Z","updated_at":"2016-01-05T16:20:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/inikulin/parse5/pulls/92","html_url":"https://github.com/inikulin/parse5/pull/92","diff_url":"https://github.com/inikulin/parse5/pull/92.diff","patch_url":"https://github.com/inikulin/parse5/pull/92.patch"},"body":"This is based on the work by @sakagg in #59 , with additional changes that:\r\n\r\n- based off the latest 2.0 master;\r\n- attrs location info attached to both `node.__location` and `node.__location.startTag`, as suggested in [this comment](https://github.com/inikulin/parse5/pull/59#issuecomment-130285405);\r\n- fixed and ran the regression benchmark with the following result (no significant perf regression):\r\n\r\n<img width=\"907\" alt=\"screen shot 2016-01-04 at 9 16 40 pm\" src=\"https://cloud.githubusercontent.com/assets/499550/12105988/8a4ddcec-b328-11e5-8a2f-4c658b847fac.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/inikulin/parse5/issues/comments/169048983","html_url":"https://github.com/inikulin/parse5/pull/92#issuecomment-169048983","issue_url":"https://api.github.com/repos/inikulin/parse5/issues/92","id":169048983,"user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"created_at":"2016-01-05T16:20:15Z","updated_at":"2016-01-05T16:20:15Z","body":"@yyx990803 Well, it's a little bit tricky. It requires new type `TagLocationInfo` that will extend `LocationInfo`, but will contain `attrs` as well. Meanwhile `startTag` and `endTag` in `ElementLocationInfo` should have `TagLocationInfo` type now. And we need to update references to the `LocationInfo` there `TagLocationInfo` meant. "}}