{"action":"created","issue":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/336","repository_url":"https://api.github.com/repos/TypeStrong/ts-loader","labels_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/336/comments","events_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/336/events","html_url":"https://github.com/TypeStrong/ts-loader/issues/336","id":184657512,"number":336,"title":"HappyPack with ts-loader.","user":{"login":"aindlq","id":2255044,"avatar_url":"https://avatars.githubusercontent.com/u/2255044?v=3","gravatar_id":"","url":"https://api.github.com/users/aindlq","html_url":"https://github.com/aindlq","followers_url":"https://api.github.com/users/aindlq/followers","following_url":"https://api.github.com/users/aindlq/following{/other_user}","gists_url":"https://api.github.com/users/aindlq/gists{/gist_id}","starred_url":"https://api.github.com/users/aindlq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aindlq/subscriptions","organizations_url":"https://api.github.com/users/aindlq/orgs","repos_url":"https://api.github.com/users/aindlq/repos","events_url":"https://api.github.com/users/aindlq/events{/privacy}","received_events_url":"https://api.github.com/users/aindlq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-22T22:14:47Z","updated_at":"2016-11-07T11:15:07Z","closed_at":null,"body":"I'm trying to use HappyPack with ts-loader, and it seems to be working fine in `transpileOnly` mode if I remove lines:\r\n\r\nhttps://github.com/TypeStrong/ts-loader/blob/v0.9.5/index.ts#L346\r\nhttps://github.com/TypeStrong/ts-loader/blob/v0.9.5/index.ts#L718\r\nhttps://github.com/TypeStrong/ts-loader/blob/v0.9.5/index.ts#L763\r\n\r\nFor me it is fine to remove L346 and L718 because I have tsc running in the background in typecheck mode. I wonder what are the implication of L763.\r\n\r\nAlso do you think it is possible to do some change to make it work out of the box without local patching of ts-loader.\r\n\r\nsee also https://github.com/amireh/happypack/issues/33\r\n"},"comment":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/comments/258809582","html_url":"https://github.com/TypeStrong/ts-loader/issues/336#issuecomment-258809582","issue_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/336","id":258809582,"user":{"login":"amireh","id":153786,"avatar_url":"https://avatars.githubusercontent.com/u/153786?v=3","gravatar_id":"","url":"https://api.github.com/users/amireh","html_url":"https://github.com/amireh","followers_url":"https://api.github.com/users/amireh/followers","following_url":"https://api.github.com/users/amireh/following{/other_user}","gists_url":"https://api.github.com/users/amireh/gists{/gist_id}","starred_url":"https://api.github.com/users/amireh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amireh/subscriptions","organizations_url":"https://api.github.com/users/amireh/orgs","repos_url":"https://api.github.com/users/amireh/repos","events_url":"https://api.github.com/users/amireh/events{/privacy}","received_events_url":"https://api.github.com/users/amireh/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T11:15:07Z","updated_at":"2016-11-07T11:15:07Z","body":"FWIW, I can happily add support to managing `loader._module.errors` via HappyPack but the loader needs to adjust to use an unofficial API (e.g. duck-typing), which is why I've kept back from introducing such a change. The thing is, it can't be synchronous, so statements such as:\r\n\r\n```javascript\r\npushArray(loader._module.errors, ...)\r\n```\r\n\r\nNeed to turn into something like this:\r\n\r\n```javascript\r\nloaderInstance.registerModuleErrors(..., function(err) { })\r\n```\r\n\r\nOr just ignore the callback if you don't need to wait on it. Would this help?\r\n\r\n(The same applies to the module \"meta\" hash, we can provide accessors.)"}}
{"actor":{"display_login":"amireh"}}