{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/47","repository_url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker","labels_url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/47/comments","events_url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/47/events","html_url":"https://github.com/m-lab/ndt-e2e-clientworker/pull/47","id":151500617,"number":47,"title":"Adding a partial implementation of the Banjo driver","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-27T21:56:15Z","updated_at":"2016-04-27T22:05:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/pulls/47","html_url":"https://github.com/m-lab/ndt-e2e-clientworker/pull/47","diff_url":"https://github.com/m-lab/ndt-e2e-clientworker/pull/47.diff","patch_url":"https://github.com/m-lab/ndt-e2e-clientworker/pull/47.patch"},"body":"Adds a partial selenium driver for the Banjo client. Adds a unit test for\r\nthe currently implemented functionality.\r\n\r\nAlso fixes a minor issue with the TestResult constructor. It turns out that\r\nusing the default parameter of [] was causing all instances that used that\r\nconstructor to share the same list, which breaks unit tests. This fixes\r\nthe constructor and both client drivers' usage of the constructor.\r\n\r\nThe Banjo driver differs from the HTML5 driver in that the Banjo driver\r\nuses a private _BanjoUiFlowWrapper so that it doesn't keep having to\r\npass around the \"driver\" and \"result\" parameters to different module-\r\nlevel functions, but perform_test still is idempotent, which was the reason\r\nthe HTML5 driver didn't use instance variables to pass around data\r\nin the first place. We should eventually refactor the HTML5 driver to follow\r\nthe same pattern.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/m-lab/ndt-e2e-clientworker/47)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/comments/215245082","html_url":"https://github.com/m-lab/ndt-e2e-clientworker/pull/47#issuecomment-215245082","issue_url":"https://api.github.com/repos/m-lab/ndt-e2e-clientworker/issues/47","id":215245082,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T22:05:26Z","updated_at":"2016-04-27T22:05:26Z","body":"\n[![Coverage Status](https://coveralls.io/builds/5961278/badge)](https://coveralls.io/builds/5961278)\n\nChanges Unknown when pulling **6b719084d160f005435217ee2449d1a857235470 on mtlynch:banjo1** into ** on m-lab:master**.\n"}}