{"action":"created","issue":{"url":"https://api.github.com/repos/TextDB/textdb/issues/252","repository_url":"https://api.github.com/repos/TextDB/textdb","labels_url":"https://api.github.com/repos/TextDB/textdb/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/TextDB/textdb/issues/252/comments","events_url":"https://api.github.com/repos/TextDB/textdb/issues/252/events","html_url":"https://github.com/TextDB/textdb/pull/252","id":184548343,"number":252,"title":"Modify ScanBasedSourceOperator's parameter","user":{"login":"zuozhiw","id":12578068,"avatar_url":"https://avatars.githubusercontent.com/u/12578068?v=3","gravatar_id":"","url":"https://api.github.com/users/zuozhiw","html_url":"https://github.com/zuozhiw","followers_url":"https://api.github.com/users/zuozhiw/followers","following_url":"https://api.github.com/users/zuozhiw/following{/other_user}","gists_url":"https://api.github.com/users/zuozhiw/gists{/gist_id}","starred_url":"https://api.github.com/users/zuozhiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuozhiw/subscriptions","organizations_url":"https://api.github.com/users/zuozhiw/orgs","repos_url":"https://api.github.com/users/zuozhiw/repos","events_url":"https://api.github.com/users/zuozhiw/events{/privacy}","received_events_url":"https://api.github.com/users/zuozhiw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T19:10:50Z","updated_at":"2016-10-21T19:15:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TextDB/textdb/pulls/252","html_url":"https://github.com/TextDB/textdb/pull/252","diff_url":"https://github.com/TextDB/textdb/pull/252.diff","patch_url":"https://github.com/TextDB/textdb/pull/252.patch"},"body":"Before, `ScanBasedSourceOperator` needs to take a `DataReader`, which is constructed by a `DataReaderPredicate`, which requires the user to provide: `lucene query`, `query string`, `index directory`, `schema`, and `lucene analyzer`. \r\n`Lucene query` and `query string` are apparently redundant, because ScanBasedSourceOperator's query will always be `SCAN_QUERY`.\r\n\r\nThis PR modifies the constructor of `ScanBasedSourceOperator`, now it only requires `DataStore`, which is indexDirectory and Schema, and `lucene analyzer`."},"comment":{"url":"https://api.github.com/repos/TextDB/textdb/issues/comments/255444544","html_url":"https://github.com/TextDB/textdb/pull/252#issuecomment-255444544","issue_url":"https://api.github.com/repos/TextDB/textdb/issues/252","id":255444544,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T19:15:56Z","updated_at":"2016-10-21T19:15:56Z","body":"## [Current coverage](https://codecov.io/gh/TextDB/textdb/pull/252?src=pr) is 64.13% (diff: 87.50%)\n> Merging [#252](https://codecov.io/gh/TextDB/textdb/pull/252?src=pr) into [master](https://codecov.io/gh/TextDB/textdb/branch/master?src=pr) will decrease coverage by **0.10%**\n\n```diff\n@@             master       #252   diff @@\n==========================================\n  Files           130        130          \n  Lines          3490       3491     +1   \n  Methods           0          0          \n  Messages          0          0          \n  Branches        568        568          \n==========================================\n- Hits           2242       2239     -3   \n- Misses         1103       1107     +4   \n  Partials        145        145          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [8432460...ee7504c](https://codecov.io/gh/TextDB/textdb/compare/8432460c0c660db00d745627daafaa0a96dd8379...ee7504cf3a237469e859c906792179b2c1bdb791?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}