{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1477","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1477/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1477/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1477/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1477","id":193863752,"number":1477,"title":"feat(datagrid): add ui for datagrid filters for large layout","user":{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars.githubusercontent.com/u/3472990?v=3","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-06T19:34:07Z","updated_at":"2016-12-07T02:37:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/1477","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1477","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1477.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1477.patch"},"body":"## Description\r\n<!-- Link to an issue or include a description -->\r\nCreate filters for large view viewer (Filters are on the table and they are removed for small display). Tu use with catalog layers, filter of type string, number range and date range have been added. For selection filter it should be added when we will have thematic map.\r\n\r\n## Testing\r\n<!-- Have you added unit tests for this code?  If not explain why. -->\r\nTested it in Chrome, Firefox and Safari\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\nNone\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\nAdded a layer \"Date layer field\" where all type of filter can be test. In the console, when value change, the value and the name of the field on trigger the change should be logged.\r\n\r\n- [x] commits messages follow the guidelines\r\n- [x] code passes unit tests\r\n- [x] release notes have been updated\r\n- [x] PR targets the correct release version\r\n\r\nCloses #1417\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/1477)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/265338640","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1477#issuecomment-265338640","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1477","id":265338640,"user":{"login":"alyec","id":7646414,"avatar_url":"https://avatars.githubusercontent.com/u/7646414?v=3","gravatar_id":"","url":"https://api.github.com/users/alyec","html_url":"https://github.com/alyec","followers_url":"https://api.github.com/users/alyec/followers","following_url":"https://api.github.com/users/alyec/following{/other_user}","gists_url":"https://api.github.com/users/alyec/gists{/gist_id}","starred_url":"https://api.github.com/users/alyec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyec/subscriptions","organizations_url":"https://api.github.com/users/alyec/orgs","repos_url":"https://api.github.com/users/alyec/repos","events_url":"https://api.github.com/users/alyec/events{/privacy}","received_events_url":"https://api.github.com/users/alyec/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T02:37:02Z","updated_at":"2016-12-07T02:37:02Z","body":"This PR is against master, it should probably target 1.5 or 1.6 .\n\n---\n\nReviewed 7 of 7 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/app/ui/filters/filters-number-only.directire.js, line 1 at r1](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1477#-KYL3AejBMw7B1w3ZKTT:-KYL3Aej9yVDJJ3gEpdw:bb0wemp) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/9298f419e5bbb7e474a08a5a7e379c0951ef6adb/src/app/ui/filters/filters-number-only.directire.js#L1)):*\n> ```JavaScript\n> (() => {\n> ```\n\nThe filename has a typo `directire` to `directive`\n\n---\n\n*[src/app/ui/filters/filters.service.js, line 104 at r1](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1477#-KYL2ug5BmROzklorLJS:-KYL2ug5BYFBcv1SNF6x:b-haz5ao) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/9298f419e5bbb7e474a08a5a7e379c0951ef6adb/src/app/ui/filters/filters.service.js#L104)):*\n> ```JavaScript\n>          *\n>          * @function preventSorting\n>          */\n> ```\n\nmissing doc for the event argument\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1477#-:-KYL9M5P20AOW9GxMTSx:b-53shru)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"alyec"}}