{"action":"closed","number":476,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476","id":80723864,"html_url":"https://github.com/mapbox/mapbox-gl-draw/pull/476","diff_url":"https://github.com/mapbox/mapbox-gl-draw/pull/476.diff","patch_url":"https://github.com/mapbox/mapbox-gl-draw/pull/476.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/476","number":476,"state":"closed","locked":false,"title":"Update API docs regarding style ids and sources","user":{"login":"timiyay","id":1470250,"avatar_url":"https://avatars.githubusercontent.com/u/1470250?v=3","gravatar_id":"","url":"https://api.github.com/users/timiyay","html_url":"https://github.com/timiyay","followers_url":"https://api.github.com/users/timiyay/followers","following_url":"https://api.github.com/users/timiyay/following{/other_user}","gists_url":"https://api.github.com/users/timiyay/gists{/gist_id}","starred_url":"https://api.github.com/users/timiyay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timiyay/subscriptions","organizations_url":"https://api.github.com/users/timiyay/orgs","repos_url":"https://api.github.com/users/timiyay/repos","events_url":"https://api.github.com/users/timiyay/events{/privacy}","received_events_url":"https://api.github.com/users/timiyay/received_events","type":"User","site_admin":false},"body":"This PR enhances the `API.md` docs to head off confusion for users who are learning to style `mapbox-gl-draw` features, as in this issue: https://github.com/mapbox/mapbox-gl-draw/issues/472\r\n\r\nThe must-have changes are the clarification of `source` and `id` here: https://github.com/mapbox/mapbox-gl-draw/compare/master...timiyay:feature/api-docs?expand=1#diff-88333ba11114e014e87198d04680144dR395\r\n\r\nThere's a few optional changes too:\r\n\r\n* a second styling example - it's long example for styling for lines and polygons, which compliments the existing point-only example\r\n* extra info on mode transitions, explaining how completed features always transition to `simple_select` (see https://github.com/mapbox/mapbox-gl-draw/issues/472#issuecomment-238578275)\r\n\r\nI wasn't 100% on the vocabulary to use when explaining \"completed\" features. I was attempting to describe a feature that was in the process of being drawn by the user, who then double-clicked to \"complete\" the feature, and triggered the mode transition.\r\n\r\nI also mimicked the use of **BOLD CAPITALISED** statements used in style source. These are arguably overkill, and I'd be happy to change them.","created_at":"2016-08-10T02:04:53Z","updated_at":"2016-08-31T15:21:44Z","closed_at":"2016-08-31T15:21:44Z","merged_at":null,"merge_commit_sha":"74cc5ee0cbcafdd4cf56d093f3c87bda5ead9f3e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/476/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/43b48d6a39c9ee137a12e9fda9e0f1a38c275bf0","head":{"label":"timiyay:feature/api-docs","ref":"feature/api-docs","sha":"43b48d6a39c9ee137a12e9fda9e0f1a38c275bf0","user":{"login":"timiyay","id":1470250,"avatar_url":"https://avatars.githubusercontent.com/u/1470250?v=3","gravatar_id":"","url":"https://api.github.com/users/timiyay","html_url":"https://github.com/timiyay","followers_url":"https://api.github.com/users/timiyay/followers","following_url":"https://api.github.com/users/timiyay/following{/other_user}","gists_url":"https://api.github.com/users/timiyay/gists{/gist_id}","starred_url":"https://api.github.com/users/timiyay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timiyay/subscriptions","organizations_url":"https://api.github.com/users/timiyay/orgs","repos_url":"https://api.github.com/users/timiyay/repos","events_url":"https://api.github.com/users/timiyay/events{/privacy}","received_events_url":"https://api.github.com/users/timiyay/received_events","type":"User","site_admin":false},"repo":{"id":65341862,"name":"mapbox-gl-draw","full_name":"timiyay/mapbox-gl-draw","owner":{"login":"timiyay","id":1470250,"avatar_url":"https://avatars.githubusercontent.com/u/1470250?v=3","gravatar_id":"","url":"https://api.github.com/users/timiyay","html_url":"https://github.com/timiyay","followers_url":"https://api.github.com/users/timiyay/followers","following_url":"https://api.github.com/users/timiyay/following{/other_user}","gists_url":"https://api.github.com/users/timiyay/gists{/gist_id}","starred_url":"https://api.github.com/users/timiyay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timiyay/subscriptions","organizations_url":"https://api.github.com/users/timiyay/orgs","repos_url":"https://api.github.com/users/timiyay/repos","events_url":"https://api.github.com/users/timiyay/events{/privacy}","received_events_url":"https://api.github.com/users/timiyay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timiyay/mapbox-gl-draw","description":"Draw tools for mapbox-gl-js","fork":true,"url":"https://api.github.com/repos/timiyay/mapbox-gl-draw","forks_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/forks","keys_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/teams","hooks_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/hooks","issue_events_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/issues/events{/number}","events_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/events","assignees_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/assignees{/user}","branches_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/branches{/branch}","tags_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/tags","blobs_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/git/refs{/sha}","trees_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/statuses/{sha}","languages_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/languages","stargazers_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/stargazers","contributors_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/contributors","subscribers_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/subscribers","subscription_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/subscription","commits_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/commits{/sha}","git_commits_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/git/commits{/sha}","comments_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/comments{/number}","issue_comment_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/issues/comments{/number}","contents_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/contents/{+path}","compare_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/merges","archive_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/downloads","issues_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/issues{/number}","pulls_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/pulls{/number}","milestones_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/milestones{/number}","notifications_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/labels{/name}","releases_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/releases{/id}","deployments_url":"https://api.github.com/repos/timiyay/mapbox-gl-draw/deployments","created_at":"2016-08-10T01:57:56Z","updated_at":"2016-08-10T01:57:57Z","pushed_at":"2016-08-31T00:01:56Z","git_url":"git://github.com/timiyay/mapbox-gl-draw.git","ssh_url":"git@github.com:timiyay/mapbox-gl-draw.git","clone_url":"https://github.com/timiyay/mapbox-gl-draw.git","svn_url":"https://github.com/timiyay/mapbox-gl-draw","homepage":"","size":3495,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"ca46e9ae83b81a8bc71b14e150bd2703b7112cf2","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":29943859,"name":"mapbox-gl-draw","full_name":"mapbox/mapbox-gl-draw","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-draw","description":"Draw tools for mapbox-gl-js","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/deployments","created_at":"2015-01-28T01:12:21Z","updated_at":"2016-08-28T20:02:45Z","pushed_at":"2016-08-31T15:21:15Z","git_url":"git://github.com/mapbox/mapbox-gl-draw.git","ssh_url":"git@github.com:mapbox/mapbox-gl-draw.git","clone_url":"https://github.com/mapbox/mapbox-gl-draw.git","svn_url":"https://github.com/mapbox/mapbox-gl-draw","homepage":"","size":4390,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":31,"forks":25,"open_issues":31,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476"},"html":{"href":"https://github.com/mapbox/mapbox-gl-draw/pull/476"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/476"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/43b48d6a39c9ee137a12e9fda9e0f1a38c275bf0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":4,"commits":2,"additions":179,"deletions":38,"changed_files":2}}
{"actor":{"display_login":"mcwhittemore"}}