{"action":"opened","number":2043,"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/2043","id":71328031,"html_url":"https://github.com/lxc/lxd/pull/2043","diff_url":"https://github.com/lxc/lxd/pull/2043.diff","patch_url":"https://github.com/lxc/lxd/pull/2043.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/2043","number":2043,"state":"open","locked":false,"title":"Add config key for container force shutdown timeout","user":{"login":"ctrlrsf","id":6004738,"avatar_url":"https://avatars.githubusercontent.com/u/6004738?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlrsf","html_url":"https://github.com/ctrlrsf","followers_url":"https://api.github.com/users/ctrlrsf/followers","following_url":"https://api.github.com/users/ctrlrsf/following{/other_user}","gists_url":"https://api.github.com/users/ctrlrsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlrsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlrsf/subscriptions","organizations_url":"https://api.github.com/users/ctrlrsf/orgs","repos_url":"https://api.github.com/users/ctrlrsf/repos","events_url":"https://api.github.com/users/ctrlrsf/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlrsf/received_events","type":"User","site_admin":false},"body":"Currently, if a container takes more than 30 seconds to shutdown it is stopped anyway. The 30 second timeout is hardcoded and this change makes the timeout configurable.\r\n\r\nThis `boot.force_shutdown_timeout` container config key sets how long to wait (in seconds) for a container to shutdown before it is force stopped.\r\n\r\nI used config key `boot.force_shutdown_timeout` as its pretty meaningful, and shouldn't get confused with unrelated `lxd shutdown --timeout` option. If there are any other suggestions for the config key name, or if it should be in a different namespace than \"boot\", please let me know.\r\n\r\nCloses https://github.com/lxc/lxd/issues/2027\r\n\r\nSigned-off-by: Rene Fragoso <ctrlrsf@gmail.com>","created_at":"2016-05-25T04:12:00Z","updated_at":"2016-05-25T04:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/2043/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/2043/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/2043/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/c986ce4b69197214faf776808a9affdd611577b9","head":{"label":"ctrlrsf:shutdown-timeout","ref":"shutdown-timeout","sha":"c986ce4b69197214faf776808a9affdd611577b9","user":{"login":"ctrlrsf","id":6004738,"avatar_url":"https://avatars.githubusercontent.com/u/6004738?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlrsf","html_url":"https://github.com/ctrlrsf","followers_url":"https://api.github.com/users/ctrlrsf/followers","following_url":"https://api.github.com/users/ctrlrsf/following{/other_user}","gists_url":"https://api.github.com/users/ctrlrsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlrsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlrsf/subscriptions","organizations_url":"https://api.github.com/users/ctrlrsf/orgs","repos_url":"https://api.github.com/users/ctrlrsf/repos","events_url":"https://api.github.com/users/ctrlrsf/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlrsf/received_events","type":"User","site_admin":false},"repo":{"id":59041395,"name":"lxd","full_name":"ctrlrsf/lxd","owner":{"login":"ctrlrsf","id":6004738,"avatar_url":"https://avatars.githubusercontent.com/u/6004738?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlrsf","html_url":"https://github.com/ctrlrsf","followers_url":"https://api.github.com/users/ctrlrsf/followers","following_url":"https://api.github.com/users/ctrlrsf/following{/other_user}","gists_url":"https://api.github.com/users/ctrlrsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlrsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlrsf/subscriptions","organizations_url":"https://api.github.com/users/ctrlrsf/orgs","repos_url":"https://api.github.com/users/ctrlrsf/repos","events_url":"https://api.github.com/users/ctrlrsf/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlrsf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctrlrsf/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":true,"url":"https://api.github.com/repos/ctrlrsf/lxd","forks_url":"https://api.github.com/repos/ctrlrsf/lxd/forks","keys_url":"https://api.github.com/repos/ctrlrsf/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctrlrsf/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctrlrsf/lxd/teams","hooks_url":"https://api.github.com/repos/ctrlrsf/lxd/hooks","issue_events_url":"https://api.github.com/repos/ctrlrsf/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/ctrlrsf/lxd/events","assignees_url":"https://api.github.com/repos/ctrlrsf/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/ctrlrsf/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/ctrlrsf/lxd/tags","blobs_url":"https://api.github.com/repos/ctrlrsf/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctrlrsf/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctrlrsf/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctrlrsf/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctrlrsf/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/ctrlrsf/lxd/languages","stargazers_url":"https://api.github.com/repos/ctrlrsf/lxd/stargazers","contributors_url":"https://api.github.com/repos/ctrlrsf/lxd/contributors","subscribers_url":"https://api.github.com/repos/ctrlrsf/lxd/subscribers","subscription_url":"https://api.github.com/repos/ctrlrsf/lxd/subscription","commits_url":"https://api.github.com/repos/ctrlrsf/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctrlrsf/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctrlrsf/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctrlrsf/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctrlrsf/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/ctrlrsf/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctrlrsf/lxd/merges","archive_url":"https://api.github.com/repos/ctrlrsf/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctrlrsf/lxd/downloads","issues_url":"https://api.github.com/repos/ctrlrsf/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/ctrlrsf/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/ctrlrsf/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/ctrlrsf/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctrlrsf/lxd/labels{/name}","releases_url":"https://api.github.com/repos/ctrlrsf/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/ctrlrsf/lxd/deployments","created_at":"2016-05-17T16:49:58Z","updated_at":"2016-05-17T16:50:00Z","pushed_at":"2016-05-25T04:00:38Z","git_url":"git://github.com/ctrlrsf/lxd.git","ssh_url":"git@github.com:ctrlrsf/lxd.git","clone_url":"https://github.com/ctrlrsf/lxd.git","svn_url":"https://github.com/ctrlrsf/lxd","homepage":"https://linuxcontainers.org/lxd","size":6023,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"8bc369c6924caaf2400ac17b2281cb66ad659650","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2016-05-24T23:55:25Z","pushed_at":"2016-05-24T23:21:57Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":7484,"stargazers_count":981,"watchers_count":981,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":76,"forks":185,"open_issues":76,"watchers":981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2043"},"html":{"href":"https://github.com/lxc/lxd/pull/2043"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/2043"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/2043/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2043/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2043/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/c986ce4b69197214faf776808a9affdd611577b9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"ctrlrsf"}}