{"action":"created","comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/84354372","pull_request_review_id":5137784,"id":84354372,"diff_hunk":"@@ -61,6 +61,7 @@ def test_extraradiation(input, expected, method):\n \n \n @requires_numba\n+@pytest.mark.xfail(raises=ValueError, reason = 'spa.calculate_deltat not implemented for numba yet')","path":"pvlib/test/test_irradiance.py","position":4,"original_position":4,"commit_id":"92abe833a06a3e7788f781432e566669d9740af5","original_commit_id":"92abe833a06a3e7788f781432e566669d9740af5","user":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars.githubusercontent.com/u/4383303?v=3","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"body":"We can now get rid of the xfail on test_extraradiation_nrel_numba, right? It would be good to add a more localized test in test_spa.py or test_solarposition.py that does fail under the expected conditions (decorated with xfail, of course).","created_at":"2016-10-20T19:04:47Z","updated_at":"2016-10-20T19:05:38Z","html_url":"https://github.com/pvlib/pvlib-python/pull/240#discussion_r84354372","pull_request_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/84354372"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/240#discussion_r84354372"},"pull_request":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240","id":84720828,"html_url":"https://github.com/pvlib/pvlib-python/pull/240","diff_url":"https://github.com/pvlib/pvlib-python/pull/240.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/240.patch","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/240","number":240,"state":"open","locked":false,"title":"Issue 165: Added calculate_deltaT function into spa.py ","user":{"login":"VolkrB","id":20803912,"avatar_url":"https://avatars.githubusercontent.com/u/20803912?v=3","gravatar_id":"","url":"https://api.github.com/users/VolkrB","html_url":"https://github.com/VolkrB","followers_url":"https://api.github.com/users/VolkrB/followers","following_url":"https://api.github.com/users/VolkrB/following{/other_user}","gists_url":"https://api.github.com/users/VolkrB/gists{/gist_id}","starred_url":"https://api.github.com/users/VolkrB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolkrB/subscriptions","organizations_url":"https://api.github.com/users/VolkrB/orgs","repos_url":"https://api.github.com/users/VolkrB/repos","events_url":"https://api.github.com/users/VolkrB/events{/privacy}","received_events_url":"https://api.github.com/users/VolkrB/received_events","type":"User","site_admin":false},"body":"Hey!\r\nI'd like to get involved and figured this would be a good place for me to start. I have appended a delta t function (similar to the one that was recently added into the matlab version) to the spa module.  Anything you want me to change, add or improve, I will happily do! \r\n\r\nVolker","created_at":"2016-09-09T21:17:29Z","updated_at":"2016-10-20T19:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcb370570a6458376c236b85d9bdda43237ae58c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/14","html_url":"https://github.com/pvlib/pvlib-python/milestones/0.4.2","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/14/labels","id":2047998,"number":14,"title":"0.4.2","description":"","creator":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars.githubusercontent.com/u/4383303?v=3","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2016-10-04T21:10:15Z","updated_at":"2016-10-19T17:26:41Z","due_on":"2016-10-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240/commits","review_comments_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240/comments","review_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/240/comments","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/92abe833a06a3e7788f781432e566669d9740af5","head":{"label":"VolkrB:master","ref":"master","sha":"92abe833a06a3e7788f781432e566669d9740af5","user":{"login":"VolkrB","id":20803912,"avatar_url":"https://avatars.githubusercontent.com/u/20803912?v=3","gravatar_id":"","url":"https://api.github.com/users/VolkrB","html_url":"https://github.com/VolkrB","followers_url":"https://api.github.com/users/VolkrB/followers","following_url":"https://api.github.com/users/VolkrB/following{/other_user}","gists_url":"https://api.github.com/users/VolkrB/gists{/gist_id}","starred_url":"https://api.github.com/users/VolkrB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolkrB/subscriptions","organizations_url":"https://api.github.com/users/VolkrB/orgs","repos_url":"https://api.github.com/users/VolkrB/repos","events_url":"https://api.github.com/users/VolkrB/events{/privacy}","received_events_url":"https://api.github.com/users/VolkrB/received_events","type":"User","site_admin":false},"repo":{"id":67832269,"name":"pvlib-python","full_name":"VolkrB/pvlib-python","owner":{"login":"VolkrB","id":20803912,"avatar_url":"https://avatars.githubusercontent.com/u/20803912?v=3","gravatar_id":"","url":"https://api.github.com/users/VolkrB","html_url":"https://github.com/VolkrB","followers_url":"https://api.github.com/users/VolkrB/followers","following_url":"https://api.github.com/users/VolkrB/following{/other_user}","gists_url":"https://api.github.com/users/VolkrB/gists{/gist_id}","starred_url":"https://api.github.com/users/VolkrB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolkrB/subscriptions","organizations_url":"https://api.github.com/users/VolkrB/orgs","repos_url":"https://api.github.com/users/VolkrB/repos","events_url":"https://api.github.com/users/VolkrB/events{/privacy}","received_events_url":"https://api.github.com/users/VolkrB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VolkrB/pvlib-python","description":"A set of documented functions for simulating the performance of photovoltaic energy systems.","fork":true,"url":"https://api.github.com/repos/VolkrB/pvlib-python","forks_url":"https://api.github.com/repos/VolkrB/pvlib-python/forks","keys_url":"https://api.github.com/repos/VolkrB/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VolkrB/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VolkrB/pvlib-python/teams","hooks_url":"https://api.github.com/repos/VolkrB/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/VolkrB/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/VolkrB/pvlib-python/events","assignees_url":"https://api.github.com/repos/VolkrB/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/VolkrB/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/VolkrB/pvlib-python/tags","blobs_url":"https://api.github.com/repos/VolkrB/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VolkrB/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VolkrB/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/VolkrB/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VolkrB/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/VolkrB/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/VolkrB/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/VolkrB/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/VolkrB/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/VolkrB/pvlib-python/subscription","commits_url":"https://api.github.com/repos/VolkrB/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/VolkrB/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/VolkrB/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/VolkrB/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/VolkrB/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/VolkrB/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VolkrB/pvlib-python/merges","archive_url":"https://api.github.com/repos/VolkrB/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VolkrB/pvlib-python/downloads","issues_url":"https://api.github.com/repos/VolkrB/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/VolkrB/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/VolkrB/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/VolkrB/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VolkrB/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/VolkrB/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/VolkrB/pvlib-python/deployments","created_at":"2016-09-09T20:57:21Z","updated_at":"2016-09-09T20:57:23Z","pushed_at":"2016-10-20T17:34:13Z","git_url":"git://github.com/VolkrB/pvlib-python.git","ssh_url":"git@github.com:VolkrB/pvlib-python.git","clone_url":"https://github.com/VolkrB/pvlib-python.git","svn_url":"https://github.com/VolkrB/pvlib-python","homepage":"","size":65581,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pvlib:master","ref":"master","sha":"23a4d1a3751bf732ac5d6fd6d9de9c9ee6fac489","user":{"login":"pvlib","id":11037261,"avatar_url":"https://avatars.githubusercontent.com/u/11037261?v=3","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"repo":{"id":30895522,"name":"pvlib-python","full_name":"pvlib/pvlib-python","owner":{"login":"pvlib","id":11037261,"avatar_url":"https://avatars.githubusercontent.com/u/11037261?v=3","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pvlib/pvlib-python","description":"A set of documented functions for simulating the performance of photovoltaic energy systems.","fork":false,"url":"https://api.github.com/repos/pvlib/pvlib-python","forks_url":"https://api.github.com/repos/pvlib/pvlib-python/forks","keys_url":"https://api.github.com/repos/pvlib/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvlib/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvlib/pvlib-python/teams","hooks_url":"https://api.github.com/repos/pvlib/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/pvlib/pvlib-python/events","assignees_url":"https://api.github.com/repos/pvlib/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/pvlib/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/pvlib/pvlib-python/tags","blobs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvlib/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvlib/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/pvlib/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/pvlib/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/pvlib/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/pvlib/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/pvlib/pvlib-python/subscription","commits_url":"https://api.github.com/repos/pvlib/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvlib/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvlib/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/pvlib/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvlib/pvlib-python/merges","archive_url":"https://api.github.com/repos/pvlib/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvlib/pvlib-python/downloads","issues_url":"https://api.github.com/repos/pvlib/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/pvlib/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/pvlib/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/pvlib/pvlib-python/deployments","created_at":"2015-02-17T00:21:33Z","updated_at":"2016-10-06T07:57:24Z","pushed_at":"2016-10-20T17:34:13Z","git_url":"git://github.com/pvlib/pvlib-python.git","ssh_url":"git@github.com:pvlib/pvlib-python.git","clone_url":"https://github.com/pvlib/pvlib-python.git","svn_url":"https://github.com/pvlib/pvlib-python","homepage":"","size":70959,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":41,"forks":81,"open_issues":41,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/240"},"issue":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/240"},"comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/pvlib/pvlib-python/statuses/92abe833a06a3e7788f781432e566669d9740af5"}}}}
{"actor":{"display_login":"wholmgren"}}