{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/33851","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/33851/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/33851/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/33851/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/33851","id":124470106,"number":33851,"title":"LPS-60454 buildLang","user":{"login":"marcellustavares","id":286892,"avatar_url":"https://avatars.githubusercontent.com/u/286892?v=3","gravatar_id":"","url":"https://api.github.com/users/marcellustavares","html_url":"https://github.com/marcellustavares","followers_url":"https://api.github.com/users/marcellustavares/followers","following_url":"https://api.github.com/users/marcellustavares/following{/other_user}","gists_url":"https://api.github.com/users/marcellustavares/gists{/gist_id}","starred_url":"https://api.github.com/users/marcellustavares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcellustavares/subscriptions","organizations_url":"https://api.github.com/users/marcellustavares/orgs","repos_url":"https://api.github.com/users/marcellustavares/repos","events_url":"https://api.github.com/users/marcellustavares/events{/privacy}","received_events_url":"https://api.github.com/users/marcellustavares/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-31T13:17:52Z","updated_at":"2016-01-01T23:52:36Z","closed_at":"2016-01-01T23:52:36Z","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/33851","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/33851","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/33851.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/33851.patch"},"body":"Hey Brian, there are some keys that are being used as field labels or placeholders, so I removed the `.` from them. I think it's weird to have . on these cases.\r\n\r\nSuch as `Select an option.` as an option on a select field.\r\n\r\n@rbohl, could you please help me to review them once we this in upstream?\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/168351316","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/33851#issuecomment-168351316","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/33851","id":168351316,"user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"created_at":"2016-01-01T23:52:35Z","updated_at":"2016-01-01T23:52:35Z","body":"@marcellustavares can you rebase and resend? Conflict error.\r\n\r\nPlease make sure things are either titles: Select an Option\r\n\r\nor sentences:\r\n\r\nSelect an option.\r\n\r\nBut never\r\n\r\nSelect an option\r\n\r\nThx."}}