{"action":"opened","number":411,"pull_request":{"url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411","id":61345834,"html_url":"https://github.com/daledotshan/liferay-portal/pull/411","diff_url":"https://github.com/daledotshan/liferay-portal/pull/411.diff","patch_url":"https://github.com/daledotshan/liferay-portal/pull/411.patch","issue_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/411","number":411,"state":"open","locked":false,"title":"[Technical-Support] LPS-63807","user":{"login":"yuhai","id":1029227,"avatar_url":"https://avatars.githubusercontent.com/u/1029227?v=3","gravatar_id":"","url":"https://api.github.com/users/yuhai","html_url":"https://github.com/yuhai","followers_url":"https://api.github.com/users/yuhai/followers","following_url":"https://api.github.com/users/yuhai/following{/other_user}","gists_url":"https://api.github.com/users/yuhai/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhai/subscriptions","organizations_url":"https://api.github.com/users/yuhai/orgs","repos_url":"https://api.github.com/users/yuhai/repos","events_url":"https://api.github.com/users/yuhai/events{/privacy}","received_events_url":"https://api.github.com/users/yuhai/received_events","type":"User","site_admin":false},"body":"For Content Reviewer role, it can get threadslist (status=-1), please refer to the logic:\r\n\r\nmessage_boards/view.jsp:\r\nmbListDisplayContext.populateResultsAndTotal(entriesSearchContainer); // 94 lines\r\n->DefaultMBListDisplayContext.populateResultsAndTotal(){\r\nif (permissionChecker.isContentReviewer(\r\n\t\t\t\t\tthemeDisplay.getCompanyId(),\r\n\t\t\t\t\tthemeDisplay.getScopeGroupId())) {\r\n\r\n\tstatus = WorkflowConstants.STATUS_ANY;\r\n    }\r\n}\r\n\r\nAt this point, we use isContentReviewer as permission check so the Content Reviewer role can get all threadslist.\r\n\r\nHowever, when click the detail thread, we use isGroupAdmin(), this will block Content Reviewer role can't view the thread. The fix uses isContentReviewer() and keeps the consistent with get all threadsList.\r\n\r\nThanks,\r\nHai","created_at":"2016-03-02T03:20:59Z","updated_at":"2016-03-02T03:20:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411/commits","review_comments_url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411/comments","review_comment_url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/411/comments","statuses_url":"https://api.github.com/repos/daledotshan/liferay-portal/statuses/be48c0499dede486cef6e50f1cddf18251974ba1","head":{"label":"yuhai:LPS-63807","ref":"LPS-63807","sha":"be48c0499dede486cef6e50f1cddf18251974ba1","user":{"login":"yuhai","id":1029227,"avatar_url":"https://avatars.githubusercontent.com/u/1029227?v=3","gravatar_id":"","url":"https://api.github.com/users/yuhai","html_url":"https://github.com/yuhai","followers_url":"https://api.github.com/users/yuhai/followers","following_url":"https://api.github.com/users/yuhai/following{/other_user}","gists_url":"https://api.github.com/users/yuhai/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhai/subscriptions","organizations_url":"https://api.github.com/users/yuhai/orgs","repos_url":"https://api.github.com/users/yuhai/repos","events_url":"https://api.github.com/users/yuhai/events{/privacy}","received_events_url":"https://api.github.com/users/yuhai/received_events","type":"User","site_admin":false},"repo":{"id":6821865,"name":"liferay-portal","full_name":"yuhai/liferay-portal","owner":{"login":"yuhai","id":1029227,"avatar_url":"https://avatars.githubusercontent.com/u/1029227?v=3","gravatar_id":"","url":"https://api.github.com/users/yuhai","html_url":"https://github.com/yuhai","followers_url":"https://api.github.com/users/yuhai/followers","following_url":"https://api.github.com/users/yuhai/following{/other_user}","gists_url":"https://api.github.com/users/yuhai/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhai/subscriptions","organizations_url":"https://api.github.com/users/yuhai/orgs","repos_url":"https://api.github.com/users/yuhai/repos","events_url":"https://api.github.com/users/yuhai/events{/privacy}","received_events_url":"https://api.github.com/users/yuhai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuhai/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/yuhai/liferay-portal","forks_url":"https://api.github.com/repos/yuhai/liferay-portal/forks","keys_url":"https://api.github.com/repos/yuhai/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuhai/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuhai/liferay-portal/teams","hooks_url":"https://api.github.com/repos/yuhai/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/yuhai/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/yuhai/liferay-portal/events","assignees_url":"https://api.github.com/repos/yuhai/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/yuhai/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/yuhai/liferay-portal/tags","blobs_url":"https://api.github.com/repos/yuhai/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuhai/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuhai/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuhai/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuhai/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/yuhai/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/yuhai/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/yuhai/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/yuhai/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/yuhai/liferay-portal/subscription","commits_url":"https://api.github.com/repos/yuhai/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuhai/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuhai/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuhai/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuhai/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/yuhai/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuhai/liferay-portal/merges","archive_url":"https://api.github.com/repos/yuhai/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuhai/liferay-portal/downloads","issues_url":"https://api.github.com/repos/yuhai/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/yuhai/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/yuhai/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/yuhai/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuhai/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/yuhai/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/yuhai/liferay-portal/deployments","created_at":"2012-11-23T03:19:21Z","updated_at":"2015-05-06T01:44:05Z","pushed_at":"2016-03-02T02:49:27Z","git_url":"git://github.com/yuhai/liferay-portal.git","ssh_url":"git@github.com:yuhai/liferay-portal.git","clone_url":"https://github.com/yuhai/liferay-portal.git","svn_url":"https://github.com/yuhai/liferay-portal","homepage":"http://liferay.com","size":5971838,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"daledotshan:master","ref":"master","sha":"d7f912b32a08909df13abad90e76bcfcd8f53dd8","user":{"login":"daledotshan","id":861683,"avatar_url":"https://avatars.githubusercontent.com/u/861683?v=3","gravatar_id":"","url":"https://api.github.com/users/daledotshan","html_url":"https://github.com/daledotshan","followers_url":"https://api.github.com/users/daledotshan/followers","following_url":"https://api.github.com/users/daledotshan/following{/other_user}","gists_url":"https://api.github.com/users/daledotshan/gists{/gist_id}","starred_url":"https://api.github.com/users/daledotshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daledotshan/subscriptions","organizations_url":"https://api.github.com/users/daledotshan/orgs","repos_url":"https://api.github.com/users/daledotshan/repos","events_url":"https://api.github.com/users/daledotshan/events{/privacy}","received_events_url":"https://api.github.com/users/daledotshan/received_events","type":"User","site_admin":false},"repo":{"id":9027093,"name":"liferay-portal","full_name":"daledotshan/liferay-portal","owner":{"login":"daledotshan","id":861683,"avatar_url":"https://avatars.githubusercontent.com/u/861683?v=3","gravatar_id":"","url":"https://api.github.com/users/daledotshan","html_url":"https://github.com/daledotshan","followers_url":"https://api.github.com/users/daledotshan/followers","following_url":"https://api.github.com/users/daledotshan/following{/other_user}","gists_url":"https://api.github.com/users/daledotshan/gists{/gist_id}","starred_url":"https://api.github.com/users/daledotshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daledotshan/subscriptions","organizations_url":"https://api.github.com/users/daledotshan/orgs","repos_url":"https://api.github.com/users/daledotshan/repos","events_url":"https://api.github.com/users/daledotshan/events{/privacy}","received_events_url":"https://api.github.com/users/daledotshan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daledotshan/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/daledotshan/liferay-portal","forks_url":"https://api.github.com/repos/daledotshan/liferay-portal/forks","keys_url":"https://api.github.com/repos/daledotshan/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daledotshan/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daledotshan/liferay-portal/teams","hooks_url":"https://api.github.com/repos/daledotshan/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/daledotshan/liferay-portal/events","assignees_url":"https://api.github.com/repos/daledotshan/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/daledotshan/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/daledotshan/liferay-portal/tags","blobs_url":"https://api.github.com/repos/daledotshan/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daledotshan/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daledotshan/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/daledotshan/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daledotshan/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/daledotshan/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/daledotshan/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/daledotshan/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/daledotshan/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/daledotshan/liferay-portal/subscription","commits_url":"https://api.github.com/repos/daledotshan/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/daledotshan/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/daledotshan/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/daledotshan/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/daledotshan/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daledotshan/liferay-portal/merges","archive_url":"https://api.github.com/repos/daledotshan/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daledotshan/liferay-portal/downloads","issues_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/daledotshan/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/daledotshan/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daledotshan/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/daledotshan/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/daledotshan/liferay-portal/deployments","created_at":"2013-03-26T09:41:10Z","updated_at":"2016-01-11T08:23:19Z","pushed_at":"2016-02-29T07:35:48Z","git_url":"git://github.com/daledotshan/liferay-portal.git","ssh_url":"git@github.com:daledotshan/liferay-portal.git","clone_url":"https://github.com/daledotshan/liferay-portal.git","svn_url":"https://github.com/daledotshan/liferay-portal","homepage":"http://liferay.com","size":5893429,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411"},"html":{"href":"https://github.com/daledotshan/liferay-portal/pull/411"},"issue":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/issues/411"},"comments":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/daledotshan/liferay-portal/statuses/be48c0499dede486cef6e50f1cddf18251974ba1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10000,"additions":9248,"deletions":216,"changed_files":54036}}