{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/60388945","id":60388945,"diff_hunk":"@@ -47,6 +47,17 @@ object ABNewHeaderVariant extends TestDefinition(\n   }\n }\n \n+object ABGalleryRedesignVariant extends TestDefinition(\n+  variants = Nil,\n+  name = \"ab-gallery-redesign-variant\",\n+  description = \"Feature switch (0% test) for gallery redesign\",\n+  sellByDate = new LocalDate(2016, 5, 10)\n+) {\n+  override def isParticipating(implicit request: RequestHeader): Boolean = {\n+    request.headers.get(\"X-GU-ab-gallery-redesign\").contains(\"variant\") && switch.isSwitchedOn && ServerSideTests.isSwitchedOn","path":"common/app/mvt/MultiVariateTesting.scala","position":11,"original_position":11,"commit_id":"dc6ff0e2f84f469b6c526761725a2889923cb3d6","original_commit_id":"dc6ff0e2f84f469b6c526761725a2889923cb3d6","user":{"login":"desbo","id":1064734,"avatar_url":"https://avatars.githubusercontent.com/u/1064734?v=3","gravatar_id":"","url":"https://api.github.com/users/desbo","html_url":"https://github.com/desbo","followers_url":"https://api.github.com/users/desbo/followers","following_url":"https://api.github.com/users/desbo/following{/other_user}","gists_url":"https://api.github.com/users/desbo/gists{/gist_id}","starred_url":"https://api.github.com/users/desbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desbo/subscriptions","organizations_url":"https://api.github.com/users/desbo/orgs","repos_url":"https://api.github.com/users/desbo/repos","events_url":"https://api.github.com/users/desbo/events{/privacy}","received_events_url":"https://api.github.com/users/desbo/received_events","type":"User","site_admin":false},"body":"do you need this header? I'm not sure there's any need to override `isParticipating` here ","created_at":"2016-04-20T11:07:04Z","updated_at":"2016-04-20T11:07:04Z","html_url":"https://github.com/guardian/frontend/pull/12576#discussion_r60388945","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/12576","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/60388945"},"html":{"href":"https://github.com/guardian/frontend/pull/12576#discussion_r60388945"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12576"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/12576","id":66638519,"html_url":"https://github.com/guardian/frontend/pull/12576","diff_url":"https://github.com/guardian/frontend/pull/12576.diff","patch_url":"https://github.com/guardian/frontend/pull/12576.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/12576","number":12576,"state":"open","locked":false,"title":"Gallery redesign WIP: Initial PR","user":{"login":"NataliaLKB","id":8774970,"avatar_url":"https://avatars.githubusercontent.com/u/8774970?v=3","gravatar_id":"","url":"https://api.github.com/users/NataliaLKB","html_url":"https://github.com/NataliaLKB","followers_url":"https://api.github.com/users/NataliaLKB/followers","following_url":"https://api.github.com/users/NataliaLKB/following{/other_user}","gists_url":"https://api.github.com/users/NataliaLKB/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaLKB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaLKB/subscriptions","organizations_url":"https://api.github.com/users/NataliaLKB/orgs","repos_url":"https://api.github.com/users/NataliaLKB/repos","events_url":"https://api.github.com/users/NataliaLKB/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaLKB/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\n@zeftilldeath designed what galleries should look like, this is the initial PR implementing the design.\r\n\r\n## What is the value of this and can you measure success?\r\nThis will start as a 0% A/B test while we iterate. Next week the aim is to start rolling it out an audience \r\n\r\n## What is next?\r\n\r\n- [x] Use picture element instead of srcset\r\n- [ ] Try to eliminate jank, at least where pictures are loading. Had a talk with @OliverJAsh yesterday about how to do this.\r\n- [ ] Add animation for when you scroll down (ask myself or @zeftilldeath for the video if you want to see)\r\n- [ ] On mobile, option to only see images and not captions.\r\n- [ ] Set a limit for caption length on both mobile and desktop\r\n- [ ] Fastly Change persistent cookie for optin so that people in the business can take a look without adding a header\r\n- [ ] Fix 100vh jumping on mobile across immersives. talked to @gtrufitt about this, and th\r\n- [ ] MPU slot styling\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo\r\n\r\n## Screenshots\r\n\r\nMobile:\r\n![image](https://cloud.githubusercontent.com/assets/8774970/14561964/d74be7e4-0311-11e6-8ce5-7fab5c0740fe.png)\r\n![image](https://cloud.githubusercontent.com/assets/8774970/14566246/9881eecc-0326-11e6-85b6-ca0b05639fa0.png)\r\n\r\n\r\n\r\nDesktop:\r\n![image](https://cloud.githubusercontent.com/assets/8774970/14561935/b80c1048-0311-11e6-962a-ee359d41d6dd.png)\r\n![image](https://cloud.githubusercontent.com/assets/8774970/14566237/82f6198e-0326-11e6-8f59-9de7d1995e0e.png)\r\n\r\n\r\n## Request for comment\r\n@OliverJAsh ","created_at":"2016-04-15T13:01:15Z","updated_at":"2016-04-20T11:07:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8bb48590a7cd00bac0c54868589e948df967b95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/12576/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/12576/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/12576/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/dc6ff0e2f84f469b6c526761725a2889923cb3d6","head":{"label":"guardian:gallery-redesign","ref":"gallery-redesign","sha":"dc6ff0e2f84f469b6c526761725a2889923cb3d6","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-19T23:13:26Z","pushed_at":"2016-04-20T11:05:19Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":470515,"stargazers_count":3156,"watchers_count":3156,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"open_issues_count":36,"forks":320,"open_issues":36,"watchers":3156,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"4ad6f798036fd5fb7282bd09e538790e2293b085","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-19T23:13:26Z","pushed_at":"2016-04-20T11:05:19Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":470515,"stargazers_count":3156,"watchers_count":3156,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"open_issues_count":36,"forks":320,"open_issues":36,"watchers":3156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12576"},"html":{"href":"https://github.com/guardian/frontend/pull/12576"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/12576"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/12576/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12576/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12576/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/dc6ff0e2f84f469b6c526761725a2889923cb3d6"}}}}