{"action":"opened","number":64,"pull_request":{"url":"https://api.github.com/repos/ggozad/behaving/pulls/64","id":84687523,"html_url":"https://github.com/ggozad/behaving/pull/64","diff_url":"https://github.com/ggozad/behaving/pull/64.diff","patch_url":"https://github.com/ggozad/behaving/pull/64.patch","issue_url":"https://api.github.com/repos/ggozad/behaving/issues/64","number":64,"state":"open","locked":false,"title":"Fix quote handling for xpath","user":{"login":"kageurufu","id":259751,"avatar_url":"https://avatars.githubusercontent.com/u/259751?v=3","gravatar_id":"","url":"https://api.github.com/users/kageurufu","html_url":"https://github.com/kageurufu","followers_url":"https://api.github.com/users/kageurufu/followers","following_url":"https://api.github.com/users/kageurufu/following{/other_user}","gists_url":"https://api.github.com/users/kageurufu/gists{/gist_id}","starred_url":"https://api.github.com/users/kageurufu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kageurufu/subscriptions","organizations_url":"https://api.github.com/users/kageurufu/orgs","repos_url":"https://api.github.com/users/kageurufu/repos","events_url":"https://api.github.com/users/kageurufu/events{/privacy}","received_events_url":"https://api.github.com/users/kageurufu/received_events","type":"User","site_admin":false},"body":"xpath has no way of properly escaping quotes. \r\n\r\nThe prior version would break horribly if you had quotes in your text, such as Jacob's\r\n\r\nThis will escape double quotes (as those are escapes are handled by javascript, and inside wrapping single quotes), and convert single quotes to string concatenations with double quoted single quotes inside. \r\n\r\nI did attempt to use both &quot;/&apos; as well as \"\" or '' to escape them, which just caused javascript errors across browsers. \r\n\r\nThis solution has been testing against a variety of mixed quotes in the search string, and seems fairly robust","created_at":"2016-09-09T17:26:18Z","updated_at":"2016-09-09T17:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ggozad/behaving/pulls/64/commits","review_comments_url":"https://api.github.com/repos/ggozad/behaving/pulls/64/comments","review_comment_url":"https://api.github.com/repos/ggozad/behaving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ggozad/behaving/issues/64/comments","statuses_url":"https://api.github.com/repos/ggozad/behaving/statuses/07fcec2c822e856fc617f25caa2c8cb169b5add3","head":{"label":"DisruptiveLabs:escape_quotes_text_contains","ref":"escape_quotes_text_contains","sha":"07fcec2c822e856fc617f25caa2c8cb169b5add3","user":{"login":"DisruptiveLabs","id":5648126,"avatar_url":"https://avatars.githubusercontent.com/u/5648126?v=3","gravatar_id":"","url":"https://api.github.com/users/DisruptiveLabs","html_url":"https://github.com/DisruptiveLabs","followers_url":"https://api.github.com/users/DisruptiveLabs/followers","following_url":"https://api.github.com/users/DisruptiveLabs/following{/other_user}","gists_url":"https://api.github.com/users/DisruptiveLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DisruptiveLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisruptiveLabs/subscriptions","organizations_url":"https://api.github.com/users/DisruptiveLabs/orgs","repos_url":"https://api.github.com/users/DisruptiveLabs/repos","events_url":"https://api.github.com/users/DisruptiveLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DisruptiveLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":16558100,"name":"behaving","full_name":"DisruptiveLabs/behaving","owner":{"login":"DisruptiveLabs","id":5648126,"avatar_url":"https://avatars.githubusercontent.com/u/5648126?v=3","gravatar_id":"","url":"https://api.github.com/users/DisruptiveLabs","html_url":"https://github.com/DisruptiveLabs","followers_url":"https://api.github.com/users/DisruptiveLabs/followers","following_url":"https://api.github.com/users/DisruptiveLabs/following{/other_user}","gists_url":"https://api.github.com/users/DisruptiveLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DisruptiveLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisruptiveLabs/subscriptions","organizations_url":"https://api.github.com/users/DisruptiveLabs/orgs","repos_url":"https://api.github.com/users/DisruptiveLabs/repos","events_url":"https://api.github.com/users/DisruptiveLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DisruptiveLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DisruptiveLabs/behaving","description":"Behavior-Driver-Development for multi-user web/email/sms applications","fork":true,"url":"https://api.github.com/repos/DisruptiveLabs/behaving","forks_url":"https://api.github.com/repos/DisruptiveLabs/behaving/forks","keys_url":"https://api.github.com/repos/DisruptiveLabs/behaving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DisruptiveLabs/behaving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DisruptiveLabs/behaving/teams","hooks_url":"https://api.github.com/repos/DisruptiveLabs/behaving/hooks","issue_events_url":"https://api.github.com/repos/DisruptiveLabs/behaving/issues/events{/number}","events_url":"https://api.github.com/repos/DisruptiveLabs/behaving/events","assignees_url":"https://api.github.com/repos/DisruptiveLabs/behaving/assignees{/user}","branches_url":"https://api.github.com/repos/DisruptiveLabs/behaving/branches{/branch}","tags_url":"https://api.github.com/repos/DisruptiveLabs/behaving/tags","blobs_url":"https://api.github.com/repos/DisruptiveLabs/behaving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DisruptiveLabs/behaving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DisruptiveLabs/behaving/git/refs{/sha}","trees_url":"https://api.github.com/repos/DisruptiveLabs/behaving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DisruptiveLabs/behaving/statuses/{sha}","languages_url":"https://api.github.com/repos/DisruptiveLabs/behaving/languages","stargazers_url":"https://api.github.com/repos/DisruptiveLabs/behaving/stargazers","contributors_url":"https://api.github.com/repos/DisruptiveLabs/behaving/contributors","subscribers_url":"https://api.github.com/repos/DisruptiveLabs/behaving/subscribers","subscription_url":"https://api.github.com/repos/DisruptiveLabs/behaving/subscription","commits_url":"https://api.github.com/repos/DisruptiveLabs/behaving/commits{/sha}","git_commits_url":"https://api.github.com/repos/DisruptiveLabs/behaving/git/commits{/sha}","comments_url":"https://api.github.com/repos/DisruptiveLabs/behaving/comments{/number}","issue_comment_url":"https://api.github.com/repos/DisruptiveLabs/behaving/issues/comments{/number}","contents_url":"https://api.github.com/repos/DisruptiveLabs/behaving/contents/{+path}","compare_url":"https://api.github.com/repos/DisruptiveLabs/behaving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DisruptiveLabs/behaving/merges","archive_url":"https://api.github.com/repos/DisruptiveLabs/behaving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DisruptiveLabs/behaving/downloads","issues_url":"https://api.github.com/repos/DisruptiveLabs/behaving/issues{/number}","pulls_url":"https://api.github.com/repos/DisruptiveLabs/behaving/pulls{/number}","milestones_url":"https://api.github.com/repos/DisruptiveLabs/behaving/milestones{/number}","notifications_url":"https://api.github.com/repos/DisruptiveLabs/behaving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DisruptiveLabs/behaving/labels{/name}","releases_url":"https://api.github.com/repos/DisruptiveLabs/behaving/releases{/id}","deployments_url":"https://api.github.com/repos/DisruptiveLabs/behaving/deployments","created_at":"2014-02-05T20:57:13Z","updated_at":"2015-04-23T15:35:20Z","pushed_at":"2016-09-09T16:59:07Z","git_url":"git://github.com/DisruptiveLabs/behaving.git","ssh_url":"git@github.com:DisruptiveLabs/behaving.git","clone_url":"https://github.com/DisruptiveLabs/behaving.git","svn_url":"https://github.com/DisruptiveLabs/behaving","homepage":null,"size":1276,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ggozad:master","ref":"master","sha":"4c9578d2beda8d64a8660819dd3dd8ae977b1af6","user":{"login":"ggozad","id":183103,"avatar_url":"https://avatars.githubusercontent.com/u/183103?v=3","gravatar_id":"","url":"https://api.github.com/users/ggozad","html_url":"https://github.com/ggozad","followers_url":"https://api.github.com/users/ggozad/followers","following_url":"https://api.github.com/users/ggozad/following{/other_user}","gists_url":"https://api.github.com/users/ggozad/gists{/gist_id}","starred_url":"https://api.github.com/users/ggozad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggozad/subscriptions","organizations_url":"https://api.github.com/users/ggozad/orgs","repos_url":"https://api.github.com/users/ggozad/repos","events_url":"https://api.github.com/users/ggozad/events{/privacy}","received_events_url":"https://api.github.com/users/ggozad/received_events","type":"User","site_admin":false},"repo":{"id":9316339,"name":"behaving","full_name":"ggozad/behaving","owner":{"login":"ggozad","id":183103,"avatar_url":"https://avatars.githubusercontent.com/u/183103?v=3","gravatar_id":"","url":"https://api.github.com/users/ggozad","html_url":"https://github.com/ggozad","followers_url":"https://api.github.com/users/ggozad/followers","following_url":"https://api.github.com/users/ggozad/following{/other_user}","gists_url":"https://api.github.com/users/ggozad/gists{/gist_id}","starred_url":"https://api.github.com/users/ggozad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggozad/subscriptions","organizations_url":"https://api.github.com/users/ggozad/orgs","repos_url":"https://api.github.com/users/ggozad/repos","events_url":"https://api.github.com/users/ggozad/events{/privacy}","received_events_url":"https://api.github.com/users/ggozad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggozad/behaving","description":"Behavior-Driver-Development for multi-user web/email/sms applications","fork":false,"url":"https://api.github.com/repos/ggozad/behaving","forks_url":"https://api.github.com/repos/ggozad/behaving/forks","keys_url":"https://api.github.com/repos/ggozad/behaving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggozad/behaving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggozad/behaving/teams","hooks_url":"https://api.github.com/repos/ggozad/behaving/hooks","issue_events_url":"https://api.github.com/repos/ggozad/behaving/issues/events{/number}","events_url":"https://api.github.com/repos/ggozad/behaving/events","assignees_url":"https://api.github.com/repos/ggozad/behaving/assignees{/user}","branches_url":"https://api.github.com/repos/ggozad/behaving/branches{/branch}","tags_url":"https://api.github.com/repos/ggozad/behaving/tags","blobs_url":"https://api.github.com/repos/ggozad/behaving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggozad/behaving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggozad/behaving/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggozad/behaving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggozad/behaving/statuses/{sha}","languages_url":"https://api.github.com/repos/ggozad/behaving/languages","stargazers_url":"https://api.github.com/repos/ggozad/behaving/stargazers","contributors_url":"https://api.github.com/repos/ggozad/behaving/contributors","subscribers_url":"https://api.github.com/repos/ggozad/behaving/subscribers","subscription_url":"https://api.github.com/repos/ggozad/behaving/subscription","commits_url":"https://api.github.com/repos/ggozad/behaving/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggozad/behaving/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggozad/behaving/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggozad/behaving/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggozad/behaving/contents/{+path}","compare_url":"https://api.github.com/repos/ggozad/behaving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggozad/behaving/merges","archive_url":"https://api.github.com/repos/ggozad/behaving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggozad/behaving/downloads","issues_url":"https://api.github.com/repos/ggozad/behaving/issues{/number}","pulls_url":"https://api.github.com/repos/ggozad/behaving/pulls{/number}","milestones_url":"https://api.github.com/repos/ggozad/behaving/milestones{/number}","notifications_url":"https://api.github.com/repos/ggozad/behaving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggozad/behaving/labels{/name}","releases_url":"https://api.github.com/repos/ggozad/behaving/releases{/id}","deployments_url":"https://api.github.com/repos/ggozad/behaving/deployments","created_at":"2013-04-09T08:19:26Z","updated_at":"2016-08-22T13:05:04Z","pushed_at":"2016-09-09T17:26:19Z","git_url":"git://github.com/ggozad/behaving.git","ssh_url":"git@github.com:ggozad/behaving.git","clone_url":"https://github.com/ggozad/behaving.git","svn_url":"https://github.com/ggozad/behaving","homepage":null,"size":1493,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ggozad/behaving/pulls/64"},"html":{"href":"https://github.com/ggozad/behaving/pull/64"},"issue":{"href":"https://api.github.com/repos/ggozad/behaving/issues/64"},"comments":{"href":"https://api.github.com/repos/ggozad/behaving/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/ggozad/behaving/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/ggozad/behaving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ggozad/behaving/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/ggozad/behaving/statuses/07fcec2c822e856fc617f25caa2c8cb169b5add3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"kageurufu"}}