{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82845826","pull_request_review_id":3724272,"id":82845826,"diff_hunk":"@@ -231,6 +231,19 @@ skein_mod_init(void)\n \n int\n skein_mod_fini(void) {\n+\tint ret;\n+\n+\tif (skein_prov_handle != 0) {\n+\t\tif ((ret = crypto_unregister_provider(skein_prov_handle)) !=\n+\t\t    CRYPTO_SUCCESS) {","path":"module/icp/io/skein_mod.c","position":8,"original_position":8,"commit_id":"dd3310577a886108f6357bc41dc205da923ef732","original_commit_id":"dd3310577a886108f6357bc41dc205da923ef732","user":{"login":"tcaputi","id":1920053,"avatar_url":"https://avatars.githubusercontent.com/u/1920053?v=3","gravatar_id":"","url":"https://api.github.com/users/tcaputi","html_url":"https://github.com/tcaputi","followers_url":"https://api.github.com/users/tcaputi/followers","following_url":"https://api.github.com/users/tcaputi/following{/other_user}","gists_url":"https://api.github.com/users/tcaputi/gists{/gist_id}","starred_url":"https://api.github.com/users/tcaputi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcaputi/subscriptions","organizations_url":"https://api.github.com/users/tcaputi/orgs","repos_url":"https://api.github.com/users/tcaputi/repos","events_url":"https://api.github.com/users/tcaputi/events{/privacy}","received_events_url":"https://api.github.com/users/tcaputi/received_events","type":"User","site_admin":false},"body":"I styled the code like this in order to match the existing code of Illumos's KCF (and therefore the rest of the ICP). For instance, [here ](https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/crypto/io/sha2_mod.c#L226-L241) is the `_init()` code from Illumos's sha2_mod.c. Would you still like me to change it?","created_at":"2016-10-11T17:29:49Z","updated_at":"2016-10-11T17:29:49Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5265#discussion_r82845826","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82845826"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5265#discussion_r82845826"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265","id":88870212,"html_url":"https://github.com/zfsonlinux/zfs/pull/5265","diff_url":"https://github.com/zfsonlinux/zfs/pull/5265.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5265.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5265","number":5265,"state":"open","locked":false,"title":"Fixing ICP memleak introduced in #4760","user":{"login":"tcaputi","id":1920053,"avatar_url":"https://avatars.githubusercontent.com/u/1920053?v=3","gravatar_id":"","url":"https://api.github.com/users/tcaputi","html_url":"https://github.com/tcaputi","followers_url":"https://api.github.com/users/tcaputi/followers","following_url":"https://api.github.com/users/tcaputi/following{/other_user}","gists_url":"https://api.github.com/users/tcaputi/gists{/gist_id}","starred_url":"https://api.github.com/users/tcaputi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcaputi/subscriptions","organizations_url":"https://api.github.com/users/tcaputi/orgs","repos_url":"https://api.github.com/users/tcaputi/repos","events_url":"https://api.github.com/users/tcaputi/events{/privacy}","received_events_url":"https://api.github.com/users/tcaputi/received_events","type":"User","site_admin":false},"body":"The ICP requires destructors to for each crypto module that is added.\r\nThese do not necessarily exist in Illumos because they assume that\r\nthese modules can never be unloaded from the kernel. Some of this\r\ncleanup code was missed when #4760 was merged, resulting in leaks.\r\nThis patch simply fixes that.","created_at":"2016-10-11T16:54:21Z","updated_at":"2016-10-11T17:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b00b804903c078056fc7c4095614378aef56459e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5265/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/dd3310577a886108f6357bc41dc205da923ef732","head":{"label":"tcaputi:icp_memleak","ref":"icp_memleak","sha":"dd3310577a886108f6357bc41dc205da923ef732","user":{"login":"tcaputi","id":1920053,"avatar_url":"https://avatars.githubusercontent.com/u/1920053?v=3","gravatar_id":"","url":"https://api.github.com/users/tcaputi","html_url":"https://github.com/tcaputi","followers_url":"https://api.github.com/users/tcaputi/followers","following_url":"https://api.github.com/users/tcaputi/following{/other_user}","gists_url":"https://api.github.com/users/tcaputi/gists{/gist_id}","starred_url":"https://api.github.com/users/tcaputi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcaputi/subscriptions","organizations_url":"https://api.github.com/users/tcaputi/orgs","repos_url":"https://api.github.com/users/tcaputi/repos","events_url":"https://api.github.com/users/tcaputi/events{/privacy}","received_events_url":"https://api.github.com/users/tcaputi/received_events","type":"User","site_admin":false},"repo":{"id":47715883,"name":"zfs","full_name":"tcaputi/zfs","owner":{"login":"tcaputi","id":1920053,"avatar_url":"https://avatars.githubusercontent.com/u/1920053?v=3","gravatar_id":"","url":"https://api.github.com/users/tcaputi","html_url":"https://github.com/tcaputi","followers_url":"https://api.github.com/users/tcaputi/followers","following_url":"https://api.github.com/users/tcaputi/following{/other_user}","gists_url":"https://api.github.com/users/tcaputi/gists{/gist_id}","starred_url":"https://api.github.com/users/tcaputi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcaputi/subscriptions","organizations_url":"https://api.github.com/users/tcaputi/orgs","repos_url":"https://api.github.com/users/tcaputi/repos","events_url":"https://api.github.com/users/tcaputi/events{/privacy}","received_events_url":"https://api.github.com/users/tcaputi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcaputi/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/tcaputi/zfs","forks_url":"https://api.github.com/repos/tcaputi/zfs/forks","keys_url":"https://api.github.com/repos/tcaputi/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcaputi/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcaputi/zfs/teams","hooks_url":"https://api.github.com/repos/tcaputi/zfs/hooks","issue_events_url":"https://api.github.com/repos/tcaputi/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/tcaputi/zfs/events","assignees_url":"https://api.github.com/repos/tcaputi/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/tcaputi/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/tcaputi/zfs/tags","blobs_url":"https://api.github.com/repos/tcaputi/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcaputi/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcaputi/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcaputi/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcaputi/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/tcaputi/zfs/languages","stargazers_url":"https://api.github.com/repos/tcaputi/zfs/stargazers","contributors_url":"https://api.github.com/repos/tcaputi/zfs/contributors","subscribers_url":"https://api.github.com/repos/tcaputi/zfs/subscribers","subscription_url":"https://api.github.com/repos/tcaputi/zfs/subscription","commits_url":"https://api.github.com/repos/tcaputi/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcaputi/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcaputi/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcaputi/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcaputi/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/tcaputi/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcaputi/zfs/merges","archive_url":"https://api.github.com/repos/tcaputi/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcaputi/zfs/downloads","issues_url":"https://api.github.com/repos/tcaputi/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/tcaputi/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/tcaputi/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/tcaputi/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcaputi/zfs/labels{/name}","releases_url":"https://api.github.com/repos/tcaputi/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/tcaputi/zfs/deployments","created_at":"2015-12-09T20:08:08Z","updated_at":"2016-02-06T01:00:15Z","pushed_at":"2016-10-11T16:53:14Z","git_url":"git://github.com/tcaputi/zfs.git","ssh_url":"git@github.com:tcaputi/zfs.git","clone_url":"https://github.com/tcaputi/zfs.git","svn_url":"https://github.com/tcaputi/zfs","homepage":"http://zfsonlinux.org/","size":33088,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"52f1fe3cfd35b9414568046ad7456bfbc80a9354","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-10-11T01:46:28Z","pushed_at":"2016-10-11T17:24:18Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":60316,"stargazers_count":2082,"watchers_count":2082,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"open_issues_count":978,"forks":520,"open_issues":978,"watchers":2082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5265"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5265"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5265/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5265/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/dd3310577a886108f6357bc41dc205da923ef732"}}}}
{"actor":{"display_login":"tcaputi"}}