{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/comments/61085177","id":61085177,"diff_hunk":"@@ -540,33 +540,33 @@ namespace GLTF\n         shared_ptr <GLTF::JSONObject> accessors = asset->root()->createObjectIfNeeded(kAccessors);\n         shared_ptr<JSONObject> parameter(new JSONObject());\n         unsigned int glType = profile->getGLenumForString(parameterType);\n-        parameter->setUnsignedInt32(\"count\", cvtAnimation->getCount());\n+        parameter->setUnsignedInt32(\"count\", (int)cvtAnimation->getCount());\n         parameter->setString(kType, profile->getTypeForGLType(glType));\n         parameter->setUnsignedInt32(kComponentType, profile->getGLComponentTypeForGLType(glType));\n \n         accessors->setValue(accessorUID, parameter);\n         cvtAnimation->parameters()->setString(parameterSID, accessorUID);\n         \n         //write\n-        size_t byteOffset = 0;\n+        int byteOffset = 0;\n         bool shouldEncodeOpen3DGC = CONFIG_STRING(asset, \"compressionType\")  == \"Open3DGC\";\n         GLTFOutputStream *outputStream = shouldEncodeOpen3DGC ? asset->createOutputStreamIfNeeded(kCompressionOutputStream).get() : asset->createOutputStreamIfNeeded(asset->getSharedBufferId()).get();;\n-        byteOffset = outputStream->length();\n+        byteOffset = (int)outputStream->length();\n         parameter->setUnsignedInt32(\"byteOffset\", byteOffset);\n         \n         if (shouldEncodeOpen3DGC) {\n-            size_t componentsCount = profile->getComponentsCountForType(parameter->getString(kType));\n+            long componentsCount = (long)profile->getComponentsCountForType(parameter->getString(kType));","path":"COLLADA2GLTF/extensions/o3dgc-compression/GLTF-Open3DGC.cpp","position":70,"original_position":70,"commit_id":"66cbb417d8c8d7cf15e7c833708e97131afb4566","original_commit_id":"66cbb417d8c8d7cf15e7c833708e97131afb4566","user":{"login":"lasalvavida","id":2489570,"avatar_url":"https://avatars.githubusercontent.com/u/2489570?v=3","gravatar_id":"","url":"https://api.github.com/users/lasalvavida","html_url":"https://github.com/lasalvavida","followers_url":"https://api.github.com/users/lasalvavida/followers","following_url":"https://api.github.com/users/lasalvavida/following{/other_user}","gists_url":"https://api.github.com/users/lasalvavida/gists{/gist_id}","starred_url":"https://api.github.com/users/lasalvavida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasalvavida/subscriptions","organizations_url":"https://api.github.com/users/lasalvavida/orgs","repos_url":"https://api.github.com/users/lasalvavida/repos","events_url":"https://api.github.com/users/lasalvavida/events{/privacy}","received_events_url":"https://api.github.com/users/lasalvavida/received_events","type":"User","site_admin":false},"body":"This is size_t -> long, you shouldn't need a cast","created_at":"2016-04-26T13:32:42Z","updated_at":"2016-04-26T13:32:42Z","html_url":"https://github.com/KhronosGroup/glTF/pull/577#discussion_r61085177","pull_request_url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/comments/61085177"},"html":{"href":"https://github.com/KhronosGroup/glTF/pull/577#discussion_r61085177"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577","id":67745134,"html_url":"https://github.com/KhronosGroup/glTF/pull/577","diff_url":"https://github.com/KhronosGroup/glTF/pull/577.diff","patch_url":"https://github.com/KhronosGroup/glTF/pull/577.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/577","number":577,"state":"open","locked":false,"title":"Fixed warnings when building","user":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"body":"For #199 \r\n\r\nFixed trivial warnings. Still need to fix four more `C4503` warnings.","created_at":"2016-04-25T16:02:55Z","updated_at":"2016-04-26T13:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43faa2cb897e309c2a557d12d9036f5ff9b70867","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glTF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/577/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glTF/statuses/66cbb417d8c8d7cf15e7c833708e97131afb4566","head":{"label":"TomPed:fix-warnings","ref":"fix-warnings","sha":"66cbb417d8c8d7cf15e7c833708e97131afb4566","user":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"repo":{"id":57048139,"name":"glTF","full_name":"TomPed/glTF","owner":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomPed/glTF","description":"glTF - the runtime asset format for WebGL, OpenGL ES, and OpenGL.","fork":true,"url":"https://api.github.com/repos/TomPed/glTF","forks_url":"https://api.github.com/repos/TomPed/glTF/forks","keys_url":"https://api.github.com/repos/TomPed/glTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomPed/glTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomPed/glTF/teams","hooks_url":"https://api.github.com/repos/TomPed/glTF/hooks","issue_events_url":"https://api.github.com/repos/TomPed/glTF/issues/events{/number}","events_url":"https://api.github.com/repos/TomPed/glTF/events","assignees_url":"https://api.github.com/repos/TomPed/glTF/assignees{/user}","branches_url":"https://api.github.com/repos/TomPed/glTF/branches{/branch}","tags_url":"https://api.github.com/repos/TomPed/glTF/tags","blobs_url":"https://api.github.com/repos/TomPed/glTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomPed/glTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomPed/glTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomPed/glTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomPed/glTF/statuses/{sha}","languages_url":"https://api.github.com/repos/TomPed/glTF/languages","stargazers_url":"https://api.github.com/repos/TomPed/glTF/stargazers","contributors_url":"https://api.github.com/repos/TomPed/glTF/contributors","subscribers_url":"https://api.github.com/repos/TomPed/glTF/subscribers","subscription_url":"https://api.github.com/repos/TomPed/glTF/subscription","commits_url":"https://api.github.com/repos/TomPed/glTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomPed/glTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomPed/glTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomPed/glTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomPed/glTF/contents/{+path}","compare_url":"https://api.github.com/repos/TomPed/glTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomPed/glTF/merges","archive_url":"https://api.github.com/repos/TomPed/glTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomPed/glTF/downloads","issues_url":"https://api.github.com/repos/TomPed/glTF/issues{/number}","pulls_url":"https://api.github.com/repos/TomPed/glTF/pulls{/number}","milestones_url":"https://api.github.com/repos/TomPed/glTF/milestones{/number}","notifications_url":"https://api.github.com/repos/TomPed/glTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomPed/glTF/labels{/name}","releases_url":"https://api.github.com/repos/TomPed/glTF/releases{/id}","deployments_url":"https://api.github.com/repos/TomPed/glTF/deployments","created_at":"2016-04-25T14:24:16Z","updated_at":"2016-04-25T14:24:23Z","pushed_at":"2016-04-25T21:08:51Z","git_url":"git://github.com/TomPed/glTF.git","ssh_url":"git@github.com:TomPed/glTF.git","clone_url":"https://github.com/TomPed/glTF.git","svn_url":"https://github.com/TomPed/glTF","homepage":"","size":117814,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"eca3e692b35318ef15cb55f337e2bb0795064d4f","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":7921466,"name":"glTF","full_name":"KhronosGroup/glTF","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glTF","description":"glTF - the runtime asset format for WebGL, OpenGL ES, and OpenGL.","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glTF","forks_url":"https://api.github.com/repos/KhronosGroup/glTF/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glTF/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glTF/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glTF/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glTF/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glTF/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glTF/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glTF/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glTF/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glTF/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glTF/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glTF/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glTF/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glTF/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glTF/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glTF/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glTF/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glTF/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glTF/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glTF/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glTF/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/glTF/deployments","created_at":"2013-01-30T19:01:11Z","updated_at":"2016-04-24T21:55:09Z","pushed_at":"2016-04-25T21:08:51Z","git_url":"git://github.com/KhronosGroup/glTF.git","ssh_url":"git@github.com:KhronosGroup/glTF.git","clone_url":"https://github.com/KhronosGroup/glTF.git","svn_url":"https://github.com/KhronosGroup/glTF","homepage":"","size":130725,"stargazers_count":636,"watchers_count":636,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":141,"mirror_url":null,"open_issues_count":128,"forks":141,"open_issues":128,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577"},"html":{"href":"https://github.com/KhronosGroup/glTF/pull/577"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glTF/issues/577"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glTF/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glTF/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glTF/statuses/66cbb417d8c8d7cf15e7c833708e97131afb4566"}}}}