{"action":"closed","number":400,"pull_request":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400","id":63883189,"html_url":"https://github.com/theforeman/smart-proxy/pull/400","diff_url":"https://github.com/theforeman/smart-proxy/pull/400.diff","patch_url":"https://github.com/theforeman/smart-proxy/pull/400.patch","issue_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/400","number":400,"state":"closed","locked":false,"title":"Fixes #13552: Validate DNS names passsed to the DNS API","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"Includes https://github.com/theforeman/smart-proxy/pull/399 because they modify the same code and splitting them and then merging is a lot of useless work.","created_at":"2016-03-23T13:42:10Z","updated_at":"2016-03-24T15:35:39Z","closed_at":"2016-03-24T15:35:39Z","merged_at":null,"merge_commit_sha":"4f183c4ec7d6ee190cd48e2246d99d89c4d6fa71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400/commits","review_comments_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400/comments","review_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/400/comments","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/f36e111ab8a5a5718310b6cb24b91a785dc7e0c1","head":{"label":"ekohl:133552-dns-api-dns-name-validation","ref":"133552-dns-api-dns-name-validation","sha":"f36e111ab8a5a5718310b6cb24b91a785dc7e0c1","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"repo":{"id":10153129,"name":"smart-proxy","full_name":"ekohl/smart-proxy","owner":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekohl/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP and Puppet","fork":true,"url":"https://api.github.com/repos/ekohl/smart-proxy","forks_url":"https://api.github.com/repos/ekohl/smart-proxy/forks","keys_url":"https://api.github.com/repos/ekohl/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekohl/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekohl/smart-proxy/teams","hooks_url":"https://api.github.com/repos/ekohl/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/ekohl/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/ekohl/smart-proxy/events","assignees_url":"https://api.github.com/repos/ekohl/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/ekohl/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/ekohl/smart-proxy/tags","blobs_url":"https://api.github.com/repos/ekohl/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekohl/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekohl/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekohl/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekohl/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/ekohl/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/ekohl/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/ekohl/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/ekohl/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/ekohl/smart-proxy/subscription","commits_url":"https://api.github.com/repos/ekohl/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekohl/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekohl/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekohl/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekohl/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/ekohl/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekohl/smart-proxy/merges","archive_url":"https://api.github.com/repos/ekohl/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekohl/smart-proxy/downloads","issues_url":"https://api.github.com/repos/ekohl/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/ekohl/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/ekohl/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/ekohl/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekohl/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/ekohl/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/ekohl/smart-proxy/deployments","created_at":"2013-05-19T08:55:49Z","updated_at":"2013-12-09T17:12:36Z","pushed_at":"2016-03-24T11:46:57Z","git_url":"git://github.com/ekohl/smart-proxy.git","ssh_url":"git@github.com:ekohl/smart-proxy.git","clone_url":"https://github.com/ekohl/smart-proxy.git","svn_url":"https://github.com/ekohl/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1088,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"b85ad0e5ae3bbe8bb80872eba041f2a7cc71952a","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":986551,"name":"smart-proxy","full_name":"theforeman/smart-proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP, BMC and Puppet","fork":false,"url":"https://api.github.com/repos/theforeman/smart-proxy","forks_url":"https://api.github.com/repos/theforeman/smart-proxy/forks","keys_url":"https://api.github.com/repos/theforeman/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/smart-proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/smart-proxy/events","assignees_url":"https://api.github.com/repos/theforeman/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/smart-proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/smart-proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/smart-proxy/merges","archive_url":"https://api.github.com/repos/theforeman/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/smart-proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/smart-proxy/deployments","created_at":"2010-10-14T10:00:51Z","updated_at":"2016-03-17T17:01:40Z","pushed_at":"2016-03-24T15:34:50Z","git_url":"git://github.com/theforeman/smart-proxy.git","ssh_url":"git@github.com:theforeman/smart-proxy.git","clone_url":"https://github.com/theforeman/smart-proxy.git","svn_url":"https://github.com/theforeman/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1902,"stargazers_count":126,"watchers_count":126,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":22,"forks":153,"open_issues":22,"watchers":126,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/400"},"issue":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/400"},"comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/smart-proxy/statuses/f36e111ab8a5a5718310b6cb24b91a785dc7e0c1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":3,"commits":1,"additions":45,"deletions":3,"changed_files":2}}