{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit-console/issues/141","repository_url":"https://api.github.com/repos/nunit/nunit-console","labels_url":"https://api.github.com/repos/nunit/nunit-console/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit-console/issues/141/comments","events_url":"https://api.github.com/repos/nunit/nunit-console/issues/141/events","html_url":"https://github.com/nunit/nunit-console/pull/141","id":193307170,"number":141,"title":"Fix problem with parallel loading and limitations on number of agents","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-03T19:00:00Z","updated_at":"2016-12-04T22:01:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit-console/pulls/141","html_url":"https://github.com/nunit/nunit-console/pull/141","diff_url":"https://github.com/nunit/nunit-console/pull/141.diff","patch_url":"https://github.com/nunit/nunit-console/pull/141.patch"},"body":"A problem crept into the engine causing all assemblies to be loaded as soon as the MasterTestRunner was created. Of course, this causes all processes to be created at once, in spite of any limitation the user may have set with the `--agents` option.\r\n\r\nAfter removing the offending line of code, I discovered that there were random failures occuring because of threading issues in RuntimeFramework. This will need a lot of work at some time, so I added an explanatory comment to RuntimeFramework. For the moment, the hack I added to RuntimeFrameworkService prevents the problem from occuring by forcing RuntimeFramework to initialize the list of available frameworks early enough that it's ready for use when multiple threads start trying to access it.\r\n\r\n@chris-smith-zocdoc This is the fix you will want to have in your own PR. Since you are set up to test the situation of loading multiple assemblies in parallel, could you pull this and try it out? I have been running with only two processes and various command-line options. I haven't seen the exception thrown for the last dozen or so runs, so I'm fairly confident, but it's hard to test a negative!\r\n"},"comment":{"url":"https://api.github.com/repos/nunit/nunit-console/issues/comments/264734943","html_url":"https://github.com/nunit/nunit-console/pull/141#issuecomment-264734943","issue_url":"https://api.github.com/repos/nunit/nunit-console/issues/141","id":264734943,"user":{"login":"chris-smith-zocdoc","id":2537809,"avatar_url":"https://avatars.githubusercontent.com/u/2537809?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith-zocdoc","html_url":"https://github.com/chris-smith-zocdoc","followers_url":"https://api.github.com/users/chris-smith-zocdoc/followers","following_url":"https://api.github.com/users/chris-smith-zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith-zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith-zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith-zocdoc/subscriptions","organizations_url":"https://api.github.com/users/chris-smith-zocdoc/orgs","repos_url":"https://api.github.com/users/chris-smith-zocdoc/repos","events_url":"https://api.github.com/users/chris-smith-zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith-zocdoc/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T22:01:07Z","updated_at":"2016-12-04T22:01:07Z","body":"Ran it constantly for the last couple hours, no issues"}}
{"actor":{"display_login":"chris-smith-zocdoc"}}