{"action":"created","comment":{"url":"https://api.github.com/repos/AnHardt/Marlin/pulls/comments/68338694","id":68338694,"diff_hunk":"@@ -1906,13 +1907,16 @@ static void clean_up_after_endstop_or_probe_move() {\n \n     if (!endstops.z_probe_enabled) return;\n \n+    // Make room for the probe\n+    do_probe_raise(Z_RAISE_BETWEEN_PROBINGS);","path":"Marlin/Marlin_main.cpp","position":106,"original_position":106,"commit_id":"baa188bc60fd6df0c3a528632d65c85acdb60bf4","original_commit_id":"baa188bc60fd6df0c3a528632d65c85acdb60bf4","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"body":"Aha, the code is trying to be too clever. Actually I think this should work in all cases:\r\n```cpp\r\n// Adjust the current Z and send it to the planner.\r\ncurrent_position[Z_AXIS] += z_tmp - real_z;\r\nSYNC_PLAN_POSITION_KINEMATIC();\r\n```","created_at":"2016-06-24T00:34:50Z","updated_at":"2016-06-24T00:34:50Z","html_url":"https://github.com/AnHardt/Marlin/pull/48#discussion_r68338694","pull_request_url":"https://api.github.com/repos/AnHardt/Marlin/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/comments/68338694"},"html":{"href":"https://github.com/AnHardt/Marlin/pull/48#discussion_r68338694"},"pull_request":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/AnHardt/Marlin/pulls/48","id":74945074,"html_url":"https://github.com/AnHardt/Marlin/pull/48","diff_url":"https://github.com/AnHardt/Marlin/pull/48.diff","patch_url":"https://github.com/AnHardt/Marlin/pull/48.patch","issue_url":"https://api.github.com/repos/AnHardt/Marlin/issues/48","number":48,"state":"open","locked":false,"title":"Some more probe cleanup","user":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"body":"```diff\r\n-    if (probe_action & ProbeStow) {\r\n+    if (stow) {\r\n       stow_z_probe();\r\n     }\r\n+    else {\r\n+      do_probe_raise(max(current_position[Z_AXIS],Z_RAISE_BETWEEN_PROBINGS));\r\n+    }\r\n```\r\nis the key idea in `probe_pt()`.\r\nThe rest is more or less the concequences.\r\n\r\nAnd a simple servo tweak to prevent the probe from moving before the servo is at its target angle.\r\n\r\nNot very well tested.\r\n\r\nBest viewd with https://github.com/AnHardt/Marlin/pull/48/files?diff=unified?w=1","created_at":"2016-06-23T12:21:35Z","updated_at":"2016-06-24T00:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"111ca11faa650841a4ff691b7826e49dd229ee6d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnHardt/Marlin/pulls/48/commits","review_comments_url":"https://api.github.com/repos/AnHardt/Marlin/pulls/48/comments","review_comment_url":"https://api.github.com/repos/AnHardt/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnHardt/Marlin/issues/48/comments","statuses_url":"https://api.github.com/repos/AnHardt/Marlin/statuses/baa188bc60fd6df0c3a528632d65c85acdb60bf4","head":{"label":"AnHardt:more-probe-simplifications","ref":"more-probe-simplifications","sha":"baa188bc60fd6df0c3a528632d65c85acdb60bf4","user":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"repo":{"id":43525464,"name":"Marlin","full_name":"AnHardt/Marlin","owner":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnHardt/Marlin","description":"Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu","fork":true,"url":"https://api.github.com/repos/AnHardt/Marlin","forks_url":"https://api.github.com/repos/AnHardt/Marlin/forks","keys_url":"https://api.github.com/repos/AnHardt/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnHardt/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnHardt/Marlin/teams","hooks_url":"https://api.github.com/repos/AnHardt/Marlin/hooks","issue_events_url":"https://api.github.com/repos/AnHardt/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/AnHardt/Marlin/events","assignees_url":"https://api.github.com/repos/AnHardt/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/AnHardt/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/AnHardt/Marlin/tags","blobs_url":"https://api.github.com/repos/AnHardt/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnHardt/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnHardt/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnHardt/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnHardt/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/AnHardt/Marlin/languages","stargazers_url":"https://api.github.com/repos/AnHardt/Marlin/stargazers","contributors_url":"https://api.github.com/repos/AnHardt/Marlin/contributors","subscribers_url":"https://api.github.com/repos/AnHardt/Marlin/subscribers","subscription_url":"https://api.github.com/repos/AnHardt/Marlin/subscription","commits_url":"https://api.github.com/repos/AnHardt/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnHardt/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnHardt/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnHardt/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnHardt/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/AnHardt/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnHardt/Marlin/merges","archive_url":"https://api.github.com/repos/AnHardt/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnHardt/Marlin/downloads","issues_url":"https://api.github.com/repos/AnHardt/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/AnHardt/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/AnHardt/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/AnHardt/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnHardt/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/AnHardt/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/AnHardt/Marlin/deployments","created_at":"2015-10-01T22:54:37Z","updated_at":"2016-05-16T14:41:02Z","pushed_at":"2016-06-23T15:16:43Z","git_url":"git://github.com/AnHardt/Marlin.git","ssh_url":"git@github.com:AnHardt/Marlin.git","clone_url":"https://github.com/AnHardt/Marlin.git","svn_url":"https://github.com/AnHardt/Marlin","homepage":"","size":32170,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":1,"default_branch":"RCBugFix"}},"base":{"label":"AnHardt:RCBugFix","ref":"RCBugFix","sha":"61f34eec03323762f51dc6d7f29ff7934654911e","user":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"repo":{"id":43525464,"name":"Marlin","full_name":"AnHardt/Marlin","owner":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnHardt/Marlin","description":"Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu","fork":true,"url":"https://api.github.com/repos/AnHardt/Marlin","forks_url":"https://api.github.com/repos/AnHardt/Marlin/forks","keys_url":"https://api.github.com/repos/AnHardt/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnHardt/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnHardt/Marlin/teams","hooks_url":"https://api.github.com/repos/AnHardt/Marlin/hooks","issue_events_url":"https://api.github.com/repos/AnHardt/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/AnHardt/Marlin/events","assignees_url":"https://api.github.com/repos/AnHardt/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/AnHardt/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/AnHardt/Marlin/tags","blobs_url":"https://api.github.com/repos/AnHardt/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnHardt/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnHardt/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnHardt/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnHardt/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/AnHardt/Marlin/languages","stargazers_url":"https://api.github.com/repos/AnHardt/Marlin/stargazers","contributors_url":"https://api.github.com/repos/AnHardt/Marlin/contributors","subscribers_url":"https://api.github.com/repos/AnHardt/Marlin/subscribers","subscription_url":"https://api.github.com/repos/AnHardt/Marlin/subscription","commits_url":"https://api.github.com/repos/AnHardt/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnHardt/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnHardt/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnHardt/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnHardt/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/AnHardt/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnHardt/Marlin/merges","archive_url":"https://api.github.com/repos/AnHardt/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnHardt/Marlin/downloads","issues_url":"https://api.github.com/repos/AnHardt/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/AnHardt/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/AnHardt/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/AnHardt/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnHardt/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/AnHardt/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/AnHardt/Marlin/deployments","created_at":"2015-10-01T22:54:37Z","updated_at":"2016-05-16T14:41:02Z","pushed_at":"2016-06-23T15:16:43Z","git_url":"git://github.com/AnHardt/Marlin.git","ssh_url":"git@github.com:AnHardt/Marlin.git","clone_url":"https://github.com/AnHardt/Marlin.git","svn_url":"https://github.com/AnHardt/Marlin","homepage":"","size":32170,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":1,"default_branch":"RCBugFix"}},"_links":{"self":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/48"},"html":{"href":"https://github.com/AnHardt/Marlin/pull/48"},"issue":{"href":"https://api.github.com/repos/AnHardt/Marlin/issues/48"},"comments":{"href":"https://api.github.com/repos/AnHardt/Marlin/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnHardt/Marlin/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/AnHardt/Marlin/statuses/baa188bc60fd6df0c3a528632d65c85acdb60bf4"}}}}
{"actor":{"display_login":"thinkyhead"}}