{"action":"created","issue":{"url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/27","repository_url":"https://api.github.com/repos/auraphp/Aura.Intl","labels_url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/27/comments","events_url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/27/events","html_url":"https://github.com/auraphp/Aura.Intl/pull/27","id":157952460,"number":27,"title":"Making Translator's messages 'mutable'","user":{"login":"jhuet","id":372409,"avatar_url":"https://avatars.githubusercontent.com/u/372409?v=3","gravatar_id":"","url":"https://api.github.com/users/jhuet","html_url":"https://github.com/jhuet","followers_url":"https://api.github.com/users/jhuet/followers","following_url":"https://api.github.com/users/jhuet/following{/other_user}","gists_url":"https://api.github.com/users/jhuet/gists{/gist_id}","starred_url":"https://api.github.com/users/jhuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhuet/subscriptions","organizations_url":"https://api.github.com/users/jhuet/orgs","repos_url":"https://api.github.com/users/jhuet/repos","events_url":"https://api.github.com/users/jhuet/events{/privacy}","received_events_url":"https://api.github.com/users/jhuet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-01T16:35:48Z","updated_at":"2016-06-02T08:44:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/auraphp/Aura.Intl/pulls/27","html_url":"https://github.com/auraphp/Aura.Intl/pull/27","diff_url":"https://github.com/auraphp/Aura.Intl/pull/27.diff","patch_url":"https://github.com/auraphp/Aura.Intl/pull/27.patch"},"body":"Alright, this PR is more a proposal than anything else.\r\n\r\nIn my application i happen to only load translations \"template\" by template, thus i have a translation file by template. This means that i dynamically load translations at runtime depending on which template i need at that time.\r\n\r\nBecause of the way Aura.Intl is made, there is no way to change the messages once a Translator has been created, disallowing one to load more translation messages at runtime.\r\n\r\nIn order to fix this, i propose to make the Translator depending on a Package instance rather than its messages. We can then add new messages to the Package and the Translator will automatically have access to them.\r\n\r\nIs there any reason why the Translator was design this way in the 1st place ?"},"comment":{"url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/comments/223231408","html_url":"https://github.com/auraphp/Aura.Intl/pull/27#issuecomment-223231408","issue_url":"https://api.github.com/repos/auraphp/Aura.Intl/issues/27","id":223231408,"user":{"login":"jhuet","id":372409,"avatar_url":"https://avatars.githubusercontent.com/u/372409?v=3","gravatar_id":"","url":"https://api.github.com/users/jhuet","html_url":"https://github.com/jhuet","followers_url":"https://api.github.com/users/jhuet/followers","following_url":"https://api.github.com/users/jhuet/following{/other_user}","gists_url":"https://api.github.com/users/jhuet/gists{/gist_id}","starred_url":"https://api.github.com/users/jhuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhuet/subscriptions","organizations_url":"https://api.github.com/users/jhuet/orgs","repos_url":"https://api.github.com/users/jhuet/repos","events_url":"https://api.github.com/users/jhuet/events{/privacy}","received_events_url":"https://api.github.com/users/jhuet/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T08:44:14Z","updated_at":"2016-06-02T08:44:14Z","body":"> Probably the template should define different messages ?\r\n\r\nI'm not sure what you mean here. Or maybe you meant that it should define a different package ?"}}
{"actor":{"display_login":"jhuet"}}