{"action":"created","comment":{"url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/comments/83249019","pull_request_review_id":4104721,"id":83249019,"diff_hunk":"@@ -33,22 +33,28 @@ init([]) ->\n     ?CHILD(deliverly_server, worker),\n     ?CHILD(deliverly_nodes, worker)\n   ],\n-  RSizeArgs = [\n-    {size, 5},\n-    {max_overflow, 10}\n-  ],\n-  RPoolArgs = [\n-    {name, {local, ?R_POOL}},\n-    {worker_module, eredis}\n-  ] ++ RSizeArgs,\n-  RedisOpt = [\n-    {host, ulitos_app:get_var(?APP, redis_host, \"127.0.0.1\")},\n-    {port, ulitos_app:get_var(?APP, redis_port, 6379)},\n-    {database, ulitos_app:get_var(?APP, redis_database, 0)},\n-    {password, ulitos_app:get_var(?APP, redis_password, \"\")},\n-    {reconnect_sleep, ulitos_app:get_var(?APP, redis_reconnect_sleep, 100)},\n-    {connect_timeout, ulitos_app:get_var(?APP, redis_connect_timeout, 5000)}\n-  ],\n-  RPoolSpecs = [poolboy:child_spec(?R_POOL, RPoolArgs, RedisOpt)],\n+  RPoolSpecs = \n+    case ulitos_app:get_var(?APP, use_redis, true) of","path":"src/deliverly_sup.erl","position":22,"original_position":22,"commit_id":"e71e678617edf7a7c413d64b9dccf755dc509d27","original_commit_id":"e71e678617edf7a7c413d64b9dccf755dc509d27","user":{"login":"palkan","id":1516722,"avatar_url":"https://avatars.githubusercontent.com/u/1516722?v=3","gravatar_id":"","url":"https://api.github.com/users/palkan","html_url":"https://github.com/palkan","followers_url":"https://api.github.com/users/palkan/followers","following_url":"https://api.github.com/users/palkan/following{/other_user}","gists_url":"https://api.github.com/users/palkan/gists{/gist_id}","starred_url":"https://api.github.com/users/palkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palkan/subscriptions","organizations_url":"https://api.github.com/users/palkan/orgs","repos_url":"https://api.github.com/users/palkan/repos","events_url":"https://api.github.com/users/palkan/events{/privacy}","received_events_url":"https://api.github.com/users/palkan/received_events","type":"User","site_admin":false},"body":"Давай лучше так:\r\n\r\n```erlang\r\nRPoolSpecs = redis_pool_specs(?Config(user_redis, true),\r\n...\r\n```\r\n\r\nи\r\n\r\n```erlang\r\nredis_pool_specs(true) ->\r\n  ...,\r\n  [poolboy:child_spec(?R_POOL, RPoolArgs, RedisOpt)];\r\n\r\nredis_pool_specs(_) -> [].\r\n```","created_at":"2016-10-13T15:51:06Z","updated_at":"2016-10-13T15:51:11Z","html_url":"https://github.com/deliverly/deliverly-core/pull/7#discussion_r83249019","pull_request_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/comments/83249019"},"html":{"href":"https://github.com/deliverly/deliverly-core/pull/7#discussion_r83249019"},"pull_request":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7","id":89223670,"html_url":"https://github.com/deliverly/deliverly-core/pull/7","diff_url":"https://github.com/deliverly/deliverly-core/pull/7.diff","patch_url":"https://github.com/deliverly/deliverly-core/pull/7.patch","issue_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/7","number":7,"state":"open","locked":false,"title":"Add flag to use redis","user":{"login":"silkbottle","id":4836648,"avatar_url":"https://avatars.githubusercontent.com/u/4836648?v=3","gravatar_id":"","url":"https://api.github.com/users/silkbottle","html_url":"https://github.com/silkbottle","followers_url":"https://api.github.com/users/silkbottle/followers","following_url":"https://api.github.com/users/silkbottle/following{/other_user}","gists_url":"https://api.github.com/users/silkbottle/gists{/gist_id}","starred_url":"https://api.github.com/users/silkbottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silkbottle/subscriptions","organizations_url":"https://api.github.com/users/silkbottle/orgs","repos_url":"https://api.github.com/users/silkbottle/repos","events_url":"https://api.github.com/users/silkbottle/events{/privacy}","received_events_url":"https://api.github.com/users/silkbottle/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-13T15:18:14Z","updated_at":"2016-10-13T15:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84ea3be66a1fb0bb855210ac76c967e0ce8e183f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7/commits","review_comments_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7/comments","review_comment_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/7/comments","statuses_url":"https://api.github.com/repos/deliverly/deliverly-core/statuses/e71e678617edf7a7c413d64b9dccf755dc509d27","head":{"label":"deliverly:optional-redis","ref":"optional-redis","sha":"e71e678617edf7a7c413d64b9dccf755dc509d27","user":{"login":"deliverly","id":10158986,"avatar_url":"https://avatars.githubusercontent.com/u/10158986?v=3","gravatar_id":"","url":"https://api.github.com/users/deliverly","html_url":"https://github.com/deliverly","followers_url":"https://api.github.com/users/deliverly/followers","following_url":"https://api.github.com/users/deliverly/following{/other_user}","gists_url":"https://api.github.com/users/deliverly/gists{/gist_id}","starred_url":"https://api.github.com/users/deliverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliverly/subscriptions","organizations_url":"https://api.github.com/users/deliverly/orgs","repos_url":"https://api.github.com/users/deliverly/repos","events_url":"https://api.github.com/users/deliverly/events{/privacy}","received_events_url":"https://api.github.com/users/deliverly/received_events","type":"Organization","site_admin":false},"repo":{"id":28183809,"name":"deliverly-core","full_name":"deliverly/deliverly-core","owner":{"login":"deliverly","id":10158986,"avatar_url":"https://avatars.githubusercontent.com/u/10158986?v=3","gravatar_id":"","url":"https://api.github.com/users/deliverly","html_url":"https://github.com/deliverly","followers_url":"https://api.github.com/users/deliverly/followers","following_url":"https://api.github.com/users/deliverly/following{/other_user}","gists_url":"https://api.github.com/users/deliverly/gists{/gist_id}","starred_url":"https://api.github.com/users/deliverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliverly/subscriptions","organizations_url":"https://api.github.com/users/deliverly/orgs","repos_url":"https://api.github.com/users/deliverly/repos","events_url":"https://api.github.com/users/deliverly/events{/privacy}","received_events_url":"https://api.github.com/users/deliverly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deliverly/deliverly-core","description":"Core DelivErly app","fork":false,"url":"https://api.github.com/repos/deliverly/deliverly-core","forks_url":"https://api.github.com/repos/deliverly/deliverly-core/forks","keys_url":"https://api.github.com/repos/deliverly/deliverly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deliverly/deliverly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deliverly/deliverly-core/teams","hooks_url":"https://api.github.com/repos/deliverly/deliverly-core/hooks","issue_events_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/events{/number}","events_url":"https://api.github.com/repos/deliverly/deliverly-core/events","assignees_url":"https://api.github.com/repos/deliverly/deliverly-core/assignees{/user}","branches_url":"https://api.github.com/repos/deliverly/deliverly-core/branches{/branch}","tags_url":"https://api.github.com/repos/deliverly/deliverly-core/tags","blobs_url":"https://api.github.com/repos/deliverly/deliverly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deliverly/deliverly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deliverly/deliverly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/deliverly/deliverly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deliverly/deliverly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/deliverly/deliverly-core/languages","stargazers_url":"https://api.github.com/repos/deliverly/deliverly-core/stargazers","contributors_url":"https://api.github.com/repos/deliverly/deliverly-core/contributors","subscribers_url":"https://api.github.com/repos/deliverly/deliverly-core/subscribers","subscription_url":"https://api.github.com/repos/deliverly/deliverly-core/subscription","commits_url":"https://api.github.com/repos/deliverly/deliverly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/deliverly/deliverly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/deliverly/deliverly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/deliverly/deliverly-core/contents/{+path}","compare_url":"https://api.github.com/repos/deliverly/deliverly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deliverly/deliverly-core/merges","archive_url":"https://api.github.com/repos/deliverly/deliverly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deliverly/deliverly-core/downloads","issues_url":"https://api.github.com/repos/deliverly/deliverly-core/issues{/number}","pulls_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/deliverly/deliverly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/deliverly/deliverly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deliverly/deliverly-core/labels{/name}","releases_url":"https://api.github.com/repos/deliverly/deliverly-core/releases{/id}","deployments_url":"https://api.github.com/repos/deliverly/deliverly-core/deployments","created_at":"2014-12-18T13:04:33Z","updated_at":"2016-07-07T15:34:38Z","pushed_at":"2016-10-13T15:18:15Z","git_url":"git://github.com/deliverly/deliverly-core.git","ssh_url":"git@github.com:deliverly/deliverly-core.git","clone_url":"https://github.com/deliverly/deliverly-core.git","svn_url":"https://github.com/deliverly/deliverly-core","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"deliverly:master","ref":"master","sha":"d67596f5d9df20b042092dfaf31d352d9f6a7068","user":{"login":"deliverly","id":10158986,"avatar_url":"https://avatars.githubusercontent.com/u/10158986?v=3","gravatar_id":"","url":"https://api.github.com/users/deliverly","html_url":"https://github.com/deliverly","followers_url":"https://api.github.com/users/deliverly/followers","following_url":"https://api.github.com/users/deliverly/following{/other_user}","gists_url":"https://api.github.com/users/deliverly/gists{/gist_id}","starred_url":"https://api.github.com/users/deliverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliverly/subscriptions","organizations_url":"https://api.github.com/users/deliverly/orgs","repos_url":"https://api.github.com/users/deliverly/repos","events_url":"https://api.github.com/users/deliverly/events{/privacy}","received_events_url":"https://api.github.com/users/deliverly/received_events","type":"Organization","site_admin":false},"repo":{"id":28183809,"name":"deliverly-core","full_name":"deliverly/deliverly-core","owner":{"login":"deliverly","id":10158986,"avatar_url":"https://avatars.githubusercontent.com/u/10158986?v=3","gravatar_id":"","url":"https://api.github.com/users/deliverly","html_url":"https://github.com/deliverly","followers_url":"https://api.github.com/users/deliverly/followers","following_url":"https://api.github.com/users/deliverly/following{/other_user}","gists_url":"https://api.github.com/users/deliverly/gists{/gist_id}","starred_url":"https://api.github.com/users/deliverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliverly/subscriptions","organizations_url":"https://api.github.com/users/deliverly/orgs","repos_url":"https://api.github.com/users/deliverly/repos","events_url":"https://api.github.com/users/deliverly/events{/privacy}","received_events_url":"https://api.github.com/users/deliverly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deliverly/deliverly-core","description":"Core DelivErly app","fork":false,"url":"https://api.github.com/repos/deliverly/deliverly-core","forks_url":"https://api.github.com/repos/deliverly/deliverly-core/forks","keys_url":"https://api.github.com/repos/deliverly/deliverly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deliverly/deliverly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deliverly/deliverly-core/teams","hooks_url":"https://api.github.com/repos/deliverly/deliverly-core/hooks","issue_events_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/events{/number}","events_url":"https://api.github.com/repos/deliverly/deliverly-core/events","assignees_url":"https://api.github.com/repos/deliverly/deliverly-core/assignees{/user}","branches_url":"https://api.github.com/repos/deliverly/deliverly-core/branches{/branch}","tags_url":"https://api.github.com/repos/deliverly/deliverly-core/tags","blobs_url":"https://api.github.com/repos/deliverly/deliverly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deliverly/deliverly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deliverly/deliverly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/deliverly/deliverly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deliverly/deliverly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/deliverly/deliverly-core/languages","stargazers_url":"https://api.github.com/repos/deliverly/deliverly-core/stargazers","contributors_url":"https://api.github.com/repos/deliverly/deliverly-core/contributors","subscribers_url":"https://api.github.com/repos/deliverly/deliverly-core/subscribers","subscription_url":"https://api.github.com/repos/deliverly/deliverly-core/subscription","commits_url":"https://api.github.com/repos/deliverly/deliverly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/deliverly/deliverly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/deliverly/deliverly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/deliverly/deliverly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/deliverly/deliverly-core/contents/{+path}","compare_url":"https://api.github.com/repos/deliverly/deliverly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deliverly/deliverly-core/merges","archive_url":"https://api.github.com/repos/deliverly/deliverly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deliverly/deliverly-core/downloads","issues_url":"https://api.github.com/repos/deliverly/deliverly-core/issues{/number}","pulls_url":"https://api.github.com/repos/deliverly/deliverly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/deliverly/deliverly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/deliverly/deliverly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deliverly/deliverly-core/labels{/name}","releases_url":"https://api.github.com/repos/deliverly/deliverly-core/releases{/id}","deployments_url":"https://api.github.com/repos/deliverly/deliverly-core/deployments","created_at":"2014-12-18T13:04:33Z","updated_at":"2016-07-07T15:34:38Z","pushed_at":"2016-10-13T15:18:15Z","git_url":"git://github.com/deliverly/deliverly-core.git","ssh_url":"git@github.com:deliverly/deliverly-core.git","clone_url":"https://github.com/deliverly/deliverly-core.git","svn_url":"https://github.com/deliverly/deliverly-core","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7"},"html":{"href":"https://github.com/deliverly/deliverly-core/pull/7"},"issue":{"href":"https://api.github.com/repos/deliverly/deliverly-core/issues/7"},"comments":{"href":"https://api.github.com/repos/deliverly/deliverly-core/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deliverly/deliverly-core/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/deliverly/deliverly-core/statuses/e71e678617edf7a7c413d64b9dccf755dc509d27"}}}}
{"actor":{"display_login":"palkan"}}