{"action":"closed","number":154,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154","id":85058995,"html_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/154","diff_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/154.diff","patch_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/154.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/154","number":154,"state":"closed","locked":false,"title":"Make sure filters actually have a value (even if the value might be bad)","user":{"login":"hmoco","id":6268982,"avatar_url":"https://avatars.githubusercontent.com/u/6268982?v=3","gravatar_id":"","url":"https://api.github.com/users/hmoco","html_url":"https://github.com/hmoco","followers_url":"https://api.github.com/users/hmoco/followers","following_url":"https://api.github.com/users/hmoco/following{/other_user}","gists_url":"https://api.github.com/users/hmoco/gists{/gist_id}","starred_url":"https://api.github.com/users/hmoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmoco/subscriptions","organizations_url":"https://api.github.com/users/hmoco/orgs","repos_url":"https://api.github.com/users/hmoco/repos","events_url":"https://api.github.com/users/hmoco/events{/privacy}","received_events_url":"https://api.github.com/users/hmoco/received_events","type":"User","site_admin":false},"body":"## Purpose:\r\nWhen pasting a link something like `subject=` gets converted to `subject`, which Ember reads as a value of ` true ` to the Subject query param. When trying to convert query params to filters, it is read as string ` true `. This prevents that behavior (but it does not validate the value of the query param if something is actually passed).\r\n\r\n## Changes:\r\nIf a queryParam's value is ` true`, do not use it as a filter.","created_at":"2016-09-13T14:28:19Z","updated_at":"2016-09-23T14:24:52Z","closed_at":"2016-09-23T14:24:52Z","merged_at":null,"merge_commit_sha":"48be3f7ca0f21465dcf0bf5a187faf12be6abc65","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/milestones/2","html_url":"https://github.com/CenterForOpenScience/ember-preprints/milestones/0.94.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/milestones/2/labels","id":1993934,"number":2,"title":"0.94.0","description":"","creator":{"login":"caneruguz","id":1314003,"avatar_url":"https://avatars.githubusercontent.com/u/1314003?v=3","gravatar_id":"","url":"https://api.github.com/users/caneruguz","html_url":"https://github.com/caneruguz","followers_url":"https://api.github.com/users/caneruguz/followers","following_url":"https://api.github.com/users/caneruguz/following{/other_user}","gists_url":"https://api.github.com/users/caneruguz/gists{/gist_id}","starred_url":"https://api.github.com/users/caneruguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caneruguz/subscriptions","organizations_url":"https://api.github.com/users/caneruguz/orgs","repos_url":"https://api.github.com/users/caneruguz/repos","events_url":"https://api.github.com/users/caneruguz/events{/privacy}","received_events_url":"https://api.github.com/users/caneruguz/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2016-09-09T16:53:02Z","updated_at":"2016-09-23T14:24:52Z","due_on":"2016-09-26T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/154/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/1d25721bf9058064ad60d62f08c089d3dd9a6c94","head":{"label":"CenterForOpenScience:hotfix/prevent-bad-filter","ref":"hotfix/prevent-bad-filter","sha":"1d25721bf9058064ad60d62f08c089d3dd9a6c94","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":63790282,"name":"ember-preprints","full_name":"CenterForOpenScience/ember-preprints","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-preprints","description":"This is the codebase for OSF Preprints, the open preprint repository network","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/deployments","created_at":"2016-07-20T14:56:36Z","updated_at":"2016-08-31T19:35:52Z","pushed_at":"2016-09-23T14:24:39Z","git_url":"git://github.com/CenterForOpenScience/ember-preprints.git","ssh_url":"git@github.com:CenterForOpenScience/ember-preprints.git","clone_url":"https://github.com/CenterForOpenScience/ember-preprints.git","svn_url":"https://github.com/CenterForOpenScience/ember-preprints","homepage":"https://osf.io/preprints/","size":12581,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":3,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:master","ref":"master","sha":"d11d7cde50cfab180812bd774b7f829a71da08fb","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":63790282,"name":"ember-preprints","full_name":"CenterForOpenScience/ember-preprints","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-preprints","description":"This is the codebase for OSF Preprints, the open preprint repository network","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/deployments","created_at":"2016-07-20T14:56:36Z","updated_at":"2016-08-31T19:35:52Z","pushed_at":"2016-09-23T14:24:39Z","git_url":"git://github.com/CenterForOpenScience/ember-preprints.git","ssh_url":"git@github.com:CenterForOpenScience/ember-preprints.git","clone_url":"https://github.com/CenterForOpenScience/ember-preprints.git","svn_url":"https://github.com/CenterForOpenScience/ember-preprints","homepage":"https://osf.io/preprints/","size":12581,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154"},"html":{"href":"https://github.com/CenterForOpenScience/ember-preprints/pull/154"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/154"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/1d25721bf9058064ad60d62f08c089d3dd9a6c94"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"hmoco"}}