{"action":"created","comment":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/86003533","pull_request_review_id":6684656,"id":86003533,"diff_hunk":"@@ -35,10 +35,18 @@ The following patterns are not considered warnings:\n \n ```js\n ...\n-\"forbid-component-props\": [<enabled>, { \"forbid\": [<string>] }]\n+\"forbid-component-props\": [<enabled>, { \"forbid\": [<string>], \"forbidPatterns\": [<string>], ignoreDomNodes: <boolean> }]\n ...\n ```\n \n ### `forbid`\n \n An array of strings, with the names of props that are forbidden. The default value of this option is `['className', 'style']`.\n+\n+### `forbidPatterns`\n+\n+An array of strings, with the patterns of props that are forbidden; you can use `*` as a wildcard. e.g: `['data-*', '*-foo-*']`\n+\n+### `ignoreDomNodes`\n+\n+Whether to check forbidden props on DOM nodes (div, input, span, etc...). Defaults to true","path":"docs/rules/forbid-component-props.md","position":27,"original_position":27,"commit_id":"3deeb99e9f847c683e5de9da07cb439b0b952dd8","original_commit_id":"3deeb99e9f847c683e5de9da07cb439b0b952dd8","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"having options where absence and `false` are not the same is a very bad idea - it'd be better to rename this to `checkDOMNodes` and default it to `false`.","created_at":"2016-11-01T19:18:40Z","updated_at":"2016-11-01T19:18:40Z","html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/936#discussion_r86003533","pull_request_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936","_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/86003533"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/936#discussion_r86003533"},"pull_request":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936"}}},"pull_request":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936","id":91810559,"html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/936","diff_url":"https://github.com/yannickcr/eslint-plugin-react/pull/936.diff","patch_url":"https://github.com/yannickcr/eslint-plugin-react/pull/936.patch","issue_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/936","number":936,"state":"open","locked":false,"title":"Add forbidPatterns to forbid-component-props rule","user":{"login":"burabure","id":3132298,"avatar_url":"https://avatars.githubusercontent.com/u/3132298?v=3","gravatar_id":"","url":"https://api.github.com/users/burabure","html_url":"https://github.com/burabure","followers_url":"https://api.github.com/users/burabure/followers","following_url":"https://api.github.com/users/burabure/following{/other_user}","gists_url":"https://api.github.com/users/burabure/gists{/gist_id}","starred_url":"https://api.github.com/users/burabure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burabure/subscriptions","organizations_url":"https://api.github.com/users/burabure/orgs","repos_url":"https://api.github.com/users/burabure/repos","events_url":"https://api.github.com/users/burabure/events{/privacy}","received_events_url":"https://api.github.com/users/burabure/received_events","type":"User","site_admin":false},"body":"Adds a forbidPatterns option that takes an array of regexp strings so it's possible to forbid the use of things like `data-*` props","created_at":"2016-11-01T16:00:39Z","updated_at":"2016-11-01T19:19:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddccb090878d60d875aece9a8627dbfd442d0a35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936/commits","review_comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936/comments","review_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/936/comments","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/3deeb99e9f847c683e5de9da07cb439b0b952dd8","head":{"label":"burabure:forbid-component-props-forbidPatterns","ref":"forbid-component-props-forbidPatterns","sha":"3deeb99e9f847c683e5de9da07cb439b0b952dd8","user":{"login":"burabure","id":3132298,"avatar_url":"https://avatars.githubusercontent.com/u/3132298?v=3","gravatar_id":"","url":"https://api.github.com/users/burabure","html_url":"https://github.com/burabure","followers_url":"https://api.github.com/users/burabure/followers","following_url":"https://api.github.com/users/burabure/following{/other_user}","gists_url":"https://api.github.com/users/burabure/gists{/gist_id}","starred_url":"https://api.github.com/users/burabure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burabure/subscriptions","organizations_url":"https://api.github.com/users/burabure/orgs","repos_url":"https://api.github.com/users/burabure/repos","events_url":"https://api.github.com/users/burabure/events{/privacy}","received_events_url":"https://api.github.com/users/burabure/received_events","type":"User","site_admin":false},"repo":{"id":71590108,"name":"eslint-plugin-react","full_name":"burabure/eslint-plugin-react","owner":{"login":"burabure","id":3132298,"avatar_url":"https://avatars.githubusercontent.com/u/3132298?v=3","gravatar_id":"","url":"https://api.github.com/users/burabure","html_url":"https://github.com/burabure","followers_url":"https://api.github.com/users/burabure/followers","following_url":"https://api.github.com/users/burabure/following{/other_user}","gists_url":"https://api.github.com/users/burabure/gists{/gist_id}","starred_url":"https://api.github.com/users/burabure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burabure/subscriptions","organizations_url":"https://api.github.com/users/burabure/orgs","repos_url":"https://api.github.com/users/burabure/repos","events_url":"https://api.github.com/users/burabure/events{/privacy}","received_events_url":"https://api.github.com/users/burabure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burabure/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":true,"url":"https://api.github.com/repos/burabure/eslint-plugin-react","forks_url":"https://api.github.com/repos/burabure/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/burabure/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burabure/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burabure/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/burabure/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/burabure/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/burabure/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/burabure/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/burabure/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/burabure/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/burabure/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burabure/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burabure/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/burabure/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burabure/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/burabure/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/burabure/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/burabure/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/burabure/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/burabure/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/burabure/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/burabure/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/burabure/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/burabure/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/burabure/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/burabure/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burabure/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/burabure/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burabure/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/burabure/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/burabure/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/burabure/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/burabure/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burabure/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/burabure/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/burabure/eslint-plugin-react/deployments","created_at":"2016-10-21T19:14:48Z","updated_at":"2016-10-21T19:14:50Z","pushed_at":"2016-11-01T17:57:18Z","git_url":"git://github.com/burabure/eslint-plugin-react.git","ssh_url":"git@github.com:burabure/eslint-plugin-react.git","clone_url":"https://github.com/burabure/eslint-plugin-react.git","svn_url":"https://github.com/burabure/eslint-plugin-react","homepage":null,"size":1287,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yannickcr:master","ref":"master","sha":"56f177737784a4c112f3762ddd0c880d5589b68f","user":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"repo":{"id":28061676,"name":"eslint-plugin-react","full_name":"yannickcr/eslint-plugin-react","owner":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannickcr/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":false,"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react","forks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/deployments","created_at":"2014-12-15T23:44:14Z","updated_at":"2016-11-01T13:41:59Z","pushed_at":"2016-11-01T18:43:16Z","git_url":"git://github.com/yannickcr/eslint-plugin-react.git","ssh_url":"git@github.com:yannickcr/eslint-plugin-react.git","clone_url":"https://github.com/yannickcr/eslint-plugin-react.git","svn_url":"https://github.com/yannickcr/eslint-plugin-react","homepage":null,"size":1674,"stargazers_count":1915,"watchers_count":1915,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":195,"forks":380,"open_issues":195,"watchers":1915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/936"},"issue":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/936"},"comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/3deeb99e9f847c683e5de9da07cb439b0b952dd8"}}}}
{"actor":{"display_login":"ljharb"}}