{"action":"created","issue":{"url":"https://api.github.com/repos/cyclestreets/android/issues/139","repository_url":"https://api.github.com/repos/cyclestreets/android","labels_url":"https://api.github.com/repos/cyclestreets/android/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/cyclestreets/android/issues/139/comments","events_url":"https://api.github.com/repos/cyclestreets/android/issues/139/events","html_url":"https://github.com/cyclestreets/android/pull/139","id":162970484,"number":139,"title":"Migrate `register()`, `signin()`, and `sendFeedback()` APIs to Retrofit","user":{"login":"oliverlockwood","id":6017680,"avatar_url":"https://avatars.githubusercontent.com/u/6017680?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverlockwood","html_url":"https://github.com/oliverlockwood","followers_url":"https://api.github.com/users/oliverlockwood/followers","following_url":"https://api.github.com/users/oliverlockwood/following{/other_user}","gists_url":"https://api.github.com/users/oliverlockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverlockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverlockwood/subscriptions","organizations_url":"https://api.github.com/users/oliverlockwood/orgs","repos_url":"https://api.github.com/users/oliverlockwood/repos","events_url":"https://api.github.com/users/oliverlockwood/events{/privacy}","received_events_url":"https://api.github.com/users/oliverlockwood/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-29T16:30:28Z","updated_at":"2016-06-30T14:51:09Z","closed_at":"2016-06-30T09:58:20Z","pull_request":{"url":"https://api.github.com/repos/cyclestreets/android/pulls/139","html_url":"https://github.com/cyclestreets/android/pull/139","diff_url":"https://github.com/cyclestreets/android/pull/139.diff","patch_url":"https://github.com/cyclestreets/android/pull/139.patch"},"body":"Similar to the other PRs I've raised recently.\r\n\r\nA couple of things to note:\r\n-  As part of migrating each of these, I've also upgraded to use the V2 API.\r\n-  I haven't been able to integration-test the new implementation of the signin() API, due to #138.  If this can't be resolved swiftly, could you let me have a test email and password so I can verify this aspect?"},"comment":{"url":"https://api.github.com/repos/cyclestreets/android/issues/comments/229682268","html_url":"https://github.com/cyclestreets/android/pull/139#issuecomment-229682268","issue_url":"https://api.github.com/repos/cyclestreets/android/issues/139","id":229682268,"user":{"login":"oliverlockwood","id":6017680,"avatar_url":"https://avatars.githubusercontent.com/u/6017680?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverlockwood","html_url":"https://github.com/oliverlockwood","followers_url":"https://api.github.com/users/oliverlockwood/followers","following_url":"https://api.github.com/users/oliverlockwood/following{/other_user}","gists_url":"https://api.github.com/users/oliverlockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverlockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverlockwood/subscriptions","organizations_url":"https://api.github.com/users/oliverlockwood/orgs","repos_url":"https://api.github.com/users/oliverlockwood/repos","events_url":"https://api.github.com/users/oliverlockwood/events{/privacy}","received_events_url":"https://api.github.com/users/oliverlockwood/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T14:51:08Z","updated_at":"2016-06-30T14:51:08Z","body":"Glad to help out 👍 \r\n\r\n@jezhiggins - Thanks for merging.\r\n\r\n@mvl22 Can you clarify your concern?  [RetrofitApiClientTest](https://github.com/cyclestreets/android/blob/master/libraries/cyclestreets-core/src/test/java/net/cyclestreets/api/client/RetrofitApiClientTest.java) (the only place where [registration-ok.json](https://github.com/cyclestreets/android/blob/master/libraries/cyclestreets-core/src/test/resources/__files/registration-ok.json) and [api-error.json](https://github.com/cyclestreets/android/blob/master/libraries/cyclestreets-core/src/test/resources/__files/api-error.json) are used) is a unit test so effectively the tests verify:\r\n-  that whatever the server returns (in this case mocked by Wiremock) is propagated through the system\r\n-  hardcoded strings in the app itself\r\nI believe therefore that those tests are robust to changes in the string values returned by the server.\r\n\r\nIf I've misunderstood, please accept my apologies and point me more specifically at what needs changing 😀 "}}
{"actor":{"display_login":"oliverlockwood"}}