{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/53537003","id":53537003,"diff_hunk":"@@ -1269,7 +1330,7 @@ void TrackGenerator::segmentize() {\n \n     /* Loop over all Tracks */\n     for (int i=0; i < _num_azim; i++) {\n-#pragma omp parallel for firstprivate(track)","path":"src/TrackGenerator.cpp","position":192,"original_position":192,"commit_id":"2a9dd157f8dff5cd0e332d0a954fc1f6fae7aa9d","original_commit_id":"2a9dd157f8dff5cd0e332d0a954fc1f6fae7aa9d","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"body":"Whoa, this looks like it may have been a bug before","created_at":"2016-02-20T00:19:01Z","updated_at":"2016-02-20T00:19:01Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/264#discussion_r53537003","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/53537003"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/264#discussion_r53537003"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264","id":59298783,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/264","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/264.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/264.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/264","number":264,"state":"open","locked":false,"title":"Parallelized segmentation loops in the TrackGenerator","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This pull requests speeds up some of the set up methods by parallelizing all loops over segments in the TrackGenerator. In doing so, the ownership of the FSR locks has been given to the TrackGenerator and the Solver gets the FSR locks from the TrackGenerator to avoid unnecessary duplication.\r\n\r\nIn running a very fine track laydown on the LRA problem, I found that the `TrackGenerator::initializeSegments()` method was very slow because it called `Geometry::findFSRMaterial()` for every segment. This method is quite slow because it requires a search through the whole CSG hierarchy. The `TrackGenerator::initializeSegments()` method has been restructured so that the materials for each FSR are precomputed by looping over all the FSRs.\r\n\r\nThe LRA input files have also been updated by separating the creation of the surfaces, cells, universes, and lattices into different files instead of forming them all in the `geometry.py` file.","created_at":"2016-02-14T16:12:51Z","updated_at":"2016-02-20T00:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f75ff598d5a0051b09653343ea89c884f578f6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/264/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/2a9dd157f8dff5cd0e332d0a954fc1f6fae7aa9d","head":{"label":"samuelshaner:parallelize-seg-loops","ref":"parallelize-seg-loops","sha":"2a9dd157f8dff5cd0e332d0a954fc1f6fae7aa9d","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":17918430,"name":"OpenMOC","full_name":"samuelshaner/OpenMOC","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/samuelshaner/OpenMOC","forks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/forks","keys_url":"https://api.github.com/repos/samuelshaner/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/OpenMOC/teams","hooks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/events","assignees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/tags","blobs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscription","commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/OpenMOC/merges","archive_url":"https://api.github.com/repos/samuelshaner/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/OpenMOC/downloads","issues_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/samuelshaner/OpenMOC/deployments","created_at":"2014-03-19T20:03:02Z","updated_at":"2014-03-19T20:03:02Z","pushed_at":"2016-02-19T03:11:52Z","git_url":"git://github.com/samuelshaner/OpenMOC.git","ssh_url":"git@github.com:samuelshaner/OpenMOC.git","clone_url":"https://github.com/samuelshaner/OpenMOC.git","svn_url":"https://github.com/samuelshaner/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":111999,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"e6b96a346d094ee0e771e9902e09b478ea5ca76f","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/deployments","created_at":"2013-03-14T17:19:26Z","updated_at":"2016-02-12T23:37:19Z","pushed_at":"2016-02-19T23:52:08Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":135010,"stargazers_count":20,"watchers_count":20,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":20,"forks":27,"open_issues":20,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/264"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/264"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/2a9dd157f8dff5cd0e332d0a954fc1f6fae7aa9d"}}}}