{"push_id":1042440384,"size":12,"distinct_size":9,"ref":"refs/heads/tabishev/depjvm_twitter","head":"7e8ffd098a67be118499f436b7fa5b3b98523640","before":"2d443e7c31f0bfa6686a9dfcdecbc58c388a9805","commits":[{"sha":"458b673b459ea1a2d1365b772b150bbd7a72944f","author":{"email":"8a48ad68f751b273a85583580b85b5eceb3e5ac9@twopensource.com","name":"Kris Wilson"},"message":"Merge pants/release/2.0.5-rc1 back into 2.0.4 branch.","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/458b673b459ea1a2d1365b772b150bbd7a72944f"},{"sha":"e378c4a03bf4436f32874193096b1d65197add50","author":{"email":"c04adb29a15043e181c29f1f6e048ba362b8d55f@gmail.com","name":"Matt Landis"},"message":"Avoid pathological regex performance when linkifying large ivy output.\n\nOur build contains an 800 MB jar. Ivy outputs 110k dots while downloading this. Pants then tries to linkify this and `re.findall` takes 10+ minutes.\n\nI tried instead changing all the groups to non-capturing and all the `?` and `+`s to non-greedy, but they didn't solve the problem (they did help a bit, but not enough to suffice).\n\nThe negative lookahead solution in this commit feels hacky. I'm open to other suggestions (it might be worth trying the regex or re2 libraries for non-backtracking regexes, if it's worth adding those deps to pants - also not sure if those will actually help, since we'll still be quadratic).\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/118159590\n\nalso turned linkify.py into a standalone script to repro the issue on our ivy output and verified execution time went from awful -> good\n\nBugs closed: 3085\n\nReviewed at https://rbcommons.com/s/twitter/r/3603/","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/e378c4a03bf4436f32874193096b1d65197add50"},{"sha":"9f88647c01a0be6967968e36cc186e505f5e9673","author":{"email":"bb1f132dcb86bfc59bf4a043a3139a9ac7c0b658@gmail.com","name":"Stu Hood"},"message":"Stabilize isort","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/9f88647c01a0be6967968e36cc186e505f5e9673"},{"sha":"15ba1099c9a975ab57e46907b16d0c1da608e9ea","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"Fix `compute_hashes` for `Page` target type\n\nI've discovered `fingerprint` method fails on `Page` targets because `WikiArtifact` doesn't contain `fingerprint` method. This PR contains tests for `WikiArtifact` payload fingerprint and fix for it.\n\nTesting Done:\nhttps://travis-ci.org/ttim/pants/builds/117498326\n\nBugs closed: 3069\n\nReviewed at https://rbcommons.com/s/twitter/r/3591/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/15ba1099c9a975ab57e46907b16d0c1da608e9ea"},{"sha":"f465a988c1248e07e87f4c1ed2dd02c1f366eeb8","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"Do not return directories from BUILD file's globs implementation\n\nI've discovered `fingerprint` method fails on `jvm_app` targets because of pants `globs` implementation returns folders which are not hashable. I think it's fair enough to return only files in `globs`/`rglobs`/`zglobs` implementations for `BUILD` files. This PR contains tests for both `jvm_app` fingerprint and `globs` behaviour + fix for it.\n\nTesting Done:\nhttps://travis-ci.org/ttim/pants/builds/117934043\n\nBugs closed: 3068\n\nReviewed at https://rbcommons.com/s/twitter/r/3590/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/f465a988c1248e07e87f4c1ed2dd02c1f366eeb8"},{"sha":"d13f3acc75da328ea9314b68a86d149918b8bfc9","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"using cache for jvm_dependency_usage","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/d13f3acc75da328ea9314b68a86d149918b8bfc9"},{"sha":"096f99732ca2236850921d9075a9ab1dc71008d6","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"add integration tests on dep-usage.cache","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/096f99732ca2236850921d9075a9ab1dc71008d6"},{"sha":"e4887a8f51983447021d0d46453cd9c7c5c2095f","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"add unit test","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/e4887a8f51983447021d0d46453cd9c7c5c2095f"},{"sha":"28ad5b604890a990ddb359a57d576d3ed8e8739d","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"remove unnecessary mkdir","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/28ad5b604890a990ddb359a57d576d3ed8e8739d"},{"sha":"40f2fffa6e165a8b3a07fe6edea9a721cbaa27a4","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"move node_creators outside of method","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/40f2fffa6e165a8b3a07fe6edea9a721cbaa27a4"},{"sha":"13ace9956c4834de302b8736ed68ad9a2ff4b7a7","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"update option help","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/13ace9956c4834de302b8736ed68ad9a2ff4b7a7"},{"sha":"7e8ffd098a67be118499f436b7fa5b3b98523640","author":{"email":"5c03386320a2b453ce4a1ee67bf5a90e435fee84@gmail.com","name":"Timur Abishev"},"message":"rephrasing and comments on strategies","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/7e8ffd098a67be118499f436b7fa5b3b98523640"}]}