{"action":"created","comment":{"url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/comments/73194812","id":73194812,"diff_hunk":"@@ -435,21 +435,26 @@ function anchorTimestamps(text, videoID) {\n       mm:ss\n       m:ss\n     and wraps the timestamps in <a> tags\n+    RegEx explanation:\n+    ((?:[0-5]\\d|\\d|) either the string is \"colon 00-59\" or \"0-9\" or \"blank\"\n+    (?:\\d|\\:[0-5]\\d) either the string is \"colon 0-9\" or \"colon 00-59\"\n+    (?:$|\\:[0-5]\\d)) either the string ends or is a a number between 00-59\n     */\n     var re = /((?:[0-5]\\d|\\d|)(?:\\d|\\:[0-5]\\d)(?:$|\\:[0-5]\\d))/g;\n-    return text.replace(re, (match, $1) => \"<a href=\\\"\" + makeListenURL(videoID, convertTimestamp($1)) + \"\\\">\" + $1 + \"</a>\");\n+    return text.replace(re, function(match) { return \"<a href=\\\"\" + makeListenURL(videoID, convertTimestamp(match)) + \"\\\">\" + match + \"</a>\"; });","path":"js/everything.js","position":null,"original_position":11,"commit_id":"48e866f27f0cbbef06bf187388e47f226e23970e","original_commit_id":"294de3ca458afc3ad7e8b38a35b76dca86dd5074","user":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"body":"Okay, I can tweak later once I get some time. Let's at least put the function body on it's own line (and indented by 4 spaces) so it's a bit more readable","created_at":"2016-08-02T16:59:59Z","updated_at":"2016-08-02T16:59:59Z","html_url":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234#discussion_r73194812","pull_request_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/comments/73194812"},"html":{"href":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234#discussion_r73194812"},"pull_request":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234","id":79498918,"html_url":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234","diff_url":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234.diff","patch_url":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234.patch","issue_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/234","number":234,"state":"open","locked":false,"title":"Anchor timestamp URLs in description. Closes #228","user":{"login":"hogniRunar","id":12848049,"avatar_url":"https://avatars.githubusercontent.com/u/12848049?v=3","gravatar_id":"","url":"https://api.github.com/users/hogniRunar","html_url":"https://github.com/hogniRunar","followers_url":"https://api.github.com/users/hogniRunar/followers","following_url":"https://api.github.com/users/hogniRunar/following{/other_user}","gists_url":"https://api.github.com/users/hogniRunar/gists{/gist_id}","starred_url":"https://api.github.com/users/hogniRunar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hogniRunar/subscriptions","organizations_url":"https://api.github.com/users/hogniRunar/orgs","repos_url":"https://api.github.com/users/hogniRunar/repos","events_url":"https://api.github.com/users/hogniRunar/events{/privacy}","received_events_url":"https://api.github.com/users/hogniRunar/received_events","type":"User","site_admin":false},"body":"Provide a general summary of your changes in the **Title** above.\r\n\r\n### Important\r\nMark with [x] to select. Leave as [ ] to unselect.\r\n\r\n### Motivation and Context\r\n- [ ] Why is this change required? What problem does it solve?\r\n- [x] If it fixes an open issue, include the text `Closes #1` (where 1 would be the issue number) to your commit message.\r\n\r\n### Types of changes\r\nWhat types of changes does your code introduce? Check all the boxes that apply:\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Description\r\n- [x] Describe your changes in detail.\r\n\r\n### Final checklist:\r\nGo over all the following points and check all the boxes that apply  \r\nIf you're unsure about any of these, don't hesitate to ask. We're here to help!\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**CONTRIBUTING**](.github/CONTRIBUTING.md) guidelines.\r\n- [x] All tests passed.\r\n\r\nThis closes the issue #228. The main changes that were made were:\r\nPass videoID into the setupVideoDescription funciton (to be able to construct the URLs)\r\nTwo new functions were created called anchorTimestamps and convertTimestamps. The first creates URLs in the description and the latter converts timestamps from 01:00:00 to 01h00m00s for example","created_at":"2016-07-31T23:05:57Z","updated_at":"2016-08-02T16:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb64b65a2d73dbc0746e79fe60ffb5a2e20aba06","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234/commits","review_comments_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234/comments","review_comment_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/234/comments","statuses_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/statuses/48e866f27f0cbbef06bf187388e47f226e23970e","head":{"label":"hogniRunar:master","ref":"master","sha":"48e866f27f0cbbef06bf187388e47f226e23970e","user":{"login":"hogniRunar","id":12848049,"avatar_url":"https://avatars.githubusercontent.com/u/12848049?v=3","gravatar_id":"","url":"https://api.github.com/users/hogniRunar","html_url":"https://github.com/hogniRunar","followers_url":"https://api.github.com/users/hogniRunar/followers","following_url":"https://api.github.com/users/hogniRunar/following{/other_user}","gists_url":"https://api.github.com/users/hogniRunar/gists{/gist_id}","starred_url":"https://api.github.com/users/hogniRunar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hogniRunar/subscriptions","organizations_url":"https://api.github.com/users/hogniRunar/orgs","repos_url":"https://api.github.com/users/hogniRunar/repos","events_url":"https://api.github.com/users/hogniRunar/events{/privacy}","received_events_url":"https://api.github.com/users/hogniRunar/received_events","type":"User","site_admin":false},"repo":{"id":64354400,"name":"zen-audio-player.github.io","full_name":"hogniRunar/zen-audio-player.github.io","owner":{"login":"hogniRunar","id":12848049,"avatar_url":"https://avatars.githubusercontent.com/u/12848049?v=3","gravatar_id":"","url":"https://api.github.com/users/hogniRunar","html_url":"https://github.com/hogniRunar","followers_url":"https://api.github.com/users/hogniRunar/followers","following_url":"https://api.github.com/users/hogniRunar/following{/other_user}","gists_url":"https://api.github.com/users/hogniRunar/gists{/gist_id}","starred_url":"https://api.github.com/users/hogniRunar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hogniRunar/subscriptions","organizations_url":"https://api.github.com/users/hogniRunar/orgs","repos_url":"https://api.github.com/users/hogniRunar/repos","events_url":"https://api.github.com/users/hogniRunar/events{/privacy}","received_events_url":"https://api.github.com/users/hogniRunar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hogniRunar/zen-audio-player.github.io","description":"Listen to YouTube videos, without the distracting visuals.","fork":true,"url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io","forks_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/forks","keys_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/teams","hooks_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/hooks","issue_events_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/events","assignees_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/tags","blobs_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/languages","stargazers_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/stargazers","contributors_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/contributors","subscribers_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/subscribers","subscription_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/subscription","commits_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/merges","archive_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/downloads","issues_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/labels{/name}","releases_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/hogniRunar/zen-audio-player.github.io/deployments","created_at":"2016-07-28T01:38:01Z","updated_at":"2016-08-02T00:02:41Z","pushed_at":"2016-08-01T22:34:01Z","git_url":"git://github.com/hogniRunar/zen-audio-player.github.io.git","ssh_url":"git@github.com:hogniRunar/zen-audio-player.github.io.git","clone_url":"https://github.com/hogniRunar/zen-audio-player.github.io.git","svn_url":"https://github.com/hogniRunar/zen-audio-player.github.io","homepage":"https://ZenPlayer.Audio","size":7081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zen-audio-player:master","ref":"master","sha":"135fb7a0d21e3d1853cf4788318ce186acc5ebdf","user":{"login":"zen-audio-player","id":12404635,"avatar_url":"https://avatars.githubusercontent.com/u/12404635?v=3","gravatar_id":"","url":"https://api.github.com/users/zen-audio-player","html_url":"https://github.com/zen-audio-player","followers_url":"https://api.github.com/users/zen-audio-player/followers","following_url":"https://api.github.com/users/zen-audio-player/following{/other_user}","gists_url":"https://api.github.com/users/zen-audio-player/gists{/gist_id}","starred_url":"https://api.github.com/users/zen-audio-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zen-audio-player/subscriptions","organizations_url":"https://api.github.com/users/zen-audio-player/orgs","repos_url":"https://api.github.com/users/zen-audio-player/repos","events_url":"https://api.github.com/users/zen-audio-player/events{/privacy}","received_events_url":"https://api.github.com/users/zen-audio-player/received_events","type":"Organization","site_admin":false},"repo":{"id":35466062,"name":"zen-audio-player.github.io","full_name":"zen-audio-player/zen-audio-player.github.io","owner":{"login":"zen-audio-player","id":12404635,"avatar_url":"https://avatars.githubusercontent.com/u/12404635?v=3","gravatar_id":"","url":"https://api.github.com/users/zen-audio-player","html_url":"https://github.com/zen-audio-player","followers_url":"https://api.github.com/users/zen-audio-player/followers","following_url":"https://api.github.com/users/zen-audio-player/following{/other_user}","gists_url":"https://api.github.com/users/zen-audio-player/gists{/gist_id}","starred_url":"https://api.github.com/users/zen-audio-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zen-audio-player/subscriptions","organizations_url":"https://api.github.com/users/zen-audio-player/orgs","repos_url":"https://api.github.com/users/zen-audio-player/repos","events_url":"https://api.github.com/users/zen-audio-player/events{/privacy}","received_events_url":"https://api.github.com/users/zen-audio-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zen-audio-player/zen-audio-player.github.io","description":"Listen to YouTube videos, without the distracting visuals.","fork":false,"url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io","forks_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/forks","keys_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/teams","hooks_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/hooks","issue_events_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/events","assignees_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/tags","blobs_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/languages","stargazers_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/stargazers","contributors_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/contributors","subscribers_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/subscribers","subscription_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/subscription","commits_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/merges","archive_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/downloads","issues_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/labels{/name}","releases_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/deployments","created_at":"2015-05-12T04:06:22Z","updated_at":"2016-08-01T22:40:27Z","pushed_at":"2016-08-02T08:21:00Z","git_url":"git://github.com/zen-audio-player/zen-audio-player.github.io.git","ssh_url":"git@github.com:zen-audio-player/zen-audio-player.github.io.git","clone_url":"https://github.com/zen-audio-player/zen-audio-player.github.io.git","svn_url":"https://github.com/zen-audio-player/zen-audio-player.github.io","homepage":"https://ZenPlayer.Audio","size":7356,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":22,"forks":48,"open_issues":22,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234"},"html":{"href":"https://github.com/zen-audio-player/zen-audio-player.github.io/pull/234"},"issue":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/234"},"comments":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/zen-audio-player/zen-audio-player.github.io/statuses/48e866f27f0cbbef06bf187388e47f226e23970e"}}}}
{"actor":{"display_login":"shakeelmohamed"}}