{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/61654108","id":61654108,"diff_hunk":"@@ -710,6 +717,18 @@ private void emitIfAppropriate(ReduceFn<K, InputT, OutputT, W>.Context directCon\n       paneInfoTracker.clear(directContext.state());\n       activeWindows.remove(directContext.window());\n     }\n+\n+    if (shouldDiscard &&\n+        !triggerRunner.hasState(directContext.window(), directContext.timers(),","path":"sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/ReduceFnRunner.java","position":null,"original_position":76,"commit_id":"7905fba812e366474f4b4cf7266452f7659b032d","original_commit_id":"51518a5108e39ce3c8024c88fe7b1724021b195f","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"body":"I think this is now covered by looking for just the finished bits.","created_at":"2016-04-29T22:40:33Z","updated_at":"2016-04-29T22:40:33Z","html_url":"https://github.com/apache/incubator-beam/pull/139#discussion_r61654108","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/61654108"},"html":{"href":"https://github.com/apache/incubator-beam/pull/139#discussion_r61654108"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/139","id":65541038,"html_url":"https://github.com/apache/incubator-beam/pull/139","diff_url":"https://github.com/apache/incubator-beam/pull/139.diff","patch_url":"https://github.com/apache/incubator-beam/pull/139.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/139","number":139,"state":"open","locked":false,"title":"[BEAM-175] Don't leak state in Global window.","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"body":"* Delete end-of-window timer after triggering if there's no\r\n  state left to garbage collect.\r\n* Avoid holds and end-of-time.\r\n* Avoid requiring previous pane info in global window.\r\n* Protect against overflow with GlobalWindow.maxTimestamp\r\n  and getAllowedLateness [BEAM-122]\r\n\r\n**Rough cut for comments**","created_at":"2016-04-06T21:41:24Z","updated_at":"2016-04-29T22:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35859f96bdfe6813d273b6b4e1ba314f22bb5b4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/139/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/139/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/139/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/7905fba812e366474f4b4cf7266452f7659b032d","head":{"label":"mshields822:beam-175","ref":"beam-175","sha":"7905fba812e366474f4b4cf7266452f7659b032d","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"repo":{"id":52641502,"name":"incubator-beam","full_name":"mshields822/incubator-beam","owner":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mshields822/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/mshields822/incubator-beam","forks_url":"https://api.github.com/repos/mshields822/incubator-beam/forks","keys_url":"https://api.github.com/repos/mshields822/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mshields822/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mshields822/incubator-beam/teams","hooks_url":"https://api.github.com/repos/mshields822/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/mshields822/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/mshields822/incubator-beam/events","assignees_url":"https://api.github.com/repos/mshields822/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/mshields822/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/mshields822/incubator-beam/tags","blobs_url":"https://api.github.com/repos/mshields822/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mshields822/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mshields822/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/mshields822/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mshields822/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/mshields822/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/mshields822/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/mshields822/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/mshields822/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/mshields822/incubator-beam/subscription","commits_url":"https://api.github.com/repos/mshields822/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/mshields822/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/mshields822/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/mshields822/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/mshields822/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/mshields822/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mshields822/incubator-beam/merges","archive_url":"https://api.github.com/repos/mshields822/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mshields822/incubator-beam/downloads","issues_url":"https://api.github.com/repos/mshields822/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/mshields822/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/mshields822/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/mshields822/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mshields822/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/mshields822/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/mshields822/incubator-beam/deployments","created_at":"2016-02-27T00:22:15Z","updated_at":"2016-02-27T00:22:17Z","pushed_at":"2016-04-29T04:19:17Z","git_url":"git://github.com/mshields822/incubator-beam.git","ssh_url":"git@github.com:mshields822/incubator-beam.git","clone_url":"https://github.com/mshields822/incubator-beam.git","svn_url":"https://github.com/mshields822/incubator-beam","homepage":null,"size":13390,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4d5303d8a8cc175cecf3686347e7d7465f902a9e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-04-29T21:08:12Z","pushed_at":"2016-04-29T22:20:40Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":15763,"stargazers_count":150,"watchers_count":150,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":15,"forks":75,"open_issues":15,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/139"},"html":{"href":"https://github.com/apache/incubator-beam/pull/139"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/139"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/7905fba812e366474f4b4cf7266452f7659b032d"}}}}