{"action":"created","issue":{"url":"https://api.github.com/repos/18F/web-design-standards/issues/1248","repository_url":"https://api.github.com/repos/18F/web-design-standards","labels_url":"https://api.github.com/repos/18F/web-design-standards/issues/1248/labels{/name}","comments_url":"https://api.github.com/repos/18F/web-design-standards/issues/1248/comments","events_url":"https://api.github.com/repos/18F/web-design-standards/issues/1248/events","html_url":"https://github.com/18F/web-design-standards/pull/1248","id":159490711,"number":1248,"title":"[Footer]: Fix footer social icon hit area","user":{"login":"joshbruce","id":15252830,"avatar_url":"https://avatars.githubusercontent.com/u/15252830?v=3","gravatar_id":"","url":"https://api.github.com/users/joshbruce","html_url":"https://github.com/joshbruce","followers_url":"https://api.github.com/users/joshbruce/followers","following_url":"https://api.github.com/users/joshbruce/following{/other_user}","gists_url":"https://api.github.com/users/joshbruce/gists{/gist_id}","starred_url":"https://api.github.com/users/joshbruce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshbruce/subscriptions","organizations_url":"https://api.github.com/users/joshbruce/orgs","repos_url":"https://api.github.com/users/joshbruce/repos","events_url":"https://api.github.com/users/joshbruce/events{/privacy}","received_events_url":"https://api.github.com/users/joshbruce/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/18F/web-design-standards/labels/[Status]%20Accepted","name":"[Status] Accepted","color":"f9c642"}],"state":"open","locked":false,"assignee":{"login":"ericadeahl","id":5911280,"avatar_url":"https://avatars.githubusercontent.com/u/5911280?v=3","gravatar_id":"","url":"https://api.github.com/users/ericadeahl","html_url":"https://github.com/ericadeahl","followers_url":"https://api.github.com/users/ericadeahl/followers","following_url":"https://api.github.com/users/ericadeahl/following{/other_user}","gists_url":"https://api.github.com/users/ericadeahl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericadeahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericadeahl/subscriptions","organizations_url":"https://api.github.com/users/ericadeahl/orgs","repos_url":"https://api.github.com/users/ericadeahl/repos","events_url":"https://api.github.com/users/ericadeahl/events{/privacy}","received_events_url":"https://api.github.com/users/ericadeahl/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2016-06-09T19:38:14Z","updated_at":"2016-06-15T19:34:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/web-design-standards/pulls/1248","html_url":"https://github.com/18F/web-design-standards/pull/1248","diff_url":"https://github.com/18F/web-design-standards/pull/1248.diff","patch_url":"https://github.com/18F/web-design-standards/pull/1248.patch"},"body":"## Description\n\nFixes #346\n\n## Additional information\n\n* This PR uses `display: inline-block` to allow setting height and\nwidth to an inline element.\n* Uses 44 pixels for both height and width per the Apple iOS HIG\n* Concerns with `text-align: right` - could result in thumb hitting to\nthe right of the hit area - actually hitting the icon to the right of\nthe actual target. `text-align: center` used instead.\n* Using `text-align: center` causes the right alignment of the icons to\nbe off when compared “Agency Contact Center” text. `position: relative;\nleft: 13px` used in order to compensate. Slight concern that this could\ncause a horizontal scroll bar to appear on mobile - though, given the\noverall alignment of the `social-links` container - concern may be moot."},"comment":{"url":"https://api.github.com/repos/18F/web-design-standards/issues/comments/226295662","html_url":"https://github.com/18F/web-design-standards/pull/1248#issuecomment-226295662","issue_url":"https://api.github.com/repos/18F/web-design-standards/issues/1248","id":226295662,"user":{"login":"maya","id":5249443,"avatar_url":"https://avatars.githubusercontent.com/u/5249443?v=3","gravatar_id":"","url":"https://api.github.com/users/maya","html_url":"https://github.com/maya","followers_url":"https://api.github.com/users/maya/followers","following_url":"https://api.github.com/users/maya/following{/other_user}","gists_url":"https://api.github.com/users/maya/gists{/gist_id}","starred_url":"https://api.github.com/users/maya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maya/subscriptions","organizations_url":"https://api.github.com/users/maya/orgs","repos_url":"https://api.github.com/users/maya/repos","events_url":"https://api.github.com/users/maya/events{/privacy}","received_events_url":"https://api.github.com/users/maya/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T19:34:22Z","updated_at":"2016-06-15T19:34:22Z","body":">Curious to know the rationale regarding the alphabetical ordering as opposed to groupings similar to:\r\n\r\nGood question! We find it's easier to find where properties are when it's alphabetical and easier for people to meet the standards and to review and lint - especially on such a large code base with external contributors. Our coding styleguide says we can use either on a project as long as it's consistent, but we've gone with alphabetical for the previous reasons."}}
{"actor":{"display_login":"maya"}}