{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52251488","id":52251488,"diff_hunk":"@@ -200,6 +214,14 @@ func (f *Framework) afterEach() {\n \tf.Client = nil\n }\n \n+func (f *Framework) CreateNamespace(baseName string, c *client.Client, labels map[string]string) (*api.Namespace, error) {\n+\tns, err := createTestingNS(baseName, c, labels)","path":"test/e2e/framework.go","position":83,"original_position":83,"commit_id":"d248aa62e3be690d95d51e45e9916ef8aa2d1c1b","original_commit_id":"d248aa62e3be690d95d51e45e9916ef8aa2d1c1b","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"+1 for just deleting `createTestingNS`.","created_at":"2016-02-09T00:30:50Z","updated_at":"2016-02-09T00:30:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/20771#discussion_r52251488","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52251488"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20771#discussion_r52251488"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771","id":58512639,"html_url":"https://github.com/kubernetes/kubernetes/pull/20771","diff_url":"https://github.com/kubernetes/kubernetes/pull/20771.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20771.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20771","number":20771,"state":"open","locked":false,"title":"E2E framework cleanups","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"A few things have always bugged me about our framework.  Specifically the guarantees about cleanup are almost useless in the face of test timeouts or manual ^C (I assume a timeout == SIGINT, but I guess we'll see?).\r\n\r\nNow this tries harder to always clean up. ","created_at":"2016-02-06T05:42:49Z","updated_at":"2016-02-09T00:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c92c2542e804e0086b659085e2bc9c5a87418fa","assignee":{"login":"ihmccreery","id":368416,"avatar_url":"https://avatars.githubusercontent.com/u/368416?v=3","gravatar_id":"","url":"https://api.github.com/users/ihmccreery","html_url":"https://github.com/ihmccreery","followers_url":"https://api.github.com/users/ihmccreery/followers","following_url":"https://api.github.com/users/ihmccreery/following{/other_user}","gists_url":"https://api.github.com/users/ihmccreery/gists{/gist_id}","starred_url":"https://api.github.com/users/ihmccreery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihmccreery/subscriptions","organizations_url":"https://api.github.com/users/ihmccreery/orgs","repos_url":"https://api.github.com/users/ihmccreery/repos","events_url":"https://api.github.com/users/ihmccreery/events{/privacy}","received_events_url":"https://api.github.com/users/ihmccreery/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20771/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d248aa62e3be690d95d51e45e9916ef8aa2d1c1b","head":{"label":"thockin:e2e-framework","ref":"e2e-framework","sha":"d248aa62e3be690d95d51e45e9916ef8aa2d1c1b","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"repo":{"id":21042716,"name":"kubernetes","full_name":"thockin/kubernetes","owner":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thockin/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/thockin/kubernetes","forks_url":"https://api.github.com/repos/thockin/kubernetes/forks","keys_url":"https://api.github.com/repos/thockin/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thockin/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thockin/kubernetes/teams","hooks_url":"https://api.github.com/repos/thockin/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/thockin/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/thockin/kubernetes/events","assignees_url":"https://api.github.com/repos/thockin/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/thockin/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/thockin/kubernetes/tags","blobs_url":"https://api.github.com/repos/thockin/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thockin/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thockin/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/thockin/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thockin/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/thockin/kubernetes/languages","stargazers_url":"https://api.github.com/repos/thockin/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/thockin/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/thockin/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/thockin/kubernetes/subscription","commits_url":"https://api.github.com/repos/thockin/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/thockin/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/thockin/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/thockin/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/thockin/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/thockin/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thockin/kubernetes/merges","archive_url":"https://api.github.com/repos/thockin/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thockin/kubernetes/downloads","issues_url":"https://api.github.com/repos/thockin/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/thockin/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/thockin/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/thockin/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thockin/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/thockin/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/thockin/kubernetes/deployments","created_at":"2014-06-20T15:30:28Z","updated_at":"2016-02-04T18:05:56Z","pushed_at":"2016-02-08T18:31:40Z","git_url":"git://github.com/thockin/kubernetes.git","ssh_url":"git@github.com:thockin/kubernetes.git","clone_url":"https://github.com/thockin/kubernetes.git","svn_url":"https://github.com/thockin/kubernetes","homepage":null,"size":162169,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b73f83d90491116e71e906a8deb379960961f634","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-08T22:25:42Z","pushed_at":"2016-02-09T00:30:35Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":321507,"stargazers_count":12575,"watchers_count":12575,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3578,"mirror_url":null,"open_issues_count":2816,"forks":3578,"open_issues":2816,"watchers":12575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20771"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20771"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20771/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20771/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d248aa62e3be690d95d51e45e9916ef8aa2d1c1b"}}}}