{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21","id":92731639,"html_url":"https://github.com/Administrate/surveymonkey/pull/21","diff_url":"https://github.com/Administrate/surveymonkey/pull/21.diff","patch_url":"https://github.com/Administrate/surveymonkey/pull/21.patch","issue_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/21","number":21,"state":"closed","locked":false,"title":"Housekeeping","user":{"login":"aaronbassett","id":97928,"avatar_url":"https://avatars.githubusercontent.com/u/97928?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronbassett","html_url":"https://github.com/aaronbassett","followers_url":"https://api.github.com/users/aaronbassett/followers","following_url":"https://api.github.com/users/aaronbassett/following{/other_user}","gists_url":"https://api.github.com/users/aaronbassett/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronbassett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronbassett/subscriptions","organizations_url":"https://api.github.com/users/aaronbassett/orgs","repos_url":"https://api.github.com/users/aaronbassett/repos","events_url":"https://api.github.com/users/aaronbassett/events{/privacy}","received_events_url":"https://api.github.com/users/aaronbassett/received_events","type":"User","site_admin":false},"body":"# Some general housekeeping\r\n\r\n![Good housekeeping](http://i.imgur.com/jxnhtrt.png)\r\n\r\n* Halved test times by being a bit chary about initialising `Faker`\r\n* Added some more unhappy path tests\r\n* imports started to get confusing, so converted all imports to be absolute\r\n* Some small pep8 fixes in test files\r\n* Updated .gitignore\r\n\r\n---\r\n\r\n## Checklist\r\n\r\n- [x] Meets criteria\r\n- [x] Is modular & tested\r\n- [x] Readable code\r\n- [x] No duplication\r\n- [x] Clear commits\r\n- ~Documentation updated~\r\n- [x] Handled error cases\r\n- [x] **Code always improving**\r\n\r\nhttps://www.pivotaltracker.com/story/show/133614415\r\n","created_at":"2016-11-08T08:06:37Z","updated_at":"2016-11-08T10:08:24Z","closed_at":"2016-11-08T10:08:24Z","merged_at":"2016-11-08T10:08:24Z","merge_commit_sha":"9a359b13b80023b713f90a4f3cd7e3241c4eb87b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Administrate/surveymonkey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/21/comments","statuses_url":"https://api.github.com/repos/Administrate/surveymonkey/statuses/3f1f7db641d96fb26421a832807185fc129cdb28","head":{"label":"Administrate:PT133614415-Add-more-tests-and-some-clean-up","ref":"PT133614415-Add-more-tests-and-some-clean-up","sha":"3f1f7db641d96fb26421a832807185fc129cdb28","user":{"login":"Administrate","id":1012646,"avatar_url":"https://avatars.githubusercontent.com/u/1012646?v=3","gravatar_id":"","url":"https://api.github.com/users/Administrate","html_url":"https://github.com/Administrate","followers_url":"https://api.github.com/users/Administrate/followers","following_url":"https://api.github.com/users/Administrate/following{/other_user}","gists_url":"https://api.github.com/users/Administrate/gists{/gist_id}","starred_url":"https://api.github.com/users/Administrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Administrate/subscriptions","organizations_url":"https://api.github.com/users/Administrate/orgs","repos_url":"https://api.github.com/users/Administrate/repos","events_url":"https://api.github.com/users/Administrate/events{/privacy}","received_events_url":"https://api.github.com/users/Administrate/received_events","type":"Organization","site_admin":false},"repo":{"id":69564318,"name":"surveymonkey","full_name":"Administrate/surveymonkey","owner":{"login":"Administrate","id":1012646,"avatar_url":"https://avatars.githubusercontent.com/u/1012646?v=3","gravatar_id":"","url":"https://api.github.com/users/Administrate","html_url":"https://github.com/Administrate","followers_url":"https://api.github.com/users/Administrate/followers","following_url":"https://api.github.com/users/Administrate/following{/other_user}","gists_url":"https://api.github.com/users/Administrate/gists{/gist_id}","starred_url":"https://api.github.com/users/Administrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Administrate/subscriptions","organizations_url":"https://api.github.com/users/Administrate/orgs","repos_url":"https://api.github.com/users/Administrate/repos","events_url":"https://api.github.com/users/Administrate/events{/privacy}","received_events_url":"https://api.github.com/users/Administrate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Administrate/surveymonkey","description":null,"fork":false,"url":"https://api.github.com/repos/Administrate/surveymonkey","forks_url":"https://api.github.com/repos/Administrate/surveymonkey/forks","keys_url":"https://api.github.com/repos/Administrate/surveymonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Administrate/surveymonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Administrate/surveymonkey/teams","hooks_url":"https://api.github.com/repos/Administrate/surveymonkey/hooks","issue_events_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/events{/number}","events_url":"https://api.github.com/repos/Administrate/surveymonkey/events","assignees_url":"https://api.github.com/repos/Administrate/surveymonkey/assignees{/user}","branches_url":"https://api.github.com/repos/Administrate/surveymonkey/branches{/branch}","tags_url":"https://api.github.com/repos/Administrate/surveymonkey/tags","blobs_url":"https://api.github.com/repos/Administrate/surveymonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Administrate/surveymonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Administrate/surveymonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/Administrate/surveymonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Administrate/surveymonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/Administrate/surveymonkey/languages","stargazers_url":"https://api.github.com/repos/Administrate/surveymonkey/stargazers","contributors_url":"https://api.github.com/repos/Administrate/surveymonkey/contributors","subscribers_url":"https://api.github.com/repos/Administrate/surveymonkey/subscribers","subscription_url":"https://api.github.com/repos/Administrate/surveymonkey/subscription","commits_url":"https://api.github.com/repos/Administrate/surveymonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/Administrate/surveymonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/Administrate/surveymonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/Administrate/surveymonkey/contents/{+path}","compare_url":"https://api.github.com/repos/Administrate/surveymonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Administrate/surveymonkey/merges","archive_url":"https://api.github.com/repos/Administrate/surveymonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Administrate/surveymonkey/downloads","issues_url":"https://api.github.com/repos/Administrate/surveymonkey/issues{/number}","pulls_url":"https://api.github.com/repos/Administrate/surveymonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/Administrate/surveymonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/Administrate/surveymonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Administrate/surveymonkey/labels{/name}","releases_url":"https://api.github.com/repos/Administrate/surveymonkey/releases{/id}","deployments_url":"https://api.github.com/repos/Administrate/surveymonkey/deployments","created_at":"2016-09-29T12:13:36Z","updated_at":"2016-11-03T13:00:33Z","pushed_at":"2016-11-08T10:08:24Z","git_url":"git://github.com/Administrate/surveymonkey.git","ssh_url":"git@github.com:Administrate/surveymonkey.git","clone_url":"https://github.com/Administrate/surveymonkey.git","svn_url":"https://github.com/Administrate/surveymonkey","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Administrate:master","ref":"master","sha":"48ff19dd2969bbf1a8e3c5584f594784f6e61049","user":{"login":"Administrate","id":1012646,"avatar_url":"https://avatars.githubusercontent.com/u/1012646?v=3","gravatar_id":"","url":"https://api.github.com/users/Administrate","html_url":"https://github.com/Administrate","followers_url":"https://api.github.com/users/Administrate/followers","following_url":"https://api.github.com/users/Administrate/following{/other_user}","gists_url":"https://api.github.com/users/Administrate/gists{/gist_id}","starred_url":"https://api.github.com/users/Administrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Administrate/subscriptions","organizations_url":"https://api.github.com/users/Administrate/orgs","repos_url":"https://api.github.com/users/Administrate/repos","events_url":"https://api.github.com/users/Administrate/events{/privacy}","received_events_url":"https://api.github.com/users/Administrate/received_events","type":"Organization","site_admin":false},"repo":{"id":69564318,"name":"surveymonkey","full_name":"Administrate/surveymonkey","owner":{"login":"Administrate","id":1012646,"avatar_url":"https://avatars.githubusercontent.com/u/1012646?v=3","gravatar_id":"","url":"https://api.github.com/users/Administrate","html_url":"https://github.com/Administrate","followers_url":"https://api.github.com/users/Administrate/followers","following_url":"https://api.github.com/users/Administrate/following{/other_user}","gists_url":"https://api.github.com/users/Administrate/gists{/gist_id}","starred_url":"https://api.github.com/users/Administrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Administrate/subscriptions","organizations_url":"https://api.github.com/users/Administrate/orgs","repos_url":"https://api.github.com/users/Administrate/repos","events_url":"https://api.github.com/users/Administrate/events{/privacy}","received_events_url":"https://api.github.com/users/Administrate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Administrate/surveymonkey","description":null,"fork":false,"url":"https://api.github.com/repos/Administrate/surveymonkey","forks_url":"https://api.github.com/repos/Administrate/surveymonkey/forks","keys_url":"https://api.github.com/repos/Administrate/surveymonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Administrate/surveymonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Administrate/surveymonkey/teams","hooks_url":"https://api.github.com/repos/Administrate/surveymonkey/hooks","issue_events_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/events{/number}","events_url":"https://api.github.com/repos/Administrate/surveymonkey/events","assignees_url":"https://api.github.com/repos/Administrate/surveymonkey/assignees{/user}","branches_url":"https://api.github.com/repos/Administrate/surveymonkey/branches{/branch}","tags_url":"https://api.github.com/repos/Administrate/surveymonkey/tags","blobs_url":"https://api.github.com/repos/Administrate/surveymonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Administrate/surveymonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Administrate/surveymonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/Administrate/surveymonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Administrate/surveymonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/Administrate/surveymonkey/languages","stargazers_url":"https://api.github.com/repos/Administrate/surveymonkey/stargazers","contributors_url":"https://api.github.com/repos/Administrate/surveymonkey/contributors","subscribers_url":"https://api.github.com/repos/Administrate/surveymonkey/subscribers","subscription_url":"https://api.github.com/repos/Administrate/surveymonkey/subscription","commits_url":"https://api.github.com/repos/Administrate/surveymonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/Administrate/surveymonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/Administrate/surveymonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/Administrate/surveymonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/Administrate/surveymonkey/contents/{+path}","compare_url":"https://api.github.com/repos/Administrate/surveymonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Administrate/surveymonkey/merges","archive_url":"https://api.github.com/repos/Administrate/surveymonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Administrate/surveymonkey/downloads","issues_url":"https://api.github.com/repos/Administrate/surveymonkey/issues{/number}","pulls_url":"https://api.github.com/repos/Administrate/surveymonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/Administrate/surveymonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/Administrate/surveymonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Administrate/surveymonkey/labels{/name}","releases_url":"https://api.github.com/repos/Administrate/surveymonkey/releases{/id}","deployments_url":"https://api.github.com/repos/Administrate/surveymonkey/deployments","created_at":"2016-09-29T12:13:36Z","updated_at":"2016-11-03T13:00:33Z","pushed_at":"2016-11-08T10:08:24Z","git_url":"git://github.com/Administrate/surveymonkey.git","ssh_url":"git@github.com:Administrate/surveymonkey.git","clone_url":"https://github.com/Administrate/surveymonkey.git","svn_url":"https://github.com/Administrate/surveymonkey","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21"},"html":{"href":"https://github.com/Administrate/surveymonkey/pull/21"},"issue":{"href":"https://api.github.com/repos/Administrate/surveymonkey/issues/21"},"comments":{"href":"https://api.github.com/repos/Administrate/surveymonkey/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Administrate/surveymonkey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Administrate/surveymonkey/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Administrate/surveymonkey/statuses/3f1f7db641d96fb26421a832807185fc129cdb28"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ruu1989","id":1401632,"avatar_url":"https://avatars.githubusercontent.com/u/1401632?v=3","gravatar_id":"","url":"https://api.github.com/users/ruu1989","html_url":"https://github.com/ruu1989","followers_url":"https://api.github.com/users/ruu1989/followers","following_url":"https://api.github.com/users/ruu1989/following{/other_user}","gists_url":"https://api.github.com/users/ruu1989/gists{/gist_id}","starred_url":"https://api.github.com/users/ruu1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruu1989/subscriptions","organizations_url":"https://api.github.com/users/ruu1989/orgs","repos_url":"https://api.github.com/users/ruu1989/repos","events_url":"https://api.github.com/users/ruu1989/events{/privacy}","received_events_url":"https://api.github.com/users/ruu1989/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":6,"additions":227,"deletions":88,"changed_files":46}}
{"actor":{"display_login":"ruu1989"}}