{"action":"created","issue":{"url":"https://api.github.com/repos/claunia/plist-cil/issues/2","repository_url":"https://api.github.com/repos/claunia/plist-cil","labels_url":"https://api.github.com/repos/claunia/plist-cil/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/claunia/plist-cil/issues/2/comments","events_url":"https://api.github.com/repos/claunia/plist-cil/issues/2/events","html_url":"https://github.com/claunia/plist-cil/pull/2","id":131724181,"number":2,"title":"Minor enhancements to plist-cil","user":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars.githubusercontent.com/u/9918129?v=3","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-05T18:51:42Z","updated_at":"2016-02-17T20:14:54Z","closed_at":"2016-02-16T14:44:21Z","pull_request":{"url":"https://api.github.com/repos/claunia/plist-cil/pulls/2","html_url":"https://github.com/claunia/plist-cil/pull/2","diff_url":"https://github.com/claunia/plist-cil/pull/2.diff","patch_url":"https://github.com/claunia/plist-cil/pull/2.patch"},"body":"Hi,\r\n\r\nI used plist-cil and encoutered some minor issues; so here is a pull request which should address them:\r\n\r\n* An empty array (of size 0) could not be serialized using the `BinaryPropertyListWriter` because there was a check for a 0-integer value. I changed it to check for negative values; the code now passes.\r\n* The order in which IDs are generated differs from the way the Apple libraries generate IDs (they generate IDs first for the keys and then for the values). I updated the code so that it follows the same pattern as Apple's code - ensuring binary compatibility.\r\n* plist-cil was not strong named; my assembly was; so I added a strong name to the plist-cil project"},"comment":{"url":"https://api.github.com/repos/claunia/plist-cil/issues/comments/185383446","html_url":"https://github.com/claunia/plist-cil/pull/2#issuecomment-185383446","issue_url":"https://api.github.com/repos/claunia/plist-cil/issues/2","id":185383446,"user":{"login":"3breadt","id":1140937,"avatar_url":"https://avatars.githubusercontent.com/u/1140937?v=3","gravatar_id":"","url":"https://api.github.com/users/3breadt","html_url":"https://github.com/3breadt","followers_url":"https://api.github.com/users/3breadt/followers","following_url":"https://api.github.com/users/3breadt/following{/other_user}","gists_url":"https://api.github.com/users/3breadt/gists{/gist_id}","starred_url":"https://api.github.com/users/3breadt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3breadt/subscriptions","organizations_url":"https://api.github.com/users/3breadt/orgs","repos_url":"https://api.github.com/users/3breadt/repos","events_url":"https://api.github.com/users/3breadt/events{/privacy}","received_events_url":"https://api.github.com/users/3breadt/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T20:14:54Z","updated_at":"2016-02-17T20:14:54Z","body":"Some of the improvements really make sense and would benefit [dd-plist](https://github.com/3breadt/dd-plist). But I am not sure whether equivalent arrays really should be saved multiple times. Is that also just for binary compatibility with the plists produced by Apple's code?"}}