{"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48","id":82900507,"html_url":"https://github.com/bencripps/react-redux-grid/pull/48","diff_url":"https://github.com/bencripps/react-redux-grid/pull/48.diff","patch_url":"https://github.com/bencripps/react-redux-grid/pull/48.patch","issue_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/48","number":48,"state":"open","locked":false,"title":"Feature/casing","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"body":"This is a semi-breaking change, so it will be released as a minor version.\r\n\r\nBefore this change, the `reducers` were exposed as this object:\r\n````js\r\nexport const Reducers = {\r\n    BulkActions: bulkaction,\r\n    DataSource: dataSource,\r\n    Editor: editor,\r\n    ErrorHandler: errorhandler,\r\n    Grid: grid,\r\n    Loader: loader,\r\n    Menu: menu,\r\n    Pager: pager,\r\n    Selection: selection\r\n};\r\n````\r\n\r\nThis worked OK, but it proved to be problematic when a developer tried to import the reducers into their own store. The desired behavior would be to:\r\n\r\n````js\r\nexport const rootReducer = combineReducers({\r\n    myAppReducer,\r\n    myDataReducer,\r\n    ...gridReducers\r\n});\r\n````\r\n\r\nbut the casing would bork, because it would read `DataSource` instead of `dataSource`. Currently the grid anaylzes `reducer-keys` in a case-insensitive manner, so this wouldn't cause issues -- it is however, relatively slow in comparison. This MR changes the reducer export to:\r\n\r\n````js\r\nexport const Reducers = {\r\n    bulkAction,\r\n    dataSource,\r\n    editor,\r\n    errorHandler,\r\n    grid,\r\n    loader,\r\n    menu,\r\n    pager,\r\n    selection\r\n};\r\n````\r\n\r\nso you can now simply spread the grid `reducer` export in your custom reducer object. For now, case-insensitivity issues for `reducers` will only throw a warning in the console. **In the next major version, this feature will be removed, causing unmodified versions to break**\r\n\r\n","created_at":"2016-08-26T14:46:15Z","updated_at":"2016-08-26T14:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8311e6de04c7049a38da5710a8e542790ac7a379","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48/commits","review_comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48/comments","review_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/48/comments","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/df78053c5e9680a31a68e7bfab84044b23c2bc4f","head":{"label":"bencripps:feature/casing","ref":"feature/casing","sha":"df78053c5e9680a31a68e7bfab84044b23c2bc4f","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"repo":{"id":49901310,"name":"react-redux-grid","full_name":"bencripps/react-redux-grid","owner":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencripps/react-redux-grid","description":"A React Grid/Tree Component written in the Redux Pattern ","fork":false,"url":"https://api.github.com/repos/bencripps/react-redux-grid","forks_url":"https://api.github.com/repos/bencripps/react-redux-grid/forks","keys_url":"https://api.github.com/repos/bencripps/react-redux-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencripps/react-redux-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencripps/react-redux-grid/teams","hooks_url":"https://api.github.com/repos/bencripps/react-redux-grid/hooks","issue_events_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/events{/number}","events_url":"https://api.github.com/repos/bencripps/react-redux-grid/events","assignees_url":"https://api.github.com/repos/bencripps/react-redux-grid/assignees{/user}","branches_url":"https://api.github.com/repos/bencripps/react-redux-grid/branches{/branch}","tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/tags","blobs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/bencripps/react-redux-grid/languages","stargazers_url":"https://api.github.com/repos/bencripps/react-redux-grid/stargazers","contributors_url":"https://api.github.com/repos/bencripps/react-redux-grid/contributors","subscribers_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscribers","subscription_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscription","commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencripps/react-redux-grid/contents/{+path}","compare_url":"https://api.github.com/repos/bencripps/react-redux-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencripps/react-redux-grid/merges","archive_url":"https://api.github.com/repos/bencripps/react-redux-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencripps/react-redux-grid/downloads","issues_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues{/number}","pulls_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/bencripps/react-redux-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/bencripps/react-redux-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencripps/react-redux-grid/labels{/name}","releases_url":"https://api.github.com/repos/bencripps/react-redux-grid/releases{/id}","deployments_url":"https://api.github.com/repos/bencripps/react-redux-grid/deployments","created_at":"2016-01-18T19:54:56Z","updated_at":"2016-08-25T15:21:40Z","pushed_at":"2016-08-26T14:46:15Z","git_url":"git://github.com/bencripps/react-redux-grid.git","ssh_url":"git@github.com:bencripps/react-redux-grid.git","clone_url":"https://github.com/bencripps/react-redux-grid.git","svn_url":"https://github.com/bencripps/react-redux-grid","homepage":"http://react-redux-grid.herokuapp.com/","size":2914,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":27,"default_branch":"master"}},"base":{"label":"bencripps:master","ref":"master","sha":"1ade75aca48758b8efeecdce7bfefadbeb424b20","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"repo":{"id":49901310,"name":"react-redux-grid","full_name":"bencripps/react-redux-grid","owner":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencripps/react-redux-grid","description":"A React Grid/Tree Component written in the Redux Pattern ","fork":false,"url":"https://api.github.com/repos/bencripps/react-redux-grid","forks_url":"https://api.github.com/repos/bencripps/react-redux-grid/forks","keys_url":"https://api.github.com/repos/bencripps/react-redux-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencripps/react-redux-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencripps/react-redux-grid/teams","hooks_url":"https://api.github.com/repos/bencripps/react-redux-grid/hooks","issue_events_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/events{/number}","events_url":"https://api.github.com/repos/bencripps/react-redux-grid/events","assignees_url":"https://api.github.com/repos/bencripps/react-redux-grid/assignees{/user}","branches_url":"https://api.github.com/repos/bencripps/react-redux-grid/branches{/branch}","tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/tags","blobs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/bencripps/react-redux-grid/languages","stargazers_url":"https://api.github.com/repos/bencripps/react-redux-grid/stargazers","contributors_url":"https://api.github.com/repos/bencripps/react-redux-grid/contributors","subscribers_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscribers","subscription_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscription","commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencripps/react-redux-grid/contents/{+path}","compare_url":"https://api.github.com/repos/bencripps/react-redux-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencripps/react-redux-grid/merges","archive_url":"https://api.github.com/repos/bencripps/react-redux-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencripps/react-redux-grid/downloads","issues_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues{/number}","pulls_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/bencripps/react-redux-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/bencripps/react-redux-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencripps/react-redux-grid/labels{/name}","releases_url":"https://api.github.com/repos/bencripps/react-redux-grid/releases{/id}","deployments_url":"https://api.github.com/repos/bencripps/react-redux-grid/deployments","created_at":"2016-01-18T19:54:56Z","updated_at":"2016-08-25T15:21:40Z","pushed_at":"2016-08-26T14:46:15Z","git_url":"git://github.com/bencripps/react-redux-grid.git","ssh_url":"git@github.com:bencripps/react-redux-grid.git","clone_url":"https://github.com/bencripps/react-redux-grid.git","svn_url":"https://github.com/bencripps/react-redux-grid","homepage":"http://react-redux-grid.herokuapp.com/","size":2914,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48"},"html":{"href":"https://github.com/bencripps/react-redux-grid/pull/48"},"issue":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/issues/48"},"comments":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/df78053c5e9680a31a68e7bfab84044b23c2bc4f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":169,"deletions":54,"changed_files":10}}
{"actor":{"display_login":"bencripps"}}