{"action":"created","comment":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76531036","id":76531036,"diff_hunk":"@@ -250,14 +251,7 @@ public void removeFromUserMap(final String region, final String race, final Stri\n \t\tfinal String key;\n \t\tfinal int x = tag.indexOf(':');\n \n-\t\tif (x < 0)\n-\t\t{\n-\t\t\tkey = tag;\n-\t\t}\n-\t\telse\n-\t\t{\n-\t\t\tkey = tag.substring(0, x);\n-\t\t}\n+\t\tkey = x < 0 ? tag : tag.substring(0, x);","path":"code/src/java/pcgen/core/BioSet.java","position":35,"original_position":35,"commit_id":"c1b0faa667985aecfdf409c646b6d1af2e369549","original_commit_id":"c1b0faa667985aecfdf409c646b6d1af2e369549","user":{"login":"thpr","id":8837174,"avatar_url":"https://avatars.githubusercontent.com/u/8837174?v=3","gravatar_id":"","url":"https://api.github.com/users/thpr","html_url":"https://github.com/thpr","followers_url":"https://api.github.com/users/thpr/followers","following_url":"https://api.github.com/users/thpr/following{/other_user}","gists_url":"https://api.github.com/users/thpr/gists{/gist_id}","starred_url":"https://api.github.com/users/thpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thpr/subscriptions","organizations_url":"https://api.github.com/users/thpr/orgs","repos_url":"https://api.github.com/users/thpr/repos","events_url":"https://api.github.com/users/thpr/events{/privacy}","received_events_url":"https://api.github.com/users/thpr/received_events","type":"User","site_admin":false},"body":"This type of in-lining is controversial of whether it is a best practice.  Before we make these types of changes, we need a discussion on the code list as to best practices.  I happen to dislike this usage because the \"x < 0\" is not in parenthesis and thus the line is harder to interpret.","created_at":"2016-08-28T12:27:27Z","updated_at":"2016-08-28T12:27:27Z","html_url":"https://github.com/PCGen/pcgen/pull/1491#discussion_r76531036","pull_request_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1491","_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76531036"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1491#discussion_r76531036"},"pull_request":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1491"}}},"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/1491","id":83007120,"html_url":"https://github.com/PCGen/pcgen/pull/1491","diff_url":"https://github.com/PCGen/pcgen/pull/1491.diff","patch_url":"https://github.com/PCGen/pcgen/pull/1491.patch","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/1491","number":1491,"state":"open","locked":false,"title":"move attribute fields outside of PlayerCharacter","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"Rather than keep PlayerCharacter attributes hardcoded with specific getters and setters for each, move them into appropriate enum types.","created_at":"2016-08-28T05:48:26Z","updated_at":"2016-08-28T12:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ec167135e5bb18089bf1649d4a3cd0da20ff993","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1491/commits","review_comments_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1491/comments","review_comment_url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/1491/comments","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/c1b0faa667985aecfdf409c646b6d1af2e369549","head":{"label":"grimreaper:eax/pcgen-core","ref":"eax/pcgen-core","sha":"c1b0faa667985aecfdf409c646b6d1af2e369549","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":43053313,"name":"pcgen","full_name":"grimreaper/pcgen","owner":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grimreaper/pcgen","description":"Main code and data development for pcgen program release","fork":true,"url":"https://api.github.com/repos/grimreaper/pcgen","forks_url":"https://api.github.com/repos/grimreaper/pcgen/forks","keys_url":"https://api.github.com/repos/grimreaper/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/pcgen/teams","hooks_url":"https://api.github.com/repos/grimreaper/pcgen/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/pcgen/events","assignees_url":"https://api.github.com/repos/grimreaper/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/pcgen/tags","blobs_url":"https://api.github.com/repos/grimreaper/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/pcgen/languages","stargazers_url":"https://api.github.com/repos/grimreaper/pcgen/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/pcgen/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/pcgen/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/pcgen/subscription","commits_url":"https://api.github.com/repos/grimreaper/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/pcgen/merges","archive_url":"https://api.github.com/repos/grimreaper/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/pcgen/downloads","issues_url":"https://api.github.com/repos/grimreaper/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/grimreaper/pcgen/deployments","created_at":"2015-09-24T08:01:43Z","updated_at":"2016-08-26T10:41:32Z","pushed_at":"2016-08-28T07:05:05Z","git_url":"git://github.com/grimreaper/pcgen.git","ssh_url":"git@github.com:grimreaper/pcgen.git","clone_url":"https://github.com/grimreaper/pcgen.git","svn_url":"https://github.com/grimreaper/pcgen","homepage":"http://pcgen.org","size":217859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCGen:master","ref":"master","sha":"b8d8187b08d9c56d38241173639e644c847f67dc","user":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"repo":{"id":28585874,"name":"pcgen","full_name":"PCGen/pcgen","owner":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCGen/pcgen","description":"Main code and data development for pcgen program release","fork":false,"url":"https://api.github.com/repos/PCGen/pcgen","forks_url":"https://api.github.com/repos/PCGen/pcgen/forks","keys_url":"https://api.github.com/repos/PCGen/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCGen/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCGen/pcgen/teams","hooks_url":"https://api.github.com/repos/PCGen/pcgen/hooks","issue_events_url":"https://api.github.com/repos/PCGen/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/PCGen/pcgen/events","assignees_url":"https://api.github.com/repos/PCGen/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/PCGen/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/PCGen/pcgen/tags","blobs_url":"https://api.github.com/repos/PCGen/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCGen/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCGen/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCGen/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/PCGen/pcgen/languages","stargazers_url":"https://api.github.com/repos/PCGen/pcgen/stargazers","contributors_url":"https://api.github.com/repos/PCGen/pcgen/contributors","subscribers_url":"https://api.github.com/repos/PCGen/pcgen/subscribers","subscription_url":"https://api.github.com/repos/PCGen/pcgen/subscription","commits_url":"https://api.github.com/repos/PCGen/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCGen/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCGen/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCGen/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCGen/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/PCGen/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCGen/pcgen/merges","archive_url":"https://api.github.com/repos/PCGen/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCGen/pcgen/downloads","issues_url":"https://api.github.com/repos/PCGen/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/PCGen/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/PCGen/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/PCGen/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCGen/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/PCGen/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/PCGen/pcgen/deployments","created_at":"2014-12-29T08:41:04Z","updated_at":"2016-08-23T17:12:52Z","pushed_at":"2016-08-28T07:19:55Z","git_url":"git://github.com/PCGen/pcgen.git","ssh_url":"git@github.com:PCGen/pcgen.git","clone_url":"https://github.com/PCGen/pcgen.git","svn_url":"https://github.com/PCGen/pcgen","homepage":"http://pcgen.org","size":238323,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":7,"forks":80,"open_issues":7,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1491"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1491"},"issue":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1491"},"comments":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1491/comments"},"review_comments":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1491/comments"},"review_comment":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1491/commits"},"statuses":{"href":"https://api.github.com/repos/PCGen/pcgen/statuses/c1b0faa667985aecfdf409c646b6d1af2e369549"}}}}
{"actor":{"display_login":"thpr"}}