{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/Automattic/social-logos/pulls/43","id":94055417,"html_url":"https://github.com/Automattic/social-logos/pull/43","diff_url":"https://github.com/Automattic/social-logos/pull/43.diff","patch_url":"https://github.com/Automattic/social-logos/pull/43.patch","issue_url":"https://api.github.com/repos/Automattic/social-logos/issues/43","number":43,"state":"closed","locked":false,"title":"Remove classname peer dependency","user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"body":"This is a follow up to #42 where we\r\n- Add peerDependency definitions to package.json. Note that npm 3 will only warn and no longer installs missing peer dependencies. For example attempting to install with empty node_modules will prompt: `npm WARN social-logos@1.0.1 requires a peer of react@>=14.x but none was installed.`\r\n- Add an `npm run build` script\r\n- Add a prepublish script and remove any generated files from git. This will run before `npm publish` and during `npm install`\r\n- Remove the classname dependency\r\n- Remove comments from the minified `build/index.js` file\r\n- Minify and publish the example component\r\n\r\n## Testing\r\n- `npm install`\r\n- install required system deps from https://github.com/sapegin/grunt-webfont\r\n- `npm run build`\r\n- No differences in generated files. \r\n- Make a change to an svg\r\n- `npm run build` generates changes\r\n- Calypso usage works: https://github.com/Automattic/wp-calypso/pull/9449\r\n## Steps after merging\r\n- [ ] Publish version 1.0.1 to npm with tag latest\r\n- `npm publish --tag latest`\r\n\r\ncc @aduth @lamosty @retrofox  ","created_at":"2016-11-16T21:37:58Z","updated_at":"2016-11-23T17:49:27Z","closed_at":"2016-11-23T17:49:26Z","merged_at":"2016-11-23T17:49:26Z","merge_commit_sha":"f4c9505b0314b0b273d1d3168f9c14965c4e0256","assignee":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"assignees":[{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/social-logos/pulls/43/commits","review_comments_url":"https://api.github.com/repos/Automattic/social-logos/pulls/43/comments","review_comment_url":"https://api.github.com/repos/Automattic/social-logos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/social-logos/issues/43/comments","statuses_url":"https://api.github.com/repos/Automattic/social-logos/statuses/6ce253c170cb4f51c355ea7077d03c5a9a641110","head":{"label":"Automattic:add/peer-dependencies","ref":"add/peer-dependencies","sha":"6ce253c170cb4f51c355ea7077d03c5a9a641110","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":42674027,"name":"social-logos","full_name":"Automattic/social-logos","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/social-logos","description":"A repository of all the social logos we use on WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/social-logos","forks_url":"https://api.github.com/repos/Automattic/social-logos/forks","keys_url":"https://api.github.com/repos/Automattic/social-logos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/social-logos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/social-logos/teams","hooks_url":"https://api.github.com/repos/Automattic/social-logos/hooks","issue_events_url":"https://api.github.com/repos/Automattic/social-logos/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/social-logos/events","assignees_url":"https://api.github.com/repos/Automattic/social-logos/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/social-logos/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/social-logos/tags","blobs_url":"https://api.github.com/repos/Automattic/social-logos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/social-logos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/social-logos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/social-logos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/social-logos/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/social-logos/languages","stargazers_url":"https://api.github.com/repos/Automattic/social-logos/stargazers","contributors_url":"https://api.github.com/repos/Automattic/social-logos/contributors","subscribers_url":"https://api.github.com/repos/Automattic/social-logos/subscribers","subscription_url":"https://api.github.com/repos/Automattic/social-logos/subscription","commits_url":"https://api.github.com/repos/Automattic/social-logos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/social-logos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/social-logos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/social-logos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/social-logos/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/social-logos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/social-logos/merges","archive_url":"https://api.github.com/repos/Automattic/social-logos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/social-logos/downloads","issues_url":"https://api.github.com/repos/Automattic/social-logos/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/social-logos/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/social-logos/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/social-logos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/social-logos/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/social-logos/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/social-logos/deployments","created_at":"2015-09-17T18:27:13Z","updated_at":"2016-10-31T03:26:53Z","pushed_at":"2016-11-23T17:49:27Z","git_url":"git://github.com/Automattic/social-logos.git","ssh_url":"git@github.com:Automattic/social-logos.git","clone_url":"https://github.com/Automattic/social-logos.git","svn_url":"https://github.com/Automattic/social-logos","homepage":"","size":4859,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":15,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"edad720730a854a20a98ae2a1511216c600fcd22","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":42674027,"name":"social-logos","full_name":"Automattic/social-logos","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/social-logos","description":"A repository of all the social logos we use on WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/social-logos","forks_url":"https://api.github.com/repos/Automattic/social-logos/forks","keys_url":"https://api.github.com/repos/Automattic/social-logos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/social-logos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/social-logos/teams","hooks_url":"https://api.github.com/repos/Automattic/social-logos/hooks","issue_events_url":"https://api.github.com/repos/Automattic/social-logos/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/social-logos/events","assignees_url":"https://api.github.com/repos/Automattic/social-logos/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/social-logos/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/social-logos/tags","blobs_url":"https://api.github.com/repos/Automattic/social-logos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/social-logos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/social-logos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/social-logos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/social-logos/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/social-logos/languages","stargazers_url":"https://api.github.com/repos/Automattic/social-logos/stargazers","contributors_url":"https://api.github.com/repos/Automattic/social-logos/contributors","subscribers_url":"https://api.github.com/repos/Automattic/social-logos/subscribers","subscription_url":"https://api.github.com/repos/Automattic/social-logos/subscription","commits_url":"https://api.github.com/repos/Automattic/social-logos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/social-logos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/social-logos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/social-logos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/social-logos/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/social-logos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/social-logos/merges","archive_url":"https://api.github.com/repos/Automattic/social-logos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/social-logos/downloads","issues_url":"https://api.github.com/repos/Automattic/social-logos/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/social-logos/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/social-logos/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/social-logos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/social-logos/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/social-logos/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/social-logos/deployments","created_at":"2015-09-17T18:27:13Z","updated_at":"2016-10-31T03:26:53Z","pushed_at":"2016-11-23T17:49:27Z","git_url":"git://github.com/Automattic/social-logos.git","ssh_url":"git@github.com:Automattic/social-logos.git","clone_url":"https://github.com/Automattic/social-logos.git","svn_url":"https://github.com/Automattic/social-logos","homepage":"","size":4859,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/social-logos/pulls/43"},"html":{"href":"https://github.com/Automattic/social-logos/pull/43"},"issue":{"href":"https://api.github.com/repos/Automattic/social-logos/issues/43"},"comments":{"href":"https://api.github.com/repos/Automattic/social-logos/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/social-logos/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/social-logos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/social-logos/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/social-logos/statuses/6ce253c170cb4f51c355ea7077d03c5a9a641110"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"comments":2,"review_comments":12,"commits":12,"additions":28,"deletions":2047,"changed_files":64}}
{"actor":{"display_login":"gwwar"}}