{"action":"created","comment":{"url":"https://api.github.com/repos/commercialhaskell/stack/pulls/comments/66774446","id":66774446,"diff_hunk":"@@ -840,6 +842,8 @@ data ConfigMonoid =\n     -- ^ See: 'configExtraIncludeDirs'\n     ,configMonoidExtraLibDirs        :: !(Set Text)\n     -- ^ See: 'configExtraLibDirs'\n+    , configMonoidOverrideGccPath    :: !(First Text)","path":"src/Stack/Types/Config.hs","position":13,"original_position":13,"commit_id":"900dd4d4182636671e7d046c14d95d4efb1949fa","original_commit_id":"9d61f81fe1bf729985be5ce2593abd10f625ec0b","user":{"login":"sjakobi","id":3664523,"avatar_url":"https://avatars.githubusercontent.com/u/3664523?v=3","gravatar_id":"","url":"https://api.github.com/users/sjakobi","html_url":"https://github.com/sjakobi","followers_url":"https://api.github.com/users/sjakobi/followers","following_url":"https://api.github.com/users/sjakobi/following{/other_user}","gists_url":"https://api.github.com/users/sjakobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sjakobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjakobi/subscriptions","organizations_url":"https://api.github.com/users/sjakobi/orgs","repos_url":"https://api.github.com/users/sjakobi/repos","events_url":"https://api.github.com/users/sjakobi/events{/privacy}","received_events_url":"https://api.github.com/users/sjakobi/received_events","type":"User","site_admin":false},"body":"Personally, I'd prefer a `First (Path Abs File)` here.\r\n\r\nThe main advantage I'd expect from that, would be better error messages than those that we currently relay from `cabal` or `ghc`.\r\n\r\nI also think that this should be done \"categorically\", so for `configMonoidExtraIncludeDirs` and `configMonoidExtraLibDirs` too.\r\n\r\n`Options.Applicative.Builder.eitherReader` would probably be a useful helper function for this.","created_at":"2016-06-13T11:05:17Z","updated_at":"2016-06-13T11:05:17Z","html_url":"https://github.com/commercialhaskell/stack/pull/2264#discussion_r66774446","pull_request_url":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264","_links":{"self":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/comments/66774446"},"html":{"href":"https://github.com/commercialhaskell/stack/pull/2264#discussion_r66774446"},"pull_request":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264"}}},"pull_request":{"url":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264","id":73457589,"html_url":"https://github.com/commercialhaskell/stack/pull/2264","diff_url":"https://github.com/commercialhaskell/stack/pull/2264.diff","patch_url":"https://github.com/commercialhaskell/stack/pull/2264.patch","issue_url":"https://api.github.com/repos/commercialhaskell/stack/issues/2264","number":2264,"state":"open","locked":false,"title":"Add a config option to override gcc path","user":{"login":"khanage","id":483121,"avatar_url":"https://avatars.githubusercontent.com/u/483121?v=3","gravatar_id":"","url":"https://api.github.com/users/khanage","html_url":"https://github.com/khanage","followers_url":"https://api.github.com/users/khanage/followers","following_url":"https://api.github.com/users/khanage/following{/other_user}","gists_url":"https://api.github.com/users/khanage/gists{/gist_id}","starred_url":"https://api.github.com/users/khanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khanage/subscriptions","organizations_url":"https://api.github.com/users/khanage/orgs","repos_url":"https://api.github.com/users/khanage/repos","events_url":"https://api.github.com/users/khanage/events{/privacy}","received_events_url":"https://api.github.com/users/khanage/received_events","type":"User","site_admin":false},"body":"This allows one to specify `with-gcc:` in stack.yaml.\r\n\r\nHappy for any feedback - I just picked this up as it's marked with newcomer!\r\n\r\n","created_at":"2016-06-11T03:47:25Z","updated_at":"2016-06-13T11:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43c364d580641d1bc1f4320a4b64ca0e1099f9fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264/commits","review_comments_url":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264/comments","review_comment_url":"https://api.github.com/repos/commercialhaskell/stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercialhaskell/stack/issues/2264/comments","statuses_url":"https://api.github.com/repos/commercialhaskell/stack/statuses/900dd4d4182636671e7d046c14d95d4efb1949fa","head":{"label":"khanage:593_override_gcc_path","ref":"593_override_gcc_path","sha":"900dd4d4182636671e7d046c14d95d4efb1949fa","user":{"login":"khanage","id":483121,"avatar_url":"https://avatars.githubusercontent.com/u/483121?v=3","gravatar_id":"","url":"https://api.github.com/users/khanage","html_url":"https://github.com/khanage","followers_url":"https://api.github.com/users/khanage/followers","following_url":"https://api.github.com/users/khanage/following{/other_user}","gists_url":"https://api.github.com/users/khanage/gists{/gist_id}","starred_url":"https://api.github.com/users/khanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khanage/subscriptions","organizations_url":"https://api.github.com/users/khanage/orgs","repos_url":"https://api.github.com/users/khanage/repos","events_url":"https://api.github.com/users/khanage/events{/privacy}","received_events_url":"https://api.github.com/users/khanage/received_events","type":"User","site_admin":false},"repo":{"id":60889237,"name":"stack","full_name":"khanage/stack","owner":{"login":"khanage","id":483121,"avatar_url":"https://avatars.githubusercontent.com/u/483121?v=3","gravatar_id":"","url":"https://api.github.com/users/khanage","html_url":"https://github.com/khanage","followers_url":"https://api.github.com/users/khanage/followers","following_url":"https://api.github.com/users/khanage/following{/other_user}","gists_url":"https://api.github.com/users/khanage/gists{/gist_id}","starred_url":"https://api.github.com/users/khanage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khanage/subscriptions","organizations_url":"https://api.github.com/users/khanage/orgs","repos_url":"https://api.github.com/users/khanage/repos","events_url":"https://api.github.com/users/khanage/events{/privacy}","received_events_url":"https://api.github.com/users/khanage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khanage/stack","description":"The Haskell Tool Stack","fork":true,"url":"https://api.github.com/repos/khanage/stack","forks_url":"https://api.github.com/repos/khanage/stack/forks","keys_url":"https://api.github.com/repos/khanage/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khanage/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khanage/stack/teams","hooks_url":"https://api.github.com/repos/khanage/stack/hooks","issue_events_url":"https://api.github.com/repos/khanage/stack/issues/events{/number}","events_url":"https://api.github.com/repos/khanage/stack/events","assignees_url":"https://api.github.com/repos/khanage/stack/assignees{/user}","branches_url":"https://api.github.com/repos/khanage/stack/branches{/branch}","tags_url":"https://api.github.com/repos/khanage/stack/tags","blobs_url":"https://api.github.com/repos/khanage/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khanage/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khanage/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/khanage/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khanage/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/khanage/stack/languages","stargazers_url":"https://api.github.com/repos/khanage/stack/stargazers","contributors_url":"https://api.github.com/repos/khanage/stack/contributors","subscribers_url":"https://api.github.com/repos/khanage/stack/subscribers","subscription_url":"https://api.github.com/repos/khanage/stack/subscription","commits_url":"https://api.github.com/repos/khanage/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/khanage/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/khanage/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/khanage/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/khanage/stack/contents/{+path}","compare_url":"https://api.github.com/repos/khanage/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khanage/stack/merges","archive_url":"https://api.github.com/repos/khanage/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khanage/stack/downloads","issues_url":"https://api.github.com/repos/khanage/stack/issues{/number}","pulls_url":"https://api.github.com/repos/khanage/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/khanage/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/khanage/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khanage/stack/labels{/name}","releases_url":"https://api.github.com/repos/khanage/stack/releases{/id}","deployments_url":"https://api.github.com/repos/khanage/stack/deployments","created_at":"2016-06-11T03:30:37Z","updated_at":"2016-06-11T03:30:39Z","pushed_at":"2016-06-12T23:40:15Z","git_url":"git://github.com/khanage/stack.git","ssh_url":"git@github.com:khanage/stack.git","clone_url":"https://github.com/khanage/stack.git","svn_url":"https://github.com/khanage/stack","homepage":"http://haskellstack.org","size":7570,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"commercialhaskell:master","ref":"master","sha":"7f7f1a5f67f4ecdd1f3009495f1ff101dd38047e","user":{"login":"commercialhaskell","id":10633049,"avatar_url":"https://avatars.githubusercontent.com/u/10633049?v=3","gravatar_id":"","url":"https://api.github.com/users/commercialhaskell","html_url":"https://github.com/commercialhaskell","followers_url":"https://api.github.com/users/commercialhaskell/followers","following_url":"https://api.github.com/users/commercialhaskell/following{/other_user}","gists_url":"https://api.github.com/users/commercialhaskell/gists{/gist_id}","starred_url":"https://api.github.com/users/commercialhaskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercialhaskell/subscriptions","organizations_url":"https://api.github.com/users/commercialhaskell/orgs","repos_url":"https://api.github.com/users/commercialhaskell/repos","events_url":"https://api.github.com/users/commercialhaskell/events{/privacy}","received_events_url":"https://api.github.com/users/commercialhaskell/received_events","type":"Organization","site_admin":false},"repo":{"id":34817922,"name":"stack","full_name":"commercialhaskell/stack","owner":{"login":"commercialhaskell","id":10633049,"avatar_url":"https://avatars.githubusercontent.com/u/10633049?v=3","gravatar_id":"","url":"https://api.github.com/users/commercialhaskell","html_url":"https://github.com/commercialhaskell","followers_url":"https://api.github.com/users/commercialhaskell/followers","following_url":"https://api.github.com/users/commercialhaskell/following{/other_user}","gists_url":"https://api.github.com/users/commercialhaskell/gists{/gist_id}","starred_url":"https://api.github.com/users/commercialhaskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercialhaskell/subscriptions","organizations_url":"https://api.github.com/users/commercialhaskell/orgs","repos_url":"https://api.github.com/users/commercialhaskell/repos","events_url":"https://api.github.com/users/commercialhaskell/events{/privacy}","received_events_url":"https://api.github.com/users/commercialhaskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercialhaskell/stack","description":"The Haskell Tool Stack","fork":false,"url":"https://api.github.com/repos/commercialhaskell/stack","forks_url":"https://api.github.com/repos/commercialhaskell/stack/forks","keys_url":"https://api.github.com/repos/commercialhaskell/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercialhaskell/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercialhaskell/stack/teams","hooks_url":"https://api.github.com/repos/commercialhaskell/stack/hooks","issue_events_url":"https://api.github.com/repos/commercialhaskell/stack/issues/events{/number}","events_url":"https://api.github.com/repos/commercialhaskell/stack/events","assignees_url":"https://api.github.com/repos/commercialhaskell/stack/assignees{/user}","branches_url":"https://api.github.com/repos/commercialhaskell/stack/branches{/branch}","tags_url":"https://api.github.com/repos/commercialhaskell/stack/tags","blobs_url":"https://api.github.com/repos/commercialhaskell/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercialhaskell/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercialhaskell/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercialhaskell/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercialhaskell/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/commercialhaskell/stack/languages","stargazers_url":"https://api.github.com/repos/commercialhaskell/stack/stargazers","contributors_url":"https://api.github.com/repos/commercialhaskell/stack/contributors","subscribers_url":"https://api.github.com/repos/commercialhaskell/stack/subscribers","subscription_url":"https://api.github.com/repos/commercialhaskell/stack/subscription","commits_url":"https://api.github.com/repos/commercialhaskell/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercialhaskell/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercialhaskell/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercialhaskell/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercialhaskell/stack/contents/{+path}","compare_url":"https://api.github.com/repos/commercialhaskell/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercialhaskell/stack/merges","archive_url":"https://api.github.com/repos/commercialhaskell/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercialhaskell/stack/downloads","issues_url":"https://api.github.com/repos/commercialhaskell/stack/issues{/number}","pulls_url":"https://api.github.com/repos/commercialhaskell/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/commercialhaskell/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/commercialhaskell/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercialhaskell/stack/labels{/name}","releases_url":"https://api.github.com/repos/commercialhaskell/stack/releases{/id}","deployments_url":"https://api.github.com/repos/commercialhaskell/stack/deployments","created_at":"2015-04-29T20:56:42Z","updated_at":"2016-06-13T08:05:57Z","pushed_at":"2016-06-12T23:40:16Z","git_url":"git://github.com/commercialhaskell/stack.git","ssh_url":"git@github.com:commercialhaskell/stack.git","clone_url":"https://github.com/commercialhaskell/stack.git","svn_url":"https://github.com/commercialhaskell/stack","homepage":"http://haskellstack.org","size":8759,"stargazers_count":1697,"watchers_count":1697,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":379,"forks":273,"open_issues":379,"watchers":1697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264"},"html":{"href":"https://github.com/commercialhaskell/stack/pull/2264"},"issue":{"href":"https://api.github.com/repos/commercialhaskell/stack/issues/2264"},"comments":{"href":"https://api.github.com/repos/commercialhaskell/stack/issues/2264/comments"},"review_comments":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264/comments"},"review_comment":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercialhaskell/stack/pulls/2264/commits"},"statuses":{"href":"https://api.github.com/repos/commercialhaskell/stack/statuses/900dd4d4182636671e7d046c14d95d4efb1949fa"}}}}
{"actor":{"display_login":"sjakobi"}}