{"action":"created","issue":{"url":"https://api.github.com/repos/kakaroto/SWProxy/issues/165","repository_url":"https://api.github.com/repos/kakaroto/SWProxy","labels_url":"https://api.github.com/repos/kakaroto/SWProxy/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/kakaroto/SWProxy/issues/165/comments","events_url":"https://api.github.com/repos/kakaroto/SWProxy/issues/165/events","html_url":"https://github.com/kakaroto/SWProxy/pull/165","id":193421569,"number":165,"title":"allow to change interface/ip from GUI and with commandline with '-i' …","user":{"login":"Nightreaver","id":3270156,"avatar_url":"https://avatars.githubusercontent.com/u/3270156?v=3","gravatar_id":"","url":"https://api.github.com/users/Nightreaver","html_url":"https://github.com/Nightreaver","followers_url":"https://api.github.com/users/Nightreaver/followers","following_url":"https://api.github.com/users/Nightreaver/following{/other_user}","gists_url":"https://api.github.com/users/Nightreaver/gists{/gist_id}","starred_url":"https://api.github.com/users/Nightreaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nightreaver/subscriptions","organizations_url":"https://api.github.com/users/Nightreaver/orgs","repos_url":"https://api.github.com/users/Nightreaver/repos","events_url":"https://api.github.com/users/Nightreaver/events{/privacy}","received_events_url":"https://api.github.com/users/Nightreaver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-05T06:32:34Z","updated_at":"2016-12-07T21:06:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kakaroto/SWProxy/pulls/165","html_url":"https://github.com/kakaroto/SWProxy/pull/165","diff_url":"https://github.com/kakaroto/SWProxy/pull/165.diff","patch_url":"https://github.com/kakaroto/SWProxy/pull/165.patch"},"body":"…option\r\n\r\nadded check to validate local ip address\r\nadded .idea/ gitignore (PyCharm)"},"comment":{"url":"https://api.github.com/repos/kakaroto/SWProxy/issues/comments/265573464","html_url":"https://github.com/kakaroto/SWProxy/pull/165#issuecomment-265573464","issue_url":"https://api.github.com/repos/kakaroto/SWProxy/issues/165","id":265573464,"user":{"login":"kakaroto","id":27990,"avatar_url":"https://avatars.githubusercontent.com/u/27990?v=3","gravatar_id":"","url":"https://api.github.com/users/kakaroto","html_url":"https://github.com/kakaroto","followers_url":"https://api.github.com/users/kakaroto/followers","following_url":"https://api.github.com/users/kakaroto/following{/other_user}","gists_url":"https://api.github.com/users/kakaroto/gists{/gist_id}","starred_url":"https://api.github.com/users/kakaroto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakaroto/subscriptions","organizations_url":"https://api.github.com/users/kakaroto/orgs","repos_url":"https://api.github.com/users/kakaroto/repos","events_url":"https://api.github.com/users/kakaroto/events{/privacy}","received_events_url":"https://api.github.com/users/kakaroto/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T21:06:33Z","updated_at":"2016-12-07T21:06:33Z","body":"On closer inspection, I don't like the name of 'interface' in the command line options, because I would then do ./SWProxy -i eth0 or -i wlan0, etc.. that's what an interface is technically (in linux speak at least). so I would keep it as ip address, but make the usage/help specify that it's the listening address to use.\r\nAlso, if you make it modifiable in the GUI, it needs a 'Reset' button in case someone changes it by mistake\r\n\r\nAnyways, thinking about it... the easiest would probably be to simply bind 0.0.0.0 (ANY interface), the IP address here is only shown to the user so he/she knows what to put in their phone's proxy configuration. I don't really see the point of binding a specific interface, instead of all possible interfaces. Maybe this has been discussed already in #38, but I don't have time right now to read the backlog there.\r\n"}}
{"actor":{"display_login":"kakaroto"}}