{"action":"created","comment":{"url":"https://api.github.com/repos/callstack-io/async-storage/pulls/comments/92085696","pull_request_review_id":12594939,"id":92085696,"diff_hunk":"@@ -75,10 +75,9 @@ const API: TAsyncStorage = {\n         }\n \n         try {\n-          const parsedValue = JSON.parse(rawValue);","path":"src/index.js","position":4,"original_position":4,"commit_id":"df9bc87cd8dd9fa652940b5e59ba19406da9c0fb","original_commit_id":"df9bc87cd8dd9fa652940b5e59ba19406da9c0fb","user":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars.githubusercontent.com/u/774577?v=3","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"body":"From RN docs of [multiMerge](https://facebook.github.io/react-native/docs/asyncstorage.html#multimerge): `This assumes that the values are stringified JSON.`. And if we check typing (for both `setItem` and `multiSet`) value it's always string, so if we want to pass and object, the assumption is correct (we would previously have already used `JSON.stringify()`).","created_at":"2016-12-13T02:15:26Z","updated_at":"2016-12-13T02:15:26Z","html_url":"https://github.com/callstack-io/async-storage/pull/1#discussion_r92085696","pull_request_url":"https://api.github.com/repos/callstack-io/async-storage/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/comments/92085696"},"html":{"href":"https://github.com/callstack-io/async-storage/pull/1#discussion_r92085696"},"pull_request":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/callstack-io/async-storage/pulls/1","id":97674438,"html_url":"https://github.com/callstack-io/async-storage/pull/1","diff_url":"https://github.com/callstack-io/async-storage/pull/1.diff","patch_url":"https://github.com/callstack-io/async-storage/pull/1.patch","issue_url":"https://api.github.com/repos/callstack-io/async-storage/issues/1","number":1,"state":"open","locked":false,"title":"First batch of unit tests + fix multiMerge","user":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars.githubusercontent.com/u/774577?v=3","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-13T02:15:09Z","updated_at":"2016-12-13T02:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aa8fbcf92467b87fd2f227e7365d8508d96a0e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callstack-io/async-storage/pulls/1/commits","review_comments_url":"https://api.github.com/repos/callstack-io/async-storage/pulls/1/comments","review_comment_url":"https://api.github.com/repos/callstack-io/async-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callstack-io/async-storage/issues/1/comments","statuses_url":"https://api.github.com/repos/callstack-io/async-storage/statuses/df9bc87cd8dd9fa652940b5e59ba19406da9c0fb","head":{"label":"callstack-io:tests","ref":"tests","sha":"df9bc87cd8dd9fa652940b5e59ba19406da9c0fb","user":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"repo":{"id":76268255,"name":"async-storage","full_name":"callstack-io/async-storage","owner":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack-io/async-storage","description":"Cross platform storage for React, built on top of AsyncStorage","fork":false,"url":"https://api.github.com/repos/callstack-io/async-storage","forks_url":"https://api.github.com/repos/callstack-io/async-storage/forks","keys_url":"https://api.github.com/repos/callstack-io/async-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack-io/async-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack-io/async-storage/teams","hooks_url":"https://api.github.com/repos/callstack-io/async-storage/hooks","issue_events_url":"https://api.github.com/repos/callstack-io/async-storage/issues/events{/number}","events_url":"https://api.github.com/repos/callstack-io/async-storage/events","assignees_url":"https://api.github.com/repos/callstack-io/async-storage/assignees{/user}","branches_url":"https://api.github.com/repos/callstack-io/async-storage/branches{/branch}","tags_url":"https://api.github.com/repos/callstack-io/async-storage/tags","blobs_url":"https://api.github.com/repos/callstack-io/async-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack-io/async-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack-io/async-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack-io/async-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack-io/async-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack-io/async-storage/languages","stargazers_url":"https://api.github.com/repos/callstack-io/async-storage/stargazers","contributors_url":"https://api.github.com/repos/callstack-io/async-storage/contributors","subscribers_url":"https://api.github.com/repos/callstack-io/async-storage/subscribers","subscription_url":"https://api.github.com/repos/callstack-io/async-storage/subscription","commits_url":"https://api.github.com/repos/callstack-io/async-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack-io/async-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack-io/async-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack-io/async-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack-io/async-storage/contents/{+path}","compare_url":"https://api.github.com/repos/callstack-io/async-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack-io/async-storage/merges","archive_url":"https://api.github.com/repos/callstack-io/async-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack-io/async-storage/downloads","issues_url":"https://api.github.com/repos/callstack-io/async-storage/issues{/number}","pulls_url":"https://api.github.com/repos/callstack-io/async-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack-io/async-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack-io/async-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack-io/async-storage/labels{/name}","releases_url":"https://api.github.com/repos/callstack-io/async-storage/releases{/id}","deployments_url":"https://api.github.com/repos/callstack-io/async-storage/deployments","created_at":"2016-12-12T15:14:34Z","updated_at":"2016-12-12T22:28:21Z","pushed_at":"2016-12-13T02:15:09Z","git_url":"git://github.com/callstack-io/async-storage.git","ssh_url":"git@github.com:callstack-io/async-storage.git","clone_url":"https://github.com/callstack-io/async-storage.git","svn_url":"https://github.com/callstack-io/async-storage","homepage":"","size":14,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"callstack-io:master","ref":"master","sha":"aaaeb61b1b507055888234fb5615b1072f7efab0","user":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"repo":{"id":76268255,"name":"async-storage","full_name":"callstack-io/async-storage","owner":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack-io/async-storage","description":"Cross platform storage for React, built on top of AsyncStorage","fork":false,"url":"https://api.github.com/repos/callstack-io/async-storage","forks_url":"https://api.github.com/repos/callstack-io/async-storage/forks","keys_url":"https://api.github.com/repos/callstack-io/async-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack-io/async-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack-io/async-storage/teams","hooks_url":"https://api.github.com/repos/callstack-io/async-storage/hooks","issue_events_url":"https://api.github.com/repos/callstack-io/async-storage/issues/events{/number}","events_url":"https://api.github.com/repos/callstack-io/async-storage/events","assignees_url":"https://api.github.com/repos/callstack-io/async-storage/assignees{/user}","branches_url":"https://api.github.com/repos/callstack-io/async-storage/branches{/branch}","tags_url":"https://api.github.com/repos/callstack-io/async-storage/tags","blobs_url":"https://api.github.com/repos/callstack-io/async-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack-io/async-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack-io/async-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack-io/async-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack-io/async-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack-io/async-storage/languages","stargazers_url":"https://api.github.com/repos/callstack-io/async-storage/stargazers","contributors_url":"https://api.github.com/repos/callstack-io/async-storage/contributors","subscribers_url":"https://api.github.com/repos/callstack-io/async-storage/subscribers","subscription_url":"https://api.github.com/repos/callstack-io/async-storage/subscription","commits_url":"https://api.github.com/repos/callstack-io/async-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack-io/async-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack-io/async-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack-io/async-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack-io/async-storage/contents/{+path}","compare_url":"https://api.github.com/repos/callstack-io/async-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack-io/async-storage/merges","archive_url":"https://api.github.com/repos/callstack-io/async-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack-io/async-storage/downloads","issues_url":"https://api.github.com/repos/callstack-io/async-storage/issues{/number}","pulls_url":"https://api.github.com/repos/callstack-io/async-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack-io/async-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack-io/async-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack-io/async-storage/labels{/name}","releases_url":"https://api.github.com/repos/callstack-io/async-storage/releases{/id}","deployments_url":"https://api.github.com/repos/callstack-io/async-storage/deployments","created_at":"2016-12-12T15:14:34Z","updated_at":"2016-12-12T22:28:21Z","pushed_at":"2016-12-13T02:15:09Z","git_url":"git://github.com/callstack-io/async-storage.git","ssh_url":"git@github.com:callstack-io/async-storage.git","clone_url":"https://github.com/callstack-io/async-storage.git","svn_url":"https://github.com/callstack-io/async-storage","homepage":"","size":14,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/1"},"html":{"href":"https://github.com/callstack-io/async-storage/pull/1"},"issue":{"href":"https://api.github.com/repos/callstack-io/async-storage/issues/1"},"comments":{"href":"https://api.github.com/repos/callstack-io/async-storage/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callstack-io/async-storage/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/callstack-io/async-storage/statuses/df9bc87cd8dd9fa652940b5e59ba19406da9c0fb"}}}}
{"actor":{"display_login":"ferrannp"}}