{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/61620759","id":61620759,"diff_hunk":"@@ -17,29 +20,42 @@ public struct CompilerCacheResult\n         /// Initializes a new instance of <see cref=\"CompilerCacheResult\"/> with the specified\n         /// <see cref=\"Compilation.CompilationResult\"/>.\n         /// </summary>\n+        /// <param name=\"relativePath\">Application relative path to the view file.</param>\n         /// <param name=\"compilationResult\">The <see cref=\"Compilation.CompilationResult\"/>.</param>\n-        public CompilerCacheResult(CompilationResult compilationResult)\n-            : this(compilationResult, new IChangeToken[0])\n+        public CompilerCacheResult(string relativePath, CompilationResult compilationResult)\n+            : this(relativePath, compilationResult, new IChangeToken[0])\n         {\n         }\n \n         /// <summary>\n         /// Initializes a new instance of <see cref=\"CompilerCacheResult\"/> with the specified\n         /// <see cref=\"Compilation.CompilationResult\"/>.\n         /// </summary>\n+        /// <param name=\"relativePath\">Application relative path to the view file.</param>\n         /// <param name=\"compilationResult\">The <see cref=\"Compilation.CompilationResult\"/>.</param>\n         /// <param name=\"expirationTokens\">One or more <see cref=\"IChangeToken\"/> instances that indicate when\n         /// this result has expired.</param>\n-        public CompilerCacheResult(CompilationResult compilationResult, IList<IChangeToken> expirationTokens)\n+        public CompilerCacheResult(string relativePath, CompilationResult compilationResult, IList<IChangeToken> expirationTokens)\n         {\n             if (expirationTokens == null)\n             {\n                 throw new ArgumentNullException(nameof(expirationTokens));\n             }\n \n-            CompilationResult = compilationResult;\n-            Success = true;\n             ExpirationTokens = expirationTokens;\n+            var compiledType = compilationResult.CompiledType;\n+\n+            var newExpression = Expression.New(compiledType);\n+\n+            var pathProperty = compiledType.GetProperty(nameof(IRazorPage.Path)) ?? \n+                (MemberInfo)compiledType.GetField(nameof(IRazorPage.Path));","path":"src/Microsoft.AspNetCore.Mvc.Razor/Internal/CompilerCacheResult.cs","position":47,"original_position":47,"commit_id":"8a13647eaf9d114edfcf629703549b3aec6c55b9","original_commit_id":"8a13647eaf9d114edfcf629703549b3aec6c55b9","user":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars.githubusercontent.com/u/174281?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"body":"Isn't this always going to be a property? Why look for a field?","created_at":"2016-04-29T18:04:28Z","updated_at":"2016-04-29T18:04:28Z","html_url":"https://github.com/aspnet/Mvc/pull/4557#discussion_r61620759","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4557","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/61620759"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4557#discussion_r61620759"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4557"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/4557","id":68291511,"html_url":"https://github.com/aspnet/Mvc/pull/4557","diff_url":"https://github.com/aspnet/Mvc/pull/4557.diff","patch_url":"https://github.com/aspnet/Mvc/pull/4557.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/4557","number":4557,"state":"open","locked":false,"title":"[Perf] [Perf] Replace Activator.CreateInstance with cached delegate in RazorPageFactoryProvider","user":{"login":"mnltejaswini","id":8011073,"avatar_url":"https://avatars.githubusercontent.com/u/8011073?v=3","gravatar_id":"","url":"https://api.github.com/users/mnltejaswini","html_url":"https://github.com/mnltejaswini","followers_url":"https://api.github.com/users/mnltejaswini/followers","following_url":"https://api.github.com/users/mnltejaswini/following{/other_user}","gists_url":"https://api.github.com/users/mnltejaswini/gists{/gist_id}","starred_url":"https://api.github.com/users/mnltejaswini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnltejaswini/subscriptions","organizations_url":"https://api.github.com/users/mnltejaswini/orgs","repos_url":"https://api.github.com/users/mnltejaswini/repos","events_url":"https://api.github.com/users/mnltejaswini/events{/privacy}","received_events_url":"https://api.github.com/users/mnltejaswini/received_events","type":"User","site_admin":false},"body":"Fixes #4470\r\n\r\nIsolated changes corresponding to RazorPageFactoryProvider from #4524 for simplicity. For more details please refer to #4524 \r\n\r\nScenario: https://github.com/aspnet/Performance/tree/dev/testapp/HelloWorldMvc\r\n\r\nBefore Optimization\r\n--------------------------\r\nhttps://cloud.githubusercontent.com/assets/8011073/14792823/fbbc40d0-0ad0-11e6-92e8-57c6146fe87c.png\r\n\r\nAfter Optimization\r\n----------------------\r\nhttps://cloud.githubusercontent.com/assets/8011073/14793013/e9d08fa6-0ad1-11e6-8339-11039f7f4a92.png\r\n","created_at":"2016-04-28T21:13:06Z","updated_at":"2016-04-29T18:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab74e8a141f6b5a78e6a96add8ef3ec4f6e394d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4557/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4557/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/4557/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/8a13647eaf9d114edfcf629703549b3aec6c55b9","head":{"label":"aspnet:naduggar/Issue4470_2","ref":"naduggar/Issue4470_2","sha":"8a13647eaf9d114edfcf629703549b3aec6c55b9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-04-29T13:37:23Z","pushed_at":"2016-04-29T17:59:11Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":54786,"stargazers_count":3018,"watchers_count":3018,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1215,"mirror_url":null,"open_issues_count":332,"forks":1215,"open_issues":332,"watchers":3018,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"30ace9f35a63da9527281f903c71059accb33274","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-04-29T13:37:23Z","pushed_at":"2016-04-29T17:59:11Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":54786,"stargazers_count":3018,"watchers_count":3018,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1215,"mirror_url":null,"open_issues_count":332,"forks":1215,"open_issues":332,"watchers":3018,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4557"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4557"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4557"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4557/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4557/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4557/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/8a13647eaf9d114edfcf629703549b3aec6c55b9"}}}}