{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/86153864","pull_request_review_id":6825131,"id":86153864,"diff_hunk":"@@ -125,18 +125,18 @@ func ExtendedValidateRoute(route *routeapi.Route) field.ErrorList {\n \t//       break, so disable the hostname validation for now.\n \t// hostname := route.Spec.Host\n \thostname := \"\"\n-\tvar certPool *x509.CertPool\n+\tvar verifyOptions *x509.VerifyOptions\n \n \tif len(tlsConfig.CACertificate) > 0 {\n-\t\tcertPool = x509.NewCertPool()\n+\t\tcertPool := x509.NewCertPool()\n \t\tif ok := certPool.AppendCertsFromPEM([]byte(tlsConfig.CACertificate)); !ok {\n \t\t\tresult = append(result, field.Invalid(tlsFieldPath.Child(\"caCertificate\"), tlsConfig.CACertificate, \"failed to parse CA certificate\"))\n \t\t}\n-\t}\n \n-\tverifyOptions := &x509.VerifyOptions{\n-\t\tDNSName: hostname,\n-\t\tRoots:   certPool,\n+\t\tverifyOptions = &x509.VerifyOptions{\n+\t\t\tDNSName: hostname,\n+\t\t\tRoots:   certPool,\n+\t\t}\n \t}","path":"pkg/route/api/validation/validation.go","position":22,"original_position":22,"commit_id":"22524f70a2a1df7e16d038546c19d8a3e67eb9f2","original_commit_id":"22524f70a2a1df7e16d038546c19d8a3e67eb9f2","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"when verifying, probably need to override the current time in VerifyOptions to be the NotAfter time on the cert","created_at":"2016-11-02T14:31:05Z","updated_at":"2016-11-02T14:31:05Z","html_url":"https://github.com/openshift/origin/pull/11716#discussion_r86153864","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11716","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/86153864"},"html":{"href":"https://github.com/openshift/origin/pull/11716#discussion_r86153864"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11716"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11716","id":91884958,"html_url":"https://github.com/openshift/origin/pull/11716","diff_url":"https://github.com/openshift/origin/pull/11716.diff","patch_url":"https://github.com/openshift/origin/pull/11716.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11716","number":11716,"state":"open","locked":false,"title":"Fix for bugz #1389165 - extended route validation breaks included templates","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"body":"@knobunc  @liggitt   PTAL  Thx\r\naddressed the concerns you had in bug 1389165 [link](https://bugzilla.redhat.com/show_bug.cgi?id=1389165) as well - there were already existing tests that covered some of those but added a few more.","created_at":"2016-11-01T23:37:13Z","updated_at":"2016-11-02T14:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c5464da48e194dfb2a796932914e82ba2eb391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11716/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11716/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11716/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/22524f70a2a1df7e16d038546c19d8a3e67eb9f2","head":{"label":"ramr:fix-extval-bug","ref":"fix-extval-bug","sha":"22524f70a2a1df7e16d038546c19d8a3e67eb9f2","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"repo":{"id":31566423,"name":"origin","full_name":"ramr/origin","owner":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramr/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/ramr/origin","forks_url":"https://api.github.com/repos/ramr/origin/forks","keys_url":"https://api.github.com/repos/ramr/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramr/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramr/origin/teams","hooks_url":"https://api.github.com/repos/ramr/origin/hooks","issue_events_url":"https://api.github.com/repos/ramr/origin/issues/events{/number}","events_url":"https://api.github.com/repos/ramr/origin/events","assignees_url":"https://api.github.com/repos/ramr/origin/assignees{/user}","branches_url":"https://api.github.com/repos/ramr/origin/branches{/branch}","tags_url":"https://api.github.com/repos/ramr/origin/tags","blobs_url":"https://api.github.com/repos/ramr/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramr/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramr/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramr/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramr/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/ramr/origin/languages","stargazers_url":"https://api.github.com/repos/ramr/origin/stargazers","contributors_url":"https://api.github.com/repos/ramr/origin/contributors","subscribers_url":"https://api.github.com/repos/ramr/origin/subscribers","subscription_url":"https://api.github.com/repos/ramr/origin/subscription","commits_url":"https://api.github.com/repos/ramr/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramr/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramr/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramr/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramr/origin/contents/{+path}","compare_url":"https://api.github.com/repos/ramr/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramr/origin/merges","archive_url":"https://api.github.com/repos/ramr/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramr/origin/downloads","issues_url":"https://api.github.com/repos/ramr/origin/issues{/number}","pulls_url":"https://api.github.com/repos/ramr/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/ramr/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/ramr/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramr/origin/labels{/name}","releases_url":"https://api.github.com/repos/ramr/origin/releases{/id}","deployments_url":"https://api.github.com/repos/ramr/origin/deployments","created_at":"2015-03-02T22:18:42Z","updated_at":"2016-01-21T01:51:05Z","pushed_at":"2016-11-01T23:02:55Z","git_url":"git://github.com/ramr/origin.git","ssh_url":"git@github.com:ramr/origin.git","clone_url":"https://github.com/ramr/origin.git","svn_url":"https://github.com/ramr/origin","homepage":"https://openshift.github.io","size":365838,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8ecb3f5d187dcf199319c55861720bcf1cd66c75","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-11-02T09:49:07Z","pushed_at":"2016-11-02T14:08:55Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":616051,"stargazers_count":1907,"watchers_count":1907,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1297,"mirror_url":null,"open_issues_count":1204,"forks":1297,"open_issues":1204,"watchers":1907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11716"},"html":{"href":"https://github.com/openshift/origin/pull/11716"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11716"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11716/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11716/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11716/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/22524f70a2a1df7e16d038546c19d8a3e67eb9f2"}}}}
{"actor":{"display_login":"liggitt"}}