{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic/issues/8717","repository_url":"https://api.github.com/repos/driftyco/ionic","labels_url":"https://api.github.com/repos/driftyco/ionic/issues/8717/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/8717/comments","events_url":"https://api.github.com/repos/driftyco/ionic/issues/8717/events","html_url":"https://github.com/driftyco/ionic/issues/8717","id":183194788,"number":8717,"title":"OneSignal cordova plugin gives error on Android permission","user":{"login":"basvdijk","id":644550,"avatar_url":"https://avatars.githubusercontent.com/u/644550?v=3","gravatar_id":"","url":"https://api.github.com/users/basvdijk","html_url":"https://github.com/basvdijk","followers_url":"https://api.github.com/users/basvdijk/followers","following_url":"https://api.github.com/users/basvdijk/following{/other_user}","gists_url":"https://api.github.com/users/basvdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/basvdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvdijk/subscriptions","organizations_url":"https://api.github.com/users/basvdijk/orgs","repos_url":"https://api.github.com/users/basvdijk/repos","events_url":"https://api.github.com/users/basvdijk/events{/privacy}","received_events_url":"https://api.github.com/users/basvdijk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-15T07:30:02Z","updated_at":"2016-10-17T00:01:21Z","closed_at":null,"body":"When running `ionic build android --release` it gives an error on the OneSignal plugin\r\n#### Short description of the problem:\r\n\r\n```\r\nionic-app/platforms/android/AndroidManifest.xml:21: Error: The <uses-permission> element must be a direct child of the <manifest> root element [WrongManifestParent]\r\n\r\n        <uses-permission android:name=\"com.amazon.device.messaging.permission.RECEIVE\" />\r\n        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n\r\n\r\n   Explanation for issues of type \"WrongManifestParent\":\r\n   The <uses-library> element should be defined as a direct child of the\r\n   <application> tag, not the <manifest> tag or an <activity> tag. Similarly,\r\n   a <uses-sdk> tag must be declared at the root level, and so on. This check\r\n   looks for incorrect declaration locations in the manifest, and complains if\r\n   an element is found in the wrong place.\r\n\r\n\r\n   http://developer.android.com/guide/topics/manifest/manifest-intro.html\r\n```\r\n\r\nWhich is on line 55 in `ionic-app/plugins/onesignal-cordova-plugin/plugin.xml`\r\n\r\n\r\n#### What behavior are you expecting?\r\nThe error not appearing\r\n\r\n\r\n**Steps to reproduce:**\r\nCreate app with one signal plugin in RC1\r\n\r\n**Which Ionic Version?** 2.x\r\n\r\n**Run `ionic info` from terminal/cmd prompt:** (paste output below)\r\n\r\n```\r\nYour system information:\r\n\r\nCordova CLI: 6.3.1\r\nIonic Framework Version: 2.0.0-rc.1\r\nIonic CLI Version: 2.1.0\r\nIonic App Lib Version: 2.1.0-beta.1\r\nios-deploy version: Not installed\r\nios-sim version: Not installed\r\nOS: Mac OS X El Capitan\r\nNode Version: v6.7.0\r\nXcode version: Xcode 8.0 Build version 8A218a\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/driftyco/ionic/issues/comments/254086571","html_url":"https://github.com/driftyco/ionic/issues/8717#issuecomment-254086571","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/8717","id":254086571,"user":{"login":"jgw96","id":8823093,"avatar_url":"https://avatars.githubusercontent.com/u/8823093?v=3","gravatar_id":"","url":"https://api.github.com/users/jgw96","html_url":"https://github.com/jgw96","followers_url":"https://api.github.com/users/jgw96/followers","following_url":"https://api.github.com/users/jgw96/following{/other_user}","gists_url":"https://api.github.com/users/jgw96/gists{/gist_id}","starred_url":"https://api.github.com/users/jgw96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgw96/subscriptions","organizations_url":"https://api.github.com/users/jgw96/orgs","repos_url":"https://api.github.com/users/jgw96/repos","events_url":"https://api.github.com/users/jgw96/events{/privacy}","received_events_url":"https://api.github.com/users/jgw96/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T00:01:21Z","updated_at":"2016-10-17T00:01:21Z","body":"Hello, thanks for using Ionic! Is this using an Ionic Native plugin?"}}
{"actor":{"display_login":"jgw96"}}