{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76","id":63372857,"html_url":"https://github.com/ucb-bar/rocket-chip/pull/76","diff_url":"https://github.com/ucb-bar/rocket-chip/pull/76.diff","patch_url":"https://github.com/ucb-bar/rocket-chip/pull/76.patch","issue_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/76","number":76,"state":"closed","locked":false,"title":"Trace generator: updates and additions to the scripts directory","user":{"login":"mn416","id":8067462,"avatar_url":"https://avatars.githubusercontent.com/u/8067462?v=3","gravatar_id":"","url":"https://api.github.com/users/mn416","html_url":"https://github.com/mn416","followers_url":"https://api.github.com/users/mn416/followers","following_url":"https://api.github.com/users/mn416/following{/other_user}","gists_url":"https://api.github.com/users/mn416/gists{/gist_id}","starred_url":"https://api.github.com/users/mn416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn416/subscriptions","organizations_url":"https://api.github.com/users/mn416/orgs","repos_url":"https://api.github.com/users/mn416/repos","events_url":"https://api.github.com/users/mn416/events{/privacy}","received_events_url":"https://api.github.com/users/mn416/received_events","type":"User","site_admin":false},"body":"1. Introduce `tracegen.py`, a script that invokes the emulator (built with `TraceGenConfig`), sending a `SIGTERM` once all cores are finished.\r\n\r\n2. Update `toaxe.py` to gather some statistics about the trace.\r\n\r\n3. Introduce `tracestats.py`, which displays the stats in a useful way.\r\n\r\n4. Introduce `tracegen+check.py`, a top-level script that generates traces, checks them, and emits stats.\r\n\r\nIf this commit is pulled, it should be done after pulling my latest groundtest commit.\r\n\r\n`tracegen+check.py` is designed to be run in the emulator directory with the scripts directory in your `PATH`, e.g.\r\n\r\n```\r\nmn416@babbage:~/rocket-chip/emulator$ tracegen+check.sh \r\nTesting against WMO model:\r\n \r\n       0: .......... .......... .......... .......... .......... \r\n      50: .......... .......... .......... .......... ..........\r\n\r\nOK, passed 100 tests\r\nLR/SC success rate: 1%\r\nLoad-external rate: 76%\r\n\r\n```\r\n\r\nIf you want 1000 tests starting from seed 100, you can do `NUM_TESTS=1000 START_SEED=100 tracegen+check.sh`.  There are various other parameters too (look in the script to see).\r\n\r\nThe current rocket-chip is passing a lot of tests, but note the `LR/SC success rate` at 1% which is probably related to issue #74.  In some cases, we can also observe a successful LR/SC performing non-atomic updates: specifically when the SC is issued before the LR response occurs.  This may be related to issue #74 too, so I'll not post a new issue.\r\n\r\nThe `Load-external rate` shows the proportion of loads that read a value written by another core.  It is there to show liveness: otherwise, an implementation in which each core is connected to a different memory, with no sharing, would be classed as passing.\r\n\r\nThere are other potentially useful stats too, e.g. average time between memory request and response.  If these non-functional properties are of interest I can add some more.\r\n\r\n","created_at":"2016-03-18T13:20:20Z","updated_at":"2016-03-23T17:07:47Z","closed_at":"2016-03-23T17:07:47Z","merged_at":null,"merge_commit_sha":"edbc83ec60dfbcad84efe435f685e2a38640af9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76/commits","review_comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76/comments","review_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/76/comments","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/004375f9673f39a69dcb0daadfd239640bf4e23e","head":{"label":"mn416:master","ref":"master","sha":"004375f9673f39a69dcb0daadfd239640bf4e23e","user":{"login":"mn416","id":8067462,"avatar_url":"https://avatars.githubusercontent.com/u/8067462?v=3","gravatar_id":"","url":"https://api.github.com/users/mn416","html_url":"https://github.com/mn416","followers_url":"https://api.github.com/users/mn416/followers","following_url":"https://api.github.com/users/mn416/following{/other_user}","gists_url":"https://api.github.com/users/mn416/gists{/gist_id}","starred_url":"https://api.github.com/users/mn416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn416/subscriptions","organizations_url":"https://api.github.com/users/mn416/orgs","repos_url":"https://api.github.com/users/mn416/repos","events_url":"https://api.github.com/users/mn416/events{/privacy}","received_events_url":"https://api.github.com/users/mn416/received_events","type":"User","site_admin":false},"repo":{"id":54197735,"name":"rocket-chip","full_name":"mn416/rocket-chip","owner":{"login":"mn416","id":8067462,"avatar_url":"https://avatars.githubusercontent.com/u/8067462?v=3","gravatar_id":"","url":"https://api.github.com/users/mn416","html_url":"https://github.com/mn416","followers_url":"https://api.github.com/users/mn416/followers","following_url":"https://api.github.com/users/mn416/following{/other_user}","gists_url":"https://api.github.com/users/mn416/gists{/gist_id}","starred_url":"https://api.github.com/users/mn416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn416/subscriptions","organizations_url":"https://api.github.com/users/mn416/orgs","repos_url":"https://api.github.com/users/mn416/repos","events_url":"https://api.github.com/users/mn416/events{/privacy}","received_events_url":"https://api.github.com/users/mn416/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mn416/rocket-chip","description":"Rocket Chip Generator","fork":true,"url":"https://api.github.com/repos/mn416/rocket-chip","forks_url":"https://api.github.com/repos/mn416/rocket-chip/forks","keys_url":"https://api.github.com/repos/mn416/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mn416/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mn416/rocket-chip/teams","hooks_url":"https://api.github.com/repos/mn416/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/mn416/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/mn416/rocket-chip/events","assignees_url":"https://api.github.com/repos/mn416/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/mn416/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/mn416/rocket-chip/tags","blobs_url":"https://api.github.com/repos/mn416/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mn416/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mn416/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/mn416/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mn416/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/mn416/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/mn416/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/mn416/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/mn416/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/mn416/rocket-chip/subscription","commits_url":"https://api.github.com/repos/mn416/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/mn416/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/mn416/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/mn416/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/mn416/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/mn416/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mn416/rocket-chip/merges","archive_url":"https://api.github.com/repos/mn416/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mn416/rocket-chip/downloads","issues_url":"https://api.github.com/repos/mn416/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/mn416/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/mn416/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/mn416/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mn416/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/mn416/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/mn416/rocket-chip/deployments","created_at":"2016-03-18T11:55:08Z","updated_at":"2016-03-18T11:55:10Z","pushed_at":"2016-03-22T10:28:47Z","git_url":"git://github.com/mn416/rocket-chip.git","ssh_url":"git@github.com:mn416/rocket-chip.git","clone_url":"https://github.com/mn416/rocket-chip.git","svn_url":"https://github.com/mn416/rocket-chip","homepage":null,"size":2699,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ucb-bar:master","ref":"master","sha":"b5992186df9705b7c42fd82d18a563e76617accf","user":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"repo":{"id":23950406,"name":"rocket-chip","full_name":"ucb-bar/rocket-chip","owner":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucb-bar/rocket-chip","description":"Rocket Chip Generator","fork":false,"url":"https://api.github.com/repos/ucb-bar/rocket-chip","forks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/forks","keys_url":"https://api.github.com/repos/ucb-bar/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucb-bar/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucb-bar/rocket-chip/teams","hooks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/events","assignees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/ucb-bar/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/tags","blobs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/ucb-bar/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscription","commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/ucb-bar/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucb-bar/rocket-chip/merges","archive_url":"https://api.github.com/repos/ucb-bar/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucb-bar/rocket-chip/downloads","issues_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/ucb-bar/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/ucb-bar/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucb-bar/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/ucb-bar/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/deployments","created_at":"2014-09-12T07:04:30Z","updated_at":"2016-03-21T19:24:28Z","pushed_at":"2016-03-23T17:06:41Z","git_url":"git://github.com/ucb-bar/rocket-chip.git","ssh_url":"git@github.com:ucb-bar/rocket-chip.git","clone_url":"https://github.com/ucb-bar/rocket-chip.git","svn_url":"https://github.com/ucb-bar/rocket-chip","homepage":null,"size":3594,"stargazers_count":114,"watchers_count":114,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":3,"forks":58,"open_issues":3,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76"},"html":{"href":"https://github.com/ucb-bar/rocket-chip/pull/76"},"issue":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/76"},"comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/004375f9673f39a69dcb0daadfd239640bf4e23e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":458,"deletions":137,"changed_files":5}}