{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/85913684","pull_request_review_id":6599043,"id":85913684,"diff_hunk":"@@ -170,6 +171,44 @@ enum ucp_dt_type {\n \n \n /**\n+ * @ingroup UCP_WORKER\n+ * @brief UCP worker parameters field mask.\n+ *\n+ * The enumeration allows specifying which fields in @ref ucp_worker_params_t are\n+ * present. It is used for the enablement of backward compatibility support.\n+ */\n+enum ucp_worker_params_field {\n+    UCP_PARAM_FIELD_THREAD_MODE     = UCS_BIT(0), /* thread_mode */\n+    UCP_PARAM_FIELD_CPU_SET         = UCS_BIT(1), /* cpu_set */\n+};\n+\n+\n+/**\n+ * @ingroup UCP_WORKER\n+ * @brief UCP parameters for ucp worker creation\n+ *\n+ */\n+struct ucp_worker_params {\n+    /**\n+      * cpu_set affinity to use \n+      */\n+    ucs_cpu_set_t                 cpu_set;\n+\n+    /**\n+     * Mask of valid fields in this structure, using bits from @ref ucp_worker_params_field.\n+     * Fields not specified in this mask would be ignored.\n+     * Provides ABI compatibility with respect to adding new fields.\n+     */\n+    uint64_t                      field_mask;\n+\n+     /**\n+      *  thread mode for ucp worker\n+      */\n+    ucs_thread_mode_t             thread_mode;\n+};","path":"src/ucp/api/ucp.h","position":46,"original_position":46,"commit_id":"b74ff6412dbc88fc15baf72ab3db7fa57e94bde8","original_commit_id":"b74ff6412dbc88fc15baf72ab3db7fa57e94bde8","user":{"login":"shssf","id":19515906,"avatar_url":"https://avatars.githubusercontent.com/u/19515906?v=3","gravatar_id":"","url":"https://api.github.com/users/shssf","html_url":"https://github.com/shssf","followers_url":"https://api.github.com/users/shssf/followers","following_url":"https://api.github.com/users/shssf/following{/other_user}","gists_url":"https://api.github.com/users/shssf/gists{/gist_id}","starred_url":"https://api.github.com/users/shssf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shssf/subscriptions","organizations_url":"https://api.github.com/users/shssf/orgs","repos_url":"https://api.github.com/users/shssf/repos","events_url":"https://api.github.com/users/shssf/events{/privacy}","received_events_url":"https://api.github.com/users/shssf/received_events","type":"User","site_admin":false},"body":"Do we really want to define `ucp_worker_params_t` in other `ucp/api/ucp_def.h` file by `typedef` instead simply define it in this place?","created_at":"2016-11-01T11:44:04Z","updated_at":"2016-11-01T11:44:04Z","html_url":"https://github.com/openucx/ucx/pull/1070#discussion_r85913684","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/1070","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/85913684"},"html":{"href":"https://github.com/openucx/ucx/pull/1070#discussion_r85913684"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1070"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/1070","id":90187246,"html_url":"https://github.com/openucx/ucx/pull/1070","diff_url":"https://github.com/openucx/ucx/pull/1070.diff","patch_url":"https://github.com/openucx/ucx/pull/1070.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/1070","number":1070,"state":"open","locked":false,"title":"UCP/API: Add CPU affinity support to UCP worker","user":{"login":"guy101","id":9695544,"avatar_url":"https://avatars.githubusercontent.com/u/9695544?v=3","gravatar_id":"","url":"https://api.github.com/users/guy101","html_url":"https://github.com/guy101","followers_url":"https://api.github.com/users/guy101/followers","following_url":"https://api.github.com/users/guy101/following{/other_user}","gists_url":"https://api.github.com/users/guy101/gists{/gist_id}","starred_url":"https://api.github.com/users/guy101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guy101/subscriptions","organizations_url":"https://api.github.com/users/guy101/orgs","repos_url":"https://api.github.com/users/guy101/repos","events_url":"https://api.github.com/users/guy101/events{/privacy}","received_events_url":"https://api.github.com/users/guy101/received_events","type":"User","site_admin":false},"body":"UCP/API: Added  worker_params value to ucp_worker_create()  …\n               Added cpu_set to worker_params\n","created_at":"2016-10-20T12:07:34Z","updated_at":"2016-11-01T11:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed9dd3ceb0639acff0a6c77c02d7201005b3c664","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/1070/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/1070/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/1070/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/b74ff6412dbc88fc15baf72ab3db7fa57e94bde8","head":{"label":"guy101:add_cpu_affinity_support_to_UCP_worker_cq/1057","ref":"add_cpu_affinity_support_to_UCP_worker_cq/1057","sha":"b74ff6412dbc88fc15baf72ab3db7fa57e94bde8","user":{"login":"guy101","id":9695544,"avatar_url":"https://avatars.githubusercontent.com/u/9695544?v=3","gravatar_id":"","url":"https://api.github.com/users/guy101","html_url":"https://github.com/guy101","followers_url":"https://api.github.com/users/guy101/followers","following_url":"https://api.github.com/users/guy101/following{/other_user}","gists_url":"https://api.github.com/users/guy101/gists{/gist_id}","starred_url":"https://api.github.com/users/guy101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guy101/subscriptions","organizations_url":"https://api.github.com/users/guy101/orgs","repos_url":"https://api.github.com/users/guy101/repos","events_url":"https://api.github.com/users/guy101/events{/privacy}","received_events_url":"https://api.github.com/users/guy101/received_events","type":"User","site_admin":false},"repo":{"id":68795417,"name":"ucx","full_name":"guy101/ucx","owner":{"login":"guy101","id":9695544,"avatar_url":"https://avatars.githubusercontent.com/u/9695544?v=3","gravatar_id":"","url":"https://api.github.com/users/guy101","html_url":"https://github.com/guy101","followers_url":"https://api.github.com/users/guy101/followers","following_url":"https://api.github.com/users/guy101/following{/other_user}","gists_url":"https://api.github.com/users/guy101/gists{/gist_id}","starred_url":"https://api.github.com/users/guy101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guy101/subscriptions","organizations_url":"https://api.github.com/users/guy101/orgs","repos_url":"https://api.github.com/users/guy101/repos","events_url":"https://api.github.com/users/guy101/events{/privacy}","received_events_url":"https://api.github.com/users/guy101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guy101/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/guy101/ucx","forks_url":"https://api.github.com/repos/guy101/ucx/forks","keys_url":"https://api.github.com/repos/guy101/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guy101/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guy101/ucx/teams","hooks_url":"https://api.github.com/repos/guy101/ucx/hooks","issue_events_url":"https://api.github.com/repos/guy101/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/guy101/ucx/events","assignees_url":"https://api.github.com/repos/guy101/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/guy101/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/guy101/ucx/tags","blobs_url":"https://api.github.com/repos/guy101/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guy101/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guy101/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/guy101/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guy101/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/guy101/ucx/languages","stargazers_url":"https://api.github.com/repos/guy101/ucx/stargazers","contributors_url":"https://api.github.com/repos/guy101/ucx/contributors","subscribers_url":"https://api.github.com/repos/guy101/ucx/subscribers","subscription_url":"https://api.github.com/repos/guy101/ucx/subscription","commits_url":"https://api.github.com/repos/guy101/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/guy101/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/guy101/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/guy101/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/guy101/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/guy101/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guy101/ucx/merges","archive_url":"https://api.github.com/repos/guy101/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guy101/ucx/downloads","issues_url":"https://api.github.com/repos/guy101/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/guy101/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/guy101/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/guy101/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guy101/ucx/labels{/name}","releases_url":"https://api.github.com/repos/guy101/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/guy101/ucx/deployments","created_at":"2016-09-21T08:16:53Z","updated_at":"2016-09-21T08:16:56Z","pushed_at":"2016-10-27T10:29:48Z","git_url":"git://github.com/guy101/ucx.git","ssh_url":"git@github.com:guy101/ucx.git","clone_url":"https://github.com/guy101/ucx.git","svn_url":"https://github.com/guy101/ucx","homepage":"http://www.openucx.org","size":6265,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"93fe9fb790c27dd50513ada48c309c4ce4863f46","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2016-10-23T08:24:18Z","pushed_at":"2016-11-01T09:54:06Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":8240,"stargazers_count":46,"watchers_count":46,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":83,"forks":41,"open_issues":83,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1070"},"html":{"href":"https://github.com/openucx/ucx/pull/1070"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/1070"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/1070/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1070/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1070/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/b74ff6412dbc88fc15baf72ab3db7fa57e94bde8"}}}}
{"actor":{"display_login":"shssf"}}