{"action":"created","comment":{"url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments/89186230","pull_request_review_id":9734327,"id":89186230,"diff_hunk":"@@ -1 +1,70 @@\n-/* New slider masthead styles will go here */\n\\ No newline at end of file\n+/*\n+ * Slider v201611\n+ */\n+div.slider.version-201611 {\n+  margin: 0 auto;\n+  width: 1130px;\n+  height: 440px;\n+\n+  div.grid {\n+    .column {\n+      float: left;\n+      position: relative;\n+      height: 440px;\n+      overflow: hidden;\n+      font-family: $font-stack-heading;\n+\n+      &.image {\n+        width: 780px;\n+\n+        div.photo-by {\n+          position: absolute;\n+          bottom: 0;\n+          left: 0;\n+          padding: 16px;\n+          font-size: 16px;\n+          color: $white;\n+          background-color: rgba(56,56,56,0.90);\n+        }\n+      }\n+\n+      &.header {\n+        width: 350px;\n+        color: $white;\n+\n+        div.aligned {\n+          position: absolute;","path":"app/assets/stylesheets/regions/mastheads/slider-masthead.scss","position":38,"original_position":38,"commit_id":"54a996f20c6ded5101c9ffbaf552925b201a5f65","original_commit_id":"54a996f20c6ded5101c9ffbaf552925b201a5f65","user":{"login":"tatwell","id":12798918,"avatar_url":"https://avatars.githubusercontent.com/u/12798918?v=3","gravatar_id":"","url":"https://api.github.com/users/tatwell","html_url":"https://github.com/tatwell","followers_url":"https://api.github.com/users/tatwell/followers","following_url":"https://api.github.com/users/tatwell/following{/other_user}","gists_url":"https://api.github.com/users/tatwell/gists{/gist_id}","starred_url":"https://api.github.com/users/tatwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatwell/subscriptions","organizations_url":"https://api.github.com/users/tatwell/orgs","repos_url":"https://api.github.com/users/tatwell/repos","events_url":"https://api.github.com/users/tatwell/events{/privacy}","received_events_url":"https://api.github.com/users/tatwell/received_events","type":"User","site_admin":false},"body":"@mirabelrice I agree blindly nesting like the article describes is bad (see line 5 of the Zen: `Flat is better than nested.`), but that's not what's really happening here. \r\n\r\nNotice, there's no empty rules. Rather, I'm targeting a specific case, e.g. the new slider master, to the exclusion of existing slightly variant versions. I've inherited a deeply nested structure here with the flex-slider. The SASS rules target specific pieces of it.\r\n\r\nBut I'm always open to cleaner alternative, provided they don't hide complexity or produce conflicts.","created_at":"2016-11-22T19:00:50Z","updated_at":"2016-11-22T19:00:50Z","html_url":"https://github.com/chapmanu/cascade-assets/pull/103#discussion_r89186230","pull_request_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments/89186230"},"html":{"href":"https://github.com/chapmanu/cascade-assets/pull/103#discussion_r89186230"},"pull_request":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103","id":94722517,"html_url":"https://github.com/chapmanu/cascade-assets/pull/103","diff_url":"https://github.com/chapmanu/cascade-assets/pull/103.diff","patch_url":"https://github.com/chapmanu/cascade-assets/pull/103.patch","issue_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/103","number":103,"state":"open","locked":false,"title":"As a web coordinator in Cascade, I want to be able to choose Wai's new mastheads in Cascade.","user":{"login":"tatwell","id":12798918,"avatar_url":"https://avatars.githubusercontent.com/u/12798918?v=3","gravatar_id":"","url":"https://api.github.com/users/tatwell","html_url":"https://github.com/tatwell","followers_url":"https://api.github.com/users/tatwell/followers","following_url":"https://api.github.com/users/tatwell/following{/other_user}","gists_url":"https://api.github.com/users/tatwell/gists{/gist_id}","starred_url":"https://api.github.com/users/tatwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatwell/subscriptions","organizations_url":"https://api.github.com/users/tatwell/orgs","repos_url":"https://api.github.com/users/tatwell/repos","events_url":"https://api.github.com/users/tatwell/events{/privacy}","received_events_url":"https://api.github.com/users/tatwell/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/nyCOSWbo/74-as-a-web-coordinator-in-cascade-i-want-to-be-able-to-choose-wai-s-new-mastheads-in-cascade#","created_at":"2016-11-21T23:59:37Z","updated_at":"2016-11-22T19:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5ee6a2de5d920a7a897e0ad29101a3c3b68fce8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103/commits","review_comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103/comments","review_comment_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/103/comments","statuses_url":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/54a996f20c6ded5101c9ffbaf552925b201a5f65","head":{"label":"chapmanu:new-cascade-masteheads","ref":"new-cascade-masteheads","sha":"54a996f20c6ded5101c9ffbaf552925b201a5f65","user":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars.githubusercontent.com/u/5008659?v=3","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"repo":{"id":31608435,"name":"cascade-assets","full_name":"chapmanu/cascade-assets","owner":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars.githubusercontent.com/u/5008659?v=3","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapmanu/cascade-assets","description":"Manage assets outside of cascade.","fork":false,"url":"https://api.github.com/repos/chapmanu/cascade-assets","forks_url":"https://api.github.com/repos/chapmanu/cascade-assets/forks","keys_url":"https://api.github.com/repos/chapmanu/cascade-assets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapmanu/cascade-assets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapmanu/cascade-assets/teams","hooks_url":"https://api.github.com/repos/chapmanu/cascade-assets/hooks","issue_events_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/events{/number}","events_url":"https://api.github.com/repos/chapmanu/cascade-assets/events","assignees_url":"https://api.github.com/repos/chapmanu/cascade-assets/assignees{/user}","branches_url":"https://api.github.com/repos/chapmanu/cascade-assets/branches{/branch}","tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/tags","blobs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/{sha}","languages_url":"https://api.github.com/repos/chapmanu/cascade-assets/languages","stargazers_url":"https://api.github.com/repos/chapmanu/cascade-assets/stargazers","contributors_url":"https://api.github.com/repos/chapmanu/cascade-assets/contributors","subscribers_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscribers","subscription_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscription","commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapmanu/cascade-assets/contents/{+path}","compare_url":"https://api.github.com/repos/chapmanu/cascade-assets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapmanu/cascade-assets/merges","archive_url":"https://api.github.com/repos/chapmanu/cascade-assets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapmanu/cascade-assets/downloads","issues_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues{/number}","pulls_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls{/number}","milestones_url":"https://api.github.com/repos/chapmanu/cascade-assets/milestones{/number}","notifications_url":"https://api.github.com/repos/chapmanu/cascade-assets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapmanu/cascade-assets/labels{/name}","releases_url":"https://api.github.com/repos/chapmanu/cascade-assets/releases{/id}","deployments_url":"https://api.github.com/repos/chapmanu/cascade-assets/deployments","created_at":"2015-03-03T16:26:42Z","updated_at":"2016-02-17T15:51:05Z","pushed_at":"2016-11-21T23:59:37Z","git_url":"git://github.com/chapmanu/cascade-assets.git","ssh_url":"git@github.com:chapmanu/cascade-assets.git","clone_url":"https://github.com/chapmanu/cascade-assets.git","svn_url":"https://github.com/chapmanu/cascade-assets","homepage":null,"size":30297,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"chapmanu:master","ref":"master","sha":"f8494697b77f12289c961767a42a99f59a63ffca","user":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars.githubusercontent.com/u/5008659?v=3","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"repo":{"id":31608435,"name":"cascade-assets","full_name":"chapmanu/cascade-assets","owner":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars.githubusercontent.com/u/5008659?v=3","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapmanu/cascade-assets","description":"Manage assets outside of cascade.","fork":false,"url":"https://api.github.com/repos/chapmanu/cascade-assets","forks_url":"https://api.github.com/repos/chapmanu/cascade-assets/forks","keys_url":"https://api.github.com/repos/chapmanu/cascade-assets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapmanu/cascade-assets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapmanu/cascade-assets/teams","hooks_url":"https://api.github.com/repos/chapmanu/cascade-assets/hooks","issue_events_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/events{/number}","events_url":"https://api.github.com/repos/chapmanu/cascade-assets/events","assignees_url":"https://api.github.com/repos/chapmanu/cascade-assets/assignees{/user}","branches_url":"https://api.github.com/repos/chapmanu/cascade-assets/branches{/branch}","tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/tags","blobs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/{sha}","languages_url":"https://api.github.com/repos/chapmanu/cascade-assets/languages","stargazers_url":"https://api.github.com/repos/chapmanu/cascade-assets/stargazers","contributors_url":"https://api.github.com/repos/chapmanu/cascade-assets/contributors","subscribers_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscribers","subscription_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscription","commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapmanu/cascade-assets/contents/{+path}","compare_url":"https://api.github.com/repos/chapmanu/cascade-assets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapmanu/cascade-assets/merges","archive_url":"https://api.github.com/repos/chapmanu/cascade-assets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapmanu/cascade-assets/downloads","issues_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues{/number}","pulls_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls{/number}","milestones_url":"https://api.github.com/repos/chapmanu/cascade-assets/milestones{/number}","notifications_url":"https://api.github.com/repos/chapmanu/cascade-assets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapmanu/cascade-assets/labels{/name}","releases_url":"https://api.github.com/repos/chapmanu/cascade-assets/releases{/id}","deployments_url":"https://api.github.com/repos/chapmanu/cascade-assets/deployments","created_at":"2015-03-03T16:26:42Z","updated_at":"2016-02-17T15:51:05Z","pushed_at":"2016-11-21T23:59:37Z","git_url":"git://github.com/chapmanu/cascade-assets.git","ssh_url":"git@github.com:chapmanu/cascade-assets.git","clone_url":"https://github.com/chapmanu/cascade-assets.git","svn_url":"https://github.com/chapmanu/cascade-assets","homepage":null,"size":30297,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103"},"html":{"href":"https://github.com/chapmanu/cascade-assets/pull/103"},"issue":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/issues/103"},"comments":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/54a996f20c6ded5101c9ffbaf552925b201a5f65"}}}}
{"actor":{"display_login":"tatwell"}}