{"action":"created","comment":{"url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/comments/59599612","id":59599612,"diff_hunk":"@@ -126,7 +126,12 @@ var Fragment = Model.extend(Ember.Comparable, Ember.Copyable, {\n   },\n \n   toStringExtension: function() {\n-    return 'owner(' + get(internalModelFor(this)._owner, 'id') + ')';\n+    let owner = internalModelFor(this)._owner;\n+    if (owner) {\n+      return 'owner(' + get(owner, 'id') + ')';\n+    } else {\n+      return '';\n+    }","path":"addon/fragment.js","position":10,"original_position":10,"commit_id":"30f73b62046cc5f370c01d8f76b8c212b4b23cb6","original_commit_id":"30f73b62046cc5f370c01d8f76b8c212b4b23cb6","user":{"login":"jakesjews","id":481412,"avatar_url":"https://avatars.githubusercontent.com/u/481412?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesjews","html_url":"https://github.com/jakesjews","followers_url":"https://api.github.com/users/jakesjews/followers","following_url":"https://api.github.com/users/jakesjews/following{/other_user}","gists_url":"https://api.github.com/users/jakesjews/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesjews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesjews/subscriptions","organizations_url":"https://api.github.com/users/jakesjews/orgs","repos_url":"https://api.github.com/users/jakesjews/repos","events_url":"https://api.github.com/users/jakesjews/events{/privacy}","received_events_url":"https://api.github.com/users/jakesjews/received_events","type":"User","site_admin":false},"body":"I actually found the problem with the combination of Ember-Data 2.4 and Ember 2.5. It was triggering a deprecation from Ember-Data using Ember.merge which was causing errors in this function. The problem doesn't seem to exist with Ember-Data 2.5 but I think this is good to prevent crashes.","created_at":"2016-04-13T18:25:14Z","updated_at":"2016-04-13T18:25:14Z","html_url":"https://github.com/lytics/ember-data-model-fragments/pull/194#discussion_r59599612","pull_request_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/comments/59599612"},"html":{"href":"https://github.com/lytics/ember-data-model-fragments/pull/194#discussion_r59599612"},"pull_request":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194","id":66083537,"html_url":"https://github.com/lytics/ember-data-model-fragments/pull/194","diff_url":"https://github.com/lytics/ember-data-model-fragments/pull/194.diff","patch_url":"https://github.com/lytics/ember-data-model-fragments/pull/194.patch","issue_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/194","number":194,"state":"open","locked":false,"title":"ember 2.5 compatibility","user":{"login":"jakesjews","id":481412,"avatar_url":"https://avatars.githubusercontent.com/u/481412?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesjews","html_url":"https://github.com/jakesjews","followers_url":"https://api.github.com/users/jakesjews/followers","following_url":"https://api.github.com/users/jakesjews/following{/other_user}","gists_url":"https://api.github.com/users/jakesjews/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesjews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesjews/subscriptions","organizations_url":"https://api.github.com/users/jakesjews/orgs","repos_url":"https://api.github.com/users/jakesjews/repos","events_url":"https://api.github.com/users/jakesjews/events{/privacy}","received_events_url":"https://api.github.com/users/jakesjews/received_events","type":"User","site_admin":false},"body":"Replace deprecated use of Ember.merge with Ember.assign.\r\n\r\nRight now an assertion is being triggered in ember-data since Ember.merge is being used and this is causing a null exception in toString() since it's called before the owner is set. It seems like there could be other cases where toString could be called before a parent is assigned so this might be a useful fix.","created_at":"2016-04-12T00:22:02Z","updated_at":"2016-04-13T18:25:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8ba01022e62b53ea40e829c70149aae567a0014","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194/commits","review_comments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194/comments","review_comment_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/194/comments","statuses_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/statuses/30f73b62046cc5f370c01d8f76b8c212b4b23cb6","head":{"label":"lytics:ember-2.5","ref":"ember-2.5","sha":"30f73b62046cc5f370c01d8f76b8c212b4b23cb6","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":17752746,"name":"ember-data-model-fragments","full_name":"lytics/ember-data-model-fragments","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/ember-data-model-fragments","description":"Ember Data addon to support nested JSON documents ","fork":false,"url":"https://api.github.com/repos/lytics/ember-data-model-fragments","forks_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/forks","keys_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/teams","hooks_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/hooks","issue_events_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/events","assignees_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/tags","blobs_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/languages","stargazers_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/stargazers","contributors_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/contributors","subscribers_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/subscribers","subscription_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/subscription","commits_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/merges","archive_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/downloads","issues_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/labels{/name}","releases_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/deployments","created_at":"2014-03-14T16:38:39Z","updated_at":"2016-04-11T05:46:05Z","pushed_at":"2016-04-12T00:22:03Z","git_url":"git://github.com/lytics/ember-data-model-fragments.git","ssh_url":"git@github.com:lytics/ember-data-model-fragments.git","clone_url":"https://github.com/lytics/ember-data-model-fragments.git","svn_url":"https://github.com/lytics/ember-data-model-fragments","homepage":"","size":2424,"stargazers_count":245,"watchers_count":245,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":9,"forks":55,"open_issues":9,"watchers":245,"default_branch":"master"}},"base":{"label":"lytics:master","ref":"master","sha":"d86b15a4eb4b216fe20a380754bc1457f8bdc352","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":17752746,"name":"ember-data-model-fragments","full_name":"lytics/ember-data-model-fragments","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/ember-data-model-fragments","description":"Ember Data addon to support nested JSON documents ","fork":false,"url":"https://api.github.com/repos/lytics/ember-data-model-fragments","forks_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/forks","keys_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/teams","hooks_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/hooks","issue_events_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/events","assignees_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/tags","blobs_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/languages","stargazers_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/stargazers","contributors_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/contributors","subscribers_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/subscribers","subscription_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/subscription","commits_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/merges","archive_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/downloads","issues_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/labels{/name}","releases_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/deployments","created_at":"2014-03-14T16:38:39Z","updated_at":"2016-04-11T05:46:05Z","pushed_at":"2016-04-12T00:22:03Z","git_url":"git://github.com/lytics/ember-data-model-fragments.git","ssh_url":"git@github.com:lytics/ember-data-model-fragments.git","clone_url":"https://github.com/lytics/ember-data-model-fragments.git","svn_url":"https://github.com/lytics/ember-data-model-fragments","homepage":"","size":2424,"stargazers_count":245,"watchers_count":245,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":9,"forks":55,"open_issues":9,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194"},"html":{"href":"https://github.com/lytics/ember-data-model-fragments/pull/194"},"issue":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/194"},"comments":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/lytics/ember-data-model-fragments/statuses/30f73b62046cc5f370c01d8f76b8c212b4b23cb6"}}}}