{"action":"opened","number":12481,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/12481","id":74332026,"html_url":"https://github.com/odoo/odoo/pull/12481","diff_url":"https://github.com/odoo/odoo/pull/12481.diff","patch_url":"https://github.com/odoo/odoo/pull/12481.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/12481","number":12481,"state":"open","locked":false,"title":"FIX account.invoice.tax base amount computation for taxes with includ…","user":{"login":"JosDeGraeve","id":7703788,"avatar_url":"https://avatars.githubusercontent.com/u/7703788?v=3","gravatar_id":"","url":"https://api.github.com/users/JosDeGraeve","html_url":"https://github.com/JosDeGraeve","followers_url":"https://api.github.com/users/JosDeGraeve/followers","following_url":"https://api.github.com/users/JosDeGraeve/following{/other_user}","gists_url":"https://api.github.com/users/JosDeGraeve/gists{/gist_id}","starred_url":"https://api.github.com/users/JosDeGraeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosDeGraeve/subscriptions","organizations_url":"https://api.github.com/users/JosDeGraeve/orgs","repos_url":"https://api.github.com/users/JosDeGraeve/repos","events_url":"https://api.github.com/users/JosDeGraeve/events{/privacy}","received_events_url":"https://api.github.com/users/JosDeGraeve/received_events","type":"User","site_admin":false},"body":"I have created an OPW ticket for this: 681102 ( issue 1 )\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nWhen using taxes with \"Affect base of subsequent taxes\" , the base amount is not correctly calculated on invoice tax lines\r\n\r\nCurrent behavior before PR:\r\n\r\ncreate a DB with belgian localization and demo data\r\nCreate a tax \"ECO\" ( let's say fixed 10 eur ) with these parameters:\r\nTax computation=FIXED\r\nAmount = 10\r\nAffect base of subsequent taxes = TRUE\r\nTax scope = Sale\r\nMake sure that the ECO tax is on top on the taxes list.\r\nCreate an invoice with 1 line:\r\ndescription TEST\r\nprice = 90 EUR\r\nTaxes: ECO tax + 21%\r\nValidate invoice, invoice total = 121 EUR which is totally correct\r\nPrint invoice, check the tax split lines on the printed invoice ( issue 1 ) ( see attachment invoices(2).pdf )\r\n\r\nObserved issue:\r\n* the VAT 21% has the base amount equal to 90 EUR\r\n\r\n\r\nDesired behavior after PR is merged:\r\n\r\n* the VAT 21% has the base amount equal to 100 EUR. The ECO tax affects the base of subsequent taxes and should be added to the base amount here.\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n\r\n…e_base_amount=True","created_at":"2016-06-18T08:51:35Z","updated_at":"2016-06-18T08:51:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/12481/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/12481/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/12481/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/c36d873866e239feec3e66bd81a5e4aa7921059f","head":{"label":"apertoso:9.0_fix_account_invoice_tax_base","ref":"9.0_fix_account_invoice_tax_base","sha":"c36d873866e239feec3e66bd81a5e4aa7921059f","user":{"login":"apertoso","id":7703792,"avatar_url":"https://avatars.githubusercontent.com/u/7703792?v=3","gravatar_id":"","url":"https://api.github.com/users/apertoso","html_url":"https://github.com/apertoso","followers_url":"https://api.github.com/users/apertoso/followers","following_url":"https://api.github.com/users/apertoso/following{/other_user}","gists_url":"https://api.github.com/users/apertoso/gists{/gist_id}","starred_url":"https://api.github.com/users/apertoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apertoso/subscriptions","organizations_url":"https://api.github.com/users/apertoso/orgs","repos_url":"https://api.github.com/users/apertoso/repos","events_url":"https://api.github.com/users/apertoso/events{/privacy}","received_events_url":"https://api.github.com/users/apertoso/received_events","type":"Organization","site_admin":false},"repo":{"id":21132979,"name":"odoo","full_name":"apertoso/odoo","owner":{"login":"apertoso","id":7703792,"avatar_url":"https://avatars.githubusercontent.com/u/7703792?v=3","gravatar_id":"","url":"https://api.github.com/users/apertoso","html_url":"https://github.com/apertoso","followers_url":"https://api.github.com/users/apertoso/followers","following_url":"https://api.github.com/users/apertoso/following{/other_user}","gists_url":"https://api.github.com/users/apertoso/gists{/gist_id}","starred_url":"https://api.github.com/users/apertoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apertoso/subscriptions","organizations_url":"https://api.github.com/users/apertoso/orgs","repos_url":"https://api.github.com/users/apertoso/repos","events_url":"https://api.github.com/users/apertoso/events{/privacy}","received_events_url":"https://api.github.com/users/apertoso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apertoso/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":true,"url":"https://api.github.com/repos/apertoso/odoo","forks_url":"https://api.github.com/repos/apertoso/odoo/forks","keys_url":"https://api.github.com/repos/apertoso/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apertoso/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apertoso/odoo/teams","hooks_url":"https://api.github.com/repos/apertoso/odoo/hooks","issue_events_url":"https://api.github.com/repos/apertoso/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/apertoso/odoo/events","assignees_url":"https://api.github.com/repos/apertoso/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/apertoso/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/apertoso/odoo/tags","blobs_url":"https://api.github.com/repos/apertoso/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apertoso/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apertoso/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apertoso/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apertoso/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/apertoso/odoo/languages","stargazers_url":"https://api.github.com/repos/apertoso/odoo/stargazers","contributors_url":"https://api.github.com/repos/apertoso/odoo/contributors","subscribers_url":"https://api.github.com/repos/apertoso/odoo/subscribers","subscription_url":"https://api.github.com/repos/apertoso/odoo/subscription","commits_url":"https://api.github.com/repos/apertoso/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apertoso/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apertoso/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apertoso/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apertoso/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/apertoso/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apertoso/odoo/merges","archive_url":"https://api.github.com/repos/apertoso/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apertoso/odoo/downloads","issues_url":"https://api.github.com/repos/apertoso/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/apertoso/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/apertoso/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/apertoso/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apertoso/odoo/labels{/name}","releases_url":"https://api.github.com/repos/apertoso/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/apertoso/odoo/deployments","created_at":"2014-06-23T16:11:43Z","updated_at":"2016-01-11T12:07:06Z","pushed_at":"2016-06-18T08:47:55Z","git_url":"git://github.com/apertoso/odoo.git","ssh_url":"git@github.com:apertoso/odoo.git","clone_url":"https://github.com/apertoso/odoo.git","svn_url":"https://github.com/apertoso/odoo","homepage":"https://www.odoo.com","size":1486611,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odoo:9.0","ref":"9.0","sha":"39a7ce44b02d1fd77ca23076c0e084342b31c747","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2016-06-17T21:24:56Z","pushed_at":"2016-06-18T03:42:42Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1722379,"stargazers_count":4467,"watchers_count":4467,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4283,"mirror_url":null,"open_issues_count":3113,"forks":4283,"open_issues":3113,"watchers":4467,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12481"},"html":{"href":"https://github.com/odoo/odoo/pull/12481"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/12481"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/12481/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12481/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12481/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/c36d873866e239feec3e66bd81a5e4aa7921059f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"JosDeGraeve"}}