{"action":"closed","number":530,"pull_request":{"url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530","id":79806690,"html_url":"https://github.com/openpathsampling/openpathsampling/pull/530","diff_url":"https://github.com/openpathsampling/openpathsampling/pull/530.diff","patch_url":"https://github.com/openpathsampling/openpathsampling/pull/530.patch","issue_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/530","number":530,"state":"closed","locked":false,"title":"New handling of MS-outer interface","user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"body":"As discussed with @jhprinz, I’m modifying the way that we create the MS outer interface. Previously, we automatically created it. But that led to some weird behavior (see, for example, the way it was unclear whether the last interface listed is MS-outer or not in the MISTIS example.) Plus, we think we’re going to move away from using MS-outer interface in the future (better to use state-swap moves; same decorrelation with less sampling effort).\r\n\r\nThe basic idea extends #528. Now we define the MS-outer in a separate step, as\r\n\r\n```python\r\nms_outer = MSOuterInterface(interface_sets, volumes, lambdas)\r\n```\r\n\r\n(with lambdas optional) or, if the `interface_sets` have a `.new_interface(lambda_i)` function:\r\n\r\n```python\r\nms_outer = MSOuterInterface.from_lambdas(interface_sets_lambdas)\r\n```\r\n\r\nwhere `interface_sets_lambdas` is a dictionary of the interface set to the lambda value for its part of the MS-outer ensemble. (I think this second version will be more commonly used; it reads cleaner.)\r\n\r\nThen, instead of being built immediately from the input interfaces for the `network`, each of `MSTISNetwork` and `MISTISNetwork` will have an additional option (after the transition info tuple they start with now) called `ms_outers`, which is a list of these `MSOuterInterface` objects (MISTIS can have multiple MS-outer interfaces).\r\n\r\nOverall, significance is this:\r\n* The way we used to set up outer interfaces was easiest if you assume you’ll want an outer interface. I no longer think that assumption is a good one.\r\n* The new approach is much more explicit about what you’re setting up, and I think it will be more clear to users (instead of magically taking one of their interfaces and turning it into an MS-outer, they have to define the MS-outer explicitly).\r\n\r\n- [x] Create the `MSOuterTISInterface` object\r\n- [x] Tests for `MSOuterTISInterface`\r\n- [x] Docstrings\r\n- [x] Use `MSOuterTISInterface` in networks with current input\r\n- [x] Update `MSTISNetwork` inputs\r\n- [x] Update `MISTISNetwork` inputs\r\n- [x] Code cleanup after changes","created_at":"2016-08-02T20:52:08Z","updated_at":"2016-08-03T20:14:18Z","closed_at":"2016-08-03T20:14:17Z","merged_at":"2016-08-03T20:14:17Z","merge_commit_sha":"d9839330e360ec213474b3c70e2b83c1de5a925f","assignee":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones/1","html_url":"https://github.com/openpathsampling/openpathsampling/milestones/1.0","labels_url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones/1/labels","id":882847,"number":1,"title":"1.0","description":"Issues that should be solved before first public release.","creator":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":86,"state":"open","created_at":"2014-11-27T17:27:40Z","updated_at":"2016-08-03T20:14:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530/commits","review_comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530/comments","review_comment_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/530/comments","statuses_url":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/8aad4a5a77fb7e3326a8dd595701dc0bb5ac482f","head":{"label":"dwhswenson:ms_outers","ref":"ms_outers","sha":"8aad4a5a77fb7e3326a8dd595701dc0bb5ac482f","user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"repo":{"id":23991437,"name":"openpathsampling","full_name":"dwhswenson/openpathsampling","owner":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwhswenson/openpathsampling","description":"A flexible, open framework for path sampling calculations","fork":true,"url":"https://api.github.com/repos/dwhswenson/openpathsampling","forks_url":"https://api.github.com/repos/dwhswenson/openpathsampling/forks","keys_url":"https://api.github.com/repos/dwhswenson/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwhswenson/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwhswenson/openpathsampling/teams","hooks_url":"https://api.github.com/repos/dwhswenson/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/dwhswenson/openpathsampling/events","assignees_url":"https://api.github.com/repos/dwhswenson/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/dwhswenson/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/dwhswenson/openpathsampling/tags","blobs_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwhswenson/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/dwhswenson/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/dwhswenson/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/dwhswenson/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/dwhswenson/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/dwhswenson/openpathsampling/subscription","commits_url":"https://api.github.com/repos/dwhswenson/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwhswenson/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwhswenson/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/dwhswenson/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwhswenson/openpathsampling/merges","archive_url":"https://api.github.com/repos/dwhswenson/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwhswenson/openpathsampling/downloads","issues_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/dwhswenson/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/dwhswenson/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/dwhswenson/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwhswenson/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/dwhswenson/openpathsampling/releases{/id}","deployments_url":"https://api.github.com/repos/dwhswenson/openpathsampling/deployments","created_at":"2014-09-13T10:15:43Z","updated_at":"2016-01-14T13:05:43Z","pushed_at":"2016-08-03T17:48:59Z","git_url":"git://github.com/dwhswenson/openpathsampling.git","ssh_url":"git@github.com:dwhswenson/openpathsampling.git","clone_url":"https://github.com/dwhswenson/openpathsampling.git","svn_url":"https://github.com/dwhswenson/openpathsampling","homepage":"","size":242098,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openpathsampling:master","ref":"master","sha":"44ec62fb3abf3feb6b093f4f6d7b6dfeb18e3426","user":{"login":"openpathsampling","id":19826308,"avatar_url":"https://avatars.githubusercontent.com/u/19826308?v=3","gravatar_id":"","url":"https://api.github.com/users/openpathsampling","html_url":"https://github.com/openpathsampling","followers_url":"https://api.github.com/users/openpathsampling/followers","following_url":"https://api.github.com/users/openpathsampling/following{/other_user}","gists_url":"https://api.github.com/users/openpathsampling/gists{/gist_id}","starred_url":"https://api.github.com/users/openpathsampling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpathsampling/subscriptions","organizations_url":"https://api.github.com/users/openpathsampling/orgs","repos_url":"https://api.github.com/users/openpathsampling/repos","events_url":"https://api.github.com/users/openpathsampling/events{/privacy}","received_events_url":"https://api.github.com/users/openpathsampling/received_events","type":"Organization","site_admin":false},"repo":{"id":12592267,"name":"openpathsampling","full_name":"openpathsampling/openpathsampling","owner":{"login":"openpathsampling","id":19826308,"avatar_url":"https://avatars.githubusercontent.com/u/19826308?v=3","gravatar_id":"","url":"https://api.github.com/users/openpathsampling","html_url":"https://github.com/openpathsampling","followers_url":"https://api.github.com/users/openpathsampling/followers","following_url":"https://api.github.com/users/openpathsampling/following{/other_user}","gists_url":"https://api.github.com/users/openpathsampling/gists{/gist_id}","starred_url":"https://api.github.com/users/openpathsampling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpathsampling/subscriptions","organizations_url":"https://api.github.com/users/openpathsampling/orgs","repos_url":"https://api.github.com/users/openpathsampling/repos","events_url":"https://api.github.com/users/openpathsampling/events{/privacy}","received_events_url":"https://api.github.com/users/openpathsampling/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openpathsampling/openpathsampling","description":"An open source Python framework for transition interface and path sampling calculations.","fork":false,"url":"https://api.github.com/repos/openpathsampling/openpathsampling","forks_url":"https://api.github.com/repos/openpathsampling/openpathsampling/forks","keys_url":"https://api.github.com/repos/openpathsampling/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openpathsampling/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openpathsampling/openpathsampling/teams","hooks_url":"https://api.github.com/repos/openpathsampling/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/openpathsampling/openpathsampling/events","assignees_url":"https://api.github.com/repos/openpathsampling/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/openpathsampling/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/openpathsampling/openpathsampling/tags","blobs_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/openpathsampling/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/openpathsampling/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/openpathsampling/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/openpathsampling/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/openpathsampling/openpathsampling/subscription","commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/openpathsampling/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/openpathsampling/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openpathsampling/openpathsampling/merges","archive_url":"https://api.github.com/repos/openpathsampling/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openpathsampling/openpathsampling/downloads","issues_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/openpathsampling/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openpathsampling/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/openpathsampling/openpathsampling/releases{/id}","deployments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/deployments","created_at":"2013-09-04T14:06:28Z","updated_at":"2016-07-28T16:13:01Z","pushed_at":"2016-08-03T20:14:18Z","git_url":"git://github.com/openpathsampling/openpathsampling.git","ssh_url":"git@github.com:openpathsampling/openpathsampling.git","clone_url":"https://github.com/openpathsampling/openpathsampling.git","svn_url":"https://github.com/openpathsampling/openpathsampling","homepage":"","size":246516,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":57,"forks":8,"open_issues":57,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530"},"html":{"href":"https://github.com/openpathsampling/openpathsampling/pull/530"},"issue":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/530"},"comments":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/530/comments"},"review_comments":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530/comments"},"review_comment":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/530/commits"},"statuses":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/8aad4a5a77fb7e3326a8dd595701dc0bb5ac482f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":28,"additions":576,"deletions":189,"changed_files":15}}
{"actor":{"display_login":"jhprinz"}}