{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19799","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19799/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19799/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19799/events","html_url":"https://github.com/kubernetes/kubernetes/pull/19799","id":127311015,"number":19799,"title":"AWS: Reuse more GCE kube-up infrastructure","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000"}],"state":"open","locked":false,"assignee":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-01-18T21:05:52Z","updated_at":"2016-01-20T17:26:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19799","html_url":"https://github.com/kubernetes/kubernetes/pull/19799","diff_url":"https://github.com/kubernetes/kubernetes/pull/19799.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19799.patch"},"body":"This continues on from #19776, and probably it is much easier to review that PR first.\r\n\r\nWe are able to reuse the GCE scripts to remove a huge amount of AWS kube-up code.  Moreover, because kube-up is now much closer to how GCE works, we can now more easily implement kube-push and upgrade.\r\n\r\nImportant points:\r\n\r\n* There is a 16KB metadata limit on AWS.  So we upload just the settings as metadata, along with a brief `wget | sh` of the configure-vm.sh script.  That script is uploaded alongside kubernetes.tar.gz.  We have to gzip the user data to fit under the 16KB limit (cloud-init handles this automatically)\r\n\r\n* We currently reuse GCE's configure-vm.sh script, primarily using nasty sed tricks to remove blocks of code between `#+GCE` and `#-GCE`.  I would like to change GCE kube-up also to build configure-vm dynamically, combining common code with provider-specific code as the AWS code does.  I guess I could also just override the functions, but this might be confusing.  Or maybe not?\r\n\r\n* This also switches AWS to operate in local-salt mode on the nodes (i.e. the same as GCE)\r\n "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/173289347","html_url":"https://github.com/kubernetes/kubernetes/pull/19799#issuecomment-173289347","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19799","id":173289347,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T17:26:20Z","updated_at":"2016-01-20T17:26:20Z","body":"GCE e2e build/test **failed** for commit ad8ec76509fa518417fd573dbbff777e494946b1.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/ad8ec76509fa518417fd573dbbff777e494946b1/kubernetes-pull-build-test-e2e-gce/24318/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/ad8ec76509fa518417fd573dbbff777e494946b1/kubernetes-pull-build-test-e2e-gce/24318/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//24318)\n"}}