{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/72807741","id":72807741,"diff_hunk":"@@ -2934,7 +2941,7 @@ unittest\n \n private enum isSlicePointer(T) = isPointer!T || is(T : PtrShell!R, R);\n \n-private struct LikePtr {}\n+package struct LikePtr {}","path":"std/experimental/ndslice/slice.d","position":241,"original_position":82,"commit_id":"8896310c6fe3bb5d92d3d1aff0eaa7e0226457b6","original_commit_id":"6c3576b65883a42d9f2e010e4c79d48ec7f7a45c","user":{"login":"klickverbot","id":19335,"avatar_url":"https://avatars.githubusercontent.com/u/19335?v=3","gravatar_id":"","url":"https://api.github.com/users/klickverbot","html_url":"https://github.com/klickverbot","followers_url":"https://api.github.com/users/klickverbot/followers","following_url":"https://api.github.com/users/klickverbot/following{/other_user}","gists_url":"https://api.github.com/users/klickverbot/gists{/gist_id}","starred_url":"https://api.github.com/users/klickverbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klickverbot/subscriptions","organizations_url":"https://api.github.com/users/klickverbot/orgs","repos_url":"https://api.github.com/users/klickverbot/repos","events_url":"https://api.github.com/users/klickverbot/events{/privacy}","received_events_url":"https://api.github.com/users/klickverbot/received_events","type":"User","site_admin":false},"body":"What if I want to implement my own algorithm that is not part of Phobos? It seems like I would want to be able to use `LikePtr` in such a situation to interface seamlessly with the rest of ndslice.","created_at":"2016-07-29T15:09:25Z","updated_at":"2016-07-29T15:09:25Z","html_url":"https://github.com/dlang/phobos/pull/4652#discussion_r72807741","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/4652","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/72807741"},"html":{"href":"https://github.com/dlang/phobos/pull/4652#discussion_r72807741"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4652"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4652","id":78730944,"html_url":"https://github.com/dlang/phobos/pull/4652","diff_url":"https://github.com/dlang/phobos/pull/4652.diff","patch_url":"https://github.com/dlang/phobos/pull/4652.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4652","number":4652,"state":"open","locked":false,"title":"ndslice.algorithm","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=3","gravatar_id":"","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"body":"### ndslice.algorithm\r\n\r\n- [x] `ndMap` (multidimensional map type of `Slice(N, xxx)`)\r\n- [x] `ndFold` (single tensor, multiple functions and seeds)\r\n- [x] `ndReduce` (single seed, multiple tensors)\r\n- [x] `ndEach` (no seed, multiple tensors)\r\n- [x] `ndAll` (multiple tensors)\r\n- [x] `ndAny` (multiple tensors)\r\n- [x] `ndFindNeedle` (multiple tensors)\r\n- [x] `ndCanFindNeedle` (multiple tensors)\r\n- [x] `ndFind` (multiple tensors)\r\n- [x] `ndCmp` (multidimensional propagation)\r\n- [x] `ndEqual` (multiple tensors)\r\n- [ ] Add more tests\r\n  - [ ] packed slices\r\n  - [ ] Zipped slices with `assumeSameStructure`\r\n- [ ] Update docs\r\n  - [ ] Module description\r\n  - [ ] Notes about why no `ndZip` and why `assumeSameStructure`\r\n  - [ ] Notes about `ref` parameters.\r\n  - [ ] Notes about optimisation in case of `ndMap` (when `.front` is not `ref`)\r\n  - [ ] Refs in `std.algorithm`\r\n\r\n### ndslice.slice\r\n- [x] optimize memory allocations using `ndFold`. \r\n- [x] opCmp using ndCmp\r\n","created_at":"2016-07-25T18:42:44Z","updated_at":"2016-07-29T15:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69cf4ac3a882de00f0e8c47811b856874d0e2ad5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4652/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4652/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4652/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/8896310c6fe3bb5d92d3d1aff0eaa7e0226457b6","head":{"label":"9il:ndmap2","ref":"ndmap2","sha":"8896310c6fe3bb5d92d3d1aff0eaa7e0226457b6","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=3","gravatar_id":"","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"repo":{"id":63796209,"name":"phobos","full_name":"9il/phobos","owner":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=3","gravatar_id":"","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9il/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/9il/phobos","forks_url":"https://api.github.com/repos/9il/phobos/forks","keys_url":"https://api.github.com/repos/9il/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9il/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9il/phobos/teams","hooks_url":"https://api.github.com/repos/9il/phobos/hooks","issue_events_url":"https://api.github.com/repos/9il/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/9il/phobos/events","assignees_url":"https://api.github.com/repos/9il/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/9il/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/9il/phobos/tags","blobs_url":"https://api.github.com/repos/9il/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9il/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9il/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/9il/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9il/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/9il/phobos/languages","stargazers_url":"https://api.github.com/repos/9il/phobos/stargazers","contributors_url":"https://api.github.com/repos/9il/phobos/contributors","subscribers_url":"https://api.github.com/repos/9il/phobos/subscribers","subscription_url":"https://api.github.com/repos/9il/phobos/subscription","commits_url":"https://api.github.com/repos/9il/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/9il/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/9il/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/9il/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/9il/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/9il/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9il/phobos/merges","archive_url":"https://api.github.com/repos/9il/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9il/phobos/downloads","issues_url":"https://api.github.com/repos/9il/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/9il/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/9il/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/9il/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9il/phobos/labels{/name}","releases_url":"https://api.github.com/repos/9il/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/9il/phobos/deployments","created_at":"2016-07-20T16:17:20Z","updated_at":"2016-07-20T16:17:24Z","pushed_at":"2016-07-29T14:59:56Z","git_url":"git://github.com/9il/phobos.git","ssh_url":"git@github.com:9il/phobos.git","clone_url":"https://github.com/9il/phobos.git","svn_url":"https://github.com/9il/phobos","homepage":"dlang.org/phobos","size":45339,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"6db08d3dadb007d930a4042a6140ca4fb22ea540","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-07-27T09:44:23Z","pushed_at":"2016-07-29T14:59:57Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":74392,"stargazers_count":726,"watchers_count":726,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":null,"open_issues_count":108,"forks":504,"open_issues":108,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4652"},"html":{"href":"https://github.com/dlang/phobos/pull/4652"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4652"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4652/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4652/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4652/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/8896310c6fe3bb5d92d3d1aff0eaa7e0226457b6"}}}}
{"actor":{"display_login":"klickverbot"}}