{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55","id":91474743,"html_url":"https://github.com/manatee-matinee/piddle/pull/55","diff_url":"https://github.com/manatee-matinee/piddle/pull/55.diff","patch_url":"https://github.com/manatee-matinee/piddle/pull/55.patch","issue_url":"https://api.github.com/repos/manatee-matinee/piddle/issues/55","number":55,"state":"closed","locked":false,"title":"(feature) Change static file folder","user":{"login":"rhinodavid","id":5778036,"avatar_url":"https://avatars.githubusercontent.com/u/5778036?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinodavid","html_url":"https://github.com/rhinodavid","followers_url":"https://api.github.com/users/rhinodavid/followers","following_url":"https://api.github.com/users/rhinodavid/following{/other_user}","gists_url":"https://api.github.com/users/rhinodavid/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinodavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinodavid/subscriptions","organizations_url":"https://api.github.com/users/rhinodavid/orgs","repos_url":"https://api.github.com/users/rhinodavid/repos","events_url":"https://api.github.com/users/rhinodavid/events{/privacy}","received_events_url":"https://api.github.com/users/rhinodavid/received_events","type":"User","site_admin":false},"body":"The react-scripts `build` script places the generated files in the `build` folder, not `public`, so I've changed the server to serve up files from `build` and deleted `public`. I also have set it up so that if a path 404s, the server will serve up `index.html`. This will let React handle the routing. We will need to a add a 'catch-all' in the React router so actual 404s will display as such, but now you can, for instance, paste http://localhost:3000/login into a new window and still get to the React login screen, which didn't work before, and accessing bill shortIds by going to http://localhost:3000/<shortId> should be possible too from client-side routing.","created_at":"2016-10-29T01:48:49Z","updated_at":"2016-10-30T02:50:35Z","closed_at":"2016-10-30T02:50:35Z","merged_at":"2016-10-30T02:50:35Z","merge_commit_sha":"f9a93982a7b7c30f2640f26125c52f8527d360b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55/commits","review_comments_url":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55/comments","review_comment_url":"https://api.github.com/repos/manatee-matinee/piddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manatee-matinee/piddle/issues/55/comments","statuses_url":"https://api.github.com/repos/manatee-matinee/piddle/statuses/57ddee7aaff2a9361636908169b7a82573b8a69e","head":{"label":"rhinodavid:buildfolder","ref":"buildfolder","sha":"57ddee7aaff2a9361636908169b7a82573b8a69e","user":{"login":"rhinodavid","id":5778036,"avatar_url":"https://avatars.githubusercontent.com/u/5778036?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinodavid","html_url":"https://github.com/rhinodavid","followers_url":"https://api.github.com/users/rhinodavid/followers","following_url":"https://api.github.com/users/rhinodavid/following{/other_user}","gists_url":"https://api.github.com/users/rhinodavid/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinodavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinodavid/subscriptions","organizations_url":"https://api.github.com/users/rhinodavid/orgs","repos_url":"https://api.github.com/users/rhinodavid/repos","events_url":"https://api.github.com/users/rhinodavid/events{/privacy}","received_events_url":"https://api.github.com/users/rhinodavid/received_events","type":"User","site_admin":false},"repo":{"id":71941560,"name":"piddle","full_name":"rhinodavid/piddle","owner":{"login":"rhinodavid","id":5778036,"avatar_url":"https://avatars.githubusercontent.com/u/5778036?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinodavid","html_url":"https://github.com/rhinodavid","followers_url":"https://api.github.com/users/rhinodavid/followers","following_url":"https://api.github.com/users/rhinodavid/following{/other_user}","gists_url":"https://api.github.com/users/rhinodavid/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinodavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinodavid/subscriptions","organizations_url":"https://api.github.com/users/rhinodavid/orgs","repos_url":"https://api.github.com/users/rhinodavid/repos","events_url":"https://api.github.com/users/rhinodavid/events{/privacy}","received_events_url":"https://api.github.com/users/rhinodavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhinodavid/piddle","description":null,"fork":true,"url":"https://api.github.com/repos/rhinodavid/piddle","forks_url":"https://api.github.com/repos/rhinodavid/piddle/forks","keys_url":"https://api.github.com/repos/rhinodavid/piddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinodavid/piddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinodavid/piddle/teams","hooks_url":"https://api.github.com/repos/rhinodavid/piddle/hooks","issue_events_url":"https://api.github.com/repos/rhinodavid/piddle/issues/events{/number}","events_url":"https://api.github.com/repos/rhinodavid/piddle/events","assignees_url":"https://api.github.com/repos/rhinodavid/piddle/assignees{/user}","branches_url":"https://api.github.com/repos/rhinodavid/piddle/branches{/branch}","tags_url":"https://api.github.com/repos/rhinodavid/piddle/tags","blobs_url":"https://api.github.com/repos/rhinodavid/piddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinodavid/piddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinodavid/piddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinodavid/piddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinodavid/piddle/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinodavid/piddle/languages","stargazers_url":"https://api.github.com/repos/rhinodavid/piddle/stargazers","contributors_url":"https://api.github.com/repos/rhinodavid/piddle/contributors","subscribers_url":"https://api.github.com/repos/rhinodavid/piddle/subscribers","subscription_url":"https://api.github.com/repos/rhinodavid/piddle/subscription","commits_url":"https://api.github.com/repos/rhinodavid/piddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinodavid/piddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinodavid/piddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinodavid/piddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinodavid/piddle/contents/{+path}","compare_url":"https://api.github.com/repos/rhinodavid/piddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinodavid/piddle/merges","archive_url":"https://api.github.com/repos/rhinodavid/piddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinodavid/piddle/downloads","issues_url":"https://api.github.com/repos/rhinodavid/piddle/issues{/number}","pulls_url":"https://api.github.com/repos/rhinodavid/piddle/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinodavid/piddle/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinodavid/piddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinodavid/piddle/labels{/name}","releases_url":"https://api.github.com/repos/rhinodavid/piddle/releases{/id}","deployments_url":"https://api.github.com/repos/rhinodavid/piddle/deployments","created_at":"2016-10-25T21:43:17Z","updated_at":"2016-10-26T19:28:39Z","pushed_at":"2016-10-29T23:10:11Z","git_url":"git://github.com/rhinodavid/piddle.git","ssh_url":"git@github.com:rhinodavid/piddle.git","clone_url":"https://github.com/rhinodavid/piddle.git","svn_url":"https://github.com/rhinodavid/piddle","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"manatee-matinee:develop","ref":"develop","sha":"a353c8deebe5af4317cbaf6cb3f520a650307cf2","user":{"login":"manatee-matinee","id":22945776,"avatar_url":"https://avatars.githubusercontent.com/u/22945776?v=3","gravatar_id":"","url":"https://api.github.com/users/manatee-matinee","html_url":"https://github.com/manatee-matinee","followers_url":"https://api.github.com/users/manatee-matinee/followers","following_url":"https://api.github.com/users/manatee-matinee/following{/other_user}","gists_url":"https://api.github.com/users/manatee-matinee/gists{/gist_id}","starred_url":"https://api.github.com/users/manatee-matinee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manatee-matinee/subscriptions","organizations_url":"https://api.github.com/users/manatee-matinee/orgs","repos_url":"https://api.github.com/users/manatee-matinee/repos","events_url":"https://api.github.com/users/manatee-matinee/events{/privacy}","received_events_url":"https://api.github.com/users/manatee-matinee/received_events","type":"Organization","site_admin":false},"repo":{"id":71401179,"name":"piddle","full_name":"manatee-matinee/piddle","owner":{"login":"manatee-matinee","id":22945776,"avatar_url":"https://avatars.githubusercontent.com/u/22945776?v=3","gravatar_id":"","url":"https://api.github.com/users/manatee-matinee","html_url":"https://github.com/manatee-matinee","followers_url":"https://api.github.com/users/manatee-matinee/followers","following_url":"https://api.github.com/users/manatee-matinee/following{/other_user}","gists_url":"https://api.github.com/users/manatee-matinee/gists{/gist_id}","starred_url":"https://api.github.com/users/manatee-matinee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manatee-matinee/subscriptions","organizations_url":"https://api.github.com/users/manatee-matinee/orgs","repos_url":"https://api.github.com/users/manatee-matinee/repos","events_url":"https://api.github.com/users/manatee-matinee/events{/privacy}","received_events_url":"https://api.github.com/users/manatee-matinee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/manatee-matinee/piddle","description":null,"fork":false,"url":"https://api.github.com/repos/manatee-matinee/piddle","forks_url":"https://api.github.com/repos/manatee-matinee/piddle/forks","keys_url":"https://api.github.com/repos/manatee-matinee/piddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manatee-matinee/piddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manatee-matinee/piddle/teams","hooks_url":"https://api.github.com/repos/manatee-matinee/piddle/hooks","issue_events_url":"https://api.github.com/repos/manatee-matinee/piddle/issues/events{/number}","events_url":"https://api.github.com/repos/manatee-matinee/piddle/events","assignees_url":"https://api.github.com/repos/manatee-matinee/piddle/assignees{/user}","branches_url":"https://api.github.com/repos/manatee-matinee/piddle/branches{/branch}","tags_url":"https://api.github.com/repos/manatee-matinee/piddle/tags","blobs_url":"https://api.github.com/repos/manatee-matinee/piddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manatee-matinee/piddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manatee-matinee/piddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/manatee-matinee/piddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manatee-matinee/piddle/statuses/{sha}","languages_url":"https://api.github.com/repos/manatee-matinee/piddle/languages","stargazers_url":"https://api.github.com/repos/manatee-matinee/piddle/stargazers","contributors_url":"https://api.github.com/repos/manatee-matinee/piddle/contributors","subscribers_url":"https://api.github.com/repos/manatee-matinee/piddle/subscribers","subscription_url":"https://api.github.com/repos/manatee-matinee/piddle/subscription","commits_url":"https://api.github.com/repos/manatee-matinee/piddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/manatee-matinee/piddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/manatee-matinee/piddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/manatee-matinee/piddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/manatee-matinee/piddle/contents/{+path}","compare_url":"https://api.github.com/repos/manatee-matinee/piddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manatee-matinee/piddle/merges","archive_url":"https://api.github.com/repos/manatee-matinee/piddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manatee-matinee/piddle/downloads","issues_url":"https://api.github.com/repos/manatee-matinee/piddle/issues{/number}","pulls_url":"https://api.github.com/repos/manatee-matinee/piddle/pulls{/number}","milestones_url":"https://api.github.com/repos/manatee-matinee/piddle/milestones{/number}","notifications_url":"https://api.github.com/repos/manatee-matinee/piddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manatee-matinee/piddle/labels{/name}","releases_url":"https://api.github.com/repos/manatee-matinee/piddle/releases{/id}","deployments_url":"https://api.github.com/repos/manatee-matinee/piddle/deployments","created_at":"2016-10-19T21:34:24Z","updated_at":"2016-10-19T21:34:24Z","pushed_at":"2016-10-30T02:50:35Z","git_url":"git://github.com/manatee-matinee/piddle.git","ssh_url":"git@github.com:manatee-matinee/piddle.git","clone_url":"https://github.com/manatee-matinee/piddle.git","svn_url":"https://github.com/manatee-matinee/piddle","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55"},"html":{"href":"https://github.com/manatee-matinee/piddle/pull/55"},"issue":{"href":"https://api.github.com/repos/manatee-matinee/piddle/issues/55"},"comments":{"href":"https://api.github.com/repos/manatee-matinee/piddle/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/manatee-matinee/piddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manatee-matinee/piddle/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/manatee-matinee/piddle/statuses/57ddee7aaff2a9361636908169b7a82573b8a69e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cashweaver","id":5192047,"avatar_url":"https://avatars.githubusercontent.com/u/5192047?v=3","gravatar_id":"","url":"https://api.github.com/users/cashweaver","html_url":"https://github.com/cashweaver","followers_url":"https://api.github.com/users/cashweaver/followers","following_url":"https://api.github.com/users/cashweaver/following{/other_user}","gists_url":"https://api.github.com/users/cashweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/cashweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cashweaver/subscriptions","organizations_url":"https://api.github.com/users/cashweaver/orgs","repos_url":"https://api.github.com/users/cashweaver/repos","events_url":"https://api.github.com/users/cashweaver/events{/privacy}","received_events_url":"https://api.github.com/users/cashweaver/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":32,"changed_files":3}}
{"actor":{"display_login":"cashweaver"}}