{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6252","repository_url":"https://api.github.com/repos/ember-cli/ember-cli","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6252/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6252/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6252/events","html_url":"https://github.com/ember-cli/ember-cli/issues/6252","id":176468294,"number":6252,"title":"Prototype Extensions are disabled in 2.8.0's blueprint.","user":{"login":"nathanhammond","id":20542,"avatar_url":"https://avatars.githubusercontent.com/u/20542?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhammond","html_url":"https://github.com/nathanhammond","followers_url":"https://api.github.com/users/nathanhammond/followers","following_url":"https://api.github.com/users/nathanhammond/following{/other_user}","gists_url":"https://api.github.com/users/nathanhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhammond/subscriptions","organizations_url":"https://api.github.com/users/nathanhammond/orgs","repos_url":"https://api.github.com/users/nathanhammond/repos","events_url":"https://api.github.com/users/nathanhammond/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhammond/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Regression","name":"Regression","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-12T19:54:29Z","updated_at":"2016-09-12T20:40:22Z","closed_at":null,"body":"#6194 accidentally turned off prototype extensions in newly generated apps. We have two possible solutions proposed by @cibernox:\r\n\r\n1. Modify the blueprint to specify each of the prototypes which we extend as proposed by @morhook [here](https://github.com/ember-cli/ember-cli/pull/6194#issuecomment-243815707).\r\n2. Make the code in Ember check for explicit `true` or `false`.\r\n\r\nWe should also take this opportunity to discuss the future of prototype extensions."},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/246485032","html_url":"https://github.com/ember-cli/ember-cli/issues/6252#issuecomment-246485032","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6252","id":246485032,"user":{"login":"cibernox","id":265339,"avatar_url":"https://avatars.githubusercontent.com/u/265339?v=3","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T20:40:22Z","updated_at":"2016-09-12T20:40:22Z","body":"To clarify, I proposed to check for explicit `false` since now it's the default, but if the plan is to deprecate prototype extensions, in that case I'd advocate the opposite and check for `true`.\r\n\r\nWhen it comes to prototype extensions, I think that the only problematic one is Array. 95% of apps wont notice disabling extensions in Date. Around 70% won't notice removing `.property` and `.observes` from Function since `Ember.computed/observer` have been encouraged for a long time. String extensions are a bit more extended, but Array is the real deal."}}
{"actor":{"display_login":"cibernox"}}