{"action":"created","issue":{"url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/4","repository_url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers","labels_url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/4/comments","events_url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/4/events","html_url":"https://github.com/LocusEnergy/ember-d3-helpers/pull/4","id":162763825,"number":4,"title":"Updates D3 to v4 RC1, updates Ember-CLI to v2.6","user":{"login":"zigahertz","id":2994167,"avatar_url":"https://avatars.githubusercontent.com/u/2994167?v=3","gravatar_id":"","url":"https://api.github.com/users/zigahertz","html_url":"https://github.com/zigahertz","followers_url":"https://api.github.com/users/zigahertz/followers","following_url":"https://api.github.com/users/zigahertz/following{/other_user}","gists_url":"https://api.github.com/users/zigahertz/gists{/gist_id}","starred_url":"https://api.github.com/users/zigahertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zigahertz/subscriptions","organizations_url":"https://api.github.com/users/zigahertz/orgs","repos_url":"https://api.github.com/users/zigahertz/repos","events_url":"https://api.github.com/users/zigahertz/events{/privacy}","received_events_url":"https://api.github.com/users/zigahertz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-06-28T19:15:28Z","updated_at":"2016-07-03T04:25:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/pulls/4","html_url":"https://github.com/LocusEnergy/ember-d3-helpers/pull/4","diff_url":"https://github.com/LocusEnergy/ember-d3-helpers/pull/4.diff","patch_url":"https://github.com/LocusEnergy/ember-d3-helpers/pull/4.patch"},"body":"This recreates the PR made by @ivanvanderbyl at https://github.com/spencer516/ember-d3-scale/pull/9. CCing @spencer516 and @taras "},"comment":{"url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/comments/230134720","html_url":"https://github.com/LocusEnergy/ember-d3-helpers/pull/4#issuecomment-230134720","issue_url":"https://api.github.com/repos/LocusEnergy/ember-d3-helpers/issues/4","id":230134720,"user":{"login":"zigahertz","id":2994167,"avatar_url":"https://avatars.githubusercontent.com/u/2994167?v=3","gravatar_id":"","url":"https://api.github.com/users/zigahertz","html_url":"https://github.com/zigahertz","followers_url":"https://api.github.com/users/zigahertz/followers","following_url":"https://api.github.com/users/zigahertz/following{/other_user}","gists_url":"https://api.github.com/users/zigahertz/gists{/gist_id}","starred_url":"https://api.github.com/users/zigahertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zigahertz/subscriptions","organizations_url":"https://api.github.com/users/zigahertz/orgs","repos_url":"https://api.github.com/users/zigahertz/repos","events_url":"https://api.github.com/users/zigahertz/events{/privacy}","received_events_url":"https://api.github.com/users/zigahertz/received_events","type":"User","site_admin":false},"created_at":"2016-07-03T04:25:14Z","updated_at":"2016-07-03T04:25:14Z","body":"Ok, @spencer516 I uncommented that line - tests for the `cat-color-scale` are failing, I didn't have time to dig into this too deeply - when using a color scale, the scheme categories from https://github.com/LocusEnergy/ember-d3-helpers/pull/4/files#diff-a2cbf1a835f25bb02cb42e2460dc1893R2 are just strings, and not functions, so https://github.com/LocusEnergy/ember-d3-helpers/blob/master/addon/utils/guid-domain-scale.js#L9 is failing. I think we can convert the string to an ordinal scale, and then pass to `guidDomainScale`. I can spend more time on this next week, curious if the solution is more immediately apparent to you. "}}
{"actor":{"display_login":"zigahertz"}}