{"action":"created","comment":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/comments/58061768","id":58061768,"diff_hunk":"@@ -56,5 +56,35 @@\n \n       it { expect {process.start}.to raise_error Aruba::LaunchError }\n     end\n+\n+    context \"with a childprocess launch error\" do\n+      let(:child) { instance_double(ChildProcess::AbstractProcess) }","path":"spec/aruba/spawn_process_spec.rb","position":6,"original_position":6,"commit_id":"e34e26eeda7f49b3d08f0e1f84354931844f2dd9","original_commit_id":"e34e26eeda7f49b3d08f0e1f84354931844f2dd9","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"body":"ChildProcess is from the `child_process` gem, that's why I mocked it out. (https://github.com/jarib/childprocess).\r\n","created_at":"2016-03-31T14:22:36Z","updated_at":"2016-03-31T14:22:36Z","html_url":"https://github.com/cucumber/aruba/pull/357#discussion_r58061768","pull_request_url":"https://api.github.com/repos/cucumber/aruba/pulls/357","_links":{"self":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/comments/58061768"},"html":{"href":"https://github.com/cucumber/aruba/pull/357#discussion_r58061768"},"pull_request":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/357","id":64718188,"html_url":"https://github.com/cucumber/aruba/pull/357","diff_url":"https://github.com/cucumber/aruba/pull/357.diff","patch_url":"https://github.com/cucumber/aruba/pull/357.patch","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/357","number":357,"state":"open","locked":false,"title":"Fix broken exception handler","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nAn old, undefined variable (`cmd`) was left over after refactoring. It was replaced with the right one (`commandline`).\r\n\r\nAlso, a spec was added to force the code to fail on Unix.\r\n\r\n## Details\r\n\r\nThis caused failures on AppVeyor, because the exception handler crashed.\r\n\r\nThis failed only on Windows because the PATH traversing didn't throw an error earlier.\r\n\r\nStill, the error could've occurred on Unix if the program was in the PATH (so no exception there), and yet there was an error accessing a program's file (like if the file wasn't readable). \r\n\r\n## Motivation and Context\r\n\r\nFixes failure on AppVeyor.\r\n\r\n## How Has This Been Tested?\r\n\r\nLocally, RSpec.\r\n\r\nThis probably can be simulated in Cucumber scenarios by having an unreadable binary file (e.g. using `chmod -r`)\r\n\r\n## Types of changes\r\n\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n\r\n## Checklist:\r\n\r\n- [X] My code follows the code style of this project.\r\n","created_at":"2016-03-31T00:23:57Z","updated_at":"2016-03-31T14:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1118433334c01e012a5130a232c420951fd3d6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/aruba/pulls/357/commits","review_comments_url":"https://api.github.com/repos/cucumber/aruba/pulls/357/comments","review_comment_url":"https://api.github.com/repos/cucumber/aruba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/357/comments","statuses_url":"https://api.github.com/repos/cucumber/aruba/statuses/e34e26eeda7f49b3d08f0e1f84354931844f2dd9","head":{"label":"e2:e2-fix_broken_exception_handler","ref":"e2-fix_broken_exception_handler","sha":"e34e26eeda7f49b3d08f0e1f84354931844f2dd9","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"repo":{"id":37140323,"name":"aruba","full_name":"e2/aruba","owner":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/e2/aruba","description":"CLI Steps for Cucumber","fork":true,"url":"https://api.github.com/repos/e2/aruba","forks_url":"https://api.github.com/repos/e2/aruba/forks","keys_url":"https://api.github.com/repos/e2/aruba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e2/aruba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e2/aruba/teams","hooks_url":"https://api.github.com/repos/e2/aruba/hooks","issue_events_url":"https://api.github.com/repos/e2/aruba/issues/events{/number}","events_url":"https://api.github.com/repos/e2/aruba/events","assignees_url":"https://api.github.com/repos/e2/aruba/assignees{/user}","branches_url":"https://api.github.com/repos/e2/aruba/branches{/branch}","tags_url":"https://api.github.com/repos/e2/aruba/tags","blobs_url":"https://api.github.com/repos/e2/aruba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e2/aruba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e2/aruba/git/refs{/sha}","trees_url":"https://api.github.com/repos/e2/aruba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e2/aruba/statuses/{sha}","languages_url":"https://api.github.com/repos/e2/aruba/languages","stargazers_url":"https://api.github.com/repos/e2/aruba/stargazers","contributors_url":"https://api.github.com/repos/e2/aruba/contributors","subscribers_url":"https://api.github.com/repos/e2/aruba/subscribers","subscription_url":"https://api.github.com/repos/e2/aruba/subscription","commits_url":"https://api.github.com/repos/e2/aruba/commits{/sha}","git_commits_url":"https://api.github.com/repos/e2/aruba/git/commits{/sha}","comments_url":"https://api.github.com/repos/e2/aruba/comments{/number}","issue_comment_url":"https://api.github.com/repos/e2/aruba/issues/comments{/number}","contents_url":"https://api.github.com/repos/e2/aruba/contents/{+path}","compare_url":"https://api.github.com/repos/e2/aruba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e2/aruba/merges","archive_url":"https://api.github.com/repos/e2/aruba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e2/aruba/downloads","issues_url":"https://api.github.com/repos/e2/aruba/issues{/number}","pulls_url":"https://api.github.com/repos/e2/aruba/pulls{/number}","milestones_url":"https://api.github.com/repos/e2/aruba/milestones{/number}","notifications_url":"https://api.github.com/repos/e2/aruba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e2/aruba/labels{/name}","releases_url":"https://api.github.com/repos/e2/aruba/releases{/id}","deployments_url":"https://api.github.com/repos/e2/aruba/deployments","created_at":"2015-06-09T15:22:21Z","updated_at":"2015-06-09T15:22:22Z","pushed_at":"2016-03-31T14:21:20Z","git_url":"git://github.com/e2/aruba.git","ssh_url":"git@github.com:e2/aruba.git","clone_url":"https://github.com/e2/aruba.git","svn_url":"https://github.com/e2/aruba","homepage":"","size":1727,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"fca339b6b243150078858cd4ab323a8a7d61779e","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":515585,"name":"aruba","full_name":"cucumber/aruba","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/aruba","description":"Test command-line applications with Cucumber-Ruby, RSpec or Minitest","fork":false,"url":"https://api.github.com/repos/cucumber/aruba","forks_url":"https://api.github.com/repos/cucumber/aruba/forks","keys_url":"https://api.github.com/repos/cucumber/aruba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/aruba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/aruba/teams","hooks_url":"https://api.github.com/repos/cucumber/aruba/hooks","issue_events_url":"https://api.github.com/repos/cucumber/aruba/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/aruba/events","assignees_url":"https://api.github.com/repos/cucumber/aruba/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/aruba/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/aruba/tags","blobs_url":"https://api.github.com/repos/cucumber/aruba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/aruba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/aruba/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/aruba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/aruba/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/aruba/languages","stargazers_url":"https://api.github.com/repos/cucumber/aruba/stargazers","contributors_url":"https://api.github.com/repos/cucumber/aruba/contributors","subscribers_url":"https://api.github.com/repos/cucumber/aruba/subscribers","subscription_url":"https://api.github.com/repos/cucumber/aruba/subscription","commits_url":"https://api.github.com/repos/cucumber/aruba/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/aruba/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/aruba/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/aruba/issues/comments{/number}","contents_url":"https://api.github.com/repos/cucumber/aruba/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/aruba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/aruba/merges","archive_url":"https://api.github.com/repos/cucumber/aruba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/aruba/downloads","issues_url":"https://api.github.com/repos/cucumber/aruba/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/aruba/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/aruba/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/aruba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/aruba/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/aruba/releases{/id}","deployments_url":"https://api.github.com/repos/cucumber/aruba/deployments","created_at":"2010-02-12T19:06:31Z","updated_at":"2016-03-31T05:19:01Z","pushed_at":"2016-03-31T08:23:01Z","git_url":"git://github.com/cucumber/aruba.git","ssh_url":"git@github.com:cucumber/aruba.git","clone_url":"https://github.com/cucumber/aruba.git","svn_url":"https://github.com/cucumber/aruba","homepage":"","size":2181,"stargazers_count":690,"watchers_count":690,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":26,"forks":120,"open_issues":26,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/357"},"html":{"href":"https://github.com/cucumber/aruba/pull/357"},"issue":{"href":"https://api.github.com/repos/cucumber/aruba/issues/357"},"comments":{"href":"https://api.github.com/repos/cucumber/aruba/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/aruba/statuses/e34e26eeda7f49b3d08f0e1f84354931844f2dd9"}}}}