{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/91963173","pull_request_review_id":12472203,"id":91963173,"diff_hunk":"@@ -215,10 +240,9 @@ void WaitCurrentThread_Sleep();\n  * @param wait_objects Kernel objects that we are waiting on\n  * @param wait_set_output If true, set the output parameter on thread wakeup (for\n  * WaitSynchronizationN only)\n- * @param wait_all If true, wait on all objects before resuming (for WaitSynchronizationN only)\n  */\n void WaitCurrentThread_WaitSynchronization(std::vector<SharedPtr<WaitObject>> wait_objects,\n-                                           bool wait_set_output, bool wait_all);\n+                                           bool wait_set_output);","path":"src/core/hle/kernel/thread.h","position":77,"original_position":77,"commit_id":"406907d57055965780e04769482556995de8c50a","original_commit_id":"406907d57055965780e04769482556995de8c50a","user":{"login":"wwylele","id":4592895,"avatar_url":"https://avatars.githubusercontent.com/u/4592895?v=3","gravatar_id":"","url":"https://api.github.com/users/wwylele","html_url":"https://github.com/wwylele","followers_url":"https://api.github.com/users/wwylele/followers","following_url":"https://api.github.com/users/wwylele/following{/other_user}","gists_url":"https://api.github.com/users/wwylele/gists{/gist_id}","starred_url":"https://api.github.com/users/wwylele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwylele/subscriptions","organizations_url":"https://api.github.com/users/wwylele/orgs","repos_url":"https://api.github.com/users/wwylele/repos","events_url":"https://api.github.com/users/wwylele/events{/privacy}","received_events_url":"https://api.github.com/users/wwylele/received_events","type":"User","site_admin":false},"body":"This function is actually not used any more. We can remove it","created_at":"2016-12-12T15:03:40Z","updated_at":"2016-12-12T15:29:21Z","html_url":"https://github.com/citra-emu/citra/pull/2260#discussion_r91963173","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/2260","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/91963173"},"html":{"href":"https://github.com/citra-emu/citra/pull/2260#discussion_r91963173"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2260"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/2260","id":96420269,"html_url":"https://github.com/citra-emu/citra/pull/2260","diff_url":"https://github.com/citra-emu/citra/pull/2260.diff","patch_url":"https://github.com/citra-emu/citra/pull/2260.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/2260","number":2260,"state":"open","locked":false,"title":"Threading: Reworked the way our scheduler works.","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"Threads will now be awakened when the objects they're waiting on are signaled, instead of repeating the WaitSynchronization call every now and then.\r\n\r\nThe scheduler is now called once after every SVC call, and once after a thread is awakened from sleep by its timeout callback.\r\n\r\nThis new implementation is based off reverse-engineering of the real kernel.\r\n\r\nSee [here](https://gist.github.com/Subv/02f29bd9f1e5deb7aceea1e8f019c8f4) for a more detailed description of how the real kernel handles rescheduling.\r\n\r\nFixes #2125 even with @neobrain's changes.\r\nFixes #2091\r\nFixes #2119 \r\nFixes #2028 \r\nFixes #2026\r\n\r\nThese changes provide a more stable framework for implementing #1904. I actually have an implementation in mind already, following what the real kernel does.\r\n\r\nThis PR will make it much easier to implement svcReplyAndReceive after #2249 is merged.","created_at":"2016-12-04T03:45:23Z","updated_at":"2016-12-12T15:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d802263d5a84c89324944399893df15050c3ec1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/2260/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/2260/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/2260/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/406907d57055965780e04769482556995de8c50a","head":{"label":"Subv:scheduling","ref":"scheduling","sha":"406907d57055965780e04769482556995de8c50a","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"repo":{"id":22818827,"name":"citra","full_name":"Subv/citra","owner":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subv/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/Subv/citra","forks_url":"https://api.github.com/repos/Subv/citra/forks","keys_url":"https://api.github.com/repos/Subv/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subv/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subv/citra/teams","hooks_url":"https://api.github.com/repos/Subv/citra/hooks","issue_events_url":"https://api.github.com/repos/Subv/citra/issues/events{/number}","events_url":"https://api.github.com/repos/Subv/citra/events","assignees_url":"https://api.github.com/repos/Subv/citra/assignees{/user}","branches_url":"https://api.github.com/repos/Subv/citra/branches{/branch}","tags_url":"https://api.github.com/repos/Subv/citra/tags","blobs_url":"https://api.github.com/repos/Subv/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subv/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subv/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subv/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subv/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/Subv/citra/languages","stargazers_url":"https://api.github.com/repos/Subv/citra/stargazers","contributors_url":"https://api.github.com/repos/Subv/citra/contributors","subscribers_url":"https://api.github.com/repos/Subv/citra/subscribers","subscription_url":"https://api.github.com/repos/Subv/citra/subscription","commits_url":"https://api.github.com/repos/Subv/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subv/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subv/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subv/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subv/citra/contents/{+path}","compare_url":"https://api.github.com/repos/Subv/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subv/citra/merges","archive_url":"https://api.github.com/repos/Subv/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subv/citra/downloads","issues_url":"https://api.github.com/repos/Subv/citra/issues{/number}","pulls_url":"https://api.github.com/repos/Subv/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/Subv/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/Subv/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subv/citra/labels{/name}","releases_url":"https://api.github.com/repos/Subv/citra/releases{/id}","deployments_url":"https://api.github.com/repos/Subv/citra/deployments","created_at":"2014-08-10T21:13:43Z","updated_at":"2016-11-22T00:35:06Z","pushed_at":"2016-12-10T18:29:46Z","git_url":"git://github.com/Subv/citra.git","ssh_url":"git@github.com:Subv/citra.git","clone_url":"https://github.com/Subv/citra.git","svn_url":"https://github.com/Subv/citra","homepage":null,"size":15505,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"a5cd925a9566553f80212420cb46650fe0992ec2","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-12-12T11:44:45Z","pushed_at":"2016-12-12T14:59:03Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":23109,"stargazers_count":2556,"watchers_count":2556,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":669,"mirror_url":null,"open_issues_count":212,"forks":669,"open_issues":212,"watchers":2556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2260"},"html":{"href":"https://github.com/citra-emu/citra/pull/2260"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2260"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2260/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2260/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2260/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/406907d57055965780e04769482556995de8c50a"}}}}
{"actor":{"display_login":"wwylele"}}