{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/84886500","pull_request_review_id":5633450,"id":84886500,"diff_hunk":"@@ -585,8 +582,8 @@ void FABADAMinimizer::finalize() {\n     double bin = (red_conv_chain[m_nParams][conv_length - 1] - start) /\n                  double(pdf_length);\n     size_t step = 0;\n-    MantidVec &X = ws->dataX(m_nParams);\n-    MantidVec &Y = ws->dataY(m_nParams);\n+    auto &X = ws->mutableX(m_nParams);\n+    auto &Y = ws->mutableY(m_nParams);\n     X[0] = start;\n     for (size_t i = 1; i < static_cast<size_t>(pdf_length) + 1; i++) {","path":"Framework/CurveFitting/src/FuncMinimizers/FABADAMinimizer.cpp","position":50,"original_position":50,"commit_id":"7966c40b30d43ff04577e4f8d0a031b4857cb121","original_commit_id":"7966c40b30d43ff04577e4f8d0a031b4857cb121","user":{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars.githubusercontent.com/u/15360272?v=3","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false},"body":"Could you use LinearGenerator for X here again?","created_at":"2016-10-25T12:04:13Z","updated_at":"2016-10-25T12:04:13Z","html_url":"https://github.com/mantidproject/mantid/pull/17779#discussion_r84886500","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17779","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/84886500"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17779#discussion_r84886500"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17779"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17779","id":88857065,"html_url":"https://github.com/mantidproject/mantid/pull/17779","diff_url":"https://github.com/mantidproject/mantid/pull/17779.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17779.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17779","number":17779,"state":"open","locked":false,"title":"Algorithms 82 to 86 updated with Histogram Data","user":{"login":"DimitarTasev","id":9135965,"avatar_url":"https://avatars.githubusercontent.com/u/9135965?v=3","gravatar_id":"","url":"https://api.github.com/users/DimitarTasev","html_url":"https://github.com/DimitarTasev","followers_url":"https://api.github.com/users/DimitarTasev/followers","following_url":"https://api.github.com/users/DimitarTasev/following{/other_user}","gists_url":"https://api.github.com/users/DimitarTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitarTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitarTasev/subscriptions","organizations_url":"https://api.github.com/users/DimitarTasev/orgs","repos_url":"https://api.github.com/users/DimitarTasev/repos","events_url":"https://api.github.com/users/DimitarTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DimitarTasev/received_events","type":"User","site_admin":false},"body":"HistogramData rollout: algorithms\r\n\r\nThis issue is part of the HistogramData rollout, see #17641.\r\nAlgorithms covered in this issue are:\r\n\r\n\r\n```\r\nFramework/CurveFitting/src/Algorithms/VesuvioCalculateMS.cpp\r\nFramework/CurveFitting/src/FitMW.cpp\r\nFramework/CurveFitting/src/FuncMinimizers/FABADAMinimizer.cpp\r\nFramework/CurveFitting/src/FunctionDomain1DSpectrumCreator.cpp\r\nFramework/CurveFitting/src/Functions/BivariateNormal.cpp\r\n```\r\n","created_at":"2016-10-11T15:39:38Z","updated_at":"2016-10-25T12:19:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1aeca0716542384685160c9f16b3cb0355ad982","assignee":{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars.githubusercontent.com/u/15360272?v=3","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false},"assignees":[{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars.githubusercontent.com/u/15360272?v=3","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/59","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.9","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/59/labels","id":1622022,"number":59,"title":"Release 3.9","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars.githubusercontent.com/u/1017173?v=3","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":126,"closed_issues":149,"state":"open","created_at":"2016-03-04T11:29:48Z","updated_at":"2016-10-25T11:59:56Z","due_on":"2017-02-13T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17779/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17779/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17779/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/7966c40b30d43ff04577e4f8d0a031b4857cb121","head":{"label":"mantidproject:17722_histogram_rollout_82_86","ref":"17722_histogram_rollout_82_86","sha":"7966c40b30d43ff04577e4f8d0a031b4857cb121","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-10-24T09:59:03Z","pushed_at":"2016-10-25T12:17:36Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":446658,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":1627,"forks":37,"open_issues":1627,"watchers":47,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"507589a0740ca6de3ab2cb5503659a2dd67b7d25","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-10-24T09:59:03Z","pushed_at":"2016-10-25T12:17:36Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":446658,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":1627,"forks":37,"open_issues":1627,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17779"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17779"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17779"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17779/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17779/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17779/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/7966c40b30d43ff04577e4f8d0a031b4857cb121"}}}}
{"actor":{"display_login":"LamarMoore"}}