{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/82698121","pull_request_review_id":3587682,"id":82698121,"diff_hunk":"@@ -684,7 +703,7 @@ private void ProduceStart(bool appCompleted)\n \n         protected Task TryProduceInvalidRequestResponse()\n         {\n-            if (_requestRejected)\n+            if (_requestRejected || _applicationException != null)","path":"src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/Frame.cs","position":76,"original_position":76,"commit_id":"f754a0747c126ad20a92376b970c1027437f6c6a","original_commit_id":"a7e70444ecbec8e7ddb098810f4792a762632d4b","user":{"login":"cesarbs","id":924164,"avatar_url":"https://avatars.githubusercontent.com/u/924164?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarbs","html_url":"https://github.com/cesarbs","followers_url":"https://api.github.com/users/cesarbs/followers","following_url":"https://api.github.com/users/cesarbs/following{/other_user}","gists_url":"https://api.github.com/users/cesarbs/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarbs/subscriptions","organizations_url":"https://api.github.com/users/cesarbs/orgs","repos_url":"https://api.github.com/users/cesarbs/repos","events_url":"https://api.github.com/users/cesarbs/events{/privacy}","received_events_url":"https://api.github.com/users/cesarbs/received_events","type":"User","site_admin":false},"body":"Indeed. My very first change (that I didn't even commit) was calling `Abort()` on a content length mismatch. This would prevent the call to `ProduceEnd()` in `FrameOfT`. But since I moved away from that decision, `ProduceEnd()` handles it as expected.","created_at":"2016-10-10T22:56:27Z","updated_at":"2016-10-10T22:56:27Z","html_url":"https://github.com/aspnet/KestrelHttpServer/pull/1155#discussion_r82698121","pull_request_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155","_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/82698121"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/1155#discussion_r82698121"},"pull_request":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155","id":88476593,"html_url":"https://github.com/aspnet/KestrelHttpServer/pull/1155","diff_url":"https://github.com/aspnet/KestrelHttpServer/pull/1155.diff","patch_url":"https://github.com/aspnet/KestrelHttpServer/pull/1155.patch","issue_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1155","number":1155,"state":"open","locked":false,"title":"Handle response content length mismatches (#175)","user":{"login":"cesarbs","id":924164,"avatar_url":"https://avatars.githubusercontent.com/u/924164?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarbs","html_url":"https://github.com/cesarbs","followers_url":"https://api.github.com/users/cesarbs/followers","following_url":"https://api.github.com/users/cesarbs/following{/other_user}","gists_url":"https://api.github.com/users/cesarbs/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarbs/subscriptions","organizations_url":"https://api.github.com/users/cesarbs/orgs","repos_url":"https://api.github.com/users/cesarbs/repos","events_url":"https://api.github.com/users/cesarbs/events{/privacy}","received_events_url":"https://api.github.com/users/cesarbs/received_events","type":"User","site_admin":false},"body":"#175 \r\n\r\n- [x] TODO: `InvalidOperationException` might not be the right exception type for this\r\n- [x] TODO: is logging this as application errors OK or should we add new event IDs for response length mismatches?\r\n\r\n@halter73 @Tratcher @mikeharder @davidfowl ","created_at":"2016-10-07T17:24:26Z","updated_at":"2016-10-10T22:56:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2796e6640553aeb2f28b912433550dc1c8b13f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155/commits","review_comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155/comments","review_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1155/comments","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/f754a0747c126ad20a92376b970c1027437f6c6a","head":{"label":"aspnet:cesarbs/track-response-content-length","ref":"cesarbs/track-response-content-length","sha":"f754a0747c126ad20a92376b970c1027437f6c6a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20344662,"name":"KestrelHttpServer","full_name":"aspnet/KestrelHttpServer","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/KestrelHttpServer","description":"A web server for ASP.NET Core based on libuv.","fork":false,"url":"https://api.github.com/repos/aspnet/KestrelHttpServer","forks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/deployments","created_at":"2014-05-30T22:46:28Z","updated_at":"2016-10-10T20:25:31Z","pushed_at":"2016-10-10T22:28:34Z","git_url":"git://github.com/aspnet/KestrelHttpServer.git","ssh_url":"git@github.com:aspnet/KestrelHttpServer.git","clone_url":"https://github.com/aspnet/KestrelHttpServer.git","svn_url":"https://github.com/aspnet/KestrelHttpServer","homepage":"","size":7325,"stargazers_count":1122,"watchers_count":1122,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":70,"forks":235,"open_issues":70,"watchers":1122,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"6c2532682acbcbeda7e70f711b954e39e40a1ce1","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20344662,"name":"KestrelHttpServer","full_name":"aspnet/KestrelHttpServer","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/KestrelHttpServer","description":"A web server for ASP.NET Core based on libuv.","fork":false,"url":"https://api.github.com/repos/aspnet/KestrelHttpServer","forks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/deployments","created_at":"2014-05-30T22:46:28Z","updated_at":"2016-10-10T20:25:31Z","pushed_at":"2016-10-10T22:28:34Z","git_url":"git://github.com/aspnet/KestrelHttpServer.git","ssh_url":"git@github.com:aspnet/KestrelHttpServer.git","clone_url":"https://github.com/aspnet/KestrelHttpServer.git","svn_url":"https://github.com/aspnet/KestrelHttpServer","homepage":"","size":7325,"stargazers_count":1122,"watchers_count":1122,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":70,"forks":235,"open_issues":70,"watchers":1122,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/1155"},"issue":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1155"},"comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1155/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1155/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/f754a0747c126ad20a92376b970c1027437f6c6a"}}}}
{"actor":{"display_login":"cesarbs"}}