{"action":"created","issue":{"url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/96","repository_url":"https://api.github.com/repos/d8-contrib-modules/encrypt","labels_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/96/comments","events_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/96/events","html_url":"https://github.com/d8-contrib-modules/encrypt/pull/96","id":134648840,"number":96,"title":"Simplify EncryptService","user":{"login":"svendecabooter","id":201144,"avatar_url":"https://avatars.githubusercontent.com/u/201144?v=3","gravatar_id":"","url":"https://api.github.com/users/svendecabooter","html_url":"https://github.com/svendecabooter","followers_url":"https://api.github.com/users/svendecabooter/followers","following_url":"https://api.github.com/users/svendecabooter/following{/other_user}","gists_url":"https://api.github.com/users/svendecabooter/gists{/gist_id}","starred_url":"https://api.github.com/users/svendecabooter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svendecabooter/subscriptions","organizations_url":"https://api.github.com/users/svendecabooter/orgs","repos_url":"https://api.github.com/users/svendecabooter/repos","events_url":"https://api.github.com/users/svendecabooter/events{/privacy}","received_events_url":"https://api.github.com/users/svendecabooter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-18T17:55:35Z","updated_at":"2016-02-19T15:50:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/96","html_url":"https://github.com/d8-contrib-modules/encrypt/pull/96","diff_url":"https://github.com/d8-contrib-modules/encrypt/pull/96.diff","patch_url":"https://github.com/d8-contrib-modules/encrypt/pull/96.patch"},"body":"The current implementation of EncryptService only calls checkDependencies() on the selected encryption method, before trying to encrypt.\r\n\r\nThis PR simplifies the code & test logic of the EncryptService, and makes sure the validate() function on the EncryptionProfile entity gets called. This will still call checkDependencies(), but also provide extra validation (e.g.: check if encryption key is still available)."},"comment":{"url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/comments/186271131","html_url":"https://github.com/d8-contrib-modules/encrypt/pull/96#issuecomment-186271131","issue_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/96","id":186271131,"user":{"login":"svendecabooter","id":201144,"avatar_url":"https://avatars.githubusercontent.com/u/201144?v=3","gravatar_id":"","url":"https://api.github.com/users/svendecabooter","html_url":"https://github.com/svendecabooter","followers_url":"https://api.github.com/users/svendecabooter/followers","following_url":"https://api.github.com/users/svendecabooter/following{/other_user}","gists_url":"https://api.github.com/users/svendecabooter/gists{/gist_id}","starred_url":"https://api.github.com/users/svendecabooter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svendecabooter/subscriptions","organizations_url":"https://api.github.com/users/svendecabooter/orgs","repos_url":"https://api.github.com/users/svendecabooter/repos","events_url":"https://api.github.com/users/svendecabooter/events{/privacy}","received_events_url":"https://api.github.com/users/svendecabooter/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T15:50:39Z","updated_at":"2016-02-19T15:50:39Z","body":"\"valid\" method has been renamed to \"validate\" now.\r\n\r\nThe $errors variable contains an array up until the point it gets passed to the exception being thrown. At that point it gets imploded into a string, because that's the exception expects (for display in watchdog messages or on the screen). Not sure if we can improve this easily..."}}