{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/61278658","id":61278658,"diff_hunk":"@@ -1490,7 +1490,7 @@ ol.Map.createOptionsInternal = function(options) {\n     var logo = options.logo;\n     if (typeof logo === 'string') {\n       logos[logo] = '';\n-    } else if (goog.isObject(logo)) {\n+    } else if (goog.isObject(logo) && !(logo instanceof HTMLElement)) {","path":"src/ol/map.js","position":5,"original_position":5,"commit_id":"c2af8187b94ca6353c6e51bb59fd90ac5f71647b","original_commit_id":"c2af8187b94ca6353c6e51bb59fd90ac5f71647b","user":{"login":"tsauerwein","id":266474,"avatar_url":"https://avatars.githubusercontent.com/u/266474?v=3","gravatar_id":"","url":"https://api.github.com/users/tsauerwein","html_url":"https://github.com/tsauerwein","followers_url":"https://api.github.com/users/tsauerwein/followers","following_url":"https://api.github.com/users/tsauerwein/following{/other_user}","gists_url":"https://api.github.com/users/tsauerwein/gists{/gist_id}","starred_url":"https://api.github.com/users/tsauerwein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsauerwein/subscriptions","organizations_url":"https://api.github.com/users/tsauerwein/orgs","repos_url":"https://api.github.com/users/tsauerwein/repos","events_url":"https://api.github.com/users/tsauerwein/events{/privacy}","received_events_url":"https://api.github.com/users/tsauerwein/received_events","type":"User","site_admin":false},"body":"I think you committed this one accidentally.","created_at":"2016-04-27T15:23:17Z","updated_at":"2016-04-27T15:23:17Z","html_url":"https://github.com/openlayers/ol3/pull/5177#discussion_r61278658","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/5177","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/61278658"},"html":{"href":"https://github.com/openlayers/ol3/pull/5177#discussion_r61278658"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/5177"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/5177","id":65377217,"html_url":"https://github.com/openlayers/ol3/pull/5177","diff_url":"https://github.com/openlayers/ol3/pull/5177.diff","patch_url":"https://github.com/openlayers/ol3/pull/5177.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/5177","number":5177,"state":"open","locked":false,"title":"Add render options for vector tile layers","user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"body":"The goal of this pull request is to simplify code and improve performance and rendering quality:\r\n\r\n* Change `ol.renderer.canvas.VectorTileLayer` so it inherits from `ol.renderer.canvas.TileLayer`. With this change, the new improved tile rendering with clipped lower resolution regions is used, and no gaps between vector tiles are visible any more - not even on rotated views.\r\n* Instead of deciding whether to render vector tile replays to a tile image or directly to the output canvas based on the tile pixel size, we can now do both tile image and output canvas rendering at the same time, even with different subsets of the replay group. By default, polygon and line elements are rendered to a tile image, and images and texts to the output canvas.\r\n* The new `renderMode` option on `ol.layer.VectorTile` allows users to control the rendering behaviour. The default is `'hybrid'`, which means polygons and lines are no longer replayed with every render frame, but rendered to a tile image. Images and texts are replayed, so they stay upright during rotation and maintain their scale during zoom animations.\r\n\r\nFixes #4897.","created_at":"2016-04-05T21:56:15Z","updated_at":"2016-04-27T15:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceb55f195127479abd4130429709f6a7914db671","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/5177/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/5177/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/5177/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/c2af8187b94ca6353c6e51bb59fd90ac5f71647b","head":{"label":"ahocevar:vector-tile-hybrid-rendering","ref":"vector-tile-hybrid-rendering","sha":"c2af8187b94ca6353c6e51bb59fd90ac5f71647b","user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"repo":{"id":4974939,"name":"ol3","full_name":"ahocevar/ol3","owner":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahocevar/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/ahocevar/ol3","forks_url":"https://api.github.com/repos/ahocevar/ol3/forks","keys_url":"https://api.github.com/repos/ahocevar/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahocevar/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahocevar/ol3/teams","hooks_url":"https://api.github.com/repos/ahocevar/ol3/hooks","issue_events_url":"https://api.github.com/repos/ahocevar/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/ahocevar/ol3/events","assignees_url":"https://api.github.com/repos/ahocevar/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/ahocevar/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/ahocevar/ol3/tags","blobs_url":"https://api.github.com/repos/ahocevar/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahocevar/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahocevar/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahocevar/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahocevar/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/ahocevar/ol3/languages","stargazers_url":"https://api.github.com/repos/ahocevar/ol3/stargazers","contributors_url":"https://api.github.com/repos/ahocevar/ol3/contributors","subscribers_url":"https://api.github.com/repos/ahocevar/ol3/subscribers","subscription_url":"https://api.github.com/repos/ahocevar/ol3/subscription","commits_url":"https://api.github.com/repos/ahocevar/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahocevar/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahocevar/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahocevar/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahocevar/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/ahocevar/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahocevar/ol3/merges","archive_url":"https://api.github.com/repos/ahocevar/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahocevar/ol3/downloads","issues_url":"https://api.github.com/repos/ahocevar/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/ahocevar/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/ahocevar/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/ahocevar/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahocevar/ol3/labels{/name}","releases_url":"https://api.github.com/repos/ahocevar/ol3/releases{/id}","deployments_url":"https://api.github.com/repos/ahocevar/ol3/deployments","created_at":"2012-07-10T14:11:39Z","updated_at":"2015-04-21T14:20:28Z","pushed_at":"2016-04-27T15:22:14Z","git_url":"git://github.com/ahocevar/ol3.git","ssh_url":"git@github.com:ahocevar/ol3.git","clone_url":"https://github.com/ahocevar/ol3.git","svn_url":"https://github.com/ahocevar/ol3","homepage":null,"size":61304,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"0e4692e69e571c66cf3b64d57caa008b4dea54ae","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","deployments_url":"https://api.github.com/repos/openlayers/ol3/deployments","created_at":"2012-06-20T06:53:59Z","updated_at":"2016-04-27T08:28:42Z","pushed_at":"2016-04-27T15:22:15Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"http://openlayers.org","size":99822,"stargazers_count":1762,"watchers_count":1762,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":957,"mirror_url":null,"open_issues_count":419,"forks":957,"open_issues":419,"watchers":1762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/5177"},"html":{"href":"https://github.com/openlayers/ol3/pull/5177"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/5177"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/5177/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/5177/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/5177/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/c2af8187b94ca6353c6e51bb59fd90ac5f71647b"}}}}