{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/93443279","pull_request_review_id":13970625,"id":93443279,"diff_hunk":"@@ -192,7 +192,7 @@ import CocoaLumberjackSwift\n     \n     func deleteUserClient(_ userClient: UserClient, credentials: ZMEmailCredentials) {\n         self.showLoadingView = true\n-        ZMUserSession.shared().delete([userClient], with: credentials);\n+        ZMUserSession.shared()!.delete([userClient], with: credentials);","path":"Wire-iOS/Sources/UserInterface/Settings/DeviceManagement/ClientListViewController.swift","position":38,"original_position":38,"commit_id":"7c9f06ebb625f663fe5a8ea0884ed8ccb4765fcf","original_commit_id":"7c9f06ebb625f663fe5a8ea0884ed8ccb4765fcf","user":{"login":"typfel","id":7156,"avatar_url":"https://avatars.githubusercontent.com/u/7156?v=3","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"body":"can be `?`","created_at":"2016-12-21T14:09:00Z","updated_at":"2016-12-21T14:09:00Z","html_url":"https://github.com/wireapp/wire-ios/pull/505#discussion_r93443279","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/93443279"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/505#discussion_r93443279"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/505","id":98914566,"html_url":"https://github.com/wireapp/wire-ios/pull/505","diff_url":"https://github.com/wireapp/wire-ios/pull/505.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/505.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/505","number":505,"state":"open","locked":false,"title":"Fix shared user session assumed to be not nil when uploading AB","user":{"login":"marcoconti83","id":620000,"avatar_url":"https://avatars.githubusercontent.com/u/620000?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoconti83","html_url":"https://github.com/marcoconti83","followers_url":"https://api.github.com/users/marcoconti83/followers","following_url":"https://api.github.com/users/marcoconti83/following{/other_user}","gists_url":"https://api.github.com/users/marcoconti83/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoconti83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoconti83/subscriptions","organizations_url":"https://api.github.com/users/marcoconti83/orgs","repos_url":"https://api.github.com/users/marcoconti83/repos","events_url":"https://api.github.com/users/marcoconti83/events{/privacy}","received_events_url":"https://api.github.com/users/marcoconti83/received_events","type":"User","site_admin":false},"body":"In some cases, the user session could still be nil (e.g. if performing a migration). However it was forced unwrapped in a few cases, e.g. when checking whether to upload the AB.\r\n\r\nNow I'm using the user session as optional, and I don't start the AB upload if the session is not there yet","created_at":"2016-12-21T11:15:49Z","updated_at":"2016-12-21T14:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c9d8a27e091b9ea97d7494ba5bb9f0fa4b784dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/505/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/505/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/505/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/7c9f06ebb625f663fe5a8ea0884ed8ccb4765fcf","head":{"label":"wireapp:fix/do-no-upload-AB-on-start","ref":"fix/do-no-upload-AB-on-start","sha":"7c9f06ebb625f663fe5a8ea0884ed8ccb4765fcf","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire iOS client (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2016-12-21T08:16:07Z","pushed_at":"2016-12-21T13:47:56Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":79919,"stargazers_count":1695,"watchers_count":1695,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":68,"forks":247,"open_issues":68,"watchers":1695,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"26da927354ed80e48c5bf5d0c629011cafa1c343","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire iOS client (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2016-12-21T08:16:07Z","pushed_at":"2016-12-21T13:47:56Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":79919,"stargazers_count":1695,"watchers_count":1695,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":68,"forks":247,"open_issues":68,"watchers":1695,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/505"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/505"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/505"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios/statuses/7c9f06ebb625f663fe5a8ea0884ed8ccb4765fcf"}}}}
{"actor":{"display_login":"typfel"}}