{"action":"created","comment":{"url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/comments/71570783","id":71570783,"diff_hunk":"@@ -71,6 +69,7 @@\n   private ConcurrentHashMap<EventType, List<Transport>> transports = null;\n   private ClientStatEmitter autoStatEmitter = null;\n   private Thread emitterThread = null;\n+  private Integer maxNumMetrics = null;","path":"src/main/java/org/mondemand/Client.java","position":18,"original_position":18,"commit_id":"d3d10f2e5826fc28a40115bf38aa04a13faf4fef","original_commit_id":"d3d10f2e5826fc28a40115bf38aa04a13faf4fef","user":{"login":"mohammadkolahdouzan","id":2965021,"avatar_url":"https://avatars.githubusercontent.com/u/2965021?v=3","gravatar_id":"","url":"https://api.github.com/users/mohammadkolahdouzan","html_url":"https://github.com/mohammadkolahdouzan","followers_url":"https://api.github.com/users/mohammadkolahdouzan/followers","following_url":"https://api.github.com/users/mohammadkolahdouzan/following{/other_user}","gists_url":"https://api.github.com/users/mohammadkolahdouzan/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammadkolahdouzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammadkolahdouzan/subscriptions","organizations_url":"https://api.github.com/users/mohammadkolahdouzan/orgs","repos_url":"https://api.github.com/users/mohammadkolahdouzan/repos","events_url":"https://api.github.com/users/mohammadkolahdouzan/events{/privacy}","received_events_url":"https://api.github.com/users/mohammadkolahdouzan/received_events","type":"User","site_admin":false},"body":"would it not be better if we defined the default value for this here, and then overwrite it in the set..() method if we need to?","created_at":"2016-07-20T17:35:46Z","updated_at":"2016-07-20T17:35:46Z","html_url":"https://github.com/mondemand/mondemand-java/pull/19#discussion_r71570783","pull_request_url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/comments/71570783"},"html":{"href":"https://github.com/mondemand/mondemand-java/pull/19#discussion_r71570783"},"pull_request":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19","id":78187404,"html_url":"https://github.com/mondemand/mondemand-java/pull/19","diff_url":"https://github.com/mondemand/mondemand-java/pull/19.diff","patch_url":"https://github.com/mondemand/mondemand-java/pull/19.patch","issue_url":"https://api.github.com/repos/mondemand/mondemand-java/issues/19","number":19,"state":"open","locked":false,"title":"Max metrics support","user":{"login":"nimaco","id":3443579,"avatar_url":"https://avatars.githubusercontent.com/u/3443579?v=3","gravatar_id":"","url":"https://api.github.com/users/nimaco","html_url":"https://github.com/nimaco","followers_url":"https://api.github.com/users/nimaco/followers","following_url":"https://api.github.com/users/nimaco/following{/other_user}","gists_url":"https://api.github.com/users/nimaco/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaco/subscriptions","organizations_url":"https://api.github.com/users/nimaco/orgs","repos_url":"https://api.github.com/users/nimaco/repos","events_url":"https://api.github.com/users/nimaco/events{/privacy}","received_events_url":"https://api.github.com/users/nimaco/received_events","type":"User","site_admin":false},"body":"add support to use multiple lwes events to send mondemand metrics, rather than be limited to a single event","created_at":"2016-07-20T17:31:16Z","updated_at":"2016-07-20T17:35:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6240d5df56eb547382a549bde86ad4d4c5d576bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mondemand/mondemand-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mondemand/mondemand-java/issues/19/comments","statuses_url":"https://api.github.com/repos/mondemand/mondemand-java/statuses/d3d10f2e5826fc28a40115bf38aa04a13faf4fef","head":{"label":"nimaco:master","ref":"master","sha":"d3d10f2e5826fc28a40115bf38aa04a13faf4fef","user":{"login":"nimaco","id":3443579,"avatar_url":"https://avatars.githubusercontent.com/u/3443579?v=3","gravatar_id":"","url":"https://api.github.com/users/nimaco","html_url":"https://github.com/nimaco","followers_url":"https://api.github.com/users/nimaco/followers","following_url":"https://api.github.com/users/nimaco/following{/other_user}","gists_url":"https://api.github.com/users/nimaco/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaco/subscriptions","organizations_url":"https://api.github.com/users/nimaco/orgs","repos_url":"https://api.github.com/users/nimaco/repos","events_url":"https://api.github.com/users/nimaco/events{/privacy}","received_events_url":"https://api.github.com/users/nimaco/received_events","type":"User","site_admin":false},"repo":{"id":63371005,"name":"mondemand-java","full_name":"nimaco/mondemand-java","owner":{"login":"nimaco","id":3443579,"avatar_url":"https://avatars.githubusercontent.com/u/3443579?v=3","gravatar_id":"","url":"https://api.github.com/users/nimaco","html_url":"https://github.com/nimaco","followers_url":"https://api.github.com/users/nimaco/followers","following_url":"https://api.github.com/users/nimaco/following{/other_user}","gists_url":"https://api.github.com/users/nimaco/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaco/subscriptions","organizations_url":"https://api.github.com/users/nimaco/orgs","repos_url":"https://api.github.com/users/nimaco/repos","events_url":"https://api.github.com/users/nimaco/events{/privacy}","received_events_url":"https://api.github.com/users/nimaco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nimaco/mondemand-java","description":"Mondemand Java Library","fork":true,"url":"https://api.github.com/repos/nimaco/mondemand-java","forks_url":"https://api.github.com/repos/nimaco/mondemand-java/forks","keys_url":"https://api.github.com/repos/nimaco/mondemand-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimaco/mondemand-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimaco/mondemand-java/teams","hooks_url":"https://api.github.com/repos/nimaco/mondemand-java/hooks","issue_events_url":"https://api.github.com/repos/nimaco/mondemand-java/issues/events{/number}","events_url":"https://api.github.com/repos/nimaco/mondemand-java/events","assignees_url":"https://api.github.com/repos/nimaco/mondemand-java/assignees{/user}","branches_url":"https://api.github.com/repos/nimaco/mondemand-java/branches{/branch}","tags_url":"https://api.github.com/repos/nimaco/mondemand-java/tags","blobs_url":"https://api.github.com/repos/nimaco/mondemand-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimaco/mondemand-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimaco/mondemand-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimaco/mondemand-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimaco/mondemand-java/statuses/{sha}","languages_url":"https://api.github.com/repos/nimaco/mondemand-java/languages","stargazers_url":"https://api.github.com/repos/nimaco/mondemand-java/stargazers","contributors_url":"https://api.github.com/repos/nimaco/mondemand-java/contributors","subscribers_url":"https://api.github.com/repos/nimaco/mondemand-java/subscribers","subscription_url":"https://api.github.com/repos/nimaco/mondemand-java/subscription","commits_url":"https://api.github.com/repos/nimaco/mondemand-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimaco/mondemand-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimaco/mondemand-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimaco/mondemand-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimaco/mondemand-java/contents/{+path}","compare_url":"https://api.github.com/repos/nimaco/mondemand-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimaco/mondemand-java/merges","archive_url":"https://api.github.com/repos/nimaco/mondemand-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimaco/mondemand-java/downloads","issues_url":"https://api.github.com/repos/nimaco/mondemand-java/issues{/number}","pulls_url":"https://api.github.com/repos/nimaco/mondemand-java/pulls{/number}","milestones_url":"https://api.github.com/repos/nimaco/mondemand-java/milestones{/number}","notifications_url":"https://api.github.com/repos/nimaco/mondemand-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimaco/mondemand-java/labels{/name}","releases_url":"https://api.github.com/repos/nimaco/mondemand-java/releases{/id}","deployments_url":"https://api.github.com/repos/nimaco/mondemand-java/deployments","created_at":"2016-07-14T21:28:52Z","updated_at":"2016-07-14T21:28:53Z","pushed_at":"2016-07-20T17:28:08Z","git_url":"git://github.com/nimaco/mondemand-java.git","ssh_url":"git@github.com:nimaco/mondemand-java.git","clone_url":"https://github.com/nimaco/mondemand-java.git","svn_url":"https://github.com/nimaco/mondemand-java","homepage":null,"size":246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mondemand:master","ref":"master","sha":"f97ba5cadfff727878e9f89323f71d96e05a3374","user":{"login":"mondemand","id":638457,"avatar_url":"https://avatars.githubusercontent.com/u/638457?v=3","gravatar_id":"","url":"https://api.github.com/users/mondemand","html_url":"https://github.com/mondemand","followers_url":"https://api.github.com/users/mondemand/followers","following_url":"https://api.github.com/users/mondemand/following{/other_user}","gists_url":"https://api.github.com/users/mondemand/gists{/gist_id}","starred_url":"https://api.github.com/users/mondemand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mondemand/subscriptions","organizations_url":"https://api.github.com/users/mondemand/orgs","repos_url":"https://api.github.com/users/mondemand/repos","events_url":"https://api.github.com/users/mondemand/events{/privacy}","received_events_url":"https://api.github.com/users/mondemand/received_events","type":"Organization","site_admin":false},"repo":{"id":5683377,"name":"mondemand-java","full_name":"mondemand/mondemand-java","owner":{"login":"mondemand","id":638457,"avatar_url":"https://avatars.githubusercontent.com/u/638457?v=3","gravatar_id":"","url":"https://api.github.com/users/mondemand","html_url":"https://github.com/mondemand","followers_url":"https://api.github.com/users/mondemand/followers","following_url":"https://api.github.com/users/mondemand/following{/other_user}","gists_url":"https://api.github.com/users/mondemand/gists{/gist_id}","starred_url":"https://api.github.com/users/mondemand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mondemand/subscriptions","organizations_url":"https://api.github.com/users/mondemand/orgs","repos_url":"https://api.github.com/users/mondemand/repos","events_url":"https://api.github.com/users/mondemand/events{/privacy}","received_events_url":"https://api.github.com/users/mondemand/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mondemand/mondemand-java","description":"Mondemand Java Library","fork":false,"url":"https://api.github.com/repos/mondemand/mondemand-java","forks_url":"https://api.github.com/repos/mondemand/mondemand-java/forks","keys_url":"https://api.github.com/repos/mondemand/mondemand-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mondemand/mondemand-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mondemand/mondemand-java/teams","hooks_url":"https://api.github.com/repos/mondemand/mondemand-java/hooks","issue_events_url":"https://api.github.com/repos/mondemand/mondemand-java/issues/events{/number}","events_url":"https://api.github.com/repos/mondemand/mondemand-java/events","assignees_url":"https://api.github.com/repos/mondemand/mondemand-java/assignees{/user}","branches_url":"https://api.github.com/repos/mondemand/mondemand-java/branches{/branch}","tags_url":"https://api.github.com/repos/mondemand/mondemand-java/tags","blobs_url":"https://api.github.com/repos/mondemand/mondemand-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mondemand/mondemand-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mondemand/mondemand-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mondemand/mondemand-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mondemand/mondemand-java/statuses/{sha}","languages_url":"https://api.github.com/repos/mondemand/mondemand-java/languages","stargazers_url":"https://api.github.com/repos/mondemand/mondemand-java/stargazers","contributors_url":"https://api.github.com/repos/mondemand/mondemand-java/contributors","subscribers_url":"https://api.github.com/repos/mondemand/mondemand-java/subscribers","subscription_url":"https://api.github.com/repos/mondemand/mondemand-java/subscription","commits_url":"https://api.github.com/repos/mondemand/mondemand-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mondemand/mondemand-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mondemand/mondemand-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mondemand/mondemand-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mondemand/mondemand-java/contents/{+path}","compare_url":"https://api.github.com/repos/mondemand/mondemand-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mondemand/mondemand-java/merges","archive_url":"https://api.github.com/repos/mondemand/mondemand-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mondemand/mondemand-java/downloads","issues_url":"https://api.github.com/repos/mondemand/mondemand-java/issues{/number}","pulls_url":"https://api.github.com/repos/mondemand/mondemand-java/pulls{/number}","milestones_url":"https://api.github.com/repos/mondemand/mondemand-java/milestones{/number}","notifications_url":"https://api.github.com/repos/mondemand/mondemand-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mondemand/mondemand-java/labels{/name}","releases_url":"https://api.github.com/repos/mondemand/mondemand-java/releases{/id}","deployments_url":"https://api.github.com/repos/mondemand/mondemand-java/deployments","created_at":"2012-09-05T06:26:25Z","updated_at":"2015-07-11T18:33:58Z","pushed_at":"2016-07-20T17:31:16Z","git_url":"git://github.com/mondemand/mondemand-java.git","ssh_url":"git@github.com:mondemand/mondemand-java.git","clone_url":"https://github.com/mondemand/mondemand-java.git","svn_url":"https://github.com/mondemand/mondemand-java","homepage":null,"size":246,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19"},"html":{"href":"https://github.com/mondemand/mondemand-java/pull/19"},"issue":{"href":"https://api.github.com/repos/mondemand/mondemand-java/issues/19"},"comments":{"href":"https://api.github.com/repos/mondemand/mondemand-java/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mondemand/mondemand-java/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mondemand/mondemand-java/statuses/d3d10f2e5826fc28a40115bf38aa04a13faf4fef"}}}}
{"actor":{"display_login":"mohammadkolahdouzan"}}