{"action":"created","issue":{"url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/168","repository_url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2","labels_url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/168/comments","events_url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/168/events","html_url":"https://github.com/jhu-digital-manuscripts/rosa2/issues/168","id":181216726,"number":168,"title":"Include Lucene indexes in WAR during maven build","user":{"login":"jabrah","id":5167587,"avatar_url":"https://avatars.githubusercontent.com/u/5167587?v=3","gravatar_id":"","url":"https://api.github.com/users/jabrah","html_url":"https://github.com/jabrah","followers_url":"https://api.github.com/users/jabrah/followers","following_url":"https://api.github.com/users/jabrah/following{/other_user}","gists_url":"https://api.github.com/users/jabrah/gists{/gist_id}","starred_url":"https://api.github.com/users/jabrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabrah/subscriptions","organizations_url":"https://api.github.com/users/jabrah/orgs","repos_url":"https://api.github.com/users/jabrah/repos","events_url":"https://api.github.com/users/jabrah/events{/privacy}","received_events_url":"https://api.github.com/users/jabrah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-05T17:27:32Z","updated_at":"2016-10-11T20:15:15Z","closed_at":null,"body":""},"comment":{"url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/comments/253032243","html_url":"https://github.com/jhu-digital-manuscripts/rosa2/issues/168#issuecomment-253032243","issue_url":"https://api.github.com/repos/jhu-digital-manuscripts/rosa2/issues/168","id":253032243,"user":{"login":"jabrah","id":5167587,"avatar_url":"https://avatars.githubusercontent.com/u/5167587?v=3","gravatar_id":"","url":"https://api.github.com/users/jabrah","html_url":"https://github.com/jabrah","followers_url":"https://api.github.com/users/jabrah/followers","following_url":"https://api.github.com/users/jabrah/following{/other_user}","gists_url":"https://api.github.com/users/jabrah/gists{/gist_id}","starred_url":"https://api.github.com/users/jabrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabrah/subscriptions","organizations_url":"https://api.github.com/users/jabrah/orgs","repos_url":"https://api.github.com/users/jabrah/repos","events_url":"https://api.github.com/users/jabrah/events{/privacy}","received_events_url":"https://api.github.com/users/jabrah/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T20:15:15Z","updated_at":"2016-10-11T20:15:15Z","body":"Seems I will have to split this code into two separate tools for website and IIIF uses. When initializing a SearchService to start the indexing process, you need to give it a LuceneMapper implementation. Website and IIIF each have different mappers that cannot be accessed from the `rosa-search` module.\r\n\r\nBoth `rosa-iiif` and `rosa-website` modules are dependent on `rosa-search` module, so we cannot have the search module depend on the other modules in order to grab the necessary LuceneMapper implementations, as this would introduce a circular dependency.\r\n\r\n```\r\nrosa-search\r\n    |- BaseSearchDerivative : abstract class\r\n        - abstract LuceneMapper mapper() : must be extended to point to a LuceneMapper impl\r\n        - void update() : method that will use abstract mapper method to write an index to a target directory\r\n\r\nrosa-iiif\r\n    |- rosa-iiif-presentation-endpoint\r\n        |- IIIFSearchDerivative extends BaseSearchDerivative\r\n            - LuceneMapper mapper() : returns instance of JHSearchLuceneMapper\r\n\r\nrosa-website\r\n    |- rosa-website-search\r\n        |- WebsiteSearchDerivative extends BaseSearchDerivative\r\n            - LuceneMapper mapper() : returns instance of WebsiteLuceneMapper\r\n```"}}
{"actor":{"display_login":"jabrah"}}