{"action":"opened","issue":{"url":"https://api.github.com/repos/osuosl/iam/issues/99","repository_url":"https://api.github.com/repos/osuosl/iam","labels_url":"https://api.github.com/repos/osuosl/iam/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/osuosl/iam/issues/99/comments","events_url":"https://api.github.com/repos/osuosl/iam/issues/99/events","html_url":"https://github.com/osuosl/iam/issues/99","id":160298486,"number":99,"title":"Review spec tests for correctness","user":{"login":"ElijahCaine","id":1897147,"avatar_url":"https://avatars.githubusercontent.com/u/1897147?v=3","gravatar_id":"","url":"https://api.github.com/users/ElijahCaine","html_url":"https://github.com/ElijahCaine","followers_url":"https://api.github.com/users/ElijahCaine/followers","following_url":"https://api.github.com/users/ElijahCaine/following{/other_user}","gists_url":"https://api.github.com/users/ElijahCaine/gists{/gist_id}","starred_url":"https://api.github.com/users/ElijahCaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElijahCaine/subscriptions","organizations_url":"https://api.github.com/users/ElijahCaine/orgs","repos_url":"https://api.github.com/users/ElijahCaine/repos","events_url":"https://api.github.com/users/ElijahCaine/events{/privacy}","received_events_url":"https://api.github.com/users/ElijahCaine/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/osuosl/iam/labels/Bug","name":"Bug","color":"b60205"},{"url":"https://api.github.com/repos/osuosl/iam/labels/Easy","name":"Easy","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-14T22:24:12Z","updated_at":"2016-06-14T22:24:12Z","closed_at":null,"body":"There are a few tests, specifically those related to the plugins, which do not actually test what we expect them to. This should be addressed earlier rather than later.\r\n\r\n## Procedure for checking test correctness:\r\n\r\n1. Run tests.\r\n2. Modify individual test.\r\n3. Run tests again, verify that the test **does not pass**.\r\n  -  If the test still passes, re-write it to **actually test the parameter covered in the test**.\r\n  -  If the test fails, revert that portion of the test back and keep checking.\r\n\r\nTests which are at high-risk for being faulty:\r\n```\r\n.\r\n├── lib\r\n│   └── BasePlugin\r\n│       └── spec.rb\r\n├── plugins\r\n│   ├── DiskSize\r\n│   │   └── spec.rb\r\n│   ├── DiskTemplate\r\n│   │   └── spec.rb\r\n│   ├── RamSize\r\n│   │   └── spec.rb\r\n│   └── VCPUCount\r\n│       ├── migrations\r\n│       └── spec.rb\r\n└── spec\r\n    ├── factories.rb\r\n    ├── models\r\n    │   ├── client_spec.rb\r\n    │   └── project_spec.rb\r\n    ├── routes\r\n    │   ├── app_spec.rb\r\n    │   ├── client_spec.rb\r\n    │   └── project_spec.rb\r\n    └── spec_helper.rb\r\n```\r\n\r\n### Note:\r\n\r\nTests should *fail*, not error. If a test gets a syntax error or complains about bad syntax in the test, that is a bad change. The test should still run, just fail."}}
{"actor":{"display_login":"ElijahCaine"}}