{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23","id":68950002,"html_url":"https://github.com/zendesk/ticket_sharing/pull/23","diff_url":"https://github.com/zendesk/ticket_sharing/pull/23.diff","patch_url":"https://github.com/zendesk/ticket_sharing/pull/23.patch","issue_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/23","number":23,"state":"closed","locked":false,"title":"Remove bare Net HTTP and make compatible with Faraday clients.","user":{"login":"pschambacher","id":547203,"avatar_url":"https://avatars.githubusercontent.com/u/547203?v=3","gravatar_id":"","url":"https://api.github.com/users/pschambacher","html_url":"https://github.com/pschambacher","followers_url":"https://api.github.com/users/pschambacher/followers","following_url":"https://api.github.com/users/pschambacher/following{/other_user}","gists_url":"https://api.github.com/users/pschambacher/gists{/gist_id}","starred_url":"https://api.github.com/users/pschambacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschambacher/subscriptions","organizations_url":"https://api.github.com/users/pschambacher/orgs","repos_url":"https://api.github.com/users/pschambacher/repos","events_url":"https://api.github.com/users/pschambacher/events{/privacy}","received_events_url":"https://api.github.com/users/pschambacher/received_events","type":"User","site_admin":false},"body":":octopus::computer:\r\n\r\n/cc @grosser @anamartinez @jcheatham @gabetax \r\n\r\nAlso interested in @ciaranarcher 's opinion since we're aiming to use our very own custom Faraday connection for this.\r\n\r\n### Description\r\nRemove Net::HTTP implementation in favor of Faraday clients.\r\n\r\nThis should allow us to configure the gem with a Faraday connection and use it, benefiting from all the middlewares coming with it.\r\n\r\nI'm just a bit doubtful about the SSL-bit since Faraday doesn't exactly allow us to change the configuration on the fly but I think it should work.\r\n\r\n### Steps to merge\r\n* [ ] :+1: from the team\r\n\r\n### Risks\r\n* High: this will be a major bump, the entire gem might not be working at all (I'm not entirely sure how much we can trust the test suite)","created_at":"2016-05-04T23:50:15Z","updated_at":"2016-05-06T18:35:13Z","closed_at":"2016-05-06T18:35:13Z","merged_at":"2016-05-06T18:35:13Z","merge_commit_sha":"305c0c464aefab66b4025102e815b4d63ef6cbaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23/commits","review_comments_url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23/comments","review_comment_url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/23/comments","statuses_url":"https://api.github.com/repos/zendesk/ticket_sharing/statuses/8c8898f621f76f171fa20722209f87563f1c2d57","head":{"label":"zendesk:pschambacher/faraday","ref":"pschambacher/faraday","sha":"8c8898f621f76f171fa20722209f87563f1c2d57","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":1606739,"name":"ticket_sharing","full_name":"zendesk/ticket_sharing","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/ticket_sharing","description":"Ticket Sharing","fork":false,"url":"https://api.github.com/repos/zendesk/ticket_sharing","forks_url":"https://api.github.com/repos/zendesk/ticket_sharing/forks","keys_url":"https://api.github.com/repos/zendesk/ticket_sharing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/ticket_sharing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/ticket_sharing/teams","hooks_url":"https://api.github.com/repos/zendesk/ticket_sharing/hooks","issue_events_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/ticket_sharing/events","assignees_url":"https://api.github.com/repos/zendesk/ticket_sharing/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/ticket_sharing/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/ticket_sharing/tags","blobs_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/ticket_sharing/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/ticket_sharing/languages","stargazers_url":"https://api.github.com/repos/zendesk/ticket_sharing/stargazers","contributors_url":"https://api.github.com/repos/zendesk/ticket_sharing/contributors","subscribers_url":"https://api.github.com/repos/zendesk/ticket_sharing/subscribers","subscription_url":"https://api.github.com/repos/zendesk/ticket_sharing/subscription","commits_url":"https://api.github.com/repos/zendesk/ticket_sharing/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/ticket_sharing/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/ticket_sharing/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/ticket_sharing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/ticket_sharing/merges","archive_url":"https://api.github.com/repos/zendesk/ticket_sharing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/ticket_sharing/downloads","issues_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/ticket_sharing/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/ticket_sharing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/ticket_sharing/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/ticket_sharing/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/ticket_sharing/deployments","created_at":"2011-04-12T22:56:26Z","updated_at":"2016-01-28T16:22:23Z","pushed_at":"2016-05-06T18:35:13Z","git_url":"git://github.com/zendesk/ticket_sharing.git","ssh_url":"git@github.com:zendesk/ticket_sharing.git","clone_url":"https://github.com/zendesk/ticket_sharing.git","svn_url":"https://github.com/zendesk/ticket_sharing","homepage":"","size":105,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"f8c0a82e7a0708f4d7064a97ec7ccf7a7d1d8c4a","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":1606739,"name":"ticket_sharing","full_name":"zendesk/ticket_sharing","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/ticket_sharing","description":"Ticket Sharing","fork":false,"url":"https://api.github.com/repos/zendesk/ticket_sharing","forks_url":"https://api.github.com/repos/zendesk/ticket_sharing/forks","keys_url":"https://api.github.com/repos/zendesk/ticket_sharing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/ticket_sharing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/ticket_sharing/teams","hooks_url":"https://api.github.com/repos/zendesk/ticket_sharing/hooks","issue_events_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/ticket_sharing/events","assignees_url":"https://api.github.com/repos/zendesk/ticket_sharing/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/ticket_sharing/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/ticket_sharing/tags","blobs_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/ticket_sharing/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/ticket_sharing/languages","stargazers_url":"https://api.github.com/repos/zendesk/ticket_sharing/stargazers","contributors_url":"https://api.github.com/repos/zendesk/ticket_sharing/contributors","subscribers_url":"https://api.github.com/repos/zendesk/ticket_sharing/subscribers","subscription_url":"https://api.github.com/repos/zendesk/ticket_sharing/subscription","commits_url":"https://api.github.com/repos/zendesk/ticket_sharing/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/ticket_sharing/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/ticket_sharing/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/ticket_sharing/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/ticket_sharing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/ticket_sharing/merges","archive_url":"https://api.github.com/repos/zendesk/ticket_sharing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/ticket_sharing/downloads","issues_url":"https://api.github.com/repos/zendesk/ticket_sharing/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/ticket_sharing/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/ticket_sharing/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/ticket_sharing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/ticket_sharing/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/ticket_sharing/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/ticket_sharing/deployments","created_at":"2011-04-12T22:56:26Z","updated_at":"2016-01-28T16:22:23Z","pushed_at":"2016-05-06T18:35:13Z","git_url":"git://github.com/zendesk/ticket_sharing.git","ssh_url":"git@github.com:zendesk/ticket_sharing.git","clone_url":"https://github.com/zendesk/ticket_sharing.git","svn_url":"https://github.com/zendesk/ticket_sharing","homepage":"","size":105,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23"},"html":{"href":"https://github.com/zendesk/ticket_sharing/pull/23"},"issue":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/issues/23"},"comments":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/ticket_sharing/statuses/8c8898f621f76f171fa20722209f87563f1c2d57"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pschambacher","id":547203,"avatar_url":"https://avatars.githubusercontent.com/u/547203?v=3","gravatar_id":"","url":"https://api.github.com/users/pschambacher","html_url":"https://github.com/pschambacher","followers_url":"https://api.github.com/users/pschambacher/followers","following_url":"https://api.github.com/users/pschambacher/following{/other_user}","gists_url":"https://api.github.com/users/pschambacher/gists{/gist_id}","starred_url":"https://api.github.com/users/pschambacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschambacher/subscriptions","organizations_url":"https://api.github.com/users/pschambacher/orgs","repos_url":"https://api.github.com/users/pschambacher/repos","events_url":"https://api.github.com/users/pschambacher/events{/privacy}","received_events_url":"https://api.github.com/users/pschambacher/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":82,"deletions":59,"changed_files":12}}