{"action":"created","comment":{"url":"https://api.github.com/repos/librsync/librsync/pulls/comments/84596645","pull_request_review_id":5365593,"id":84596645,"diff_hunk":"@@ -37,9 +37,36 @@\n #define _RSYNC_H\n \n #include <sys/types.h>\n-#include \"types.h\"\n #include \"librsync-config.h\"\n \n+#define HAVE_UINT64 1 /* assume success, but might be undefined below */\n+\n+#if defined(HAVE_STDINT_H)\n+#  include <stdint.h>\n+#else\n+# if SIZEOF_UNSIGNED_INT == 4","path":"src/librsync.h","position":12,"original_position":12,"commit_id":"dc3c3a9d89052c31cdb82877b3b42793bd137b5e","original_commit_id":"dc3c3a9d89052c31cdb82877b3b42793bd137b5e","user":{"login":"sourcefrog","id":346355,"avatar_url":"https://avatars.githubusercontent.com/u/346355?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcefrog","html_url":"https://github.com/sourcefrog","followers_url":"https://api.github.com/users/sourcefrog/followers","following_url":"https://api.github.com/users/sourcefrog/following{/other_user}","gists_url":"https://api.github.com/users/sourcefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcefrog/subscriptions","organizations_url":"https://api.github.com/users/sourcefrog/orgs","repos_url":"https://api.github.com/users/sourcefrog/repos","events_url":"https://api.github.com/users/sourcefrog/events{/privacy}","received_events_url":"https://api.github.com/users/sourcefrog/received_events","type":"User","site_admin":false},"body":"stdint is apparently from C99, and generally I think it's reasonable we rely on C99.  And, as you say, blake2.h assumes it.\r\n\r\nI'll put up an alternative fix.","created_at":"2016-10-23T14:08:07Z","updated_at":"2016-10-23T14:08:07Z","html_url":"https://github.com/librsync/librsync/pull/91#discussion_r84596645","pull_request_url":"https://api.github.com/repos/librsync/librsync/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/librsync/librsync/pulls/comments/84596645"},"html":{"href":"https://github.com/librsync/librsync/pull/91#discussion_r84596645"},"pull_request":{"href":"https://api.github.com/repos/librsync/librsync/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/librsync/librsync/pulls/91","id":90491484,"html_url":"https://github.com/librsync/librsync/pull/91","diff_url":"https://github.com/librsync/librsync/pull/91.diff","patch_url":"https://github.com/librsync/librsync/pull/91.patch","issue_url":"https://api.github.com/repos/librsync/librsync/issues/91","number":91,"state":"open","locked":false,"title":"Move types.h inline in librsync.h","user":{"login":"sourcefrog","id":346355,"avatar_url":"https://avatars.githubusercontent.com/u/346355?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcefrog","html_url":"https://github.com/sourcefrog","followers_url":"https://api.github.com/users/sourcefrog/followers","following_url":"https://api.github.com/users/sourcefrog/following{/other_user}","gists_url":"https://api.github.com/users/sourcefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcefrog/subscriptions","organizations_url":"https://api.github.com/users/sourcefrog/orgs","repos_url":"https://api.github.com/users/sourcefrog/repos","events_url":"https://api.github.com/users/sourcefrog/events{/privacy}","received_events_url":"https://api.github.com/users/sourcefrog/received_events","type":"User","site_admin":false},"body":"Avoids errors building from an installed copy of librsync.h, when\r\ntypes.h cannot be found.\r\n\r\nFixes #90.","created_at":"2016-10-22T18:50:17Z","updated_at":"2016-10-23T14:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d08b229d9395471ccfe2509b94519f36135607ae","assignee":{"login":"dbaarda","id":2046387,"avatar_url":"https://avatars.githubusercontent.com/u/2046387?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaarda","html_url":"https://github.com/dbaarda","followers_url":"https://api.github.com/users/dbaarda/followers","following_url":"https://api.github.com/users/dbaarda/following{/other_user}","gists_url":"https://api.github.com/users/dbaarda/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaarda/subscriptions","organizations_url":"https://api.github.com/users/dbaarda/orgs","repos_url":"https://api.github.com/users/dbaarda/repos","events_url":"https://api.github.com/users/dbaarda/events{/privacy}","received_events_url":"https://api.github.com/users/dbaarda/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbaarda","id":2046387,"avatar_url":"https://avatars.githubusercontent.com/u/2046387?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaarda","html_url":"https://github.com/dbaarda","followers_url":"https://api.github.com/users/dbaarda/followers","following_url":"https://api.github.com/users/dbaarda/following{/other_user}","gists_url":"https://api.github.com/users/dbaarda/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaarda/subscriptions","organizations_url":"https://api.github.com/users/dbaarda/orgs","repos_url":"https://api.github.com/users/dbaarda/repos","events_url":"https://api.github.com/users/dbaarda/events{/privacy}","received_events_url":"https://api.github.com/users/dbaarda/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/librsync/librsync/pulls/91/commits","review_comments_url":"https://api.github.com/repos/librsync/librsync/pulls/91/comments","review_comment_url":"https://api.github.com/repos/librsync/librsync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librsync/librsync/issues/91/comments","statuses_url":"https://api.github.com/repos/librsync/librsync/statuses/dc3c3a9d89052c31cdb82877b3b42793bd137b5e","head":{"label":"sourcefrog:90-types.h","ref":"90-types.h","sha":"dc3c3a9d89052c31cdb82877b3b42793bd137b5e","user":{"login":"sourcefrog","id":346355,"avatar_url":"https://avatars.githubusercontent.com/u/346355?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcefrog","html_url":"https://github.com/sourcefrog","followers_url":"https://api.github.com/users/sourcefrog/followers","following_url":"https://api.github.com/users/sourcefrog/following{/other_user}","gists_url":"https://api.github.com/users/sourcefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcefrog/subscriptions","organizations_url":"https://api.github.com/users/sourcefrog/orgs","repos_url":"https://api.github.com/users/sourcefrog/repos","events_url":"https://api.github.com/users/sourcefrog/events{/privacy}","received_events_url":"https://api.github.com/users/sourcefrog/received_events","type":"User","site_admin":false},"repo":{"id":25123454,"name":"librsync","full_name":"sourcefrog/librsync","owner":{"login":"sourcefrog","id":346355,"avatar_url":"https://avatars.githubusercontent.com/u/346355?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcefrog","html_url":"https://github.com/sourcefrog","followers_url":"https://api.github.com/users/sourcefrog/followers","following_url":"https://api.github.com/users/sourcefrog/following{/other_user}","gists_url":"https://api.github.com/users/sourcefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcefrog/subscriptions","organizations_url":"https://api.github.com/users/sourcefrog/orgs","repos_url":"https://api.github.com/users/sourcefrog/repos","events_url":"https://api.github.com/users/sourcefrog/events{/privacy}","received_events_url":"https://api.github.com/users/sourcefrog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sourcefrog/librsync","description":"remote delta-compression library","fork":true,"url":"https://api.github.com/repos/sourcefrog/librsync","forks_url":"https://api.github.com/repos/sourcefrog/librsync/forks","keys_url":"https://api.github.com/repos/sourcefrog/librsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcefrog/librsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcefrog/librsync/teams","hooks_url":"https://api.github.com/repos/sourcefrog/librsync/hooks","issue_events_url":"https://api.github.com/repos/sourcefrog/librsync/issues/events{/number}","events_url":"https://api.github.com/repos/sourcefrog/librsync/events","assignees_url":"https://api.github.com/repos/sourcefrog/librsync/assignees{/user}","branches_url":"https://api.github.com/repos/sourcefrog/librsync/branches{/branch}","tags_url":"https://api.github.com/repos/sourcefrog/librsync/tags","blobs_url":"https://api.github.com/repos/sourcefrog/librsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcefrog/librsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcefrog/librsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcefrog/librsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcefrog/librsync/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcefrog/librsync/languages","stargazers_url":"https://api.github.com/repos/sourcefrog/librsync/stargazers","contributors_url":"https://api.github.com/repos/sourcefrog/librsync/contributors","subscribers_url":"https://api.github.com/repos/sourcefrog/librsync/subscribers","subscription_url":"https://api.github.com/repos/sourcefrog/librsync/subscription","commits_url":"https://api.github.com/repos/sourcefrog/librsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcefrog/librsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcefrog/librsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcefrog/librsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcefrog/librsync/contents/{+path}","compare_url":"https://api.github.com/repos/sourcefrog/librsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcefrog/librsync/merges","archive_url":"https://api.github.com/repos/sourcefrog/librsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcefrog/librsync/downloads","issues_url":"https://api.github.com/repos/sourcefrog/librsync/issues{/number}","pulls_url":"https://api.github.com/repos/sourcefrog/librsync/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcefrog/librsync/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcefrog/librsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcefrog/librsync/labels{/name}","releases_url":"https://api.github.com/repos/sourcefrog/librsync/releases{/id}","deployments_url":"https://api.github.com/repos/sourcefrog/librsync/deployments","created_at":"2014-10-12T15:32:10Z","updated_at":"2015-11-14T23:17:39Z","pushed_at":"2016-10-22T18:48:10Z","git_url":"git://github.com/sourcefrog/librsync.git","ssh_url":"git@github.com:sourcefrog/librsync.git","clone_url":"https://github.com/sourcefrog/librsync.git","svn_url":"https://github.com/sourcefrog/librsync","homepage":"librsync.sourcefrog.net","size":2167,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librsync:master","ref":"master","sha":"8a2efa9c23d8b066a27218b259d3bc1d9a60db66","user":{"login":"librsync","id":7358443,"avatar_url":"https://avatars.githubusercontent.com/u/7358443?v=3","gravatar_id":"","url":"https://api.github.com/users/librsync","html_url":"https://github.com/librsync","followers_url":"https://api.github.com/users/librsync/followers","following_url":"https://api.github.com/users/librsync/following{/other_user}","gists_url":"https://api.github.com/users/librsync/gists{/gist_id}","starred_url":"https://api.github.com/users/librsync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librsync/subscriptions","organizations_url":"https://api.github.com/users/librsync/orgs","repos_url":"https://api.github.com/users/librsync/repos","events_url":"https://api.github.com/users/librsync/events{/privacy}","received_events_url":"https://api.github.com/users/librsync/received_events","type":"Organization","site_admin":false},"repo":{"id":19018387,"name":"librsync","full_name":"librsync/librsync","owner":{"login":"librsync","id":7358443,"avatar_url":"https://avatars.githubusercontent.com/u/7358443?v=3","gravatar_id":"","url":"https://api.github.com/users/librsync","html_url":"https://github.com/librsync","followers_url":"https://api.github.com/users/librsync/followers","following_url":"https://api.github.com/users/librsync/following{/other_user}","gists_url":"https://api.github.com/users/librsync/gists{/gist_id}","starred_url":"https://api.github.com/users/librsync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librsync/subscriptions","organizations_url":"https://api.github.com/users/librsync/orgs","repos_url":"https://api.github.com/users/librsync/repos","events_url":"https://api.github.com/users/librsync/events{/privacy}","received_events_url":"https://api.github.com/users/librsync/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librsync/librsync","description":"remote delta-compression library","fork":false,"url":"https://api.github.com/repos/librsync/librsync","forks_url":"https://api.github.com/repos/librsync/librsync/forks","keys_url":"https://api.github.com/repos/librsync/librsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librsync/librsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librsync/librsync/teams","hooks_url":"https://api.github.com/repos/librsync/librsync/hooks","issue_events_url":"https://api.github.com/repos/librsync/librsync/issues/events{/number}","events_url":"https://api.github.com/repos/librsync/librsync/events","assignees_url":"https://api.github.com/repos/librsync/librsync/assignees{/user}","branches_url":"https://api.github.com/repos/librsync/librsync/branches{/branch}","tags_url":"https://api.github.com/repos/librsync/librsync/tags","blobs_url":"https://api.github.com/repos/librsync/librsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librsync/librsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librsync/librsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/librsync/librsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librsync/librsync/statuses/{sha}","languages_url":"https://api.github.com/repos/librsync/librsync/languages","stargazers_url":"https://api.github.com/repos/librsync/librsync/stargazers","contributors_url":"https://api.github.com/repos/librsync/librsync/contributors","subscribers_url":"https://api.github.com/repos/librsync/librsync/subscribers","subscription_url":"https://api.github.com/repos/librsync/librsync/subscription","commits_url":"https://api.github.com/repos/librsync/librsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/librsync/librsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/librsync/librsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/librsync/librsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/librsync/librsync/contents/{+path}","compare_url":"https://api.github.com/repos/librsync/librsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librsync/librsync/merges","archive_url":"https://api.github.com/repos/librsync/librsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librsync/librsync/downloads","issues_url":"https://api.github.com/repos/librsync/librsync/issues{/number}","pulls_url":"https://api.github.com/repos/librsync/librsync/pulls{/number}","milestones_url":"https://api.github.com/repos/librsync/librsync/milestones{/number}","notifications_url":"https://api.github.com/repos/librsync/librsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librsync/librsync/labels{/name}","releases_url":"https://api.github.com/repos/librsync/librsync/releases{/id}","deployments_url":"https://api.github.com/repos/librsync/librsync/deployments","created_at":"2014-04-22T05:36:08Z","updated_at":"2016-10-22T17:07:55Z","pushed_at":"2016-10-22T18:50:17Z","git_url":"git://github.com/librsync/librsync.git","ssh_url":"git@github.com:librsync/librsync.git","clone_url":"https://github.com/librsync/librsync.git","svn_url":"https://github.com/librsync/librsync","homepage":"librsync.sourcefrog.net","size":2242,"stargazers_count":227,"watchers_count":227,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":35,"forks":63,"open_issues":35,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librsync/librsync/pulls/91"},"html":{"href":"https://github.com/librsync/librsync/pull/91"},"issue":{"href":"https://api.github.com/repos/librsync/librsync/issues/91"},"comments":{"href":"https://api.github.com/repos/librsync/librsync/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/librsync/librsync/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/librsync/librsync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librsync/librsync/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/librsync/librsync/statuses/dc3c3a9d89052c31cdb82877b3b42793bd137b5e"}}}}
{"actor":{"display_login":"sourcefrog"}}