{"action":"created","issue":{"url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/4","repository_url":"https://api.github.com/repos/statisticsnorway/json-stat.java","labels_url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/4/comments","events_url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/4/events","html_url":"https://github.com/statisticsnorway/json-stat.java/pull/4","id":184598430,"number":4,"title":"Adds Extension to Dataset; Adds Index to, Removes Class and Version from Dimension","user":{"login":"jmouradi","id":3516098,"avatar_url":"https://avatars.githubusercontent.com/u/3516098?v=3","gravatar_id":"","url":"https://api.github.com/users/jmouradi","html_url":"https://github.com/jmouradi","followers_url":"https://api.github.com/users/jmouradi/followers","following_url":"https://api.github.com/users/jmouradi/following{/other_user}","gists_url":"https://api.github.com/users/jmouradi/gists{/gist_id}","starred_url":"https://api.github.com/users/jmouradi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmouradi/subscriptions","organizations_url":"https://api.github.com/users/jmouradi/orgs","repos_url":"https://api.github.com/users/jmouradi/repos","events_url":"https://api.github.com/users/jmouradi/events{/privacy}","received_events_url":"https://api.github.com/users/jmouradi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-22T01:00:34Z","updated_at":"2016-10-25T20:53:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/statisticsnorway/json-stat.java/pulls/4","html_url":"https://github.com/statisticsnorway/json-stat.java/pull/4","diff_url":"https://github.com/statisticsnorway/json-stat.java/pull/4.diff","patch_url":"https://github.com/statisticsnorway/json-stat.java/pull/4.patch"},"body":"This revision: \r\n\r\n1. Removes `class` and `version` from the `Dimension` class, as the `Dimension` class is used internally to the `Dataset` class; the `dimension` field within `dataset` in the [schema](https://json-stat.org/format/schema/2.0/) does not include these and the presence of these fields is invalid according to the json-stat.org [validator](https://json-stat.org/format/validator/).\r\n\r\n2. Adds the ability to provide only an `index` without a `label` in `dimension`. \r\n3. Adds the ability to supply an `extension` field to a `dataset`. \r\n\r\nItem (1) is for correctness (though a separate, top-level `dimension` response class will need to be created), while items (2) and (3) are features required for our own minimum viable prototyping and iteration.\r\n\r\nBecause this is not a confirmed release, pom.xml is not bumped.\r\n\r\nPlease let me know what changes you'd like to see before making this merge!"},"comment":{"url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/comments/256172447","html_url":"https://github.com/statisticsnorway/json-stat.java/pull/4#issuecomment-256172447","issue_url":"https://api.github.com/repos/statisticsnorway/json-stat.java/issues/4","id":256172447,"user":{"login":"jmouradi","id":3516098,"avatar_url":"https://avatars.githubusercontent.com/u/3516098?v=3","gravatar_id":"","url":"https://api.github.com/users/jmouradi","html_url":"https://github.com/jmouradi","followers_url":"https://api.github.com/users/jmouradi/followers","following_url":"https://api.github.com/users/jmouradi/following{/other_user}","gists_url":"https://api.github.com/users/jmouradi/gists{/gist_id}","starred_url":"https://api.github.com/users/jmouradi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmouradi/subscriptions","organizations_url":"https://api.github.com/users/jmouradi/orgs","repos_url":"https://api.github.com/users/jmouradi/repos","events_url":"https://api.github.com/users/jmouradi/events{/privacy}","received_events_url":"https://api.github.com/users/jmouradi/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T20:53:29Z","updated_at":"2016-10-25T20:53:29Z","body":"Hi Hadrien,\r\n    Thanks for taking a look! I have removed the `<String, String>` typing from Extension, and also made it nullable. What do you think of the current accessor, [getExtension](https://github.com/statisticsnorway/json-stat.java/pull/4/files#diff-af63729710dae6c221d9d305304faca0R89)? "}}
{"actor":{"display_login":"jmouradi"}}