{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/51178085","id":51178085,"diff_hunk":"@@ -1147,9 +1147,11 @@ goog.scope(function() {\n             gl.texImage2D(gl.TEXTURE_2D, 0, gl.R8I, 0, 0, 0, gl.RED_INTEGER, gl.BYTE, null);\n             gl.generateMipmap(gl.TEXTURE_2D);\n             this.expectError(gl.INVALID_OPERATION);\n-            gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA32F, 0, 0, 0, gl.RGBA, gl.FLOAT, null);\n-            gl.generateMipmap(gl.TEXTURE_2D);\n-            this.expectError(gl.INVALID_OPERATION);\n+            if (!gl.getExtension('EXT_color_buffer_float') || !gl.getExtension('OES_texture_float_linear')) {","path":"sdk/tests/deqp/functional/gles3/es3fNegativeTextureApiTests.js","position":7,"original_position":7,"commit_id":"1c7978f30d9f49e2394be869e1c2c26565c5cb19","original_commit_id":"1c7978f30d9f49e2394be869e1c2c26565c5cb19","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"body":"That's correct. The original code should have always generated an INVALID_OPERATION.\r\n\r\nA new clause here could read something like:\r\n\r\nif (gl.getExtension('EXT_color_buffer_float') && gl.getExtension('OES_texture_float_linear')) {\r\n  gl.generateMipmap(gl.TEXTURE_2D);\r\n  this.expectError(gl.NO_ERROR);\r\n}\r\n","created_at":"2016-01-28T19:56:04Z","updated_at":"2016-01-28T19:56:04Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1456#discussion_r51178085","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/51178085"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1456#discussion_r51178085"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456","id":57537974,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1456","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1456.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1456.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1456","number":1456,"state":"open","locked":false,"title":"Fix generateMipmap for float texture","user":{"login":"qkmiao","id":1152109,"avatar_url":"https://avatars.githubusercontent.com/u/1152109?v=3","gravatar_id":"","url":"https://api.github.com/users/qkmiao","html_url":"https://github.com/qkmiao","followers_url":"https://api.github.com/users/qkmiao/followers","following_url":"https://api.github.com/users/qkmiao/following{/other_user}","gists_url":"https://api.github.com/users/qkmiao/gists{/gist_id}","starred_url":"https://api.github.com/users/qkmiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkmiao/subscriptions","organizations_url":"https://api.github.com/users/qkmiao/orgs","repos_url":"https://api.github.com/users/qkmiao/repos","events_url":"https://api.github.com/users/qkmiao/events{/privacy}","received_events_url":"https://api.github.com/users/qkmiao/received_events","type":"User","site_admin":false},"body":"When extensions EXT_color_buffer_float and OES_texture_float_linear are\r\nenabled, generateMipmap should success for float type texture.","created_at":"2016-01-28T17:43:15Z","updated_at":"2016-01-28T19:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1245dc3d5bae58a6875f476ab9764bfb6c8d717","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1456/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/1c7978f30d9f49e2394be869e1c2c26565c5cb19","head":{"label":"qkmiao:ext-color-buffer-float","ref":"ext-color-buffer-float","sha":"1c7978f30d9f49e2394be869e1c2c26565c5cb19","user":{"login":"qkmiao","id":1152109,"avatar_url":"https://avatars.githubusercontent.com/u/1152109?v=3","gravatar_id":"","url":"https://api.github.com/users/qkmiao","html_url":"https://github.com/qkmiao","followers_url":"https://api.github.com/users/qkmiao/followers","following_url":"https://api.github.com/users/qkmiao/following{/other_user}","gists_url":"https://api.github.com/users/qkmiao/gists{/gist_id}","starred_url":"https://api.github.com/users/qkmiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkmiao/subscriptions","organizations_url":"https://api.github.com/users/qkmiao/orgs","repos_url":"https://api.github.com/users/qkmiao/repos","events_url":"https://api.github.com/users/qkmiao/events{/privacy}","received_events_url":"https://api.github.com/users/qkmiao/received_events","type":"User","site_admin":false},"repo":{"id":35211224,"name":"WebGL","full_name":"qkmiao/WebGL","owner":{"login":"qkmiao","id":1152109,"avatar_url":"https://avatars.githubusercontent.com/u/1152109?v=3","gravatar_id":"","url":"https://api.github.com/users/qkmiao","html_url":"https://github.com/qkmiao","followers_url":"https://api.github.com/users/qkmiao/followers","following_url":"https://api.github.com/users/qkmiao/following{/other_user}","gists_url":"https://api.github.com/users/qkmiao/gists{/gist_id}","starred_url":"https://api.github.com/users/qkmiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkmiao/subscriptions","organizations_url":"https://api.github.com/users/qkmiao/orgs","repos_url":"https://api.github.com/users/qkmiao/repos","events_url":"https://api.github.com/users/qkmiao/events{/privacy}","received_events_url":"https://api.github.com/users/qkmiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qkmiao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/qkmiao/WebGL","forks_url":"https://api.github.com/repos/qkmiao/WebGL/forks","keys_url":"https://api.github.com/repos/qkmiao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qkmiao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qkmiao/WebGL/teams","hooks_url":"https://api.github.com/repos/qkmiao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/qkmiao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/qkmiao/WebGL/events","assignees_url":"https://api.github.com/repos/qkmiao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/qkmiao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/qkmiao/WebGL/tags","blobs_url":"https://api.github.com/repos/qkmiao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qkmiao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qkmiao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/qkmiao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qkmiao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/qkmiao/WebGL/languages","stargazers_url":"https://api.github.com/repos/qkmiao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/qkmiao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/qkmiao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/qkmiao/WebGL/subscription","commits_url":"https://api.github.com/repos/qkmiao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/qkmiao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/qkmiao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/qkmiao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/qkmiao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/qkmiao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qkmiao/WebGL/merges","archive_url":"https://api.github.com/repos/qkmiao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qkmiao/WebGL/downloads","issues_url":"https://api.github.com/repos/qkmiao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/qkmiao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/qkmiao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/qkmiao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qkmiao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/qkmiao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/qkmiao/WebGL/deployments","created_at":"2015-05-07T09:30:20Z","updated_at":"2015-05-07T09:30:39Z","pushed_at":"2016-01-28T17:42:51Z","git_url":"git://github.com/qkmiao/WebGL.git","ssh_url":"git@github.com:qkmiao/WebGL.git","clone_url":"https://github.com/qkmiao/WebGL.git","svn_url":"https://github.com/qkmiao/WebGL","homepage":null,"size":20117,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"ceacc49916cb82d16909ae14b0e0f8d2897385dd","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-01-26T09:56:58Z","pushed_at":"2016-01-28T17:43:16Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":26620,"stargazers_count":503,"watchers_count":503,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":53,"forks":273,"open_issues":53,"watchers":503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1456"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1456"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1456/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1456/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/1c7978f30d9f49e2394be869e1c2c26565c5cb19"}}}}