{"comment":{"url":"https://api.github.com/repos/cicerono/validator/comments/19786554","html_url":"https://github.com/cicerono/validator/commit/d4b9dd1da102a7e9c1191bfa69386266d1eba00e#commitcomment-19786554","id":19786554,"user":{"login":"relekang","id":476364,"avatar_url":"https://avatars.githubusercontent.com/u/476364?v=3","gravatar_id":"","url":"https://api.github.com/users/relekang","html_url":"https://github.com/relekang","followers_url":"https://api.github.com/users/relekang/followers","following_url":"https://api.github.com/users/relekang/following{/other_user}","gists_url":"https://api.github.com/users/relekang/gists{/gist_id}","starred_url":"https://api.github.com/users/relekang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relekang/subscriptions","organizations_url":"https://api.github.com/users/relekang/orgs","repos_url":"https://api.github.com/users/relekang/repos","events_url":"https://api.github.com/users/relekang/events{/privacy}","received_events_url":"https://api.github.com/users/relekang/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"d4b9dd1da102a7e9c1191bfa69386266d1eba00e","created_at":"2016-11-11T13:58:14Z","updated_at":"2016-11-11T13:58:14Z","body":"> I haven't used memoize before, but from the documentation it seems memoizing object parameters can have unwanted behaviour if we do not define our own resolver. As I understand it the cache key of an object is the reference and not a deep comparison, which could lead to bugs if the input objects are mutated.\r\n\r\nGood point, it is not a problem for our current usage since it should be used with immutable stores, but we should probably document it well, and yeah let's keep it optional."}}
{"actor":{"display_login":"relekang"}}