{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/scalding/pulls/comments/59228040","id":59228040,"diff_hunk":"@@ -140,14 +140,14 @@ class TypedParquetTupleScheme[T](val readSupport: ParquetReadSupport[T], val wri\n   type SourceCallType = SourceCall[Array[AnyRef], Reader]\n   type SinkCallType = SinkCall[Array[AnyRef], Output]\n \n-  override def sourceConfInit(flowProcess: FlowProcess[JobConf], tap: TapType, jobConf: JobConf): Unit = {\n+  override def sourceConfInit(flowProcess: FlowProcess[_ <: JobConf], tap: TapType, jobConf: JobConf): Unit = {","path":"scalding-parquet/src/main/scala/com/twitter/scalding/parquet/tuple/scheme/TypedParquetTupleScheme.scala","position":5,"original_position":5,"commit_id":"ed5b95d318cff43b3d7a25be1b5e1ca52066ad76","original_commit_id":"3cf03b050a8fe3e7bc8e3967188b3d8157d88b46","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"body":"JobConf is the old hadoop1 api and Configuration is hadoop2. In cascading3, Hfs taps and descendents were moved to the hadoop2 api. Cascading's MultiInputFormat still looks at the hadoop1 key for the input formats though (see https://github.com/twitter/elephant-bird/pull/465). So broadly, the changes involved moving anything that's closely tied to the Hfs tap to use Configuration, leaving the remaining to use JobConf, and still using the Deprecated wrappers for the EB input and output formats.","created_at":"2016-04-11T15:46:42Z","updated_at":"2016-04-11T15:46:42Z","html_url":"https://github.com/twitter/scalding/pull/1521#discussion_r59228040","pull_request_url":"https://api.github.com/repos/twitter/scalding/pulls/1521","_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments/59228040"},"html":{"href":"https://github.com/twitter/scalding/pull/1521#discussion_r59228040"},"pull_request":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1521"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/scalding/pulls/1521","id":59905307,"html_url":"https://github.com/twitter/scalding/pull/1521","diff_url":"https://github.com/twitter/scalding/pull/1521.diff","patch_url":"https://github.com/twitter/scalding/pull/1521.patch","issue_url":"https://api.github.com/repos/twitter/scalding/issues/1521","number":1521,"state":"open","locked":false,"title":"[cascading3] Migrate core, commons and related","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"body":"part of https://github.com/twitter/scalding/issues/1465\r\nbased on Cyrille's work in https://github.com/twitter/scalding/pull/1446\r\n\r\nMost of the interesting changes are in:\r\n* Operations.scala -- to handle both old and new cascading aggregate by thresholds\r\n* PlatformTest.scala -- some updated tests, hashjoining and then merging the result with one side of the same join is no longer supported in cascading3\r\n\r\nCascading fabric selection changes will be sent in a separate PR.","created_at":"2016-02-19T05:08:32Z","updated_at":"2016-04-11T15:46:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daada117dfe09f4f3db5799f4ac0e7ca84d98f50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/scalding/pulls/1521/commits","review_comments_url":"https://api.github.com/repos/twitter/scalding/pulls/1521/comments","review_comment_url":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/scalding/issues/1521/comments","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/ed5b95d318cff43b3d7a25be1b5e1ca52066ad76","head":{"label":"twitter:rubanm/cascading3/core","ref":"rubanm/cascading3/core","sha":"ed5b95d318cff43b3d7a25be1b5e1ca52066ad76","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3146558,"name":"scalding","full_name":"twitter/scalding","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scalding","description":"A Scala API for Cascading","fork":false,"url":"https://api.github.com/repos/twitter/scalding","forks_url":"https://api.github.com/repos/twitter/scalding/forks","keys_url":"https://api.github.com/repos/twitter/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scalding/teams","hooks_url":"https://api.github.com/repos/twitter/scalding/hooks","issue_events_url":"https://api.github.com/repos/twitter/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scalding/events","assignees_url":"https://api.github.com/repos/twitter/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scalding/tags","blobs_url":"https://api.github.com/repos/twitter/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scalding/languages","stargazers_url":"https://api.github.com/repos/twitter/scalding/stargazers","contributors_url":"https://api.github.com/repos/twitter/scalding/contributors","subscribers_url":"https://api.github.com/repos/twitter/scalding/subscribers","subscription_url":"https://api.github.com/repos/twitter/scalding/subscription","commits_url":"https://api.github.com/repos/twitter/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scalding/merges","archive_url":"https://api.github.com/repos/twitter/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scalding/downloads","issues_url":"https://api.github.com/repos/twitter/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scalding/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scalding/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/scalding/deployments","created_at":"2012-01-10T16:22:08Z","updated_at":"2016-04-11T07:31:44Z","pushed_at":"2016-04-08T20:42:25Z","git_url":"git://github.com/twitter/scalding.git","ssh_url":"git@github.com:twitter/scalding.git","clone_url":"https://github.com/twitter/scalding.git","svn_url":"https://github.com/twitter/scalding","homepage":"http://twitter.com/scalding","size":15565,"stargazers_count":2479,"watchers_count":2479,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":582,"mirror_url":null,"open_issues_count":266,"forks":582,"open_issues":266,"watchers":2479,"default_branch":"develop"}},"base":{"label":"twitter:cascading3","ref":"cascading3","sha":"9229e52366d541691d1ba30ca59e21aadfd30831","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3146558,"name":"scalding","full_name":"twitter/scalding","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scalding","description":"A Scala API for Cascading","fork":false,"url":"https://api.github.com/repos/twitter/scalding","forks_url":"https://api.github.com/repos/twitter/scalding/forks","keys_url":"https://api.github.com/repos/twitter/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scalding/teams","hooks_url":"https://api.github.com/repos/twitter/scalding/hooks","issue_events_url":"https://api.github.com/repos/twitter/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scalding/events","assignees_url":"https://api.github.com/repos/twitter/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scalding/tags","blobs_url":"https://api.github.com/repos/twitter/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scalding/languages","stargazers_url":"https://api.github.com/repos/twitter/scalding/stargazers","contributors_url":"https://api.github.com/repos/twitter/scalding/contributors","subscribers_url":"https://api.github.com/repos/twitter/scalding/subscribers","subscription_url":"https://api.github.com/repos/twitter/scalding/subscription","commits_url":"https://api.github.com/repos/twitter/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scalding/merges","archive_url":"https://api.github.com/repos/twitter/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scalding/downloads","issues_url":"https://api.github.com/repos/twitter/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scalding/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scalding/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/scalding/deployments","created_at":"2012-01-10T16:22:08Z","updated_at":"2016-04-11T07:31:44Z","pushed_at":"2016-04-08T20:42:25Z","git_url":"git://github.com/twitter/scalding.git","ssh_url":"git@github.com:twitter/scalding.git","clone_url":"https://github.com/twitter/scalding.git","svn_url":"https://github.com/twitter/scalding","homepage":"http://twitter.com/scalding","size":15565,"stargazers_count":2479,"watchers_count":2479,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":582,"mirror_url":null,"open_issues_count":266,"forks":582,"open_issues":266,"watchers":2479,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1521"},"html":{"href":"https://github.com/twitter/scalding/pull/1521"},"issue":{"href":"https://api.github.com/repos/twitter/scalding/issues/1521"},"comments":{"href":"https://api.github.com/repos/twitter/scalding/issues/1521/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1521/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1521/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/scalding/statuses/ed5b95d318cff43b3d7a25be1b5e1ca52066ad76"}}}}