{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/83543536","pull_request_review_id":4382463,"id":83543536,"diff_hunk":"@@ -119,6 +119,7 @@ Database::applySchemaUpgrade(unsigned long vers)\n \n     case 4:\n         BanManager::dropAll(*this);\n+        DataFrame::dropAll(*this); // not and error, it changed again","path":"src/database/Database.cpp","position":4,"original_position":4,"commit_id":"6bf54bde60fd86472efa059101f4edd21785fb53","original_commit_id":"6bf54bde60fd86472efa059101f4edd21785fb53","user":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars.githubusercontent.com/u/4213763?v=3","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"body":"this change is actually wrong: deleting from the database doesn't delete from the bucket list so I think this will cause entries to show up as \"create\" instead of \"updates\" and potentially cause weird problems down the line with shadow entries. The proper way to do this is to do a alter table where lastmodified is something consistent with the past (I think it was stored as 0 in the xdr with the previous bug)","created_at":"2016-10-16T02:00:36Z","updated_at":"2016-10-16T02:00:36Z","html_url":"https://github.com/stellar/stellar-core/pull/1064#discussion_r83543536","pull_request_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1064","_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/83543536"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1064#discussion_r83543536"},"pull_request":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/1064","id":87102678,"html_url":"https://github.com/stellar/stellar-core/pull/1064","diff_url":"https://github.com/stellar/stellar-core/pull/1064.diff","patch_url":"https://github.com/stellar/stellar-core/pull/1064.patch","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/1064","number":1064,"state":"closed","locked":false,"title":"store lastmodified field in accountdata","user":{"login":"vogel","id":101391,"avatar_url":"https://avatars.githubusercontent.com/u/101391?v=3","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"body":"All other EntryFrame types (account, offer, trust) store value of\r\nlastModifiedLedgerSeq in database in lastmodified field. Now data also\r\nstores that.\r\n\r\nLack of this field caused errors in stellar-core-acceptance-history-\r\ntestnet-catchup: EntryFrame::checkAgainstDatabase was loading data\r\nfrom database but with lastModifiedLedgerSeq set to 0 - it was causing\r\n\"Inconsistent state between objects\" exception.\r\n\r\nSigned-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>","created_at":"2016-09-28T11:38:08Z","updated_at":"2016-10-16T02:00:36Z","closed_at":"2016-10-14T19:30:06Z","merged_at":"2016-10-14T19:30:06Z","merge_commit_sha":"6bf54bde60fd86472efa059101f4edd21785fb53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/1064/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/6bf54bde60fd86472efa059101f4edd21785fb53","head":{"label":"vogel:fix-history-testnet-catchup","ref":"fix-history-testnet-catchup","sha":"6bf54bde60fd86472efa059101f4edd21785fb53","user":{"login":"vogel","id":101391,"avatar_url":"https://avatars.githubusercontent.com/u/101391?v=3","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"repo":{"id":59241865,"name":"stellar-core","full_name":"vogel/stellar-core","owner":{"login":"vogel","id":101391,"avatar_url":"https://avatars.githubusercontent.com/u/101391?v=3","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vogel/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/vogel/stellar-core","forks_url":"https://api.github.com/repos/vogel/stellar-core/forks","keys_url":"https://api.github.com/repos/vogel/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vogel/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vogel/stellar-core/teams","hooks_url":"https://api.github.com/repos/vogel/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/vogel/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/vogel/stellar-core/events","assignees_url":"https://api.github.com/repos/vogel/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/vogel/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/vogel/stellar-core/tags","blobs_url":"https://api.github.com/repos/vogel/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vogel/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vogel/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/vogel/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vogel/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/vogel/stellar-core/languages","stargazers_url":"https://api.github.com/repos/vogel/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/vogel/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/vogel/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/vogel/stellar-core/subscription","commits_url":"https://api.github.com/repos/vogel/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/vogel/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/vogel/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/vogel/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/vogel/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/vogel/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vogel/stellar-core/merges","archive_url":"https://api.github.com/repos/vogel/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vogel/stellar-core/downloads","issues_url":"https://api.github.com/repos/vogel/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/vogel/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/vogel/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/vogel/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vogel/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/vogel/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/vogel/stellar-core/deployments","created_at":"2016-05-19T20:51:49Z","updated_at":"2016-06-07T01:14:42Z","pushed_at":"2016-10-14T21:13:36Z","git_url":"git://github.com/vogel/stellar-core.git","ssh_url":"git@github.com:vogel/stellar-core.git","clone_url":"https://github.com/vogel/stellar-core.git","svn_url":"https://github.com/vogel/stellar-core","homepage":"","size":11433,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:next-db-and-proto","ref":"next-db-and-proto","sha":"da048dc6ad16e1f1739ed89ba91f3f2ae89fb73d","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":27085821,"name":"stellar-core","full_name":"stellar/stellar-core","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-core","forks_url":"https://api.github.com/repos/stellar/stellar-core/forks","keys_url":"https://api.github.com/repos/stellar/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-core/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-core/events","assignees_url":"https://api.github.com/repos/stellar/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-core/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-core/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-core/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-core/merges","archive_url":"https://api.github.com/repos/stellar/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-core/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-core/deployments","created_at":"2014-11-24T17:11:12Z","updated_at":"2016-10-10T05:31:41Z","pushed_at":"2016-10-14T21:13:37Z","git_url":"git://github.com/stellar/stellar-core.git","ssh_url":"git@github.com:stellar/stellar-core.git","clone_url":"https://github.com/stellar/stellar-core.git","svn_url":"https://github.com/stellar/stellar-core","homepage":"","size":11816,"stargazers_count":350,"watchers_count":350,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":80,"forks":102,"open_issues":80,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1064"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1064"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1064"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-core/statuses/6bf54bde60fd86472efa059101f4edd21785fb53"}}}}
{"actor":{"display_login":"MonsieurNicolas"}}