{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/62042758","id":62042758,"diff_hunk":"@@ -575,8 +575,13 @@ class SparkSubmitSuite\n   // NOTE: This is an expensive operation in terms of time (10 seconds+). Use sparingly.\n   private def runSparkSubmit(args: Seq[String]): Unit = {\n     val sparkHome = sys.props.getOrElse(\"spark.test.home\", fail(\"spark.test.home is not set!\"))\n+    val sparkSubmit = if (Utils.isWindows) {\n+      Seq(new File(\"..\\\\bin\\\\spark-submit.cmd\").getAbsolutePath) ++ args\n+    } else {\n+      Seq(\"./bin/spark-submit\") ++ args","path":"core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala","position":7,"original_position":7,"commit_id":"18fbda57c373ab5c5e2995a4b6b24527ae5089ba","original_commit_id":"18fbda57c373ab5c5e2995a4b6b24527ae5089ba","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"OK this PR looks fine to me. My last suggested change would be to simply this changed bit of code to something like ...\r\n\r\n```\r\nval sparkSubmitPath = if (Utils.isWindows) \"...\" else \"...\"\r\n...\r\nval process = Utils.executeCommand(\r\n   sparkSubmitPath.getAbsolutePath +: args,\r\n...\r\n```\r\nI don't feel strongly about it","created_at":"2016-05-04T13:57:39Z","updated_at":"2016-05-04T13:57:39Z","html_url":"https://github.com/apache/spark/pull/12696#discussion_r62042758","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12696","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/62042758"},"html":{"href":"https://github.com/apache/spark/pull/12696#discussion_r62042758"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12696"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12696","id":67842189,"html_url":"https://github.com/apache/spark/pull/12696","diff_url":"https://github.com/apache/spark/pull/12696.diff","patch_url":"https://github.com/apache/spark/pull/12696.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12696","number":12696,"state":"open","locked":false,"title":"[SPARK-14914] Skip some test cases on Windows due to limitation of Windows ","user":{"login":"taoli91","id":18526063,"avatar_url":"https://avatars.githubusercontent.com/u/18526063?v=3","gravatar_id":"","url":"https://api.github.com/users/taoli91","html_url":"https://github.com/taoli91","followers_url":"https://api.github.com/users/taoli91/followers","following_url":"https://api.github.com/users/taoli91/following{/other_user}","gists_url":"https://api.github.com/users/taoli91/gists{/gist_id}","starred_url":"https://api.github.com/users/taoli91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoli91/subscriptions","organizations_url":"https://api.github.com/users/taoli91/orgs","repos_url":"https://api.github.com/users/taoli91/repos","events_url":"https://api.github.com/users/taoli91/events{/privacy}","received_events_url":"https://api.github.com/users/taoli91/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nThis pull request fix some general issue on windows:\r\n1. There are some jdk bugs on windows. \r\n2. Symlink handling on windows. \r\n\r\n## How was this patch tested?\r\nUnit tests (Not fully passed on windows)\r\n\r\n","created_at":"2016-04-26T08:02:49Z","updated_at":"2016-05-04T13:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47bdaebc2f540edffc1358e4d387e1836f0173d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12696/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12696/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12696/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/18fbda57c373ab5c5e2995a4b6b24527ae5089ba","head":{"label":"taoli91:windows_issue","ref":"windows_issue","sha":"18fbda57c373ab5c5e2995a4b6b24527ae5089ba","user":{"login":"taoli91","id":18526063,"avatar_url":"https://avatars.githubusercontent.com/u/18526063?v=3","gravatar_id":"","url":"https://api.github.com/users/taoli91","html_url":"https://github.com/taoli91","followers_url":"https://api.github.com/users/taoli91/followers","following_url":"https://api.github.com/users/taoli91/following{/other_user}","gists_url":"https://api.github.com/users/taoli91/gists{/gist_id}","starred_url":"https://api.github.com/users/taoli91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoli91/subscriptions","organizations_url":"https://api.github.com/users/taoli91/orgs","repos_url":"https://api.github.com/users/taoli91/repos","events_url":"https://api.github.com/users/taoli91/events{/privacy}","received_events_url":"https://api.github.com/users/taoli91/received_events","type":"User","site_admin":false},"repo":{"id":57106009,"name":"spark","full_name":"taoli91/spark","owner":{"login":"taoli91","id":18526063,"avatar_url":"https://avatars.githubusercontent.com/u/18526063?v=3","gravatar_id":"","url":"https://api.github.com/users/taoli91","html_url":"https://github.com/taoli91","followers_url":"https://api.github.com/users/taoli91/followers","following_url":"https://api.github.com/users/taoli91/following{/other_user}","gists_url":"https://api.github.com/users/taoli91/gists{/gist_id}","starred_url":"https://api.github.com/users/taoli91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoli91/subscriptions","organizations_url":"https://api.github.com/users/taoli91/orgs","repos_url":"https://api.github.com/users/taoli91/repos","events_url":"https://api.github.com/users/taoli91/events{/privacy}","received_events_url":"https://api.github.com/users/taoli91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taoli91/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/taoli91/spark","forks_url":"https://api.github.com/repos/taoli91/spark/forks","keys_url":"https://api.github.com/repos/taoli91/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taoli91/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taoli91/spark/teams","hooks_url":"https://api.github.com/repos/taoli91/spark/hooks","issue_events_url":"https://api.github.com/repos/taoli91/spark/issues/events{/number}","events_url":"https://api.github.com/repos/taoli91/spark/events","assignees_url":"https://api.github.com/repos/taoli91/spark/assignees{/user}","branches_url":"https://api.github.com/repos/taoli91/spark/branches{/branch}","tags_url":"https://api.github.com/repos/taoli91/spark/tags","blobs_url":"https://api.github.com/repos/taoli91/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taoli91/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taoli91/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/taoli91/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taoli91/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/taoli91/spark/languages","stargazers_url":"https://api.github.com/repos/taoli91/spark/stargazers","contributors_url":"https://api.github.com/repos/taoli91/spark/contributors","subscribers_url":"https://api.github.com/repos/taoli91/spark/subscribers","subscription_url":"https://api.github.com/repos/taoli91/spark/subscription","commits_url":"https://api.github.com/repos/taoli91/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/taoli91/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/taoli91/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/taoli91/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/taoli91/spark/contents/{+path}","compare_url":"https://api.github.com/repos/taoli91/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taoli91/spark/merges","archive_url":"https://api.github.com/repos/taoli91/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taoli91/spark/downloads","issues_url":"https://api.github.com/repos/taoli91/spark/issues{/number}","pulls_url":"https://api.github.com/repos/taoli91/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/taoli91/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/taoli91/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taoli91/spark/labels{/name}","releases_url":"https://api.github.com/repos/taoli91/spark/releases{/id}","deployments_url":"https://api.github.com/repos/taoli91/spark/deployments","created_at":"2016-04-26T07:08:01Z","updated_at":"2016-04-26T07:08:22Z","pushed_at":"2016-05-03T09:53:49Z","git_url":"git://github.com/taoli91/spark.git","ssh_url":"git@github.com:taoli91/spark.git","clone_url":"https://github.com/taoli91/spark.git","svn_url":"https://github.com/taoli91/spark","homepage":null,"size":166793,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2a5c930790b4b92674e74f093380d89a9a625552","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-05-04T13:04:12Z","pushed_at":"2016-05-04T13:47:00Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":475953,"stargazers_count":8391,"watchers_count":8391,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7788,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":413,"forks":7788,"open_issues":413,"watchers":8391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12696"},"html":{"href":"https://github.com/apache/spark/pull/12696"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12696"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12696/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12696/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12696/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/18fbda57c373ab5c5e2995a4b6b24527ae5089ba"}}}}