{"action":"created","issue":{"url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/3","repository_url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d","labels_url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/3/comments","events_url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/3/events","html_url":"https://github.com/SDLash3D/hlsdk-xash3d/pull/3","id":155337423,"number":3,"title":"VS 2015 Port of \"hlsdk for Xash\" and Other Fixes","user":{"login":"fuzun","id":5276126,"avatar_url":"https://avatars.githubusercontent.com/u/5276126?v=3","gravatar_id":"","url":"https://api.github.com/users/fuzun","html_url":"https://github.com/fuzun","followers_url":"https://api.github.com/users/fuzun/followers","following_url":"https://api.github.com/users/fuzun/following{/other_user}","gists_url":"https://api.github.com/users/fuzun/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzun/subscriptions","organizations_url":"https://api.github.com/users/fuzun/orgs","repos_url":"https://api.github.com/users/fuzun/repos","events_url":"https://api.github.com/users/fuzun/events{/privacy}","received_events_url":"https://api.github.com/users/fuzun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-17T19:07:40Z","updated_at":"2016-05-18T15:04:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/pulls/3","html_url":"https://github.com/SDLash3D/hlsdk-xash3d/pull/3","diff_url":"https://github.com/SDLash3D/hlsdk-xash3d/pull/3.diff","patch_url":"https://github.com/SDLash3D/hlsdk-xash3d/pull/3.patch"},"body":"First of all, I tried to not modify anything that did not give a warning or an error. I did not do anything that could break compatibility.\r\n-\r\nThis port contains portions from \"hlsdk23 msvc2008 port by\r\nGary_McTaggart\" so first, these are the changes that came with that\r\nproject:\r\n\r\n- Original VC6 DSPs removed.\r\n- 'ARRAYSIZE' macro in 'engine\\eiface.h' undefines a macro with the same\r\nname which defined in 'winnt.h'.\r\n- 'HSPRITE' type on the client renamed to 'SpriteHandle_t' due to\r\n'windef.h' which defined same-named type for itself.\r\n\r\nAnd these are the changes made to make this project compatible for VS2015:\r\n- VS2015 properly configured project files added. Release and debug\r\nfolders are located at main folder. (ReleaseHL, ReleaseCL)\r\n->xash.sln(root)\r\n-->'client' project\r\n-->'dlls' project\r\n- Full port to VS 2015.\r\n- Gitignore file fixed(typo) and adjusted.\r\n- vec3_origin renamed to vec3_origin_c in C files due to redefinition.\r\n(vec3_origin is not changed for c++ files. But note that vec3_origin_c\r\nis a typedef rather than a standard vector.)\r\n- Some line endings converted to LF from CR LF.\r\n- VGUI files moved to 'unused' because it VGUI support was broken\r\nalready. (xash port of sdk does not have all the files needed for vgui,\r\neven though dsp files have them.)\r\n- Some required casts added.\r\n- Partially adopted to C++11.\r\n- Tested for win32 and android. Both works.\r\n- debug.bat and release.bat removed because they are very old and\r\nprobably won't work after this commit."},"comment":{"url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/comments/220055579","html_url":"https://github.com/SDLash3D/hlsdk-xash3d/pull/3#issuecomment-220055579","issue_url":"https://api.github.com/repos/SDLash3D/hlsdk-xash3d/issues/3","id":220055579,"user":{"login":"fuzun","id":5276126,"avatar_url":"https://avatars.githubusercontent.com/u/5276126?v=3","gravatar_id":"","url":"https://api.github.com/users/fuzun","html_url":"https://github.com/fuzun","followers_url":"https://api.github.com/users/fuzun/followers","following_url":"https://api.github.com/users/fuzun/following{/other_user}","gists_url":"https://api.github.com/users/fuzun/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzun/subscriptions","organizations_url":"https://api.github.com/users/fuzun/orgs","repos_url":"https://api.github.com/users/fuzun/repos","events_url":"https://api.github.com/users/fuzun/events{/privacy}","received_events_url":"https://api.github.com/users/fuzun/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T15:04:27Z","updated_at":"2016-05-18T15:04:27Z","body":">Even if ARRAYSIZE have the same meaning, it's better to undefine it and define again.\r\nYeah it actually does that.\r\n>I don't see any point to remove it, but I also don't see why MSVC6 should be supported in our days. \r\nI removed it because of incompability concerns. Since a lot of stuff have been changed in order to make it compatible for modern compilers (This case it is msvc14) or removed so It might not be backwards compatible to MSVC6.\r\n\r\nNew commit:\r\n*Integrated @nekonomicon's pull request with these exclusions:\r\n->Uncommented \"TraceResult tr;\" because it is used and it gave an error\r\nwhen it was commented.\r\n->Some setthink() and setuse() parameters differ.\r\n->Did not change abs() to fabs macro in C++ files; instead, <cmath>\r\nused.\r\n*Line endings are now fixed to LF.\r\n*Tested for both win32 and android. There is no problem."}}