{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/50621758","id":50621758,"diff_hunk":"@@ -35,6 +35,8 @@ The default Logback configuration file is at `/etc/puppetserver/logback.xml` or\n \n Puppet Server relies on `logrotate` to manage the log file, and installs a configuration file at `/etc/logrotate.d/puppetserver` or `/etc/logrotate.d/pe-puppetserver`.\n \n+For some tips on advanced logging configuration, including information about configuring your system to send log data to logstash, see the [Advanced Logging Configuration](./config_logging_advanced.html) documentation.","path":"documentation/configuration.markdown","position":4,"original_position":4,"commit_id":"2aeb8cf884d9e1a26f423066de77254c60397f08","original_commit_id":"2aeb8cf884d9e1a26f423066de77254c60397f08","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"I agree that we could use more coverage of other logback features, and would love to see your branch get merged in wherever is appropriate.  One minor thing to keep in mind is that much of this documentation is relevant to all of the other Clojure projects as well, but we could at least start by getting it into the Puppet Server docs.  Your branch looks great, let us know how we can help.\r\n\r\nI will tweak the mention of logstash above to be a bit more general.","created_at":"2016-01-23T16:12:23Z","updated_at":"2016-01-23T16:12:23Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/874#discussion_r50621758","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/50621758"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/874#discussion_r50621758"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874","id":56932411,"html_url":"https://github.com/puppetlabs/puppet-server/pull/874","diff_url":"https://github.com/puppetlabs/puppet-server/pull/874.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/874.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/874","number":874,"state":"open","locked":false,"title":"(SERVER-1069) bundle logback json encoder","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"This PR adds a dependency on the logback logstash JSON encoder library, so that we will bundle it with our uberjar.  This allows users to opt-in to configuring their Puppet Server logs to write output in a JSON format that can be imported into logstash.\r\n\r\nThe PR also includes documentation with examples of how to configure Puppet Server's logging accordingly.\r\n\r\nWe were almost certainly going to end up with a dependency on this library in the future anyway, because it is a dependency of the structured logging library that PuppetDB is now using.","created_at":"2016-01-22T19:43:53Z","updated_at":"2016-01-23T16:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03dfe24069629385544b976205c24d4c61bd46f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/874/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/2aeb8cf884d9e1a26f423066de77254c60397f08","head":{"label":"cprice404:feature/master/SERVER-1069-bundle-logback-json-encoder","ref":"feature/master/SERVER-1069-bundle-logback-json-encoder","sha":"2aeb8cf884d9e1a26f423066de77254c60397f08","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"repo":{"id":24339614,"name":"puppet-server","full_name":"cprice404/puppet-server","owner":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cprice404/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/cprice404/puppet-server","forks_url":"https://api.github.com/repos/cprice404/puppet-server/forks","keys_url":"https://api.github.com/repos/cprice404/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cprice404/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cprice404/puppet-server/teams","hooks_url":"https://api.github.com/repos/cprice404/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/cprice404/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/cprice404/puppet-server/events","assignees_url":"https://api.github.com/repos/cprice404/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/cprice404/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/cprice404/puppet-server/tags","blobs_url":"https://api.github.com/repos/cprice404/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cprice404/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cprice404/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/cprice404/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cprice404/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/cprice404/puppet-server/languages","stargazers_url":"https://api.github.com/repos/cprice404/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/cprice404/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/cprice404/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/cprice404/puppet-server/subscription","commits_url":"https://api.github.com/repos/cprice404/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/cprice404/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/cprice404/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/cprice404/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/cprice404/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/cprice404/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cprice404/puppet-server/merges","archive_url":"https://api.github.com/repos/cprice404/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cprice404/puppet-server/downloads","issues_url":"https://api.github.com/repos/cprice404/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/cprice404/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/cprice404/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/cprice404/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cprice404/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/cprice404/puppet-server/releases{/id}","deployments_url":"https://api.github.com/repos/cprice404/puppet-server/deployments","created_at":"2014-09-22T18:11:20Z","updated_at":"2016-01-15T21:06:43Z","pushed_at":"2016-01-23T06:01:20Z","git_url":"git://github.com/cprice404/puppet-server.git","ssh_url":"git@github.com:cprice404/puppet-server.git","clone_url":"https://github.com/cprice404/puppet-server.git","svn_url":"https://github.com/cprice404/puppet-server","homepage":"","size":3222,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"516fbc1ba2282131a0aafad7917a35e598ee1891","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet-server/deployments","created_at":"2014-05-07T19:00:24Z","updated_at":"2016-01-21T02:00:05Z","pushed_at":"2016-01-23T06:04:09Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":5054,"stargazers_count":125,"watchers_count":125,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":6,"forks":80,"open_issues":6,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/874"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/874"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/2aeb8cf884d9e1a26f423066de77254c60397f08"}}}}