{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10503","repository_url":"https://api.github.com/repos/dimagi/commcare-hq","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10503/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10503/comments","events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10503/events","html_url":"https://github.com/dimagi/commcare-hq/pull/10503","id":136552396,"number":10503,"title":"make a bunch of app_manager js use hqDefine","user":{"login":"dannyroberts","id":137212,"avatar_url":"https://avatars.githubusercontent.com/u/137212?v=3","gravatar_id":"","url":"https://api.github.com/users/dannyroberts","html_url":"https://github.com/dannyroberts","followers_url":"https://api.github.com/users/dannyroberts/followers","following_url":"https://api.github.com/users/dannyroberts/following{/other_user}","gists_url":"https://api.github.com/users/dannyroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyroberts/subscriptions","organizations_url":"https://api.github.com/users/dannyroberts/orgs","repos_url":"https://api.github.com/users/dannyroberts/repos","events_url":"https://api.github.com/users/dannyroberts/events{/privacy}","received_events_url":"https://api.github.com/users/dannyroberts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-26T00:04:24Z","updated_at":"2016-03-08T12:17:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10503","html_url":"https://github.com/dimagi/commcare-hq/pull/10503","diff_url":"https://github.com/dimagi/commcare-hq/pull/10503.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/10503.patch"},"body":"You'll definitely want to review this ignoring whitespace (https://github.com/dimagi/commcare-hq/pull/10503/files?w=1)"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments/193761106","html_url":"https://github.com/dimagi/commcare-hq/pull/10503#issuecomment-193761106","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10503","id":193761106,"user":{"login":"dimagimon","id":1179034,"avatar_url":"https://avatars.githubusercontent.com/u/1179034?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagimon","html_url":"https://github.com/dimagimon","followers_url":"https://api.github.com/users/dimagimon/followers","following_url":"https://api.github.com/users/dimagimon/following{/other_user}","gists_url":"https://api.github.com/users/dimagimon/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagimon/subscriptions","organizations_url":"https://api.github.com/users/dimagimon/orgs","repos_url":"https://api.github.com/users/dimagimon/repos","events_url":"https://api.github.com/users/dimagimon/events{/privacy}","received_events_url":"https://api.github.com/users/dimagimon/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T12:17:28Z","updated_at":"2016-03-08T12:17:28Z","body":"There are 14 errors:\n\n* corehq/apps/app_manager/static/app_manager/js/case-knockout-bindings.js, line 17 - 'MAXLEN' is already defined.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 45 - Don't make functions within a loop.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 47 - Unnecessary semicolon.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 100 - Missing semicolon.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 165 - Missing semicolon.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 166 - Missing semicolon.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 183 - Use '!==' to compare with 'null'.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 261 - Don't make functions within a loop.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 339 - Missing semicolon.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 384 - Confusing use of '!'.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 399 - ['values'] is better written in dot notation.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 400 - ['value_names'] is better written in dot notation.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 410 - ['hq'] is better written in dot notation.\n* corehq/apps/app_manager/static/app_manager/js/commcaresettings.js, line 410 - ['application_version'] is better written in dot notation.\n"}}