{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/87821667","pull_request_review_id":8416148,"id":87821667,"diff_hunk":"@@ -28,13 +28,13 @@\n namespace Google.Storage.V1.Snippets\n {\n     [Collection(nameof(StorageSnippetFixture))]\n-    public class SignedUrlUtilsSnippets\n+    public class UrlSignerSnippets\n     {\n         private readonly string credentialsFilePath = GetCredentialsFilePath();","path":"apis/Google.Storage.V1/Google.Storage.V1.Snippets/UrlSignerSnippets.cs","position":7,"original_position":7,"commit_id":"e800a78e9eaa6b734200c8bd0e66db85ed8660e9","original_commit_id":"e800a78e9eaa6b734200c8bd0e66db85ed8660e9","user":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"I'd make this variable a local variable in each method. That way we can still use that name, while keeping our naming conventions of an underscore prefix. Ditto the HttpClient.","created_at":"2016-11-14T15:24:34Z","updated_at":"2016-11-14T15:25:59Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531#discussion_r87821667","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/87821667"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531#discussion_r87821667"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531","id":93585260,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/531","number":531,"state":"open","locked":false,"title":"Changed static SignedUrlUrils to class with instance methods","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"body":"I was on the fence about whether to rename the Create methods to Sign or not, so I'll happily change it back if anyone prefers. Or change it to something else entirely if there's a better name.","created_at":"2016-11-14T15:19:08Z","updated_at":"2016-11-14T15:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17c9c061936244e97d22edf6a6d172945f8f478e","assignee":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/531/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/e800a78e9eaa6b734200c8bd0e66db85ed8660e9","head":{"label":"evildour:urlsigner","ref":"urlsigner","sha":"e800a78e9eaa6b734200c8bd0e66db85ed8660e9","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"repo":{"id":62015644,"name":"google-cloud-dotnet","full_name":"evildour/google-cloud-dotnet","owner":{"login":"evildour","id":4014815,"avatar_url":"https://avatars.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evildour/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/evildour/google-cloud-dotnet","forks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/deployments","created_at":"2016-06-27T01:02:10Z","updated_at":"2016-10-24T18:27:48Z","pushed_at":"2016-11-14T15:24:18Z","git_url":"git://github.com/evildour/google-cloud-dotnet.git","ssh_url":"git@github.com:evildour/google-cloud-dotnet.git","clone_url":"https://github.com/evildour/google-cloud-dotnet.git","svn_url":"https://github.com/evildour/google-cloud-dotnet","homepage":null,"size":9239,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"2fa3384b07bba42fb4d40218c881af6e27fb5656","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"google-cloud-dotnet","full_name":"GoogleCloudPlatform/google-cloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2016-11-13T02:07:04Z","pushed_at":"2016-11-14T15:24:19Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":12171,"stargazers_count":55,"watchers_count":55,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":58,"forks":25,"open_issues":58,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/531"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/531"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/531/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/531/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/e800a78e9eaa6b734200c8bd0e66db85ed8660e9"}}}}
{"actor":{"display_login":"jskeet"}}