{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/62432538","id":62432538,"diff_hunk":"@@ -548,8 +548,9 @@ LLConstant *IrAggr::getClassInfoInterfaces() {\n \n   // create and apply initializer\n   LLConstant *arr = LLConstantArray::get(array_type, constants);\n-  classInterfacesArray->setInitializer(arr);\n-  setLinkage(cd, classInterfacesArray);\n+  auto ciarr = getInterfaceArraySymbol();","path":"ir/irclass.cpp","position":6,"original_position":6,"commit_id":"c9a18bc5b1b54bba60e46e7f70568f778a95c171","original_commit_id":"ffe830d8b9376ee66b8d0b601ab290c58bb0ca2b","user":{"login":"JohanEngelen","id":10983051,"avatar_url":"https://avatars.githubusercontent.com/u/10983051?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanEngelen","html_url":"https://github.com/JohanEngelen","followers_url":"https://api.github.com/users/JohanEngelen/followers","following_url":"https://api.github.com/users/JohanEngelen/following{/other_user}","gists_url":"https://api.github.com/users/JohanEngelen/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanEngelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanEngelen/subscriptions","organizations_url":"https://api.github.com/users/JohanEngelen/orgs","repos_url":"https://api.github.com/users/JohanEngelen/repos","events_url":"https://api.github.com/users/JohanEngelen/events{/privacy}","received_events_url":"https://api.github.com/users/JohanEngelen/received_events","type":"User","site_admin":false},"body":"> Just calling a getter function and then using the initialized cached member is a bit strange\r\n\r\nYes, very :-)","created_at":"2016-05-08T14:16:12Z","updated_at":"2016-05-08T14:16:12Z","html_url":"https://github.com/ldc-developers/ldc/pull/1481#discussion_r62432538","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/62432538"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1481#discussion_r62432538"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481","id":69263359,"html_url":"https://github.com/ldc-developers/ldc/pull/1481","diff_url":"https://github.com/ldc-developers/ldc/pull/1481.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1481.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1481","number":1481,"state":"open","locked":false,"title":"fix issue #1473: ICE when implementing extern(C++) interfaces","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"body":"The vtbl still contained the class info entry for C++ interfaces.","created_at":"2016-05-08T08:02:28Z","updated_at":"2016-05-08T14:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf91d954ed450478fff2cd3a8414afdc8edc6237","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1481/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/c9a18bc5b1b54bba60e46e7f70568f778a95c171","head":{"label":"rainers:fix_cppinterface","ref":"fix_cppinterface","sha":"c9a18bc5b1b54bba60e46e7f70568f778a95c171","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"repo":{"id":44043472,"name":"ldc","full_name":"rainers/ldc","owner":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rainers/ldc","description":"The LLVM-based D compiler.","fork":true,"url":"https://api.github.com/repos/rainers/ldc","forks_url":"https://api.github.com/repos/rainers/ldc/forks","keys_url":"https://api.github.com/repos/rainers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainers/ldc/teams","hooks_url":"https://api.github.com/repos/rainers/ldc/hooks","issue_events_url":"https://api.github.com/repos/rainers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/rainers/ldc/events","assignees_url":"https://api.github.com/repos/rainers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/rainers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/rainers/ldc/tags","blobs_url":"https://api.github.com/repos/rainers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/rainers/ldc/languages","stargazers_url":"https://api.github.com/repos/rainers/ldc/stargazers","contributors_url":"https://api.github.com/repos/rainers/ldc/contributors","subscribers_url":"https://api.github.com/repos/rainers/ldc/subscribers","subscription_url":"https://api.github.com/repos/rainers/ldc/subscription","commits_url":"https://api.github.com/repos/rainers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/rainers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/rainers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainers/ldc/merges","archive_url":"https://api.github.com/repos/rainers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainers/ldc/downloads","issues_url":"https://api.github.com/repos/rainers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/rainers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/rainers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/rainers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/rainers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/rainers/ldc/deployments","created_at":"2015-10-11T07:40:53Z","updated_at":"2015-10-11T07:40:59Z","pushed_at":"2016-05-08T13:34:00Z","git_url":"git://github.com/rainers/ldc.git","ssh_url":"git@github.com:rainers/ldc.git","clone_url":"https://github.com/rainers/ldc.git","svn_url":"https://github.com/rainers/ldc","homepage":"http://wiki.dlang.org/LDC","size":24177,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"070f81de1db55e3180b6f4bf909cf1592a3d15e1","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-05-08T11:35:09Z","pushed_at":"2016-05-08T14:12:46Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":28292,"stargazers_count":449,"watchers_count":449,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":93,"mirror_url":null,"open_issues_count":182,"forks":93,"open_issues":182,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1481"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1481"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1481/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1481/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/c9a18bc5b1b54bba60e46e7f70568f778a95c171"}}}}