{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/comments/81268913","pull_request_review_id":2260828,"id":81268913,"diff_hunk":"@@ -90,7 +91,7 @@ private void assertCommandBehavior(String inputCommand,\n         //Confirm the state of data is as expected\n         assertEquals(expectedAddressBook, addressBook);\n         assertEquals(lastShownList, logic.getLastShownList());\n-        assertEquals(addressBook, saveFile.load());\n+        assertEquals(addressBook, stubSaveFile.load());","path":"test/java/seedu/addressbook/logic/LogicTest.java","position":34,"original_position":34,"commit_id":"4ad3a75455b4ab719cd2e09d3fc1b44d755359e5","original_commit_id":"4ad3a75455b4ab719cd2e09d3fc1b44d755359e5","user":{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars.githubusercontent.com/u/1023494?v=3","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},"body":"you will notice that the tests will fail with this.\r\nthe stub doesn't do any save, loading will only give null pointer (i think) and tests fail.\r\nthe best way to handle this is to remove this line here. \r\nif we need to test storage functionality, we need to write separate tests for those.\r\n","created_at":"2016-09-30T02:05:06Z","updated_at":"2016-09-30T02:05:10Z","html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740#discussion_r81268913","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/comments/81268913"},"html":{"href":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740#discussion_r81268913"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740","id":87066061,"html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740","diff_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740.diff","patch_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/740","number":740,"state":"open","locked":false,"title":"[T6A3][T13-C1] Hong Bangwu","user":{"login":"bangwu93","id":21193210,"avatar_url":"https://avatars.githubusercontent.com/u/21193210?v=3","gravatar_id":"","url":"https://api.github.com/users/bangwu93","html_url":"https://github.com/bangwu93","followers_url":"https://api.github.com/users/bangwu93/followers","following_url":"https://api.github.com/users/bangwu93/following{/other_user}","gists_url":"https://api.github.com/users/bangwu93/gists{/gist_id}","starred_url":"https://api.github.com/users/bangwu93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangwu93/subscriptions","organizations_url":"https://api.github.com/users/bangwu93/orgs","repos_url":"https://api.github.com/users/bangwu93/repos","events_url":"https://api.github.com/users/bangwu93/events{/privacy}","received_events_url":"https://api.github.com/users/bangwu93/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-28T07:15:34Z","updated_at":"2016-09-30T02:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3378945236773684ded4d386127c406c32dee177","assignee":{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars.githubusercontent.com/u/1023494?v=3","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},"assignees":[{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars.githubusercontent.com/u/1023494?v=3","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/740/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/statuses/4ad3a75455b4ab719cd2e09d3fc1b44d755359e5","head":{"label":"bangwu93:T6A3","ref":"T6A3","sha":"4ad3a75455b4ab719cd2e09d3fc1b44d755359e5","user":{"login":"bangwu93","id":21193210,"avatar_url":"https://avatars.githubusercontent.com/u/21193210?v=3","gravatar_id":"","url":"https://api.github.com/users/bangwu93","html_url":"https://github.com/bangwu93","followers_url":"https://api.github.com/users/bangwu93/followers","following_url":"https://api.github.com/users/bangwu93/following{/other_user}","gists_url":"https://api.github.com/users/bangwu93/gists{/gist_id}","starred_url":"https://api.github.com/users/bangwu93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangwu93/subscriptions","organizations_url":"https://api.github.com/users/bangwu93/orgs","repos_url":"https://api.github.com/users/bangwu93/repos","events_url":"https://api.github.com/users/bangwu93/events{/privacy}","received_events_url":"https://api.github.com/users/bangwu93/received_events","type":"User","site_admin":false},"repo":{"id":67785496,"name":"addressbook-level3","full_name":"bangwu93/addressbook-level3","owner":{"login":"bangwu93","id":21193210,"avatar_url":"https://avatars.githubusercontent.com/u/21193210?v=3","gravatar_id":"","url":"https://api.github.com/users/bangwu93","html_url":"https://github.com/bangwu93","followers_url":"https://api.github.com/users/bangwu93/followers","following_url":"https://api.github.com/users/bangwu93/following{/other_user}","gists_url":"https://api.github.com/users/bangwu93/gists{/gist_id}","starred_url":"https://api.github.com/users/bangwu93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangwu93/subscriptions","organizations_url":"https://api.github.com/users/bangwu93/orgs","repos_url":"https://api.github.com/users/bangwu93/repos","events_url":"https://api.github.com/users/bangwu93/events{/privacy}","received_events_url":"https://api.github.com/users/bangwu93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bangwu93/addressbook-level3","description":"Address Book sample application (Level 3)","fork":true,"url":"https://api.github.com/repos/bangwu93/addressbook-level3","forks_url":"https://api.github.com/repos/bangwu93/addressbook-level3/forks","keys_url":"https://api.github.com/repos/bangwu93/addressbook-level3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bangwu93/addressbook-level3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bangwu93/addressbook-level3/teams","hooks_url":"https://api.github.com/repos/bangwu93/addressbook-level3/hooks","issue_events_url":"https://api.github.com/repos/bangwu93/addressbook-level3/issues/events{/number}","events_url":"https://api.github.com/repos/bangwu93/addressbook-level3/events","assignees_url":"https://api.github.com/repos/bangwu93/addressbook-level3/assignees{/user}","branches_url":"https://api.github.com/repos/bangwu93/addressbook-level3/branches{/branch}","tags_url":"https://api.github.com/repos/bangwu93/addressbook-level3/tags","blobs_url":"https://api.github.com/repos/bangwu93/addressbook-level3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bangwu93/addressbook-level3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bangwu93/addressbook-level3/git/refs{/sha}","trees_url":"https://api.github.com/repos/bangwu93/addressbook-level3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bangwu93/addressbook-level3/statuses/{sha}","languages_url":"https://api.github.com/repos/bangwu93/addressbook-level3/languages","stargazers_url":"https://api.github.com/repos/bangwu93/addressbook-level3/stargazers","contributors_url":"https://api.github.com/repos/bangwu93/addressbook-level3/contributors","subscribers_url":"https://api.github.com/repos/bangwu93/addressbook-level3/subscribers","subscription_url":"https://api.github.com/repos/bangwu93/addressbook-level3/subscription","commits_url":"https://api.github.com/repos/bangwu93/addressbook-level3/commits{/sha}","git_commits_url":"https://api.github.com/repos/bangwu93/addressbook-level3/git/commits{/sha}","comments_url":"https://api.github.com/repos/bangwu93/addressbook-level3/comments{/number}","issue_comment_url":"https://api.github.com/repos/bangwu93/addressbook-level3/issues/comments{/number}","contents_url":"https://api.github.com/repos/bangwu93/addressbook-level3/contents/{+path}","compare_url":"https://api.github.com/repos/bangwu93/addressbook-level3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bangwu93/addressbook-level3/merges","archive_url":"https://api.github.com/repos/bangwu93/addressbook-level3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bangwu93/addressbook-level3/downloads","issues_url":"https://api.github.com/repos/bangwu93/addressbook-level3/issues{/number}","pulls_url":"https://api.github.com/repos/bangwu93/addressbook-level3/pulls{/number}","milestones_url":"https://api.github.com/repos/bangwu93/addressbook-level3/milestones{/number}","notifications_url":"https://api.github.com/repos/bangwu93/addressbook-level3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bangwu93/addressbook-level3/labels{/name}","releases_url":"https://api.github.com/repos/bangwu93/addressbook-level3/releases{/id}","deployments_url":"https://api.github.com/repos/bangwu93/addressbook-level3/deployments","created_at":"2016-09-09T09:24:07Z","updated_at":"2016-09-09T09:24:08Z","pushed_at":"2016-09-28T07:13:00Z","git_url":"git://github.com/bangwu93/addressbook-level3.git","ssh_url":"git@github.com:bangwu93/addressbook-level3.git","clone_url":"https://github.com/bangwu93/addressbook-level3.git","svn_url":"https://github.com/bangwu93/addressbook-level3","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1617S1:master","ref":"master","sha":"6f0fc26ed700c94cb47ccbc35d8e2adc678ace57","user":{"login":"nus-cs2103-AY1617S1","id":20475842,"avatar_url":"https://avatars.githubusercontent.com/u/20475842?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S1","html_url":"https://github.com/nus-cs2103-AY1617S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/received_events","type":"Organization","site_admin":false},"repo":{"id":67619169,"name":"addressbook-level3","full_name":"nus-cs2103-AY1617S1/addressbook-level3","owner":{"login":"nus-cs2103-AY1617S1","id":20475842,"avatar_url":"https://avatars.githubusercontent.com/u/20475842?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S1","html_url":"https://github.com/nus-cs2103-AY1617S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3","description":"Address Book sample application (Level 3)","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3","forks_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/deployments","created_at":"2016-09-07T15:22:23Z","updated_at":"2016-09-17T01:26:01Z","pushed_at":"2016-09-30T02:01:38Z","git_url":"git://github.com/nus-cs2103-AY1617S1/addressbook-level3.git","ssh_url":"git@github.com:nus-cs2103-AY1617S1/addressbook-level3.git","clone_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3.git","svn_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3","homepage":null,"size":16610,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":334,"forks":311,"open_issues":334,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740"},"html":{"href":"https://github.com/nus-cs2103-AY1617S1/addressbook-level3/pull/740"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/740"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/issues/740/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/pulls/740/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level3/statuses/4ad3a75455b4ab719cd2e09d3fc1b44d755359e5"}}}}
{"actor":{"display_login":"okkhoy"}}