{"action":"created","comment":{"url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/comments/67861629","id":67861629,"diff_hunk":"@@ -256,7 +259,19 @@ void vtkMRMLSequenceNode::SetDataNodeAtValue(vtkMRMLNode* node, const char* inde\n     return;\n   }\n \n+  std::string newNodeName = this->SequenceScene->GetUniqueNameByString( node->GetName() );\n   vtkMRMLNode* newNode=this->SequenceScene->CopyNode(node);\n+  newNode->SetName( newNodeName.c_str() ); // Make sure all the node names in the sequence's scene are unique for saving purposes\n+  \n+  // Hack to enforce deep copying of volumes (otherwise, a separate image data is not stored for each frame)\n+  // TODO: Is there a better way to architecture this?\n+  vtkMRMLVolumeNode* volNode = vtkMRMLVolumeNode::SafeDownCast(newNode);\n+  if (volNode!=NULL)\n+  {\n+    vtkImageData* imageDataCopy = vtkImageData::New();","path":"Sequences/MRML/vtkMRMLSequenceNode.cxx","position":28,"original_position":28,"commit_id":"61da1241ab7159d79b9c387b34ba82cb1c50fa77","original_commit_id":"61da1241ab7159d79b9c387b34ba82cb1c50fa77","user":{"login":"mholden8","id":3238050,"avatar_url":"https://avatars.githubusercontent.com/u/3238050?v=3","gravatar_id":"","url":"https://api.github.com/users/mholden8","html_url":"https://github.com/mholden8","followers_url":"https://api.github.com/users/mholden8/followers","following_url":"https://api.github.com/users/mholden8/following{/other_user}","gists_url":"https://api.github.com/users/mholden8/gists{/gist_id}","starred_url":"https://api.github.com/users/mholden8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholden8/subscriptions","organizations_url":"https://api.github.com/users/mholden8/orgs","repos_url":"https://api.github.com/users/mholden8/repos","events_url":"https://api.github.com/users/mholden8/events{/privacy}","received_events_url":"https://api.github.com/users/mholden8/received_events","type":"User","site_admin":false},"body":"Thanks for the input, I see now that the line as is currently will cause a memory leak, but I don't entirely follow your solution. The sequence node's ```Copy``` function doesn't seem to be used here.","created_at":"2016-06-21T12:53:43Z","updated_at":"2016-06-21T12:53:43Z","html_url":"https://github.com/SlicerRt/Sequences/pull/16#discussion_r67861629","pull_request_url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/comments/67861629"},"html":{"href":"https://github.com/SlicerRt/Sequences/pull/16#discussion_r67861629"},"pull_request":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16","id":74020685,"html_url":"https://github.com/SlicerRt/Sequences/pull/16","diff_url":"https://github.com/SlicerRt/Sequences/pull/16.diff","patch_url":"https://github.com/SlicerRt/Sequences/pull/16.patch","issue_url":"https://api.github.com/repos/SlicerRt/Sequences/issues/16","number":16,"state":"open","locked":false,"title":"Added functionality to record sequences of nodes from the sequence browser module.","user":{"login":"mholden8","id":3238050,"avatar_url":"https://avatars.githubusercontent.com/u/3238050?v=3","gravatar_id":"","url":"https://api.github.com/users/mholden8","html_url":"https://github.com/mholden8","followers_url":"https://api.github.com/users/mholden8/followers","following_url":"https://api.github.com/users/mholden8/following{/other_user}","gists_url":"https://api.github.com/users/mholden8/gists{/gist_id}","starred_url":"https://api.github.com/users/mholden8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholden8/subscriptions","organizations_url":"https://api.github.com/users/mholden8/orgs","repos_url":"https://api.github.com/users/mholden8/repos","events_url":"https://api.github.com/users/mholden8/events{/privacy}","received_events_url":"https://api.github.com/users/mholden8/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-16T04:27:36Z","updated_at":"2016-06-21T12:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ce0528b6b8f5d004d18b20f31c14c98a4d5dc7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SlicerRt/Sequences/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SlicerRt/Sequences/issues/16/comments","statuses_url":"https://api.github.com/repos/SlicerRt/Sequences/statuses/61da1241ab7159d79b9c387b34ba82cb1c50fa77","head":{"label":"mholden8:master","ref":"master","sha":"61da1241ab7159d79b9c387b34ba82cb1c50fa77","user":{"login":"mholden8","id":3238050,"avatar_url":"https://avatars.githubusercontent.com/u/3238050?v=3","gravatar_id":"","url":"https://api.github.com/users/mholden8","html_url":"https://github.com/mholden8","followers_url":"https://api.github.com/users/mholden8/followers","following_url":"https://api.github.com/users/mholden8/following{/other_user}","gists_url":"https://api.github.com/users/mholden8/gists{/gist_id}","starred_url":"https://api.github.com/users/mholden8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholden8/subscriptions","organizations_url":"https://api.github.com/users/mholden8/orgs","repos_url":"https://api.github.com/users/mholden8/repos","events_url":"https://api.github.com/users/mholden8/events{/privacy}","received_events_url":"https://api.github.com/users/mholden8/received_events","type":"User","site_admin":false},"repo":{"id":57314777,"name":"Sequences","full_name":"mholden8/Sequences","owner":{"login":"mholden8","id":3238050,"avatar_url":"https://avatars.githubusercontent.com/u/3238050?v=3","gravatar_id":"","url":"https://api.github.com/users/mholden8","html_url":"https://github.com/mholden8","followers_url":"https://api.github.com/users/mholden8/followers","following_url":"https://api.github.com/users/mholden8/following{/other_user}","gists_url":"https://api.github.com/users/mholden8/gists{/gist_id}","starred_url":"https://api.github.com/users/mholden8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholden8/subscriptions","organizations_url":"https://api.github.com/users/mholden8/orgs","repos_url":"https://api.github.com/users/mholden8/repos","events_url":"https://api.github.com/users/mholden8/events{/privacy}","received_events_url":"https://api.github.com/users/mholden8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mholden8/Sequences","description":"Repository to host Sequences (formerly MultidimData) extension","fork":true,"url":"https://api.github.com/repos/mholden8/Sequences","forks_url":"https://api.github.com/repos/mholden8/Sequences/forks","keys_url":"https://api.github.com/repos/mholden8/Sequences/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholden8/Sequences/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholden8/Sequences/teams","hooks_url":"https://api.github.com/repos/mholden8/Sequences/hooks","issue_events_url":"https://api.github.com/repos/mholden8/Sequences/issues/events{/number}","events_url":"https://api.github.com/repos/mholden8/Sequences/events","assignees_url":"https://api.github.com/repos/mholden8/Sequences/assignees{/user}","branches_url":"https://api.github.com/repos/mholden8/Sequences/branches{/branch}","tags_url":"https://api.github.com/repos/mholden8/Sequences/tags","blobs_url":"https://api.github.com/repos/mholden8/Sequences/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholden8/Sequences/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholden8/Sequences/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholden8/Sequences/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholden8/Sequences/statuses/{sha}","languages_url":"https://api.github.com/repos/mholden8/Sequences/languages","stargazers_url":"https://api.github.com/repos/mholden8/Sequences/stargazers","contributors_url":"https://api.github.com/repos/mholden8/Sequences/contributors","subscribers_url":"https://api.github.com/repos/mholden8/Sequences/subscribers","subscription_url":"https://api.github.com/repos/mholden8/Sequences/subscription","commits_url":"https://api.github.com/repos/mholden8/Sequences/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholden8/Sequences/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholden8/Sequences/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholden8/Sequences/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholden8/Sequences/contents/{+path}","compare_url":"https://api.github.com/repos/mholden8/Sequences/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholden8/Sequences/merges","archive_url":"https://api.github.com/repos/mholden8/Sequences/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholden8/Sequences/downloads","issues_url":"https://api.github.com/repos/mholden8/Sequences/issues{/number}","pulls_url":"https://api.github.com/repos/mholden8/Sequences/pulls{/number}","milestones_url":"https://api.github.com/repos/mholden8/Sequences/milestones{/number}","notifications_url":"https://api.github.com/repos/mholden8/Sequences/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholden8/Sequences/labels{/name}","releases_url":"https://api.github.com/repos/mholden8/Sequences/releases{/id}","deployments_url":"https://api.github.com/repos/mholden8/Sequences/deployments","created_at":"2016-04-28T15:57:48Z","updated_at":"2016-04-28T15:57:49Z","pushed_at":"2016-06-16T04:24:00Z","git_url":"git://github.com/mholden8/Sequences.git","ssh_url":"git@github.com:mholden8/Sequences.git","clone_url":"https://github.com/mholden8/Sequences.git","svn_url":"https://github.com/mholden8/Sequences","homepage":null,"size":2807,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SlicerRt:master","ref":"master","sha":"d0206c3800755d34a8b732dd0f1123fff575c2ad","user":{"login":"SlicerRt","id":1325988,"avatar_url":"https://avatars.githubusercontent.com/u/1325988?v=3","gravatar_id":"","url":"https://api.github.com/users/SlicerRt","html_url":"https://github.com/SlicerRt","followers_url":"https://api.github.com/users/SlicerRt/followers","following_url":"https://api.github.com/users/SlicerRt/following{/other_user}","gists_url":"https://api.github.com/users/SlicerRt/gists{/gist_id}","starred_url":"https://api.github.com/users/SlicerRt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlicerRt/subscriptions","organizations_url":"https://api.github.com/users/SlicerRt/orgs","repos_url":"https://api.github.com/users/SlicerRt/repos","events_url":"https://api.github.com/users/SlicerRt/events{/privacy}","received_events_url":"https://api.github.com/users/SlicerRt/received_events","type":"Organization","site_admin":false},"repo":{"id":32884067,"name":"Sequences","full_name":"SlicerRt/Sequences","owner":{"login":"SlicerRt","id":1325988,"avatar_url":"https://avatars.githubusercontent.com/u/1325988?v=3","gravatar_id":"","url":"https://api.github.com/users/SlicerRt","html_url":"https://github.com/SlicerRt","followers_url":"https://api.github.com/users/SlicerRt/followers","following_url":"https://api.github.com/users/SlicerRt/following{/other_user}","gists_url":"https://api.github.com/users/SlicerRt/gists{/gist_id}","starred_url":"https://api.github.com/users/SlicerRt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlicerRt/subscriptions","organizations_url":"https://api.github.com/users/SlicerRt/orgs","repos_url":"https://api.github.com/users/SlicerRt/repos","events_url":"https://api.github.com/users/SlicerRt/events{/privacy}","received_events_url":"https://api.github.com/users/SlicerRt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SlicerRt/Sequences","description":"Repository to host Sequences (formerly MultidimData) extension","fork":false,"url":"https://api.github.com/repos/SlicerRt/Sequences","forks_url":"https://api.github.com/repos/SlicerRt/Sequences/forks","keys_url":"https://api.github.com/repos/SlicerRt/Sequences/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlicerRt/Sequences/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlicerRt/Sequences/teams","hooks_url":"https://api.github.com/repos/SlicerRt/Sequences/hooks","issue_events_url":"https://api.github.com/repos/SlicerRt/Sequences/issues/events{/number}","events_url":"https://api.github.com/repos/SlicerRt/Sequences/events","assignees_url":"https://api.github.com/repos/SlicerRt/Sequences/assignees{/user}","branches_url":"https://api.github.com/repos/SlicerRt/Sequences/branches{/branch}","tags_url":"https://api.github.com/repos/SlicerRt/Sequences/tags","blobs_url":"https://api.github.com/repos/SlicerRt/Sequences/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlicerRt/Sequences/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlicerRt/Sequences/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlicerRt/Sequences/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlicerRt/Sequences/statuses/{sha}","languages_url":"https://api.github.com/repos/SlicerRt/Sequences/languages","stargazers_url":"https://api.github.com/repos/SlicerRt/Sequences/stargazers","contributors_url":"https://api.github.com/repos/SlicerRt/Sequences/contributors","subscribers_url":"https://api.github.com/repos/SlicerRt/Sequences/subscribers","subscription_url":"https://api.github.com/repos/SlicerRt/Sequences/subscription","commits_url":"https://api.github.com/repos/SlicerRt/Sequences/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlicerRt/Sequences/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlicerRt/Sequences/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlicerRt/Sequences/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlicerRt/Sequences/contents/{+path}","compare_url":"https://api.github.com/repos/SlicerRt/Sequences/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlicerRt/Sequences/merges","archive_url":"https://api.github.com/repos/SlicerRt/Sequences/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlicerRt/Sequences/downloads","issues_url":"https://api.github.com/repos/SlicerRt/Sequences/issues{/number}","pulls_url":"https://api.github.com/repos/SlicerRt/Sequences/pulls{/number}","milestones_url":"https://api.github.com/repos/SlicerRt/Sequences/milestones{/number}","notifications_url":"https://api.github.com/repos/SlicerRt/Sequences/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlicerRt/Sequences/labels{/name}","releases_url":"https://api.github.com/repos/SlicerRt/Sequences/releases{/id}","deployments_url":"https://api.github.com/repos/SlicerRt/Sequences/deployments","created_at":"2015-03-25T18:45:53Z","updated_at":"2016-01-12T18:08:17Z","pushed_at":"2016-06-16T04:27:37Z","git_url":"git://github.com/SlicerRt/Sequences.git","ssh_url":"git@github.com:SlicerRt/Sequences.git","clone_url":"https://github.com/SlicerRt/Sequences.git","svn_url":"https://github.com/SlicerRt/Sequences","homepage":null,"size":2759,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16"},"html":{"href":"https://github.com/SlicerRt/Sequences/pull/16"},"issue":{"href":"https://api.github.com/repos/SlicerRt/Sequences/issues/16"},"comments":{"href":"https://api.github.com/repos/SlicerRt/Sequences/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SlicerRt/Sequences/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SlicerRt/Sequences/statuses/61da1241ab7159d79b9c387b34ba82cb1c50fa77"}}}}
{"actor":{"display_login":"mholden8"}}