{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/build/issues/304","labels_url":"https://api.github.com/repos/nodejs/build/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/build/issues/304/comments","events_url":"https://api.github.com/repos/nodejs/build/issues/304/events","html_url":"https://github.com/nodejs/build/issues/304","id":126741634,"number":304,"title":"V8 4.9 and trace_event DEPS change","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-14T20:29:06Z","updated_at":"2016-01-19T19:04:07Z","closed_at":"2016-01-19T17:43:46Z","body":"Hello Build WG Members:\r\n\r\nV8 4.9 introduces a new source dependency that embedders are going to need to be able to build V8. Specifically: https://github.com/v8/v8/blob/5312bfb9f3ecd09ebabd848dbf661e7326c84ef9/DEPS#L16\r\n\r\nBasically, the directory v8/base/trace_event/common is supposed to be fetched from the external repository (https://chromium.googlesource.com/chromium/src/base/trace_event/common.git) as a pre-requisite in order to be able to build V8.\r\n\r\nSince we (Node.js) don't use `depot_tools` and instead have a copy of V8 checked into our repository, we'll need some changes to ensure we can build and update V8 smoothly going forward.\r\n\r\nHere are some of the options I can think of:\r\n\r\n1. Delete (or edit) deps/v8/.gitignore in our repo and include copy of base/trace_event/common into the copy of V8 in our repository. This is simplest for the short term but requires overhead going forward when V8 or trace_event is updated.\r\n\r\n2. Track base/trace_event/common as a direct dependency of Node.js. I.e. create a deps/trace-event-common directory with a copy of https://chromium.googlesource.com/chromium/src/base/trace_event/common.git. At build time we will have to copy / symlink this into the deps/v8/base/trace_event/common directory to allow V8 to be built.\r\n\r\n3. Start using the v8 DEPS file directly and fetching all the dependencies as a step in the build process. This might be a more future proof solution.\r\n\r\nIdeas/thoughts/comments?\r\n\r\n/cc @nodejs/v8 @jeisinger\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/build/issues/comments/172953135","html_url":"https://github.com/nodejs/build/issues/304#issuecomment-172953135","issue_url":"https://api.github.com/repos/nodejs/build/issues/304","id":172953135,"user":{"login":"jbergstroem","id":176984,"avatar_url":"https://avatars.githubusercontent.com/u/176984?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergstroem","html_url":"https://github.com/jbergstroem","followers_url":"https://api.github.com/users/jbergstroem/followers","following_url":"https://api.github.com/users/jbergstroem/following{/other_user}","gists_url":"https://api.github.com/users/jbergstroem/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergstroem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergstroem/subscriptions","organizations_url":"https://api.github.com/users/jbergstroem/orgs","repos_url":"https://api.github.com/users/jbergstroem/repos","events_url":"https://api.github.com/users/jbergstroem/events{/privacy}","received_events_url":"https://api.github.com/users/jbergstroem/received_events","type":"User","site_admin":false},"created_at":"2016-01-19T19:04:07Z","updated_at":"2016-01-19T19:04:07Z","body":"How about we create a repo with update procedures, floating patches and above script and whatnot to make bumping v8 more public? I still believe there must be some kind of scripting that should apply for most bumps -- especially minors. Also, last time I bumped a minor I didn't reapply floating patches, rather diff v8 trees and land commits on top. Perhaps thats not standard procedure but it was trivial to do."}}