{"action":"closed","number":23850,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/23850","id":74764929,"html_url":"https://github.com/docker/docker/pull/23850","diff_url":"https://github.com/docker/docker/pull/23850.diff","patch_url":"https://github.com/docker/docker/pull/23850.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/23850","number":23850,"state":"closed","locked":false,"title":"Load environment files to systemd service and utilize DOCKER_OPTS for backward compatibility while upgrading docker on long lived systems","user":{"login":"cardil","id":540893,"avatar_url":"https://avatars.githubusercontent.com/u/540893?v=3","gravatar_id":"","url":"https://api.github.com/users/cardil","html_url":"https://github.com/cardil","followers_url":"https://api.github.com/users/cardil/followers","following_url":"https://api.github.com/users/cardil/following{/other_user}","gists_url":"https://api.github.com/users/cardil/gists{/gist_id}","starred_url":"https://api.github.com/users/cardil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cardil/subscriptions","organizations_url":"https://api.github.com/users/cardil/orgs","repos_url":"https://api.github.com/users/cardil/repos","events_url":"https://api.github.com/users/cardil/events{/privacy}","received_events_url":"https://api.github.com/users/cardil/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\n\r\nI have added optional reading of Debian and RHEL system default configuration files. I did that to ensure backward compatibility while upgrading Docker/OSs.\r\n\r\n**- How I did it**\r\n\r\nI have added `EnvironmentFile` for `/etc/default/docker` and `/etc/sysconfig/docker` files. I've also utilized `$DOCKER_OPTS` and `$other_args` variables in docker daemon command. In this way those opts will be read on systems that are long lived (especially production docker hosts).\r\n\r\n**- How to verify it**\r\n\r\nThe changes refer to configuration files, so I think only VM test can verify this.\r\n\r\n**- Description for the changelog**\r\n\r\n* Load environment files to systemd service and utilize DOCKER_OPTS\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n![Cute whale](http://data.whicdn.com/images/112100631/large.jpg)\r\n\r\nSigned-off-by: Suszyński Krzysztof <krzysztof.suszynski@coi.gov.pl>","created_at":"2016-06-22T11:09:00Z","updated_at":"2016-06-28T07:05:11Z","closed_at":"2016-06-28T07:05:11Z","merged_at":null,"merge_commit_sha":"6444b6b85ee2e0d5d62c902645516bbffb0f916b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/23850/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/23850/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/23850/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a31ac4562a9b359821a35f828861d2e7b35fff6e","head":{"label":"coi-gov-pl:bugfix/loading-environment-files-for-systemd","ref":"bugfix/loading-environment-files-for-systemd","sha":"a31ac4562a9b359821a35f828861d2e7b35fff6e","user":{"login":"coi-gov-pl","id":7711115,"avatar_url":"https://avatars.githubusercontent.com/u/7711115?v=3","gravatar_id":"","url":"https://api.github.com/users/coi-gov-pl","html_url":"https://github.com/coi-gov-pl","followers_url":"https://api.github.com/users/coi-gov-pl/followers","following_url":"https://api.github.com/users/coi-gov-pl/following{/other_user}","gists_url":"https://api.github.com/users/coi-gov-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/coi-gov-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coi-gov-pl/subscriptions","organizations_url":"https://api.github.com/users/coi-gov-pl/orgs","repos_url":"https://api.github.com/users/coi-gov-pl/repos","events_url":"https://api.github.com/users/coi-gov-pl/events{/privacy}","received_events_url":"https://api.github.com/users/coi-gov-pl/received_events","type":"Organization","site_admin":false},"repo":{"id":61709375,"name":"docker","full_name":"coi-gov-pl/docker","owner":{"login":"coi-gov-pl","id":7711115,"avatar_url":"https://avatars.githubusercontent.com/u/7711115?v=3","gravatar_id":"","url":"https://api.github.com/users/coi-gov-pl","html_url":"https://github.com/coi-gov-pl","followers_url":"https://api.github.com/users/coi-gov-pl/followers","following_url":"https://api.github.com/users/coi-gov-pl/following{/other_user}","gists_url":"https://api.github.com/users/coi-gov-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/coi-gov-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coi-gov-pl/subscriptions","organizations_url":"https://api.github.com/users/coi-gov-pl/orgs","repos_url":"https://api.github.com/users/coi-gov-pl/repos","events_url":"https://api.github.com/users/coi-gov-pl/events{/privacy}","received_events_url":"https://api.github.com/users/coi-gov-pl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coi-gov-pl/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/coi-gov-pl/docker","forks_url":"https://api.github.com/repos/coi-gov-pl/docker/forks","keys_url":"https://api.github.com/repos/coi-gov-pl/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coi-gov-pl/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coi-gov-pl/docker/teams","hooks_url":"https://api.github.com/repos/coi-gov-pl/docker/hooks","issue_events_url":"https://api.github.com/repos/coi-gov-pl/docker/issues/events{/number}","events_url":"https://api.github.com/repos/coi-gov-pl/docker/events","assignees_url":"https://api.github.com/repos/coi-gov-pl/docker/assignees{/user}","branches_url":"https://api.github.com/repos/coi-gov-pl/docker/branches{/branch}","tags_url":"https://api.github.com/repos/coi-gov-pl/docker/tags","blobs_url":"https://api.github.com/repos/coi-gov-pl/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coi-gov-pl/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coi-gov-pl/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/coi-gov-pl/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coi-gov-pl/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/coi-gov-pl/docker/languages","stargazers_url":"https://api.github.com/repos/coi-gov-pl/docker/stargazers","contributors_url":"https://api.github.com/repos/coi-gov-pl/docker/contributors","subscribers_url":"https://api.github.com/repos/coi-gov-pl/docker/subscribers","subscription_url":"https://api.github.com/repos/coi-gov-pl/docker/subscription","commits_url":"https://api.github.com/repos/coi-gov-pl/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/coi-gov-pl/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/coi-gov-pl/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/coi-gov-pl/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/coi-gov-pl/docker/contents/{+path}","compare_url":"https://api.github.com/repos/coi-gov-pl/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coi-gov-pl/docker/merges","archive_url":"https://api.github.com/repos/coi-gov-pl/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coi-gov-pl/docker/downloads","issues_url":"https://api.github.com/repos/coi-gov-pl/docker/issues{/number}","pulls_url":"https://api.github.com/repos/coi-gov-pl/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/coi-gov-pl/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/coi-gov-pl/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coi-gov-pl/docker/labels{/name}","releases_url":"https://api.github.com/repos/coi-gov-pl/docker/releases{/id}","deployments_url":"https://api.github.com/repos/coi-gov-pl/docker/deployments","created_at":"2016-06-22T10:10:54Z","updated_at":"2016-06-22T10:11:09Z","pushed_at":"2016-06-22T10:50:46Z","git_url":"git://github.com/coi-gov-pl/docker.git","ssh_url":"git@github.com:coi-gov-pl/docker.git","clone_url":"https://github.com/coi-gov-pl/docker.git","svn_url":"https://github.com/coi-gov-pl/docker","homepage":"http://www.docker.com","size":97347,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b2da02dc7e4695dbe42efe25fab0684f3b846b30","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-06-28T06:12:09Z","pushed_at":"2016-06-28T06:12:29Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":204826,"stargazers_count":32462,"watchers_count":32462,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9350,"mirror_url":null,"open_issues_count":1807,"forks":9350,"open_issues":1807,"watchers":32462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/23850"},"html":{"href":"https://github.com/docker/docker/pull/23850"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/23850"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/23850/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/23850/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/23850/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a31ac4562a9b359821a35f828861d2e7b35fff6e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"thaJeztah"}}