{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6602","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6602/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6602/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6602/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6602","id":144444114,"number":6602,"title":"[MRG] Refactored OneHotEncoder ","user":{"login":"vighneshbirodkar","id":3823490,"avatar_url":"https://avatars.githubusercontent.com/u/3823490?v=3","gravatar_id":"","url":"https://api.github.com/users/vighneshbirodkar","html_url":"https://github.com/vighneshbirodkar","followers_url":"https://api.github.com/users/vighneshbirodkar/followers","following_url":"https://api.github.com/users/vighneshbirodkar/following{/other_user}","gists_url":"https://api.github.com/users/vighneshbirodkar/gists{/gist_id}","starred_url":"https://api.github.com/users/vighneshbirodkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vighneshbirodkar/subscriptions","organizations_url":"https://api.github.com/users/vighneshbirodkar/orgs","repos_url":"https://api.github.com/users/vighneshbirodkar/repos","events_url":"https://api.github.com/users/vighneshbirodkar/events{/privacy}","received_events_url":"https://api.github.com/users/vighneshbirodkar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/18","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.18","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/18/labels","id":1314892,"number":18,"title":"0.18","description":"","creator":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":49,"state":"open","created_at":"2015-09-20T02:17:00Z","updated_at":"2016-08-31T23:51:03Z","due_on":"2016-02-29T08:00:00Z","closed_at":null},"comments":33,"created_at":"2016-03-30T02:35:22Z","updated_at":"2016-09-01T14:51:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6602","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6602","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6602.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6602.patch"},"body":"### New Features in `OneHotEncoder`\r\n* Support for strings, negative integers ( and anything that can be put in an object array )\r\n* Specify discrete values using the `classes` parameter instead of `n_values`.\r\n* Uses a `LabelEncoder` instance for each column.\r\n\r\n### Changes\r\n* Changes `_transform_selected` to `_apply_selected` giving it the ability to optionally not return transformed values.\r\n* `_apply_selected` can no longer accept lists. It has to be given a `np.array` object. This is done because the input can be of `np.object` type and it cannot be always cast as a whole to `np.int` or `np.float` type. The transformed and non-transformed parts of the array are converted to the specified type before returning.\r\n* Instead of raising an error only when the feature in a column goes outside the max value, this change enables raising an error when any previously unknown value is seen"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/244103928","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6602#issuecomment-244103928","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6602","id":244103928,"user":{"login":"vighneshbirodkar","id":3823490,"avatar_url":"https://avatars.githubusercontent.com/u/3823490?v=3","gravatar_id":"","url":"https://api.github.com/users/vighneshbirodkar","html_url":"https://github.com/vighneshbirodkar","followers_url":"https://api.github.com/users/vighneshbirodkar/followers","following_url":"https://api.github.com/users/vighneshbirodkar/following{/other_user}","gists_url":"https://api.github.com/users/vighneshbirodkar/gists{/gist_id}","starred_url":"https://api.github.com/users/vighneshbirodkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vighneshbirodkar/subscriptions","organizations_url":"https://api.github.com/users/vighneshbirodkar/orgs","repos_url":"https://api.github.com/users/vighneshbirodkar/repos","events_url":"https://api.github.com/users/vighneshbirodkar/events{/privacy}","received_events_url":"https://api.github.com/users/vighneshbirodkar/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T14:51:54Z","updated_at":"2016-09-01T14:51:54Z","body":"@jnothman I like your idea of using a `UnknownButInRangeWarning`. I will make a new PR for this, but I hope it's alright to use the same branch. Just to clarify,  `UnknownButInRangeWarning` and `error-strict` should both be implemented or either one of them ?"}}
{"actor":{"display_login":"vighneshbirodkar"}}