{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9182","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9182/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9182/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9182/events","html_url":"https://github.com/cockroachdb/cockroach/pull/9182","id":175549160,"number":9182,"title":"sql: add create table test","user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/cockroachdb/cockroach/milestones/5","html_url":"https://github.com/cockroachdb/cockroach/milestones/Q3","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones/5/labels","id":1875804,"number":5,"title":"Q3","description":"","creator":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"open_issues":142,"closed_issues":204,"state":"open","created_at":"2016-07-11T13:25:51Z","updated_at":"2016-09-07T19:22:17Z","due_on":"2016-10-01T04:00:00Z","closed_at":null},"comments":9,"created_at":"2016-09-07T16:31:40Z","updated_at":"2016-09-07T19:43:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9182","html_url":"https://github.com/cockroachdb/cockroach/pull/9182","diff_url":"https://github.com/cockroachdb/cockroach/pull/9182.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/9182.patch"},"body":"sql: add create table test\r\nCloses #9012.\r\n\r\nAlso 2 small spelling fixes commits.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/9182)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/245394177","html_url":"https://github.com/cockroachdb/cockroach/pull/9182#issuecomment-245394177","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9182","id":245394177,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T19:43:44Z","updated_at":"2016-09-07T19:43:44Z","body":"\n\n\n\nReview status: 2 of 3 files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.\n\n---\n\n*[sql/create_test.go, line 211 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/9182#-KR4XUVTwD0YSGAZJ0he:-KR5AHXn8YgEyfT5b3KA:b-xdtt8w) ([raw file](https://github.com/cockroachdb/cockroach/blob/ef4312c631cd422f3a466b4a22489b2792200bff/sql/create_test.go#L211)):*\n<details><summary><i>Previously, BramGruneir (Bram Gruneir) wrote…</i></summary>\n> The idea was to wait until all tables were created (or attempted at least). What would the waiting condition look like in that case?\n</details>\nReading an expected number of errors (some will be nil) from the channel.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/9182)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}