{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/56773336","id":56773336,"diff_hunk":"@@ -62,6 +62,128 @@ get_new_point (const Quadrature<spacedim> &quad) const\n }\n \n \n+\n+template <>\n+Tensor<1,2>\n+Manifold<2, 2>::\n+normal_vector (const typename Triangulation<2, 2>::face_iterator &face,\n+               const Point<2> &p) const\n+{\n+  const int spacedim=2, dim=2;\n+\n+  Tensor<1,spacedim> tangent = ((p-face->vertex(0)).norm_square() > (p-face->vertex(1)).norm_square() ?","path":"source/grid/manifold.cc","position":13,"original_position":13,"commit_id":"266246f1df9ef4ff219c54efdd6e75d1a38901eb","original_commit_id":"266246f1df9ef4ff219c54efdd6e75d1a38901eb","user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"or are you trying to avoid the sqrt here? Then maybe leave it as is.","created_at":"2016-03-20T22:10:42Z","updated_at":"2016-03-20T22:10:42Z","html_url":"https://github.com/dealii/dealii/pull/2387#discussion_r56773336","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/2387","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/56773336"},"html":{"href":"https://github.com/dealii/dealii/pull/2387#discussion_r56773336"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2387"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2387","id":63502786,"html_url":"https://github.com/dealii/dealii/pull/2387","diff_url":"https://github.com/dealii/dealii/pull/2387.diff","patch_url":"https://github.com/dealii/dealii/pull/2387.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2387","number":2387,"state":"open","locked":false,"title":"Move normal_vector and normals_at_vertices inside Manifold","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=3","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"body":"And provide a default implementation that uses get_tangent_vector.","created_at":"2016-03-20T18:15:33Z","updated_at":"2016-03-20T22:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a0885745b4258f722dd5dd61c9cc9eede7dc99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/2387/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/2387/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2387/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/266246f1df9ef4ff219c54efdd6e75d1a38901eb","head":{"label":"luca-heltai:normal-vectors","ref":"normal-vectors","sha":"266246f1df9ef4ff219c54efdd6e75d1a38901eb","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=3","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"repo":{"id":22053864,"name":"dealii","full_name":"luca-heltai/dealii","owner":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars.githubusercontent.com/u/2919756?v=3","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luca-heltai/dealii","description":"","fork":true,"url":"https://api.github.com/repos/luca-heltai/dealii","forks_url":"https://api.github.com/repos/luca-heltai/dealii/forks","keys_url":"https://api.github.com/repos/luca-heltai/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luca-heltai/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luca-heltai/dealii/teams","hooks_url":"https://api.github.com/repos/luca-heltai/dealii/hooks","issue_events_url":"https://api.github.com/repos/luca-heltai/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/luca-heltai/dealii/events","assignees_url":"https://api.github.com/repos/luca-heltai/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/luca-heltai/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/luca-heltai/dealii/tags","blobs_url":"https://api.github.com/repos/luca-heltai/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luca-heltai/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luca-heltai/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/luca-heltai/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luca-heltai/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/luca-heltai/dealii/languages","stargazers_url":"https://api.github.com/repos/luca-heltai/dealii/stargazers","contributors_url":"https://api.github.com/repos/luca-heltai/dealii/contributors","subscribers_url":"https://api.github.com/repos/luca-heltai/dealii/subscribers","subscription_url":"https://api.github.com/repos/luca-heltai/dealii/subscription","commits_url":"https://api.github.com/repos/luca-heltai/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/luca-heltai/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/luca-heltai/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/luca-heltai/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/luca-heltai/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/luca-heltai/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luca-heltai/dealii/merges","archive_url":"https://api.github.com/repos/luca-heltai/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luca-heltai/dealii/downloads","issues_url":"https://api.github.com/repos/luca-heltai/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/luca-heltai/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/luca-heltai/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/luca-heltai/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luca-heltai/dealii/labels{/name}","releases_url":"https://api.github.com/repos/luca-heltai/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/luca-heltai/dealii/deployments","created_at":"2014-07-21T06:17:40Z","updated_at":"2016-01-25T16:21:24Z","pushed_at":"2016-03-20T18:14:39Z","git_url":"git://github.com/luca-heltai/dealii.git","ssh_url":"git@github.com:luca-heltai/dealii.git","clone_url":"https://github.com/luca-heltai/dealii.git","svn_url":"https://github.com/luca-heltai/dealii","homepage":null,"size":143447,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"5aec6a309b05a9d25cea93978215fff32451ba7a","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-03-20T16:34:52Z","pushed_at":"2016-03-20T21:14:05Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":156040,"stargazers_count":128,"watchers_count":128,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":162,"forks":154,"open_issues":162,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2387"},"html":{"href":"https://github.com/dealii/dealii/pull/2387"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/2387"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/2387/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2387/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2387/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/266246f1df9ef4ff219c54efdd6e75d1a38901eb"}}}}