{"action":"created","issue":{"url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/228","repository_url":"https://api.github.com/repos/HaliteChallenge/Halite","labels_url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/228/comments","events_url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/228/events","html_url":"https://github.com/HaliteChallenge/Halite/pull/228","id":189537749,"number":228,"title":"Let javac use UTF-8 encoding, and look for MyBot.class","user":{"login":"hyPiRion","id":504876,"avatar_url":"https://avatars.githubusercontent.com/u/504876?v=3","gravatar_id":"","url":"https://api.github.com/users/hyPiRion","html_url":"https://github.com/hyPiRion","followers_url":"https://api.github.com/users/hyPiRion/followers","following_url":"https://api.github.com/users/hyPiRion/following{/other_user}","gists_url":"https://api.github.com/users/hyPiRion/gists{/gist_id}","starred_url":"https://api.github.com/users/hyPiRion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyPiRion/subscriptions","organizations_url":"https://api.github.com/users/hyPiRion/orgs","repos_url":"https://api.github.com/users/hyPiRion/repos","events_url":"https://api.github.com/users/hyPiRion/events{/privacy}","received_events_url":"https://api.github.com/users/hyPiRion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-15T23:28:50Z","updated_at":"2016-11-15T23:52:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HaliteChallenge/Halite/pulls/228","html_url":"https://github.com/HaliteChallenge/Halite/pull/228","diff_url":"https://github.com/HaliteChallenge/Halite/pull/228.diff","patch_url":"https://github.com/HaliteChallenge/Halite/pull/228.patch"},"body":"#217 exposed some issues with Java submissions:\r\n\r\n* Compilation may seem to succeed when it actually doesn't\r\n* The encoding used when calling `javac` is environment-dependent\r\n\r\nAs Java files doesn't _have_ to produce class files with the same name as the file itself, we cannot use `out_ext` as it would create false positives. However,  we do know that `MyBot.class` will exist, and we can check for that one.\r\n\r\nThe Docker environment causes the javac compiler to run with ASCII encoding, which causes trouble with... non-ASCII values in source code. The typical default encoding for Javac on more or less all system these days is UTF-8, which is also backwards compatible with ASCII. Therefore it should be fine to set UTF-8 as default encoding for javac.\r\n\r\nI haven't tested this with the Python code in a running environment as I was unable to get it set up, so I've only ran it by calling functions manually through a Python REPL. "},"comment":{"url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/comments/260808640","html_url":"https://github.com/HaliteChallenge/Halite/pull/228#issuecomment-260808640","issue_url":"https://api.github.com/repos/HaliteChallenge/Halite/issues/228","id":260808640,"user":{"login":"truell20","id":4297743,"avatar_url":"https://avatars.githubusercontent.com/u/4297743?v=3","gravatar_id":"","url":"https://api.github.com/users/truell20","html_url":"https://github.com/truell20","followers_url":"https://api.github.com/users/truell20/followers","following_url":"https://api.github.com/users/truell20/following{/other_user}","gists_url":"https://api.github.com/users/truell20/gists{/gist_id}","starred_url":"https://api.github.com/users/truell20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truell20/subscriptions","organizations_url":"https://api.github.com/users/truell20/orgs","repos_url":"https://api.github.com/users/truell20/repos","events_url":"https://api.github.com/users/truell20/events{/privacy}","received_events_url":"https://api.github.com/users/truell20/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T23:52:00Z","updated_at":"2016-11-15T23:52:00Z","body":"lgtm. We have some ideas about how to make testing the worker easier. For the time being, feel free to run the test suite located in `tests/`."}}
{"actor":{"display_login":"truell20"}}