{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-mobile/prox/issues/78","repository_url":"https://api.github.com/repos/mozilla-mobile/prox","labels_url":"https://api.github.com/repos/mozilla-mobile/prox/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-mobile/prox/issues/78/comments","events_url":"https://api.github.com/repos/mozilla-mobile/prox/issues/78/events","html_url":"https://github.com/mozilla-mobile/prox/pull/78","id":186857817,"number":78,"title":"Issue 11 - place card vertical scrolling","user":{"login":"fluffyemily","id":12613048,"avatar_url":"https://avatars.githubusercontent.com/u/12613048?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyemily","html_url":"https://github.com/fluffyemily","followers_url":"https://api.github.com/users/fluffyemily/followers","following_url":"https://api.github.com/users/fluffyemily/following{/other_user}","gists_url":"https://api.github.com/users/fluffyemily/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyemily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyemily/subscriptions","organizations_url":"https://api.github.com/users/fluffyemily/orgs","repos_url":"https://api.github.com/users/fluffyemily/repos","events_url":"https://api.github.com/users/fluffyemily/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyemily/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mcomella","id":759372,"avatar_url":"https://avatars.githubusercontent.com/u/759372?v=3","gravatar_id":"","url":"https://api.github.com/users/mcomella","html_url":"https://github.com/mcomella","followers_url":"https://api.github.com/users/mcomella/followers","following_url":"https://api.github.com/users/mcomella/following{/other_user}","gists_url":"https://api.github.com/users/mcomella/gists{/gist_id}","starred_url":"https://api.github.com/users/mcomella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcomella/subscriptions","organizations_url":"https://api.github.com/users/mcomella/orgs","repos_url":"https://api.github.com/users/mcomella/repos","events_url":"https://api.github.com/users/mcomella/events{/privacy}","received_events_url":"https://api.github.com/users/mcomella/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcomella","id":759372,"avatar_url":"https://avatars.githubusercontent.com/u/759372?v=3","gravatar_id":"","url":"https://api.github.com/users/mcomella","html_url":"https://github.com/mcomella","followers_url":"https://api.github.com/users/mcomella/followers","following_url":"https://api.github.com/users/mcomella/following{/other_user}","gists_url":"https://api.github.com/users/mcomella/gists{/gist_id}","starred_url":"https://api.github.com/users/mcomella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcomella/subscriptions","organizations_url":"https://api.github.com/users/mcomella/orgs","repos_url":"https://api.github.com/users/mcomella/repos","events_url":"https://api.github.com/users/mcomella/events{/privacy}","received_events_url":"https://api.github.com/users/mcomella/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-02T16:53:13Z","updated_at":"2016-11-03T11:45:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/prox/pulls/78","html_url":"https://github.com/mozilla-mobile/prox/pull/78","diff_url":"https://github.com/mozilla-mobile/prox/pull/78.diff","patch_url":"https://github.com/mozilla-mobile/prox/pull/78.patch"},"body":"Move scroll view to parent view for place card view. \r\nSet the scroll view content offset through a delegate.\r\nEnsure that vertical scrolling that starts on the current place card doesn't interfere with pan and page horizontal gestures"},"comment":{"url":"https://api.github.com/repos/mozilla-mobile/prox/issues/comments/258121569","html_url":"https://github.com/mozilla-mobile/prox/pull/78#issuecomment-258121569","issue_url":"https://api.github.com/repos/mozilla-mobile/prox/issues/78","id":258121569,"user":{"login":"fluffyemily","id":12613048,"avatar_url":"https://avatars.githubusercontent.com/u/12613048?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyemily","html_url":"https://github.com/fluffyemily","followers_url":"https://api.github.com/users/fluffyemily/followers","following_url":"https://api.github.com/users/fluffyemily/following{/other_user}","gists_url":"https://api.github.com/users/fluffyemily/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyemily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyemily/subscriptions","organizations_url":"https://api.github.com/users/fluffyemily/orgs","repos_url":"https://api.github.com/users/fluffyemily/repos","events_url":"https://api.github.com/users/fluffyemily/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyemily/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T11:45:17Z","updated_at":"2016-11-03T11:45:17Z","body":"@mcomella I've fixed almost everything I think. Underlying scroll view is now handling all vertical scrolling with no interference from us. In order to achieve this, I had to prevent scrolling entirely when the views are unexpanded. This leads to the only remaining niggle:\r\n\r\nCurrently, when we scroll to an unexpanded view from an expanded view, we shrink the content size and prevent scrolling. This leads to a 'jerk' as the view resets if the scroll is anywhere other than at the top when we pan. However, if I don't reset, then when the expanded view is off screen, it feels odd to have the extra scroll length that leads nowhere. I couldn't decide which to do, so I left it here and thought I would ask your opinion."}}
{"actor":{"display_login":"fluffyemily"}}