{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3","id":72832486,"html_url":"https://github.com/PontusHorn/Pico-Tags/pull/3","diff_url":"https://github.com/PontusHorn/Pico-Tags/pull/3.diff","patch_url":"https://github.com/PontusHorn/Pico-Tags/pull/3.patch","issue_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/3","number":3,"state":"closed","locked":false,"title":"Fix empty meta.filter bug which results in empty page list","user":{"login":"jonas-wilhelm","id":11683095,"avatar_url":"https://avatars.githubusercontent.com/u/11683095?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas-wilhelm","html_url":"https://github.com/jonas-wilhelm","followers_url":"https://api.github.com/users/jonas-wilhelm/followers","following_url":"https://api.github.com/users/jonas-wilhelm/following{/other_user}","gists_url":"https://api.github.com/users/jonas-wilhelm/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas-wilhelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas-wilhelm/subscriptions","organizations_url":"https://api.github.com/users/jonas-wilhelm/orgs","repos_url":"https://api.github.com/users/jonas-wilhelm/repos","events_url":"https://api.github.com/users/jonas-wilhelm/events{/privacy}","received_events_url":"https://api.github.com/users/jonas-wilhelm/received_events","type":"User","site_admin":false},"body":"For an empty meta.filter, `private static function parseTags($tags)` returns: `array(1) { [0]=> string(0) \"\" }`\r\n\r\nThis result is passed into `empty()` inside `public function onPagesLoaded(&$pages, &$currentPage, &$previousPage, &$nextPage)` which returns false of, course.\r\n\r\nI added an additional check to `parseTags($tags)`.","created_at":"2016-06-07T08:12:21Z","updated_at":"2016-06-07T09:39:49Z","closed_at":"2016-06-07T09:39:49Z","merged_at":"2016-06-07T09:39:49Z","merge_commit_sha":"290a5f146708621c50ac3af50b98488fb8a7238d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3/commits","review_comments_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3/comments","review_comment_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/3/comments","statuses_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/statuses/4d4938251672824f6e00b272773cc4e3eeb33f69","head":{"label":"tworabbits:empty-filter-fix","ref":"empty-filter-fix","sha":"4d4938251672824f6e00b272773cc4e3eeb33f69","user":{"login":"tworabbits","id":11683110,"avatar_url":"https://avatars.githubusercontent.com/u/11683110?v=3","gravatar_id":"","url":"https://api.github.com/users/tworabbits","html_url":"https://github.com/tworabbits","followers_url":"https://api.github.com/users/tworabbits/followers","following_url":"https://api.github.com/users/tworabbits/following{/other_user}","gists_url":"https://api.github.com/users/tworabbits/gists{/gist_id}","starred_url":"https://api.github.com/users/tworabbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tworabbits/subscriptions","organizations_url":"https://api.github.com/users/tworabbits/orgs","repos_url":"https://api.github.com/users/tworabbits/repos","events_url":"https://api.github.com/users/tworabbits/events{/privacy}","received_events_url":"https://api.github.com/users/tworabbits/received_events","type":"Organization","site_admin":false},"repo":{"id":60594276,"name":"Pico-Tags","full_name":"tworabbits/Pico-Tags","owner":{"login":"tworabbits","id":11683110,"avatar_url":"https://avatars.githubusercontent.com/u/11683110?v=3","gravatar_id":"","url":"https://api.github.com/users/tworabbits","html_url":"https://github.com/tworabbits","followers_url":"https://api.github.com/users/tworabbits/followers","following_url":"https://api.github.com/users/tworabbits/following{/other_user}","gists_url":"https://api.github.com/users/tworabbits/gists{/gist_id}","starred_url":"https://api.github.com/users/tworabbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tworabbits/subscriptions","organizations_url":"https://api.github.com/users/tworabbits/orgs","repos_url":"https://api.github.com/users/tworabbits/repos","events_url":"https://api.github.com/users/tworabbits/events{/privacy}","received_events_url":"https://api.github.com/users/tworabbits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tworabbits/Pico-Tags","description":"A plugin for Pico to add tagging functionality.","fork":true,"url":"https://api.github.com/repos/tworabbits/Pico-Tags","forks_url":"https://api.github.com/repos/tworabbits/Pico-Tags/forks","keys_url":"https://api.github.com/repos/tworabbits/Pico-Tags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tworabbits/Pico-Tags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tworabbits/Pico-Tags/teams","hooks_url":"https://api.github.com/repos/tworabbits/Pico-Tags/hooks","issue_events_url":"https://api.github.com/repos/tworabbits/Pico-Tags/issues/events{/number}","events_url":"https://api.github.com/repos/tworabbits/Pico-Tags/events","assignees_url":"https://api.github.com/repos/tworabbits/Pico-Tags/assignees{/user}","branches_url":"https://api.github.com/repos/tworabbits/Pico-Tags/branches{/branch}","tags_url":"https://api.github.com/repos/tworabbits/Pico-Tags/tags","blobs_url":"https://api.github.com/repos/tworabbits/Pico-Tags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tworabbits/Pico-Tags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tworabbits/Pico-Tags/git/refs{/sha}","trees_url":"https://api.github.com/repos/tworabbits/Pico-Tags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tworabbits/Pico-Tags/statuses/{sha}","languages_url":"https://api.github.com/repos/tworabbits/Pico-Tags/languages","stargazers_url":"https://api.github.com/repos/tworabbits/Pico-Tags/stargazers","contributors_url":"https://api.github.com/repos/tworabbits/Pico-Tags/contributors","subscribers_url":"https://api.github.com/repos/tworabbits/Pico-Tags/subscribers","subscription_url":"https://api.github.com/repos/tworabbits/Pico-Tags/subscription","commits_url":"https://api.github.com/repos/tworabbits/Pico-Tags/commits{/sha}","git_commits_url":"https://api.github.com/repos/tworabbits/Pico-Tags/git/commits{/sha}","comments_url":"https://api.github.com/repos/tworabbits/Pico-Tags/comments{/number}","issue_comment_url":"https://api.github.com/repos/tworabbits/Pico-Tags/issues/comments{/number}","contents_url":"https://api.github.com/repos/tworabbits/Pico-Tags/contents/{+path}","compare_url":"https://api.github.com/repos/tworabbits/Pico-Tags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tworabbits/Pico-Tags/merges","archive_url":"https://api.github.com/repos/tworabbits/Pico-Tags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tworabbits/Pico-Tags/downloads","issues_url":"https://api.github.com/repos/tworabbits/Pico-Tags/issues{/number}","pulls_url":"https://api.github.com/repos/tworabbits/Pico-Tags/pulls{/number}","milestones_url":"https://api.github.com/repos/tworabbits/Pico-Tags/milestones{/number}","notifications_url":"https://api.github.com/repos/tworabbits/Pico-Tags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tworabbits/Pico-Tags/labels{/name}","releases_url":"https://api.github.com/repos/tworabbits/Pico-Tags/releases{/id}","deployments_url":"https://api.github.com/repos/tworabbits/Pico-Tags/deployments","created_at":"2016-06-07T08:04:26Z","updated_at":"2016-06-07T08:04:27Z","pushed_at":"2016-06-07T08:43:10Z","git_url":"git://github.com/tworabbits/Pico-Tags.git","ssh_url":"git@github.com:tworabbits/Pico-Tags.git","clone_url":"https://github.com/tworabbits/Pico-Tags.git","svn_url":"https://github.com/tworabbits/Pico-Tags","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PontusHorn:master","ref":"master","sha":"101d39a1da321b8af8f514db03d978adbdd94bcb","user":{"login":"PontusHorn","id":6806243,"avatar_url":"https://avatars.githubusercontent.com/u/6806243?v=3","gravatar_id":"","url":"https://api.github.com/users/PontusHorn","html_url":"https://github.com/PontusHorn","followers_url":"https://api.github.com/users/PontusHorn/followers","following_url":"https://api.github.com/users/PontusHorn/following{/other_user}","gists_url":"https://api.github.com/users/PontusHorn/gists{/gist_id}","starred_url":"https://api.github.com/users/PontusHorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PontusHorn/subscriptions","organizations_url":"https://api.github.com/users/PontusHorn/orgs","repos_url":"https://api.github.com/users/PontusHorn/repos","events_url":"https://api.github.com/users/PontusHorn/events{/privacy}","received_events_url":"https://api.github.com/users/PontusHorn/received_events","type":"User","site_admin":false},"repo":{"id":42612427,"name":"Pico-Tags","full_name":"PontusHorn/Pico-Tags","owner":{"login":"PontusHorn","id":6806243,"avatar_url":"https://avatars.githubusercontent.com/u/6806243?v=3","gravatar_id":"","url":"https://api.github.com/users/PontusHorn","html_url":"https://github.com/PontusHorn","followers_url":"https://api.github.com/users/PontusHorn/followers","following_url":"https://api.github.com/users/PontusHorn/following{/other_user}","gists_url":"https://api.github.com/users/PontusHorn/gists{/gist_id}","starred_url":"https://api.github.com/users/PontusHorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PontusHorn/subscriptions","organizations_url":"https://api.github.com/users/PontusHorn/orgs","repos_url":"https://api.github.com/users/PontusHorn/repos","events_url":"https://api.github.com/users/PontusHorn/events{/privacy}","received_events_url":"https://api.github.com/users/PontusHorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PontusHorn/Pico-Tags","description":"A plugin for Pico to add tagging functionality.","fork":false,"url":"https://api.github.com/repos/PontusHorn/Pico-Tags","forks_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/forks","keys_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/teams","hooks_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/hooks","issue_events_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/events{/number}","events_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/events","assignees_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/assignees{/user}","branches_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/branches{/branch}","tags_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/tags","blobs_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/git/refs{/sha}","trees_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/statuses/{sha}","languages_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/languages","stargazers_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/stargazers","contributors_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/contributors","subscribers_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/subscribers","subscription_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/subscription","commits_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/commits{/sha}","git_commits_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/git/commits{/sha}","comments_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/comments{/number}","issue_comment_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/comments{/number}","contents_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/contents/{+path}","compare_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/merges","archive_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/downloads","issues_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues{/number}","pulls_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls{/number}","milestones_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/milestones{/number}","notifications_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/labels{/name}","releases_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/releases{/id}","deployments_url":"https://api.github.com/repos/PontusHorn/Pico-Tags/deployments","created_at":"2015-09-16T20:45:42Z","updated_at":"2016-02-18T21:02:07Z","pushed_at":"2016-06-07T09:39:49Z","git_url":"git://github.com/PontusHorn/Pico-Tags.git","ssh_url":"git@github.com:PontusHorn/Pico-Tags.git","clone_url":"https://github.com/PontusHorn/Pico-Tags.git","svn_url":"https://github.com/PontusHorn/Pico-Tags","homepage":null,"size":6,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3"},"html":{"href":"https://github.com/PontusHorn/Pico-Tags/pull/3"},"issue":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/3"},"comments":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/PontusHorn/Pico-Tags/statuses/4d4938251672824f6e00b272773cc4e3eeb33f69"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PontusHorn","id":6806243,"avatar_url":"https://avatars.githubusercontent.com/u/6806243?v=3","gravatar_id":"","url":"https://api.github.com/users/PontusHorn","html_url":"https://github.com/PontusHorn","followers_url":"https://api.github.com/users/PontusHorn/followers","following_url":"https://api.github.com/users/PontusHorn/following{/other_user}","gists_url":"https://api.github.com/users/PontusHorn/gists{/gist_id}","starred_url":"https://api.github.com/users/PontusHorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PontusHorn/subscriptions","organizations_url":"https://api.github.com/users/PontusHorn/orgs","repos_url":"https://api.github.com/users/PontusHorn/repos","events_url":"https://api.github.com/users/PontusHorn/events{/privacy}","received_events_url":"https://api.github.com/users/PontusHorn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"PontusHorn"}}