{"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/57364422","id":57364422,"diff_hunk":"@@ -181,8 +183,13 @@ export class uProxyCore implements uproxy_core_api.CoreApi {\n    */\n   public logout = (networkInfo :social.SocialNetworkInfo) : Promise<void> => {\n     var networkName = networkInfo.name;\n-    var userId = networkInfo.userId;\n-    var network = social_network.getNetwork(networkName, userId);\n+    if (networkInfo.userId) {\n+      var userId = networkInfo.userId;","path":"src/generic_core/uproxy_core.ts","position":null,"original_position":16,"commit_id":"0fca82585c1cc0f973c57df62fed631cf1ce923e","original_commit_id":"76c835dbb67d9545b4317778124765c32fbb7a50","user":{"login":"gitlaura","id":2903381,"avatar_url":"https://avatars.githubusercontent.com/u/2903381?v=3","gravatar_id":"","url":"https://api.github.com/users/gitlaura","html_url":"https://github.com/gitlaura","followers_url":"https://api.github.com/users/gitlaura/followers","following_url":"https://api.github.com/users/gitlaura/following{/other_user}","gists_url":"https://api.github.com/users/gitlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlaura/subscriptions","organizations_url":"https://api.github.com/users/gitlaura/orgs","repos_url":"https://api.github.com/users/gitlaura/repos","events_url":"https://api.github.com/users/gitlaura/events{/privacy}","received_events_url":"https://api.github.com/users/gitlaura/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-03-24T18:24:28Z","updated_at":"2016-03-24T18:24:28Z","html_url":"https://github.com/uProxy/uproxy/pull/2317#discussion_r57364422","pull_request_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2317","_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/57364422"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2317#discussion_r57364422"},"pull_request":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2317"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/2317","id":63945082,"html_url":"https://github.com/uProxy/uproxy/pull/2317","diff_url":"https://github.com/uProxy/uproxy/pull/2317.diff","patch_url":"https://github.com/uProxy/uproxy/pull/2317.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/2317","number":2317,"state":"open","locked":false,"title":"Destroy cloud server and remove cloud friend","user":{"login":"gitlaura","id":2903381,"avatar_url":"https://avatars.githubusercontent.com/u/2903381?v=3","gravatar_id":"","url":"https://api.github.com/users/gitlaura","html_url":"https://github.com/gitlaura","followers_url":"https://api.github.com/users/gitlaura/followers","following_url":"https://api.github.com/users/gitlaura/following{/other_user}","gists_url":"https://api.github.com/users/gitlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlaura/subscriptions","organizations_url":"https://api.github.com/users/gitlaura/orgs","repos_url":"https://api.github.com/users/gitlaura/repos","events_url":"https://api.github.com/users/gitlaura/events{/privacy}","received_events_url":"https://api.github.com/users/gitlaura/received_events","type":"User","site_admin":false},"body":"There's a lot here and I'm excited to get some extra eyes on it!\r\n\r\nNEW\r\n- Added delete icon to cloud server contacts\r\n- Showing dialogs when user clicks delete and for removal success/failure\r\n- Destroying cloud server if the user created it\r\n- Removing cloud contact from storage and friend list after server is deleted or just removing if the user is only a getter\r\n\r\nTODO\r\n- Improve how we send data via core-signals so I can send the contact ID along with the signal to the getConfirmation dialog\r\n- Unit tests - wanted to get these changes in quickly so didn't include them yet, but let me know if you want unit tests in this PR\r\n\r\nIn order to use, you need to pull in latest changes from uproxy-lib\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/2317)\n<!-- Reviewable:end -->\n","created_at":"2016-03-23T20:11:19Z","updated_at":"2016-03-24T18:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5617bc7b1d33171737c433ee7770735b3c7df1a","assignee":{"login":"dborkan","id":6494307,"avatar_url":"https://avatars.githubusercontent.com/u/6494307?v=3","gravatar_id":"","url":"https://api.github.com/users/dborkan","html_url":"https://github.com/dborkan","followers_url":"https://api.github.com/users/dborkan/followers","following_url":"https://api.github.com/users/dborkan/following{/other_user}","gists_url":"https://api.github.com/users/dborkan/gists{/gist_id}","starred_url":"https://api.github.com/users/dborkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dborkan/subscriptions","organizations_url":"https://api.github.com/users/dborkan/orgs","repos_url":"https://api.github.com/users/dborkan/repos","events_url":"https://api.github.com/users/dborkan/events{/privacy}","received_events_url":"https://api.github.com/users/dborkan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2317/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2317/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/2317/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/0fca82585c1cc0f973c57df62fed631cf1ce923e","head":{"label":"uProxy:gitlaura-cloud-destroy","ref":"gitlaura-cloud-destroy","sha":"0fca82585c1cc0f973c57df62fed631cf1ce923e","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/uproxy/deployments","created_at":"2014-04-07T20:34:40Z","updated_at":"2016-03-23T02:02:09Z","pushed_at":"2016-03-24T18:23:14Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":17755,"stargazers_count":350,"watchers_count":350,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":483,"forks":92,"open_issues":483,"watchers":350,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"0b75aea2f6bc6eae6c98b28c62896fe2be22ce0d","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/uproxy/deployments","created_at":"2014-04-07T20:34:40Z","updated_at":"2016-03-23T02:02:09Z","pushed_at":"2016-03-24T18:23:14Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":17755,"stargazers_count":350,"watchers_count":350,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":483,"forks":92,"open_issues":483,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2317"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2317"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2317"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2317/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2317/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2317/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/0fca82585c1cc0f973c57df62fed631cf1ce923e"}}}}