{"action":"created","issue":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/100","repository_url":"https://api.github.com/repos/sailfishos/sailfish-office","labels_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/100/comments","events_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/100/events","html_url":"https://github.com/sailfishos/sailfish-office/pull/100","id":191271351,"number":100,"title":"[office] Use the same scroll animator as for goto link for search matching.","user":{"login":"dcaliste","id":5889532,"avatar_url":"https://avatars.githubusercontent.com/u/5889532?v=3","gravatar_id":"","url":"https://api.github.com/users/dcaliste","html_url":"https://github.com/dcaliste","followers_url":"https://api.github.com/users/dcaliste/followers","following_url":"https://api.github.com/users/dcaliste/following{/other_user}","gists_url":"https://api.github.com/users/dcaliste/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaliste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaliste/subscriptions","organizations_url":"https://api.github.com/users/dcaliste/orgs","repos_url":"https://api.github.com/users/dcaliste/repos","events_url":"https://api.github.com/users/dcaliste/events{/privacy}","received_events_url":"https://api.github.com/users/dcaliste/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-23T13:32:58Z","updated_at":"2016-12-02T13:12:24Z","closed_at":"2016-12-02T12:42:06Z","pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/100","html_url":"https://github.com/sailfishos/sailfish-office/pull/100","diff_url":"https://github.com/sailfishos/sailfish-office/pull/100.diff","patch_url":"https://github.com/sailfishos/sailfish-office/pull/100.patch"},"body":"Factorise the code in PDFView.qml to use the same scrolling animator for goto link and search matching. This solves also the issue of seing all empty pages scroll when the next match is far away."},"comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/comments/264450928","html_url":"https://github.com/sailfishos/sailfish-office/pull/100#issuecomment-264450928","issue_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/100","id":264450928,"user":{"login":"dcaliste","id":5889532,"avatar_url":"https://avatars.githubusercontent.com/u/5889532?v=3","gravatar_id":"","url":"https://api.github.com/users/dcaliste","html_url":"https://github.com/dcaliste","followers_url":"https://api.github.com/users/dcaliste/followers","following_url":"https://api.github.com/users/dcaliste/following{/other_user}","gists_url":"https://api.github.com/users/dcaliste/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaliste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaliste/subscriptions","organizations_url":"https://api.github.com/users/dcaliste/orgs","repos_url":"https://api.github.com/users/dcaliste/repos","events_url":"https://api.github.com/users/dcaliste/events{/privacy}","received_events_url":"https://api.github.com/users/dcaliste/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T13:12:24Z","updated_at":"2016-12-02T13:12:24Z","body":"Thank you for the merge. I've done this as you understand I guess, for the same concern than we had for the goto link action, *i.e* avoid seing a lot of blank page shapes scrolling fast when the next match is far away.\r\n\r\n> as search mode doesn't have page number indication.\r\n\r\nThat is a relevant concern I think. The situation before the PR was that we know that we have scrolled a lot of pages. The situation is slightly degraded now, quick scroll masking the quantity of scroll (*e.g.* only one page if the zoom level is high).\r\n\r\nOne solution would be to display the page id of the current match in the label (beside the number of matches). But for now, I find this solution not very convenient, making the UI overcrowded. Any idea is welcome !"}}
{"actor":{"display_login":"dcaliste"}}