{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37846","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37846/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37846/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37846/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37846","id":192943021,"number":37846,"title":"error in setNodeStatus func should not abort node status update","user":{"login":"sjenning","id":493891,"avatar_url":"https://avatars.githubusercontent.com/u/493891?v=3","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"assignees":[{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-12-01T19:43:54Z","updated_at":"2016-12-02T14:11:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37846","html_url":"https://github.com/kubernetes/kubernetes/pull/37846","diff_url":"https://github.com/kubernetes/kubernetes/pull/37846.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37846.patch"},"body":"`setNodeStatus()` currently errors out if any of the functions in the `kl.setNodeStatusFuncs` returns an error, resulting in the node not reporting status and eventually being marked as `NotReady`.\r\n\r\n`setNodeAddress()` is currently the only function in `defaultNodeStatusFuncs()` that can return an error and it does if the cloud provider can't be contacted for any number of reasons like token expiration, API outage, ratelimit block, etc.\r\n\r\nThis PR changes `setNodeStatus()` to log, rather than return, when an error is returned by one of the `setNodeStatusFuncs` so that the node status update can proceed.\r\n\r\nFixes #34455\r\n\r\nxref https://bugzilla.redhat.com/show_bug.cgi?id=1400574\r\n\r\n@eparis @derekwaynecarr @mikedanese @anguslees"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/264462198","html_url":"https://github.com/kubernetes/kubernetes/pull/37846#issuecomment-264462198","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37846","id":264462198,"user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T14:11:34Z","updated_at":"2016-12-02T14:11:34Z","body":"@k8s-bot cvm gce e2e test this"}}
{"actor":{"display_login":"derekwaynecarr"}}