{"action":"closed","number":518,"pull_request":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/518","id":57742103,"html_url":"https://github.com/espressomd/espresso/pull/518","diff_url":"https://github.com/espressomd/espresso/pull/518.diff","patch_url":"https://github.com/espressomd/espresso/pull/518.patch","issue_url":"https://api.github.com/repos/espressomd/espresso/issues/518","number":518,"state":"closed","locked":false,"title":"Reactions","user":{"login":"hmenke","id":1903556,"avatar_url":"https://avatars.githubusercontent.com/u/1903556?v=3","gravatar_id":"","url":"https://api.github.com/users/hmenke","html_url":"https://github.com/hmenke","followers_url":"https://api.github.com/users/hmenke/followers","following_url":"https://api.github.com/users/hmenke/following{/other_user}","gists_url":"https://api.github.com/users/hmenke/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenke/subscriptions","organizations_url":"https://api.github.com/users/hmenke/orgs","repos_url":"https://api.github.com/users/hmenke/repos","events_url":"https://api.github.com/users/hmenke/events{/privacy}","received_events_url":"https://api.github.com/users/hmenke/received_events","type":"User","site_admin":false},"body":"This pull-request contains the updated `reaction` method.  The old behaviour is preserved and selected by default.  The new method allows direction-dependent swapping of particles.  A python interface has also been made available.\r\n\r\nThe declarations `using namespace std;` have been purged from the header files `grid.hpp` and `fene.hpp`, as it is considered bad style [1,2].  Also, these declarations were leaking out into all `.cpp` files, which included these, which might ultimately lead to silent overloading of local funtions with a counterpart in `std::`.  To further support my argument, I quote “Thinking in C++” by Bruce Eckel\r\n\r\n> However you'll virtually never see a using directive in a header file (at least not outside of scope). The reason is that using directive eliminate the protection of that particular namespace, and the effect last until the end of current compilation unit. If you put a using directive (outside of a scope) in a header file, it means that this loss of \"namespace protection\" will occur within any file that include this header, which often mean other header files.\r\n\r\n[1] https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers\r\n[2] https://stackoverflow.com/questions/4872373/why-is-including-using-namespace-into-a-header-file-a-bad-idea-in-c","created_at":"2016-01-30T15:27:01Z","updated_at":"2016-02-08T22:16:19Z","closed_at":"2016-02-08T22:16:19Z","merged_at":null,"merge_commit_sha":"0703f63ba6ad0d3ff5bb28e57a34a93ca3445c3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/espressomd/espresso/pulls/518/commits","review_comments_url":"https://api.github.com/repos/espressomd/espresso/pulls/518/comments","review_comment_url":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressomd/espresso/issues/518/comments","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/292cd104712c97b59d6ba6125649415c6c05651e","head":{"label":"hmenke:reactions","ref":"reactions","sha":"292cd104712c97b59d6ba6125649415c6c05651e","user":{"login":"hmenke","id":1903556,"avatar_url":"https://avatars.githubusercontent.com/u/1903556?v=3","gravatar_id":"","url":"https://api.github.com/users/hmenke","html_url":"https://github.com/hmenke","followers_url":"https://api.github.com/users/hmenke/followers","following_url":"https://api.github.com/users/hmenke/following{/other_user}","gists_url":"https://api.github.com/users/hmenke/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenke/subscriptions","organizations_url":"https://api.github.com/users/hmenke/orgs","repos_url":"https://api.github.com/users/hmenke/repos","events_url":"https://api.github.com/users/hmenke/events{/privacy}","received_events_url":"https://api.github.com/users/hmenke/received_events","type":"User","site_admin":false},"repo":{"id":6443092,"name":"espresso","full_name":"hmenke/espresso","owner":{"login":"hmenke","id":1903556,"avatar_url":"https://avatars.githubusercontent.com/u/1903556?v=3","gravatar_id":"","url":"https://api.github.com/users/hmenke","html_url":"https://github.com/hmenke","followers_url":"https://api.github.com/users/hmenke/followers","following_url":"https://api.github.com/users/hmenke/following{/other_user}","gists_url":"https://api.github.com/users/hmenke/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenke/subscriptions","organizations_url":"https://api.github.com/users/hmenke/orgs","repos_url":"https://api.github.com/users/hmenke/repos","events_url":"https://api.github.com/users/hmenke/events{/privacy}","received_events_url":"https://api.github.com/users/hmenke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmenke/espresso","description":"The ESPResSo package","fork":true,"url":"https://api.github.com/repos/hmenke/espresso","forks_url":"https://api.github.com/repos/hmenke/espresso/forks","keys_url":"https://api.github.com/repos/hmenke/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmenke/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmenke/espresso/teams","hooks_url":"https://api.github.com/repos/hmenke/espresso/hooks","issue_events_url":"https://api.github.com/repos/hmenke/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/hmenke/espresso/events","assignees_url":"https://api.github.com/repos/hmenke/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/hmenke/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/hmenke/espresso/tags","blobs_url":"https://api.github.com/repos/hmenke/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmenke/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmenke/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmenke/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmenke/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/hmenke/espresso/languages","stargazers_url":"https://api.github.com/repos/hmenke/espresso/stargazers","contributors_url":"https://api.github.com/repos/hmenke/espresso/contributors","subscribers_url":"https://api.github.com/repos/hmenke/espresso/subscribers","subscription_url":"https://api.github.com/repos/hmenke/espresso/subscription","commits_url":"https://api.github.com/repos/hmenke/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmenke/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmenke/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmenke/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmenke/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/hmenke/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmenke/espresso/merges","archive_url":"https://api.github.com/repos/hmenke/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmenke/espresso/downloads","issues_url":"https://api.github.com/repos/hmenke/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/hmenke/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/hmenke/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/hmenke/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmenke/espresso/labels{/name}","releases_url":"https://api.github.com/repos/hmenke/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/hmenke/espresso/deployments","created_at":"2012-10-29T15:48:50Z","updated_at":"2015-05-04T13:53:49Z","pushed_at":"2016-01-30T14:53:53Z","git_url":"git://github.com/hmenke/espresso.git","ssh_url":"git@github.com:hmenke/espresso.git","clone_url":"https://github.com/hmenke/espresso.git","svn_url":"https://github.com/hmenke/espresso","homepage":"http://espressomd.org","size":75335,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"espressomd:master","ref":"master","sha":"10978b7cab4afc8651168df62c56f1e5b21ae4a8","user":{"login":"espressomd","id":689837,"avatar_url":"https://avatars.githubusercontent.com/u/689837?v=3","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"repo":{"id":1524644,"name":"espresso","full_name":"espressomd/espresso","owner":{"login":"espressomd","id":689837,"avatar_url":"https://avatars.githubusercontent.com/u/689837?v=3","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressomd/espresso","description":"The ESPResSo package","fork":false,"url":"https://api.github.com/repos/espressomd/espresso","forks_url":"https://api.github.com/repos/espressomd/espresso/forks","keys_url":"https://api.github.com/repos/espressomd/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressomd/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressomd/espresso/teams","hooks_url":"https://api.github.com/repos/espressomd/espresso/hooks","issue_events_url":"https://api.github.com/repos/espressomd/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/espressomd/espresso/events","assignees_url":"https://api.github.com/repos/espressomd/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/espressomd/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/espressomd/espresso/tags","blobs_url":"https://api.github.com/repos/espressomd/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressomd/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressomd/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressomd/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/espressomd/espresso/languages","stargazers_url":"https://api.github.com/repos/espressomd/espresso/stargazers","contributors_url":"https://api.github.com/repos/espressomd/espresso/contributors","subscribers_url":"https://api.github.com/repos/espressomd/espresso/subscribers","subscription_url":"https://api.github.com/repos/espressomd/espresso/subscription","commits_url":"https://api.github.com/repos/espressomd/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressomd/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressomd/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressomd/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressomd/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/espressomd/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressomd/espresso/merges","archive_url":"https://api.github.com/repos/espressomd/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressomd/espresso/downloads","issues_url":"https://api.github.com/repos/espressomd/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/espressomd/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/espressomd/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/espressomd/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressomd/espresso/labels{/name}","releases_url":"https://api.github.com/repos/espressomd/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/espressomd/espresso/deployments","created_at":"2011-03-25T07:43:15Z","updated_at":"2016-02-02T12:02:41Z","pushed_at":"2016-02-08T22:16:01Z","git_url":"git://github.com/espressomd/espresso.git","ssh_url":"git@github.com:espressomd/espresso.git","clone_url":"https://github.com/espressomd/espresso.git","svn_url":"https://github.com/espressomd/espresso","homepage":"http://espressomd.org","size":84956,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":89,"forks":72,"open_issues":89,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/518"},"html":{"href":"https://github.com/espressomd/espresso/pull/518"},"issue":{"href":"https://api.github.com/repos/espressomd/espresso/issues/518"},"comments":{"href":"https://api.github.com/repos/espressomd/espresso/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/espressomd/espresso/statuses/292cd104712c97b59d6ba6125649415c6c05651e"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":18,"additions":704,"deletions":316,"changed_files":54}}