{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/2604","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/2604/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/2604/comments","events_url":"https://api.github.com/repos/apache/flink/issues/2604/events","html_url":"https://github.com/apache/flink/pull/2604","id":181417595,"number":2604,"title":"[FLINK-4753] [kafka] PeriodicOffsetCommitter should synchronize on checkpoint lock","user":{"login":"tzulitai","id":5284370,"avatar_url":"https://avatars.githubusercontent.com/u/5284370?v=3","gravatar_id":"","url":"https://api.github.com/users/tzulitai","html_url":"https://github.com/tzulitai","followers_url":"https://api.github.com/users/tzulitai/followers","following_url":"https://api.github.com/users/tzulitai/following{/other_user}","gists_url":"https://api.github.com/users/tzulitai/gists{/gist_id}","starred_url":"https://api.github.com/users/tzulitai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzulitai/subscriptions","organizations_url":"https://api.github.com/users/tzulitai/orgs","repos_url":"https://api.github.com/users/tzulitai/repos","events_url":"https://api.github.com/users/tzulitai/events{/privacy}","received_events_url":"https://api.github.com/users/tzulitai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-06T13:39:54Z","updated_at":"2016-10-10T09:41:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2604","html_url":"https://github.com/apache/flink/pull/2604","diff_url":"https://github.com/apache/flink/pull/2604.diff","patch_url":"https://github.com/apache/flink/pull/2604.patch"},"body":"The `PeriodicOffsetCommitter` in Kafka 0.8 currently doesn't synchronize on the checkpoint lock when creating a copy of the partition offsets in the current state.\r\n\r\nThis change proposes to pass the checkpoint lock into `PeriodicOffsetCommitter`, and let `PeriodicOffsetCommitter` use `Kafka08Fetcher#snapshotCurrentState()` to make copies of the current state.\r\n\r\nThis PR also includes removal of some leftover unused code after some recent refactoring of the Kafka connectors in commit 53ed6ada."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/252573610","html_url":"https://github.com/apache/flink/pull/2604#issuecomment-252573610","issue_url":"https://api.github.com/repos/apache/flink/issues/2604","id":252573610,"user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T09:41:40Z","updated_at":"2016-10-10T09:41:40Z","body":"Why do you want to synchronize on the checkpoint lock when creating the copy?\r\nThe `PeriodicOffsetCommitter` doesn't provide any reliability guarantees anyways, so synchronizing doesn't add any additional correctness."}}
{"actor":{"display_login":"rmetzger"}}