{"action":"created","comment":{"url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/comments/59398780","id":59398780,"diff_hunk":"@@ -1,5 +1,6 @@\n 2.0.0 (Unreleased)\n ==================\n+- [BREAKING] Removed make_result method from View and Query classes.","path":"CHANGES.rst","position":3,"original_position":3,"commit_id":"f5d6f347b7fefe64dec2b9953bf6bd8678a43236","original_commit_id":"f5d6f347b7fefe64dec2b9953bf6bd8678a43236","user":{"login":"emlaver","id":10552966,"avatar_url":"https://avatars.githubusercontent.com/u/10552966?v=3","gravatar_id":"","url":"https://api.github.com/users/emlaver","html_url":"https://github.com/emlaver","followers_url":"https://api.github.com/users/emlaver/followers","following_url":"https://api.github.com/users/emlaver/following{/other_user}","gists_url":"https://api.github.com/users/emlaver/gists{/gist_id}","starred_url":"https://api.github.com/users/emlaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlaver/subscriptions","organizations_url":"https://api.github.com/users/emlaver/orgs","repos_url":"https://api.github.com/users/emlaver/repos","events_url":"https://api.github.com/users/emlaver/events{/privacy}","received_events_url":"https://api.github.com/users/emlaver/received_events","type":"User","site_admin":false},"body":"UPDATE:\r\n```\r\n[BREAKING] Removed make_result method from View and Query classes. Use one of the methods ``CloudantDatabase.get_query_result``, ``CouchDatabase.get_view_result``, or ``View.custom_result`` for equivalent functionality.\r\n```","created_at":"2016-04-12T15:38:49Z","updated_at":"2016-04-12T15:38:49Z","html_url":"https://github.com/cloudant/python-cloudant/pull/144#discussion_r59398780","pull_request_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/comments/59398780"},"html":{"href":"https://github.com/cloudant/python-cloudant/pull/144#discussion_r59398780"},"pull_request":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144","id":65813142,"html_url":"https://github.com/cloudant/python-cloudant/pull/144","diff_url":"https://github.com/cloudant/python-cloudant/pull/144.diff","patch_url":"https://github.com/cloudant/python-cloudant/pull/144.patch","issue_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144","number":144,"state":"open","locked":false,"title":"Remove make_result from Query and View","user":{"login":"emlaver","id":10552966,"avatar_url":"https://avatars.githubusercontent.com/u/10552966?v=3","gravatar_id":"","url":"https://api.github.com/users/emlaver","html_url":"https://github.com/emlaver","followers_url":"https://api.github.com/users/emlaver/followers","following_url":"https://api.github.com/users/emlaver/following{/other_user}","gists_url":"https://api.github.com/users/emlaver/gists{/gist_id}","starred_url":"https://api.github.com/users/emlaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlaver/subscriptions","organizations_url":"https://api.github.com/users/emlaver/orgs","repos_url":"https://api.github.com/users/emlaver/repos","events_url":"https://api.github.com/users/emlaver/events{/privacy}","received_events_url":"https://api.github.com/users/emlaver/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nThe make_result method in Query and View classes is redundant and confusing. It should be removed. A Result/QueryResult object can be stood up that essentially would perform the same functionality. Likewise the database convenience methods of get_view_results and get_query_results also perform the same functionality.\r\n\r\n## How\r\n\r\nIn database.py module:\r\n- change get_view_results to standup a new Result object passing it **kwargs.\r\n- change get_query_results to standup a new QueryResult object passing it **kwargs.\r\n\r\nIn result.py module:\r\n- Move parameter docs from make_result methods to Result/QueryResult class docstring.\r\n- Remove references to make_result in comments.\r\n\r\nIn view.py module:\r\n- Remove make_result.\r\n- Refactor custom_result to use a new Result object passing it **kwargs.\r\n- Add QueryIndexView.custom_result to override and disable the base method View.custom_result\r\n\r\nIn query.py module:\r\n- Remove make_result.\r\n- Refactor custom_result to use a new QueryResult object passing it **kwargs.\r\n\r\n## Testing\r\n\r\nNo additional tests.\r\nRemoved make_result tests.\r\n\r\n## Reviewers\r\n\r\nreviewer @alfinkel \r\nreviewer @ricellis\r\n\r\n## Issues\r\n\r\n#46 ","created_at":"2016-04-08T16:34:13Z","updated_at":"2016-04-12T15:38:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa689d429fd6601ce5ebe3766c3bc4fb94476021","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144/commits","review_comments_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144/comments","review_comment_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144/comments","statuses_url":"https://api.github.com/repos/cloudant/python-cloudant/statuses/f5d6f347b7fefe64dec2b9953bf6bd8678a43236","head":{"label":"cloudant:46-remove-make-result-from-query-and-view","ref":"46-remove-make-result-from-query-and-view","sha":"f5d6f347b7fefe64dec2b9953bf6bd8678a43236","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":41557383,"name":"python-cloudant","full_name":"cloudant/python-cloudant","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/python-cloudant","description":"A Python library for Cloudant and CouchDB","fork":false,"url":"https://api.github.com/repos/cloudant/python-cloudant","forks_url":"https://api.github.com/repos/cloudant/python-cloudant/forks","keys_url":"https://api.github.com/repos/cloudant/python-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/python-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/python-cloudant/teams","hooks_url":"https://api.github.com/repos/cloudant/python-cloudant/hooks","issue_events_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/python-cloudant/events","assignees_url":"https://api.github.com/repos/cloudant/python-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/python-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/python-cloudant/tags","blobs_url":"https://api.github.com/repos/cloudant/python-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/python-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/python-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/python-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/python-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/python-cloudant/languages","stargazers_url":"https://api.github.com/repos/cloudant/python-cloudant/stargazers","contributors_url":"https://api.github.com/repos/cloudant/python-cloudant/contributors","subscribers_url":"https://api.github.com/repos/cloudant/python-cloudant/subscribers","subscription_url":"https://api.github.com/repos/cloudant/python-cloudant/subscription","commits_url":"https://api.github.com/repos/cloudant/python-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/python-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/python-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/python-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/python-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/python-cloudant/merges","archive_url":"https://api.github.com/repos/cloudant/python-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/python-cloudant/downloads","issues_url":"https://api.github.com/repos/cloudant/python-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/python-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/python-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/python-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/python-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/python-cloudant/deployments","created_at":"2015-08-28T16:22:49Z","updated_at":"2016-03-23T10:05:47Z","pushed_at":"2016-04-11T16:05:49Z","git_url":"git://github.com/cloudant/python-cloudant.git","ssh_url":"git@github.com:cloudant/python-cloudant.git","clone_url":"https://github.com/cloudant/python-cloudant.git","svn_url":"https://github.com/cloudant/python-cloudant","homepage":null,"size":579,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":30,"forks":5,"open_issues":30,"watchers":16,"default_branch":"master"}},"base":{"label":"cloudant:master","ref":"master","sha":"37befe1ba4a48fa3bbdffdb7b363dddb38668b54","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":41557383,"name":"python-cloudant","full_name":"cloudant/python-cloudant","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/python-cloudant","description":"A Python library for Cloudant and CouchDB","fork":false,"url":"https://api.github.com/repos/cloudant/python-cloudant","forks_url":"https://api.github.com/repos/cloudant/python-cloudant/forks","keys_url":"https://api.github.com/repos/cloudant/python-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/python-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/python-cloudant/teams","hooks_url":"https://api.github.com/repos/cloudant/python-cloudant/hooks","issue_events_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/python-cloudant/events","assignees_url":"https://api.github.com/repos/cloudant/python-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/python-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/python-cloudant/tags","blobs_url":"https://api.github.com/repos/cloudant/python-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/python-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/python-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/python-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/python-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/python-cloudant/languages","stargazers_url":"https://api.github.com/repos/cloudant/python-cloudant/stargazers","contributors_url":"https://api.github.com/repos/cloudant/python-cloudant/contributors","subscribers_url":"https://api.github.com/repos/cloudant/python-cloudant/subscribers","subscription_url":"https://api.github.com/repos/cloudant/python-cloudant/subscription","commits_url":"https://api.github.com/repos/cloudant/python-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/python-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/python-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/python-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/python-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/python-cloudant/merges","archive_url":"https://api.github.com/repos/cloudant/python-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/python-cloudant/downloads","issues_url":"https://api.github.com/repos/cloudant/python-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/python-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/python-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/python-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/python-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/python-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/python-cloudant/deployments","created_at":"2015-08-28T16:22:49Z","updated_at":"2016-03-23T10:05:47Z","pushed_at":"2016-04-11T16:05:49Z","git_url":"git://github.com/cloudant/python-cloudant.git","ssh_url":"git@github.com:cloudant/python-cloudant.git","clone_url":"https://github.com/cloudant/python-cloudant.git","svn_url":"https://github.com/cloudant/python-cloudant","homepage":null,"size":579,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":30,"forks":5,"open_issues":30,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144"},"html":{"href":"https://github.com/cloudant/python-cloudant/pull/144"},"issue":{"href":"https://api.github.com/repos/cloudant/python-cloudant/issues/144"},"comments":{"href":"https://api.github.com/repos/cloudant/python-cloudant/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/cloudant/python-cloudant/statuses/f5d6f347b7fefe64dec2b9953bf6bd8678a43236"}}}}