{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/73351405","id":73351405,"diff_hunk":"@@ -216,23 +208,20 @@ test('update texttrack buttons on removetrack or addtrack', function() {\n   player.dispose();\n });\n \n-test('if native text tracks are not supported, create a texttrackdisplay', function() {\n-  let oldTestVid = Html5.TEST_VID;\n-  let oldIsFirefox = browser.IS_FIREFOX;\n-  let oldTextTrackDisplay = Component.getComponent('TextTrackDisplay');\n+QUnit.test('if native text tracks are not supported, create a texttrackdisplay', function() {\n+  const oldTestVid = Html5.TEST_VID;\n+  const oldIsFirefox = browser.IS_FIREFOX;\n+  const oldTextTrackDisplay = Component.getComponent('TextTrackDisplay');\n   let called = false;\n-  let player;\n-  let tag;\n-  let track;\n+  const tag = document.createElement('video');\n+  const track = document.createElement('track');\n \n-  tag = document.createElement('video');\n-  track = document.createElement('track');\n   track.kind = 'captions';\n   track.label = 'en';\n   track.language = 'English';\n   track.src = 'en.vtt';\n   tag.appendChild(track);\n-  track = document.createElement('track');","path":"test/unit/tracks/text-tracks.test.js","position":240,"original_position":240,"commit_id":"ff15d9b0b4ae9884156537faba134bbd96d52425","original_commit_id":"ff15d9b0b4ae9884156537faba134bbd96d52425","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"body":"they are defined above with most of the other variable definitions","created_at":"2016-08-03T14:46:32Z","updated_at":"2016-08-03T14:46:32Z","html_url":"https://github.com/videojs/video.js/pull/3484#discussion_r73351405","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/3484","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/73351405"},"html":{"href":"https://github.com/videojs/video.js/pull/3484#discussion_r73351405"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3484"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3484","id":79637864,"html_url":"https://github.com/videojs/video.js/pull/3484","diff_url":"https://github.com/videojs/video.js/pull/3484.diff","patch_url":"https://github.com/videojs/video.js/pull/3484.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3484","number":3484,"state":"open","locked":false,"title":"vjsstandard - Tests - Other 1/2 of Tracks folder + Misc","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"body":"## Description\r\nlinted the other half of the `test/unit/tracks` folder and some other misc files\r\n\r\n## Requirements Checklist\r\n- [x] Feature implemented / Bug fixed\r\n- [ ] Reviewed by Two Core Contributors","created_at":"2016-08-01T21:13:29Z","updated_at":"2016-08-03T14:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e90e826c6040c99808ce3f0a874541000ebe117","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/videojs/video.js/milestones/10","html_url":"https://github.com/videojs/video.js/milestones/Linting","labels_url":"https://api.github.com/repos/videojs/video.js/milestones/10/labels","id":1903023,"number":10,"title":"Linting","description":"","creator":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":5,"state":"open","created_at":"2016-07-25T17:12:42Z","updated_at":"2016-08-02T16:16:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3484/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3484/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3484/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/ff15d9b0b4ae9884156537faba134bbd96d52425","head":{"label":"BrandonOCasey:chore/test-linting-pt5","ref":"chore/test-linting-pt5","sha":"ff15d9b0b4ae9884156537faba134bbd96d52425","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"repo":{"id":48056229,"name":"video.js","full_name":"BrandonOCasey/video.js","owner":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrandonOCasey/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/BrandonOCasey/video.js","forks_url":"https://api.github.com/repos/BrandonOCasey/video.js/forks","keys_url":"https://api.github.com/repos/BrandonOCasey/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrandonOCasey/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrandonOCasey/video.js/teams","hooks_url":"https://api.github.com/repos/BrandonOCasey/video.js/hooks","issue_events_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/BrandonOCasey/video.js/events","assignees_url":"https://api.github.com/repos/BrandonOCasey/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/BrandonOCasey/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/BrandonOCasey/video.js/tags","blobs_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrandonOCasey/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BrandonOCasey/video.js/languages","stargazers_url":"https://api.github.com/repos/BrandonOCasey/video.js/stargazers","contributors_url":"https://api.github.com/repos/BrandonOCasey/video.js/contributors","subscribers_url":"https://api.github.com/repos/BrandonOCasey/video.js/subscribers","subscription_url":"https://api.github.com/repos/BrandonOCasey/video.js/subscription","commits_url":"https://api.github.com/repos/BrandonOCasey/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrandonOCasey/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrandonOCasey/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrandonOCasey/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/BrandonOCasey/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrandonOCasey/video.js/merges","archive_url":"https://api.github.com/repos/BrandonOCasey/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrandonOCasey/video.js/downloads","issues_url":"https://api.github.com/repos/BrandonOCasey/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/BrandonOCasey/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BrandonOCasey/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BrandonOCasey/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrandonOCasey/video.js/labels{/name}","releases_url":"https://api.github.com/repos/BrandonOCasey/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/BrandonOCasey/video.js/deployments","created_at":"2015-12-15T16:43:06Z","updated_at":"2016-02-12T14:53:16Z","pushed_at":"2016-08-03T14:40:24Z","git_url":"git://github.com/BrandonOCasey/video.js.git","ssh_url":"git@github.com:BrandonOCasey/video.js.git","clone_url":"https://github.com/BrandonOCasey/video.js.git","svn_url":"https://github.com/BrandonOCasey/video.js","homepage":"www.videojs.com","size":79683,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:vjsstandard-core","ref":"vjsstandard-core","sha":"deddb6b5d14bdd6cad16141676df738d5979d30e","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-08-03T14:25:18Z","pushed_at":"2016-08-03T14:40:26Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":110002,"stargazers_count":13152,"watchers_count":13152,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3816,"mirror_url":null,"open_issues_count":197,"forks":3816,"open_issues":197,"watchers":13152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3484"},"html":{"href":"https://github.com/videojs/video.js/pull/3484"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3484"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3484/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3484/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3484/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/ff15d9b0b4ae9884156537faba134bbd96d52425"}}}}
{"actor":{"display_login":"BrandonOCasey"}}