{"action":"created","comment":{"url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/comments/70166612","id":70166612,"diff_hunk":"@@ -146,7 +146,7 @@ S_Init\n */\n void S_Init(void)\n {\n-    s_enable = Cvar_Get(\"s_enable\", \"1\", CVAR_SOUND);\n+    s_enable = Cvar_Get(\"s_enable\", \"2\", CVAR_SOUND);\n     if (s_enable->integer <= SS_NOT) {\n         Com_Printf(\"Sound initialization disabled.\\n\");\n         return;","path":"src/client/sound/main.c","position":8,"original_position":8,"commit_id":"76605106306499aca3ca38b33b0d818572a68a55","original_commit_id":"76605106306499aca3ca38b33b0d818572a68a55","user":{"login":"jdolan","id":643118,"avatar_url":"https://avatars.githubusercontent.com/u/643118?v=3","gravatar_id":"","url":"https://api.github.com/users/jdolan","html_url":"https://github.com/jdolan","followers_url":"https://api.github.com/users/jdolan/followers","following_url":"https://api.github.com/users/jdolan/following{/other_user}","gists_url":"https://api.github.com/users/jdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdolan/subscriptions","organizations_url":"https://api.github.com/users/jdolan/orgs","repos_url":"https://api.github.com/users/jdolan/repos","events_url":"https://api.github.com/users/jdolan/events{/privacy}","received_events_url":"https://api.github.com/users/jdolan/received_events","type":"User","site_admin":false},"body":"Default this to 2 so that OpenAL is tried if available. Seems like a logical thing to do?","created_at":"2016-07-09T12:35:33Z","updated_at":"2016-07-09T12:35:33Z","html_url":"https://github.com/AndreyNazarov/q2pro/pull/106#discussion_r70166612","pull_request_url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/comments/70166612"},"html":{"href":"https://github.com/AndreyNazarov/q2pro/pull/106#discussion_r70166612"},"pull_request":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106","id":76845977,"html_url":"https://github.com/AndreyNazarov/q2pro/pull/106","diff_url":"https://github.com/AndreyNazarov/q2pro/pull/106.diff","patch_url":"https://github.com/AndreyNazarov/q2pro/pull/106.patch","issue_url":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/106","number":106,"state":"open","locked":false,"title":"Minor fixes for OS X compilation","user":{"login":"jdolan","id":643118,"avatar_url":"https://avatars.githubusercontent.com/u/643118?v=3","gravatar_id":"","url":"https://api.github.com/users/jdolan","html_url":"https://github.com/jdolan","followers_url":"https://api.github.com/users/jdolan/followers","following_url":"https://api.github.com/users/jdolan/following{/other_user}","gists_url":"https://api.github.com/users/jdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdolan/subscriptions","organizations_url":"https://api.github.com/users/jdolan/orgs","repos_url":"https://api.github.com/users/jdolan/repos","events_url":"https://api.github.com/users/jdolan/events{/privacy}","received_events_url":"https://api.github.com/users/jdolan/received_events","type":"User","site_admin":false},"body":"This PR fixes some Clang compilation warnings, and gets OpenAL workable on OS X.\r\n\r\nHere's the `.config` I'm compiling with:\r\n\r\n```\r\nCONFIG_DEFAULT_MODELIST = 640x480 800x600 1024x768 1440x900 1920x1080\r\nCONFIG_DEFAULT_GEOMETRY = 1440x900\r\n\r\nCONFIG_HTTP = 1\r\n\r\nCONFIG_OPENAL = 1\r\nCONFIG_FIXED_LIBAL = 1\r\nAL_CFLAGS = -framework OpenAL\r\nAL_LIBS = -framework OpenAL\r\n\r\nCONFIG_PNG = 1\r\nCONFIG_JPEG = 1\r\n\r\nCONFIG_SDL2= 1\r\n```\r\n\r\nA few things I've noticed:\r\n\r\n1. I don't know where the menus have gone. Hitting ESC no longer brings up the menu. I'm sure that I'm compiling with menu support. Not sure what's up with that.\r\n1. LibPNG implementation struggles to load textures that other engines load just fine. It squawks errors in the console, and the loaded textures are garbled. Not sure if this is specific to OS X, or if you see this on other platforms. Screenshot attached.\r\n1. OpenAL implementation seems .. odd. Sound attenuation is very different from default behavior. Is Q2Pro's OpenAL considered \"ready,\" or is it still experimental?\r\n\r\n![quake051](https://cloud.githubusercontent.com/assets/643118/16707955/a3d85a60-45af-11e6-80a1-d5f04f24276d.jpg)\r\n","created_at":"2016-07-09T12:33:00Z","updated_at":"2016-07-09T12:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e39e0a50fa70331e157252e680ad384e4fbd304","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106/commits","review_comments_url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106/comments","review_comment_url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/106/comments","statuses_url":"https://api.github.com/repos/AndreyNazarov/q2pro/statuses/76605106306499aca3ca38b33b0d818572a68a55","head":{"label":"jdolan:master","ref":"master","sha":"76605106306499aca3ca38b33b0d818572a68a55","user":{"login":"jdolan","id":643118,"avatar_url":"https://avatars.githubusercontent.com/u/643118?v=3","gravatar_id":"","url":"https://api.github.com/users/jdolan","html_url":"https://github.com/jdolan","followers_url":"https://api.github.com/users/jdolan/followers","following_url":"https://api.github.com/users/jdolan/following{/other_user}","gists_url":"https://api.github.com/users/jdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdolan/subscriptions","organizations_url":"https://api.github.com/users/jdolan/orgs","repos_url":"https://api.github.com/users/jdolan/repos","events_url":"https://api.github.com/users/jdolan/events{/privacy}","received_events_url":"https://api.github.com/users/jdolan/received_events","type":"User","site_admin":false},"repo":{"id":9132758,"name":"q2pro","full_name":"jdolan/q2pro","owner":{"login":"jdolan","id":643118,"avatar_url":"https://avatars.githubusercontent.com/u/643118?v=3","gravatar_id":"","url":"https://api.github.com/users/jdolan","html_url":"https://github.com/jdolan","followers_url":"https://api.github.com/users/jdolan/followers","following_url":"https://api.github.com/users/jdolan/following{/other_user}","gists_url":"https://api.github.com/users/jdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdolan/subscriptions","organizations_url":"https://api.github.com/users/jdolan/orgs","repos_url":"https://api.github.com/users/jdolan/repos","events_url":"https://api.github.com/users/jdolan/events{/privacy}","received_events_url":"https://api.github.com/users/jdolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdolan/q2pro","description":"Enhanced Quake 2 client and server focused on multiplayer","fork":true,"url":"https://api.github.com/repos/jdolan/q2pro","forks_url":"https://api.github.com/repos/jdolan/q2pro/forks","keys_url":"https://api.github.com/repos/jdolan/q2pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdolan/q2pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdolan/q2pro/teams","hooks_url":"https://api.github.com/repos/jdolan/q2pro/hooks","issue_events_url":"https://api.github.com/repos/jdolan/q2pro/issues/events{/number}","events_url":"https://api.github.com/repos/jdolan/q2pro/events","assignees_url":"https://api.github.com/repos/jdolan/q2pro/assignees{/user}","branches_url":"https://api.github.com/repos/jdolan/q2pro/branches{/branch}","tags_url":"https://api.github.com/repos/jdolan/q2pro/tags","blobs_url":"https://api.github.com/repos/jdolan/q2pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdolan/q2pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdolan/q2pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdolan/q2pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdolan/q2pro/statuses/{sha}","languages_url":"https://api.github.com/repos/jdolan/q2pro/languages","stargazers_url":"https://api.github.com/repos/jdolan/q2pro/stargazers","contributors_url":"https://api.github.com/repos/jdolan/q2pro/contributors","subscribers_url":"https://api.github.com/repos/jdolan/q2pro/subscribers","subscription_url":"https://api.github.com/repos/jdolan/q2pro/subscription","commits_url":"https://api.github.com/repos/jdolan/q2pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdolan/q2pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdolan/q2pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdolan/q2pro/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdolan/q2pro/contents/{+path}","compare_url":"https://api.github.com/repos/jdolan/q2pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdolan/q2pro/merges","archive_url":"https://api.github.com/repos/jdolan/q2pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdolan/q2pro/downloads","issues_url":"https://api.github.com/repos/jdolan/q2pro/issues{/number}","pulls_url":"https://api.github.com/repos/jdolan/q2pro/pulls{/number}","milestones_url":"https://api.github.com/repos/jdolan/q2pro/milestones{/number}","notifications_url":"https://api.github.com/repos/jdolan/q2pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdolan/q2pro/labels{/name}","releases_url":"https://api.github.com/repos/jdolan/q2pro/releases{/id}","deployments_url":"https://api.github.com/repos/jdolan/q2pro/deployments","created_at":"2013-03-31T16:31:33Z","updated_at":"2015-07-06T07:10:05Z","pushed_at":"2016-07-09T12:14:07Z","git_url":"git://github.com/jdolan/q2pro.git","ssh_url":"git@github.com:jdolan/q2pro.git","clone_url":"https://github.com/jdolan/q2pro.git","svn_url":"https://github.com/jdolan/q2pro","homepage":null,"size":14693,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"AndreyNazarov:master","ref":"master","sha":"924ff39aa48df1d6cd985b42a2fe5a60ff154030","user":{"login":"AndreyNazarov","id":3035748,"avatar_url":"https://avatars.githubusercontent.com/u/3035748?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyNazarov","html_url":"https://github.com/AndreyNazarov","followers_url":"https://api.github.com/users/AndreyNazarov/followers","following_url":"https://api.github.com/users/AndreyNazarov/following{/other_user}","gists_url":"https://api.github.com/users/AndreyNazarov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyNazarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyNazarov/subscriptions","organizations_url":"https://api.github.com/users/AndreyNazarov/orgs","repos_url":"https://api.github.com/users/AndreyNazarov/repos","events_url":"https://api.github.com/users/AndreyNazarov/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyNazarov/received_events","type":"User","site_admin":false},"repo":{"id":7152142,"name":"q2pro","full_name":"AndreyNazarov/q2pro","owner":{"login":"AndreyNazarov","id":3035748,"avatar_url":"https://avatars.githubusercontent.com/u/3035748?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyNazarov","html_url":"https://github.com/AndreyNazarov","followers_url":"https://api.github.com/users/AndreyNazarov/followers","following_url":"https://api.github.com/users/AndreyNazarov/following{/other_user}","gists_url":"https://api.github.com/users/AndreyNazarov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyNazarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyNazarov/subscriptions","organizations_url":"https://api.github.com/users/AndreyNazarov/orgs","repos_url":"https://api.github.com/users/AndreyNazarov/repos","events_url":"https://api.github.com/users/AndreyNazarov/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyNazarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreyNazarov/q2pro","description":"Enhanced Quake 2 client and server focused on multiplayer","fork":false,"url":"https://api.github.com/repos/AndreyNazarov/q2pro","forks_url":"https://api.github.com/repos/AndreyNazarov/q2pro/forks","keys_url":"https://api.github.com/repos/AndreyNazarov/q2pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreyNazarov/q2pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreyNazarov/q2pro/teams","hooks_url":"https://api.github.com/repos/AndreyNazarov/q2pro/hooks","issue_events_url":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/events{/number}","events_url":"https://api.github.com/repos/AndreyNazarov/q2pro/events","assignees_url":"https://api.github.com/repos/AndreyNazarov/q2pro/assignees{/user}","branches_url":"https://api.github.com/repos/AndreyNazarov/q2pro/branches{/branch}","tags_url":"https://api.github.com/repos/AndreyNazarov/q2pro/tags","blobs_url":"https://api.github.com/repos/AndreyNazarov/q2pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreyNazarov/q2pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreyNazarov/q2pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreyNazarov/q2pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreyNazarov/q2pro/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreyNazarov/q2pro/languages","stargazers_url":"https://api.github.com/repos/AndreyNazarov/q2pro/stargazers","contributors_url":"https://api.github.com/repos/AndreyNazarov/q2pro/contributors","subscribers_url":"https://api.github.com/repos/AndreyNazarov/q2pro/subscribers","subscription_url":"https://api.github.com/repos/AndreyNazarov/q2pro/subscription","commits_url":"https://api.github.com/repos/AndreyNazarov/q2pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreyNazarov/q2pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreyNazarov/q2pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreyNazarov/q2pro/contents/{+path}","compare_url":"https://api.github.com/repos/AndreyNazarov/q2pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreyNazarov/q2pro/merges","archive_url":"https://api.github.com/repos/AndreyNazarov/q2pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreyNazarov/q2pro/downloads","issues_url":"https://api.github.com/repos/AndreyNazarov/q2pro/issues{/number}","pulls_url":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreyNazarov/q2pro/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreyNazarov/q2pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreyNazarov/q2pro/labels{/name}","releases_url":"https://api.github.com/repos/AndreyNazarov/q2pro/releases{/id}","deployments_url":"https://api.github.com/repos/AndreyNazarov/q2pro/deployments","created_at":"2012-12-13T17:17:40Z","updated_at":"2016-07-08T13:49:06Z","pushed_at":"2016-07-09T12:33:00Z","git_url":"git://github.com/AndreyNazarov/q2pro.git","ssh_url":"git@github.com:AndreyNazarov/q2pro.git","clone_url":"https://github.com/AndreyNazarov/q2pro.git","svn_url":"https://github.com/AndreyNazarov/q2pro","homepage":null,"size":15337,"stargazers_count":35,"watchers_count":35,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":27,"forks":14,"open_issues":27,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106"},"html":{"href":"https://github.com/AndreyNazarov/q2pro/pull/106"},"issue":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/106"},"comments":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/AndreyNazarov/q2pro/statuses/76605106306499aca3ca38b33b0d818572a68a55"}}}}
{"actor":{"display_login":"jdolan"}}