{"action":"created","issue":{"url":"https://api.github.com/repos/mcollina/node-coap/issues/103","repository_url":"https://api.github.com/repos/mcollina/node-coap","labels_url":"https://api.github.com/repos/mcollina/node-coap/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/mcollina/node-coap/issues/103/comments","events_url":"https://api.github.com/repos/mcollina/node-coap/issues/103/events","html_url":"https://github.com/mcollina/node-coap/pull/103","id":132704346,"number":103,"title":"Fix undefined var problem in isObserve()","user":{"login":"zacwbond","id":16196680,"avatar_url":"https://avatars.githubusercontent.com/u/16196680?v=3","gravatar_id":"","url":"https://api.github.com/users/zacwbond","html_url":"https://github.com/zacwbond","followers_url":"https://api.github.com/users/zacwbond/followers","following_url":"https://api.github.com/users/zacwbond/following{/other_user}","gists_url":"https://api.github.com/users/zacwbond/gists{/gist_id}","starred_url":"https://api.github.com/users/zacwbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacwbond/subscriptions","organizations_url":"https://api.github.com/users/zacwbond/orgs","repos_url":"https://api.github.com/users/zacwbond/repos","events_url":"https://api.github.com/users/zacwbond/events{/privacy}","received_events_url":"https://api.github.com/users/zacwbond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-10T13:46:29Z","updated_at":"2016-02-24T10:38:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcollina/node-coap/pulls/103","html_url":"https://github.com/mcollina/node-coap/pull/103","diff_url":"https://github.com/mcollina/node-coap/pull/103.diff","patch_url":"https://github.com/mcollina/node-coap/pull/103.patch"},"body":"When I tried to use the coap proxy server, I got a curious error.  I created a proxy and target servers in separate processes, based on the example proxy code, and then used the coap-cli module to construct a message to the target through the proxy (i.e., I added the `proxyUri` option).  The message and response worked, but shortly after the client received the response, the proxy and the target got locked into an endless loop of debug like this: \r\n\r\n`Target receives [request is not defined] in port [8976] from port [6780].`\r\n\r\nI tracked the problem down to isObserve(), where it appears `request` is being used instead of `packet`, and which is also not even testing anything because it doesn't return a value.  \r\n\r\nAll of the unit tests pass in spite of this.  Apparently, that's because it takes too much time for the error to percolate up, and I guess none of the tests check for unexpected requests anyway.\r\n\r\nI could use some advice on the test I added.  I had to disable the sinon fake timers to get it to pass (otherwise, it would hang forever), which is probably bad form.  I'm sure there is a way to use them and make it work, but I'm not familiar enough with them to know how.\r\n"},"comment":{"url":"https://api.github.com/repos/mcollina/node-coap/issues/comments/188187072","html_url":"https://github.com/mcollina/node-coap/pull/103#issuecomment-188187072","issue_url":"https://api.github.com/repos/mcollina/node-coap/issues/103","id":188187072,"user":{"login":"dmoranj","id":1152892,"avatar_url":"https://avatars.githubusercontent.com/u/1152892?v=3","gravatar_id":"","url":"https://api.github.com/users/dmoranj","html_url":"https://github.com/dmoranj","followers_url":"https://api.github.com/users/dmoranj/followers","following_url":"https://api.github.com/users/dmoranj/following{/other_user}","gists_url":"https://api.github.com/users/dmoranj/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoranj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoranj/subscriptions","organizations_url":"https://api.github.com/users/dmoranj/orgs","repos_url":"https://api.github.com/users/dmoranj/repos","events_url":"https://api.github.com/users/dmoranj/events{/privacy}","received_events_url":"https://api.github.com/users/dmoranj/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T10:38:33Z","updated_at":"2016-02-24T10:38:33Z","body":"This raises another interesting question, BTW. What versions of Node.js is node-coap expected to support? 0.10 to 5?"}}