{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/77633778","id":77633778,"diff_hunk":"@@ -210,7 +210,9 @@ def __getitem__(self, key):\n             return self.parent.keywords[key]\n \n     def __setitem__(self, key, value):\n-        self._markers[key] = value\n+        from _pytest.mark import MarkDecorator\n+        if not isinstance(self._markers.get(key), MarkDecorator):","path":"_pytest/main.py","position":6,"original_position":6,"commit_id":"11785eea833b1aed84e09ece51073be2085c8a9f","original_commit_id":"11785eea833b1aed84e09ece51073be2085c8a9f","user":{"login":"RonnyPfannschmidt","id":156838,"avatar_url":"https://avatars.githubusercontent.com/u/156838?v=3","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"body":"no, its currently not fixable due to broken internal (i forsee any minimal attempt causing more regressions)","created_at":"2016-09-06T13:29:54Z","updated_at":"2016-09-06T13:29:54Z","html_url":"https://github.com/pytest-dev/pytest/pull/1915#discussion_r77633778","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/77633778"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1915#discussion_r77633778"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915","id":84036190,"html_url":"https://github.com/pytest-dev/pytest/pull/1915","diff_url":"https://github.com/pytest-dev/pytest/pull/1915.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/1915.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1915","number":1915,"state":"open","locked":false,"title":"Checking if keyword is a MarkDecorator before set","user":{"login":"cr3","id":1476750,"avatar_url":"https://avatars.githubusercontent.com/u/1476750?v=3","gravatar_id":"","url":"https://api.github.com/users/cr3","html_url":"https://github.com/cr3","followers_url":"https://api.github.com/users/cr3/followers","following_url":"https://api.github.com/users/cr3/following{/other_user}","gists_url":"https://api.github.com/users/cr3/gists{/gist_id}","starred_url":"https://api.github.com/users/cr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr3/subscriptions","organizations_url":"https://api.github.com/users/cr3/orgs","repos_url":"https://api.github.com/users/cr3/repos","events_url":"https://api.github.com/users/cr3/events{/privacy}","received_events_url":"https://api.github.com/users/cr3/received_events","type":"User","site_admin":false},"body":"In NodeKeywords, setitem might be called multiple times for the same\r\nkey. For example, pytest.mark.foo('foo') will call setitem first with a\r\nMarkDecorator value and then with a True value. The MarkDecorator value is\r\ntherefore overwritten and the marked keyword is never matched. This change\r\nonly sets the keyword when it's not already a MarkDecorator instance.","created_at":"2016-09-05T19:58:50Z","updated_at":"2016-09-06T13:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1b5f6fe89b42303ce26407e620238e5501924e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1915/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/11785eea833b1aed84e09ece51073be2085c8a9f","head":{"label":"cr3:marker-in-fixture-params","ref":"marker-in-fixture-params","sha":"11785eea833b1aed84e09ece51073be2085c8a9f","user":{"login":"cr3","id":1476750,"avatar_url":"https://avatars.githubusercontent.com/u/1476750?v=3","gravatar_id":"","url":"https://api.github.com/users/cr3","html_url":"https://github.com/cr3","followers_url":"https://api.github.com/users/cr3/followers","following_url":"https://api.github.com/users/cr3/following{/other_user}","gists_url":"https://api.github.com/users/cr3/gists{/gist_id}","starred_url":"https://api.github.com/users/cr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr3/subscriptions","organizations_url":"https://api.github.com/users/cr3/orgs","repos_url":"https://api.github.com/users/cr3/repos","events_url":"https://api.github.com/users/cr3/events{/privacy}","received_events_url":"https://api.github.com/users/cr3/received_events","type":"User","site_admin":false},"repo":{"id":67311360,"name":"pytest","full_name":"cr3/pytest","owner":{"login":"cr3","id":1476750,"avatar_url":"https://avatars.githubusercontent.com/u/1476750?v=3","gravatar_id":"","url":"https://api.github.com/users/cr3","html_url":"https://github.com/cr3","followers_url":"https://api.github.com/users/cr3/followers","following_url":"https://api.github.com/users/cr3/following{/other_user}","gists_url":"https://api.github.com/users/cr3/gists{/gist_id}","starred_url":"https://api.github.com/users/cr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr3/subscriptions","organizations_url":"https://api.github.com/users/cr3/orgs","repos_url":"https://api.github.com/users/cr3/repos","events_url":"https://api.github.com/users/cr3/events{/privacy}","received_events_url":"https://api.github.com/users/cr3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cr3/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":true,"url":"https://api.github.com/repos/cr3/pytest","forks_url":"https://api.github.com/repos/cr3/pytest/forks","keys_url":"https://api.github.com/repos/cr3/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cr3/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cr3/pytest/teams","hooks_url":"https://api.github.com/repos/cr3/pytest/hooks","issue_events_url":"https://api.github.com/repos/cr3/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/cr3/pytest/events","assignees_url":"https://api.github.com/repos/cr3/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/cr3/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/cr3/pytest/tags","blobs_url":"https://api.github.com/repos/cr3/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cr3/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cr3/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cr3/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cr3/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/cr3/pytest/languages","stargazers_url":"https://api.github.com/repos/cr3/pytest/stargazers","contributors_url":"https://api.github.com/repos/cr3/pytest/contributors","subscribers_url":"https://api.github.com/repos/cr3/pytest/subscribers","subscription_url":"https://api.github.com/repos/cr3/pytest/subscription","commits_url":"https://api.github.com/repos/cr3/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cr3/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cr3/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cr3/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cr3/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/cr3/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cr3/pytest/merges","archive_url":"https://api.github.com/repos/cr3/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cr3/pytest/downloads","issues_url":"https://api.github.com/repos/cr3/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/cr3/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/cr3/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/cr3/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cr3/pytest/labels{/name}","releases_url":"https://api.github.com/repos/cr3/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/cr3/pytest/deployments","created_at":"2016-09-03T20:58:09Z","updated_at":"2016-09-03T20:58:11Z","pushed_at":"2016-09-05T20:04:24Z","git_url":"git://github.com/cr3/pytest.git","ssh_url":"git@github.com:cr3/pytest.git","clone_url":"https://github.com/cr3/pytest.git","svn_url":"https://github.com/cr3/pytest","homepage":"http://pytest.org/","size":8963,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"99efc281ee2d217acd2a5265a44549254fc78599","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":37489525,"name":"pytest","full_name":"pytest-dev/pytest","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest","forks_url":"https://api.github.com/repos/pytest-dev/pytest/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest/deployments","created_at":"2015-06-15T20:28:27Z","updated_at":"2016-09-06T13:28:53Z","pushed_at":"2016-09-05T20:04:24Z","git_url":"git://github.com/pytest-dev/pytest.git","ssh_url":"git@github.com:pytest-dev/pytest.git","clone_url":"https://github.com/pytest-dev/pytest.git","svn_url":"https://github.com/pytest-dev/pytest","homepage":"http://pytest.org/","size":10991,"stargazers_count":872,"watchers_count":872,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":287,"forks":244,"open_issues":287,"watchers":872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1915"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1915"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1915/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1915/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest/statuses/11785eea833b1aed84e09ece51073be2085c8a9f"}}}}
{"actor":{"display_login":"RonnyPfannschmidt"}}