{"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/50132275","id":50132275,"diff_hunk":"@@ -21,15 +21,14 @@ import com.esotericsoftware.kryo.{ Kryo, Serializer }\n import com.esotericsoftware.kryo.io.{ Output, Input }\n import org.apache.spark.Logging\n import org.apache.spark.rdd.RDD\n+import org.bdgenomics.adam.rdd.ADAMContext\n import org.bdgenomics.adam.rdd.ADAMContext._\n import org.bdgenomics.adam.serialization.AvroSerializer\n-import org.bdgenomics.formats.avro.{\n-  AlignmentRecord,\n-  Fragment\n-}\n+import org.bdgenomics.formats.avro.{ SingleReadBucket, AlignmentRecord, Fragment }\n+\n import scala.collection.JavaConversions._\n \n-object SingleReadBucket extends Logging {\n+object SingleReadBucketRDD extends Logging {","path":"adam-core/src/main/scala/org/bdgenomics/adam/models/SingleReadBucket.scala","position":16,"original_position":16,"commit_id":"b44df150fc21056df566584c290c6455900503c7","original_commit_id":"b44df150fc21056df566584c290c6455900503c7","user":{"login":"heuermh","id":35293,"avatar_url":"https://avatars.githubusercontent.com/u/35293?v=3","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-01-19T16:10:14Z","updated_at":"2016-01-19T16:10:14Z","html_url":"https://github.com/bigdatagenomics/adam/pull/922#discussion_r50132275","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/50132275"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/922#discussion_r50132275"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922","id":56373398,"html_url":"https://github.com/bigdatagenomics/adam/pull/922","diff_url":"https://github.com/bigdatagenomics/adam/pull/922.diff","patch_url":"https://github.com/bigdatagenomics/adam/pull/922.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/922","number":922,"state":"open","locked":false,"title":"Splitting out SingleReadBucket into an Avro model","user":{"login":"tdanford","id":395608,"avatar_url":"https://avatars.githubusercontent.com/u/395608?v=3","gravatar_id":"","url":"https://api.github.com/users/tdanford","html_url":"https://github.com/tdanford","followers_url":"https://api.github.com/users/tdanford/followers","following_url":"https://api.github.com/users/tdanford/following{/other_user}","gists_url":"https://api.github.com/users/tdanford/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanford/subscriptions","organizations_url":"https://api.github.com/users/tdanford/orgs","repos_url":"https://api.github.com/users/tdanford/repos","events_url":"https://api.github.com/users/tdanford/events{/privacy}","received_events_url":"https://api.github.com/users/tdanford/received_events","type":"User","site_admin":false},"body":"This is the beginning of the experiment we discussed prior to the Amplab\r\n2016 retreat: can we split some of the model classes that are currently\r\nhand-written into pairs:\r\n(1) an Avro-schema'ed model class, and\r\n(2) a \"*Utils\"-style class containing what were previously the class\r\nmethods of the model.\r\n\r\nThe initial commit only converts the SingleReadBucket model, from a\r\nScala class into an Avro record, as an example of the work involved.\r\n\r\nAll the old class methods have been put into a new class,\r\nSingleReadBucketUtils.\r\n\r\nThe old _object_ SingleReadBucket was shadowing (unavoidably) the\r\nSingleReadBucket class, and so it has been renamed SingleReadBucketRDD.","created_at":"2016-01-18T17:52:16Z","updated_at":"2016-01-19T16:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"574f2443b693548760f40b76e8e2c3a842b7a241","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/922/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/b44df150fc21056df566584c290c6455900503c7","head":{"label":"tdanford:example-avro-model","ref":"example-avro-model","sha":"b44df150fc21056df566584c290c6455900503c7","user":{"login":"tdanford","id":395608,"avatar_url":"https://avatars.githubusercontent.com/u/395608?v=3","gravatar_id":"","url":"https://api.github.com/users/tdanford","html_url":"https://github.com/tdanford","followers_url":"https://api.github.com/users/tdanford/followers","following_url":"https://api.github.com/users/tdanford/following{/other_user}","gists_url":"https://api.github.com/users/tdanford/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanford/subscriptions","organizations_url":"https://api.github.com/users/tdanford/orgs","repos_url":"https://api.github.com/users/tdanford/repos","events_url":"https://api.github.com/users/tdanford/events{/privacy}","received_events_url":"https://api.github.com/users/tdanford/received_events","type":"User","site_admin":false},"repo":{"id":23480866,"name":"adam","full_name":"tdanford/adam","owner":{"login":"tdanford","id":395608,"avatar_url":"https://avatars.githubusercontent.com/u/395608?v=3","gravatar_id":"","url":"https://api.github.com/users/tdanford","html_url":"https://github.com/tdanford","followers_url":"https://api.github.com/users/tdanford/followers","following_url":"https://api.github.com/users/tdanford/following{/other_user}","gists_url":"https://api.github.com/users/tdanford/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanford/subscriptions","organizations_url":"https://api.github.com/users/tdanford/orgs","repos_url":"https://api.github.com/users/tdanford/repos","events_url":"https://api.github.com/users/tdanford/events{/privacy}","received_events_url":"https://api.github.com/users/tdanford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdanford/adam","description":"A genomics processing engine and specialized file format built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/tdanford/adam","forks_url":"https://api.github.com/repos/tdanford/adam/forks","keys_url":"https://api.github.com/repos/tdanford/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdanford/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdanford/adam/teams","hooks_url":"https://api.github.com/repos/tdanford/adam/hooks","issue_events_url":"https://api.github.com/repos/tdanford/adam/issues/events{/number}","events_url":"https://api.github.com/repos/tdanford/adam/events","assignees_url":"https://api.github.com/repos/tdanford/adam/assignees{/user}","branches_url":"https://api.github.com/repos/tdanford/adam/branches{/branch}","tags_url":"https://api.github.com/repos/tdanford/adam/tags","blobs_url":"https://api.github.com/repos/tdanford/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdanford/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdanford/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdanford/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdanford/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/tdanford/adam/languages","stargazers_url":"https://api.github.com/repos/tdanford/adam/stargazers","contributors_url":"https://api.github.com/repos/tdanford/adam/contributors","subscribers_url":"https://api.github.com/repos/tdanford/adam/subscribers","subscription_url":"https://api.github.com/repos/tdanford/adam/subscription","commits_url":"https://api.github.com/repos/tdanford/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdanford/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdanford/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdanford/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdanford/adam/contents/{+path}","compare_url":"https://api.github.com/repos/tdanford/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdanford/adam/merges","archive_url":"https://api.github.com/repos/tdanford/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdanford/adam/downloads","issues_url":"https://api.github.com/repos/tdanford/adam/issues{/number}","pulls_url":"https://api.github.com/repos/tdanford/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/tdanford/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/tdanford/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdanford/adam/labels{/name}","releases_url":"https://api.github.com/repos/tdanford/adam/releases{/id}","created_at":"2014-08-29T23:51:21Z","updated_at":"2016-01-13T16:22:59Z","pushed_at":"2016-01-18T18:36:15Z","git_url":"git://github.com/tdanford/adam.git","ssh_url":"git@github.com:tdanford/adam.git","clone_url":"https://github.com/tdanford/adam.git","svn_url":"https://github.com/tdanford/adam","homepage":"http://bdgenomics.org/","size":51633,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"cd6ef4162ae97460059ef067d21bbed7e060b289","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":14541530,"name":"adam","full_name":"bigdatagenomics/adam","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/adam","forks_url":"https://api.github.com/repos/bigdatagenomics/adam/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/adam/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/adam/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/adam/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/adam/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/adam/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/adam/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/adam/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/adam/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/adam/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/adam/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/adam/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/adam/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/adam/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/adam/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/adam/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/adam/releases{/id}","created_at":"2013-11-19T23:47:57Z","updated_at":"2016-01-17T23:25:08Z","pushed_at":"2016-01-18T18:36:15Z","git_url":"git://github.com/bigdatagenomics/adam.git","ssh_url":"git@github.com:bigdatagenomics/adam.git","clone_url":"https://github.com/bigdatagenomics/adam.git","svn_url":"https://github.com/bigdatagenomics/adam","homepage":"http://bdgenomics.org/","size":52666,"stargazers_count":370,"watchers_count":370,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":114,"forks":143,"open_issues":114,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/922"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/922"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/adam/statuses/b44df150fc21056df566584c290c6455900503c7"}}}}