{"action":"closed","number":615,"pull_request":{"url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615","id":59395377,"html_url":"https://github.com/cerebris/jsonapi-resources/pull/615","diff_url":"https://github.com/cerebris/jsonapi-resources/pull/615.diff","patch_url":"https://github.com/cerebris/jsonapi-resources/pull/615.patch","issue_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/615","number":615,"state":"closed","locked":false,"title":"Make offset and paged paginators links consistent","user":{"login":"coryodaniel","id":11587,"avatar_url":"https://avatars.githubusercontent.com/u/11587?v=3","gravatar_id":"","url":"https://api.github.com/users/coryodaniel","html_url":"https://github.com/coryodaniel","followers_url":"https://api.github.com/users/coryodaniel/followers","following_url":"https://api.github.com/users/coryodaniel/following{/other_user}","gists_url":"https://api.github.com/users/coryodaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/coryodaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryodaniel/subscriptions","organizations_url":"https://api.github.com/users/coryodaniel/orgs","repos_url":"https://api.github.com/users/coryodaniel/repos","events_url":"https://api.github.com/users/coryodaniel/events{/privacy}","received_events_url":"https://api.github.com/users/coryodaniel/received_events","type":"User","site_admin":false},"body":"Per the pagination spec (http://jsonapi.org/format/#fetching-pagination)\r\nprevious links should be 'prev'.  It was done this way in the paged\r\npaginator but not the offset.\r\n\r\nI left the original key name in there for backwards compat and updated the tests to expect an additional key. LMK if you want me to add a deprecation message and notes around the tests where the link count has changed.","created_at":"2016-02-15T17:48:34Z","updated_at":"2016-02-17T18:51:07Z","closed_at":"2016-02-17T18:51:07Z","merged_at":"2016-02-17T18:51:07Z","merge_commit_sha":"c47205e217b80cf6292584b978efc466502a55e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615/commits","review_comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615/comments","review_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/615/comments","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/44f8da89218fc30299dd87dd204834cbfa3259a8","head":{"label":"coryodaniel:pagination-links-consistency","ref":"pagination-links-consistency","sha":"44f8da89218fc30299dd87dd204834cbfa3259a8","user":{"login":"coryodaniel","id":11587,"avatar_url":"https://avatars.githubusercontent.com/u/11587?v=3","gravatar_id":"","url":"https://api.github.com/users/coryodaniel","html_url":"https://github.com/coryodaniel","followers_url":"https://api.github.com/users/coryodaniel/followers","following_url":"https://api.github.com/users/coryodaniel/following{/other_user}","gists_url":"https://api.github.com/users/coryodaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/coryodaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryodaniel/subscriptions","organizations_url":"https://api.github.com/users/coryodaniel/orgs","repos_url":"https://api.github.com/users/coryodaniel/repos","events_url":"https://api.github.com/users/coryodaniel/events{/privacy}","received_events_url":"https://api.github.com/users/coryodaniel/received_events","type":"User","site_admin":false},"repo":{"id":51624845,"name":"jsonapi-resources","full_name":"coryodaniel/jsonapi-resources","owner":{"login":"coryodaniel","id":11587,"avatar_url":"https://avatars.githubusercontent.com/u/11587?v=3","gravatar_id":"","url":"https://api.github.com/users/coryodaniel","html_url":"https://github.com/coryodaniel","followers_url":"https://api.github.com/users/coryodaniel/followers","following_url":"https://api.github.com/users/coryodaniel/following{/other_user}","gists_url":"https://api.github.com/users/coryodaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/coryodaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryodaniel/subscriptions","organizations_url":"https://api.github.com/users/coryodaniel/orgs","repos_url":"https://api.github.com/users/coryodaniel/repos","events_url":"https://api.github.com/users/coryodaniel/events{/privacy}","received_events_url":"https://api.github.com/users/coryodaniel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coryodaniel/jsonapi-resources","description":"A resource-focused Rails library for developing JSON API compliant servers.","fork":true,"url":"https://api.github.com/repos/coryodaniel/jsonapi-resources","forks_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/releases{/id}","deployments_url":"https://api.github.com/repos/coryodaniel/jsonapi-resources/deployments","created_at":"2016-02-13T00:17:18Z","updated_at":"2016-02-13T00:17:19Z","pushed_at":"2016-02-17T18:08:16Z","git_url":"git://github.com/coryodaniel/jsonapi-resources.git","ssh_url":"git@github.com:coryodaniel/jsonapi-resources.git","clone_url":"https://github.com/coryodaniel/jsonapi-resources.git","svn_url":"https://github.com/coryodaniel/jsonapi-resources","homepage":"","size":1792,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cerebris:master","ref":"master","sha":"8e85d68dfbaf9181344c7618b0b29b4cfd362034","user":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"repo":{"id":18248068,"name":"jsonapi-resources","full_name":"cerebris/jsonapi-resources","owner":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerebris/jsonapi-resources","description":"A resource-focused Rails library for developing JSON API compliant servers.","fork":false,"url":"https://api.github.com/repos/cerebris/jsonapi-resources","forks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/cerebris/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerebris/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerebris/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/cerebris/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/cerebris/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/cerebris/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerebris/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/cerebris/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerebris/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/cerebris/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/cerebris/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerebris/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/cerebris/jsonapi-resources/releases{/id}","deployments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/deployments","created_at":"2014-03-29T18:45:23Z","updated_at":"2016-02-17T15:17:05Z","pushed_at":"2016-02-17T18:51:07Z","git_url":"git://github.com/cerebris/jsonapi-resources.git","ssh_url":"git@github.com:cerebris/jsonapi-resources.git","clone_url":"https://github.com/cerebris/jsonapi-resources.git","svn_url":"https://github.com/cerebris/jsonapi-resources","homepage":"","size":2226,"stargazers_count":1011,"watchers_count":1011,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":133,"forks":187,"open_issues":133,"watchers":1011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615"},"html":{"href":"https://github.com/cerebris/jsonapi-resources/pull/615"},"issue":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/615"},"comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/44f8da89218fc30299dd87dd204834cbfa3259a8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lgebhardt","id":29154,"avatar_url":"https://avatars.githubusercontent.com/u/29154?v=3","gravatar_id":"","url":"https://api.github.com/users/lgebhardt","html_url":"https://github.com/lgebhardt","followers_url":"https://api.github.com/users/lgebhardt/followers","following_url":"https://api.github.com/users/lgebhardt/following{/other_user}","gists_url":"https://api.github.com/users/lgebhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/lgebhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgebhardt/subscriptions","organizations_url":"https://api.github.com/users/lgebhardt/orgs","repos_url":"https://api.github.com/users/lgebhardt/repos","events_url":"https://api.github.com/users/lgebhardt/events{/privacy}","received_events_url":"https://api.github.com/users/lgebhardt/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":9,"deletions":9,"changed_files":2}}