{"action":"created","issue":{"url":"https://api.github.com/repos/chef/ohai/issues/722","repository_url":"https://api.github.com/repos/chef/ohai","labels_url":"https://api.github.com/repos/chef/ohai/issues/722/labels{/name}","comments_url":"https://api.github.com/repos/chef/ohai/issues/722/comments","events_url":"https://api.github.com/repos/chef/ohai/issues/722/events","html_url":"https://github.com/chef/ohai/pull/722","id":130863986,"number":722,"title":"Detect paravirt amazon instances without hint files","user":{"login":"tas50","id":1015200,"avatar_url":"https://avatars.githubusercontent.com/u/1015200?v=3","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/ohai/labels/Pending%20Maintainer%20Review","name":"Pending Maintainer Review","color":"eb6420"},{"url":"https://api.github.com/repos/chef/ohai/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-03T00:20:24Z","updated_at":"2016-02-04T11:54:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/ohai/pulls/722","html_url":"https://github.com/chef/ohai/pull/722","diff_url":"https://github.com/chef/ohai/pull/722.diff","patch_url":"https://github.com/chef/ohai/pull/722.patch"},"body":"Official AMIs ship with the ec2metadata binary which we can look for. With this change we should be detecting the majority of scenarios without a hint file.\r\n\r\nhas_ec2_mac has been renamed has_xen_mac since we're actually looking for a xen mac.  Due to that the attempt to connect to the metadata only needs to happen when we only find the mac address since that can be either AWS or Xen.  If we find dmi data, a hint, or the metadata binary we can safely assume the metadata endpoint will respond.\r\n\r\n I also consolidated the \"no hints or signs of AWS\" scenario into a single spec since it seems to make more sense that way."},"comment":{"url":"https://api.github.com/repos/chef/ohai/issues/comments/179789203","html_url":"https://github.com/chef/ohai/pull/722#issuecomment-179789203","issue_url":"https://api.github.com/repos/chef/ohai/issues/722","id":179789203,"user":{"login":"thommay","id":8500,"avatar_url":"https://avatars.githubusercontent.com/u/8500?v=3","gravatar_id":"","url":"https://api.github.com/users/thommay","html_url":"https://github.com/thommay","followers_url":"https://api.github.com/users/thommay/followers","following_url":"https://api.github.com/users/thommay/following{/other_user}","gists_url":"https://api.github.com/users/thommay/gists{/gist_id}","starred_url":"https://api.github.com/users/thommay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thommay/subscriptions","organizations_url":"https://api.github.com/users/thommay/orgs","repos_url":"https://api.github.com/users/thommay/repos","events_url":"https://api.github.com/users/thommay/events{/privacy}","received_events_url":"https://api.github.com/users/thommay/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T11:54:55Z","updated_at":"2016-02-04T11:54:55Z","body":"merge in #723 and then I'm :+1: "}}