{"action":"closed","number":202,"pull_request":{"url":"https://api.github.com/repos/alphagov/government-frontend/pulls/202","id":95691589,"html_url":"https://github.com/alphagov/government-frontend/pull/202","diff_url":"https://github.com/alphagov/government-frontend/pull/202.diff","patch_url":"https://github.com/alphagov/government-frontend/pull/202.patch","issue_url":"https://api.github.com/repos/alphagov/government-frontend/issues/202","number":202,"state":"closed","locked":false,"title":"Use `schema_name` consistently","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"The content item attribute `format` is deprecated.\r\n\r\nalphagov/govuk-content-schemas#444 attempts to remove `format` from the frontend, but the tests for this application fail without `format` in the examples. This is because the tests are testing kind of the wrong thing.\r\n\r\nFor example:\r\n\r\n```\r\nassert_equal schema_item['format'], presented_item.format\r\n```\r\n\r\nChecks the string in `presented_item.format` which actually points to `schema_item['schema_name']`. Because they're `format` and `schema_name` are identical in the examples this worked. Now that we've removed `format` it doesn't anymore.\r\n\r\nhttps://trello.com/c/C8A9bnuO/344-work-on-making-the-document-type-concept-clearer","created_at":"2016-11-29T13:26:13Z","updated_at":"2016-11-30T10:17:07Z","closed_at":"2016-11-30T10:17:07Z","merged_at":"2016-11-30T10:17:07Z","merge_commit_sha":"c7a6c95c510222da18181f3a89cc7e10ba92e8f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/government-frontend/pulls/202/commits","review_comments_url":"https://api.github.com/repos/alphagov/government-frontend/pulls/202/comments","review_comment_url":"https://api.github.com/repos/alphagov/government-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/government-frontend/issues/202/comments","statuses_url":"https://api.github.com/repos/alphagov/government-frontend/statuses/6ce5b21e8bf6fedc51fd3d8b3ff4441a1e693887","head":{"label":"alphagov:use-schema-name","ref":"use-schema-name","sha":"6ce5b21e8bf6fedc51fd3d8b3ff4441a1e693887","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":26582330,"name":"government-frontend","full_name":"alphagov/government-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/government-frontend","description":"Public-facing app to display documents on www.gov.uk/government","fork":false,"url":"https://api.github.com/repos/alphagov/government-frontend","forks_url":"https://api.github.com/repos/alphagov/government-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/government-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/government-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/government-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/government-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/government-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/government-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/government-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/government-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/government-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/government-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/government-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/government-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/government-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/government-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/government-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/government-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/government-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/government-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/government-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/government-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/government-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/government-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/government-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/government-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/government-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/government-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/government-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/government-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/government-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/government-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/government-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/government-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/government-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/government-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/government-frontend/deployments","created_at":"2014-11-13T10:18:07Z","updated_at":"2016-10-31T13:34:52Z","pushed_at":"2016-11-30T10:17:07Z","git_url":"git://github.com/alphagov/government-frontend.git","ssh_url":"git@github.com:alphagov/government-frontend.git","clone_url":"https://github.com/alphagov/government-frontend.git","svn_url":"https://github.com/alphagov/government-frontend","homepage":"","size":1296,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"0215e215fa6c44f94118e6f18fc0364805839cf1","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":26582330,"name":"government-frontend","full_name":"alphagov/government-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/government-frontend","description":"Public-facing app to display documents on www.gov.uk/government","fork":false,"url":"https://api.github.com/repos/alphagov/government-frontend","forks_url":"https://api.github.com/repos/alphagov/government-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/government-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/government-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/government-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/government-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/government-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/government-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/government-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/government-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/government-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/government-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/government-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/government-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/government-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/government-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/government-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/government-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/government-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/government-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/government-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/government-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/government-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/government-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/government-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/government-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/government-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/government-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/government-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/government-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/government-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/government-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/government-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/government-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/government-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/government-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/government-frontend/deployments","created_at":"2014-11-13T10:18:07Z","updated_at":"2016-10-31T13:34:52Z","pushed_at":"2016-11-30T10:17:07Z","git_url":"git://github.com/alphagov/government-frontend.git","ssh_url":"git@github.com:alphagov/government-frontend.git","clone_url":"https://github.com/alphagov/government-frontend.git","svn_url":"https://github.com/alphagov/government-frontend","homepage":"","size":1296,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/government-frontend/pulls/202"},"html":{"href":"https://github.com/alphagov/government-frontend/pull/202"},"issue":{"href":"https://api.github.com/repos/alphagov/government-frontend/issues/202"},"comments":{"href":"https://api.github.com/repos/alphagov/government-frontend/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/government-frontend/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/government-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/government-frontend/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/government-frontend/statuses/6ce5b21e8bf6fedc51fd3d8b3ff4441a1e693887"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":1,"additions":10,"deletions":10,"changed_files":10}}
{"actor":{"display_login":"tijmenb"}}