{"action":"closed","number":1100,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1100","id":88570084,"html_url":"https://github.com/opencontainers/runc/pull/1100","diff_url":"https://github.com/opencontainers/runc/pull/1100.diff","patch_url":"https://github.com/opencontainers/runc/pull/1100.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1100","number":1100,"state":"closed","locked":false,"title":"remove O_SYNC flag to improve logrus' efficiency","user":{"login":"keloyang","id":11223367,"avatar_url":"https://avatars.githubusercontent.com/u/11223367?v=3","gravatar_id":"","url":"https://api.github.com/users/keloyang","html_url":"https://github.com/keloyang","followers_url":"https://api.github.com/users/keloyang/followers","following_url":"https://api.github.com/users/keloyang/following{/other_user}","gists_url":"https://api.github.com/users/keloyang/gists{/gist_id}","starred_url":"https://api.github.com/users/keloyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keloyang/subscriptions","organizations_url":"https://api.github.com/users/keloyang/orgs","repos_url":"https://api.github.com/users/keloyang/repos","events_url":"https://api.github.com/users/keloyang/events{/privacy}","received_events_url":"https://api.github.com/users/keloyang/received_events","type":"User","site_admin":false},"body":"* Why remove O_SYNC\r\nas we know, OpenFile with O_SYNC flag, sync operation come with write every time, this can lead to low efficiency.\r\n\r\n* Necessity of O_SYNC\r\nO_SYNC make sure the data in buffer can be flushed to disk timely, and the log data will not lost。\r\nbut the data in buffer will not lost actually except kernel is panic, so O_SYNC is not necessary for logrus. On the other hand,as practice shows, O_SYNC is not necessary for log, and docker'log (json log driver) also have no use O_SYNC.\r\n\r\nSigned-off-by: Shukui Yang <yangshukui@huawei.com>","created_at":"2016-10-09T06:06:53Z","updated_at":"2016-10-12T00:56:54Z","closed_at":"2016-10-12T00:56:54Z","merged_at":null,"merge_commit_sha":"4d716963ed58f9719b60f023e8b3d7bb9648f4e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1100/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/a9ec23f9dd3f4470ef700c7a703857c9bac8c33c","head":{"label":"keloyang:remove-sync-logrus","ref":"remove-sync-logrus","sha":"a9ec23f9dd3f4470ef700c7a703857c9bac8c33c","user":{"login":"keloyang","id":11223367,"avatar_url":"https://avatars.githubusercontent.com/u/11223367?v=3","gravatar_id":"","url":"https://api.github.com/users/keloyang","html_url":"https://github.com/keloyang","followers_url":"https://api.github.com/users/keloyang/followers","following_url":"https://api.github.com/users/keloyang/following{/other_user}","gists_url":"https://api.github.com/users/keloyang/gists{/gist_id}","starred_url":"https://api.github.com/users/keloyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keloyang/subscriptions","organizations_url":"https://api.github.com/users/keloyang/orgs","repos_url":"https://api.github.com/users/keloyang/repos","events_url":"https://api.github.com/users/keloyang/events{/privacy}","received_events_url":"https://api.github.com/users/keloyang/received_events","type":"User","site_admin":false},"repo":{"id":66764615,"name":"runc","full_name":"keloyang/runc","owner":{"login":"keloyang","id":11223367,"avatar_url":"https://avatars.githubusercontent.com/u/11223367?v=3","gravatar_id":"","url":"https://api.github.com/users/keloyang","html_url":"https://github.com/keloyang","followers_url":"https://api.github.com/users/keloyang/followers","following_url":"https://api.github.com/users/keloyang/following{/other_user}","gists_url":"https://api.github.com/users/keloyang/gists{/gist_id}","starred_url":"https://api.github.com/users/keloyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keloyang/subscriptions","organizations_url":"https://api.github.com/users/keloyang/orgs","repos_url":"https://api.github.com/users/keloyang/repos","events_url":"https://api.github.com/users/keloyang/events{/privacy}","received_events_url":"https://api.github.com/users/keloyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keloyang/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/keloyang/runc","forks_url":"https://api.github.com/repos/keloyang/runc/forks","keys_url":"https://api.github.com/repos/keloyang/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keloyang/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keloyang/runc/teams","hooks_url":"https://api.github.com/repos/keloyang/runc/hooks","issue_events_url":"https://api.github.com/repos/keloyang/runc/issues/events{/number}","events_url":"https://api.github.com/repos/keloyang/runc/events","assignees_url":"https://api.github.com/repos/keloyang/runc/assignees{/user}","branches_url":"https://api.github.com/repos/keloyang/runc/branches{/branch}","tags_url":"https://api.github.com/repos/keloyang/runc/tags","blobs_url":"https://api.github.com/repos/keloyang/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keloyang/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keloyang/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keloyang/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keloyang/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/keloyang/runc/languages","stargazers_url":"https://api.github.com/repos/keloyang/runc/stargazers","contributors_url":"https://api.github.com/repos/keloyang/runc/contributors","subscribers_url":"https://api.github.com/repos/keloyang/runc/subscribers","subscription_url":"https://api.github.com/repos/keloyang/runc/subscription","commits_url":"https://api.github.com/repos/keloyang/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keloyang/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keloyang/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keloyang/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keloyang/runc/contents/{+path}","compare_url":"https://api.github.com/repos/keloyang/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keloyang/runc/merges","archive_url":"https://api.github.com/repos/keloyang/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keloyang/runc/downloads","issues_url":"https://api.github.com/repos/keloyang/runc/issues{/number}","pulls_url":"https://api.github.com/repos/keloyang/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/keloyang/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/keloyang/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keloyang/runc/labels{/name}","releases_url":"https://api.github.com/repos/keloyang/runc/releases{/id}","deployments_url":"https://api.github.com/repos/keloyang/runc/deployments","created_at":"2016-08-28T11:28:31Z","updated_at":"2016-08-28T11:28:32Z","pushed_at":"2016-10-11T06:00:37Z","git_url":"git://github.com/keloyang/runc.git","ssh_url":"git@github.com:keloyang/runc.git","clone_url":"https://github.com/keloyang/runc.git","svn_url":"https://github.com/keloyang/runc","homepage":"https://www.opencontainers.org/","size":3658,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"45c30e75abfd52107b53048004a83165403ad0d1","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-10-11T21:52:57Z","pushed_at":"2016-10-11T23:26:07Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":6411,"stargazers_count":3172,"watchers_count":3172,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":459,"mirror_url":null,"open_issues_count":92,"forks":459,"open_issues":92,"watchers":3172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1100"},"html":{"href":"https://github.com/opencontainers/runc/pull/1100"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1100"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/a9ec23f9dd3f4470ef700c7a703857c9bac8c33c"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"keloyang"}}