{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/77712523","id":77712523,"diff_hunk":"@@ -0,0 +1,317 @@\n+<!--\n+\n+/*\n+** Copyright (c) 2016 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+\n+-->\n+\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>Verify int(bool) uint(bool) float(bool) works correctly (Mac AMD driver bug)</title>\n+<link rel=\"stylesheet\" href=\"../../../resources/js-test-style.css\"/>\n+<script src=\"../../../js/js-test-pre.js\"></script>\n+<script src=\"../../../js/webgl-test-utils.js\"></script>\n+</head>\n+<body>\n+<canvas id=\"canvas\" width=\"2\" height=\"2\"> </canvas>\n+<div id=\"description\"></div>\n+<div id=\"console\"></div>\n+<script id=\"vshader-int1\" type=\"x-shader/x-vertex\">\n+attribute vec3 aPosition;\n+varying mediump float fvalue;\n+uniform bool bvalue;\n+\n+void main() {\n+    gl_Position = vec4(aPosition, 1);\n+    int ivalue = int(bvalue);\n+    if (ivalue == 0) {\n+        fvalue = 0.0;\n+    } else if (ivalue == 1) {\n+        fvalue = 1.0;\n+    } else {\n+        fvalue = -1.0;\n+    }\n+}\n+</script>\n+<script id=\"fshader-int1\" type=\"x-shader/x-fragment\">\n+varying mediump float fvalue;\n+\n+void main() {\n+    if (fvalue == 1.0)","path":"sdk/tests/conformance/glsl/bugs/bool-type-cast-bug.html","position":62,"original_position":62,"commit_id":"e187f44cda742e71d99845437b07e235e58ec446","original_commit_id":"e187f44cda742e71d99845437b07e235e58ec446","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"body":"I think this is fine. 1.0 is precisely representable as a floating-point number. Using an epsilon comparison will just complicate things.","created_at":"2016-09-06T20:30:28Z","updated_at":"2016-09-06T20:30:28Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2009#discussion_r77712523","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/77712523"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2009#discussion_r77712523"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009","id":83877978,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2009","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2009.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2009.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2009","number":2009,"state":"open","locked":false,"title":"Expand int(bool) cast tests to also cover float(bool) and uint(bool)","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"int(true) and uint(true) are incorrect on MacOSX AMD","created_at":"2016-09-02T23:46:17Z","updated_at":"2016-09-06T20:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c37640e63e8204491b8b9e6dae221c36e767da1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2009/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/e187f44cda742e71d99845437b07e235e58ec446","head":{"label":"zhenyao:bool","ref":"bool","sha":"e187f44cda742e71d99845437b07e235e58ec446","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"repo":{"id":5252508,"name":"WebGL","full_name":"zhenyao/WebGL","owner":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhenyao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/zhenyao/WebGL","forks_url":"https://api.github.com/repos/zhenyao/WebGL/forks","keys_url":"https://api.github.com/repos/zhenyao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenyao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenyao/WebGL/teams","hooks_url":"https://api.github.com/repos/zhenyao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/zhenyao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/zhenyao/WebGL/events","assignees_url":"https://api.github.com/repos/zhenyao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/zhenyao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/zhenyao/WebGL/tags","blobs_url":"https://api.github.com/repos/zhenyao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenyao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenyao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenyao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenyao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenyao/WebGL/languages","stargazers_url":"https://api.github.com/repos/zhenyao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/zhenyao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/zhenyao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/zhenyao/WebGL/subscription","commits_url":"https://api.github.com/repos/zhenyao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenyao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenyao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenyao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenyao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/zhenyao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenyao/WebGL/merges","archive_url":"https://api.github.com/repos/zhenyao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenyao/WebGL/downloads","issues_url":"https://api.github.com/repos/zhenyao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/zhenyao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenyao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenyao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenyao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/zhenyao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/zhenyao/WebGL/deployments","created_at":"2012-07-31T22:49:16Z","updated_at":"2015-05-18T22:29:46Z","pushed_at":"2016-09-02T23:46:05Z","git_url":"git://github.com/zhenyao/WebGL.git","ssh_url":"git@github.com:zhenyao/WebGL.git","clone_url":"https://github.com/zhenyao/WebGL.git","svn_url":"https://github.com/zhenyao/WebGL","homepage":null,"size":22724,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"3edf8099a21b87395a4406e75bd70c85aedd8195","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-09-05T17:22:22Z","pushed_at":"2016-09-06T17:56:49Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29704,"stargazers_count":665,"watchers_count":665,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":325,"mirror_url":null,"open_issues_count":78,"forks":325,"open_issues":78,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2009"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2009"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2009/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2009/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/e187f44cda742e71d99845437b07e235e58ec446"}}}}
{"actor":{"display_login":"kenrussell"}}