{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/1940","repository_url":"https://api.github.com/repos/hyperledger/fabric","labels_url":"https://api.github.com/repos/hyperledger/fabric/issues/1940/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1940/comments","events_url":"https://api.github.com/repos/hyperledger/fabric/issues/1940/events","html_url":"https://github.com/hyperledger/fabric/pull/1940","id":161487919,"number":1940,"title":"Issues/1922/grpcio pip install: Moved from Makefile to hosts.sh script, varant destroy/up required","user":{"login":"jeffgarratt","id":4991920,"avatar_url":"https://avatars.githubusercontent.com/u/4991920?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffgarratt","html_url":"https://github.com/jeffgarratt","followers_url":"https://api.github.com/users/jeffgarratt/followers","following_url":"https://api.github.com/users/jeffgarratt/following{/other_user}","gists_url":"https://api.github.com/users/jeffgarratt/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffgarratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffgarratt/subscriptions","organizations_url":"https://api.github.com/users/jeffgarratt/orgs","repos_url":"https://api.github.com/users/jeffgarratt/repos","events_url":"https://api.github.com/users/jeffgarratt/events{/privacy}","received_events_url":"https://api.github.com/users/jeffgarratt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-06-21T16:53:59Z","updated_at":"2016-06-24T15:57:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1940","html_url":"https://github.com/hyperledger/fabric/pull/1940","diff_url":"https://github.com/hyperledger/fabric/pull/1940.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1940.patch"},"body":"## Description\r\nMoved the pip install of the python grpc package from the Makefile to the hosts.sh file.  This will require developers perform a vagrant destroy/up cycle.  Also moved all grpc related usage in python to bdd_grpc_util.py module.\r\n\r\n## Motivation and Context\r\nThe Makefile mechanism is causing a problem in Travis CI.\r\n\r\n\r\n## How Has This Been Tested?\r\nGoing to verify through this PRs verification process.\r\n\r\n## Checklist:\r\n- [X] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff).\r\n- [X] I have either added documentation to cover my changes or this change requires no new documentation.\r\n- [X] I have either added unit tests to cover my changes or this change requires no new tests.\r\n- [X] I have run [golint](https://github.com/golang/lint) and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.\r\n\r\nThe continuous integration build process will run [make checks](https://github.com/hyperledger/fabric/blob/master/Makefile#L22) to confirm that tests pass and that code quality meets minimum standards. You may optionally run this locally as PRs will not be accepted until they pass.\r\n\r\nSigned-off-by: Jeff Garratt garratt.jeff@gmail.com\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/comments/228384995","html_url":"https://github.com/hyperledger/fabric/pull/1940#issuecomment-228384995","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1940","id":228384995,"user":{"login":"jeffgarratt","id":4991920,"avatar_url":"https://avatars.githubusercontent.com/u/4991920?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffgarratt","html_url":"https://github.com/jeffgarratt","followers_url":"https://api.github.com/users/jeffgarratt/followers","following_url":"https://api.github.com/users/jeffgarratt/following{/other_user}","gists_url":"https://api.github.com/users/jeffgarratt/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffgarratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffgarratt/subscriptions","organizations_url":"https://api.github.com/users/jeffgarratt/orgs","repos_url":"https://api.github.com/users/jeffgarratt/repos","events_url":"https://api.github.com/users/jeffgarratt/events{/privacy}","received_events_url":"https://api.github.com/users/jeffgarratt/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T15:57:57Z","updated_at":"2016-06-24T15:57:57Z","body":"@ghaskins @rameshthoomu @gongsu832 @tuand27613 Think we are still waiting on https://github.com/hyperledger/fabric/issues/1922.  Will work @tuand27613 and see if I can aid."}}
{"actor":{"display_login":"jeffgarratt"}}