{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/92397788","pull_request_review_id":12911535,"id":92397788,"diff_hunk":"@@ -144,6 +149,7 @@ func IsDNS1035Label(value string) []string {\n // - valid: *.bar.com, *.foo.bar.com\n // - invalid: *.*.bar.com, *.foo.*.com, *bar.com, f*.bar.com, *\n const wildcardDNS1123SubdomainFmt = \"\\\\*\\\\.\" + dns1123SubdomainFmt\n+const wildcardDNS1123SubdomainErrMsg = \"a valid wildcard DNS (RFC 1123) subdomain label must start with '*.', followed by a valid DNS subdomain name, which must consist of lower case alphanumeric character, '-' or '.' and end with an alphanumeric character\"","path":"pkg/util/validation/validation.go","position":92,"original_position":92,"commit_id":"9064eb998c3218d4418032b896d902e094c2a739","original_commit_id":"9064eb998c3218d4418032b896d902e094c2a739","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Pluralize first `character`: `must consist of lower case alphanumeric characters, ...`","created_at":"2016-12-14T14:01:56Z","updated_at":"2016-12-14T14:01:56Z","html_url":"https://github.com/kubernetes/kubernetes/pull/38090#discussion_r92397788","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/92397788"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38090#discussion_r92397788"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090","id":96481235,"html_url":"https://github.com/kubernetes/kubernetes/pull/38090","diff_url":"https://github.com/kubernetes/kubernetes/pull/38090.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38090.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38090","number":38090,"state":"open","locked":false,"title":"Improve error message for name/label validation.","user":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"body":"Instead of just providing regex in name/label validation error output, we need to add the naming rules of the name/label, which is more end-user readable.\r\n\r\nFixed #37654","created_at":"2016-12-05T07:34:13Z","updated_at":"2016-12-14T14:01:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e98ee07437eb829796aa7d8054319a83dcd191cd","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38090/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9064eb998c3218d4418032b896d902e094c2a739","head":{"label":"xingzhou:kube-37654","ref":"kube-37654","sha":"9064eb998c3218d4418032b896d902e094c2a739","user":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"repo":{"id":64464580,"name":"kubernetes","full_name":"xingzhou/kubernetes","owner":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xingzhou/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/xingzhou/kubernetes","forks_url":"https://api.github.com/repos/xingzhou/kubernetes/forks","keys_url":"https://api.github.com/repos/xingzhou/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xingzhou/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xingzhou/kubernetes/teams","hooks_url":"https://api.github.com/repos/xingzhou/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xingzhou/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xingzhou/kubernetes/events","assignees_url":"https://api.github.com/repos/xingzhou/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xingzhou/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xingzhou/kubernetes/tags","blobs_url":"https://api.github.com/repos/xingzhou/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xingzhou/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xingzhou/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xingzhou/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xingzhou/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xingzhou/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xingzhou/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xingzhou/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xingzhou/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xingzhou/kubernetes/subscription","commits_url":"https://api.github.com/repos/xingzhou/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xingzhou/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xingzhou/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xingzhou/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xingzhou/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xingzhou/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xingzhou/kubernetes/merges","archive_url":"https://api.github.com/repos/xingzhou/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xingzhou/kubernetes/downloads","issues_url":"https://api.github.com/repos/xingzhou/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xingzhou/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xingzhou/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xingzhou/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xingzhou/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xingzhou/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xingzhou/kubernetes/deployments","created_at":"2016-07-29T08:30:52Z","updated_at":"2016-07-29T08:31:36Z","pushed_at":"2016-12-14T08:12:58Z","git_url":"git://github.com/xingzhou/kubernetes.git","ssh_url":"git@github.com:xingzhou/kubernetes.git","clone_url":"https://github.com/xingzhou/kubernetes.git","svn_url":"https://github.com/xingzhou/kubernetes","homepage":"http://kubernetes.io","size":367470,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"af23f40f82ce9b356cf6d78d67400aef7c013543","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-14T13:52:26Z","pushed_at":"2016-12-14T13:54:42Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":473864,"stargazers_count":19239,"watchers_count":19239,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6400,"mirror_url":null,"open_issues_count":5381,"forks":6400,"open_issues":5381,"watchers":19239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38090"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38090"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38090/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38090/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9064eb998c3218d4418032b896d902e094c2a739"}}}}
{"actor":{"display_login":"smarterclayton"}}