{"action":"closed","number":2281,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281","id":80771428,"html_url":"https://github.com/openshift/openshift-ansible/pull/2281","diff_url":"https://github.com/openshift/openshift-ansible/pull/2281.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2281.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2281","number":2281,"state":"closed","locked":false,"title":"a-o-i: flexible to set openshift_hostname and openshift_public_hostname","user":{"login":"ganhuang","id":15881433,"avatar_url":"https://avatars.githubusercontent.com/u/15881433?v=3","gravatar_id":"","url":"https://api.github.com/users/ganhuang","html_url":"https://github.com/ganhuang","followers_url":"https://api.github.com/users/ganhuang/followers","following_url":"https://api.github.com/users/ganhuang/following{/other_user}","gists_url":"https://api.github.com/users/ganhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/ganhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganhuang/subscriptions","organizations_url":"https://api.github.com/users/ganhuang/orgs","repos_url":"https://api.github.com/users/ganhuang/repos","events_url":"https://api.github.com/users/ganhuang/events{/privacy}","received_events_url":"https://api.github.com/users/ganhuang/received_events","type":"User","site_admin":false},"body":"In my previous testing on OpenStack (Neutron deployment), we're bothered that 'openshift_hostname' and 'openshift_public_hostname' is set to [instance_name].novalocal by quick-installer, this hostname can't be resloved in Neutron deployment (only host-192-168-2-xx can be resloved by internal dns). Thus we have to modify installer.cfg.yml manually, this is really not convenient. \r\n\r\n(Note: in nova-network deployment, [instance_name].novalocal can be resloved successfully, but nova-network has been deprecated in recent OpenStack releases)\r\n\r\nSo if users input a hostname instead of ip address, it's better to apply the hostname to the values of \"openshift_hostname\" and \"openshift_public_hostname\" directly.","created_at":"2016-08-10T10:36:23Z","updated_at":"2016-09-06T22:12:31Z","closed_at":"2016-09-06T22:12:31Z","merged_at":null,"merge_commit_sha":"9ac03784d6d614c96ad00c55556f311423748ae0","assignee":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"assignees":[{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2281/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/0ba7d66dcd655acf5c43494029ec609d0c0696a2","head":{"label":"ganhuang:flexible_hostname","ref":"flexible_hostname","sha":"0ba7d66dcd655acf5c43494029ec609d0c0696a2","user":{"login":"ganhuang","id":15881433,"avatar_url":"https://avatars.githubusercontent.com/u/15881433?v=3","gravatar_id":"","url":"https://api.github.com/users/ganhuang","html_url":"https://github.com/ganhuang","followers_url":"https://api.github.com/users/ganhuang/followers","following_url":"https://api.github.com/users/ganhuang/following{/other_user}","gists_url":"https://api.github.com/users/ganhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/ganhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganhuang/subscriptions","organizations_url":"https://api.github.com/users/ganhuang/orgs","repos_url":"https://api.github.com/users/ganhuang/repos","events_url":"https://api.github.com/users/ganhuang/events{/privacy}","received_events_url":"https://api.github.com/users/ganhuang/received_events","type":"User","site_admin":false},"repo":{"id":65342856,"name":"openshift-ansible","full_name":"ganhuang/openshift-ansible","owner":{"login":"ganhuang","id":15881433,"avatar_url":"https://avatars.githubusercontent.com/u/15881433?v=3","gravatar_id":"","url":"https://api.github.com/users/ganhuang","html_url":"https://github.com/ganhuang","followers_url":"https://api.github.com/users/ganhuang/followers","following_url":"https://api.github.com/users/ganhuang/following{/other_user}","gists_url":"https://api.github.com/users/ganhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/ganhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganhuang/subscriptions","organizations_url":"https://api.github.com/users/ganhuang/orgs","repos_url":"https://api.github.com/users/ganhuang/repos","events_url":"https://api.github.com/users/ganhuang/events{/privacy}","received_events_url":"https://api.github.com/users/ganhuang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ganhuang/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/ganhuang/openshift-ansible","forks_url":"https://api.github.com/repos/ganhuang/openshift-ansible/forks","keys_url":"https://api.github.com/repos/ganhuang/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ganhuang/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ganhuang/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/ganhuang/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/ganhuang/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ganhuang/openshift-ansible/events","assignees_url":"https://api.github.com/repos/ganhuang/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ganhuang/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ganhuang/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/ganhuang/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ganhuang/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ganhuang/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ganhuang/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ganhuang/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ganhuang/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/ganhuang/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/ganhuang/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/ganhuang/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/ganhuang/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/ganhuang/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ganhuang/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ganhuang/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ganhuang/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ganhuang/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ganhuang/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ganhuang/openshift-ansible/merges","archive_url":"https://api.github.com/repos/ganhuang/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ganhuang/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/ganhuang/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ganhuang/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ganhuang/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ganhuang/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ganhuang/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ganhuang/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ganhuang/openshift-ansible/deployments","created_at":"2016-08-10T02:14:37Z","updated_at":"2016-08-10T02:14:43Z","pushed_at":"2016-09-04T09:35:01Z","git_url":"git://github.com/ganhuang/openshift-ansible.git","ssh_url":"git@github.com:ganhuang/openshift-ansible.git","clone_url":"https://github.com/ganhuang/openshift-ansible.git","svn_url":"https://github.com/ganhuang/openshift-ansible","homepage":"install.openshift.com","size":6136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f555b4c341ff96d3c4f6bd86919c1a47b1193b0e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-09-06T01:47:33Z","pushed_at":"2016-09-06T20:55:55Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":7980,"stargazers_count":236,"watchers_count":236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":379,"mirror_url":null,"open_issues_count":326,"forks":379,"open_issues":326,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2281"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2281"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2281/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2281/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/0ba7d66dcd655acf5c43494029ec609d0c0696a2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ganhuang"}}