{"push_id":1187911144,"size":281,"distinct_size":46,"ref":"refs/heads/master","head":"7d7753e4ca4ea6ef040685e366e5eb0db787754c","before":"e3d81adedd2cc596b931ae5ba8590ff8d0e82c5f","commits":[{"sha":"35666f1c4e490f1c3ba9788d314c28172a28d771","author":{"name":"Lance Richardson","email":"529d81928dd60beeaf299499acfc13e39cc028fb@redhat.com"},"message":"rhel: Add 'rpm-fedora' and 'rpm-fedora-kmod' targets\n\nAdd make targets for Fedora and RHEL7 RPMs, update INSTALL.Fedora.md\nto document their use\n\nAdded distribution tarball and rpm build directory to .gitignore.\n\nSigned-off-by: Lance Richardson <lrichard@redhat.com>\nAcked-by: Flavio Leitner <fbl@sysclose.org>\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/35666f1c4e490f1c3ba9788d314c28172a28d771"},{"sha":"ab83c8c571df1fde72f7b75375ecc389d9e82c3e","author":{"name":"Jarno Rajahalme","email":"34c96149e0f84eb25c9df6d97f4a94ff9adedc00@ovn.org"},"message":"odp-util: Use FLOW_MAX_MPLS_LABELS when parsing MPLS ODP keys.\n\nEven though the number of supported MPLS labels may vary between a\ndatapath and the OVS userspace, it is better to use the\nFLOW_MAX_MPLS_LABELS than a hard-coded '3' as the maximum number of\nlabels to scan.\n\nRequested-by: Ben Pfaff <blp@ovn.org>\nSigned-off-by: Jarno Rajahalme <jarno@ovn.org>\nAcked-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/ab83c8c571df1fde72f7b75375ecc389d9e82c3e"},{"sha":"06d4d4b68726d9cf153577a4a2287f944276f0d7","author":{"name":"Jarno Rajahalme","email":"34c96149e0f84eb25c9df6d97f4a94ff9adedc00@ovn.org"},"message":"ofp: Add support for bundles extension in OpenFlow 1.3.\n\nONF Extension 230 adds support for OpenFlow 1.4 bundles to OpenFlow\n1.3.  Supporting this allows OpenFlow 1.3 controllers to start using\nbundles.  Also the ovs-ofctl '--bundle' option can now be used with\nOpenFlow 1.3.\n\nSigned-off-by: Jarno Rajahalme <jarno@ovn.org>\nAcked-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/06d4d4b68726d9cf153577a4a2287f944276f0d7"},{"sha":"d0a46cb4608e632f5028034762f0adde2ce947a0","author":{"name":"Russell Bryant","email":"fd8b60c701e625cd87d3295450968ba52715a0a5@ovn.org"},"message":"ofpbuf: Fix trivial spelling typo.\n\ns/bofy/body/. I noticed this spelling typo while reading this header\nfile.\n\nSigned-off-by: Russell Bryant <russell@ovn.org>\nAcked-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/d0a46cb4608e632f5028034762f0adde2ce947a0"},{"sha":"0bf765f753fd6cfde4918be49474fcd20659ceaa","author":{"name":"Ian Stokes","email":"d178f7405cf7a5f807b7140b290295f548f228a1@intel.com"},"message":"netdev_dpdk.c: Add QoS functionality.\n\nThis patch provides the modifications required in netdev-dpdk.c and\nvswitch.xml to allow for a DPDK user space QoS algorithm.\n\nThis patch adds a QoS configuration structure for netdev-dpdk and\nexpected QoS operations 'dpdk_qos_ops'. Various helper functions\nare also supplied.\n\nAlso included are the modifications required for vswitch.xml to allow a\nnew QoS implementation for netdev-dpdk devices. This includes a new QoS type\n`egress-policer` as well as its expected QoS table entries.\n\nThe QoS functionality implemented for DPDK devices is `egress-policer`.\nThis can be used to drop egress packets at a configurable rate.\n\nThe INSTALL.DPDK.md guide has also been modified to provide an example\nconfiguration of `egress-policer` QoS.\n\nSigned-off-by: Ian Stokes <ian.stokes@intel.com>\nAcked-by: Flavio Leitner <fbl@sysclose.org>\nAcked-by: Daniele Di Proietto <diproiettod@vmware.com>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/0bf765f753fd6cfde4918be49474fcd20659ceaa"},{"sha":"d60a9c21939c73efb17acf950e9e6cf33f7cadd9","author":{"name":"mweglicx","email":"9cb8e8f0ba29a5b24d808692cbc19d48b2322c9d@intel.com"},"message":"INSTALL.DPDK.md: Installation steps correction for DPDK 2.2.\n\nMissing step added to INSTALL.DPDK.md which prevents\ninstallation error message.\n\nSigned-off-by: Michal Weglicki <michalx.weglicki@intel.com>\nAcked-by: Flavio Leitner <fbl@sysclose.org>\nSigned-off-by: Daniele Di Proietto <diproiettod@vmware.com>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/d60a9c21939c73efb17acf950e9e6cf33f7cadd9"},{"sha":"3a103e4a99d1d66344277473a5618c34321a59a0","author":{"name":"Russell Bryant","email":"fd8b60c701e625cd87d3295450968ba52715a0a5@ovn.org"},"message":"ovs-ofctl.8: commit is required with alg in ct().\n\nThe \"alg=\" argument to the ct() action only makes sense when used in\ncombination with \"commit\".  Add this to the documentation to help make\nit clear.\n\nSigned-off-by: Russell Bryant <russell@ovn.org>\nAcked-by: Justin Pettit <jpettit@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/3a103e4a99d1d66344277473a5618c34321a59a0"},{"sha":"8b8ef592521e32d0e32581bf39c5d2a5cd445977","author":{"name":"Joe Stringer","email":"d2ff8d83efb8d5aeb4f4e85388fa7e6f5a2df730@ovn.org"},"message":"tests: Add bundle action test with buffer realloc.\n\nAdd a test which causes internal reallocation of the ofpacts buffer,\nfollowed by a large bundle action which should cause a subsequent\nreallocation while decoding slave ports. Running this test under\nvalgrind reveals the issue below, which is fixed in the following\ncommit.\n\nInvalid read of size 4\n   at 0x4CED87: decode_bundle (ofp-actions.c:1253)\n   by 0x4CEDFC: decode_NXAST_RAW_BUNDLE (ofp-actions.c:1272)\n   by 0x4DBDE6: ofpact_decode (ofp-actions.inc2:3765)\n   by 0x4D6914: ofpacts_decode (ofp-actions.c:5735)\n   by 0x4D6A3D: ofpacts_pull_openflow_actions__ (ofp-actions.c:5772)\n   by 0x4D74F3: ofpacts_pull_openflow_instructions (ofp-actions.c:6352)\n   by 0x4F59FA: ofputil_decode_flow_mod (ofp-util.c:1704)\n   by 0x4EAD18: ofp_print_flow_mod (ofp-print.c:786)\n   by 0x4F0711: ofp_to_string__ (ofp-print.c:3220)\n   by 0x4F0D98: ofp_to_string (ofp-print.c:3453)\n   by 0x5486B3: do_recv (vconn.c:644)\n   by 0x548498: vconn_recv (vconn.c:598)\n   by 0x524582: rconn_recv (rconn.c:703)\n   by 0x45DA61: ofconn_run (connmgr.c:1370)\n   by 0x45B3B4: connmgr_run (connmgr.c:323)\n   by 0x41D1E8: ofproto_run (ofproto.c:1762)\n   by 0x40CEE0: bridge_run__ (bridge.c:2885)\n   by 0x40D093: bridge_run (bridge.c:2940)\n   by 0x412F7E: main (ovs-vswitchd.c:120)\nAddress 0x66aa460 is 1,152 bytes inside a block of size 1,184 free'd\n   at 0x4C2AF2E: realloc (vg_replace_malloc.c:692)\n   by 0x543D27: xrealloc (util.c:123)\n   by 0x5089EF: ofpbuf_resize__ (ofpbuf.c:243)\n   by 0x508B81: ofpbuf_prealloc_tailroom (ofpbuf.c:290)\n   by 0x508D5C: ofpbuf_put_uninit (ofpbuf.c:364)\n   by 0x508DEF: ofpbuf_put (ofpbuf.c:387)\n   by 0x4CED7D: decode_bundle (ofp-actions.c:1255)\n   by 0x4CEDFC: decode_NXAST_RAW_BUNDLE (ofp-actions.c:1272)\n   by 0x4DBDE6: ofpact_decode (ofp-actions.inc2:3765)\n   by 0x4D6914: ofpacts_decode (ofp-actions.c:5735)\n   by 0x4D6A3D: ofpacts_pull_openflow_actions__ (ofp-actions.c:5772)\n   by 0x4D74F3: ofpacts_pull_openflow_instructions (ofp-actions.c:6352)\n   by 0x4F59FA: ofputil_decode_flow_mod (ofp-util.c:1704)\n   by 0x4EAD18: ofp_print_flow_mod (ofp-print.c:786)\n   by 0x4F0711: ofp_to_string__ (ofp-print.c:3220)\n   by 0x4F0D98: ofp_to_string (ofp-print.c:3453)\n   by 0x5486B3: do_recv (vconn.c:644)\n   by 0x548498: vconn_recv (vconn.c:598)\n   by 0x524582: rconn_recv (rconn.c:703)\n   by 0x45DA61: ofconn_run (connmgr.c:1370)\n\nSigned-off-by: Joe Stringer <joe@ovn.org>\nAcked-by: Jarno Rajahalme <jarno@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/8b8ef592521e32d0e32581bf39c5d2a5cd445977"},{"sha":"19b58f3cbcb3191432eefba3a504376399cc07a7","author":{"name":"Joe Stringer","email":"d2ff8d83efb8d5aeb4f4e85388fa7e6f5a2df730@ovn.org"},"message":"ofp-actions: Fix use-after-free in bundle action.\n\nIf the actions list in an incoming flow mod is long enough, and there is\na bundle() action with 3 or more slaves, then it is possible for a\nreallocation to occur after placing the ofpact_bundle into the ofpacts\nbuffer, while slave ports into the buffer. If the memory freed by this\nreallocation is then passed to another thread, then that thread may\nmodify the value that bundle->n_slaves points to. If this occurs quickly\nenough before the main thread finishes copying all of the slaves, then\nthe iteration may continue beyond the originally intended number of\nslaves, copying (and swapping) an undetermined number of 2-byte chunks\nfrom the openflow message. Finally, the length of the ofpact will be\nupdated based on how much data was written to the buffer, which may be\nsignificantly longer than intended.\n\nIn many cases, the freed memory may not be allocated to another thread\nand be left untouched. In some milder bug cases, this will lead to\n'bundle' actions using more memory than required. In more serious cases,\nthis length may then exceed the maximum length of an OpenFlow action,\nwhich is then stored (truncated) into the 16-bit length field in the\nofpact header. Later execution of ofpacts_verify() would then use this\nlength to iterate through the ofpacts, and may dereference memory in\nunintended ways, causing crashes or infinite loops by attempting to\nparse/validate arbitrary data as ofpact objects.\n\nFix the issue by updating 'bundle' within the iteration, immediately\nafter (potentially) expanding the bundle.\n\nThanks to Jarno Rajahalme for his keen pair of eyes on finding this\nissue.\n\nVMWare-BZ: #1614715\nFixes: f25d0cf3c366 (\"Introduce ofpacts, an abstraction of OpenFlow actions.\")\nSigned-off-by: Joe Stringer <joe@ovn.org>\nAcked-by: Jarno Rajahalme <jarno@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/19b58f3cbcb3191432eefba3a504376399cc07a7"},{"sha":"5308056f53406e75d211f73a2847f9ebdf9c91c8","author":{"name":"Joe Stringer","email":"d2ff8d83efb8d5aeb4f4e85388fa7e6f5a2df730@ovn.org"},"message":"ofp-actions: Prevent integer overflow in decode.\n\nWhen decoding a variable-length action, if the length of the action\nexceeds the length storable in a uint16_t then something has gone\nterribly wrong. Assert that this is not the case.\n\nSigned-off-by: Joe Stringer <joe@ovn.org>\nAcked-by: Jarno Rajahalme <jarno@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/5308056f53406e75d211f73a2847f9ebdf9c91c8"},{"sha":"c391558c30d7d7eb5c20da3ba0cd4700b6890962","author":{"name":"Joe Stringer","email":"d2ff8d83efb8d5aeb4f4e85388fa7e6f5a2df730@ovn.org"},"message":"ofpbuf: Use ptrdiff_t for pointer delta.\n\nSigned-off-by: Joe Stringer <joe@ovn.org>\nAcked-by: Jarno Rajahalme <jarno@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/c391558c30d7d7eb5c20da3ba0cd4700b6890962"},{"sha":"c26d70a2452ad0d7a13b72c94641d08001283119","author":{"name":"Pravin B Shelar","email":"7be20214bc2736ed9c11d782ce7520915155858b@ovn.org"},"message":"datapath: STT: Fix checksum handling.\n\nOn packet receive STT verifies the checksum if not done in\nhardware. But IP and TCP were pulled before the verification\nstep. The verification expect to see packet with TCP header.\nThis causes STT to drop packet in certain cases.\n\nSigned-off-by: Pravin B Shelar <pshelar@ovn.org>\nAcked-by: Joe Stringer <joe@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/c26d70a2452ad0d7a13b72c94641d08001283119"},{"sha":"6019cb63956dc87afd130c31ac17137d1304a931","author":{"name":"Ilya Maximets","email":"8d2b0d23d2491417bf557dc7d3765b880009af04@samsung.com"},"message":"netdev-dpdk: Fix memory leak in netdev_dpdk_vhost_destruct().\n\nFixes: 4573fbd38fa1 (\"netdev-dpdk: Add vhost-user multiqueue support\")\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\nAcked-by: Flavio Leitner <fbl@sysclose.org>\nAcked-by: Daniele Di Proietto <diproiettod@vmware.com>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/6019cb63956dc87afd130c31ac17137d1304a931"},{"sha":"8520deefbf208b24518c2bf67baad6d230f39dc0","author":{"name":"bschanmu@redhat.com","email":"d176b18492c4a22f4574028543035df12e2c5905@redhat.com"},"message":"Use 'RUNDIR' from make for rhel/ovn-controller.service\n\nPerviously it was using the platform's runtime directory which can be\ndifferent from the runtime directory of ovsdb-server started by the\nopenvswitch service\n\nSigned-off-by: Babu Shanmugam <bschanmu@redhat.com>\nAcked-by: Flavio Leitner <fbl@sysclose.org>\nSigned-off-by: Russell Bryant <russell@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/8520deefbf208b24518c2bf67baad6d230f39dc0"},{"sha":"3a83007a76bbf05144cee1fda7ad81c1c717dca7","author":{"name":"Ramu Ramamurthy","email":"fb1e6149bd7c9b4871977d45960e0ba80d28e924@gmail.com"},"message":"ovn-controller: race between binding-run and patch-run for localnet ports\n\nwhen ctx->ovnsb_idl_txn is null, binding_run exits early\nand does not add any local_datapaths, but patch_run\ndoesnt check this, and ends up deleting localnet ports,\nbecause there are no local datapaths for them,\nThey get readded in a subsequent run causing unnecessary\ndeletion and readdition.\n\nSigned-off-by: Ramu Ramamurthy <ramu.ramamurthy@us.ibm.com>\nSigned-off-by: Russell Bryant <russell@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/3a83007a76bbf05144cee1fda7ad81c1c717dca7"},{"sha":"674da62d386c17b84d88555cd57743e2a58aa766","author":{"name":"Russell Bryant","email":"fd8b60c701e625cd87d3295450968ba52715a0a5@ovn.org"},"message":"AUTHORS: Add Ramu Ramamurthy.\n\nRamu is the author of 3a83007a76bbf05144cee1fda7ad81c1c717dca7.\n\nSigned-off-by: Russell Bryant <russell@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/674da62d386c17b84d88555cd57743e2a58aa766"},{"sha":"b1b401391a910a72b6d683712139084ae1025e1c","author":{"name":"Jarno Rajahalme","email":"34c96149e0f84eb25c9df6d97f4a94ff9adedc00@ovn.org"},"message":"ofpbuf: Make offset calculation more consistent.\n\nUse the same method of offset calculation in\nofpbuf_clone_with_headroom() as in ofpbuf_resize__().\n\nSigned-off-by: Jarno Rajahalme <jarno@ovn.org>\nAcked-by: Joe Stringer <joe@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/b1b401391a910a72b6d683712139084ae1025e1c"},{"sha":"742c06cc8861aec292e2fafd1d161c7b7929fd81","author":{"name":"Jarno Rajahalme","email":"34c96149e0f84eb25c9df6d97f4a94ff9adedc00@ovn.org"},"message":"ofpbuf: Rename 'data_delta' to 'xxx_offset'\n\nUsing more accurate and descriptive variable names improves code\nreadability.\n\nSigned-off-by: Jarno Rajahalme <jarno@ovn.org>\nAcked-by: Joe Stringer <joe@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/742c06cc8861aec292e2fafd1d161c7b7929fd81"},{"sha":"aacaeb373079bf774770c0f7f183873a6ce9bbb4","author":{"name":"Jarno Rajahalme","email":"34c96149e0f84eb25c9df6d97f4a94ff9adedc00@ovn.org"},"message":"ofpbuf: Fix setting of 'msg' in ofpbuf_clone_with_headroom()\n\nCommit 38876d31 fixed setting 'msg' when resizing an ofpbuf, but\nfailed to fix the same issue in ofpbuf_clone_with_headroom().  Without\nthis fix the newly cloned ofpbuf's 'msg', if non-NULL, will point to\nthe buffer of the original ofpbuf.\n\nSigned-off-by: Jarno Rajahalme <jarno@ovn.org>\nAcked-by: Joe Stringer <joe@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/aacaeb373079bf774770c0f7f183873a6ce9bbb4"},{"sha":"81bec2c9bc5362597950058cdbf6b0165f84a92d","author":{"name":"William Tu","email":"be7c2c62e54536945948a4b5dbf304c85c346c2a@gmail.com"},"message":"ofpbuf: Fix use-after-free in bundle parse.\n\nAddress pointed by bundle could be obsolete/free'd when\nrealloc, called from ofpbuf_put_zero(), returns new address.\nReported by Valgrind 367: ovs-ofctl parse-flows (NXM)\n\nInvalid write of size 4\n    bundle_parse__ (bundle.c:200)\n    bundle_parse_load (bundle.c:272)\n    parse_bundle_load (ofp-actions.c:1324)\n    ofpacts_parse__ (ofp-actions.c:7484)\n    ofpacts_parse (ofp-actions.c:7540)\n    ofpacts_parse_copy (ofp-actions.c:7558)\n    parse_ofp_str__ (ofp-parse.c:491)\n    parse_ofp_str (ofp-parse.c:544)\n    parse_ofp_flow_mod_str (ofp-parse.c:870)\n\nAddress 0x7a4e96c is 12 bytes inside a block of size 64 free'd\n    free (vg_replace_malloc.c:530)\n    ofpbuf_resize__ (ofpbuf.c:246) (purposely add to force using new buf)\n    ofpbuf_put_zeros (ofpbuf.c:375)\n    bundle_parse__ (bundle.c:181)\n    bundle_parse_load (bundle.c:272)\n    parse_bundle_load (ofp-actions.c:1324)\n    ofpacts_parse__ (ofp-actions.c:7484)\n    ofpacts_parse (ofp-actions.c:7540)\n    ofpacts_parse_copy (ofp-actions.c:7558)\n\nSigned-off-by: William Tu <u9012063@gmail.com>\nSigned-off-by: Joe Stringer <joe@ovn.org>","distinct":false,"url":"https://api.github.com/repos/sebastian-arguello/ovs/commits/81bec2c9bc5362597950058cdbf6b0165f84a92d"}]}
{"actor":{"display_login":"sebastian-arguello"}}