{"action":"created","issue":{"url":"https://api.github.com/repos/edx/codejail/issues/48","repository_url":"https://api.github.com/repos/edx/codejail","labels_url":"https://api.github.com/repos/edx/codejail/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/edx/codejail/issues/48/comments","events_url":"https://api.github.com/repos/edx/codejail/issues/48/events","html_url":"https://github.com/edx/codejail/pull/48","id":164595735,"number":48,"title":"Fixing django integration.","user":{"login":"jcdyer","id":77486,"avatar_url":"https://avatars.githubusercontent.com/u/77486?v=3","gravatar_id":"","url":"https://api.github.com/users/jcdyer","html_url":"https://github.com/jcdyer","followers_url":"https://api.github.com/users/jcdyer/followers","following_url":"https://api.github.com/users/jcdyer/following{/other_user}","gists_url":"https://api.github.com/users/jcdyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdyer/subscriptions","organizations_url":"https://api.github.com/users/jcdyer/orgs","repos_url":"https://api.github.com/users/jcdyer/repos","events_url":"https://api.github.com/users/jcdyer/events{/privacy}","received_events_url":"https://api.github.com/users/jcdyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-08T19:03:08Z","updated_at":"2016-07-11T17:26:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/codejail/pulls/48","html_url":"https://github.com/edx/codejail/pull/48","diff_url":"https://github.com/edx/codejail/pull/48.diff","patch_url":"https://github.com/edx/codejail/pull/48.patch"},"body":"Apparently, there were zero tests on django integration, and I introduced an error into that code, which was causing failures in edx-platform. Additionally, the django integration only worked with a single codejail named \"python.\"  This allows multiple jails to be configured in django settings, but maintains backwards compatibility with existing configuration.\r\n\r\n(There are further errors on edx-platform due to jails not being configured for tests.  The jails were previously configured using codejail's unsafe autoconfiguration mechanism.  Fixing that needs to happen on the edx-platform side, and is being addressed in https://github.com/edx/edx-platform/pull/12891)\r\n\r\n### Testing\r\n- [ ] Unit tests\r\n\r\n### Reviewers\r\n- [ ] @nedbat \r\n- [ ] @efischer19 \r\n- [ ] devops review: @e0d / @feanil \r\n\r\n### Post-review tasks\r\n- [ ] squash commits"},"comment":{"url":"https://api.github.com/repos/edx/codejail/issues/comments/231803935","html_url":"https://github.com/edx/codejail/pull/48#issuecomment-231803935","issue_url":"https://api.github.com/repos/edx/codejail/issues/48","id":231803935,"user":{"login":"efischer19","id":7373924,"avatar_url":"https://avatars.githubusercontent.com/u/7373924?v=3","gravatar_id":"","url":"https://api.github.com/users/efischer19","html_url":"https://github.com/efischer19","followers_url":"https://api.github.com/users/efischer19/followers","following_url":"https://api.github.com/users/efischer19/following{/other_user}","gists_url":"https://api.github.com/users/efischer19/gists{/gist_id}","starred_url":"https://api.github.com/users/efischer19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efischer19/subscriptions","organizations_url":"https://api.github.com/users/efischer19/orgs","repos_url":"https://api.github.com/users/efischer19/repos","events_url":"https://api.github.com/users/efischer19/events{/privacy}","received_events_url":"https://api.github.com/users/efischer19/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T17:26:00Z","updated_at":"2016-07-11T17:26:00Z","body":"👍 Seems good so far, LMK if there are substantial changes between now and when you're ready to merge this."}}
{"actor":{"display_login":"efischer19"}}