{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments/63287135","id":63287135,"diff_hunk":"@@ -71,7 +71,8 @@ test( 'Given a private adddress, address validation sends values to server', fun\n } );\n \n test( 'Given an incomplete private adddress, address validation sends no values to server', function ( t ) {\n-\tvar postFunctionSpy = sinon.spy(),\n+\tvar negativeResult = { status: 'ERR' },","path":"app/js/tests/test_form_validation.js","position":5,"original_position":5,"commit_id":"9d8f53c4ef21d593fbc2eb13916e3d3e7ecee058","original_commit_id":"9d8f53c4ef21d593fbc2eb13916e3d3e7ecee058","user":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"body":"failureResult probably better","created_at":"2016-05-15T06:50:49Z","updated_at":"2016-05-15T06:50:49Z","html_url":"https://github.com/wmde/FundraisingFrontend/pull/400#discussion_r63287135","pull_request_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments/63287135"},"html":{"href":"https://github.com/wmde/FundraisingFrontend/pull/400#discussion_r63287135"},"pull_request":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400","id":69873216,"html_url":"https://github.com/wmde/FundraisingFrontend/pull/400","diff_url":"https://github.com/wmde/FundraisingFrontend/pull/400.diff","patch_url":"https://github.com/wmde/FundraisingFrontend/pull/400.patch","issue_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/400","number":400,"state":"open","locked":false,"title":"Membership form validation","user":{"login":"KaiNissen","id":5435996,"avatar_url":"https://avatars.githubusercontent.com/u/5435996?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiNissen","html_url":"https://github.com/KaiNissen","followers_url":"https://api.github.com/users/KaiNissen/followers","following_url":"https://api.github.com/users/KaiNissen/following{/other_user}","gists_url":"https://api.github.com/users/KaiNissen/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiNissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiNissen/subscriptions","organizations_url":"https://api.github.com/users/KaiNissen/orgs","repos_url":"https://api.github.com/users/KaiNissen/repos","events_url":"https://api.github.com/users/KaiNissen/events{/privacy}","received_events_url":"https://api.github.com/users/KaiNissen/received_events","type":"User","site_admin":false},"body":"I moved the fee validation stuff around to be able to just validate that rather than validate the whole form. Tests still need to be moved.","created_at":"2016-05-12T17:09:55Z","updated_at":"2016-05-15T06:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c6ceed1b5b9fd305b23142d4ccd02b1f2c62a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400/commits","review_comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400/comments","review_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/400/comments","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/9d8f53c4ef21d593fbc2eb13916e3d3e7ecee058","head":{"label":"wmde:membership-form-validation","ref":"membership-form-validation","sha":"9d8f53c4ef21d593fbc2eb13916e3d3e7ecee058","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":42872217,"name":"FundraisingFrontend","full_name":"wmde/FundraisingFrontend","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/FundraisingFrontend","description":"Fundraising Frontend backend code v2 alpha","fork":false,"url":"https://api.github.com/repos/wmde/FundraisingFrontend","forks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/forks","keys_url":"https://api.github.com/repos/wmde/FundraisingFrontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/FundraisingFrontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/FundraisingFrontend/teams","hooks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/hooks","issue_events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/events","assignees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/FundraisingFrontend/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/tags","blobs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/FundraisingFrontend/languages","stargazers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/stargazers","contributors_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contributors","subscribers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscribers","subscription_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscription","commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/FundraisingFrontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/FundraisingFrontend/merges","archive_url":"https://api.github.com/repos/wmde/FundraisingFrontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/FundraisingFrontend/downloads","issues_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/FundraisingFrontend/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/FundraisingFrontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/FundraisingFrontend/labels{/name}","releases_url":"https://api.github.com/repos/wmde/FundraisingFrontend/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/deployments","created_at":"2015-09-21T14:42:43Z","updated_at":"2016-04-28T08:49:36Z","pushed_at":"2016-05-14T04:01:26Z","git_url":"git://github.com/wmde/FundraisingFrontend.git","ssh_url":"git@github.com:wmde/FundraisingFrontend.git","clone_url":"https://github.com/wmde/FundraisingFrontend.git","svn_url":"https://github.com/wmde/FundraisingFrontend","homepage":"","size":1795,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":11,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"225d95ee928216c101ef8f370bf27c087d290a20","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":42872217,"name":"FundraisingFrontend","full_name":"wmde/FundraisingFrontend","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/FundraisingFrontend","description":"Fundraising Frontend backend code v2 alpha","fork":false,"url":"https://api.github.com/repos/wmde/FundraisingFrontend","forks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/forks","keys_url":"https://api.github.com/repos/wmde/FundraisingFrontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/FundraisingFrontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/FundraisingFrontend/teams","hooks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/hooks","issue_events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/events","assignees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/FundraisingFrontend/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/tags","blobs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/FundraisingFrontend/languages","stargazers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/stargazers","contributors_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contributors","subscribers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscribers","subscription_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscription","commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/FundraisingFrontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/FundraisingFrontend/merges","archive_url":"https://api.github.com/repos/wmde/FundraisingFrontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/FundraisingFrontend/downloads","issues_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/FundraisingFrontend/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/FundraisingFrontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/FundraisingFrontend/labels{/name}","releases_url":"https://api.github.com/repos/wmde/FundraisingFrontend/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/deployments","created_at":"2015-09-21T14:42:43Z","updated_at":"2016-04-28T08:49:36Z","pushed_at":"2016-05-14T04:01:26Z","git_url":"git://github.com/wmde/FundraisingFrontend.git","ssh_url":"git@github.com:wmde/FundraisingFrontend.git","clone_url":"https://github.com/wmde/FundraisingFrontend.git","svn_url":"https://github.com/wmde/FundraisingFrontend","homepage":"","size":1795,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400"},"html":{"href":"https://github.com/wmde/FundraisingFrontend/pull/400"},"issue":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/400"},"comments":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/9d8f53c4ef21d593fbc2eb13916e3d3e7ecee058"}}}}