{"action":"closed","number":1488,"pull_request":{"url":"https://api.github.com/repos/nltk/nltk/pulls/1488","id":90937637,"html_url":"https://github.com/nltk/nltk/pull/1488","diff_url":"https://github.com/nltk/nltk/pull/1488.diff","patch_url":"https://github.com/nltk/nltk/pull/1488.patch","issue_url":"https://api.github.com/repos/nltk/nltk/issues/1488","number":1488,"state":"closed","locked":false,"title":"Final tests and tweaks to fix BLEU","user":{"login":"alvations","id":1050316,"avatar_url":"https://avatars.githubusercontent.com/u/1050316?v=3","gravatar_id":"","url":"https://api.github.com/users/alvations","html_url":"https://github.com/alvations","followers_url":"https://api.github.com/users/alvations/followers","following_url":"https://api.github.com/users/alvations/following{/other_user}","gists_url":"https://api.github.com/users/alvations/gists{/gist_id}","starred_url":"https://api.github.com/users/alvations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvations/subscriptions","organizations_url":"https://api.github.com/users/alvations/orgs","repos_url":"https://api.github.com/users/alvations/repos","events_url":"https://api.github.com/users/alvations/events{/privacy}","received_events_url":"https://api.github.com/users/alvations/received_events","type":"User","site_admin":false},"body":"**Wrote tests to validate NLTK BLEU with mteval-13a.pl**:\n\nCurrently, it's checking that NLTK implementations don't stray too far away from mteval's by 0.05 BLEU, when it ranges between [0.0, 1.0]; i.e. 0.5 BLEU if score range between [0.0, 100.0]. Details on #1330 \n\n**Tweak in BLEU sum(log(p_i)**:\n\nOne thing that cannot be controlled is the data structures that the different smoothing methods can return. As much as possible, the code will try to keep the `Fraction` object, but when it's float, then checking the `p_i.numerator` wouldn't be possible. Since smoothen values are always floatable and non-zero and unsmoothen values are always `Fractions`, we can tease apart the sum log calculations and that would look a little ugly but that'll avoid creation of a new polymorphic float-fraction object that allow floats to hallucinate a numerator/denominator.\n","created_at":"2016-10-26T05:11:23Z","updated_at":"2016-11-10T10:18:28Z","closed_at":"2016-11-10T10:18:28Z","merged_at":"2016-11-10T10:18:28Z","merge_commit_sha":"416f5d90fee01fcd4e50ee8540dda2d027745ba8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nltk/nltk/pulls/1488/commits","review_comments_url":"https://api.github.com/repos/nltk/nltk/pulls/1488/comments","review_comment_url":"https://api.github.com/repos/nltk/nltk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nltk/nltk/issues/1488/comments","statuses_url":"https://api.github.com/repos/nltk/nltk/statuses/97be4ff7dc02d71f42ae952e226f16db9125f70f","head":{"label":"alvations:develop","ref":"develop","sha":"97be4ff7dc02d71f42ae952e226f16db9125f70f","user":{"login":"alvations","id":1050316,"avatar_url":"https://avatars.githubusercontent.com/u/1050316?v=3","gravatar_id":"","url":"https://api.github.com/users/alvations","html_url":"https://github.com/alvations","followers_url":"https://api.github.com/users/alvations/followers","following_url":"https://api.github.com/users/alvations/following{/other_user}","gists_url":"https://api.github.com/users/alvations/gists{/gist_id}","starred_url":"https://api.github.com/users/alvations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvations/subscriptions","organizations_url":"https://api.github.com/users/alvations/orgs","repos_url":"https://api.github.com/users/alvations/repos","events_url":"https://api.github.com/users/alvations/events{/privacy}","received_events_url":"https://api.github.com/users/alvations/received_events","type":"User","site_admin":false},"repo":{"id":19137851,"name":"nltk","full_name":"alvations/nltk","owner":{"login":"alvations","id":1050316,"avatar_url":"https://avatars.githubusercontent.com/u/1050316?v=3","gravatar_id":"","url":"https://api.github.com/users/alvations","html_url":"https://github.com/alvations","followers_url":"https://api.github.com/users/alvations/followers","following_url":"https://api.github.com/users/alvations/following{/other_user}","gists_url":"https://api.github.com/users/alvations/gists{/gist_id}","starred_url":"https://api.github.com/users/alvations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvations/subscriptions","organizations_url":"https://api.github.com/users/alvations/orgs","repos_url":"https://api.github.com/users/alvations/repos","events_url":"https://api.github.com/users/alvations/events{/privacy}","received_events_url":"https://api.github.com/users/alvations/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alvations/nltk","description":"NLTK Source","fork":true,"url":"https://api.github.com/repos/alvations/nltk","forks_url":"https://api.github.com/repos/alvations/nltk/forks","keys_url":"https://api.github.com/repos/alvations/nltk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvations/nltk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvations/nltk/teams","hooks_url":"https://api.github.com/repos/alvations/nltk/hooks","issue_events_url":"https://api.github.com/repos/alvations/nltk/issues/events{/number}","events_url":"https://api.github.com/repos/alvations/nltk/events","assignees_url":"https://api.github.com/repos/alvations/nltk/assignees{/user}","branches_url":"https://api.github.com/repos/alvations/nltk/branches{/branch}","tags_url":"https://api.github.com/repos/alvations/nltk/tags","blobs_url":"https://api.github.com/repos/alvations/nltk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvations/nltk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvations/nltk/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvations/nltk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvations/nltk/statuses/{sha}","languages_url":"https://api.github.com/repos/alvations/nltk/languages","stargazers_url":"https://api.github.com/repos/alvations/nltk/stargazers","contributors_url":"https://api.github.com/repos/alvations/nltk/contributors","subscribers_url":"https://api.github.com/repos/alvations/nltk/subscribers","subscription_url":"https://api.github.com/repos/alvations/nltk/subscription","commits_url":"https://api.github.com/repos/alvations/nltk/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvations/nltk/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvations/nltk/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvations/nltk/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvations/nltk/contents/{+path}","compare_url":"https://api.github.com/repos/alvations/nltk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvations/nltk/merges","archive_url":"https://api.github.com/repos/alvations/nltk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvations/nltk/downloads","issues_url":"https://api.github.com/repos/alvations/nltk/issues{/number}","pulls_url":"https://api.github.com/repos/alvations/nltk/pulls{/number}","milestones_url":"https://api.github.com/repos/alvations/nltk/milestones{/number}","notifications_url":"https://api.github.com/repos/alvations/nltk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvations/nltk/labels{/name}","releases_url":"https://api.github.com/repos/alvations/nltk/releases{/id}","deployments_url":"https://api.github.com/repos/alvations/nltk/deployments","created_at":"2014-04-25T07:28:37Z","updated_at":"2016-10-26T02:07:19Z","pushed_at":"2016-10-27T05:43:40Z","git_url":"git://github.com/alvations/nltk.git","ssh_url":"git@github.com:alvations/nltk.git","clone_url":"https://github.com/alvations/nltk.git","svn_url":"https://github.com/alvations/nltk","homepage":"http://nltk.github.com/","size":103497,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"nltk:develop","ref":"develop","sha":"b8de3cddd7efe3470d63d1085320604c22b3e859","user":{"login":"nltk","id":124114,"avatar_url":"https://avatars.githubusercontent.com/u/124114?v=3","gravatar_id":"","url":"https://api.github.com/users/nltk","html_url":"https://github.com/nltk","followers_url":"https://api.github.com/users/nltk/followers","following_url":"https://api.github.com/users/nltk/following{/other_user}","gists_url":"https://api.github.com/users/nltk/gists{/gist_id}","starred_url":"https://api.github.com/users/nltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nltk/subscriptions","organizations_url":"https://api.github.com/users/nltk/orgs","repos_url":"https://api.github.com/users/nltk/repos","events_url":"https://api.github.com/users/nltk/events{/privacy}","received_events_url":"https://api.github.com/users/nltk/received_events","type":"Organization","site_admin":false},"repo":{"id":299862,"name":"nltk","full_name":"nltk/nltk","owner":{"login":"nltk","id":124114,"avatar_url":"https://avatars.githubusercontent.com/u/124114?v=3","gravatar_id":"","url":"https://api.github.com/users/nltk","html_url":"https://github.com/nltk","followers_url":"https://api.github.com/users/nltk/followers","following_url":"https://api.github.com/users/nltk/following{/other_user}","gists_url":"https://api.github.com/users/nltk/gists{/gist_id}","starred_url":"https://api.github.com/users/nltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nltk/subscriptions","organizations_url":"https://api.github.com/users/nltk/orgs","repos_url":"https://api.github.com/users/nltk/repos","events_url":"https://api.github.com/users/nltk/events{/privacy}","received_events_url":"https://api.github.com/users/nltk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nltk/nltk","description":"NLTK Source","fork":false,"url":"https://api.github.com/repos/nltk/nltk","forks_url":"https://api.github.com/repos/nltk/nltk/forks","keys_url":"https://api.github.com/repos/nltk/nltk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nltk/nltk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nltk/nltk/teams","hooks_url":"https://api.github.com/repos/nltk/nltk/hooks","issue_events_url":"https://api.github.com/repos/nltk/nltk/issues/events{/number}","events_url":"https://api.github.com/repos/nltk/nltk/events","assignees_url":"https://api.github.com/repos/nltk/nltk/assignees{/user}","branches_url":"https://api.github.com/repos/nltk/nltk/branches{/branch}","tags_url":"https://api.github.com/repos/nltk/nltk/tags","blobs_url":"https://api.github.com/repos/nltk/nltk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nltk/nltk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nltk/nltk/git/refs{/sha}","trees_url":"https://api.github.com/repos/nltk/nltk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nltk/nltk/statuses/{sha}","languages_url":"https://api.github.com/repos/nltk/nltk/languages","stargazers_url":"https://api.github.com/repos/nltk/nltk/stargazers","contributors_url":"https://api.github.com/repos/nltk/nltk/contributors","subscribers_url":"https://api.github.com/repos/nltk/nltk/subscribers","subscription_url":"https://api.github.com/repos/nltk/nltk/subscription","commits_url":"https://api.github.com/repos/nltk/nltk/commits{/sha}","git_commits_url":"https://api.github.com/repos/nltk/nltk/git/commits{/sha}","comments_url":"https://api.github.com/repos/nltk/nltk/comments{/number}","issue_comment_url":"https://api.github.com/repos/nltk/nltk/issues/comments{/number}","contents_url":"https://api.github.com/repos/nltk/nltk/contents/{+path}","compare_url":"https://api.github.com/repos/nltk/nltk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nltk/nltk/merges","archive_url":"https://api.github.com/repos/nltk/nltk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nltk/nltk/downloads","issues_url":"https://api.github.com/repos/nltk/nltk/issues{/number}","pulls_url":"https://api.github.com/repos/nltk/nltk/pulls{/number}","milestones_url":"https://api.github.com/repos/nltk/nltk/milestones{/number}","notifications_url":"https://api.github.com/repos/nltk/nltk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nltk/nltk/labels{/name}","releases_url":"https://api.github.com/repos/nltk/nltk/releases{/id}","deployments_url":"https://api.github.com/repos/nltk/nltk/deployments","created_at":"2009-09-07T10:53:58Z","updated_at":"2016-11-10T08:43:15Z","pushed_at":"2016-11-10T10:18:28Z","git_url":"git://github.com/nltk/nltk.git","ssh_url":"git@github.com:nltk/nltk.git","clone_url":"https://github.com/nltk/nltk.git","svn_url":"https://github.com/nltk/nltk","homepage":"http://nltk.org/","size":401253,"stargazers_count":3964,"watchers_count":3964,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1191,"mirror_url":null,"open_issues_count":305,"forks":1191,"open_issues":305,"watchers":3964,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nltk/nltk/pulls/1488"},"html":{"href":"https://github.com/nltk/nltk/pull/1488"},"issue":{"href":"https://api.github.com/repos/nltk/nltk/issues/1488"},"comments":{"href":"https://api.github.com/repos/nltk/nltk/issues/1488/comments"},"review_comments":{"href":"https://api.github.com/repos/nltk/nltk/pulls/1488/comments"},"review_comment":{"href":"https://api.github.com/repos/nltk/nltk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nltk/nltk/pulls/1488/commits"},"statuses":{"href":"https://api.github.com/repos/nltk/nltk/statuses/97be4ff7dc02d71f42ae952e226f16db9125f70f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevenbird","id":55406,"avatar_url":"https://avatars.githubusercontent.com/u/55406?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenbird","html_url":"https://github.com/stevenbird","followers_url":"https://api.github.com/users/stevenbird/followers","following_url":"https://api.github.com/users/stevenbird/following{/other_user}","gists_url":"https://api.github.com/users/stevenbird/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenbird/subscriptions","organizations_url":"https://api.github.com/users/stevenbird/orgs","repos_url":"https://api.github.com/users/stevenbird/repos","events_url":"https://api.github.com/users/stevenbird/events{/privacy}","received_events_url":"https://api.github.com/users/stevenbird/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":8,"additions":98,"deletions":44,"changed_files":2}}
{"actor":{"display_login":"stevenbird"}}