{"action":"created","comment":{"url":"https://api.github.com/repos/k9mail/k-9/pulls/comments/91877902","pull_request_review_id":12386643,"id":91877902,"diff_hunk":"@@ -36,6 +41,8 @@\n             \"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384\",\n             \"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256\",\n             \"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256\",\n+            \"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256\",\n+            \"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256\",","path":"k9mail-library/src/main/java/com/fsck/k9/mail/ssl/DefaultTrustedSocketFactory.java","position":26,"original_position":26,"commit_id":"f1b84ea58a1020dfd537dfd2032b000074a09951","original_commit_id":"f1b84ea58a1020dfd537dfd2032b000074a09951","user":{"login":"cketti","id":218061,"avatar_url":"https://avatars.githubusercontent.com/u/218061?v=3","gravatar_id":"","url":"https://api.github.com/users/cketti","html_url":"https://github.com/cketti","followers_url":"https://api.github.com/users/cketti/followers","following_url":"https://api.github.com/users/cketti/following{/other_user}","gists_url":"https://api.github.com/users/cketti/gists{/gist_id}","starred_url":"https://api.github.com/users/cketti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cketti/subscriptions","organizations_url":"https://api.github.com/users/cketti/orgs","repos_url":"https://api.github.com/users/cketti/repos","events_url":"https://api.github.com/users/cketti/events{/privacy}","received_events_url":"https://api.github.com/users/cketti/received_events","type":"User","site_admin":false},"body":"The ChaCha cipher suites were only added in API24. Since we're not doing the reordering on these API levels there's no point in including them here.","created_at":"2016-12-12T03:13:36Z","updated_at":"2016-12-12T03:21:22Z","html_url":"https://github.com/k9mail/k-9/pull/1778#discussion_r91877902","pull_request_url":"https://api.github.com/repos/k9mail/k-9/pulls/1778","_links":{"self":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/comments/91877902"},"html":{"href":"https://github.com/k9mail/k-9/pull/1778#discussion_r91877902"},"pull_request":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/1778"}}},"pull_request":{"url":"https://api.github.com/repos/k9mail/k-9/pulls/1778","id":92483217,"html_url":"https://github.com/k9mail/k-9/pull/1778","diff_url":"https://github.com/k9mail/k-9/pull/1778.diff","patch_url":"https://github.com/k9mail/k-9/pull/1778.patch","issue_url":"https://api.github.com/repos/k9mail/k-9/issues/1778","number":1778,"state":"open","locked":false,"title":"Add Poly1305/ChaCha20 ciphers - from Mozilla & Google recommended cipher lists","user":{"login":"philipwhiuk","id":1316415,"avatar_url":"https://avatars.githubusercontent.com/u/1316415?v=3","gravatar_id":"","url":"https://api.github.com/users/philipwhiuk","html_url":"https://github.com/philipwhiuk","followers_url":"https://api.github.com/users/philipwhiuk/followers","following_url":"https://api.github.com/users/philipwhiuk/following{/other_user}","gists_url":"https://api.github.com/users/philipwhiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/philipwhiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipwhiuk/subscriptions","organizations_url":"https://api.github.com/users/philipwhiuk/orgs","repos_url":"https://api.github.com/users/philipwhiuk/repos","events_url":"https://api.github.com/users/philipwhiuk/events{/privacy}","received_events_url":"https://api.github.com/users/philipwhiuk/received_events","type":"User","site_admin":false},"body":"Google uses them in Chrome: https://security.googleblog.com/2014/04/speeding-up-and-strengthening-https.html\r\n\r\nMozilla puts them second but doesn't have to worry about mobile phone devices (which don't have hardware support) as much as we do: https://wiki.mozilla.org/Security/Server_Side_TLS\r\n\r\nRelated articles: https://www.imperialviolet.org/2013/10/07/chacha20.html\r\nDeployment: https://blog.cloudflare.com/do-the-chacha-better-mobile-performance-with-cryptography/\r\n\r\nDevelopment: https://cr.yp.to/mac.html\r\n\r\nFixes #1775 \r\n","created_at":"2016-11-06T10:39:10Z","updated_at":"2016-12-12T03:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f88ba4249842c70991dd2b7f4a540bdb622af8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/k9mail/k-9/pulls/1778/commits","review_comments_url":"https://api.github.com/repos/k9mail/k-9/pulls/1778/comments","review_comment_url":"https://api.github.com/repos/k9mail/k-9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/k9mail/k-9/issues/1778/comments","statuses_url":"https://api.github.com/repos/k9mail/k-9/statuses/f1b84ea58a1020dfd537dfd2032b000074a09951","head":{"label":"philipwhiuk:newCiphers","ref":"newCiphers","sha":"f1b84ea58a1020dfd537dfd2032b000074a09951","user":{"login":"philipwhiuk","id":1316415,"avatar_url":"https://avatars.githubusercontent.com/u/1316415?v=3","gravatar_id":"","url":"https://api.github.com/users/philipwhiuk","html_url":"https://github.com/philipwhiuk","followers_url":"https://api.github.com/users/philipwhiuk/followers","following_url":"https://api.github.com/users/philipwhiuk/following{/other_user}","gists_url":"https://api.github.com/users/philipwhiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/philipwhiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipwhiuk/subscriptions","organizations_url":"https://api.github.com/users/philipwhiuk/orgs","repos_url":"https://api.github.com/users/philipwhiuk/repos","events_url":"https://api.github.com/users/philipwhiuk/events{/privacy}","received_events_url":"https://api.github.com/users/philipwhiuk/received_events","type":"User","site_admin":false},"repo":{"id":53193707,"name":"k-9","full_name":"philipwhiuk/k-9","owner":{"login":"philipwhiuk","id":1316415,"avatar_url":"https://avatars.githubusercontent.com/u/1316415?v=3","gravatar_id":"","url":"https://api.github.com/users/philipwhiuk","html_url":"https://github.com/philipwhiuk","followers_url":"https://api.github.com/users/philipwhiuk/followers","following_url":"https://api.github.com/users/philipwhiuk/following{/other_user}","gists_url":"https://api.github.com/users/philipwhiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/philipwhiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipwhiuk/subscriptions","organizations_url":"https://api.github.com/users/philipwhiuk/orgs","repos_url":"https://api.github.com/users/philipwhiuk/repos","events_url":"https://api.github.com/users/philipwhiuk/events{/privacy}","received_events_url":"https://api.github.com/users/philipwhiuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philipwhiuk/k-9","description":"K-9 Mail – Advanced Email for Android","fork":true,"url":"https://api.github.com/repos/philipwhiuk/k-9","forks_url":"https://api.github.com/repos/philipwhiuk/k-9/forks","keys_url":"https://api.github.com/repos/philipwhiuk/k-9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipwhiuk/k-9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipwhiuk/k-9/teams","hooks_url":"https://api.github.com/repos/philipwhiuk/k-9/hooks","issue_events_url":"https://api.github.com/repos/philipwhiuk/k-9/issues/events{/number}","events_url":"https://api.github.com/repos/philipwhiuk/k-9/events","assignees_url":"https://api.github.com/repos/philipwhiuk/k-9/assignees{/user}","branches_url":"https://api.github.com/repos/philipwhiuk/k-9/branches{/branch}","tags_url":"https://api.github.com/repos/philipwhiuk/k-9/tags","blobs_url":"https://api.github.com/repos/philipwhiuk/k-9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipwhiuk/k-9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipwhiuk/k-9/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipwhiuk/k-9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipwhiuk/k-9/statuses/{sha}","languages_url":"https://api.github.com/repos/philipwhiuk/k-9/languages","stargazers_url":"https://api.github.com/repos/philipwhiuk/k-9/stargazers","contributors_url":"https://api.github.com/repos/philipwhiuk/k-9/contributors","subscribers_url":"https://api.github.com/repos/philipwhiuk/k-9/subscribers","subscription_url":"https://api.github.com/repos/philipwhiuk/k-9/subscription","commits_url":"https://api.github.com/repos/philipwhiuk/k-9/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipwhiuk/k-9/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipwhiuk/k-9/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipwhiuk/k-9/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipwhiuk/k-9/contents/{+path}","compare_url":"https://api.github.com/repos/philipwhiuk/k-9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipwhiuk/k-9/merges","archive_url":"https://api.github.com/repos/philipwhiuk/k-9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipwhiuk/k-9/downloads","issues_url":"https://api.github.com/repos/philipwhiuk/k-9/issues{/number}","pulls_url":"https://api.github.com/repos/philipwhiuk/k-9/pulls{/number}","milestones_url":"https://api.github.com/repos/philipwhiuk/k-9/milestones{/number}","notifications_url":"https://api.github.com/repos/philipwhiuk/k-9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipwhiuk/k-9/labels{/name}","releases_url":"https://api.github.com/repos/philipwhiuk/k-9/releases{/id}","deployments_url":"https://api.github.com/repos/philipwhiuk/k-9/deployments","created_at":"2016-03-05T09:28:04Z","updated_at":"2016-12-02T20:34:52Z","pushed_at":"2016-12-10T21:02:10Z","git_url":"git://github.com/philipwhiuk/k-9.git","ssh_url":"git@github.com:philipwhiuk/k-9.git","clone_url":"https://github.com/philipwhiuk/k-9.git","svn_url":"https://github.com/philipwhiuk/k-9","homepage":"","size":42935,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"k9mail:master","ref":"master","sha":"0617d4250f0f3289f013185704e56bd73022bc5d","user":{"login":"k9mail","id":567044,"avatar_url":"https://avatars.githubusercontent.com/u/567044?v=3","gravatar_id":"","url":"https://api.github.com/users/k9mail","html_url":"https://github.com/k9mail","followers_url":"https://api.github.com/users/k9mail/followers","following_url":"https://api.github.com/users/k9mail/following{/other_user}","gists_url":"https://api.github.com/users/k9mail/gists{/gist_id}","starred_url":"https://api.github.com/users/k9mail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k9mail/subscriptions","organizations_url":"https://api.github.com/users/k9mail/orgs","repos_url":"https://api.github.com/users/k9mail/repos","events_url":"https://api.github.com/users/k9mail/events{/privacy}","received_events_url":"https://api.github.com/users/k9mail/received_events","type":"Organization","site_admin":false},"repo":{"id":1326671,"name":"k-9","full_name":"k9mail/k-9","owner":{"login":"k9mail","id":567044,"avatar_url":"https://avatars.githubusercontent.com/u/567044?v=3","gravatar_id":"","url":"https://api.github.com/users/k9mail","html_url":"https://github.com/k9mail","followers_url":"https://api.github.com/users/k9mail/followers","following_url":"https://api.github.com/users/k9mail/following{/other_user}","gists_url":"https://api.github.com/users/k9mail/gists{/gist_id}","starred_url":"https://api.github.com/users/k9mail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k9mail/subscriptions","organizations_url":"https://api.github.com/users/k9mail/orgs","repos_url":"https://api.github.com/users/k9mail/repos","events_url":"https://api.github.com/users/k9mail/events{/privacy}","received_events_url":"https://api.github.com/users/k9mail/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/k9mail/k-9","description":"K-9 Mail – Advanced Email for Android","fork":false,"url":"https://api.github.com/repos/k9mail/k-9","forks_url":"https://api.github.com/repos/k9mail/k-9/forks","keys_url":"https://api.github.com/repos/k9mail/k-9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k9mail/k-9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k9mail/k-9/teams","hooks_url":"https://api.github.com/repos/k9mail/k-9/hooks","issue_events_url":"https://api.github.com/repos/k9mail/k-9/issues/events{/number}","events_url":"https://api.github.com/repos/k9mail/k-9/events","assignees_url":"https://api.github.com/repos/k9mail/k-9/assignees{/user}","branches_url":"https://api.github.com/repos/k9mail/k-9/branches{/branch}","tags_url":"https://api.github.com/repos/k9mail/k-9/tags","blobs_url":"https://api.github.com/repos/k9mail/k-9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k9mail/k-9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k9mail/k-9/git/refs{/sha}","trees_url":"https://api.github.com/repos/k9mail/k-9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k9mail/k-9/statuses/{sha}","languages_url":"https://api.github.com/repos/k9mail/k-9/languages","stargazers_url":"https://api.github.com/repos/k9mail/k-9/stargazers","contributors_url":"https://api.github.com/repos/k9mail/k-9/contributors","subscribers_url":"https://api.github.com/repos/k9mail/k-9/subscribers","subscription_url":"https://api.github.com/repos/k9mail/k-9/subscription","commits_url":"https://api.github.com/repos/k9mail/k-9/commits{/sha}","git_commits_url":"https://api.github.com/repos/k9mail/k-9/git/commits{/sha}","comments_url":"https://api.github.com/repos/k9mail/k-9/comments{/number}","issue_comment_url":"https://api.github.com/repos/k9mail/k-9/issues/comments{/number}","contents_url":"https://api.github.com/repos/k9mail/k-9/contents/{+path}","compare_url":"https://api.github.com/repos/k9mail/k-9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k9mail/k-9/merges","archive_url":"https://api.github.com/repos/k9mail/k-9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k9mail/k-9/downloads","issues_url":"https://api.github.com/repos/k9mail/k-9/issues{/number}","pulls_url":"https://api.github.com/repos/k9mail/k-9/pulls{/number}","milestones_url":"https://api.github.com/repos/k9mail/k-9/milestones{/number}","notifications_url":"https://api.github.com/repos/k9mail/k-9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k9mail/k-9/labels{/name}","releases_url":"https://api.github.com/repos/k9mail/k-9/releases{/id}","deployments_url":"https://api.github.com/repos/k9mail/k-9/deployments","created_at":"2011-02-04T02:40:00Z","updated_at":"2016-12-11T20:15:05Z","pushed_at":"2016-12-12T03:00:16Z","git_url":"git://github.com/k9mail/k-9.git","ssh_url":"git@github.com:k9mail/k-9.git","clone_url":"https://github.com/k9mail/k-9.git","svn_url":"https://github.com/k9mail/k-9","homepage":"","size":71000,"stargazers_count":2815,"watchers_count":2815,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1478,"mirror_url":null,"open_issues_count":409,"forks":1478,"open_issues":409,"watchers":2815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/1778"},"html":{"href":"https://github.com/k9mail/k-9/pull/1778"},"issue":{"href":"https://api.github.com/repos/k9mail/k-9/issues/1778"},"comments":{"href":"https://api.github.com/repos/k9mail/k-9/issues/1778/comments"},"review_comments":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/1778/comments"},"review_comment":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/k9mail/k-9/pulls/1778/commits"},"statuses":{"href":"https://api.github.com/repos/k9mail/k-9/statuses/f1b84ea58a1020dfd537dfd2032b000074a09951"}}}}
{"actor":{"display_login":"cketti"}}