{"action":"created","issue":{"url":"https://api.github.com/repos/github/gitignore/issues/1768","repository_url":"https://api.github.com/repos/github/gitignore","labels_url":"https://api.github.com/repos/github/gitignore/issues/1768/labels{/name}","comments_url":"https://api.github.com/repos/github/gitignore/issues/1768/comments","events_url":"https://api.github.com/repos/github/gitignore/issues/1768/events","html_url":"https://github.com/github/gitignore/pull/1768","id":119071893,"number":1768,"title":"Add rule to unignore the maven wrapper jar","user":{"login":"thomaseizinger","id":5486389,"avatar_url":"https://avatars.githubusercontent.com/u/5486389?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaseizinger","html_url":"https://github.com/thomaseizinger","followers_url":"https://api.github.com/users/thomaseizinger/followers","following_url":"https://api.github.com/users/thomaseizinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseizinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseizinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseizinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseizinger/orgs","repos_url":"https://api.github.com/users/thomaseizinger/repos","events_url":"https://api.github.com/users/thomaseizinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseizinger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/github/gitignore/labels/feedback%20given","name":"feedback given","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-11-26T16:09:13Z","updated_at":"2016-08-09T00:39:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/github/gitignore/pulls/1768","html_url":"https://github.com/github/gitignore/pull/1768","diff_url":"https://github.com/github/gitignore/pull/1768.diff","patch_url":"https://github.com/github/gitignore/pull/1768.patch"},"body":"If a project uses the maven-wrapper library (https://github.com/takari/maven-wrapper) the .jar file of the maven-wrapper gets excluded if there is a catch-all `*.jar` rule in the .gitignore. \r\n\r\nI think the un-ignore rule for the maven-wrapper fits best into the normal maven `.gitignore`. \r\nHowever, I have noticed that the un-ignore rule is ignored if the catch-all `*.jar` rule is applied after the one I add. Is it possible to further customize the rule in a way, so the order in which the rules appear in the `.gitignore` is not important?"},"comment":{"url":"https://api.github.com/repos/github/gitignore/issues/comments/238420318","html_url":"https://github.com/github/gitignore/pull/1768#issuecomment-238420318","issue_url":"https://api.github.com/repos/github/gitignore/issues/1768","id":238420318,"user":{"login":"thomaseizinger","id":5486389,"avatar_url":"https://avatars.githubusercontent.com/u/5486389?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaseizinger","html_url":"https://github.com/thomaseizinger","followers_url":"https://api.github.com/users/thomaseizinger/followers","following_url":"https://api.github.com/users/thomaseizinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseizinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseizinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseizinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseizinger/orgs","repos_url":"https://api.github.com/users/thomaseizinger/repos","events_url":"https://api.github.com/users/thomaseizinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseizinger/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T00:39:41Z","updated_at":"2016-08-09T00:39:41Z","body":"Thanks for commenting @ssherwood!\r\nThe solution I present here is indeed directly inspired from `Gradle.gitignore`. As you have pointed out correctly, this one is actually more restrictive, as it just applies to wrapper jar and nothing else.\r\n\r\nGradle introduced the concept of the wrapper jar to allow users to build their projects without having gradle installed locally. This concept has then been ported for maven. It don't think the will change the location or name of the wrapper jar, as there is absolutely no need for doing so.\r\n\r\nPS: I too was stuck with a failing CI build until I realized that the catch-all `jar`-exclude rule excluded the wrapper jar from my repository.\r\n\r\n@shiftkey What would have to be done to actually merge this pull request? Or is there still something unclear that needs to be sorted out?"}}
{"actor":{"display_login":"thomaseizinger"}}