{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/5668","repository_url":"https://api.github.com/repos/chef/chef","labels_url":"https://api.github.com/repos/chef/chef/issues/5668/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/5668/comments","events_url":"https://api.github.com/repos/chef/chef/issues/5668/events","html_url":"https://github.com/chef/chef/pull/5668","id":196967952,"number":5668,"title":"Report a dummy resource if sensitive is enabled","user":{"login":"afiune","id":5712253,"avatar_url":"https://avatars.githubusercontent.com/u/5712253?v=3","gravatar_id":"","url":"https://api.github.com/users/afiune","html_url":"https://github.com/afiune","followers_url":"https://api.github.com/users/afiune/followers","following_url":"https://api.github.com/users/afiune/following{/other_user}","gists_url":"https://api.github.com/users/afiune/gists{/gist_id}","starred_url":"https://api.github.com/users/afiune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afiune/subscriptions","organizations_url":"https://api.github.com/users/afiune/orgs","repos_url":"https://api.github.com/users/afiune/repos","events_url":"https://api.github.com/users/afiune/events{/privacy}","received_events_url":"https://api.github.com/users/afiune/received_events","type":"User","site_admin":false},"labels":[{"id":100752942,"url":"https://api.github.com/repos/chef/chef/labels/Bug","name":"Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-12-21T15:59:10Z","updated_at":"2016-12-22T19:28:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/5668","html_url":"https://github.com/chef/chef/pull/5668","diff_url":"https://github.com/chef/chef/pull/5668.diff","patch_url":"https://github.com/chef/chef/pull/5668.patch"},"body":"### Description\r\n\r\nBefore this commit we were sending sensitive resource information to\r\nReporting and therefor you were able to see the sensitive data on the\r\nRun History in the Chef Manage Console.\r\n\r\nThis commit is fixing this problem and now it is transforming any\r\nsensitive resource to display the word `*sensitive*` instead of the\r\nactual data. As we are inserting this values directly to the data base,\r\nit means that this change will cascade all the way to the front-end.\r\n\r\nCatch: Old data that was already reported and is displaying sensitive\r\ndata will contineu to be displayed. Apologize.\r\n\r\nSigned-off-by: Salim Afiune <afiune@chef.io>\r\n\r\n### Issues Resolved\r\n\r\nCOOL-642/ZD 12936 - Chef Manage Run History compromises sensitive data\r\n\r\n### Check List\r\n\r\n- [x] New functionality includes tests\r\n- [x] All tests pass\r\n- [x] RELEASE\\_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)\r\n- [x] All commits have been signed-off for the Developer Certificate of Origin. See <https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco>\r\n"},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/268872424","html_url":"https://github.com/chef/chef/pull/5668#issuecomment-268872424","issue_url":"https://api.github.com/repos/chef/chef/issues/5668","id":268872424,"user":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T19:28:18Z","updated_at":"2016-12-22T19:28:18Z","body":"Also I don't think this handles sensitive props? I guess that would actually be a problem if that's something you intend to support."}}
{"actor":{"display_login":"coderanger"}}