{"action":"created","issue":{"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/251","repository_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer","labels_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/251/comments","events_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/251/events","html_url":"https://github.com/MushroomObserver/mushroom-observer/pull/251","id":197415777,"number":251,"title":"Response to naming email","user":{"login":"pellaea","id":3225269,"avatar_url":"https://avatars.githubusercontent.com/u/3225269?v=3","gravatar_id":"","url":"https://api.github.com/users/pellaea","html_url":"https://github.com/pellaea","followers_url":"https://api.github.com/users/pellaea/followers","following_url":"https://api.github.com/users/pellaea/following{/other_user}","gists_url":"https://api.github.com/users/pellaea/gists{/gist_id}","starred_url":"https://api.github.com/users/pellaea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pellaea/subscriptions","organizations_url":"https://api.github.com/users/pellaea/orgs","repos_url":"https://api.github.com/users/pellaea/repos","events_url":"https://api.github.com/users/pellaea/events{/privacy}","received_events_url":"https://api.github.com/users/pellaea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-23T19:16:10Z","updated_at":"2016-12-24T18:54:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/251","html_url":"https://github.com/MushroomObserver/mushroom-observer/pull/251","diff_url":"https://github.com/MushroomObserver/mushroom-observer/pull/251.diff","patch_url":"https://github.com/MushroomObserver/mushroom-observer/pull/251.patch"},"body":"Very simple feature.  Just makes it so users who have proposed names but not bothered to comment will also get \"comment response\" emails when someone comments on the observation.  (I personally will find this invaluable!!)"},"comment":{"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/comments/269096127","html_url":"https://github.com/MushroomObserver/mushroom-observer/pull/251#issuecomment-269096127","issue_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/251","id":269096127,"user":{"login":"pellaea","id":3225269,"avatar_url":"https://avatars.githubusercontent.com/u/3225269?v=3","gravatar_id":"","url":"https://api.github.com/users/pellaea","html_url":"https://github.com/pellaea","followers_url":"https://api.github.com/users/pellaea/followers","following_url":"https://api.github.com/users/pellaea/following{/other_user}","gists_url":"https://api.github.com/users/pellaea/gists{/gist_id}","starred_url":"https://api.github.com/users/pellaea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pellaea/subscriptions","organizations_url":"https://api.github.com/users/pellaea/orgs","repos_url":"https://api.github.com/users/pellaea/repos","events_url":"https://api.github.com/users/pellaea/events{/privacy}","received_events_url":"https://api.github.com/users/pellaea/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T18:54:22Z","updated_at":"2016-12-24T18:54:22Z","body":"This has to be wrong, I couldn't possibly have caused 51 new offences, I\nonly added one method that's 3 lines long!  And I should point out that\napp/models/comment.rb is one of the only files that actually passes without\n*any* warnings.  (After several hours of work the other day.)\n\n[Yes, just checked, there are no new rubocop warnings in either comment.rb\nor comment/callbacks.rb -- the only files in the code I might have touched\n-- except for a request for comments which already exist in the main\nComment class which I don't know how to silence because it's clearly a\nbogus warning, and it's complaining about a blank line I just added for\nreadability, but which I'd be happy to remove, didn't occur to me that\nmight be a problem.]\n\nYour diff method didn't work for me at all.  If you add a line of comments\nat the top of the file it claims all the offences in that file are new even\nif you didn't touch any of the rest of the file.\n\nI am happy to ensure that my new code follows rubocops dubious protocols\nbut I can't be responsible for cleaning up all the warnings in any file I\ntouch -- I would never get anything done and there would be a huge\nactivation energy to making even the tiniest contribution to the site.\n\n-Jason\n\nOn Sat, Dec 24, 2016 at 9:22 AM, Nathan Wilson <notifications@github.com>\nwrote:\n\n> rubocop report 51 offenses in the files that were touched:\n>\n> % git diff --name-only master | xargs rubocop\n> ...\n> 3 files inspected, 51 offenses detected\n>\n> At lot of those would be really easy to clean up (lines too long, indents\n> etc.). The hard ones include the \"Assignment Branch Condition size\" and\n> \"Class has too many lines\" offenses. It would be great if the easy ones\n> could get cleaned up and we can worry about the hard ones later.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/MushroomObserver/mushroom-observer/pull/251#issuecomment-269092945>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADE2tWaddkxD2gTDLlPLmjlQ56dzbX-7ks5rLVTngaJpZM4LVBJN>\n> .\n>\n"}}
{"actor":{"display_login":"pellaea"}}