{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/67213019","id":67213019,"diff_hunk":"@@ -15,9 +15,6 @@ internal static class ManifestVersionUtility\n         public const int TargetFrameworkSupportForDependencyContentsAndToolsVersion = 4;\n         public const int TargetFrameworkSupportForReferencesVersion = 5;\n         public const int XdtTransformationVersion = 6;\n-        // Note that this version should change from 7 to 8 when the PackageType\n-        // schema is merged into here\n-        public const int ServiceableVersion = 7;\n \n         public static int GetManifestVersion(ManifestMetadata metadata)\n         {","path":"src/dotnet/commands/dotnet-pack/NuGet/ManifestVersionUtility.cs","position":null,"original_position":9,"commit_id":"1c317f7c2dbb3e966c2151d8bf4bb9bb6f61acb0","original_commit_id":"ff183651fb486f07c9eee4d7d4993366d6cb6301","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"I think we missed one comment from https://github.com/dotnet/cli/pull/3492/files\r\n\r\n```\r\n             // Important: always add newer version checks at the top\r\n```","created_at":"2016-06-15T18:00:09Z","updated_at":"2016-06-15T18:00:09Z","html_url":"https://github.com/dotnet/cli/pull/3588#discussion_r67213019","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/3588","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/67213019"},"html":{"href":"https://github.com/dotnet/cli/pull/3588#discussion_r67213019"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3588"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/3588","id":73951524,"html_url":"https://github.com/dotnet/cli/pull/3588","diff_url":"https://github.com/dotnet/cli/pull/3588.diff","patch_url":"https://github.com/dotnet/cli/pull/3588.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/3588","number":3588,"state":"open","locked":false,"title":"Port rel/1.0.0-preview2 to rel/1.0.0","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"body":"@eerhardt @livarcocc @piotrpMSFT \r\n\r\nTake a look at the last commit here, it's the only interesting one\r\n","created_at":"2016-06-15T17:26:42Z","updated_at":"2016-06-15T18:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0488fb67c7eebe0b0429a881dd5d31436a2e8a1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/3588/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/3588/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/3588/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/1c317f7c2dbb3e966c2151d8bf4bb9bb6f61acb0","head":{"label":"brthor:brthor/rel1port","ref":"brthor/rel1port","sha":"1c317f7c2dbb3e966c2151d8bf4bb9bb6f61acb0","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"repo":{"id":46514660,"name":"cli","full_name":"brthor/cli","owner":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brthor/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/brthor/cli","forks_url":"https://api.github.com/repos/brthor/cli/forks","keys_url":"https://api.github.com/repos/brthor/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brthor/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brthor/cli/teams","hooks_url":"https://api.github.com/repos/brthor/cli/hooks","issue_events_url":"https://api.github.com/repos/brthor/cli/issues/events{/number}","events_url":"https://api.github.com/repos/brthor/cli/events","assignees_url":"https://api.github.com/repos/brthor/cli/assignees{/user}","branches_url":"https://api.github.com/repos/brthor/cli/branches{/branch}","tags_url":"https://api.github.com/repos/brthor/cli/tags","blobs_url":"https://api.github.com/repos/brthor/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brthor/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brthor/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brthor/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brthor/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brthor/cli/languages","stargazers_url":"https://api.github.com/repos/brthor/cli/stargazers","contributors_url":"https://api.github.com/repos/brthor/cli/contributors","subscribers_url":"https://api.github.com/repos/brthor/cli/subscribers","subscription_url":"https://api.github.com/repos/brthor/cli/subscription","commits_url":"https://api.github.com/repos/brthor/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brthor/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brthor/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brthor/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brthor/cli/contents/{+path}","compare_url":"https://api.github.com/repos/brthor/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brthor/cli/merges","archive_url":"https://api.github.com/repos/brthor/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brthor/cli/downloads","issues_url":"https://api.github.com/repos/brthor/cli/issues{/number}","pulls_url":"https://api.github.com/repos/brthor/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brthor/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brthor/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brthor/cli/labels{/name}","releases_url":"https://api.github.com/repos/brthor/cli/releases{/id}","deployments_url":"https://api.github.com/repos/brthor/cli/deployments","created_at":"2015-11-19T19:17:23Z","updated_at":"2016-06-01T22:27:26Z","pushed_at":"2016-06-15T17:40:31Z","git_url":"git://github.com/brthor/cli.git","ssh_url":"git@github.com:brthor/cli.git","clone_url":"https://github.com/brthor/cli.git","svn_url":"https://github.com/brthor/cli","homepage":"http://dotnet.github.io/","size":103074,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"92077dd6d8e2533d077a42db9b48d6b4164b43e2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-06-15T14:10:39Z","pushed_at":"2016-06-15T17:40:31Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"http://dot.net/","size":117909,"stargazers_count":1140,"watchers_count":1140,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":781,"forks":256,"open_issues":781,"watchers":1140,"default_branch":"rel/1.0.0-preview2"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3588"},"html":{"href":"https://github.com/dotnet/cli/pull/3588"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/3588"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/3588/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3588/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3588/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/1c317f7c2dbb3e966c2151d8bf4bb9bb6f61acb0"}}}}
{"actor":{"display_login":"eerhardt"}}