{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/comments/79487133","id":79487133,"diff_hunk":"@@ -215,7 +227,9 @@ enable_omsagent_service()\n         fi\n         touch  /etc/opt/microsoft/omsagent/conf/.service_registered\n         start_omsagent\n-    fi\n+    else\n+        exit_if_agent_not_onboarded","path":"installer/scripts/service_control","position":55,"original_position":55,"commit_id":"391055e124ca4c6cc665cf199b0e1289b4d262df","original_commit_id":"391055e124ca4c6cc665cf199b0e1289b4d262df","user":{"login":"jeffaco","id":13700943,"avatar_url":"https://avatars.githubusercontent.com/u/13700943?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffaco","html_url":"https://github.com/jeffaco","followers_url":"https://api.github.com/users/jeffaco/followers","following_url":"https://api.github.com/users/jeffaco/following{/other_user}","gists_url":"https://api.github.com/users/jeffaco/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffaco/subscriptions","organizations_url":"https://api.github.com/users/jeffaco/orgs","repos_url":"https://api.github.com/users/jeffaco/repos","events_url":"https://api.github.com/users/jeffaco/events{/privacy}","received_events_url":"https://api.github.com/users/jeffaco/received_events","type":"User","site_admin":false},"body":"We know we're not onboarded at this point, yes? Thus, no need to do the 'if' test again. Not a biggie, just a nit.","created_at":"2016-09-19T20:56:12Z","updated_at":"2016-09-19T20:56:49Z","html_url":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205#discussion_r79487133","pull_request_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/comments/79487133"},"html":{"href":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205#discussion_r79487133"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205","id":85653673,"html_url":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205","diff_url":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205.diff","patch_url":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205.patch","issue_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/205","number":205,"state":"open","locked":false,"title":"Fix bugs in onboarding script and service_control","user":{"login":"sugr4","id":12738984,"avatar_url":"https://avatars.githubusercontent.com/u/12738984?v=3","gravatar_id":"","url":"https://api.github.com/users/sugr4","html_url":"https://github.com/sugr4","followers_url":"https://api.github.com/users/sugr4/followers","following_url":"https://api.github.com/users/sugr4/following{/other_user}","gists_url":"https://api.github.com/users/sugr4/gists{/gist_id}","starred_url":"https://api.github.com/users/sugr4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugr4/subscriptions","organizations_url":"https://api.github.com/users/sugr4/orgs","repos_url":"https://api.github.com/users/sugr4/repos","events_url":"https://api.github.com/users/sugr4/events{/privacy}","received_events_url":"https://api.github.com/users/sugr4/received_events","type":"User","site_admin":false},"body":"Changes made are:\r\n- service_control enable/start/restart will warn if agent is not onboarded\r\n- omsadmin.sh will register omsagent as a service if onboarding is successful\r\n- added double quotes to if statement for checking if dmidecode exists to\r\n  get rid of the error [: =: unary operator expected\r\n\r\n\r\n\r\n@Microsoft/omsagent-devs ","created_at":"2016-09-16T23:27:19Z","updated_at":"2016-09-19T20:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ab25aa3284e64ab4b06d74b0a153934c192045","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205/commits","review_comments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205/comments","review_comment_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/205/comments","statuses_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/statuses/391055e124ca4c6cc665cf199b0e1289b4d262df","head":{"label":"Microsoft:sujgu-bugfix-onboarding","ref":"sujgu-bugfix-onboarding","sha":"391055e124ca4c6cc665cf199b0e1289b4d262df","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43709699,"name":"OMS-Agent-for-Linux","full_name":"Microsoft/OMS-Agent-for-Linux","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/OMS-Agent-for-Linux","description":"","fork":false,"url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux","forks_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/forks","keys_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/teams","hooks_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/events","assignees_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/tags","blobs_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/languages","stargazers_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/subscription","commits_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/merges","archive_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/downloads","issues_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/deployments","created_at":"2015-10-05T19:50:18Z","updated_at":"2016-09-12T15:26:14Z","pushed_at":"2016-09-19T20:53:40Z","git_url":"git://github.com/Microsoft/OMS-Agent-for-Linux.git","ssh_url":"git@github.com:Microsoft/OMS-Agent-for-Linux.git","clone_url":"https://github.com/Microsoft/OMS-Agent-for-Linux.git","svn_url":"https://github.com/Microsoft/OMS-Agent-for-Linux","homepage":"http://www.microsoft.com/oms","size":10466,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":16,"forks":26,"open_issues":16,"watchers":58,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"9d3e7a8f9757d99ac74246ee7785e045323a1891","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43709699,"name":"OMS-Agent-for-Linux","full_name":"Microsoft/OMS-Agent-for-Linux","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/OMS-Agent-for-Linux","description":"","fork":false,"url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux","forks_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/forks","keys_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/teams","hooks_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/events","assignees_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/tags","blobs_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/languages","stargazers_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/subscription","commits_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/merges","archive_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/downloads","issues_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/deployments","created_at":"2015-10-05T19:50:18Z","updated_at":"2016-09-12T15:26:14Z","pushed_at":"2016-09-19T20:53:40Z","git_url":"git://github.com/Microsoft/OMS-Agent-for-Linux.git","ssh_url":"git@github.com:Microsoft/OMS-Agent-for-Linux.git","clone_url":"https://github.com/Microsoft/OMS-Agent-for-Linux.git","svn_url":"https://github.com/Microsoft/OMS-Agent-for-Linux","homepage":"http://www.microsoft.com/oms","size":10466,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":16,"forks":26,"open_issues":16,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205"},"html":{"href":"https://github.com/Microsoft/OMS-Agent-for-Linux/pull/205"},"issue":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/205"},"comments":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/OMS-Agent-for-Linux/statuses/391055e124ca4c6cc665cf199b0e1289b4d262df"}}}}
{"actor":{"display_login":"jeffaco"}}