{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5758","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5758/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5758/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5758/events","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/5758","id":163285910,"number":5758,"title":"Re-code i18n keys to have namespaces","user":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/38","html_url":"https://github.com/silverstripe/silverstripe-framework/milestones/CMS%204.0.0-beta1","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/38/labels","id":1858534,"number":38,"title":"CMS 4.0.0-beta1","description":"Feature-complete release of SilverStripe 4.","creator":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-06-30T22:49:57Z","updated_at":"2016-06-30T23:07:05Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-06-30T23:07:05Z","updated_at":"2016-06-30T23:18:20Z","closed_at":null,"body":"From Ingo's comments on #5734:\r\n\r\nIngo: i18nTextCollector will collect fully qualified \"namespaces\" through DataObject->provideI18nEntities() now (for {$this->class}.SINGULARNAME. Is it too hacky to use DataObject::$table_name for it, assuming that core classes will get a short table name?\r\n\r\nSam: Can we do some kind of extract-transform-load step with transifex as a one-off?\r\n\r\nIngo: Yeah. It's also going to mess with everybody else's translations though (not just core), so ideally it's an optional part of the upgrader. Using <MyModel>.SINGULARNAME will be quite common in projects, because the key is generated by default on text collection. Or more explicitly mentioned in the upgrade guide as a manual task."},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/229815393","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/5758#issuecomment-229815393","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5758","id":229815393,"user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T23:18:20Z","updated_at":"2016-06-30T23:18:20Z","body":"As a part of this we'll need to create a new set of transifex masters for 4.x going forward (the same as what we did for blog 2.0), to prevent 3.x strings getting messed up.\r\n\r\nThis should be done later on once we've completed namespacing.\r\n\r\nMy ideal is to keep using FQN for keys, and not use table_name, since we avoid conflicts in that case."}}
{"actor":{"display_login":"tractorcow"}}