{"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89","id":51357716,"html_url":"https://github.com/googleads/googleads-python-lib/pull/89","diff_url":"https://github.com/googleads/googleads-python-lib/pull/89.diff","patch_url":"https://github.com/googleads/googleads-python-lib/pull/89.patch","issue_url":"https://api.github.com/repos/googleads/googleads-python-lib/issues/89","number":89,"state":"closed","locked":false,"title":"Alternatives to urllib2","user":{"login":"merll","id":6816929,"avatar_url":"https://avatars.githubusercontent.com/u/6816929?v=3","gravatar_id":"","url":"https://api.github.com/users/merll","html_url":"https://github.com/merll","followers_url":"https://api.github.com/users/merll/followers","following_url":"https://api.github.com/users/merll/following{/other_user}","gists_url":"https://api.github.com/users/merll/gists{/gist_id}","starred_url":"https://api.github.com/users/merll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merll/subscriptions","organizations_url":"https://api.github.com/users/merll/orgs","repos_url":"https://api.github.com/users/merll/repos","events_url":"https://api.github.com/users/merll/events{/privacy}","received_events_url":"https://api.github.com/users/merll/received_events","type":"User","site_admin":false},"body":"We had some mutate operations on ads raising `UnicodeDecodeError`s because of special characters in unicode strings. Similar to #88 and possibly others, the solution could be to encode strings before passing them in. However, that seems a bit redundant considering that there are already great HTTP libraries that deal with content encoding and decoding in both Python 2 and 3.\r\n\r\nFor Suds, there is [suds_requests](https://github.com/armooo/suds_requests) allowing for Suds to use the [Requests](http://docs.python-requests.org) library instead of urllib2. Therefore, one change of this PR is to allow specifying the `transport` argument to `suds.client.Client`. Currently this needs a callable (`transport_factory`), as transports cannot be used for multiple instances.\r\n\r\nThe second main change of this PR is to create abstractions of the report downloaders and the batch job helper; this provides a possibility to use other libraries than urllib2 there as well. We have a working implementation on Requests; but before we include it in the PR we would like to know if you even agree to these changes so far, and if you would consider merging such implementations as well. Alternatively they could be maintained separately.","created_at":"2015-11-20T13:45:58Z","updated_at":"2016-07-14T15:00:39Z","closed_at":"2016-07-14T15:00:38Z","merged_at":null,"merge_commit_sha":"4ec14b522197381e345607bf1bb59d20103738a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89/commits","review_comments_url":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89/comments","review_comment_url":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleads/googleads-python-lib/issues/89/comments","statuses_url":"https://api.github.com/repos/googleads/googleads-python-lib/statuses/a2bd7d319d50bb8f344be59eb2b4df407b9c0dc1","head":{"label":"Precis:precis_transports","ref":"precis_transports","sha":"a2bd7d319d50bb8f344be59eb2b4df407b9c0dc1","user":{"login":"Precis","id":6817050,"avatar_url":"https://avatars.githubusercontent.com/u/6817050?v=3","gravatar_id":"","url":"https://api.github.com/users/Precis","html_url":"https://github.com/Precis","followers_url":"https://api.github.com/users/Precis/followers","following_url":"https://api.github.com/users/Precis/following{/other_user}","gists_url":"https://api.github.com/users/Precis/gists{/gist_id}","starred_url":"https://api.github.com/users/Precis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Precis/subscriptions","organizations_url":"https://api.github.com/users/Precis/orgs","repos_url":"https://api.github.com/users/Precis/repos","events_url":"https://api.github.com/users/Precis/events{/privacy}","received_events_url":"https://api.github.com/users/Precis/received_events","type":"Organization","site_admin":false},"repo":{"id":46482374,"name":"googleads-python-lib","full_name":"Precis/googleads-python-lib","owner":{"login":"Precis","id":6817050,"avatar_url":"https://avatars.githubusercontent.com/u/6817050?v=3","gravatar_id":"","url":"https://api.github.com/users/Precis","html_url":"https://github.com/Precis","followers_url":"https://api.github.com/users/Precis/followers","following_url":"https://api.github.com/users/Precis/following{/other_user}","gists_url":"https://api.github.com/users/Precis/gists{/gist_id}","starred_url":"https://api.github.com/users/Precis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Precis/subscriptions","organizations_url":"https://api.github.com/users/Precis/orgs","repos_url":"https://api.github.com/users/Precis/repos","events_url":"https://api.github.com/users/Precis/events{/privacy}","received_events_url":"https://api.github.com/users/Precis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Precis/googleads-python-lib","description":"The Python client library for Google's Ads APIs","fork":true,"url":"https://api.github.com/repos/Precis/googleads-python-lib","forks_url":"https://api.github.com/repos/Precis/googleads-python-lib/forks","keys_url":"https://api.github.com/repos/Precis/googleads-python-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Precis/googleads-python-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Precis/googleads-python-lib/teams","hooks_url":"https://api.github.com/repos/Precis/googleads-python-lib/hooks","issue_events_url":"https://api.github.com/repos/Precis/googleads-python-lib/issues/events{/number}","events_url":"https://api.github.com/repos/Precis/googleads-python-lib/events","assignees_url":"https://api.github.com/repos/Precis/googleads-python-lib/assignees{/user}","branches_url":"https://api.github.com/repos/Precis/googleads-python-lib/branches{/branch}","tags_url":"https://api.github.com/repos/Precis/googleads-python-lib/tags","blobs_url":"https://api.github.com/repos/Precis/googleads-python-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Precis/googleads-python-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Precis/googleads-python-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Precis/googleads-python-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Precis/googleads-python-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/Precis/googleads-python-lib/languages","stargazers_url":"https://api.github.com/repos/Precis/googleads-python-lib/stargazers","contributors_url":"https://api.github.com/repos/Precis/googleads-python-lib/contributors","subscribers_url":"https://api.github.com/repos/Precis/googleads-python-lib/subscribers","subscription_url":"https://api.github.com/repos/Precis/googleads-python-lib/subscription","commits_url":"https://api.github.com/repos/Precis/googleads-python-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Precis/googleads-python-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Precis/googleads-python-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Precis/googleads-python-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Precis/googleads-python-lib/contents/{+path}","compare_url":"https://api.github.com/repos/Precis/googleads-python-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Precis/googleads-python-lib/merges","archive_url":"https://api.github.com/repos/Precis/googleads-python-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Precis/googleads-python-lib/downloads","issues_url":"https://api.github.com/repos/Precis/googleads-python-lib/issues{/number}","pulls_url":"https://api.github.com/repos/Precis/googleads-python-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/Precis/googleads-python-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/Precis/googleads-python-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Precis/googleads-python-lib/labels{/name}","releases_url":"https://api.github.com/repos/Precis/googleads-python-lib/releases{/id}","deployments_url":"https://api.github.com/repos/Precis/googleads-python-lib/deployments","created_at":"2015-11-19T09:37:20Z","updated_at":"2016-02-09T09:05:51Z","pushed_at":"2016-06-20T13:34:17Z","git_url":"git://github.com/Precis/googleads-python-lib.git","ssh_url":"git@github.com:Precis/googleads-python-lib.git","clone_url":"https://github.com/Precis/googleads-python-lib.git","svn_url":"https://github.com/Precis/googleads-python-lib","homepage":null,"size":3290,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleads:master","ref":"master","sha":"c5d3f7cdbc1f9b61cc765047f14cac17431a15ae","user":{"login":"googleads","id":4551618,"avatar_url":"https://avatars.githubusercontent.com/u/4551618?v=3","gravatar_id":"","url":"https://api.github.com/users/googleads","html_url":"https://github.com/googleads","followers_url":"https://api.github.com/users/googleads/followers","following_url":"https://api.github.com/users/googleads/following{/other_user}","gists_url":"https://api.github.com/users/googleads/gists{/gist_id}","starred_url":"https://api.github.com/users/googleads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleads/subscriptions","organizations_url":"https://api.github.com/users/googleads/orgs","repos_url":"https://api.github.com/users/googleads/repos","events_url":"https://api.github.com/users/googleads/events{/privacy}","received_events_url":"https://api.github.com/users/googleads/received_events","type":"Organization","site_admin":false},"repo":{"id":17710133,"name":"googleads-python-lib","full_name":"googleads/googleads-python-lib","owner":{"login":"googleads","id":4551618,"avatar_url":"https://avatars.githubusercontent.com/u/4551618?v=3","gravatar_id":"","url":"https://api.github.com/users/googleads","html_url":"https://github.com/googleads","followers_url":"https://api.github.com/users/googleads/followers","following_url":"https://api.github.com/users/googleads/following{/other_user}","gists_url":"https://api.github.com/users/googleads/gists{/gist_id}","starred_url":"https://api.github.com/users/googleads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleads/subscriptions","organizations_url":"https://api.github.com/users/googleads/orgs","repos_url":"https://api.github.com/users/googleads/repos","events_url":"https://api.github.com/users/googleads/events{/privacy}","received_events_url":"https://api.github.com/users/googleads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleads/googleads-python-lib","description":"The Python client library for Google's Ads APIs","fork":false,"url":"https://api.github.com/repos/googleads/googleads-python-lib","forks_url":"https://api.github.com/repos/googleads/googleads-python-lib/forks","keys_url":"https://api.github.com/repos/googleads/googleads-python-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleads/googleads-python-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleads/googleads-python-lib/teams","hooks_url":"https://api.github.com/repos/googleads/googleads-python-lib/hooks","issue_events_url":"https://api.github.com/repos/googleads/googleads-python-lib/issues/events{/number}","events_url":"https://api.github.com/repos/googleads/googleads-python-lib/events","assignees_url":"https://api.github.com/repos/googleads/googleads-python-lib/assignees{/user}","branches_url":"https://api.github.com/repos/googleads/googleads-python-lib/branches{/branch}","tags_url":"https://api.github.com/repos/googleads/googleads-python-lib/tags","blobs_url":"https://api.github.com/repos/googleads/googleads-python-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleads/googleads-python-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleads/googleads-python-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleads/googleads-python-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleads/googleads-python-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/googleads/googleads-python-lib/languages","stargazers_url":"https://api.github.com/repos/googleads/googleads-python-lib/stargazers","contributors_url":"https://api.github.com/repos/googleads/googleads-python-lib/contributors","subscribers_url":"https://api.github.com/repos/googleads/googleads-python-lib/subscribers","subscription_url":"https://api.github.com/repos/googleads/googleads-python-lib/subscription","commits_url":"https://api.github.com/repos/googleads/googleads-python-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleads/googleads-python-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleads/googleads-python-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleads/googleads-python-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleads/googleads-python-lib/contents/{+path}","compare_url":"https://api.github.com/repos/googleads/googleads-python-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleads/googleads-python-lib/merges","archive_url":"https://api.github.com/repos/googleads/googleads-python-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleads/googleads-python-lib/downloads","issues_url":"https://api.github.com/repos/googleads/googleads-python-lib/issues{/number}","pulls_url":"https://api.github.com/repos/googleads/googleads-python-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/googleads/googleads-python-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/googleads/googleads-python-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleads/googleads-python-lib/labels{/name}","releases_url":"https://api.github.com/repos/googleads/googleads-python-lib/releases{/id}","deployments_url":"https://api.github.com/repos/googleads/googleads-python-lib/deployments","created_at":"2014-03-13T13:00:34Z","updated_at":"2016-07-11T15:08:05Z","pushed_at":"2016-06-17T21:40:44Z","git_url":"git://github.com/googleads/googleads-python-lib.git","ssh_url":"git@github.com:googleads/googleads-python-lib.git","clone_url":"https://github.com/googleads/googleads-python-lib.git","svn_url":"https://github.com/googleads/googleads-python-lib","homepage":null,"size":3926,"stargazers_count":126,"watchers_count":126,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":181,"mirror_url":null,"open_issues_count":18,"forks":181,"open_issues":18,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89"},"html":{"href":"https://github.com/googleads/googleads-python-lib/pull/89"},"issue":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/issues/89"},"comments":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/googleads/googleads-python-lib/statuses/a2bd7d319d50bb8f344be59eb2b4df407b9c0dc1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":175,"deletions":72,"changed_files":4}}
{"actor":{"display_login":"merll"}}