{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/92907468","pull_request_review_id":13433280,"id":92907468,"diff_hunk":"@@ -485,6 +485,10 @@ const ARTRenderer = ReactFiberReconciler({\n     // Noop\n   },\n \n+  getRootHostContext() {\n+    return null;","path":"src/renderers/art/ReactARTFiber.js","position":5,"original_position":5,"commit_id":"d36ba98a994569afbf731d33e762af25ef90411b","original_commit_id":"d36ba98a994569afbf731d33e762af25ef90411b","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"IIRC you wanted something like this anyway.","created_at":"2016-12-17T00:20:04Z","updated_at":"2016-12-17T00:20:04Z","html_url":"https://github.com/facebook/react/pull/8586#discussion_r92907468","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8586","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/92907468"},"html":{"href":"https://github.com/facebook/react/pull/8586#discussion_r92907468"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8586"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8586","id":98259394,"html_url":"https://github.com/facebook/react/pull/8586","diff_url":"https://github.com/facebook/react/pull/8586.diff","patch_url":"https://github.com/facebook/react/pull/8586.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8586","number":8586,"state":"open","locked":false,"title":"[Fiber][WIP] Nesting validation warnings","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"Dirty right now, will clean up tomorrow. But it almost works.\r\n\r\nNot very happy with different host context types in DEV and PROD but I don't know how else to avoid extra allocations in PROD.\r\n\r\nIt is annoying to have to recalculate own context for non-reified text in host components so I probably need to pass own context to hosts. Also I might need to add something like `getRootHostContext` to avoid passing root instance to every `getChildContext`.","created_at":"2016-12-16T00:39:27Z","updated_at":"2016-12-17T00:20:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ebb4a8362fe6a5703ac53209ce5e926db65b869","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8586/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8586/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8586/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/d36ba98a994569afbf731d33e762af25ef90411b","head":{"label":"gaearon:warnings-3","ref":"warnings-3","sha":"d36ba98a994569afbf731d33e762af25ef90411b","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"repo":{"id":71563876,"name":"react","full_name":"gaearon/react","owner":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaearon/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/gaearon/react","forks_url":"https://api.github.com/repos/gaearon/react/forks","keys_url":"https://api.github.com/repos/gaearon/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaearon/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaearon/react/teams","hooks_url":"https://api.github.com/repos/gaearon/react/hooks","issue_events_url":"https://api.github.com/repos/gaearon/react/issues/events{/number}","events_url":"https://api.github.com/repos/gaearon/react/events","assignees_url":"https://api.github.com/repos/gaearon/react/assignees{/user}","branches_url":"https://api.github.com/repos/gaearon/react/branches{/branch}","tags_url":"https://api.github.com/repos/gaearon/react/tags","blobs_url":"https://api.github.com/repos/gaearon/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaearon/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaearon/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaearon/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaearon/react/statuses/{sha}","languages_url":"https://api.github.com/repos/gaearon/react/languages","stargazers_url":"https://api.github.com/repos/gaearon/react/stargazers","contributors_url":"https://api.github.com/repos/gaearon/react/contributors","subscribers_url":"https://api.github.com/repos/gaearon/react/subscribers","subscription_url":"https://api.github.com/repos/gaearon/react/subscription","commits_url":"https://api.github.com/repos/gaearon/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaearon/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaearon/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaearon/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaearon/react/contents/{+path}","compare_url":"https://api.github.com/repos/gaearon/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaearon/react/merges","archive_url":"https://api.github.com/repos/gaearon/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaearon/react/downloads","issues_url":"https://api.github.com/repos/gaearon/react/issues{/number}","pulls_url":"https://api.github.com/repos/gaearon/react/pulls{/number}","milestones_url":"https://api.github.com/repos/gaearon/react/milestones{/number}","notifications_url":"https://api.github.com/repos/gaearon/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaearon/react/labels{/name}","releases_url":"https://api.github.com/repos/gaearon/react/releases{/id}","deployments_url":"https://api.github.com/repos/gaearon/react/deployments","created_at":"2016-10-21T12:39:49Z","updated_at":"2016-12-01T23:26:08Z","pushed_at":"2016-12-17T00:09:59Z","git_url":"git://github.com/gaearon/react.git","ssh_url":"git@github.com:gaearon/react.git","clone_url":"https://github.com/gaearon/react.git","svn_url":"https://github.com/gaearon/react","homepage":"https://facebook.github.io/react/","size":71047,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7fca464e7cf8a3e23d14dd5b9f5e8d1cef0116aa","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-12-17T00:06:52Z","pushed_at":"2016-12-17T00:10:00Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":111450,"stargazers_count":55877,"watchers_count":55877,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10077,"mirror_url":null,"open_issues_count":655,"forks":10077,"open_issues":655,"watchers":55877,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8586"},"html":{"href":"https://github.com/facebook/react/pull/8586"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8586"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8586/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8586/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8586/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/d36ba98a994569afbf731d33e762af25ef90411b"}}}}
{"actor":{"display_login":"gaearon"}}