{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8459","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8459/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8459/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8459/events","html_url":"https://github.com/Automattic/wp-calypso/pull/8459","id":181002246,"number":8459,"title":"server/pages: Convert Jade to JSX templates","user":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"assignees":[{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-10-04T20:54:27Z","updated_at":"2016-10-07T19:50:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8459","html_url":"https://github.com/Automattic/wp-calypso/pull/8459","diff_url":"https://github.com/Automattic/wp-calypso/pull/8459.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/8459.patch"},"body":"Reboot of #4723 since the latest node (and possibly Babel) upgrades did miraculously solve some issues this branch had.\r\n\r\nThis PR uses `dangerouslySetInnerHtml` in `pages/index.jsx` to output the `renderToString`-rendered `Layout` element tree for SSR'd sections (=== Theme Sheets) as opposed to just putting that element tree into `pages/index.jsx`. This is done since\r\n\r\n1. `express-react-views` (which this PR uses to render `pages/*.jsx`) internally uses `renderToStaticMarkup`, which loses  `data-reactid`s -- so its output can't be reconciled with the client generated React element tree.\r\n2. We'd lose our current markup cache and would have to come up with a different solution.\r\n\r\nNote that this PR removes the iOS specific magic from `index.jade` which has been unused for a while (see `10207-gh-calypso-pre-oss`).\r\n\r\nIdeally, we'd also use the `EmptyContent` component for `404.jsx` and `500.jsx`, but that chokes on ES6 statements in that component for me.\r\n\r\nCode QA:\r\n* Make sure JSX files are up to par with their jade counterparts.\r\n\r\nTo test:\r\n* Compare Page Source for this branch and `master` (or production), in particular:\r\n * For any logged-in section\r\n * For logged-out `/design`\r\n * For a logged-out 'Theme' (e.g. `/theme/twentyten`)\r\n * For a 404 (e.g. `/blah`)\r\n\r\nPerformance QA:\r\n* Compare this branch to `master`\r\n\r\ncc @gwwar @aduth @mtias @ehg for review"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/252345323","html_url":"https://github.com/Automattic/wp-calypso/pull/8459#issuecomment-252345323","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8459","id":252345323,"user":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T19:50:33Z","updated_at":"2016-10-07T19:50:33Z","body":"Seems like it's possible to turn that off, though: https://github.com/reactjs/express-react-views#options\r\n\r\nMakes me wonder though why it doesn't pick up our pre-babelled code anyway (outside the `views` dir, I mean)."}}
{"actor":{"display_login":"ockham"}}