{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3918","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3918/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3918/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3918/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3918","id":161791964,"number":3918,"title":"constexpr added to BitSet.h","user":{"login":"dhustkoder","id":11935784,"avatar_url":"https://avatars.githubusercontent.com/u/11935784?v=3","gravatar_id":"","url":"https://api.github.com/users/dhustkoder","html_url":"https://github.com/dhustkoder","followers_url":"https://api.github.com/users/dhustkoder/followers","following_url":"https://api.github.com/users/dhustkoder/following{/other_user}","gists_url":"https://api.github.com/users/dhustkoder/gists{/gist_id}","starred_url":"https://api.github.com/users/dhustkoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhustkoder/subscriptions","organizations_url":"https://api.github.com/users/dhustkoder/orgs","repos_url":"https://api.github.com/users/dhustkoder/repos","events_url":"https://api.github.com/users/dhustkoder/events{/privacy}","received_events_url":"https://api.github.com/users/dhustkoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-22T21:33:30Z","updated_at":"2016-06-22T22:31:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3918","html_url":"https://github.com/dolphin-emu/dolphin/pull/3918","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3918.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3918.patch"},"body":"Have been looking for some TODOs in the Core and found this. \r\nI've added constexpr only for functions within C++11 constexpr rules, the rest ( non const member functions ) need C++14 constexpr extension.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3918)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/227897377","html_url":"https://github.com/dolphin-emu/dolphin/pull/3918#issuecomment-227897377","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3918","id":227897377,"user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T22:31:00Z","updated_at":"2016-06-22T22:31:00Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[Source/Core/Common/BitSet.h, line 17 \\[r1\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/3918#-KKuDDEJL4KEc_jbc7T4:-KKuDDEJL4KEc_jbc7T5:-520400085) ([raw file](https://github.com/dolphin-emu/dolphin/blob/42ebe7a1847f41cb727c553298335b04c98f2cf9/Source/Core/Common/BitSet.h#L17)):*\n> ```objc\n> \n> template <typename T>\n> static inline constexpr int CountSetBits(T v)\n> ```\n\nThis should not be made constexpr if the non-MSVC equivalents are also not constexpr.\n\n---\n\n*[Source/Core/Common/BitSet.h, line 152 \\[r1\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/3918#-KKuDfmx5kZ5CHeeQSLM:-KKuDfmyUsvCcoNEBaRM:943490171) ([raw file](https://github.com/dolphin-emu/dolphin/blob/42ebe7a1847f41cb727c553298335b04c98f2cf9/Source/Core/Common/BitSet.h#L152)):*\n> ```objc\n> \t}\n> \n> \tstatic BitSet AllTrue(size_t count)\n> ```\n\nThis is capable of being constexpr\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dolphin-emu/dolphin/3918)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lioncash"}}