{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/67553009","id":67553009,"diff_hunk":"@@ -114,8 +147,8 @@ public class SetBreakpointCommandTests {\n             Assert.AreEqual(commandId, setBreakpointCommand.Id);\n             Assert.AreEqual(\n                 string.Format(\n-                    \"{{\\\"command\\\":\\\"setbreakpoint\\\",\\\"seq\\\":{0},\\\"type\\\":\\\"request\\\",\\\"arguments\\\":{{\\\"line\\\":{1},\\\"column\\\":{2},\\\"type\\\":\\\"script\\\",\\\"target\\\":\\\"{3}\\\",\\\"ignoreCount\\\":1}}}}\",\n-                    commandId, line, column, fileName.Replace(@\"\\\", @\"\\\\\")),\n+                    \"{{\\\"command\\\":\\\"setbreakpoint\\\",\\\"seq\\\":{0},\\\"type\\\":\\\"request\\\",\\\"arguments\\\":{{\\\"line\\\":{1},\\\"column\\\":{2},\\\"type\\\":\\\"scriptRegExp\\\",\\\"target\\\":\\\"{3}\\\",\\\"ignoreCount\\\":1}}}}\",\n+                    commandId, line, column, SetBreakpointCommand.CreateLocalScriptRegExp(fileName).Replace(@\"\\\", @\"\\\\\")),\n                 setBreakpointCommand.ToString());\n         }","path":"Nodejs/Tests/Core/Debugger/Commands/SetBreakpointCommandTests.cs","position":56,"original_position":56,"commit_id":"20c8dd7e33fcc2bcccf2e3af797098ae3f983992","original_commit_id":"20c8dd7e33fcc2bcccf2e3af797098ae3f983992","user":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"body":"If you haven't already - can you also take a look through existing UI tests and see if we need to change anything there? ","created_at":"2016-06-17T18:14:01Z","updated_at":"2016-06-17T18:14:01Z","html_url":"https://github.com/Microsoft/nodejstools/pull/1054#discussion_r67553009","pull_request_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/67553009"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/1054#discussion_r67553009"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054","id":73832108,"html_url":"https://github.com/Microsoft/nodejstools/pull/1054","diff_url":"https://github.com/Microsoft/nodejstools/pull/1054.diff","patch_url":"https://github.com/Microsoft/nodejstools/pull/1054.patch","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1054","number":1054,"state":"open","locked":false,"title":"Fix Node 6 Debugging","user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"body":"Issue #934\r\n\r\n##### Bug\r\nInitial breakpoints currently sometimes do not resolve when using Node 6.x. In most cases, you can remove the breakpoint and add it back about 30 seconds after the program has started in order to get it to resolve.\r\n\r\n##### Fix\r\nI believe something with Node 6 changed the casing for the names of scripts in the v8-debug protocol. \r\n\r\nThere were two fixes here:\r\n\r\n* Use a case insensitive regular expression to match the script names when setting a breakpoint (I believe this is similar to what VS code does)\r\n* Fix one case where we were relying on a case sensitive comparision to update a breakpoint.\r\n\r\nThis is not quite tested to be get merged in just yet, but wanted to see if there were any initial concerns or feedback with the approch here.","created_at":"2016-06-14T23:44:47Z","updated_at":"2016-06-17T18:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62724f93561299bd81c2c0e0d316eb861f66566a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1054/comments","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/20c8dd7e33fcc2bcccf2e3af797098ae3f983992","head":{"label":"mjbvz:fix-node6-debugging","ref":"fix-node6-debugging","sha":"20c8dd7e33fcc2bcccf2e3af797098ae3f983992","user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"repo":{"id":52391688,"name":"nodejstools","full_name":"mjbvz/nodejstools","owner":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjbvz/nodejstools","description":"Node.js Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/mjbvz/nodejstools","forks_url":"https://api.github.com/repos/mjbvz/nodejstools/forks","keys_url":"https://api.github.com/repos/mjbvz/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjbvz/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjbvz/nodejstools/teams","hooks_url":"https://api.github.com/repos/mjbvz/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/mjbvz/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/mjbvz/nodejstools/events","assignees_url":"https://api.github.com/repos/mjbvz/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/mjbvz/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/mjbvz/nodejstools/tags","blobs_url":"https://api.github.com/repos/mjbvz/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjbvz/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjbvz/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjbvz/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjbvz/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/mjbvz/nodejstools/languages","stargazers_url":"https://api.github.com/repos/mjbvz/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/mjbvz/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/mjbvz/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/mjbvz/nodejstools/subscription","commits_url":"https://api.github.com/repos/mjbvz/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjbvz/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjbvz/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjbvz/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjbvz/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/mjbvz/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjbvz/nodejstools/merges","archive_url":"https://api.github.com/repos/mjbvz/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjbvz/nodejstools/downloads","issues_url":"https://api.github.com/repos/mjbvz/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/mjbvz/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/mjbvz/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/mjbvz/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjbvz/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/mjbvz/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/mjbvz/nodejstools/deployments","created_at":"2016-02-23T21:06:55Z","updated_at":"2016-02-23T21:07:01Z","pushed_at":"2016-06-16T23:12:42Z","git_url":"git://github.com/mjbvz/nodejstools.git","ssh_url":"git@github.com:mjbvz/nodejstools.git","clone_url":"https://github.com/mjbvz/nodejstools.git","svn_url":"https://github.com/mjbvz/nodejstools","homepage":"http://aka.ms/explorentvs","size":93393,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8875b2749a1130563ff5c78e2dab03f76c596770","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33017149,"name":"nodejstools","full_name":"Microsoft/nodejstools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/nodejstools","description":"Node.js Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/nodejstools","forks_url":"https://api.github.com/repos/Microsoft/nodejstools/forks","keys_url":"https://api.github.com/repos/Microsoft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nodejstools/teams","hooks_url":"https://api.github.com/repos/Microsoft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nodejstools/events","assignees_url":"https://api.github.com/repos/Microsoft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nodejstools/tags","blobs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nodejstools/subscription","commits_url":"https://api.github.com/repos/Microsoft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nodejstools/merges","archive_url":"https://api.github.com/repos/Microsoft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nodejstools/downloads","issues_url":"https://api.github.com/repos/Microsoft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/nodejstools/deployments","created_at":"2015-03-28T01:37:20Z","updated_at":"2016-06-15T20:23:12Z","pushed_at":"2016-06-17T01:09:57Z","git_url":"git://github.com/Microsoft/nodejstools.git","ssh_url":"git@github.com:Microsoft/nodejstools.git","clone_url":"https://github.com/Microsoft/nodejstools.git","svn_url":"https://github.com/Microsoft/nodejstools","homepage":"http://aka.ms/explorentvs","size":95057,"stargazers_count":1246,"watchers_count":1246,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":236,"forks":208,"open_issues":236,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/1054"},"issue":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/1054"},"comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nodejstools/statuses/20c8dd7e33fcc2bcccf2e3af797098ae3f983992"}}}}
{"actor":{"display_login":"mousetraps"}}