{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/92970257","pull_request_review_id":13491012,"id":92970257,"diff_hunk":"@@ -0,0 +1,25 @@\n+/*","path":"pkg/model/misc.go","position":1,"original_position":1,"commit_id":"50296f1a30989dbaecb56c70cd3a2c6708b7fd94","original_commit_id":"91b77ae11e73501c2dbfbe08ed046f7682e14f8d","user":{"login":"kris-nova","id":13757818,"avatar_url":"https://avatars.githubusercontent.com/u/13757818?v=3","gravatar_id":"","url":"https://api.github.com/users/kris-nova","html_url":"https://github.com/kris-nova","followers_url":"https://api.github.com/users/kris-nova/followers","following_url":"https://api.github.com/users/kris-nova/following{/other_user}","gists_url":"https://api.github.com/users/kris-nova/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-nova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-nova/subscriptions","organizations_url":"https://api.github.com/users/kris-nova/orgs","repos_url":"https://api.github.com/users/kris-nova/repos","events_url":"https://api.github.com/users/kris-nova/events{/privacy}","received_events_url":"https://api.github.com/users/kris-nova/received_events","type":"User","site_admin":false},"body":"Just in general whenever a shortcut name like `s()` is used, I have found it useful to have it wrap a more verbose function - that's all I am getting at - simple code doc would work too ","created_at":"2016-12-19T05:30:58Z","updated_at":"2016-12-19T05:30:58Z","html_url":"https://github.com/kubernetes/kops/pull/1183#discussion_r92970257","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/1183","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/92970257"},"html":{"href":"https://github.com/kubernetes/kops/pull/1183#discussion_r92970257"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1183"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/1183","id":98450794,"html_url":"https://github.com/kubernetes/kops/pull/1183","diff_url":"https://github.com/kubernetes/kops/pull/1183.diff","patch_url":"https://github.com/kubernetes/kops/pull/1183.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/1183","number":1183,"state":"open","locked":false,"title":"WIP: v1alpha2 API","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/1183)\n<!-- Reviewable:end -->\n","created_at":"2016-12-17T17:59:28Z","updated_at":"2016-12-19T05:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"731536100b5b727d413a8fa140183334fade3965","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/1183/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/1183/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/1183/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/50296f1a30989dbaecb56c70cd3a2c6708b7fd94","head":{"label":"justinsb:use_ig_for_bastions_2","ref":"use_ig_for_bastions_2","sha":"50296f1a30989dbaecb56c70cd3a2c6708b7fd94","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"repo":{"id":62278833,"name":"kops","full_name":"justinsb/kops","owner":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinsb/kops","description":"kops deployment","fork":true,"url":"https://api.github.com/repos/justinsb/kops","forks_url":"https://api.github.com/repos/justinsb/kops/forks","keys_url":"https://api.github.com/repos/justinsb/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinsb/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinsb/kops/teams","hooks_url":"https://api.github.com/repos/justinsb/kops/hooks","issue_events_url":"https://api.github.com/repos/justinsb/kops/issues/events{/number}","events_url":"https://api.github.com/repos/justinsb/kops/events","assignees_url":"https://api.github.com/repos/justinsb/kops/assignees{/user}","branches_url":"https://api.github.com/repos/justinsb/kops/branches{/branch}","tags_url":"https://api.github.com/repos/justinsb/kops/tags","blobs_url":"https://api.github.com/repos/justinsb/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinsb/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinsb/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinsb/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinsb/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/justinsb/kops/languages","stargazers_url":"https://api.github.com/repos/justinsb/kops/stargazers","contributors_url":"https://api.github.com/repos/justinsb/kops/contributors","subscribers_url":"https://api.github.com/repos/justinsb/kops/subscribers","subscription_url":"https://api.github.com/repos/justinsb/kops/subscription","commits_url":"https://api.github.com/repos/justinsb/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinsb/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinsb/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinsb/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinsb/kops/contents/{+path}","compare_url":"https://api.github.com/repos/justinsb/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinsb/kops/merges","archive_url":"https://api.github.com/repos/justinsb/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinsb/kops/downloads","issues_url":"https://api.github.com/repos/justinsb/kops/issues{/number}","pulls_url":"https://api.github.com/repos/justinsb/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/justinsb/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/justinsb/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinsb/kops/labels{/name}","releases_url":"https://api.github.com/repos/justinsb/kops/releases{/id}","deployments_url":"https://api.github.com/repos/justinsb/kops/deployments","created_at":"2016-06-30T04:16:38Z","updated_at":"2016-09-29T08:56:59Z","pushed_at":"2016-12-19T05:23:31Z","git_url":"git://github.com/justinsb/kops.git","ssh_url":"git@github.com:justinsb/kops.git","clone_url":"https://github.com/justinsb/kops.git","svn_url":"https://github.com/justinsb/kops","homepage":"","size":104806,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6ce2cc3664414e320e48cd400b17a39b0cb36d03","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2016-12-19T03:21:53Z","pushed_at":"2016-12-19T05:23:40Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":104631,"stargazers_count":733,"watchers_count":733,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":412,"forks":137,"open_issues":412,"watchers":733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1183"},"html":{"href":"https://github.com/kubernetes/kops/pull/1183"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1183"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1183/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1183/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1183/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/50296f1a30989dbaecb56c70cd3a2c6708b7fd94"}}}}
{"actor":{"display_login":"kris-nova"}}