{"action":"created","comment":{"url":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/52377821","id":52377821,"diff_hunk":"@@ -1,139 +0,0 @@\n-/**\n- * Licensed to Apereo under one or more contributor license\n- * agreements. See the NOTICE file distributed with this work\n- * for additional information regarding copyright ownership.\n- * Apereo licenses this file to you under the Apache License,\n- * Version 2.0 (the \"License\"); you may not use this file\n- * except in compliance with the License.  You may obtain a\n- * copy of the License at the following location:\n- *\n- *   http://www.apache.org/licenses/LICENSE-2.0\n- *\n- * Unless required by applicable law or agreed to in writing,\n- * software distributed under the License is distributed on an\n- * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n- * KIND, either express or implied.  See the License for the\n- * specific language governing permissions and limitations\n- * under the License.\n- */\n-package org.jasig.portal.security.provider;\n-\n-import java.util.Date;\n-import java.util.Iterator;\n-\n-import org.jasig.portal.AuthorizationException;\n-import org.jasig.portal.groups.GroupsException;\n-import org.jasig.portal.groups.IGroupMember;\n-import org.jasig.portal.permission.IPermissionActivity;\n-import org.jasig.portal.permission.IPermissionOwner;\n-import org.jasig.portal.permission.target.IPermissionTarget;\n-import org.jasig.portal.security.IAuthorizationPrincipal;\n-import org.jasig.portal.security.IAuthorizationService;\n-import org.jasig.portal.security.IPermission;\n-import org.jasig.portal.security.IPermissionPolicy;\n-\n-/**\n- * Implements a strategy for answering the basic authorization question: does the\n- * <code>principal</code> have permission to perform the <code>activity</code> on\n- * the <code>target</code>.\n- *\n- * @author Dan Ellentuck (de3@columbia.edu)\n- * @version $Revision$\n- */\n-public class DefaultPermissionPolicy implements IPermissionPolicy {","path":"uportal-war/src/main/java/org/jasig/portal/security/provider/DefaultPermissionPolicy.java","position":43,"original_position":43,"commit_id":"a40d8a63a6bae8982cf8b9e0d7666d2d81253292","original_commit_id":"a40d8a63a6bae8982cf8b9e0d7666d2d81253292","user":{"login":"bjagg","id":1264750,"avatar_url":"https://avatars.githubusercontent.com/u/1264750?v=3","gravatar_id":"","url":"https://api.github.com/users/bjagg","html_url":"https://github.com/bjagg","followers_url":"https://api.github.com/users/bjagg/followers","following_url":"https://api.github.com/users/bjagg/following{/other_user}","gists_url":"https://api.github.com/users/bjagg/gists{/gist_id}","starred_url":"https://api.github.com/users/bjagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjagg/subscriptions","organizations_url":"https://api.github.com/users/bjagg/orgs","repos_url":"https://api.github.com/users/bjagg/repos","events_url":"https://api.github.com/users/bjagg/events{/privacy}","received_events_url":"https://api.github.com/users/bjagg/received_events","type":"User","site_admin":false},"body":"The reason to remove in this PR is thin -- I found it confusing to have an unused class when checking the policy code.","created_at":"2016-02-09T21:37:09Z","updated_at":"2016-02-09T21:37:09Z","html_url":"https://github.com/Jasig/uPortal/pull/616#discussion_r52377821","pull_request_url":"https://api.github.com/repos/Jasig/uPortal/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/52377821"},"html":{"href":"https://github.com/Jasig/uPortal/pull/616#discussion_r52377821"},"pull_request":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/Jasig/uPortal/pulls/616","id":56917490,"html_url":"https://github.com/Jasig/uPortal/pull/616","diff_url":"https://github.com/Jasig/uPortal/pull/616.diff","patch_url":"https://github.com/Jasig/uPortal/pull/616.patch","issue_url":"https://api.github.com/repos/Jasig/uPortal/issues/616","number":616,"state":"open","locked":false,"title":"UP-4617: clean up data set permissions","user":{"login":"bjagg","id":1264750,"avatar_url":"https://avatars.githubusercontent.com/u/1264750?v=3","gravatar_id":"","url":"https://api.github.com/users/bjagg","html_url":"https://github.com/bjagg","followers_url":"https://api.github.com/users/bjagg/followers","following_url":"https://api.github.com/users/bjagg/following{/other_user}","gists_url":"https://api.github.com/users/bjagg/gists{/gist_id}","starred_url":"https://api.github.com/users/bjagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjagg/subscriptions","organizations_url":"https://api.github.com/users/bjagg/orgs","repos_url":"https://api.github.com/users/bjagg/repos","events_url":"https://api.github.com/users/bjagg/events{/privacy}","received_events_url":"https://api.github.com/users/bjagg/received_events","type":"User","site_admin":false},"body":"Reducing default permissions for developers an fragment owners.","created_at":"2016-01-22T17:33:13Z","updated_at":"2016-02-09T21:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d9c54139e4632af266f2adedfc0d0f41e87c30f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/uPortal/pulls/616/commits","review_comments_url":"https://api.github.com/repos/Jasig/uPortal/pulls/616/comments","review_comment_url":"https://api.github.com/repos/Jasig/uPortal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jasig/uPortal/issues/616/comments","statuses_url":"https://api.github.com/repos/Jasig/uPortal/statuses/a40d8a63a6bae8982cf8b9e0d7666d2d81253292","head":{"label":"bjagg:UP-4617_clean-up-data-set-permissions","ref":"UP-4617_clean-up-data-set-permissions","sha":"a40d8a63a6bae8982cf8b9e0d7666d2d81253292","user":{"login":"bjagg","id":1264750,"avatar_url":"https://avatars.githubusercontent.com/u/1264750?v=3","gravatar_id":"","url":"https://api.github.com/users/bjagg","html_url":"https://github.com/bjagg","followers_url":"https://api.github.com/users/bjagg/followers","following_url":"https://api.github.com/users/bjagg/following{/other_user}","gists_url":"https://api.github.com/users/bjagg/gists{/gist_id}","starred_url":"https://api.github.com/users/bjagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjagg/subscriptions","organizations_url":"https://api.github.com/users/bjagg/orgs","repos_url":"https://api.github.com/users/bjagg/repos","events_url":"https://api.github.com/users/bjagg/events{/privacy}","received_events_url":"https://api.github.com/users/bjagg/received_events","type":"User","site_admin":false},"repo":{"id":21404063,"name":"uPortal","full_name":"bjagg/uPortal","owner":{"login":"bjagg","id":1264750,"avatar_url":"https://avatars.githubusercontent.com/u/1264750?v=3","gravatar_id":"","url":"https://api.github.com/users/bjagg","html_url":"https://github.com/bjagg","followers_url":"https://api.github.com/users/bjagg/followers","following_url":"https://api.github.com/users/bjagg/following{/other_user}","gists_url":"https://api.github.com/users/bjagg/gists{/gist_id}","starred_url":"https://api.github.com/users/bjagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjagg/subscriptions","organizations_url":"https://api.github.com/users/bjagg/orgs","repos_url":"https://api.github.com/users/bjagg/repos","events_url":"https://api.github.com/users/bjagg/events{/privacy}","received_events_url":"https://api.github.com/users/bjagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjagg/uPortal","description":"Enterprise open source portal built by and for the higher education community.","fork":true,"url":"https://api.github.com/repos/bjagg/uPortal","forks_url":"https://api.github.com/repos/bjagg/uPortal/forks","keys_url":"https://api.github.com/repos/bjagg/uPortal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjagg/uPortal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjagg/uPortal/teams","hooks_url":"https://api.github.com/repos/bjagg/uPortal/hooks","issue_events_url":"https://api.github.com/repos/bjagg/uPortal/issues/events{/number}","events_url":"https://api.github.com/repos/bjagg/uPortal/events","assignees_url":"https://api.github.com/repos/bjagg/uPortal/assignees{/user}","branches_url":"https://api.github.com/repos/bjagg/uPortal/branches{/branch}","tags_url":"https://api.github.com/repos/bjagg/uPortal/tags","blobs_url":"https://api.github.com/repos/bjagg/uPortal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjagg/uPortal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjagg/uPortal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjagg/uPortal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjagg/uPortal/statuses/{sha}","languages_url":"https://api.github.com/repos/bjagg/uPortal/languages","stargazers_url":"https://api.github.com/repos/bjagg/uPortal/stargazers","contributors_url":"https://api.github.com/repos/bjagg/uPortal/contributors","subscribers_url":"https://api.github.com/repos/bjagg/uPortal/subscribers","subscription_url":"https://api.github.com/repos/bjagg/uPortal/subscription","commits_url":"https://api.github.com/repos/bjagg/uPortal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjagg/uPortal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjagg/uPortal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjagg/uPortal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjagg/uPortal/contents/{+path}","compare_url":"https://api.github.com/repos/bjagg/uPortal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjagg/uPortal/merges","archive_url":"https://api.github.com/repos/bjagg/uPortal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjagg/uPortal/downloads","issues_url":"https://api.github.com/repos/bjagg/uPortal/issues{/number}","pulls_url":"https://api.github.com/repos/bjagg/uPortal/pulls{/number}","milestones_url":"https://api.github.com/repos/bjagg/uPortal/milestones{/number}","notifications_url":"https://api.github.com/repos/bjagg/uPortal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjagg/uPortal/labels{/name}","releases_url":"https://api.github.com/repos/bjagg/uPortal/releases{/id}","deployments_url":"https://api.github.com/repos/bjagg/uPortal/deployments","created_at":"2014-07-01T22:21:15Z","updated_at":"2016-01-11T22:07:52Z","pushed_at":"2016-02-05T01:06:33Z","git_url":"git://github.com/bjagg/uPortal.git","ssh_url":"git@github.com:bjagg/uPortal.git","clone_url":"https://github.com/bjagg/uPortal.git","svn_url":"https://github.com/bjagg/uPortal","homepage":"http://www.jasig.org/uportal","size":146954,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"b8cd173f65b27f2af02759cf5bfaaf85152945c3","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":2614085,"name":"uPortal","full_name":"Jasig/uPortal","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/uPortal","description":"Enterprise open source portal built by and for the higher education community.","fork":false,"url":"https://api.github.com/repos/Jasig/uPortal","forks_url":"https://api.github.com/repos/Jasig/uPortal/forks","keys_url":"https://api.github.com/repos/Jasig/uPortal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/uPortal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/uPortal/teams","hooks_url":"https://api.github.com/repos/Jasig/uPortal/hooks","issue_events_url":"https://api.github.com/repos/Jasig/uPortal/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/uPortal/events","assignees_url":"https://api.github.com/repos/Jasig/uPortal/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/uPortal/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/uPortal/tags","blobs_url":"https://api.github.com/repos/Jasig/uPortal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/uPortal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/uPortal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/uPortal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/uPortal/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/uPortal/languages","stargazers_url":"https://api.github.com/repos/Jasig/uPortal/stargazers","contributors_url":"https://api.github.com/repos/Jasig/uPortal/contributors","subscribers_url":"https://api.github.com/repos/Jasig/uPortal/subscribers","subscription_url":"https://api.github.com/repos/Jasig/uPortal/subscription","commits_url":"https://api.github.com/repos/Jasig/uPortal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/uPortal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/uPortal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/uPortal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/uPortal/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/uPortal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/uPortal/merges","archive_url":"https://api.github.com/repos/Jasig/uPortal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/uPortal/downloads","issues_url":"https://api.github.com/repos/Jasig/uPortal/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/uPortal/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/uPortal/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/uPortal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/uPortal/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/uPortal/releases{/id}","deployments_url":"https://api.github.com/repos/Jasig/uPortal/deployments","created_at":"2011-10-20T15:34:22Z","updated_at":"2016-02-09T00:31:49Z","pushed_at":"2016-02-08T21:11:47Z","git_url":"git://github.com/Jasig/uPortal.git","ssh_url":"git@github.com:Jasig/uPortal.git","clone_url":"https://github.com/Jasig/uPortal.git","svn_url":"https://github.com/Jasig/uPortal","homepage":"http://www.jasig.org/uportal","size":151184,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":27,"forks":172,"open_issues":27,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/616"},"html":{"href":"https://github.com/Jasig/uPortal/pull/616"},"issue":{"href":"https://api.github.com/repos/Jasig/uPortal/issues/616"},"comments":{"href":"https://api.github.com/repos/Jasig/uPortal/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/uPortal/statuses/a40d8a63a6bae8982cf8b9e0d7666d2d81253292"}}}}