{"action":"created","comment":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/65884885","id":65884885,"diff_hunk":"@@ -73,7 +73,9 @@ class A : public Serializable\n     {\n \tstd::string toFill;\n \tsys::byte b[1];\n-\twhile (true)\n+\t// Work-around warning C4127: conditional expression is constant;\n+\t// see https://msdn.microsoft.com/en-us/library/6t66728h.aspx and http://stackoverflow.com/questions/1946445/c-c-how-to-use-the-do-while0-construct-without-compiler-warnings-like-c412\n+\tfor (;;) // while (true)","path":"modules/c++/io/tests/serializeTest1.cpp","position":7,"original_position":7,"commit_id":"6ef0e0ba414e325227c8f34e2b69f0d32228c29e","original_commit_id":"6ef0e0ba414e325227c8f34e2b69f0d32228c29e","user":{"login":"JDanielSmith","id":3493475,"avatar_url":"https://avatars.githubusercontent.com/u/3493475?v=3","gravatar_id":"","url":"https://api.github.com/users/JDanielSmith","html_url":"https://github.com/JDanielSmith","followers_url":"https://api.github.com/users/JDanielSmith/followers","following_url":"https://api.github.com/users/JDanielSmith/following{/other_user}","gists_url":"https://api.github.com/users/JDanielSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JDanielSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDanielSmith/subscriptions","organizations_url":"https://api.github.com/users/JDanielSmith/orgs","repos_url":"https://api.github.com/users/JDanielSmith/repos","events_url":"https://api.github.com/users/JDanielSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JDanielSmith/received_events","type":"User","site_admin":false},"body":"See https://blogs.msdn.microsoft.com/vcblog/2016/06/03/c-core-guidelines-checkers-are-now-in-a-single-nuget-package/ (links to http://reviews.llvm.org/diffusion/L/browse/clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/) for one way to get (a lot?) more warnings on Linux.\r\n\r\nThis (http://stackoverflow.com/a/12247461/8877) SO answer indicates that GCC also has a lot more warnings available than those from -Wall.","created_at":"2016-06-06T12:58:41Z","updated_at":"2016-06-06T12:58:41Z","html_url":"https://github.com/mdaus/coda-oss/pull/133#discussion_r65884885","pull_request_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/65884885"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/133#discussion_r65884885"},"pull_request":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/133","id":72181788,"html_url":"https://github.com/mdaus/coda-oss/pull/133","diff_url":"https://github.com/mdaus/coda-oss/pull/133.diff","patch_url":"https://github.com/mdaus/coda-oss/pull/133.patch","issue_url":"https://api.github.com/repos/mdaus/coda-oss/issues/133","number":133,"state":"open","locked":false,"title":"fix (or turn off) some compiler warnings","user":{"login":"JDanielSmith","id":3493475,"avatar_url":"https://avatars.githubusercontent.com/u/3493475?v=3","gravatar_id":"","url":"https://api.github.com/users/JDanielSmith","html_url":"https://github.com/JDanielSmith","followers_url":"https://api.github.com/users/JDanielSmith/followers","following_url":"https://api.github.com/users/JDanielSmith/following{/other_user}","gists_url":"https://api.github.com/users/JDanielSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JDanielSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDanielSmith/subscriptions","organizations_url":"https://api.github.com/users/JDanielSmith/orgs","repos_url":"https://api.github.com/users/JDanielSmith/repos","events_url":"https://api.github.com/users/JDanielSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JDanielSmith/received_events","type":"User","site_admin":false},"body":"Incremental progress towards fixing (or turning off) various compiler warnings.  Some of these are rather pedantic (to say the least), but they can hide other (more important) warnings.","created_at":"2016-06-01T13:37:23Z","updated_at":"2016-06-06T12:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7293ba9ad4bc2d28cac52402b84986cdfc6cbde0","assignee":{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mdaus/coda-oss/milestones/1","html_url":"https://github.com/mdaus/coda-oss/milestones/CODA%2016.07","labels_url":"https://api.github.com/repos/mdaus/coda-oss/milestones/1/labels","id":1702272,"number":1,"title":"CODA 16.07","description":null,"creator":{"login":"JonathanMeans","id":5521504,"avatar_url":"https://avatars.githubusercontent.com/u/5521504?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanMeans","html_url":"https://github.com/JonathanMeans","followers_url":"https://api.github.com/users/JonathanMeans/followers","following_url":"https://api.github.com/users/JonathanMeans/following{/other_user}","gists_url":"https://api.github.com/users/JonathanMeans/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanMeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanMeans/subscriptions","organizations_url":"https://api.github.com/users/JonathanMeans/orgs","repos_url":"https://api.github.com/users/JonathanMeans/repos","events_url":"https://api.github.com/users/JonathanMeans/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanMeans/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":23,"state":"open","created_at":"2016-04-12T19:46:07Z","updated_at":"2016-06-01T22:04:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/133/commits","review_comments_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/133/comments","review_comment_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/issues/133/comments","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/6ef0e0ba414e325227c8f34e2b69f0d32228c29e","head":{"label":"mdaus:jds-compiler_warnings","ref":"jds-compiler_warnings","sha":"6ef0e0ba414e325227c8f34e2b69f0d32228c29e","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-01-26T13:50:06Z","pushed_at":"2016-06-01T14:59:16Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123471,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"mdaus:master","ref":"master","sha":"1e046b6777d1515123757a99c4e9bfb6288f0c38","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-01-26T13:50:06Z","pushed_at":"2016-06-01T14:59:16Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123471,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/133"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/133"},"issue":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/133"},"comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/mdaus/coda-oss/statuses/6ef0e0ba414e325227c8f34e2b69f0d32228c29e"}}}}
{"actor":{"display_login":"JDanielSmith"}}