{"push_id":1239171859,"size":1,"distinct_size":1,"ref":"refs/heads/3.3","head":"f8701d903a0e7a35314edc2f8502f16914ac9097","before":"21a0e7bb8ebc22609a033b24076cd046462c8f00","commits":[{"sha":"f8701d903a0e7a35314edc2f8502f16914ac9097","author":{"name":"Phil Bates","email":"df59ec83a262d0357f67810e2a21733cdd8a1f79@gmail.com"},"message":"Wrap .env.example variable values in quotes\n\nWhen the developer copies .env.example to .env they are unlikely to\nadd quotes to the values in .env. When the developer needs to\nset the value of an environment variable to a value containing a\nspace, as none of the existing values in .env are quoted, the\ndeveloper is unlikely to wrap this new value with spaces in quotes.\nThis will result in an error, as The vlucas/phpdotenv library throws\nan error when setting an environment variable to a value with a space.\n\nQuote all default environment variables by default, reducing the\nlikelihood of the developer ever receiving the error relating to\nenvironment variables needing to be quoted when they contain spaces.\n\nThis excludes true, null etc. even though wrapping them in quotes\nwould still result in the desired behaviour, as it is more intuitive\nto see these special types not wrapped in quotes.\n\nThe current default values in .env.example don't contain any spaces,\nso this commit will make no difference out of the box; its only\npurpose is to help out the developer further down the line on the day\nwhen they need to set an environment variable to a value containing\nspaces.\n\nAlso, the vlucas/phpdotenv library docs currently uses quoted\nvariables in every example, so quoting .env.example's values will lead\nto more consistency with those docs. This will likely stop any\nconfusion for the developer when reading the vlucas/phpdotenv docs.\n\nSigned-off-by: crynobone <crynobone@gmail.com>","distinct":true,"url":"https://api.github.com/repos/orchestral/platform/commits/f8701d903a0e7a35314edc2f8502f16914ac9097"}]}
{"actor":{"display_login":"crynobone"}}