{"action":"created","comment":{"url":"https://api.github.com/repos/hyperhq/hyperd/pulls/comments/81055786","pull_request_review_id":2064085,"id":81055786,"diff_hunk":"@@ -290,6 +315,50 @@ func (cli *HyperClient) JsonFromCmdline(cmdArgs, cmdEnvs, cmdPortmaps []string,\n \treturn string(jsonString), nil\n }\n \n+func parseVolumes(volStr string) (*pod.UserVolumeReference, error) {\n+\n+\tvar (\n+\t\tvolRef   = pod.UserVolumeReference{}\n+\t\tsrcName  string\n+\t\tdestPath string\n+\t\treadOnly string\n+\t\tfilename string\n+\t)\n+\n+\tfields := strings.Split(volStr, \":\")\n+\tif len(fields) == 3 {\n+\t\t// cmd: -v host-src:container-dest:rw\n+\t\tsrcName = fields[0]\n+\t\tdestPath = fields[1]\n+\t\treadOnly = fields[2]","path":"client/run.go","position":117,"original_position":117,"commit_id":"a567a1717ca0cd9dc227429c4626259a5d794d0e","original_commit_id":"a567a1717ca0cd9dc227429c4626259a5d794d0e","user":{"login":"laijs","id":125671,"avatar_url":"https://avatars.githubusercontent.com/u/125671?v=3","gravatar_id":"","url":"https://api.github.com/users/laijs","html_url":"https://github.com/laijs","followers_url":"https://api.github.com/users/laijs/followers","following_url":"https://api.github.com/users/laijs/following{/other_user}","gists_url":"https://api.github.com/users/laijs/gists{/gist_id}","starred_url":"https://api.github.com/users/laijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laijs/subscriptions","organizations_url":"https://api.github.com/users/laijs/orgs","repos_url":"https://api.github.com/users/laijs/repos","events_url":"https://api.github.com/users/laijs/events{/privacy}","received_events_url":"https://api.github.com/users/laijs/received_events","type":"User","site_admin":false},"body":"please check the readOnly here.","created_at":"2016-09-29T02:36:36Z","updated_at":"2016-09-29T02:36:36Z","html_url":"https://github.com/hyperhq/hyperd/pull/429#discussion_r81055786","pull_request_url":"https://api.github.com/repos/hyperhq/hyperd/pulls/429","_links":{"self":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/comments/81055786"},"html":{"href":"https://github.com/hyperhq/hyperd/pull/429#discussion_r81055786"},"pull_request":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/429"}}},"pull_request":{"url":"https://api.github.com/repos/hyperhq/hyperd/pulls/429","id":86740234,"html_url":"https://github.com/hyperhq/hyperd/pull/429","diff_url":"https://github.com/hyperhq/hyperd/pull/429.diff","patch_url":"https://github.com/hyperhq/hyperd/pull/429.patch","issue_url":"https://api.github.com/repos/hyperhq/hyperd/issues/429","number":429,"state":"open","locked":false,"title":"add --volume support for hyperctl","user":{"login":"crook","id":120556,"avatar_url":"https://avatars.githubusercontent.com/u/120556?v=3","gravatar_id":"","url":"https://api.github.com/users/crook","html_url":"https://github.com/crook","followers_url":"https://api.github.com/users/crook/followers","following_url":"https://api.github.com/users/crook/following{/other_user}","gists_url":"https://api.github.com/users/crook/gists{/gist_id}","starred_url":"https://api.github.com/users/crook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crook/subscriptions","organizations_url":"https://api.github.com/users/crook/orgs","repos_url":"https://api.github.com/users/crook/repos","events_url":"https://api.github.com/users/crook/events{/privacy}","received_events_url":"https://api.github.com/users/crook/received_events","type":"User","site_admin":false},"body":"use bind mount to close #341 \r\n\r\nNow support: hyperctl run -v /host-src:/container-dest -t <images>\r\n\r\nTest log:\r\nhttp://pastebin.com/Wr1mZwEa","created_at":"2016-09-26T13:16:48Z","updated_at":"2016-09-29T02:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1585b39f10150b1825c1e19443f36123a3b5ee99","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperhq/hyperd/pulls/429/commits","review_comments_url":"https://api.github.com/repos/hyperhq/hyperd/pulls/429/comments","review_comment_url":"https://api.github.com/repos/hyperhq/hyperd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperhq/hyperd/issues/429/comments","statuses_url":"https://api.github.com/repos/hyperhq/hyperd/statuses/a567a1717ca0cd9dc227429c4626259a5d794d0e","head":{"label":"crook:master","ref":"master","sha":"a567a1717ca0cd9dc227429c4626259a5d794d0e","user":{"login":"crook","id":120556,"avatar_url":"https://avatars.githubusercontent.com/u/120556?v=3","gravatar_id":"","url":"https://api.github.com/users/crook","html_url":"https://github.com/crook","followers_url":"https://api.github.com/users/crook/followers","following_url":"https://api.github.com/users/crook/following{/other_user}","gists_url":"https://api.github.com/users/crook/gists{/gist_id}","starred_url":"https://api.github.com/users/crook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crook/subscriptions","organizations_url":"https://api.github.com/users/crook/orgs","repos_url":"https://api.github.com/users/crook/repos","events_url":"https://api.github.com/users/crook/events{/privacy}","received_events_url":"https://api.github.com/users/crook/received_events","type":"User","site_admin":false},"repo":{"id":69250849,"name":"hyperd","full_name":"crook/hyperd","owner":{"login":"crook","id":120556,"avatar_url":"https://avatars.githubusercontent.com/u/120556?v=3","gravatar_id":"","url":"https://api.github.com/users/crook","html_url":"https://github.com/crook","followers_url":"https://api.github.com/users/crook/followers","following_url":"https://api.github.com/users/crook/following{/other_user}","gists_url":"https://api.github.com/users/crook/gists{/gist_id}","starred_url":"https://api.github.com/users/crook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crook/subscriptions","organizations_url":"https://api.github.com/users/crook/orgs","repos_url":"https://api.github.com/users/crook/repos","events_url":"https://api.github.com/users/crook/events{/privacy}","received_events_url":"https://api.github.com/users/crook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crook/hyperd","description":"HyperContainer Daemon","fork":true,"url":"https://api.github.com/repos/crook/hyperd","forks_url":"https://api.github.com/repos/crook/hyperd/forks","keys_url":"https://api.github.com/repos/crook/hyperd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crook/hyperd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crook/hyperd/teams","hooks_url":"https://api.github.com/repos/crook/hyperd/hooks","issue_events_url":"https://api.github.com/repos/crook/hyperd/issues/events{/number}","events_url":"https://api.github.com/repos/crook/hyperd/events","assignees_url":"https://api.github.com/repos/crook/hyperd/assignees{/user}","branches_url":"https://api.github.com/repos/crook/hyperd/branches{/branch}","tags_url":"https://api.github.com/repos/crook/hyperd/tags","blobs_url":"https://api.github.com/repos/crook/hyperd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crook/hyperd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crook/hyperd/git/refs{/sha}","trees_url":"https://api.github.com/repos/crook/hyperd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crook/hyperd/statuses/{sha}","languages_url":"https://api.github.com/repos/crook/hyperd/languages","stargazers_url":"https://api.github.com/repos/crook/hyperd/stargazers","contributors_url":"https://api.github.com/repos/crook/hyperd/contributors","subscribers_url":"https://api.github.com/repos/crook/hyperd/subscribers","subscription_url":"https://api.github.com/repos/crook/hyperd/subscription","commits_url":"https://api.github.com/repos/crook/hyperd/commits{/sha}","git_commits_url":"https://api.github.com/repos/crook/hyperd/git/commits{/sha}","comments_url":"https://api.github.com/repos/crook/hyperd/comments{/number}","issue_comment_url":"https://api.github.com/repos/crook/hyperd/issues/comments{/number}","contents_url":"https://api.github.com/repos/crook/hyperd/contents/{+path}","compare_url":"https://api.github.com/repos/crook/hyperd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crook/hyperd/merges","archive_url":"https://api.github.com/repos/crook/hyperd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crook/hyperd/downloads","issues_url":"https://api.github.com/repos/crook/hyperd/issues{/number}","pulls_url":"https://api.github.com/repos/crook/hyperd/pulls{/number}","milestones_url":"https://api.github.com/repos/crook/hyperd/milestones{/number}","notifications_url":"https://api.github.com/repos/crook/hyperd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crook/hyperd/labels{/name}","releases_url":"https://api.github.com/repos/crook/hyperd/releases{/id}","deployments_url":"https://api.github.com/repos/crook/hyperd/deployments","created_at":"2016-09-26T13:06:38Z","updated_at":"2016-09-26T13:06:39Z","pushed_at":"2016-09-26T13:15:09Z","git_url":"git://github.com/crook/hyperd.git","ssh_url":"git@github.com:crook/hyperd.git","clone_url":"https://github.com/crook/hyperd.git","svn_url":"https://github.com/crook/hyperd","homepage":"http://www.hypercontainer.io","size":21329,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperhq:master","ref":"master","sha":"3ec146a03688e039145e7eb1d5b4d3b2fc4278a4","user":{"login":"hyperhq","id":12324138,"avatar_url":"https://avatars.githubusercontent.com/u/12324138?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperhq","html_url":"https://github.com/hyperhq","followers_url":"https://api.github.com/users/hyperhq/followers","following_url":"https://api.github.com/users/hyperhq/following{/other_user}","gists_url":"https://api.github.com/users/hyperhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperhq/subscriptions","organizations_url":"https://api.github.com/users/hyperhq/orgs","repos_url":"https://api.github.com/users/hyperhq/repos","events_url":"https://api.github.com/users/hyperhq/events{/privacy}","received_events_url":"https://api.github.com/users/hyperhq/received_events","type":"Organization","site_admin":false},"repo":{"id":36214040,"name":"hyperd","full_name":"hyperhq/hyperd","owner":{"login":"hyperhq","id":12324138,"avatar_url":"https://avatars.githubusercontent.com/u/12324138?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperhq","html_url":"https://github.com/hyperhq","followers_url":"https://api.github.com/users/hyperhq/followers","following_url":"https://api.github.com/users/hyperhq/following{/other_user}","gists_url":"https://api.github.com/users/hyperhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperhq/subscriptions","organizations_url":"https://api.github.com/users/hyperhq/orgs","repos_url":"https://api.github.com/users/hyperhq/repos","events_url":"https://api.github.com/users/hyperhq/events{/privacy}","received_events_url":"https://api.github.com/users/hyperhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperhq/hyperd","description":"HyperContainer Daemon","fork":false,"url":"https://api.github.com/repos/hyperhq/hyperd","forks_url":"https://api.github.com/repos/hyperhq/hyperd/forks","keys_url":"https://api.github.com/repos/hyperhq/hyperd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperhq/hyperd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperhq/hyperd/teams","hooks_url":"https://api.github.com/repos/hyperhq/hyperd/hooks","issue_events_url":"https://api.github.com/repos/hyperhq/hyperd/issues/events{/number}","events_url":"https://api.github.com/repos/hyperhq/hyperd/events","assignees_url":"https://api.github.com/repos/hyperhq/hyperd/assignees{/user}","branches_url":"https://api.github.com/repos/hyperhq/hyperd/branches{/branch}","tags_url":"https://api.github.com/repos/hyperhq/hyperd/tags","blobs_url":"https://api.github.com/repos/hyperhq/hyperd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperhq/hyperd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperhq/hyperd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperhq/hyperd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperhq/hyperd/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperhq/hyperd/languages","stargazers_url":"https://api.github.com/repos/hyperhq/hyperd/stargazers","contributors_url":"https://api.github.com/repos/hyperhq/hyperd/contributors","subscribers_url":"https://api.github.com/repos/hyperhq/hyperd/subscribers","subscription_url":"https://api.github.com/repos/hyperhq/hyperd/subscription","commits_url":"https://api.github.com/repos/hyperhq/hyperd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperhq/hyperd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperhq/hyperd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperhq/hyperd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperhq/hyperd/contents/{+path}","compare_url":"https://api.github.com/repos/hyperhq/hyperd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperhq/hyperd/merges","archive_url":"https://api.github.com/repos/hyperhq/hyperd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperhq/hyperd/downloads","issues_url":"https://api.github.com/repos/hyperhq/hyperd/issues{/number}","pulls_url":"https://api.github.com/repos/hyperhq/hyperd/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperhq/hyperd/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperhq/hyperd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperhq/hyperd/labels{/name}","releases_url":"https://api.github.com/repos/hyperhq/hyperd/releases{/id}","deployments_url":"https://api.github.com/repos/hyperhq/hyperd/deployments","created_at":"2015-05-25T06:26:27Z","updated_at":"2016-09-27T02:37:14Z","pushed_at":"2016-09-27T02:01:55Z","git_url":"git://github.com/hyperhq/hyperd.git","ssh_url":"git@github.com:hyperhq/hyperd.git","clone_url":"https://github.com/hyperhq/hyperd.git","svn_url":"https://github.com/hyperhq/hyperd","homepage":"http://www.hypercontainer.io","size":22148,"stargazers_count":1115,"watchers_count":1115,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":66,"forks":105,"open_issues":66,"watchers":1115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/429"},"html":{"href":"https://github.com/hyperhq/hyperd/pull/429"},"issue":{"href":"https://api.github.com/repos/hyperhq/hyperd/issues/429"},"comments":{"href":"https://api.github.com/repos/hyperhq/hyperd/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperhq/hyperd/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/hyperhq/hyperd/statuses/a567a1717ca0cd9dc227429c4626259a5d794d0e"}}}}
{"actor":{"display_login":"laijs"}}