{"action":"created","comment":{"url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/comments/94045681","pull_request_review_id":14575734,"id":94045681,"diff_hunk":"@@ -80,37 +138,52 @@ function arrayContainsElement(arr, val) {\n \n function checkCareerFilter(userInfo, filter) {","path":"src/server/controllers/match.controller.js","position":128,"original_position":128,"commit_id":"14153cc854f58bddbde853457e909ba131e4ef23","original_commit_id":"14153cc854f58bddbde853457e909ba131e4ef23","user":{"login":"ethkim","id":1045658,"avatar_url":"https://avatars.githubusercontent.com/u/1045658?v=3","gravatar_id":"","url":"https://api.github.com/users/ethkim","html_url":"https://github.com/ethkim","followers_url":"https://api.github.com/users/ethkim/followers","following_url":"https://api.github.com/users/ethkim/following{/other_user}","gists_url":"https://api.github.com/users/ethkim/gists{/gist_id}","starred_url":"https://api.github.com/users/ethkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethkim/subscriptions","organizations_url":"https://api.github.com/users/ethkim/orgs","repos_url":"https://api.github.com/users/ethkim/repos","events_url":"https://api.github.com/users/ethkim/events{/privacy}","received_events_url":"https://api.github.com/users/ethkim/received_events","type":"User","site_admin":false},"body":"What does this function do? \"check\" doesn't tell me what it does - it seems like it's just checking for preconditions for the filter object, but not sure why these are required. Either change the method name or comment on what this function does?","created_at":"2016-12-28T15:41:35Z","updated_at":"2016-12-28T15:52:57Z","html_url":"https://github.com/sv-bootcamp/bridgeme-server/pull/112#discussion_r94045681","pull_request_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/comments/94045681"},"html":{"href":"https://github.com/sv-bootcamp/bridgeme-server/pull/112#discussion_r94045681"},"pull_request":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112","id":99537196,"html_url":"https://github.com/sv-bootcamp/bridgeme-server/pull/112","diff_url":"https://github.com/sv-bootcamp/bridgeme-server/pull/112.diff","patch_url":"https://github.com/sv-bootcamp/bridgeme-server/pull/112.patch","issue_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/112","number":112,"state":"open","locked":false,"title":"Enhancing Filter Functions","user":{"login":"KyuaKwon","id":13380303,"avatar_url":"https://avatars.githubusercontent.com/u/13380303?v=3","gravatar_id":"","url":"https://api.github.com/users/KyuaKwon","html_url":"https://github.com/KyuaKwon","followers_url":"https://api.github.com/users/KyuaKwon/followers","following_url":"https://api.github.com/users/KyuaKwon/following{/other_user}","gists_url":"https://api.github.com/users/KyuaKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/KyuaKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyuaKwon/subscriptions","organizations_url":"https://api.github.com/users/KyuaKwon/orgs","repos_url":"https://api.github.com/users/KyuaKwon/repos","events_url":"https://api.github.com/users/KyuaKwon/events{/privacy}","received_events_url":"https://api.github.com/users/KyuaKwon/received_events","type":"User","site_admin":false},"body":"- I shorten the getMentorList function and applied a Promise process.\r\n- User.model is edited. Career is no more an array.\r\n\r\nI will enhance over and over. Counting function also.\r\nThen I'll do the DB jobs.\r\n\r\n( If this PR is merged, the DB should be cleared )","created_at":"2016-12-28T11:12:51Z","updated_at":"2016-12-28T15:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2408a70a65cc4561054ecfb1cda2b0e9830cdd73","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112/commits","review_comments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112/comments","review_comment_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/112/comments","statuses_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/statuses/14153cc854f58bddbde853457e909ba131e4ef23","head":{"label":"sv-bootcamp:filter","ref":"filter","sha":"14153cc854f58bddbde853457e909ba131e4ef23","user":{"login":"sv-bootcamp","id":20648483,"avatar_url":"https://avatars.githubusercontent.com/u/20648483?v=3","gravatar_id":"","url":"https://api.github.com/users/sv-bootcamp","html_url":"https://github.com/sv-bootcamp","followers_url":"https://api.github.com/users/sv-bootcamp/followers","following_url":"https://api.github.com/users/sv-bootcamp/following{/other_user}","gists_url":"https://api.github.com/users/sv-bootcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/sv-bootcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv-bootcamp/subscriptions","organizations_url":"https://api.github.com/users/sv-bootcamp/orgs","repos_url":"https://api.github.com/users/sv-bootcamp/repos","events_url":"https://api.github.com/users/sv-bootcamp/events{/privacy}","received_events_url":"https://api.github.com/users/sv-bootcamp/received_events","type":"Organization","site_admin":false},"repo":{"id":65598569,"name":"bridgeme-server","full_name":"sv-bootcamp/bridgeme-server","owner":{"login":"sv-bootcamp","id":20648483,"avatar_url":"https://avatars.githubusercontent.com/u/20648483?v=3","gravatar_id":"","url":"https://api.github.com/users/sv-bootcamp","html_url":"https://github.com/sv-bootcamp","followers_url":"https://api.github.com/users/sv-bootcamp/followers","following_url":"https://api.github.com/users/sv-bootcamp/following{/other_user}","gists_url":"https://api.github.com/users/sv-bootcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/sv-bootcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv-bootcamp/subscriptions","organizations_url":"https://api.github.com/users/sv-bootcamp/orgs","repos_url":"https://api.github.com/users/sv-bootcamp/repos","events_url":"https://api.github.com/users/sv-bootcamp/events{/privacy}","received_events_url":"https://api.github.com/users/sv-bootcamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sv-bootcamp/bridgeme-server","description":"Codename Yoda. Mentoring.","fork":false,"url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server","forks_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/forks","keys_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/teams","hooks_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/hooks","issue_events_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/events{/number}","events_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/events","assignees_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/assignees{/user}","branches_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/branches{/branch}","tags_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/tags","blobs_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/statuses/{sha}","languages_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/languages","stargazers_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/stargazers","contributors_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/contributors","subscribers_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/subscribers","subscription_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/subscription","commits_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/contents/{+path}","compare_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/merges","archive_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/downloads","issues_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues{/number}","pulls_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls{/number}","milestones_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/milestones{/number}","notifications_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/labels{/name}","releases_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/releases{/id}","deployments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/deployments","created_at":"2016-08-13T04:09:04Z","updated_at":"2016-12-08T02:36:19Z","pushed_at":"2016-12-28T11:12:52Z","git_url":"git://github.com/sv-bootcamp/bridgeme-server.git","ssh_url":"git@github.com:sv-bootcamp/bridgeme-server.git","clone_url":"https://github.com/sv-bootcamp/bridgeme-server.git","svn_url":"https://github.com/sv-bootcamp/bridgeme-server","homepage":null,"size":23722,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"sv-bootcamp:master","ref":"master","sha":"60f6a1eb90c37f47ee4fdddb427e4470fdba820d","user":{"login":"sv-bootcamp","id":20648483,"avatar_url":"https://avatars.githubusercontent.com/u/20648483?v=3","gravatar_id":"","url":"https://api.github.com/users/sv-bootcamp","html_url":"https://github.com/sv-bootcamp","followers_url":"https://api.github.com/users/sv-bootcamp/followers","following_url":"https://api.github.com/users/sv-bootcamp/following{/other_user}","gists_url":"https://api.github.com/users/sv-bootcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/sv-bootcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv-bootcamp/subscriptions","organizations_url":"https://api.github.com/users/sv-bootcamp/orgs","repos_url":"https://api.github.com/users/sv-bootcamp/repos","events_url":"https://api.github.com/users/sv-bootcamp/events{/privacy}","received_events_url":"https://api.github.com/users/sv-bootcamp/received_events","type":"Organization","site_admin":false},"repo":{"id":65598569,"name":"bridgeme-server","full_name":"sv-bootcamp/bridgeme-server","owner":{"login":"sv-bootcamp","id":20648483,"avatar_url":"https://avatars.githubusercontent.com/u/20648483?v=3","gravatar_id":"","url":"https://api.github.com/users/sv-bootcamp","html_url":"https://github.com/sv-bootcamp","followers_url":"https://api.github.com/users/sv-bootcamp/followers","following_url":"https://api.github.com/users/sv-bootcamp/following{/other_user}","gists_url":"https://api.github.com/users/sv-bootcamp/gists{/gist_id}","starred_url":"https://api.github.com/users/sv-bootcamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv-bootcamp/subscriptions","organizations_url":"https://api.github.com/users/sv-bootcamp/orgs","repos_url":"https://api.github.com/users/sv-bootcamp/repos","events_url":"https://api.github.com/users/sv-bootcamp/events{/privacy}","received_events_url":"https://api.github.com/users/sv-bootcamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sv-bootcamp/bridgeme-server","description":"Codename Yoda. Mentoring.","fork":false,"url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server","forks_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/forks","keys_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/teams","hooks_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/hooks","issue_events_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/events{/number}","events_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/events","assignees_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/assignees{/user}","branches_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/branches{/branch}","tags_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/tags","blobs_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/statuses/{sha}","languages_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/languages","stargazers_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/stargazers","contributors_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/contributors","subscribers_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/subscribers","subscription_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/subscription","commits_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/contents/{+path}","compare_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/merges","archive_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/downloads","issues_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues{/number}","pulls_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls{/number}","milestones_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/milestones{/number}","notifications_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/labels{/name}","releases_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/releases{/id}","deployments_url":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/deployments","created_at":"2016-08-13T04:09:04Z","updated_at":"2016-12-08T02:36:19Z","pushed_at":"2016-12-28T11:12:52Z","git_url":"git://github.com/sv-bootcamp/bridgeme-server.git","ssh_url":"git@github.com:sv-bootcamp/bridgeme-server.git","clone_url":"https://github.com/sv-bootcamp/bridgeme-server.git","svn_url":"https://github.com/sv-bootcamp/bridgeme-server","homepage":null,"size":23722,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112"},"html":{"href":"https://github.com/sv-bootcamp/bridgeme-server/pull/112"},"issue":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/112"},"comments":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/sv-bootcamp/bridgeme-server/statuses/14153cc854f58bddbde853457e909ba131e4ef23"}}}}
{"actor":{"display_login":"ethkim"}}