{"action":"created","comment":{"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/comments/71193617","id":71193617,"diff_hunk":"@@ -53,19 +53,13 @@ extension SignupControllerDelegate {\n         app.networkActivityIndicatorVisible = false\n     }\n     \n-    public func signupController(controller: SignupController, didSignUpWithError error: SessionServiceError) {\n-        controller.signupView.usernameTextFieldValid = false\n-        controller.signupView.emailTextFieldValid = false\n-        controller.signupView.passwordTextFieldValid = false\n-        controller.signupView.passwordConfirmationTextFieldValid = false\n-        controller.signupView.signupButtonPressed = false\n-        \n-        if let errorLabel = controller.signupView.signupErrorLabel {\n+    public func signupController(controller: SignupController, didSignUpWithError error: SessionServiceError) {        \n+        if let errorLabel = controller.signupView.signUpErrorLabel {\n             errorLabel.text = error.message\n         }\n         if shouldDisplaySignupErrorWithAlert {","path":"Authentication/SignUp/View/SignupControllerDelegate.swift","position":null,"original_position":25,"commit_id":"4eaa8132fa56c55405154540e35d3fee8563542f","original_commit_id":"3d953ae0f3f5a9b180310c08365956775d1f6635","user":{"login":"guidomb","id":390645,"avatar_url":"https://avatars.githubusercontent.com/u/390645?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomb","html_url":"https://github.com/guidomb","followers_url":"https://api.github.com/users/guidomb/followers","following_url":"https://api.github.com/users/guidomb/following{/other_user}","gists_url":"https://api.github.com/users/guidomb/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomb/subscriptions","organizations_url":"https://api.github.com/users/guidomb/orgs","repos_url":"https://api.github.com/users/guidomb/repos","events_url":"https://api.github.com/users/guidomb/events{/privacy}","received_events_url":"https://api.github.com/users/guidomb/received_events","type":"User","site_admin":false},"body":"I agree with @danielaRiesgo in this one.","created_at":"2016-07-18T17:43:22Z","updated_at":"2016-07-18T17:43:22Z","html_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/10#discussion_r71193617","pull_request_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/comments/71193617"},"html":{"href":"https://github.com/Wolox/wolmo-authentication-ios/pull/10#discussion_r71193617"},"pull_request":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10","id":77685404,"html_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/10","diff_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/10.diff","patch_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/10.patch","issue_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/10","number":10,"state":"open","locked":false,"title":"Register view frontend","user":{"login":"danielaRiesgo","id":12351004,"avatar_url":"https://avatars.githubusercontent.com/u/12351004?v=3","gravatar_id":"","url":"https://api.github.com/users/danielaRiesgo","html_url":"https://github.com/danielaRiesgo","followers_url":"https://api.github.com/users/danielaRiesgo/followers","following_url":"https://api.github.com/users/danielaRiesgo/following{/other_user}","gists_url":"https://api.github.com/users/danielaRiesgo/gists{/gist_id}","starred_url":"https://api.github.com/users/danielaRiesgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielaRiesgo/subscriptions","organizations_url":"https://api.github.com/users/danielaRiesgo/orgs","repos_url":"https://api.github.com/users/danielaRiesgo/repos","events_url":"https://api.github.com/users/danielaRiesgo/events{/privacy}","received_events_url":"https://api.github.com/users/danielaRiesgo/received_events","type":"User","site_admin":false},"body":"## Sumary ##\r\n**Trello card**: https://trello.com/c/BuvnKgwk/3-vista-sign-up\r\n\r\nAdding the sign up default view with all visual \"effects\".\r\nAdding what necessary to controller for transitions and binding with view objects that were missing.\r\n\r\n## Test Plan ##\r\n\r\n  * Open the app\r\n  * Try to login: \r\n       It will only succeed if using email \"example@mail.com\" and password \"password\". And take you to a blank view.\r\n  * Press Signup button to go to signup.\r\n  * Try to signup:\r\n       It will only succeed if using email \"example@mail.com\" and password \"password\". And take you to a blank view.\r\n  * Press Login button to go to login.\r\n\r\n## Screencast ##\r\n\r\n### Updated Login and Signup\r\nVersion 2: with stack views\r\n![signup view and login v2](https://cloud.githubusercontent.com/assets/12351004/16924340/242f2918-4cf5-11e6-82f3-d7b0036b2204.gif)\r\n\r\n\r\n## Known issues ##\r\nTerms and Services pending for another PR.\r\nMissing tests.\r\n","created_at":"2016-07-15T22:08:16Z","updated_at":"2016-07-18T17:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbffeafde3c61bbd5fd53a8527e5daaa05901f4","assignee":{"login":"guidomb","id":390645,"avatar_url":"https://avatars.githubusercontent.com/u/390645?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomb","html_url":"https://github.com/guidomb","followers_url":"https://api.github.com/users/guidomb/followers","following_url":"https://api.github.com/users/guidomb/following{/other_user}","gists_url":"https://api.github.com/users/guidomb/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomb/subscriptions","organizations_url":"https://api.github.com/users/guidomb/orgs","repos_url":"https://api.github.com/users/guidomb/repos","events_url":"https://api.github.com/users/guidomb/events{/privacy}","received_events_url":"https://api.github.com/users/guidomb/received_events","type":"User","site_admin":false},"assignees":[{"login":"guidomb","id":390645,"avatar_url":"https://avatars.githubusercontent.com/u/390645?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomb","html_url":"https://github.com/guidomb","followers_url":"https://api.github.com/users/guidomb/followers","following_url":"https://api.github.com/users/guidomb/following{/other_user}","gists_url":"https://api.github.com/users/guidomb/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomb/subscriptions","organizations_url":"https://api.github.com/users/guidomb/orgs","repos_url":"https://api.github.com/users/guidomb/repos","events_url":"https://api.github.com/users/guidomb/events{/privacy}","received_events_url":"https://api.github.com/users/guidomb/received_events","type":"User","site_admin":false},{"login":"FranDepascuali","id":12101394,"avatar_url":"https://avatars.githubusercontent.com/u/12101394?v=3","gravatar_id":"","url":"https://api.github.com/users/FranDepascuali","html_url":"https://github.com/FranDepascuali","followers_url":"https://api.github.com/users/FranDepascuali/followers","following_url":"https://api.github.com/users/FranDepascuali/following{/other_user}","gists_url":"https://api.github.com/users/FranDepascuali/gists{/gist_id}","starred_url":"https://api.github.com/users/FranDepascuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FranDepascuali/subscriptions","organizations_url":"https://api.github.com/users/FranDepascuali/orgs","repos_url":"https://api.github.com/users/FranDepascuali/repos","events_url":"https://api.github.com/users/FranDepascuali/events{/privacy}","received_events_url":"https://api.github.com/users/FranDepascuali/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/10/comments","statuses_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/statuses/4eaa8132fa56c55405154540e35d3fee8563542f","head":{"label":"Wolox:register-view-frontend","ref":"register-view-frontend","sha":"4eaa8132fa56c55405154540e35d3fee8563542f","user":{"login":"Wolox","id":1046241,"avatar_url":"https://avatars.githubusercontent.com/u/1046241?v=3","gravatar_id":"","url":"https://api.github.com/users/Wolox","html_url":"https://github.com/Wolox","followers_url":"https://api.github.com/users/Wolox/followers","following_url":"https://api.github.com/users/Wolox/following{/other_user}","gists_url":"https://api.github.com/users/Wolox/gists{/gist_id}","starred_url":"https://api.github.com/users/Wolox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wolox/subscriptions","organizations_url":"https://api.github.com/users/Wolox/orgs","repos_url":"https://api.github.com/users/Wolox/repos","events_url":"https://api.github.com/users/Wolox/events{/privacy}","received_events_url":"https://api.github.com/users/Wolox/received_events","type":"Organization","site_admin":false},"repo":{"id":53330743,"name":"wolmo-authentication-ios","full_name":"Wolox/wolmo-authentication-ios","owner":{"login":"Wolox","id":1046241,"avatar_url":"https://avatars.githubusercontent.com/u/1046241?v=3","gravatar_id":"","url":"https://api.github.com/users/Wolox","html_url":"https://github.com/Wolox","followers_url":"https://api.github.com/users/Wolox/followers","following_url":"https://api.github.com/users/Wolox/following{/other_user}","gists_url":"https://api.github.com/users/Wolox/gists{/gist_id}","starred_url":"https://api.github.com/users/Wolox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wolox/subscriptions","organizations_url":"https://api.github.com/users/Wolox/orgs","repos_url":"https://api.github.com/users/Wolox/repos","events_url":"https://api.github.com/users/Wolox/events{/privacy}","received_events_url":"https://api.github.com/users/Wolox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wolox/wolmo-authentication-ios","description":"Wolmo - Wolox Mobile SDK Authentication library for iOS","fork":false,"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios","forks_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/forks","keys_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/teams","hooks_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/hooks","issue_events_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/events","assignees_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/tags","blobs_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/languages","stargazers_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/stargazers","contributors_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/contributors","subscribers_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/subscribers","subscription_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/subscription","commits_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/merges","archive_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/downloads","issues_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/labels{/name}","releases_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/deployments","created_at":"2016-03-07T14:16:10Z","updated_at":"2016-03-18T14:49:58Z","pushed_at":"2016-07-18T17:33:55Z","git_url":"git://github.com/Wolox/wolmo-authentication-ios.git","ssh_url":"git@github.com:Wolox/wolmo-authentication-ios.git","clone_url":"https://github.com/Wolox/wolmo-authentication-ios.git","svn_url":"https://github.com/Wolox/wolmo-authentication-ios","homepage":null,"size":329,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Wolox:master","ref":"master","sha":"9a9f3afcd9b9593e193d07adb28e56eb7a0a6b9c","user":{"login":"Wolox","id":1046241,"avatar_url":"https://avatars.githubusercontent.com/u/1046241?v=3","gravatar_id":"","url":"https://api.github.com/users/Wolox","html_url":"https://github.com/Wolox","followers_url":"https://api.github.com/users/Wolox/followers","following_url":"https://api.github.com/users/Wolox/following{/other_user}","gists_url":"https://api.github.com/users/Wolox/gists{/gist_id}","starred_url":"https://api.github.com/users/Wolox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wolox/subscriptions","organizations_url":"https://api.github.com/users/Wolox/orgs","repos_url":"https://api.github.com/users/Wolox/repos","events_url":"https://api.github.com/users/Wolox/events{/privacy}","received_events_url":"https://api.github.com/users/Wolox/received_events","type":"Organization","site_admin":false},"repo":{"id":53330743,"name":"wolmo-authentication-ios","full_name":"Wolox/wolmo-authentication-ios","owner":{"login":"Wolox","id":1046241,"avatar_url":"https://avatars.githubusercontent.com/u/1046241?v=3","gravatar_id":"","url":"https://api.github.com/users/Wolox","html_url":"https://github.com/Wolox","followers_url":"https://api.github.com/users/Wolox/followers","following_url":"https://api.github.com/users/Wolox/following{/other_user}","gists_url":"https://api.github.com/users/Wolox/gists{/gist_id}","starred_url":"https://api.github.com/users/Wolox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wolox/subscriptions","organizations_url":"https://api.github.com/users/Wolox/orgs","repos_url":"https://api.github.com/users/Wolox/repos","events_url":"https://api.github.com/users/Wolox/events{/privacy}","received_events_url":"https://api.github.com/users/Wolox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wolox/wolmo-authentication-ios","description":"Wolmo - Wolox Mobile SDK Authentication library for iOS","fork":false,"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios","forks_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/forks","keys_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/teams","hooks_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/hooks","issue_events_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/events","assignees_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/tags","blobs_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/languages","stargazers_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/stargazers","contributors_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/contributors","subscribers_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/subscribers","subscription_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/subscription","commits_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/merges","archive_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/downloads","issues_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/labels{/name}","releases_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/deployments","created_at":"2016-03-07T14:16:10Z","updated_at":"2016-03-18T14:49:58Z","pushed_at":"2016-07-18T17:33:55Z","git_url":"git://github.com/Wolox/wolmo-authentication-ios.git","ssh_url":"git@github.com:Wolox/wolmo-authentication-ios.git","clone_url":"https://github.com/Wolox/wolmo-authentication-ios.git","svn_url":"https://github.com/Wolox/wolmo-authentication-ios","homepage":null,"size":329,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10"},"html":{"href":"https://github.com/Wolox/wolmo-authentication-ios/pull/10"},"issue":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/10"},"comments":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/statuses/4eaa8132fa56c55405154540e35d3fee8563542f"}}}}
{"actor":{"display_login":"guidomb"}}