{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/4378","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/4378/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4378/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/4378/events","html_url":"https://github.com/systemd/systemd/pull/4378","id":183187798,"number":4378,"title":"tests: add smoke test for systemd-nspawn","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemd/systemd/labels/nspawn","name":"nspawn","color":"bfdadc"},{"url":"https://api.github.com/repos/systemd/systemd/labels/tests","name":"tests","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-15T04:19:05Z","updated_at":"2016-10-17T00:15:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4378","html_url":"https://github.com/systemd/systemd/pull/4378","diff_url":"https://github.com/systemd/systemd/pull/4378.diff","patch_url":"https://github.com/systemd/systemd/pull/4378.patch"},"body":"Basically, this test runs:\r\n```\r\n    systemd-nspawn --register=no -D \"$_root\" -b\r\n    systemd-nspawn --register=no -D \"$_root\" --private-network -b\r\n    systemd-nspawn --register=no -D \"$_root\" -U -b\r\n    systemd-nspawn --register=no -D \"$_root\" --private-network -U -b\r\n```\r\nand exports the `UNIFIED_CGROUP_HIERARCHY=[yes|no]`, `SYSTEMD_NSPAWN_USE_CGNS=[yes|no]`\r\n\r\nInspired by\r\n* https://github.com/systemd/systemd/pull/3589#r68821097\r\n* https://github.com/systemd/systemd/pull/4372#issuecomment-253711563\r\n* https://github.com/systemd/systemd/pull/4223#issuecomment-252522955\r\n* https://github.com/systemd/systemd/issues/1555\r\n\r\nand so on :-)\r\n\r\n\r\n@martinpitt , this test\r\n* should pass on Xenial-testbeds\r\n* should fail on Yaketty-testbeds (`UNIFIED_CGROUP_HIERARCHY=no SYSTEMD_NSPAWN_USE_CGNS=yes systemd-nspawn --register=no -D /var/lib/machines/unified-no-cgns-yes -U -b`)"},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/254087353","html_url":"https://github.com/systemd/systemd/pull/4378#issuecomment-254087353","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4378","id":254087353,"user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T00:15:19Z","updated_at":"2016-10-17T00:15:19Z","body":"In my testing of your original patch, not all logs ended up in the journal. At some point the output from the script was cut off. Maybe it's a bug, but it's not central to the problem at hand.\r\n\r\nOK, so you don't like my changes. Can you repush with just my documentation patch, and incorporate the missing return fix into your patch?"}}
{"actor":{"display_login":"keszybz"}}