{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/73962053","id":73962053,"diff_hunk":"@@ -57,6 +58,22 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> {\n                     self.trans_rvalue(bcx, tr_dest, rvalue, debug_loc)\n                 }\n             }\n+            mir::StatementKind::StorageLive(ref lvalue) => {\n+                if let Some(index) = self.mir.local_index(lvalue) {\n+                    if let LocalRef::Lvalue(tr_lval) = self.locals[index] {\n+                        base::Lifetime::Start.call(&bcx, tr_lval.llval);\n+                    }\n+                }\n+                bcx\n+            }\n+            mir::StatementKind::StorageDead(ref lvalue) => {\n+                if let Some(index) = self.mir.local_index(lvalue) {\n+                    if let LocalRef::Lvalue(tr_lval) = self.locals[index] {\n+                        base::Lifetime::End.call(&bcx, tr_lval.llval);\n+                    }\n+                }\n+                bcx\n+            }","path":"src/librustc_trans/mir/statement.rs","position":27,"original_position":27,"commit_id":"19955cf19cee733cfb67a1dcb2c7509b89520fb9","original_commit_id":"19955cf19cee733cfb67a1dcb2c7509b89520fb9","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"We need to do nothing if the local is not an `Lvalue`.\r\nUsing a method taking `lvalue` and the `base::Lifetime` would work, yeah.","created_at":"2016-08-08T21:49:25Z","updated_at":"2016-08-08T21:49:26Z","html_url":"https://github.com/rust-lang/rust/pull/35409#discussion_r73962053","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/35409","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/73962053"},"html":{"href":"https://github.com/rust-lang/rust/pull/35409#discussion_r73962053"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35409"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/35409","id":80327903,"html_url":"https://github.com/rust-lang/rust/pull/35409","diff_url":"https://github.com/rust-lang/rust/pull/35409.diff","patch_url":"https://github.com/rust-lang/rust/pull/35409.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/35409","number":35409,"state":"open","locked":false,"title":"[MIR] Add Storage{Live,Dead} statements to emit llvm.lifetime.{start,end}.","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Storage live ranges are tracked for all MIR variables and temporaries with a drop scope.\r\n`StorageLive` is lowered to `llvm.lifetime.start` and `StorageDead` to `llvm.lifetime.end`.\r\n\r\nThere are some improvements possible here, such as:\r\n* pack multiple storage liveness statements by using the index of first local + `u64` bitset\r\n* enforce that locals are not directly accessed outside their storage live range\r\n* shrink storage live ranges for never-borrowed locals to initialization -> last use\r\n* emit storage liveness statements for *all* temporaries\r\n * however, the remaining ones are *always* SSA immediates, so they'd be noop in MIR trans\r\n * could have a flag on the temporary that its storage is irrelevant (a la C's old `register`)\r\n   * would also deny borrows if necessary\r\n    * this seems like an overcompliation and with packing & optimizations it may be pointless\r\n\r\nEven in the current state, it helps stage2 `rustc` compile `boiler` without overflowing (see #35408).","created_at":"2016-08-06T02:16:18Z","updated_at":"2016-08-08T21:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"555d845c39e9b4741ee659ad5e1239d3c5467c6f","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/35409/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/35409/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/35409/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/19955cf19cee733cfb67a1dcb2c7509b89520fb9","head":{"label":"eddyb:mir-storage-stmts","ref":"mir-storage-stmts","sha":"19955cf19cee733cfb67a1dcb2c7509b89520fb9","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"repo":{"id":13473977,"name":"rust","full_name":"eddyb/rust","owner":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddyb/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/eddyb/rust","forks_url":"https://api.github.com/repos/eddyb/rust/forks","keys_url":"https://api.github.com/repos/eddyb/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddyb/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddyb/rust/teams","hooks_url":"https://api.github.com/repos/eddyb/rust/hooks","issue_events_url":"https://api.github.com/repos/eddyb/rust/issues/events{/number}","events_url":"https://api.github.com/repos/eddyb/rust/events","assignees_url":"https://api.github.com/repos/eddyb/rust/assignees{/user}","branches_url":"https://api.github.com/repos/eddyb/rust/branches{/branch}","tags_url":"https://api.github.com/repos/eddyb/rust/tags","blobs_url":"https://api.github.com/repos/eddyb/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddyb/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddyb/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddyb/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddyb/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/eddyb/rust/languages","stargazers_url":"https://api.github.com/repos/eddyb/rust/stargazers","contributors_url":"https://api.github.com/repos/eddyb/rust/contributors","subscribers_url":"https://api.github.com/repos/eddyb/rust/subscribers","subscription_url":"https://api.github.com/repos/eddyb/rust/subscription","commits_url":"https://api.github.com/repos/eddyb/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddyb/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddyb/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddyb/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddyb/rust/contents/{+path}","compare_url":"https://api.github.com/repos/eddyb/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddyb/rust/merges","archive_url":"https://api.github.com/repos/eddyb/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddyb/rust/downloads","issues_url":"https://api.github.com/repos/eddyb/rust/issues{/number}","pulls_url":"https://api.github.com/repos/eddyb/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/eddyb/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/eddyb/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddyb/rust/labels{/name}","releases_url":"https://api.github.com/repos/eddyb/rust/releases{/id}","deployments_url":"https://api.github.com/repos/eddyb/rust/deployments","created_at":"2013-10-10T14:40:52Z","updated_at":"2015-06-10T12:47:08Z","pushed_at":"2016-08-06T21:50:37Z","git_url":"git://github.com/eddyb/rust.git","ssh_url":"git@github.com:eddyb/rust.git","clone_url":"https://github.com/eddyb/rust.git","svn_url":"https://github.com/eddyb/rust","homepage":"http://www.rust-lang.org","size":295808,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b30eff7ba72a78e31acd61a2b6931919a0ad62e8","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-08-08T21:45:56Z","pushed_at":"2016-08-08T21:42:37Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":516039,"stargazers_count":17828,"watchers_count":17828,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3439,"mirror_url":null,"open_issues_count":2736,"forks":3439,"open_issues":2736,"watchers":17828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35409"},"html":{"href":"https://github.com/rust-lang/rust/pull/35409"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/35409"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/35409/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35409/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35409/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/19955cf19cee733cfb67a1dcb2c7509b89520fb9"}}}}
{"actor":{"display_login":"eddyb"}}