{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/92666209","pull_request_review_id":13186228,"id":92666209,"diff_hunk":"@@ -370,7 +370,10 @@ func (c *Cluster) delete() {\n \t\t}\n \t}\n \tif c.spec.Backup != nil {","path":"pkg/cluster/cluster.go","position":49,"original_position":49,"commit_id":"df793998702f2ffd54f7711ee8e1ade859e00c29","original_commit_id":"77829eb5ed6dac59d1efd4330223887720b19356","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"Missed it.\r\nLet me submit a fix shortly","created_at":"2016-12-15T18:10:08Z","updated_at":"2016-12-15T18:10:08Z","html_url":"https://github.com/coreos/etcd-operator/pull/460#discussion_r92666209","pull_request_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/92666209"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/460#discussion_r92666209"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/460","id":98098416,"html_url":"https://github.com/coreos/etcd-operator/pull/460","diff_url":"https://github.com/coreos/etcd-operator/pull/460.diff","patch_url":"https://github.com/coreos/etcd-operator/pull/460.patch","issue_url":"https://api.github.com/repos/coreos/etcd-operator/issues/460","number":460,"state":"closed","locked":false,"title":"backup: fix CleanupBackups path","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"We need to handle S3 case as well.\nDecided to add a method in backup manager and also make backupmanager a\nfield in cluster.","created_at":"2016-12-15T07:16:51Z","updated_at":"2016-12-15T18:10:08Z","closed_at":"2016-12-15T18:07:58Z","merged_at":"2016-12-15T18:07:58Z","merge_commit_sha":"76d484a1821634be539ad6325b9674fd346d6c4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/460/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/460/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/issues/460/comments","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/df793998702f2ffd54f7711ee8e1ade859e00c29","head":{"label":"hongchaodeng:b","ref":"b","sha":"df793998702f2ffd54f7711ee8e1ade859e00c29","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"repo":{"id":72786503,"name":"etcd-operator","full_name":"hongchaodeng/etcd-operator","owner":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hongchaodeng/etcd-operator","description":"etcd Operator creates/configures/manages etcd clusters atop Kubernetes","fork":true,"url":"https://api.github.com/repos/hongchaodeng/etcd-operator","forks_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/forks","keys_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/teams","hooks_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/events","assignees_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/tags","blobs_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/subscription","commits_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/merges","archive_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/downloads","issues_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/hongchaodeng/etcd-operator/deployments","created_at":"2016-11-03T21:01:55Z","updated_at":"2016-11-03T21:01:56Z","pushed_at":"2016-12-15T18:08:35Z","git_url":"git://github.com/hongchaodeng/etcd-operator.git","ssh_url":"git@github.com:hongchaodeng/etcd-operator.git","clone_url":"https://github.com/hongchaodeng/etcd-operator.git","svn_url":"https://github.com/hongchaodeng/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":1052,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"9d27002c469df3fbcf566fc7485d1facafe55a6b","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":64974719,"name":"etcd-operator","full_name":"coreos/etcd-operator","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd-operator","description":"etcd Operator creates/configures/manages etcd clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/etcd-operator","forks_url":"https://api.github.com/repos/coreos/etcd-operator/forks","keys_url":"https://api.github.com/repos/coreos/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd-operator/teams","hooks_url":"https://api.github.com/repos/coreos/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd-operator/events","assignees_url":"https://api.github.com/repos/coreos/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd-operator/tags","blobs_url":"https://api.github.com/repos/coreos/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd-operator/subscription","commits_url":"https://api.github.com/repos/coreos/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd-operator/merges","archive_url":"https://api.github.com/repos/coreos/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd-operator/downloads","issues_url":"https://api.github.com/repos/coreos/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd-operator/deployments","created_at":"2016-08-04T23:54:58Z","updated_at":"2016-12-15T15:26:00Z","pushed_at":"2016-12-15T18:08:38Z","git_url":"git://github.com/coreos/etcd-operator.git","ssh_url":"git@github.com:coreos/etcd-operator.git","clone_url":"https://github.com/coreos/etcd-operator.git","svn_url":"https://github.com/coreos/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":1048,"stargazers_count":139,"watchers_count":139,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":22,"forks":14,"open_issues":22,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/460"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/460"},"issue":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/460"},"comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd-operator/statuses/df793998702f2ffd54f7711ee8e1ade859e00c29"}}}}
{"actor":{"display_login":"hongchaodeng"}}