{"action":"opened","number":164,"pull_request":{"url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164","id":83936588,"html_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting/pull/164","diff_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting/pull/164.diff","patch_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting/pull/164.patch","issue_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/164","number":164,"state":"open","locked":false,"title":"Coding standard fixes","user":{"login":"jconroy","id":355014,"avatar_url":"https://avatars.githubusercontent.com/u/355014?v=3","gravatar_id":"","url":"https://api.github.com/users/jconroy","html_url":"https://github.com/jconroy","followers_url":"https://api.github.com/users/jconroy/followers","following_url":"https://api.github.com/users/jconroy/following{/other_user}","gists_url":"https://api.github.com/users/jconroy/gists{/gist_id}","starred_url":"https://api.github.com/users/jconroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jconroy/subscriptions","organizations_url":"https://api.github.com/users/jconroy/orgs","repos_url":"https://api.github.com/users/jconroy/repos","events_url":"https://api.github.com/users/jconroy/events{/privacy}","received_events_url":"https://api.github.com/users/jconroy/received_events","type":"User","site_admin":false},"body":"Getting in some coding standard fixes to avoid 🔴 before I implement https://github.com/Prospress/prospress-coding-standards/issues/3\r\n\r\nThese changes shouldn't affect plugin behavior/functionality - but should still be reviewed carefully.\r\n\r\nSome additional background info on the commits:\r\n\r\n* 63e34f0 fixes some indentation issues that now get picked up\r\n* 38c7ef7 the `WordPress.WP.I18n` sniff is now part of the WordPress Core rule set. When there is more than 1 placeholder in a translatable string they should be numbered - for RTL languages etc. it means the order can be moved around.\r\n* 1ddc37a fixes some white space issues that now get picked up\r\n* 54a5596 removes an extra `;`\r\n* 23349a1 fixes a few yoda condition issues. There were a number of fixes in WPCS 0.9.0 for the `WordPress.PHP.YodaConditions` sniff that we are now being picked up.\r\n* 3602872 the sniffs now identify instances where strings don't really need to be concatenated together.\r\n* 2f440ff instead of inserting the `$order_by` variable within the `$wpdb->prepare()` string directly it should be run through `prepare()` using a placeholder.\r\n* 36f975a, 639588e and b0f36e1 are probably the most notable of the changes. They change a bunch of the translatable strings to make better use of placeholders rather than a concatenated string + variables approach (which don't translate nicely).\r\n","created_at":"2016-09-04T22:54:34Z","updated_at":"2016-09-04T22:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164/commits","review_comments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164/comments","review_comment_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/164/comments","statuses_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/statuses/b0f36e1409762ef59cb361bd3bcb661e9655b822","head":{"label":"Prospress:update-coding-standards","ref":"update-coding-standards","sha":"b0f36e1409762ef59cb361bd3bcb661e9655b822","user":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars.githubusercontent.com/u/7764284?v=3","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"repo":{"id":35837555,"name":"woocommerce-subscriptions-gifting","full_name":"Prospress/woocommerce-subscriptions-gifting","owner":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars.githubusercontent.com/u/7764284?v=3","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting","description":"Give the gift that keeps on giving, by offering customers a way to purchase subscription products as gifts with WooCommerce Subscriptions.","fork":false,"url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting","forks_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/forks","keys_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/teams","hooks_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/hooks","issue_events_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/events{/number}","events_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/events","assignees_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/assignees{/user}","branches_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/branches{/branch}","tags_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/tags","blobs_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/statuses/{sha}","languages_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/languages","stargazers_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/stargazers","contributors_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/contributors","subscribers_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/subscribers","subscription_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/subscription","commits_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/contents/{+path}","compare_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/merges","archive_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/downloads","issues_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues{/number}","pulls_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls{/number}","milestones_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/milestones{/number}","notifications_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/labels{/name}","releases_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/releases{/id}","deployments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/deployments","created_at":"2015-05-18T19:16:32Z","updated_at":"2016-08-16T01:20:49Z","pushed_at":"2016-09-04T10:52:36Z","git_url":"git://github.com/Prospress/woocommerce-subscriptions-gifting.git","ssh_url":"git@github.com:Prospress/woocommerce-subscriptions-gifting.git","clone_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting.git","svn_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting","homepage":"","size":385,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":22,"default_branch":"master"}},"base":{"label":"Prospress:master","ref":"master","sha":"fe35fa9113c3758147468142b2fadb41ab60f9d3","user":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars.githubusercontent.com/u/7764284?v=3","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"repo":{"id":35837555,"name":"woocommerce-subscriptions-gifting","full_name":"Prospress/woocommerce-subscriptions-gifting","owner":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars.githubusercontent.com/u/7764284?v=3","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting","description":"Give the gift that keeps on giving, by offering customers a way to purchase subscription products as gifts with WooCommerce Subscriptions.","fork":false,"url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting","forks_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/forks","keys_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/teams","hooks_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/hooks","issue_events_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/events{/number}","events_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/events","assignees_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/assignees{/user}","branches_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/branches{/branch}","tags_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/tags","blobs_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/statuses/{sha}","languages_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/languages","stargazers_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/stargazers","contributors_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/contributors","subscribers_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/subscribers","subscription_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/subscription","commits_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/contents/{+path}","compare_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/merges","archive_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/downloads","issues_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues{/number}","pulls_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls{/number}","milestones_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/milestones{/number}","notifications_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/labels{/name}","releases_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/releases{/id}","deployments_url":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/deployments","created_at":"2015-05-18T19:16:32Z","updated_at":"2016-08-16T01:20:49Z","pushed_at":"2016-09-04T10:52:36Z","git_url":"git://github.com/Prospress/woocommerce-subscriptions-gifting.git","ssh_url":"git@github.com:Prospress/woocommerce-subscriptions-gifting.git","clone_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting.git","svn_url":"https://github.com/Prospress/woocommerce-subscriptions-gifting","homepage":"","size":385,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164"},"html":{"href":"https://github.com/Prospress/woocommerce-subscriptions-gifting/pull/164"},"issue":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/164"},"comments":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/Prospress/woocommerce-subscriptions-gifting/statuses/b0f36e1409762ef59cb361bd3bcb661e9655b822"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":28,"deletions":30,"changed_files":15}}
{"actor":{"display_login":"jconroy"}}