{"action":"created","issue":{"url":"https://api.github.com/repos/Comcast/traffic_control/issues/1485","repository_url":"https://api.github.com/repos/Comcast/traffic_control","labels_url":"https://api.github.com/repos/Comcast/traffic_control/issues/1485/labels{/name}","comments_url":"https://api.github.com/repos/Comcast/traffic_control/issues/1485/comments","events_url":"https://api.github.com/repos/Comcast/traffic_control/issues/1485/events","html_url":"https://github.com/Comcast/traffic_control/pull/1485","id":158222403,"number":1485,"title":"To steering api updates","user":{"login":"dneuman64","id":5092346,"avatar_url":"https://avatars.githubusercontent.com/u/5092346?v=3","gravatar_id":"","url":"https://api.github.com/users/dneuman64","html_url":"https://github.com/dneuman64","followers_url":"https://api.github.com/users/dneuman64/followers","following_url":"https://api.github.com/users/dneuman64/following{/other_user}","gists_url":"https://api.github.com/users/dneuman64/gists{/gist_id}","starred_url":"https://api.github.com/users/dneuman64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneuman64/subscriptions","organizations_url":"https://api.github.com/users/dneuman64/orgs","repos_url":"https://api.github.com/users/dneuman64/repos","events_url":"https://api.github.com/users/dneuman64/events{/privacy}","received_events_url":"https://api.github.com/users/dneuman64/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Comcast/traffic_control/labels/Traffic%20Ops","name":"Traffic Ops","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"trevorackerman","id":6789769,"avatar_url":"https://avatars.githubusercontent.com/u/6789769?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorackerman","html_url":"https://github.com/trevorackerman","followers_url":"https://api.github.com/users/trevorackerman/followers","following_url":"https://api.github.com/users/trevorackerman/following{/other_user}","gists_url":"https://api.github.com/users/trevorackerman/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorackerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorackerman/subscriptions","organizations_url":"https://api.github.com/users/trevorackerman/orgs","repos_url":"https://api.github.com/users/trevorackerman/repos","events_url":"https://api.github.com/users/trevorackerman/events{/privacy}","received_events_url":"https://api.github.com/users/trevorackerman/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Comcast/traffic_control/milestones/13","html_url":"https://github.com/Comcast/traffic_control/milestones/1.6.0","labels_url":"https://api.github.com/repos/Comcast/traffic_control/milestones/13/labels","id":1542209,"number":13,"title":"1.6.0","description":"","creator":{"login":"mtorluemke","id":3515510,"avatar_url":"https://avatars.githubusercontent.com/u/3515510?v=3","gravatar_id":"","url":"https://api.github.com/users/mtorluemke","html_url":"https://github.com/mtorluemke","followers_url":"https://api.github.com/users/mtorluemke/followers","following_url":"https://api.github.com/users/mtorluemke/following{/other_user}","gists_url":"https://api.github.com/users/mtorluemke/gists{/gist_id}","starred_url":"https://api.github.com/users/mtorluemke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtorluemke/subscriptions","organizations_url":"https://api.github.com/users/mtorluemke/orgs","repos_url":"https://api.github.com/users/mtorluemke/repos","events_url":"https://api.github.com/users/mtorluemke/events{/privacy}","received_events_url":"https://api.github.com/users/mtorluemke/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":65,"state":"open","created_at":"2016-01-25T17:24:50Z","updated_at":"2016-06-02T19:38:45Z","due_on":"2016-06-30T06:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-02T19:38:45Z","updated_at":"2016-06-02T20:41:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Comcast/traffic_control/pulls/1485","html_url":"https://github.com/Comcast/traffic_control/pull/1485","diff_url":"https://github.com/Comcast/traffic_control/pull/1485.diff","patch_url":"https://github.com/Comcast/traffic_control/pull/1485.patch"},"body":"Added ability to update and remove filters.\r\nTraffic Ops now returns a 400 (instead of a 200) when you try to update a steering assignment with invalid json."},"comment":{"url":"https://api.github.com/repos/Comcast/traffic_control/issues/comments/223415538","html_url":"https://github.com/Comcast/traffic_control/pull/1485#issuecomment-223415538","issue_url":"https://api.github.com/repos/Comcast/traffic_control/issues/1485","id":223415538,"user":{"login":"trevorackerman","id":6789769,"avatar_url":"https://avatars.githubusercontent.com/u/6789769?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorackerman","html_url":"https://github.com/trevorackerman","followers_url":"https://api.github.com/users/trevorackerman/followers","following_url":"https://api.github.com/users/trevorackerman/following{/other_user}","gists_url":"https://api.github.com/users/trevorackerman/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorackerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorackerman/subscriptions","organizations_url":"https://api.github.com/users/trevorackerman/orgs","repos_url":"https://api.github.com/users/trevorackerman/repos","events_url":"https://api.github.com/users/trevorackerman/events{/privacy}","received_events_url":"https://api.github.com/users/trevorackerman/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T20:41:06Z","updated_at":"2016-06-02T20:41:06Z","body":"I noticed that one of the tests still accepts the wrong json PUT data\r\n\r\nhttps://github.com/dneuman64/traffic_control/blob/be93fd85ac0e4f8cef322c446523a419875d5dc4/traffic_ops/app/t/api/1.2/steering_internal.t#L276\r\n\r\nThe 'filters' attribute is in the wrong place. Can you remove just that one line and have the test assert that we get back a 400? i.e. filters is a required attribute for the PUT data.\r\n\r\nThe test you came up with for removing filters looks good!\r\nhttps://github.com/Comcast/traffic_control/pull/1485/files#diff-27ed8be6da922277af8c7baa33b71575R337\r\n"}}
{"actor":{"display_login":"trevorackerman"}}