{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74322212","id":74322212,"diff_hunk":"@@ -62,7 +65,42 @@ func (pfs *ProcFS) GetFullContainerName(pid int) (string, error) {\n \treturn containerNameFromProcCgroup(string(content))\n }\n \n-func PidOf(name string) []int {\n+func PKill(name string, sig syscall.Signal) error {","path":"pkg/util/procfs/procfs.go","position":20,"original_position":20,"commit_id":"4c99ef6b5eedf66dad913e44808b8fa739f3490b","original_commit_id":"4c99ef6b5eedf66dad913e44808b8fa739f3490b","user":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"body":"Add godoc style comment for the function.","created_at":"2016-08-10T20:20:47Z","updated_at":"2016-08-10T20:20:47Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30087#discussion_r74322212","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74322212"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30087#discussion_r74322212"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087","id":80115948,"html_url":"https://github.com/kubernetes/kubernetes/pull/30087","diff_url":"https://github.com/kubernetes/kubernetes/pull/30087.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30087.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30087","number":30087,"state":"open","locked":false,"title":"Remove kubelet pkill dependency","user":{"login":"dims","id":23304,"avatar_url":"https://avatars.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"body":"Issue #26093 identified pkill as one of the dependencies of kublet\r\nwhich could be worked around.  Build on the code introduced for pidof\r\nand regexp for the process(es) we need to send a signal to.\r\n\r\nRelated to #26093\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30087)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-04T17:14:59Z","updated_at":"2016-08-10T20:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a4f94a03f1838d2912eafde62fa90889f208e0d","assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30087/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4c99ef6b5eedf66dad913e44808b8fa739f3490b","head":{"label":"dims:remove-pkill-dependency","ref":"remove-pkill-dependency","sha":"4c99ef6b5eedf66dad913e44808b8fa739f3490b","user":{"login":"dims","id":23304,"avatar_url":"https://avatars.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"repo":{"id":58837596,"name":"kubernetes","full_name":"dims/kubernetes","owner":{"login":"dims","id":23304,"avatar_url":"https://avatars.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dims/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dims/kubernetes","forks_url":"https://api.github.com/repos/dims/kubernetes/forks","keys_url":"https://api.github.com/repos/dims/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dims/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dims/kubernetes/teams","hooks_url":"https://api.github.com/repos/dims/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dims/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dims/kubernetes/events","assignees_url":"https://api.github.com/repos/dims/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dims/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dims/kubernetes/tags","blobs_url":"https://api.github.com/repos/dims/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dims/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dims/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dims/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dims/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dims/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dims/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dims/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dims/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dims/kubernetes/subscription","commits_url":"https://api.github.com/repos/dims/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dims/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dims/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dims/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dims/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dims/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dims/kubernetes/merges","archive_url":"https://api.github.com/repos/dims/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dims/kubernetes/downloads","issues_url":"https://api.github.com/repos/dims/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dims/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dims/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dims/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dims/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dims/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dims/kubernetes/deployments","created_at":"2016-05-15T01:04:18Z","updated_at":"2016-05-15T01:04:33Z","pushed_at":"2016-08-10T19:22:14Z","git_url":"git://github.com/dims/kubernetes.git","ssh_url":"git@github.com:dims/kubernetes.git","clone_url":"https://github.com/dims/kubernetes.git","svn_url":"https://github.com/dims/kubernetes","homepage":"http://kubernetes.io","size":304658,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"66c9edfdea17a182b79257348f33e8b0131420f2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-10T20:16:37Z","pushed_at":"2016-08-10T20:20:41Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":518947,"stargazers_count":16068,"watchers_count":16068,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5095,"mirror_url":null,"open_issues_count":4149,"forks":5095,"open_issues":4149,"watchers":16068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30087"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30087"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30087/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30087/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4c99ef6b5eedf66dad913e44808b8fa739f3490b"}}}}
{"actor":{"display_login":"yujuhong"}}