{"action":"created","issue":{"url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/31","repository_url":"https://api.github.com/repos/danfickle/openhtmltopdf","labels_url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/31/comments","events_url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/31/events","html_url":"https://github.com/danfickle/openhtmltopdf/pull/31","id":165314009,"number":31,"title":"Implement -fs-page-break-min-height","user":{"login":"rototor","id":711674,"avatar_url":"https://avatars.githubusercontent.com/u/711674?v=3","gravatar_id":"","url":"https://api.github.com/users/rototor","html_url":"https://github.com/rototor","followers_url":"https://api.github.com/users/rototor/followers","following_url":"https://api.github.com/users/rototor/following{/other_user}","gists_url":"https://api.github.com/users/rototor/gists{/gist_id}","starred_url":"https://api.github.com/users/rototor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rototor/subscriptions","organizations_url":"https://api.github.com/users/rototor/orgs","repos_url":"https://api.github.com/users/rototor/repos","events_url":"https://api.github.com/users/rototor/events{/privacy}","received_events_url":"https://api.github.com/users/rototor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-13T12:58:53Z","updated_at":"2016-07-15T10:17:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/danfickle/openhtmltopdf/pulls/31","html_url":"https://github.com/danfickle/openhtmltopdf/pull/31","diff_url":"https://github.com/danfickle/openhtmltopdf/pull/31.diff","patch_url":"https://github.com/danfickle/openhtmltopdf/pull/31.patch"},"body":"This CSS property allows to force a page break before an element if not the specified space is left on the\r\ncurrent page.\r\n\r\nCSS orphans and page-break-inside:avoid are nice, but dont work always,\r\nespecially with complex tables.\r\n\r\nThis CSS property allows to workaround many page break problems.\r\n\r\nAlso adds a sample document which demonstrates the effect of\r\nthis property. Also the TestcaseRunner now prints onto the System.out\r\nwere the output PDF was written.\r\n\r\n@danfickle I'm not sure if -fs-page-break-min-height is the best name for this property. If you can come up with some better name, I'll change it.\r\n\r\nYes, this is some kind of \"workaround\" hack. But I \"need\" openhtmltopdf work for me now, as I want to redo some complex JasperReports reports with FreeMarker + openhtmltopdf. Of course it would be better to just fix the layout bugs, but as seen in #19 its not that easy :(\r\n\r\nIf you want to see what bugs I mean => just comment out the CSS properties in FSPageBreakMinHeightSample.html:176 and FSPageBreakMinHeightSample.html:173  and run the TestcaseRunner."},"comment":{"url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/comments/232914992","html_url":"https://github.com/danfickle/openhtmltopdf/pull/31#issuecomment-232914992","issue_url":"https://api.github.com/repos/danfickle/openhtmltopdf/issues/31","id":232914992,"user":{"login":"danfickle","id":1415728,"avatar_url":"https://avatars.githubusercontent.com/u/1415728?v=3","gravatar_id":"","url":"https://api.github.com/users/danfickle","html_url":"https://github.com/danfickle","followers_url":"https://api.github.com/users/danfickle/followers","following_url":"https://api.github.com/users/danfickle/following{/other_user}","gists_url":"https://api.github.com/users/danfickle/gists{/gist_id}","starred_url":"https://api.github.com/users/danfickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfickle/subscriptions","organizations_url":"https://api.github.com/users/danfickle/orgs","repos_url":"https://api.github.com/users/danfickle/repos","events_url":"https://api.github.com/users/danfickle/events{/privacy}","received_events_url":"https://api.github.com/users/danfickle/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T10:17:15Z","updated_at":"2016-07-15T10:17:15Z","body":"Thanks @rototor - The code looks good - The only queries I have are:\r\n+ I don't think this property should be inherited. Layout properties generally are not.\r\n+ Is it possible to make a simpler test case that just demonstrates this property?\r\n+ What happens if the figure provided is greater than the page height?\r\n\r\nIf you like I can take care of these minor concerns after the merge. Let me know if that is alright. Thanks again and sorry for the delay, I've had a cold."}}
{"actor":{"display_login":"danfickle"}}