{"action":"created","issue":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/2790","repository_url":"https://api.github.com/repos/simulationcraft/simc","labels_url":"https://api.github.com/repos/simulationcraft/simc/issues/2790/labels{/name}","comments_url":"https://api.github.com/repos/simulationcraft/simc/issues/2790/comments","events_url":"https://api.github.com/repos/simulationcraft/simc/issues/2790/events","html_url":"https://github.com/simulationcraft/simc/issues/2790","id":173662315,"number":2790,"title":"[Warrior] [Arms] - Dauntless/Deadly Calm and Execute interaction bugs","user":{"login":"amulder87","id":20569226,"avatar_url":"https://avatars.githubusercontent.com/u/20569226?v=3","gravatar_id":"","url":"https://api.github.com/users/amulder87","html_url":"https://github.com/amulder87","followers_url":"https://api.github.com/users/amulder87/followers","following_url":"https://api.github.com/users/amulder87/following{/other_user}","gists_url":"https://api.github.com/users/amulder87/gists{/gist_id}","starred_url":"https://api.github.com/users/amulder87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amulder87/subscriptions","organizations_url":"https://api.github.com/users/amulder87/orgs","repos_url":"https://api.github.com/users/amulder87/repos","events_url":"https://api.github.com/users/amulder87/events{/privacy}","received_events_url":"https://api.github.com/users/amulder87/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Collisionc","id":7837280,"avatar_url":"https://avatars.githubusercontent.com/u/7837280?v=3","gravatar_id":"","url":"https://api.github.com/users/Collisionc","html_url":"https://github.com/Collisionc","followers_url":"https://api.github.com/users/Collisionc/followers","following_url":"https://api.github.com/users/Collisionc/following{/other_user}","gists_url":"https://api.github.com/users/Collisionc/gists{/gist_id}","starred_url":"https://api.github.com/users/Collisionc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Collisionc/subscriptions","organizations_url":"https://api.github.com/users/Collisionc/orgs","repos_url":"https://api.github.com/users/Collisionc/repos","events_url":"https://api.github.com/users/Collisionc/events{/privacy}","received_events_url":"https://api.github.com/users/Collisionc/received_events","type":"User","site_admin":false},"assignees":[{"login":"Collisionc","id":7837280,"avatar_url":"https://avatars.githubusercontent.com/u/7837280?v=3","gravatar_id":"","url":"https://api.github.com/users/Collisionc","html_url":"https://github.com/Collisionc","followers_url":"https://api.github.com/users/Collisionc/followers","following_url":"https://api.github.com/users/Collisionc/following{/other_user}","gists_url":"https://api.github.com/users/Collisionc/gists{/gist_id}","starred_url":"https://api.github.com/users/Collisionc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Collisionc/subscriptions","organizations_url":"https://api.github.com/users/Collisionc/orgs","repos_url":"https://api.github.com/users/Collisionc/repos","events_url":"https://api.github.com/users/Collisionc/events{/privacy}","received_events_url":"https://api.github.com/users/Collisionc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-28T19:15:33Z","updated_at":"2016-08-28T20:47:55Z","closed_at":"2016-08-28T20:47:55Z","body":"Dauntless is reducing the damage of execute and its chance to proc Tactician whenever execute is used below 40 rage.\r\n\r\nIf I sim a profile that just auto attacks and executes only with 40 or more rage and compare with/without dauntless taken, the damage per execute is identical with both, giving execute 25% more damage per rage and proccing tactician 25% more often when dauntless is taken, which is what we'd expect.\r\n\r\nToggle Dauntless on/off with this APL for this comparison:\r\n```\r\nwarrior=\"Test\"\r\nlevel=100\r\nrace=orc\r\nrole=attack\r\nposition=back\r\ntalents=0000000\r\nspec=arms\r\n\r\nactions+=/auto_attack\r\nactions+=/execute,if=rage>=40\r\n\r\nmain_hand=large_club,id=2480\r\n```\r\n\r\nIf you change the conditions on execute to only execute below 32 rage and compare with/without dauntless again, Execute has an identical damage per rage with/without Dauntless when it should still be 25% higher with Dauntless, and Tactician procs no more often when it should still be 25% higher too.\r\n\r\nToggle Dauntless on/off with this APL for comparison. Tactician procs are slightly higher since spending rage on WW is granting a higher chance to proc technician than execute:\r\n```\r\nwarrior=\"Test\"\r\nlevel=100\r\nrace=orc\r\nrole=attack\r\nposition=back\r\ntalents=0000000\r\nspec=arms\r\n\r\nactions+=/auto_attack\r\nactions+=/execute,if=rage<=32\r\nactions+=/whirlwind,if=target.health.pct<20&rage>32\r\n\r\nmain_hand=large_club,id=2480\r\n```\r\n\r\nWith Deadly Calm taken, the current rage of the player is being used to calculate both the damage of execute and the amount of rage that counts towards tactician procs(counts as spending 10 minimum though I think?), instead of using 40 for both. Regardless of the player's current rage, an execute during Deadly Calm should count as a max rage execute for damage calculations(4x dmg) and tactician proc chances. Rage is also being consumed when execute is used during Deadly Calm when it should be entirely free.\r\n\r\nExample APL that gives 0 damage from execute and reduced tactician procs:\r\n```\r\nwarrior=\"Test\"\r\nlevel=100\r\nrace=orc\r\nrole=attack\r\nposition=back\r\ntalents=1000311\r\nspec=arms\r\n\r\nactions+=/battle_cry,if=target.health.pct<20\r\nactions+=/execute,if=buff.battle_cry.up\r\n\r\nmain_hand=large_club,id=2480\r\n```\r\n\r\nJust adding auto attack to that APL will let execute deal damage and quadruple tactician procs, when it should make no difference for this scenario."},"comment":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/comments/242998306","html_url":"https://github.com/simulationcraft/simc/issues/2790#issuecomment-242998306","issue_url":"https://api.github.com/repos/simulationcraft/simc/issues/2790","id":242998306,"user":{"login":"Collisionc","id":7837280,"avatar_url":"https://avatars.githubusercontent.com/u/7837280?v=3","gravatar_id":"","url":"https://api.github.com/users/Collisionc","html_url":"https://github.com/Collisionc","followers_url":"https://api.github.com/users/Collisionc/followers","following_url":"https://api.github.com/users/Collisionc/following{/other_user}","gists_url":"https://api.github.com/users/Collisionc/gists{/gist_id}","starred_url":"https://api.github.com/users/Collisionc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Collisionc/subscriptions","organizations_url":"https://api.github.com/users/Collisionc/orgs","repos_url":"https://api.github.com/users/Collisionc/repos","events_url":"https://api.github.com/users/Collisionc/events{/privacy}","received_events_url":"https://api.github.com/users/Collisionc/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T20:47:55Z","updated_at":"2016-08-28T20:47:55Z","body":"Ok uploaded a fixed version after testing it out a little. "}}
{"actor":{"display_login":"Collisionc"}}