{"action":"created","issue":{"url":"https://api.github.com/repos/ably/ably-js/issues/225","repository_url":"https://api.github.com/repos/ably/ably-js","labels_url":"https://api.github.com/repos/ably/ably-js/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/ably/ably-js/issues/225/comments","events_url":"https://api.github.com/repos/ably/ably-js/issues/225/events","html_url":"https://github.com/ably/ably-js/pull/225","id":130175549,"number":225,"title":"Updated tests for spec","user":{"login":"adamgiacomelli","id":8747447,"avatar_url":"https://avatars.githubusercontent.com/u/8747447?v=3","gravatar_id":"","url":"https://api.github.com/users/adamgiacomelli","html_url":"https://github.com/adamgiacomelli","followers_url":"https://api.github.com/users/adamgiacomelli/followers","following_url":"https://api.github.com/users/adamgiacomelli/following{/other_user}","gists_url":"https://api.github.com/users/adamgiacomelli/gists{/gist_id}","starred_url":"https://api.github.com/users/adamgiacomelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamgiacomelli/subscriptions","organizations_url":"https://api.github.com/users/adamgiacomelli/orgs","repos_url":"https://api.github.com/users/adamgiacomelli/repos","events_url":"https://api.github.com/users/adamgiacomelli/events{/privacy}","received_events_url":"https://api.github.com/users/adamgiacomelli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-01-31T20:07:25Z","updated_at":"2016-02-09T20:12:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ably/ably-js/pulls/225","html_url":"https://github.com/ably/ably-js/pull/225","diff_url":"https://github.com/ably/ably-js/pull/225.diff","patch_url":"https://github.com/ably/ably-js/pull/225.patch"},"body":"Work done:\r\n1.)Missing tests \r\n - Added fixtures for limit testing\r\n - Added missing tests for default & max limit\r\n - Added direction omitted test\r\n\r\n2.)Various\r\n- Fixed comment on query pagination forwards, \r\n- Renamed limit0 and limit1 tests to a more human readable name, fixed wrong direction specified on forwards test\r\n- Tuned existing tests to the new fixtures\r\n\r\nI have observed that while running the tests a message appears in the fixtures with current time/date and it caused my backwards tests to fail since it had 0 inbound/outbound messages with 0 data. When I test with an hour ago ending all tests pass.\r\n "},"comment":{"url":"https://api.github.com/repos/ably/ably-js/issues/comments/182042771","html_url":"https://github.com/ably/ably-js/pull/225#issuecomment-182042771","issue_url":"https://api.github.com/repos/ably/ably-js/issues/225","id":182042771,"user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T20:12:31Z","updated_at":"2016-02-09T20:12:31Z","body":"Thanks @adamgiacomelli "}}