{"action":"created","comment":{"url":"https://api.github.com/repos/HashNuke/hound/pulls/comments/63226794","id":63226794,"diff_hunk":"@@ -201,6 +201,9 @@ defmodule Hound.Helpers.Element do\n   You can also pass the selector as a tuple.\n \n       element_displayed?({:name, \"example\"})\n+      \n+  Note: If you'd like to check presence of elements in the DOM use `element?/2`, \n+  `element_displayed?/1` will only consider elements that are always present in the DOM, either in visible or hidden state.","path":"lib/hound/helpers/element.ex","position":6,"original_position":6,"commit_id":"94c434fcb1da1ee575ce92b2dd076fc64aa0d62c","original_commit_id":"94c434fcb1da1ee575ce92b2dd076fc64aa0d62c","user":{"login":"jasdeepsingh","id":603900,"avatar_url":"https://avatars.githubusercontent.com/u/603900?v=3","gravatar_id":"","url":"https://api.github.com/users/jasdeepsingh","html_url":"https://github.com/jasdeepsingh","followers_url":"https://api.github.com/users/jasdeepsingh/followers","following_url":"https://api.github.com/users/jasdeepsingh/following{/other_user}","gists_url":"https://api.github.com/users/jasdeepsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jasdeepsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasdeepsingh/subscriptions","organizations_url":"https://api.github.com/users/jasdeepsingh/orgs","repos_url":"https://api.github.com/users/jasdeepsingh/repos","events_url":"https://api.github.com/users/jasdeepsingh/events{/privacy}","received_events_url":"https://api.github.com/users/jasdeepsingh/received_events","type":"User","site_admin":false},"body":"I guess what's more important is that the documentation needs to reflect that there is an `element?/2` function present (albeit in a different module)\r\n\r\nThe intent and functionality of `element_displayed?` becomes clear after using it. \r\n\r\nA developer scouring through the documentation for `Hound.Helpers.Element` may think they can use `element_displayed?` when what they really wanted to use was `element?`\r\n\r\nSo, in light of this, do you think the second line that I wrote can just be discarded? ","created_at":"2016-05-13T18:07:58Z","updated_at":"2016-05-13T18:07:58Z","html_url":"https://github.com/HashNuke/hound/pull/106#discussion_r63226794","pull_request_url":"https://api.github.com/repos/HashNuke/hound/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/comments/63226794"},"html":{"href":"https://github.com/HashNuke/hound/pull/106#discussion_r63226794"},"pull_request":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/HashNuke/hound/pulls/106","id":69939084,"html_url":"https://github.com/HashNuke/hound/pull/106","diff_url":"https://github.com/HashNuke/hound/pull/106.diff","patch_url":"https://github.com/HashNuke/hound/pull/106.patch","issue_url":"https://api.github.com/repos/HashNuke/hound/issues/106","number":106,"state":"open","locked":false,"title":"Added a note in the docs outlining difference b/w element?/2 and element_displayed?/1","user":{"login":"jasdeepsingh","id":603900,"avatar_url":"https://avatars.githubusercontent.com/u/603900?v=3","gravatar_id":"","url":"https://api.github.com/users/jasdeepsingh","html_url":"https://github.com/jasdeepsingh","followers_url":"https://api.github.com/users/jasdeepsingh/followers","following_url":"https://api.github.com/users/jasdeepsingh/following{/other_user}","gists_url":"https://api.github.com/users/jasdeepsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jasdeepsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasdeepsingh/subscriptions","organizations_url":"https://api.github.com/users/jasdeepsingh/orgs","repos_url":"https://api.github.com/users/jasdeepsingh/repos","events_url":"https://api.github.com/users/jasdeepsingh/events{/privacy}","received_events_url":"https://api.github.com/users/jasdeepsingh/received_events","type":"User","site_admin":false},"body":"This tripped me up and took me some time to figure this out. Partially because `element?/2` was defined within `Hound.Matchers` and I kept looking into `Hound.Helpers.Element` for possible ways to check the presence of an element instead of it's visibility.","created_at":"2016-05-13T03:38:17Z","updated_at":"2016-05-13T18:07:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de36d50de914b7660724914f300e20445ac3db07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HashNuke/hound/pulls/106/commits","review_comments_url":"https://api.github.com/repos/HashNuke/hound/pulls/106/comments","review_comment_url":"https://api.github.com/repos/HashNuke/hound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HashNuke/hound/issues/106/comments","statuses_url":"https://api.github.com/repos/HashNuke/hound/statuses/94c434fcb1da1ee575ce92b2dd076fc64aa0d62c","head":{"label":"metaware:master","ref":"master","sha":"94c434fcb1da1ee575ce92b2dd076fc64aa0d62c","user":{"login":"metaware","id":1767846,"avatar_url":"https://avatars.githubusercontent.com/u/1767846?v=3","gravatar_id":"","url":"https://api.github.com/users/metaware","html_url":"https://github.com/metaware","followers_url":"https://api.github.com/users/metaware/followers","following_url":"https://api.github.com/users/metaware/following{/other_user}","gists_url":"https://api.github.com/users/metaware/gists{/gist_id}","starred_url":"https://api.github.com/users/metaware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaware/subscriptions","organizations_url":"https://api.github.com/users/metaware/orgs","repos_url":"https://api.github.com/users/metaware/repos","events_url":"https://api.github.com/users/metaware/events{/privacy}","received_events_url":"https://api.github.com/users/metaware/received_events","type":"Organization","site_admin":false},"repo":{"id":58696355,"name":"hound","full_name":"metaware/hound","owner":{"login":"metaware","id":1767846,"avatar_url":"https://avatars.githubusercontent.com/u/1767846?v=3","gravatar_id":"","url":"https://api.github.com/users/metaware","html_url":"https://github.com/metaware","followers_url":"https://api.github.com/users/metaware/followers","following_url":"https://api.github.com/users/metaware/following{/other_user}","gists_url":"https://api.github.com/users/metaware/gists{/gist_id}","starred_url":"https://api.github.com/users/metaware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaware/subscriptions","organizations_url":"https://api.github.com/users/metaware/orgs","repos_url":"https://api.github.com/users/metaware/repos","events_url":"https://api.github.com/users/metaware/events{/privacy}","received_events_url":"https://api.github.com/users/metaware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metaware/hound","description":"Elixir library for writing integration tests and browser automation","fork":true,"url":"https://api.github.com/repos/metaware/hound","forks_url":"https://api.github.com/repos/metaware/hound/forks","keys_url":"https://api.github.com/repos/metaware/hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metaware/hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metaware/hound/teams","hooks_url":"https://api.github.com/repos/metaware/hound/hooks","issue_events_url":"https://api.github.com/repos/metaware/hound/issues/events{/number}","events_url":"https://api.github.com/repos/metaware/hound/events","assignees_url":"https://api.github.com/repos/metaware/hound/assignees{/user}","branches_url":"https://api.github.com/repos/metaware/hound/branches{/branch}","tags_url":"https://api.github.com/repos/metaware/hound/tags","blobs_url":"https://api.github.com/repos/metaware/hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metaware/hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metaware/hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/metaware/hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metaware/hound/statuses/{sha}","languages_url":"https://api.github.com/repos/metaware/hound/languages","stargazers_url":"https://api.github.com/repos/metaware/hound/stargazers","contributors_url":"https://api.github.com/repos/metaware/hound/contributors","subscribers_url":"https://api.github.com/repos/metaware/hound/subscribers","subscription_url":"https://api.github.com/repos/metaware/hound/subscription","commits_url":"https://api.github.com/repos/metaware/hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/metaware/hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/metaware/hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/metaware/hound/issues/comments{/number}","contents_url":"https://api.github.com/repos/metaware/hound/contents/{+path}","compare_url":"https://api.github.com/repos/metaware/hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metaware/hound/merges","archive_url":"https://api.github.com/repos/metaware/hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metaware/hound/downloads","issues_url":"https://api.github.com/repos/metaware/hound/issues{/number}","pulls_url":"https://api.github.com/repos/metaware/hound/pulls{/number}","milestones_url":"https://api.github.com/repos/metaware/hound/milestones{/number}","notifications_url":"https://api.github.com/repos/metaware/hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metaware/hound/labels{/name}","releases_url":"https://api.github.com/repos/metaware/hound/releases{/id}","deployments_url":"https://api.github.com/repos/metaware/hound/deployments","created_at":"2016-05-13T03:30:31Z","updated_at":"2016-05-13T03:30:32Z","pushed_at":"2016-05-13T03:31:25Z","git_url":"git://github.com/metaware/hound.git","ssh_url":"git@github.com:metaware/hound.git","clone_url":"https://github.com/metaware/hound.git","svn_url":"https://github.com/metaware/hound","homepage":"http://hexdocs.pm/hound","size":376,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HashNuke:master","ref":"master","sha":"b94baed7871dc52aea30124c1ba84e3fa079c115","user":{"login":"HashNuke","id":84005,"avatar_url":"https://avatars.githubusercontent.com/u/84005?v=3","gravatar_id":"","url":"https://api.github.com/users/HashNuke","html_url":"https://github.com/HashNuke","followers_url":"https://api.github.com/users/HashNuke/followers","following_url":"https://api.github.com/users/HashNuke/following{/other_user}","gists_url":"https://api.github.com/users/HashNuke/gists{/gist_id}","starred_url":"https://api.github.com/users/HashNuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashNuke/subscriptions","organizations_url":"https://api.github.com/users/HashNuke/orgs","repos_url":"https://api.github.com/users/HashNuke/repos","events_url":"https://api.github.com/users/HashNuke/events{/privacy}","received_events_url":"https://api.github.com/users/HashNuke/received_events","type":"User","site_admin":false},"repo":{"id":15204429,"name":"hound","full_name":"HashNuke/hound","owner":{"login":"HashNuke","id":84005,"avatar_url":"https://avatars.githubusercontent.com/u/84005?v=3","gravatar_id":"","url":"https://api.github.com/users/HashNuke","html_url":"https://github.com/HashNuke","followers_url":"https://api.github.com/users/HashNuke/followers","following_url":"https://api.github.com/users/HashNuke/following{/other_user}","gists_url":"https://api.github.com/users/HashNuke/gists{/gist_id}","starred_url":"https://api.github.com/users/HashNuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashNuke/subscriptions","organizations_url":"https://api.github.com/users/HashNuke/orgs","repos_url":"https://api.github.com/users/HashNuke/repos","events_url":"https://api.github.com/users/HashNuke/events{/privacy}","received_events_url":"https://api.github.com/users/HashNuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HashNuke/hound","description":"Elixir library for writing integration tests and browser automation","fork":false,"url":"https://api.github.com/repos/HashNuke/hound","forks_url":"https://api.github.com/repos/HashNuke/hound/forks","keys_url":"https://api.github.com/repos/HashNuke/hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HashNuke/hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HashNuke/hound/teams","hooks_url":"https://api.github.com/repos/HashNuke/hound/hooks","issue_events_url":"https://api.github.com/repos/HashNuke/hound/issues/events{/number}","events_url":"https://api.github.com/repos/HashNuke/hound/events","assignees_url":"https://api.github.com/repos/HashNuke/hound/assignees{/user}","branches_url":"https://api.github.com/repos/HashNuke/hound/branches{/branch}","tags_url":"https://api.github.com/repos/HashNuke/hound/tags","blobs_url":"https://api.github.com/repos/HashNuke/hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HashNuke/hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HashNuke/hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/HashNuke/hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HashNuke/hound/statuses/{sha}","languages_url":"https://api.github.com/repos/HashNuke/hound/languages","stargazers_url":"https://api.github.com/repos/HashNuke/hound/stargazers","contributors_url":"https://api.github.com/repos/HashNuke/hound/contributors","subscribers_url":"https://api.github.com/repos/HashNuke/hound/subscribers","subscription_url":"https://api.github.com/repos/HashNuke/hound/subscription","commits_url":"https://api.github.com/repos/HashNuke/hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/HashNuke/hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/HashNuke/hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/HashNuke/hound/issues/comments{/number}","contents_url":"https://api.github.com/repos/HashNuke/hound/contents/{+path}","compare_url":"https://api.github.com/repos/HashNuke/hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HashNuke/hound/merges","archive_url":"https://api.github.com/repos/HashNuke/hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HashNuke/hound/downloads","issues_url":"https://api.github.com/repos/HashNuke/hound/issues{/number}","pulls_url":"https://api.github.com/repos/HashNuke/hound/pulls{/number}","milestones_url":"https://api.github.com/repos/HashNuke/hound/milestones{/number}","notifications_url":"https://api.github.com/repos/HashNuke/hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HashNuke/hound/labels{/name}","releases_url":"https://api.github.com/repos/HashNuke/hound/releases{/id}","deployments_url":"https://api.github.com/repos/HashNuke/hound/deployments","created_at":"2013-12-15T14:01:16Z","updated_at":"2016-05-13T15:21:05Z","pushed_at":"2016-05-13T03:38:18Z","git_url":"git://github.com/HashNuke/hound.git","ssh_url":"git@github.com:HashNuke/hound.git","clone_url":"https://github.com/HashNuke/hound.git","svn_url":"https://github.com/HashNuke/hound","homepage":"http://hexdocs.pm/hound","size":381,"stargazers_count":482,"watchers_count":482,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":5,"forks":41,"open_issues":5,"watchers":482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/106"},"html":{"href":"https://github.com/HashNuke/hound/pull/106"},"issue":{"href":"https://api.github.com/repos/HashNuke/hound/issues/106"},"comments":{"href":"https://api.github.com/repos/HashNuke/hound/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HashNuke/hound/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/HashNuke/hound/statuses/94c434fcb1da1ee575ce92b2dd076fc64aa0d62c"}}}}