{"action":"created","comment":{"url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/comments/71178320","id":71178320,"diff_hunk":"@@ -819,17 +814,14 @@ mav_result_t Mavlink_waypoint_handler::set_auto_landing(Mavlink_waypoint_handler\n \n         //waypoint_handler->navigation_.dubin_state = DUBIN_INIT;\n \n-        local_position_t landing_position = waypoint_handler->position_estimation_.local_position;\n-        landing_position.pos[Z] = -5.0f;\n+        local_position_t landing_position = waypoint_handler->ins_.position_lf();\n+        landing_position[Z] = -5.0f;\n         if (packet->param1 == 1)\n         {\n             print_util_dbg_print(\"Landing at a given location\\r\\n\");\n \n-            landing_position.pos[X] = packet->param5;\n-            landing_position.pos[Y] = packet->param6;\n-            \n-            landing_position.heading = waypoint_handler->position_estimation_.local_position.heading;","path":"communication/mavlink_waypoint_handler.cpp","position":198,"original_position":188,"commit_id":"54c7d291025422e9b125eaa4a8913dbab97ed8cb","original_commit_id":"71e67e431532fe388b66ae215419efb18a35ccb0","user":{"login":"jlecoeur","id":1379463,"avatar_url":"https://avatars.githubusercontent.com/u/1379463?v=3","gravatar_id":"","url":"https://api.github.com/users/jlecoeur","html_url":"https://github.com/jlecoeur","followers_url":"https://api.github.com/users/jlecoeur/followers","following_url":"https://api.github.com/users/jlecoeur/following{/other_user}","gists_url":"https://api.github.com/users/jlecoeur/gists{/gist_id}","starred_url":"https://api.github.com/users/jlecoeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlecoeur/subscriptions","organizations_url":"https://api.github.com/users/jlecoeur/orgs","repos_url":"https://api.github.com/users/jlecoeur/repos","events_url":"https://api.github.com/users/jlecoeur/events{/privacy}","received_events_url":"https://api.github.com/users/jlecoeur/received_events","type":"User","site_admin":false},"body":"The heading is set to the current heading just bellow on line https://github.com/lis-epfl/MAVRIC_Library/blob/dev/ins/communication/mavlink_waypoint_handler.cpp#L839 ","created_at":"2016-07-18T16:16:16Z","updated_at":"2016-07-18T16:16:16Z","html_url":"https://github.com/lis-epfl/MAVRIC_Library/pull/278#discussion_r71178320","pull_request_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/comments/71178320"},"html":{"href":"https://github.com/lis-epfl/MAVRIC_Library/pull/278#discussion_r71178320"},"pull_request":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278","id":77785844,"html_url":"https://github.com/lis-epfl/MAVRIC_Library/pull/278","diff_url":"https://github.com/lis-epfl/MAVRIC_Library/pull/278.diff","patch_url":"https://github.com/lis-epfl/MAVRIC_Library/pull/278.patch","issue_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/278","number":278,"state":"open","locked":false,"title":"Dev/ins","user":{"login":"jlecoeur","id":1379463,"avatar_url":"https://avatars.githubusercontent.com/u/1379463?v=3","gravatar_id":"","url":"https://api.github.com/users/jlecoeur","html_url":"https://github.com/jlecoeur","followers_url":"https://api.github.com/users/jlecoeur/followers","following_url":"https://api.github.com/users/jlecoeur/following{/other_user}","gists_url":"https://api.github.com/users/jlecoeur/gists{/gist_id}","starred_url":"https://api.github.com/users/jlecoeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlecoeur/subscriptions","organizations_url":"https://api.github.com/users/jlecoeur/orgs","repos_url":"https://api.github.com/users/jlecoeur/repos","events_url":"https://api.github.com/users/jlecoeur/events{/privacy}","received_events_url":"https://api.github.com/users/jlecoeur/received_events","type":"User","site_admin":false},"body":"This PR adds an interface for position/velocity estimation (similar to ahrs for attitude estimation)\r\n- add interface\r\n- convert position_estimation to follow this interface\r\n- adapt all code to use ins instead of position_estimation\r\n- add linear kalman ins","created_at":"2016-07-18T10:19:45Z","updated_at":"2016-07-18T16:16:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b588a78a64907402bbb1371913bce020c782778","assignee":{"login":"GregoireH","id":3974772,"avatar_url":"https://avatars.githubusercontent.com/u/3974772?v=3","gravatar_id":"","url":"https://api.github.com/users/GregoireH","html_url":"https://github.com/GregoireH","followers_url":"https://api.github.com/users/GregoireH/followers","following_url":"https://api.github.com/users/GregoireH/following{/other_user}","gists_url":"https://api.github.com/users/GregoireH/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoireH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoireH/subscriptions","organizations_url":"https://api.github.com/users/GregoireH/orgs","repos_url":"https://api.github.com/users/GregoireH/repos","events_url":"https://api.github.com/users/GregoireH/events{/privacy}","received_events_url":"https://api.github.com/users/GregoireH/received_events","type":"User","site_admin":false},"assignees":[{"login":"GregoireH","id":3974772,"avatar_url":"https://avatars.githubusercontent.com/u/3974772?v=3","gravatar_id":"","url":"https://api.github.com/users/GregoireH","html_url":"https://github.com/GregoireH","followers_url":"https://api.github.com/users/GregoireH/followers","following_url":"https://api.github.com/users/GregoireH/following{/other_user}","gists_url":"https://api.github.com/users/GregoireH/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoireH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoireH/subscriptions","organizations_url":"https://api.github.com/users/GregoireH/orgs","repos_url":"https://api.github.com/users/GregoireH/repos","events_url":"https://api.github.com/users/GregoireH/events{/privacy}","received_events_url":"https://api.github.com/users/GregoireH/received_events","type":"User","site_admin":false},{"login":"Spyroth","id":8477986,"avatar_url":"https://avatars.githubusercontent.com/u/8477986?v=3","gravatar_id":"","url":"https://api.github.com/users/Spyroth","html_url":"https://github.com/Spyroth","followers_url":"https://api.github.com/users/Spyroth/followers","following_url":"https://api.github.com/users/Spyroth/following{/other_user}","gists_url":"https://api.github.com/users/Spyroth/gists{/gist_id}","starred_url":"https://api.github.com/users/Spyroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spyroth/subscriptions","organizations_url":"https://api.github.com/users/Spyroth/orgs","repos_url":"https://api.github.com/users/Spyroth/repos","events_url":"https://api.github.com/users/Spyroth/events{/privacy}","received_events_url":"https://api.github.com/users/Spyroth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278/commits","review_comments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278/comments","review_comment_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/278/comments","statuses_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/statuses/54c7d291025422e9b125eaa4a8913dbab97ed8cb","head":{"label":"lis-epfl:dev/ins","ref":"dev/ins","sha":"54c7d291025422e9b125eaa4a8913dbab97ed8cb","user":{"login":"lis-epfl","id":4990370,"avatar_url":"https://avatars.githubusercontent.com/u/4990370?v=3","gravatar_id":"","url":"https://api.github.com/users/lis-epfl","html_url":"https://github.com/lis-epfl","followers_url":"https://api.github.com/users/lis-epfl/followers","following_url":"https://api.github.com/users/lis-epfl/following{/other_user}","gists_url":"https://api.github.com/users/lis-epfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lis-epfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lis-epfl/subscriptions","organizations_url":"https://api.github.com/users/lis-epfl/orgs","repos_url":"https://api.github.com/users/lis-epfl/repos","events_url":"https://api.github.com/users/lis-epfl/events{/privacy}","received_events_url":"https://api.github.com/users/lis-epfl/received_events","type":"Organization","site_admin":false},"repo":{"id":23586059,"name":"MAVRIC_Library","full_name":"lis-epfl/MAVRIC_Library","owner":{"login":"lis-epfl","id":4990370,"avatar_url":"https://avatars.githubusercontent.com/u/4990370?v=3","gravatar_id":"","url":"https://api.github.com/users/lis-epfl","html_url":"https://github.com/lis-epfl","followers_url":"https://api.github.com/users/lis-epfl/followers","following_url":"https://api.github.com/users/lis-epfl/following{/other_user}","gists_url":"https://api.github.com/users/lis-epfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lis-epfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lis-epfl/subscriptions","organizations_url":"https://api.github.com/users/lis-epfl/orgs","repos_url":"https://api.github.com/users/lis-epfl/repos","events_url":"https://api.github.com/users/lis-epfl/events{/privacy}","received_events_url":"https://api.github.com/users/lis-epfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lis-epfl/MAVRIC_Library","description":"","fork":false,"url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library","forks_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/forks","keys_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/teams","hooks_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/hooks","issue_events_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/events{/number}","events_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/events","assignees_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/assignees{/user}","branches_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/branches{/branch}","tags_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/tags","blobs_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/statuses/{sha}","languages_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/languages","stargazers_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/stargazers","contributors_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/contributors","subscribers_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/subscribers","subscription_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/subscription","commits_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/contents/{+path}","compare_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/merges","archive_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/downloads","issues_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues{/number}","pulls_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls{/number}","milestones_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/milestones{/number}","notifications_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/labels{/name}","releases_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/releases{/id}","deployments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/deployments","created_at":"2014-09-02T16:19:00Z","updated_at":"2016-07-12T10:26:48Z","pushed_at":"2016-07-18T16:11:25Z","git_url":"git://github.com/lis-epfl/MAVRIC_Library.git","ssh_url":"git@github.com:lis-epfl/MAVRIC_Library.git","clone_url":"https://github.com/lis-epfl/MAVRIC_Library.git","svn_url":"https://github.com/lis-epfl/MAVRIC_Library","homepage":null,"size":353295,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"lis-epfl:master","ref":"master","sha":"ed1aa2993f78f6d71c4c54aaa5e008571a0a23f1","user":{"login":"lis-epfl","id":4990370,"avatar_url":"https://avatars.githubusercontent.com/u/4990370?v=3","gravatar_id":"","url":"https://api.github.com/users/lis-epfl","html_url":"https://github.com/lis-epfl","followers_url":"https://api.github.com/users/lis-epfl/followers","following_url":"https://api.github.com/users/lis-epfl/following{/other_user}","gists_url":"https://api.github.com/users/lis-epfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lis-epfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lis-epfl/subscriptions","organizations_url":"https://api.github.com/users/lis-epfl/orgs","repos_url":"https://api.github.com/users/lis-epfl/repos","events_url":"https://api.github.com/users/lis-epfl/events{/privacy}","received_events_url":"https://api.github.com/users/lis-epfl/received_events","type":"Organization","site_admin":false},"repo":{"id":23586059,"name":"MAVRIC_Library","full_name":"lis-epfl/MAVRIC_Library","owner":{"login":"lis-epfl","id":4990370,"avatar_url":"https://avatars.githubusercontent.com/u/4990370?v=3","gravatar_id":"","url":"https://api.github.com/users/lis-epfl","html_url":"https://github.com/lis-epfl","followers_url":"https://api.github.com/users/lis-epfl/followers","following_url":"https://api.github.com/users/lis-epfl/following{/other_user}","gists_url":"https://api.github.com/users/lis-epfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lis-epfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lis-epfl/subscriptions","organizations_url":"https://api.github.com/users/lis-epfl/orgs","repos_url":"https://api.github.com/users/lis-epfl/repos","events_url":"https://api.github.com/users/lis-epfl/events{/privacy}","received_events_url":"https://api.github.com/users/lis-epfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lis-epfl/MAVRIC_Library","description":"","fork":false,"url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library","forks_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/forks","keys_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/teams","hooks_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/hooks","issue_events_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/events{/number}","events_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/events","assignees_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/assignees{/user}","branches_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/branches{/branch}","tags_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/tags","blobs_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/statuses/{sha}","languages_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/languages","stargazers_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/stargazers","contributors_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/contributors","subscribers_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/subscribers","subscription_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/subscription","commits_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/contents/{+path}","compare_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/merges","archive_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/downloads","issues_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues{/number}","pulls_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls{/number}","milestones_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/milestones{/number}","notifications_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/labels{/name}","releases_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/releases{/id}","deployments_url":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/deployments","created_at":"2014-09-02T16:19:00Z","updated_at":"2016-07-12T10:26:48Z","pushed_at":"2016-07-18T16:11:25Z","git_url":"git://github.com/lis-epfl/MAVRIC_Library.git","ssh_url":"git@github.com:lis-epfl/MAVRIC_Library.git","clone_url":"https://github.com/lis-epfl/MAVRIC_Library.git","svn_url":"https://github.com/lis-epfl/MAVRIC_Library","homepage":null,"size":353295,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278"},"html":{"href":"https://github.com/lis-epfl/MAVRIC_Library/pull/278"},"issue":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/278"},"comments":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/lis-epfl/MAVRIC_Library/statuses/54c7d291025422e9b125eaa4a8913dbab97ed8cb"}}}}
{"actor":{"display_login":"jlecoeur"}}