{"action":"opened","number":1678,"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1678","id":93624965,"html_url":"https://github.com/javaslang/javaslang/pull/1678","diff_url":"https://github.com/javaslang/javaslang/pull/1678.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1678.patch","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1678","number":1678,"state":"open","locked":false,"title":"noticed that the ifPresent test sections duplicates the forEach tests","user":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"body":"it seems javaslang used to have a `ifPresent` method on `Option` and it was removed or renamed to `forEach`.\r\n\r\nNow the test section for `ifPresent` duplicates exactly the one for `forEach` which is a little lower in the same file:\r\nhttps://github.com/javaslang/javaslang/blob/master/javaslang/src/test/java/javaslang/control/OptionTest.java#L350-L364\r\n\r\nso this PR removes the now duplicate tests.","created_at":"2016-11-14T18:54:39Z","updated_at":"2016-11-14T18:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d961f722a6cdd0646f069bbd5fd2971733ba5130","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1678/comments","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/49bc6df086b65af49039fcd7e9073218faeef989","head":{"label":"emmanueltouzery:remove_duplicate_tests","ref":"remove_duplicate_tests","sha":"49bc6df086b65af49039fcd7e9073218faeef989","user":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"repo":{"id":60285996,"name":"javaslang","full_name":"emmanueltouzery/javaslang","owner":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emmanueltouzery/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":true,"url":"https://api.github.com/repos/emmanueltouzery/javaslang","forks_url":"https://api.github.com/repos/emmanueltouzery/javaslang/forks","keys_url":"https://api.github.com/repos/emmanueltouzery/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmanueltouzery/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmanueltouzery/javaslang/teams","hooks_url":"https://api.github.com/repos/emmanueltouzery/javaslang/hooks","issue_events_url":"https://api.github.com/repos/emmanueltouzery/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/emmanueltouzery/javaslang/events","assignees_url":"https://api.github.com/repos/emmanueltouzery/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/emmanueltouzery/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/emmanueltouzery/javaslang/tags","blobs_url":"https://api.github.com/repos/emmanueltouzery/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmanueltouzery/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmanueltouzery/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmanueltouzery/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmanueltouzery/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/emmanueltouzery/javaslang/languages","stargazers_url":"https://api.github.com/repos/emmanueltouzery/javaslang/stargazers","contributors_url":"https://api.github.com/repos/emmanueltouzery/javaslang/contributors","subscribers_url":"https://api.github.com/repos/emmanueltouzery/javaslang/subscribers","subscription_url":"https://api.github.com/repos/emmanueltouzery/javaslang/subscription","commits_url":"https://api.github.com/repos/emmanueltouzery/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmanueltouzery/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmanueltouzery/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmanueltouzery/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/emmanueltouzery/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/emmanueltouzery/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmanueltouzery/javaslang/merges","archive_url":"https://api.github.com/repos/emmanueltouzery/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmanueltouzery/javaslang/downloads","issues_url":"https://api.github.com/repos/emmanueltouzery/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/emmanueltouzery/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/emmanueltouzery/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/emmanueltouzery/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmanueltouzery/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/emmanueltouzery/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/emmanueltouzery/javaslang/deployments","created_at":"2016-06-02T18:01:50Z","updated_at":"2016-06-02T18:01:52Z","pushed_at":"2016-11-14T18:52:37Z","git_url":"git://github.com/emmanueltouzery/javaslang.git","ssh_url":"git@github.com:emmanueltouzery/javaslang.git","clone_url":"https://github.com/emmanueltouzery/javaslang.git","svn_url":"https://github.com/emmanueltouzery/javaslang","homepage":"http://javaslang.io","size":12873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"javaslang:master","ref":"master","sha":"9955d594d2e96889fafa903335da7d9392ad71b3","user":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"repo":{"id":16378879,"name":"javaslang","full_name":"javaslang/javaslang","owner":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/javaslang/javaslang","description":"Javaslang is an object-functional language extension to Java 8, which aims to reduce the lines of code and increase code quality. It provides persistent collections, functional abstractions for error handling, concurrent programming, pattern matching and much more.  Javaslang fuses the power of object-oriented programming with the elegance and robustness of functional programming. The most interesting part is a feature-rich, persistent collection library that smoothly integrates with Java's standard collections.","fork":false,"url":"https://api.github.com/repos/javaslang/javaslang","forks_url":"https://api.github.com/repos/javaslang/javaslang/forks","keys_url":"https://api.github.com/repos/javaslang/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaslang/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaslang/javaslang/teams","hooks_url":"https://api.github.com/repos/javaslang/javaslang/hooks","issue_events_url":"https://api.github.com/repos/javaslang/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/javaslang/javaslang/events","assignees_url":"https://api.github.com/repos/javaslang/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/javaslang/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/javaslang/javaslang/tags","blobs_url":"https://api.github.com/repos/javaslang/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaslang/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaslang/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaslang/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/javaslang/javaslang/languages","stargazers_url":"https://api.github.com/repos/javaslang/javaslang/stargazers","contributors_url":"https://api.github.com/repos/javaslang/javaslang/contributors","subscribers_url":"https://api.github.com/repos/javaslang/javaslang/subscribers","subscription_url":"https://api.github.com/repos/javaslang/javaslang/subscription","commits_url":"https://api.github.com/repos/javaslang/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaslang/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaslang/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaslang/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaslang/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/javaslang/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaslang/javaslang/merges","archive_url":"https://api.github.com/repos/javaslang/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaslang/javaslang/downloads","issues_url":"https://api.github.com/repos/javaslang/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/javaslang/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/javaslang/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/javaslang/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaslang/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/javaslang/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/javaslang/javaslang/deployments","created_at":"2014-01-30T14:07:25Z","updated_at":"2016-11-14T16:11:23Z","pushed_at":"2016-11-14T18:54:39Z","git_url":"git://github.com/javaslang/javaslang.git","ssh_url":"git@github.com:javaslang/javaslang.git","clone_url":"https://github.com/javaslang/javaslang.git","svn_url":"https://github.com/javaslang/javaslang","homepage":"http://javaslang.io","size":14987,"stargazers_count":1300,"watchers_count":1300,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":93,"forks":156,"open_issues":93,"watchers":1300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1678"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1678"},"issue":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1678"},"comments":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/javaslang/javaslang/statuses/49bc6df086b65af49039fcd7e9073218faeef989"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":16,"changed_files":1}}
{"actor":{"display_login":"emmanueltouzery"}}