{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/bess/pulls/comments/91395466","pull_request_review_id":11903829,"id":91395466,"diff_hunk":"@@ -12,7 +12,7 @@\n #include \"task.h\"\n \n static inline void set_cmd_response_error(pb_cmd_response_t *response,\n-                                          const pb_error_t &error) {\n+    const pb_error_t &error) {","path":"core/module.h","position":5,"original_position":5,"commit_id":"c2fd260b5aeeb47ff4f4468c9c4682c3b9284abe","original_commit_id":"c2fd260b5aeeb47ff4f4468c9c4682c3b9284abe","user":{"login":"justinemarie","id":80406,"avatar_url":"https://avatars.githubusercontent.com/u/80406?v=3","gravatar_id":"","url":"https://api.github.com/users/justinemarie","html_url":"https://github.com/justinemarie","followers_url":"https://api.github.com/users/justinemarie/followers","following_url":"https://api.github.com/users/justinemarie/following{/other_user}","gists_url":"https://api.github.com/users/justinemarie/gists{/gist_id}","starred_url":"https://api.github.com/users/justinemarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinemarie/subscriptions","organizations_url":"https://api.github.com/users/justinemarie/orgs","repos_url":"https://api.github.com/users/justinemarie/repos","events_url":"https://api.github.com/users/justinemarie/events{/privacy}","received_events_url":"https://api.github.com/users/justinemarie/received_events","type":"User","site_admin":false},"body":"I ran clang-format -- is that no longer recommended?","created_at":"2016-12-07T21:49:11Z","updated_at":"2016-12-07T21:49:11Z","html_url":"https://github.com/NetSys/bess/pull/158#discussion_r91395466","pull_request_url":"https://api.github.com/repos/NetSys/bess/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments/91395466"},"html":{"href":"https://github.com/NetSys/bess/pull/158#discussion_r91395466"},"pull_request":{"href":"https://api.github.com/repos/NetSys/bess/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/bess/pulls/158","id":97012192,"html_url":"https://github.com/NetSys/bess/pull/158","diff_url":"https://github.com/NetSys/bess/pull/158.diff","patch_url":"https://github.com/NetSys/bess/pull/158.patch","issue_url":"https://api.github.com/repos/NetSys/bess/issues/158","number":158,"state":"open","locked":false,"title":"call modules recursively","user":{"login":"justinemarie","id":80406,"avatar_url":"https://avatars.githubusercontent.com/u/80406?v=3","gravatar_id":"","url":"https://api.github.com/users/justinemarie","html_url":"https://github.com/justinemarie","followers_url":"https://api.github.com/users/justinemarie/followers","following_url":"https://api.github.com/users/justinemarie/following{/other_user}","gists_url":"https://api.github.com/users/justinemarie/gists{/gist_id}","starred_url":"https://api.github.com/users/justinemarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinemarie/subscriptions","organizations_url":"https://api.github.com/users/justinemarie/orgs","repos_url":"https://api.github.com/users/justinemarie/repos","events_url":"https://api.github.com/users/justinemarie/events{/privacy}","received_events_url":"https://api.github.com/users/justinemarie/received_events","type":"User","site_admin":false},"body":"This switches back to calling modules recursively to improve throughput.","created_at":"2016-12-07T21:36:27Z","updated_at":"2016-12-07T21:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f81d4cea4d302e7506eb1620ed1d917e4a8c8cb3","assignee":{"login":"barath","id":605050,"avatar_url":"https://avatars.githubusercontent.com/u/605050?v=3","gravatar_id":"","url":"https://api.github.com/users/barath","html_url":"https://github.com/barath","followers_url":"https://api.github.com/users/barath/followers","following_url":"https://api.github.com/users/barath/following{/other_user}","gists_url":"https://api.github.com/users/barath/gists{/gist_id}","starred_url":"https://api.github.com/users/barath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barath/subscriptions","organizations_url":"https://api.github.com/users/barath/orgs","repos_url":"https://api.github.com/users/barath/repos","events_url":"https://api.github.com/users/barath/events{/privacy}","received_events_url":"https://api.github.com/users/barath/received_events","type":"User","site_admin":false},"assignees":[{"login":"barath","id":605050,"avatar_url":"https://avatars.githubusercontent.com/u/605050?v=3","gravatar_id":"","url":"https://api.github.com/users/barath","html_url":"https://github.com/barath","followers_url":"https://api.github.com/users/barath/followers","following_url":"https://api.github.com/users/barath/following{/other_user}","gists_url":"https://api.github.com/users/barath/gists{/gist_id}","starred_url":"https://api.github.com/users/barath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barath/subscriptions","organizations_url":"https://api.github.com/users/barath/orgs","repos_url":"https://api.github.com/users/barath/repos","events_url":"https://api.github.com/users/barath/events{/privacy}","received_events_url":"https://api.github.com/users/barath/received_events","type":"User","site_admin":false},{"login":"sangjinhan","id":1916976,"avatar_url":"https://avatars.githubusercontent.com/u/1916976?v=3","gravatar_id":"","url":"https://api.github.com/users/sangjinhan","html_url":"https://github.com/sangjinhan","followers_url":"https://api.github.com/users/sangjinhan/followers","following_url":"https://api.github.com/users/sangjinhan/following{/other_user}","gists_url":"https://api.github.com/users/sangjinhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sangjinhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangjinhan/subscriptions","organizations_url":"https://api.github.com/users/sangjinhan/orgs","repos_url":"https://api.github.com/users/sangjinhan/repos","events_url":"https://api.github.com/users/sangjinhan/events{/privacy}","received_events_url":"https://api.github.com/users/sangjinhan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/bess/pulls/158/commits","review_comments_url":"https://api.github.com/repos/NetSys/bess/pulls/158/comments","review_comment_url":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/bess/issues/158/comments","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/c2fd260b5aeeb47ff4f4468c9c4682c3b9284abe","head":{"label":"justinemarie:recursive_module_invocation","ref":"recursive_module_invocation","sha":"c2fd260b5aeeb47ff4f4468c9c4682c3b9284abe","user":{"login":"justinemarie","id":80406,"avatar_url":"https://avatars.githubusercontent.com/u/80406?v=3","gravatar_id":"","url":"https://api.github.com/users/justinemarie","html_url":"https://github.com/justinemarie","followers_url":"https://api.github.com/users/justinemarie/followers","following_url":"https://api.github.com/users/justinemarie/following{/other_user}","gists_url":"https://api.github.com/users/justinemarie/gists{/gist_id}","starred_url":"https://api.github.com/users/justinemarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinemarie/subscriptions","organizations_url":"https://api.github.com/users/justinemarie/orgs","repos_url":"https://api.github.com/users/justinemarie/repos","events_url":"https://api.github.com/users/justinemarie/events{/privacy}","received_events_url":"https://api.github.com/users/justinemarie/received_events","type":"User","site_admin":false},"repo":{"id":71384373,"name":"bess","full_name":"justinemarie/bess","owner":{"login":"justinemarie","id":80406,"avatar_url":"https://avatars.githubusercontent.com/u/80406?v=3","gravatar_id":"","url":"https://api.github.com/users/justinemarie","html_url":"https://github.com/justinemarie","followers_url":"https://api.github.com/users/justinemarie/followers","following_url":"https://api.github.com/users/justinemarie/following{/other_user}","gists_url":"https://api.github.com/users/justinemarie/gists{/gist_id}","starred_url":"https://api.github.com/users/justinemarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinemarie/subscriptions","organizations_url":"https://api.github.com/users/justinemarie/orgs","repos_url":"https://api.github.com/users/justinemarie/repos","events_url":"https://api.github.com/users/justinemarie/events{/privacy}","received_events_url":"https://api.github.com/users/justinemarie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinemarie/bess","description":"BESS: Berkeley Extensible Software Switch","fork":true,"url":"https://api.github.com/repos/justinemarie/bess","forks_url":"https://api.github.com/repos/justinemarie/bess/forks","keys_url":"https://api.github.com/repos/justinemarie/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinemarie/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinemarie/bess/teams","hooks_url":"https://api.github.com/repos/justinemarie/bess/hooks","issue_events_url":"https://api.github.com/repos/justinemarie/bess/issues/events{/number}","events_url":"https://api.github.com/repos/justinemarie/bess/events","assignees_url":"https://api.github.com/repos/justinemarie/bess/assignees{/user}","branches_url":"https://api.github.com/repos/justinemarie/bess/branches{/branch}","tags_url":"https://api.github.com/repos/justinemarie/bess/tags","blobs_url":"https://api.github.com/repos/justinemarie/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinemarie/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinemarie/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinemarie/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinemarie/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/justinemarie/bess/languages","stargazers_url":"https://api.github.com/repos/justinemarie/bess/stargazers","contributors_url":"https://api.github.com/repos/justinemarie/bess/contributors","subscribers_url":"https://api.github.com/repos/justinemarie/bess/subscribers","subscription_url":"https://api.github.com/repos/justinemarie/bess/subscription","commits_url":"https://api.github.com/repos/justinemarie/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinemarie/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinemarie/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinemarie/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinemarie/bess/contents/{+path}","compare_url":"https://api.github.com/repos/justinemarie/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinemarie/bess/merges","archive_url":"https://api.github.com/repos/justinemarie/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinemarie/bess/downloads","issues_url":"https://api.github.com/repos/justinemarie/bess/issues{/number}","pulls_url":"https://api.github.com/repos/justinemarie/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/justinemarie/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/justinemarie/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinemarie/bess/labels{/name}","releases_url":"https://api.github.com/repos/justinemarie/bess/releases{/id}","deployments_url":"https://api.github.com/repos/justinemarie/bess/deployments","created_at":"2016-10-19T17:51:06Z","updated_at":"2016-10-19T17:51:08Z","pushed_at":"2016-12-07T21:35:50Z","git_url":"git://github.com/justinemarie/bess.git","ssh_url":"git@github.com:justinemarie/bess.git","clone_url":"https://github.com/justinemarie/bess.git","svn_url":"https://github.com/justinemarie/bess","homepage":"","size":4506,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"NetSys:c++","ref":"c++","sha":"1654f9eb909ac7b07c94b88475db06a35174af0f","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2016-11-17T03:04:44Z","pushed_at":"2016-12-07T21:36:28Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":4861,"stargazers_count":45,"watchers_count":45,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":4,"forks":26,"open_issues":4,"watchers":45,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/158"},"html":{"href":"https://github.com/NetSys/bess/pull/158"},"issue":{"href":"https://api.github.com/repos/NetSys/bess/issues/158"},"comments":{"href":"https://api.github.com/repos/NetSys/bess/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/bess/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/bess/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/bess/statuses/c2fd260b5aeeb47ff4f4468c9c4682c3b9284abe"}}}}
{"actor":{"display_login":"justinemarie"}}