{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1219","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1219/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1219/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1219/events","html_url":"https://github.com/solidusio/solidus/pull/1219","id":158427095,"number":1219,"title":"Failing spec for change in Coordinator behavior","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/solidusio/solidus/milestones/6","html_url":"https://github.com/solidusio/solidus/milestones/1.3.0","labels_url":"https://api.github.com/repos/solidusio/solidus/milestones/6/labels","id":1490610,"number":6,"title":"1.3.0","description":"","creator":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":14,"state":"open","created_at":"2016-01-07T23:24:00Z","updated_at":"2016-06-03T18:56:55Z","due_on":"2016-05-01T07:00:00Z","closed_at":null},"comments":5,"created_at":"2016-06-03T18:31:11Z","updated_at":"2016-06-06T17:16:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1219","html_url":"https://github.com/solidusio/solidus/pull/1219","diff_url":"https://github.com/solidusio/solidus/pull/1219.diff","patch_url":"https://github.com/solidusio/solidus/pull/1219.patch"},"body":"I'm not sure whether I think this is a bug or not, but it was unexpected for\r\nme and broke how we're using Coordinator in our app.  This spec passes\r\nin Solidus 1.2.\r\n\r\nIn our app we are using Coordinator to generate tentative shipments\r\nwithout necessarily using those shipments or attaching them to the\r\norder.\r\n\r\nBut in Solidus v1.3 things have changed so that this has a side effect:\r\n\r\nEdit: See @jhawthorn's comment below.\r\n\r\n~~In Solidus 1.3 one of my own commits updated Package so that\r\ngenerated shipments get attached to the order right away:~~\r\n~~https://github.com/solidusio/solidus/commit/796ed7f#diff-e742b21f326403fa3a2b3553e15874ba~~\r\n\r\n~~This was to enable tax calculations on shipments and shipping rates.\r\n(See [this comment thread in PR 904](https://github.com/solidusio/solidus/pull/904/#discussion-diff-54887938).)~~\r\n\r\nThe side effect is that if you call `Coordinator.new(order).shipments` and\r\nthen happen to call `order.update!` (or `order.save!`, etc) later then the\r\nnew shipments will be saved and attached to the order.\r\n\r\nIt feels like `Coordinator#shipments` shouldn't mutate the order, and if so\r\nthen this is probably a bug.  If we don't think it's a bug then we at least\r\nprobably need to add a note to the method and the changelog about this\r\nside effect.\r\n\r\nThoughts?\r\n\r\nJust a note - in Solidus 1.2 `order.update!` would not have triggered\r\nthis issue since it used `update_columns` instead of `save`.  But\r\nusing `save` is a definite improvement, so no complaints about that,\r\njust a note that it's an additional avenue to trigger this in 1.3.\r\n"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/224024814","html_url":"https://github.com/solidusio/solidus/pull/1219#issuecomment-224024814","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1219","id":224024814,"user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T17:16:10Z","updated_at":"2016-06-06T17:16:10Z","body":"@jordan-brough could you swap the order of these commits? This way all commits are passing.\r\n\r\nOther than that :+1:"}}
{"actor":{"display_login":"jhawthorn"}}