{"action":"created","issue":{"url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/111","repository_url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS","labels_url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/111/comments","events_url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/111/events","html_url":"https://github.com/OpenBCI/OpenBCI_NodeJS/pull/111","id":184656744,"number":111,"title":"Fix connection-related leaks and inconsistencies","user":{"login":"baffo32","id":240981,"avatar_url":"https://avatars.githubusercontent.com/u/240981?v=3","gravatar_id":"","url":"https://api.github.com/users/baffo32","html_url":"https://github.com/baffo32","followers_url":"https://api.github.com/users/baffo32/followers","following_url":"https://api.github.com/users/baffo32/following{/other_user}","gists_url":"https://api.github.com/users/baffo32/gists{/gist_id}","starred_url":"https://api.github.com/users/baffo32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baffo32/subscriptions","organizations_url":"https://api.github.com/users/baffo32/orgs","repos_url":"https://api.github.com/users/baffo32/repos","events_url":"https://api.github.com/users/baffo32/events{/privacy}","received_events_url":"https://api.github.com/users/baffo32/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-10-22T22:02:25Z","updated_at":"2016-10-30T15:22:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/pulls/111","html_url":"https://github.com/OpenBCI/OpenBCI_NodeJS/pull/111","diff_url":"https://github.com/OpenBCI/OpenBCI_NodeJS/pull/111.diff","patch_url":"https://github.com/OpenBCI/OpenBCI_NodeJS/pull/111.patch"},"body":"Fixes #92\r\n\r\nNotable changes:\r\n- Added a utils test file that tracks `setTimeout()` and `setInterval()` uses that are never `clear`ed.\r\n- Changed `.connected` to `.isConnected()` so that it may be part of the public API\r\n- Paired uses of `.sntpStart` with matching `.sntpStop`\r\n- Raise a few more errors in places where exceptional things happen\r\n- Handled all forms of disconnection and cleaned up state "},"comment":{"url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/comments/257157418","html_url":"https://github.com/OpenBCI/OpenBCI_NodeJS/pull/111#issuecomment-257157418","issue_url":"https://api.github.com/repos/OpenBCI/OpenBCI_NodeJS/issues/111","id":257157418,"user":{"login":"aj-ptw","id":11437469,"avatar_url":"https://avatars.githubusercontent.com/u/11437469?v=3","gravatar_id":"","url":"https://api.github.com/users/aj-ptw","html_url":"https://github.com/aj-ptw","followers_url":"https://api.github.com/users/aj-ptw/followers","following_url":"https://api.github.com/users/aj-ptw/following{/other_user}","gists_url":"https://api.github.com/users/aj-ptw/gists{/gist_id}","starred_url":"https://api.github.com/users/aj-ptw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aj-ptw/subscriptions","organizations_url":"https://api.github.com/users/aj-ptw/orgs","repos_url":"https://api.github.com/users/aj-ptw/repos","events_url":"https://api.github.com/users/aj-ptw/events{/privacy}","received_events_url":"https://api.github.com/users/aj-ptw/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T15:22:08Z","updated_at":"2016-10-30T15:22:08Z","body":"> which revealed a lot of them, all of which I plugged. Any thoughts?\r\n\r\neverything I'm seeing seems to only drastically increase the quality of promise test coverage. Looks good, I don't think it's decrememnting quality of coverage. Not too sure how to verify this though. I'm happy to merge this with 1.4.0 and begin testing it"}}
{"actor":{"display_login":"aj-ptw"}}