{"action":"created","issue":{"url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/10","repository_url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf","labels_url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/10/comments","events_url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/10/events","html_url":"https://github.com/DOREMUS-ANR/marc2rdf/issues/10","id":157711434,"number":10,"title":"Improvements on genres vocabulary matching","user":{"login":"pasqLisena","id":4126222,"avatar_url":"https://avatars.githubusercontent.com/u/4126222?v=3","gravatar_id":"","url":"https://api.github.com/users/pasqLisena","html_url":"https://github.com/pasqLisena","followers_url":"https://api.github.com/users/pasqLisena/followers","following_url":"https://api.github.com/users/pasqLisena/following{/other_user}","gists_url":"https://api.github.com/users/pasqLisena/gists{/gist_id}","starred_url":"https://api.github.com/users/pasqLisena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasqLisena/subscriptions","organizations_url":"https://api.github.com/users/pasqLisena/orgs","repos_url":"https://api.github.com/users/pasqLisena/repos","events_url":"https://api.github.com/users/pasqLisena/events{/privacy}","received_events_url":"https://api.github.com/users/pasqLisena/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"pasqLisena","id":4126222,"avatar_url":"https://avatars.githubusercontent.com/u/4126222?v=3","gravatar_id":"","url":"https://api.github.com/users/pasqLisena","html_url":"https://github.com/pasqLisena","followers_url":"https://api.github.com/users/pasqLisena/followers","following_url":"https://api.github.com/users/pasqLisena/following{/other_user}","gists_url":"https://api.github.com/users/pasqLisena/gists{/gist_id}","starred_url":"https://api.github.com/users/pasqLisena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasqLisena/subscriptions","organizations_url":"https://api.github.com/users/pasqLisena/orgs","repos_url":"https://api.github.com/users/pasqLisena/repos","events_url":"https://api.github.com/users/pasqLisena/events{/privacy}","received_events_url":"https://api.github.com/users/pasqLisena/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-31T16:14:02Z","updated_at":"2016-06-01T07:05:41Z","closed_at":null,"body":"How it is working now:\r\n\r\n1. Search for a genre code in the MARC file  ( F22_SelfContainedExpression.java ), e.g. ```mld```\r\n2. Find the match in [GenresBNF.xlsx](../blob/master/src/main/resources/GenresBNF.xlsx), e.g. ```melodie@fr```\r\n3. Add temporary the property ```U12_has_genre``` with the literal as value\r\n4. After the RDF creation, the \"string2uri\" part searches for the literal string in the [vocabulary](https://github.com/DOREMUS-ANR/knowledge-base/blob/master/vocabularies/genre.ttl)\r\n5. The literal is replaced with the URI defined in SKOS, e.g. <http://data.doremus.org/vocabulary/genre/mld>\r\n\r\n### Limits\r\n1. We are doing a double jump (from code to label, then again to code)\r\n2. Some label are shared between different genres ... e.g. ```operetta@it``` can fall both in ```ops``` and ```opt```\r\n3. Values that are not in the excel file can be discarded, but the code could be in the vocabulary. It happens very often with ```zz#``` = ```other form@en```\r\n4. Do it afterwards could have unexpected situation: what happens if the title of a work is exactly ```Concerto```? (@rtroncy I wish to know also your opinion on this :) )\r\n\r\nNote that the vocabulary contains the whole GenresBNF.xlsx, GenresIAML.xlsx and the other [AIBM genres](http://www.urfm.braidense.it/risorse/forme_query_en.php).\r\n\r\n### My proposal\r\nUse the vocabulary directly at step 2. (instead of GenresBNF.xlsx) and replace directly with the final URI.\r\n\r\n-------------------\r\n**Related question** for @marie-ototoi The [`uuu` or \"unknow\"](https://github.com/DOREMUS-ANR/knowledge-base/blob/master/vocabularies/genre.ttl#L3600) is conceptually the same of `###` or ```non renseigné```?\r\n* [ ] If yes, we can merge these values.\r\n* [ ] If not, we should find another code for the latter (better avoid the `#`)."},"comment":{"url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/comments/222910521","html_url":"https://github.com/DOREMUS-ANR/marc2rdf/issues/10#issuecomment-222910521","issue_url":"https://api.github.com/repos/DOREMUS-ANR/marc2rdf/issues/10","id":222910521,"user":{"login":"pierrechoffe","id":3597680,"avatar_url":"https://avatars.githubusercontent.com/u/3597680?v=3","gravatar_id":"","url":"https://api.github.com/users/pierrechoffe","html_url":"https://github.com/pierrechoffe","followers_url":"https://api.github.com/users/pierrechoffe/followers","following_url":"https://api.github.com/users/pierrechoffe/following{/other_user}","gists_url":"https://api.github.com/users/pierrechoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/pierrechoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierrechoffe/subscriptions","organizations_url":"https://api.github.com/users/pierrechoffe/orgs","repos_url":"https://api.github.com/users/pierrechoffe/repos","events_url":"https://api.github.com/users/pierrechoffe/events{/privacy}","received_events_url":"https://api.github.com/users/pierrechoffe/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T07:05:41Z","updated_at":"2016-06-01T07:05:41Z","body":"@pasqLisena @marie-ototoi\r\nthanks for this !\r\nuu and zz have different labels, but very often they are used for the same \"idea\" i.e. \"i don't know how to categorize this work\". Therefore I suggest they could be merged, and they also are (more or less) equivalent to \"non renseigné\". They are used a lot for contemporary music because genres can be somewhat fuzzy.\r\nregarding operetta : this one is opt and definitely not ops (which is opera seria), so they should not be merged.\r\n"}}
{"actor":{"display_login":"pierrechoffe"}}