{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/84811516","pull_request_review_id":5565078,"id":84811516,"diff_hunk":"@@ -0,0 +1,58 @@\n+apiVersion: extensions/v1beta1\n+kind: Deployment\n+metadata:\n+  name: traefik-ingress-controller\n+  labels:\n+    k8s-app: traefik-ingress-controller\n+spec:\n+  replicas: 1\n+  selector:\n+    matchLabels:\n+      k8s-app: traefik-ingress-controller\n+  template:\n+    metadata:\n+      labels:\n+        k8s-app: traefik-ingress-controller\n+        version: {{ .Chart.Version }}\n+    spec:\n+      terminationGracePeriodSeconds: 60\n+      containers:\n+      - image: traefik:v{{ .Values.imageTag }}\n+        name: traefik-ingress-controller\n+        volumeMounts:\n+        - mountPath: /config\n+          name: config\n+        {{- if .Values.ssl.enabled }}\n+        - mountPath: /ssl\n+          name: ssl\n+        {{- end }}\n+        {{- if .Values.acme.enabled }}\n+        - mountPath: /acme\n+          name: acme\n+        {{- end }}\n+        ports:\n+        - containerPort: 80\n+        - containerPort: 443\n+        {{- if .Values.dashboard.enabled }}\n+        - containerPort: 8080\n+        {{- end }}\n+        args:\n+        - --configfile=/config/traefik.toml\n+      volumes:\n+      - name: config\n+        configMap:\n+          name: traefik-config\n+      {{- if .Values.ssl.enabled }}\n+      - name: ssl\n+        secret:\n+          secretName: traefik-default-cert\n+      {{- end }}\n+      {{- if .Values.acme.enabled }}\n+      - name: acme\n+      {{- if .Values.acme.persistence.enabled }}\n+        persistentVolumeClaim:","path":"incubator/traefik/templates/deployment.yaml","position":53,"original_position":53,"commit_id":"35ab9bf54482858f678af4f8c282fec448ce4646","original_commit_id":"35ab9bf54482858f678af4f8c282fec448ce4646","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars.githubusercontent.com/u/335402?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"It there value to have storage classes?","created_at":"2016-10-25T00:30:16Z","updated_at":"2016-10-25T00:30:16Z","html_url":"https://github.com/kubernetes/charts/pull/146#discussion_r84811516","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/84811516"},"html":{"href":"https://github.com/kubernetes/charts/pull/146#discussion_r84811516"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/146","id":90694817,"html_url":"https://github.com/kubernetes/charts/pull/146","diff_url":"https://github.com/kubernetes/charts/pull/146.diff","patch_url":"https://github.com/kubernetes/charts/pull/146.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/146","number":146,"state":"open","locked":false,"title":"Add chart for Traefik-based ingress controller","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-24T21:19:03Z","updated_at":"2016-10-25T00:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2bbda55d2d39d57e5990d98a9a89868c5a8349","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/146/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/146/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/146/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/35ab9bf54482858f678af4f8c282fec448ce4646","head":{"label":"krancour:traefik","ref":"traefik","sha":"35ab9bf54482858f678af4f8c282fec448ce4646","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"repo":{"id":71831940,"name":"charts","full_name":"krancour/charts","owner":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krancour/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/krancour/charts","forks_url":"https://api.github.com/repos/krancour/charts/forks","keys_url":"https://api.github.com/repos/krancour/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krancour/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krancour/charts/teams","hooks_url":"https://api.github.com/repos/krancour/charts/hooks","issue_events_url":"https://api.github.com/repos/krancour/charts/issues/events{/number}","events_url":"https://api.github.com/repos/krancour/charts/events","assignees_url":"https://api.github.com/repos/krancour/charts/assignees{/user}","branches_url":"https://api.github.com/repos/krancour/charts/branches{/branch}","tags_url":"https://api.github.com/repos/krancour/charts/tags","blobs_url":"https://api.github.com/repos/krancour/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krancour/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krancour/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/krancour/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krancour/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/krancour/charts/languages","stargazers_url":"https://api.github.com/repos/krancour/charts/stargazers","contributors_url":"https://api.github.com/repos/krancour/charts/contributors","subscribers_url":"https://api.github.com/repos/krancour/charts/subscribers","subscription_url":"https://api.github.com/repos/krancour/charts/subscription","commits_url":"https://api.github.com/repos/krancour/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/krancour/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/krancour/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/krancour/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/krancour/charts/contents/{+path}","compare_url":"https://api.github.com/repos/krancour/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krancour/charts/merges","archive_url":"https://api.github.com/repos/krancour/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krancour/charts/downloads","issues_url":"https://api.github.com/repos/krancour/charts/issues{/number}","pulls_url":"https://api.github.com/repos/krancour/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/krancour/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/krancour/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krancour/charts/labels{/name}","releases_url":"https://api.github.com/repos/krancour/charts/releases{/id}","deployments_url":"https://api.github.com/repos/krancour/charts/deployments","created_at":"2016-10-24T21:03:15Z","updated_at":"2016-10-24T21:03:17Z","pushed_at":"2016-10-24T23:27:46Z","git_url":"git://github.com/krancour/charts.git","ssh_url":"git@github.com:krancour/charts.git","clone_url":"https://github.com/krancour/charts.git","svn_url":"https://github.com/krancour/charts","homepage":"","size":277,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4950785264edaab339708f4b40dc0a61486e6cd4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-10-24T18:55:09Z","pushed_at":"2016-10-25T00:30:28Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":650,"stargazers_count":100,"watchers_count":100,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":27,"forks":69,"open_issues":27,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/146"},"html":{"href":"https://github.com/kubernetes/charts/pull/146"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/146"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/35ab9bf54482858f678af4f8c282fec448ce4646"}}}}
{"actor":{"display_login":"chrislovecnm"}}