{"action":"created","issue":{"url":"https://api.github.com/repos/wout/svg.js/issues/536","repository_url":"https://api.github.com/repos/wout/svg.js","labels_url":"https://api.github.com/repos/wout/svg.js/issues/536/labels{/name}","comments_url":"https://api.github.com/repos/wout/svg.js/issues/536/comments","events_url":"https://api.github.com/repos/wout/svg.js/issues/536/events","html_url":"https://github.com/wout/svg.js/pull/536","id":183306337,"number":536,"title":"Make SVG.FX.speed act more like others animations libraries","user":{"login":"RmiTtro","id":21284258,"avatar_url":"https://avatars.githubusercontent.com/u/21284258?v=3","gravatar_id":"","url":"https://api.github.com/users/RmiTtro","html_url":"https://github.com/RmiTtro","followers_url":"https://api.github.com/users/RmiTtro/followers","following_url":"https://api.github.com/users/RmiTtro/following{/other_user}","gists_url":"https://api.github.com/users/RmiTtro/gists{/gist_id}","starred_url":"https://api.github.com/users/RmiTtro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RmiTtro/subscriptions","organizations_url":"https://api.github.com/users/RmiTtro/orgs","repos_url":"https://api.github.com/users/RmiTtro/repos","events_url":"https://api.github.com/users/RmiTtro/events{/privacy}","received_events_url":"https://api.github.com/users/RmiTtro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-17T01:14:22Z","updated_at":"2016-10-17T20:45:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wout/svg.js/pulls/536","html_url":"https://github.com/wout/svg.js/pull/536","diff_url":"https://github.com/wout/svg.js/pull/536.diff","patch_url":"https://github.com/wout/svg.js/pull/536.patch"},"body":"This pull request makes the speed method of the FX module act more like others animations libraries.\r\n\r\nFor example, a call .speed(2) would make the animation 2 times faster.\r\nIf you then call .speed(4), this would make the animation 4 times faster.\r\nAnd a call .speed(1) would make it go back to normal speed.\r\n\r\nThe current implementation is more like this:\r\nA call .speed(2) would make the animation 2 times faster.\r\nIf you then call .speed(4), this would make the animation 8 times faster.\r\nAnd a call .speed(1) would have no effect (the animation stay 8 times faster).\r\n\r\nThis change would not be backward compatible since it modifies the way the method speed work. Then again, since this method is kind of hidden, it must not be widely used. At the very least, this change could be considered for the next version of this library.\r\n\r\nIf you decide to refuse this pull request, be sure to check my other pull request #535 that correct some of the bugs with the current implementation of the method speed.\r\n\r\nThx for reading this long comment!\r\n"},"comment":{"url":"https://api.github.com/repos/wout/svg.js/issues/comments/254328590","html_url":"https://github.com/wout/svg.js/pull/536#issuecomment-254328590","issue_url":"https://api.github.com/repos/wout/svg.js/issues/536","id":254328590,"user":{"login":"Fuzzyma","id":3540542,"avatar_url":"https://avatars.githubusercontent.com/u/3540542?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuzzyma","html_url":"https://github.com/Fuzzyma","followers_url":"https://api.github.com/users/Fuzzyma/followers","following_url":"https://api.github.com/users/Fuzzyma/following{/other_user}","gists_url":"https://api.github.com/users/Fuzzyma/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuzzyma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuzzyma/subscriptions","organizations_url":"https://api.github.com/users/Fuzzyma/orgs","repos_url":"https://api.github.com/users/Fuzzyma/repos","events_url":"https://api.github.com/users/Fuzzyma/events{/privacy}","received_events_url":"https://api.github.com/users/Fuzzyma/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T20:45:54Z","updated_at":"2016-10-17T20:45:54Z","body":"There are 2 more comments which are shown as outdated. Did you read them? :)"}}
{"actor":{"display_login":"Fuzzyma"}}