{"action":"closed","number":2123,"pull_request":{"url":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123","id":96176204,"html_url":"https://github.com/bridgedotnet/Bridge/pull/2123","diff_url":"https://github.com/bridgedotnet/Bridge/pull/2123.diff","patch_url":"https://github.com/bridgedotnet/Bridge/pull/2123.patch","issue_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/2123","number":2123,"state":"closed","locked":false,"title":"[2112] Fixes for parsing numbers","user":{"login":"Zaid-Ajaj","id":13316248,"avatar_url":"https://avatars.githubusercontent.com/u/13316248?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaid-Ajaj","html_url":"https://github.com/Zaid-Ajaj","followers_url":"https://api.github.com/users/Zaid-Ajaj/followers","following_url":"https://api.github.com/users/Zaid-Ajaj/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Ajaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Ajaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Ajaj/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Ajaj/orgs","repos_url":"https://api.github.com/users/Zaid-Ajaj/repos","events_url":"https://api.github.com/users/Zaid-Ajaj/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Ajaj/received_events","type":"User","site_admin":false},"body":"Fixes #2112. \r\n\r\nNot only the issue should be fixed but other edge cases as well\r\n\r\nby default, `double.Parse` handles string with multiple comma's and also combined with dots, all of the following examples are valid with .Net:\r\n\r\n```csharp\r\ndouble.Parse(\"10,10\"); // 1010\r\ndouble.Parse(\"10,2,10\") // 10210\r\ndouble.Parse(\"10,1,1,1,1,1\") // 1011111\r\ndouble.Parse(\"10,00\") // 1000\r\ndouble.Parse(\"10,10,2.5\") // 10102.5\r\n```\r\n\r\nBut with Bridge ([Deck](http://deck.net/0e1e8ee741801dd227a35f7dec9e78ac))\r\n```csharp\r\ndouble.Parse(\"10,10\"); // 10\r\ndouble.Parse(\"10,2,10\") // 10\r\ndouble.Parse(\"10,1,1,1,1,1\") // 10\r\ndouble.Parse(\"10,00\") // 10\r\ndouble.Parse(\"10,10,2.5\") // 10\r\n```\r\n\r\nNow these should be parsed correctly when calling `double.Parse` from Bridge\r\n\r\nNo tests unfortunately, I didn't know where to put my tests (I was testing with another script and node). \r\n\r\nScript used for testing [JS Bin](https://jsbin.com/nehuheyuxu/edit?js,console)\r\n","created_at":"2016-12-01T21:41:32Z","updated_at":"2016-12-03T21:46:32Z","closed_at":"2016-12-03T21:46:31Z","merged_at":null,"merge_commit_sha":"0851c56c5d0ed7716ea4cda630f13d4227c763a3","assignee":{"login":"LeonidVeriga","id":11466613,"avatar_url":"https://avatars.githubusercontent.com/u/11466613?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonidVeriga","html_url":"https://github.com/LeonidVeriga","followers_url":"https://api.github.com/users/LeonidVeriga/followers","following_url":"https://api.github.com/users/LeonidVeriga/following{/other_user}","gists_url":"https://api.github.com/users/LeonidVeriga/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonidVeriga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonidVeriga/subscriptions","organizations_url":"https://api.github.com/users/LeonidVeriga/orgs","repos_url":"https://api.github.com/users/LeonidVeriga/repos","events_url":"https://api.github.com/users/LeonidVeriga/events{/privacy}","received_events_url":"https://api.github.com/users/LeonidVeriga/received_events","type":"User","site_admin":false},"assignees":[{"login":"LeonidVeriga","id":11466613,"avatar_url":"https://avatars.githubusercontent.com/u/11466613?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonidVeriga","html_url":"https://github.com/LeonidVeriga","followers_url":"https://api.github.com/users/LeonidVeriga/followers","following_url":"https://api.github.com/users/LeonidVeriga/following{/other_user}","gists_url":"https://api.github.com/users/LeonidVeriga/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonidVeriga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonidVeriga/subscriptions","organizations_url":"https://api.github.com/users/LeonidVeriga/orgs","repos_url":"https://api.github.com/users/LeonidVeriga/repos","events_url":"https://api.github.com/users/LeonidVeriga/events{/privacy}","received_events_url":"https://api.github.com/users/LeonidVeriga/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/bridgedotnet/Bridge/milestones/33","html_url":"https://github.com/bridgedotnet/Bridge/milestones/15.5","labels_url":"https://api.github.com/repos/bridgedotnet/Bridge/milestones/33/labels","id":2105980,"number":33,"title":"15.5","description":"","creator":{"login":"geoffreymcgill","id":62210,"avatar_url":"https://avatars.githubusercontent.com/u/62210?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffreymcgill","html_url":"https://github.com/geoffreymcgill","followers_url":"https://api.github.com/users/geoffreymcgill/followers","following_url":"https://api.github.com/users/geoffreymcgill/following{/other_user}","gists_url":"https://api.github.com/users/geoffreymcgill/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffreymcgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffreymcgill/subscriptions","organizations_url":"https://api.github.com/users/geoffreymcgill/orgs","repos_url":"https://api.github.com/users/geoffreymcgill/repos","events_url":"https://api.github.com/users/geoffreymcgill/events{/privacy}","received_events_url":"https://api.github.com/users/geoffreymcgill/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":69,"state":"open","created_at":"2016-11-01T04:05:41Z","updated_at":"2016-12-03T21:46:32Z","due_on":"2016-12-05T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123/commits","review_comments_url":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123/comments","review_comment_url":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/2123/comments","statuses_url":"https://api.github.com/repos/bridgedotnet/Bridge/statuses/c4bcb50b050969d16d319a2e23877d2081552be9","head":{"label":"Zaid-Ajaj:master","ref":"master","sha":"c4bcb50b050969d16d319a2e23877d2081552be9","user":{"login":"Zaid-Ajaj","id":13316248,"avatar_url":"https://avatars.githubusercontent.com/u/13316248?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaid-Ajaj","html_url":"https://github.com/Zaid-Ajaj","followers_url":"https://api.github.com/users/Zaid-Ajaj/followers","following_url":"https://api.github.com/users/Zaid-Ajaj/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Ajaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Ajaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Ajaj/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Ajaj/orgs","repos_url":"https://api.github.com/users/Zaid-Ajaj/repos","events_url":"https://api.github.com/users/Zaid-Ajaj/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Ajaj/received_events","type":"User","site_admin":false},"repo":{"id":75333390,"name":"Bridge","full_name":"Zaid-Ajaj/Bridge","owner":{"login":"Zaid-Ajaj","id":13316248,"avatar_url":"https://avatars.githubusercontent.com/u/13316248?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaid-Ajaj","html_url":"https://github.com/Zaid-Ajaj","followers_url":"https://api.github.com/users/Zaid-Ajaj/followers","following_url":"https://api.github.com/users/Zaid-Ajaj/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Ajaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Ajaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Ajaj/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Ajaj/orgs","repos_url":"https://api.github.com/users/Zaid-Ajaj/repos","events_url":"https://api.github.com/users/Zaid-Ajaj/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Ajaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zaid-Ajaj/Bridge","description":"Write modern mobile and web apps in C#. Run them anywhere in JavaScript with Bridge.NET.","fork":true,"url":"https://api.github.com/repos/Zaid-Ajaj/Bridge","forks_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/forks","keys_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/teams","hooks_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/hooks","issue_events_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/issues/events{/number}","events_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/events","assignees_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/assignees{/user}","branches_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/branches{/branch}","tags_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/tags","blobs_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/languages","stargazers_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/stargazers","contributors_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/contributors","subscribers_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/subscribers","subscription_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/subscription","commits_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/contents/{+path}","compare_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/merges","archive_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/downloads","issues_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/issues{/number}","pulls_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/labels{/name}","releases_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/releases{/id}","deployments_url":"https://api.github.com/repos/Zaid-Ajaj/Bridge/deployments","created_at":"2016-12-01T21:14:55Z","updated_at":"2016-12-01T21:15:01Z","pushed_at":"2016-12-01T22:34:51Z","git_url":"git://github.com/Zaid-Ajaj/Bridge.git","ssh_url":"git@github.com:Zaid-Ajaj/Bridge.git","clone_url":"https://github.com/Zaid-Ajaj/Bridge.git","svn_url":"https://github.com/Zaid-Ajaj/Bridge","homepage":"http://bridge.net","size":43893,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bridgedotnet:master","ref":"master","sha":"20fac49533a281a87afd3c4610115e95dabbffbd","user":{"login":"bridgedotnet","id":7505705,"avatar_url":"https://avatars.githubusercontent.com/u/7505705?v=3","gravatar_id":"","url":"https://api.github.com/users/bridgedotnet","html_url":"https://github.com/bridgedotnet","followers_url":"https://api.github.com/users/bridgedotnet/followers","following_url":"https://api.github.com/users/bridgedotnet/following{/other_user}","gists_url":"https://api.github.com/users/bridgedotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bridgedotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridgedotnet/subscriptions","organizations_url":"https://api.github.com/users/bridgedotnet/orgs","repos_url":"https://api.github.com/users/bridgedotnet/repos","events_url":"https://api.github.com/users/bridgedotnet/events{/privacy}","received_events_url":"https://api.github.com/users/bridgedotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15860426,"name":"Bridge","full_name":"bridgedotnet/Bridge","owner":{"login":"bridgedotnet","id":7505705,"avatar_url":"https://avatars.githubusercontent.com/u/7505705?v=3","gravatar_id":"","url":"https://api.github.com/users/bridgedotnet","html_url":"https://github.com/bridgedotnet","followers_url":"https://api.github.com/users/bridgedotnet/followers","following_url":"https://api.github.com/users/bridgedotnet/following{/other_user}","gists_url":"https://api.github.com/users/bridgedotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bridgedotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridgedotnet/subscriptions","organizations_url":"https://api.github.com/users/bridgedotnet/orgs","repos_url":"https://api.github.com/users/bridgedotnet/repos","events_url":"https://api.github.com/users/bridgedotnet/events{/privacy}","received_events_url":"https://api.github.com/users/bridgedotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bridgedotnet/Bridge","description":"Write modern mobile and web apps in C#. Run them anywhere in JavaScript with Bridge.NET.","fork":false,"url":"https://api.github.com/repos/bridgedotnet/Bridge","forks_url":"https://api.github.com/repos/bridgedotnet/Bridge/forks","keys_url":"https://api.github.com/repos/bridgedotnet/Bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bridgedotnet/Bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bridgedotnet/Bridge/teams","hooks_url":"https://api.github.com/repos/bridgedotnet/Bridge/hooks","issue_events_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/events{/number}","events_url":"https://api.github.com/repos/bridgedotnet/Bridge/events","assignees_url":"https://api.github.com/repos/bridgedotnet/Bridge/assignees{/user}","branches_url":"https://api.github.com/repos/bridgedotnet/Bridge/branches{/branch}","tags_url":"https://api.github.com/repos/bridgedotnet/Bridge/tags","blobs_url":"https://api.github.com/repos/bridgedotnet/Bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bridgedotnet/Bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bridgedotnet/Bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/bridgedotnet/Bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bridgedotnet/Bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/bridgedotnet/Bridge/languages","stargazers_url":"https://api.github.com/repos/bridgedotnet/Bridge/stargazers","contributors_url":"https://api.github.com/repos/bridgedotnet/Bridge/contributors","subscribers_url":"https://api.github.com/repos/bridgedotnet/Bridge/subscribers","subscription_url":"https://api.github.com/repos/bridgedotnet/Bridge/subscription","commits_url":"https://api.github.com/repos/bridgedotnet/Bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/bridgedotnet/Bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/bridgedotnet/Bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/bridgedotnet/Bridge/contents/{+path}","compare_url":"https://api.github.com/repos/bridgedotnet/Bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bridgedotnet/Bridge/merges","archive_url":"https://api.github.com/repos/bridgedotnet/Bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bridgedotnet/Bridge/downloads","issues_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues{/number}","pulls_url":"https://api.github.com/repos/bridgedotnet/Bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/bridgedotnet/Bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/bridgedotnet/Bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bridgedotnet/Bridge/labels{/name}","releases_url":"https://api.github.com/repos/bridgedotnet/Bridge/releases{/id}","deployments_url":"https://api.github.com/repos/bridgedotnet/Bridge/deployments","created_at":"2014-01-13T06:50:46Z","updated_at":"2016-12-02T14:50:08Z","pushed_at":"2016-12-03T21:39:52Z","git_url":"git://github.com/bridgedotnet/Bridge.git","ssh_url":"git@github.com:bridgedotnet/Bridge.git","clone_url":"https://github.com/bridgedotnet/Bridge.git","svn_url":"https://github.com/bridgedotnet/Bridge","homepage":"http://bridge.net","size":50843,"stargazers_count":688,"watchers_count":688,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":274,"forks":117,"open_issues":274,"watchers":688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123"},"html":{"href":"https://github.com/bridgedotnet/Bridge/pull/2123"},"issue":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/issues/2123"},"comments":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/issues/2123/comments"},"review_comments":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123/comments"},"review_comment":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/pulls/2123/commits"},"statuses":{"href":"https://api.github.com/repos/bridgedotnet/Bridge/statuses/c4bcb50b050969d16d319a2e23877d2081552be9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":4,"additions":92,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"LeonidVeriga"}}