{"action":"created","comment":{"url":"https://api.github.com/repos/Cloudef/wlc/pulls/comments/52872127","id":52872127,"diff_hunk":"@@ -234,6 +234,44 @@ finish_frame_tasks(struct wlc_output *output)\n }\n \n static void\n+render_subsurface(struct wlc_output *output, struct wlc_surface *surface, struct wlc_point offset, struct wlc_coordinate_scale parent_scale) {\n+   struct wlc_geometry g = (struct wlc_geometry) {","path":"src/compositor/output.c","position":5,"original_position":5,"commit_id":"5a7e7de12006af00bed572d07b58eae4f3c1bac7","original_commit_id":"5a7e7de12006af00bed572d07b58eae4f3c1bac7","user":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"body":"this looks like candicate for const","created_at":"2016-02-15T08:48:51Z","updated_at":"2016-02-15T08:48:51Z","html_url":"https://github.com/Cloudef/wlc/pull/120#discussion_r52872127","pull_request_url":"https://api.github.com/repos/Cloudef/wlc/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/comments/52872127"},"html":{"href":"https://github.com/Cloudef/wlc/pull/120#discussion_r52872127"},"pull_request":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/Cloudef/wlc/pulls/120","id":59268915,"html_url":"https://github.com/Cloudef/wlc/pull/120","diff_url":"https://github.com/Cloudef/wlc/pull/120.diff","patch_url":"https://github.com/Cloudef/wlc/pull/120.patch","issue_url":"https://api.github.com/repos/Cloudef/wlc/issues/120","number":120,"state":"open","locked":false,"title":"Implement subsurfaces","user":{"login":"ammen99","id":6287487,"avatar_url":"https://avatars.githubusercontent.com/u/6287487?v=3","gravatar_id":"","url":"https://api.github.com/users/ammen99","html_url":"https://github.com/ammen99","followers_url":"https://api.github.com/users/ammen99/followers","following_url":"https://api.github.com/users/ammen99/following{/other_user}","gists_url":"https://api.github.com/users/ammen99/gists{/gist_id}","starred_url":"https://api.github.com/users/ammen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammen99/subscriptions","organizations_url":"https://api.github.com/users/ammen99/orgs","repos_url":"https://api.github.com/users/ammen99/repos","events_url":"https://api.github.com/users/ammen99/events{/privacy}","received_events_url":"https://api.github.com/users/ammen99/received_events","type":"User","site_admin":false},"body":"Should resolve #22 \r\n\r\nThis is my work on subsurfaces inside WLC. I haven't tested them a lot(the only compositor tested is orbment), but gedit and nautlilus work properly now(and they use subsurfaces). If there is anything which doesn't work, please tell me, I'll do my best to fix it.\r\n\r\nWhat this pull request does is rendering the subsurfaces of a surface and also modify pointer focus functions to support focusing of subsurfaces. \r\n\r\nThings that still need to be done(aka TODO list):\r\n\r\n1. Implement proper handling of synchronized subsurfaces\r\n2. Implement subsurface::place_above and subsurface::place_below (both are really easy)\r\n","created_at":"2016-02-13T15:01:20Z","updated_at":"2016-02-15T08:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"244a38aefaa6db2287b25de79ec4cad415bd6960","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Cloudef/wlc/pulls/120/commits","review_comments_url":"https://api.github.com/repos/Cloudef/wlc/pulls/120/comments","review_comment_url":"https://api.github.com/repos/Cloudef/wlc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cloudef/wlc/issues/120/comments","statuses_url":"https://api.github.com/repos/Cloudef/wlc/statuses/5a7e7de12006af00bed572d07b58eae4f3c1bac7","head":{"label":"ammen99:master","ref":"master","sha":"5a7e7de12006af00bed572d07b58eae4f3c1bac7","user":{"login":"ammen99","id":6287487,"avatar_url":"https://avatars.githubusercontent.com/u/6287487?v=3","gravatar_id":"","url":"https://api.github.com/users/ammen99","html_url":"https://github.com/ammen99","followers_url":"https://api.github.com/users/ammen99/followers","following_url":"https://api.github.com/users/ammen99/following{/other_user}","gists_url":"https://api.github.com/users/ammen99/gists{/gist_id}","starred_url":"https://api.github.com/users/ammen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammen99/subscriptions","organizations_url":"https://api.github.com/users/ammen99/orgs","repos_url":"https://api.github.com/users/ammen99/repos","events_url":"https://api.github.com/users/ammen99/events{/privacy}","received_events_url":"https://api.github.com/users/ammen99/received_events","type":"User","site_admin":false},"repo":{"id":48479112,"name":"wlc","full_name":"ammen99/wlc","owner":{"login":"ammen99","id":6287487,"avatar_url":"https://avatars.githubusercontent.com/u/6287487?v=3","gravatar_id":"","url":"https://api.github.com/users/ammen99","html_url":"https://github.com/ammen99","followers_url":"https://api.github.com/users/ammen99/followers","following_url":"https://api.github.com/users/ammen99/following{/other_user}","gists_url":"https://api.github.com/users/ammen99/gists{/gist_id}","starred_url":"https://api.github.com/users/ammen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammen99/subscriptions","organizations_url":"https://api.github.com/users/ammen99/orgs","repos_url":"https://api.github.com/users/ammen99/repos","events_url":"https://api.github.com/users/ammen99/events{/privacy}","received_events_url":"https://api.github.com/users/ammen99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ammen99/wlc","description":"Wayland compositor library","fork":true,"url":"https://api.github.com/repos/ammen99/wlc","forks_url":"https://api.github.com/repos/ammen99/wlc/forks","keys_url":"https://api.github.com/repos/ammen99/wlc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ammen99/wlc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ammen99/wlc/teams","hooks_url":"https://api.github.com/repos/ammen99/wlc/hooks","issue_events_url":"https://api.github.com/repos/ammen99/wlc/issues/events{/number}","events_url":"https://api.github.com/repos/ammen99/wlc/events","assignees_url":"https://api.github.com/repos/ammen99/wlc/assignees{/user}","branches_url":"https://api.github.com/repos/ammen99/wlc/branches{/branch}","tags_url":"https://api.github.com/repos/ammen99/wlc/tags","blobs_url":"https://api.github.com/repos/ammen99/wlc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ammen99/wlc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ammen99/wlc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ammen99/wlc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ammen99/wlc/statuses/{sha}","languages_url":"https://api.github.com/repos/ammen99/wlc/languages","stargazers_url":"https://api.github.com/repos/ammen99/wlc/stargazers","contributors_url":"https://api.github.com/repos/ammen99/wlc/contributors","subscribers_url":"https://api.github.com/repos/ammen99/wlc/subscribers","subscription_url":"https://api.github.com/repos/ammen99/wlc/subscription","commits_url":"https://api.github.com/repos/ammen99/wlc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ammen99/wlc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ammen99/wlc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ammen99/wlc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ammen99/wlc/contents/{+path}","compare_url":"https://api.github.com/repos/ammen99/wlc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ammen99/wlc/merges","archive_url":"https://api.github.com/repos/ammen99/wlc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ammen99/wlc/downloads","issues_url":"https://api.github.com/repos/ammen99/wlc/issues{/number}","pulls_url":"https://api.github.com/repos/ammen99/wlc/pulls{/number}","milestones_url":"https://api.github.com/repos/ammen99/wlc/milestones{/number}","notifications_url":"https://api.github.com/repos/ammen99/wlc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ammen99/wlc/labels{/name}","releases_url":"https://api.github.com/repos/ammen99/wlc/releases{/id}","deployments_url":"https://api.github.com/repos/ammen99/wlc/deployments","created_at":"2015-12-23T08:31:51Z","updated_at":"2015-12-23T08:31:52Z","pushed_at":"2016-02-14T08:08:19Z","git_url":"git://github.com/ammen99/wlc.git","ssh_url":"git@github.com:ammen99/wlc.git","clone_url":"https://github.com/ammen99/wlc.git","svn_url":"https://github.com/ammen99/wlc","homepage":null,"size":1432,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"opengl"}},"base":{"label":"Cloudef:master","ref":"master","sha":"faa4d3cba670576c202b0844e087b13538f772c5","user":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"repo":{"id":22349616,"name":"wlc","full_name":"Cloudef/wlc","owner":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cloudef/wlc","description":"Wayland compositor library","fork":false,"url":"https://api.github.com/repos/Cloudef/wlc","forks_url":"https://api.github.com/repos/Cloudef/wlc/forks","keys_url":"https://api.github.com/repos/Cloudef/wlc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cloudef/wlc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cloudef/wlc/teams","hooks_url":"https://api.github.com/repos/Cloudef/wlc/hooks","issue_events_url":"https://api.github.com/repos/Cloudef/wlc/issues/events{/number}","events_url":"https://api.github.com/repos/Cloudef/wlc/events","assignees_url":"https://api.github.com/repos/Cloudef/wlc/assignees{/user}","branches_url":"https://api.github.com/repos/Cloudef/wlc/branches{/branch}","tags_url":"https://api.github.com/repos/Cloudef/wlc/tags","blobs_url":"https://api.github.com/repos/Cloudef/wlc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cloudef/wlc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cloudef/wlc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cloudef/wlc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cloudef/wlc/statuses/{sha}","languages_url":"https://api.github.com/repos/Cloudef/wlc/languages","stargazers_url":"https://api.github.com/repos/Cloudef/wlc/stargazers","contributors_url":"https://api.github.com/repos/Cloudef/wlc/contributors","subscribers_url":"https://api.github.com/repos/Cloudef/wlc/subscribers","subscription_url":"https://api.github.com/repos/Cloudef/wlc/subscription","commits_url":"https://api.github.com/repos/Cloudef/wlc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cloudef/wlc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cloudef/wlc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cloudef/wlc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cloudef/wlc/contents/{+path}","compare_url":"https://api.github.com/repos/Cloudef/wlc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cloudef/wlc/merges","archive_url":"https://api.github.com/repos/Cloudef/wlc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cloudef/wlc/downloads","issues_url":"https://api.github.com/repos/Cloudef/wlc/issues{/number}","pulls_url":"https://api.github.com/repos/Cloudef/wlc/pulls{/number}","milestones_url":"https://api.github.com/repos/Cloudef/wlc/milestones{/number}","notifications_url":"https://api.github.com/repos/Cloudef/wlc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cloudef/wlc/labels{/name}","releases_url":"https://api.github.com/repos/Cloudef/wlc/releases{/id}","deployments_url":"https://api.github.com/repos/Cloudef/wlc/deployments","created_at":"2014-07-28T16:27:14Z","updated_at":"2016-02-14T11:48:22Z","pushed_at":"2016-02-15T00:02:53Z","git_url":"git://github.com/Cloudef/wlc.git","ssh_url":"git@github.com:Cloudef/wlc.git","clone_url":"https://github.com/Cloudef/wlc.git","svn_url":"https://github.com/Cloudef/wlc","homepage":null,"size":1314,"stargazers_count":102,"watchers_count":102,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":39,"forks":27,"open_issues":39,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/120"},"html":{"href":"https://github.com/Cloudef/wlc/pull/120"},"issue":{"href":"https://api.github.com/repos/Cloudef/wlc/issues/120"},"comments":{"href":"https://api.github.com/repos/Cloudef/wlc/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/Cloudef/wlc/statuses/5a7e7de12006af00bed572d07b58eae4f3c1bac7"}}}}