{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/81410925","pull_request_review_id":2395483,"id":81410925,"diff_hunk":"@@ -28,7 +28,17 @@ public function process(ContainerBuilder $container)\n                 $validators[$attributes[0]['alias']] = $id;\n             }\n \n-            $validators[$container->getDefinition($id)->getClass()] = $id;\n+            $definition = $container->getDefinition($id);\n+\n+            if (!$definition->isPublic()) {\n+                throw new InvalidArgumentException(sprintf('The service \"%s\" must be public as it can be lazy-loaded.', $id));\n+            }\n+\n+            if ($definition->isAbstract()) {\n+                throw new InvalidArgumentException(sprintf('The service \"%s\" must not be abstract as it can be lazy-loaded.', $id));\n+            }\n+\n+            $validators[$definition->getClass()] = $id;","path":"src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConstraintValidatorsPass.php","position":15,"original_position":15,"commit_id":"4166a07962e4d59c6f2ae5d22c055128061b0c67","original_commit_id":"4166a07962e4d59c6f2ae5d22c055128061b0c67","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"shouldn't this be done in older branches ?","created_at":"2016-09-30T20:20:39Z","updated_at":"2016-09-30T20:20:39Z","html_url":"https://github.com/symfony/symfony/pull/20112#discussion_r81410925","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20112","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/81410925"},"html":{"href":"https://github.com/symfony/symfony/pull/20112#discussion_r81410925"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20112"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20112","id":87547627,"html_url":"https://github.com/symfony/symfony/pull/20112","diff_url":"https://github.com/symfony/symfony/pull/20112.diff","patch_url":"https://github.com/symfony/symfony/pull/20112.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20112","number":20112,"state":"open","locked":false,"title":"added checks for public services on compiler passes that use service ids and not references","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n","created_at":"2016-09-30T18:57:51Z","updated_at":"2016-09-30T20:20:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5534373a4f2446a3745c0b237e15e8a86fc7c19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20112/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20112/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20112/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/4166a07962e4d59c6f2ae5d22c055128061b0c67","head":{"label":"fabpot:public-services","ref":"public-services","sha":"4166a07962e4d59c6f2ae5d22c055128061b0c67","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"repo":{"id":458135,"name":"symfony","full_name":"fabpot/symfony","owner":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabpot/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/fabpot/symfony","forks_url":"https://api.github.com/repos/fabpot/symfony/forks","keys_url":"https://api.github.com/repos/fabpot/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabpot/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabpot/symfony/teams","hooks_url":"https://api.github.com/repos/fabpot/symfony/hooks","issue_events_url":"https://api.github.com/repos/fabpot/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/fabpot/symfony/events","assignees_url":"https://api.github.com/repos/fabpot/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/fabpot/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/fabpot/symfony/tags","blobs_url":"https://api.github.com/repos/fabpot/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabpot/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabpot/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabpot/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabpot/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/fabpot/symfony/languages","stargazers_url":"https://api.github.com/repos/fabpot/symfony/stargazers","contributors_url":"https://api.github.com/repos/fabpot/symfony/contributors","subscribers_url":"https://api.github.com/repos/fabpot/symfony/subscribers","subscription_url":"https://api.github.com/repos/fabpot/symfony/subscription","commits_url":"https://api.github.com/repos/fabpot/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabpot/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabpot/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabpot/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabpot/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/fabpot/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabpot/symfony/merges","archive_url":"https://api.github.com/repos/fabpot/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabpot/symfony/downloads","issues_url":"https://api.github.com/repos/fabpot/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/fabpot/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/fabpot/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/fabpot/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabpot/symfony/labels{/name}","releases_url":"https://api.github.com/repos/fabpot/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/fabpot/symfony/deployments","created_at":"2010-01-04T15:41:06Z","updated_at":"2016-09-26T22:33:57Z","pushed_at":"2016-09-30T19:36:06Z","git_url":"git://github.com/fabpot/symfony.git","ssh_url":"git@github.com:fabpot/symfony.git","clone_url":"https://github.com/fabpot/symfony.git","svn_url":"https://github.com/fabpot/symfony","homepage":"http://symfony.com/","size":75091,"stargazers_count":361,"watchers_count":361,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":0,"forks":49,"open_issues":0,"watchers":361,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"418944bb50a23ccd5e2ce803bf60a8b3c69c8a05","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-09-30T13:11:34Z","pushed_at":"2016-09-30T19:53:11Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":136875,"stargazers_count":13059,"watchers_count":13059,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5067,"mirror_url":null,"open_issues_count":770,"forks":5067,"open_issues":770,"watchers":13059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20112"},"html":{"href":"https://github.com/symfony/symfony/pull/20112"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20112"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20112/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20112/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20112/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/4166a07962e4d59c6f2ae5d22c055128061b0c67"}}}}
{"actor":{"display_login":"stof"}}