{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/10795","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/10795/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/10795/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/10795/events","html_url":"https://github.com/dotnet/corefx/pull/10795","id":171211066,"number":10795,"title":"Glibc readdir_r() deprecated use readdir()","user":{"login":"wobbol","id":5775301,"avatar_url":"https://avatars.githubusercontent.com/u/5775301?v=3","gravatar_id":"","url":"https://api.github.com/users/wobbol","html_url":"https://github.com/wobbol","followers_url":"https://api.github.com/users/wobbol/followers","following_url":"https://api.github.com/users/wobbol/following{/other_user}","gists_url":"https://api.github.com/users/wobbol/gists{/gist_id}","starred_url":"https://api.github.com/users/wobbol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wobbol/subscriptions","organizations_url":"https://api.github.com/users/wobbol/orgs","repos_url":"https://api.github.com/users/wobbol/repos","events_url":"https://api.github.com/users/wobbol/events{/privacy}","received_events_url":"https://api.github.com/users/wobbol/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/3%20-%20Ready%20For%20Review","name":"3 - Ready For Review","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-not-required","name":"cla-not-required","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-15T16:49:09Z","updated_at":"2016-08-16T16:19:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/10795","html_url":"https://github.com/dotnet/corefx/pull/10795","diff_url":"https://github.com/dotnet/corefx/pull/10795.diff","patch_url":"https://github.com/dotnet/corefx/pull/10795.patch"},"body":"when compiling against glibc 2.24 a deprecated warning stops compilation.\r\nThis PR should fix it without changing behavior too much.\r\n\r\nChanging to the non_reentrant version of `readdir()` does make `int32_t SystemNative_ReadDirR()` thread unsafe. The thread safety conditions documented by [glibc](https://www.gnu.org/software/libc/manual/html_node/Reading_002fClosing-Directory.html#Reading_002fClosing-Directory) says glibc's implementation of `readdir()` is thread safe _unless_ more than one thread uses same directory stream pointer as input to `readdir()` , behavior is undefined.\r\n\r\nIs this an acceptable change, or must extra steps be taken to ensure thread safety?"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/240154726","html_url":"https://github.com/dotnet/corefx/pull/10795#issuecomment-240154726","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/10795","id":240154726,"user":{"login":"wobbol","id":5775301,"avatar_url":"https://avatars.githubusercontent.com/u/5775301?v=3","gravatar_id":"","url":"https://api.github.com/users/wobbol","html_url":"https://github.com/wobbol","followers_url":"https://api.github.com/users/wobbol/followers","following_url":"https://api.github.com/users/wobbol/following{/other_user}","gists_url":"https://api.github.com/users/wobbol/gists{/gist_id}","starred_url":"https://api.github.com/users/wobbol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wobbol/subscriptions","organizations_url":"https://api.github.com/users/wobbol/orgs","repos_url":"https://api.github.com/users/wobbol/repos","events_url":"https://api.github.com/users/wobbol/events{/privacy}","received_events_url":"https://api.github.com/users/wobbol/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T16:19:17Z","updated_at":"2016-08-16T16:19:17Z","body":"This PR should be able to close issue #10712 "}}
{"actor":{"display_login":"wobbol"}}