{"action":"created","comment":{"url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/comments/63941506","id":63941506,"diff_hunk":"@@ -37,6 +37,9 @@\n   agent_yaml['loadBalancerConfig']['rootPath'] = agent_root_path\n   agent_yaml['templates'] = templates || node['baragon']['templates'].to_hash.values\n \n+  # Process the templates as ERB\n+  agent_yaml['templates'].each { |item| item['template'] = ERB.new(item['template']).result(binding) }","path":"resources/agent.rb","position":5,"original_position":5,"commit_id":"cfaf4a64fb367197e8ee837a3d5a63dd8150a4dd","original_commit_id":"cfaf4a64fb367197e8ee837a3d5a63dd8150a4dd","user":{"login":"jeffbyrnes","id":260553,"avatar_url":"https://avatars.githubusercontent.com/u/260553?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffbyrnes","html_url":"https://github.com/jeffbyrnes","followers_url":"https://api.github.com/users/jeffbyrnes/followers","following_url":"https://api.github.com/users/jeffbyrnes/following{/other_user}","gists_url":"https://api.github.com/users/jeffbyrnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbyrnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbyrnes/subscriptions","organizations_url":"https://api.github.com/users/jeffbyrnes/orgs","repos_url":"https://api.github.com/users/jeffbyrnes/repos","events_url":"https://api.github.com/users/jeffbyrnes/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbyrnes/received_events","type":"User","site_admin":false},"body":"This very line. You’ve dropped the tests asserting that `!ruby/hash:Chef::Node::Immutable` is not present in various YAML, I wondered if this was why.","created_at":"2016-05-19T19:40:29Z","updated_at":"2016-05-19T19:40:29Z","html_url":"https://github.com/evertrue/baragon-cookbook/pull/4#discussion_r63941506","pull_request_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/comments/63941506"},"html":{"href":"https://github.com/evertrue/baragon-cookbook/pull/4#discussion_r63941506"},"pull_request":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4","id":70751932,"html_url":"https://github.com/evertrue/baragon-cookbook/pull/4","diff_url":"https://github.com/evertrue/baragon-cookbook/pull/4.diff","patch_url":"https://github.com/evertrue/baragon-cookbook/pull/4.patch","issue_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/4","number":4,"state":"open","locked":false,"title":"Make upstreams unique per lb group","user":{"login":"eherot","id":400447,"avatar_url":"https://avatars.githubusercontent.com/u/400447?v=3","gravatar_id":"","url":"https://api.github.com/users/eherot","html_url":"https://github.com/eherot","followers_url":"https://api.github.com/users/eherot/followers","following_url":"https://api.github.com/users/eherot/following{/other_user}","gists_url":"https://api.github.com/users/eherot/gists{/gist_id}","starred_url":"https://api.github.com/users/eherot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eherot/subscriptions","organizations_url":"https://api.github.com/users/eherot/orgs","repos_url":"https://api.github.com/users/eherot/repos","events_url":"https://api.github.com/users/eherot/events{/privacy}","received_events_url":"https://api.github.com/users/eherot/received_events","type":"User","site_admin":false},"body":"The add-an-upstream test that I created may not actually work on first convergence for order-of-operations reasons but I didn't want this very important feature to be held up any more because of that.","created_at":"2016-05-19T19:34:01Z","updated_at":"2016-05-19T19:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c826fd1f889070a483cd1f27fa53ba11608cff08","assignee":{"login":"jeffbyrnes","id":260553,"avatar_url":"https://avatars.githubusercontent.com/u/260553?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffbyrnes","html_url":"https://github.com/jeffbyrnes","followers_url":"https://api.github.com/users/jeffbyrnes/followers","following_url":"https://api.github.com/users/jeffbyrnes/following{/other_user}","gists_url":"https://api.github.com/users/jeffbyrnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbyrnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbyrnes/subscriptions","organizations_url":"https://api.github.com/users/jeffbyrnes/orgs","repos_url":"https://api.github.com/users/jeffbyrnes/repos","events_url":"https://api.github.com/users/jeffbyrnes/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbyrnes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4/commits","review_comments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4/comments","review_comment_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/4/comments","statuses_url":"https://api.github.com/repos/evertrue/baragon-cookbook/statuses/cfaf4a64fb367197e8ee837a3d5a63dd8150a4dd","head":{"label":"evertrue:eherot/make_upstreams_unique_per_lb_group","ref":"eherot/make_upstreams_unique_per_lb_group","sha":"cfaf4a64fb367197e8ee837a3d5a63dd8150a4dd","user":{"login":"evertrue","id":1162677,"avatar_url":"https://avatars.githubusercontent.com/u/1162677?v=3","gravatar_id":"","url":"https://api.github.com/users/evertrue","html_url":"https://github.com/evertrue","followers_url":"https://api.github.com/users/evertrue/followers","following_url":"https://api.github.com/users/evertrue/following{/other_user}","gists_url":"https://api.github.com/users/evertrue/gists{/gist_id}","starred_url":"https://api.github.com/users/evertrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evertrue/subscriptions","organizations_url":"https://api.github.com/users/evertrue/orgs","repos_url":"https://api.github.com/users/evertrue/repos","events_url":"https://api.github.com/users/evertrue/events{/privacy}","received_events_url":"https://api.github.com/users/evertrue/received_events","type":"Organization","site_admin":false},"repo":{"id":35566626,"name":"baragon-cookbook","full_name":"evertrue/baragon-cookbook","owner":{"login":"evertrue","id":1162677,"avatar_url":"https://avatars.githubusercontent.com/u/1162677?v=3","gravatar_id":"","url":"https://api.github.com/users/evertrue","html_url":"https://github.com/evertrue","followers_url":"https://api.github.com/users/evertrue/followers","following_url":"https://api.github.com/users/evertrue/following{/other_user}","gists_url":"https://api.github.com/users/evertrue/gists{/gist_id}","starred_url":"https://api.github.com/users/evertrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evertrue/subscriptions","organizations_url":"https://api.github.com/users/evertrue/orgs","repos_url":"https://api.github.com/users/evertrue/repos","events_url":"https://api.github.com/users/evertrue/events{/privacy}","received_events_url":"https://api.github.com/users/evertrue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evertrue/baragon-cookbook","description":"Cookbook for HubSpot Baragon","fork":false,"url":"https://api.github.com/repos/evertrue/baragon-cookbook","forks_url":"https://api.github.com/repos/evertrue/baragon-cookbook/forks","keys_url":"https://api.github.com/repos/evertrue/baragon-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evertrue/baragon-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evertrue/baragon-cookbook/teams","hooks_url":"https://api.github.com/repos/evertrue/baragon-cookbook/hooks","issue_events_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/evertrue/baragon-cookbook/events","assignees_url":"https://api.github.com/repos/evertrue/baragon-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/evertrue/baragon-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/evertrue/baragon-cookbook/tags","blobs_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evertrue/baragon-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/evertrue/baragon-cookbook/languages","stargazers_url":"https://api.github.com/repos/evertrue/baragon-cookbook/stargazers","contributors_url":"https://api.github.com/repos/evertrue/baragon-cookbook/contributors","subscribers_url":"https://api.github.com/repos/evertrue/baragon-cookbook/subscribers","subscription_url":"https://api.github.com/repos/evertrue/baragon-cookbook/subscription","commits_url":"https://api.github.com/repos/evertrue/baragon-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/evertrue/baragon-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/evertrue/baragon-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evertrue/baragon-cookbook/merges","archive_url":"https://api.github.com/repos/evertrue/baragon-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evertrue/baragon-cookbook/downloads","issues_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/evertrue/baragon-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/evertrue/baragon-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evertrue/baragon-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/evertrue/baragon-cookbook/releases{/id}","deployments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/deployments","created_at":"2015-05-13T18:22:36Z","updated_at":"2015-05-13T18:22:46Z","pushed_at":"2016-05-19T19:34:03Z","git_url":"git://github.com/evertrue/baragon-cookbook.git","ssh_url":"git@github.com:evertrue/baragon-cookbook.git","clone_url":"https://github.com/evertrue/baragon-cookbook.git","svn_url":"https://github.com/evertrue/baragon-cookbook","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"evertrue:master","ref":"master","sha":"8ae351b327177ad3c5097cbf4addb4f2fd522cd8","user":{"login":"evertrue","id":1162677,"avatar_url":"https://avatars.githubusercontent.com/u/1162677?v=3","gravatar_id":"","url":"https://api.github.com/users/evertrue","html_url":"https://github.com/evertrue","followers_url":"https://api.github.com/users/evertrue/followers","following_url":"https://api.github.com/users/evertrue/following{/other_user}","gists_url":"https://api.github.com/users/evertrue/gists{/gist_id}","starred_url":"https://api.github.com/users/evertrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evertrue/subscriptions","organizations_url":"https://api.github.com/users/evertrue/orgs","repos_url":"https://api.github.com/users/evertrue/repos","events_url":"https://api.github.com/users/evertrue/events{/privacy}","received_events_url":"https://api.github.com/users/evertrue/received_events","type":"Organization","site_admin":false},"repo":{"id":35566626,"name":"baragon-cookbook","full_name":"evertrue/baragon-cookbook","owner":{"login":"evertrue","id":1162677,"avatar_url":"https://avatars.githubusercontent.com/u/1162677?v=3","gravatar_id":"","url":"https://api.github.com/users/evertrue","html_url":"https://github.com/evertrue","followers_url":"https://api.github.com/users/evertrue/followers","following_url":"https://api.github.com/users/evertrue/following{/other_user}","gists_url":"https://api.github.com/users/evertrue/gists{/gist_id}","starred_url":"https://api.github.com/users/evertrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evertrue/subscriptions","organizations_url":"https://api.github.com/users/evertrue/orgs","repos_url":"https://api.github.com/users/evertrue/repos","events_url":"https://api.github.com/users/evertrue/events{/privacy}","received_events_url":"https://api.github.com/users/evertrue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evertrue/baragon-cookbook","description":"Cookbook for HubSpot Baragon","fork":false,"url":"https://api.github.com/repos/evertrue/baragon-cookbook","forks_url":"https://api.github.com/repos/evertrue/baragon-cookbook/forks","keys_url":"https://api.github.com/repos/evertrue/baragon-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evertrue/baragon-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evertrue/baragon-cookbook/teams","hooks_url":"https://api.github.com/repos/evertrue/baragon-cookbook/hooks","issue_events_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/evertrue/baragon-cookbook/events","assignees_url":"https://api.github.com/repos/evertrue/baragon-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/evertrue/baragon-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/evertrue/baragon-cookbook/tags","blobs_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evertrue/baragon-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/evertrue/baragon-cookbook/languages","stargazers_url":"https://api.github.com/repos/evertrue/baragon-cookbook/stargazers","contributors_url":"https://api.github.com/repos/evertrue/baragon-cookbook/contributors","subscribers_url":"https://api.github.com/repos/evertrue/baragon-cookbook/subscribers","subscription_url":"https://api.github.com/repos/evertrue/baragon-cookbook/subscription","commits_url":"https://api.github.com/repos/evertrue/baragon-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/evertrue/baragon-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/evertrue/baragon-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/evertrue/baragon-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evertrue/baragon-cookbook/merges","archive_url":"https://api.github.com/repos/evertrue/baragon-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evertrue/baragon-cookbook/downloads","issues_url":"https://api.github.com/repos/evertrue/baragon-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/evertrue/baragon-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/evertrue/baragon-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evertrue/baragon-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/evertrue/baragon-cookbook/releases{/id}","deployments_url":"https://api.github.com/repos/evertrue/baragon-cookbook/deployments","created_at":"2015-05-13T18:22:36Z","updated_at":"2015-05-13T18:22:46Z","pushed_at":"2016-05-19T19:34:03Z","git_url":"git://github.com/evertrue/baragon-cookbook.git","ssh_url":"git@github.com:evertrue/baragon-cookbook.git","clone_url":"https://github.com/evertrue/baragon-cookbook.git","svn_url":"https://github.com/evertrue/baragon-cookbook","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4"},"html":{"href":"https://github.com/evertrue/baragon-cookbook/pull/4"},"issue":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/4"},"comments":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/evertrue/baragon-cookbook/statuses/cfaf4a64fb367197e8ee837a3d5a63dd8150a4dd"}}}}