{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4950","repository_url":"https://api.github.com/repos/zfsonlinux/zfs","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4950/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4950/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4950/events","html_url":"https://github.com/zfsonlinux/zfs/pull/4950","id":170271782,"number":4950,"title":"Illumos 7176 Yet another hole birth issue","user":{"login":"kernelOfTruth","id":4529709,"avatar_url":"https://avatars.githubusercontent.com/u/4529709?v=3","gravatar_id":"","url":"https://api.github.com/users/kernelOfTruth","html_url":"https://github.com/kernelOfTruth","followers_url":"https://api.github.com/users/kernelOfTruth/followers","following_url":"https://api.github.com/users/kernelOfTruth/following{/other_user}","gists_url":"https://api.github.com/users/kernelOfTruth/gists{/gist_id}","starred_url":"https://api.github.com/users/kernelOfTruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernelOfTruth/subscriptions","organizations_url":"https://api.github.com/users/kernelOfTruth/orgs","repos_url":"https://api.github.com/users/kernelOfTruth/repos","events_url":"https://api.github.com/users/kernelOfTruth/events{/privacy}","received_events_url":"https://api.github.com/users/kernelOfTruth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-09T21:10:47Z","updated_at":"2016-08-18T16:31:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4950","html_url":"https://github.com/zfsonlinux/zfs/pull/4950","diff_url":"https://github.com/zfsonlinux/zfs/pull/4950.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4950.patch"},"body":"Illumos 7176 Yet another hole birth issue\r\n\r\nAuthored by: Paul Dagnelie <pcd@delphix.com>\r\nReviewed by: Matthew Ahrens mahrens@delphix.com\r\nReviewed by: George Wilson george.wilson@delphix.com\r\nApproved by: \r\nPorted-by: kernelOfTruth <kerneloftruth@gmail.com>\r\nOpenZFS-issue: https://www.illumos.org/issues/7176\r\nOpenZFS-commit:\r\n\r\nThis is another bug in the long line of hole-birth related issues. In this particular case, it was discovered that a previous hole-birth fix (illumos bug 6513) did not cover as many cases as we thought\r\nit did. While the issue worked in the case of hole-punching (writing zeroes to a large part of a file), it did not deal with truncation, and then writing beyond the new end of the file.\r\n\r\nThe problem is that dbuf_findbp will return ENOENT if the block it's trying to find is beyond the end of the file. If that happens, we assume there is no birth time, and so we lose that information when\r\nwe write out new blkptrs. We should teach dbuf_findbp to look for things that are beyond the current end, but not beyond the absolute end of the file.\r\n\r\nUpstream bugs: DLPX-46009"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/240779975","html_url":"https://github.com/zfsonlinux/zfs/pull/4950#issuecomment-240779975","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4950","id":240779975,"user":{"login":"richardelling","id":867533,"avatar_url":"https://avatars.githubusercontent.com/u/867533?v=3","gravatar_id":"","url":"https://api.github.com/users/richardelling","html_url":"https://github.com/richardelling","followers_url":"https://api.github.com/users/richardelling/followers","following_url":"https://api.github.com/users/richardelling/following{/other_user}","gists_url":"https://api.github.com/users/richardelling/gists{/gist_id}","starred_url":"https://api.github.com/users/richardelling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardelling/subscriptions","organizations_url":"https://api.github.com/users/richardelling/orgs","repos_url":"https://api.github.com/users/richardelling/repos","events_url":"https://api.github.com/users/richardelling/events{/privacy}","received_events_url":"https://api.github.com/users/richardelling/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T16:31:43Z","updated_at":"2016-08-18T16:31:43Z","body":"@bprotopopov DN_MAX_INDBLKSHIFT to 17 is covered by PR 4800 https://github.com/zfsonlinux/zfs/pull/4800"}}
{"actor":{"display_login":"richardelling"}}