{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153","id":81051849,"html_url":"https://github.com/shlomiassaf/angular2-modal/pull/153","diff_url":"https://github.com/shlomiassaf/angular2-modal/pull/153.diff","patch_url":"https://github.com/shlomiassaf/angular2-modal/pull/153.patch","issue_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/153","number":153,"state":"closed","locked":false,"title":"Refactor: Overlay and dynamically styled components","user":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"body":"This PR introduces an core change in the way a modal/dialog is built.\r\nIt borrows the idea of Overlay from Material2.\r\n\r\nA ModalOverlay is the core component upon which a modal is built.\r\n\r\nAn underlaying overlay service is used to manage overlay lifecycle, behaviour (click to close, etc..) and more.\r\n\r\nWith this change some new directives are used as helpers for plugin implementation.\r\n\r\nTo allows click detection support `OverlayDialogBoundary` directive can be set on a container which will close the windows on every click outside of it (as lock as isBlocking is set to false)\r\nthis can also be set via code with the overlay service.\r\n\r\nTo specify a view container (for contained modal, within an element) a developer had to get a reference to the view container of that element (`@ViewChild`). Now `OverlayTarget` can be used to set an id to a view container which later can be referenced by given the string (id) instead of the viewContainerRef object.\r\n\r\n\r\nAnother feature that ease up plugin development is the base component class `BaseDynamicComponent` which provides API support for dynamically adding components, applying styles and getting transition and animation lifecycle notification.\r\nThis is useful for modal plugins based on CSS frameworks (e.g: bootstrap) where animation and styles are based on CSS classes. This reduces the code required by such plugins significantly.\r\n\r\n> Angular 2 native plugins should use the angular animation api.\r\n\r\nWith the introduction of overlays plugins are only responsible for setting the inner content of an overlay (an overlay comes empty), which is done by implementing the `create` function on a Modal class. ","created_at":"2016-08-12T00:16:28Z","updated_at":"2016-08-21T13:11:27Z","closed_at":"2016-08-21T13:11:27Z","merged_at":"2016-08-21T13:11:27Z","merge_commit_sha":"93d001aec1bfc2f422424e737561ecfcaddf6444","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153/commits","review_comments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153/comments","review_comment_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/153/comments","statuses_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/statuses/3a6456d41f09ca290b0e119e7c37904395f074c0","head":{"label":"shlomiassaf:overlay-based","ref":"overlay-based","sha":"3a6456d41f09ca290b0e119e7c37904395f074c0","user":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"repo":{"id":37190644,"name":"angular2-modal","full_name":"shlomiassaf/angular2-modal","owner":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shlomiassaf/angular2-modal","description":"Angular2 Modal / Dialog window","fork":false,"url":"https://api.github.com/repos/shlomiassaf/angular2-modal","forks_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/forks","keys_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/teams","hooks_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/hooks","issue_events_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/events{/number}","events_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/events","assignees_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/assignees{/user}","branches_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/branches{/branch}","tags_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/tags","blobs_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/languages","stargazers_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/stargazers","contributors_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/contributors","subscribers_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/subscribers","subscription_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/subscription","commits_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/contents/{+path}","compare_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/merges","archive_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/downloads","issues_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues{/number}","pulls_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/labels{/name}","releases_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/releases{/id}","deployments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/deployments","created_at":"2015-06-10T10:25:43Z","updated_at":"2016-08-18T11:43:52Z","pushed_at":"2016-08-21T13:11:27Z","git_url":"git://github.com/shlomiassaf/angular2-modal.git","ssh_url":"git@github.com:shlomiassaf/angular2-modal.git","clone_url":"https://github.com/shlomiassaf/angular2-modal.git","svn_url":"https://github.com/shlomiassaf/angular2-modal","homepage":"http://shlomiassaf.github.io/angular2-modal","size":18994,"stargazers_count":189,"watchers_count":189,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":38,"forks":91,"open_issues":38,"watchers":189,"default_branch":"master"}},"base":{"label":"shlomiassaf:master","ref":"master","sha":"1154f4c948d170105e7734a018b841c5aac2cfcb","user":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"repo":{"id":37190644,"name":"angular2-modal","full_name":"shlomiassaf/angular2-modal","owner":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shlomiassaf/angular2-modal","description":"Angular2 Modal / Dialog window","fork":false,"url":"https://api.github.com/repos/shlomiassaf/angular2-modal","forks_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/forks","keys_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/teams","hooks_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/hooks","issue_events_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/events{/number}","events_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/events","assignees_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/assignees{/user}","branches_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/branches{/branch}","tags_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/tags","blobs_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/languages","stargazers_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/stargazers","contributors_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/contributors","subscribers_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/subscribers","subscription_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/subscription","commits_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/contents/{+path}","compare_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/merges","archive_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/downloads","issues_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues{/number}","pulls_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/labels{/name}","releases_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/releases{/id}","deployments_url":"https://api.github.com/repos/shlomiassaf/angular2-modal/deployments","created_at":"2015-06-10T10:25:43Z","updated_at":"2016-08-18T11:43:52Z","pushed_at":"2016-08-21T13:11:27Z","git_url":"git://github.com/shlomiassaf/angular2-modal.git","ssh_url":"git@github.com:shlomiassaf/angular2-modal.git","clone_url":"https://github.com/shlomiassaf/angular2-modal.git","svn_url":"https://github.com/shlomiassaf/angular2-modal","homepage":"http://shlomiassaf.github.io/angular2-modal","size":18994,"stargazers_count":189,"watchers_count":189,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":38,"forks":91,"open_issues":38,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153"},"html":{"href":"https://github.com/shlomiassaf/angular2-modal/pull/153"},"issue":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/153"},"comments":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/shlomiassaf/angular2-modal/statuses/3a6456d41f09ca290b0e119e7c37904395f074c0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shlomiassaf","id":5377501,"avatar_url":"https://avatars.githubusercontent.com/u/5377501?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomiassaf","html_url":"https://github.com/shlomiassaf","followers_url":"https://api.github.com/users/shlomiassaf/followers","following_url":"https://api.github.com/users/shlomiassaf/following{/other_user}","gists_url":"https://api.github.com/users/shlomiassaf/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomiassaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomiassaf/subscriptions","organizations_url":"https://api.github.com/users/shlomiassaf/orgs","repos_url":"https://api.github.com/users/shlomiassaf/repos","events_url":"https://api.github.com/users/shlomiassaf/events{/privacy}","received_events_url":"https://api.github.com/users/shlomiassaf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":15,"additions":1958,"deletions":1541,"changed_files":74}}
{"actor":{"display_login":"shlomiassaf"}}