{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/52612582","id":52612582,"diff_hunk":"@@ -162,7 +162,6 @@ def discover(self, url, which_tests=loader.DEFAULT):\n             # the test params. This will allow users to access avocado params\n             # from inside virt tests. This feature would only work if the virt\n             # test in question is executed from inside avocado.\n-            params['avocado_inject_params'] = True","path":"avocado_vt/loader.py","position":4,"original_position":4,"commit_id":"a8c3d7d1e9a388b4bec370fd02e4f866f43ff45d","original_commit_id":"a8c3d7d1e9a388b4bec370fd02e4f866f43ff45d","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"body":"OK.","created_at":"2016-02-11T15:05:22Z","updated_at":"2016-02-11T15:05:22Z","html_url":"https://github.com/avocado-framework/avocado-vt/pull/353#discussion_r52612582","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/52612582"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/353#discussion_r52612582"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353","id":57530402,"html_url":"https://github.com/avocado-framework/avocado-vt/pull/353","diff_url":"https://github.com/avocado-framework/avocado-vt/pull/353.diff","patch_url":"https://github.com/avocado-framework/avocado-vt/pull/353.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/353","number":353,"state":"open","locked":false,"title":"test: Rework the params handling","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"This version modifies the avocado-vt loader to inject params as `vt_params`. In the `Test.__init__` it let's the superclass to init the `self.params` using the default logic, moves it into `self.avocado_params` and initialize it's own `self.params`.\r\n\r\n~~This patch uses a new Avocado feature to initialize params directly~~\r\n~~by superclass and then moves the self.params to the expected location~~\r\n~~(self.avocado_params) and initialize to cartesian-based params instead.~~\r\n\r\nSigned-off-by: Lukáš Doktor <ldoktor@redhat.com>\r\n\r\n~~This is a second part of https://github.com/avocado-framework/avocado/pull/990~~ __this version does not require any change on avocado part.__","created_at":"2016-01-28T16:51:44Z","updated_at":"2016-02-11T15:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b603ae938f5f8f8844899f94e2f2700d3b41d72e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/353/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/a8c3d7d1e9a388b4bec370fd02e4f866f43ff45d","head":{"label":"ldoktor:params","ref":"params","sha":"a8c3d7d1e9a388b4bec370fd02e4f866f43ff45d","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"repo":{"id":37206852,"name":"avocado-vt","full_name":"ldoktor/avocado-vt","owner":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldoktor/avocado-vt","description":"Avocado Virt Test Compatibility Layer Plugin","fork":true,"url":"https://api.github.com/repos/ldoktor/avocado-vt","forks_url":"https://api.github.com/repos/ldoktor/avocado-vt/forks","keys_url":"https://api.github.com/repos/ldoktor/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldoktor/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldoktor/avocado-vt/teams","hooks_url":"https://api.github.com/repos/ldoktor/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/ldoktor/avocado-vt/events","assignees_url":"https://api.github.com/repos/ldoktor/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/ldoktor/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/ldoktor/avocado-vt/tags","blobs_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldoktor/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/ldoktor/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/ldoktor/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/ldoktor/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/ldoktor/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/ldoktor/avocado-vt/subscription","commits_url":"https://api.github.com/repos/ldoktor/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldoktor/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldoktor/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/ldoktor/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldoktor/avocado-vt/merges","archive_url":"https://api.github.com/repos/ldoktor/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldoktor/avocado-vt/downloads","issues_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/ldoktor/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/ldoktor/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/ldoktor/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldoktor/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/ldoktor/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/ldoktor/avocado-vt/deployments","created_at":"2015-06-10T15:51:41Z","updated_at":"2016-01-28T16:50:30Z","pushed_at":"2016-02-09T09:06:18Z","git_url":"git://github.com/ldoktor/avocado-vt.git","ssh_url":"git@github.com:ldoktor/avocado-vt.git","clone_url":"https://github.com/ldoktor/avocado-vt.git","svn_url":"https://github.com/ldoktor/avocado-vt","homepage":null,"size":18968,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"5e738f1ef39d7e0fd3e15325290d8d8d86d85ebf","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36371959,"name":"avocado-vt","full_name":"avocado-framework/avocado-vt","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado-vt","description":"Avocado VT Plugin","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado-vt","forks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado-vt/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado-vt/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado-vt/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/deployments","created_at":"2015-05-27T14:22:13Z","updated_at":"2016-02-04T10:06:15Z","pushed_at":"2016-02-09T09:06:18Z","git_url":"git://github.com/avocado-framework/avocado-vt.git","ssh_url":"git@github.com:avocado-framework/avocado-vt.git","clone_url":"https://github.com/avocado-framework/avocado-vt.git","svn_url":"https://github.com/avocado-framework/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":19176,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":30,"forks":37,"open_issues":30,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/353"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/353"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/a8c3d7d1e9a388b4bec370fd02e4f866f43ff45d"}}}}