{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments/84751613","pull_request_review_id":5508376,"id":84751613,"diff_hunk":"@@ -34,45 +39,91 @@ class Home extends React.Component {\n     }\n \n     render() {\n+        const {\n+            categories,\n+            banners\n+        } = this.props\n+\n         return (\n-            <div>\n-                <Logo />\n-                <Link href=\"/customer/account/login/\">\n-                    Login\n-                </Link>\n-                <h2>\n-                    Home Page\n-                </h2>\n-                <Link href=\"/potions.html\">\n-                    View potions\n-                </Link>\n-                <div>\n-                    This is an example of UTF-8 character set text: テスト勉強　チコメ\n-                </div>\n-                <div>\n-                    This is the title of the home page: {this.props.home.get('title')}\n-                </div>\n-                <div className=\"u-text-all-caps\">\n-                    This is a test\n-                </div>\n-                <Button onClick={this.triggerTapEvent}>Themed Component</Button>\n+            <div className=\"container\">\n+                {banners.length > 1 &&\n+                    <Carousel allowLooping={true}>\n+                        {banners.map(({src, href, alt}, key) => { // TODO: fix this when we put mobile assets on desktop\n+                            return (\n+                                <CarouselItem href={href} key={key}>\n+                                    <Image\n+                                        src={getAssetUrl(`static/img/homepage_carousel/${key}.png`)}\n+                                        alt={alt}\n+                                        hidePlaceholder={true}\n+                                        loadingIndicator={<SkeletonBlock height=\"84vw\" />}\n+                                    />\n+                                </CarouselItem>\n+                            )\n+                        })}\n+                    </Carousel>\n+                }\n+                {banners.length === 0 &&\n+                    // The ratio of the banner image width:height is 1:.84.\n+                    // Since the banner will be width=100%, we can use 84vw to predict the banner height.\n+                    <SkeletonBlock height=\"84vw\" />\n+                }\n+                <div className=\"c-card u-margin-all\">","path":"app/containers/home/container.js","position":74,"original_position":74,"commit_id":"49f4cced775482154ccde05330b9468beeefa7b9","original_commit_id":"49f4cced775482154ccde05330b9468beeefa7b9","user":{"login":"jeffkamo","id":734535,"avatar_url":"https://avatars.githubusercontent.com/u/734535?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffkamo","html_url":"https://github.com/jeffkamo","followers_url":"https://api.github.com/users/jeffkamo/followers","following_url":"https://api.github.com/users/jeffkamo/following{/other_user}","gists_url":"https://api.github.com/users/jeffkamo/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkamo/subscriptions","organizations_url":"https://api.github.com/users/jeffkamo/orgs","repos_url":"https://api.github.com/users/jeffkamo/repos","events_url":"https://api.github.com/users/jeffkamo/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkamo/received_events","type":"User","site_admin":false},"body":"Should there be an actual `c-card` component made?\r\n\r\nI think we'll want to refrain from decorating our markup with component styles and instead rely on the components being made into proper React components for easier reusability.","created_at":"2016-10-24T18:25:50Z","updated_at":"2016-10-24T18:25:50Z","html_url":"https://github.com/mobify/progressive-web-scaffold/pull/122#discussion_r84751613","pull_request_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments/84751613"},"html":{"href":"https://github.com/mobify/progressive-web-scaffold/pull/122#discussion_r84751613"},"pull_request":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122","id":90249202,"html_url":"https://github.com/mobify/progressive-web-scaffold/pull/122","diff_url":"https://github.com/mobify/progressive-web-scaffold/pull/122.diff","patch_url":"https://github.com/mobify/progressive-web-scaffold/pull/122.patch","issue_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/122","number":122,"state":"open","locked":false,"title":"Merlins homepage","user":{"login":"guisers","id":8797909,"avatar_url":"https://avatars.githubusercontent.com/u/8797909?v=3","gravatar_id":"","url":"https://api.github.com/users/guisers","html_url":"https://github.com/guisers","followers_url":"https://api.github.com/users/guisers/followers","following_url":"https://api.github.com/users/guisers/following{/other_user}","gists_url":"https://api.github.com/users/guisers/gists{/gist_id}","starred_url":"https://api.github.com/users/guisers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guisers/subscriptions","organizations_url":"https://api.github.com/users/guisers/orgs","repos_url":"https://api.github.com/users/guisers/repos","events_url":"https://api.github.com/users/guisers/events{/privacy}","received_events_url":"https://api.github.com/users/guisers/received_events","type":"User","site_admin":false},"body":"JIRA: https://mobify.atlassian.net/browse/WEB-916\r\nMock: http://longing-giraffe.surge.sh/#artboard4\r\n\r\n## Changes\r\n- Add Merlins homepage\r\n\r\n## TODO\r\n- [ ] merge in global fetch @fractaltheory \r\n- [ ] patch up banner logic/tests after changes to desktop\r\n\r\n## How to test-drive this PR\r\n- Serve bundle `npm run dev`\r\n- Preview Merlins\r\n- Observe homepage\r\n","created_at":"2016-10-20T17:51:51Z","updated_at":"2016-10-24T18:35:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6df2ff1c52b970bcd9fcd6c88b172f570341be3c","assignee":{"login":"guisers","id":8797909,"avatar_url":"https://avatars.githubusercontent.com/u/8797909?v=3","gravatar_id":"","url":"https://api.github.com/users/guisers","html_url":"https://github.com/guisers","followers_url":"https://api.github.com/users/guisers/followers","following_url":"https://api.github.com/users/guisers/following{/other_user}","gists_url":"https://api.github.com/users/guisers/gists{/gist_id}","starred_url":"https://api.github.com/users/guisers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guisers/subscriptions","organizations_url":"https://api.github.com/users/guisers/orgs","repos_url":"https://api.github.com/users/guisers/repos","events_url":"https://api.github.com/users/guisers/events{/privacy}","received_events_url":"https://api.github.com/users/guisers/received_events","type":"User","site_admin":false},"assignees":[{"login":"guisers","id":8797909,"avatar_url":"https://avatars.githubusercontent.com/u/8797909?v=3","gravatar_id":"","url":"https://api.github.com/users/guisers","html_url":"https://github.com/guisers","followers_url":"https://api.github.com/users/guisers/followers","following_url":"https://api.github.com/users/guisers/following{/other_user}","gists_url":"https://api.github.com/users/guisers/gists{/gist_id}","starred_url":"https://api.github.com/users/guisers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guisers/subscriptions","organizations_url":"https://api.github.com/users/guisers/orgs","repos_url":"https://api.github.com/users/guisers/repos","events_url":"https://api.github.com/users/guisers/events{/privacy}","received_events_url":"https://api.github.com/users/guisers/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122/commits","review_comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122/comments","review_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/122/comments","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/49f4cced775482154ccde05330b9468beeefa7b9","head":{"label":"mobify:merlins-homepage","ref":"merlins-homepage","sha":"49f4cced775482154ccde05330b9468beeefa7b9","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"progressive-web-scaffold","full_name":"mobify/progressive-web-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/progressive-web-scaffold","description":"The scaffold / starter kit for Progressive Web","fork":false,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold","forks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2016-10-24T18:27:03Z","pushed_at":"2016-10-24T18:31:59Z","git_url":"git://github.com/mobify/progressive-web-scaffold.git","ssh_url":"git@github.com:mobify/progressive-web-scaffold.git","clone_url":"https://github.com/mobify/progressive-web-scaffold.git","svn_url":"https://github.com/mobify/progressive-web-scaffold","homepage":null,"size":2088,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"a13dfd809be7cbb3b646a3e1745aaa6ef028d964","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"progressive-web-scaffold","full_name":"mobify/progressive-web-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/progressive-web-scaffold","description":"The scaffold / starter kit for Progressive Web","fork":false,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold","forks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2016-10-24T18:27:03Z","pushed_at":"2016-10-24T18:31:59Z","git_url":"git://github.com/mobify/progressive-web-scaffold.git","ssh_url":"git@github.com:mobify/progressive-web-scaffold.git","clone_url":"https://github.com/mobify/progressive-web-scaffold.git","svn_url":"https://github.com/mobify/progressive-web-scaffold","homepage":null,"size":2088,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122"},"html":{"href":"https://github.com/mobify/progressive-web-scaffold/pull/122"},"issue":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/122"},"comments":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/49f4cced775482154ccde05330b9468beeefa7b9"}}}}
{"actor":{"display_login":"jeffkamo"}}