{"action":"created","issue":{"url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/37","repository_url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin","labels_url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/37/comments","events_url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/37/events","html_url":"https://github.com/Ardesco/selenium-standalone-server-plugin/pull/37","id":167990662,"number":37,"title":"Correct issue with extracting wire on windows.","user":{"login":"blindenvy","id":712289,"avatar_url":"https://avatars.githubusercontent.com/u/712289?v=3","gravatar_id":"","url":"https://api.github.com/users/blindenvy","html_url":"https://github.com/blindenvy","followers_url":"https://api.github.com/users/blindenvy/followers","following_url":"https://api.github.com/users/blindenvy/following{/other_user}","gists_url":"https://api.github.com/users/blindenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/blindenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindenvy/subscriptions","organizations_url":"https://api.github.com/users/blindenvy/orgs","repos_url":"https://api.github.com/users/blindenvy/repos","events_url":"https://api.github.com/users/blindenvy/events{/privacy}","received_events_url":"https://api.github.com/users/blindenvy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-28T00:59:39Z","updated_at":"2016-08-02T08:18:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/pulls/37","html_url":"https://github.com/Ardesco/selenium-standalone-server-plugin/pull/37","diff_url":"https://github.com/Ardesco/selenium-standalone-server-plugin/pull/37.diff","patch_url":"https://github.com/Ardesco/selenium-standalone-server-plugin/pull/37.patch"},"body":"These changes will allow extraction of the wire executable when run on windows. The old code was trying to use a regular expression with String.endsWith() which doesn't support regular expressions. Instead we should be using String.matches() and use a more robust regular expression to match on. Since only the MARIONETTE driver requires the use of a regular expression we check for the driver type and if it is MARIONETTE we use matches, otherwise we still use endsWith. Note that wire archive is only in zip format on windows thus only the unzipFile was modified. I Added some test cases to check the regular expression. I tested this on windows and osx and seems to be working. "},"comment":{"url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/comments/236836029","html_url":"https://github.com/Ardesco/selenium-standalone-server-plugin/pull/37#issuecomment-236836029","issue_url":"https://api.github.com/repos/Ardesco/selenium-standalone-server-plugin/issues/37","id":236836029,"user":{"login":"Ardesco","id":1205116,"avatar_url":"https://avatars.githubusercontent.com/u/1205116?v=3","gravatar_id":"","url":"https://api.github.com/users/Ardesco","html_url":"https://github.com/Ardesco","followers_url":"https://api.github.com/users/Ardesco/followers","following_url":"https://api.github.com/users/Ardesco/following{/other_user}","gists_url":"https://api.github.com/users/Ardesco/gists{/gist_id}","starred_url":"https://api.github.com/users/Ardesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ardesco/subscriptions","organizations_url":"https://api.github.com/users/Ardesco/orgs","repos_url":"https://api.github.com/users/Ardesco/repos","events_url":"https://api.github.com/users/Ardesco/events{/privacy}","received_events_url":"https://api.github.com/users/Ardesco/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T08:18:12Z","updated_at":"2016-08-02T08:18:12Z","body":"I'll look at this tonight, however my first impressions are:\r\n\r\n- Overcomplicated regex which will bite you in the arse when they change the naming strategy.\r\n- A couple of changes in the PR are not needed and don't add any value (they are stylistic). "}}
{"actor":{"display_login":"Ardesco"}}