{"action":"created","comment":{"url":"https://api.github.com/repos/artefactual/automation-tools/pulls/comments/63390030","id":63390030,"diff_hunk":"@@ -158,8 +178,8 @@ def get_accession_id(dirname):\n     script_path = os.path.join(THIS_DIR, 'get-accession-number')\n     try:\n         p = subprocess.Popen([script_path, dirname], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n-    except FileNotFoundError:\n-        LOGGER.info('%s does not exist.', script_path)\n+    except:","path":"transfers/transfer.py","position":120,"original_position":120,"commit_id":"c29682145473201abe23be2125e54312dd83f283","original_commit_id":"c29682145473201abe23be2125e54312dd83f283","user":{"login":"Hwesta","id":3166226,"avatar_url":"https://avatars.githubusercontent.com/u/3166226?v=3","gravatar_id":"","url":"https://api.github.com/users/Hwesta","html_url":"https://github.com/Hwesta","followers_url":"https://api.github.com/users/Hwesta/followers","following_url":"https://api.github.com/users/Hwesta/following{/other_user}","gists_url":"https://api.github.com/users/Hwesta/gists{/gist_id}","starred_url":"https://api.github.com/users/Hwesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hwesta/subscriptions","organizations_url":"https://api.github.com/users/Hwesta/orgs","repos_url":"https://api.github.com/users/Hwesta/repos","events_url":"https://api.github.com/users/Hwesta/events{/privacy}","received_events_url":"https://api.github.com/users/Hwesta/received_events","type":"User","site_admin":false},"body":"Should be `except Exception:` so it doesn't catch `KeyboardInterrupt` etc https://docs.python.org/3/library/exceptions.html#exception-hierarchy Any exception handling should specify what exceptions we're expecting to catch, or at a minimum `Exception`.","created_at":"2016-05-16T17:23:28Z","updated_at":"2016-05-16T17:23:28Z","html_url":"https://github.com/artefactual/automation-tools/pull/18#discussion_r63390030","pull_request_url":"https://api.github.com/repos/artefactual/automation-tools/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/comments/63390030"},"html":{"href":"https://github.com/artefactual/automation-tools/pull/18#discussion_r63390030"},"pull_request":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/artefactual/automation-tools/pulls/18","id":67552700,"html_url":"https://github.com/artefactual/automation-tools/pull/18","diff_url":"https://github.com/artefactual/automation-tools/pull/18.diff","patch_url":"https://github.com/artefactual/automation-tools/pull/18.patch","issue_url":"https://api.github.com/repos/artefactual/automation-tools/issues/18","number":18,"state":"open","locked":false,"title":"transfers: add config file for log/db/pid file paths","user":{"login":"hakamine","id":10160634,"avatar_url":"https://avatars.githubusercontent.com/u/10160634?v=3","gravatar_id":"","url":"https://api.github.com/users/hakamine","html_url":"https://github.com/hakamine","followers_url":"https://api.github.com/users/hakamine/followers","following_url":"https://api.github.com/users/hakamine/following{/other_user}","gists_url":"https://api.github.com/users/hakamine/gists{/gist_id}","starred_url":"https://api.github.com/users/hakamine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakamine/subscriptions","organizations_url":"https://api.github.com/users/hakamine/orgs","repos_url":"https://api.github.com/users/hakamine/repos","events_url":"https://api.github.com/users/hakamine/events{/privacy}","received_events_url":"https://api.github.com/users/hakamine/received_events","type":"User","site_admin":false},"body":"Avoid creating log/db/pid files in the code path:\r\n- Make models.py and transfer.py find config information in file\r\n  /etc/archivematica/automation-tools/automation-tools.conf\r\n- Provide example config files in etc/ directory","created_at":"2016-04-22T18:23:45Z","updated_at":"2016-05-16T17:23:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9f47f02ef7674c7c111a76b0243bf17ba724486","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artefactual/automation-tools/pulls/18/commits","review_comments_url":"https://api.github.com/repos/artefactual/automation-tools/pulls/18/comments","review_comment_url":"https://api.github.com/repos/artefactual/automation-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual/automation-tools/issues/18/comments","statuses_url":"https://api.github.com/repos/artefactual/automation-tools/statuses/c29682145473201abe23be2125e54312dd83f283","head":{"label":"artefactual:dev/deploy","ref":"dev/deploy","sha":"c29682145473201abe23be2125e54312dd83f283","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":25843990,"name":"automation-tools","full_name":"artefactual/automation-tools","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/automation-tools","description":"Tools to aid automation of Archivematica and AtoM.","fork":false,"url":"https://api.github.com/repos/artefactual/automation-tools","forks_url":"https://api.github.com/repos/artefactual/automation-tools/forks","keys_url":"https://api.github.com/repos/artefactual/automation-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/automation-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/automation-tools/teams","hooks_url":"https://api.github.com/repos/artefactual/automation-tools/hooks","issue_events_url":"https://api.github.com/repos/artefactual/automation-tools/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/automation-tools/events","assignees_url":"https://api.github.com/repos/artefactual/automation-tools/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/automation-tools/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/automation-tools/tags","blobs_url":"https://api.github.com/repos/artefactual/automation-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/automation-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/automation-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/automation-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/automation-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/automation-tools/languages","stargazers_url":"https://api.github.com/repos/artefactual/automation-tools/stargazers","contributors_url":"https://api.github.com/repos/artefactual/automation-tools/contributors","subscribers_url":"https://api.github.com/repos/artefactual/automation-tools/subscribers","subscription_url":"https://api.github.com/repos/artefactual/automation-tools/subscription","commits_url":"https://api.github.com/repos/artefactual/automation-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/automation-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/automation-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/automation-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/automation-tools/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/automation-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/automation-tools/merges","archive_url":"https://api.github.com/repos/artefactual/automation-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/automation-tools/downloads","issues_url":"https://api.github.com/repos/artefactual/automation-tools/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/automation-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/automation-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/automation-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/automation-tools/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/automation-tools/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/automation-tools/deployments","created_at":"2014-10-27T23:26:50Z","updated_at":"2016-05-04T20:22:41Z","pushed_at":"2016-05-15T22:50:33Z","git_url":"git://github.com/artefactual/automation-tools.git","ssh_url":"git@github.com:artefactual/automation-tools.git","clone_url":"https://github.com/artefactual/automation-tools.git","svn_url":"https://github.com/artefactual/automation-tools","homepage":null,"size":104,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":10,"default_branch":"master"}},"base":{"label":"artefactual:master","ref":"master","sha":"326c9f0e0ac65eb535d9a543fc899cac37983fba","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":25843990,"name":"automation-tools","full_name":"artefactual/automation-tools","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/automation-tools","description":"Tools to aid automation of Archivematica and AtoM.","fork":false,"url":"https://api.github.com/repos/artefactual/automation-tools","forks_url":"https://api.github.com/repos/artefactual/automation-tools/forks","keys_url":"https://api.github.com/repos/artefactual/automation-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/automation-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/automation-tools/teams","hooks_url":"https://api.github.com/repos/artefactual/automation-tools/hooks","issue_events_url":"https://api.github.com/repos/artefactual/automation-tools/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/automation-tools/events","assignees_url":"https://api.github.com/repos/artefactual/automation-tools/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/automation-tools/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/automation-tools/tags","blobs_url":"https://api.github.com/repos/artefactual/automation-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/automation-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/automation-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/automation-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/automation-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/automation-tools/languages","stargazers_url":"https://api.github.com/repos/artefactual/automation-tools/stargazers","contributors_url":"https://api.github.com/repos/artefactual/automation-tools/contributors","subscribers_url":"https://api.github.com/repos/artefactual/automation-tools/subscribers","subscription_url":"https://api.github.com/repos/artefactual/automation-tools/subscription","commits_url":"https://api.github.com/repos/artefactual/automation-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/automation-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/automation-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/automation-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/automation-tools/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/automation-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/automation-tools/merges","archive_url":"https://api.github.com/repos/artefactual/automation-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/automation-tools/downloads","issues_url":"https://api.github.com/repos/artefactual/automation-tools/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/automation-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/automation-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/automation-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/automation-tools/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/automation-tools/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/automation-tools/deployments","created_at":"2014-10-27T23:26:50Z","updated_at":"2016-05-04T20:22:41Z","pushed_at":"2016-05-15T22:50:33Z","git_url":"git://github.com/artefactual/automation-tools.git","ssh_url":"git@github.com:artefactual/automation-tools.git","clone_url":"https://github.com/artefactual/automation-tools.git","svn_url":"https://github.com/artefactual/automation-tools","homepage":null,"size":104,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/18"},"html":{"href":"https://github.com/artefactual/automation-tools/pull/18"},"issue":{"href":"https://api.github.com/repos/artefactual/automation-tools/issues/18"},"comments":{"href":"https://api.github.com/repos/artefactual/automation-tools/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual/automation-tools/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual/automation-tools/statuses/c29682145473201abe23be2125e54312dd83f283"}}}}