{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/83644833","pull_request_review_id":4473789,"id":83644833,"diff_hunk":"@@ -209,7 +244,14 @@ case class Skewness(child: Expression) extends CentralMomentAgg(child) {\n }\n \n @ExpressionDescription(\n-  usage = \"_FUNC_(x) - Returns the Kurtosis value calculated from values of a group.\")\n+  usage =\n+    \"\"\"\n+      _FUNC_(expr) - Returns the Kurtosis value calculated from values of a group.","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala","position":89,"original_position":89,"commit_id":"2059374537496c9f81512b643e3ec084e43e2594","original_commit_id":"2059374537496c9f81512b643e3ec084e43e2594","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Same with kurtosis, they're not proper nouns","created_at":"2016-10-17T13:42:20Z","updated_at":"2016-10-17T13:44:27Z","html_url":"https://github.com/apache/spark/pull/15513#discussion_r83644833","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15513","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/83644833"},"html":{"href":"https://github.com/apache/spark/pull/15513#discussion_r83644833"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15513"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15513","id":89622877,"html_url":"https://github.com/apache/spark/pull/15513","diff_url":"https://github.com/apache/spark/pull/15513.diff","patch_url":"https://github.com/apache/spark/pull/15513.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15513","number":15513,"state":"open","locked":false,"title":"[WIP][SPARK-17963][SQL][Documentation] Add examples (extend) in each function and improve documentation with arguments","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR proposes to change the documentation for functions.\r\n\r\nThe changes include\r\n\r\n - Re-indent the documentation\r\n - Add arguments\r\n - Add examples in `extended` where the arguments are multiple or specific format (e.g. xml/ json).\r\n\r\nFor examples, the documentation was updated as below:\r\n\r\n**Before**\r\n\r\n  - `approx_count_distinct`\r\n\r\n    ```sql\r\nUsage: approx_count_distinct(expr) - Returns the estimated cardinality by HyperLogLog++.\r\n    approx_count_distinct(expr, relativeSD=0.05) - Returns the estimated cardinality by HyperLogLog++\r\n      with relativeSD, the maximum estimation error allowed.\r\n\r\nExtended Usage:\r\nNo example for approx_count_distinct.\r\n```\r\n\r\n  - `percentile_approx`\r\n\r\n    ```sql\r\nUsage:\r\n      percentile_approx(col, percentage [, accuracy]) - Returns the approximate percentile value of numeric\r\n      column `col` at the given percentage. The value of percentage must be between 0.0\r\n      and 1.0. The `accuracy` parameter (default: 10000) is a positive integer literal which\r\n      controls approximation accuracy at the cost of memory. Higher value of `accuracy` yields\r\n      better accuracy, `1.0/accuracy` is the relative error of the approximation.\r\n\r\n      percentile_approx(col, array(percentage1 [, percentage2]...) [, accuracy]) - Returns the approximate\r\n      percentile array of column `col` at the given percentage array. Each value of the\r\n      percentage array must be between 0.0 and 1.0. The `accuracy` parameter (default: 10000) is\r\n      a positive integer literal which controls approximation accuracy at the cost of memory.\r\n      Higher value of `accuracy` yields better accuracy, `1.0/accuracy` is the relative error of\r\n      the approximation.\r\n\r\nExtended Usage:\r\nNo example for percentile_approx.\r\n```\r\n\r\n**After**\r\n\r\n  - `approx_count_distinct`\r\n\r\n    ```sql\r\nUsage:\r\n      approx_count_distinct(expr) - Returns the estimated cardinality by HyperLogLog++.\r\n\r\n        Arguments:\r\n          expr - any type expression that represents data to collect the first.\r\n\r\n      approx_count_distinct(expr, relativeSD) - Returns the estimated cardinality by HyperLogLog++\r\n        with relativeSD, the maximum estimation error allowed.\r\n\r\n        Arguments:\r\n          expr - any type expression that represents data to collect the first.\r\n          relativeSD - any numeric type or any nonnumeric type literal that can be implicitly\r\n            converted to double type, that represents maximum estimation error allowed\r\n            (default = 0.05).\r\n\r\nExtended Usage: No example for approx_count_distinct.\r\n```\r\n\r\n  - `percentile_approx`\r\n\r\n    ```sql\r\nUsage:\r\n      percentile_approx(col, percentage [, accuracy]) - Returns the approximate percentile value of numeric\r\n        column `col` at the given percentage. The value of percentage must be between 0.0\r\n        and 1.0. The `accuracy` parameter (default: 10000) is a positive integer literal which\r\n        controls approximation accuracy at the cost of memory. Higher value of `accuracy` yields\r\n        better accuracy, `1.0/accuracy` is the relative error of the approximation.\r\n\r\n        Arguments:\r\n          col - any numeric type or any nonnumeric type expression that can be implicitly\r\n            converted to double type.\r\n          percentage - any numeric type or any nonnumeric type literal that can be\r\n            implicitly converted to double type.\r\n          accuracy - any numeric type or any nonnumeric type literal that can be implicitly\r\n            converted to int type.\r\n\r\n      percentile_approx(col, array(percentage1 [, percentage2]...) [, accuracy]) - Returns the approximate\r\n        percentile array of column `col` at the given percentage array. Each value of the\r\n        percentage array must be between 0.0 and 1.0. The `accuracy` parameter (default: 10000) is\r\n        a positive integer literal which controls approximation accuracy at the cost of memory.\r\n        Higher value of `accuracy` yields better accuracy, `1.0/accuracy` is the relative error of\r\n        the approximation.\r\n\r\n        Arguments:\r\n          col - any numeric type or any nonnumeric type expression that can be implicitly\r\n            converted to double type.\r\n          array(...) - an array that contains any numeric type literal that can be implicitly\r\n            converted to double type.\r\n          accuracy - any numeric type or any nonnumeric type literal that can be implicitly\r\n            converted to int type.\r\n\r\nExtended Usage:\r\n      > SELECT percentile_approx(10.0, 0.5, 100);\r\n       10.0\r\n\r\n      > SELECT percentile_approx(10.0, array(0.5, 0.4, 0.1), 100);\r\n       [10.0,10.0,10.0]\r\n```\r\n\r\n## How was this patch tested?\r\n\r\nN/A","created_at":"2016-10-17T13:26:12Z","updated_at":"2016-10-17T13:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"916c3bd4620b29f5be78601132d89cfc7eafee3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15513/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15513/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15513/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2059374537496c9f81512b643e3ec084e43e2594","head":{"label":"HyukjinKwon:SPARK-17963","ref":"SPARK-17963","sha":"2059374537496c9f81512b643e3ec084e43e2594","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"repo":{"id":42300713,"name":"spark","full_name":"HyukjinKwon/spark","owner":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HyukjinKwon/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/HyukjinKwon/spark","forks_url":"https://api.github.com/repos/HyukjinKwon/spark/forks","keys_url":"https://api.github.com/repos/HyukjinKwon/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyukjinKwon/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyukjinKwon/spark/teams","hooks_url":"https://api.github.com/repos/HyukjinKwon/spark/hooks","issue_events_url":"https://api.github.com/repos/HyukjinKwon/spark/issues/events{/number}","events_url":"https://api.github.com/repos/HyukjinKwon/spark/events","assignees_url":"https://api.github.com/repos/HyukjinKwon/spark/assignees{/user}","branches_url":"https://api.github.com/repos/HyukjinKwon/spark/branches{/branch}","tags_url":"https://api.github.com/repos/HyukjinKwon/spark/tags","blobs_url":"https://api.github.com/repos/HyukjinKwon/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyukjinKwon/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyukjinKwon/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyukjinKwon/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyukjinKwon/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/HyukjinKwon/spark/languages","stargazers_url":"https://api.github.com/repos/HyukjinKwon/spark/stargazers","contributors_url":"https://api.github.com/repos/HyukjinKwon/spark/contributors","subscribers_url":"https://api.github.com/repos/HyukjinKwon/spark/subscribers","subscription_url":"https://api.github.com/repos/HyukjinKwon/spark/subscription","commits_url":"https://api.github.com/repos/HyukjinKwon/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyukjinKwon/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyukjinKwon/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyukjinKwon/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/HyukjinKwon/spark/contents/{+path}","compare_url":"https://api.github.com/repos/HyukjinKwon/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyukjinKwon/spark/merges","archive_url":"https://api.github.com/repos/HyukjinKwon/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyukjinKwon/spark/downloads","issues_url":"https://api.github.com/repos/HyukjinKwon/spark/issues{/number}","pulls_url":"https://api.github.com/repos/HyukjinKwon/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/HyukjinKwon/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/HyukjinKwon/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyukjinKwon/spark/labels{/name}","releases_url":"https://api.github.com/repos/HyukjinKwon/spark/releases{/id}","deployments_url":"https://api.github.com/repos/HyukjinKwon/spark/deployments","created_at":"2015-09-11T09:47:43Z","updated_at":"2016-04-11T01:30:54Z","pushed_at":"2016-10-17T13:18:08Z","git_url":"git://github.com/HyukjinKwon/spark.git","ssh_url":"git@github.com:HyukjinKwon/spark.git","clone_url":"https://github.com/HyukjinKwon/spark.git","svn_url":"https://github.com/HyukjinKwon/spark","homepage":null,"size":242042,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e3bf37fa3ada43624b2e77bef90ad3d3dbcd8ce1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-10-17T10:09:44Z","pushed_at":"2016-10-17T13:26:12Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":596584,"stargazers_count":10387,"watchers_count":10387,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9651,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":476,"forks":9651,"open_issues":476,"watchers":10387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15513"},"html":{"href":"https://github.com/apache/spark/pull/15513"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15513"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15513/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15513/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15513/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2059374537496c9f81512b643e3ec084e43e2594"}}}}
{"actor":{"display_login":"srowen"}}