{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/canon-react/issues/163","repository_url":"https://api.github.com/repos/rackerlabs/canon-react","labels_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/163/comments","events_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/163/events","html_url":"https://github.com/rackerlabs/canon-react/pull/163","id":182520573,"number":163,"title":"Add optional prop to display additional content on the FormPopover footer","user":{"login":"ilmotta","id":46027,"avatar_url":"https://avatars.githubusercontent.com/u/46027?v=3","gravatar_id":"","url":"https://api.github.com/users/ilmotta","html_url":"https://github.com/ilmotta","followers_url":"https://api.github.com/users/ilmotta/followers","following_url":"https://api.github.com/users/ilmotta/following{/other_user}","gists_url":"https://api.github.com/users/ilmotta/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmotta/subscriptions","organizations_url":"https://api.github.com/users/ilmotta/orgs","repos_url":"https://api.github.com/users/ilmotta/repos","events_url":"https://api.github.com/users/ilmotta/events{/privacy}","received_events_url":"https://api.github.com/users/ilmotta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-12T13:06:19Z","updated_at":"2016-10-12T17:39:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/canon-react/pulls/163","html_url":"https://github.com/rackerlabs/canon-react/pull/163","diff_url":"https://github.com/rackerlabs/canon-react/pull/163.diff","patch_url":"https://github.com/rackerlabs/canon-react/pull/163.patch"},"body":"This PR adds a new prop to the `FormPopover` component in order to allow developers to display additional content after the control buttons/links (e.g. submit and cancel).\r\n\r\n#### Problem\r\n\r\nI have a submittable popover component using the `FormPopover` component and I need to display a right-aligned tooltip on the footer. There is no appropriate way to use a `FormPopover` and display additional content after the control buttons. The only thing similar is the `additionalControls` prop, but it is rendered before the cancel component.\r\n\r\n\r\n#### Questions\r\n\r\n1. Do you think the new prop name (`additionalInfo`) is a good one?\r\n\r\n#### Tasks\r\n\r\n- [x] Add support for new prop in `FormPopover`\r\n- [x] Implement demo\r\n- [x] Update changelog\r\n\r\n---\r\n\r\n### Screenshot of a submittable popover displaying an additional _status indicator_\r\n\r\n![image](https://cloud.githubusercontent.com/assets/46027/19312112/6f1c36ea-9067-11e6-8679-e9e6185cd362.png)"},"comment":{"url":"https://api.github.com/repos/rackerlabs/canon-react/issues/comments/253284004","html_url":"https://github.com/rackerlabs/canon-react/pull/163#issuecomment-253284004","issue_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/163","id":253284004,"user":{"login":"ilmotta","id":46027,"avatar_url":"https://avatars.githubusercontent.com/u/46027?v=3","gravatar_id":"","url":"https://api.github.com/users/ilmotta","html_url":"https://github.com/ilmotta","followers_url":"https://api.github.com/users/ilmotta/followers","following_url":"https://api.github.com/users/ilmotta/following{/other_user}","gists_url":"https://api.github.com/users/ilmotta/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmotta/subscriptions","organizations_url":"https://api.github.com/users/ilmotta/orgs","repos_url":"https://api.github.com/users/ilmotta/repos","events_url":"https://api.github.com/users/ilmotta/events{/privacy}","received_events_url":"https://api.github.com/users/ilmotta/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T17:39:52Z","updated_at":"2016-10-12T17:39:52Z","body":"@hannahstwinter, thanks for sharing your thoughts.\r\n\r\nI agree the demo can be improved. I went on the same route as the other `additionalControls` prop and tried to keep them similar. Any suggestions?\r\n\r\n> Do you think that passing in a tooltip trigger with the tooltip itself indicating 'Optional additionalControlsContent' would be any clearer?\r\n\r\nMy problem is strictly related to displaying tooltips on the footer, but I tried to keep names less specific. I think your suggestion of `additionalControlsContent` is a good one!\r\n\r\n> is this a common enough pattern to warrant putting it into Canon-React?\r\n\r\nI found a couple places with pricing tooltips as Adam said. One of them even duplicate the same behaviour as the FormPopover and implements a `tooltip` prop. My motivation was to keep things simple and perhaps reuse this feature in the future for refactorings or just for new popovers with pricing tooltips.\r\n\r\n"}}
{"actor":{"display_login":"ilmotta"}}