{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/52295910","id":52295910,"diff_hunk":"@@ -372,14 +372,4 @@ public function testGivenNonEmptyList_isNotEmpty() {\n \t\t$this->assertFalse( $references->isEmpty() );\n \t}\n \n-\tpublic function testGivenNonEmptyListWithForwardedIterator_isNotEmpty() {\n-\t\t$references = new ReferenceList();\n-\t\t$references->addNewReference( new PropertyNoValueSnak( 1 ) );\n-\t\t$references->next();","path":"tests/unit/ReferenceListTest.php","position":7,"original_position":7,"commit_id":"caeef5d8a4eadd2d56a043e1fd51ac291e8254fd","original_commit_id":"caeef5d8a4eadd2d56a043e1fd51ac291e8254fd","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"`next` is not removed, as far as I can see. Why is this test removed then?","created_at":"2016-02-09T11:28:49Z","updated_at":"2016-02-09T11:28:49Z","html_url":"https://github.com/wmde/WikibaseDataModel/pull/609#discussion_r52295910","pull_request_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609","_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/52295910"},"html":{"href":"https://github.com/wmde/WikibaseDataModel/pull/609#discussion_r52295910"},"pull_request":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609","id":58531317,"html_url":"https://github.com/wmde/WikibaseDataModel/pull/609","diff_url":"https://github.com/wmde/WikibaseDataModel/pull/609.diff","patch_url":"https://github.com/wmde/WikibaseDataModel/pull/609.patch","issue_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/609","number":609,"state":"closed","locked":false,"title":"Refactor ReferenceList","user":{"login":"Benestar","id":2998254,"avatar_url":"https://avatars.githubusercontent.com/u/2998254?v=3","gravatar_id":"","url":"https://api.github.com/users/Benestar","html_url":"https://github.com/Benestar","followers_url":"https://api.github.com/users/Benestar/followers","following_url":"https://api.github.com/users/Benestar/following{/other_user}","gists_url":"https://api.github.com/users/Benestar/gists{/gist_id}","starred_url":"https://api.github.com/users/Benestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benestar/subscriptions","organizations_url":"https://api.github.com/users/Benestar/orgs","repos_url":"https://api.github.com/users/Benestar/repos","events_url":"https://api.github.com/users/Benestar/events{/privacy}","received_events_url":"https://api.github.com/users/Benestar/received_events","type":"User","site_admin":false},"body":"This removes the inheritance between ReferenceList and SplObjectStorage\r\nand replaces it with a native array. To make the change as minimal as\r\npossible, the Countable interface and the IteratorAggregate interface are\r\nnow implemented by ReferenceList so that it can be used almost the same as\r\nbefore (like iterating over it and calling count() on it).","created_at":"2016-02-06T21:50:04Z","updated_at":"2016-02-09T11:28:49Z","closed_at":"2016-02-07T16:05:05Z","merged_at":"2016-02-07T16:05:05Z","merge_commit_sha":"3a98438843bd0b892d3ddc50f883013c65bf59eb","assignee":null,"milestone":{"url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones/15","html_url":"https://github.com/wmde/WikibaseDataModel/milestones/5.0.0","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones/15/labels","id":1230116,"number":15,"title":"5.0.0","description":"","creator":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":15,"state":"open","created_at":"2015-07-28T19:15:19Z","updated_at":"2016-02-09T10:59:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609/commits","review_comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609/comments","review_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/609/comments","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/caeef5d8a4eadd2d56a043e1fd51ac291e8254fd","head":{"label":"wmde:refactor-referencelist","ref":"refactor-referencelist","sha":"caeef5d8a4eadd2d56a043e1fd51ac291e8254fd","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15110788,"name":"WikibaseDataModel","full_name":"wmde/WikibaseDataModel","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModel","description":"PHP implementation of the Wikibase Data Model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModel","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModel/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModel/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModel/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModel/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModel/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModel/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModel/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/deployments","created_at":"2013-12-11T15:20:51Z","updated_at":"2016-01-11T10:39:20Z","pushed_at":"2016-02-09T10:59:30Z","git_url":"git://github.com/wmde/WikibaseDataModel.git","ssh_url":"git@github.com:wmde/WikibaseDataModel.git","clone_url":"https://github.com/wmde/WikibaseDataModel.git","svn_url":"https://github.com/wmde/WikibaseDataModel","homepage":"http://wikiba.se/","size":2098,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":28,"forks":5,"open_issues":28,"watchers":10,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"976c425b8013fce57b0044d6e37bd398c3016886","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15110788,"name":"WikibaseDataModel","full_name":"wmde/WikibaseDataModel","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModel","description":"PHP implementation of the Wikibase Data Model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModel","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModel/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModel/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModel/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModel/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModel/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModel/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModel/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/deployments","created_at":"2013-12-11T15:20:51Z","updated_at":"2016-01-11T10:39:20Z","pushed_at":"2016-02-09T10:59:30Z","git_url":"git://github.com/wmde/WikibaseDataModel.git","ssh_url":"git@github.com:wmde/WikibaseDataModel.git","clone_url":"https://github.com/wmde/WikibaseDataModel.git","svn_url":"https://github.com/wmde/WikibaseDataModel","homepage":"http://wikiba.se/","size":2098,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":28,"forks":5,"open_issues":28,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609"},"html":{"href":"https://github.com/wmde/WikibaseDataModel/pull/609"},"issue":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/609"},"comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/609/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/609/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/caeef5d8a4eadd2d56a043e1fd51ac291e8254fd"}}}}