{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/49247809","id":49247809,"diff_hunk":"@@ -0,0 +1,328 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ * <p/>\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * <p/>\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.storm.hdfs.spout;\n+\n+\n+import org.apache.hadoop.fs.FSDataInputStream;\n+import org.apache.hadoop.fs.FSDataOutputStream;\n+import org.apache.hadoop.fs.FileSystem;\n+import org.apache.hadoop.fs.Path;\n+import org.apache.hadoop.hdfs.DistributedFileSystem;\n+import org.apache.hadoop.hdfs.protocol.AlreadyBeingCreatedException;\n+import org.apache.hadoop.ipc.RemoteException;\n+import org.apache.storm.hdfs.common.HdfsUtils;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.io.BufferedReader;\n+import java.io.IOException;\n+import java.io.InputStreamReader;\n+import java.util.Collection;\n+\n+/**\n+ * Facility to synchronize access to HDFS files. Thread gains exclusive access to a file by acquiring\n+ * a FileLock object. The lock itself is represented as file on HDFS. Relies on atomic file creation.\n+ * Owning thread must heartbeat periodically on the lock to prevent the lock from being deemed as\n+ * stale (i.e. lock whose owning thread have died).\n+ */\n+public class FileLock {\n+\n+  private final FileSystem fs;\n+  private final String componentID;\n+  private final Path lockFile;\n+  private final FSDataOutputStream lockFileStream;\n+  private LogEntry lastEntry;\n+\n+  private static final Logger LOG = LoggerFactory.getLogger(FileLock.class);\n+\n+  private FileLock(FileSystem fs, Path lockFile, FSDataOutputStream lockFileStream, String spoutId)\n+          throws IOException {\n+    this.fs = fs;\n+    this.lockFile = lockFile;\n+    this.lockFileStream = lockFileStream;\n+    this.componentID = spoutId;\n+    logProgress(\"0\", false);\n+  }\n+\n+  private FileLock(FileSystem fs, Path lockFile, String spoutId, LogEntry entry)\n+          throws IOException {\n+    this.fs = fs;\n+    this.lockFile = lockFile;\n+    this.lockFileStream =  fs.append(lockFile);\n+    this.componentID = spoutId;\n+    LOG.info(\"Acquired abandoned lockFile {}, Spout {}\", lockFile, spoutId);\n+    logProgress(entry.fileOffset, true);\n+  }\n+\n+  public void heartbeat(String fileOffset) throws IOException {\n+    logProgress(fileOffset, true);\n+  }\n+\n+  // new line is at beginning of each line (instead of end) for better recovery from\n+  // partial writes of prior lines\n+  private void logProgress(String fileOffset, boolean prefixNewLine)\n+          throws IOException {\n+    long now = System.currentTimeMillis();\n+    LogEntry entry = new LogEntry(now, componentID, fileOffset);\n+    String line = entry.toString();\n+    if(prefixNewLine) {\n+      lockFileStream.writeBytes(System.lineSeparator() + line);\n+    }\n+    else {\n+      lockFileStream.writeBytes(line);\n+    }\n+    lockFileStream.hflush();\n+\n+    lastEntry = entry; // update this only after writing to hdfs\n+  }\n+\n+  /** Release lock by deleting file\n+   * @throws IOException if lock file could not be deleted\n+   */\n+  public void release() throws IOException {\n+    lockFileStream.close();\n+    if(!fs.delete(lockFile, false)) {\n+      LOG.warn(\"Unable to delete lock file, Spout = {}\", componentID);\n+      throw new IOException(\"Unable to delete lock file\");\n+    }\n+    LOG.debug(\"Released lock file {}. Spout {}\", lockFile, componentID);\n+  }\n+\n+  // For testing only.. invoked via reflection\n+  private void forceCloseLockFile() throws IOException {\n+    lockFileStream.close();\n+  }\n+\n+  /** returns lock on file or null if file is already locked. throws if unexpected problem */\n+  public static FileLock tryLock(FileSystem fs, Path fileToLock, Path lockDirPath, String spoutId)\n+          throws IOException {\n+    String lockFileName = lockDirPath.toString() + Path.SEPARATOR_CHAR + fileToLock.getName();\n+    Path lockFile = new Path(lockFileName);\n+\n+    try {\n+      FSDataOutputStream ostream = HdfsUtils.tryCreateFile(fs, lockFile);\n+      if (ostream != null) {\n+        LOG.debug(\"Acquired lock on file {}. LockFile= {}, Spout = {}\", fileToLock, lockFile, spoutId);\n+        return new FileLock(fs, lockFile, ostream, spoutId);\n+      } else {\n+        LOG.debug(\"Cannot lock file {} as its already locked. Spout = {}\", fileToLock, spoutId);\n+        return null;\n+      }\n+    } catch (IOException e) {\n+      LOG.error(\"Error when acquiring lock on file \" + fileToLock + \" Spout = \" + spoutId, e);\n+      throw e;\n+    }\n+  }\n+\n+  /**\n+   * checks if lockFile is older than 'olderThan' UTC time by examining the modification time\n+   * on file and (if necessary) the timestamp in last log entry in the file. If its stale, then\n+   * returns the last log entry, else returns null.\n+   * @param fs\n+   * @param lockFile\n+   * @param olderThan  time (millis) in UTC.\n+   * @return the last entry in the file if its too old. null if last entry is not too old\n+   * @throws IOException\n+   */\n+  public static LogEntry getLastEntryIfStale(FileSystem fs, Path lockFile, long olderThan)\n+          throws IOException {\n+    long modifiedTime = fs.getFileStatus(lockFile).getModificationTime();\n+    if( modifiedTime <= olderThan ) { // look\n+      //Impt: HDFS timestamp may not reflect recent appends, so we double check the\n+      // timestamp in last line of file to see when the last update was made\n+      LogEntry lastEntry =  getLastEntry(fs, lockFile);\n+      if(lastEntry==null) {\n+        throw new RuntimeException(lockFile.getName() + \" is empty. this file is invalid.\");","path":"external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/FileLock.java","position":151,"original_position":151,"commit_id":"0dd12ac2f464dbd73d0e07705eeac59494ac6ccf","original_commit_id":"0dd12ac2f464dbd73d0e07705eeac59494ac6ccf","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"Thanks for the explanation about when this can happen, but I am more concerned about how we can recover from this.  The RuntimeException when it does happen looks like it will bubble all the way up to nextTuple which will trigger the worker to shut down and restart.  But because nothing has happened to the corrupted file all of the spouts as they finish parsing their file will now go into an endless restart loop.\r\n\r\nCan we at least think about how we can recover from this situation.  Or at least not crash constantly when it does happen and yell a lot in the logs.","created_at":"2016-01-08T22:43:33Z","updated_at":"2016-01-08T22:43:33Z","html_url":"https://github.com/apache/storm/pull/936#discussion_r49247809","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/936","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/49247809"},"html":{"href":"https://github.com/apache/storm/pull/936#discussion_r49247809"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/936"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/936","id":53187976,"html_url":"https://github.com/apache/storm/pull/936","diff_url":"https://github.com/apache/storm/pull/936.diff","patch_url":"https://github.com/apache/storm/pull/936.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/936","number":936,"state":"open","locked":false,"title":"STORM-1199 : HDFS Spout Functionally complete. Not well tested. Some UTs","user":{"login":"roshannaik","id":2366541,"avatar_url":"https://avatars.githubusercontent.com/u/2366541?v=3","gravatar_id":"","url":"https://api.github.com/users/roshannaik","html_url":"https://github.com/roshannaik","followers_url":"https://api.github.com/users/roshannaik/followers","following_url":"https://api.github.com/users/roshannaik/following{/other_user}","gists_url":"https://api.github.com/users/roshannaik/gists{/gist_id}","starred_url":"https://api.github.com/users/roshannaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshannaik/subscriptions","organizations_url":"https://api.github.com/users/roshannaik/orgs","repos_url":"https://api.github.com/users/roshannaik/repos","events_url":"https://api.github.com/users/roshannaik/events{/privacy}","received_events_url":"https://api.github.com/users/roshannaik/received_events","type":"User","site_admin":false},"body":"HDFS Spout  for initial review (no Trident support).\r\n\r\n**Features:**\r\n - Monitors directory. Picks up new files as they show up.\r\n - Built-in  support for consuming Text and Sequence File formats \r\n - Extensible to other file formats. \r\n - Works with or without ACKers.\r\n - Concurrent consumption: Each spout instance consumes a different file in parallel. \r\n - Zookeeper free synchronization: HDFS based synchronization mechanism enables each spout to concurrently decide which of the available files to consume next. Spout acquires a lock on a file before consuming it. The lock files are stored in a .lock subdirectory. Lock file is deleted once file is consumed.\r\n - Archiving: Completed files are moved to a (configurable) 'done' folder \r\n - Easy progress tracking: Files being consumed are renamed with a '.inprogress' suffix allowing users to easily check which files are being processed by simply listing the dir. More more detailed info users can rely on dashboard metrics.\r\n - Read model : Buffered reads & lazy tuple parsing. Reads are buffered, but parsing out a tuple is delayed until tuple is needed. Avoids periodic latency spikes involved with 'eager' parsing (e.g Kafka spout) of the entire  batch of records. \r\n - Sliding window model used to track outstanding unACKed tuples (instead of Tumbling Window model used in Kafka spout). Tumbling window model prevents new tuple generation even if one tuple in the batch is not acked.\r\n - Support for clusters where NTP is not used to synchronize machine clocks (for identifying timed out locks - see *spout failure detection* section below). \r\n - Kerberos support\r\n\r\n**Fault Tolerance :**\r\n - Un-parseable files - are moved to a  separate (configurable) directory\r\n - I/O errors - Retry later if currently experiencing I/O errors during read\r\n - Duplicate Delivery mitigation\r\n     + Spout tracks its progress on HDFS. So if it dies, another spout can resume from where it left off, rather than reprocessing the whole file.\r\n     + Configurable number of outstanding unACKed tuples - helps contain the amount of duplicate emits when a spout takes over the job of a failed spout.\r\n - Spout Failure and Failover :\r\n  + Spout failure detection - Each spout acquires a lock on the file it is reading and periodically heartbeats (appends) its progress into the lock file with a timestamp. This helps identify stale/abandoned locks easily (based on configurable lock timeout).  Spouts periodically check for stale locks.\r\n  + Failover to another spout - A spout can take ownership of a stale lock and resume reading the file corresponding to the lock. The latest progress noted in the lock file is used to decide the location from which to resume.\r\n \r\n","created_at":"2015-12-09T22:29:55Z","updated_at":"2016-01-08T22:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d7aa12172736270bb0f036b1f5019252f1262a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/936/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/936/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/936/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/0dd12ac2f464dbd73d0e07705eeac59494ac6ccf","head":{"label":"roshannaik:STORM-1199","ref":"STORM-1199","sha":"0dd12ac2f464dbd73d0e07705eeac59494ac6ccf","user":{"login":"roshannaik","id":2366541,"avatar_url":"https://avatars.githubusercontent.com/u/2366541?v=3","gravatar_id":"","url":"https://api.github.com/users/roshannaik","html_url":"https://github.com/roshannaik","followers_url":"https://api.github.com/users/roshannaik/followers","following_url":"https://api.github.com/users/roshannaik/following{/other_user}","gists_url":"https://api.github.com/users/roshannaik/gists{/gist_id}","starred_url":"https://api.github.com/users/roshannaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshannaik/subscriptions","organizations_url":"https://api.github.com/users/roshannaik/orgs","repos_url":"https://api.github.com/users/roshannaik/repos","events_url":"https://api.github.com/users/roshannaik/events{/privacy}","received_events_url":"https://api.github.com/users/roshannaik/received_events","type":"User","site_admin":false},"repo":{"id":45638597,"name":"storm","full_name":"roshannaik/storm","owner":{"login":"roshannaik","id":2366541,"avatar_url":"https://avatars.githubusercontent.com/u/2366541?v=3","gravatar_id":"","url":"https://api.github.com/users/roshannaik","html_url":"https://github.com/roshannaik","followers_url":"https://api.github.com/users/roshannaik/followers","following_url":"https://api.github.com/users/roshannaik/following{/other_user}","gists_url":"https://api.github.com/users/roshannaik/gists{/gist_id}","starred_url":"https://api.github.com/users/roshannaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshannaik/subscriptions","organizations_url":"https://api.github.com/users/roshannaik/orgs","repos_url":"https://api.github.com/users/roshannaik/repos","events_url":"https://api.github.com/users/roshannaik/events{/privacy}","received_events_url":"https://api.github.com/users/roshannaik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roshannaik/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/roshannaik/storm","forks_url":"https://api.github.com/repos/roshannaik/storm/forks","keys_url":"https://api.github.com/repos/roshannaik/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roshannaik/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roshannaik/storm/teams","hooks_url":"https://api.github.com/repos/roshannaik/storm/hooks","issue_events_url":"https://api.github.com/repos/roshannaik/storm/issues/events{/number}","events_url":"https://api.github.com/repos/roshannaik/storm/events","assignees_url":"https://api.github.com/repos/roshannaik/storm/assignees{/user}","branches_url":"https://api.github.com/repos/roshannaik/storm/branches{/branch}","tags_url":"https://api.github.com/repos/roshannaik/storm/tags","blobs_url":"https://api.github.com/repos/roshannaik/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roshannaik/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roshannaik/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/roshannaik/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roshannaik/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/roshannaik/storm/languages","stargazers_url":"https://api.github.com/repos/roshannaik/storm/stargazers","contributors_url":"https://api.github.com/repos/roshannaik/storm/contributors","subscribers_url":"https://api.github.com/repos/roshannaik/storm/subscribers","subscription_url":"https://api.github.com/repos/roshannaik/storm/subscription","commits_url":"https://api.github.com/repos/roshannaik/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/roshannaik/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/roshannaik/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/roshannaik/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/roshannaik/storm/contents/{+path}","compare_url":"https://api.github.com/repos/roshannaik/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roshannaik/storm/merges","archive_url":"https://api.github.com/repos/roshannaik/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roshannaik/storm/downloads","issues_url":"https://api.github.com/repos/roshannaik/storm/issues{/number}","pulls_url":"https://api.github.com/repos/roshannaik/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/roshannaik/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/roshannaik/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roshannaik/storm/labels{/name}","releases_url":"https://api.github.com/repos/roshannaik/storm/releases{/id}","created_at":"2015-11-05T20:51:37Z","updated_at":"2015-11-05T20:51:45Z","pushed_at":"2016-01-08T03:23:37Z","git_url":"git://github.com/roshannaik/storm.git","ssh_url":"git@github.com:roshannaik/storm.git","clone_url":"https://github.com/roshannaik/storm.git","svn_url":"https://github.com/roshannaik/storm","homepage":null,"size":151099,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"64ff34966927d4d7c53af3bc4000375655413d81","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-01-08T09:00:59Z","pushed_at":"2016-01-08T21:28:03Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":156169,"stargazers_count":2713,"watchers_count":2713,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2032,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":77,"forks":2032,"open_issues":77,"watchers":2713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/936"},"html":{"href":"https://github.com/apache/storm/pull/936"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/936"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/0dd12ac2f464dbd73d0e07705eeac59494ac6ccf"}}}}