{"action":"created","issue":{"url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/148","repository_url":"https://api.github.com/repos/SalesforceFoundation/HEDAP","labels_url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/148/comments","events_url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/148/events","html_url":"https://github.com/SalesforceFoundation/HEDAP/pull/148","id":129893131,"number":148,"title":"Feature/label change","user":{"login":"ceiroa","id":1894238,"avatar_url":"https://avatars.githubusercontent.com/u/1894238?v=3","gravatar_id":"","url":"https://api.github.com/users/ceiroa","html_url":"https://github.com/ceiroa","followers_url":"https://api.github.com/users/ceiroa/followers","following_url":"https://api.github.com/users/ceiroa/following{/other_user}","gists_url":"https://api.github.com/users/ceiroa/gists{/gist_id}","starred_url":"https://api.github.com/users/ceiroa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceiroa/subscriptions","organizations_url":"https://api.github.com/users/ceiroa/orgs","repos_url":"https://api.github.com/users/ceiroa/repos","events_url":"https://api.github.com/users/ceiroa/events{/privacy}","received_events_url":"https://api.github.com/users/ceiroa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-29T21:53:37Z","updated_at":"2016-02-03T17:12:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/pulls/148","html_url":"https://github.com/SalesforceFoundation/HEDAP/pull/148","diff_url":"https://github.com/SalesforceFoundation/HEDAP/pull/148.diff","patch_url":"https://github.com/SalesforceFoundation/HEDAP/pull/148.patch"},"body":"# Warning\r\n\r\n# Info\r\n- Changing label from Department to Academic Program in Course Enrollment, for ease of use.\r\n- Providing object descriptions.\r\n- Enabling reports on custom objects.\r\n- Fixing bug in seasonal address overlap detection."},"comment":{"url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/comments/179353134","html_url":"https://github.com/SalesforceFoundation/HEDAP/pull/148#issuecomment-179353134","issue_url":"https://api.github.com/repos/SalesforceFoundation/HEDAP/issues/148","id":179353134,"user":{"login":"davidhabib","id":908119,"avatar_url":"https://avatars.githubusercontent.com/u/908119?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhabib","html_url":"https://github.com/davidhabib","followers_url":"https://api.github.com/users/davidhabib/followers","following_url":"https://api.github.com/users/davidhabib/following{/other_user}","gists_url":"https://api.github.com/users/davidhabib/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhabib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhabib/subscriptions","organizations_url":"https://api.github.com/users/davidhabib/orgs","repos_url":"https://api.github.com/users/davidhabib/repos","events_url":"https://api.github.com/users/davidhabib/events{/privacy}","received_events_url":"https://api.github.com/users/davidhabib/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T17:12:35Z","updated_at":"2016-02-03T17:12:35Z","body":"the problem got introduced when isSeasonalOverlap() was changed from the NPSP logic to use getStartOrEndDateOfAddrSeasonal().  the problem is getStartOrEndDateOfAddrSeasonal() is dependent on the current date (due to the reasons I explained previously).  but isSeasonalOverlap() should not include the year component if the seasonal addresses don't explicitly include year.  So I think you need to restore getStartOrEndDateOfAddrSeasonal() to what it was, and then redesign HEDAP's implementation of isSeasonalOverlap()."}}