{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/4605","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/4605/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/4605/comments","events_url":"https://api.github.com/repos/apple/swift/issues/4605/events","html_url":"https://github.com/apple/swift/pull/4605","id":174863734,"number":4605,"title":"Start moving toward a callback model for code-completion type-checking","user":{"login":"benlangmuir","id":3412956,"avatar_url":"https://avatars.githubusercontent.com/u/3412956?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangmuir","html_url":"https://github.com/benlangmuir","followers_url":"https://api.github.com/users/benlangmuir/followers","following_url":"https://api.github.com/users/benlangmuir/following{/other_user}","gists_url":"https://api.github.com/users/benlangmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangmuir/subscriptions","organizations_url":"https://api.github.com/users/benlangmuir/orgs","repos_url":"https://api.github.com/users/benlangmuir/repos","events_url":"https://api.github.com/users/benlangmuir/events{/privacy}","received_events_url":"https://api.github.com/users/benlangmuir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"benlangmuir","id":3412956,"avatar_url":"https://avatars.githubusercontent.com/u/3412956?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangmuir","html_url":"https://github.com/benlangmuir","followers_url":"https://api.github.com/users/benlangmuir/followers","following_url":"https://api.github.com/users/benlangmuir/following{/other_user}","gists_url":"https://api.github.com/users/benlangmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangmuir/subscriptions","organizations_url":"https://api.github.com/users/benlangmuir/orgs","repos_url":"https://api.github.com/users/benlangmuir/repos","events_url":"https://api.github.com/users/benlangmuir/events{/privacy}","received_events_url":"https://api.github.com/users/benlangmuir/received_events","type":"User","site_admin":false},"assignees":[{"login":"benlangmuir","id":3412956,"avatar_url":"https://avatars.githubusercontent.com/u/3412956?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangmuir","html_url":"https://github.com/benlangmuir","followers_url":"https://api.github.com/users/benlangmuir/followers","following_url":"https://api.github.com/users/benlangmuir/following{/other_user}","gists_url":"https://api.github.com/users/benlangmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangmuir/subscriptions","organizations_url":"https://api.github.com/users/benlangmuir/orgs","repos_url":"https://api.github.com/users/benlangmuir/repos","events_url":"https://api.github.com/users/benlangmuir/events{/privacy}","received_events_url":"https://api.github.com/users/benlangmuir/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-02T23:14:20Z","updated_at":"2016-09-02T23:15:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4605","html_url":"https://github.com/apple/swift/pull/4605","diff_url":"https://github.com/apple/swift/pull/4605.diff","patch_url":"https://github.com/apple/swift/pull/4605.patch"},"body":"<!-- What's in this pull request? -->\r\n... to reduce and someday eliminate all the places we do double\r\ntypechecking.  The goal is to setup any 'interesting' expressions ahead\r\nof time so that if we type-check them at any point - e.g.  during\r\nchecking the context - we don't lose the results and try to check them\r\nagain.\r\n\r\nFor now, this is limited to cases where the original expression is not\r\nreplaced by pre-checking or CSGen (i.e. we don't handle\r\nUnresolvedDeclRef through this mechanism yet), and we're only using it\r\nfor the \"parsed expression\", which is either the base of a dot\r\ncompletion, or the name in a function-call or initializer call\r\nexpression.  The intent is to move unresolved member completion to the\r\nsame model in the future.\r\n\r\nCurrently, we use the results from the callbacks for 60% of these\r\ncompletions, and of the 40% we miss, about 80% are simply\r\nUnresolvedDeclRef or similarly obvious cases.\r\n\r\nProgress toward rdar://21466394\r\nIncidentally fixes rdar://20962472\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/244508222","html_url":"https://github.com/apple/swift/pull/4605#issuecomment-244508222","issue_url":"https://api.github.com/repos/apple/swift/issues/4605","id":244508222,"user":{"login":"benlangmuir","id":3412956,"avatar_url":"https://avatars.githubusercontent.com/u/3412956?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangmuir","html_url":"https://github.com/benlangmuir","followers_url":"https://api.github.com/users/benlangmuir/followers","following_url":"https://api.github.com/users/benlangmuir/following{/other_user}","gists_url":"https://api.github.com/users/benlangmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangmuir/subscriptions","organizations_url":"https://api.github.com/users/benlangmuir/orgs","repos_url":"https://api.github.com/users/benlangmuir/repos","events_url":"https://api.github.com/users/benlangmuir/events{/privacy}","received_events_url":"https://api.github.com/users/benlangmuir/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T23:15:59Z","updated_at":"2016-09-02T23:15:59Z","body":"@swift-ci Please ASAN test"}}
{"actor":{"display_login":"benlangmuir"}}