{"push_id":1365572078,"size":8,"distinct_size":3,"ref":"refs/heads/2.8","head":"2011f447df97d5c04edf73453a9b33a4c24f0395","before":"5dfaf584fb6fd778b8d747ec457ea6182c3fd066","commits":[{"sha":"c333eb70b67e1531de0131e3a14ea3c71eb92442","author":{"name":"Christian Flothmann","email":"aba769945e5ab0e948be3a2c0061fe5823865200@sensiolabs.de"},"message":"merge tags instead of completely replacing them","distinct":false,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/c333eb70b67e1531de0131e3a14ea3c71eb92442"},{"sha":"5951378727ae4f26107899282f5ff9b89a3aa277","author":{"name":"Robin Chalas","email":"b2279aef7859a3d07e898d1552aa88f2e54a09f8@gmail.com"},"message":"A decorated service should not keep the autowiring types","distinct":true,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/5951378727ae4f26107899282f5ff9b89a3aa277"},{"sha":"7f3ce9af83358265b5cf3b6747c6e4fc996be54e","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20278 [DependencyInjection] merge tags instead of completely replacing them (xabbuh)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[DependencyInjection] merge tags instead of completely replacing them\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | yes/no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #20150, #20207\n| License       | MIT\n| Doc PR        |\n\nIn #20207, I missed the `array_merge()` call. Thus, previously set tags of the decorating service would have been discarded by the compiler pass.\n\nCommits\n-------\n\nc333eb7 merge tags instead of completely replacing them","distinct":false,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/7f3ce9af83358265b5cf3b6747c6e4fc996be54e"},{"sha":"ae68e66d7ed2f376b1d8383266d7084f0f20f88b","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20267 [DependencyInjection] A decorated service should not keep the autowiring types (chalasr)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[DependencyInjection] A decorated service should not keep the autowiring types\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | https://github.com/symfony/symfony/pull/20260#issuecomment-255364862\n| License       | MIT\n| Doc PR        | n/a\n\nWhen decorating a service which is not abstract and has `autowiring_types`, the decorator should be the one used for autowiring methods of autowired services, so we should explicitly empty them on the decorated definition after merged them into the child. See  https://github.com/symfony/symfony/pull/20260#issuecomment-255364862 for a use case where we are forced to manually empty the decorated service's `autowiring_types`.\n\nCommits\n-------\n\n5951378 A decorated service should not keep the autowiring types","distinct":true,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/ae68e66d7ed2f376b1d8383266d7084f0f20f88b"},{"sha":"7b56cc08767bfaa2b1a53f211fd657a8a8328c0f","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"removed usage of Twig_Compiler::addIndentation","distinct":false,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/7b56cc08767bfaa2b1a53f211fd657a8a8328c0f"},{"sha":"a79991f44aac63950c6406545ef9461cfb3fbc7c","author":{"name":"Tristan Darricau","email":"f27a17fc90c00d8c248d8510a1084221738b492b@nicofuma.fr"},"message":"Fix edge case with StreamedResponse where headers are sent twice","distinct":false,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/a79991f44aac63950c6406545ef9461cfb3fbc7c"},{"sha":"6bca8afb314b8d62869e75d89759028ac248e183","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20289 Fix edge case with StreamedResponse where headers are sent twice (Nicofuma)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\nFix edge case with StreamedResponse where headers are sent twice\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes/no\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nIf you have PHPs output buffering enabled (`output_buffering=4096` in your php.ini per example), there is an edge case with the StreamedResponse object where the headers are sent twice. Even if it is harmless most of the time, it can be critical sometimes (per example, if an `Access-Control-Allow-Origin` header is duplicated the browser will block the request).\n\nExplanation: because the streamed response may need the request in order to generate the content, the `StreamedResponseListener` class calls the send method of the `Response` when the event `kernel.response` is fired. To prevent the content from being duplicated, a state has been introduced in the `sendContent()` method and it works fine.\n\nBut there is an edge case is the headers of the response. If the content generated by the `sendContent()` method is smaller than the value defined for `output_buffering` in the `php.ini` then the buffer won't be flushed and the `headers_sent()` function will return false.\nTherefore when `$response->send()` is called for the second time (in the `app.php` file), the headers will be sent a second time.\n\nCommits\n-------\n\na79991f Fix edge case with StreamedResponse where headers are sent twice","distinct":false,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/6bca8afb314b8d62869e75d89759028ac248e183"},{"sha":"2011f447df97d5c04edf73453a9b33a4c24f0395","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '2.7' into 2.8\n\n* 2.7:\n  Fix edge case with StreamedResponse where headers are sent twice\n  removed usage of Twig_Compiler::addIndentation\n  merge tags instead of completely replacing them","distinct":true,"url":"https://api.github.com/repos/vincentaubert/symfony/commits/2011f447df97d5c04edf73453a9b33a4c24f0395"}]}
{"actor":{"display_login":"vincentaubert"}}