{"action":"created","issue":{"url":"https://api.github.com/repos/timj/starlink-pyast/issues/15","repository_url":"https://api.github.com/repos/timj/starlink-pyast","labels_url":"https://api.github.com/repos/timj/starlink-pyast/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/timj/starlink-pyast/issues/15/comments","events_url":"https://api.github.com/repos/timj/starlink-pyast/issues/15/events","html_url":"https://github.com/timj/starlink-pyast/pull/15","id":183258512,"number":15,"title":"Defer matplotlib","user":{"login":"timj","id":60622,"avatar_url":"https://avatars.githubusercontent.com/u/60622?v=3","gravatar_id":"","url":"https://api.github.com/users/timj","html_url":"https://github.com/timj","followers_url":"https://api.github.com/users/timj/followers","following_url":"https://api.github.com/users/timj/following{/other_user}","gists_url":"https://api.github.com/users/timj/gists{/gist_id}","starred_url":"https://api.github.com/users/timj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timj/subscriptions","organizations_url":"https://api.github.com/users/timj/orgs","repos_url":"https://api.github.com/users/timj/repos","events_url":"https://api.github.com/users/timj/events{/privacy}","received_events_url":"https://api.github.com/users/timj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-16T09:50:19Z","updated_at":"2016-10-16T14:37:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timj/starlink-pyast/pulls/15","html_url":"https://github.com/timj/starlink-pyast/pull/15","diff_url":"https://github.com/timj/starlink-pyast/pull/15.diff","patch_url":"https://github.com/timj/starlink-pyast/pull/15.patch"},"body":"This is an attempt at fixing #14 but includes a couple of extra fixes."},"comment":{"url":"https://api.github.com/repos/timj/starlink-pyast/issues/comments/254050610","html_url":"https://github.com/timj/starlink-pyast/pull/15#issuecomment-254050610","issue_url":"https://api.github.com/repos/timj/starlink-pyast/issues/15","id":254050610,"user":{"login":"rmjarvis","id":623887,"avatar_url":"https://avatars.githubusercontent.com/u/623887?v=3","gravatar_id":"","url":"https://api.github.com/users/rmjarvis","html_url":"https://github.com/rmjarvis","followers_url":"https://api.github.com/users/rmjarvis/followers","following_url":"https://api.github.com/users/rmjarvis/following{/other_user}","gists_url":"https://api.github.com/users/rmjarvis/gists{/gist_id}","starred_url":"https://api.github.com/users/rmjarvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmjarvis/subscriptions","organizations_url":"https://api.github.com/users/rmjarvis/orgs","repos_url":"https://api.github.com/users/rmjarvis/repos","events_url":"https://api.github.com/users/rmjarvis/events{/privacy}","received_events_url":"https://api.github.com/users/rmjarvis/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T14:37:51Z","updated_at":"2016-10-16T14:37:51Z","body":"This fix looks right to me.  Thank you.\r\n\r\nThe only comment I have is that your Travis tests don't run test_Atl.py, which probably would have caught this bug (since you don't have travis install matplotlib as a dependency).  So I'd suggest editing test_Atl.py to move the matplotlib stuff to a separate script (and fixing the `astrop` typo that shows up there as well) and including it in your travis script.  \r\n\r\nOr possibly add matplotlib to the travis dependencies and keep the matplotlib stuff in that test file.  But it seems like something you should include in your Travis CI.\r\n\r\nIn the longer term, I'd also suggest that this test script should include more code patterns that you list in your [Examples](http://timj.github.io/starlink-pyast/node4.html) page of the documentation.  But that's obviously a bigger job, so it deserves to be a separate issue."}}
{"actor":{"display_login":"rmjarvis"}}