{"action":"closed","issue":{"url":"https://api.github.com/repos/SmingHub/Sming/issues/528","labels_url":"https://api.github.com/repos/SmingHub/Sming/issues/528/labels{/name}","comments_url":"https://api.github.com/repos/SmingHub/Sming/issues/528/comments","events_url":"https://api.github.com/repos/SmingHub/Sming/issues/528/events","html_url":"https://github.com/SmingHub/Sming/issues/528","id":124681787,"number":528,"title":"MQTT usename and password too short for IBM iot service","user":{"login":"ericmnel","id":692338,"avatar_url":"https://avatars.githubusercontent.com/u/692338?v=3","gravatar_id":"","url":"https://api.github.com/users/ericmnel","html_url":"https://github.com/ericmnel","followers_url":"https://api.github.com/users/ericmnel/followers","following_url":"https://api.github.com/users/ericmnel/following{/other_user}","gists_url":"https://api.github.com/users/ericmnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmnel/subscriptions","organizations_url":"https://api.github.com/users/ericmnel/orgs","repos_url":"https://api.github.com/users/ericmnel/repos","events_url":"https://api.github.com/users/ericmnel/events{/privacy}","received_events_url":"https://api.github.com/users/ericmnel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-01-04T00:43:40Z","updated_at":"2016-01-05T18:09:55Z","closed_at":"2016-01-05T18:09:55Z","body":"IBM's iot service uses MQTT with a password length of 14 and a random token password (no idea how long the longest one is, but mine was 18 characters.  \r\n\r\nIn file /opt/Sming-2.0.0/Sming/Services/libemqtt/libemqtt.h\r\n\r\nin the top of the file I propose changing these two constants:\r\n\r\n    #define MQTT_CONF_USERNAME_LENGTH 13\r\n    #define MQTT_CONF_PASSWORD_LENGTH 13\r\n\r\nto be 20 for the username and 30 for the password.  15 and 19 would be the minimum but longer would be safer.\r\n\r\n\r\n"}}