{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/69712663","id":69712663,"diff_hunk":"@@ -102,6 +102,13 @@ AC_ARG_WITH([stage1-systemd-version],\n             [RKT_STAGE1_SYSTEMD_VER=\"${withval}\"],\n             [RKT_STAGE1_SYSTEMD_VER='auto'])\n \n+# STAGE1 - KVM hypervisor. LKVM is the only choice for now\n+AC_ARG_WITH([stage1-kvm-hypervisor],\n+            [AS_HELP_STRING([--with-stage1-kvm-hypervisor],\n+                            [hypervisor used by 'kvm' flavor; default and only option for now: 'lkvm'])],\n+\t\t\t    [RKT_STAGE1_KVM_HV=\"${withval}\"],","path":"configure.ac","position":8,"original_position":8,"commit_id":"0c64d5e332d0e0121b4111443d4f52a9b27b54f8","original_commit_id":"0c64d5e332d0e0121b4111443d4f52a9b27b54f8","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"Untabify and align with the `[AS_HELP_STRING…`.","created_at":"2016-07-06T11:16:52Z","updated_at":"2016-07-06T11:16:52Z","html_url":"https://github.com/coreos/rkt/pull/2684#discussion_r69712663","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2684","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/69712663"},"html":{"href":"https://github.com/coreos/rkt/pull/2684#discussion_r69712663"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2684","id":71243753,"html_url":"https://github.com/coreos/rkt/pull/2684","diff_url":"https://github.com/coreos/rkt/pull/2684.diff","patch_url":"https://github.com/coreos/rkt/pull/2684.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2684","number":2684,"state":"open","locked":false,"title":"KVM: Hypervisor support for KVM flavor","user":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"body":"Here's the first PR in our plan to put some focus on qemu as a KVM hypervisor. Whole code is based on Michał Stachowski's (@mstachowski) work in https://github.com/coreos/rkt/pull/2592 ,and it's taken by me, due to the other activities inside our company that Michał must handle. We're also closing #2592.\r\nThis code provides a generic mechanism to use different kvm hypervisors (such as lkvm, qemu-kvm), to set it by passing proper option to ./configure (New configure option --with-stage1-kvm-hypervisor). This PR covers only implementation of KvmHypervisor type and a small refactor of kvm's part of init.go to match the new KvmHypervisor interface (lkvm is the only option that could be passed to --with-stage1-kvm-hypervisor and it's also default)\r\nI fixed most of the review suggestions from #2592 ","created_at":"2016-05-24T15:40:57Z","updated_at":"2016-07-06T11:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af02c60de1bb86bb3a27b99d0ca01c5d56dcc4fa","assignee":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"assignees":[{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/42","html_url":"https://github.com/coreos/rkt/milestones/v1.10.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/42/labels","id":1815914,"number":42,"title":"v1.10.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":16,"state":"open","created_at":"2016-06-08T15:21:22Z","updated_at":"2016-07-06T10:12:33Z","due_on":"2016-07-06T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2684/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2684/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2684/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/0c64d5e332d0e0121b4111443d4f52a9b27b54f8","head":{"label":"intelsdi-x:jlakis-hypervisor","ref":"jlakis-hypervisor","sha":"0c64d5e332d0e0121b4111443d4f52a9b27b54f8","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":38779722,"name":"rkt","full_name":"intelsdi-x/rkt","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/intelsdi-x/rkt","forks_url":"https://api.github.com/repos/intelsdi-x/rkt/forks","keys_url":"https://api.github.com/repos/intelsdi-x/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/rkt/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/rkt/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/rkt/events","assignees_url":"https://api.github.com/repos/intelsdi-x/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/rkt/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/rkt/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/rkt/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/rkt/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/rkt/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/rkt/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/rkt/merges","archive_url":"https://api.github.com/repos/intelsdi-x/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/rkt/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/rkt/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/rkt/deployments","created_at":"2015-07-08T21:00:32Z","updated_at":"2016-06-16T09:44:10Z","pushed_at":"2016-07-04T11:34:06Z","git_url":"git://github.com/intelsdi-x/rkt.git","ssh_url":"git@github.com:intelsdi-x/rkt.git","clone_url":"https://github.com/intelsdi-x/rkt.git","svn_url":"https://github.com/intelsdi-x/rkt","homepage":"","size":22257,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"d4c5927a2240b18860232101bd573704fb562982","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-07-06T07:29:52Z","pushed_at":"2016-07-06T10:12:34Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28515,"stargazers_count":5680,"watchers_count":5680,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":544,"mirror_url":null,"open_issues_count":342,"forks":544,"open_issues":342,"watchers":5680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684"},"html":{"href":"https://github.com/coreos/rkt/pull/2684"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2684"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2684/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/0c64d5e332d0e0121b4111443d4f52a9b27b54f8"}}}}
{"actor":{"display_login":"krnowak"}}