{"action":"created","issue":{"url":"https://api.github.com/repos/markovmodel/variational/issues/42","repository_url":"https://api.github.com/repos/markovmodel/variational","labels_url":"https://api.github.com/repos/markovmodel/variational/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/markovmodel/variational/issues/42/comments","events_url":"https://api.github.com/repos/markovmodel/variational/issues/42/events","html_url":"https://github.com/markovmodel/variational/pull/42","id":182598864,"number":42,"title":"Cleanup and small modifications","user":{"login":"fnueske","id":11500718,"avatar_url":"https://avatars.githubusercontent.com/u/11500718?v=3","gravatar_id":"","url":"https://api.github.com/users/fnueske","html_url":"https://github.com/fnueske","followers_url":"https://api.github.com/users/fnueske/followers","following_url":"https://api.github.com/users/fnueske/following{/other_user}","gists_url":"https://api.github.com/users/fnueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fnueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnueske/subscriptions","organizations_url":"https://api.github.com/users/fnueske/orgs","repos_url":"https://api.github.com/users/fnueske/repos","events_url":"https://api.github.com/users/fnueske/events{/privacy}","received_events_url":"https://api.github.com/users/fnueske/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-10-12T18:29:11Z","updated_at":"2016-11-10T13:05:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/markovmodel/variational/pulls/42","html_url":"https://github.com/markovmodel/variational/pull/42","diff_url":"https://github.com/markovmodel/variational/pull/42.diff","patch_url":"https://github.com/markovmodel/variational/pull/42.patch"},"body":"-- Cleanup of running_moments.py: Removed options \"time_lagged\" and \"lag\" from RunningCovar, and all their uses, including tests. This was a mistake, see #35 \n-- Deleted estimators/lagged_correlation.py, because it is obsolete. This class did not use RunningCovar, the correlations were computed directly. I suggest to add an estimator for time-lagged data based on RunningCovar directly in running_moments.py\n-- Renamed solvers/qr_c/qr_solver.pyx/qr_solve to solvers/eig_qr/eig_qr.pyx/eig_qr, and added documentation.\n-- Added option \"sign_maxelement\" to solvers/direct/eig_corr. Eigenvectors can be scaled s.t. the largest element in absolute value is positive.\n"},"comment":{"url":"https://api.github.com/repos/markovmodel/variational/issues/comments/259684946","html_url":"https://github.com/markovmodel/variational/pull/42#issuecomment-259684946","issue_url":"https://api.github.com/repos/markovmodel/variational/issues/42","id":259684946,"user":{"login":"fnueske","id":11500718,"avatar_url":"https://avatars.githubusercontent.com/u/11500718?v=3","gravatar_id":"","url":"https://api.github.com/users/fnueske","html_url":"https://github.com/fnueske","followers_url":"https://api.github.com/users/fnueske/followers","following_url":"https://api.github.com/users/fnueske/following{/other_user}","gists_url":"https://api.github.com/users/fnueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fnueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnueske/subscriptions","organizations_url":"https://api.github.com/users/fnueske/orgs","repos_url":"https://api.github.com/users/fnueske/repos","events_url":"https://api.github.com/users/fnueske/events{/privacy}","received_events_url":"https://api.github.com/users/fnueske/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T13:05:05Z","updated_at":"2016-11-10T13:05:05Z","body":"As we will merge variational into pyemma, and the design will probably change many times in the near future, I suggest to just remove the tests and merge this. As you said, we can recover the tests at a later point anyway."}}
{"actor":{"display_login":"fnueske"}}