{"action":"opened","number":41,"pull_request":{"url":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41","id":81426737,"html_url":"https://github.com/dwyl/aws-sdk-mock/pull/41","diff_url":"https://github.com/dwyl/aws-sdk-mock/pull/41.diff","patch_url":"https://github.com/dwyl/aws-sdk-mock/pull/41.patch","issue_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/41","number":41,"state":"open","locked":false,"title":"Feature proposal: Validate service method params if config.paramValidation is set","user":{"login":"motiz88","id":2246565,"avatar_url":"https://avatars.githubusercontent.com/u/2246565?v=3","gravatar_id":"","url":"https://api.github.com/users/motiz88","html_url":"https://github.com/motiz88","followers_url":"https://api.github.com/users/motiz88/followers","following_url":"https://api.github.com/users/motiz88/following{/other_user}","gists_url":"https://api.github.com/users/motiz88/gists{/gist_id}","starred_url":"https://api.github.com/users/motiz88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motiz88/subscriptions","organizations_url":"https://api.github.com/users/motiz88/orgs","repos_url":"https://api.github.com/users/motiz88/repos","events_url":"https://api.github.com/users/motiz88/events{/privacy}","received_events_url":"https://api.github.com/users/motiz88/received_events","type":"User","site_admin":false},"body":"This reuses the SDK's own validation code, and is technically a breaking change: Since the default for `AWS.config.paramValidation` is `true`, currently-passing tests may break if they rely on invalid AWS calls succeeding.\r\n\r\nI initially started down the route of making all of `aws-sdk-mock`'s own tests use valid AWS input data, but quickly realized it was impractical. So I just set `paramValidation=false` globally and enabled it for the new tests only.\r\n\r\nIn my own project I do something similar for outputs, too, essentially checking that my mocks are realistic. However, this has no analog in `aws-sdk` and I'm not sure what would be the optimal way to do something similar in this module.","created_at":"2016-08-16T07:36:02Z","updated_at":"2016-08-16T07:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbff77dbd6576d36f37b7974ed2408e96a70598e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41/commits","review_comments_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41/comments","review_comment_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/41/comments","statuses_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/statuses/56c13346e426c5e42a206eeaccfe5ba5c75f190d","head":{"label":"motiz88:param-validation","ref":"param-validation","sha":"56c13346e426c5e42a206eeaccfe5ba5c75f190d","user":{"login":"motiz88","id":2246565,"avatar_url":"https://avatars.githubusercontent.com/u/2246565?v=3","gravatar_id":"","url":"https://api.github.com/users/motiz88","html_url":"https://github.com/motiz88","followers_url":"https://api.github.com/users/motiz88/followers","following_url":"https://api.github.com/users/motiz88/following{/other_user}","gists_url":"https://api.github.com/users/motiz88/gists{/gist_id}","starred_url":"https://api.github.com/users/motiz88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motiz88/subscriptions","organizations_url":"https://api.github.com/users/motiz88/orgs","repos_url":"https://api.github.com/users/motiz88/repos","events_url":"https://api.github.com/users/motiz88/events{/privacy}","received_events_url":"https://api.github.com/users/motiz88/received_events","type":"User","site_admin":false},"repo":{"id":64652445,"name":"aws-sdk-mock","full_name":"motiz88/aws-sdk-mock","owner":{"login":"motiz88","id":2246565,"avatar_url":"https://avatars.githubusercontent.com/u/2246565?v=3","gravatar_id":"","url":"https://api.github.com/users/motiz88","html_url":"https://github.com/motiz88","followers_url":"https://api.github.com/users/motiz88/followers","following_url":"https://api.github.com/users/motiz88/following{/other_user}","gists_url":"https://api.github.com/users/motiz88/gists{/gist_id}","starred_url":"https://api.github.com/users/motiz88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motiz88/subscriptions","organizations_url":"https://api.github.com/users/motiz88/orgs","repos_url":"https://api.github.com/users/motiz88/repos","events_url":"https://api.github.com/users/motiz88/events{/privacy}","received_events_url":"https://api.github.com/users/motiz88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/motiz88/aws-sdk-mock","description":":rainbow: AWSomocks for Javascript/Node.js aws-sdk tested, documented & maintained. Contributions welcome!","fork":true,"url":"https://api.github.com/repos/motiz88/aws-sdk-mock","forks_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/forks","keys_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/teams","hooks_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/hooks","issue_events_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/issues/events{/number}","events_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/events","assignees_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/assignees{/user}","branches_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/branches{/branch}","tags_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/tags","blobs_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/statuses/{sha}","languages_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/languages","stargazers_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/stargazers","contributors_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/contributors","subscribers_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/subscribers","subscription_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/subscription","commits_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/contents/{+path}","compare_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/merges","archive_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/downloads","issues_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/issues{/number}","pulls_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/pulls{/number}","milestones_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/milestones{/number}","notifications_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/labels{/name}","releases_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/releases{/id}","deployments_url":"https://api.github.com/repos/motiz88/aws-sdk-mock/deployments","created_at":"2016-08-01T09:05:21Z","updated_at":"2016-08-01T09:05:23Z","pushed_at":"2016-08-16T07:15:30Z","git_url":"git://github.com/motiz88/aws-sdk-mock.git","ssh_url":"git@github.com:motiz88/aws-sdk-mock.git","clone_url":"https://github.com/motiz88/aws-sdk-mock.git","svn_url":"https://github.com/motiz88/aws-sdk-mock","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dwyl:master","ref":"master","sha":"e42f07d69e3e3c7a5f66e7863d7c60f8cb280e25","user":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"repo":{"id":51156328,"name":"aws-sdk-mock","full_name":"dwyl/aws-sdk-mock","owner":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dwyl/aws-sdk-mock","description":":rainbow: AWSomocks for Javascript/Node.js aws-sdk tested, documented & maintained. Contributions welcome!","fork":false,"url":"https://api.github.com/repos/dwyl/aws-sdk-mock","forks_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/forks","keys_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/teams","hooks_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/hooks","issue_events_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/events{/number}","events_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/events","assignees_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/assignees{/user}","branches_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/branches{/branch}","tags_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/tags","blobs_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/statuses/{sha}","languages_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/languages","stargazers_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/stargazers","contributors_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/contributors","subscribers_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/subscribers","subscription_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/subscription","commits_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/contents/{+path}","compare_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/merges","archive_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/downloads","issues_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues{/number}","pulls_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls{/number}","milestones_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/milestones{/number}","notifications_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/labels{/name}","releases_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/releases{/id}","deployments_url":"https://api.github.com/repos/dwyl/aws-sdk-mock/deployments","created_at":"2016-02-05T15:53:07Z","updated_at":"2016-08-10T01:06:57Z","pushed_at":"2016-08-16T07:36:02Z","git_url":"git://github.com/dwyl/aws-sdk-mock.git","ssh_url":"git@github.com:dwyl/aws-sdk-mock.git","clone_url":"https://github.com/dwyl/aws-sdk-mock.git","svn_url":"https://github.com/dwyl/aws-sdk-mock","homepage":"","size":58,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41"},"html":{"href":"https://github.com/dwyl/aws-sdk-mock/pull/41"},"issue":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/41"},"comments":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/dwyl/aws-sdk-mock/statuses/56c13346e426c5e42a206eeaccfe5ba5c75f190d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"motiz88"}}