{"action":"created","issue":{"url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/16","repository_url":"https://api.github.com/repos/svkaiser/Doom64EX","labels_url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/16/comments","events_url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/16/events","html_url":"https://github.com/svkaiser/Doom64EX/issues/16","id":157243481,"number":16,"title":"Issues with CMake build system","user":{"login":"alexey-lysiuk","id":777125,"avatar_url":"https://avatars.githubusercontent.com/u/777125?v=3","gravatar_id":"","url":"https://api.github.com/users/alexey-lysiuk","html_url":"https://github.com/alexey-lysiuk","followers_url":"https://api.github.com/users/alexey-lysiuk/followers","following_url":"https://api.github.com/users/alexey-lysiuk/following{/other_user}","gists_url":"https://api.github.com/users/alexey-lysiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-lysiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-lysiuk/subscriptions","organizations_url":"https://api.github.com/users/alexey-lysiuk/orgs","repos_url":"https://api.github.com/users/alexey-lysiuk/repos","events_url":"https://api.github.com/users/alexey-lysiuk/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-lysiuk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"dotfloat","id":2150728,"avatar_url":"https://avatars.githubusercontent.com/u/2150728?v=3","gravatar_id":"","url":"https://api.github.com/users/dotfloat","html_url":"https://github.com/dotfloat","followers_url":"https://api.github.com/users/dotfloat/followers","following_url":"https://api.github.com/users/dotfloat/following{/other_user}","gists_url":"https://api.github.com/users/dotfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/dotfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotfloat/subscriptions","organizations_url":"https://api.github.com/users/dotfloat/orgs","repos_url":"https://api.github.com/users/dotfloat/repos","events_url":"https://api.github.com/users/dotfloat/events{/privacy}","received_events_url":"https://api.github.com/users/dotfloat/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-05-27T16:25:08Z","updated_at":"2016-06-07T15:08:50Z","closed_at":"2016-06-07T15:08:50Z","body":"As response to #15 I decided to create standalone Doom64EX build environment for OS X.\r\nHowever a few issues are still preventing me from finishing it:\r\n\r\n1. `kexlib` depends on `libpng`, at least `png.h` must be available. However if I don't have it somewhere in default search paths, `kexlib` will fail to build. Although the main executable target doesn't have this problem and locates `libpng` correctly.\r\n2. The same target has [a quite strange statement](https://github.com/svkaiser/Doom64EX/blob/master/src/kexlib/CMakeLists.txt#L44) for a static library:\r\n`target_link_libraries(kexlib m png)`. In fact this affects executable that is linked with this library. But what if `libpng` library is named differently, like `libpng16.a` in my case? I think this statement should be removed and replaced with proper `libpng` dependency, similar to the main executable target.\r\n3. The main executable target tries to search for `FluidSynth` headers inside `FLUIDSYNTH_INCLUDE_DIRS`. However the corresponding CMake file doesn't provide this variable but it provides `FLUIDSYNTH_INCLUDE_DIR` (without S at the end) instead.\r\n\r\nI can make a pull request with fixes however I have very limited abilities to test on other platforms. Moreover _1._ and _2._ can be fixed in various ways."},"comment":{"url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/comments/224311152","html_url":"https://github.com/svkaiser/Doom64EX/issues/16#issuecomment-224311152","issue_url":"https://api.github.com/repos/svkaiser/Doom64EX/issues/16","id":224311152,"user":{"login":"dotfloat","id":2150728,"avatar_url":"https://avatars.githubusercontent.com/u/2150728?v=3","gravatar_id":"","url":"https://api.github.com/users/dotfloat","html_url":"https://github.com/dotfloat","followers_url":"https://api.github.com/users/dotfloat/followers","following_url":"https://api.github.com/users/dotfloat/following{/other_user}","gists_url":"https://api.github.com/users/dotfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/dotfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotfloat/subscriptions","organizations_url":"https://api.github.com/users/dotfloat/orgs","repos_url":"https://api.github.com/users/dotfloat/repos","events_url":"https://api.github.com/users/dotfloat/events{/privacy}","received_events_url":"https://api.github.com/users/dotfloat/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T15:08:50Z","updated_at":"2016-06-07T15:08:50Z","body":"The kex.wad is not a dependency of the engine target.\r\n\r\nIt can be disabled by running cmake with `-DKEXWAD=OFF`."}}
{"actor":{"display_login":"dotfloat"}}