{"action":"created","comment":{"url":"https://api.github.com/repos/behdad/fonttools/pulls/comments/61624035","id":61624035,"diff_hunk":"@@ -1070,11 +1070,12 @@ def compile(self, more, haveInstructions, glyfTable):\n \t\t\t\tdata = data + struct.pack(\">HH\", self.firstPt, self.secondPt)\n \t\t\t\tflags = flags | ARG_1_AND_2_ARE_WORDS\n \t\telse:\n+\t\t\tx, y = self.roundOffset()","path":"Lib/fontTools/ttLib/tables/_g_l_y_f.py","position":4,"original_position":4,"commit_id":"09abdc3e7c83fa028e349c3a688ffefeb73a100d","original_commit_id":"09abdc3e7c83fa028e349c3a688ffefeb73a100d","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"I would think that `self.roundOffset()` would simply round the `self.x` and `self.y` in place without returning a value.\r\nIf the method does return a value, I would maybe call it `self.getRoundOffsets()`.\r\nBTW, the `GlyphCoordinates.toInt()` method does not have a return value, for example.\r\n\r\nBut these are details anyway. Thanks @khaledhosny!\r\n\r\n\r\n","created_at":"2016-04-29T18:26:34Z","updated_at":"2016-04-29T18:26:34Z","html_url":"https://github.com/behdad/fonttools/pull/598#discussion_r61624035","pull_request_url":"https://api.github.com/repos/behdad/fonttools/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/comments/61624035"},"html":{"href":"https://github.com/behdad/fonttools/pull/598#discussion_r61624035"},"pull_request":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/598"}}},"pull_request":{"url":"https://api.github.com/repos/behdad/fonttools/pulls/598","id":68393605,"html_url":"https://github.com/behdad/fonttools/pull/598","diff_url":"https://github.com/behdad/fonttools/pull/598.diff","patch_url":"https://github.com/behdad/fonttools/pull/598.patch","issue_url":"https://api.github.com/repos/behdad/fonttools/issues/598","number":598,"state":"open","locked":false,"title":"Make sure component coordinates are integers","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"body":"If they are not integers compiling the glyf table will fail.","created_at":"2016-04-29T15:55:40Z","updated_at":"2016-04-29T18:26:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ffde9ad8cca7e8e7d102a0deb6dab8396a52d95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/behdad/fonttools/pulls/598/commits","review_comments_url":"https://api.github.com/repos/behdad/fonttools/pulls/598/comments","review_comment_url":"https://api.github.com/repos/behdad/fonttools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behdad/fonttools/issues/598/comments","statuses_url":"https://api.github.com/repos/behdad/fonttools/statuses/09abdc3e7c83fa028e349c3a688ffefeb73a100d","head":{"label":"khaledhosny:ttglyphpen-int-component-coord","ref":"ttglyphpen-int-component-coord","sha":"09abdc3e7c83fa028e349c3a688ffefeb73a100d","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"repo":{"id":12779629,"name":"fonttools","full_name":"khaledhosny/fonttools","owner":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khaledhosny/fonttools","description":"Form of fonttools project from Sourceforge, with new features and bugfixes","fork":true,"url":"https://api.github.com/repos/khaledhosny/fonttools","forks_url":"https://api.github.com/repos/khaledhosny/fonttools/forks","keys_url":"https://api.github.com/repos/khaledhosny/fonttools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khaledhosny/fonttools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khaledhosny/fonttools/teams","hooks_url":"https://api.github.com/repos/khaledhosny/fonttools/hooks","issue_events_url":"https://api.github.com/repos/khaledhosny/fonttools/issues/events{/number}","events_url":"https://api.github.com/repos/khaledhosny/fonttools/events","assignees_url":"https://api.github.com/repos/khaledhosny/fonttools/assignees{/user}","branches_url":"https://api.github.com/repos/khaledhosny/fonttools/branches{/branch}","tags_url":"https://api.github.com/repos/khaledhosny/fonttools/tags","blobs_url":"https://api.github.com/repos/khaledhosny/fonttools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khaledhosny/fonttools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khaledhosny/fonttools/git/refs{/sha}","trees_url":"https://api.github.com/repos/khaledhosny/fonttools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khaledhosny/fonttools/statuses/{sha}","languages_url":"https://api.github.com/repos/khaledhosny/fonttools/languages","stargazers_url":"https://api.github.com/repos/khaledhosny/fonttools/stargazers","contributors_url":"https://api.github.com/repos/khaledhosny/fonttools/contributors","subscribers_url":"https://api.github.com/repos/khaledhosny/fonttools/subscribers","subscription_url":"https://api.github.com/repos/khaledhosny/fonttools/subscription","commits_url":"https://api.github.com/repos/khaledhosny/fonttools/commits{/sha}","git_commits_url":"https://api.github.com/repos/khaledhosny/fonttools/git/commits{/sha}","comments_url":"https://api.github.com/repos/khaledhosny/fonttools/comments{/number}","issue_comment_url":"https://api.github.com/repos/khaledhosny/fonttools/issues/comments{/number}","contents_url":"https://api.github.com/repos/khaledhosny/fonttools/contents/{+path}","compare_url":"https://api.github.com/repos/khaledhosny/fonttools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khaledhosny/fonttools/merges","archive_url":"https://api.github.com/repos/khaledhosny/fonttools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khaledhosny/fonttools/downloads","issues_url":"https://api.github.com/repos/khaledhosny/fonttools/issues{/number}","pulls_url":"https://api.github.com/repos/khaledhosny/fonttools/pulls{/number}","milestones_url":"https://api.github.com/repos/khaledhosny/fonttools/milestones{/number}","notifications_url":"https://api.github.com/repos/khaledhosny/fonttools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khaledhosny/fonttools/labels{/name}","releases_url":"https://api.github.com/repos/khaledhosny/fonttools/releases{/id}","deployments_url":"https://api.github.com/repos/khaledhosny/fonttools/deployments","created_at":"2013-09-12T09:15:06Z","updated_at":"2015-04-17T16:19:31Z","pushed_at":"2016-04-29T17:53:24Z","git_url":"git://github.com/khaledhosny/fonttools.git","ssh_url":"git@github.com:khaledhosny/fonttools.git","clone_url":"https://github.com/khaledhosny/fonttools.git","svn_url":"https://github.com/khaledhosny/fonttools","homepage":null,"size":4399,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"behdad:master","ref":"master","sha":"bdd0e6768fe97254895734f3bb9802d559318254","user":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"repo":{"id":11639637,"name":"fonttools","full_name":"behdad/fonttools","owner":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behdad/fonttools","description":"New upstream for fonttools project from Sourceforge.","fork":false,"url":"https://api.github.com/repos/behdad/fonttools","forks_url":"https://api.github.com/repos/behdad/fonttools/forks","keys_url":"https://api.github.com/repos/behdad/fonttools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behdad/fonttools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behdad/fonttools/teams","hooks_url":"https://api.github.com/repos/behdad/fonttools/hooks","issue_events_url":"https://api.github.com/repos/behdad/fonttools/issues/events{/number}","events_url":"https://api.github.com/repos/behdad/fonttools/events","assignees_url":"https://api.github.com/repos/behdad/fonttools/assignees{/user}","branches_url":"https://api.github.com/repos/behdad/fonttools/branches{/branch}","tags_url":"https://api.github.com/repos/behdad/fonttools/tags","blobs_url":"https://api.github.com/repos/behdad/fonttools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behdad/fonttools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behdad/fonttools/git/refs{/sha}","trees_url":"https://api.github.com/repos/behdad/fonttools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behdad/fonttools/statuses/{sha}","languages_url":"https://api.github.com/repos/behdad/fonttools/languages","stargazers_url":"https://api.github.com/repos/behdad/fonttools/stargazers","contributors_url":"https://api.github.com/repos/behdad/fonttools/contributors","subscribers_url":"https://api.github.com/repos/behdad/fonttools/subscribers","subscription_url":"https://api.github.com/repos/behdad/fonttools/subscription","commits_url":"https://api.github.com/repos/behdad/fonttools/commits{/sha}","git_commits_url":"https://api.github.com/repos/behdad/fonttools/git/commits{/sha}","comments_url":"https://api.github.com/repos/behdad/fonttools/comments{/number}","issue_comment_url":"https://api.github.com/repos/behdad/fonttools/issues/comments{/number}","contents_url":"https://api.github.com/repos/behdad/fonttools/contents/{+path}","compare_url":"https://api.github.com/repos/behdad/fonttools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behdad/fonttools/merges","archive_url":"https://api.github.com/repos/behdad/fonttools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behdad/fonttools/downloads","issues_url":"https://api.github.com/repos/behdad/fonttools/issues{/number}","pulls_url":"https://api.github.com/repos/behdad/fonttools/pulls{/number}","milestones_url":"https://api.github.com/repos/behdad/fonttools/milestones{/number}","notifications_url":"https://api.github.com/repos/behdad/fonttools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behdad/fonttools/labels{/name}","releases_url":"https://api.github.com/repos/behdad/fonttools/releases{/id}","deployments_url":"https://api.github.com/repos/behdad/fonttools/deployments","created_at":"2013-07-24T16:28:35Z","updated_at":"2016-04-28T11:54:44Z","pushed_at":"2016-04-29T17:53:25Z","git_url":"git://github.com/behdad/fonttools.git","ssh_url":"git@github.com:behdad/fonttools.git","clone_url":"https://github.com/behdad/fonttools.git","svn_url":"https://github.com/behdad/fonttools","homepage":"https://groups.google.com/d/forum/fonttools","size":6273,"stargazers_count":452,"watchers_count":452,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":152,"forks":105,"open_issues":152,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/598"},"html":{"href":"https://github.com/behdad/fonttools/pull/598"},"issue":{"href":"https://api.github.com/repos/behdad/fonttools/issues/598"},"comments":{"href":"https://api.github.com/repos/behdad/fonttools/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/behdad/fonttools/statuses/09abdc3e7c83fa028e349c3a688ffefeb73a100d"}}}}