{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/customgroups/issues/1","repository_url":"https://api.github.com/repos/owncloud/customgroups","labels_url":"https://api.github.com/repos/owncloud/customgroups/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/customgroups/issues/1/comments","events_url":"https://api.github.com/repos/owncloud/customgroups/issues/1/events","html_url":"https://github.com/owncloud/customgroups/pull/1","id":192290123,"number":1,"title":"Implement group backend","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"id":495503065,"url":"https://api.github.com/repos/owncloud/customgroups/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"assignees":[{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/customgroups/milestones/1","html_url":"https://github.com/owncloud/customgroups/milestone/1","labels_url":"https://api.github.com/repos/owncloud/customgroups/milestones/1/labels","id":2163982,"number":1,"title":"10.0","description":"","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2016-11-29T16:02:59Z","updated_at":"2016-12-07T17:04:27Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-11-29T14:04:23Z","updated_at":"2016-12-09T09:41:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/customgroups/pulls/1","html_url":"https://github.com/owncloud/customgroups/pull/1","diff_url":"https://github.com/owncloud/customgroups/pull/1.diff","patch_url":"https://github.com/owncloud/customgroups/pull/1.patch"},"body":"Implement group manager.\r\n\r\nTo test:\r\n\r\n1. Enable app\r\n1. Create three users \"user1\", \"user2\", \"user3\"\r\n1. `insert into oc_custom_group values (NULL, 'My friends', 'user1');`\r\n1. `insert into oc_custom_group_member values (1, 'user2');`\r\n1. `insert into oc_custom_group_member values (1, 'user3');`\r\n1. Login as \"user1\"\r\n1. Create a folder \"test\"\r\n1. Share with \"My fri\" let it autocomplete: select \"customgroup_1\" (need future work to support display names)\r\n1. Login as \"user2\" and see that the folder is visible\r\n\r\nSome concerns:\r\n- current impl lets any user share with anybody, unless admin ticks in admin page \"only allow sharing with groups in which user is member\", this could be fine as is...\r\n- need display name support in core, might need to change some group manager APIs to support returning arrays instead of just the group ids\r\n\r\n@DeepDiver1975 @butonic @jvillafanez what do you think ?"},"comment":{"url":"https://api.github.com/repos/owncloud/customgroups/issues/comments/265973027","html_url":"https://github.com/owncloud/customgroups/pull/1#issuecomment-265973027","issue_url":"https://api.github.com/repos/owncloud/customgroups/issues/1","id":265973027,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T09:41:49Z","updated_at":"2016-12-09T09:41:49Z","body":"- [ ] rename CustomGroupsManager to something that sounds more like it's a DB accessor"}}
{"actor":{"display_login":"PVince81"}}