{"action":"closed","issue":{"url":"https://api.github.com/repos/ncw/rclone/issues/861","repository_url":"https://api.github.com/repos/ncw/rclone","labels_url":"https://api.github.com/repos/ncw/rclone/issues/861/labels{/name}","comments_url":"https://api.github.com/repos/ncw/rclone/issues/861/comments","events_url":"https://api.github.com/repos/ncw/rclone/issues/861/events","html_url":"https://github.com/ncw/rclone/issues/861","id":187731239,"number":861,"title":"Can't store file with control characters (but worked previously)","user":{"login":"diamondsw","id":49737,"avatar_url":"https://avatars.githubusercontent.com/u/49737?v=3","gravatar_id":"","url":"https://api.github.com/users/diamondsw","html_url":"https://github.com/diamondsw","followers_url":"https://api.github.com/users/diamondsw/followers","following_url":"https://api.github.com/users/diamondsw/following{/other_user}","gists_url":"https://api.github.com/users/diamondsw/gists{/gist_id}","starred_url":"https://api.github.com/users/diamondsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamondsw/subscriptions","organizations_url":"https://api.github.com/users/diamondsw/orgs","repos_url":"https://api.github.com/users/diamondsw/repos","events_url":"https://api.github.com/users/diamondsw/events{/privacy}","received_events_url":"https://api.github.com/users/diamondsw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-07T14:51:56Z","updated_at":"2016-11-09T10:42:11Z","closed_at":"2016-11-09T10:42:11Z","body":"> What is your rclone version (eg output from `rclone -V`)\r\nrclone v1.34-03-g34e7ca9β\r\n> Which OS you are using and how many bits (eg Windows 7, 64 bit)\r\nDebian 8\r\n> Which cloud storage system are you using? (eg Google Drive)\r\nAmazon Cloud Drive\r\n> The command you were trying to run (eg `rclone copy /tmp remote:tmp`)\r\nrclone sync /path amazon:/path --verbose\r\n> A log from the command with the `-v` flag (eg output from `rclone -v copy /tmp remote:tmp`)\r\nLocal file system at /nfs/nas/Backup/Dante/: Can't store file with control characters: \"Icon\\r\"\r\n\r\nPreviously rclone (v1.33) would store files with control characters (such as the unfortunately common \"Icon\\r\" files created by Mac OS X - how I'd like to give that engineer a piece of my mind!). As of the latest beta, rclone no longer supports them and prints the above message, then proceeds to delete the files from Amazon Cloud Drive.\r\n\r\nHowever, it appears that the files were successfully stored by v1.33, as the delete message from v1.34beta is \"corrupted\", e.g.\r\n\": Deletedarie/2/Icon\"\r\nWhat happened is the filename printed, and when it hit the /r at the end of \"Icon/r\" it reset the position to the start of the line - and then the \": Deleted\" text overwrote beginning of the line. If the \"\\r\" hadn't been stored on ACD, then the deletion wouldn't have that carriage return in the middle. So it looks like at least some cloud services support some control characters.\r\n\r\nHonestly, it's not a big deal if these aren't backed up - it's a corner case for sure and control characters in filenames are evil. However, it's worth noting that there's at least one semi-useful case for them (Icon\\r, and the related ._Icon\\r when saved on foreign filesystems) and Amazon Cloud Drive at least stores them properly."}}
{"actor":{"display_login":"ncw"}}