{"action":"created","comment":{"url":"https://api.github.com/repos/magfest/ubersystem/pulls/comments/90295273","pull_request_review_id":10816685,"id":90295273,"diff_hunk":"@@ -81,7 +81,13 @@ def _suffix_property_check(inst, name):\n def csrf_protected(func):\n     @wraps(func)\n     def protected(*args, csrf_token, **kwargs):\n-        check_csrf(csrf_token)\n+        try:\n+            check_csrf(csrf_token)\n+        except AssertionError as e:","path":"uber/decorators.py","position":7,"original_position":7,"commit_id":"6cb9364b73e3a84794ac0663d0a3c1e5e761d5a5","original_commit_id":"6cb9364b73e3a84794ac0663d0a3c1e5e761d5a5","user":{"login":"kitsuta","id":7198215,"avatar_url":"https://avatars.githubusercontent.com/u/7198215?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsuta","html_url":"https://github.com/kitsuta","followers_url":"https://api.github.com/users/kitsuta/followers","following_url":"https://api.github.com/users/kitsuta/following{/other_user}","gists_url":"https://api.github.com/users/kitsuta/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsuta/subscriptions","organizations_url":"https://api.github.com/users/kitsuta/orgs","repos_url":"https://api.github.com/users/kitsuta/repos","events_url":"https://api.github.com/users/kitsuta/events{/privacy}","received_events_url":"https://api.github.com/users/kitsuta/received_events","type":"User","site_admin":false},"body":"You say `as e` in both these cases but then don't actually print the error. If you don't plan on printing the error or using it, you can just say `except AssertionError:`","created_at":"2016-11-30T18:26:17Z","updated_at":"2016-11-30T18:29:02Z","html_url":"https://github.com/magfest/ubersystem/pull/2167#discussion_r90295273","pull_request_url":"https://api.github.com/repos/magfest/ubersystem/pulls/2167","_links":{"self":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/comments/90295273"},"html":{"href":"https://github.com/magfest/ubersystem/pull/2167#discussion_r90295273"},"pull_request":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/2167"}}},"pull_request":{"url":"https://api.github.com/repos/magfest/ubersystem/pulls/2167","id":95419055,"html_url":"https://github.com/magfest/ubersystem/pull/2167","diff_url":"https://github.com/magfest/ubersystem/pull/2167.diff","patch_url":"https://github.com/magfest/ubersystem/pull/2167.patch","issue_url":"https://api.github.com/repos/magfest/ubersystem/issues/2167","number":2167,"state":"open","locked":false,"title":"Catch Missing CSRF_Token.","user":{"login":"migetman9","id":6538753,"avatar_url":"https://avatars.githubusercontent.com/u/6538753?v=3","gravatar_id":"","url":"https://api.github.com/users/migetman9","html_url":"https://github.com/migetman9","followers_url":"https://api.github.com/users/migetman9/followers","following_url":"https://api.github.com/users/migetman9/following{/other_user}","gists_url":"https://api.github.com/users/migetman9/gists{/gist_id}","starred_url":"https://api.github.com/users/migetman9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migetman9/subscriptions","organizations_url":"https://api.github.com/users/migetman9/orgs","repos_url":"https://api.github.com/users/migetman9/repos","events_url":"https://api.github.com/users/migetman9/events{/privacy}","received_events_url":"https://api.github.com/users/migetman9/received_events","type":"User","site_admin":false},"body":"Should catch the missing CSRF_Token error that keeps popping up in devbot-errors. Needs to have #2165 merged before this can be merged. Tested by deleting the CSRF input element from registration/form","created_at":"2016-11-27T22:17:43Z","updated_at":"2016-11-30T18:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bbc7a892aaf887cac67f2c5510a21b28d152bc5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/magfest/ubersystem/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/magfest/ubersystem/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/magfest/ubersystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magfest/ubersystem/issues/2167/comments","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/6cb9364b73e3a84794ac0663d0a3c1e5e761d5a5","head":{"label":"magfest:CSRF_Error_fix","ref":"CSRF_Error_fix","sha":"6cb9364b73e3a84794ac0663d0a3c1e5e761d5a5","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":16427229,"name":"ubersystem","full_name":"magfest/ubersystem","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/ubersystem","description":"MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more","fork":true,"url":"https://api.github.com/repos/magfest/ubersystem","forks_url":"https://api.github.com/repos/magfest/ubersystem/forks","keys_url":"https://api.github.com/repos/magfest/ubersystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/ubersystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/ubersystem/teams","hooks_url":"https://api.github.com/repos/magfest/ubersystem/hooks","issue_events_url":"https://api.github.com/repos/magfest/ubersystem/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/ubersystem/events","assignees_url":"https://api.github.com/repos/magfest/ubersystem/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/ubersystem/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/ubersystem/tags","blobs_url":"https://api.github.com/repos/magfest/ubersystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/ubersystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/ubersystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/ubersystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/ubersystem/languages","stargazers_url":"https://api.github.com/repos/magfest/ubersystem/stargazers","contributors_url":"https://api.github.com/repos/magfest/ubersystem/contributors","subscribers_url":"https://api.github.com/repos/magfest/ubersystem/subscribers","subscription_url":"https://api.github.com/repos/magfest/ubersystem/subscription","commits_url":"https://api.github.com/repos/magfest/ubersystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/ubersystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/ubersystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/ubersystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/ubersystem/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/ubersystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/ubersystem/merges","archive_url":"https://api.github.com/repos/magfest/ubersystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/ubersystem/downloads","issues_url":"https://api.github.com/repos/magfest/ubersystem/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/ubersystem/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/ubersystem/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/ubersystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/ubersystem/labels{/name}","releases_url":"https://api.github.com/repos/magfest/ubersystem/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/ubersystem/deployments","created_at":"2014-02-01T02:56:25Z","updated_at":"2016-10-26T15:36:13Z","pushed_at":"2016-11-30T18:23:52Z","git_url":"git://github.com/magfest/ubersystem.git","ssh_url":"git@github.com:magfest/ubersystem.git","clone_url":"https://github.com/magfest/ubersystem.git","svn_url":"https://github.com/magfest/ubersystem","homepage":"http://magfest.org","size":62881,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":355,"forks":6,"open_issues":355,"watchers":24,"default_branch":"master"}},"base":{"label":"magfest:master","ref":"master","sha":"3f51b25546d7c420573e5cbef605d0c4c31a3d0f","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":16427229,"name":"ubersystem","full_name":"magfest/ubersystem","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/ubersystem","description":"MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more","fork":true,"url":"https://api.github.com/repos/magfest/ubersystem","forks_url":"https://api.github.com/repos/magfest/ubersystem/forks","keys_url":"https://api.github.com/repos/magfest/ubersystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/ubersystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/ubersystem/teams","hooks_url":"https://api.github.com/repos/magfest/ubersystem/hooks","issue_events_url":"https://api.github.com/repos/magfest/ubersystem/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/ubersystem/events","assignees_url":"https://api.github.com/repos/magfest/ubersystem/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/ubersystem/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/ubersystem/tags","blobs_url":"https://api.github.com/repos/magfest/ubersystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/ubersystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/ubersystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/ubersystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/ubersystem/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/ubersystem/languages","stargazers_url":"https://api.github.com/repos/magfest/ubersystem/stargazers","contributors_url":"https://api.github.com/repos/magfest/ubersystem/contributors","subscribers_url":"https://api.github.com/repos/magfest/ubersystem/subscribers","subscription_url":"https://api.github.com/repos/magfest/ubersystem/subscription","commits_url":"https://api.github.com/repos/magfest/ubersystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/ubersystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/ubersystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/ubersystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/ubersystem/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/ubersystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/ubersystem/merges","archive_url":"https://api.github.com/repos/magfest/ubersystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/ubersystem/downloads","issues_url":"https://api.github.com/repos/magfest/ubersystem/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/ubersystem/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/ubersystem/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/ubersystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/ubersystem/labels{/name}","releases_url":"https://api.github.com/repos/magfest/ubersystem/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/ubersystem/deployments","created_at":"2014-02-01T02:56:25Z","updated_at":"2016-10-26T15:36:13Z","pushed_at":"2016-11-30T18:23:52Z","git_url":"git://github.com/magfest/ubersystem.git","ssh_url":"git@github.com:magfest/ubersystem.git","clone_url":"https://github.com/magfest/ubersystem.git","svn_url":"https://github.com/magfest/ubersystem","homepage":"http://magfest.org","size":62881,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":355,"forks":6,"open_issues":355,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/2167"},"html":{"href":"https://github.com/magfest/ubersystem/pull/2167"},"issue":{"href":"https://api.github.com/repos/magfest/ubersystem/issues/2167"},"comments":{"href":"https://api.github.com/repos/magfest/ubersystem/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magfest/ubersystem/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/magfest/ubersystem/statuses/6cb9364b73e3a84794ac0663d0a3c1e5e761d5a5"}}}}
{"actor":{"display_login":"kitsuta"}}