{"action":"created","comment":{"url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/comments/86412495","pull_request_review_id":7073622,"id":86412495,"diff_hunk":"@@ -89,7 +90,7 @@ private func algorithmFromString(string: String) -> Generator.Algorithm? {\n     return nil\n }\n \n-private func urlForToken(name name: String, issuer: String, factor: Generator.Factor, algorithm: Generator.Algorithm, digits: Int) throws -> NSURL {\n+private func urlForToken(name name: String, issuer: String, factor: Generator.Factor, algorithm: Generator.Algorithm, digits: Int, secret: String) throws -> NSURL {","path":"Sources/Token+URL.swift","position":15,"original_position":15,"commit_id":"4fc6869bab6587d31c6da761a57d018dbf4ba3f9","original_commit_id":"4fc6869bab6587d31c6da761a57d018dbf4ba3f9","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)<br>Line Length Violation: Line should be 100 characters or less: currently 164 characters (line_length)","created_at":"2016-11-03T18:28:51Z","updated_at":"2016-11-03T18:28:51Z","html_url":"https://github.com/mattrubin/OneTimePassword/pull/94#discussion_r86412495","pull_request_url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/comments/86412495"},"html":{"href":"https://github.com/mattrubin/OneTimePassword/pull/94#discussion_r86412495"},"pull_request":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94","id":91482514,"html_url":"https://github.com/mattrubin/OneTimePassword/pull/94","diff_url":"https://github.com/mattrubin/OneTimePassword/pull/94.diff","patch_url":"https://github.com/mattrubin/OneTimePassword/pull/94.patch","issue_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/94","number":94,"state":"open","locked":false,"title":"Watch","user":{"login":"algesten","id":227204,"avatar_url":"https://avatars.githubusercontent.com/u/227204?v=3","gravatar_id":"","url":"https://api.github.com/users/algesten","html_url":"https://github.com/algesten","followers_url":"https://api.github.com/users/algesten/followers","following_url":"https://api.github.com/users/algesten/following{/other_user}","gists_url":"https://api.github.com/users/algesten/gists{/gist_id}","starred_url":"https://api.github.com/users/algesten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algesten/subscriptions","organizations_url":"https://api.github.com/users/algesten/orgs","repos_url":"https://api.github.com/users/algesten/repos","events_url":"https://api.github.com/users/algesten/events{/privacy}","received_events_url":"https://api.github.com/users/algesten/received_events","type":"User","site_admin":false},"body":"Amends needed for the Watch App, notably the `resetTokens()` function and include secret in `Token.toURL()`. https://github.com/mattrubin/Authenticator/issues/151\n","created_at":"2016-10-29T07:58:17Z","updated_at":"2016-11-03T18:28:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17255a66e8ac665573afc77a02edbbede843d50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94/commits","review_comments_url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94/comments","review_comment_url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/94/comments","statuses_url":"https://api.github.com/repos/mattrubin/OneTimePassword/statuses/4fc6869bab6587d31c6da761a57d018dbf4ba3f9","head":{"label":"algesten:watch","ref":"watch","sha":"4fc6869bab6587d31c6da761a57d018dbf4ba3f9","user":{"login":"algesten","id":227204,"avatar_url":"https://avatars.githubusercontent.com/u/227204?v=3","gravatar_id":"","url":"https://api.github.com/users/algesten","html_url":"https://github.com/algesten","followers_url":"https://api.github.com/users/algesten/followers","following_url":"https://api.github.com/users/algesten/following{/other_user}","gists_url":"https://api.github.com/users/algesten/gists{/gist_id}","starred_url":"https://api.github.com/users/algesten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algesten/subscriptions","organizations_url":"https://api.github.com/users/algesten/orgs","repos_url":"https://api.github.com/users/algesten/repos","events_url":"https://api.github.com/users/algesten/events{/privacy}","received_events_url":"https://api.github.com/users/algesten/received_events","type":"User","site_admin":false},"repo":{"id":71710989,"name":"OneTimePassword","full_name":"algesten/OneTimePassword","owner":{"login":"algesten","id":227204,"avatar_url":"https://avatars.githubusercontent.com/u/227204?v=3","gravatar_id":"","url":"https://api.github.com/users/algesten","html_url":"https://github.com/algesten","followers_url":"https://api.github.com/users/algesten/followers","following_url":"https://api.github.com/users/algesten/following{/other_user}","gists_url":"https://api.github.com/users/algesten/gists{/gist_id}","starred_url":"https://api.github.com/users/algesten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algesten/subscriptions","organizations_url":"https://api.github.com/users/algesten/orgs","repos_url":"https://api.github.com/users/algesten/repos","events_url":"https://api.github.com/users/algesten/events{/privacy}","received_events_url":"https://api.github.com/users/algesten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/algesten/OneTimePassword","description":"A small library for generating TOTP and HOTP one-time passwords on iOS.","fork":true,"url":"https://api.github.com/repos/algesten/OneTimePassword","forks_url":"https://api.github.com/repos/algesten/OneTimePassword/forks","keys_url":"https://api.github.com/repos/algesten/OneTimePassword/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algesten/OneTimePassword/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algesten/OneTimePassword/teams","hooks_url":"https://api.github.com/repos/algesten/OneTimePassword/hooks","issue_events_url":"https://api.github.com/repos/algesten/OneTimePassword/issues/events{/number}","events_url":"https://api.github.com/repos/algesten/OneTimePassword/events","assignees_url":"https://api.github.com/repos/algesten/OneTimePassword/assignees{/user}","branches_url":"https://api.github.com/repos/algesten/OneTimePassword/branches{/branch}","tags_url":"https://api.github.com/repos/algesten/OneTimePassword/tags","blobs_url":"https://api.github.com/repos/algesten/OneTimePassword/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algesten/OneTimePassword/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algesten/OneTimePassword/git/refs{/sha}","trees_url":"https://api.github.com/repos/algesten/OneTimePassword/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algesten/OneTimePassword/statuses/{sha}","languages_url":"https://api.github.com/repos/algesten/OneTimePassword/languages","stargazers_url":"https://api.github.com/repos/algesten/OneTimePassword/stargazers","contributors_url":"https://api.github.com/repos/algesten/OneTimePassword/contributors","subscribers_url":"https://api.github.com/repos/algesten/OneTimePassword/subscribers","subscription_url":"https://api.github.com/repos/algesten/OneTimePassword/subscription","commits_url":"https://api.github.com/repos/algesten/OneTimePassword/commits{/sha}","git_commits_url":"https://api.github.com/repos/algesten/OneTimePassword/git/commits{/sha}","comments_url":"https://api.github.com/repos/algesten/OneTimePassword/comments{/number}","issue_comment_url":"https://api.github.com/repos/algesten/OneTimePassword/issues/comments{/number}","contents_url":"https://api.github.com/repos/algesten/OneTimePassword/contents/{+path}","compare_url":"https://api.github.com/repos/algesten/OneTimePassword/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algesten/OneTimePassword/merges","archive_url":"https://api.github.com/repos/algesten/OneTimePassword/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algesten/OneTimePassword/downloads","issues_url":"https://api.github.com/repos/algesten/OneTimePassword/issues{/number}","pulls_url":"https://api.github.com/repos/algesten/OneTimePassword/pulls{/number}","milestones_url":"https://api.github.com/repos/algesten/OneTimePassword/milestones{/number}","notifications_url":"https://api.github.com/repos/algesten/OneTimePassword/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algesten/OneTimePassword/labels{/name}","releases_url":"https://api.github.com/repos/algesten/OneTimePassword/releases{/id}","deployments_url":"https://api.github.com/repos/algesten/OneTimePassword/deployments","created_at":"2016-10-23T15:16:35Z","updated_at":"2016-10-23T15:16:36Z","pushed_at":"2016-11-03T18:28:43Z","git_url":"git://github.com/algesten/OneTimePassword.git","ssh_url":"git@github.com:algesten/OneTimePassword.git","clone_url":"https://github.com/algesten/OneTimePassword.git","svn_url":"https://github.com/algesten/OneTimePassword","homepage":"","size":778,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattrubin:master","ref":"master","sha":"c8a3ac266677c9de917dd92bfca81e51c0ee3ac2","user":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"repo":{"id":21712934,"name":"OneTimePassword","full_name":"mattrubin/OneTimePassword","owner":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars.githubusercontent.com/u/532638?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattrubin/OneTimePassword","description":"A small library for generating TOTP and HOTP one-time passwords on iOS.","fork":false,"url":"https://api.github.com/repos/mattrubin/OneTimePassword","forks_url":"https://api.github.com/repos/mattrubin/OneTimePassword/forks","keys_url":"https://api.github.com/repos/mattrubin/OneTimePassword/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattrubin/OneTimePassword/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattrubin/OneTimePassword/teams","hooks_url":"https://api.github.com/repos/mattrubin/OneTimePassword/hooks","issue_events_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/events{/number}","events_url":"https://api.github.com/repos/mattrubin/OneTimePassword/events","assignees_url":"https://api.github.com/repos/mattrubin/OneTimePassword/assignees{/user}","branches_url":"https://api.github.com/repos/mattrubin/OneTimePassword/branches{/branch}","tags_url":"https://api.github.com/repos/mattrubin/OneTimePassword/tags","blobs_url":"https://api.github.com/repos/mattrubin/OneTimePassword/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattrubin/OneTimePassword/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattrubin/OneTimePassword/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattrubin/OneTimePassword/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattrubin/OneTimePassword/statuses/{sha}","languages_url":"https://api.github.com/repos/mattrubin/OneTimePassword/languages","stargazers_url":"https://api.github.com/repos/mattrubin/OneTimePassword/stargazers","contributors_url":"https://api.github.com/repos/mattrubin/OneTimePassword/contributors","subscribers_url":"https://api.github.com/repos/mattrubin/OneTimePassword/subscribers","subscription_url":"https://api.github.com/repos/mattrubin/OneTimePassword/subscription","commits_url":"https://api.github.com/repos/mattrubin/OneTimePassword/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattrubin/OneTimePassword/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattrubin/OneTimePassword/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattrubin/OneTimePassword/contents/{+path}","compare_url":"https://api.github.com/repos/mattrubin/OneTimePassword/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattrubin/OneTimePassword/merges","archive_url":"https://api.github.com/repos/mattrubin/OneTimePassword/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattrubin/OneTimePassword/downloads","issues_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues{/number}","pulls_url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls{/number}","milestones_url":"https://api.github.com/repos/mattrubin/OneTimePassword/milestones{/number}","notifications_url":"https://api.github.com/repos/mattrubin/OneTimePassword/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattrubin/OneTimePassword/labels{/name}","releases_url":"https://api.github.com/repos/mattrubin/OneTimePassword/releases{/id}","deployments_url":"https://api.github.com/repos/mattrubin/OneTimePassword/deployments","created_at":"2014-07-10T22:49:19Z","updated_at":"2016-11-03T05:02:56Z","pushed_at":"2016-11-03T18:28:43Z","git_url":"git://github.com/mattrubin/OneTimePassword.git","ssh_url":"git@github.com:mattrubin/OneTimePassword.git","clone_url":"https://github.com/mattrubin/OneTimePassword.git","svn_url":"https://github.com/mattrubin/OneTimePassword","homepage":"","size":796,"stargazers_count":31,"watchers_count":31,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94"},"html":{"href":"https://github.com/mattrubin/OneTimePassword/pull/94"},"issue":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/94"},"comments":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/mattrubin/OneTimePassword/statuses/4fc6869bab6587d31c6da761a57d018dbf4ba3f9"}}}}
{"actor":{"display_login":"houndci-bot"}}