{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2809","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2809/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2809/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2809/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2809","id":173890430,"number":2809,"title":"Set explicit type for vmware maintenancemode timeout","user":{"login":"smitty-rh","id":16387147,"avatar_url":"https://avatars.githubusercontent.com/u/16387147?v=3","gravatar_id":"","url":"https://api.github.com/users/smitty-rh","html_url":"https://github.com/smitty-rh","followers_url":"https://api.github.com/users/smitty-rh/followers","following_url":"https://api.github.com/users/smitty-rh/following{/other_user}","gists_url":"https://api.github.com/users/smitty-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/smitty-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smitty-rh/subscriptions","organizations_url":"https://api.github.com/users/smitty-rh/orgs","repos_url":"https://api.github.com/users/smitty-rh/repos","events_url":"https://api.github.com/users/smitty-rh/events{/privacy}","received_events_url":"https://api.github.com/users/smitty-rh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/shipit","name":"shipit","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-29T22:44:12Z","updated_at":"2016-08-30T16:25:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2809","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2809","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/2809.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/2809.patch"},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\ncloud/vmware/vmware_maintenancemode.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.1.1.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = ['/root/']\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nvmware_maintenancemode.py needs explicit type for timeout, otherwise it reads timeout as string and breaks.\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n\r\n**BEFORE**\r\n```\r\nfatal: [localhost -> localhost]: FAILED! => {\"changed\": false, \"failed\": true, \"invocation\": {\"module_name\": \"vmware_maintenancemodeV2\"}, \"module_stderr\": \"/usr/lib/python2.7/site-packages/urllib3/connectionpool.py:769: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html\\n  InsecureRequestWarning)\\nTraceback (most recent call last):\\n  File \\\"/tmp/ansible_XYegBq/ansible_module_vmware_maintenancemodeV2.py\\\", line 213, in <module>\\n    main()\\n  File \\\"/tmp/ansible_XYegBq/ansible_module_vmware_maintenancemodeV2.py\\\", line 200, in main\\n    result = EnterMaintenanceMode(module, host)\\n  File \\\"/tmp/ansible_XYegBq/ansible_module_vmware_maintenancemodeV2.py\\\", line 132, in EnterMaintenanceMode\\n    spec)\\n  File \\\"/usr/lib/python2.7/site-packages/pyVmomi/VmomiSupport.py\\\", line 566, in <lambda>\\n    self.f(*(self.args + (obj,) + args), **kwargs)\\n  File \\\"/usr/lib/python2.7/site-packages/pyVmomi/VmomiSupport.py\\\", line 374, in _InvokeMethod\\n    map(CheckField, info.params, args)\\n  File \\\"/usr/lib/python2.7/site-packages/pyVmomi/VmomiSupport.py\\\", line 949, in CheckField\\n    % (info.name, info.type.__name__, valType.__name__))\\nTypeError: For \\\"timeout\\\" expected type int, but got str\\n\", \"module_stdout\": \"\", \"msg\": \"MODULE FAILURE\", \"parsed\": false}\r\n```\r\n\r\n**AFTER**\r\n```\r\nlocalhost                  : ok=2    changed=1    unreachable=0    failed=0\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/243496902","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2809#issuecomment-243496902","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2809","id":243496902,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T16:25:12Z","updated_at":"2016-08-30T16:25:12Z","body":"Thanks again to @smitty-rh for this PR, and thanks @jcpowermac, @mtnbikenc, @chrrrles for reviewing. Marking for inclusion.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}