{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/5178","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/5178/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/5178/comments","events_url":"https://api.github.com/repos/netty/netty/issues/5178/events","html_url":"https://github.com/netty/netty/pull/5178","id":151077311,"number":5178,"title":"Add startTls parameter to SslContextBuilder","user":{"login":"victornoel","id":160975,"avatar_url":"https://avatars.githubusercontent.com/u/160975?v=3","gravatar_id":"","url":"https://api.github.com/users/victornoel","html_url":"https://github.com/victornoel","followers_url":"https://api.github.com/users/victornoel/followers","following_url":"https://api.github.com/users/victornoel/following{/other_user}","gists_url":"https://api.github.com/users/victornoel/gists{/gist_id}","starred_url":"https://api.github.com/users/victornoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victornoel/subscriptions","organizations_url":"https://api.github.com/users/victornoel/orgs","repos_url":"https://api.github.com/users/victornoel/repos","events_url":"https://api.github.com/users/victornoel/events{/privacy}","received_events_url":"https://api.github.com/users/victornoel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netty/netty/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/141","html_url":"https://github.com/netty/netty/milestones/4.0.37.Final","labels_url":"https://api.github.com/repos/netty/netty/milestones/141/labels","id":1682502,"number":141,"title":"4.0.37.Final","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":88,"state":"open","created_at":"2016-04-04T16:35:57Z","updated_at":"2016-05-22T15:49:09Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-04-26T08:47:26Z","updated_at":"2016-05-23T18:22:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/5178","html_url":"https://github.com/netty/netty/pull/5178","diff_url":"https://github.com/netty/netty/pull/5178.diff","patch_url":"https://github.com/netty/netty/pull/5178.patch"},"body":"### Motivation (see also #5170):\r\n\r\nThere is an incoherence in terms of API when one wants to use startTls: without startTls one can use the SslContextBuilder's method newHandler, but with startTls, the developper is forced to call directly the SslHandler constructor.\r\n\r\n### Modifications:\r\n\r\nIntroduce startTls as a SslContextBuilder parameter as well as a member in SslContext (and thus Jdk and OpenSsl implementations!).\r\nAlways use this information to call the SslHandler constructor.\r\nUse false by default, in particular in deprecated constructors of the SSL implementations.\r\n\r\n### Results:\r\n\r\nFixes #5170 and more generally homogenise the API so that everything can be done via SslContextBuilder."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/221053213","html_url":"https://github.com/netty/netty/pull/5178#issuecomment-221053213","issue_url":"https://api.github.com/repos/netty/netty/issues/5178","id":221053213,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T18:22:37Z","updated_at":"2016-05-23T18:22:37Z","body":"@victornoel I think I will need to move this to the next netty version as I want to cut a release tomorrow"}}
{"actor":{"display_login":"normanmaurer"}}