{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/74868227","id":74868227,"diff_hunk":"@@ -0,0 +1,115 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.catalyst.analysis\n+\n+import org.apache.spark.{SparkConf, SparkContext}\n+import org.apache.spark.sql.catalyst.plans._\n+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Range}\n+import org.apache.spark.sql.catalyst.rules._\n+\n+/**\n+ * Rule that resolves table-valued function references.\n+ */\n+object ResolveTableValuedFunctions extends Rule[LogicalPlan] {\n+  private lazy val defaultParallelism =\n+    SparkContext.getOrCreate(new SparkConf(false)).defaultParallelism\n+\n+  /**\n+   * List of argument names and their types, used to declare a function.\n+   */\n+  private case class ArgumentList(args: (String, Class[_])*) {\n+    /**\n+     * @return whether this list is assignable from the given sequence of values.\n+     */\n+    def assignableFrom(values: Seq[Any]): Boolean = {\n+      if (args.length == values.length) {\n+        args.zip(values).forall { case ((name, clazz), value) =>\n+          clazz.isAssignableFrom(value.getClass)\n+        }\n+      } else {\n+        false\n+      }\n+    }\n+\n+    override def toString: String = {\n+      args.map { a =>\n+        s\"${a._1}: ${a._2.getSimpleName}\"\n+      }.mkString(\", \")\n+    }\n+  }\n+\n+  /**\n+   * A TVF maps argument lists to resolver functions that accept those arguments. Using a map\n+   * here allows for function overloading.\n+   */\n+  private type TVF = Map[ArgumentList, Seq[Any] => LogicalPlan]\n+\n+  /**\n+   * Internal registry of table-valued functions. TODO(ekl) we should have a proper registry\n+   */\n+  private val builtinFunctions: Map[String, TVF] = Map(","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala","position":65,"original_position":65,"commit_id":"4d94ac034d5138fb9015b134c39aff5647ab21ba","original_commit_id":"8517d71c051b07864edac6f760c349b8cfe323de","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"Going to at least change the types here to use catalyst datatypes instead of java classes.","created_at":"2016-08-16T02:29:54Z","updated_at":"2016-08-16T02:29:54Z","html_url":"https://github.com/apache/spark/pull/14656#discussion_r74868227","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/14656","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/74868227"},"html":{"href":"https://github.com/apache/spark/pull/14656#discussion_r74868227"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/14656"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14656","id":81390815,"html_url":"https://github.com/apache/spark/pull/14656","diff_url":"https://github.com/apache/spark/pull/14656.diff","patch_url":"https://github.com/apache/spark/pull/14656.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/14656","number":14656,"state":"open","locked":false,"title":"[SPARK-17069] Expose spark.range() as table-valued function in SQL","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis adds analyzer rules for resolving table-valued functions, and adds one builtin implementation for range(). The arguments for range() are the same as those of `spark.range()`.\r\n\r\n## How was this patch tested?\r\n\r\nUnit tests.\r\n\r\ncc @hvanhovell \r\n","created_at":"2016-08-15T23:07:29Z","updated_at":"2016-08-16T02:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c3de3fcfedcb8ea6400aa9ca26ef229de2a7c19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/14656/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/14656/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/14656/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/4d94ac034d5138fb9015b134c39aff5647ab21ba","head":{"label":"ericl:sc-4309","ref":"sc-4309","sha":"4d94ac034d5138fb9015b134c39aff5647ab21ba","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":23644625,"name":"spark","full_name":"ericl/spark","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ericl/spark","forks_url":"https://api.github.com/repos/ericl/spark/forks","keys_url":"https://api.github.com/repos/ericl/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/spark/teams","hooks_url":"https://api.github.com/repos/ericl/spark/hooks","issue_events_url":"https://api.github.com/repos/ericl/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/spark/events","assignees_url":"https://api.github.com/repos/ericl/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/spark/tags","blobs_url":"https://api.github.com/repos/ericl/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/spark/languages","stargazers_url":"https://api.github.com/repos/ericl/spark/stargazers","contributors_url":"https://api.github.com/repos/ericl/spark/contributors","subscribers_url":"https://api.github.com/repos/ericl/spark/subscribers","subscription_url":"https://api.github.com/repos/ericl/spark/subscription","commits_url":"https://api.github.com/repos/ericl/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/spark/merges","archive_url":"https://api.github.com/repos/ericl/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/spark/downloads","issues_url":"https://api.github.com/repos/ericl/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/spark/labels{/name}","releases_url":"https://api.github.com/repos/ericl/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/spark/deployments","created_at":"2014-09-04T01:48:06Z","updated_at":"2016-07-30T22:03:00Z","pushed_at":"2016-08-16T00:47:55Z","git_url":"git://github.com/ericl/spark.git","ssh_url":"git@github.com:ericl/spark.git","clone_url":"https://github.com/ericl/spark.git","svn_url":"https://github.com/ericl/spark","homepage":null,"size":167888,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"268b71d0d792f875fcfaec5314862236754a00d6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-08-16T02:20:37Z","pushed_at":"2016-08-16T02:19:46Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":505929,"stargazers_count":9655,"watchers_count":9655,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8997,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":469,"forks":8997,"open_issues":469,"watchers":9655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/14656"},"html":{"href":"https://github.com/apache/spark/pull/14656"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/14656"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/14656/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/14656/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/14656/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/4d94ac034d5138fb9015b134c39aff5647ab21ba"}}}}
{"actor":{"display_login":"ericl"}}