{"action":"closed","number":147,"pull_request":{"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147","id":55871234,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/147","diff_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/147.diff","patch_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/147.patch","issue_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/147","number":147,"state":"closed","locked":false,"title":"fix after QA - Feature/was 834 enrollment get requests","user":{"login":"autotelik","id":110434,"avatar_url":"https://avatars.githubusercontent.com/u/110434?v=3","gravatar_id":"","url":"https://api.github.com/users/autotelik","html_url":"https://github.com/autotelik","followers_url":"https://api.github.com/users/autotelik/followers","following_url":"https://api.github.com/users/autotelik/following{/other_user}","gists_url":"https://api.github.com/users/autotelik/gists{/gist_id}","starred_url":"https://api.github.com/users/autotelik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotelik/subscriptions","organizations_url":"https://api.github.com/users/autotelik/orgs","repos_url":"https://api.github.com/users/autotelik/repos","events_url":"https://api.github.com/users/autotelik/events{/privacy}","received_events_url":"https://api.github.com/users/autotelik/received_events","type":"User","site_admin":false},"body":"This fixes review page issue found in QA\r\n\r\nThe 2nd one r.e copying during searching for addresses, this is non trivial, since the original params sent to the address lookup service, are never shown in the url, so when this is copied and pasted, there are multiple failures in the code that tries to process address params since they are empty\r\n\r\nThis is the relevant code\r\n\r\napp/controllers/concerns/waste_exemptions/validate_pre_update.rb\r\naddress_params = enroll_params[\"organisation_attributes\"].\r\ntry(:fetch, \"contact_attributes\", {}).\r\nfetch(\"primary_address_attributes\", {})\r\n\r\nError is : undefined method `fetch' for nil:NilClass\r\n\r\nIMHO adding the lookup pareams to the url s is out of scope of this story, although maybe worth asking Rick if this code can be made more robust so that the fetch does not cause exception - then paste may work partially, we'd end up on the page but without the search results","created_at":"2016-01-13T09:17:04Z","updated_at":"2016-01-14T09:42:30Z","closed_at":"2016-01-14T09:42:30Z","merged_at":"2016-01-14T09:42:30Z","merge_commit_sha":"b9d089ad2bbd0f345d14d6c562ad50c372797022","assignee":{"login":"autotelik","id":110434,"avatar_url":"https://avatars.githubusercontent.com/u/110434?v=3","gravatar_id":"","url":"https://api.github.com/users/autotelik","html_url":"https://github.com/autotelik","followers_url":"https://api.github.com/users/autotelik/followers","following_url":"https://api.github.com/users/autotelik/following{/other_user}","gists_url":"https://api.github.com/users/autotelik/gists{/gist_id}","starred_url":"https://api.github.com/users/autotelik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotelik/subscriptions","organizations_url":"https://api.github.com/users/autotelik/orgs","repos_url":"https://api.github.com/users/autotelik/repos","events_url":"https://api.github.com/users/autotelik/events{/privacy}","received_events_url":"https://api.github.com/users/autotelik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147/commits","review_comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147/comments","review_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/147/comments","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/0c0ca5d8e49777d743e7d07f736346cd2cff234d","head":{"label":"EnvironmentAgency:feature/was-834-enrollment-get-requests","ref":"feature/was-834-enrollment-get-requests","sha":"0c0ca5d8e49777d743e7d07f736346cd2cff234d","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":36930252,"name":"waste-exemptions","full_name":"EnvironmentAgency/waste-exemptions","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions","description":"Waste Exemptions frontend code","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions","forks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/releases{/id}","created_at":"2015-06-05T11:55:29Z","updated_at":"2016-01-12T09:16:53Z","pushed_at":"2016-01-14T09:42:30Z","git_url":"git://github.com/EnvironmentAgency/waste-exemptions.git","ssh_url":"git@github.com:EnvironmentAgency/waste-exemptions.git","clone_url":"https://github.com/EnvironmentAgency/waste-exemptions.git","svn_url":"https://github.com/EnvironmentAgency/waste-exemptions","homepage":null,"size":1539,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"EnvironmentAgency:develop","ref":"develop","sha":"bf9313d8fd3c5419cac8dbf38a01db6388fd93ff","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":36930252,"name":"waste-exemptions","full_name":"EnvironmentAgency/waste-exemptions","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions","description":"Waste Exemptions frontend code","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions","forks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/releases{/id}","created_at":"2015-06-05T11:55:29Z","updated_at":"2016-01-12T09:16:53Z","pushed_at":"2016-01-14T09:42:30Z","git_url":"git://github.com/EnvironmentAgency/waste-exemptions.git","ssh_url":"git@github.com:EnvironmentAgency/waste-exemptions.git","clone_url":"https://github.com/EnvironmentAgency/waste-exemptions.git","svn_url":"https://github.com/EnvironmentAgency/waste-exemptions","homepage":null,"size":1539,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147"},"html":{"href":"https://github.com/EnvironmentAgency/waste-exemptions/pull/147"},"issue":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/147"},"comments":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/0c0ca5d8e49777d743e7d07f736346cd2cff234d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Cruikshanks","id":1789650,"avatar_url":"https://avatars.githubusercontent.com/u/1789650?v=3","gravatar_id":"","url":"https://api.github.com/users/Cruikshanks","html_url":"https://github.com/Cruikshanks","followers_url":"https://api.github.com/users/Cruikshanks/followers","following_url":"https://api.github.com/users/Cruikshanks/following{/other_user}","gists_url":"https://api.github.com/users/Cruikshanks/gists{/gist_id}","starred_url":"https://api.github.com/users/Cruikshanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cruikshanks/subscriptions","organizations_url":"https://api.github.com/users/Cruikshanks/orgs","repos_url":"https://api.github.com/users/Cruikshanks/repos","events_url":"https://api.github.com/users/Cruikshanks/events{/privacy}","received_events_url":"https://api.github.com/users/Cruikshanks/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":123,"deletions":64,"changed_files":8}}