{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10172","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10172/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10172/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10172/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10172","id":168687883,"number":10172,"title":"Domains and server groups ui","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/no","name":"darga/no","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/hawkular","name":"providers/hawkular","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"assignees":[{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2016-08-01T16:31:59Z","updated_at":"2016-08-15T15:07:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10172","html_url":"https://github.com/ManageIQ/manageiq/pull/10172","diff_url":"https://github.com/ManageIQ/manageiq/pull/10172.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10172.patch"},"body":"A follow-up PR for #10048 (views, controllers, tests, also adding the tag support for the models)\r\n\r\n![screenshot from 2016-08-04 18-37-14](https://cloud.githubusercontent.com/assets/535866/17410138/b7157a04-5a72-11e6-91fa-ce367d68ae6d.png)\r\n\r\n\r\nTODO:\r\n- [x] once the #10048 is merged, do a rebase to allow easier review\r\n- [x] tests\r\n- [x] make sure the tagging is working properly for domains and for the server groups\r\n- [x] ~~the topology (but this will be probably done in a follow-up PR)~~\r\n- [x] the relationship 'accordion' component is sometimes missing\r\n\r\n@miq-bot add_labels enhancement, providers/hawkular, ui, wip, darga/no\r\ncc @abonas"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/239826893","html_url":"https://github.com/ManageIQ/manageiq/pull/10172#issuecomment-239826893","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10172","id":239826893,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T15:07:01Z","updated_at":"2016-08-15T15:07:01Z","body":"<rubocop />Checked commits https://github.com/Jiri-Kremser/manageiq/compare/d4791aa4a93b6f3abaabe06b51c107bfd4a999a1~...932596befdbde04852b0510a4c854d09f71bcce1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n28 files checked, 7 offenses detected\n\n**app/helpers/middleware_domain_helper/textual_summary.rb**\n- [ ] :exclamation: - [Line 2](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/helpers/middleware_domain_helper/textual_summary.rb#L2), Col 1 - [Style/EmptyLinesAroundModuleBody](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/EmptyLinesAroundModuleBody) - Extra empty line detected at module body beginning.\n\n**app/helpers/middleware_server_group_helper/textual_summary.rb**\n- [ ] :exclamation: - [Line 2](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/helpers/middleware_server_group_helper/textual_summary.rb#L2), Col 1 - [Style/EmptyLinesAroundModuleBody](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/EmptyLinesAroundModuleBody) - Extra empty line detected at module body beginning.\n\n**app/presenters/menu/default_menu.rb**\n- [ ] :grey_exclamation: - [Line 141](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/presenters/menu/default_menu.rb#L141), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [187/120]\n\n**app/views/configuration/_ui_2.html.haml**\n- [ ] :warning: - [Line 62](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/views/configuration/_ui_2.html.haml#L62) - Line is too long. [210/160]\n- [ ] :warning: - [Line 71](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/views/configuration/_ui_2.html.haml#L71) - Line is too long. [167/160]\n\n**app/views/layouts/listnav/_middleware_domain.html.haml**\n- [ ] :warning: - [Line 9](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/views/layouts/listnav/_middleware_domain.html.haml#L9) - Redundant curly braces around a hash parameter.\n\n**app/views/layouts/listnav/_middleware_server_group.html.haml**\n- [ ] :warning: - [Line 9](https://github.com/Jiri-Kremser/manageiq/blob/932596befdbde04852b0510a4c854d09f71bcce1/app/views/layouts/listnav/_middleware_server_group.html.haml#L9) - Redundant curly braces around a hash parameter.\n"}}
{"actor":{"display_login":"miq-bot"}}