{"action":"opened","number":193,"pull_request":{"url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193","id":73478783,"html_url":"https://github.com/DataDog/puppet-datadog-agent/pull/193","diff_url":"https://github.com/DataDog/puppet-datadog-agent/pull/193.diff","patch_url":"https://github.com/DataDog/puppet-datadog-agent/pull/193.patch","issue_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/193","number":193,"state":"open","locked":false,"title":"Removing include datadog_agent, adding Class require. Cleaning up lin…","user":{"login":"shawn-sterling","id":994100,"avatar_url":"https://avatars.githubusercontent.com/u/994100?v=3","gravatar_id":"","url":"https://api.github.com/users/shawn-sterling","html_url":"https://github.com/shawn-sterling","followers_url":"https://api.github.com/users/shawn-sterling/followers","following_url":"https://api.github.com/users/shawn-sterling/following{/other_user}","gists_url":"https://api.github.com/users/shawn-sterling/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-sterling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-sterling/subscriptions","organizations_url":"https://api.github.com/users/shawn-sterling/orgs","repos_url":"https://api.github.com/users/shawn-sterling/repos","events_url":"https://api.github.com/users/shawn-sterling/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-sterling/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nThis removes the include datadog_agent from the integrations, because if you are calling datadog_agent with parameters, and an integration gets included first, it will include the datadog_agent without parameters; and when you try to call it with params you will get duplicate declaration errors.\r\n\r\nThis is happening because we are using roles and profiles, and in our profiles we are doing stuff like\r\n\r\n    class profile::apache {\r\n        include ::datadog_agent::integrations::apache\r\n    }\r\n\r\nwhich inside the integration does a \r\n\r\n    include datadog_agent\r\n\r\nwhich might get called before we call our parameterized datadog_agent:\r\n\r\n    class profile::monitoring::datadog {\r\n        class { '::datadog_agent':\r\n            params => foo\r\n        }\r\n    }\r\n\r\nand then cause a duplicate definition error:\r\n\r\n    Error: Duplicate declaration: Class[Datadog_agent] is already declared; cannot redeclare at \r\n\r\nThis merge will get rid of that problem and still keep the the datadog_agent as a requirement for the integrations.","created_at":"2016-06-11T21:21:37Z","updated_at":"2016-06-11T21:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193/commits","review_comments_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193/comments","review_comment_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/193/comments","statuses_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/statuses/5ae16bf220dba6cf221526b4bd12f432b586c72d","head":{"label":"shawn-sterling:master","ref":"master","sha":"5ae16bf220dba6cf221526b4bd12f432b586c72d","user":{"login":"shawn-sterling","id":994100,"avatar_url":"https://avatars.githubusercontent.com/u/994100?v=3","gravatar_id":"","url":"https://api.github.com/users/shawn-sterling","html_url":"https://github.com/shawn-sterling","followers_url":"https://api.github.com/users/shawn-sterling/followers","following_url":"https://api.github.com/users/shawn-sterling/following{/other_user}","gists_url":"https://api.github.com/users/shawn-sterling/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-sterling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-sterling/subscriptions","organizations_url":"https://api.github.com/users/shawn-sterling/orgs","repos_url":"https://api.github.com/users/shawn-sterling/repos","events_url":"https://api.github.com/users/shawn-sterling/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-sterling/received_events","type":"User","site_admin":false},"repo":{"id":60927739,"name":"puppet-datadog-agent","full_name":"shawn-sterling/puppet-datadog-agent","owner":{"login":"shawn-sterling","id":994100,"avatar_url":"https://avatars.githubusercontent.com/u/994100?v=3","gravatar_id":"","url":"https://api.github.com/users/shawn-sterling","html_url":"https://github.com/shawn-sterling","followers_url":"https://api.github.com/users/shawn-sterling/followers","following_url":"https://api.github.com/users/shawn-sterling/following{/other_user}","gists_url":"https://api.github.com/users/shawn-sterling/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-sterling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-sterling/subscriptions","organizations_url":"https://api.github.com/users/shawn-sterling/orgs","repos_url":"https://api.github.com/users/shawn-sterling/repos","events_url":"https://api.github.com/users/shawn-sterling/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-sterling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shawn-sterling/puppet-datadog-agent","description":"Puppet module to install the Datadog agent","fork":true,"url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent","forks_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/forks","keys_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/teams","hooks_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/events","assignees_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/tags","blobs_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/languages","stargazers_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/subscription","commits_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/merges","archive_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/downloads","issues_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/shawn-sterling/puppet-datadog-agent/deployments","created_at":"2016-06-11T21:04:10Z","updated_at":"2016-06-11T21:04:11Z","pushed_at":"2016-06-11T21:08:12Z","git_url":"git://github.com/shawn-sterling/puppet-datadog-agent.git","ssh_url":"git@github.com:shawn-sterling/puppet-datadog-agent.git","clone_url":"https://github.com/shawn-sterling/puppet-datadog-agent.git","svn_url":"https://github.com/shawn-sterling/puppet-datadog-agent","homepage":"","size":324,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"1dcfe95c2d981a83407f412404c1bdf5dfd72075","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":2036710,"name":"puppet-datadog-agent","full_name":"DataDog/puppet-datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/puppet-datadog-agent","description":"Puppet module to install the Datadog agent","fork":true,"url":"https://api.github.com/repos/DataDog/puppet-datadog-agent","forks_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/puppet-datadog-agent/deployments","created_at":"2011-07-12T15:16:26Z","updated_at":"2016-05-07T03:19:15Z","pushed_at":"2016-06-11T21:21:37Z","git_url":"git://github.com/DataDog/puppet-datadog-agent.git","ssh_url":"git@github.com:DataDog/puppet-datadog-agent.git","clone_url":"https://github.com/DataDog/puppet-datadog-agent.git","svn_url":"https://github.com/DataDog/puppet-datadog-agent","homepage":"","size":616,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":40,"forks":94,"open_issues":40,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193"},"html":{"href":"https://github.com/DataDog/puppet-datadog-agent/pull/193"},"issue":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/193"},"comments":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/puppet-datadog-agent/statuses/5ae16bf220dba6cf221526b4bd12f432b586c72d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":103,"deletions":71,"changed_files":29}}
{"actor":{"display_login":"shawn-sterling"}}