{"action":"created","issue":{"url":"https://api.github.com/repos/coveo/search-ui/issues/3","repository_url":"https://api.github.com/repos/coveo/search-ui","labels_url":"https://api.github.com/repos/coveo/search-ui/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/coveo/search-ui/issues/3/comments","events_url":"https://api.github.com/repos/coveo/search-ui/issues/3/events","html_url":"https://github.com/coveo/search-ui/pull/3","id":156777095,"number":3,"title":"Jsui 535","user":{"login":"dms1lva","id":6422665,"avatar_url":"https://avatars.githubusercontent.com/u/6422665?v=3","gravatar_id":"","url":"https://api.github.com/users/dms1lva","html_url":"https://github.com/dms1lva","followers_url":"https://api.github.com/users/dms1lva/followers","following_url":"https://api.github.com/users/dms1lva/following{/other_user}","gists_url":"https://api.github.com/users/dms1lva/gists{/gist_id}","starred_url":"https://api.github.com/users/dms1lva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dms1lva/subscriptions","organizations_url":"https://api.github.com/users/dms1lva/orgs","repos_url":"https://api.github.com/users/dms1lva/repos","events_url":"https://api.github.com/users/dms1lva/events{/privacy}","received_events_url":"https://api.github.com/users/dms1lva/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"olamothe","id":1591893,"avatar_url":"https://avatars.githubusercontent.com/u/1591893?v=3","gravatar_id":"","url":"https://api.github.com/users/olamothe","html_url":"https://github.com/olamothe","followers_url":"https://api.github.com/users/olamothe/followers","following_url":"https://api.github.com/users/olamothe/following{/other_user}","gists_url":"https://api.github.com/users/olamothe/gists{/gist_id}","starred_url":"https://api.github.com/users/olamothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamothe/subscriptions","organizations_url":"https://api.github.com/users/olamothe/orgs","repos_url":"https://api.github.com/users/olamothe/repos","events_url":"https://api.github.com/users/olamothe/events{/privacy}","received_events_url":"https://api.github.com/users/olamothe/received_events","type":"User","site_admin":false},"assignees":[{"login":"olamothe","id":1591893,"avatar_url":"https://avatars.githubusercontent.com/u/1591893?v=3","gravatar_id":"","url":"https://api.github.com/users/olamothe","html_url":"https://github.com/olamothe","followers_url":"https://api.github.com/users/olamothe/followers","following_url":"https://api.github.com/users/olamothe/following{/other_user}","gists_url":"https://api.github.com/users/olamothe/gists{/gist_id}","starred_url":"https://api.github.com/users/olamothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamothe/subscriptions","organizations_url":"https://api.github.com/users/olamothe/orgs","repos_url":"https://api.github.com/users/olamothe/repos","events_url":"https://api.github.com/users/olamothe/events{/privacy}","received_events_url":"https://api.github.com/users/olamothe/received_events","type":"User","site_admin":false},{"login":"mcarpentierCoveo","id":19291972,"avatar_url":"https://avatars.githubusercontent.com/u/19291972?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarpentierCoveo","html_url":"https://github.com/mcarpentierCoveo","followers_url":"https://api.github.com/users/mcarpentierCoveo/followers","following_url":"https://api.github.com/users/mcarpentierCoveo/following{/other_user}","gists_url":"https://api.github.com/users/mcarpentierCoveo/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarpentierCoveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarpentierCoveo/subscriptions","organizations_url":"https://api.github.com/users/mcarpentierCoveo/orgs","repos_url":"https://api.github.com/users/mcarpentierCoveo/repos","events_url":"https://api.github.com/users/mcarpentierCoveo/events{/privacy}","received_events_url":"https://api.github.com/users/mcarpentierCoveo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-05-25T15:17:00Z","updated_at":"2016-06-28T19:31:45Z","closed_at":"2016-06-28T13:54:44Z","pull_request":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/3","html_url":"https://github.com/coveo/search-ui/pull/3","diff_url":"https://github.com/coveo/search-ui/pull/3.diff","patch_url":"https://github.com/coveo/search-ui/pull/3.patch"},"body":"This is an early pull request.\r\n- Tabs will appear/disappear depending on the window size.\r\n- If there's a search bar, it will put the tabs under it when the tabs overflow.\r\n- The dropdown shows when you click on the `more tabs` button and disappears if you click outside of it.\r\n\r\nTo Do:\r\n\r\n- [x] Fix bug that makes the dropdown appear not centered relatively to the dropdown header.\r\n- [x] If a selected tabs goes in the dropdown, swap it.\r\n- [x] Add blue background on search bar.\r\n- [x] Fix margin on dropdown.\r\n- [x] Make dropdown disappear when you click on a tab in it.\r\n- [x] If you click on a tab inside the dropdown, it should swap with the last item in the permanently showed tabs list.\r\n- [x] Implement responsive facets.\r\n\r\n\r\nDo not merge, as I said, this is an early pull request :-)\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/coveo/search-ui/3)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/coveo/search-ui/issues/comments/229157006","html_url":"https://github.com/coveo/search-ui/pull/3#issuecomment-229157006","issue_url":"https://api.github.com/repos/coveo/search-ui/issues/3","id":229157006,"user":{"login":"dms1lva","id":6422665,"avatar_url":"https://avatars.githubusercontent.com/u/6422665?v=3","gravatar_id":"","url":"https://api.github.com/users/dms1lva","html_url":"https://github.com/dms1lva","followers_url":"https://api.github.com/users/dms1lva/followers","following_url":"https://api.github.com/users/dms1lva/following{/other_user}","gists_url":"https://api.github.com/users/dms1lva/gists{/gist_id}","starred_url":"https://api.github.com/users/dms1lva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dms1lva/subscriptions","organizations_url":"https://api.github.com/users/dms1lva/orgs","repos_url":"https://api.github.com/users/dms1lva/repos","events_url":"https://api.github.com/users/dms1lva/events{/privacy}","received_events_url":"https://api.github.com/users/dms1lva/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T19:31:45Z","updated_at":"2016-06-28T19:31:45Z","body":"\n\n\n\nReview status: 50 of 51 files reviewed at latest revision, 13 unresolved discussions.\n\n---\n\n*[test/ui/ResponsiveTabsTest.ts, line 1 \\[r5\\]](https://reviewable.io:443/reviews/coveo/search-ui/3#-KLMG9lHzQqQ-CC3fC4x:-KLMvTvozmUokUFdQTm2:-499146009) ([raw file](https://github.com/coveo/search-ui/blob/932774c42e007a31117498fa5f1f87bdd827891a/test/ui/ResponsiveTabsTest.ts#L1)):*\n<details><summary><i>Previously, olamothe (Olivier Lamothe) wrote…</i></summary>\n> If there is no test, delete this file.\n> \n> It would be a good idea to log a new user story to implement at least some basic test for this module.\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/coveo/search-ui/3)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dms1lva"}}