{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/54266759","id":54266759,"diff_hunk":"@@ -443,7 +443,13 @@ def hello(request):\n     }\n \n     if (waffle.switch_is_active('firefox-hello-2016')):\n-        return l10n_utils.render(request, 'firefox/hello/index-2016.html')\n+        variant = request.GET.get('v', '')\n+        if variant in ['b']:\n+            template = 'firefox/hello/index-2016-{0}.html'.format(variant)","path":"bedrock/firefox/views.py","position":7,"original_position":7,"commit_id":"678495662eeb1a1a8def1b9897a4d92fe6d79b1c","original_commit_id":"678495662eeb1a1a8def1b9897a4d92fe6d79b1c","user":{"login":"jpetto","id":317532,"avatar_url":"https://avatars.githubusercontent.com/u/317532?v=3","gravatar_id":"","url":"https://api.github.com/users/jpetto","html_url":"https://github.com/jpetto","followers_url":"https://api.github.com/users/jpetto/followers","following_url":"https://api.github.com/users/jpetto/following{/other_user}","gists_url":"https://api.github.com/users/jpetto/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetto/subscriptions","organizations_url":"https://api.github.com/users/jpetto/orgs","repos_url":"https://api.github.com/users/jpetto/repos","events_url":"https://api.github.com/users/jpetto/events{/privacy}","received_events_url":"https://api.github.com/users/jpetto/received_events","type":"User","site_admin":false},"body":"Yeah, since the code is temporary and functional, I wouldn't worry about it.","created_at":"2016-02-26T16:38:40Z","updated_at":"2016-02-26T16:38:40Z","html_url":"https://github.com/mozilla/bedrock/pull/3900#discussion_r54266759","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3900","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/54266759"},"html":{"href":"https://github.com/mozilla/bedrock/pull/3900#discussion_r54266759"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3900"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/3900","id":60607747,"html_url":"https://github.com/mozilla/bedrock/pull/3900","diff_url":"https://github.com/mozilla/bedrock/pull/3900.diff","patch_url":"https://github.com/mozilla/bedrock/pull/3900.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/3900","number":3900,"state":"open","locked":false,"title":"Bug 1249042 - testing copy/design of Firefox newsletter form","user":{"login":"craigcook","id":205591,"avatar_url":"https://avatars.githubusercontent.com/u/205591?v=3","gravatar_id":"","url":"https://api.github.com/users/craigcook","html_url":"https://github.com/craigcook","followers_url":"https://api.github.com/users/craigcook/followers","following_url":"https://api.github.com/users/craigcook/following{/other_user}","gists_url":"https://api.github.com/users/craigcook/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcook/subscriptions","organizations_url":"https://api.github.com/users/craigcook/orgs","repos_url":"https://api.github.com/users/craigcook/repos","events_url":"https://api.github.com/users/craigcook/events{/privacy}","received_events_url":"https://api.github.com/users/craigcook/received_events","type":"User","site_admin":false},"body":"## Description\r\nCreates a set of A/B tests on various Firefox pages to measure engagement with newsletter subscription forms with different designs and messaging. Testing will entail a redirect to alternate page templates via Optimizely with Google Analytics to track form submissions. [This test plan document](https://docs.google.com/document/d/1Q9QuRca6dDX1SdDYvVwPQQQ21I9wnLJIVZSp4JUNMRw/edit#heading=h.dda57fn2njtv) has some further detail on which variations appear on which page.\r\n\r\nWe're conducting this test targeting English only, so although these are new strings we should not expose them for l10n yet. Once we have some test data and see what messaging performs best we may settle on final strings for translation. Non-English locales viewing these pages should see either nothing at all (for pages that currently have no newsletter form) or the the standard \"Get Firefox news\" headline already translated.\r\n\r\n## Bugzilla\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1249042\r\n\r\n## Testing\r\nThere are a total of six pages included in this round of testing. For each page, the base URL acts as the \"A\" variant and appending the query parameter `?v=b` to the URL renders the \"B\" variant. See the test plan doc for which headline appears on which page.\r\n\r\nThe desktop page is a bit special since the test form should only appear for people using the latest Firefox. Other browsers and older Firefoxes should see the old form plus a download button. No other pages do any special detection and show the same content to all browsers and versions.\r\n\r\n## Checklist\r\n- [ ] Requires l10n changes.\r\n- [ ] Related functional & integration tests passing.\r\n\r\nI haven't added any functional or integration tests because, honestly, I don't know how. Should probably try to learn that some day.","created_at":"2016-02-25T01:03:11Z","updated_at":"2016-02-26T16:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b8f353d04d38c58af8fe0c9c41b53e7de9d275a","assignee":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3900/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3900/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/3900/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/678495662eeb1a1a8def1b9897a4d92fe6d79b1c","head":{"label":"mozilla:bug-1249042-firefox-newsletter-testing","ref":"bug-1249042-firefox-newsletter-testing","sha":"678495662eeb1a1a8def1b9897a4d92fe6d79b1c","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2016-02-25T15:45:44Z","pushed_at":"2016-02-26T16:23:39Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":374808,"stargazers_count":287,"watchers_count":287,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":404,"mirror_url":null,"open_issues_count":29,"forks":404,"open_issues":29,"watchers":287,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"954cf606b3a15e333416b25b353469195cf8b83a","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2016-02-25T15:45:44Z","pushed_at":"2016-02-26T16:23:39Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":374808,"stargazers_count":287,"watchers_count":287,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":404,"mirror_url":null,"open_issues_count":29,"forks":404,"open_issues":29,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3900"},"html":{"href":"https://github.com/mozilla/bedrock/pull/3900"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/3900"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/3900/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3900/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3900/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/678495662eeb1a1a8def1b9897a4d92fe6d79b1c"}}}}