{"action":"created","comment":{"url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/comments/88018502","pull_request_review_id":8604611,"id":88018502,"diff_hunk":"@@ -14,24 +15,34 @@\n      * Stores the altitude in meters.\n      */\n     private double mAltitude;\n+    private Frame mFrame;\n+\n+    public LatLongAlt() {\n+        super();\n+        mAltitude = 0.0;\n+        mFrame = Frame.GLOBAL_RELATIVE;\n+    }\n \n-    public LatLongAlt(double latitude, double longitude, double altitude) {\n+    public LatLongAlt(double latitude, double longitude, double altitude, Frame frame) {","path":"ClientLib/src/main/java/com/o3dr/services/android/lib/coordinate/LatLongAlt.java","position":21,"original_position":21,"commit_id":"8482dbea714c973896bd552f7d1d61a904d2c723","original_commit_id":"8482dbea714c973896bd552f7d1d61a904d2c723","user":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"body":"I di that for a reason in that it exposes the parts in the code that sets the frame.  I.e you can see explicitly what frame is being assumed. You don't want to accidentally put abs alt into relative. It would seem like a flyaway.","created_at":"2016-11-15T13:47:21Z","updated_at":"2016-11-15T13:47:21Z","html_url":"https://github.com/dronekit/dronekit-android/pull/460#discussion_r88018502","pull_request_url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/comments/88018502"},"html":{"href":"https://github.com/dronekit/dronekit-android/pull/460#discussion_r88018502"},"pull_request":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460","id":91510206,"html_url":"https://github.com/dronekit/dronekit-android/pull/460","diff_url":"https://github.com/dronekit/dronekit-android/pull/460.diff","patch_url":"https://github.com/dronekit/dronekit-android/pull/460.patch","issue_url":"https://api.github.com/repos/dronekit/dronekit-android/issues/460","number":460,"state":"open","locked":false,"title":"WIP: Adding Alt Frames (ie. Terrain) to API","user":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"body":"NOTE: this is not intended to be merge (yet 😀), more as a point of discussion.\r\n\r\nThis is the first working draft of adding frames to the current API to support terrain following.\r\n\r\nIt's also dependent of Tower PR https://github.com/DroidPlanner/Tower/pull/1826\r\n\r\nComments welcome. Thx.\r\n","created_at":"2016-10-30T03:47:48Z","updated_at":"2016-11-15T13:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dbea4a9ec472d5ea0a90af222b114c2ca7e792f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460/commits","review_comments_url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460/comments","review_comment_url":"https://api.github.com/repos/dronekit/dronekit-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dronekit/dronekit-android/issues/460/comments","statuses_url":"https://api.github.com/repos/dronekit/dronekit-android/statuses/8482dbea714c973896bd552f7d1d61a904d2c723","head":{"label":"billbonney:mavlink-frame-wip","ref":"mavlink-frame-wip","sha":"8482dbea714c973896bd552f7d1d61a904d2c723","user":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"repo":{"id":30094557,"name":"dronekit-android","full_name":"billbonney/dronekit-android","owner":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billbonney/dronekit-android","description":"Android DroneAPI implementation","fork":true,"url":"https://api.github.com/repos/billbonney/dronekit-android","forks_url":"https://api.github.com/repos/billbonney/dronekit-android/forks","keys_url":"https://api.github.com/repos/billbonney/dronekit-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billbonney/dronekit-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billbonney/dronekit-android/teams","hooks_url":"https://api.github.com/repos/billbonney/dronekit-android/hooks","issue_events_url":"https://api.github.com/repos/billbonney/dronekit-android/issues/events{/number}","events_url":"https://api.github.com/repos/billbonney/dronekit-android/events","assignees_url":"https://api.github.com/repos/billbonney/dronekit-android/assignees{/user}","branches_url":"https://api.github.com/repos/billbonney/dronekit-android/branches{/branch}","tags_url":"https://api.github.com/repos/billbonney/dronekit-android/tags","blobs_url":"https://api.github.com/repos/billbonney/dronekit-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billbonney/dronekit-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billbonney/dronekit-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/billbonney/dronekit-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billbonney/dronekit-android/statuses/{sha}","languages_url":"https://api.github.com/repos/billbonney/dronekit-android/languages","stargazers_url":"https://api.github.com/repos/billbonney/dronekit-android/stargazers","contributors_url":"https://api.github.com/repos/billbonney/dronekit-android/contributors","subscribers_url":"https://api.github.com/repos/billbonney/dronekit-android/subscribers","subscription_url":"https://api.github.com/repos/billbonney/dronekit-android/subscription","commits_url":"https://api.github.com/repos/billbonney/dronekit-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/billbonney/dronekit-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/billbonney/dronekit-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/billbonney/dronekit-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/billbonney/dronekit-android/contents/{+path}","compare_url":"https://api.github.com/repos/billbonney/dronekit-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billbonney/dronekit-android/merges","archive_url":"https://api.github.com/repos/billbonney/dronekit-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billbonney/dronekit-android/downloads","issues_url":"https://api.github.com/repos/billbonney/dronekit-android/issues{/number}","pulls_url":"https://api.github.com/repos/billbonney/dronekit-android/pulls{/number}","milestones_url":"https://api.github.com/repos/billbonney/dronekit-android/milestones{/number}","notifications_url":"https://api.github.com/repos/billbonney/dronekit-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billbonney/dronekit-android/labels{/name}","releases_url":"https://api.github.com/repos/billbonney/dronekit-android/releases{/id}","deployments_url":"https://api.github.com/repos/billbonney/dronekit-android/deployments","created_at":"2015-01-30T23:00:07Z","updated_at":"2016-09-17T04:20:25Z","pushed_at":"2016-11-09T04:53:06Z","git_url":"git://github.com/billbonney/dronekit-android.git","ssh_url":"git@github.com:billbonney/dronekit-android.git","clone_url":"https://github.com/billbonney/dronekit-android.git","svn_url":"https://github.com/billbonney/dronekit-android","homepage":"","size":50146,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dronekit:develop","ref":"develop","sha":"6107fdd02d104b387061c4213a45e5de396ff329","user":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"repo":{"id":27089359,"name":"dronekit-android","full_name":"dronekit/dronekit-android","owner":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dronekit/dronekit-android","description":"Android DroneKit implementation","fork":false,"url":"https://api.github.com/repos/dronekit/dronekit-android","forks_url":"https://api.github.com/repos/dronekit/dronekit-android/forks","keys_url":"https://api.github.com/repos/dronekit/dronekit-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dronekit/dronekit-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dronekit/dronekit-android/teams","hooks_url":"https://api.github.com/repos/dronekit/dronekit-android/hooks","issue_events_url":"https://api.github.com/repos/dronekit/dronekit-android/issues/events{/number}","events_url":"https://api.github.com/repos/dronekit/dronekit-android/events","assignees_url":"https://api.github.com/repos/dronekit/dronekit-android/assignees{/user}","branches_url":"https://api.github.com/repos/dronekit/dronekit-android/branches{/branch}","tags_url":"https://api.github.com/repos/dronekit/dronekit-android/tags","blobs_url":"https://api.github.com/repos/dronekit/dronekit-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dronekit/dronekit-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dronekit/dronekit-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dronekit/dronekit-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dronekit/dronekit-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dronekit/dronekit-android/languages","stargazers_url":"https://api.github.com/repos/dronekit/dronekit-android/stargazers","contributors_url":"https://api.github.com/repos/dronekit/dronekit-android/contributors","subscribers_url":"https://api.github.com/repos/dronekit/dronekit-android/subscribers","subscription_url":"https://api.github.com/repos/dronekit/dronekit-android/subscription","commits_url":"https://api.github.com/repos/dronekit/dronekit-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dronekit/dronekit-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dronekit/dronekit-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dronekit/dronekit-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dronekit/dronekit-android/contents/{+path}","compare_url":"https://api.github.com/repos/dronekit/dronekit-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dronekit/dronekit-android/merges","archive_url":"https://api.github.com/repos/dronekit/dronekit-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dronekit/dronekit-android/downloads","issues_url":"https://api.github.com/repos/dronekit/dronekit-android/issues{/number}","pulls_url":"https://api.github.com/repos/dronekit/dronekit-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dronekit/dronekit-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dronekit/dronekit-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dronekit/dronekit-android/labels{/name}","releases_url":"https://api.github.com/repos/dronekit/dronekit-android/releases{/id}","deployments_url":"https://api.github.com/repos/dronekit/dronekit-android/deployments","created_at":"2014-11-24T18:41:57Z","updated_at":"2016-11-15T06:33:35Z","pushed_at":"2016-11-09T04:53:06Z","git_url":"git://github.com/dronekit/dronekit-android.git","ssh_url":"git@github.com:dronekit/dronekit-android.git","clone_url":"https://github.com/dronekit/dronekit-android.git","svn_url":"https://github.com/dronekit/dronekit-android","homepage":"http://android.dronekit.io/","size":59724,"stargazers_count":106,"watchers_count":106,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"open_issues_count":31,"forks":129,"open_issues":31,"watchers":106,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460"},"html":{"href":"https://github.com/dronekit/dronekit-android/pull/460"},"issue":{"href":"https://api.github.com/repos/dronekit/dronekit-android/issues/460"},"comments":{"href":"https://api.github.com/repos/dronekit/dronekit-android/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dronekit/dronekit-android/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/dronekit/dronekit-android/statuses/8482dbea714c973896bd552f7d1d61a904d2c723"}}}}
{"actor":{"display_login":"billbonney"}}