{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/84078527","pull_request_review_id":4878016,"id":84078527,"diff_hunk":"@@ -547,8 +552,13 @@ void AbstractAioObjectWrite::send_write_op(bool write_guard)\n \n   librados::AioCompletion *rados_completion =\n     util::create_rados_safe_callback(this);\n-  int r = m_ictx->data_ctx.aio_operate(m_oid, rados_completion, &m_write,\n-                                       m_snap_seq, m_snaps);\n+  int r;\n+  if (m_trace && m_trace.valid())","path":"src/librbd/AioObjectRequest.cc","position":40,"original_position":40,"commit_id":"3e266851ee8a9104d6d1456428f59c870b0a7c02","original_commit_id":"938d2a242a6a4dd906c7af31a8e3b88fdb958f15","user":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"body":"My point was that since ```m_trace``` isn't a pointer, it has a ```bool``` operator that just calls ```valid()```, therefore, it's redundant to test both here.","created_at":"2016-10-19T14:10:14Z","updated_at":"2016-10-19T14:10:15Z","html_url":"https://github.com/ceph/ceph/pull/11053#discussion_r84078527","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/11053","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/84078527"},"html":{"href":"https://github.com/ceph/ceph/pull/11053#discussion_r84078527"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11053"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/11053","id":84857904,"html_url":"https://github.com/ceph/ceph/pull/11053","diff_url":"https://github.com/ceph/ceph/pull/11053.diff","patch_url":"https://github.com/ceph/ceph/pull/11053.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/11053","number":11053,"state":"open","locked":false,"title":"Zipkin tracing [GSOC 2016]","user":{"login":"vears91","id":17908679,"avatar_url":"https://avatars.githubusercontent.com/u/17908679?v=3","gravatar_id":"","url":"https://api.github.com/users/vears91","html_url":"https://github.com/vears91","followers_url":"https://api.github.com/users/vears91/followers","following_url":"https://api.github.com/users/vears91/following{/other_user}","gists_url":"https://api.github.com/users/vears91/gists{/gist_id}","starred_url":"https://api.github.com/users/vears91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vears91/subscriptions","organizations_url":"https://api.github.com/users/vears91/orgs","repos_url":"https://api.github.com/users/vears91/repos","events_url":"https://api.github.com/users/vears91/events{/privacy}","received_events_url":"https://api.github.com/users/vears91/received_events","type":"User","site_admin":false},"body":"Cleaned up from https://github.com/ceph/ceph/pull/10637 and rebased to include recent changes in librbd.\r\n\r\nPass trace information from librbd to librados. This is part of the end-to-end performance visualization Google Summer of Code project, to initialize traces in fio rbd engine and pass them to librados. It is based on the wip-blkin-osdc branch that added Zipkin tracing support to Messenger and Objecter.\r\n\r\nTrace information is passed to librbd through new rbd_aio_write_traced and rbd_aio_read_traced functions, that take trace information as one of the parameters.\r\n\r\nSigned-off-by: Victor Araujo ve.ar91@gmail.com","created_at":"2016-09-12T11:50:08Z","updated_at":"2016-10-19T14:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f15fe9c8b1722a93b2c1397d91a1165e99f87e82","assignee":{"login":"alimaredia","id":4624480,"avatar_url":"https://avatars.githubusercontent.com/u/4624480?v=3","gravatar_id":"","url":"https://api.github.com/users/alimaredia","html_url":"https://github.com/alimaredia","followers_url":"https://api.github.com/users/alimaredia/followers","following_url":"https://api.github.com/users/alimaredia/following{/other_user}","gists_url":"https://api.github.com/users/alimaredia/gists{/gist_id}","starred_url":"https://api.github.com/users/alimaredia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimaredia/subscriptions","organizations_url":"https://api.github.com/users/alimaredia/orgs","repos_url":"https://api.github.com/users/alimaredia/repos","events_url":"https://api.github.com/users/alimaredia/events{/privacy}","received_events_url":"https://api.github.com/users/alimaredia/received_events","type":"User","site_admin":false},"assignees":[{"login":"alimaredia","id":4624480,"avatar_url":"https://avatars.githubusercontent.com/u/4624480?v=3","gravatar_id":"","url":"https://api.github.com/users/alimaredia","html_url":"https://github.com/alimaredia","followers_url":"https://api.github.com/users/alimaredia/followers","following_url":"https://api.github.com/users/alimaredia/following{/other_user}","gists_url":"https://api.github.com/users/alimaredia/gists{/gist_id}","starred_url":"https://api.github.com/users/alimaredia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimaredia/subscriptions","organizations_url":"https://api.github.com/users/alimaredia/orgs","repos_url":"https://api.github.com/users/alimaredia/repos","events_url":"https://api.github.com/users/alimaredia/events{/privacy}","received_events_url":"https://api.github.com/users/alimaredia/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/11053/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/11053/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/11053/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/3e266851ee8a9104d6d1456428f59c870b0a7c02","head":{"label":"vears91:wip-zipkin-rbd","ref":"wip-zipkin-rbd","sha":"3e266851ee8a9104d6d1456428f59c870b0a7c02","user":{"login":"vears91","id":17908679,"avatar_url":"https://avatars.githubusercontent.com/u/17908679?v=3","gravatar_id":"","url":"https://api.github.com/users/vears91","html_url":"https://github.com/vears91","followers_url":"https://api.github.com/users/vears91/followers","following_url":"https://api.github.com/users/vears91/following{/other_user}","gists_url":"https://api.github.com/users/vears91/gists{/gist_id}","starred_url":"https://api.github.com/users/vears91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vears91/subscriptions","organizations_url":"https://api.github.com/users/vears91/orgs","repos_url":"https://api.github.com/users/vears91/repos","events_url":"https://api.github.com/users/vears91/events{/privacy}","received_events_url":"https://api.github.com/users/vears91/received_events","type":"User","site_admin":false},"repo":{"id":54131126,"name":"ceph","full_name":"vears91/ceph","owner":{"login":"vears91","id":17908679,"avatar_url":"https://avatars.githubusercontent.com/u/17908679?v=3","gravatar_id":"","url":"https://api.github.com/users/vears91","html_url":"https://github.com/vears91","followers_url":"https://api.github.com/users/vears91/followers","following_url":"https://api.github.com/users/vears91/following{/other_user}","gists_url":"https://api.github.com/users/vears91/gists{/gist_id}","starred_url":"https://api.github.com/users/vears91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vears91/subscriptions","organizations_url":"https://api.github.com/users/vears91/orgs","repos_url":"https://api.github.com/users/vears91/repos","events_url":"https://api.github.com/users/vears91/events{/privacy}","received_events_url":"https://api.github.com/users/vears91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vears91/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/vears91/ceph","forks_url":"https://api.github.com/repos/vears91/ceph/forks","keys_url":"https://api.github.com/repos/vears91/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vears91/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vears91/ceph/teams","hooks_url":"https://api.github.com/repos/vears91/ceph/hooks","issue_events_url":"https://api.github.com/repos/vears91/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/vears91/ceph/events","assignees_url":"https://api.github.com/repos/vears91/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/vears91/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/vears91/ceph/tags","blobs_url":"https://api.github.com/repos/vears91/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vears91/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vears91/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/vears91/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vears91/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/vears91/ceph/languages","stargazers_url":"https://api.github.com/repos/vears91/ceph/stargazers","contributors_url":"https://api.github.com/repos/vears91/ceph/contributors","subscribers_url":"https://api.github.com/repos/vears91/ceph/subscribers","subscription_url":"https://api.github.com/repos/vears91/ceph/subscription","commits_url":"https://api.github.com/repos/vears91/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/vears91/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/vears91/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/vears91/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/vears91/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/vears91/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vears91/ceph/merges","archive_url":"https://api.github.com/repos/vears91/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vears91/ceph/downloads","issues_url":"https://api.github.com/repos/vears91/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/vears91/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/vears91/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/vears91/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vears91/ceph/labels{/name}","releases_url":"https://api.github.com/repos/vears91/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/vears91/ceph/deployments","created_at":"2016-03-17T15:49:38Z","updated_at":"2016-03-17T15:49:57Z","pushed_at":"2016-10-04T14:28:15Z","git_url":"git://github.com/vears91/ceph.git","ssh_url":"git@github.com:vears91/ceph.git","clone_url":"https://github.com/vears91/ceph.git","svn_url":"https://github.com/vears91/ceph","homepage":"http://ceph.com","size":176581,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"d5c6a961d38cf08ae3fffbaa8be9be5a447e5f7a","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-10-19T13:26:46Z","pushed_at":"2016-10-19T13:58:35Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":247425,"stargazers_count":2547,"watchers_count":2547,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1501,"mirror_url":null,"open_issues_count":409,"forks":1501,"open_issues":409,"watchers":2547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11053"},"html":{"href":"https://github.com/ceph/ceph/pull/11053"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/11053"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/11053/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11053/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11053/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/3e266851ee8a9104d6d1456428f59c870b0a7c02"}}}}
{"actor":{"display_login":"dillaman"}}