{"action":"created","issue":{"url":"https://api.github.com/repos/koalyptus/TableFilter/issues/250","repository_url":"https://api.github.com/repos/koalyptus/TableFilter","labels_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/250/labels{/name}","comments_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/250/comments","events_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/250/events","html_url":"https://github.com/koalyptus/TableFilter/issues/250","id":163046327,"number":250,"title":"getFilteredData affected by pagination.","user":{"login":"cjohnsonuk","id":6104226,"avatar_url":"https://avatars.githubusercontent.com/u/6104226?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohnsonuk","html_url":"https://github.com/cjohnsonuk","followers_url":"https://api.github.com/users/cjohnsonuk/followers","following_url":"https://api.github.com/users/cjohnsonuk/following{/other_user}","gists_url":"https://api.github.com/users/cjohnsonuk/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohnsonuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohnsonuk/subscriptions","organizations_url":"https://api.github.com/users/cjohnsonuk/orgs","repos_url":"https://api.github.com/users/cjohnsonuk/repos","events_url":"https://api.github.com/users/cjohnsonuk/events{/privacy}","received_events_url":"https://api.github.com/users/cjohnsonuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-29T22:59:31Z","updated_at":"2016-06-30T23:11:03Z","closed_at":null,"body":"Feature request...?\r\n**Background**\r\nI've just noticed an effect I wasn't expecting.  I've used getFilteredData in a to create some stats on the visible data in my table.  This works well for my test data.  However the list was still very long on the live data.  I found a previous issue logged here relating to fixing the table header row to the top of the screen when scrolling down the page but that didn't appear to have a working solution so I used the toggle pagination code so that its not as far to scroll to confirm the column headers.  \r\n**Issue**\r\nI noticed that my stats created from the data returned by getFilteredData appear to be calculated based on the _visible rows_, not just the filtered rows.  getFilteredData appears to return the rows from the table that are 'visible', rather than what I expected which was the rows that match the filters.  Rows not visible due to pagination appear to be omitted from the data returned.  I'll confirm this tomorrow.  I think I can get round this by turning off pagination doing my calculations and then turning it back on again.  \r\n**Request**\r\nIt would be nice to have either a parameter in getFilteredData to ignore the effects of pagination or to have another function called getVisibleData that does what getFilteredData does and for getFilteredData to return the data matching the active filters whether its hidden by pagination or not.."},"comment":{"url":"https://api.github.com/repos/koalyptus/TableFilter/issues/comments/229814249","html_url":"https://github.com/koalyptus/TableFilter/issues/250#issuecomment-229814249","issue_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/250","id":229814249,"user":{"login":"koalyptus","id":8214629,"avatar_url":"https://avatars.githubusercontent.com/u/8214629?v=3","gravatar_id":"","url":"https://api.github.com/users/koalyptus","html_url":"https://github.com/koalyptus","followers_url":"https://api.github.com/users/koalyptus/followers","following_url":"https://api.github.com/users/koalyptus/following{/other_user}","gists_url":"https://api.github.com/users/koalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/koalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koalyptus/subscriptions","organizations_url":"https://api.github.com/users/koalyptus/orgs","repos_url":"https://api.github.com/users/koalyptus/repos","events_url":"https://api.github.com/users/koalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/koalyptus/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T23:11:03Z","updated_at":"2016-06-30T23:11:03Z","body":"Thanks for your detailed ticket. You shouldn't have to turn off pagination to get the filtered data but from memory your description seems correct. Anyway I like your idea of having an explicit getVisibleData method to make it clear what you get.\r\nCheers"}}
{"actor":{"display_login":"koalyptus"}}