{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6","id":87596122,"html_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend/pull/6","diff_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend/pull/6.diff","patch_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend/pull/6.patch","issue_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/6","number":6,"state":"closed","locked":false,"title":"Code Cleanup","user":{"login":"ThomasKerman","id":7887606,"avatar_url":"https://avatars.githubusercontent.com/u/7887606?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasKerman","html_url":"https://github.com/ThomasKerman","followers_url":"https://api.github.com/users/ThomasKerman/followers","following_url":"https://api.github.com/users/ThomasKerman/following{/other_user}","gists_url":"https://api.github.com/users/ThomasKerman/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasKerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasKerman/subscriptions","organizations_url":"https://api.github.com/users/ThomasKerman/orgs","repos_url":"https://api.github.com/users/ThomasKerman/repos","events_url":"https://api.github.com/users/ThomasKerman/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasKerman/received_events","type":"User","site_admin":false},"body":"I ran pyflakes on the whole codebase and found some critical issues I made while migrating the KerbalStuff / SpaceDock code into the backend.\r\n\r\nAdditionally I reformatted our import statements. My current style is:\r\n\r\n1. All from x import y that isn't SpaceDocks\r\n2. Then SpaceDocks from x import y\r\n3. After an empty line, all import x statements\r\n\r\nI removed the wildcard import stuff and literally wrote what is needed. Types before methods or fields.\r\nEverything is sorted alphabetically.","created_at":"2016-10-01T08:37:36Z","updated_at":"2016-10-01T14:10:41Z","closed_at":"2016-10-01T14:10:41Z","merged_at":"2016-10-01T14:10:41Z","merge_commit_sha":"b63ad87952130b420e98e356bd2dba9f4c3855d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6/commits","review_comments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6/comments","review_comment_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/6/comments","statuses_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/statuses/b26779310dc6e2df28bdeb774d3965d3ba272102","head":{"label":"KSP-SpaceDock:feature/code-cleanup","ref":"feature/code-cleanup","sha":"b26779310dc6e2df28bdeb774d3965d3ba272102","user":{"login":"KSP-SpaceDock","id":17254385,"avatar_url":"https://avatars.githubusercontent.com/u/17254385?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-SpaceDock","html_url":"https://github.com/KSP-SpaceDock","followers_url":"https://api.github.com/users/KSP-SpaceDock/followers","following_url":"https://api.github.com/users/KSP-SpaceDock/following{/other_user}","gists_url":"https://api.github.com/users/KSP-SpaceDock/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-SpaceDock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-SpaceDock/subscriptions","organizations_url":"https://api.github.com/users/KSP-SpaceDock/orgs","repos_url":"https://api.github.com/users/KSP-SpaceDock/repos","events_url":"https://api.github.com/users/KSP-SpaceDock/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-SpaceDock/received_events","type":"Organization","site_admin":false},"repo":{"id":57973586,"name":"SpaceDock-Backend","full_name":"KSP-SpaceDock/SpaceDock-Backend","owner":{"login":"KSP-SpaceDock","id":17254385,"avatar_url":"https://avatars.githubusercontent.com/u/17254385?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-SpaceDock","html_url":"https://github.com/KSP-SpaceDock","followers_url":"https://api.github.com/users/KSP-SpaceDock/followers","following_url":"https://api.github.com/users/KSP-SpaceDock/following{/other_user}","gists_url":"https://api.github.com/users/KSP-SpaceDock/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-SpaceDock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-SpaceDock/subscriptions","organizations_url":"https://api.github.com/users/KSP-SpaceDock/orgs","repos_url":"https://api.github.com/users/KSP-SpaceDock/repos","events_url":"https://api.github.com/users/KSP-SpaceDock/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-SpaceDock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend","description":"API backend for SpaceDock","fork":false,"url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend","forks_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/forks","keys_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/teams","hooks_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/hooks","issue_events_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/events","assignees_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/tags","blobs_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/languages","stargazers_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/stargazers","contributors_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/contributors","subscribers_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/subscribers","subscription_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/subscription","commits_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/merges","archive_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/downloads","issues_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/labels{/name}","releases_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/deployments","created_at":"2016-05-03T14:01:04Z","updated_at":"2016-10-01T13:32:22Z","pushed_at":"2016-10-01T14:10:41Z","git_url":"git://github.com/KSP-SpaceDock/SpaceDock-Backend.git","ssh_url":"git@github.com:KSP-SpaceDock/SpaceDock-Backend.git","clone_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend.git","svn_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend","homepage":null,"size":300,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"KSP-SpaceDock:master","ref":"master","sha":"3d8aca1a245a9a7382d7a38f4eb9559de9583530","user":{"login":"KSP-SpaceDock","id":17254385,"avatar_url":"https://avatars.githubusercontent.com/u/17254385?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-SpaceDock","html_url":"https://github.com/KSP-SpaceDock","followers_url":"https://api.github.com/users/KSP-SpaceDock/followers","following_url":"https://api.github.com/users/KSP-SpaceDock/following{/other_user}","gists_url":"https://api.github.com/users/KSP-SpaceDock/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-SpaceDock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-SpaceDock/subscriptions","organizations_url":"https://api.github.com/users/KSP-SpaceDock/orgs","repos_url":"https://api.github.com/users/KSP-SpaceDock/repos","events_url":"https://api.github.com/users/KSP-SpaceDock/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-SpaceDock/received_events","type":"Organization","site_admin":false},"repo":{"id":57973586,"name":"SpaceDock-Backend","full_name":"KSP-SpaceDock/SpaceDock-Backend","owner":{"login":"KSP-SpaceDock","id":17254385,"avatar_url":"https://avatars.githubusercontent.com/u/17254385?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-SpaceDock","html_url":"https://github.com/KSP-SpaceDock","followers_url":"https://api.github.com/users/KSP-SpaceDock/followers","following_url":"https://api.github.com/users/KSP-SpaceDock/following{/other_user}","gists_url":"https://api.github.com/users/KSP-SpaceDock/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-SpaceDock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-SpaceDock/subscriptions","organizations_url":"https://api.github.com/users/KSP-SpaceDock/orgs","repos_url":"https://api.github.com/users/KSP-SpaceDock/repos","events_url":"https://api.github.com/users/KSP-SpaceDock/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-SpaceDock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend","description":"API backend for SpaceDock","fork":false,"url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend","forks_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/forks","keys_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/teams","hooks_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/hooks","issue_events_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/events","assignees_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/tags","blobs_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/languages","stargazers_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/stargazers","contributors_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/contributors","subscribers_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/subscribers","subscription_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/subscription","commits_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/merges","archive_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/downloads","issues_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/labels{/name}","releases_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/deployments","created_at":"2016-05-03T14:01:04Z","updated_at":"2016-10-01T13:32:22Z","pushed_at":"2016-10-01T14:10:41Z","git_url":"git://github.com/KSP-SpaceDock/SpaceDock-Backend.git","ssh_url":"git@github.com:KSP-SpaceDock/SpaceDock-Backend.git","clone_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend.git","svn_url":"https://github.com/KSP-SpaceDock/SpaceDock-Backend","homepage":null,"size":300,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6"},"html":{"href":"https://github.com/KSP-SpaceDock/SpaceDock-Backend/pull/6"},"issue":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/6"},"comments":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-SpaceDock/SpaceDock-Backend/statuses/b26779310dc6e2df28bdeb774d3965d3ba272102"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ThomasKerman","id":7887606,"avatar_url":"https://avatars.githubusercontent.com/u/7887606?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasKerman","html_url":"https://github.com/ThomasKerman","followers_url":"https://api.github.com/users/ThomasKerman/followers","following_url":"https://api.github.com/users/ThomasKerman/following{/other_user}","gists_url":"https://api.github.com/users/ThomasKerman/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasKerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasKerman/subscriptions","organizations_url":"https://api.github.com/users/ThomasKerman/orgs","repos_url":"https://api.github.com/users/ThomasKerman/repos","events_url":"https://api.github.com/users/ThomasKerman/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasKerman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":10,"additions":79,"deletions":635,"changed_files":20}}
{"actor":{"display_login":"ThomasKerman"}}