{"action":"created","comment":{"url":"https://api.github.com/repos/opencv/opencv/pulls/comments/74911999","id":74911999,"diff_hunk":"@@ -1300,6 +1300,402 @@ void setUseCollection(bool flag)\n }\n #endif\n \n+template<class OBJECT>\n+Node<OBJECT>::Node()\n+{\n+    m_pParent  = 0;\n+}","path":"modules/core/src/system.cpp","position":8,"original_position":8,"commit_id":"f689b9c632337795eb071b4ec6d24bb0169a57e2","original_commit_id":"f689b9c632337795eb071b4ec6d24bb0169a57e2","user":{"login":"alalek","id":4981219,"avatar_url":"https://avatars.githubusercontent.com/u/4981219?v=3","gravatar_id":"","url":"https://api.github.com/users/alalek","html_url":"https://github.com/alalek","followers_url":"https://api.github.com/users/alalek/followers","following_url":"https://api.github.com/users/alalek/following{/other_user}","gists_url":"https://api.github.com/users/alalek/gists{/gist_id}","starred_url":"https://api.github.com/users/alalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalek/subscriptions","organizations_url":"https://api.github.com/users/alalek/orgs","repos_url":"https://api.github.com/users/alalek/repos","events_url":"https://api.github.com/users/alalek/events{/privacy}","received_events_url":"https://api.github.com/users/alalek/received_events","type":"User","site_admin":false},"body":"In general, implementation of template classes should be placed in headers (.hpp or .impl.hpp)","created_at":"2016-08-16T10:40:39Z","updated_at":"2016-08-16T10:40:39Z","html_url":"https://github.com/opencv/opencv/pull/7101#discussion_r74911999","pull_request_url":"https://api.github.com/repos/opencv/opencv/pulls/7101","_links":{"self":{"href":"https://api.github.com/repos/opencv/opencv/pulls/comments/74911999"},"html":{"href":"https://github.com/opencv/opencv/pull/7101#discussion_r74911999"},"pull_request":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7101"}}},"pull_request":{"url":"https://api.github.com/repos/opencv/opencv/pulls/7101","id":81073803,"html_url":"https://github.com/opencv/opencv/pull/7101","diff_url":"https://github.com/opencv/opencv/pull/7101.diff","patch_url":"https://github.com/opencv/opencv/pull/7101.patch","issue_url":"https://api.github.com/repos/opencv/opencv/issues/7101","number":7101,"state":"open","locked":false,"title":"Implementations instrumentation framework for OpenCV performance test system;","user":{"login":"lupustr3","id":6407682,"avatar_url":"https://avatars.githubusercontent.com/u/6407682?v=3","gravatar_id":"","url":"https://api.github.com/users/lupustr3","html_url":"https://github.com/lupustr3","followers_url":"https://api.github.com/users/lupustr3/followers","following_url":"https://api.github.com/users/lupustr3/following{/other_user}","gists_url":"https://api.github.com/users/lupustr3/gists{/gist_id}","starred_url":"https://api.github.com/users/lupustr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lupustr3/subscriptions","organizations_url":"https://api.github.com/users/lupustr3/orgs","repos_url":"https://api.github.com/users/lupustr3/repos","events_url":"https://api.github.com/users/lupustr3/events{/privacy}","received_events_url":"https://api.github.com/users/lupustr3/received_events","type":"User","site_admin":false},"body":"### This pullrequest changes\r\n\r\nInstrumentation framework for OpenCV performance test system. It was developed to:\r\n- track implementations execution inside OpenCV functions with call tree output to test logs\r\n- track implementations execution time weight in the pipeline\r\n\r\nFramework can be enabled with ENABLE_INSTRUMENTATION define in CMake and disabled by default. In disabled state it doesn't consume resources.\r\n\r\nExample instrumentation was implemented for cv::meanStdDev function:\r\n\r\nOutput example for IPP:\r\n```\r\n[ RUN      ] Size_MatType_meanStdDev.meanStdDev/6\r\n[ PERFSTAT ]    (samples = 25, mean = 0.10, median = 0.10, stddev = 0.00 (0.5%))\r\n[ VALUE    ]    (1920x1080, 8UC1)\r\n[ TRACE    ]\r\nROOT\r\n\\---cv::meanStdDev - C:25 /*entries counter*/ T:2.3906ms /*block execution time*/\r\n    \\---cv::ipp_meanStdDev<W_IPP> - C:25 T:2.3269ms L:97% /*weight in local block*/ G:97% /*weight in entire pipeline*/\r\n        \\---ippiMean_StdDev_C1R<F_IPP> - C:25 T:2.2700ms L:98% G:95%\r\n\r\nIPP weight: 95.0% /*total implementation functions execution weight across all entries*/\r\nOPENCL weight: 0.0%\r\n[/TRACE    ]\r\n[       OK ] Size_MatType_meanStdDev.meanStdDev/6 (77 ms)\r\n```\r\n\r\nOutput example for OpenCL:\r\n```\r\n[ RUN      ] OCL_MeanStdDevFixture_MeanStdDev.MeanStdDev/7\r\n[ PERFSTAT ]    (samples = 25, mean = 0.23, median = 0.23, stddev = 0.00 (1.8%))\r\n[ VALUE    ]    (1280x720, 32FC1)\r\n[ TRACE    ]\r\nROOT\r\n\\---cv::meanStdDev - C:25 T:5.8007ms\r\n    \\---cv::ocl_meanStdDev<W_OCL> - C:25 T:5.7412ms L:99% G:99%\r\n        \\---k.run<F_OCL> - C:25 T:3.5630ms L:62% G:61%\r\n\r\nIPP weight: 0.0%\r\nOPENCL weight: 61.4%\r\n[/TRACE    ]\r\n[       OK ] OCL_MeanStdDevFixture_MeanStdDev.MeanStdDev/7 (36 ms)\r\n```\r\n","created_at":"2016-08-12T06:39:02Z","updated_at":"2016-08-16T10:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"326094b6c7e1fff2ca917ff9aff8a4021801eab3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencv/opencv/pulls/7101/commits","review_comments_url":"https://api.github.com/repos/opencv/opencv/pulls/7101/comments","review_comment_url":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencv/opencv/issues/7101/comments","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/f689b9c632337795eb071b4ec6d24bb0169a57e2","head":{"label":"lupustr3:pvlasov/instrumentation","ref":"pvlasov/instrumentation","sha":"f689b9c632337795eb071b4ec6d24bb0169a57e2","user":{"login":"lupustr3","id":6407682,"avatar_url":"https://avatars.githubusercontent.com/u/6407682?v=3","gravatar_id":"","url":"https://api.github.com/users/lupustr3","html_url":"https://github.com/lupustr3","followers_url":"https://api.github.com/users/lupustr3/followers","following_url":"https://api.github.com/users/lupustr3/following{/other_user}","gists_url":"https://api.github.com/users/lupustr3/gists{/gist_id}","starred_url":"https://api.github.com/users/lupustr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lupustr3/subscriptions","organizations_url":"https://api.github.com/users/lupustr3/orgs","repos_url":"https://api.github.com/users/lupustr3/repos","events_url":"https://api.github.com/users/lupustr3/events{/privacy}","received_events_url":"https://api.github.com/users/lupustr3/received_events","type":"User","site_admin":false},"repo":{"id":24755211,"name":"opencv","full_name":"lupustr3/opencv","owner":{"login":"lupustr3","id":6407682,"avatar_url":"https://avatars.githubusercontent.com/u/6407682?v=3","gravatar_id":"","url":"https://api.github.com/users/lupustr3","html_url":"https://github.com/lupustr3","followers_url":"https://api.github.com/users/lupustr3/followers","following_url":"https://api.github.com/users/lupustr3/following{/other_user}","gists_url":"https://api.github.com/users/lupustr3/gists{/gist_id}","starred_url":"https://api.github.com/users/lupustr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lupustr3/subscriptions","organizations_url":"https://api.github.com/users/lupustr3/orgs","repos_url":"https://api.github.com/users/lupustr3/repos","events_url":"https://api.github.com/users/lupustr3/events{/privacy}","received_events_url":"https://api.github.com/users/lupustr3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lupustr3/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/lupustr3/opencv","forks_url":"https://api.github.com/repos/lupustr3/opencv/forks","keys_url":"https://api.github.com/repos/lupustr3/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lupustr3/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lupustr3/opencv/teams","hooks_url":"https://api.github.com/repos/lupustr3/opencv/hooks","issue_events_url":"https://api.github.com/repos/lupustr3/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/lupustr3/opencv/events","assignees_url":"https://api.github.com/repos/lupustr3/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/lupustr3/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/lupustr3/opencv/tags","blobs_url":"https://api.github.com/repos/lupustr3/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lupustr3/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lupustr3/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/lupustr3/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lupustr3/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/lupustr3/opencv/languages","stargazers_url":"https://api.github.com/repos/lupustr3/opencv/stargazers","contributors_url":"https://api.github.com/repos/lupustr3/opencv/contributors","subscribers_url":"https://api.github.com/repos/lupustr3/opencv/subscribers","subscription_url":"https://api.github.com/repos/lupustr3/opencv/subscription","commits_url":"https://api.github.com/repos/lupustr3/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/lupustr3/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/lupustr3/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/lupustr3/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/lupustr3/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/lupustr3/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lupustr3/opencv/merges","archive_url":"https://api.github.com/repos/lupustr3/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lupustr3/opencv/downloads","issues_url":"https://api.github.com/repos/lupustr3/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/lupustr3/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/lupustr3/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/lupustr3/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lupustr3/opencv/labels{/name}","releases_url":"https://api.github.com/repos/lupustr3/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/lupustr3/opencv/deployments","created_at":"2014-10-03T10:54:05Z","updated_at":"2016-07-04T13:46:38Z","pushed_at":"2016-08-16T06:42:58Z","git_url":"git://github.com/lupustr3/opencv.git","ssh_url":"git@github.com:lupustr3/opencv.git","clone_url":"https://github.com/lupustr3/opencv.git","svn_url":"https://github.com/lupustr3/opencv","homepage":"opencv.org","size":423128,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencv:master","ref":"master","sha":"e884bbabcb7eedfa3b20b251055bb9130643100c","user":{"login":"opencv","id":5009934,"avatar_url":"https://avatars.githubusercontent.com/u/5009934?v=3","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"opencv/opencv","owner":{"login":"opencv","id":5009934,"avatar_url":"https://avatars.githubusercontent.com/u/5009934?v=3","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencv/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/opencv/opencv","forks_url":"https://api.github.com/repos/opencv/opencv/forks","keys_url":"https://api.github.com/repos/opencv/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencv/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencv/opencv/teams","hooks_url":"https://api.github.com/repos/opencv/opencv/hooks","issue_events_url":"https://api.github.com/repos/opencv/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/opencv/opencv/events","assignees_url":"https://api.github.com/repos/opencv/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/opencv/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/opencv/opencv/tags","blobs_url":"https://api.github.com/repos/opencv/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencv/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencv/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencv/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/opencv/opencv/languages","stargazers_url":"https://api.github.com/repos/opencv/opencv/stargazers","contributors_url":"https://api.github.com/repos/opencv/opencv/contributors","subscribers_url":"https://api.github.com/repos/opencv/opencv/subscribers","subscription_url":"https://api.github.com/repos/opencv/opencv/subscription","commits_url":"https://api.github.com/repos/opencv/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencv/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencv/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencv/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencv/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/opencv/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencv/opencv/merges","archive_url":"https://api.github.com/repos/opencv/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencv/opencv/downloads","issues_url":"https://api.github.com/repos/opencv/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/opencv/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/opencv/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/opencv/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencv/opencv/labels{/name}","releases_url":"https://api.github.com/repos/opencv/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/opencv/opencv/deployments","created_at":"2012-07-19T09:40:17Z","updated_at":"2016-08-16T09:59:46Z","pushed_at":"2016-08-16T10:12:28Z","git_url":"git://github.com/opencv/opencv.git","ssh_url":"git@github.com:opencv/opencv.git","clone_url":"https://github.com/opencv/opencv.git","svn_url":"https://github.com/opencv/opencv","homepage":"opencv.org","size":1081344,"stargazers_count":10723,"watchers_count":10723,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8890,"mirror_url":null,"open_issues_count":964,"forks":8890,"open_issues":964,"watchers":10723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7101"},"html":{"href":"https://github.com/opencv/opencv/pull/7101"},"issue":{"href":"https://api.github.com/repos/opencv/opencv/issues/7101"},"comments":{"href":"https://api.github.com/repos/opencv/opencv/issues/7101/comments"},"review_comments":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7101/comments"},"review_comment":{"href":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7101/commits"},"statuses":{"href":"https://api.github.com/repos/opencv/opencv/statuses/f689b9c632337795eb071b4ec6d24bb0169a57e2"}}}}
{"actor":{"display_login":"alalek"}}