{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/71773400","id":71773400,"diff_hunk":"@@ -16,6 +16,7 @@ class TestRecorder(unittest.TestCase):\n \n     def setUp(self):  # pylint: disable=invalid-name\n         \"\"\"Setup things to be run when tests are started.\"\"\"\n+        recorder._INSTANCE = None","path":"tests/components/recorder/test_init.py","position":4,"original_position":4,"commit_id":"a81159cdaffa6396aa87f5719a0da81895aa8177","original_commit_id":"a81159cdaffa6396aa87f5719a0da81895aa8177","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"When would this be `None` ? Means a test wasn't closed properly?","created_at":"2016-07-21T19:43:33Z","updated_at":"2016-07-21T19:43:33Z","html_url":"https://github.com/home-assistant/home-assistant/pull/2549#discussion_r71773400","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/71773400"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2549#discussion_r71773400"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549","id":77746407,"html_url":"https://github.com/home-assistant/home-assistant/pull/2549","diff_url":"https://github.com/home-assistant/home-assistant/pull/2549.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/2549.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2549","number":2549,"state":"open","locked":false,"title":"Update recorder.","user":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\n`models.py`\r\n - Use scoped_session in models.py (hopefully fixes shutdown error)\r\n\r\n`__init__.py`\r\n - Session `_commit` & retry method\r\n - Single session var in `_purge_old_data`\r\n - Ensure single `_INSTANCE`\r\n - repeat `_purge_old_data` every 2 days\r\n - show correct time in `log_error`\r\n\r\n\r\n\r\n**Related issue (if applicable):** fixes #\r\n\r\nOn HASS shutdown: sqlite object created in thread x and closed in thread y.\r\n\r\n**Checklist:**\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n\r\n","created_at":"2016-07-17T21:16:57Z","updated_at":"2016-07-21T19:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"298b0c5fb26b4048cd46d19d0ffdc270cd22adf3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2549/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a81159cdaffa6396aa87f5719a0da81895aa8177","head":{"label":"kellerza:recorder","ref":"recorder","sha":"a81159cdaffa6396aa87f5719a0da81895aa8177","user":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"repo":{"id":57890671,"name":"home-assistant","full_name":"kellerza/home-assistant","owner":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellerza/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/kellerza/home-assistant","forks_url":"https://api.github.com/repos/kellerza/home-assistant/forks","keys_url":"https://api.github.com/repos/kellerza/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellerza/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellerza/home-assistant/teams","hooks_url":"https://api.github.com/repos/kellerza/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/kellerza/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/kellerza/home-assistant/events","assignees_url":"https://api.github.com/repos/kellerza/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/kellerza/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/kellerza/home-assistant/tags","blobs_url":"https://api.github.com/repos/kellerza/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellerza/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellerza/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellerza/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellerza/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/kellerza/home-assistant/languages","stargazers_url":"https://api.github.com/repos/kellerza/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/kellerza/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/kellerza/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/kellerza/home-assistant/subscription","commits_url":"https://api.github.com/repos/kellerza/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellerza/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellerza/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellerza/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellerza/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/kellerza/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellerza/home-assistant/merges","archive_url":"https://api.github.com/repos/kellerza/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellerza/home-assistant/downloads","issues_url":"https://api.github.com/repos/kellerza/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/kellerza/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/kellerza/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/kellerza/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellerza/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/kellerza/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/kellerza/home-assistant/deployments","created_at":"2016-05-02T13:03:22Z","updated_at":"2016-05-02T13:03:25Z","pushed_at":"2016-07-20T20:02:16Z","git_url":"git://github.com/kellerza/home-assistant.git","ssh_url":"git@github.com:kellerza/home-assistant.git","clone_url":"https://github.com/kellerza/home-assistant.git","svn_url":"https://github.com/kellerza/home-assistant","homepage":"https://home-assistant.io","size":67265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"ddcad275f7df1c23f9eafedbcb89865646d38fdf","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-07-21T19:29:27Z","pushed_at":"2016-07-21T19:03:45Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":93881,"stargazers_count":3737,"watchers_count":3737,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":837,"mirror_url":null,"open_issues_count":163,"forks":837,"open_issues":163,"watchers":3737,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2549"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2549"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2549/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2549/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a81159cdaffa6396aa87f5719a0da81895aa8177"}}}}
{"actor":{"display_login":"balloob"}}