{"action":"created","comment":{"url":"https://api.github.com/repos/rcos/venue/pulls/comments/67812581","id":67812581,"diff_hunk":"@@ -59,9 +59,7 @@ function AuthService($location, $http, $cookies, $q, appConfig, Util, User) {\n     createUser(user, callback) {\n       return User.save(user,\n         function(data) {\n-          $cookies.put('token', data.token);\n-          currentUser = User.get();\n-          return safeCb(callback)(null, user);\n+          $location.path('/verify/emailVerification');","path":"client/components/auth/auth.service.js","position":7,"original_position":7,"commit_id":"d7045226496281ede98891acc6627f561dfe81e7","original_commit_id":"d7045226496281ede98891acc6627f561dfe81e7","user":{"login":"kmcnellis","id":5566205,"avatar_url":"https://avatars.githubusercontent.com/u/5566205?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcnellis","html_url":"https://github.com/kmcnellis","followers_url":"https://api.github.com/users/kmcnellis/followers","following_url":"https://api.github.com/users/kmcnellis/following{/other_user}","gists_url":"https://api.github.com/users/kmcnellis/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcnellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcnellis/subscriptions","organizations_url":"https://api.github.com/users/kmcnellis/orgs","repos_url":"https://api.github.com/users/kmcnellis/repos","events_url":"https://api.github.com/users/kmcnellis/events{/privacy}","received_events_url":"https://api.github.com/users/kmcnellis/received_events","type":"User","site_admin":false},"body":"We should not break the flow of the callback (and the overall signature consistency)- instead, we should add something in the user object to say it is unverified that the calling function can check and redirect","created_at":"2016-06-21T06:07:15Z","updated_at":"2016-06-21T06:07:15Z","html_url":"https://github.com/rcos/venue/pull/284#discussion_r67812581","pull_request_url":"https://api.github.com/repos/rcos/venue/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/rcos/venue/pulls/comments/67812581"},"html":{"href":"https://github.com/rcos/venue/pull/284#discussion_r67812581"},"pull_request":{"href":"https://api.github.com/repos/rcos/venue/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/rcos/venue/pulls/284","id":74341221,"html_url":"https://github.com/rcos/venue/pull/284","diff_url":"https://github.com/rcos/venue/pull/284.diff","patch_url":"https://github.com/rcos/venue/pull/284.patch","issue_url":"https://api.github.com/repos/rcos/venue/issues/284","number":284,"state":"open","locked":false,"title":"email confirmation on signup","user":{"login":"leej42","id":7064122,"avatar_url":"https://avatars.githubusercontent.com/u/7064122?v=3","gravatar_id":"","url":"https://api.github.com/users/leej42","html_url":"https://github.com/leej42","followers_url":"https://api.github.com/users/leej42/followers","following_url":"https://api.github.com/users/leej42/following{/other_user}","gists_url":"https://api.github.com/users/leej42/gists{/gist_id}","starred_url":"https://api.github.com/users/leej42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leej42/subscriptions","organizations_url":"https://api.github.com/users/leej42/orgs","repos_url":"https://api.github.com/users/leej42/repos","events_url":"https://api.github.com/users/leej42/events{/privacy}","received_events_url":"https://api.github.com/users/leej42/received_events","type":"User","site_admin":false},"body":"Emails user on signup with unique link. ","created_at":"2016-06-18T16:28:56Z","updated_at":"2016-06-21T06:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f4d6b8b432127af6948ed852d6f254ddb4dc3cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rcos/venue/pulls/284/commits","review_comments_url":"https://api.github.com/repos/rcos/venue/pulls/284/comments","review_comment_url":"https://api.github.com/repos/rcos/venue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcos/venue/issues/284/comments","statuses_url":"https://api.github.com/repos/rcos/venue/statuses/d7045226496281ede98891acc6627f561dfe81e7","head":{"label":"rcos:email-verf","ref":"email-verf","sha":"d7045226496281ede98891acc6627f561dfe81e7","user":{"login":"rcos","id":778001,"avatar_url":"https://avatars.githubusercontent.com/u/778001?v=3","gravatar_id":"","url":"https://api.github.com/users/rcos","html_url":"https://github.com/rcos","followers_url":"https://api.github.com/users/rcos/followers","following_url":"https://api.github.com/users/rcos/following{/other_user}","gists_url":"https://api.github.com/users/rcos/gists{/gist_id}","starred_url":"https://api.github.com/users/rcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcos/subscriptions","organizations_url":"https://api.github.com/users/rcos/orgs","repos_url":"https://api.github.com/users/rcos/repos","events_url":"https://api.github.com/users/rcos/events{/privacy}","received_events_url":"https://api.github.com/users/rcos/received_events","type":"Organization","site_admin":false},"repo":{"id":48069892,"name":"venue","full_name":"rcos/venue","owner":{"login":"rcos","id":778001,"avatar_url":"https://avatars.githubusercontent.com/u/778001?v=3","gravatar_id":"","url":"https://api.github.com/users/rcos","html_url":"https://github.com/rcos","followers_url":"https://api.github.com/users/rcos/followers","following_url":"https://api.github.com/users/rcos/following{/other_user}","gists_url":"https://api.github.com/users/rcos/gists{/gist_id}","starred_url":"https://api.github.com/users/rcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcos/subscriptions","organizations_url":"https://api.github.com/users/rcos/orgs","repos_url":"https://api.github.com/users/rcos/repos","events_url":"https://api.github.com/users/rcos/events{/privacy}","received_events_url":"https://api.github.com/users/rcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcos/venue","description":"","fork":false,"url":"https://api.github.com/repos/rcos/venue","forks_url":"https://api.github.com/repos/rcos/venue/forks","keys_url":"https://api.github.com/repos/rcos/venue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcos/venue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcos/venue/teams","hooks_url":"https://api.github.com/repos/rcos/venue/hooks","issue_events_url":"https://api.github.com/repos/rcos/venue/issues/events{/number}","events_url":"https://api.github.com/repos/rcos/venue/events","assignees_url":"https://api.github.com/repos/rcos/venue/assignees{/user}","branches_url":"https://api.github.com/repos/rcos/venue/branches{/branch}","tags_url":"https://api.github.com/repos/rcos/venue/tags","blobs_url":"https://api.github.com/repos/rcos/venue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcos/venue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcos/venue/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcos/venue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcos/venue/statuses/{sha}","languages_url":"https://api.github.com/repos/rcos/venue/languages","stargazers_url":"https://api.github.com/repos/rcos/venue/stargazers","contributors_url":"https://api.github.com/repos/rcos/venue/contributors","subscribers_url":"https://api.github.com/repos/rcos/venue/subscribers","subscription_url":"https://api.github.com/repos/rcos/venue/subscription","commits_url":"https://api.github.com/repos/rcos/venue/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcos/venue/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcos/venue/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcos/venue/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcos/venue/contents/{+path}","compare_url":"https://api.github.com/repos/rcos/venue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcos/venue/merges","archive_url":"https://api.github.com/repos/rcos/venue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcos/venue/downloads","issues_url":"https://api.github.com/repos/rcos/venue/issues{/number}","pulls_url":"https://api.github.com/repos/rcos/venue/pulls{/number}","milestones_url":"https://api.github.com/repos/rcos/venue/milestones{/number}","notifications_url":"https://api.github.com/repos/rcos/venue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcos/venue/labels{/name}","releases_url":"https://api.github.com/repos/rcos/venue/releases{/id}","deployments_url":"https://api.github.com/repos/rcos/venue/deployments","created_at":"2015-12-15T21:24:52Z","updated_at":"2016-05-11T18:00:20Z","pushed_at":"2016-06-21T05:45:46Z","git_url":"git://github.com/rcos/venue.git","ssh_url":"git@github.com:rcos/venue.git","clone_url":"https://github.com/rcos/venue.git","svn_url":"https://github.com/rcos/venue","homepage":null,"size":1138,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":44,"forks":1,"open_issues":44,"watchers":1,"default_branch":"dev"}},"base":{"label":"rcos:dev","ref":"dev","sha":"0249c3b9e2319495ec75d2dd7d74c6e4da82192a","user":{"login":"rcos","id":778001,"avatar_url":"https://avatars.githubusercontent.com/u/778001?v=3","gravatar_id":"","url":"https://api.github.com/users/rcos","html_url":"https://github.com/rcos","followers_url":"https://api.github.com/users/rcos/followers","following_url":"https://api.github.com/users/rcos/following{/other_user}","gists_url":"https://api.github.com/users/rcos/gists{/gist_id}","starred_url":"https://api.github.com/users/rcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcos/subscriptions","organizations_url":"https://api.github.com/users/rcos/orgs","repos_url":"https://api.github.com/users/rcos/repos","events_url":"https://api.github.com/users/rcos/events{/privacy}","received_events_url":"https://api.github.com/users/rcos/received_events","type":"Organization","site_admin":false},"repo":{"id":48069892,"name":"venue","full_name":"rcos/venue","owner":{"login":"rcos","id":778001,"avatar_url":"https://avatars.githubusercontent.com/u/778001?v=3","gravatar_id":"","url":"https://api.github.com/users/rcos","html_url":"https://github.com/rcos","followers_url":"https://api.github.com/users/rcos/followers","following_url":"https://api.github.com/users/rcos/following{/other_user}","gists_url":"https://api.github.com/users/rcos/gists{/gist_id}","starred_url":"https://api.github.com/users/rcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcos/subscriptions","organizations_url":"https://api.github.com/users/rcos/orgs","repos_url":"https://api.github.com/users/rcos/repos","events_url":"https://api.github.com/users/rcos/events{/privacy}","received_events_url":"https://api.github.com/users/rcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcos/venue","description":"","fork":false,"url":"https://api.github.com/repos/rcos/venue","forks_url":"https://api.github.com/repos/rcos/venue/forks","keys_url":"https://api.github.com/repos/rcos/venue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcos/venue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcos/venue/teams","hooks_url":"https://api.github.com/repos/rcos/venue/hooks","issue_events_url":"https://api.github.com/repos/rcos/venue/issues/events{/number}","events_url":"https://api.github.com/repos/rcos/venue/events","assignees_url":"https://api.github.com/repos/rcos/venue/assignees{/user}","branches_url":"https://api.github.com/repos/rcos/venue/branches{/branch}","tags_url":"https://api.github.com/repos/rcos/venue/tags","blobs_url":"https://api.github.com/repos/rcos/venue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcos/venue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcos/venue/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcos/venue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcos/venue/statuses/{sha}","languages_url":"https://api.github.com/repos/rcos/venue/languages","stargazers_url":"https://api.github.com/repos/rcos/venue/stargazers","contributors_url":"https://api.github.com/repos/rcos/venue/contributors","subscribers_url":"https://api.github.com/repos/rcos/venue/subscribers","subscription_url":"https://api.github.com/repos/rcos/venue/subscription","commits_url":"https://api.github.com/repos/rcos/venue/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcos/venue/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcos/venue/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcos/venue/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcos/venue/contents/{+path}","compare_url":"https://api.github.com/repos/rcos/venue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcos/venue/merges","archive_url":"https://api.github.com/repos/rcos/venue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcos/venue/downloads","issues_url":"https://api.github.com/repos/rcos/venue/issues{/number}","pulls_url":"https://api.github.com/repos/rcos/venue/pulls{/number}","milestones_url":"https://api.github.com/repos/rcos/venue/milestones{/number}","notifications_url":"https://api.github.com/repos/rcos/venue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcos/venue/labels{/name}","releases_url":"https://api.github.com/repos/rcos/venue/releases{/id}","deployments_url":"https://api.github.com/repos/rcos/venue/deployments","created_at":"2015-12-15T21:24:52Z","updated_at":"2016-05-11T18:00:20Z","pushed_at":"2016-06-21T05:45:46Z","git_url":"git://github.com/rcos/venue.git","ssh_url":"git@github.com:rcos/venue.git","clone_url":"https://github.com/rcos/venue.git","svn_url":"https://github.com/rcos/venue","homepage":null,"size":1138,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":44,"forks":1,"open_issues":44,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rcos/venue/pulls/284"},"html":{"href":"https://github.com/rcos/venue/pull/284"},"issue":{"href":"https://api.github.com/repos/rcos/venue/issues/284"},"comments":{"href":"https://api.github.com/repos/rcos/venue/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/rcos/venue/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/rcos/venue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcos/venue/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/rcos/venue/statuses/d7045226496281ede98891acc6627f561dfe81e7"}}}}
{"actor":{"display_login":"kmcnellis"}}