{"push_id":1294729032,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"a3b3134343bd3ffcaa7485d57188c72b098b788f","before":"3d064b4c04cd50e449e4e23f873df6fa337dac4e","commits":[{"sha":"0b73edcedb6ad2d6e5c0b5cd67b2e2bf578f1f23","author":{"name":"Matt Dolan","email":"a47ae50e8e6345ab5258b8086b87d68377031655@trello.com"},"message":"Copy all namespace declarations from Response\n\nThe `add_namespaces_to_child_assertions` function [assumes the presence of an\nInclusiveNamespaces\nelement](https://github.com/Clever/saml2/blob/6cad30fb1e0e9a59ae850f7de6bed4310a403ba9/lib/saml2.coffee#L399)\nfrom which it will read a list of namespaces.\n\nIf this is present, any namespace definitions declared by InclusiveNamespaces\nare copied from the Response element to the Assertion. Then, when the Assertion\nelement is handled in isolation from the rest of the Response document, the\nnamespaces are all still defined.\n\nHowever if the InclusiveNamespaces element is not found, no namespaces are\ncopied. If then the Assertion element is namespaced (e.g. `<saml:Assertion>`),\nit [will not be\nfound](https://github.com/Clever/saml2/blob/6cad30fb1e0e9a59ae850f7de6bed4310a403ba9/lib/saml2.coffee#L440)\nand the document will be treated as not having an assertion at all.\n\nIf there is an InclusiveNamespaces element, we will continue to use that as\nbefore to read the namespaces to apply to the Assertion element.\n\nHowever if there is none, we'll just read all the namespaces from the Response\nelement onto the Assertion element.\n\nThere seemed no value in asserting the presence of a Signature element within\nthe Assertion, as it's valid to just have the whole message signed, so I\nremoved that.","distinct":true,"url":"https://api.github.com/repos/Clever/saml2/commits/0b73edcedb6ad2d6e5c0b5cd67b2e2bf578f1f23"},{"sha":"f6a2d330b71eb9ca74d83640054eb31dcd51119a","author":{"name":"Matt Dolan","email":"a47ae50e8e6345ab5258b8086b87d68377031655@trello.com"},"message":"Add test for copying from InclusiveNamespaces node\n\nThis was the previous behaviour (as far as I can ascertain from the code).","distinct":true,"url":"https://api.github.com/repos/Clever/saml2/commits/f6a2d330b71eb9ca74d83640054eb31dcd51119a"},{"sha":"dfa25dc8d11bf12a2b92fadcf86a6db99340e8ad","author":{"name":"Matt Dolan","email":"a47ae50e8e6345ab5258b8086b87d68377031655@trello.com"},"message":"Use Response xmlns if InclusiveNamespaces is empty","distinct":true,"url":"https://api.github.com/repos/Clever/saml2/commits/dfa25dc8d11bf12a2b92fadcf86a6db99340e8ad"},{"sha":"8d297b06ed388fbd1064ad5396901047a55e5324","author":{"name":"Matt Dolan","email":"a47ae50e8e6345ab5258b8086b87d68377031655@trello.com"},"message":"fixup! Use Response xmlns if InclusiveNamespaces is empty","distinct":true,"url":"https://api.github.com/repos/Clever/saml2/commits/8d297b06ed388fbd1064ad5396901047a55e5324"},{"sha":"a3b3134343bd3ffcaa7485d57188c72b098b788f","author":{"name":"jefff","email":"e7cf81cfbe1236b438c6e5c8a88774fd8966b051@gmail.com"},"message":"Merge pull request #81 from trello/mdolan/no-inclusivenamespaces\n\nDon't rely on InclusiveNamespaces for namespace declarations","distinct":true,"url":"https://api.github.com/repos/Clever/saml2/commits/a3b3134343bd3ffcaa7485d57188c72b098b788f"}]}
{"actor":{"display_login":"jefff"}}