{"action":"created","comment":{"url":"https://api.github.com/repos/kaazing/gateway/pulls/comments/72355098","id":72355098,"diff_hunk":"@@ -618,4 +643,53 @@ public void run() {\n             }\n         });\n     }\n+\n+    public void register(NioChildDatagramChannel childChannel) {    // TODO no datagram specific\n+        registerTask(() -> {\n+            childChannels.put(childChannel.getId().intValue(), childChannel);\n+        });\n+    }\n+\n+    public void deregister(NioChildDatagramChannel childChannel) {\n+        registerTask(() -> {\n+            childChannels.remove(childChannel.getId().intValue());\n+        });\n+    }\n+\n+    public void messageReceived(NioChildDatagramChannel childChannel, Object message) {\n+        assert childChannel.getId() >= 0;\n+\n+        ChannelBuffer buf = (ChannelBuffer) message;\n+        ByteBuffer byteBuffer = buf.toByteBuffer();\n+        atomicBuffer.wrap(byteBuffer);\n+        ringBuffer.write(childChannel.getId(), atomicBuffer, 0, atomicBuffer.capacity());","path":"mina.netty/src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorker.java","position":101,"original_position":101,"commit_id":"f98f1f31b9a19772ba908ce6f6f557ede4f94138","original_commit_id":"f98f1f31b9a19772ba908ce6f6f557ede4f94138","user":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"body":"Probably worth commenting that this write will be skipped if the buffer is full, effectively dropping the UDP packet.","created_at":"2016-07-26T23:12:09Z","updated_at":"2016-07-26T23:12:09Z","html_url":"https://github.com/kaazing/gateway/pull/646#discussion_r72355098","pull_request_url":"https://api.github.com/repos/kaazing/gateway/pulls/646","_links":{"self":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/comments/72355098"},"html":{"href":"https://github.com/kaazing/gateway/pull/646#discussion_r72355098"},"pull_request":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/646"}}},"pull_request":{"url":"https://api.github.com/repos/kaazing/gateway/pulls/646","id":78062759,"html_url":"https://github.com/kaazing/gateway/pull/646","diff_url":"https://github.com/kaazing/gateway/pull/646.diff","patch_url":"https://github.com/kaazing/gateway/pull/646.patch","issue_url":"https://api.github.com/repos/kaazing/gateway/issues/646","number":646,"state":"open","locked":false,"title":"Udp impl using netty","user":{"login":"jitsni","id":5131125,"avatar_url":"https://avatars.githubusercontent.com/u/5131125?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsni","html_url":"https://github.com/jitsni","followers_url":"https://api.github.com/users/jitsni/followers","following_url":"https://api.github.com/users/jitsni/following{/other_user}","gists_url":"https://api.github.com/users/jitsni/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsni/subscriptions","organizations_url":"https://api.github.com/users/jitsni/orgs","repos_url":"https://api.github.com/users/jitsni/repos","events_url":"https://api.github.com/users/jitsni/events{/privacy}","received_events_url":"https://api.github.com/users/jitsni/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-19T22:50:15Z","updated_at":"2016-07-26T23:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2508b108ddc64fc13f471ab24ddd78fbd8e643d0","assignee":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"assignees":[{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaazing/gateway/pulls/646/commits","review_comments_url":"https://api.github.com/repos/kaazing/gateway/pulls/646/comments","review_comment_url":"https://api.github.com/repos/kaazing/gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaazing/gateway/issues/646/comments","statuses_url":"https://api.github.com/repos/kaazing/gateway/statuses/f98f1f31b9a19772ba908ce6f6f557ede4f94138","head":{"label":"jitsni:udp","ref":"udp","sha":"f98f1f31b9a19772ba908ce6f6f557ede4f94138","user":{"login":"jitsni","id":5131125,"avatar_url":"https://avatars.githubusercontent.com/u/5131125?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsni","html_url":"https://github.com/jitsni","followers_url":"https://api.github.com/users/jitsni/followers","following_url":"https://api.github.com/users/jitsni/following{/other_user}","gists_url":"https://api.github.com/users/jitsni/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsni/subscriptions","organizations_url":"https://api.github.com/users/jitsni/orgs","repos_url":"https://api.github.com/users/jitsni/repos","events_url":"https://api.github.com/users/jitsni/events{/privacy}","received_events_url":"https://api.github.com/users/jitsni/received_events","type":"User","site_admin":false},"repo":{"id":31753015,"name":"gateway","full_name":"jitsni/gateway","owner":{"login":"jitsni","id":5131125,"avatar_url":"https://avatars.githubusercontent.com/u/5131125?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsni","html_url":"https://github.com/jitsni","followers_url":"https://api.github.com/users/jitsni/followers","following_url":"https://api.github.com/users/jitsni/following{/other_user}","gists_url":"https://api.github.com/users/jitsni/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsni/subscriptions","organizations_url":"https://api.github.com/users/jitsni/orgs","repos_url":"https://api.github.com/users/jitsni/repos","events_url":"https://api.github.com/users/jitsni/events{/privacy}","received_events_url":"https://api.github.com/users/jitsni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jitsni/gateway","description":"Gateway distribution","fork":true,"url":"https://api.github.com/repos/jitsni/gateway","forks_url":"https://api.github.com/repos/jitsni/gateway/forks","keys_url":"https://api.github.com/repos/jitsni/gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsni/gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsni/gateway/teams","hooks_url":"https://api.github.com/repos/jitsni/gateway/hooks","issue_events_url":"https://api.github.com/repos/jitsni/gateway/issues/events{/number}","events_url":"https://api.github.com/repos/jitsni/gateway/events","assignees_url":"https://api.github.com/repos/jitsni/gateway/assignees{/user}","branches_url":"https://api.github.com/repos/jitsni/gateway/branches{/branch}","tags_url":"https://api.github.com/repos/jitsni/gateway/tags","blobs_url":"https://api.github.com/repos/jitsni/gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsni/gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsni/gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsni/gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsni/gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsni/gateway/languages","stargazers_url":"https://api.github.com/repos/jitsni/gateway/stargazers","contributors_url":"https://api.github.com/repos/jitsni/gateway/contributors","subscribers_url":"https://api.github.com/repos/jitsni/gateway/subscribers","subscription_url":"https://api.github.com/repos/jitsni/gateway/subscription","commits_url":"https://api.github.com/repos/jitsni/gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsni/gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsni/gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsni/gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsni/gateway/contents/{+path}","compare_url":"https://api.github.com/repos/jitsni/gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsni/gateway/merges","archive_url":"https://api.github.com/repos/jitsni/gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsni/gateway/downloads","issues_url":"https://api.github.com/repos/jitsni/gateway/issues{/number}","pulls_url":"https://api.github.com/repos/jitsni/gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsni/gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsni/gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsni/gateway/labels{/name}","releases_url":"https://api.github.com/repos/jitsni/gateway/releases{/id}","deployments_url":"https://api.github.com/repos/jitsni/gateway/deployments","created_at":"2015-03-06T04:46:53Z","updated_at":"2016-03-23T22:58:20Z","pushed_at":"2016-07-26T23:01:22Z","git_url":"git://github.com/jitsni/gateway.git","ssh_url":"git@github.com:jitsni/gateway.git","clone_url":"https://github.com/jitsni/gateway.git","svn_url":"https://github.com/jitsni/gateway","homepage":null,"size":17655,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"kaazing:develop","ref":"develop","sha":"2a51e13996feb0d463648c29a394060d4ff38ef1","user":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"repo":{"id":26745548,"name":"gateway","full_name":"kaazing/gateway","owner":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaazing/gateway","description":"Kaazing Gateway","fork":false,"url":"https://api.github.com/repos/kaazing/gateway","forks_url":"https://api.github.com/repos/kaazing/gateway/forks","keys_url":"https://api.github.com/repos/kaazing/gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaazing/gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaazing/gateway/teams","hooks_url":"https://api.github.com/repos/kaazing/gateway/hooks","issue_events_url":"https://api.github.com/repos/kaazing/gateway/issues/events{/number}","events_url":"https://api.github.com/repos/kaazing/gateway/events","assignees_url":"https://api.github.com/repos/kaazing/gateway/assignees{/user}","branches_url":"https://api.github.com/repos/kaazing/gateway/branches{/branch}","tags_url":"https://api.github.com/repos/kaazing/gateway/tags","blobs_url":"https://api.github.com/repos/kaazing/gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaazing/gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaazing/gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaazing/gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaazing/gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/kaazing/gateway/languages","stargazers_url":"https://api.github.com/repos/kaazing/gateway/stargazers","contributors_url":"https://api.github.com/repos/kaazing/gateway/contributors","subscribers_url":"https://api.github.com/repos/kaazing/gateway/subscribers","subscription_url":"https://api.github.com/repos/kaazing/gateway/subscription","commits_url":"https://api.github.com/repos/kaazing/gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaazing/gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaazing/gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaazing/gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaazing/gateway/contents/{+path}","compare_url":"https://api.github.com/repos/kaazing/gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaazing/gateway/merges","archive_url":"https://api.github.com/repos/kaazing/gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaazing/gateway/downloads","issues_url":"https://api.github.com/repos/kaazing/gateway/issues{/number}","pulls_url":"https://api.github.com/repos/kaazing/gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/kaazing/gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/kaazing/gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaazing/gateway/labels{/name}","releases_url":"https://api.github.com/repos/kaazing/gateway/releases{/id}","deployments_url":"https://api.github.com/repos/kaazing/gateway/deployments","created_at":"2014-11-17T07:40:57Z","updated_at":"2016-07-26T22:30:45Z","pushed_at":"2016-07-26T23:01:22Z","git_url":"git://github.com/kaazing/gateway.git","ssh_url":"git@github.com:kaazing/gateway.git","clone_url":"https://github.com/kaazing/gateway.git","svn_url":"https://github.com/kaazing/gateway","homepage":"","size":20642,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":70,"forks":55,"open_issues":70,"watchers":56,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/646"},"html":{"href":"https://github.com/kaazing/gateway/pull/646"},"issue":{"href":"https://api.github.com/repos/kaazing/gateway/issues/646"},"comments":{"href":"https://api.github.com/repos/kaazing/gateway/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaazing/gateway/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/kaazing/gateway/statuses/f98f1f31b9a19772ba908ce6f6f557ede4f94138"}}}}
{"actor":{"display_login":"jfallows"}}