{"action":"created","comment":{"url":"https://api.github.com/repos/otland/forgottenserver/pulls/comments/48972694","id":48972694,"diff_hunk":"@@ -825,7 +825,41 @@ std::string Item::getDescription(const ItemType& it, int32_t lookDistance,\n \t\t\t\ttmpSubType = item->getSubType();\n \t\t\t}\n \n-\t\t\ts << \". \" << (it.stackable && tmpSubType > 1 ? \"They\" : \"It\") << \" can only be used with\";\n+\t\t\ts << \". \" << (it.stackable && tmpSubType > 1 ? \"They\" : \"It\") << \" can only be used by \";\n+\n+\t\t\tVocSpellMap vocMap = g_spells->getRuneSpell(it.id)->getVocMap();","path":"src/item.cpp","position":31,"original_position":31,"commit_id":"4cd4c2fac3bee01e5875634102c4cfdaaf8f00fd","original_commit_id":"4cd4c2fac3bee01e5875634102c4cfdaaf8f00fd","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"body":"1) Doesn't that means someone has not configured a rune properly? By setting it as a rune but not assigning any callback to it. Maybe it can lead to other problems too.\r\n2) No, my bad, will fix.","created_at":"2016-01-06T16:02:29Z","updated_at":"2016-01-06T16:02:29Z","html_url":"https://github.com/otland/forgottenserver/pull/1665#discussion_r48972694","pull_request_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1665","_links":{"self":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/comments/48972694"},"html":{"href":"https://github.com/otland/forgottenserver/pull/1665#discussion_r48972694"},"pull_request":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1665"}}},"pull_request":{"url":"https://api.github.com/repos/otland/forgottenserver/pulls/1665","id":55158975,"html_url":"https://github.com/otland/forgottenserver/pull/1665","diff_url":"https://github.com/otland/forgottenserver/pull/1665.diff","patch_url":"https://github.com/otland/forgottenserver/pull/1665.patch","issue_url":"https://api.github.com/repos/otland/forgottenserver/issues/1665","number":1665,"state":"open","locked":false,"title":"Fix #1634: show vocations on runes look message","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"body":"As @Zbizu reported, vocation names were missing from runes look message.\r\n\r\nThings changed a bit: vocations are now required to be listed on `spells.xml` even if the unpromoted version already is. Also, it is assumed that if you specify no vocation, it is available to all of them (except, of course, `none`) and it will show `by players` instead of the vocation list.\r\n\r\nThe vocation list is, when used, shows as `(...) used by as, bs, cs... and zs with level (...)`. Examples:\r\n```\r\nIt can only be used by players with level 54 and magic level 18 or higher.\r\nIt can only be used by druids with level 54 and magic level 18 or higher.\r\nIt can only be used by druids and sorcerers with level 54 and magic level 18 or higher.\r\nIt can only be used by druids, paladins and sorcerers with level 54 and magic level 18 or higher.\r\n```\r\n\r\nRunes do not show magic words anymore, but I feel like it could be toggled by a configuration flag (not the matter of this PR).\r\n\r\nPlease report any errors. Thanks to @slavidodo who was also developing a solution.","created_at":"2016-01-05T23:38:33Z","updated_at":"2016-01-06T16:02:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"283d1f6f30f2a1ba77b5a1297d06199c8d6c5478","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1665/commits","review_comments_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1665/comments","review_comment_url":"https://api.github.com/repos/otland/forgottenserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otland/forgottenserver/issues/1665/comments","statuses_url":"https://api.github.com/repos/otland/forgottenserver/statuses/4cd4c2fac3bee01e5875634102c4cfdaaf8f00fd","head":{"label":"ranisalt:fix-runes-look-msg","ref":"fix-runes-look-msg","sha":"4cd4c2fac3bee01e5875634102c4cfdaaf8f00fd","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"repo":{"id":34152469,"name":"forgottenserver","full_name":"ranisalt/forgottenserver","owner":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ranisalt/forgottenserver","description":"A free and open-source MMORPG server emulator written in C++","fork":true,"url":"https://api.github.com/repos/ranisalt/forgottenserver","forks_url":"https://api.github.com/repos/ranisalt/forgottenserver/forks","keys_url":"https://api.github.com/repos/ranisalt/forgottenserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ranisalt/forgottenserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ranisalt/forgottenserver/teams","hooks_url":"https://api.github.com/repos/ranisalt/forgottenserver/hooks","issue_events_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues/events{/number}","events_url":"https://api.github.com/repos/ranisalt/forgottenserver/events","assignees_url":"https://api.github.com/repos/ranisalt/forgottenserver/assignees{/user}","branches_url":"https://api.github.com/repos/ranisalt/forgottenserver/branches{/branch}","tags_url":"https://api.github.com/repos/ranisalt/forgottenserver/tags","blobs_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ranisalt/forgottenserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ranisalt/forgottenserver/languages","stargazers_url":"https://api.github.com/repos/ranisalt/forgottenserver/stargazers","contributors_url":"https://api.github.com/repos/ranisalt/forgottenserver/contributors","subscribers_url":"https://api.github.com/repos/ranisalt/forgottenserver/subscribers","subscription_url":"https://api.github.com/repos/ranisalt/forgottenserver/subscription","commits_url":"https://api.github.com/repos/ranisalt/forgottenserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ranisalt/forgottenserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ranisalt/forgottenserver/contents/{+path}","compare_url":"https://api.github.com/repos/ranisalt/forgottenserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ranisalt/forgottenserver/merges","archive_url":"https://api.github.com/repos/ranisalt/forgottenserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ranisalt/forgottenserver/downloads","issues_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues{/number}","pulls_url":"https://api.github.com/repos/ranisalt/forgottenserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ranisalt/forgottenserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ranisalt/forgottenserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ranisalt/forgottenserver/labels{/name}","releases_url":"https://api.github.com/repos/ranisalt/forgottenserver/releases{/id}","created_at":"2015-04-18T04:34:37Z","updated_at":"2015-07-21T11:25:29Z","pushed_at":"2016-01-05T23:32:58Z","git_url":"git://github.com/ranisalt/forgottenserver.git","ssh_url":"git@github.com:ranisalt/forgottenserver.git","clone_url":"https://github.com/ranisalt/forgottenserver.git","svn_url":"https://github.com/ranisalt/forgottenserver","homepage":"","size":12294,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"otland:master","ref":"master","sha":"545dd736bb3176c43287859d8e6d959a12146937","user":{"login":"otland","id":4956302,"avatar_url":"https://avatars.githubusercontent.com/u/4956302?v=3","gravatar_id":"","url":"https://api.github.com/users/otland","html_url":"https://github.com/otland","followers_url":"https://api.github.com/users/otland/followers","following_url":"https://api.github.com/users/otland/following{/other_user}","gists_url":"https://api.github.com/users/otland/gists{/gist_id}","starred_url":"https://api.github.com/users/otland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otland/subscriptions","organizations_url":"https://api.github.com/users/otland/orgs","repos_url":"https://api.github.com/users/otland/repos","events_url":"https://api.github.com/users/otland/events{/privacy}","received_events_url":"https://api.github.com/users/otland/received_events","type":"Organization","site_admin":false},"repo":{"id":11081909,"name":"forgottenserver","full_name":"otland/forgottenserver","owner":{"login":"otland","id":4956302,"avatar_url":"https://avatars.githubusercontent.com/u/4956302?v=3","gravatar_id":"","url":"https://api.github.com/users/otland","html_url":"https://github.com/otland","followers_url":"https://api.github.com/users/otland/followers","following_url":"https://api.github.com/users/otland/following{/other_user}","gists_url":"https://api.github.com/users/otland/gists{/gist_id}","starred_url":"https://api.github.com/users/otland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otland/subscriptions","organizations_url":"https://api.github.com/users/otland/orgs","repos_url":"https://api.github.com/users/otland/repos","events_url":"https://api.github.com/users/otland/events{/privacy}","received_events_url":"https://api.github.com/users/otland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otland/forgottenserver","description":"A free and open-source MMORPG server emulator written in C++","fork":false,"url":"https://api.github.com/repos/otland/forgottenserver","forks_url":"https://api.github.com/repos/otland/forgottenserver/forks","keys_url":"https://api.github.com/repos/otland/forgottenserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otland/forgottenserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otland/forgottenserver/teams","hooks_url":"https://api.github.com/repos/otland/forgottenserver/hooks","issue_events_url":"https://api.github.com/repos/otland/forgottenserver/issues/events{/number}","events_url":"https://api.github.com/repos/otland/forgottenserver/events","assignees_url":"https://api.github.com/repos/otland/forgottenserver/assignees{/user}","branches_url":"https://api.github.com/repos/otland/forgottenserver/branches{/branch}","tags_url":"https://api.github.com/repos/otland/forgottenserver/tags","blobs_url":"https://api.github.com/repos/otland/forgottenserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otland/forgottenserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otland/forgottenserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/otland/forgottenserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otland/forgottenserver/statuses/{sha}","languages_url":"https://api.github.com/repos/otland/forgottenserver/languages","stargazers_url":"https://api.github.com/repos/otland/forgottenserver/stargazers","contributors_url":"https://api.github.com/repos/otland/forgottenserver/contributors","subscribers_url":"https://api.github.com/repos/otland/forgottenserver/subscribers","subscription_url":"https://api.github.com/repos/otland/forgottenserver/subscription","commits_url":"https://api.github.com/repos/otland/forgottenserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/otland/forgottenserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/otland/forgottenserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/otland/forgottenserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/otland/forgottenserver/contents/{+path}","compare_url":"https://api.github.com/repos/otland/forgottenserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otland/forgottenserver/merges","archive_url":"https://api.github.com/repos/otland/forgottenserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otland/forgottenserver/downloads","issues_url":"https://api.github.com/repos/otland/forgottenserver/issues{/number}","pulls_url":"https://api.github.com/repos/otland/forgottenserver/pulls{/number}","milestones_url":"https://api.github.com/repos/otland/forgottenserver/milestones{/number}","notifications_url":"https://api.github.com/repos/otland/forgottenserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otland/forgottenserver/labels{/name}","releases_url":"https://api.github.com/repos/otland/forgottenserver/releases{/id}","created_at":"2013-07-01T01:57:06Z","updated_at":"2016-01-04T20:53:10Z","pushed_at":"2016-01-06T15:59:17Z","git_url":"git://github.com/otland/forgottenserver.git","ssh_url":"git@github.com:otland/forgottenserver.git","clone_url":"https://github.com/otland/forgottenserver.git","svn_url":"https://github.com/otland/forgottenserver","homepage":"","size":16864,"stargazers_count":293,"watchers_count":293,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":147,"forks":319,"open_issues":147,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1665"},"html":{"href":"https://github.com/otland/forgottenserver/pull/1665"},"issue":{"href":"https://api.github.com/repos/otland/forgottenserver/issues/1665"},"comments":{"href":"https://api.github.com/repos/otland/forgottenserver/issues/1665/comments"},"review_comments":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1665/comments"},"review_comment":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1665/commits"},"statuses":{"href":"https://api.github.com/repos/otland/forgottenserver/statuses/4cd4c2fac3bee01e5875634102c4cfdaaf8f00fd"}}}}