{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/63984581","id":63984581,"diff_hunk":"@@ -467,8 +467,14 @@\n \n       <dependency>\n         <groupId>com.google.code.findbugs</groupId>\n+        <artifactId>annotations</artifactId>\n+        <version>${findbugs.version}</version>\n+      </dependency>\n+\n+      <dependency>\n+        <groupId>com.google.code.findbugs</groupId>\n         <artifactId>jsr305</artifactId>\n-        <version>${jsr305.version}</version>\n+        <version>${findbugs.version}</version>","path":"pom.xml","position":22,"original_position":22,"commit_id":"3ed3745462e26d6e3f092d4c103b6ffb274ccb7f","original_commit_id":"3ed3745462e26d6e3f092d4c103b6ffb274ccb7f","user":{"login":"kennknowles","id":575353,"avatar_url":"https://avatars.githubusercontent.com/u/575353?v=3","gravatar_id":"","url":"https://api.github.com/users/kennknowles","html_url":"https://github.com/kennknowles","followers_url":"https://api.github.com/users/kennknowles/followers","following_url":"https://api.github.com/users/kennknowles/following{/other_user}","gists_url":"https://api.github.com/users/kennknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/kennknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennknowles/subscriptions","organizations_url":"https://api.github.com/users/kennknowles/orgs","repos_url":"https://api.github.com/users/kennknowles/repos","events_url":"https://api.github.com/users/kennknowles/events{/privacy}","received_events_url":"https://api.github.com/users/kennknowles/received_events","type":"User","site_admin":false},"body":"We talked in person, so I understand the reason for the two deps, and their overlap, and why their order is necessary to satisfy `dependency:analyze`. Can you post `dependency:tree`, preferably a curated diff? This has been great for discussion of things like this in the past.","created_at":"2016-05-20T02:41:03Z","updated_at":"2016-05-20T02:41:03Z","html_url":"https://github.com/apache/incubator-beam/pull/357#discussion_r63984581","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/357","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/63984581"},"html":{"href":"https://github.com/apache/incubator-beam/pull/357#discussion_r63984581"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/357","id":70757138,"html_url":"https://github.com/apache/incubator-beam/pull/357","diff_url":"https://github.com/apache/incubator-beam/pull/357.diff","patch_url":"https://github.com/apache/incubator-beam/pull/357.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/357","number":357,"state":"open","locked":false,"title":"[BEAM-176] Add FindBugs analysis to the build","user":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nFindBugs is a static analysis tool which looks for common coding issues in Java code. See: http://findbugs.sourceforge.net/\r\n\r\nThis PR integrates FindBugs into the build process using findbugs-maven-plugin, and subscribes java-sdk-all for analysis.\r\n\r\nThe codebase currently generates many Findbugs issues, which have been added in the findbugs-filter.xml file as a baseline. These issues should be triaged and fixed over time.\r\n\r\nThere will be some cases where we choose to ignore issues reported by FindBugs. In such a case, the issue should be suppressed in code via the `@SuppressFBWarnings` annotation with a comment describing why it is suppressed.\r\n","created_at":"2016-05-19T20:10:55Z","updated_at":"2016-05-20T02:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e4e0461757e7e411dd27c8c64fc901a436c0f99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/357/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/357/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/357/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/3ed3745462e26d6e3f092d4c103b6ffb274ccb7f","head":{"label":"swegner:findbugs","ref":"findbugs","sha":"3ed3745462e26d6e3f092d4c103b6ffb274ccb7f","user":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"repo":{"id":52832170,"name":"incubator-beam","full_name":"swegner/incubator-beam","owner":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swegner/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/swegner/incubator-beam","forks_url":"https://api.github.com/repos/swegner/incubator-beam/forks","keys_url":"https://api.github.com/repos/swegner/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swegner/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swegner/incubator-beam/teams","hooks_url":"https://api.github.com/repos/swegner/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/swegner/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/swegner/incubator-beam/events","assignees_url":"https://api.github.com/repos/swegner/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/swegner/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/swegner/incubator-beam/tags","blobs_url":"https://api.github.com/repos/swegner/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swegner/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swegner/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/swegner/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swegner/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/swegner/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/swegner/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/swegner/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/swegner/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/swegner/incubator-beam/subscription","commits_url":"https://api.github.com/repos/swegner/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/swegner/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/swegner/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/swegner/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/swegner/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/swegner/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swegner/incubator-beam/merges","archive_url":"https://api.github.com/repos/swegner/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swegner/incubator-beam/downloads","issues_url":"https://api.github.com/repos/swegner/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/swegner/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/swegner/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/swegner/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swegner/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/swegner/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/swegner/incubator-beam/deployments","created_at":"2016-02-29T23:20:08Z","updated_at":"2016-02-29T23:20:11Z","pushed_at":"2016-05-19T23:14:18Z","git_url":"git://github.com/swegner/incubator-beam.git","ssh_url":"git@github.com:swegner/incubator-beam.git","clone_url":"https://github.com/swegner/incubator-beam.git","svn_url":"https://github.com/swegner/incubator-beam","homepage":null,"size":14298,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"662e493515e43b26eab9d2d44b3b01487b31a2f4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-05-19T19:06:19Z","pushed_at":"2016-05-20T01:58:21Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":17047,"stargazers_count":192,"watchers_count":192,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":31,"forks":94,"open_issues":31,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/357"},"html":{"href":"https://github.com/apache/incubator-beam/pull/357"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/357"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/3ed3745462e26d6e3f092d4c103b6ffb274ccb7f"}}}}
{"actor":{"display_login":"kennknowles"}}