{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botoflow/pulls/comments/80669631","pull_request_review_id":1709543,"id":80669631,"diff_hunk":"@@ -0,0 +1,75 @@\n+==================\n+Helloworld Example\n+==================\n+\n+**Requires: python3**\n+\n+This example creates a two activities and one decider for those activities. The first activity will\n+ask for a name and then the second activity will print that name.\n+\n+How To\n+------\n+\n+Preconfiguration\n+~~~~~~~~~~~~~~~~\n+\n+First an IAM user with privileges in SWF is needed. Can inline policy for an existing user can be:\n+\n+.. code-block::\n+\n+    {\n+      \"Version\": \"2012-10-17\",\n+      \"Statement\": [\n+        {\n+          \"Action\": [\n+            \"swf:*\"\n+          ],\n+          \"Effect\": \"Allow\",\n+          \"Resource\": \"*\"\n+        }\n+      ]\n+    }\n+\n+\n+Setup a SWF ``domain`` and register the ``workflow-type`` in your AWS account before being able to run this example.\n+\n+This is possible with ``awscli``:\n+\n+.. code-block:: sh\n+\n+    $ aws swf register-domain \\\n+              --name helloworld \\\n+              --description \"Helloworld domain\" \\\n+              --workflow-execution-retention-period-in-days 7 \\\n+              --region us-east-1\n+\n+\n+Configuration","path":"examples/helloworld/README.rst","position":47,"original_position":47,"commit_id":"6fb4aa735a6cd8eeb93a67ab76d09072dd953638","original_commit_id":"6fb4aa735a6cd8eeb93a67ab76d09072dd953638","user":{"login":"darjus","id":177063,"avatar_url":"https://avatars.githubusercontent.com/u/177063?v=3","gravatar_id":"","url":"https://api.github.com/users/darjus","html_url":"https://github.com/darjus","followers_url":"https://api.github.com/users/darjus/followers","following_url":"https://api.github.com/users/darjus/following{/other_user}","gists_url":"https://api.github.com/users/darjus/gists{/gist_id}","starred_url":"https://api.github.com/users/darjus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darjus/subscriptions","organizations_url":"https://api.github.com/users/darjus/orgs","repos_url":"https://api.github.com/users/darjus/repos","events_url":"https://api.github.com/users/darjus/events{/privacy}","received_events_url":"https://api.github.com/users/darjus/received_events","type":"User","site_admin":false},"body":"It's interesting that you provide a configuration example here. I'd love to better understand the reasoning here and whether it's a missing feature? (again not blocking for the pr, but I'm trying to learn use-cases to build a better product).","created_at":"2016-09-27T11:19:19Z","updated_at":"2016-09-27T11:19:19Z","html_url":"https://github.com/boto/botoflow/pull/2#discussion_r80669631","pull_request_url":"https://api.github.com/repos/boto/botoflow/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/boto/botoflow/pulls/comments/80669631"},"html":{"href":"https://github.com/boto/botoflow/pull/2#discussion_r80669631"},"pull_request":{"href":"https://api.github.com/repos/boto/botoflow/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botoflow/pulls/2","id":86819394,"html_url":"https://github.com/boto/botoflow/pull/2","diff_url":"https://github.com/boto/botoflow/pull/2.diff","patch_url":"https://github.com/boto/botoflow/pull/2.patch","issue_url":"https://api.github.com/repos/boto/botoflow/issues/2","number":2,"state":"open","locked":false,"title":"Fix typos and added a complete helloworld example","user":{"login":"l2ol33rt","id":1453062,"avatar_url":"https://avatars.githubusercontent.com/u/1453062?v=3","gravatar_id":"","url":"https://api.github.com/users/l2ol33rt","html_url":"https://github.com/l2ol33rt","followers_url":"https://api.github.com/users/l2ol33rt/followers","following_url":"https://api.github.com/users/l2ol33rt/following{/other_user}","gists_url":"https://api.github.com/users/l2ol33rt/gists{/gist_id}","starred_url":"https://api.github.com/users/l2ol33rt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2ol33rt/subscriptions","organizations_url":"https://api.github.com/users/l2ol33rt/orgs","repos_url":"https://api.github.com/users/l2ol33rt/repos","events_url":"https://api.github.com/users/l2ol33rt/events{/privacy}","received_events_url":"https://api.github.com/users/l2ol33rt/received_events","type":"User","site_admin":false},"body":"PR containing:\r\n* Fixes for typos  found while review the documentation.\r\n* Additionally I'd like to propose adding an `examples` directory. Ive added a full working example of the `helloworld` code from the overview page. I think this will be really helpful to people initially getting started with botoflow. (Thank you @paulcollinsiii for the help and examples!)\r\n\r\nCurrently only works with Python3.\r\n\r\nLooking forward to your thoughts!\r\n\r\n~Rob","created_at":"2016-09-26T21:09:37Z","updated_at":"2016-09-27T11:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67714148d10b43034f2ea82f5a40df25ffc54da1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/boto/botoflow/pulls/2/commits","review_comments_url":"https://api.github.com/repos/boto/botoflow/pulls/2/comments","review_comment_url":"https://api.github.com/repos/boto/botoflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botoflow/issues/2/comments","statuses_url":"https://api.github.com/repos/boto/botoflow/statuses/6fb4aa735a6cd8eeb93a67ab76d09072dd953638","head":{"label":"l2ol33rt:create_helloworld_example","ref":"create_helloworld_example","sha":"6fb4aa735a6cd8eeb93a67ab76d09072dd953638","user":{"login":"l2ol33rt","id":1453062,"avatar_url":"https://avatars.githubusercontent.com/u/1453062?v=3","gravatar_id":"","url":"https://api.github.com/users/l2ol33rt","html_url":"https://github.com/l2ol33rt","followers_url":"https://api.github.com/users/l2ol33rt/followers","following_url":"https://api.github.com/users/l2ol33rt/following{/other_user}","gists_url":"https://api.github.com/users/l2ol33rt/gists{/gist_id}","starred_url":"https://api.github.com/users/l2ol33rt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2ol33rt/subscriptions","organizations_url":"https://api.github.com/users/l2ol33rt/orgs","repos_url":"https://api.github.com/users/l2ol33rt/repos","events_url":"https://api.github.com/users/l2ol33rt/events{/privacy}","received_events_url":"https://api.github.com/users/l2ol33rt/received_events","type":"User","site_admin":false},"repo":{"id":69064213,"name":"botoflow","full_name":"l2ol33rt/botoflow","owner":{"login":"l2ol33rt","id":1453062,"avatar_url":"https://avatars.githubusercontent.com/u/1453062?v=3","gravatar_id":"","url":"https://api.github.com/users/l2ol33rt","html_url":"https://github.com/l2ol33rt","followers_url":"https://api.github.com/users/l2ol33rt/followers","following_url":"https://api.github.com/users/l2ol33rt/following{/other_user}","gists_url":"https://api.github.com/users/l2ol33rt/gists{/gist_id}","starred_url":"https://api.github.com/users/l2ol33rt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2ol33rt/subscriptions","organizations_url":"https://api.github.com/users/l2ol33rt/orgs","repos_url":"https://api.github.com/users/l2ol33rt/repos","events_url":"https://api.github.com/users/l2ol33rt/events{/privacy}","received_events_url":"https://api.github.com/users/l2ol33rt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/l2ol33rt/botoflow","description":"Botoflow is an asynchronous framework for Amazon SWF that helps you build SWF applications using Python","fork":true,"url":"https://api.github.com/repos/l2ol33rt/botoflow","forks_url":"https://api.github.com/repos/l2ol33rt/botoflow/forks","keys_url":"https://api.github.com/repos/l2ol33rt/botoflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l2ol33rt/botoflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l2ol33rt/botoflow/teams","hooks_url":"https://api.github.com/repos/l2ol33rt/botoflow/hooks","issue_events_url":"https://api.github.com/repos/l2ol33rt/botoflow/issues/events{/number}","events_url":"https://api.github.com/repos/l2ol33rt/botoflow/events","assignees_url":"https://api.github.com/repos/l2ol33rt/botoflow/assignees{/user}","branches_url":"https://api.github.com/repos/l2ol33rt/botoflow/branches{/branch}","tags_url":"https://api.github.com/repos/l2ol33rt/botoflow/tags","blobs_url":"https://api.github.com/repos/l2ol33rt/botoflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l2ol33rt/botoflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l2ol33rt/botoflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/l2ol33rt/botoflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l2ol33rt/botoflow/statuses/{sha}","languages_url":"https://api.github.com/repos/l2ol33rt/botoflow/languages","stargazers_url":"https://api.github.com/repos/l2ol33rt/botoflow/stargazers","contributors_url":"https://api.github.com/repos/l2ol33rt/botoflow/contributors","subscribers_url":"https://api.github.com/repos/l2ol33rt/botoflow/subscribers","subscription_url":"https://api.github.com/repos/l2ol33rt/botoflow/subscription","commits_url":"https://api.github.com/repos/l2ol33rt/botoflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/l2ol33rt/botoflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/l2ol33rt/botoflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/l2ol33rt/botoflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/l2ol33rt/botoflow/contents/{+path}","compare_url":"https://api.github.com/repos/l2ol33rt/botoflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l2ol33rt/botoflow/merges","archive_url":"https://api.github.com/repos/l2ol33rt/botoflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l2ol33rt/botoflow/downloads","issues_url":"https://api.github.com/repos/l2ol33rt/botoflow/issues{/number}","pulls_url":"https://api.github.com/repos/l2ol33rt/botoflow/pulls{/number}","milestones_url":"https://api.github.com/repos/l2ol33rt/botoflow/milestones{/number}","notifications_url":"https://api.github.com/repos/l2ol33rt/botoflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l2ol33rt/botoflow/labels{/name}","releases_url":"https://api.github.com/repos/l2ol33rt/botoflow/releases{/id}","deployments_url":"https://api.github.com/repos/l2ol33rt/botoflow/deployments","created_at":"2016-09-23T22:14:31Z","updated_at":"2016-09-23T22:14:32Z","pushed_at":"2016-09-26T21:08:36Z","git_url":"git://github.com/l2ol33rt/botoflow.git","ssh_url":"git@github.com:l2ol33rt/botoflow.git","clone_url":"https://github.com/l2ol33rt/botoflow.git","svn_url":"https://github.com/l2ol33rt/botoflow","homepage":"http://botoflow.readthedocs.io","size":382,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boto:master","ref":"master","sha":"bdb87b59226e249a1f8bf4f8914e44815dcffcab","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":60211054,"name":"botoflow","full_name":"boto/botoflow","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botoflow","description":"Botoflow is an asynchronous framework for Amazon SWF that helps you build SWF applications using Python","fork":false,"url":"https://api.github.com/repos/boto/botoflow","forks_url":"https://api.github.com/repos/boto/botoflow/forks","keys_url":"https://api.github.com/repos/boto/botoflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botoflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botoflow/teams","hooks_url":"https://api.github.com/repos/boto/botoflow/hooks","issue_events_url":"https://api.github.com/repos/boto/botoflow/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botoflow/events","assignees_url":"https://api.github.com/repos/boto/botoflow/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botoflow/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botoflow/tags","blobs_url":"https://api.github.com/repos/boto/botoflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botoflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botoflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botoflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botoflow/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botoflow/languages","stargazers_url":"https://api.github.com/repos/boto/botoflow/stargazers","contributors_url":"https://api.github.com/repos/boto/botoflow/contributors","subscribers_url":"https://api.github.com/repos/boto/botoflow/subscribers","subscription_url":"https://api.github.com/repos/boto/botoflow/subscription","commits_url":"https://api.github.com/repos/boto/botoflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botoflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botoflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botoflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botoflow/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botoflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botoflow/merges","archive_url":"https://api.github.com/repos/boto/botoflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botoflow/downloads","issues_url":"https://api.github.com/repos/boto/botoflow/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botoflow/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botoflow/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botoflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botoflow/labels{/name}","releases_url":"https://api.github.com/repos/boto/botoflow/releases{/id}","deployments_url":"https://api.github.com/repos/boto/botoflow/deployments","created_at":"2016-06-01T21:10:25Z","updated_at":"2016-07-21T12:00:44Z","pushed_at":"2016-09-26T21:09:37Z","git_url":"git://github.com/boto/botoflow.git","ssh_url":"git@github.com:boto/botoflow.git","clone_url":"https://github.com/boto/botoflow.git","svn_url":"https://github.com/boto/botoflow","homepage":"http://botoflow.readthedocs.io","size":379,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botoflow/pulls/2"},"html":{"href":"https://github.com/boto/botoflow/pull/2"},"issue":{"href":"https://api.github.com/repos/boto/botoflow/issues/2"},"comments":{"href":"https://api.github.com/repos/boto/botoflow/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botoflow/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botoflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botoflow/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botoflow/statuses/6fb4aa735a6cd8eeb93a67ab76d09072dd953638"}}}}
{"actor":{"display_login":"darjus"}}