{"action":"closed","number":319,"pull_request":{"url":"https://api.github.com/repos/almighty/almighty-core/pulls/319","id":87438255,"html_url":"https://github.com/almighty/almighty-core/pull/319","diff_url":"https://github.com/almighty/almighty-core/pull/319.diff","patch_url":"https://github.com/almighty/almighty-core/pull/319.patch","issue_url":"https://api.github.com/repos/almighty/almighty-core/issues/319","number":319,"state":"closed","locked":false,"title":"Avoid too early expansion of $PATH variable","user":{"login":"kwk","id":193408,"avatar_url":"https://avatars.githubusercontent.com/u/193408?v=3","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"body":"The first version we had caused problems on Windows systems: `$(PATH)`. This was problematic due to paths with whitespaces in them.\r\n\r\nIn my second approach I did this: `$$(PATH)`. The double `$$` was used to avoid a too early expansion of the `PATH` variable. Sadly this was also wrong and cause troubles (see [this mail thread](https://www.redhat.com/archives/almighty-public/2016-September/msg00219.html))\r\n\r\nThis time, the early expansion is correct: `$$PATH`.\r\n\r\nLot of text for such a small change ;)","created_at":"2016-09-30T05:58:08Z","updated_at":"2016-09-30T06:35:16Z","closed_at":"2016-09-30T06:35:16Z","merged_at":"2016-09-30T06:35:16Z","merge_commit_sha":"289e3381a7139f2e80c156bcc6d7be48dabace94","assignee":{"login":"baijum","id":121129,"avatar_url":"https://avatars.githubusercontent.com/u/121129?v=3","gravatar_id":"","url":"https://api.github.com/users/baijum","html_url":"https://github.com/baijum","followers_url":"https://api.github.com/users/baijum/followers","following_url":"https://api.github.com/users/baijum/following{/other_user}","gists_url":"https://api.github.com/users/baijum/gists{/gist_id}","starred_url":"https://api.github.com/users/baijum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baijum/subscriptions","organizations_url":"https://api.github.com/users/baijum/orgs","repos_url":"https://api.github.com/users/baijum/repos","events_url":"https://api.github.com/users/baijum/events{/privacy}","received_events_url":"https://api.github.com/users/baijum/received_events","type":"User","site_admin":false},"assignees":[{"login":"baijum","id":121129,"avatar_url":"https://avatars.githubusercontent.com/u/121129?v=3","gravatar_id":"","url":"https://api.github.com/users/baijum","html_url":"https://github.com/baijum","followers_url":"https://api.github.com/users/baijum/followers","following_url":"https://api.github.com/users/baijum/following{/other_user}","gists_url":"https://api.github.com/users/baijum/gists{/gist_id}","starred_url":"https://api.github.com/users/baijum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baijum/subscriptions","organizations_url":"https://api.github.com/users/baijum/orgs","repos_url":"https://api.github.com/users/baijum/repos","events_url":"https://api.github.com/users/baijum/events{/privacy}","received_events_url":"https://api.github.com/users/baijum/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/almighty/almighty-core/pulls/319/commits","review_comments_url":"https://api.github.com/repos/almighty/almighty-core/pulls/319/comments","review_comment_url":"https://api.github.com/repos/almighty/almighty-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almighty/almighty-core/issues/319/comments","statuses_url":"https://api.github.com/repos/almighty/almighty-core/statuses/59655f381131c97f702fa0c0bd5ce2e89fbf74bb","head":{"label":"kwk:avoid-too-early-var-expansion","ref":"avoid-too-early-var-expansion","sha":"59655f381131c97f702fa0c0bd5ce2e89fbf74bb","user":{"login":"kwk","id":193408,"avatar_url":"https://avatars.githubusercontent.com/u/193408?v=3","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"repo":{"id":61216531,"name":"almighty-core","full_name":"kwk/almighty-core","owner":{"login":"kwk","id":193408,"avatar_url":"https://avatars.githubusercontent.com/u/193408?v=3","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwk/almighty-core","description":"","fork":true,"url":"https://api.github.com/repos/kwk/almighty-core","forks_url":"https://api.github.com/repos/kwk/almighty-core/forks","keys_url":"https://api.github.com/repos/kwk/almighty-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwk/almighty-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwk/almighty-core/teams","hooks_url":"https://api.github.com/repos/kwk/almighty-core/hooks","issue_events_url":"https://api.github.com/repos/kwk/almighty-core/issues/events{/number}","events_url":"https://api.github.com/repos/kwk/almighty-core/events","assignees_url":"https://api.github.com/repos/kwk/almighty-core/assignees{/user}","branches_url":"https://api.github.com/repos/kwk/almighty-core/branches{/branch}","tags_url":"https://api.github.com/repos/kwk/almighty-core/tags","blobs_url":"https://api.github.com/repos/kwk/almighty-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwk/almighty-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwk/almighty-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwk/almighty-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwk/almighty-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kwk/almighty-core/languages","stargazers_url":"https://api.github.com/repos/kwk/almighty-core/stargazers","contributors_url":"https://api.github.com/repos/kwk/almighty-core/contributors","subscribers_url":"https://api.github.com/repos/kwk/almighty-core/subscribers","subscription_url":"https://api.github.com/repos/kwk/almighty-core/subscription","commits_url":"https://api.github.com/repos/kwk/almighty-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwk/almighty-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwk/almighty-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwk/almighty-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwk/almighty-core/contents/{+path}","compare_url":"https://api.github.com/repos/kwk/almighty-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwk/almighty-core/merges","archive_url":"https://api.github.com/repos/kwk/almighty-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwk/almighty-core/downloads","issues_url":"https://api.github.com/repos/kwk/almighty-core/issues{/number}","pulls_url":"https://api.github.com/repos/kwk/almighty-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kwk/almighty-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kwk/almighty-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwk/almighty-core/labels{/name}","releases_url":"https://api.github.com/repos/kwk/almighty-core/releases{/id}","deployments_url":"https://api.github.com/repos/kwk/almighty-core/deployments","created_at":"2016-06-15T14:55:29Z","updated_at":"2016-06-15T14:55:30Z","pushed_at":"2016-09-30T05:52:55Z","git_url":"git://github.com/kwk/almighty-core.git","ssh_url":"git@github.com:kwk/almighty-core.git","clone_url":"https://github.com/kwk/almighty-core.git","svn_url":"https://github.com/kwk/almighty-core","homepage":null,"size":440,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"almighty:master","ref":"master","sha":"e9c0e9a7ee3f451d5d87bb24c000c3cf2c566e9b","user":{"login":"almighty","id":17783151,"avatar_url":"https://avatars.githubusercontent.com/u/17783151?v=3","gravatar_id":"","url":"https://api.github.com/users/almighty","html_url":"https://github.com/almighty","followers_url":"https://api.github.com/users/almighty/followers","following_url":"https://api.github.com/users/almighty/following{/other_user}","gists_url":"https://api.github.com/users/almighty/gists{/gist_id}","starred_url":"https://api.github.com/users/almighty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almighty/subscriptions","organizations_url":"https://api.github.com/users/almighty/orgs","repos_url":"https://api.github.com/users/almighty/repos","events_url":"https://api.github.com/users/almighty/events{/privacy}","received_events_url":"https://api.github.com/users/almighty/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"name":"almighty-core","full_name":"almighty/almighty-core","owner":{"login":"almighty","id":17783151,"avatar_url":"https://avatars.githubusercontent.com/u/17783151?v=3","gravatar_id":"","url":"https://api.github.com/users/almighty","html_url":"https://github.com/almighty","followers_url":"https://api.github.com/users/almighty/followers","following_url":"https://api.github.com/users/almighty/following{/other_user}","gists_url":"https://api.github.com/users/almighty/gists{/gist_id}","starred_url":"https://api.github.com/users/almighty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almighty/subscriptions","organizations_url":"https://api.github.com/users/almighty/orgs","repos_url":"https://api.github.com/users/almighty/repos","events_url":"https://api.github.com/users/almighty/events{/privacy}","received_events_url":"https://api.github.com/users/almighty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almighty/almighty-core","description":"","fork":false,"url":"https://api.github.com/repos/almighty/almighty-core","forks_url":"https://api.github.com/repos/almighty/almighty-core/forks","keys_url":"https://api.github.com/repos/almighty/almighty-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almighty/almighty-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almighty/almighty-core/teams","hooks_url":"https://api.github.com/repos/almighty/almighty-core/hooks","issue_events_url":"https://api.github.com/repos/almighty/almighty-core/issues/events{/number}","events_url":"https://api.github.com/repos/almighty/almighty-core/events","assignees_url":"https://api.github.com/repos/almighty/almighty-core/assignees{/user}","branches_url":"https://api.github.com/repos/almighty/almighty-core/branches{/branch}","tags_url":"https://api.github.com/repos/almighty/almighty-core/tags","blobs_url":"https://api.github.com/repos/almighty/almighty-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almighty/almighty-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almighty/almighty-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/almighty/almighty-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almighty/almighty-core/statuses/{sha}","languages_url":"https://api.github.com/repos/almighty/almighty-core/languages","stargazers_url":"https://api.github.com/repos/almighty/almighty-core/stargazers","contributors_url":"https://api.github.com/repos/almighty/almighty-core/contributors","subscribers_url":"https://api.github.com/repos/almighty/almighty-core/subscribers","subscription_url":"https://api.github.com/repos/almighty/almighty-core/subscription","commits_url":"https://api.github.com/repos/almighty/almighty-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/almighty/almighty-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/almighty/almighty-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/almighty/almighty-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/almighty/almighty-core/contents/{+path}","compare_url":"https://api.github.com/repos/almighty/almighty-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almighty/almighty-core/merges","archive_url":"https://api.github.com/repos/almighty/almighty-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almighty/almighty-core/downloads","issues_url":"https://api.github.com/repos/almighty/almighty-core/issues{/number}","pulls_url":"https://api.github.com/repos/almighty/almighty-core/pulls{/number}","milestones_url":"https://api.github.com/repos/almighty/almighty-core/milestones{/number}","notifications_url":"https://api.github.com/repos/almighty/almighty-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almighty/almighty-core/labels{/name}","releases_url":"https://api.github.com/repos/almighty/almighty-core/releases{/id}","deployments_url":"https://api.github.com/repos/almighty/almighty-core/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2016-09-21T20:02:55Z","pushed_at":"2016-09-30T06:35:16Z","git_url":"git://github.com/almighty/almighty-core.git","ssh_url":"git@github.com:almighty/almighty-core.git","clone_url":"https://github.com/almighty/almighty-core.git","svn_url":"https://github.com/almighty/almighty-core","homepage":"http://devdoc.almighty.io/","size":4768,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":105,"forks":27,"open_issues":105,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/319"},"html":{"href":"https://github.com/almighty/almighty-core/pull/319"},"issue":{"href":"https://api.github.com/repos/almighty/almighty-core/issues/319"},"comments":{"href":"https://api.github.com/repos/almighty/almighty-core/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/almighty/almighty-core/statuses/59655f381131c97f702fa0c0bd5ce2e89fbf74bb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kwk","id":193408,"avatar_url":"https://avatars.githubusercontent.com/u/193408?v=3","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"kwk"}}