{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/68085822","id":68085822,"diff_hunk":"@@ -173,7 +173,7 @@ function(strip_symbols targetName outputFilename)\n                     COMMAND ${STRIP} -u -r ${strip_source_file}\n                     COMMENT Stripping symbols from ${strip_source_file} into file ${strip_destination_file}\n                 )\n-            else(CMAKE_SYSTEM_NAME STREQUAL Darwin)\n+            elseif(CMAKE_SYSTEM_NAME STREQUAL Linux)","path":"src/Native/CMakeLists.txt","position":5,"original_position":5,"commit_id":"3a0b4c5f34e6e59adaf70b39cb9578390b0d05c7","original_commit_id":"3a0b4c5f34e6e59adaf70b39cb9578390b0d05c7","user":{"login":"adityamandaleeka","id":219224,"avatar_url":"https://avatars.githubusercontent.com/u/219224?v=3","gravatar_id":"","url":"https://api.github.com/users/adityamandaleeka","html_url":"https://github.com/adityamandaleeka","followers_url":"https://api.github.com/users/adityamandaleeka/followers","following_url":"https://api.github.com/users/adityamandaleeka/following{/other_user}","gists_url":"https://api.github.com/users/adityamandaleeka/gists{/gist_id}","starred_url":"https://api.github.com/users/adityamandaleeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityamandaleeka/subscriptions","organizations_url":"https://api.github.com/users/adityamandaleeka/orgs","repos_url":"https://api.github.com/users/adityamandaleeka/repos","events_url":"https://api.github.com/users/adityamandaleeka/events{/privacy}","received_events_url":"https://api.github.com/users/adityamandaleeka/received_events","type":"User","site_admin":false},"body":"@stephentoub No, I believe, the old logic works fine. In CMake, including an expression in the `else` and `endif` like this is optional and just indicates that they logically belong with the `if` (similar to how we sometimes include comments next to `#endif` in our C++ code which show which `#ifdef` they are ending).","created_at":"2016-06-22T16:22:28Z","updated_at":"2016-06-22T16:22:28Z","html_url":"https://github.com/dotnet/corefx/pull/9598#discussion_r68085822","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/9598","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/68085822"},"html":{"href":"https://github.com/dotnet/corefx/pull/9598#discussion_r68085822"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9598"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/9598","id":74769471,"html_url":"https://github.com/dotnet/corefx/pull/9598","diff_url":"https://github.com/dotnet/corefx/pull/9598.diff","patch_url":"https://github.com/dotnet/corefx/pull/9598.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/9598","number":9598,"state":"open","locked":false,"title":"Change branch condition in `if` statement.","user":{"login":"lemmaa","id":1185333,"avatar_url":"https://avatars.githubusercontent.com/u/1185333?v=3","gravatar_id":"","url":"https://api.github.com/users/lemmaa","html_url":"https://github.com/lemmaa","followers_url":"https://api.github.com/users/lemmaa/followers","following_url":"https://api.github.com/users/lemmaa/following{/other_user}","gists_url":"https://api.github.com/users/lemmaa/gists{/gist_id}","starred_url":"https://api.github.com/users/lemmaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemmaa/subscriptions","organizations_url":"https://api.github.com/users/lemmaa/orgs","repos_url":"https://api.github.com/users/lemmaa/repos","events_url":"https://api.github.com/users/lemmaa/events{/privacy}","received_events_url":"https://api.github.com/users/lemmaa/received_events","type":"User","site_admin":false},"body":"- To make clear, change target `Darwin` to `Linux` with `elseif`.","created_at":"2016-06-22T11:45:20Z","updated_at":"2016-06-22T16:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e99bf26aa8f86a50b4e4f7725d738ac0b3b4b49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/9598/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/9598/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/9598/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3a0b4c5f34e6e59adaf70b39cb9578390b0d05c7","head":{"label":"lemmaa:fix-cmake-function","ref":"fix-cmake-function","sha":"3a0b4c5f34e6e59adaf70b39cb9578390b0d05c7","user":{"login":"lemmaa","id":1185333,"avatar_url":"https://avatars.githubusercontent.com/u/1185333?v=3","gravatar_id":"","url":"https://api.github.com/users/lemmaa","html_url":"https://github.com/lemmaa","followers_url":"https://api.github.com/users/lemmaa/followers","following_url":"https://api.github.com/users/lemmaa/following{/other_user}","gists_url":"https://api.github.com/users/lemmaa/gists{/gist_id}","starred_url":"https://api.github.com/users/lemmaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemmaa/subscriptions","organizations_url":"https://api.github.com/users/lemmaa/orgs","repos_url":"https://api.github.com/users/lemmaa/repos","events_url":"https://api.github.com/users/lemmaa/events{/privacy}","received_events_url":"https://api.github.com/users/lemmaa/received_events","type":"User","site_admin":false},"repo":{"id":51966896,"name":"corefx","full_name":"lemmaa/corefx","owner":{"login":"lemmaa","id":1185333,"avatar_url":"https://avatars.githubusercontent.com/u/1185333?v=3","gravatar_id":"","url":"https://api.github.com/users/lemmaa","html_url":"https://github.com/lemmaa","followers_url":"https://api.github.com/users/lemmaa/followers","following_url":"https://api.github.com/users/lemmaa/following{/other_user}","gists_url":"https://api.github.com/users/lemmaa/gists{/gist_id}","starred_url":"https://api.github.com/users/lemmaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemmaa/subscriptions","organizations_url":"https://api.github.com/users/lemmaa/orgs","repos_url":"https://api.github.com/users/lemmaa/repos","events_url":"https://api.github.com/users/lemmaa/events{/privacy}","received_events_url":"https://api.github.com/users/lemmaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lemmaa/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/lemmaa/corefx","forks_url":"https://api.github.com/repos/lemmaa/corefx/forks","keys_url":"https://api.github.com/repos/lemmaa/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lemmaa/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lemmaa/corefx/teams","hooks_url":"https://api.github.com/repos/lemmaa/corefx/hooks","issue_events_url":"https://api.github.com/repos/lemmaa/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/lemmaa/corefx/events","assignees_url":"https://api.github.com/repos/lemmaa/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/lemmaa/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/lemmaa/corefx/tags","blobs_url":"https://api.github.com/repos/lemmaa/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lemmaa/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lemmaa/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/lemmaa/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lemmaa/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/lemmaa/corefx/languages","stargazers_url":"https://api.github.com/repos/lemmaa/corefx/stargazers","contributors_url":"https://api.github.com/repos/lemmaa/corefx/contributors","subscribers_url":"https://api.github.com/repos/lemmaa/corefx/subscribers","subscription_url":"https://api.github.com/repos/lemmaa/corefx/subscription","commits_url":"https://api.github.com/repos/lemmaa/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/lemmaa/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/lemmaa/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/lemmaa/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/lemmaa/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/lemmaa/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lemmaa/corefx/merges","archive_url":"https://api.github.com/repos/lemmaa/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lemmaa/corefx/downloads","issues_url":"https://api.github.com/repos/lemmaa/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/lemmaa/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/lemmaa/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/lemmaa/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lemmaa/corefx/labels{/name}","releases_url":"https://api.github.com/repos/lemmaa/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/lemmaa/corefx/deployments","created_at":"2016-02-18T00:46:58Z","updated_at":"2016-02-18T00:47:22Z","pushed_at":"2016-06-22T12:31:19Z","git_url":"git://github.com/lemmaa/corefx.git","ssh_url":"git@github.com:lemmaa/corefx.git","clone_url":"https://github.com/lemmaa/corefx.git","svn_url":"https://github.com/lemmaa/corefx","homepage":"http://dotnet.github.io/","size":75069,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a181783ef0c51da547144d78b81bb07f77923228","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-06-22T14:50:16Z","pushed_at":"2016-06-22T16:02:18Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://dotnet.github.io/","size":108682,"stargazers_count":9920,"watchers_count":9920,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2415,"mirror_url":null,"open_issues_count":1070,"forks":2415,"open_issues":1070,"watchers":9920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9598"},"html":{"href":"https://github.com/dotnet/corefx/pull/9598"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/9598"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/9598/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9598/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9598/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3a0b4c5f34e6e59adaf70b39cb9578390b0d05c7"}}}}
{"actor":{"display_login":"adityamandaleeka"}}