{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10","id":74550171,"html_url":"https://github.com/skiflink/googlemaps_dbsync/pull/10","diff_url":"https://github.com/skiflink/googlemaps_dbsync/pull/10.diff","patch_url":"https://github.com/skiflink/googlemaps_dbsync/pull/10.patch","issue_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/10","number":10,"state":"open","locked":false,"title":"Refactor specs","user":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"body":"This PR includes:\r\n\r\n* LOTS OF SPEC WORK\r\n* Clean up spec and split into directories\r\n\r\n* Model specs, just for models\r\n* Refactor/standardise models\r\n\r\n* Service specs added\r\n* Comment out a lot of console logs to clean up spec output (keeping in for now, for debugging)\r\n* Stop using postcodes sql import in tests and just mock out ones used in fixtures\r\n\r\nHopeful TODOs in the future:\r\n\r\n* Abstract model functions as a lot of duplication. This will clean up specs too.\r\n* More model specs for erroring etc.\r\n* Mock postcode object rather than using model.\r\n* Code coverage\r\n* Linter\r\n* Promises\r\n* Loads more\r\n\r\n","created_at":"2016-06-21T04:33:23Z","updated_at":"2016-06-21T04:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10/commits","review_comments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10/comments","review_comment_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/10/comments","statuses_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/statuses/3543512e19221990bcbee8491094560958fdbdea","head":{"label":"skiflink:refactor-specs","ref":"refactor-specs","sha":"3543512e19221990bcbee8491094560958fdbdea","user":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"repo":{"id":55508198,"name":"googlemaps_dbsync","full_name":"skiflink/googlemaps_dbsync","owner":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skiflink/googlemaps_dbsync","description":"Sync google maps data to database - API for retrieval and syncing","fork":false,"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync","forks_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/forks","keys_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/teams","hooks_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/hooks","issue_events_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/events{/number}","events_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/events","assignees_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/assignees{/user}","branches_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/branches{/branch}","tags_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/tags","blobs_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/statuses/{sha}","languages_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/languages","stargazers_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/stargazers","contributors_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/contributors","subscribers_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/subscribers","subscription_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/subscription","commits_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/contents/{+path}","compare_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/merges","archive_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/downloads","issues_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues{/number}","pulls_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls{/number}","milestones_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/milestones{/number}","notifications_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/labels{/name}","releases_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/releases{/id}","deployments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/deployments","created_at":"2016-04-05T13:01:44Z","updated_at":"2016-04-05T13:03:53Z","pushed_at":"2016-06-21T04:21:18Z","git_url":"git://github.com/skiflink/googlemaps_dbsync.git","ssh_url":"git@github.com:skiflink/googlemaps_dbsync.git","clone_url":"https://github.com/skiflink/googlemaps_dbsync.git","svn_url":"https://github.com/skiflink/googlemaps_dbsync","homepage":null,"size":275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"skiflink:master","ref":"master","sha":"8003cf268af3e818b8bb2a328b4b07807010c278","user":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"repo":{"id":55508198,"name":"googlemaps_dbsync","full_name":"skiflink/googlemaps_dbsync","owner":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skiflink/googlemaps_dbsync","description":"Sync google maps data to database - API for retrieval and syncing","fork":false,"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync","forks_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/forks","keys_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/teams","hooks_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/hooks","issue_events_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/events{/number}","events_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/events","assignees_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/assignees{/user}","branches_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/branches{/branch}","tags_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/tags","blobs_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/statuses/{sha}","languages_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/languages","stargazers_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/stargazers","contributors_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/contributors","subscribers_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/subscribers","subscription_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/subscription","commits_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/contents/{+path}","compare_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/merges","archive_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/downloads","issues_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues{/number}","pulls_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls{/number}","milestones_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/milestones{/number}","notifications_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/labels{/name}","releases_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/releases{/id}","deployments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/deployments","created_at":"2016-04-05T13:01:44Z","updated_at":"2016-04-05T13:03:53Z","pushed_at":"2016-06-21T04:21:18Z","git_url":"git://github.com/skiflink/googlemaps_dbsync.git","ssh_url":"git@github.com:skiflink/googlemaps_dbsync.git","clone_url":"https://github.com/skiflink/googlemaps_dbsync.git","svn_url":"https://github.com/skiflink/googlemaps_dbsync","homepage":null,"size":275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10"},"html":{"href":"https://github.com/skiflink/googlemaps_dbsync/pull/10"},"issue":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/10"},"comments":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/skiflink/googlemaps_dbsync/statuses/3543512e19221990bcbee8491094560958fdbdea"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":370,"deletions":178,"changed_files":14}}
{"actor":{"display_login":"skiflink"}}