{"action":"created","comment":{"url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/comments/84597996","pull_request_review_id":5366645,"id":84597996,"diff_hunk":"@@ -203,7 +203,12 @@\n       },\n \n       tryLogIn: function() {\n-        this.$.ajaxLogin.generateRequest();\n+        if (this.$.username.validate()) {\n+          this.$.ajaxLogin.generateRequest();\n+        } else {\n+          this.loginError = false;\n+          this.loginErrorMessage = '';","path":"app/elements/lancie-login/lancie-login-form.html","position":86,"original_position":38,"commit_id":"5332c846a71b44173469fcc607716c968bbf475d","original_commit_id":"5332c846a71b44173469fcc607716c968bbf475d","user":{"login":"mgajanssen","id":9624753,"avatar_url":"https://avatars.githubusercontent.com/u/9624753?v=3","gravatar_id":"","url":"https://api.github.com/users/mgajanssen","html_url":"https://github.com/mgajanssen","followers_url":"https://api.github.com/users/mgajanssen/followers","following_url":"https://api.github.com/users/mgajanssen/following{/other_user}","gists_url":"https://api.github.com/users/mgajanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/mgajanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgajanssen/subscriptions","organizations_url":"https://api.github.com/users/mgajanssen/orgs","repos_url":"https://api.github.com/users/mgajanssen/repos","events_url":"https://api.github.com/users/mgajanssen/events{/privacy}","received_events_url":"https://api.github.com/users/mgajanssen/received_events","type":"User","site_admin":false},"body":"Yes this is intended, there is no need to check the password, upon registering the password has to have a length. The password cannot be empty, the server returns `Bad credentials`, this is also shown in the login screen.","created_at":"2016-10-23T15:21:14Z","updated_at":"2016-10-23T15:21:14Z","html_url":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281#discussion_r84597996","pull_request_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/comments/84597996"},"html":{"href":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281#discussion_r84597996"},"pull_request":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281","id":89453975,"html_url":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281","diff_url":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281.diff","patch_url":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281.patch","issue_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/281","number":281,"state":"open","locked":false,"title":"Change login method & email check","user":{"login":"mgajanssen","id":9624753,"avatar_url":"https://avatars.githubusercontent.com/u/9624753?v=3","gravatar_id":"","url":"https://api.github.com/users/mgajanssen","html_url":"https://github.com/mgajanssen","followers_url":"https://api.github.com/users/mgajanssen/followers","following_url":"https://api.github.com/users/mgajanssen/following{/other_user}","gists_url":"https://api.github.com/users/mgajanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/mgajanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgajanssen/subscriptions","organizations_url":"https://api.github.com/users/mgajanssen/orgs","repos_url":"https://api.github.com/users/mgajanssen/repos","events_url":"https://api.github.com/users/mgajanssen/events{/privacy}","received_events_url":"https://api.github.com/users/mgajanssen/received_events","type":"User","site_admin":false},"body":"Fixes #280 ","created_at":"2016-10-14T21:00:09Z","updated_at":"2016-10-23T15:21:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbd8dd9d95bb094cb6f9396b5fbd64fbfc242afc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281/commits","review_comments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281/comments","review_comment_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/281/comments","statuses_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/statuses/5332c846a71b44173469fcc607716c968bbf475d","head":{"label":"AreaFiftyLAN:feature-email_login","ref":"feature-email_login","sha":"5332c846a71b44173469fcc607716c968bbf475d","user":{"login":"AreaFiftyLAN","id":13952301,"avatar_url":"https://avatars.githubusercontent.com/u/13952301?v=3","gravatar_id":"","url":"https://api.github.com/users/AreaFiftyLAN","html_url":"https://github.com/AreaFiftyLAN","followers_url":"https://api.github.com/users/AreaFiftyLAN/followers","following_url":"https://api.github.com/users/AreaFiftyLAN/following{/other_user}","gists_url":"https://api.github.com/users/AreaFiftyLAN/gists{/gist_id}","starred_url":"https://api.github.com/users/AreaFiftyLAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AreaFiftyLAN/subscriptions","organizations_url":"https://api.github.com/users/AreaFiftyLAN/orgs","repos_url":"https://api.github.com/users/AreaFiftyLAN/repos","events_url":"https://api.github.com/users/AreaFiftyLAN/events{/privacy}","received_events_url":"https://api.github.com/users/AreaFiftyLAN/received_events","type":"Organization","site_admin":false},"repo":{"id":46064415,"name":"lancie-frontend","full_name":"AreaFiftyLAN/lancie-frontend","owner":{"login":"AreaFiftyLAN","id":13952301,"avatar_url":"https://avatars.githubusercontent.com/u/13952301?v=3","gravatar_id":"","url":"https://api.github.com/users/AreaFiftyLAN","html_url":"https://github.com/AreaFiftyLAN","followers_url":"https://api.github.com/users/AreaFiftyLAN/followers","following_url":"https://api.github.com/users/AreaFiftyLAN/following{/other_user}","gists_url":"https://api.github.com/users/AreaFiftyLAN/gists{/gist_id}","starred_url":"https://api.github.com/users/AreaFiftyLAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AreaFiftyLAN/subscriptions","organizations_url":"https://api.github.com/users/AreaFiftyLAN/orgs","repos_url":"https://api.github.com/users/AreaFiftyLAN/repos","events_url":"https://api.github.com/users/AreaFiftyLAN/events{/privacy}","received_events_url":"https://api.github.com/users/AreaFiftyLAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AreaFiftyLAN/lancie-frontend","description":"Website for Area FiftyLAN","fork":false,"url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend","forks_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/forks","keys_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/teams","hooks_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/hooks","issue_events_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/events","assignees_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/tags","blobs_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/languages","stargazers_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/stargazers","contributors_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/contributors","subscribers_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/subscribers","subscription_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/subscription","commits_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/merges","archive_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/downloads","issues_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/labels{/name}","releases_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/deployments","created_at":"2015-11-12T16:09:07Z","updated_at":"2016-10-22T23:16:21Z","pushed_at":"2016-10-23T15:15:50Z","git_url":"git://github.com/AreaFiftyLAN/lancie-frontend.git","ssh_url":"git@github.com:AreaFiftyLAN/lancie-frontend.git","clone_url":"https://github.com/AreaFiftyLAN/lancie-frontend.git","svn_url":"https://github.com/AreaFiftyLAN/lancie-frontend","homepage":"https://areafiftylan.nl","size":78883,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":2,"default_branch":"master"}},"base":{"label":"AreaFiftyLAN:master","ref":"master","sha":"38a5d3ea0f243438699d8b3d7d662a2b6eac1de7","user":{"login":"AreaFiftyLAN","id":13952301,"avatar_url":"https://avatars.githubusercontent.com/u/13952301?v=3","gravatar_id":"","url":"https://api.github.com/users/AreaFiftyLAN","html_url":"https://github.com/AreaFiftyLAN","followers_url":"https://api.github.com/users/AreaFiftyLAN/followers","following_url":"https://api.github.com/users/AreaFiftyLAN/following{/other_user}","gists_url":"https://api.github.com/users/AreaFiftyLAN/gists{/gist_id}","starred_url":"https://api.github.com/users/AreaFiftyLAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AreaFiftyLAN/subscriptions","organizations_url":"https://api.github.com/users/AreaFiftyLAN/orgs","repos_url":"https://api.github.com/users/AreaFiftyLAN/repos","events_url":"https://api.github.com/users/AreaFiftyLAN/events{/privacy}","received_events_url":"https://api.github.com/users/AreaFiftyLAN/received_events","type":"Organization","site_admin":false},"repo":{"id":46064415,"name":"lancie-frontend","full_name":"AreaFiftyLAN/lancie-frontend","owner":{"login":"AreaFiftyLAN","id":13952301,"avatar_url":"https://avatars.githubusercontent.com/u/13952301?v=3","gravatar_id":"","url":"https://api.github.com/users/AreaFiftyLAN","html_url":"https://github.com/AreaFiftyLAN","followers_url":"https://api.github.com/users/AreaFiftyLAN/followers","following_url":"https://api.github.com/users/AreaFiftyLAN/following{/other_user}","gists_url":"https://api.github.com/users/AreaFiftyLAN/gists{/gist_id}","starred_url":"https://api.github.com/users/AreaFiftyLAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AreaFiftyLAN/subscriptions","organizations_url":"https://api.github.com/users/AreaFiftyLAN/orgs","repos_url":"https://api.github.com/users/AreaFiftyLAN/repos","events_url":"https://api.github.com/users/AreaFiftyLAN/events{/privacy}","received_events_url":"https://api.github.com/users/AreaFiftyLAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AreaFiftyLAN/lancie-frontend","description":"Website for Area FiftyLAN","fork":false,"url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend","forks_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/forks","keys_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/teams","hooks_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/hooks","issue_events_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/events","assignees_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/tags","blobs_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/languages","stargazers_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/stargazers","contributors_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/contributors","subscribers_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/subscribers","subscription_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/subscription","commits_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/merges","archive_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/downloads","issues_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/labels{/name}","releases_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/deployments","created_at":"2015-11-12T16:09:07Z","updated_at":"2016-10-22T23:16:21Z","pushed_at":"2016-10-23T15:15:50Z","git_url":"git://github.com/AreaFiftyLAN/lancie-frontend.git","ssh_url":"git@github.com:AreaFiftyLAN/lancie-frontend.git","clone_url":"https://github.com/AreaFiftyLAN/lancie-frontend.git","svn_url":"https://github.com/AreaFiftyLAN/lancie-frontend","homepage":"https://areafiftylan.nl","size":78883,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281"},"html":{"href":"https://github.com/AreaFiftyLAN/lancie-frontend/pull/281"},"issue":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/281"},"comments":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/AreaFiftyLAN/lancie-frontend/statuses/5332c846a71b44173469fcc607716c968bbf475d"}}}}
{"actor":{"display_login":"mgajanssen"}}