{"action":"created","issue":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5948","repository_url":"https://api.github.com/repos/TEAMMATES/teammates","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5948/labels{/name}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5948/comments","events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5948/events","html_url":"https://github.com/TEAMMATES/teammates/pull/5948","id":168529614,"number":5948,"title":"student view team: Show team member profile photo #5943","user":{"login":"tarun14110","id":12219700,"avatar_url":"https://avatars.githubusercontent.com/u/12219700?v=3","gravatar_id":"","url":"https://api.github.com/users/tarun14110","html_url":"https://github.com/tarun14110","followers_url":"https://api.github.com/users/tarun14110/followers","following_url":"https://api.github.com/users/tarun14110/following{/other_user}","gists_url":"https://api.github.com/users/tarun14110/gists{/gist_id}","starred_url":"https://api.github.com/users/tarun14110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarun14110/subscriptions","organizations_url":"https://api.github.com/users/tarun14110/orgs","repos_url":"https://api.github.com/users/tarun14110/repos","events_url":"https://api.github.com/users/tarun14110/events{/privacy}","received_events_url":"https://api.github.com/users/tarun14110/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.Ongoing","name":"s.Ongoing","color":"6BC471"}],"state":"open","locked":false,"assignee":{"login":"chowyb","id":7546744,"avatar_url":"https://avatars.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"chowyb","id":7546744,"avatar_url":"https://avatars.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-07-31T17:53:08Z","updated_at":"2016-08-03T18:20:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5948","html_url":"https://github.com/TEAMMATES/teammates/pull/5948","diff_url":"https://github.com/TEAMMATES/teammates/pull/5948.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/5948.patch"},"body":"Fixes #5943\r\n\r\n![screenshot from 2016-08-01 00 26 23](https://cloud.githubusercontent.com/assets/12219700/17278614/a9a9aba2-577e-11e6-98d9-72707f11d44e.png)\r\n"},"comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments/237323768","html_url":"https://github.com/TEAMMATES/teammates/pull/5948#issuecomment-237323768","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5948","id":237323768,"user":{"login":"tarun14110","id":12219700,"avatar_url":"https://avatars.githubusercontent.com/u/12219700?v=3","gravatar_id":"","url":"https://api.github.com/users/tarun14110","html_url":"https://github.com/tarun14110","followers_url":"https://api.github.com/users/tarun14110/followers","following_url":"https://api.github.com/users/tarun14110/following{/other_user}","gists_url":"https://api.github.com/users/tarun14110/gists{/gist_id}","starred_url":"https://api.github.com/users/tarun14110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarun14110/subscriptions","organizations_url":"https://api.github.com/users/tarun14110/orgs","repos_url":"https://api.github.com/users/tarun14110/repos","events_url":"https://api.github.com/users/tarun14110/events{/privacy}","received_events_url":"https://api.github.com/users/tarun14110/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T18:20:37Z","updated_at":"2016-08-03T18:20:37Z","body":"I think we don't have `upload photo` tests other than testing through comparing `HTML` files in `StudentProfilePageUiTest`. `StudentProfileEditSaveActionTest` is just testing saving of other fields other than pictures. `StudentProfilePictureActionTest` tests retrieval of picture from given params.\r\n\r\n@chowyb we are checking displayed teammates in `StudentCourseDetailsPageActionTest`. Isn't that enough to ensure correct teammates are displayed. And to check for displayed content, we are using `HTML` comparisons ?\r\n\r\nOtherwise I can add a test in `StudentCourseDetailsPageActionTest`, as discussed above?"}}
{"actor":{"display_login":"tarun14110"}}