{"action":"created","comment":{"url":"https://api.github.com/repos/Karumi/Rosie/pulls/comments/57563043","id":57563043,"diff_hunk":"@@ -36,6 +36,8 @@ public class SampleApplication extends RosieApplication {\n }\n ```\n \n+**Extend from ``RosieApplication`` is needed to be able to easily use the configuration Rosie provides you related to Dependency Injection. If you do not want to use Dependency Injection in your project, you do not need to extend from ``RosieApplication``.**","path":"README.md","position":null,"original_position":4,"commit_id":"d45b365fb5ee3ebb50c0acb470ec04e279f61132","original_commit_id":"5e2be2e931864107f980c092dacdccf004705f16","user":{"login":"pedrovgs","id":4030704,"avatar_url":"https://avatars.githubusercontent.com/u/4030704?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrovgs","html_url":"https://github.com/pedrovgs","followers_url":"https://api.github.com/users/pedrovgs/followers","following_url":"https://api.github.com/users/pedrovgs/following{/other_user}","gists_url":"https://api.github.com/users/pedrovgs/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrovgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrovgs/subscriptions","organizations_url":"https://api.github.com/users/pedrovgs/orgs","repos_url":"https://api.github.com/users/pedrovgs/repos","events_url":"https://api.github.com/users/pedrovgs/events{/privacy}","received_events_url":"https://api.github.com/users/pedrovgs/received_events","type":"User","site_admin":false},"body":"Fixed here and in the other comment I've added :)","created_at":"2016-03-28T11:17:00Z","updated_at":"2016-03-28T11:17:00Z","html_url":"https://github.com/Karumi/Rosie/pull/52#discussion_r57563043","pull_request_url":"https://api.github.com/repos/Karumi/Rosie/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/comments/57563043"},"html":{"href":"https://github.com/Karumi/Rosie/pull/52#discussion_r57563043"},"pull_request":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/Karumi/Rosie/pulls/52","id":64310049,"html_url":"https://github.com/Karumi/Rosie/pull/52","diff_url":"https://github.com/Karumi/Rosie/pull/52.diff","patch_url":"https://github.com/Karumi/Rosie/pull/52.patch","issue_url":"https://api.github.com/repos/Karumi/Rosie/issues/52","number":52,"state":"open","locked":false,"title":"Improve ``PresenterLifeCycleLinker`` public API.","user":{"login":"pedrovgs","id":4030704,"avatar_url":"https://avatars.githubusercontent.com/u/4030704?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrovgs","html_url":"https://github.com/pedrovgs","followers_url":"https://api.github.com/users/pedrovgs/followers","following_url":"https://api.github.com/users/pedrovgs/following{/other_user}","gists_url":"https://api.github.com/users/pedrovgs/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrovgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrovgs/subscriptions","organizations_url":"https://api.github.com/users/pedrovgs/orgs","repos_url":"https://api.github.com/users/pedrovgs/repos","events_url":"https://api.github.com/users/pedrovgs/events{/privacy}","received_events_url":"https://api.github.com/users/pedrovgs/received_events","type":"User","site_admin":false},"body":"Fix #51. Now that we have accepted a pull request (#49) changing the visibility of the class ``PresenterLifeCycleLinker`` from default to public I have decided to improve this class usage. This is the list of improvements you will find in this pull request.\r\n\r\n* Simplify the class usage reducing the number of methods needed to link the component lifecycle with the presenter lifecycle.\r\n* Add javadoc.\r\n* Add some guards related to the input params.\r\n* Improve test coverage.\r\n* Improve the project README to show how to use Rosie without extending from ``RosieActivity`` or ``RosieFragment``.\r\n","created_at":"2016-03-28T10:41:34Z","updated_at":"2016-03-28T11:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5d5504b7b230e9578771727f8ad34e43f74b80f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Karumi/Rosie/pulls/52/commits","review_comments_url":"https://api.github.com/repos/Karumi/Rosie/pulls/52/comments","review_comment_url":"https://api.github.com/repos/Karumi/Rosie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Karumi/Rosie/issues/52/comments","statuses_url":"https://api.github.com/repos/Karumi/Rosie/statuses/d45b365fb5ee3ebb50c0acb470ec04e279f61132","head":{"label":"Karumi:improve-presenter-lifecycle-linker-public-api","ref":"improve-presenter-lifecycle-linker-public-api","sha":"d45b365fb5ee3ebb50c0acb470ec04e279f61132","user":{"login":"Karumi","id":6469715,"avatar_url":"https://avatars.githubusercontent.com/u/6469715?v=3","gravatar_id":"","url":"https://api.github.com/users/Karumi","html_url":"https://github.com/Karumi","followers_url":"https://api.github.com/users/Karumi/followers","following_url":"https://api.github.com/users/Karumi/following{/other_user}","gists_url":"https://api.github.com/users/Karumi/gists{/gist_id}","starred_url":"https://api.github.com/users/Karumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karumi/subscriptions","organizations_url":"https://api.github.com/users/Karumi/orgs","repos_url":"https://api.github.com/users/Karumi/repos","events_url":"https://api.github.com/users/Karumi/events{/privacy}","received_events_url":"https://api.github.com/users/Karumi/received_events","type":"Organization","site_admin":false},"repo":{"id":46555171,"name":"Rosie","full_name":"Karumi/Rosie","owner":{"login":"Karumi","id":6469715,"avatar_url":"https://avatars.githubusercontent.com/u/6469715?v=3","gravatar_id":"","url":"https://api.github.com/users/Karumi","html_url":"https://github.com/Karumi","followers_url":"https://api.github.com/users/Karumi/followers","following_url":"https://api.github.com/users/Karumi/following{/other_user}","gists_url":"https://api.github.com/users/Karumi/gists{/gist_id}","starred_url":"https://api.github.com/users/Karumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karumi/subscriptions","organizations_url":"https://api.github.com/users/Karumi/orgs","repos_url":"https://api.github.com/users/Karumi/repos","events_url":"https://api.github.com/users/Karumi/events{/privacy}","received_events_url":"https://api.github.com/users/Karumi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Karumi/Rosie","description":"Rosie is an Android framework to create applications following the principles of Clean Architecture.","fork":false,"url":"https://api.github.com/repos/Karumi/Rosie","forks_url":"https://api.github.com/repos/Karumi/Rosie/forks","keys_url":"https://api.github.com/repos/Karumi/Rosie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Karumi/Rosie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Karumi/Rosie/teams","hooks_url":"https://api.github.com/repos/Karumi/Rosie/hooks","issue_events_url":"https://api.github.com/repos/Karumi/Rosie/issues/events{/number}","events_url":"https://api.github.com/repos/Karumi/Rosie/events","assignees_url":"https://api.github.com/repos/Karumi/Rosie/assignees{/user}","branches_url":"https://api.github.com/repos/Karumi/Rosie/branches{/branch}","tags_url":"https://api.github.com/repos/Karumi/Rosie/tags","blobs_url":"https://api.github.com/repos/Karumi/Rosie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Karumi/Rosie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Karumi/Rosie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Karumi/Rosie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Karumi/Rosie/statuses/{sha}","languages_url":"https://api.github.com/repos/Karumi/Rosie/languages","stargazers_url":"https://api.github.com/repos/Karumi/Rosie/stargazers","contributors_url":"https://api.github.com/repos/Karumi/Rosie/contributors","subscribers_url":"https://api.github.com/repos/Karumi/Rosie/subscribers","subscription_url":"https://api.github.com/repos/Karumi/Rosie/subscription","commits_url":"https://api.github.com/repos/Karumi/Rosie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Karumi/Rosie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Karumi/Rosie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Karumi/Rosie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Karumi/Rosie/contents/{+path}","compare_url":"https://api.github.com/repos/Karumi/Rosie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Karumi/Rosie/merges","archive_url":"https://api.github.com/repos/Karumi/Rosie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Karumi/Rosie/downloads","issues_url":"https://api.github.com/repos/Karumi/Rosie/issues{/number}","pulls_url":"https://api.github.com/repos/Karumi/Rosie/pulls{/number}","milestones_url":"https://api.github.com/repos/Karumi/Rosie/milestones{/number}","notifications_url":"https://api.github.com/repos/Karumi/Rosie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Karumi/Rosie/labels{/name}","releases_url":"https://api.github.com/repos/Karumi/Rosie/releases{/id}","deployments_url":"https://api.github.com/repos/Karumi/Rosie/deployments","created_at":"2015-11-20T10:22:54Z","updated_at":"2016-03-28T08:57:34Z","pushed_at":"2016-03-28T11:16:40Z","git_url":"git://github.com/Karumi/Rosie.git","ssh_url":"git@github.com:Karumi/Rosie.git","clone_url":"https://github.com/Karumi/Rosie.git","svn_url":"https://github.com/Karumi/Rosie","homepage":"","size":13841,"stargazers_count":1255,"watchers_count":1255,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":17,"forks":74,"open_issues":17,"watchers":1255,"default_branch":"master"}},"base":{"label":"Karumi:master","ref":"master","sha":"0c52c4d12665c8bf621694097002d1818740ef9f","user":{"login":"Karumi","id":6469715,"avatar_url":"https://avatars.githubusercontent.com/u/6469715?v=3","gravatar_id":"","url":"https://api.github.com/users/Karumi","html_url":"https://github.com/Karumi","followers_url":"https://api.github.com/users/Karumi/followers","following_url":"https://api.github.com/users/Karumi/following{/other_user}","gists_url":"https://api.github.com/users/Karumi/gists{/gist_id}","starred_url":"https://api.github.com/users/Karumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karumi/subscriptions","organizations_url":"https://api.github.com/users/Karumi/orgs","repos_url":"https://api.github.com/users/Karumi/repos","events_url":"https://api.github.com/users/Karumi/events{/privacy}","received_events_url":"https://api.github.com/users/Karumi/received_events","type":"Organization","site_admin":false},"repo":{"id":46555171,"name":"Rosie","full_name":"Karumi/Rosie","owner":{"login":"Karumi","id":6469715,"avatar_url":"https://avatars.githubusercontent.com/u/6469715?v=3","gravatar_id":"","url":"https://api.github.com/users/Karumi","html_url":"https://github.com/Karumi","followers_url":"https://api.github.com/users/Karumi/followers","following_url":"https://api.github.com/users/Karumi/following{/other_user}","gists_url":"https://api.github.com/users/Karumi/gists{/gist_id}","starred_url":"https://api.github.com/users/Karumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karumi/subscriptions","organizations_url":"https://api.github.com/users/Karumi/orgs","repos_url":"https://api.github.com/users/Karumi/repos","events_url":"https://api.github.com/users/Karumi/events{/privacy}","received_events_url":"https://api.github.com/users/Karumi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Karumi/Rosie","description":"Rosie is an Android framework to create applications following the principles of Clean Architecture.","fork":false,"url":"https://api.github.com/repos/Karumi/Rosie","forks_url":"https://api.github.com/repos/Karumi/Rosie/forks","keys_url":"https://api.github.com/repos/Karumi/Rosie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Karumi/Rosie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Karumi/Rosie/teams","hooks_url":"https://api.github.com/repos/Karumi/Rosie/hooks","issue_events_url":"https://api.github.com/repos/Karumi/Rosie/issues/events{/number}","events_url":"https://api.github.com/repos/Karumi/Rosie/events","assignees_url":"https://api.github.com/repos/Karumi/Rosie/assignees{/user}","branches_url":"https://api.github.com/repos/Karumi/Rosie/branches{/branch}","tags_url":"https://api.github.com/repos/Karumi/Rosie/tags","blobs_url":"https://api.github.com/repos/Karumi/Rosie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Karumi/Rosie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Karumi/Rosie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Karumi/Rosie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Karumi/Rosie/statuses/{sha}","languages_url":"https://api.github.com/repos/Karumi/Rosie/languages","stargazers_url":"https://api.github.com/repos/Karumi/Rosie/stargazers","contributors_url":"https://api.github.com/repos/Karumi/Rosie/contributors","subscribers_url":"https://api.github.com/repos/Karumi/Rosie/subscribers","subscription_url":"https://api.github.com/repos/Karumi/Rosie/subscription","commits_url":"https://api.github.com/repos/Karumi/Rosie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Karumi/Rosie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Karumi/Rosie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Karumi/Rosie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Karumi/Rosie/contents/{+path}","compare_url":"https://api.github.com/repos/Karumi/Rosie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Karumi/Rosie/merges","archive_url":"https://api.github.com/repos/Karumi/Rosie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Karumi/Rosie/downloads","issues_url":"https://api.github.com/repos/Karumi/Rosie/issues{/number}","pulls_url":"https://api.github.com/repos/Karumi/Rosie/pulls{/number}","milestones_url":"https://api.github.com/repos/Karumi/Rosie/milestones{/number}","notifications_url":"https://api.github.com/repos/Karumi/Rosie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Karumi/Rosie/labels{/name}","releases_url":"https://api.github.com/repos/Karumi/Rosie/releases{/id}","deployments_url":"https://api.github.com/repos/Karumi/Rosie/deployments","created_at":"2015-11-20T10:22:54Z","updated_at":"2016-03-28T08:57:34Z","pushed_at":"2016-03-28T11:16:40Z","git_url":"git://github.com/Karumi/Rosie.git","ssh_url":"git@github.com:Karumi/Rosie.git","clone_url":"https://github.com/Karumi/Rosie.git","svn_url":"https://github.com/Karumi/Rosie","homepage":"","size":13841,"stargazers_count":1255,"watchers_count":1255,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":17,"forks":74,"open_issues":17,"watchers":1255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/52"},"html":{"href":"https://github.com/Karumi/Rosie/pull/52"},"issue":{"href":"https://api.github.com/repos/Karumi/Rosie/issues/52"},"comments":{"href":"https://api.github.com/repos/Karumi/Rosie/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Karumi/Rosie/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/Karumi/Rosie/statuses/d45b365fb5ee3ebb50c0acb470ec04e279f61132"}}}}