{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/22438","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/22438/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/22438/comments","events_url":"https://api.github.com/repos/docker/docker/issues/22438/events","html_url":"https://github.com/docker/docker/pull/22438","id":152060841,"number":22438,"title":"Inconsistent --tmpfs behavior","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-01T00:29:24Z","updated_at":"2016-05-24T02:28:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/22438","html_url":"https://github.com/docker/docker/pull/22438","diff_url":"https://github.com/docker/docker/pull/22438.diff","patch_url":"https://github.com/docker/docker/pull/22438.patch"},"body":"**- What I did**\r\n\r\nThis fix tries to address the issue raised in #22420. When `--tmpfs` is specified with `/tmp`, the default value is `rw,nosuid,nodev,noexec,relatime,size=65536k`. When `--tmpfs` is specified with `/tmp:rw`, then the value changed to `rw,nosuid,nodev,noexec,relatime`.\r\n\r\nThe reason for such an inconsistency is because docker tries to add `size=65536k` option only when user provides no option.\r\n\r\n**- How I did it**\r\n\r\nThis fix tries to address this issue by always pre-probating `size=65536k` along with `rw,nosuid,nodev,noexec,relatime`. If user provides a different value (e.g., `size=8192k`), it will override the `size=65536k` anyway.\r\n\r\n**- How to verify it**\r\n\r\nAdditional test cases have been added to cover the changes in this fix.\r\n\r\n**- Description for the changelog**\r\n\r\nAddress the inconsistent --tmpfs behavior by so that `size=65536k` will always be the default value.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix fixes #22420.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/221150319","html_url":"https://github.com/docker/docker/pull/22438#issuecomment-221150319","issue_url":"https://api.github.com/repos/docker/docker/issues/22438","id":221150319,"user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T02:28:46Z","updated_at":"2016-05-24T02:28:46Z","body":"Thanks for the review @LK4D4. The pull request has been updated to cover the raised issues. Please let me know if there are any other issues."}}
{"actor":{"display_login":"yongtang"}}