{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/htmltools/issues/47","repository_url":"https://api.github.com/repos/rstudio/htmltools","labels_url":"https://api.github.com/repos/rstudio/htmltools/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/htmltools/issues/47/comments","events_url":"https://api.github.com/repos/rstudio/htmltools/issues/47/events","html_url":"https://github.com/rstudio/htmltools/pull/47","id":131551808,"number":47,"title":"Fix handling of brackets in templates","user":{"login":"wch","id":86978,"avatar_url":"https://avatars.githubusercontent.com/u/86978?v=3","gravatar_id":"","url":"https://api.github.com/users/wch","html_url":"https://github.com/wch","followers_url":"https://api.github.com/users/wch/followers","following_url":"https://api.github.com/users/wch/following{/other_user}","gists_url":"https://api.github.com/users/wch/gists{/gist_id}","starred_url":"https://api.github.com/users/wch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wch/subscriptions","organizations_url":"https://api.github.com/users/wch/orgs","repos_url":"https://api.github.com/users/wch/repos","events_url":"https://api.github.com/users/wch/events{/privacy}","received_events_url":"https://api.github.com/users/wch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-05T04:29:21Z","updated_at":"2016-02-10T00:08:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rstudio/htmltools/pulls/47","html_url":"https://github.com/rstudio/htmltools/pull/47","diff_url":"https://github.com/rstudio/htmltools/pull/47.diff","patch_url":"https://github.com/rstudio/htmltools/pull/47.patch"},"body":"This fixes #46. It implements a DFA in C++ for the template handling.\r\n\r\nNote that this introduces an Rcpp dependency, but I think that's not much of a burden because almost everyone will already have Rcpp installed (they will have installed Shiny, which uses httpuv, which uses Rcpp).\r\n\r\nNotes:\r\n* I can squash the commits if that's preferable.\r\n* I'd welcome any feedback on the C++ code."},"comment":{"url":"https://api.github.com/repos/rstudio/htmltools/issues/comments/182141177","html_url":"https://github.com/rstudio/htmltools/pull/47#issuecomment-182141177","issue_url":"https://api.github.com/repos/rstudio/htmltools/issues/47","id":182141177,"user":{"login":"jjallaire","id":104391,"avatar_url":"https://avatars.githubusercontent.com/u/104391?v=3","gravatar_id":"","url":"https://api.github.com/users/jjallaire","html_url":"https://github.com/jjallaire","followers_url":"https://api.github.com/users/jjallaire/followers","following_url":"https://api.github.com/users/jjallaire/following{/other_user}","gists_url":"https://api.github.com/users/jjallaire/gists{/gist_id}","starred_url":"https://api.github.com/users/jjallaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjallaire/subscriptions","organizations_url":"https://api.github.com/users/jjallaire/orgs","repos_url":"https://api.github.com/users/jjallaire/repos","events_url":"https://api.github.com/users/jjallaire/events{/privacy}","received_events_url":"https://api.github.com/users/jjallaire/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T00:08:51Z","updated_at":"2016-02-10T00:08:51Z","body":"There is *one* issue created by the Rcpp dependency here. The automatic installation of htmltools in RStudio (done as part of installing rmarkdown or shiny on demand) specifies type = \"source\". This is because the CRAN Mac build servers have been so far behind (and in many cases remiss in building for some platforms). So if we do this then I think RStudio needs to stop using type = \"source\" for htmltools (unfortunately we can't undo that for binaries still in the field, but I can make the change now to limit the damage)."}}