{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/elematch/issues/5","repository_url":"https://api.github.com/repos/wikimedia/elematch","labels_url":"https://api.github.com/repos/wikimedia/elematch/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/elematch/issues/5/comments","events_url":"https://api.github.com/repos/wikimedia/elematch/issues/5/events","html_url":"https://github.com/wikimedia/elematch/pull/5","id":147640402,"number":5,"title":"Basic attribute matching with CSS selectors","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-12T05:54:20Z","updated_at":"2016-04-28T22:34:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/elematch/pulls/5","html_url":"https://github.com/wikimedia/elematch/pull/5","diff_url":"https://github.com/wikimedia/elematch/pull/5.diff","patch_url":"https://github.com/wikimedia/elematch/pull/5.patch"},"body":"This patch adds basic attribute matching support, using CSS selector syntax:\r\n\r\n```css\r\na[href=\"/some/example\"]\r\n```\r\n\r\nCurrent limitations:\r\n\r\n- Element names need to be fixed, no matches for attributes only.\r\n- Only exact matches (`=`).\r\n- Only a single attribute selector.\r\n\r\nAll of these limitations can be lifted in principle.\r\n\r\nPerformance is very promising, with plain match performance slightly improving\r\nover the previous code, and targeted matches for specific attribute values (a\r\nspecific link) on a 1.5mb HTML document ([[Barack Obama]]) taking 2.1ms."},"comment":{"url":"https://api.github.com/repos/wikimedia/elematch/issues/comments/215583143","html_url":"https://github.com/wikimedia/elematch/pull/5#issuecomment-215583143","issue_url":"https://api.github.com/repos/wikimedia/elematch/issues/5","id":215583143,"user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T22:34:29Z","updated_at":"2016-04-28T22:34:29Z","body":"@Pchelolo, should we go ahead & merge? We can always improve things in the next PR."}}