{"action":"created","comment":{"url":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments/57024346","id":57024346,"diff_hunk":"@@ -19,10 +19,19 @@ add_definitions(-D_CRT_SECURE_NO_WARNINGS)\n #-------------------------------------------------------------------------------------------\n # Compiler Flags\n #-------------------------------------------------------------------------------------------\n-set(CMAKE_CXX_STANDARD 11)\n-if(UNIX)\n-    SET(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11\")\n+if( UNIX AND \"${CMAKE_CXX_COMPILER_ID}\" STREQUAL \"Intel\" )\n+  set( CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11 -fasm-blocks\" )\n endif()\n+\n+if (CMAKE_CXX_COMPILER_ID MATCHES \"Clang\")\n+\tSET(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11\")\n+endif()\n+\n+if (CMAKE_CXX_COMPILER_ID MATCHES \"Clang\" OR CMAKE_CXX_COMPILER_ID MATCHES \"GNU\")\n+\tset(CMAKE_CXX_FLAGS_DEBUG \"${CMAKE_CXX_FLAGS_DEBUG} -D_DEBUG\")","path":"test/packages/EATest/CMakeLists.txt","position":16,"original_position":16,"commit_id":"b6abb6efb3217645dee172b52d753f5df7e0c52b","original_commit_id":"b6abb6efb3217645dee172b52d753f5df7e0c52b","user":{"login":"rparolin","id":1320845,"avatar_url":"https://avatars.githubusercontent.com/u/1320845?v=3","gravatar_id":"","url":"https://api.github.com/users/rparolin","html_url":"https://github.com/rparolin","followers_url":"https://api.github.com/users/rparolin/followers","following_url":"https://api.github.com/users/rparolin/following{/other_user}","gists_url":"https://api.github.com/users/rparolin/gists{/gist_id}","starred_url":"https://api.github.com/users/rparolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rparolin/subscriptions","organizations_url":"https://api.github.com/users/rparolin/orgs","repos_url":"https://api.github.com/users/rparolin/repos","events_url":"https://api.github.com/users/rparolin/events{/privacy}","received_events_url":"https://api.github.com/users/rparolin/received_events","type":"User","site_admin":false},"body":"Ah, didn't realize that was limited to only debug builds.","created_at":"2016-03-22T16:55:57Z","updated_at":"2016-03-22T16:55:57Z","html_url":"https://github.com/electronicarts/EASTL/pull/37#discussion_r57024346","pull_request_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments/57024346"},"html":{"href":"https://github.com/electronicarts/EASTL/pull/37#discussion_r57024346"},"pull_request":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/electronicarts/EASTL/pulls/37","id":63631446,"html_url":"https://github.com/electronicarts/EASTL/pull/37","diff_url":"https://github.com/electronicarts/EASTL/pull/37.diff","patch_url":"https://github.com/electronicarts/EASTL/pull/37.patch","issue_url":"https://api.github.com/repos/electronicarts/EASTL/issues/37","number":37,"state":"open","locked":false,"title":"Support gcc and clang (MingW/LLVM's VS wrapper)","user":{"login":"DragoonX6","id":1615215,"avatar_url":"https://avatars.githubusercontent.com/u/1615215?v=3","gravatar_id":"","url":"https://api.github.com/users/DragoonX6","html_url":"https://github.com/DragoonX6","followers_url":"https://api.github.com/users/DragoonX6/followers","following_url":"https://api.github.com/users/DragoonX6/following{/other_user}","gists_url":"https://api.github.com/users/DragoonX6/gists{/gist_id}","starred_url":"https://api.github.com/users/DragoonX6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DragoonX6/subscriptions","organizations_url":"https://api.github.com/users/DragoonX6/orgs","repos_url":"https://api.github.com/users/DragoonX6/repos","events_url":"https://api.github.com/users/DragoonX6/events{/privacy}","received_events_url":"https://api.github.com/users/DragoonX6/received_events","type":"User","site_admin":false},"body":"Now builds with GCC and Clang on windows.\r\nTested platforms and compilers:\r\n* Windows\r\n    * MSYS2 GCC 5.3.0\r\n    * TDM-GCC 5.1.0\r\n    * MSYS2 Clang 3.8.0\r\n* Arch Linux\r\n    * GCC 5.3.0\r\n    * Clang 3.7.1\r\n\r\nI tested MSVC before in my VM, but I haven't run my latest changes on it. I suspect it to work, though.","created_at":"2016-03-21T21:00:02Z","updated_at":"2016-03-22T16:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08fac95a4b0ea934f0529e37d7a3bb7471c2ef2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/37/commits","review_comments_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/37/comments","review_comment_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electronicarts/EASTL/issues/37/comments","statuses_url":"https://api.github.com/repos/electronicarts/EASTL/statuses/b6abb6efb3217645dee172b52d753f5df7e0c52b","head":{"label":"DragoonX6:master","ref":"master","sha":"b6abb6efb3217645dee172b52d753f5df7e0c52b","user":{"login":"DragoonX6","id":1615215,"avatar_url":"https://avatars.githubusercontent.com/u/1615215?v=3","gravatar_id":"","url":"https://api.github.com/users/DragoonX6","html_url":"https://github.com/DragoonX6","followers_url":"https://api.github.com/users/DragoonX6/followers","following_url":"https://api.github.com/users/DragoonX6/following{/other_user}","gists_url":"https://api.github.com/users/DragoonX6/gists{/gist_id}","starred_url":"https://api.github.com/users/DragoonX6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DragoonX6/subscriptions","organizations_url":"https://api.github.com/users/DragoonX6/orgs","repos_url":"https://api.github.com/users/DragoonX6/repos","events_url":"https://api.github.com/users/DragoonX6/events{/privacy}","received_events_url":"https://api.github.com/users/DragoonX6/received_events","type":"User","site_admin":false},"repo":{"id":52690063,"name":"EASTL","full_name":"DragoonX6/EASTL","owner":{"login":"DragoonX6","id":1615215,"avatar_url":"https://avatars.githubusercontent.com/u/1615215?v=3","gravatar_id":"","url":"https://api.github.com/users/DragoonX6","html_url":"https://github.com/DragoonX6","followers_url":"https://api.github.com/users/DragoonX6/followers","following_url":"https://api.github.com/users/DragoonX6/following{/other_user}","gists_url":"https://api.github.com/users/DragoonX6/gists{/gist_id}","starred_url":"https://api.github.com/users/DragoonX6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DragoonX6/subscriptions","organizations_url":"https://api.github.com/users/DragoonX6/orgs","repos_url":"https://api.github.com/users/DragoonX6/repos","events_url":"https://api.github.com/users/DragoonX6/events{/privacy}","received_events_url":"https://api.github.com/users/DragoonX6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DragoonX6/EASTL","description":"EASTL stands for Electronic Arts Standard Template Library.  It is an extensive and robust implementation that has an emphasis on high performance.","fork":true,"url":"https://api.github.com/repos/DragoonX6/EASTL","forks_url":"https://api.github.com/repos/DragoonX6/EASTL/forks","keys_url":"https://api.github.com/repos/DragoonX6/EASTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DragoonX6/EASTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DragoonX6/EASTL/teams","hooks_url":"https://api.github.com/repos/DragoonX6/EASTL/hooks","issue_events_url":"https://api.github.com/repos/DragoonX6/EASTL/issues/events{/number}","events_url":"https://api.github.com/repos/DragoonX6/EASTL/events","assignees_url":"https://api.github.com/repos/DragoonX6/EASTL/assignees{/user}","branches_url":"https://api.github.com/repos/DragoonX6/EASTL/branches{/branch}","tags_url":"https://api.github.com/repos/DragoonX6/EASTL/tags","blobs_url":"https://api.github.com/repos/DragoonX6/EASTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DragoonX6/EASTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DragoonX6/EASTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/DragoonX6/EASTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DragoonX6/EASTL/statuses/{sha}","languages_url":"https://api.github.com/repos/DragoonX6/EASTL/languages","stargazers_url":"https://api.github.com/repos/DragoonX6/EASTL/stargazers","contributors_url":"https://api.github.com/repos/DragoonX6/EASTL/contributors","subscribers_url":"https://api.github.com/repos/DragoonX6/EASTL/subscribers","subscription_url":"https://api.github.com/repos/DragoonX6/EASTL/subscription","commits_url":"https://api.github.com/repos/DragoonX6/EASTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/DragoonX6/EASTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/DragoonX6/EASTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/DragoonX6/EASTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/DragoonX6/EASTL/contents/{+path}","compare_url":"https://api.github.com/repos/DragoonX6/EASTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DragoonX6/EASTL/merges","archive_url":"https://api.github.com/repos/DragoonX6/EASTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DragoonX6/EASTL/downloads","issues_url":"https://api.github.com/repos/DragoonX6/EASTL/issues{/number}","pulls_url":"https://api.github.com/repos/DragoonX6/EASTL/pulls{/number}","milestones_url":"https://api.github.com/repos/DragoonX6/EASTL/milestones{/number}","notifications_url":"https://api.github.com/repos/DragoonX6/EASTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DragoonX6/EASTL/labels{/name}","releases_url":"https://api.github.com/repos/DragoonX6/EASTL/releases{/id}","deployments_url":"https://api.github.com/repos/DragoonX6/EASTL/deployments","created_at":"2016-02-27T21:38:59Z","updated_at":"2016-02-27T21:39:01Z","pushed_at":"2016-03-21T20:49:25Z","git_url":"git://github.com/DragoonX6/EASTL.git","ssh_url":"git@github.com:DragoonX6/EASTL.git","clone_url":"https://github.com/DragoonX6/EASTL.git","svn_url":"https://github.com/DragoonX6/EASTL","homepage":"","size":1245,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electronicarts:master","ref":"master","sha":"2c516098f217ff3695aa23764600e3014a6ff864","user":{"login":"electronicarts","id":1637638,"avatar_url":"https://avatars.githubusercontent.com/u/1637638?v=3","gravatar_id":"","url":"https://api.github.com/users/electronicarts","html_url":"https://github.com/electronicarts","followers_url":"https://api.github.com/users/electronicarts/followers","following_url":"https://api.github.com/users/electronicarts/following{/other_user}","gists_url":"https://api.github.com/users/electronicarts/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicarts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicarts/subscriptions","organizations_url":"https://api.github.com/users/electronicarts/orgs","repos_url":"https://api.github.com/users/electronicarts/repos","events_url":"https://api.github.com/users/electronicarts/events{/privacy}","received_events_url":"https://api.github.com/users/electronicarts/received_events","type":"Organization","site_admin":false},"repo":{"id":48068902,"name":"EASTL","full_name":"electronicarts/EASTL","owner":{"login":"electronicarts","id":1637638,"avatar_url":"https://avatars.githubusercontent.com/u/1637638?v=3","gravatar_id":"","url":"https://api.github.com/users/electronicarts","html_url":"https://github.com/electronicarts","followers_url":"https://api.github.com/users/electronicarts/followers","following_url":"https://api.github.com/users/electronicarts/following{/other_user}","gists_url":"https://api.github.com/users/electronicarts/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicarts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicarts/subscriptions","organizations_url":"https://api.github.com/users/electronicarts/orgs","repos_url":"https://api.github.com/users/electronicarts/repos","events_url":"https://api.github.com/users/electronicarts/events{/privacy}","received_events_url":"https://api.github.com/users/electronicarts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electronicarts/EASTL","description":"EASTL stands for Electronic Arts Standard Template Library.  It is an extensive and robust implementation that has an emphasis on high performance.","fork":false,"url":"https://api.github.com/repos/electronicarts/EASTL","forks_url":"https://api.github.com/repos/electronicarts/EASTL/forks","keys_url":"https://api.github.com/repos/electronicarts/EASTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electronicarts/EASTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electronicarts/EASTL/teams","hooks_url":"https://api.github.com/repos/electronicarts/EASTL/hooks","issue_events_url":"https://api.github.com/repos/electronicarts/EASTL/issues/events{/number}","events_url":"https://api.github.com/repos/electronicarts/EASTL/events","assignees_url":"https://api.github.com/repos/electronicarts/EASTL/assignees{/user}","branches_url":"https://api.github.com/repos/electronicarts/EASTL/branches{/branch}","tags_url":"https://api.github.com/repos/electronicarts/EASTL/tags","blobs_url":"https://api.github.com/repos/electronicarts/EASTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electronicarts/EASTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electronicarts/EASTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/electronicarts/EASTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electronicarts/EASTL/statuses/{sha}","languages_url":"https://api.github.com/repos/electronicarts/EASTL/languages","stargazers_url":"https://api.github.com/repos/electronicarts/EASTL/stargazers","contributors_url":"https://api.github.com/repos/electronicarts/EASTL/contributors","subscribers_url":"https://api.github.com/repos/electronicarts/EASTL/subscribers","subscription_url":"https://api.github.com/repos/electronicarts/EASTL/subscription","commits_url":"https://api.github.com/repos/electronicarts/EASTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/electronicarts/EASTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/electronicarts/EASTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/electronicarts/EASTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/electronicarts/EASTL/contents/{+path}","compare_url":"https://api.github.com/repos/electronicarts/EASTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electronicarts/EASTL/merges","archive_url":"https://api.github.com/repos/electronicarts/EASTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electronicarts/EASTL/downloads","issues_url":"https://api.github.com/repos/electronicarts/EASTL/issues{/number}","pulls_url":"https://api.github.com/repos/electronicarts/EASTL/pulls{/number}","milestones_url":"https://api.github.com/repos/electronicarts/EASTL/milestones{/number}","notifications_url":"https://api.github.com/repos/electronicarts/EASTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electronicarts/EASTL/labels{/name}","releases_url":"https://api.github.com/repos/electronicarts/EASTL/releases{/id}","deployments_url":"https://api.github.com/repos/electronicarts/EASTL/deployments","created_at":"2015-12-15T21:04:13Z","updated_at":"2016-03-21T08:32:17Z","pushed_at":"2016-03-21T21:00:02Z","git_url":"git://github.com/electronicarts/EASTL.git","ssh_url":"git@github.com:electronicarts/EASTL.git","clone_url":"https://github.com/electronicarts/EASTL.git","svn_url":"https://github.com/electronicarts/EASTL","homepage":"","size":1349,"stargazers_count":1903,"watchers_count":1903,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":4,"forks":135,"open_issues":4,"watchers":1903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/37"},"html":{"href":"https://github.com/electronicarts/EASTL/pull/37"},"issue":{"href":"https://api.github.com/repos/electronicarts/EASTL/issues/37"},"comments":{"href":"https://api.github.com/repos/electronicarts/EASTL/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/electronicarts/EASTL/statuses/b6abb6efb3217645dee172b52d753f5df7e0c52b"}}}}