{"action":"created","comment":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/54292029","id":54292029,"diff_hunk":"@@ -42,12 +42,12 @@ class FlxGamepadAnalogStick\n \t\tif (settings == null)\n \t\t\treturn;\n \n-\t\tmode = (settings.mode != null) ? settings.mode : ONLY_ANALOG;\n+\t\tmode = (settings.mode != null) ? settings.mode : BOTH;\n \t\trawUp = (settings.up != null) ? settings.up : -1;\n \t\trawDown = (settings.down != null) ? settings.down : -1;\n \t\trawLeft = (settings.left != null) ? settings.left : -1;\n \t\trawRight = (settings.right != null) ? settings.right : -1;\n-\t\tdigitalThreshold = (settings.threshold != null) ? settings.threshold : -1;\n+\t\tdigitalThreshold = (settings.threshold != null) ? settings.threshold : 0.5;","path":"flixel/input/gamepad/FlxGamepadAnalogStick.hx","position":20,"original_position":20,"commit_id":"3ded9b2fc17108e870ef39b7cc748c880a680d67","original_commit_id":"4d1dd74ad672e1043029a6333f709f888576187b","user":{"login":"larsiusprime","id":739064,"avatar_url":"https://avatars.githubusercontent.com/u/739064?v=3","gravatar_id":"","url":"https://api.github.com/users/larsiusprime","html_url":"https://github.com/larsiusprime","followers_url":"https://api.github.com/users/larsiusprime/followers","following_url":"https://api.github.com/users/larsiusprime/following{/other_user}","gists_url":"https://api.github.com/users/larsiusprime/gists{/gist_id}","starred_url":"https://api.github.com/users/larsiusprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsiusprime/subscriptions","organizations_url":"https://api.github.com/users/larsiusprime/orgs","repos_url":"https://api.github.com/users/larsiusprime/repos","events_url":"https://api.github.com/users/larsiusprime/events{/privacy}","received_events_url":"https://api.github.com/users/larsiusprime/received_events","type":"User","site_admin":false},"body":"To clarify in this situation: since the default setting everywhere was to only report Analog, I'm pretty sure nobody was actually accessing this behavior. Accessing analog-to-digital virtual stick directions was buried in the API, essentially undocumented, and only worked on legacy. This PR is basically the first time the feature's actually been exposed to daylight in any practical sense.","created_at":"2016-02-26T19:46:12Z","updated_at":"2016-02-26T19:46:12Z","html_url":"https://github.com/HaxeFlixel/flixel/pull/1746#discussion_r54292029","pull_request_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746","_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/54292029"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1746#discussion_r54292029"},"pull_request":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746"}}},"pull_request":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746","id":60877649,"html_url":"https://github.com/HaxeFlixel/flixel/pull/1746","diff_url":"https://github.com/HaxeFlixel/flixel/pull/1746.diff","patch_url":"https://github.com/HaxeFlixel/flixel/pull/1746.patch","issue_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1746","number":1746,"state":"open","locked":false,"title":"Make analog sticks emit \"fake\" digital actions for left/right/up/down…","user":{"login":"larsiusprime","id":739064,"avatar_url":"https://avatars.githubusercontent.com/u/739064?v=3","gravatar_id":"","url":"https://api.github.com/users/larsiusprime","html_url":"https://github.com/larsiusprime","followers_url":"https://api.github.com/users/larsiusprime/followers","following_url":"https://api.github.com/users/larsiusprime/following{/other_user}","gists_url":"https://api.github.com/users/larsiusprime/gists{/gist_id}","starred_url":"https://api.github.com/users/larsiusprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsiusprime/subscriptions","organizations_url":"https://api.github.com/users/larsiusprime/orgs","repos_url":"https://api.github.com/users/larsiusprime/repos","events_url":"https://api.github.com/users/larsiusprime/events{/privacy}","received_events_url":"https://api.github.com/users/larsiusprime/received_events","type":"User","site_admin":false},"body":"… movement, and add ID's that make it simple to use them. Makes it easy to use an Analog stick as if it were a DPAD, a very popular input pattern.\r\n\r\nThis behavior was already implemented on legacy, but the API for it was buried. I added top level FlxGamepadInputID's for the digital events, and refactored things so that Next can emit these events as well.\r\nAlso, I added a \"value\" property to the FlxGamepadButton for storing last frame's analog input value, which should remove the requirement for FlxActions to call check() every frame in order to get accurate JUST_MOVED / JUST_STOPPED behavior.\r\n\r\n(This pull request helps the FlxAction PR, but can be considered in isolation and does not depend on it)","created_at":"2016-02-26T17:46:23Z","updated_at":"2016-02-26T19:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eba6cfec1f43eb097cef7f8af1e58af86276fcd","assignee":null,"milestone":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones/8","html_url":"https://github.com/HaxeFlixel/flixel/milestones/4.1.0","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones/8/labels","id":1556723,"number":8,"title":"4.1.0","description":"","creator":{"login":"Gama11","id":2620907,"avatar_url":"https://avatars.githubusercontent.com/u/2620907?v=3","gravatar_id":"","url":"https://api.github.com/users/Gama11","html_url":"https://github.com/Gama11","followers_url":"https://api.github.com/users/Gama11/followers","following_url":"https://api.github.com/users/Gama11/following{/other_user}","gists_url":"https://api.github.com/users/Gama11/gists{/gist_id}","starred_url":"https://api.github.com/users/Gama11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gama11/subscriptions","organizations_url":"https://api.github.com/users/Gama11/orgs","repos_url":"https://api.github.com/users/Gama11/repos","events_url":"https://api.github.com/users/Gama11/events{/privacy}","received_events_url":"https://api.github.com/users/Gama11/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2016-02-01T20:44:15Z","updated_at":"2016-02-26T19:26:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746/commits","review_comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746/comments","review_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1746/comments","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/3ded9b2fc17108e870ef39b7cc748c880a680d67","head":{"label":"larsiusprime:gamepad_analog_dpad","ref":"gamepad_analog_dpad","sha":"3ded9b2fc17108e870ef39b7cc748c880a680d67","user":{"login":"larsiusprime","id":739064,"avatar_url":"https://avatars.githubusercontent.com/u/739064?v=3","gravatar_id":"","url":"https://api.github.com/users/larsiusprime","html_url":"https://github.com/larsiusprime","followers_url":"https://api.github.com/users/larsiusprime/followers","following_url":"https://api.github.com/users/larsiusprime/following{/other_user}","gists_url":"https://api.github.com/users/larsiusprime/gists{/gist_id}","starred_url":"https://api.github.com/users/larsiusprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsiusprime/subscriptions","organizations_url":"https://api.github.com/users/larsiusprime/orgs","repos_url":"https://api.github.com/users/larsiusprime/repos","events_url":"https://api.github.com/users/larsiusprime/events{/privacy}","received_events_url":"https://api.github.com/users/larsiusprime/received_events","type":"User","site_admin":false},"repo":{"id":33733461,"name":"haxeflixel","full_name":"larsiusprime/haxeflixel","owner":{"login":"larsiusprime","id":739064,"avatar_url":"https://avatars.githubusercontent.com/u/739064?v=3","gravatar_id":"","url":"https://api.github.com/users/larsiusprime","html_url":"https://github.com/larsiusprime","followers_url":"https://api.github.com/users/larsiusprime/followers","following_url":"https://api.github.com/users/larsiusprime/following{/other_user}","gists_url":"https://api.github.com/users/larsiusprime/gists{/gist_id}","starred_url":"https://api.github.com/users/larsiusprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsiusprime/subscriptions","organizations_url":"https://api.github.com/users/larsiusprime/orgs","repos_url":"https://api.github.com/users/larsiusprime/repos","events_url":"https://api.github.com/users/larsiusprime/events{/privacy}","received_events_url":"https://api.github.com/users/larsiusprime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsiusprime/haxeflixel","description":"Free, cross-platform 2D game engine powered by Haxe and OpenFL","fork":true,"url":"https://api.github.com/repos/larsiusprime/haxeflixel","forks_url":"https://api.github.com/repos/larsiusprime/haxeflixel/forks","keys_url":"https://api.github.com/repos/larsiusprime/haxeflixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsiusprime/haxeflixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsiusprime/haxeflixel/teams","hooks_url":"https://api.github.com/repos/larsiusprime/haxeflixel/hooks","issue_events_url":"https://api.github.com/repos/larsiusprime/haxeflixel/issues/events{/number}","events_url":"https://api.github.com/repos/larsiusprime/haxeflixel/events","assignees_url":"https://api.github.com/repos/larsiusprime/haxeflixel/assignees{/user}","branches_url":"https://api.github.com/repos/larsiusprime/haxeflixel/branches{/branch}","tags_url":"https://api.github.com/repos/larsiusprime/haxeflixel/tags","blobs_url":"https://api.github.com/repos/larsiusprime/haxeflixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsiusprime/haxeflixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsiusprime/haxeflixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsiusprime/haxeflixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsiusprime/haxeflixel/statuses/{sha}","languages_url":"https://api.github.com/repos/larsiusprime/haxeflixel/languages","stargazers_url":"https://api.github.com/repos/larsiusprime/haxeflixel/stargazers","contributors_url":"https://api.github.com/repos/larsiusprime/haxeflixel/contributors","subscribers_url":"https://api.github.com/repos/larsiusprime/haxeflixel/subscribers","subscription_url":"https://api.github.com/repos/larsiusprime/haxeflixel/subscription","commits_url":"https://api.github.com/repos/larsiusprime/haxeflixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsiusprime/haxeflixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsiusprime/haxeflixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsiusprime/haxeflixel/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsiusprime/haxeflixel/contents/{+path}","compare_url":"https://api.github.com/repos/larsiusprime/haxeflixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsiusprime/haxeflixel/merges","archive_url":"https://api.github.com/repos/larsiusprime/haxeflixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsiusprime/haxeflixel/downloads","issues_url":"https://api.github.com/repos/larsiusprime/haxeflixel/issues{/number}","pulls_url":"https://api.github.com/repos/larsiusprime/haxeflixel/pulls{/number}","milestones_url":"https://api.github.com/repos/larsiusprime/haxeflixel/milestones{/number}","notifications_url":"https://api.github.com/repos/larsiusprime/haxeflixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsiusprime/haxeflixel/labels{/name}","releases_url":"https://api.github.com/repos/larsiusprime/haxeflixel/releases{/id}","deployments_url":"https://api.github.com/repos/larsiusprime/haxeflixel/deployments","created_at":"2015-04-10T14:41:26Z","updated_at":"2016-02-18T18:44:48Z","pushed_at":"2016-02-26T19:41:16Z","git_url":"git://github.com/larsiusprime/haxeflixel.git","ssh_url":"git@github.com:larsiusprime/haxeflixel.git","clone_url":"https://github.com/larsiusprime/haxeflixel.git","svn_url":"https://github.com/larsiusprime/haxeflixel","homepage":"http://www.haxeflixel.com/","size":18593,"stargazers_count":0,"watchers_count":0,"language":"Haxe","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"HaxeFlixel:dev","ref":"dev","sha":"0541162886171cded4cf6c0c8f83d985b3af660a","user":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?v=3","gravatar_id":"","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"repo":{"id":2101031,"name":"flixel","full_name":"HaxeFlixel/flixel","owner":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?v=3","gravatar_id":"","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HaxeFlixel/flixel","description":"Free, cross-platform 2D game engine powered by Haxe and OpenFL","fork":false,"url":"https://api.github.com/repos/HaxeFlixel/flixel","forks_url":"https://api.github.com/repos/HaxeFlixel/flixel/forks","keys_url":"https://api.github.com/repos/HaxeFlixel/flixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaxeFlixel/flixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaxeFlixel/flixel/teams","hooks_url":"https://api.github.com/repos/HaxeFlixel/flixel/hooks","issue_events_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/events{/number}","events_url":"https://api.github.com/repos/HaxeFlixel/flixel/events","assignees_url":"https://api.github.com/repos/HaxeFlixel/flixel/assignees{/user}","branches_url":"https://api.github.com/repos/HaxeFlixel/flixel/branches{/branch}","tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/tags","blobs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/{sha}","languages_url":"https://api.github.com/repos/HaxeFlixel/flixel/languages","stargazers_url":"https://api.github.com/repos/HaxeFlixel/flixel/stargazers","contributors_url":"https://api.github.com/repos/HaxeFlixel/flixel/contributors","subscribers_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscribers","subscription_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscription","commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/comments{/number}","contents_url":"https://api.github.com/repos/HaxeFlixel/flixel/contents/{+path}","compare_url":"https://api.github.com/repos/HaxeFlixel/flixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaxeFlixel/flixel/merges","archive_url":"https://api.github.com/repos/HaxeFlixel/flixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaxeFlixel/flixel/downloads","issues_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues{/number}","pulls_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls{/number}","milestones_url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones{/number}","notifications_url":"https://api.github.com/repos/HaxeFlixel/flixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/labels{/name}","releases_url":"https://api.github.com/repos/HaxeFlixel/flixel/releases{/id}","deployments_url":"https://api.github.com/repos/HaxeFlixel/flixel/deployments","created_at":"2011-07-25T13:12:48Z","updated_at":"2016-02-25T18:32:00Z","pushed_at":"2016-02-26T19:41:17Z","git_url":"git://github.com/HaxeFlixel/flixel.git","ssh_url":"git@github.com:HaxeFlixel/flixel.git","clone_url":"https://github.com/HaxeFlixel/flixel.git","svn_url":"https://github.com/HaxeFlixel/flixel","homepage":"http://www.haxeflixel.com/","size":31310,"stargazers_count":823,"watchers_count":823,"language":"Haxe","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":86,"forks":205,"open_issues":86,"watchers":823,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1746"},"issue":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1746"},"comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1746/comments"},"review_comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746/comments"},"review_comment":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1746/commits"},"statuses":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/3ded9b2fc17108e870ef39b7cc748c880a680d67"}}}}