{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/76490266","id":76490266,"diff_hunk":"@@ -190,14 +199,25 @@ function doubleClickWithGlade(global, data, gladeExperiment) {\n   slot.setAttribute('data-page-url', global.context.canonicalUrl);\n \n   // Size setup.\n-  // The ad container should simply fill the amp-ad iframe, but we still\n-  // need to request a specific size from the ad server.\n-  // The ad container size will be relative to the amp-iframe, so if the\n-  // latter changes the ad container will match it.\n-  slot.setAttribute('width', 'fill');\n-  slot.setAttribute('height', 'fill');\n-  slot.setAttribute('data-request-height', requestHeight);\n-  slot.setAttribute('data-request-width', requestWidth);\n+  if (global.context.layout == 'responsive') {\n+    // If the slot is responsive, we can have a different size ad come back\n+    // than the container size, so explicitly set height and width, then center\n+    // in the container.\n+    slot.setAttribute('height', requestHeight);\n+    slot.setAttribute('width', requestWidth);\n+    slot.style.top = '50%';\n+    slot.style.left = '50%';\n+    slot.style.margin = requestHeight/-2 + 'px 0 0 ' + requestWidth/-2 + 'px';","path":"ads/google/doubleclick.js","position":36,"original_position":36,"commit_id":"de8e57c264564f88b152db1289af9d49757b6a29","original_commit_id":"de8e57c264564f88b152db1289af9d49757b6a29","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"ditto.","created_at":"2016-08-26T21:23:19Z","updated_at":"2016-08-26T21:23:19Z","html_url":"https://github.com/ampproject/amphtml/pull/4735#discussion_r76490266","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4735","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/76490266"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4735#discussion_r76490266"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4735"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4735","id":82955152,"html_url":"https://github.com/ampproject/amphtml/pull/4735","diff_url":"https://github.com/ampproject/amphtml/pull/4735.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4735.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4735","number":4735,"state":"open","locked":false,"title":"Fix for bug #4693","user":{"login":"mlb7687","id":11046373,"avatar_url":"https://avatars.githubusercontent.com/u/11046373?v=3","gravatar_id":"","url":"https://api.github.com/users/mlb7687","html_url":"https://github.com/mlb7687","followers_url":"https://api.github.com/users/mlb7687/followers","following_url":"https://api.github.com/users/mlb7687/following{/other_user}","gists_url":"https://api.github.com/users/mlb7687/gists{/gist_id}","starred_url":"https://api.github.com/users/mlb7687/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlb7687/subscriptions","organizations_url":"https://api.github.com/users/mlb7687/orgs","repos_url":"https://api.github.com/users/mlb7687/repos","events_url":"https://api.github.com/users/mlb7687/events{/privacy}","received_events_url":"https://api.github.com/users/mlb7687/received_events","type":"User","site_admin":false},"body":"This adds the layout to window.context so that we can use it in cross domain ad iframe.\r\nWe will need this ability to support multi-size ads and pad as well.\r\nFor DoubleClick, if we see a responsive ad, pad and size things appropriately.\r\n\r\nFixes #4693.","created_at":"2016-08-26T21:13:56Z","updated_at":"2016-08-26T21:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aaa6e2e5528e2b310c80cfde1fa444cfa7e669e","assignee":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"assignees":[{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4735/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4735/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4735/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/de8e57c264564f88b152db1289af9d49757b6a29","head":{"label":"mlb7687:master","ref":"master","sha":"de8e57c264564f88b152db1289af9d49757b6a29","user":{"login":"mlb7687","id":11046373,"avatar_url":"https://avatars.githubusercontent.com/u/11046373?v=3","gravatar_id":"","url":"https://api.github.com/users/mlb7687","html_url":"https://github.com/mlb7687","followers_url":"https://api.github.com/users/mlb7687/followers","following_url":"https://api.github.com/users/mlb7687/following{/other_user}","gists_url":"https://api.github.com/users/mlb7687/gists{/gist_id}","starred_url":"https://api.github.com/users/mlb7687/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlb7687/subscriptions","organizations_url":"https://api.github.com/users/mlb7687/orgs","repos_url":"https://api.github.com/users/mlb7687/repos","events_url":"https://api.github.com/users/mlb7687/events{/privacy}","received_events_url":"https://api.github.com/users/mlb7687/received_events","type":"User","site_admin":false},"repo":{"id":49509700,"name":"amphtml","full_name":"mlb7687/amphtml","owner":{"login":"mlb7687","id":11046373,"avatar_url":"https://avatars.githubusercontent.com/u/11046373?v=3","gravatar_id":"","url":"https://api.github.com/users/mlb7687","html_url":"https://github.com/mlb7687","followers_url":"https://api.github.com/users/mlb7687/followers","following_url":"https://api.github.com/users/mlb7687/following{/other_user}","gists_url":"https://api.github.com/users/mlb7687/gists{/gist_id}","starred_url":"https://api.github.com/users/mlb7687/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlb7687/subscriptions","organizations_url":"https://api.github.com/users/mlb7687/orgs","repos_url":"https://api.github.com/users/mlb7687/repos","events_url":"https://api.github.com/users/mlb7687/events{/privacy}","received_events_url":"https://api.github.com/users/mlb7687/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlb7687/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/mlb7687/amphtml","forks_url":"https://api.github.com/repos/mlb7687/amphtml/forks","keys_url":"https://api.github.com/repos/mlb7687/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlb7687/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlb7687/amphtml/teams","hooks_url":"https://api.github.com/repos/mlb7687/amphtml/hooks","issue_events_url":"https://api.github.com/repos/mlb7687/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/mlb7687/amphtml/events","assignees_url":"https://api.github.com/repos/mlb7687/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/mlb7687/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/mlb7687/amphtml/tags","blobs_url":"https://api.github.com/repos/mlb7687/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlb7687/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlb7687/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlb7687/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlb7687/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/mlb7687/amphtml/languages","stargazers_url":"https://api.github.com/repos/mlb7687/amphtml/stargazers","contributors_url":"https://api.github.com/repos/mlb7687/amphtml/contributors","subscribers_url":"https://api.github.com/repos/mlb7687/amphtml/subscribers","subscription_url":"https://api.github.com/repos/mlb7687/amphtml/subscription","commits_url":"https://api.github.com/repos/mlb7687/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlb7687/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlb7687/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlb7687/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlb7687/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/mlb7687/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlb7687/amphtml/merges","archive_url":"https://api.github.com/repos/mlb7687/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlb7687/amphtml/downloads","issues_url":"https://api.github.com/repos/mlb7687/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/mlb7687/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/mlb7687/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/mlb7687/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlb7687/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/mlb7687/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/mlb7687/amphtml/deployments","created_at":"2016-01-12T15:37:45Z","updated_at":"2016-01-12T15:37:47Z","pushed_at":"2016-08-26T21:11:35Z","git_url":"git://github.com/mlb7687/amphtml.git","ssh_url":"git@github.com:mlb7687/amphtml.git","clone_url":"https://github.com/mlb7687/amphtml.git","svn_url":"https://github.com/mlb7687/amphtml","homepage":"https://ampproject.org","size":149432,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"f9b85878ba902eedb095f26ececcaacdfef21372","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-08-26T18:52:24Z","pushed_at":"2016-08-26T21:13:56Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":187762,"stargazers_count":8305,"watchers_count":8305,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1199,"mirror_url":null,"open_issues_count":700,"forks":1199,"open_issues":700,"watchers":8305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4735"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4735"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4735"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4735/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4735/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4735/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/de8e57c264564f88b152db1289af9d49757b6a29"}}}}
{"actor":{"display_login":"jridgewell"}}