{"action":"closed","number":836,"pull_request":{"url":"https://api.github.com/repos/pyne/pyne/pulls/836","id":65694017,"html_url":"https://github.com/pyne/pyne/pull/836","diff_url":"https://github.com/pyne/pyne/pull/836.diff","patch_url":"https://github.com/pyne/pyne/pull/836.patch","issue_url":"https://api.github.com/repos/pyne/pyne/issues/836","number":836,"state":"closed","locked":false,"title":"fix isnan compiler errors for newer clang,gcc","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"body":"Newer compiler versions (at least clang 3.7.1, gcc 5.3) change their stdlib\r\nshenanigans a bit causing compiler errors like this:\r\n\r\n```\r\n    /home/r/src/cyclus/cyclus/src/pyne.cc:7975:8: error: use of undeclared identifier 'isnan'\r\n      if (!isnan(k_conv)) {\r\n```\r\n\r\nSo isnan calls need to be explicitly std:: prefixed - so the pre-existing\r\nmacro for apple+win systems was just scoped to include all systems (linux\r\ntoo).","created_at":"2016-04-07T20:27:40Z","updated_at":"2016-04-07T20:53:43Z","closed_at":"2016-04-07T20:53:43Z","merged_at":"2016-04-07T20:53:43Z","merge_commit_sha":"b2b091246934344a10ee05d322a1718988020b81","assignee":null,"milestone":{"url":"https://api.github.com/repos/pyne/pyne/milestones/9","html_url":"https://github.com/pyne/pyne/milestones/v0.6","labels_url":"https://api.github.com/repos/pyne/pyne/milestones/9/labels","id":868437,"number":9,"title":"v0.6","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":72,"state":"open","created_at":"2014-11-16T20:05:29Z","updated_at":"2016-04-07T20:53:43Z","due_on":"2015-04-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pyne/pyne/pulls/836/commits","review_comments_url":"https://api.github.com/repos/pyne/pyne/pulls/836/comments","review_comment_url":"https://api.github.com/repos/pyne/pyne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyne/pyne/issues/836/comments","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/74144d170d83d3f603a00452325de107dfc5d368","head":{"label":"rwcarlsen:fix-isnan","ref":"fix-isnan","sha":"74144d170d83d3f603a00452325de107dfc5d368","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"repo":{"id":17424452,"name":"pyne","full_name":"rwcarlsen/pyne","owner":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwcarlsen/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":true,"url":"https://api.github.com/repos/rwcarlsen/pyne","forks_url":"https://api.github.com/repos/rwcarlsen/pyne/forks","keys_url":"https://api.github.com/repos/rwcarlsen/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwcarlsen/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwcarlsen/pyne/teams","hooks_url":"https://api.github.com/repos/rwcarlsen/pyne/hooks","issue_events_url":"https://api.github.com/repos/rwcarlsen/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/rwcarlsen/pyne/events","assignees_url":"https://api.github.com/repos/rwcarlsen/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/rwcarlsen/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/rwcarlsen/pyne/tags","blobs_url":"https://api.github.com/repos/rwcarlsen/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwcarlsen/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwcarlsen/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwcarlsen/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwcarlsen/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/rwcarlsen/pyne/languages","stargazers_url":"https://api.github.com/repos/rwcarlsen/pyne/stargazers","contributors_url":"https://api.github.com/repos/rwcarlsen/pyne/contributors","subscribers_url":"https://api.github.com/repos/rwcarlsen/pyne/subscribers","subscription_url":"https://api.github.com/repos/rwcarlsen/pyne/subscription","commits_url":"https://api.github.com/repos/rwcarlsen/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwcarlsen/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwcarlsen/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwcarlsen/pyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwcarlsen/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/rwcarlsen/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwcarlsen/pyne/merges","archive_url":"https://api.github.com/repos/rwcarlsen/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwcarlsen/pyne/downloads","issues_url":"https://api.github.com/repos/rwcarlsen/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/rwcarlsen/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/rwcarlsen/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/rwcarlsen/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwcarlsen/pyne/labels{/name}","releases_url":"https://api.github.com/repos/rwcarlsen/pyne/releases{/id}","deployments_url":"https://api.github.com/repos/rwcarlsen/pyne/deployments","created_at":"2014-03-05T01:53:14Z","updated_at":"2014-04-25T16:06:46Z","pushed_at":"2016-04-07T20:27:12Z","git_url":"git://github.com/rwcarlsen/pyne.git","ssh_url":"git@github.com:rwcarlsen/pyne.git","clone_url":"https://github.com/rwcarlsen/pyne.git","svn_url":"https://github.com/rwcarlsen/pyne","homepage":"http://pyne.io/","size":19608,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"pyne:develop","ref":"develop","sha":"b2651d8224cbd11d8e8f580aa1d04cb4e23b14de","user":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"repo":{"id":1684953,"name":"pyne","full_name":"pyne/pyne","owner":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyne/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":false,"url":"https://api.github.com/repos/pyne/pyne","forks_url":"https://api.github.com/repos/pyne/pyne/forks","keys_url":"https://api.github.com/repos/pyne/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyne/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyne/pyne/teams","hooks_url":"https://api.github.com/repos/pyne/pyne/hooks","issue_events_url":"https://api.github.com/repos/pyne/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/pyne/pyne/events","assignees_url":"https://api.github.com/repos/pyne/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/pyne/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/pyne/pyne/tags","blobs_url":"https://api.github.com/repos/pyne/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyne/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyne/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyne/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/pyne/pyne/languages","stargazers_url":"https://api.github.com/repos/pyne/pyne/stargazers","contributors_url":"https://api.github.com/repos/pyne/pyne/contributors","subscribers_url":"https://api.github.com/repos/pyne/pyne/subscribers","subscription_url":"https://api.github.com/repos/pyne/pyne/subscription","commits_url":"https://api.github.com/repos/pyne/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyne/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyne/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyne/pyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyne/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/pyne/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyne/pyne/merges","archive_url":"https://api.github.com/repos/pyne/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyne/pyne/downloads","issues_url":"https://api.github.com/repos/pyne/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/pyne/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/pyne/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/pyne/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyne/pyne/labels{/name}","releases_url":"https://api.github.com/repos/pyne/pyne/releases{/id}","deployments_url":"https://api.github.com/repos/pyne/pyne/deployments","created_at":"2011-04-30T15:04:07Z","updated_at":"2016-03-24T09:57:37Z","pushed_at":"2016-04-07T20:53:44Z","git_url":"git://github.com/pyne/pyne.git","ssh_url":"git@github.com:pyne/pyne.git","clone_url":"https://github.com/pyne/pyne.git","svn_url":"https://github.com/pyne/pyne","homepage":"http://pyne.io/","size":87084,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":74,"forks":82,"open_issues":74,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/836"},"html":{"href":"https://github.com/pyne/pyne/pull/836"},"issue":{"href":"https://api.github.com/repos/pyne/pyne/issues/836"},"comments":{"href":"https://api.github.com/repos/pyne/pyne/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/pyne/pyne/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyne/pyne/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/pyne/pyne/statuses/74144d170d83d3f603a00452325de107dfc5d368"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":0,"deletions":2,"changed_files":1}}