{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/holidayextras/brands/pulls/41","id":64776272,"html_url":"https://github.com/holidayextras/brands/pull/41","diff_url":"https://github.com/holidayextras/brands/pull/41.diff","patch_url":"https://github.com/holidayextras/brands/pull/41.patch","issue_url":"https://api.github.com/repos/holidayextras/brands/issues/41","number":41,"state":"closed","locked":false,"title":"Asset deployment","user":{"login":"elliottcrush","id":6357978,"avatar_url":"https://avatars.githubusercontent.com/u/6357978?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottcrush","html_url":"https://github.com/elliottcrush","followers_url":"https://api.github.com/users/elliottcrush/followers","following_url":"https://api.github.com/users/elliottcrush/following{/other_user}","gists_url":"https://api.github.com/users/elliottcrush/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottcrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottcrush/subscriptions","organizations_url":"https://api.github.com/users/elliottcrush/orgs","repos_url":"https://api.github.com/users/elliottcrush/repos","events_url":"https://api.github.com/users/elliottcrush/events{/privacy}","received_events_url":"https://api.github.com/users/elliottcrush/received_events","type":"User","site_admin":false},"body":"#### What does this PR do? (please provide any background)\r\nEnables us to deploy assets, e.g. fonts and images alongside the brand styling. Added notes to the readme for further explanation but essentially when you make a change to the brand, it will deploy the recently added files to the S3 bucket as soon as your branch is merged to master.\r\n\r\n#### What tests does this PR have?\r\nNone\r\n\r\n#### How can this be tested?\r\nGrab the branch, add an asset as per readme and then run gulp in the root of the project. You should see a `dist` directory in the root with your newly added assets.\r\n\r\n#### Screenshots / Screencast\r\n<img width=\"468\" alt=\"screen shot 2016-03-31 at 12 42 58\" src=\"https://cloud.githubusercontent.com/assets/6357978/14174715/2266ab18-f73e-11e5-8b64-5c614a815951.png\">\r\n\r\n\r\n#### What gif best describes how you feel about this work?\r\n![](https://media2.giphy.com/media/detDESm0bahoc/giphy.gif)\r\n\r\n---\r\n\r\n- [x] I have checked our general [contributing document](https://github.com/holidayextras/culture/blob/master/CONTRIBUTING.md) and the project specific [contributing document](../blob/master/CONTRIBUTING.md) (if present) and I'm happy for this to be reviewed.\r\n\r\n#### Reviewers\r\n\r\n**Review 1**\r\n- [x] :+1:\r\n\r\n**Review 2** \\*\r\n- [x] :+1:\r\n\r\n**Review 3** _(optional)_\r\n- [ ] :+1:\r\n\r\nBy adding a +1 you are confirming you have...\r\n- Witnessed the work behaving as expected (this could be on the author's machine or screencast).\r\n- Checked for coding anti-patterns.\r\n- Checked for appropriate test coverage.\r\n- Checked all the tests are passing.\r\n\r\n\\*  for HX this review must be completed by an SE, SA or Project Guru","created_at":"2016-03-31T11:43:21Z","updated_at":"2016-03-31T16:32:24Z","closed_at":"2016-03-31T16:32:24Z","merged_at":"2016-03-31T16:32:24Z","merge_commit_sha":"f29be9c41cbe7576e7331041e3c7e57d052d8281","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/brands/pulls/41/commits","review_comments_url":"https://api.github.com/repos/holidayextras/brands/pulls/41/comments","review_comment_url":"https://api.github.com/repos/holidayextras/brands/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/brands/issues/41/comments","statuses_url":"https://api.github.com/repos/holidayextras/brands/statuses/4a857b9e4a69fa33e5c42342c46bc4009e9a8b2c","head":{"label":"holidayextras:asset-deployment","ref":"asset-deployment","sha":"4a857b9e4a69fa33e5c42342c46bc4009e9a8b2c","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":50192305,"name":"brands","full_name":"holidayextras/brands","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/brands","description":"A collection of HX brands","fork":false,"url":"https://api.github.com/repos/holidayextras/brands","forks_url":"https://api.github.com/repos/holidayextras/brands/forks","keys_url":"https://api.github.com/repos/holidayextras/brands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/brands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/brands/teams","hooks_url":"https://api.github.com/repos/holidayextras/brands/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/brands/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/brands/events","assignees_url":"https://api.github.com/repos/holidayextras/brands/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/brands/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/brands/tags","blobs_url":"https://api.github.com/repos/holidayextras/brands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/brands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/brands/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/brands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/brands/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/brands/languages","stargazers_url":"https://api.github.com/repos/holidayextras/brands/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/brands/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/brands/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/brands/subscription","commits_url":"https://api.github.com/repos/holidayextras/brands/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/brands/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/brands/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/brands/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/brands/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/brands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/brands/merges","archive_url":"https://api.github.com/repos/holidayextras/brands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/brands/downloads","issues_url":"https://api.github.com/repos/holidayextras/brands/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/brands/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/brands/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/brands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/brands/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/brands/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/brands/deployments","created_at":"2016-01-22T16:16:44Z","updated_at":"2016-01-26T11:50:09Z","pushed_at":"2016-03-31T16:32:24Z","git_url":"git://github.com/holidayextras/brands.git","ssh_url":"git@github.com:holidayextras/brands.git","clone_url":"https://github.com/holidayextras/brands.git","svn_url":"https://github.com/holidayextras/brands","homepage":null,"size":326,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"cfcca6608aa780fcbbe80577c97635d6257fbc94","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":50192305,"name":"brands","full_name":"holidayextras/brands","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/brands","description":"A collection of HX brands","fork":false,"url":"https://api.github.com/repos/holidayextras/brands","forks_url":"https://api.github.com/repos/holidayextras/brands/forks","keys_url":"https://api.github.com/repos/holidayextras/brands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/brands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/brands/teams","hooks_url":"https://api.github.com/repos/holidayextras/brands/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/brands/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/brands/events","assignees_url":"https://api.github.com/repos/holidayextras/brands/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/brands/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/brands/tags","blobs_url":"https://api.github.com/repos/holidayextras/brands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/brands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/brands/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/brands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/brands/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/brands/languages","stargazers_url":"https://api.github.com/repos/holidayextras/brands/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/brands/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/brands/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/brands/subscription","commits_url":"https://api.github.com/repos/holidayextras/brands/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/brands/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/brands/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/brands/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/brands/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/brands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/brands/merges","archive_url":"https://api.github.com/repos/holidayextras/brands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/brands/downloads","issues_url":"https://api.github.com/repos/holidayextras/brands/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/brands/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/brands/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/brands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/brands/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/brands/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/brands/deployments","created_at":"2016-01-22T16:16:44Z","updated_at":"2016-01-26T11:50:09Z","pushed_at":"2016-03-31T16:32:24Z","git_url":"git://github.com/holidayextras/brands.git","ssh_url":"git@github.com:holidayextras/brands.git","clone_url":"https://github.com/holidayextras/brands.git","svn_url":"https://github.com/holidayextras/brands","homepage":null,"size":326,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/brands/pulls/41"},"html":{"href":"https://github.com/holidayextras/brands/pull/41"},"issue":{"href":"https://api.github.com/repos/holidayextras/brands/issues/41"},"comments":{"href":"https://api.github.com/repos/holidayextras/brands/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/brands/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/brands/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/brands/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/brands/statuses/4a857b9e4a69fa33e5c42342c46bc4009e9a8b2c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"elliottcrush","id":6357978,"avatar_url":"https://avatars.githubusercontent.com/u/6357978?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottcrush","html_url":"https://github.com/elliottcrush","followers_url":"https://api.github.com/users/elliottcrush/followers","following_url":"https://api.github.com/users/elliottcrush/following{/other_user}","gists_url":"https://api.github.com/users/elliottcrush/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottcrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottcrush/subscriptions","organizations_url":"https://api.github.com/users/elliottcrush/orgs","repos_url":"https://api.github.com/users/elliottcrush/repos","events_url":"https://api.github.com/users/elliottcrush/events{/privacy}","received_events_url":"https://api.github.com/users/elliottcrush/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":7,"additions":27,"deletions":7,"changed_files":4}}