{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/brave/issues/260","repository_url":"https://api.github.com/repos/openzipkin/brave","labels_url":"https://api.github.com/repos/openzipkin/brave/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/brave/issues/260/comments","events_url":"https://api.github.com/repos/openzipkin/brave/issues/260/events","html_url":"https://github.com/openzipkin/brave/issues/260","id":186069904,"number":260,"title":"Support for lazy evaluation of expensive binary annotations","user":{"login":"AlejandroRivera","id":52290,"avatar_url":"https://avatars.githubusercontent.com/u/52290?v=3","gravatar_id":"","url":"https://api.github.com/users/AlejandroRivera","html_url":"https://github.com/AlejandroRivera","followers_url":"https://api.github.com/users/AlejandroRivera/followers","following_url":"https://api.github.com/users/AlejandroRivera/following{/other_user}","gists_url":"https://api.github.com/users/AlejandroRivera/gists{/gist_id}","starred_url":"https://api.github.com/users/AlejandroRivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlejandroRivera/subscriptions","organizations_url":"https://api.github.com/users/AlejandroRivera/orgs","repos_url":"https://api.github.com/users/AlejandroRivera/repos","events_url":"https://api.github.com/users/AlejandroRivera/events{/privacy}","received_events_url":"https://api.github.com/users/AlejandroRivera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-29T09:49:37Z","updated_at":"2016-11-17T09:11:34Z","closed_at":null,"body":"It'd be nice if there was a way to add binary annotations to spans in such a way that the annotation value is only computed if the trace is being sampled.\n\nFor example:\n\n```\nlocalTracer.submitBinaryAnnotation(\"foo\", computeExpensiveValue());\n```\n\nwould become:\n\n```\nlocalTracer.submitBinaryAnnotation(\"foo\", () -> computeExpensiveValue());\n```\n\nWithout this feature support, we're forced to do:\n\n```\nif (Boolean.TRUE.equals(tracer.serverSpanThreadBinder().getCurrentServerSpan().getSample())) {\n   localTracer.submitBinaryAnnotation(\"foo\", computeExpensiveValue());\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/openzipkin/brave/issues/comments/261193614","html_url":"https://github.com/openzipkin/brave/issues/260#issuecomment-261193614","issue_url":"https://api.github.com/repos/openzipkin/brave/issues/260","id":261193614,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T09:11:34Z","updated_at":"2016-11-17T09:11:34Z","body":"one I hear about often is address resolution, but also interested in the\nmotivation!\n"}}
{"actor":{"display_login":"adriancole"}}