{"action":"created","comment":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments/56940016","id":56940016,"diff_hunk":"@@ -59,7 +59,7 @@ number.prototype.addFilterToQuery = function (filter, query) {\n \t\tif (!isNaN(min) && !isNaN(max)) {\n \t\t\tquery[this.path] = filter.inverted ? { $gte: max, $lte: min } : { $gte: min, $lte: max };\n \t\t}\n-\t\treturn;\n+\t\treturn query;","path":"fields/types/number/NumberType.js","position":14,"original_position":14,"commit_id":"bea2c7a73d88df4be10e8ac8aa6788185c76e66c","original_commit_id":"bea2c7a73d88df4be10e8ac8aa6788185c76e66c","user":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"body":"Same question as above for the text field.","created_at":"2016-03-22T05:51:21Z","updated_at":"2016-03-22T05:51:21Z","html_url":"https://github.com/keystonejs/keystone/pull/2480#discussion_r56940016","pull_request_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2480","_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments/56940016"},"html":{"href":"https://github.com/keystonejs/keystone/pull/2480#discussion_r56940016"},"pull_request":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2480"}}},"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/2480","id":63663055,"html_url":"https://github.com/keystonejs/keystone/pull/2480","diff_url":"https://github.com/keystonejs/keystone/pull/2480.diff","patch_url":"https://github.com/keystonejs/keystone/pull/2480.patch","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/2480","number":2480,"state":"open","locked":false,"title":"addFilterToQuery tests","user":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"body":"~~**WIP, do not merge yet**~~\r\n\r\nAdding tests for all existing `addFilterToQuery` methods, ref #1776.\r\n\r\n- [x] boolean\r\n- [x] code\r\n- [x] color\r\n- [x] date \r\n- [x] email\r\n- [x] html\r\n- [x] key\r\n- [x] number\r\n- [x] location\r\n- [x] password\r\n- [x] relationship\r\n- [x] select\r\n- [x] text\r\n- [x] textarea\r\n- [x] url","created_at":"2016-03-22T02:52:24Z","updated_at":"2016-03-22T05:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b20e67a65dd8a2ab9e71e392e81100526b1582a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2480/commits","review_comments_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2480/comments","review_comment_url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/2480/comments","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/bea2c7a73d88df4be10e8ac8aa6788185c76e66c","head":{"label":"keystonejs:filter-tests","ref":"filter-tests","sha":"bea2c7a73d88df4be10e8ac8aa6788185c76e66c","user":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"node.js cms and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/keystonejs/keystone/deployments","created_at":"2013-07-02T05:01:55Z","updated_at":"2016-03-22T05:21:46Z","pushed_at":"2016-03-22T05:50:22Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":80098,"stargazers_count":5843,"watchers_count":5843,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":976,"mirror_url":null,"open_issues_count":552,"forks":976,"open_issues":552,"watchers":5843,"default_branch":"master"}},"base":{"label":"keystonejs:master","ref":"master","sha":"c93db471d262e61295e637676d28dc32b4493040","user":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"node.js cms and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/keystonejs/keystone/deployments","created_at":"2013-07-02T05:01:55Z","updated_at":"2016-03-22T05:21:46Z","pushed_at":"2016-03-22T05:50:22Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":80098,"stargazers_count":5843,"watchers_count":5843,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":976,"mirror_url":null,"open_issues_count":552,"forks":976,"open_issues":552,"watchers":5843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2480"},"html":{"href":"https://github.com/keystonejs/keystone/pull/2480"},"issue":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2480"},"comments":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2480/comments"},"review_comments":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2480/comments"},"review_comment":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2480/commits"},"statuses":{"href":"https://api.github.com/repos/keystonejs/keystone/statuses/bea2c7a73d88df4be10e8ac8aa6788185c76e66c"}}}}