{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/66318844","id":66318844,"diff_hunk":"@@ -126,15 +126,15 @@ def merge_broadcastables(broadcastables):\n     return [all(bcast) for bcast in zip(*broadcastables)]\n \n \n-def scalarconsts_rest(inputs):\n+def scalarconsts_rest(inputs, elemwise=True, only_process_constants=False):\n     \"\"\"Partition a list of variables into two kinds:\n     scalar constants, and the rest.\"\"\"\n     consts = []\n     origconsts = []\n     nonconsts = []\n     for i in inputs:\n         try:\n-            v = get_scalar_constant_value(i)\n+            v = get_scalar_constant_value(i, only_process_constants=only_process_constants)","path":"theano/tensor/opt.py","position":14,"original_position":14,"commit_id":"e22c6ad631a8f581b4ab405c56090b05b35565c3","original_commit_id":"e22c6ad631a8f581b4ab405c56090b05b35565c3","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"don't forget to pass elemwise here.","created_at":"2016-06-08T19:03:57Z","updated_at":"2016-06-08T19:03:57Z","html_url":"https://github.com/Theano/Theano/pull/4128#discussion_r66318844","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4128","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/66318844"},"html":{"href":"https://github.com/Theano/Theano/pull/4128#discussion_r66318844"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4128"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4128","id":60794127,"html_url":"https://github.com/Theano/Theano/pull/4128","diff_url":"https://github.com/Theano/Theano/pull/4128.diff","patch_url":"https://github.com/Theano/Theano/pull/4128.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4128","number":4128,"state":"open","locked":false,"title":"[ENH] faster opt by changing call to extract_constant and get_scalar_constant_value","user":{"login":"caglar","id":233292,"avatar_url":"https://avatars.githubusercontent.com/u/233292?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar","html_url":"https://github.com/caglar","followers_url":"https://api.github.com/users/caglar/followers","following_url":"https://api.github.com/users/caglar/following{/other_user}","gists_url":"https://api.github.com/users/caglar/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar/subscriptions","organizations_url":"https://api.github.com/users/caglar/orgs","repos_url":"https://api.github.com/users/caglar/repos","events_url":"https://api.github.com/users/caglar/events{/privacy}","received_events_url":"https://api.github.com/users/caglar/received_events","type":"User","site_admin":false},"body":"Started adding the only_process_constants=True argument to all extract_constant() and get_scalar_constant_value() calls.\r\n\r\nfix gh-4004","created_at":"2016-02-26T05:16:20Z","updated_at":"2016-06-08T19:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4747342fb950cdf549344f9de89a16874aec438","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4128/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4128/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4128/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/e22c6ad631a8f581b4ab405c56090b05b35565c3","head":{"label":"caglar:fix_extract_constant","ref":"fix_extract_constant","sha":"e22c6ad631a8f581b4ab405c56090b05b35565c3","user":{"login":"caglar","id":233292,"avatar_url":"https://avatars.githubusercontent.com/u/233292?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar","html_url":"https://github.com/caglar","followers_url":"https://api.github.com/users/caglar/followers","following_url":"https://api.github.com/users/caglar/following{/other_user}","gists_url":"https://api.github.com/users/caglar/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar/subscriptions","organizations_url":"https://api.github.com/users/caglar/orgs","repos_url":"https://api.github.com/users/caglar/repos","events_url":"https://api.github.com/users/caglar/events{/privacy}","received_events_url":"https://api.github.com/users/caglar/received_events","type":"User","site_admin":false},"repo":{"id":4730184,"name":"Theano","full_name":"caglar/Theano","owner":{"login":"caglar","id":233292,"avatar_url":"https://avatars.githubusercontent.com/u/233292?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar","html_url":"https://github.com/caglar","followers_url":"https://api.github.com/users/caglar/followers","following_url":"https://api.github.com/users/caglar/following{/other_user}","gists_url":"https://api.github.com/users/caglar/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar/subscriptions","organizations_url":"https://api.github.com/users/caglar/orgs","repos_url":"https://api.github.com/users/caglar/repos","events_url":"https://api.github.com/users/caglar/events{/privacy}","received_events_url":"https://api.github.com/users/caglar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caglar/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/caglar/Theano","forks_url":"https://api.github.com/repos/caglar/Theano/forks","keys_url":"https://api.github.com/repos/caglar/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caglar/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caglar/Theano/teams","hooks_url":"https://api.github.com/repos/caglar/Theano/hooks","issue_events_url":"https://api.github.com/repos/caglar/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/caglar/Theano/events","assignees_url":"https://api.github.com/repos/caglar/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/caglar/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/caglar/Theano/tags","blobs_url":"https://api.github.com/repos/caglar/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caglar/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caglar/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/caglar/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caglar/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/caglar/Theano/languages","stargazers_url":"https://api.github.com/repos/caglar/Theano/stargazers","contributors_url":"https://api.github.com/repos/caglar/Theano/contributors","subscribers_url":"https://api.github.com/repos/caglar/Theano/subscribers","subscription_url":"https://api.github.com/repos/caglar/Theano/subscription","commits_url":"https://api.github.com/repos/caglar/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/caglar/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/caglar/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/caglar/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/caglar/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/caglar/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caglar/Theano/merges","archive_url":"https://api.github.com/repos/caglar/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caglar/Theano/downloads","issues_url":"https://api.github.com/repos/caglar/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/caglar/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/caglar/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/caglar/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caglar/Theano/labels{/name}","releases_url":"https://api.github.com/repos/caglar/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/caglar/Theano/deployments","created_at":"2012-06-20T19:08:16Z","updated_at":"2016-02-12T00:27:49Z","pushed_at":"2016-06-08T19:01:45Z","git_url":"git://github.com/caglar/Theano.git","ssh_url":"git@github.com:caglar/Theano.git","clone_url":"https://github.com/caglar/Theano.git","svn_url":"https://github.com/caglar/Theano","homepage":"http://www.deeplearning.net/software/theano","size":53051,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"6f97e51d9f94da8486d40578e3f7469e2ff3bfd9","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-06-08T14:30:29Z","pushed_at":"2016-06-08T19:01:45Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":73487,"stargazers_count":3902,"watchers_count":3902,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1417,"mirror_url":null,"open_issues_count":683,"forks":1417,"open_issues":683,"watchers":3902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4128"},"html":{"href":"https://github.com/Theano/Theano/pull/4128"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4128"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4128/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4128/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4128/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/e22c6ad631a8f581b4ab405c56090b05b35565c3"}}}}
{"actor":{"display_login":"nouiz"}}