{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/comments/69726237","id":69726237,"diff_hunk":"@@ -14,7 +18,15 @@ slightly less control (but a simpler life) you can let the client\n libraries create channels themselves as necessary, and shut them\n down explicitly using the static `ShutDownDefaultChannelsAsync`\n method which each client class exposes. (For example,\n-`PublisherClient.ShutDownDefaultChannelsAsync()` and\n-`SubscriberClient.ShutDownDefaultChannelsAsync()`.)\n+[PublisherClient.ShutDownDefaultChannelsAsync()](../obj/api/Google.Pubsub.V1.PublisherClient.yml#Google_Pubsub_V1_PublisherClient_ShutDownDefaultChannelsAsync) and\n+[SubscriberClient.ShutDownDefaultChannelsAsync()](../obj/api/Google.Pubsub.V1.SubscriberClient.yml#Google_Pubsub_V1_SubscriberClient_ShutDownDefaultChannelsAsync).)\n+\n+Finally, gRPC provides an environment-wide shutdown method of `GrpcEnvironment.ShutdownChannelsAsync()`.\n+\n+In all of these cases, it's entirely feasible to create more channels (implicitly or explicitly)\n+after shutting others down... it will just require a new network connection to be opened.\n \n-TODO(jonskeet): More details.\n+If you do not shut down the channels explicitly, they will be closed automatically\n+when either the application domain is unloaded, or the process exits. For most applications, this is\n+perfectly adequate; explicit shutdown is only required when your application needs to ensure that all","path":"docs/articles/cleanup.md","position":29,"original_position":29,"commit_id":"d2e7a12a0b0dc476ad6093331ae543516280b480","original_commit_id":"d2e7a12a0b0dc476ad6093331ae543516280b480","user":{"login":"chrisdunelm","id":316748,"avatar_url":"https://avatars.githubusercontent.com/u/316748?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false},"body":"Extra 'all' at end of this line (I think)","created_at":"2016-07-06T13:09:31Z","updated_at":"2016-07-06T13:09:32Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257#discussion_r69726237","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/comments/69726237"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257#discussion_r69726237"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257","id":76427486,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/257","number":257,"state":"open","locked":false,"title":"First pass at clean-up documentation","user":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-06T12:56:34Z","updated_at":"2016-07-06T13:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92449166a97f85739db640a102b382d4c92b452","assignee":{"login":"chrisdunelm","id":316748,"avatar_url":"https://avatars.githubusercontent.com/u/316748?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisdunelm","id":316748,"avatar_url":"https://avatars.githubusercontent.com/u/316748?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/257/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/statuses/d2e7a12a0b0dc476ad6093331ae543516280b480","head":{"label":"jskeet:cleanup","ref":"cleanup","sha":"d2e7a12a0b0dc476ad6093331ae543516280b480","user":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"repo":{"id":35881054,"name":"gcloud-dotnet","full_name":"jskeet/gcloud-dotnet","owner":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jskeet/gcloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/jskeet/gcloud-dotnet","forks_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/forks","keys_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/teams","hooks_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/events","assignees_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/tags","blobs_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/subscription","commits_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/merges","archive_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/downloads","issues_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/jskeet/gcloud-dotnet/deployments","created_at":"2015-05-19T12:36:32Z","updated_at":"2016-01-18T16:09:51Z","pushed_at":"2016-07-06T13:05:48Z","git_url":"git://github.com/jskeet/gcloud-dotnet.git","ssh_url":"git@github.com:jskeet/gcloud-dotnet.git","clone_url":"https://github.com/jskeet/gcloud-dotnet.git","svn_url":"https://github.com/jskeet/gcloud-dotnet","homepage":null,"size":3632,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"64e847ec22cc4b4ec11061a0d5359a5dcf357321","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"gcloud-dotnet","full_name":"GoogleCloudPlatform/gcloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet","description":"Google Cloud Client Library for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2016-07-05T19:00:31Z","pushed_at":"2016-07-06T13:05:48Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-dotnet.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-dotnet","homepage":null,"size":4659,"stargazers_count":25,"watchers_count":25,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":26,"forks":13,"open_issues":26,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-dotnet/pull/257"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/257"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-dotnet/statuses/d2e7a12a0b0dc476ad6093331ae543516280b480"}}}}
{"actor":{"display_login":"chrisdunelm"}}