{"action":"opened","number":7340,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7340","id":86599390,"html_url":"https://github.com/dotnet/coreclr/pull/7340","diff_url":"https://github.com/dotnet/coreclr/pull/7340.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7340.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7340","number":7340,"state":"open","locked":false,"title":"Add code to switch to BitVec data structure in CSE optimization.","user":{"login":"russellhadley","id":9874904,"avatar_url":"https://avatars.githubusercontent.com/u/9874904?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhadley","html_url":"https://github.com/russellhadley","followers_url":"https://api.github.com/users/russellhadley/followers","following_url":"https://api.github.com/users/russellhadley/following{/other_user}","gists_url":"https://api.github.com/users/russellhadley/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhadley/subscriptions","organizations_url":"https://api.github.com/users/russellhadley/orgs","repos_url":"https://api.github.com/users/russellhadley/repos","events_url":"https://api.github.com/users/russellhadley/events{/privacy}","received_events_url":"https://api.github.com/users/russellhadley/received_events","type":"User","site_admin":false},"body":"This change will allow us to track more than 64 CSE candidates.\r\nInitially the data structure is set to the same limits (64) as is\r\ncurrently used.  This gives us a no diffs.  Subsequent changes\r\nwill change these limits based on opportunities found in the benchmarks.\r\n\r\nThis change follows the same conventions that were used to move\r\nassertion prop to use the BitVec type.\r\n\r\nCode Diffs:\r\nNone - diffs were run using jit-diff on Ubuntu16.04 and Windows.  Additionally System.Private.CoreLib was dumped in a verbose mode that dumped the internal state of the bit vectors used in CSE.  The new data structure is bit for bit identical with the old data structure.\r\n\r\nThroughput:\r\nTiming of crossgen were taken on a number of assemblies.  The results were within the usual noise.\r\n |**Baseline**| |**Experiment**| |**Ex/Base**\r\n:-----:|:-----:|:-----:|:-----:|:-----:|:-----:\r\nBenchmark|Time(avg)|Score|Time(avg)|Score|Time\r\nmscorlib-amd64|15539|0.4605|15509|0.4614|0.998069374\r\nSystem.Data.Entity|12026|0.595|11991.2|0.5968|0.99710627\r\nSystem.Windows.Forms|11564.4|0.6188|11646.6|0.6144|1.007108021\r\nSystem.Design|7283.4|0.9825|7409.6|0.9658|1.017327073\r\nSystem.Web-amd64|11453.6|0.6248|11621.8|0.6157|1.014685339\r\nSystem.ServiceModel|18343.2|0.3901|18797.6|0.3807|1.024772123\r\nGeomean|12205.89907|0.586261092|12325.44745|0.58058544|1.009794312\r\n\r\n\r\n","created_at":"2016-09-24T00:12:11Z","updated_at":"2016-09-24T00:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7340/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7340/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7340/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/932f93e01ec1834628fc6b9ad68dfbcfaa08bf8e","head":{"label":"russellhadley:MoveCSEtoBitVec","ref":"MoveCSEtoBitVec","sha":"932f93e01ec1834628fc6b9ad68dfbcfaa08bf8e","user":{"login":"russellhadley","id":9874904,"avatar_url":"https://avatars.githubusercontent.com/u/9874904?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhadley","html_url":"https://github.com/russellhadley","followers_url":"https://api.github.com/users/russellhadley/followers","following_url":"https://api.github.com/users/russellhadley/following{/other_user}","gists_url":"https://api.github.com/users/russellhadley/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhadley/subscriptions","organizations_url":"https://api.github.com/users/russellhadley/orgs","repos_url":"https://api.github.com/users/russellhadley/repos","events_url":"https://api.github.com/users/russellhadley/events{/privacy}","received_events_url":"https://api.github.com/users/russellhadley/received_events","type":"User","site_admin":false},"repo":{"id":30832571,"name":"coreclr","full_name":"russellhadley/coreclr","owner":{"login":"russellhadley","id":9874904,"avatar_url":"https://avatars.githubusercontent.com/u/9874904?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhadley","html_url":"https://github.com/russellhadley","followers_url":"https://api.github.com/users/russellhadley/followers","following_url":"https://api.github.com/users/russellhadley/following{/other_user}","gists_url":"https://api.github.com/users/russellhadley/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhadley/subscriptions","organizations_url":"https://api.github.com/users/russellhadley/orgs","repos_url":"https://api.github.com/users/russellhadley/repos","events_url":"https://api.github.com/users/russellhadley/events{/privacy}","received_events_url":"https://api.github.com/users/russellhadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhadley/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/russellhadley/coreclr","forks_url":"https://api.github.com/repos/russellhadley/coreclr/forks","keys_url":"https://api.github.com/repos/russellhadley/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhadley/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhadley/coreclr/teams","hooks_url":"https://api.github.com/repos/russellhadley/coreclr/hooks","issue_events_url":"https://api.github.com/repos/russellhadley/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/russellhadley/coreclr/events","assignees_url":"https://api.github.com/repos/russellhadley/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/russellhadley/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/russellhadley/coreclr/tags","blobs_url":"https://api.github.com/repos/russellhadley/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhadley/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhadley/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhadley/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhadley/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhadley/coreclr/languages","stargazers_url":"https://api.github.com/repos/russellhadley/coreclr/stargazers","contributors_url":"https://api.github.com/repos/russellhadley/coreclr/contributors","subscribers_url":"https://api.github.com/repos/russellhadley/coreclr/subscribers","subscription_url":"https://api.github.com/repos/russellhadley/coreclr/subscription","commits_url":"https://api.github.com/repos/russellhadley/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhadley/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhadley/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhadley/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhadley/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/russellhadley/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhadley/coreclr/merges","archive_url":"https://api.github.com/repos/russellhadley/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhadley/coreclr/downloads","issues_url":"https://api.github.com/repos/russellhadley/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/russellhadley/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhadley/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhadley/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhadley/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/russellhadley/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/russellhadley/coreclr/deployments","created_at":"2015-02-15T16:08:45Z","updated_at":"2016-03-29T02:37:43Z","pushed_at":"2016-09-24T00:01:29Z","git_url":"git://github.com/russellhadley/coreclr.git","ssh_url":"git@github.com:russellhadley/coreclr.git","clone_url":"https://github.com/russellhadley/coreclr.git","svn_url":"https://github.com/russellhadley/coreclr","homepage":"","size":108502,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ecb241f8d30b3251ca8f8e267d17f7fe36224b8f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-09-23T16:14:00Z","pushed_at":"2016-09-24T00:12:11Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":122670,"stargazers_count":6929,"watchers_count":6929,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1661,"mirror_url":null,"open_issues_count":976,"forks":1661,"open_issues":976,"watchers":6929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7340"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7340"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7340"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7340/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7340/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7340/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/932f93e01ec1834628fc6b9ad68dfbcfaa08bf8e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":60,"deletions":52,"changed_files":5}}
{"actor":{"display_login":"russellhadley"}}