{"action":"created","issue":{"url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/92","labels_url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/92/comments","events_url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/92/events","html_url":"https://github.com/JohnMaguire/Cardinal/pull/92","id":126605605,"number":92,"title":"Configurable storage path","user":{"login":"BiohZn","id":365066,"avatar_url":"https://avatars.githubusercontent.com/u/365066?v=3","gravatar_id":"","url":"https://api.github.com/users/BiohZn","html_url":"https://github.com/BiohZn","followers_url":"https://api.github.com/users/BiohZn/followers","following_url":"https://api.github.com/users/BiohZn/following{/other_user}","gists_url":"https://api.github.com/users/BiohZn/gists{/gist_id}","starred_url":"https://api.github.com/users/BiohZn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BiohZn/subscriptions","organizations_url":"https://api.github.com/users/BiohZn/orgs","repos_url":"https://api.github.com/users/BiohZn/repos","events_url":"https://api.github.com/users/BiohZn/events{/privacy}","received_events_url":"https://api.github.com/users/BiohZn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-14T08:38:49Z","updated_at":"2016-01-15T13:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JohnMaguire/Cardinal/pulls/92","html_url":"https://github.com/JohnMaguire/Cardinal/pull/92","diff_url":"https://github.com/JohnMaguire/Cardinal/pull/92.diff","patch_url":"https://github.com/JohnMaguire/Cardinal/pull/92.patch"},"body":"Suggestion for configurable storage path, fixes #85"},"comment":{"url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/comments/171965961","html_url":"https://github.com/JohnMaguire/Cardinal/pull/92#issuecomment-171965961","issue_url":"https://api.github.com/repos/JohnMaguire/Cardinal/issues/92","id":171965961,"user":{"login":"JohnMaguire","id":440033,"avatar_url":"https://avatars.githubusercontent.com/u/440033?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnMaguire","html_url":"https://github.com/JohnMaguire","followers_url":"https://api.github.com/users/JohnMaguire/followers","following_url":"https://api.github.com/users/JohnMaguire/following{/other_user}","gists_url":"https://api.github.com/users/JohnMaguire/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnMaguire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnMaguire/subscriptions","organizations_url":"https://api.github.com/users/JohnMaguire/orgs","repos_url":"https://api.github.com/users/JohnMaguire/repos","events_url":"https://api.github.com/users/JohnMaguire/events{/privacy}","received_events_url":"https://api.github.com/users/JohnMaguire/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T13:49:59Z","updated_at":"2016-01-15T13:49:59Z","body":"Hey thanks for this PR, it looks great!\r\n\r\nHowever, there's one slight thing I'd like fixed first: I've been trying to keep application code / logic out of the CardinalBotFactory, and use it primarily for managing the connection to IRC. I'm thinking the code for creating the storage directory could go one of two places, and I'm not too attached to either one, so perhaps whichever you think makes sense:\r\n\r\n1. In the `cardinal.py` file, after all the configuration juggling. Consider it part of the \"bootstrapping\" process.\r\n2. In `CardinalBot` itself, though I think this could be a little awkward because then we aren't creating the storage directory until AFTER spawning our IRC connection.\r\n\r\nOne more thing! I think the \"Storage path does not exist, creating it...\" log line could probably be set to `info()`. Especially since I'd like to see this line if an exception gets thrown while attempting to create the storage path (say, permissions error.)\r\n\r\nThanks a ton for this PR!"}}