{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/tofino/issues/965","repository_url":"https://api.github.com/repos/mozilla/tofino","labels_url":"https://api.github.com/repos/mozilla/tofino/issues/965/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/tofino/issues/965/comments","events_url":"https://api.github.com/repos/mozilla/tofino/issues/965/events","html_url":"https://github.com/mozilla/tofino/pull/965","id":171276990,"number":965,"title":"Make the additional processes run with stock node.","user":{"login":"Mossop","id":437326,"avatar_url":"https://avatars.githubusercontent.com/u/437326?v=3","gravatar_id":"","url":"https://api.github.com/users/Mossop","html_url":"https://github.com/Mossop","followers_url":"https://api.github.com/users/Mossop/followers","following_url":"https://api.github.com/users/Mossop/following{/other_user}","gists_url":"https://api.github.com/users/Mossop/gists{/gist_id}","starred_url":"https://api.github.com/users/Mossop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mossop/subscriptions","organizations_url":"https://api.github.com/users/Mossop/orgs","repos_url":"https://api.github.com/users/Mossop/repos","events_url":"https://api.github.com/users/Mossop/events{/privacy}","received_events_url":"https://api.github.com/users/Mossop/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/tofino/labels/review?","name":"review?","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"bgrins","id":95570,"avatar_url":"https://avatars.githubusercontent.com/u/95570?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrins","html_url":"https://github.com/bgrins","followers_url":"https://api.github.com/users/bgrins/followers","following_url":"https://api.github.com/users/bgrins/following{/other_user}","gists_url":"https://api.github.com/users/bgrins/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrins/subscriptions","organizations_url":"https://api.github.com/users/bgrins/orgs","repos_url":"https://api.github.com/users/bgrins/repos","events_url":"https://api.github.com/users/bgrins/events{/privacy}","received_events_url":"https://api.github.com/users/bgrins/received_events","type":"User","site_admin":false},"assignees":[{"login":"bgrins","id":95570,"avatar_url":"https://avatars.githubusercontent.com/u/95570?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrins","html_url":"https://github.com/bgrins","followers_url":"https://api.github.com/users/bgrins/followers","following_url":"https://api.github.com/users/bgrins/following{/other_user}","gists_url":"https://api.github.com/users/bgrins/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrins/subscriptions","organizations_url":"https://api.github.com/users/bgrins/orgs","repos_url":"https://api.github.com/users/bgrins/repos","events_url":"https://api.github.com/users/bgrins/events{/privacy}","received_events_url":"https://api.github.com/users/bgrins/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-08-15T22:28:46Z","updated_at":"2016-08-25T00:41:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/965","html_url":"https://github.com/mozilla/tofino/pull/965","diff_url":"https://github.com/mozilla/tofino/pull/965.diff","patch_url":"https://github.com/mozilla/tofino/pull/965.patch"},"body":"There are a number of parts to this:\r\n\r\nWe split into two package.json files. The package.json in the app directory\r\ncontains only dependencies that can't be webpacked either because of native\r\ncode or because webpack isn't clever enough. The top-level package.json\r\ndependencies key contains the other dependencies that are needed by the app code\r\nand can be webpacked. The top-level package.json devDependencies contains any\r\nother dependencies needed by build/test code.\r\n\r\nThis structure means that app/node_modules contains only the dependencies that\r\nactually ship as-is in the final package. Part of webpack now copies all of that\r\ninto the lib directory to be used by the app.\r\n\r\nThe test test-dependencies replaces test-packages and test-devdeps and does a\r\nthorough verification that other than a few exceptions the above rules are met.\r\n\r\nEslints import plugin isn't smart enough for a two package.json structures so\r\none of its rules had to be replaced.\r\n\r\nAll of this means we can get rid of module rebuilding for electron since the\r\nnative code now runs in pure node."},"comment":{"url":"https://api.github.com/repos/mozilla/tofino/issues/comments/242250645","html_url":"https://github.com/mozilla/tofino/pull/965#issuecomment-242250645","issue_url":"https://api.github.com/repos/mozilla/tofino/issues/965","id":242250645,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T00:41:40Z","updated_at":"2016-08-25T00:41:40Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7592065/badge)](https://coveralls.io/builds/7592065)\n\nCoverage increased (+0.6%) to 43.106% when pulling **fc60f17fc088c95b9c4fdfad04cd45ecc932d966 on Mossop:plainnode** into **5a7444f6a034395dfca5f0da40a117c2c453d369 on mozilla:master**.\n"}}
{"actor":{"display_login":"coveralls"}}