{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/52677504","id":52677504,"diff_hunk":"@@ -221,11 +221,11 @@ var StudyViewProxy = (function() {\n                         var _parts = _lists[i].split('\\t');\n                         if(_parts.length < 5) continue;\n                         if (_parts[0] === parObject.studyId+\"_sequenced\") {\n-                            _sequencedSampleIds = _parts[4].split(' ');\n+                            _sequencedSampleIds = _parts[4].split(' ').filter(Boolean);","path":"portal/src/main/webapp/js/src/study-view/data/StudyViewProxy.js","position":5,"original_position":5,"commit_id":"316acdeebfa709cc071d06c3eb7255d39f54084c","original_commit_id":"316acdeebfa709cc071d06c3eb7255d39f54084c","user":{"login":"jjgao","id":840895,"avatar_url":"https://avatars.githubusercontent.com/u/840895?v=3","gravatar_id":"","url":"https://api.github.com/users/jjgao","html_url":"https://github.com/jjgao","followers_url":"https://api.github.com/users/jjgao/followers","following_url":"https://api.github.com/users/jjgao/following{/other_user}","gists_url":"https://api.github.com/users/jjgao/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgao/subscriptions","organizations_url":"https://api.github.com/users/jjgao/orgs","repos_url":"https://api.github.com/users/jjgao/repos","events_url":"https://api.github.com/users/jjgao/events{/privacy}","received_events_url":"https://api.github.com/users/jjgao/received_events","type":"User","site_admin":false},"body":"maybe do a trim() before split instead of filter() to avoid the loop?","created_at":"2016-02-11T22:23:18Z","updated_at":"2016-02-11T22:23:18Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/841#discussion_r52677504","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/52677504"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/841#discussion_r52677504"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841","id":59093606,"html_url":"https://github.com/cBioPortal/cbioportal/pull/841","diff_url":"https://github.com/cBioPortal/cbioportal/pull/841.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/841.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/841","number":841,"state":"open","locked":false,"title":"Filter out blank sample ids","user":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-11T21:06:01Z","updated_at":"2016-02-11T22:23:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10df02b76d2476ac5bf5b9e2e3a32f47aedc2bcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/841/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/316acdeebfa709cc071d06c3eb7255d39f54084c","head":{"label":"zheins:fix-counts","ref":"fix-counts","sha":"316acdeebfa709cc071d06c3eb7255d39f54084c","user":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"repo":{"id":43025720,"name":"cbioportal","full_name":"zheins/cbioportal","owner":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zheins/cbioportal","description":"","fork":true,"url":"https://api.github.com/repos/zheins/cbioportal","forks_url":"https://api.github.com/repos/zheins/cbioportal/forks","keys_url":"https://api.github.com/repos/zheins/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zheins/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zheins/cbioportal/teams","hooks_url":"https://api.github.com/repos/zheins/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/zheins/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/zheins/cbioportal/events","assignees_url":"https://api.github.com/repos/zheins/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/zheins/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/zheins/cbioportal/tags","blobs_url":"https://api.github.com/repos/zheins/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zheins/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zheins/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zheins/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zheins/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/zheins/cbioportal/languages","stargazers_url":"https://api.github.com/repos/zheins/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/zheins/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/zheins/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/zheins/cbioportal/subscription","commits_url":"https://api.github.com/repos/zheins/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zheins/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zheins/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zheins/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/zheins/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/zheins/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zheins/cbioportal/merges","archive_url":"https://api.github.com/repos/zheins/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zheins/cbioportal/downloads","issues_url":"https://api.github.com/repos/zheins/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/zheins/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/zheins/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/zheins/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zheins/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/zheins/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/zheins/cbioportal/deployments","created_at":"2015-09-23T20:43:29Z","updated_at":"2015-09-23T20:43:45Z","pushed_at":"2016-02-11T20:56:16Z","git_url":"git://github.com/zheins/cbioportal.git","ssh_url":"git@github.com:zheins/cbioportal.git","clone_url":"https://github.com/zheins/cbioportal.git","svn_url":"https://github.com/zheins/cbioportal","homepage":null,"size":151567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:hotfix","ref":"hotfix","sha":"d66582ff90baebdc2805e98c412ed4190c4bf91c","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-01-28T19:51:35Z","pushed_at":"2016-02-11T21:06:02Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":null,"size":181281,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":170,"forks":53,"open_issues":170,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/841"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/841"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/316acdeebfa709cc071d06c3eb7255d39f54084c"}}}}