{"action":"created","issue":{"url":"https://api.github.com/repos/openx/brine/issues/17","repository_url":"https://api.github.com/repos/openx/brine","labels_url":"https://api.github.com/repos/openx/brine/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/openx/brine/issues/17/comments","events_url":"https://api.github.com/repos/openx/brine/issues/17/events","html_url":"https://github.com/openx/brine/pull/17","id":156055109,"number":17,"title":"raising an error if description is missing","user":{"login":"mostafahussein","id":4104127,"avatar_url":"https://avatars.githubusercontent.com/u/4104127?v=3","gravatar_id":"","url":"https://api.github.com/users/mostafahussein","html_url":"https://github.com/mostafahussein","followers_url":"https://api.github.com/users/mostafahussein/followers","following_url":"https://api.github.com/users/mostafahussein/following{/other_user}","gists_url":"https://api.github.com/users/mostafahussein/gists{/gist_id}","starred_url":"https://api.github.com/users/mostafahussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mostafahussein/subscriptions","organizations_url":"https://api.github.com/users/mostafahussein/orgs","repos_url":"https://api.github.com/users/mostafahussein/repos","events_url":"https://api.github.com/users/mostafahussein/events{/privacy}","received_events_url":"https://api.github.com/users/mostafahussein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-20T21:32:29Z","updated_at":"2016-05-22T18:49:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openx/brine/pulls/17","html_url":"https://github.com/openx/brine/pull/17","diff_url":"https://github.com/openx/brine/pull/17.diff","patch_url":"https://github.com/openx/brine/pull/17.patch"},"body":"This should fix #14. I was thinking about using `try() and catch()` instead of using `raise()`. what do you think ?"},"comment":{"url":"https://api.github.com/repos/openx/brine/issues/comments/220848970","html_url":"https://github.com/openx/brine/pull/17#issuecomment-220848970","issue_url":"https://api.github.com/repos/openx/brine/issues/17","id":220848970,"user":{"login":"openx-luis","id":13559275,"avatar_url":"https://avatars.githubusercontent.com/u/13559275?v=3","gravatar_id":"","url":"https://api.github.com/users/openx-luis","html_url":"https://github.com/openx-luis","followers_url":"https://api.github.com/users/openx-luis/followers","following_url":"https://api.github.com/users/openx-luis/following{/other_user}","gists_url":"https://api.github.com/users/openx-luis/gists{/gist_id}","starred_url":"https://api.github.com/users/openx-luis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openx-luis/subscriptions","organizations_url":"https://api.github.com/users/openx-luis/orgs","repos_url":"https://api.github.com/users/openx-luis/repos","events_url":"https://api.github.com/users/openx-luis/events{/privacy}","received_events_url":"https://api.github.com/users/openx-luis/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T18:49:47Z","updated_at":"2016-05-22T18:49:47Z","body":"Ok, that's not what I meant at all. :)\r\n\r\nWith what you're doing you might as well forgo the exceptions and just print the error and exit directly, in that staticmethod.\r\n\r\nBack to what I was saying. Consider the case of someone who is trying to use `brine.load()` in a script. All of a sudden the program exits! That's clearly undesirable behavior. We want to allow the user of the `Brine` instance to catch the exception and act in accordance to what they want to do.\r\n\r\nSo, to summarize,\r\n* try-except clause only in `main()` – we print error message here\r\n* `brine.load()` throws `BrineError` exception, and user of script decides what to do with it.\r\n\r\nAny more questions?"}}
{"actor":{"display_login":"openx-luis"}}