{"action":"closed","number":186,"pull_request":{"url":"https://api.github.com/repos/cyverse/DE/pulls/186","id":69429124,"html_url":"https://github.com/cyverse/DE/pull/186","diff_url":"https://github.com/cyverse/DE/pull/186.diff","patch_url":"https://github.com/cyverse/DE/pull/186.patch","issue_url":"https://api.github.com/repos/cyverse/DE/issues/186","number":186,"state":"closed","locked":false,"title":"Reimplement several functions in clj-jargon to use more specific queries","user":{"login":"ianmcorvidae","id":106004,"avatar_url":"https://avatars.githubusercontent.com/u/106004?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmcorvidae","html_url":"https://github.com/ianmcorvidae","followers_url":"https://api.github.com/users/ianmcorvidae/followers","following_url":"https://api.github.com/users/ianmcorvidae/following{/other_user}","gists_url":"https://api.github.com/users/ianmcorvidae/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcorvidae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcorvidae/subscriptions","organizations_url":"https://api.github.com/users/ianmcorvidae/orgs","repos_url":"https://api.github.com/users/ianmcorvidae/repos","events_url":"https://api.github.com/users/ianmcorvidae/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcorvidae/received_events","type":"User","site_admin":false},"body":"The primary goal of this is speeding up info-typer some. I was investigating why it's so slow and found that a call to `clj-jargon/attribute?` (to check if there's already an `ipc-filetype` AVU) was taking about 90ms most times it ran, which is longer than the actual file identification process. Looking deeper, what we were doing was getting all metadata for the object and then filtering it in clj-jargon down to just the one attribute, by way of a chain of functions.\r\n\r\nThis changes the chain so it requests only the AVUs it actually wants, from the start. I've also done the same for lookups by attribute + value, which were implemented in a similar fashion.\r\n\r\nIt seems to have worked, since a brief test afterwards showed the same call taking less than a quarter of the time.","created_at":"2016-05-09T23:46:56Z","updated_at":"2016-05-11T17:53:50Z","closed_at":"2016-05-11T17:53:49Z","merged_at":"2016-05-11T17:53:49Z","merge_commit_sha":"94f37a369863ff2285003f28dd293d116dbf1823","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cyverse/DE/pulls/186/commits","review_comments_url":"https://api.github.com/repos/cyverse/DE/pulls/186/comments","review_comment_url":"https://api.github.com/repos/cyverse/DE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse/DE/issues/186/comments","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/94f37a369863ff2285003f28dd293d116dbf1823","head":{"label":"cyverse:clj-jargon-metadata-improvements","ref":"clj-jargon-metadata-improvements","sha":"94f37a369863ff2285003f28dd293d116dbf1823","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":45433519,"name":"DE","full_name":"cyverse/DE","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/DE","description":"The CyVerse Discovery Environment","fork":false,"url":"https://api.github.com/repos/cyverse/DE","forks_url":"https://api.github.com/repos/cyverse/DE/forks","keys_url":"https://api.github.com/repos/cyverse/DE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/DE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/DE/teams","hooks_url":"https://api.github.com/repos/cyverse/DE/hooks","issue_events_url":"https://api.github.com/repos/cyverse/DE/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/DE/events","assignees_url":"https://api.github.com/repos/cyverse/DE/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/DE/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/DE/tags","blobs_url":"https://api.github.com/repos/cyverse/DE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/DE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/DE/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/DE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/DE/languages","stargazers_url":"https://api.github.com/repos/cyverse/DE/stargazers","contributors_url":"https://api.github.com/repos/cyverse/DE/contributors","subscribers_url":"https://api.github.com/repos/cyverse/DE/subscribers","subscription_url":"https://api.github.com/repos/cyverse/DE/subscription","commits_url":"https://api.github.com/repos/cyverse/DE/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/DE/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/DE/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/DE/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/DE/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/DE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/DE/merges","archive_url":"https://api.github.com/repos/cyverse/DE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/DE/downloads","issues_url":"https://api.github.com/repos/cyverse/DE/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/DE/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/DE/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/DE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/DE/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/DE/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/DE/deployments","created_at":"2015-11-03T01:27:41Z","updated_at":"2016-03-05T02:16:59Z","pushed_at":"2016-05-11T17:53:49Z","git_url":"git://github.com/cyverse/DE.git","ssh_url":"git@github.com:cyverse/DE.git","clone_url":"https://github.com/cyverse/DE.git","svn_url":"https://github.com/cyverse/DE","homepage":"https://de.iplantcollaborative.org/de/","size":41747,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"cyverse:2.7","ref":"2.7","sha":"2c4173035c629540b5d92f4a0e21e0f4c2c25dc0","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":45433519,"name":"DE","full_name":"cyverse/DE","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/DE","description":"The CyVerse Discovery Environment","fork":false,"url":"https://api.github.com/repos/cyverse/DE","forks_url":"https://api.github.com/repos/cyverse/DE/forks","keys_url":"https://api.github.com/repos/cyverse/DE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/DE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/DE/teams","hooks_url":"https://api.github.com/repos/cyverse/DE/hooks","issue_events_url":"https://api.github.com/repos/cyverse/DE/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/DE/events","assignees_url":"https://api.github.com/repos/cyverse/DE/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/DE/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/DE/tags","blobs_url":"https://api.github.com/repos/cyverse/DE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/DE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/DE/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/DE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/DE/languages","stargazers_url":"https://api.github.com/repos/cyverse/DE/stargazers","contributors_url":"https://api.github.com/repos/cyverse/DE/contributors","subscribers_url":"https://api.github.com/repos/cyverse/DE/subscribers","subscription_url":"https://api.github.com/repos/cyverse/DE/subscription","commits_url":"https://api.github.com/repos/cyverse/DE/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/DE/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/DE/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/DE/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/DE/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/DE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/DE/merges","archive_url":"https://api.github.com/repos/cyverse/DE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/DE/downloads","issues_url":"https://api.github.com/repos/cyverse/DE/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/DE/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/DE/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/DE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/DE/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/DE/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/DE/deployments","created_at":"2015-11-03T01:27:41Z","updated_at":"2016-03-05T02:16:59Z","pushed_at":"2016-05-11T17:53:49Z","git_url":"git://github.com/cyverse/DE.git","ssh_url":"git@github.com:cyverse/DE.git","clone_url":"https://github.com/cyverse/DE.git","svn_url":"https://github.com/cyverse/DE","homepage":"https://de.iplantcollaborative.org/de/","size":41747,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse/DE/pulls/186"},"html":{"href":"https://github.com/cyverse/DE/pull/186"},"issue":{"href":"https://api.github.com/repos/cyverse/DE/issues/186"},"comments":{"href":"https://api.github.com/repos/cyverse/DE/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse/DE/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse/DE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse/DE/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse/DE/statuses/94f37a369863ff2285003f28dd293d116dbf1823"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ianmcorvidae","id":106004,"avatar_url":"https://avatars.githubusercontent.com/u/106004?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmcorvidae","html_url":"https://github.com/ianmcorvidae","followers_url":"https://api.github.com/users/ianmcorvidae/followers","following_url":"https://api.github.com/users/ianmcorvidae/following{/other_user}","gists_url":"https://api.github.com/users/ianmcorvidae/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcorvidae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcorvidae/subscriptions","organizations_url":"https://api.github.com/users/ianmcorvidae/orgs","repos_url":"https://api.github.com/users/ianmcorvidae/repos","events_url":"https://api.github.com/users/ianmcorvidae/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcorvidae/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":2,"additions":31,"deletions":22,"changed_files":1}}