{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/1","repository_url":"https://api.github.com/repos/driftyco/ionic-starter-super","labels_url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/1/comments","events_url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/1/events","html_url":"https://github.com/driftyco/ionic-starter-super/issues/1","id":190487351,"number":1,"title":"ngc build fails with outsourced declarations/entryComponents in app.module.ts","user":{"login":"chron0","id":3270028,"avatar_url":"https://avatars.githubusercontent.com/u/3270028?v=3","gravatar_id":"","url":"https://api.github.com/users/chron0","html_url":"https://github.com/chron0","followers_url":"https://api.github.com/users/chron0/followers","following_url":"https://api.github.com/users/chron0/following{/other_user}","gists_url":"https://api.github.com/users/chron0/gists{/gist_id}","starred_url":"https://api.github.com/users/chron0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chron0/subscriptions","organizations_url":"https://api.github.com/users/chron0/orgs","repos_url":"https://api.github.com/users/chron0/repos","events_url":"https://api.github.com/users/chron0/events{/privacy}","received_events_url":"https://api.github.com/users/chron0/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-19T09:44:33Z","updated_at":"2016-12-20T23:36:54Z","closed_at":"2016-12-20T23:36:54Z","body":"I've tried to adapt the neat declarations/entryComponents method used in app.module.ts of the app branch. I don't run builds often enough and as this works in ionic serve (dev) mode but it fails during ngc compilation, I just wanted to drop it here as a reminder:\r\n\r\n```\r\n> ionic-hello-world@ ionic:build /home/chrono/src/ionic-starter-super\r\n> ionic-app-scripts build\r\n\r\n[09:34:46]  ionic-app-scripts 0.0.44 \r\n[09:34:46]  build prod started ... \r\n[09:34:46]  clean started ... \r\n[09:34:46]  clean finished in 8 ms \r\n[09:34:46]  copy started ... \r\n[09:34:46]  ngc started ... \r\n[09:34:46]  copy finished in 59 ms \r\n[09:34:49]  Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider \r\n            replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in \r\n            /home/chrono/src/ionic-starter-super/.tmp/app/app.module.ts, resolving symbol AppModule in \r\n            /home/chrono/src/ionic-starter-super/.tmp/app/app.module.ts \r\n[09:34:49]  ngc failed \r\n[09:34:49]  ionic-app-script task: \"build\" \r\n[09:34:49]  Error: Error \r\n```"},"comment":{"url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/comments/268390857","html_url":"https://github.com/driftyco/ionic-starter-super/issues/1#issuecomment-268390857","issue_url":"https://api.github.com/repos/driftyco/ionic-starter-super/issues/1","id":268390857,"user":{"login":"mlynch","id":11214,"avatar_url":"https://avatars.githubusercontent.com/u/11214?v=3","gravatar_id":"","url":"https://api.github.com/users/mlynch","html_url":"https://github.com/mlynch","followers_url":"https://api.github.com/users/mlynch/followers","following_url":"https://api.github.com/users/mlynch/following{/other_user}","gists_url":"https://api.github.com/users/mlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlynch/subscriptions","organizations_url":"https://api.github.com/users/mlynch/orgs","repos_url":"https://api.github.com/users/mlynch/repos","events_url":"https://api.github.com/users/mlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mlynch/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T23:36:54Z","updated_at":"2016-12-20T23:36:54Z","body":"Fixed that in my recent updates and found a nice balance between centralizing things in pages/providers.ts and having them in the module."}}
{"actor":{"display_login":"mlynch"}}