{"action":"created","comment":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/comments/89904184","pull_request_review_id":10433911,"id":89904184,"diff_hunk":"@@ -139,6 +139,24 @@ class Meta:\n         icon = \"pilcrow\"\n \n \n+class BlockQuoteBlock(TextBlock):\n+\n+    def __init__(self, required=True, help_text=None, max_length=None, min_length=None, **kwargs):\n+        super(BlockQuoteBlock, self).__init__(**kwargs)","path":"wagtail/wagtailcore/blocks/field_block.py","position":7,"original_position":7,"commit_id":"30529e3b674d0f8c698f69886df499af60c03c79","original_commit_id":"30529e3b674d0f8c698f69886df499af60c03c79","user":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"body":"Are the `required` / `help_text` / `max_length` / `min_length` parameters respected here? It looks like those are just thrown away in this definition.\r\n\r\nYou can probably just omit `__init__` and `get_searchable_content` here, because they aren't doing anything that `TextBlock` isn't doing already.","created_at":"2016-11-28T22:51:09Z","updated_at":"2016-11-28T22:51:09Z","html_url":"https://github.com/torchbox/wagtail/pull/3184#discussion_r89904184","pull_request_url":"https://api.github.com/repos/torchbox/wagtail/pulls/3184","_links":{"self":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/comments/89904184"},"html":{"href":"https://github.com/torchbox/wagtail/pull/3184#discussion_r89904184"},"pull_request":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/3184"}}},"pull_request":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/3184","id":95590413,"html_url":"https://github.com/torchbox/wagtail/pull/3184","diff_url":"https://github.com/torchbox/wagtail/pull/3184.diff","patch_url":"https://github.com/torchbox/wagtail/pull/3184.patch","issue_url":"https://api.github.com/repos/torchbox/wagtail/issues/3184","number":3184,"state":"open","locked":false,"title":"Add BlockQuoteBlock to core block types","user":{"login":"shacker","id":102694,"avatar_url":"https://avatars.githubusercontent.com/u/102694?v=3","gravatar_id":"","url":"https://api.github.com/users/shacker","html_url":"https://github.com/shacker","followers_url":"https://api.github.com/users/shacker/followers","following_url":"https://api.github.com/users/shacker/following{/other_user}","gists_url":"https://api.github.com/users/shacker/gists{/gist_id}","starred_url":"https://api.github.com/users/shacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shacker/subscriptions","organizations_url":"https://api.github.com/users/shacker/orgs","repos_url":"https://api.github.com/users/shacker/repos","events_url":"https://api.github.com/users/shacker/events{/privacy}","received_events_url":"https://api.github.com/users/shacker/received_events","type":"User","site_admin":false},"body":"As discussed at https://github.com/torchbox/wagtail/issues/532\r\n\r\nI ended up subclassing TextBlock rather than CharBlock because the input needs to be multi-line (I was still able to shorten the definition this way).\r\n\r\nOne bit I'm not sure of - because `wagtailcore.blocks.__init__` imports * from all of the block modules, I should be able to import `blocks.BlockQuoteBlock`, as with other core block types. But for some reason I'm forced to import `blocks.field_block.BlockQuoteBlock` - not sure whether this means I'm missing something.","created_at":"2016-11-28T22:36:13Z","updated_at":"2016-11-28T22:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46aab8f3a71793a642aa95ba95d004d80404d501","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/torchbox/wagtail/pulls/3184/commits","review_comments_url":"https://api.github.com/repos/torchbox/wagtail/pulls/3184/comments","review_comment_url":"https://api.github.com/repos/torchbox/wagtail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/3184/comments","statuses_url":"https://api.github.com/repos/torchbox/wagtail/statuses/30529e3b674d0f8c698f69886df499af60c03c79","head":{"label":"cca:master","ref":"master","sha":"30529e3b674d0f8c698f69886df499af60c03c79","user":{"login":"cca","id":8672569,"avatar_url":"https://avatars.githubusercontent.com/u/8672569?v=3","gravatar_id":"","url":"https://api.github.com/users/cca","html_url":"https://github.com/cca","followers_url":"https://api.github.com/users/cca/followers","following_url":"https://api.github.com/users/cca/following{/other_user}","gists_url":"https://api.github.com/users/cca/gists{/gist_id}","starred_url":"https://api.github.com/users/cca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cca/subscriptions","organizations_url":"https://api.github.com/users/cca/orgs","repos_url":"https://api.github.com/users/cca/repos","events_url":"https://api.github.com/users/cca/events{/privacy}","received_events_url":"https://api.github.com/users/cca/received_events","type":"Organization","site_admin":false},"repo":{"id":41389225,"name":"wagtail","full_name":"cca/wagtail","owner":{"login":"cca","id":8672569,"avatar_url":"https://avatars.githubusercontent.com/u/8672569?v=3","gravatar_id":"","url":"https://api.github.com/users/cca","html_url":"https://github.com/cca","followers_url":"https://api.github.com/users/cca/followers","following_url":"https://api.github.com/users/cca/following{/other_user}","gists_url":"https://api.github.com/users/cca/gists{/gist_id}","starred_url":"https://api.github.com/users/cca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cca/subscriptions","organizations_url":"https://api.github.com/users/cca/orgs","repos_url":"https://api.github.com/users/cca/repos","events_url":"https://api.github.com/users/cca/events{/privacy}","received_events_url":"https://api.github.com/users/cca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cca/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":true,"url":"https://api.github.com/repos/cca/wagtail","forks_url":"https://api.github.com/repos/cca/wagtail/forks","keys_url":"https://api.github.com/repos/cca/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cca/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cca/wagtail/teams","hooks_url":"https://api.github.com/repos/cca/wagtail/hooks","issue_events_url":"https://api.github.com/repos/cca/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/cca/wagtail/events","assignees_url":"https://api.github.com/repos/cca/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/cca/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/cca/wagtail/tags","blobs_url":"https://api.github.com/repos/cca/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cca/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cca/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/cca/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cca/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/cca/wagtail/languages","stargazers_url":"https://api.github.com/repos/cca/wagtail/stargazers","contributors_url":"https://api.github.com/repos/cca/wagtail/contributors","subscribers_url":"https://api.github.com/repos/cca/wagtail/subscribers","subscription_url":"https://api.github.com/repos/cca/wagtail/subscription","commits_url":"https://api.github.com/repos/cca/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/cca/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/cca/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/cca/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/cca/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/cca/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cca/wagtail/merges","archive_url":"https://api.github.com/repos/cca/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cca/wagtail/downloads","issues_url":"https://api.github.com/repos/cca/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/cca/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/cca/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/cca/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cca/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/cca/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/cca/wagtail/deployments","created_at":"2015-08-25T21:37:59Z","updated_at":"2016-11-28T22:32:21Z","pushed_at":"2016-11-28T22:31:22Z","git_url":"git://github.com/cca/wagtail.git","ssh_url":"git@github.com:cca/wagtail.git","clone_url":"https://github.com/cca/wagtail.git","svn_url":"https://github.com/cca/wagtail","homepage":"wagtail.io","size":42175,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torchbox:master","ref":"master","sha":"4e23e461591660a3d4d236831db8e1b6df899abb","user":{"login":"torchbox","id":84015,"avatar_url":"https://avatars.githubusercontent.com/u/84015?v=3","gravatar_id":"","url":"https://api.github.com/users/torchbox","html_url":"https://github.com/torchbox","followers_url":"https://api.github.com/users/torchbox/followers","following_url":"https://api.github.com/users/torchbox/following{/other_user}","gists_url":"https://api.github.com/users/torchbox/gists{/gist_id}","starred_url":"https://api.github.com/users/torchbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torchbox/subscriptions","organizations_url":"https://api.github.com/users/torchbox/orgs","repos_url":"https://api.github.com/users/torchbox/repos","events_url":"https://api.github.com/users/torchbox/events{/privacy}","received_events_url":"https://api.github.com/users/torchbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16479108,"name":"wagtail","full_name":"torchbox/wagtail","owner":{"login":"torchbox","id":84015,"avatar_url":"https://avatars.githubusercontent.com/u/84015?v=3","gravatar_id":"","url":"https://api.github.com/users/torchbox","html_url":"https://github.com/torchbox","followers_url":"https://api.github.com/users/torchbox/followers","following_url":"https://api.github.com/users/torchbox/following{/other_user}","gists_url":"https://api.github.com/users/torchbox/gists{/gist_id}","starred_url":"https://api.github.com/users/torchbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torchbox/subscriptions","organizations_url":"https://api.github.com/users/torchbox/orgs","repos_url":"https://api.github.com/users/torchbox/repos","events_url":"https://api.github.com/users/torchbox/events{/privacy}","received_events_url":"https://api.github.com/users/torchbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torchbox/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":false,"url":"https://api.github.com/repos/torchbox/wagtail","forks_url":"https://api.github.com/repos/torchbox/wagtail/forks","keys_url":"https://api.github.com/repos/torchbox/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torchbox/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torchbox/wagtail/teams","hooks_url":"https://api.github.com/repos/torchbox/wagtail/hooks","issue_events_url":"https://api.github.com/repos/torchbox/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/torchbox/wagtail/events","assignees_url":"https://api.github.com/repos/torchbox/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/torchbox/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/torchbox/wagtail/tags","blobs_url":"https://api.github.com/repos/torchbox/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torchbox/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torchbox/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/torchbox/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torchbox/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/torchbox/wagtail/languages","stargazers_url":"https://api.github.com/repos/torchbox/wagtail/stargazers","contributors_url":"https://api.github.com/repos/torchbox/wagtail/contributors","subscribers_url":"https://api.github.com/repos/torchbox/wagtail/subscribers","subscription_url":"https://api.github.com/repos/torchbox/wagtail/subscription","commits_url":"https://api.github.com/repos/torchbox/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/torchbox/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/torchbox/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/torchbox/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/torchbox/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/torchbox/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torchbox/wagtail/merges","archive_url":"https://api.github.com/repos/torchbox/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torchbox/wagtail/downloads","issues_url":"https://api.github.com/repos/torchbox/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/torchbox/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/torchbox/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/torchbox/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torchbox/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/torchbox/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/torchbox/wagtail/deployments","created_at":"2014-02-03T12:41:59Z","updated_at":"2016-11-28T15:18:17Z","pushed_at":"2016-11-28T22:36:14Z","git_url":"git://github.com/torchbox/wagtail.git","ssh_url":"git@github.com:torchbox/wagtail.git","clone_url":"https://github.com/torchbox/wagtail.git","svn_url":"https://github.com/torchbox/wagtail","homepage":"wagtail.io","size":54122,"stargazers_count":3851,"watchers_count":3851,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":784,"mirror_url":null,"open_issues_count":510,"forks":784,"open_issues":510,"watchers":3851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/3184"},"html":{"href":"https://github.com/torchbox/wagtail/pull/3184"},"issue":{"href":"https://api.github.com/repos/torchbox/wagtail/issues/3184"},"comments":{"href":"https://api.github.com/repos/torchbox/wagtail/issues/3184/comments"},"review_comments":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/3184/comments"},"review_comment":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/3184/commits"},"statuses":{"href":"https://api.github.com/repos/torchbox/wagtail/statuses/30529e3b674d0f8c698f69886df499af60c03c79"}}}}
{"actor":{"display_login":"gasman"}}