{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments/62993286","id":62993286,"diff_hunk":"@@ -165,8 +166,78 @@ def clear_field(self):\n \n class MyCollections(Base):\n \n-    _header_locator = (By.CSS_SELECTOR, \".primary > header > h2\")\n+    _header_locator = (By.CSS_SELECTOR, '.primary > header > h2')\n+    _my_favorites_locator = (By.CSS_SELECTOR, '.other-categories ul:nth-child(3) li:nth-child(3)')\n \n     @property\n     def my_collections_header_text(self):\n         return self.selenium.find_element(*self._header_locator).text\n+\n+    def click_my_favorites(self):\n+        self.selenium.find_element(*self._my_favorites_locator).click()\n+        return MyFavorites(self.base_url, self.selenium)\n+\n+\n+class MyFavorites(Base):\n+\n+    _page_title = 'My Favorite Add-ons :: Collections :: Add-ons for Firefox'\n+    _header_locator = (By.CSS_SELECTOR, \"h2.collection > span\")\n+\n+    _edit_collection_locator = (By.CLASS_NAME, 'edit')\n+    _addon_locator = (By.CSS_SELECTOR, '.separated-listing .item')\n+    _add_on_name_locator = (By.CSS_SELECTOR, '.item h3 a')\n+\n+    def edit_collection(self):\n+        self.selenium.find_element(*self._edit_collection_locator).click()\n+        return EditCollection(self.base_url, self.selenium)\n+\n+    @property\n+    def my_favorites_header_text(self):\n+        return self.selenium.find_element(*self._header_locator).text\n+\n+    @property\n+    def add_ons(self):\n+        return [AddOn(self.base_url, self.selenium, el) for el in\n+                self.selenium.find_elements(*self._addon_locator)]","path":"pages/desktop/user.py","position":45,"original_position":45,"commit_id":"4087f1a70e5224f1a210d80cd3729a0a9135fa23","original_commit_id":"4087f1a70e5224f1a210d80cd3729a0a9135fa23","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"I wasn't expecting you to implement this, but thanks for giving it a go! We can't actually reuse `AddOn` from `pages.desktop.regions.addon` because that's a different region. Here I would suggest a nested class named `AddOn` as the region is specific to the collection page.","created_at":"2016-05-12T09:51:13Z","updated_at":"2016-05-12T09:51:13Z","html_url":"https://github.com/mozilla/Addon-Tests/pull/837#discussion_r62993286","pull_request_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments/62993286"},"html":{"href":"https://github.com/mozilla/Addon-Tests/pull/837#discussion_r62993286"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837","id":66771790,"html_url":"https://github.com/mozilla/Addon-Tests/pull/837","diff_url":"https://github.com/mozilla/Addon-Tests/pull/837.diff","patch_url":"https://github.com/mozilla/Addon-Tests/pull/837.patch","issue_url":"https://api.github.com/repos/mozilla/Addon-Tests/issues/837","number":837,"state":"open","locked":false,"title":"#836 fix - Bring back test to check add Add-On to 'My Favorites'","user":{"login":"stupchiy","id":775072,"avatar_url":"https://avatars.githubusercontent.com/u/775072?v=3","gravatar_id":"","url":"https://api.github.com/users/stupchiy","html_url":"https://github.com/stupchiy","followers_url":"https://api.github.com/users/stupchiy/followers","following_url":"https://api.github.com/users/stupchiy/following{/other_user}","gists_url":"https://api.github.com/users/stupchiy/gists{/gist_id}","starred_url":"https://api.github.com/users/stupchiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stupchiy/subscriptions","organizations_url":"https://api.github.com/users/stupchiy/orgs","repos_url":"https://api.github.com/users/stupchiy/repos","events_url":"https://api.github.com/users/stupchiy/events{/privacy}","received_events_url":"https://api.github.com/users/stupchiy/received_events","type":"User","site_admin":false},"body":"Bring back test to check add Add-On to 'My Favorites'","created_at":"2016-04-17T15:39:34Z","updated_at":"2016-05-12T09:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c280b6a51518fdbfaca8bd9341154857e787b450","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837/commits","review_comments_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837/comments","review_comment_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/Addon-Tests/issues/837/comments","statuses_url":"https://api.github.com/repos/mozilla/Addon-Tests/statuses/4087f1a70e5224f1a210d80cd3729a0a9135fa23","head":{"label":"stupchiy:issue_836","ref":"issue_836","sha":"4087f1a70e5224f1a210d80cd3729a0a9135fa23","user":{"login":"stupchiy","id":775072,"avatar_url":"https://avatars.githubusercontent.com/u/775072?v=3","gravatar_id":"","url":"https://api.github.com/users/stupchiy","html_url":"https://github.com/stupchiy","followers_url":"https://api.github.com/users/stupchiy/followers","following_url":"https://api.github.com/users/stupchiy/following{/other_user}","gists_url":"https://api.github.com/users/stupchiy/gists{/gist_id}","starred_url":"https://api.github.com/users/stupchiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stupchiy/subscriptions","organizations_url":"https://api.github.com/users/stupchiy/orgs","repos_url":"https://api.github.com/users/stupchiy/repos","events_url":"https://api.github.com/users/stupchiy/events{/privacy}","received_events_url":"https://api.github.com/users/stupchiy/received_events","type":"User","site_admin":false},"repo":{"id":3313936,"name":"Addon-Tests","full_name":"stupchiy/Addon-Tests","owner":{"login":"stupchiy","id":775072,"avatar_url":"https://avatars.githubusercontent.com/u/775072?v=3","gravatar_id":"","url":"https://api.github.com/users/stupchiy","html_url":"https://github.com/stupchiy","followers_url":"https://api.github.com/users/stupchiy/followers","following_url":"https://api.github.com/users/stupchiy/following{/other_user}","gists_url":"https://api.github.com/users/stupchiy/gists{/gist_id}","starred_url":"https://api.github.com/users/stupchiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stupchiy/subscriptions","organizations_url":"https://api.github.com/users/stupchiy/orgs","repos_url":"https://api.github.com/users/stupchiy/repos","events_url":"https://api.github.com/users/stupchiy/events{/privacy}","received_events_url":"https://api.github.com/users/stupchiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stupchiy/Addon-Tests","description":"Selenium Tests for addons.mozilla.com","fork":true,"url":"https://api.github.com/repos/stupchiy/Addon-Tests","forks_url":"https://api.github.com/repos/stupchiy/Addon-Tests/forks","keys_url":"https://api.github.com/repos/stupchiy/Addon-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stupchiy/Addon-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stupchiy/Addon-Tests/teams","hooks_url":"https://api.github.com/repos/stupchiy/Addon-Tests/hooks","issue_events_url":"https://api.github.com/repos/stupchiy/Addon-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/stupchiy/Addon-Tests/events","assignees_url":"https://api.github.com/repos/stupchiy/Addon-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/stupchiy/Addon-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/stupchiy/Addon-Tests/tags","blobs_url":"https://api.github.com/repos/stupchiy/Addon-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stupchiy/Addon-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stupchiy/Addon-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/stupchiy/Addon-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stupchiy/Addon-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/stupchiy/Addon-Tests/languages","stargazers_url":"https://api.github.com/repos/stupchiy/Addon-Tests/stargazers","contributors_url":"https://api.github.com/repos/stupchiy/Addon-Tests/contributors","subscribers_url":"https://api.github.com/repos/stupchiy/Addon-Tests/subscribers","subscription_url":"https://api.github.com/repos/stupchiy/Addon-Tests/subscription","commits_url":"https://api.github.com/repos/stupchiy/Addon-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/stupchiy/Addon-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/stupchiy/Addon-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/stupchiy/Addon-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/stupchiy/Addon-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/stupchiy/Addon-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stupchiy/Addon-Tests/merges","archive_url":"https://api.github.com/repos/stupchiy/Addon-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stupchiy/Addon-Tests/downloads","issues_url":"https://api.github.com/repos/stupchiy/Addon-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/stupchiy/Addon-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/stupchiy/Addon-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/stupchiy/Addon-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stupchiy/Addon-Tests/labels{/name}","releases_url":"https://api.github.com/repos/stupchiy/Addon-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/stupchiy/Addon-Tests/deployments","created_at":"2012-01-31T10:48:04Z","updated_at":"2014-11-05T22:04:53Z","pushed_at":"2016-05-11T21:18:43Z","git_url":"git://github.com/stupchiy/Addon-Tests.git","ssh_url":"git@github.com:stupchiy/Addon-Tests.git","clone_url":"https://github.com/stupchiy/Addon-Tests.git","svn_url":"https://github.com/stupchiy/Addon-Tests","homepage":"","size":3135,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"53d65a2538eb9830f7b17ebb721ab732da25ac71","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1735239,"name":"Addon-Tests","full_name":"mozilla/Addon-Tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/Addon-Tests","description":"Tests for Mozilla's Add-ons website","fork":false,"url":"https://api.github.com/repos/mozilla/Addon-Tests","forks_url":"https://api.github.com/repos/mozilla/Addon-Tests/forks","keys_url":"https://api.github.com/repos/mozilla/Addon-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/Addon-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/Addon-Tests/teams","hooks_url":"https://api.github.com/repos/mozilla/Addon-Tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/Addon-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/Addon-Tests/events","assignees_url":"https://api.github.com/repos/mozilla/Addon-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/Addon-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/Addon-Tests/tags","blobs_url":"https://api.github.com/repos/mozilla/Addon-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/Addon-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/Addon-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/Addon-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/Addon-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/Addon-Tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/Addon-Tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/Addon-Tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/Addon-Tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/Addon-Tests/subscription","commits_url":"https://api.github.com/repos/mozilla/Addon-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/Addon-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/Addon-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/Addon-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/Addon-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/Addon-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/Addon-Tests/merges","archive_url":"https://api.github.com/repos/mozilla/Addon-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/Addon-Tests/downloads","issues_url":"https://api.github.com/repos/mozilla/Addon-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/Addon-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/Addon-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/Addon-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/Addon-Tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/Addon-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/Addon-Tests/deployments","created_at":"2011-05-11T20:39:29Z","updated_at":"2016-04-29T07:32:39Z","pushed_at":"2016-05-12T09:28:34Z","git_url":"git://github.com/mozilla/Addon-Tests.git","ssh_url":"git@github.com:mozilla/Addon-Tests.git","clone_url":"https://github.com/mozilla/Addon-Tests.git","svn_url":"https://github.com/mozilla/Addon-Tests","homepage":"https://addons.mozilla.org/","size":4791,"stargazers_count":106,"watchers_count":106,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":9,"forks":141,"open_issues":9,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837"},"html":{"href":"https://github.com/mozilla/Addon-Tests/pull/837"},"issue":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/issues/837"},"comments":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/Addon-Tests/statuses/4087f1a70e5224f1a210d80cd3729a0a9135fa23"}}}}