{"action":"created","issue":{"url":"https://api.github.com/repos/cudamat/cudamat/issues/79","repository_url":"https://api.github.com/repos/cudamat/cudamat","labels_url":"https://api.github.com/repos/cudamat/cudamat/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/cudamat/cudamat/issues/79/comments","events_url":"https://api.github.com/repos/cudamat/cudamat/issues/79/events","html_url":"https://github.com/cudamat/cudamat/pull/79","id":185529126,"number":79,"title":"Simplify setup.py with custom compiler class","user":{"login":"f0k","id":629706,"avatar_url":"https://avatars.githubusercontent.com/u/629706?v=3","gravatar_id":"","url":"https://api.github.com/users/f0k","html_url":"https://github.com/f0k","followers_url":"https://api.github.com/users/f0k/followers","following_url":"https://api.github.com/users/f0k/following{/other_user}","gists_url":"https://api.github.com/users/f0k/gists{/gist_id}","starred_url":"https://api.github.com/users/f0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0k/subscriptions","organizations_url":"https://api.github.com/users/f0k/orgs","repos_url":"https://api.github.com/users/f0k/repos","events_url":"https://api.github.com/users/f0k/events{/privacy}","received_events_url":"https://api.github.com/users/f0k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-26T22:38:37Z","updated_at":"2016-11-15T14:55:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cudamat/cudamat/pulls/79","html_url":"https://github.com/cudamat/cudamat/pull/79","diff_url":"https://github.com/cudamat/cudamat/pull/79.diff","patch_url":"https://github.com/cudamat/cudamat/pull/79.patch"},"body":"This removes the `build_ext` hack overriding `compiler.spawn` to modify the compilation commands into proper `nvcc` calls depending on the platform (i.e., do nothing on Unix, but a lot on Windows). Instead, it defines a `NVCCCompiler` class that basically runs the same `nvcc` calls no matter whether on Linux, Mac or Windows. This makes `setup.py` less brittle, and should also resolve problems with wrong MSVC versions being used on Windows.\n\nTested on Ubuntu, and on Windows 7 with WinPython 3.4 and the Windows Platform SDK 7.1 (following [this guide](https://github.com/Lasagne/Lasagne/wiki/From-Zero-to-Lasagne-on-Windows-7-%2864-bit%29#c-compiler)).\n\nIf you're a Windows or Mac user, it would be nice if you could test this as well and report back. You can download the modified version at http://github.com/f0k/cudamat/archive/simplify-compile.zip and attempt to install it as in the [current installation guide](https://github.com/cudamat/cudamat/blob/6f4dbc773bfd0fa2b1d38939837b9019ac21d26e/INSTALL.md). A direct `pip install http://github.com/f0k/cudamat/archive/simplify-compile.zip` should also work. Set the `PATH` or `NVCCFLAGS` environment variables as needed. On Windows, especially pay attention to `--compiler-bindir` and `--cl-version` for the `NVCCFLAGS` if you run into trouble -- I'll extend the installation guide accordingly.\n\nCloses #53.\n"},"comment":{"url":"https://api.github.com/repos/cudamat/cudamat/issues/comments/260662344","html_url":"https://github.com/cudamat/cudamat/pull/79#issuecomment-260662344","issue_url":"https://api.github.com/repos/cudamat/cudamat/issues/79","id":260662344,"user":{"login":"f0k","id":629706,"avatar_url":"https://avatars.githubusercontent.com/u/629706?v=3","gravatar_id":"","url":"https://api.github.com/users/f0k","html_url":"https://github.com/f0k","followers_url":"https://api.github.com/users/f0k/followers","following_url":"https://api.github.com/users/f0k/following{/other_user}","gists_url":"https://api.github.com/users/f0k/gists{/gist_id}","starred_url":"https://api.github.com/users/f0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0k/subscriptions","organizations_url":"https://api.github.com/users/f0k/orgs","repos_url":"https://api.github.com/users/f0k/repos","events_url":"https://api.github.com/users/f0k/events{/privacy}","received_events_url":"https://api.github.com/users/f0k/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T14:55:01Z","updated_at":"2016-11-15T14:55:01Z","body":"> Just tested this out, and it worked like a charm!\r\n\r\nThank you for testing! It also works on Ubuntu.\r\n\r\nCan anybody confirm for Mac? A simple `pip install http://github.com/f0k/cudamat/archive/simplify-compile.zip` would do (with `--user` or `--upgrade --no-deps` as needed). @scttl?\r\n\r\nFor more recent Macs, it might be worth supporting `llvm` directly instead of going via `nvcc`, but I'm happy as long as it works at all."}}
{"actor":{"display_login":"f0k"}}