{"action":"opened","number":1339,"pull_request":{"url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339","id":89154398,"html_url":"https://github.com/Tatoeba/tatoeba2/pull/1339","diff_url":"https://github.com/Tatoeba/tatoeba2/pull/1339.diff","patch_url":"https://github.com/Tatoeba/tatoeba2/pull/1339.patch","issue_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/1339","number":1339,"state":"open","locked":false,"title":"Redesign sentences","user":{"login":"trang","id":221850,"avatar_url":"https://avatars.githubusercontent.com/u/221850?v=3","gravatar_id":"","url":"https://api.github.com/users/trang","html_url":"https://github.com/trang","followers_url":"https://api.github.com/users/trang/followers","following_url":"https://api.github.com/users/trang/following{/other_user}","gists_url":"https://api.github.com/users/trang/gists{/gist_id}","starred_url":"https://api.github.com/users/trang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trang/subscriptions","organizations_url":"https://api.github.com/users/trang/orgs","repos_url":"https://api.github.com/users/trang/repos","events_url":"https://api.github.com/users/trang/events{/privacy}","received_events_url":"https://api.github.com/users/trang/received_events","type":"User","site_admin":false},"body":"This pull request is part of #1180. It also addresses #1324.\r\n\r\nThe sentences have been redesigned for non-authenticated users.\r\n\r\n* The icons to translate, add to favorite, add to list have been removed. For non-authenticated users, they just redirect to a page to log in. Although they do give a hint to users what are the features of Tatoeba, I think they mostly pollute the UI which is why they were removed.\r\n* There are now a explicit labels for the sentence (`Sentence {number} - belongs to {user}`), the translations (`Translations`) and the indirect translations (`Translations of translations`). Hopefully users will understand better why some translations are in grey.\r\n* Users no longer navigate to the sentence by clicking on the `#` or arrow icons, but on the info icon that is at the end of each sentence/translation.\r\n* An arrow icon has been added in front of each translation in order to help distinguish between direct and indirect translations when there are a lot of translations. Direct translations have a black arrow. Indirect translations have a grey arrow.\r\n* The text of the indirect translations are kept in black for better readability. There is now a label that says explicitly \"Translations of translations\", so there is less need to have it grey.\r\n* Unapproved sentences are displayed the same as before (grey + warning icon), with a tooltip that says `This sentence is not reliable.` when hovering over the sentence. I'm not very satisfied with this tooltip text, but I'd like to find something else than \"unapproved\".\r\n* The language icon is kept on the left side. We cannot have it on the right side because the language icon is a pillar in the structure of the sentences. It helps users find more easily the translations in the lanugages they are more specifically interested. And for sentences that have several translations in a same language, it helps users identify more quickly which blocks of translations are in which language.\r\n* The sentence in the comments will be re-adapted later on to be consistent with the new sentence design. It's not in the scope of this pull request.\r\n\r\nAuthenticated users still have by default the old design, but can activate the new one from their settings if they wish to try to it out. Some pages will still keep the old design no matter what the setting is:\r\n\r\n* The random sentence on the homepage for authenticated users, because the feature to load another random sentence doesn't work yet with the new design. Non-authenticated users have the new design of the random sentence, but do not have the reload option.\r\n* The sentence details page, because the new sentence design does not have the sentence menu (translate, edit, etc), and users should still have access to a page where they can access every sentence feature without switching back and forth between old and new design. Also, the audio icon was not re-added (yet?) in the new design, so the sentence details would allow to listen to the audio of a specific sentence.\r\n\r\nThe new design is notably faster to render than the old one. For instance someone who has their settings set to 100 sentences per page will have some noticeable lag while searching sentences (the page will stay grey for a few seconds, or even freeze). The new design doesn't have this lag. So for users who mostly browse Tatoeba and use the sentence menu only punctually, it can be more advantageous to switch to the new design.\r\n\r\nThe features of the sentence menu will be introduced into the new design progressively. This will probably take until end of December. Once every feature has been implemented in the new design, the old design will be removed for everyone.","created_at":"2016-10-13T08:12:21Z","updated_at":"2016-10-13T08:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Tatoeba/tatoeba2/milestones/121","html_url":"https://github.com/Tatoeba/tatoeba2/milestones/2016-10-15","labels_url":"https://api.github.com/repos/Tatoeba/tatoeba2/milestones/121/labels","id":2057766,"number":121,"title":"2016-10-15","description":"","creator":{"login":"trang","id":221850,"avatar_url":"https://avatars.githubusercontent.com/u/221850?v=3","gravatar_id":"","url":"https://api.github.com/users/trang","html_url":"https://github.com/trang","followers_url":"https://api.github.com/users/trang/followers","following_url":"https://api.github.com/users/trang/following{/other_user}","gists_url":"https://api.github.com/users/trang/gists{/gist_id}","starred_url":"https://api.github.com/users/trang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trang/subscriptions","organizations_url":"https://api.github.com/users/trang/orgs","repos_url":"https://api.github.com/users/trang/repos","events_url":"https://api.github.com/users/trang/events{/privacy}","received_events_url":"https://api.github.com/users/trang/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2016-10-09T20:32:11Z","updated_at":"2016-10-13T08:12:21Z","due_on":"2016-10-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339/commits","review_comments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339/comments","review_comment_url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/1339/comments","statuses_url":"https://api.github.com/repos/Tatoeba/tatoeba2/statuses/b52f88d208a5bff719c49c8569f45a034846be68","head":{"label":"Tatoeba:issue-1180-sentences","ref":"issue-1180-sentences","sha":"b52f88d208a5bff719c49c8569f45a034846be68","user":{"login":"Tatoeba","id":2680657,"avatar_url":"https://avatars.githubusercontent.com/u/2680657?v=3","gravatar_id":"","url":"https://api.github.com/users/Tatoeba","html_url":"https://github.com/Tatoeba","followers_url":"https://api.github.com/users/Tatoeba/followers","following_url":"https://api.github.com/users/Tatoeba/following{/other_user}","gists_url":"https://api.github.com/users/Tatoeba/gists{/gist_id}","starred_url":"https://api.github.com/users/Tatoeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tatoeba/subscriptions","organizations_url":"https://api.github.com/users/Tatoeba/orgs","repos_url":"https://api.github.com/users/Tatoeba/repos","events_url":"https://api.github.com/users/Tatoeba/events{/privacy}","received_events_url":"https://api.github.com/users/Tatoeba/received_events","type":"Organization","site_admin":false},"repo":{"id":16910705,"name":"tatoeba2","full_name":"Tatoeba/tatoeba2","owner":{"login":"Tatoeba","id":2680657,"avatar_url":"https://avatars.githubusercontent.com/u/2680657?v=3","gravatar_id":"","url":"https://api.github.com/users/Tatoeba","html_url":"https://github.com/Tatoeba","followers_url":"https://api.github.com/users/Tatoeba/followers","following_url":"https://api.github.com/users/Tatoeba/following{/other_user}","gists_url":"https://api.github.com/users/Tatoeba/gists{/gist_id}","starred_url":"https://api.github.com/users/Tatoeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tatoeba/subscriptions","organizations_url":"https://api.github.com/users/Tatoeba/orgs","repos_url":"https://api.github.com/users/Tatoeba/repos","events_url":"https://api.github.com/users/Tatoeba/events{/privacy}","received_events_url":"https://api.github.com/users/Tatoeba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tatoeba/tatoeba2","description":"Official repository for main codebase for Tatoeba, a multilingual sentence/translation database.","fork":false,"url":"https://api.github.com/repos/Tatoeba/tatoeba2","forks_url":"https://api.github.com/repos/Tatoeba/tatoeba2/forks","keys_url":"https://api.github.com/repos/Tatoeba/tatoeba2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tatoeba/tatoeba2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tatoeba/tatoeba2/teams","hooks_url":"https://api.github.com/repos/Tatoeba/tatoeba2/hooks","issue_events_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/events{/number}","events_url":"https://api.github.com/repos/Tatoeba/tatoeba2/events","assignees_url":"https://api.github.com/repos/Tatoeba/tatoeba2/assignees{/user}","branches_url":"https://api.github.com/repos/Tatoeba/tatoeba2/branches{/branch}","tags_url":"https://api.github.com/repos/Tatoeba/tatoeba2/tags","blobs_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tatoeba/tatoeba2/statuses/{sha}","languages_url":"https://api.github.com/repos/Tatoeba/tatoeba2/languages","stargazers_url":"https://api.github.com/repos/Tatoeba/tatoeba2/stargazers","contributors_url":"https://api.github.com/repos/Tatoeba/tatoeba2/contributors","subscribers_url":"https://api.github.com/repos/Tatoeba/tatoeba2/subscribers","subscription_url":"https://api.github.com/repos/Tatoeba/tatoeba2/subscription","commits_url":"https://api.github.com/repos/Tatoeba/tatoeba2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tatoeba/tatoeba2/contents/{+path}","compare_url":"https://api.github.com/repos/Tatoeba/tatoeba2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tatoeba/tatoeba2/merges","archive_url":"https://api.github.com/repos/Tatoeba/tatoeba2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tatoeba/tatoeba2/downloads","issues_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues{/number}","pulls_url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls{/number}","milestones_url":"https://api.github.com/repos/Tatoeba/tatoeba2/milestones{/number}","notifications_url":"https://api.github.com/repos/Tatoeba/tatoeba2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tatoeba/tatoeba2/labels{/name}","releases_url":"https://api.github.com/repos/Tatoeba/tatoeba2/releases{/id}","deployments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/deployments","created_at":"2014-02-17T11:25:16Z","updated_at":"2016-09-21T06:44:57Z","pushed_at":"2016-10-13T08:12:21Z","git_url":"git://github.com/Tatoeba/tatoeba2.git","ssh_url":"git@github.com:Tatoeba/tatoeba2.git","clone_url":"https://github.com/Tatoeba/tatoeba2.git","svn_url":"https://github.com/Tatoeba/tatoeba2","homepage":"https://tatoeba.org","size":98192,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":235,"forks":45,"open_issues":235,"watchers":86,"default_branch":"dev"}},"base":{"label":"Tatoeba:dev","ref":"dev","sha":"5edbe2b2b95fd944504beeff4d97cec45fcb0203","user":{"login":"Tatoeba","id":2680657,"avatar_url":"https://avatars.githubusercontent.com/u/2680657?v=3","gravatar_id":"","url":"https://api.github.com/users/Tatoeba","html_url":"https://github.com/Tatoeba","followers_url":"https://api.github.com/users/Tatoeba/followers","following_url":"https://api.github.com/users/Tatoeba/following{/other_user}","gists_url":"https://api.github.com/users/Tatoeba/gists{/gist_id}","starred_url":"https://api.github.com/users/Tatoeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tatoeba/subscriptions","organizations_url":"https://api.github.com/users/Tatoeba/orgs","repos_url":"https://api.github.com/users/Tatoeba/repos","events_url":"https://api.github.com/users/Tatoeba/events{/privacy}","received_events_url":"https://api.github.com/users/Tatoeba/received_events","type":"Organization","site_admin":false},"repo":{"id":16910705,"name":"tatoeba2","full_name":"Tatoeba/tatoeba2","owner":{"login":"Tatoeba","id":2680657,"avatar_url":"https://avatars.githubusercontent.com/u/2680657?v=3","gravatar_id":"","url":"https://api.github.com/users/Tatoeba","html_url":"https://github.com/Tatoeba","followers_url":"https://api.github.com/users/Tatoeba/followers","following_url":"https://api.github.com/users/Tatoeba/following{/other_user}","gists_url":"https://api.github.com/users/Tatoeba/gists{/gist_id}","starred_url":"https://api.github.com/users/Tatoeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tatoeba/subscriptions","organizations_url":"https://api.github.com/users/Tatoeba/orgs","repos_url":"https://api.github.com/users/Tatoeba/repos","events_url":"https://api.github.com/users/Tatoeba/events{/privacy}","received_events_url":"https://api.github.com/users/Tatoeba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tatoeba/tatoeba2","description":"Official repository for main codebase for Tatoeba, a multilingual sentence/translation database.","fork":false,"url":"https://api.github.com/repos/Tatoeba/tatoeba2","forks_url":"https://api.github.com/repos/Tatoeba/tatoeba2/forks","keys_url":"https://api.github.com/repos/Tatoeba/tatoeba2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tatoeba/tatoeba2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tatoeba/tatoeba2/teams","hooks_url":"https://api.github.com/repos/Tatoeba/tatoeba2/hooks","issue_events_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/events{/number}","events_url":"https://api.github.com/repos/Tatoeba/tatoeba2/events","assignees_url":"https://api.github.com/repos/Tatoeba/tatoeba2/assignees{/user}","branches_url":"https://api.github.com/repos/Tatoeba/tatoeba2/branches{/branch}","tags_url":"https://api.github.com/repos/Tatoeba/tatoeba2/tags","blobs_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tatoeba/tatoeba2/statuses/{sha}","languages_url":"https://api.github.com/repos/Tatoeba/tatoeba2/languages","stargazers_url":"https://api.github.com/repos/Tatoeba/tatoeba2/stargazers","contributors_url":"https://api.github.com/repos/Tatoeba/tatoeba2/contributors","subscribers_url":"https://api.github.com/repos/Tatoeba/tatoeba2/subscribers","subscription_url":"https://api.github.com/repos/Tatoeba/tatoeba2/subscription","commits_url":"https://api.github.com/repos/Tatoeba/tatoeba2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tatoeba/tatoeba2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tatoeba/tatoeba2/contents/{+path}","compare_url":"https://api.github.com/repos/Tatoeba/tatoeba2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tatoeba/tatoeba2/merges","archive_url":"https://api.github.com/repos/Tatoeba/tatoeba2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tatoeba/tatoeba2/downloads","issues_url":"https://api.github.com/repos/Tatoeba/tatoeba2/issues{/number}","pulls_url":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls{/number}","milestones_url":"https://api.github.com/repos/Tatoeba/tatoeba2/milestones{/number}","notifications_url":"https://api.github.com/repos/Tatoeba/tatoeba2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tatoeba/tatoeba2/labels{/name}","releases_url":"https://api.github.com/repos/Tatoeba/tatoeba2/releases{/id}","deployments_url":"https://api.github.com/repos/Tatoeba/tatoeba2/deployments","created_at":"2014-02-17T11:25:16Z","updated_at":"2016-09-21T06:44:57Z","pushed_at":"2016-10-13T08:12:21Z","git_url":"git://github.com/Tatoeba/tatoeba2.git","ssh_url":"git@github.com:Tatoeba/tatoeba2.git","clone_url":"https://github.com/Tatoeba/tatoeba2.git","svn_url":"https://github.com/Tatoeba/tatoeba2","homepage":"https://tatoeba.org","size":98192,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":235,"forks":45,"open_issues":235,"watchers":86,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339"},"html":{"href":"https://github.com/Tatoeba/tatoeba2/pull/1339"},"issue":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/1339"},"comments":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/issues/1339/comments"},"review_comments":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339/comments"},"review_comment":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/pulls/1339/commits"},"statuses":{"href":"https://api.github.com/repos/Tatoeba/tatoeba2/statuses/b52f88d208a5bff719c49c8569f45a034846be68"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":493,"deletions":75,"changed_files":21}}
{"actor":{"display_login":"trang"}}