{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/helios/issues/922","repository_url":"https://api.github.com/repos/spotify/helios","labels_url":"https://api.github.com/repos/spotify/helios/issues/922/labels{/name}","comments_url":"https://api.github.com/repos/spotify/helios/issues/922/comments","events_url":"https://api.github.com/repos/spotify/helios/issues/922/events","html_url":"https://github.com/spotify/helios/pull/922","id":155740783,"number":922,"title":"WIP: helios-testing: refactor with breaking changes","user":{"login":"davidxia","id":480621,"avatar_url":"https://avatars.githubusercontent.com/u/480621?v=3","gravatar_id":"","url":"https://api.github.com/users/davidxia","html_url":"https://github.com/davidxia","followers_url":"https://api.github.com/users/davidxia/followers","following_url":"https://api.github.com/users/davidxia/following{/other_user}","gists_url":"https://api.github.com/users/davidxia/gists{/gist_id}","starred_url":"https://api.github.com/users/davidxia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidxia/subscriptions","organizations_url":"https://api.github.com/users/davidxia/orgs","repos_url":"https://api.github.com/users/davidxia/repos","events_url":"https://api.github.com/users/davidxia/events{/privacy}","received_events_url":"https://api.github.com/users/davidxia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-19T13:46:55Z","updated_at":"2016-05-26T19:42:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/helios/pulls/922","html_url":"https://github.com/spotify/helios/pull/922","diff_url":"https://github.com/spotify/helios/pull/922.diff","patch_url":"https://github.com/spotify/helios/pull/922.patch"},"body":"This PR makes the following changes in order:\r\n\r\n* Make `TemporaryJobs` instead of the user manage `HeliosSoloDeployment`\r\n* Make `HeliosSoloDeployment` package local\r\n* Make helios-solo container have logic to clean up and kill itself to prevent leaked containers even when `TemporaryJobs` is SIGKILLed\r\n* one `HeliosSoloDeployment` per JVM process per test run\r\n\r\nTODOs:\r\n* split TemporaryJobs into two classes - one that implements AutoCloseable and another that implements JUnit's Rule\r\n* delete other stuff?"},"comment":{"url":"https://api.github.com/repos/spotify/helios/issues/comments/221973506","html_url":"https://github.com/spotify/helios/pull/922#issuecomment-221973506","issue_url":"https://api.github.com/repos/spotify/helios/issues/922","id":221973506,"user":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T19:42:43Z","updated_at":"2016-05-26T19:42:43Z","body":"`docs/integration_tests_with_helios_solo.md` and probably `docs/testing_framework.md` should be updated as they are outdated now"}}
{"actor":{"display_login":"mattnworb"}}