{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/2726","repository_url":"https://api.github.com/repos/uProxy/uproxy","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/2726/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/2726/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/2726/events","html_url":"https://github.com/uProxy/uproxy/pull/2726","id":173532675,"number":2726,"title":"Add activity metrics to uProxy client","user":{"login":"dborkan","id":6494307,"avatar_url":"https://avatars.githubusercontent.com/u/6494307?v=3","gravatar_id":"","url":"https://api.github.com/users/dborkan","html_url":"https://github.com/dborkan","followers_url":"https://api.github.com/users/dborkan/followers","following_url":"https://api.github.com/users/dborkan/following{/other_user}","gists_url":"https://api.github.com/users/dborkan/gists{/gist_id}","starred_url":"https://api.github.com/users/dborkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dborkan/subscriptions","organizations_url":"https://api.github.com/users/dborkan/orgs","repos_url":"https://api.github.com/users/dborkan/repos","events_url":"https://api.github.com/users/dborkan/events{/privacy}","received_events_url":"https://api.github.com/users/dborkan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"assignees":[{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-08-26T20:04:56Z","updated_at":"2016-09-19T23:02:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/2726","html_url":"https://github.com/uProxy/uproxy/pull/2726","diff_url":"https://github.com/uProxy/uproxy/pull/2726.diff","patch_url":"https://github.com/uProxy/uproxy/pull/2726.patch"},"body":"* Added activity metrics to uProxy client.  Now once a user begins getting access, if they have metrics enabled they will make a post with the current date+country and previous date+country (if they have proxied before).  Since we don't have country lookup implemented yet, country is hardcoded to 'ZZ' (unknown) for now.\r\n* If activity metrics fail to post, they are written to storage, and will be attempted to post the next time the user gets access.\r\n* Renamed old metrics / metrics_module to rapporMetrics / rappor_metrics to distinguish it from the new activity metrics.\r\n* I have not yet created tests, but have tested manually.  I will created unit tests once I get an OK on this basic design (unit tests to mock out XHRs are kind of a pain, so I want to make sure this is the basic design we will be using before I spent too much time on them).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/2726)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/248154130","html_url":"https://github.com/uProxy/uproxy/pull/2726#issuecomment-248154130","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/2726","id":248154130,"user":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T23:02:40Z","updated_at":"2016-09-19T23:02:40Z","body":":thumbsup:\n\n---\n\nReviewed 2 of 2 files at r5.\nReview status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/uproxy/uproxy/2726#-:-KS3fxT4bMSjIGeMdK_8:bn1wz0t)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"fortuna"}}