{"action":"created","issue":{"url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/4","repository_url":"https://api.github.com/repos/UCDenver-ccp/kabob","labels_url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/4/comments","events_url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/4/events","html_url":"https://github.com/UCDenver-ccp/kabob/pull/4","id":134945730,"number":4,"title":"don't swallow rule errors","user":{"login":"sinistral","id":388984,"avatar_url":"https://avatars.githubusercontent.com/u/388984?v=3","gravatar_id":"","url":"https://api.github.com/users/sinistral","html_url":"https://github.com/sinistral","followers_url":"https://api.github.com/users/sinistral/followers","following_url":"https://api.github.com/users/sinistral/following{/other_user}","gists_url":"https://api.github.com/users/sinistral/gists{/gist_id}","starred_url":"https://api.github.com/users/sinistral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinistral/subscriptions","organizations_url":"https://api.github.com/users/sinistral/orgs","repos_url":"https://api.github.com/users/sinistral/repos","events_url":"https://api.github.com/users/sinistral/events{/privacy}","received_events_url":"https://api.github.com/users/sinistral/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ekwhite","id":2439557,"avatar_url":"https://avatars.githubusercontent.com/u/2439557?v=3","gravatar_id":"","url":"https://api.github.com/users/ekwhite","html_url":"https://github.com/ekwhite","followers_url":"https://api.github.com/users/ekwhite/followers","following_url":"https://api.github.com/users/ekwhite/following{/other_user}","gists_url":"https://api.github.com/users/ekwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/ekwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekwhite/subscriptions","organizations_url":"https://api.github.com/users/ekwhite/orgs","repos_url":"https://api.github.com/users/ekwhite/repos","events_url":"https://api.github.com/users/ekwhite/events{/privacy}","received_events_url":"https://api.github.com/users/ekwhite/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-19T18:53:43Z","updated_at":"2016-04-12T20:53:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UCDenver-ccp/kabob/pulls/4","html_url":"https://github.com/UCDenver-ccp/kabob/pull/4","diff_url":"https://github.com/UCDenver-ccp/kabob/pull/4.diff","patch_url":"https://github.com/UCDenver-ccp/kabob/pull/4.patch"},"body":"Much of what you see in this pull request is cleanup and reformatting.  The commits for these are separate from the one that introduces the functional change, and I'd be happy to submit a separate pull request for the reformatting if that is preferable.  \r\n\r\nThe [last commit](https://github.com/UCDenver-ccp/kabob/commit/6b9f62d1110340619e9677c0bd4e7693320ad9f0) in the series is what actually introduces the functional change.  It simply removes the catch clause and allows any exception raised while processing rules to bubble up to the top level.\r\n\r\nIt looks there was, at some point, an intent to process the rules in parallel, collect the results, and (I presume) at that point raise an error if any of the rules was not run successfully.  As the number of rules increases, parallel execution becomes more attractive, and then properly collecting and handling the errors will be important.  But for now, I think it's more important to simply fail outright if the rules could not be applied cleanly."},"comment":{"url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/comments/209097796","html_url":"https://github.com/UCDenver-ccp/kabob/pull/4#issuecomment-209097796","issue_url":"https://api.github.com/repos/UCDenver-ccp/kabob/issues/4","id":209097796,"user":{"login":"sinistral","id":388984,"avatar_url":"https://avatars.githubusercontent.com/u/388984?v=3","gravatar_id":"","url":"https://api.github.com/users/sinistral","html_url":"https://github.com/sinistral","followers_url":"https://api.github.com/users/sinistral/followers","following_url":"https://api.github.com/users/sinistral/following{/other_user}","gists_url":"https://api.github.com/users/sinistral/gists{/gist_id}","starred_url":"https://api.github.com/users/sinistral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinistral/subscriptions","organizations_url":"https://api.github.com/users/sinistral/orgs","repos_url":"https://api.github.com/users/sinistral/repos","events_url":"https://api.github.com/users/sinistral/events{/privacy}","received_events_url":"https://api.github.com/users/sinistral/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T20:53:46Z","updated_at":"2016-04-12T20:53:46Z","body":"Are there any outstanding concerns with this request?"}}