{"action":"closed","issue":{"url":"https://api.github.com/repos/grs/rhea/issues/17","repository_url":"https://api.github.com/repos/grs/rhea","labels_url":"https://api.github.com/repos/grs/rhea/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/grs/rhea/issues/17/comments","events_url":"https://api.github.com/repos/grs/rhea/issues/17/events","html_url":"https://github.com/grs/rhea/issues/17","id":185527482,"number":17,"title":"Don't log to stdout from library code","user":{"login":"ssorj","id":1463232,"avatar_url":"https://avatars.githubusercontent.com/u/1463232?v=3","gravatar_id":"","url":"https://api.github.com/users/ssorj","html_url":"https://github.com/ssorj","followers_url":"https://api.github.com/users/ssorj/followers","following_url":"https://api.github.com/users/ssorj/following{/other_user}","gists_url":"https://api.github.com/users/ssorj/gists{/gist_id}","starred_url":"https://api.github.com/users/ssorj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssorj/subscriptions","organizations_url":"https://api.github.com/users/ssorj/orgs","repos_url":"https://api.github.com/users/ssorj/repos","events_url":"https://api.github.com/users/ssorj/events{/privacy}","received_events_url":"https://api.github.com/users/ssorj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-26T22:29:38Z","updated_at":"2016-10-28T19:01:38Z","closed_at":"2016-10-28T19:01:38Z","body":"My use of rhea depends on uniform application output to stdout, and things such as connection errors on stdout pose a problem.\r\n\r\n[jross@localhost quiver (master)]$ fgrep -r \"console.log\" javascript/node_modules/rhea/lib\r\njavascript/node_modules/rhea/lib/terminus.js:            console.log('Unknown terminus: ' + field.descriptor);\r\njavascript/node_modules/rhea/lib/ws.js:                console.log('ERROR: Attempt to set unrecognised handler on websocket wrapper: ' + event);\r\njavascript/node_modules/rhea/lib/connection.js:    console.log('[' + this.options.id + '] error: ' + e);\r\njavascript/node_modules/rhea/lib/connection.js:            console.log('[' + this.options.id + '] disconnected');\r\njavascript/node_modules/rhea/lib/session.js:            console.log('ERROR: Next pending delivery not found: ' + this.next_pending_delivery);\r\njavascript/node_modules/rhea/lib/rpc.js:        console.log('no request pending for ' + id + ', ignoring response');\r\njavascript/node_modules/rhea/lib/link.js:        if (frame.performative.link_credit > 0) console.log('ERROR: received flow with drain set, but non zero credit');\r\njavascript/node_modules/rhea/lib/message.js:                console.log(\"WARNING: did not recognise message section with descriptor \" + s.descriptor);\r\njavascript/node_modules/rhea/lib/message.js:            console.log(\"WARNING: expected described message section got \" + JSON.stringify(s));\r\njavascript/node_modules/rhea/lib/message.js:    console.log('unrecognised outcome: ' + JSON.stringify(outcome));\r\n"}}
{"actor":{"display_login":"grs"}}