{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1580","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1580/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1580/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1580/events","html_url":"https://github.com/solidusio/solidus/pull/1580","id":188090709,"number":1580,"title":"Allow users to inline update the variant of an image in admin","user":{"login":"mtomov","id":1651750,"avatar_url":"https://avatars.githubusercontent.com/u/1651750?v=3","gravatar_id":"","url":"https://api.github.com/users/mtomov","html_url":"https://github.com/mtomov","followers_url":"https://api.github.com/users/mtomov/followers","following_url":"https://api.github.com/users/mtomov/following{/other_user}","gists_url":"https://api.github.com/users/mtomov/gists{/gist_id}","starred_url":"https://api.github.com/users/mtomov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtomov/subscriptions","organizations_url":"https://api.github.com/users/mtomov/orgs","repos_url":"https://api.github.com/users/mtomov/repos","events_url":"https://api.github.com/users/mtomov/events{/privacy}","received_events_url":"https://api.github.com/users/mtomov/received_events","type":"User","site_admin":false},"labels":[{"id":307903810,"url":"https://api.github.com/repos/solidusio/solidus/labels/admin","name":"admin","color":"c7def8","default":false},{"id":178438458,"url":"https://api.github.com/repos/solidusio/solidus/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-08T20:07:59Z","updated_at":"2016-12-01T23:22:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1580","html_url":"https://github.com/solidusio/solidus/pull/1580","diff_url":"https://github.com/solidusio/solidus/pull/1580.diff","patch_url":"https://github.com/solidusio/solidus/pull/1580.patch"},"body":"This should allow users to update the variant of an image directly within the admin images table.\r\n\r\nI have pretty much copy/pasted the code from the [`payments/edit`](https://github.com/solidusio/solidus/blob/94f630fd4ca31f52a8ed72956db0259668144796/backend/app/assets/javascripts/spree/backend/payments/edit.js.coffee) class, so thanks @jhawthorn for that! Indeed a great learner on syncing Backbone's models with the backend.\r\n\r\nNot sure about the dotted underline below the small icons .. maybe I can remove that, but couldn't find an appropriate class for the purpose.\r\n\r\n![inline image variant update](https://cloud.githubusercontent.com/assets/1651750/20114918/2e52ed4c-a5ee-11e6-9c1b-f9c25988de6c.png)\r\n"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/264326708","html_url":"https://github.com/solidusio/solidus/pull/1580#issuecomment-264326708","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1580","id":264326708,"user":{"login":"mtomov","id":1651750,"avatar_url":"https://avatars.githubusercontent.com/u/1651750?v=3","gravatar_id":"","url":"https://api.github.com/users/mtomov","html_url":"https://github.com/mtomov","followers_url":"https://api.github.com/users/mtomov/followers","following_url":"https://api.github.com/users/mtomov/following{/other_user}","gists_url":"https://api.github.com/users/mtomov/gists{/gist_id}","starred_url":"https://api.github.com/users/mtomov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtomov/subscriptions","organizations_url":"https://api.github.com/users/mtomov/orgs","repos_url":"https://api.github.com/users/mtomov/repos","events_url":"https://api.github.com/users/mtomov/events{/privacy}","received_events_url":"https://api.github.com/users/mtomov/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T23:22:52Z","updated_at":"2016-12-01T23:22:52Z","body":"Amanda, the hover suggestion was brilliant, did it, wasn't difficult at all actually, hopefully can also be used by other similar in-table editing functionalities.  \r\n\r\nWith the hover, it's quite incredible how quickly one could change the variant on a whole bunch of images. \r\n\r\n- e86a884 was the actual commit with the change \r\n\r\n\r\n\r\n#### on hover\r\n![screenshot from 2016-12-01 23 07 37](https://cloud.githubusercontent.com/assets/1651750/20816870/6de52386-b81c-11e6-91ae-b6cf1620d17d.png)\r\n\r\n#### on click\r\n![screenshot from 2016-12-01 23 07 47](https://cloud.githubusercontent.com/assets/1651750/20816871/6de5d1b4-b81c-11e6-963a-ccdb3a022724.png)\r\n\r\n.. finally the user needs to click on the check icon to confirm the change\r\n\r\n"}}
{"actor":{"display_login":"mtomov"}}