{"action":"created","comment":{"url":"https://api.github.com/repos/Unidata/thredds/pulls/comments/54795127","id":54795127,"diff_hunk":"@@ -136,6 +142,18 @@ private Service findService(List<Service> services, String want)  {\n     return null;\n   }\n \n+  private Service findService(List<Service> services, ServiceType type)  {","path":"cdm/src/main/java/thredds/client/catalog/Catalog.java","position":17,"original_position":17,"commit_id":"4b8c9cdce4de85705d3d7c29fe7173a22f577f4b","original_commit_id":"4b8c9cdce4de85705d3d7c29fe7173a22f577f4b","user":{"login":"JohnLCaron","id":613568,"avatar_url":"https://avatars.githubusercontent.com/u/613568?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLCaron","html_url":"https://github.com/JohnLCaron","followers_url":"https://api.github.com/users/JohnLCaron/followers","following_url":"https://api.github.com/users/JohnLCaron/following{/other_user}","gists_url":"https://api.github.com/users/JohnLCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLCaron/subscriptions","organizations_url":"https://api.github.com/users/JohnLCaron/orgs","repos_url":"https://api.github.com/users/JohnLCaron/repos","events_url":"https://api.github.com/users/JohnLCaron/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLCaron/received_events","type":"User","site_admin":false},"body":"hmmm, dont remember those...\n\nOn Wed, Mar 2, 2016 at 2:28 PM, Ryan May <notifications@github.com> wrote:\n\n> In cdm/src/main/java/thredds/client/catalog/Catalog.java\n> <https://github.com/Unidata/thredds/pull/461#discussion_r54794514>:\n>\n> > @@ -136,6 +142,18 @@ private Service findService(List<Service> services, String want)  {\n> >      return null;\n> >    }\n> >\n> > +  private Service findService(List<Service> services, ServiceType type)  {\n>\n> I only ask because I know we had quite a few Coverity issues like this. I\n> don't have a stake in it, other than to prevent the Coverity # going up.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Unidata/thredds/pull/461/files#r54794514>.\n>\n","created_at":"2016-03-02T21:32:42Z","updated_at":"2016-03-02T21:32:42Z","html_url":"https://github.com/Unidata/thredds/pull/461#discussion_r54795127","pull_request_url":"https://api.github.com/repos/Unidata/thredds/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/comments/54795127"},"html":{"href":"https://github.com/Unidata/thredds/pull/461#discussion_r54795127"},"pull_request":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/Unidata/thredds/pulls/461","id":61437250,"html_url":"https://github.com/Unidata/thredds/pull/461","diff_url":"https://github.com/Unidata/thredds/pull/461.diff","patch_url":"https://github.com/Unidata/thredds/pull/461.patch","issue_url":"https://api.github.com/repos/Unidata/thredds/issues/461","number":461,"state":"open","locked":false,"title":"5.0.0 unit test fixes","user":{"login":"JohnLCaron","id":613568,"avatar_url":"https://avatars.githubusercontent.com/u/613568?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLCaron","html_url":"https://github.com/JohnLCaron","followers_url":"https://api.github.com/users/JohnLCaron/followers","following_url":"https://api.github.com/users/JohnLCaron/following{/other_user}","gists_url":"https://api.github.com/users/JohnLCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLCaron/subscriptions","organizations_url":"https://api.github.com/users/JohnLCaron/orgs","repos_url":"https://api.github.com/users/JohnLCaron/repos","events_url":"https://api.github.com/users/JohnLCaron/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLCaron/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-02T17:36:25Z","updated_at":"2016-03-02T21:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d354ed44fcc1f87a4bb6d8e52ae290c7ea635474","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Unidata/thredds/pulls/461/commits","review_comments_url":"https://api.github.com/repos/Unidata/thredds/pulls/461/comments","review_comment_url":"https://api.github.com/repos/Unidata/thredds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unidata/thredds/issues/461/comments","statuses_url":"https://api.github.com/repos/Unidata/thredds/statuses/4b8c9cdce4de85705d3d7c29fe7173a22f577f4b","head":{"label":"JohnLCaron:5.0.0","ref":"5.0.0","sha":"4b8c9cdce4de85705d3d7c29fe7173a22f577f4b","user":{"login":"JohnLCaron","id":613568,"avatar_url":"https://avatars.githubusercontent.com/u/613568?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLCaron","html_url":"https://github.com/JohnLCaron","followers_url":"https://api.github.com/users/JohnLCaron/followers","following_url":"https://api.github.com/users/JohnLCaron/following{/other_user}","gists_url":"https://api.github.com/users/JohnLCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLCaron/subscriptions","organizations_url":"https://api.github.com/users/JohnLCaron/orgs","repos_url":"https://api.github.com/users/JohnLCaron/repos","events_url":"https://api.github.com/users/JohnLCaron/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLCaron/received_events","type":"User","site_admin":false},"repo":{"id":10650181,"name":"thredds","full_name":"JohnLCaron/thredds","owner":{"login":"JohnLCaron","id":613568,"avatar_url":"https://avatars.githubusercontent.com/u/613568?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLCaron","html_url":"https://github.com/JohnLCaron","followers_url":"https://api.github.com/users/JohnLCaron/followers","following_url":"https://api.github.com/users/JohnLCaron/following{/other_user}","gists_url":"https://api.github.com/users/JohnLCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLCaron/subscriptions","organizations_url":"https://api.github.com/users/JohnLCaron/orgs","repos_url":"https://api.github.com/users/JohnLCaron/repos","events_url":"https://api.github.com/users/JohnLCaron/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLCaron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnLCaron/thredds","description":"Thredds and netCDF-Java (CDM)","fork":true,"url":"https://api.github.com/repos/JohnLCaron/thredds","forks_url":"https://api.github.com/repos/JohnLCaron/thredds/forks","keys_url":"https://api.github.com/repos/JohnLCaron/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnLCaron/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnLCaron/thredds/teams","hooks_url":"https://api.github.com/repos/JohnLCaron/thredds/hooks","issue_events_url":"https://api.github.com/repos/JohnLCaron/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/JohnLCaron/thredds/events","assignees_url":"https://api.github.com/repos/JohnLCaron/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/JohnLCaron/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/JohnLCaron/thredds/tags","blobs_url":"https://api.github.com/repos/JohnLCaron/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnLCaron/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnLCaron/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnLCaron/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnLCaron/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnLCaron/thredds/languages","stargazers_url":"https://api.github.com/repos/JohnLCaron/thredds/stargazers","contributors_url":"https://api.github.com/repos/JohnLCaron/thredds/contributors","subscribers_url":"https://api.github.com/repos/JohnLCaron/thredds/subscribers","subscription_url":"https://api.github.com/repos/JohnLCaron/thredds/subscription","commits_url":"https://api.github.com/repos/JohnLCaron/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnLCaron/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnLCaron/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnLCaron/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnLCaron/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/JohnLCaron/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnLCaron/thredds/merges","archive_url":"https://api.github.com/repos/JohnLCaron/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnLCaron/thredds/downloads","issues_url":"https://api.github.com/repos/JohnLCaron/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/JohnLCaron/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnLCaron/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnLCaron/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnLCaron/thredds/labels{/name}","releases_url":"https://api.github.com/repos/JohnLCaron/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/JohnLCaron/thredds/deployments","created_at":"2013-06-12T19:21:49Z","updated_at":"2015-08-18T20:15:56Z","pushed_at":"2016-03-02T17:35:24Z","git_url":"git://github.com/JohnLCaron/thredds.git","ssh_url":"git@github.com:JohnLCaron/thredds.git","clone_url":"https://github.com/JohnLCaron/thredds.git","svn_url":"https://github.com/JohnLCaron/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":883440,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unidata:5.0.0","ref":"5.0.0","sha":"292601851f6cf57ce4beeb7e4e844e721cc3245c","user":{"login":"Unidata","id":613345,"avatar_url":"https://avatars.githubusercontent.com/u/613345?v=3","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"repo":{"id":2138392,"name":"thredds","full_name":"Unidata/thredds","owner":{"login":"Unidata","id":613345,"avatar_url":"https://avatars.githubusercontent.com/u/613345?v=3","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unidata/thredds","description":"Thredds and netCDF-Java (CDM)","fork":false,"url":"https://api.github.com/repos/Unidata/thredds","forks_url":"https://api.github.com/repos/Unidata/thredds/forks","keys_url":"https://api.github.com/repos/Unidata/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unidata/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unidata/thredds/teams","hooks_url":"https://api.github.com/repos/Unidata/thredds/hooks","issue_events_url":"https://api.github.com/repos/Unidata/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/Unidata/thredds/events","assignees_url":"https://api.github.com/repos/Unidata/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/Unidata/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/Unidata/thredds/tags","blobs_url":"https://api.github.com/repos/Unidata/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unidata/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unidata/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unidata/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unidata/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/Unidata/thredds/languages","stargazers_url":"https://api.github.com/repos/Unidata/thredds/stargazers","contributors_url":"https://api.github.com/repos/Unidata/thredds/contributors","subscribers_url":"https://api.github.com/repos/Unidata/thredds/subscribers","subscription_url":"https://api.github.com/repos/Unidata/thredds/subscription","commits_url":"https://api.github.com/repos/Unidata/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unidata/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unidata/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unidata/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unidata/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/Unidata/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unidata/thredds/merges","archive_url":"https://api.github.com/repos/Unidata/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unidata/thredds/downloads","issues_url":"https://api.github.com/repos/Unidata/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/Unidata/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/Unidata/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/Unidata/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unidata/thredds/labels{/name}","releases_url":"https://api.github.com/repos/Unidata/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/Unidata/thredds/deployments","created_at":"2011-08-01T18:53:21Z","updated_at":"2016-03-02T07:32:51Z","pushed_at":"2016-03-02T21:03:39Z","git_url":"git://github.com/Unidata/thredds.git","ssh_url":"git@github.com:Unidata/thredds.git","clone_url":"https://github.com/Unidata/thredds.git","svn_url":"https://github.com/Unidata/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":893766,"stargazers_count":103,"watchers_count":103,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":99,"forks":106,"open_issues":99,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/461"},"html":{"href":"https://github.com/Unidata/thredds/pull/461"},"issue":{"href":"https://api.github.com/repos/Unidata/thredds/issues/461"},"comments":{"href":"https://api.github.com/repos/Unidata/thredds/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unidata/thredds/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/Unidata/thredds/statuses/4b8c9cdce4de85705d3d7c29fe7173a22f577f4b"}}}}