{"action":"opened","number":542,"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542","id":90813292,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/542","diff_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/542.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/542.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/542","number":542,"state":"open","locked":false,"title":"[#130358101] Update FrameworkAgreements directly ","user":{"login":"TheDoubleK","id":6525554,"avatar_url":"https://avatars.githubusercontent.com/u/6525554?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDoubleK","html_url":"https://github.com/TheDoubleK","followers_url":"https://api.github.com/users/TheDoubleK/followers","following_url":"https://api.github.com/users/TheDoubleK/following{/other_user}","gists_url":"https://api.github.com/users/TheDoubleK/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDoubleK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDoubleK/subscriptions","organizations_url":"https://api.github.com/users/TheDoubleK/orgs","repos_url":"https://api.github.com/users/TheDoubleK/repos","events_url":"https://api.github.com/users/TheDoubleK/events{/privacy}","received_events_url":"https://api.github.com/users/TheDoubleK/received_events","type":"User","site_admin":false},"body":"For this story: https://www.pivotaltracker.com/story/show/130358101\r\n\r\nThese changes make it so that FrameworkAgreements are updated directly rather than via a SupplierFramework.\r\n\r\nFor pre-G-Cloud-8 frameworks this means making three API calls in a single route (i.e. to  create, add signer details and \"sign\" the agreement).\r\n\r\nFor G-Cloud-8 and beyond the new signing agreement flow now creates a FrameworkAgreement when the new \"Return your signed signature page\" button is first clicked (it's currently a link not a button):\r\n\r\n![screen shot 2016-10-25 at 13 44 54](https://cloud.githubusercontent.com/assets/6525554/19688834/27f3fb3e-9ac3-11e6-9a92-17bbcec46648.png)\r\n\r\nand the ID of the FrameworkAgreement thus created becomes part of the  URL for subsequent pages, allowing the FrameworkAgreement to be updated  directly with first the signer details, then the agreement path (when the  file is uploaded) and finally the \"signed_at\" timestamp is added when the  final \"confirm\" button is clicked.\r\n\r\nThis is the penultimate piece of the puzzle to fix the bug that it was previously  possible for someone to come along and update the signer details for a signed  agreement after it had been countersigned, and without uploading a new document or hitting the \"sign\" button.\r\n\r\nThe risk is mitigated by this new flow (a new draft FrameworkAgreement is created  every time the green button is pressed, and existing ones not updated), but  is still susceptible to users navigating directly to the URL for a specific FrameworkAgreement and updating it.  The final piece of the puzzle to block this altogether will come when this API `TODO` is done (coming v. soon!): https://github.com/alphagov/digitalmarketplace-api/blob/master/app/main/views/agreements.py#L94\r\n\r\nNote, any users in the middle of the \"return a framework agreement\" flow when this is deployed will hit a 404 error page and have to start again.  We discussed with @allait and decided that this is fine as it is highly unlikely anyone will be doing that (as nearly all DOS and G-8 agreements are returned already) and if they are then starting over is no great hardship.","created_at":"2016-10-25T13:58:42Z","updated_at":"2016-10-25T13:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/542/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/f2d14cd807208866f838d825efb6bb10641aaae2","head":{"label":"alphagov:routes-with-fa-ids","ref":"routes-with-fa-ids","sha":"f2d14cd807208866f838d825efb6bb10641aaae2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-10-24T15:23:17Z","pushed_at":"2016-10-25T13:55:33Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":2803,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"7f526f1b3c900e453c7fbad07989764ac4efb294","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-10-24T15:23:17Z","pushed_at":"2016-10-25T13:55:33Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":2803,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/542"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/542"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/f2d14cd807208866f838d825efb6bb10641aaae2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":13,"additions":783,"deletions":425,"changed_files":10}}
{"actor":{"display_login":"TheDoubleK"}}