{"action":"created","comment":{"url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/comments/57600784","id":57600784,"diff_hunk":"@@ -0,0 +1,49 @@\n+# This configuration was generated by\n+# `rubocop --auto-gen-config`\n+# on 2016-03-27 01:01:12 +0100 using RuboCop version 0.38.0.\n+# The point is for the user to remove these configuration records\n+# one by one as the offenses are removed from the code base.\n+# Note that changes in the inspected code, or installation of new\n+# versions of RuboCop, may require this file to be generated again.\n+\n+# I don't have a preference.\n+Lint/Loop:\n+  Enabled: false\n+\n+# I'd rather use context_dependent, even if I'm not even sure we should enforce a style.\n+# SupportedStyles: braces, no_braces, context_dependent\n+Style/BracesAroundHashParameters:\n+  Enabled: false\n+  EnforcedStyle: context_dependent\n+\n+# Offense count: 39\n+Style/Documentation:\n+  Enabled: false\n+  Exclude:\n+    - 'spec/**/*'\n+    - 'test/**/*'\n+\n+# I was a big fan of leading, but after I had some weird compile issues, I reverted\n+# to trailing. Any proposal?\n+# SupportedStyles: leading, trailing","path":".rubocop_todo.yml","position":28,"original_position":28,"commit_id":"b6e226ba68687dbaba708b01dd34493cee83e976","original_commit_id":"b6e226ba68687dbaba708b01dd34493cee83e976","user":{"login":"jacegu","id":381143,"avatar_url":"https://avatars.githubusercontent.com/u/381143?v=3","gravatar_id":"","url":"https://api.github.com/users/jacegu","html_url":"https://github.com/jacegu","followers_url":"https://api.github.com/users/jacegu/followers","following_url":"https://api.github.com/users/jacegu/following{/other_user}","gists_url":"https://api.github.com/users/jacegu/gists{/gist_id}","starred_url":"https://api.github.com/users/jacegu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacegu/subscriptions","organizations_url":"https://api.github.com/users/jacegu/orgs","repos_url":"https://api.github.com/users/jacegu/repos","events_url":"https://api.github.com/users/jacegu/events{/privacy}","received_events_url":"https://api.github.com/users/jacegu/received_events","type":"User","site_admin":false},"body":"I tend to use trailing but have no preference... ","created_at":"2016-03-28T17:30:13Z","updated_at":"2016-03-28T17:30:13Z","html_url":"https://github.com/aetrion/dnsimple-ruby/pull/93#discussion_r57600784","pull_request_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/comments/57600784"},"html":{"href":"https://github.com/aetrion/dnsimple-ruby/pull/93#discussion_r57600784"},"pull_request":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93","id":64271993,"html_url":"https://github.com/aetrion/dnsimple-ruby/pull/93","diff_url":"https://github.com/aetrion/dnsimple-ruby/pull/93.diff","patch_url":"https://github.com/aetrion/dnsimple-ruby/pull/93.patch","issue_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/93","number":93,"state":"open","locked":false,"title":"Rubocop","user":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"body":"I've been experimenting with [Rubocop](https://github.com/bbatsov/rubocop) to try to come up with a codification of the Ruby conventions we've been using so far.\r\n\r\nAfter using Go for a while, I like the idea to have an (even more) consistent codebase (I believe @aeden would agree).\r\n\r\nThe goal is to try to extend the consistency across our various Ruby repo. In fact, the RuboCop rules can be extracted in files, and each project can extend one (or more) base file. We could even publish it in our internal wiki, so that we have a single source.\r\n\r\nThis PR runs Rubocop against this lib. I've been testing it on a couple of my projects, and this is the first test against a DNSimple project. I've only handled the configs that affected this repo. It's likely more configs will affect the main DNSimple repo.\r\n\r\nA great feature of Rubocop is the flexibility, but also the possibility to auto-refactor offending code automatically. This is quite nice especially for super simple conventions, such as spaces, commas, etc.\r\n\r\n/cc @aetrion/dnsimple can you please give it a look? I've left in `.rubocop_todo.yml` some settings I could not come up with a decision based on the fact that it was either irrelevant or that we applied different approaches depending on the context. I left a comment on each rule. I'd appreciate your feedback.\r\n","created_at":"2016-03-27T18:26:14Z","updated_at":"2016-03-28T17:30:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eca1bd2a9f572b7cec6c5f6706f15d601087bf75","assignee":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93/commits","review_comments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93/comments","review_comment_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/93/comments","statuses_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/statuses/b6e226ba68687dbaba708b01dd34493cee83e976","head":{"label":"aetrion:rubocop","ref":"rubocop","sha":"b6e226ba68687dbaba708b01dd34493cee83e976","user":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"repo":{"id":768077,"name":"dnsimple-ruby","full_name":"aetrion/dnsimple-ruby","owner":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aetrion/dnsimple-ruby","description":"The DNSimple API client for Ruby.","fork":false,"url":"https://api.github.com/repos/aetrion/dnsimple-ruby","forks_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/forks","keys_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/teams","hooks_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/hooks","issue_events_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/events","assignees_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/tags","blobs_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/languages","stargazers_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/stargazers","contributors_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/contributors","subscribers_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/subscribers","subscription_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/subscription","commits_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/merges","archive_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/downloads","issues_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/labels{/name}","releases_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/deployments","created_at":"2010-07-10T20:48:48Z","updated_at":"2016-03-21T21:44:46Z","pushed_at":"2016-03-28T13:24:25Z","git_url":"git://github.com/aetrion/dnsimple-ruby.git","ssh_url":"git@github.com:aetrion/dnsimple-ruby.git","clone_url":"https://github.com/aetrion/dnsimple-ruby.git","svn_url":"https://github.com/aetrion/dnsimple-ruby","homepage":"https://developer.dnsimple.com","size":1003,"stargazers_count":125,"watchers_count":125,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":4,"forks":44,"open_issues":4,"watchers":125,"default_branch":"master"}},"base":{"label":"aetrion:master","ref":"master","sha":"a9c42f2bdd64cb59b04fc052695d9a101f079127","user":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"repo":{"id":768077,"name":"dnsimple-ruby","full_name":"aetrion/dnsimple-ruby","owner":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aetrion/dnsimple-ruby","description":"The DNSimple API client for Ruby.","fork":false,"url":"https://api.github.com/repos/aetrion/dnsimple-ruby","forks_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/forks","keys_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/teams","hooks_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/hooks","issue_events_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/events","assignees_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/tags","blobs_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/languages","stargazers_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/stargazers","contributors_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/contributors","subscribers_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/subscribers","subscription_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/subscription","commits_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/merges","archive_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/downloads","issues_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/labels{/name}","releases_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/aetrion/dnsimple-ruby/deployments","created_at":"2010-07-10T20:48:48Z","updated_at":"2016-03-21T21:44:46Z","pushed_at":"2016-03-28T13:24:25Z","git_url":"git://github.com/aetrion/dnsimple-ruby.git","ssh_url":"git@github.com:aetrion/dnsimple-ruby.git","clone_url":"https://github.com/aetrion/dnsimple-ruby.git","svn_url":"https://github.com/aetrion/dnsimple-ruby","homepage":"https://developer.dnsimple.com","size":1003,"stargazers_count":125,"watchers_count":125,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":4,"forks":44,"open_issues":4,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93"},"html":{"href":"https://github.com/aetrion/dnsimple-ruby/pull/93"},"issue":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/93"},"comments":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/aetrion/dnsimple-ruby/statuses/b6e226ba68687dbaba708b01dd34493cee83e976"}}}}