{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8186","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8186/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8186/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8186/events","html_url":"https://github.com/ManageIQ/manageiq/pull/8186","id":150367266,"number":8186,"title":"Remove references to the never set pending_restart status","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/core/workers","name":"core/workers","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-22T13:16:18Z","updated_at":"2016-04-22T15:10:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8186","html_url":"https://github.com/ManageIQ/manageiq/pull/8186","diff_url":"https://github.com/ManageIQ/manageiq/pull/8186.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/8186.patch"},"body":"Note:  This was found while researching some issues that @mkanoor was seeing with UI workers not exiting cleanly.  It doesn't solve his issue but gets in the way of following the code.  Also note, I was the one that failed to delete the pending_restart in the first place. 😢 \r\n\r\nAs of 250985c4b3ed pending_restart is never set, so don't look for it.\r\n\r\nAt some point before 250985c4b3ed, we would deal with stopping/killing a worker\r\nand then immediately start a new one.  The pending_restart status was used in\r\nthat stop/start worker workflow.\r\n\r\nWe changed this behavior so that the stop/kill logic only handles stopping/killing\r\nthe worker and we let sync_workers deal with starting any desired workers.\r\n\r\n@chessbyte @Fryguy @gtanzillo Could one of you please review?  🙇 "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/213467368","html_url":"https://github.com/ManageIQ/manageiq/pull/8186#issuecomment-213467368","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8186","id":213467368,"user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T15:10:25Z","updated_at":"2016-04-22T15:10:25Z","body":"@jrafanie Can you link the commit that caused the issue?  I can't reach the one you gave\r\n"}}