{"action":"closed","number":403,"pull_request":{"url":"https://api.github.com/repos/aurelia/binding/pulls/403","id":70092727,"html_url":"https://github.com/aurelia/binding/pull/403","diff_url":"https://github.com/aurelia/binding/pull/403.diff","patch_url":"https://github.com/aurelia/binding/pull/403.patch","issue_url":"https://api.github.com/repos/aurelia/binding/issues/403","number":403,"state":"closed","locked":false,"title":"Respect non-enumerable properties","user":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"body":"When creating a property like this:\r\n```\r\nReflect.defineProperty(obj, 'foo', {\r\n  configurable: true,\r\n  enumerable: false, // <-- non-enumerable\r\n  set: setter,\r\n  get: getter\r\n});\r\n```\r\nthe property observer will add its own setter and getter (which is a good thing), but also sets the `enumerable` setting to `true`.\r\nThis PR makes the observer respect the existing setting.","created_at":"2016-05-14T13:57:52Z","updated_at":"2016-05-16T16:28:33Z","closed_at":"2016-05-16T16:28:33Z","merged_at":"2016-05-16T16:28:33Z","merge_commit_sha":"ff8f9c7d24f646fa888be416225a0a2a4cd1386e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/binding/pulls/403/commits","review_comments_url":"https://api.github.com/repos/aurelia/binding/pulls/403/comments","review_comment_url":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/binding/issues/403/comments","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/ff8f9c7d24f646fa888be416225a0a2a4cd1386e","head":{"label":"gingerik:respect-nonenumerable-properties","ref":"respect-nonenumerable-properties","sha":"ff8f9c7d24f646fa888be416225a0a2a4cd1386e","user":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"repo":{"id":52154198,"name":"binding","full_name":"gingerik/binding","owner":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gingerik/binding","description":"A modern databinding library for JavaScript and HTML.","fork":true,"url":"https://api.github.com/repos/gingerik/binding","forks_url":"https://api.github.com/repos/gingerik/binding/forks","keys_url":"https://api.github.com/repos/gingerik/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gingerik/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gingerik/binding/teams","hooks_url":"https://api.github.com/repos/gingerik/binding/hooks","issue_events_url":"https://api.github.com/repos/gingerik/binding/issues/events{/number}","events_url":"https://api.github.com/repos/gingerik/binding/events","assignees_url":"https://api.github.com/repos/gingerik/binding/assignees{/user}","branches_url":"https://api.github.com/repos/gingerik/binding/branches{/branch}","tags_url":"https://api.github.com/repos/gingerik/binding/tags","blobs_url":"https://api.github.com/repos/gingerik/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gingerik/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gingerik/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/gingerik/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gingerik/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/gingerik/binding/languages","stargazers_url":"https://api.github.com/repos/gingerik/binding/stargazers","contributors_url":"https://api.github.com/repos/gingerik/binding/contributors","subscribers_url":"https://api.github.com/repos/gingerik/binding/subscribers","subscription_url":"https://api.github.com/repos/gingerik/binding/subscription","commits_url":"https://api.github.com/repos/gingerik/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/gingerik/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/gingerik/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/gingerik/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/gingerik/binding/contents/{+path}","compare_url":"https://api.github.com/repos/gingerik/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gingerik/binding/merges","archive_url":"https://api.github.com/repos/gingerik/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gingerik/binding/downloads","issues_url":"https://api.github.com/repos/gingerik/binding/issues{/number}","pulls_url":"https://api.github.com/repos/gingerik/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/gingerik/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/gingerik/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gingerik/binding/labels{/name}","releases_url":"https://api.github.com/repos/gingerik/binding/releases{/id}","deployments_url":"https://api.github.com/repos/gingerik/binding/deployments","created_at":"2016-02-20T13:17:25Z","updated_at":"2016-02-20T13:17:26Z","pushed_at":"2016-05-16T14:14:53Z","git_url":"git://github.com/gingerik/binding.git","ssh_url":"git@github.com:gingerik/binding.git","clone_url":"https://github.com/gingerik/binding.git","svn_url":"https://github.com/gingerik/binding","homepage":null,"size":3264,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"bb405750993a0e413f0b93e319fbdaac1a61d434","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27744828,"name":"binding","full_name":"aurelia/binding","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/binding","description":"A modern databinding library for JavaScript and HTML.","fork":false,"url":"https://api.github.com/repos/aurelia/binding","forks_url":"https://api.github.com/repos/aurelia/binding/forks","keys_url":"https://api.github.com/repos/aurelia/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/binding/teams","hooks_url":"https://api.github.com/repos/aurelia/binding/hooks","issue_events_url":"https://api.github.com/repos/aurelia/binding/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/binding/events","assignees_url":"https://api.github.com/repos/aurelia/binding/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/binding/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/binding/tags","blobs_url":"https://api.github.com/repos/aurelia/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/binding/languages","stargazers_url":"https://api.github.com/repos/aurelia/binding/stargazers","contributors_url":"https://api.github.com/repos/aurelia/binding/contributors","subscribers_url":"https://api.github.com/repos/aurelia/binding/subscribers","subscription_url":"https://api.github.com/repos/aurelia/binding/subscription","commits_url":"https://api.github.com/repos/aurelia/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/binding/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/binding/merges","archive_url":"https://api.github.com/repos/aurelia/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/binding/downloads","issues_url":"https://api.github.com/repos/aurelia/binding/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/binding/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/binding/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/binding/deployments","created_at":"2014-12-09T02:00:32Z","updated_at":"2016-04-26T04:43:19Z","pushed_at":"2016-05-16T16:28:32Z","git_url":"git://github.com/aurelia/binding.git","ssh_url":"git@github.com:aurelia/binding.git","clone_url":"https://github.com/aurelia/binding.git","svn_url":"https://github.com/aurelia/binding","homepage":null,"size":3649,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":26,"forks":54,"open_issues":26,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/binding/pulls/403"},"html":{"href":"https://github.com/aurelia/binding/pull/403"},"issue":{"href":"https://api.github.com/repos/aurelia/binding/issues/403"},"comments":{"href":"https://api.github.com/repos/aurelia/binding/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/binding/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/binding/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/binding/statuses/ff8f9c7d24f646fa888be416225a0a2a4cd1386e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jdanyow","id":1306747,"avatar_url":"https://avatars.githubusercontent.com/u/1306747?v=3","gravatar_id":"","url":"https://api.github.com/users/jdanyow","html_url":"https://github.com/jdanyow","followers_url":"https://api.github.com/users/jdanyow/followers","following_url":"https://api.github.com/users/jdanyow/following{/other_user}","gists_url":"https://api.github.com/users/jdanyow/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanyow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanyow/subscriptions","organizations_url":"https://api.github.com/users/jdanyow/orgs","repos_url":"https://api.github.com/users/jdanyow/repos","events_url":"https://api.github.com/users/jdanyow/events{/privacy}","received_events_url":"https://api.github.com/users/jdanyow/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":1,"additions":20,"deletions":1,"changed_files":2}}