{"action":"created","issue":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/1980","repository_url":"https://api.github.com/repos/geoadmin/mf-chsdi3","labels_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/1980/labels{/name}","comments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/1980/comments","events_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/1980/events","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/1980","id":140207952,"number":1980,"title":"[WIP] Grid Suppport","user":{"login":"loicgasser","id":3306154,"avatar_url":"https://avatars.githubusercontent.com/u/3306154?v=3","gravatar_id":"","url":"https://api.github.com/users/loicgasser","html_url":"https://github.com/loicgasser","followers_url":"https://api.github.com/users/loicgasser/followers","following_url":"https://api.github.com/users/loicgasser/following{/other_user}","gists_url":"https://api.github.com/users/loicgasser/gists{/gist_id}","starred_url":"https://api.github.com/users/loicgasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loicgasser/subscriptions","organizations_url":"https://api.github.com/users/loicgasser/orgs","repos_url":"https://api.github.com/users/loicgasser/repos","events_url":"https://api.github.com/users/loicgasser/events{/privacy}","received_events_url":"https://api.github.com/users/loicgasser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-11T15:12:33Z","updated_at":"2016-03-14T12:19:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/1980","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/1980","diff_url":"https://github.com/geoadmin/mf-chsdi3/pull/1980.diff","patch_url":"https://github.com/geoadmin/mf-chsdi3/pull/1980.patch"},"body":"https://github.com/geoadmin/mf-chsdi3/pull/1966\r\nhttps://github.com/geoadmin/mf-chsdi3/pull/1955\r\n\r\n@gjn @ltclm  @davidoesch [No DB grid test link](https://mf-geoadmin3.dev.bgdi.ch/gal_grid/?layers=ch.bfe.windenergie-geschwindigkeit_h50&topic=ech&lang=fr&bgLayer=ch.swisstopo.pixelkarte-farbe&X=158070.00&Y=555000.00&zoom=5)\r\n\r\nUpdate from @ltclm for the tooltip. Looks pretty good now."},"comment":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/comments/196287425","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/1980#issuecomment-196287425","issue_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/1980","id":196287425,"user":{"login":"loicgasser","id":3306154,"avatar_url":"https://avatars.githubusercontent.com/u/3306154?v=3","gravatar_id":"","url":"https://api.github.com/users/loicgasser","html_url":"https://github.com/loicgasser","followers_url":"https://api.github.com/users/loicgasser/followers","following_url":"https://api.github.com/users/loicgasser/following{/other_user}","gists_url":"https://api.github.com/users/loicgasser/gists{/gist_id}","starred_url":"https://api.github.com/users/loicgasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loicgasser/subscriptions","organizations_url":"https://api.github.com/users/loicgasser/orgs","repos_url":"https://api.github.com/users/loicgasser/repos","events_url":"https://api.github.com/users/loicgasser/events{/privacy}","received_events_url":"https://api.github.com/users/loicgasser/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T12:19:52Z","updated_at":"2016-03-14T12:19:52Z","body":"a) In order to add an iframe parameter in the intial request, we'd have to put this info on the client side somewhere in the layersConfig. The added valule is that we can request both, a reqular tooltip without an embedded iframe (never requested in geoadmin though) and an iframe based tooltip. We'd probaly need to document it as people using our tooltips might wonder why we are inconsistent.\r\n\r\nb) So you'd have a iframe in both tooltips? I would not put an iframe where we don't need one. Moreover \"rose\" dimensions varies accoding to where it is inserted (a regular or an extended tooltip). We'd also need to know this info client side as in a). Note that I am not against creating a new service for that.\r\n\r\nFinally I personally think the iframe should be based on an extended tooltip template or a dedicated one as an extended tooltip represents an html page (head, body, links to resources etc..) and the regular tooltip is only an html fragment.\r\n\r\nNow, for me it comes down to one main question I can't answer alone:\r\n\r\nDo we want to generalize this approach and use it for more layers?\r\n\r\nIf we don't know yet, I'd be in favour of keeping the actual implementation and extend it if we need to, as I don't see any backward compatibility issue if we go either ways."}}