{"action":"opened","number":419,"pull_request":{"url":"https://api.github.com/repos/roomorama/Caldroid/pulls/419","id":79500376,"html_url":"https://github.com/roomorama/Caldroid/pull/419","diff_url":"https://github.com/roomorama/Caldroid/pull/419.diff","patch_url":"https://github.com/roomorama/Caldroid/pull/419.patch","issue_url":"https://api.github.com/repos/roomorama/Caldroid/issues/419","number":419,"state":"open","locked":false,"title":"Use GridView verticalSpacing when calculating the grid height","user":{"login":"grennis","id":1767641,"avatar_url":"https://avatars.githubusercontent.com/u/1767641?v=3","gravatar_id":"","url":"https://api.github.com/users/grennis","html_url":"https://github.com/grennis","followers_url":"https://api.github.com/users/grennis/followers","following_url":"https://api.github.com/users/grennis/following{/other_user}","gists_url":"https://api.github.com/users/grennis/gists{/gist_id}","starred_url":"https://api.github.com/users/grennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grennis/subscriptions","organizations_url":"https://api.github.com/users/grennis/orgs","repos_url":"https://api.github.com/users/grennis/repos","events_url":"https://api.github.com/users/grennis/events{/privacy}","received_events_url":"https://api.github.com/users/grennis/received_events","type":"User","site_admin":false},"body":"This fixes #418. The grid view vertical spacing is considering when calculating the actual height of the GridView. Unfortunately, SDK 16 is required for the call to getVerticalSpacing, so that call is guarded with an SDK check. Also, in my testing, this removes the need for the arbitrary \"height -= 12\" statement and so that is only done if the spacing could not be determined.\r\n","created_at":"2016-08-01T00:07:07Z","updated_at":"2016-08-01T00:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/roomorama/Caldroid/pulls/419/commits","review_comments_url":"https://api.github.com/repos/roomorama/Caldroid/pulls/419/comments","review_comment_url":"https://api.github.com/repos/roomorama/Caldroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roomorama/Caldroid/issues/419/comments","statuses_url":"https://api.github.com/repos/roomorama/Caldroid/statuses/663f9061568865f3fc5f7c10d352ec9533de4376","head":{"label":"grennis:fix-gridheight-vertical-spacing","ref":"fix-gridheight-vertical-spacing","sha":"663f9061568865f3fc5f7c10d352ec9533de4376","user":{"login":"grennis","id":1767641,"avatar_url":"https://avatars.githubusercontent.com/u/1767641?v=3","gravatar_id":"","url":"https://api.github.com/users/grennis","html_url":"https://github.com/grennis","followers_url":"https://api.github.com/users/grennis/followers","following_url":"https://api.github.com/users/grennis/following{/other_user}","gists_url":"https://api.github.com/users/grennis/gists{/gist_id}","starred_url":"https://api.github.com/users/grennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grennis/subscriptions","organizations_url":"https://api.github.com/users/grennis/orgs","repos_url":"https://api.github.com/users/grennis/repos","events_url":"https://api.github.com/users/grennis/events{/privacy}","received_events_url":"https://api.github.com/users/grennis/received_events","type":"User","site_admin":false},"repo":{"id":64620935,"name":"Caldroid","full_name":"grennis/Caldroid","owner":{"login":"grennis","id":1767641,"avatar_url":"https://avatars.githubusercontent.com/u/1767641?v=3","gravatar_id":"","url":"https://api.github.com/users/grennis","html_url":"https://github.com/grennis","followers_url":"https://api.github.com/users/grennis/followers","following_url":"https://api.github.com/users/grennis/following{/other_user}","gists_url":"https://api.github.com/users/grennis/gists{/gist_id}","starred_url":"https://api.github.com/users/grennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grennis/subscriptions","organizations_url":"https://api.github.com/users/grennis/orgs","repos_url":"https://api.github.com/users/grennis/repos","events_url":"https://api.github.com/users/grennis/events{/privacy}","received_events_url":"https://api.github.com/users/grennis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grennis/Caldroid","description":"A better calendar for Android","fork":true,"url":"https://api.github.com/repos/grennis/Caldroid","forks_url":"https://api.github.com/repos/grennis/Caldroid/forks","keys_url":"https://api.github.com/repos/grennis/Caldroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grennis/Caldroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grennis/Caldroid/teams","hooks_url":"https://api.github.com/repos/grennis/Caldroid/hooks","issue_events_url":"https://api.github.com/repos/grennis/Caldroid/issues/events{/number}","events_url":"https://api.github.com/repos/grennis/Caldroid/events","assignees_url":"https://api.github.com/repos/grennis/Caldroid/assignees{/user}","branches_url":"https://api.github.com/repos/grennis/Caldroid/branches{/branch}","tags_url":"https://api.github.com/repos/grennis/Caldroid/tags","blobs_url":"https://api.github.com/repos/grennis/Caldroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grennis/Caldroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grennis/Caldroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/grennis/Caldroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grennis/Caldroid/statuses/{sha}","languages_url":"https://api.github.com/repos/grennis/Caldroid/languages","stargazers_url":"https://api.github.com/repos/grennis/Caldroid/stargazers","contributors_url":"https://api.github.com/repos/grennis/Caldroid/contributors","subscribers_url":"https://api.github.com/repos/grennis/Caldroid/subscribers","subscription_url":"https://api.github.com/repos/grennis/Caldroid/subscription","commits_url":"https://api.github.com/repos/grennis/Caldroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/grennis/Caldroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/grennis/Caldroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/grennis/Caldroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/grennis/Caldroid/contents/{+path}","compare_url":"https://api.github.com/repos/grennis/Caldroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grennis/Caldroid/merges","archive_url":"https://api.github.com/repos/grennis/Caldroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grennis/Caldroid/downloads","issues_url":"https://api.github.com/repos/grennis/Caldroid/issues{/number}","pulls_url":"https://api.github.com/repos/grennis/Caldroid/pulls{/number}","milestones_url":"https://api.github.com/repos/grennis/Caldroid/milestones{/number}","notifications_url":"https://api.github.com/repos/grennis/Caldroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grennis/Caldroid/labels{/name}","releases_url":"https://api.github.com/repos/grennis/Caldroid/releases{/id}","deployments_url":"https://api.github.com/repos/grennis/Caldroid/deployments","created_at":"2016-07-31T23:28:49Z","updated_at":"2016-07-31T23:28:50Z","pushed_at":"2016-08-01T00:05:08Z","git_url":"git://github.com/grennis/Caldroid.git","ssh_url":"git@github.com:grennis/Caldroid.git","clone_url":"https://github.com/grennis/Caldroid.git","svn_url":"https://github.com/grennis/Caldroid","homepage":null,"size":4180,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roomorama:master","ref":"master","sha":"b50db7b6226c6e5a554de16f0ecde71d3345e34a","user":{"login":"roomorama","id":53760,"avatar_url":"https://avatars.githubusercontent.com/u/53760?v=3","gravatar_id":"","url":"https://api.github.com/users/roomorama","html_url":"https://github.com/roomorama","followers_url":"https://api.github.com/users/roomorama/followers","following_url":"https://api.github.com/users/roomorama/following{/other_user}","gists_url":"https://api.github.com/users/roomorama/gists{/gist_id}","starred_url":"https://api.github.com/users/roomorama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roomorama/subscriptions","organizations_url":"https://api.github.com/users/roomorama/orgs","repos_url":"https://api.github.com/users/roomorama/repos","events_url":"https://api.github.com/users/roomorama/events{/privacy}","received_events_url":"https://api.github.com/users/roomorama/received_events","type":"Organization","site_admin":false},"repo":{"id":8641067,"name":"Caldroid","full_name":"roomorama/Caldroid","owner":{"login":"roomorama","id":53760,"avatar_url":"https://avatars.githubusercontent.com/u/53760?v=3","gravatar_id":"","url":"https://api.github.com/users/roomorama","html_url":"https://github.com/roomorama","followers_url":"https://api.github.com/users/roomorama/followers","following_url":"https://api.github.com/users/roomorama/following{/other_user}","gists_url":"https://api.github.com/users/roomorama/gists{/gist_id}","starred_url":"https://api.github.com/users/roomorama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roomorama/subscriptions","organizations_url":"https://api.github.com/users/roomorama/orgs","repos_url":"https://api.github.com/users/roomorama/repos","events_url":"https://api.github.com/users/roomorama/events{/privacy}","received_events_url":"https://api.github.com/users/roomorama/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roomorama/Caldroid","description":"A better calendar for Android","fork":false,"url":"https://api.github.com/repos/roomorama/Caldroid","forks_url":"https://api.github.com/repos/roomorama/Caldroid/forks","keys_url":"https://api.github.com/repos/roomorama/Caldroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roomorama/Caldroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roomorama/Caldroid/teams","hooks_url":"https://api.github.com/repos/roomorama/Caldroid/hooks","issue_events_url":"https://api.github.com/repos/roomorama/Caldroid/issues/events{/number}","events_url":"https://api.github.com/repos/roomorama/Caldroid/events","assignees_url":"https://api.github.com/repos/roomorama/Caldroid/assignees{/user}","branches_url":"https://api.github.com/repos/roomorama/Caldroid/branches{/branch}","tags_url":"https://api.github.com/repos/roomorama/Caldroid/tags","blobs_url":"https://api.github.com/repos/roomorama/Caldroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roomorama/Caldroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roomorama/Caldroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/roomorama/Caldroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roomorama/Caldroid/statuses/{sha}","languages_url":"https://api.github.com/repos/roomorama/Caldroid/languages","stargazers_url":"https://api.github.com/repos/roomorama/Caldroid/stargazers","contributors_url":"https://api.github.com/repos/roomorama/Caldroid/contributors","subscribers_url":"https://api.github.com/repos/roomorama/Caldroid/subscribers","subscription_url":"https://api.github.com/repos/roomorama/Caldroid/subscription","commits_url":"https://api.github.com/repos/roomorama/Caldroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/roomorama/Caldroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/roomorama/Caldroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/roomorama/Caldroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/roomorama/Caldroid/contents/{+path}","compare_url":"https://api.github.com/repos/roomorama/Caldroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roomorama/Caldroid/merges","archive_url":"https://api.github.com/repos/roomorama/Caldroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roomorama/Caldroid/downloads","issues_url":"https://api.github.com/repos/roomorama/Caldroid/issues{/number}","pulls_url":"https://api.github.com/repos/roomorama/Caldroid/pulls{/number}","milestones_url":"https://api.github.com/repos/roomorama/Caldroid/milestones{/number}","notifications_url":"https://api.github.com/repos/roomorama/Caldroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roomorama/Caldroid/labels{/name}","releases_url":"https://api.github.com/repos/roomorama/Caldroid/releases{/id}","deployments_url":"https://api.github.com/repos/roomorama/Caldroid/deployments","created_at":"2013-03-08T02:06:03Z","updated_at":"2016-07-31T12:59:18Z","pushed_at":"2016-05-28T11:36:50Z","git_url":"git://github.com/roomorama/Caldroid.git","ssh_url":"git@github.com:roomorama/Caldroid.git","clone_url":"https://github.com/roomorama/Caldroid.git","svn_url":"https://github.com/roomorama/Caldroid","homepage":null,"size":4180,"stargazers_count":1105,"watchers_count":1105,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":490,"mirror_url":null,"open_issues_count":76,"forks":490,"open_issues":76,"watchers":1105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roomorama/Caldroid/pulls/419"},"html":{"href":"https://github.com/roomorama/Caldroid/pull/419"},"issue":{"href":"https://api.github.com/repos/roomorama/Caldroid/issues/419"},"comments":{"href":"https://api.github.com/repos/roomorama/Caldroid/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/roomorama/Caldroid/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/roomorama/Caldroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roomorama/Caldroid/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/roomorama/Caldroid/statuses/663f9061568865f3fc5f7c10d352ec9533de4376"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"grennis"}}