{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/7490","repository_url":"https://api.github.com/repos/facebook/hhvm","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/7490/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/7490/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/7490/events","html_url":"https://github.com/facebook/hhvm/pull/7490","id":189296568,"number":7490,"title":"[Aarch64] Fix decqmlock with acquire and release semantics","user":{"login":"jim-saxman","id":22753343,"avatar_url":"https://avatars.githubusercontent.com/u/22753343?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-saxman","html_url":"https://github.com/jim-saxman","followers_url":"https://api.github.com/users/jim-saxman/followers","following_url":"https://api.github.com/users/jim-saxman/following{/other_user}","gists_url":"https://api.github.com/users/jim-saxman/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-saxman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-saxman/subscriptions","organizations_url":"https://api.github.com/users/jim-saxman/orgs","repos_url":"https://api.github.com/users/jim-saxman/repos","events_url":"https://api.github.com/users/jim-saxman/events{/privacy}","received_events_url":"https://api.github.com/users/jim-saxman/received_events","type":"User","site_admin":false},"labels":[{"id":196857004,"url":"https://api.github.com/repos/facebook/hhvm/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":434441950,"url":"https://api.github.com/repos/facebook/hhvm/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"mxw","id":1013739,"avatar_url":"https://avatars.githubusercontent.com/u/1013739?v=3","gravatar_id":"","url":"https://api.github.com/users/mxw","html_url":"https://github.com/mxw","followers_url":"https://api.github.com/users/mxw/followers","following_url":"https://api.github.com/users/mxw/following{/other_user}","gists_url":"https://api.github.com/users/mxw/gists{/gist_id}","starred_url":"https://api.github.com/users/mxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxw/subscriptions","organizations_url":"https://api.github.com/users/mxw/orgs","repos_url":"https://api.github.com/users/mxw/repos","events_url":"https://api.github.com/users/mxw/events{/privacy}","received_events_url":"https://api.github.com/users/mxw/received_events","type":"User","site_admin":false},"assignees":[{"login":"mxw","id":1013739,"avatar_url":"https://avatars.githubusercontent.com/u/1013739?v=3","gravatar_id":"","url":"https://api.github.com/users/mxw","html_url":"https://github.com/mxw","followers_url":"https://api.github.com/users/mxw/followers","following_url":"https://api.github.com/users/mxw/following{/other_user}","gists_url":"https://api.github.com/users/mxw/gists{/gist_id}","starred_url":"https://api.github.com/users/mxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxw/subscriptions","organizations_url":"https://api.github.com/users/mxw/orgs","repos_url":"https://api.github.com/users/mxw/repos","events_url":"https://api.github.com/users/mxw/events{/privacy}","received_events_url":"https://api.github.com/users/mxw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-11-15T04:21:03Z","updated_at":"2016-11-30T21:44:44Z","closed_at":"2016-11-30T21:44:44Z","pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/7490","html_url":"https://github.com/facebook/hhvm/pull/7490","diff_url":"https://github.com/facebook/hhvm/pull/7490.diff","patch_url":"https://github.com/facebook/hhvm/pull/7490.patch"},"body":"The VASM decqmlock and incqmlock have no ordering semantics when\r\nusing ldxr and stxr Aarch64 instructions. The current code is\r\nbroken and could be fixed by adding DMB barrier instructions,\r\nhowever the cleaner approach taken here is to use the load-acquire\r\nand store-release, which is equal to x86 including ordering\r\ncharacteristics. This is also the same as PPC64's decqmlock."},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/264005237","html_url":"https://github.com/facebook/hhvm/pull/7490#issuecomment-264005237","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/7490","id":264005237,"user":{"login":"mxw","id":1013739,"avatar_url":"https://avatars.githubusercontent.com/u/1013739?v=3","gravatar_id":"","url":"https://api.github.com/users/mxw","html_url":"https://github.com/mxw","followers_url":"https://api.github.com/users/mxw/followers","following_url":"https://api.github.com/users/mxw/following{/other_user}","gists_url":"https://api.github.com/users/mxw/gists{/gist_id}","starred_url":"https://api.github.com/users/mxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxw/subscriptions","organizations_url":"https://api.github.com/users/mxw/orgs","repos_url":"https://api.github.com/users/mxw/repos","events_url":"https://api.github.com/users/mxw/events{/privacy}","received_events_url":"https://api.github.com/users/mxw/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T21:44:44Z","updated_at":"2016-11-30T21:44:44Z","body":"Okay, I'm going to close without landing.  Ping here if it should be reopened."}}
{"actor":{"display_login":"mxw"}}