{"action":"created","issue":{"url":"https://api.github.com/repos/autotest/autotest-docker/issues/580","repository_url":"https://api.github.com/repos/autotest/autotest-docker","labels_url":"https://api.github.com/repos/autotest/autotest-docker/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/issues/580/comments","events_url":"https://api.github.com/repos/autotest/autotest-docker/issues/580/events","html_url":"https://github.com/autotest/autotest-docker/pull/580","id":143333404,"number":580,"title":"bz1097344 (docker-1.10 exit codes): prep work","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/autotest/autotest-docker/labels/Docker%20Autotest%20Bug","name":"Docker Autotest Bug","color":"006b75"},{"url":"https://api.github.com/repos/autotest/autotest-docker/labels/Docker%20Autotest%20Feature","name":"Docker Autotest Feature","color":"84b6eb"},{"url":"https://api.github.com/repos/autotest/autotest-docker/labels/On%20Milestone","name":"On Milestone","color":"8309cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/autotest/autotest-docker/milestones/21","html_url":"https://github.com/autotest/autotest-docker/milestones/Docker%20Autotest%20Version%200.8.5%20(NO%20API%20Changes)","labels_url":"https://api.github.com/repos/autotest/autotest-docker/milestones/21/labels","id":1079148,"number":21,"title":"Docker Autotest Version 0.8.5 (NO API Changes)","description":"","creator":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":47,"state":"open","created_at":"2015-04-22T15:55:31Z","updated_at":"2016-03-31T16:06:49Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2016-03-24T19:08:43Z","updated_at":"2016-03-31T16:34:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/580","html_url":"https://github.com/autotest/autotest-docker/pull/580","diff_url":"https://github.com/autotest/autotest-docker/pull/580.diff","patch_url":"https://github.com/autotest/autotest-docker/pull/580.patch"},"body":"Background: 'docker run' exit codes will be changing in 1.10,\r\nto differentiate between container exit status and errors from\r\ndocker itself[1]. This commit prepares for that, by\r\nredefining the use of the docker_expected_status config\r\nsetting. Instead of 'PASS' or 'FAIL' (old values), it\r\nis now expected to be an integer: 0 for success, X\r\nfor failure. As of this commit X is always 1, but at\r\nsome future point that will change. When it does,\r\nthe new failif_ne() helper will display the new exit\r\ncode, and it will be easy to update .ini files as\r\nnecessary.\r\n\r\nAdditionally, the mustfail() helper now requires the\r\nexpected exit status as an argument. These statuses can\r\nactually be hardcoded in the code itself, because\r\nmustfail() tests (once) if the installed docker binary\r\nreturns unique exit codes; if it doesn't, it changes\r\nthe expectation to 1 (what old-docker always returns).\r\n\r\nAlso includes two unrelated fixes for minor problems\r\ndiscovered during this process: removed an unused\r\nconfig setting, and fixed an incorrect test helper.\r\n\r\n [1] https://github.com/docker/docker/pull/14012/files\r\n\r\nNote that the exit codes here are UNTESTED, and will\r\nrequire tweaking once we actually have docker-1.10\r\navailable. That is expected to be minor effort.\r\n\r\nSigned-off-by: Ed Santiago <santiago@redhat.com>"},"comment":{"url":"https://api.github.com/repos/autotest/autotest-docker/issues/comments/204011696","html_url":"https://github.com/autotest/autotest-docker/pull/580#issuecomment-204011696","issue_url":"https://api.github.com/repos/autotest/autotest-docker/issues/580","id":204011696,"user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T16:34:17Z","updated_at":"2016-03-31T16:34:17Z","body":"Wow, this is very nice work.  I'd suggest don't drive yourself completely mad by fixing up all the old tests, it's a big time-sink.  That work is much easier to do during the 0.9.1 testing when all the 'big picture' stuff comes into play.  Anyway, just a suggestion.\r\n\r\nIs this ready to merge do you think, or was there more looking/tweaking you wanted to do?"}}