{"action":"opened","number":723,"pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/723","id":84735200,"html_url":"https://github.com/18F/calc/pull/723","diff_url":"https://github.com/18F/calc/pull/723.diff","patch_url":"https://github.com/18F/calc/pull/723.patch","issue_url":"https://api.github.com/repos/18F/calc/issues/723","number":723,"state":"open","locked":false,"title":"Make <upload-widget> work w/ funky upgrade timings.","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"body":"This fixes #710.\r\n\r\n#710 was not caused by any kind of regression in #583--I think it may be a regression introduced way back in 1f04e7ff0295844900148d47d4e48b30252234f4 that we didn't discover until today.\r\n\r\nI also discovered that #710 also only exhibits itself on Chrome, which is the only browser with native support for Custom Elements.\r\n\r\nBasically, when dynamically injecting the HTML of an ajaxform into the page, we're first creating the DOM for the new form and then attaching it to the document tree.  In Chrome's case, this means that the web components in the HTML are upgraded *before* being attached to the document tree.  Once attached to the document tree, the `attachedCallback`s on custom elements were called in **tree order** (preorder, depth-first traversal), which basically meant that `<upload-widget>`'s was called before `<input is=\"upload-input\">`'s.\r\n\r\nUltimately this means that the `upgrade()` method of the `UploadInput` was being called after it was upgraded but *before* its `attachedCallback` was called.  Because of the implementation, this meant that once the `attachedCallback` was eventually called, the `isUpgraded` property of the custom element was overwritten to be `false`, which completely messed up the state of the whole ajax form. :disappointed: \r\n\r\nThis fixes things so that our `UploadInput` works with unusual upgrade timings, and also changes the way tests are run to force those unusual upgrade timings to happen on Chrome (it makes no difference on other browsers that don't natively support custom elements).","created_at":"2016-09-09T23:42:39Z","updated_at":"2016-09-09T23:42:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59ea1b3a443802396577abf602f3ed77f5b406ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/calc/pulls/723/commits","review_comments_url":"https://api.github.com/repos/18F/calc/pulls/723/comments","review_comment_url":"https://api.github.com/repos/18F/calc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/calc/issues/723/comments","statuses_url":"https://api.github.com/repos/18F/calc/statuses/a272b14c68d5a98fd9cd1995424f7b395ee80e18","head":{"label":"18F:funky-upgrade-timings","ref":"funky-upgrade-timings","sha":"a272b14c68d5a98fd9cd1995424f7b395ee80e18","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-09-02T17:29:13Z","pushed_at":"2016-09-09T23:42:39Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":16563,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":103,"forks":42,"open_issues":103,"watchers":82,"default_branch":"develop"}},"base":{"label":"18F:develop","ref":"develop","sha":"e4585b28d4a31f64fe5f9a96b7ca1521204f8a94","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-09-02T17:29:13Z","pushed_at":"2016-09-09T23:42:39Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":16563,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":103,"forks":42,"open_issues":103,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/723"},"html":{"href":"https://github.com/18F/calc/pull/723"},"issue":{"href":"https://api.github.com/repos/18F/calc/issues/723"},"comments":{"href":"https://api.github.com/repos/18F/calc/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/calc/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/calc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/calc/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/18F/calc/statuses/a272b14c68d5a98fd9cd1995424f7b395ee80e18"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"toolness"}}