{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/comments/90413395","pull_request_review_id":10929388,"id":90413395,"diff_hunk":"@@ -0,0 +1,13 @@\n+'use strict'\n+\n+const randomBytes = require('random-bytes')","path":"src/util.js","position":3,"original_position":3,"commit_id":"be4c9b05646a212b0dd1e63021e7e2f776203bd7","original_commit_id":"be4c9b05646a212b0dd1e63021e7e2f776203bd7","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"body":"hmm why do you need a module for random bytes? there is `crypto.getRandomValues()` in the browser and `crypto.randomBytes()` in node.js","created_at":"2016-12-01T09:52:18Z","updated_at":"2016-12-01T09:53:55Z","html_url":"https://github.com/libp2p/js-libp2p-ping/pull/38#discussion_r90413395","pull_request_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/comments/90413395"},"html":{"href":"https://github.com/libp2p/js-libp2p-ping/pull/38#discussion_r90413395"},"pull_request":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38","id":96042137,"html_url":"https://github.com/libp2p/js-libp2p-ping/pull/38","diff_url":"https://github.com/libp2p/js-libp2p-ping/pull/38.diff","patch_url":"https://github.com/libp2p/js-libp2p-ping/pull/38.patch","issue_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/38","number":38,"state":"open","locked":false,"title":"Clean up and complete libp2p ping","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"I was going to add this to js-libp2p, but found out that currently the implementation is broken as it only supports one ping (problem with using always pull.values). Fixing it.\r\n\r\n//cc @xicombd ","created_at":"2016-12-01T08:02:03Z","updated_at":"2016-12-01T09:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04a763d0d7456e99c09cf65a89632061adb49ccf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38/commits","review_comments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38/comments","review_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/38/comments","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/statuses/be4c9b05646a212b0dd1e63021e7e2f776203bd7","head":{"label":"libp2p:feat/clean-and-finish","ref":"feat/clean-and-finish","sha":"be4c9b05646a212b0dd1e63021e7e2f776203bd7","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":39478585,"name":"js-libp2p-ping","full_name":"libp2p/js-libp2p-ping","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/js-libp2p-ping","description":"Node.js IPFS ping protocol implementation","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-ping","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/deployments","created_at":"2015-07-22T01:28:16Z","updated_at":"2016-11-05T23:18:37Z","pushed_at":"2016-12-01T09:40:30Z","git_url":"git://github.com/libp2p/js-libp2p-ping.git","ssh_url":"git@github.com:libp2p/js-libp2p-ping.git","clone_url":"https://github.com/libp2p/js-libp2p-ping.git","svn_url":"https://github.com/libp2p/js-libp2p-ping","homepage":null,"size":39,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"f1434bb1a517b4ee750fdca4675266814aacf8f2","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":39478585,"name":"js-libp2p-ping","full_name":"libp2p/js-libp2p-ping","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/js-libp2p-ping","description":"Node.js IPFS ping protocol implementation","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-ping","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-ping/deployments","created_at":"2015-07-22T01:28:16Z","updated_at":"2016-11-05T23:18:37Z","pushed_at":"2016-12-01T09:40:30Z","git_url":"git://github.com/libp2p/js-libp2p-ping.git","ssh_url":"git@github.com:libp2p/js-libp2p-ping.git","clone_url":"https://github.com/libp2p/js-libp2p-ping.git","svn_url":"https://github.com/libp2p/js-libp2p-ping","homepage":null,"size":39,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38"},"html":{"href":"https://github.com/libp2p/js-libp2p-ping/pull/38"},"issue":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/38"},"comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/js-libp2p-ping/statuses/be4c9b05646a212b0dd1e63021e7e2f776203bd7"}}}}
{"actor":{"display_login":"dignifiedquire"}}