{"action":"closed","issue":{"url":"https://api.github.com/repos/mozilla-services/autopush/issues/488","repository_url":"https://api.github.com/repos/mozilla-services/autopush","labels_url":"https://api.github.com/repos/mozilla-services/autopush/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/issues/488/comments","events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/488/events","html_url":"https://github.com/mozilla-services/autopush/issues/488","id":162421517,"number":488,"title":"Messages are delivered even if previous ones haven't been acknowledged","user":{"login":"kitcambridge","id":243830,"avatar_url":"https://avatars.githubusercontent.com/u/243830?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcambridge","html_url":"https://github.com/kitcambridge","followers_url":"https://api.github.com/users/kitcambridge/followers","following_url":"https://api.github.com/users/kitcambridge/following{/other_user}","gists_url":"https://api.github.com/users/kitcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcambridge/subscriptions","organizations_url":"https://api.github.com/users/kitcambridge/orgs","repos_url":"https://api.github.com/users/kitcambridge/repos","events_url":"https://api.github.com/users/kitcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/kitcambridge/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-27T10:34:00Z","updated_at":"2016-06-27T15:38:07Z","closed_at":"2016-06-27T15:38:07Z","body":"I just tried connecting and delivering several messages without acking them. Subsequent messages still make it through, even though I didn't ack any of the previous ones. Is this intentional? I was under the impression we write messages directly to storage if the client hasn't acked outstanding ones, but maybe that's not correct.\r\n\r\nwscat session:\r\n\r\n```\r\n> {\"messageType\":\"hello\",\"use_webpush\":true}\r\n< {\"status\": 200, \"ping\": 300.0, \"messageType\": \"hello\", \"env\": \"prod\", \"uaid\": \"f5679e4589a74bf0af153c467905c2d4\", \"use_webpush\": true}\r\n> {\"messageType\":\"register\",\"channelID\":\"9ae78077-16cc-4940-b94f-297124f01169\"}\r\n< {\"status\": 200, \"channelID\": \"9ae78077-16cc-4940-b94f-297124f01169\", \"messageType\": \"register\", \"pushEndpoint\": \"https://updates.push.services.mozilla.com/push/v1/gAAAAABXcP88zJpN3X-2Z2EEztxHBaP5dcG73L-Md3O7Picbd37ie61x4ToBjTkgoygjnYeiHMloXQuSeYUHcXv1EguKaj9_MNNNBR6zTKFh9L6zVMNv-wTNaiEyeWjDvvf8DHi0qd6G\"}\r\n```\r\n\r\nThen, if I run `curl -XPOST https://updates.push.services.mozilla.com/push/v1/gAAAAABXcP88zJpN3X-2Z2EEztxHBaP5dcG73L-Md3O7Picbd37ie61x4ToBjTkgoygjnYeiHMloXQuSeYUHcXv1EguKaj9_MNNNBR6zTKFh9L6zVMNv-wTNaiEyeWjDvvf8DHi0qd6G`, I see:\r\n\r\n```\r\n< {\"version\": \"gAAAAABXcP9EZGOsG4N1QR2oemy8I_0ieams0UadNQAGeANbkJzK8DVCALbWbQft1quhGNu8VjlEH9066fbgvJcMJ-JWyiCA21r6O8-WxnSzqAEVqXu0wlhRgX9BBKWe4Dal5kgBEYpeUzOEubBQPvMCZZRIWnOW9cd2hucuZUC1gNVg9MyN6Hs=:\", \"channelID\": \"9ae78077-16cc-4940-b94f-297124f01169\", \"messageType\": \"notification\"}\r\n< {\"version\": \"gAAAAABXcP9FKEwNcFvWxikFw0-AfrsoqUhKesDaHHGO4tUaRorfBy-M6EuqRyptLEkQjNYFWc1yulHqVPeoGv-clnj5SZ7DmR7IXCTRgdeGk81SpVT2sX2INGW9Mu0_qljLoXzd8panoJhKnPHl0dt5U_tXCS-bmxOiPKSSgXiLrnUQEJ3qxAw=:\", \"channelID\": \"9ae78077-16cc-4940-b94f-297124f01169\", \"messageType\": \"notification\"}\r\n< {\"version\": \"gAAAAABXcP9Hl71MTQue8IIPyuoz0okNDa_apzcr7uDJYa7JRSJgVT5LxrmVN0IkhtzoFcm7Mcc9PCbhtYizMPtdzC7U9iOBC-nq31u2pw1Uqw2f26ng-E5nNIFn9uZklJy3cFQiNrTmwXN_c5ZlnMmJkhpVBCB-hpcEwRJN2yFqYjtOwx-UKqs=:\", \"channelID\": \"9ae78077-16cc-4940-b94f-297124f01169\", \"messageType\": \"notification\"}\r\n```\r\n\r\nThe second (`gAAAAABXcP9FKEwNcFvWxikFw0-AfrsoqUhKesDaHHGO4tUaRorfBy-M6EuqRyptLEkQjNYFWc1yulHqVPeoGv-clnj5SZ7DmR7IXCTRgdeGk81SpVT2sX2INGW9Mu0_qljLoXzd8panoJhKnPHl0dt5U_tXCS-bmxOiPKSSgXiLrnUQEJ3qxAw=:`) and third (`gAAAAABXcP9Hl71MTQue8IIPyuoz0okNDa_apzcr7uDJYa7JRSJgVT5LxrmVN0IkhtzoFcm7Mcc9PCbhtYizMPtdzC7U9iOBC-nq31u2pw1Uqw2f26ng-E5nNIFn9uZklJy3cFQiNrTmwXN_c5ZlnMmJkhpVBCB-hpcEwRJN2yFqYjtOwx-UKqs=:`) messages are delivered...even though the client hasn't acked the first one (`gAAAAABXcP9EZGOsG4N1QR2oemy8I_0ieams0UadNQAGeANbkJzK8DVCALbWbQft1quhGNu8VjlEH9066fbgvJcMJ-JWyiCA21r6O8-WxnSzqAEVqXu0wlhRgX9BBKWe4Dal5kgBEYpeUzOEubBQPvMCZZRIWnOW9cd2hucuZUC1gNVg9MyN6Hs=:`) yet.\r\n\r\nI was expecting the second and third messages wouldn't be delivered until the first one was acked."}}
{"actor":{"display_login":"kitcambridge"}}