{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/comments/59391881","id":59391881,"diff_hunk":"@@ -0,0 +1,19 @@\n+.PHONY: run clean\n+\n+EXE=iowait\n+IMAGE=weavescope-iowait-plugin\n+UPTODATE=.$(EXE).uptodate\n+\n+run: $(UPTODATE)\n+\tdocker run --rm -it --privileged -v /var/run/scope/plugins:/var/run/scope/plugins --name $(IMAGE) $(IMAGE) -hostname=$(shell hostname)","path":"examples/plugins/iowait/Makefile","position":8,"original_position":8,"commit_id":"4b7cfcc9e86a65e0180d2bfa2bf150e2226a64c3","original_commit_id":"4b7cfcc9e86a65e0180d2bfa2bf150e2226a64c3","user":{"login":"2opremio","id":2362916,"avatar_url":"https://avatars.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false},"body":"`/var/run/scope/plugins` won't exist if Scope is not running. I am not sure we want to do something about this. The http-requests plugin has this problem too.","created_at":"2016-04-12T15:02:05Z","updated_at":"2016-04-12T15:02:05Z","html_url":"https://github.com/weaveworks/scope/pull/1126#discussion_r59391881","pull_request_url":"https://api.github.com/repos/weaveworks/scope/pulls/1126","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments/59391881"},"html":{"href":"https://github.com/weaveworks/scope/pull/1126#discussion_r59391881"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/1126","id":61744756,"html_url":"https://github.com/weaveworks/scope/pull/1126","diff_url":"https://github.com/weaveworks/scope/pull/1126.diff","patch_url":"https://github.com/weaveworks/scope/pull/1126.patch","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/1126","number":1126,"state":"open","locked":false,"title":"Plugins","user":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"body":"Fixes #554\r\n\r\nCommits are still super-messy, and tests are earmarked, as this is both a work-in-progress and a proof-of-concept.\r\n\r\nHTTP Request latency is shown on the weavescope node (we can correlate it due to weavescope being in the host network).\r\n\r\nPlugin registry turned out very similar to #809.\r\n\r\nTODO:\r\n- [x] figure out what the sysdig querying looks like and how flexible it is\r\n    - [x] do some plugin data from the raw sysdig stream\r\n      - bandwidth usage per-process, maybe\r\n      - can we parse stuff fast enough? or filter it better?\r\n- [ ] ~~get better data from sysdig plugin~~\r\n    - Either need to:\r\n      - implement the plugin in lua (possible?)\r\n      - make the lua chisel more flexible and add an interface for the go plugin to control it\r\n      - just add more aggregations for each type of data\r\n- [x] show plugin list in UI\r\n    - [x] styling\r\n    - [ ] maybe adjust timers? or include it with report/node updates?\r\n- [x] clean up and make plugins code sane/tested\r\n- [x] add safe zero-values for everything in a report so json deserialization is safer on malformed inputs\r\n- [x] all templates (not just extra, and including metrics) need to come from the probe\r\n- [x] add deadline/timeout on plugin calls\r\n- [x] add api versioning to plugin handshake\r\n- [x] re-organize code to be consistent with controls\r\n- [x] clean up todos\r\n- [x] consider rest api instead of jsonrpc\r\n- [x] add periodic retry on dead plugin sockets (for if they restart)\r\n- [ ] ~~replace example plugin with something else~~ Pushed eBPF plugin into a separate PR.\r\n  - [ ] add check to ebpf plugin for if kernel is new enough\r\n  - [ ] port ebpf plugin to python, and do counting in kernel\r\n  - [ ] figure out how to get pids from ebpf, so we can get more accurate counts per/process\r\n- [ ] ~~consider an async \"plugin-push\" interface instead of probe polling.~~ Considered it. Delaying to a future \"api version\"\r\n- [x] see about removing render/detailed/labels.go\r\n- [x] final test fixup\r\n- [x] documentation\r\n- [x] update plugins when they change\r\n  - [x] lets ditch handshake, and just assume all plugins respond to `/report`, then parse the pluginspec from that.","created_at":"2016-03-04T17:34:33Z","updated_at":"2016-04-12T15:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8900db0d37630e717830f78316ba19092f6e3b43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/scope/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/weaveworks/scope/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/1126/comments","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/4b7cfcc9e86a65e0180d2bfa2bf150e2226a64c3","head":{"label":"weaveworks:plugins","ref":"plugins","sha":"4b7cfcc9e86a65e0180d2bfa2bf150e2226a64c3","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":34659664,"name":"scope","full_name":"weaveworks/scope","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/scope","description":"Monitoring, visualisation & management for Docker","fork":false,"url":"https://api.github.com/repos/weaveworks/scope","forks_url":"https://api.github.com/repos/weaveworks/scope/forks","keys_url":"https://api.github.com/repos/weaveworks/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/scope/teams","hooks_url":"https://api.github.com/repos/weaveworks/scope/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/scope/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/scope/events","assignees_url":"https://api.github.com/repos/weaveworks/scope/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/scope/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/scope/tags","blobs_url":"https://api.github.com/repos/weaveworks/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/scope/languages","stargazers_url":"https://api.github.com/repos/weaveworks/scope/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/scope/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/scope/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/scope/subscription","commits_url":"https://api.github.com/repos/weaveworks/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/scope/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/scope/merges","archive_url":"https://api.github.com/repos/weaveworks/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/scope/downloads","issues_url":"https://api.github.com/repos/weaveworks/scope/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/scope/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/scope/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/scope/deployments","created_at":"2015-04-27T10:12:35Z","updated_at":"2016-04-12T05:00:30Z","pushed_at":"2016-04-12T14:55:42Z","git_url":"git://github.com/weaveworks/scope.git","ssh_url":"git@github.com:weaveworks/scope.git","clone_url":"https://github.com/weaveworks/scope.git","svn_url":"https://github.com/weaveworks/scope","homepage":"http://weave.works/product/scope/","size":55234,"stargazers_count":579,"watchers_count":579,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":187,"forks":36,"open_issues":187,"watchers":579,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"f3c9ff2ce42f4fede6e5020e4d7917fc276080a9","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":34659664,"name":"scope","full_name":"weaveworks/scope","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/scope","description":"Monitoring, visualisation & management for Docker","fork":false,"url":"https://api.github.com/repos/weaveworks/scope","forks_url":"https://api.github.com/repos/weaveworks/scope/forks","keys_url":"https://api.github.com/repos/weaveworks/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/scope/teams","hooks_url":"https://api.github.com/repos/weaveworks/scope/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/scope/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/scope/events","assignees_url":"https://api.github.com/repos/weaveworks/scope/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/scope/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/scope/tags","blobs_url":"https://api.github.com/repos/weaveworks/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/scope/languages","stargazers_url":"https://api.github.com/repos/weaveworks/scope/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/scope/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/scope/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/scope/subscription","commits_url":"https://api.github.com/repos/weaveworks/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/scope/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/scope/merges","archive_url":"https://api.github.com/repos/weaveworks/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/scope/downloads","issues_url":"https://api.github.com/repos/weaveworks/scope/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/scope/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/scope/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/scope/deployments","created_at":"2015-04-27T10:12:35Z","updated_at":"2016-04-12T05:00:30Z","pushed_at":"2016-04-12T14:55:42Z","git_url":"git://github.com/weaveworks/scope.git","ssh_url":"git@github.com:weaveworks/scope.git","clone_url":"https://github.com/weaveworks/scope.git","svn_url":"https://github.com/weaveworks/scope","homepage":"http://weave.works/product/scope/","size":55234,"stargazers_count":579,"watchers_count":579,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":187,"forks":36,"open_issues":187,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1126"},"html":{"href":"https://github.com/weaveworks/scope/pull/1126"},"issue":{"href":"https://api.github.com/repos/weaveworks/scope/issues/1126"},"comments":{"href":"https://api.github.com/repos/weaveworks/scope/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/scope/statuses/4b7cfcc9e86a65e0180d2bfa2bf150e2226a64c3"}}}}