{"action":"created","issue":{"url":"https://api.github.com/repos/netz98/n98-magerun/issues/850","repository_url":"https://api.github.com/repos/netz98/n98-magerun","labels_url":"https://api.github.com/repos/netz98/n98-magerun/issues/850/labels{/name}","comments_url":"https://api.github.com/repos/netz98/n98-magerun/issues/850/comments","events_url":"https://api.github.com/repos/netz98/n98-magerun/issues/850/events","html_url":"https://github.com/netz98/n98-magerun/issues/850","id":170723089,"number":850,"title":"Don't flush the cache during 'sys:setup:run'","user":{"login":"fbrnc","id":468820,"avatar_url":"https://avatars.githubusercontent.com/u/468820?v=3","gravatar_id":"","url":"https://api.github.com/users/fbrnc","html_url":"https://github.com/fbrnc","followers_url":"https://api.github.com/users/fbrnc/followers","following_url":"https://api.github.com/users/fbrnc/following{/other_user}","gists_url":"https://api.github.com/users/fbrnc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbrnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbrnc/subscriptions","organizations_url":"https://api.github.com/users/fbrnc/orgs","repos_url":"https://api.github.com/users/fbrnc/repos","events_url":"https://api.github.com/users/fbrnc/events{/privacy}","received_events_url":"https://api.github.com/users/fbrnc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netz98/n98-magerun/labels/support","name":"support","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-11T19:13:36Z","updated_at":"2016-08-12T08:25:40Z","closed_at":null,"body":"Before executing `sys:setup:run` n98-magerun flushes the entire cache (see https://github.com/netz98/n98-magerun/blob/master/src/N98/Magento/Command/System/Setup/RunCommand.php#L48)\r\n\r\nThis is critial since it has a major impact on the infrastructure, especially while your rolling out a new deployment. On top of that we typically use customized cache prefixes (configured in local.xml) to 'namespace' the different builds with a build number in the cache prefix. `sys:setup:run`will delete everything affecting the current deployment.\r\n\r\nIs there a reason why the cache needs to be flushed?\r\nCould the cache just by cleaned (which would respect the cache prefix)?\r\nOr could we even just selectively clean the config cache? (or what else is stuck in the cache that needs to be updated before running updates?"},"comment":{"url":"https://api.github.com/repos/netz98/n98-magerun/issues/comments/239389692","html_url":"https://github.com/netz98/n98-magerun/issues/850#issuecomment-239389692","issue_url":"https://api.github.com/repos/netz98/n98-magerun/issues/850","id":239389692,"user":{"login":"cmuench","id":211294,"avatar_url":"https://avatars.githubusercontent.com/u/211294?v=3","gravatar_id":"","url":"https://api.github.com/users/cmuench","html_url":"https://github.com/cmuench","followers_url":"https://api.github.com/users/cmuench/followers","following_url":"https://api.github.com/users/cmuench/following{/other_user}","gists_url":"https://api.github.com/users/cmuench/gists{/gist_id}","starred_url":"https://api.github.com/users/cmuench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmuench/subscriptions","organizations_url":"https://api.github.com/users/cmuench/orgs","repos_url":"https://api.github.com/users/cmuench/repos","events_url":"https://api.github.com/users/cmuench/events{/privacy}","received_events_url":"https://api.github.com/users/cmuench/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T08:25:40Z","updated_at":"2016-08-12T08:25:40Z","body":"@fbrnc As Tom mentioned is the code very old. We supported Magento 1.3 at this time.\r\nI think it could be an issue with some store initialization. With n98-magerun you also need to flush the cache to start the update process in the web frontend.\r\n\r\nI think we should add the `--skip-cache-flush` option to the command and @fbrnc can investigate if this change will produce any issues."}}
{"actor":{"display_login":"cmuench"}}