{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6437","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6437/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6437/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6437/events","html_url":"https://github.com/playframework/playframework/pull/6437","id":171077911,"number":6437,"title":"shutdown hooks will now be called correctly in dev mode","user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-08-14T20:51:25Z","updated_at":"2016-08-16T07:02:46Z","closed_at":"2016-08-15T20:40:59Z","pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6437","html_url":"https://github.com/playframework/playframework/pull/6437","diff_url":"https://github.com/playframework/playframework/pull/6437.diff","patch_url":"https://github.com/playframework/playframework/pull/6437.patch"},"body":"# Helpful things\r\n\r\n## Fixes\r\n\r\nFixes #6433\r\n\r\n## Purpose\r\n\r\nIt actually ensure's that Shutdown Hooks will be only called **once** and that they will **always** be called in dev mode. This ensure's that nothing can go stale.\r\n\r\n## Background Context\r\n\r\nActually without breaking backwards compatibility I didn't see any other way of having a good way to do it.\r\n\r\nSo this isn't back portable since it will break mima and definitly add some problems when people **didn't** used BuiltInComponentsWithContext.\r\n\r\nAnother problem still happens or at least I don't if it will, it still never garbage collects the ReloadableClassLoader which I can't actually fix without a profiler like Yourkit (VisualVM is too dumb), I guess something still holds a reference to something but since nothing is running there it isn't a big deal. \r\n"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/240019781","html_url":"https://github.com/playframework/playframework/pull/6437#issuecomment-240019781","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6437","id":240019781,"user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T07:02:46Z","updated_at":"2016-08-16T07:02:46Z","body":"Backport here: https://github.com/playframework/playframework/pull/6449"}}
{"actor":{"display_login":"schmitch"}}