{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/64254335","id":64254335,"diff_hunk":"@@ -0,0 +1,74 @@\n+## JVM configuration\n+\n+# Xms represents the initial size of total heap space\n+# Xmx represents the maximum size of total heap space\n+\n+-Xms256m\n+-Xmx1g\n+\n+################################################################\n+## Expert settings\n+################################################################\n+##\n+## All settings below this section are considered\n+## expert settings. Don't tamper with them unless\n+## you understand what you are doing\n+##\n+################################################################\n+\n+## GC configuration\n+-XX:+UseParNewGC\n+-XX:+UseConcMarkSweepGC\n+-XX:CMSInitiatingOccupancyFraction=75\n+-XX:+UseCMSInitiatingOccupancyOnly\n+\n+## optimizations\n+\n+# disable calls to System#gc\n+-XX:+DisableExplicitGC\n+\n+## Locale\n+# Set the locale language\n+#-Duser.language=en\n+\n+# Set the locale country\n+#-Duser.country=US\n+\n+# Set the locale variant, if any\n+#-Duser.variant=\n+\n+## Basic settings","path":"pkg/jvm.options","position":40,"original_position":40,"commit_id":"4bc2335a8b818751f9581f52038d822a6d570272","original_commit_id":"4bc2335a8b818751f9581f52038d822a6d570272","user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"Feels weird to have a section above saying \"Expert settings\" and then below saying \"Basic settings\"\r\n\r\nAre these expert basic settings? ;P","created_at":"2016-05-23T17:21:34Z","updated_at":"2016-05-23T17:21:34Z","html_url":"https://github.com/elastic/logstash/pull/5341#discussion_r64254335","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5341","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/64254335"},"html":{"href":"https://github.com/elastic/logstash/pull/5341#discussion_r64254335"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5341"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5341","id":70900750,"html_url":"https://github.com/elastic/logstash/pull/5341","diff_url":"https://github.com/elastic/logstash/pull/5341.diff","patch_url":"https://github.com/elastic/logstash/pull/5341.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5341","number":5341,"state":"open","locked":false,"title":"Feature/release packaging","user":{"login":"untergeek","id":1020383,"avatar_url":"https://avatars.githubusercontent.com/u/1020383?v=3","gravatar_id":"","url":"https://api.github.com/users/untergeek","html_url":"https://github.com/untergeek","followers_url":"https://api.github.com/users/untergeek/followers","following_url":"https://api.github.com/users/untergeek/following{/other_user}","gists_url":"https://api.github.com/users/untergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/untergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untergeek/subscriptions","organizations_url":"https://api.github.com/users/untergeek/orgs","repos_url":"https://api.github.com/users/untergeek/repos","events_url":"https://api.github.com/users/untergeek/events{/privacy}","received_events_url":"https://api.github.com/users/untergeek/received_events","type":"User","site_admin":false},"body":"Updates to work with @jsvd's work on `logstash.yml` settings.\r\n\r\nThis uses a wrapper around `pleaserun` (bin/system-install) to generate the proper startup files for whatever environment you're using.","created_at":"2016-05-20T18:51:10Z","updated_at":"2016-05-23T17:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e689b1b7ee73f922196bff4e0b63cd5475212cf","assignee":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5341/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5341/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5341/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/4bc2335a8b818751f9581f52038d822a6d570272","head":{"label":"untergeek:feature/release_packaging","ref":"feature/release_packaging","sha":"4bc2335a8b818751f9581f52038d822a6d570272","user":{"login":"untergeek","id":1020383,"avatar_url":"https://avatars.githubusercontent.com/u/1020383?v=3","gravatar_id":"","url":"https://api.github.com/users/untergeek","html_url":"https://github.com/untergeek","followers_url":"https://api.github.com/users/untergeek/followers","following_url":"https://api.github.com/users/untergeek/following{/other_user}","gists_url":"https://api.github.com/users/untergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/untergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untergeek/subscriptions","organizations_url":"https://api.github.com/users/untergeek/orgs","repos_url":"https://api.github.com/users/untergeek/repos","events_url":"https://api.github.com/users/untergeek/events{/privacy}","received_events_url":"https://api.github.com/users/untergeek/received_events","type":"User","site_admin":false},"repo":{"id":6462322,"name":"logstash","full_name":"untergeek/logstash","owner":{"login":"untergeek","id":1020383,"avatar_url":"https://avatars.githubusercontent.com/u/1020383?v=3","gravatar_id":"","url":"https://api.github.com/users/untergeek","html_url":"https://github.com/untergeek","followers_url":"https://api.github.com/users/untergeek/followers","following_url":"https://api.github.com/users/untergeek/following{/other_user}","gists_url":"https://api.github.com/users/untergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/untergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untergeek/subscriptions","organizations_url":"https://api.github.com/users/untergeek/orgs","repos_url":"https://api.github.com/users/untergeek/repos","events_url":"https://api.github.com/users/untergeek/events{/privacy}","received_events_url":"https://api.github.com/users/untergeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/untergeek/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/untergeek/logstash","forks_url":"https://api.github.com/repos/untergeek/logstash/forks","keys_url":"https://api.github.com/repos/untergeek/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untergeek/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untergeek/logstash/teams","hooks_url":"https://api.github.com/repos/untergeek/logstash/hooks","issue_events_url":"https://api.github.com/repos/untergeek/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/untergeek/logstash/events","assignees_url":"https://api.github.com/repos/untergeek/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/untergeek/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/untergeek/logstash/tags","blobs_url":"https://api.github.com/repos/untergeek/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untergeek/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untergeek/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/untergeek/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untergeek/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/untergeek/logstash/languages","stargazers_url":"https://api.github.com/repos/untergeek/logstash/stargazers","contributors_url":"https://api.github.com/repos/untergeek/logstash/contributors","subscribers_url":"https://api.github.com/repos/untergeek/logstash/subscribers","subscription_url":"https://api.github.com/repos/untergeek/logstash/subscription","commits_url":"https://api.github.com/repos/untergeek/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/untergeek/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/untergeek/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/untergeek/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/untergeek/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/untergeek/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untergeek/logstash/merges","archive_url":"https://api.github.com/repos/untergeek/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untergeek/logstash/downloads","issues_url":"https://api.github.com/repos/untergeek/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/untergeek/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/untergeek/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/untergeek/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untergeek/logstash/labels{/name}","releases_url":"https://api.github.com/repos/untergeek/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/untergeek/logstash/deployments","created_at":"2012-10-30T18:33:19Z","updated_at":"2015-02-27T16:11:20Z","pushed_at":"2016-05-20T22:38:37Z","git_url":"git://github.com/untergeek/logstash.git","ssh_url":"git@github.com:untergeek/logstash.git","clone_url":"https://github.com/untergeek/logstash.git","svn_url":"https://github.com/untergeek/logstash","homepage":"http://logstash.net/","size":74260,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"bdddab99a9d1807a46d1a6176853b1d5cb801edc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-05-23T15:19:21Z","pushed_at":"2016-05-23T13:52:54Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":88325,"stargazers_count":5900,"watchers_count":5900,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1784,"mirror_url":null,"open_issues_count":733,"forks":1784,"open_issues":733,"watchers":5900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5341"},"html":{"href":"https://github.com/elastic/logstash/pull/5341"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5341"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5341/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5341/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5341/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/4bc2335a8b818751f9581f52038d822a6d570272"}}}}
{"actor":{"display_login":"jordansissel"}}