{"action":"created","comment":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments/84038007","pull_request_review_id":4839360,"id":84038007,"diff_hunk":"@@ -0,0 +1,45 @@\n+# -*- coding: utf-8 -*-\n+\n+# ###################################################\n+# Copyright (C) 2008-2016 The Unknown Horizons Team\n+# team@unknown-horizons.org\n+# This file is part of Unknown Horizons.\n+#\n+# Unknown Horizons is free software; you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation; either version 2 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program; if not, write to the\n+# Free Software Foundation, Inc.,\n+# 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA\n+# ###################################################\n+\n+import os\n+from unittest import TestCase\n+\n+import pep8\n+\n+\n+class TestCodeFormat(TestCase):\n+\t\"\"\"automatical test for code format use pep8\"\"\"\n+\n+\tdef test_pep8_dir_tests(self):\n+\t\t\"\"\"Test that code conform to PEP8 test all files\"\"\"\n+\t\ttests = [\n+\t\t\t# http://pep8.readthedocs.org/en/latest/intro.html#error-codes\n+\t\t\t'W2',    # whitespace warnings\n+\t\t]\n+\n+\t\tchecker = pep8.StyleGuide(select=tests, paths=['.'], reporter=pep8.StandardReport)","path":"tests/unittests/test_pep8.py","position":40,"original_position":40,"commit_id":"6d4f9d0f86a387df4aeb7e33ab63cbb0e49cad7a","original_commit_id":"6d4f9d0f86a387df4aeb7e33ab63cbb0e49cad7a","user":{"login":"squiddy","id":50333,"avatar_url":"https://avatars.githubusercontent.com/u/50333?v=3","gravatar_id":"","url":"https://api.github.com/users/squiddy","html_url":"https://github.com/squiddy","followers_url":"https://api.github.com/users/squiddy/followers","following_url":"https://api.github.com/users/squiddy/following{/other_user}","gists_url":"https://api.github.com/users/squiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/squiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squiddy/subscriptions","organizations_url":"https://api.github.com/users/squiddy/orgs","repos_url":"https://api.github.com/users/squiddy/repos","events_url":"https://api.github.com/users/squiddy/events{/privacy}","received_events_url":"https://api.github.com/users/squiddy/received_events","type":"User","site_admin":false},"body":"I think we need to be more explicit here. This basically runs pep8 on everything in the current working directory, yes?\r\n\r\nThis should specify horizons/, tests/, development/ explicitly. Otherwise I think this pep8 check might run on packages I have in my virtualenv for example.","created_at":"2016-10-19T10:12:54Z","updated_at":"2016-10-19T10:12:54Z","html_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2526#discussion_r84038007","pull_request_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526","_links":{"self":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments/84038007"},"html":{"href":"https://github.com/unknown-horizons/unknown-horizons/pull/2526#discussion_r84038007"},"pull_request":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526"}}},"pull_request":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526","id":89767861,"html_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2526","diff_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2526.diff","patch_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2526.patch","issue_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2526","number":2526,"state":"open","locked":false,"title":"Use pep8 for trailing whitespace check ","user":{"login":"MarkusHackspacher","id":1457863,"avatar_url":"https://avatars.githubusercontent.com/u/1457863?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusHackspacher","html_url":"https://github.com/MarkusHackspacher","followers_url":"https://api.github.com/users/MarkusHackspacher/followers","following_url":"https://api.github.com/users/MarkusHackspacher/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHackspacher/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHackspacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHackspacher/subscriptions","organizations_url":"https://api.github.com/users/MarkusHackspacher/orgs","repos_url":"https://api.github.com/users/MarkusHackspacher/repos","events_url":"https://api.github.com/users/MarkusHackspacher/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHackspacher/received_events","type":"User","site_admin":false},"body":"The trailing whitespace remove my IDE automatically, according to the .editorconfig settings.\r\nBut that has influence if I want to edit other, these are also removed. See: https://github.com/unknown-horizons/unknown-horizons/pull/2503#discussion_r82510052\r\n\r\nThe idea was make a check where in the project all the trailing whitespace.","created_at":"2016-10-18T08:26:39Z","updated_at":"2016-10-19T10:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87b6a076dad5e67105f432ebc4ee9dc08e89f521","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526/commits","review_comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526/comments","review_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2526/comments","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/6d4f9d0f86a387df4aeb7e33ab63cbb0e49cad7a","head":{"label":"MarkusHackspacher:patch-5","ref":"patch-5","sha":"6d4f9d0f86a387df4aeb7e33ab63cbb0e49cad7a","user":{"login":"MarkusHackspacher","id":1457863,"avatar_url":"https://avatars.githubusercontent.com/u/1457863?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusHackspacher","html_url":"https://github.com/MarkusHackspacher","followers_url":"https://api.github.com/users/MarkusHackspacher/followers","following_url":"https://api.github.com/users/MarkusHackspacher/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHackspacher/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHackspacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHackspacher/subscriptions","organizations_url":"https://api.github.com/users/MarkusHackspacher/orgs","repos_url":"https://api.github.com/users/MarkusHackspacher/repos","events_url":"https://api.github.com/users/MarkusHackspacher/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHackspacher/received_events","type":"User","site_admin":false},"repo":{"id":22783414,"name":"unknown-horizons","full_name":"MarkusHackspacher/unknown-horizons","owner":{"login":"MarkusHackspacher","id":1457863,"avatar_url":"https://avatars.githubusercontent.com/u/1457863?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusHackspacher","html_url":"https://github.com/MarkusHackspacher","followers_url":"https://api.github.com/users/MarkusHackspacher/followers","following_url":"https://api.github.com/users/MarkusHackspacher/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHackspacher/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHackspacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHackspacher/subscriptions","organizations_url":"https://api.github.com/users/MarkusHackspacher/orgs","repos_url":"https://api.github.com/users/MarkusHackspacher/repos","events_url":"https://api.github.com/users/MarkusHackspacher/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHackspacher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkusHackspacher/unknown-horizons","description":"Unknown Horizons","fork":true,"url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons","forks_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/forks","keys_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/events","assignees_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/merges","archive_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/MarkusHackspacher/unknown-horizons/deployments","created_at":"2014-08-09T09:45:41Z","updated_at":"2016-06-29T21:22:58Z","pushed_at":"2016-10-18T19:53:12Z","git_url":"git://github.com/MarkusHackspacher/unknown-horizons.git","ssh_url":"git@github.com:MarkusHackspacher/unknown-horizons.git","clone_url":"https://github.com/MarkusHackspacher/unknown-horizons.git","svn_url":"https://github.com/MarkusHackspacher/unknown-horizons","homepage":"http://www.unknown-horizons.org","size":486985,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"unknown-horizons:master","ref":"master","sha":"b8bbbc30bc303cfd13d17f64f1e102532ad39144","user":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars.githubusercontent.com/u/372796?v=3","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"repo":{"id":856193,"name":"unknown-horizons","full_name":"unknown-horizons/unknown-horizons","owner":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars.githubusercontent.com/u/372796?v=3","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unknown-horizons/unknown-horizons","description":"Unknown Horizons official code repository","fork":false,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","forks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/forks","keys_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/events","assignees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/merges","archive_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/deployments","created_at":"2010-08-23T08:48:29Z","updated_at":"2016-10-16T13:11:29Z","pushed_at":"2016-10-18T21:32:25Z","git_url":"git://github.com/unknown-horizons/unknown-horizons.git","ssh_url":"git@github.com:unknown-horizons/unknown-horizons.git","clone_url":"https://github.com/unknown-horizons/unknown-horizons.git","svn_url":"https://github.com/unknown-horizons/unknown-horizons","homepage":"http://www.unknown-horizons.org","size":524413,"stargazers_count":342,"watchers_count":342,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":258,"forks":126,"open_issues":258,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526"},"html":{"href":"https://github.com/unknown-horizons/unknown-horizons/pull/2526"},"issue":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2526"},"comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2526/comments"},"review_comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526/comments"},"review_comment":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2526/commits"},"statuses":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/6d4f9d0f86a387df4aeb7e33ab63cbb0e49cad7a"}}}}
{"actor":{"display_login":"squiddy"}}