{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/superset/pulls/comments/89945392","pull_request_review_id":10472673,"id":89945392,"diff_hunk":"@@ -871,6 +872,7 @@ class SqlaTable(Model, Queryable, AuditMixinNullable, ImportMixin):\n     default_endpoint = Column(Text)\n     database_id = Column(Integer, ForeignKey('dbs.id'), nullable=False)\n     is_featured = Column(Boolean, default=False)\n+    filter_select_enabled = Column(Boolean, default=False)","path":"superset/models.py","position":12,"original_position":12,"commit_id":"cc34fede72a9f34d664901ce4f78f5050138dc1b","original_commit_id":"cc34fede72a9f34d664901ce4f78f5050138dc1b","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"body":"is there any reason not to enable filter select all of the time?","created_at":"2016-11-29T05:56:59Z","updated_at":"2016-11-29T05:56:59Z","html_url":"https://github.com/airbnb/superset/pull/1697#discussion_r89945392","pull_request_url":"https://api.github.com/repos/airbnb/superset/pulls/1697","_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments/89945392"},"html":{"href":"https://github.com/airbnb/superset/pull/1697#discussion_r89945392"},"pull_request":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1697"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/superset/pulls/1697","id":95553580,"html_url":"https://github.com/airbnb/superset/pull/1697","diff_url":"https://github.com/airbnb/superset/pull/1697.diff","patch_url":"https://github.com/airbnb/superset/pull/1697.patch","issue_url":"https://api.github.com/repos/airbnb/superset/issues/1697","number":1697,"state":"open","locked":false,"title":"Enable freeform-select with fetched column values for filter values","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"body":"Credits to: @the-dcruz [https://github.com/airbnb/superset/pull/1061](url)\r\n Done:\r\n - db migration to add filter_select_enabled\r\n - add freeform-multi option for Selectfield\r\n - modify formatFilter() function on query to accomodate filter-select\r\n\r\nTo enable:\r\nin edit table mode:\r\n<img width=\"1343\" alt=\"screen shot 2016-11-28 at 10 23 37 am\" src=\"https://cloud.githubusercontent.com/assets/20978302/20680678/e1864c0e-b554-11e6-984b-3ba64f1fbf52.png\">\r\n\r\n\r\nSelect for filter-value:\r\n<img width=\"1411\" alt=\"screen shot 2016-11-28 at 10 18 40 am\" src=\"https://cloud.githubusercontent.com/assets/20978302/20680613/a4ed5a58-b554-11e6-9429-4f28258eec39.png\">\r\n\r\n<img width=\"1411\" alt=\"screen shot 2016-11-28 at 10 18 40 am\" src=\"https://cloud.githubusercontent.com/assets/20978302/20680621/ab03065e-b554-11e6-95c1-180eb8f2ddcb.png\">\r\n\r\nneeds-review @mistercrunch @ascott @bkyryliuk \r\n","created_at":"2016-11-28T18:38:11Z","updated_at":"2016-11-29T05:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a14c4fa6f4482e1f57231ec592a57856a0649d9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/superset/pulls/1697/commits","review_comments_url":"https://api.github.com/repos/airbnb/superset/pulls/1697/comments","review_comment_url":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/superset/issues/1697/comments","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/cc34fede72a9f34d664901ce4f78f5050138dc1b","head":{"label":"vera-liu:freeform_select_filter","ref":"freeform_select_filter","sha":"cc34fede72a9f34d664901ce4f78f5050138dc1b","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"repo":{"id":65501764,"name":"caravel","full_name":"vera-liu/caravel","owner":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vera-liu/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/vera-liu/caravel","forks_url":"https://api.github.com/repos/vera-liu/caravel/forks","keys_url":"https://api.github.com/repos/vera-liu/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vera-liu/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vera-liu/caravel/teams","hooks_url":"https://api.github.com/repos/vera-liu/caravel/hooks","issue_events_url":"https://api.github.com/repos/vera-liu/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/vera-liu/caravel/events","assignees_url":"https://api.github.com/repos/vera-liu/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/vera-liu/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/vera-liu/caravel/tags","blobs_url":"https://api.github.com/repos/vera-liu/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vera-liu/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vera-liu/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vera-liu/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vera-liu/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/vera-liu/caravel/languages","stargazers_url":"https://api.github.com/repos/vera-liu/caravel/stargazers","contributors_url":"https://api.github.com/repos/vera-liu/caravel/contributors","subscribers_url":"https://api.github.com/repos/vera-liu/caravel/subscribers","subscription_url":"https://api.github.com/repos/vera-liu/caravel/subscription","commits_url":"https://api.github.com/repos/vera-liu/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vera-liu/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vera-liu/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vera-liu/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vera-liu/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/vera-liu/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vera-liu/caravel/merges","archive_url":"https://api.github.com/repos/vera-liu/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vera-liu/caravel/downloads","issues_url":"https://api.github.com/repos/vera-liu/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/vera-liu/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/vera-liu/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/vera-liu/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vera-liu/caravel/labels{/name}","releases_url":"https://api.github.com/repos/vera-liu/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/vera-liu/caravel/deployments","created_at":"2016-08-11T21:10:17Z","updated_at":"2016-08-11T21:10:18Z","pushed_at":"2016-11-29T04:52:31Z","git_url":"git://github.com/vera-liu/caravel.git","ssh_url":"git@github.com:vera-liu/caravel.git","clone_url":"https://github.com/vera-liu/caravel.git","svn_url":"https://github.com/vera-liu/caravel","homepage":"","size":38464,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"84e8f741ae969888c4f2501ada132f58bdcfb249","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"superset","full_name":"airbnb/superset","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/superset","description":"Superset is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/superset","forks_url":"https://api.github.com/repos/airbnb/superset/forks","keys_url":"https://api.github.com/repos/airbnb/superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/superset/teams","hooks_url":"https://api.github.com/repos/airbnb/superset/hooks","issue_events_url":"https://api.github.com/repos/airbnb/superset/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/superset/events","assignees_url":"https://api.github.com/repos/airbnb/superset/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/superset/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/superset/tags","blobs_url":"https://api.github.com/repos/airbnb/superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/superset/languages","stargazers_url":"https://api.github.com/repos/airbnb/superset/stargazers","contributors_url":"https://api.github.com/repos/airbnb/superset/contributors","subscribers_url":"https://api.github.com/repos/airbnb/superset/subscribers","subscription_url":"https://api.github.com/repos/airbnb/superset/subscription","commits_url":"https://api.github.com/repos/airbnb/superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/superset/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/superset/merges","archive_url":"https://api.github.com/repos/airbnb/superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/superset/downloads","issues_url":"https://api.github.com/repos/airbnb/superset/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/superset/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/superset/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/superset/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/superset/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-11-29T05:46:03Z","pushed_at":"2016-11-29T05:05:38Z","git_url":"git://github.com/airbnb/superset.git","ssh_url":"git@github.com:airbnb/superset.git","clone_url":"https://github.com/airbnb/superset.git","svn_url":"https://github.com/airbnb/superset","homepage":"","size":46308,"stargazers_count":9174,"watchers_count":9174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1092,"mirror_url":null,"open_issues_count":342,"forks":1092,"open_issues":342,"watchers":9174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1697"},"html":{"href":"https://github.com/airbnb/superset/pull/1697"},"issue":{"href":"https://api.github.com/repos/airbnb/superset/issues/1697"},"comments":{"href":"https://api.github.com/repos/airbnb/superset/issues/1697/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1697/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1697/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/superset/statuses/cc34fede72a9f34d664901ce4f78f5050138dc1b"}}}}
{"actor":{"display_login":"ascott"}}