{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/61349241","id":61349241,"diff_hunk":"@@ -1064,7 +1054,8 @@ zfsctl_snapshot_mount(struct path *path, int flags)\n \tzfs_sb_t *snap_zsb;\n \tzfs_snapentry_t *se;\n \tchar *full_name, *full_path;\n-\tchar *argv[] = { \"/bin/sh\", \"-c\", NULL, NULL };\n+\tchar *argv[] = { \"/usr/libexec/zfs/z_usermodehelper\", \"mount\",","path":"module/zfs/zfs_ctldir.c","position":57,"original_position":57,"commit_id":"f282c4bafb7bc945cdb5e7d0beb253521a8b467b","original_commit_id":"25266c4c515f060391b3e234d2026917f780c509","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"body":"Great, then we'll need to implement a minimal `/sbin/umount.zfs`.","created_at":"2016-04-27T22:40:45Z","updated_at":"2016-04-27T22:40:45Z","html_url":"https://github.com/zfsonlinux/zfs/pull/4568#discussion_r61349241","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/61349241"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4568#discussion_r61349241"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568","id":68009770,"html_url":"https://github.com/zfsonlinux/zfs/pull/4568","diff_url":"https://github.com/zfsonlinux/zfs/pull/4568.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4568.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4568","number":4568,"state":"open","locked":false,"title":"Grsecurity compat: Add dedicated usermode helper","user":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"body":"Add executable z_usermodehelper in /usr/libexec. This usermode helper is\r\nused in place of the calls to /bin/sh in zfs_ctldir.c, which were not\r\npermitted by grsecurity.\r\n\r\nFixes #4377","created_at":"2016-04-27T07:42:00Z","updated_at":"2016-04-27T22:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5adf9e08d38b0fbe344e46dc5415bcd3cd90807c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4568/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f282c4bafb7bc945cdb5e7d0beb253521a8b467b","head":{"label":"stiell:grsec-compat","ref":"grsec-compat","sha":"f282c4bafb7bc945cdb5e7d0beb253521a8b467b","user":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"repo":{"id":57029938,"name":"zfs","full_name":"stiell/zfs","owner":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stiell/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/stiell/zfs","forks_url":"https://api.github.com/repos/stiell/zfs/forks","keys_url":"https://api.github.com/repos/stiell/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stiell/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stiell/zfs/teams","hooks_url":"https://api.github.com/repos/stiell/zfs/hooks","issue_events_url":"https://api.github.com/repos/stiell/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/stiell/zfs/events","assignees_url":"https://api.github.com/repos/stiell/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/stiell/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/stiell/zfs/tags","blobs_url":"https://api.github.com/repos/stiell/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stiell/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stiell/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stiell/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stiell/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/stiell/zfs/languages","stargazers_url":"https://api.github.com/repos/stiell/zfs/stargazers","contributors_url":"https://api.github.com/repos/stiell/zfs/contributors","subscribers_url":"https://api.github.com/repos/stiell/zfs/subscribers","subscription_url":"https://api.github.com/repos/stiell/zfs/subscription","commits_url":"https://api.github.com/repos/stiell/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stiell/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stiell/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stiell/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stiell/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/stiell/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stiell/zfs/merges","archive_url":"https://api.github.com/repos/stiell/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stiell/zfs/downloads","issues_url":"https://api.github.com/repos/stiell/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/stiell/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/stiell/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/stiell/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stiell/zfs/labels{/name}","releases_url":"https://api.github.com/repos/stiell/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/stiell/zfs/deployments","created_at":"2016-04-25T09:37:45Z","updated_at":"2016-04-25T09:37:51Z","pushed_at":"2016-04-27T08:45:32Z","git_url":"git://github.com/stiell/zfs.git","ssh_url":"git@github.com:stiell/zfs.git","clone_url":"https://github.com/stiell/zfs.git","svn_url":"https://github.com/stiell/zfs","homepage":"http://zfsonlinux.org/","size":27966,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"325414e483a7858c1d10fb30cefe5749207098f4","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"Native ZFS for Linux","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-04-27T22:26:42Z","pushed_at":"2016-04-27T20:47:41Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":53077,"stargazers_count":1764,"watchers_count":1764,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"open_issues_count":1011,"forks":458,"open_issues":1011,"watchers":1764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4568"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4568"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4568/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4568/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f282c4bafb7bc945cdb5e7d0beb253521a8b467b"}}}}