{"action":"created","issue":{"url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/34","repository_url":"https://api.github.com/repos/cargomedia/janus-gateway-js","labels_url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/34/comments","events_url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/34/events","html_url":"https://github.com/cargomedia/janus-gateway-js/pull/34","id":157244380,"number":34,"title":"MediaPlugin","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-27T16:30:14Z","updated_at":"2016-05-31T10:08:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cargomedia/janus-gateway-js/pulls/34","html_url":"https://github.com/cargomedia/janus-gateway-js/pull/34","diff_url":"https://github.com/cargomedia/janus-gateway-js/pull/34.diff","patch_url":"https://github.com/cargomedia/janus-gateway-js/pull/34.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/comments/222646730","html_url":"https://github.com/cargomedia/janus-gateway-js/pull/34#issuecomment-222646730","issue_url":"https://api.github.com/repos/cargomedia/janus-gateway-js/issues/34","id":222646730,"user":{"login":"zazabe","id":401598,"avatar_url":"https://avatars.githubusercontent.com/u/401598?v=3","gravatar_id":"","url":"https://api.github.com/users/zazabe","html_url":"https://github.com/zazabe","followers_url":"https://api.github.com/users/zazabe/followers","following_url":"https://api.github.com/users/zazabe/following{/other_user}","gists_url":"https://api.github.com/users/zazabe/gists{/gist_id}","starred_url":"https://api.github.com/users/zazabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazabe/subscriptions","organizations_url":"https://api.github.com/users/zazabe/orgs","repos_url":"https://api.github.com/users/zazabe/repos","events_url":"https://api.github.com/users/zazabe/events{/privacy}","received_events_url":"https://api.github.com/users/zazabe/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T10:08:21Z","updated_at":"2016-05-31T10:08:21Z","body":"- some missing docus\r\n- not sure if we really need `IceCandidateListener` / `IceCandidate`, is it not possible to just deal with plain object?  \r\n- https://www.npmjs.com/package/webrtc-adapter is not supposed to provide the shim for `getUserMedia`, etc... ?\r\n- the `pc.onicecandidate` callback should be registered when the `PeerConnection` is instantiated, because we may listen multiple times to `candidate/complete` in `MediaPlugin::_createSDP`  if an offer is created first, and then an answer\r\n- not sure, but in `janus.js`, for `createOffer/createAnswer`, all candidates must have been received before calling the success callback: https://github.com/meetecho/janus-gateway/blob/master/html/janus.js#L1641    \r\n  I don't understand exactly what will happen if `(!config.iceDone && !config.trickle) == true`, obviously, no `callbacks.success`, but then... ?"}}
{"actor":{"display_login":"zazabe"}}