{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12","id":89609750,"html_url":"https://github.com/exponentjs/exponent-docs/pull/12","diff_url":"https://github.com/exponentjs/exponent-docs/pull/12.diff","patch_url":"https://github.com/exponentjs/exponent-docs/pull/12.patch","issue_url":"https://api.github.com/repos/exponentjs/exponent-docs/issues/12","number":12,"state":"closed","locked":false,"title":"Update documentation to match module functionality","user":{"login":"benkaiser","id":608054,"avatar_url":"https://avatars.githubusercontent.com/u/608054?v=3","gravatar_id":"","url":"https://api.github.com/users/benkaiser","html_url":"https://github.com/benkaiser","followers_url":"https://api.github.com/users/benkaiser/followers","following_url":"https://api.github.com/users/benkaiser/following{/other_user}","gists_url":"https://api.github.com/users/benkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/benkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benkaiser/subscriptions","organizations_url":"https://api.github.com/users/benkaiser/orgs","repos_url":"https://api.github.com/users/benkaiser/repos","events_url":"https://api.github.com/users/benkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/benkaiser/received_events","type":"User","site_admin":false},"body":"I just spend 20 minutes trying to work out why the app was failing on my device when I was following the docs only to realise the docs didn't match the module: https://github.com/exponentjs/exponent-sdk/blob/6a07b8be5a3ab1eb9ca048284ae0520d7649e4e6/src/Components/Video.js#L144","created_at":"2016-10-17T12:00:42Z","updated_at":"2016-10-19T21:08:47Z","closed_at":"2016-10-19T21:08:47Z","merged_at":null,"merge_commit_sha":"3dd3662ff831b1c46d84654fe22cfa06a5dc61c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12/commits","review_comments_url":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12/comments","review_comment_url":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exponentjs/exponent-docs/issues/12/comments","statuses_url":"https://api.github.com/repos/exponentjs/exponent-docs/statuses/e0cf2b432cf5144e0425b1881e8fda56882e0c64","head":{"label":"benkaiser:patch-2","ref":"patch-2","sha":"e0cf2b432cf5144e0425b1881e8fda56882e0c64","user":{"login":"benkaiser","id":608054,"avatar_url":"https://avatars.githubusercontent.com/u/608054?v=3","gravatar_id":"","url":"https://api.github.com/users/benkaiser","html_url":"https://github.com/benkaiser","followers_url":"https://api.github.com/users/benkaiser/followers","following_url":"https://api.github.com/users/benkaiser/following{/other_user}","gists_url":"https://api.github.com/users/benkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/benkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benkaiser/subscriptions","organizations_url":"https://api.github.com/users/benkaiser/orgs","repos_url":"https://api.github.com/users/benkaiser/repos","events_url":"https://api.github.com/users/benkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/benkaiser/received_events","type":"User","site_admin":false},"repo":{"id":71133313,"name":"exponent-docs","full_name":"benkaiser/exponent-docs","owner":{"login":"benkaiser","id":608054,"avatar_url":"https://avatars.githubusercontent.com/u/608054?v=3","gravatar_id":"","url":"https://api.github.com/users/benkaiser","html_url":"https://github.com/benkaiser","followers_url":"https://api.github.com/users/benkaiser/followers","following_url":"https://api.github.com/users/benkaiser/following{/other_user}","gists_url":"https://api.github.com/users/benkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/benkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benkaiser/subscriptions","organizations_url":"https://api.github.com/users/benkaiser/orgs","repos_url":"https://api.github.com/users/benkaiser/repos","events_url":"https://api.github.com/users/benkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/benkaiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benkaiser/exponent-docs","description":"Documentation!","fork":true,"url":"https://api.github.com/repos/benkaiser/exponent-docs","forks_url":"https://api.github.com/repos/benkaiser/exponent-docs/forks","keys_url":"https://api.github.com/repos/benkaiser/exponent-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benkaiser/exponent-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benkaiser/exponent-docs/teams","hooks_url":"https://api.github.com/repos/benkaiser/exponent-docs/hooks","issue_events_url":"https://api.github.com/repos/benkaiser/exponent-docs/issues/events{/number}","events_url":"https://api.github.com/repos/benkaiser/exponent-docs/events","assignees_url":"https://api.github.com/repos/benkaiser/exponent-docs/assignees{/user}","branches_url":"https://api.github.com/repos/benkaiser/exponent-docs/branches{/branch}","tags_url":"https://api.github.com/repos/benkaiser/exponent-docs/tags","blobs_url":"https://api.github.com/repos/benkaiser/exponent-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benkaiser/exponent-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benkaiser/exponent-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/benkaiser/exponent-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benkaiser/exponent-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/benkaiser/exponent-docs/languages","stargazers_url":"https://api.github.com/repos/benkaiser/exponent-docs/stargazers","contributors_url":"https://api.github.com/repos/benkaiser/exponent-docs/contributors","subscribers_url":"https://api.github.com/repos/benkaiser/exponent-docs/subscribers","subscription_url":"https://api.github.com/repos/benkaiser/exponent-docs/subscription","commits_url":"https://api.github.com/repos/benkaiser/exponent-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/benkaiser/exponent-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/benkaiser/exponent-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/benkaiser/exponent-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/benkaiser/exponent-docs/contents/{+path}","compare_url":"https://api.github.com/repos/benkaiser/exponent-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benkaiser/exponent-docs/merges","archive_url":"https://api.github.com/repos/benkaiser/exponent-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benkaiser/exponent-docs/downloads","issues_url":"https://api.github.com/repos/benkaiser/exponent-docs/issues{/number}","pulls_url":"https://api.github.com/repos/benkaiser/exponent-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/benkaiser/exponent-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/benkaiser/exponent-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benkaiser/exponent-docs/labels{/name}","releases_url":"https://api.github.com/repos/benkaiser/exponent-docs/releases{/id}","deployments_url":"https://api.github.com/repos/benkaiser/exponent-docs/deployments","created_at":"2016-10-17T11:56:41Z","updated_at":"2016-10-17T11:56:42Z","pushed_at":"2016-10-17T11:59:49Z","git_url":"git://github.com/benkaiser/exponent-docs.git","ssh_url":"git@github.com:benkaiser/exponent-docs.git","clone_url":"https://github.com/benkaiser/exponent-docs.git","svn_url":"https://github.com/benkaiser/exponent-docs","homepage":null,"size":13542,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exponentjs:master","ref":"master","sha":"816cd76a276b17d58eced24989f5cd8ec506be7c","user":{"login":"exponentjs","id":12504344,"avatar_url":"https://avatars.githubusercontent.com/u/12504344?v=3","gravatar_id":"","url":"https://api.github.com/users/exponentjs","html_url":"https://github.com/exponentjs","followers_url":"https://api.github.com/users/exponentjs/followers","following_url":"https://api.github.com/users/exponentjs/following{/other_user}","gists_url":"https://api.github.com/users/exponentjs/gists{/gist_id}","starred_url":"https://api.github.com/users/exponentjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exponentjs/subscriptions","organizations_url":"https://api.github.com/users/exponentjs/orgs","repos_url":"https://api.github.com/users/exponentjs/repos","events_url":"https://api.github.com/users/exponentjs/events{/privacy}","received_events_url":"https://api.github.com/users/exponentjs/received_events","type":"Organization","site_admin":false},"repo":{"id":60140476,"name":"exponent-docs","full_name":"exponentjs/exponent-docs","owner":{"login":"exponentjs","id":12504344,"avatar_url":"https://avatars.githubusercontent.com/u/12504344?v=3","gravatar_id":"","url":"https://api.github.com/users/exponentjs","html_url":"https://github.com/exponentjs","followers_url":"https://api.github.com/users/exponentjs/followers","following_url":"https://api.github.com/users/exponentjs/following{/other_user}","gists_url":"https://api.github.com/users/exponentjs/gists{/gist_id}","starred_url":"https://api.github.com/users/exponentjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exponentjs/subscriptions","organizations_url":"https://api.github.com/users/exponentjs/orgs","repos_url":"https://api.github.com/users/exponentjs/repos","events_url":"https://api.github.com/users/exponentjs/events{/privacy}","received_events_url":"https://api.github.com/users/exponentjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exponentjs/exponent-docs","description":"Documentation!","fork":false,"url":"https://api.github.com/repos/exponentjs/exponent-docs","forks_url":"https://api.github.com/repos/exponentjs/exponent-docs/forks","keys_url":"https://api.github.com/repos/exponentjs/exponent-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exponentjs/exponent-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exponentjs/exponent-docs/teams","hooks_url":"https://api.github.com/repos/exponentjs/exponent-docs/hooks","issue_events_url":"https://api.github.com/repos/exponentjs/exponent-docs/issues/events{/number}","events_url":"https://api.github.com/repos/exponentjs/exponent-docs/events","assignees_url":"https://api.github.com/repos/exponentjs/exponent-docs/assignees{/user}","branches_url":"https://api.github.com/repos/exponentjs/exponent-docs/branches{/branch}","tags_url":"https://api.github.com/repos/exponentjs/exponent-docs/tags","blobs_url":"https://api.github.com/repos/exponentjs/exponent-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exponentjs/exponent-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exponentjs/exponent-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/exponentjs/exponent-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exponentjs/exponent-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/exponentjs/exponent-docs/languages","stargazers_url":"https://api.github.com/repos/exponentjs/exponent-docs/stargazers","contributors_url":"https://api.github.com/repos/exponentjs/exponent-docs/contributors","subscribers_url":"https://api.github.com/repos/exponentjs/exponent-docs/subscribers","subscription_url":"https://api.github.com/repos/exponentjs/exponent-docs/subscription","commits_url":"https://api.github.com/repos/exponentjs/exponent-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/exponentjs/exponent-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/exponentjs/exponent-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/exponentjs/exponent-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/exponentjs/exponent-docs/contents/{+path}","compare_url":"https://api.github.com/repos/exponentjs/exponent-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exponentjs/exponent-docs/merges","archive_url":"https://api.github.com/repos/exponentjs/exponent-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exponentjs/exponent-docs/downloads","issues_url":"https://api.github.com/repos/exponentjs/exponent-docs/issues{/number}","pulls_url":"https://api.github.com/repos/exponentjs/exponent-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/exponentjs/exponent-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/exponentjs/exponent-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exponentjs/exponent-docs/labels{/name}","releases_url":"https://api.github.com/repos/exponentjs/exponent-docs/releases{/id}","deployments_url":"https://api.github.com/repos/exponentjs/exponent-docs/deployments","created_at":"2016-06-01T02:50:34Z","updated_at":"2016-10-11T20:49:19Z","pushed_at":"2016-10-19T21:08:46Z","git_url":"git://github.com/exponentjs/exponent-docs.git","ssh_url":"git@github.com:exponentjs/exponent-docs.git","clone_url":"https://github.com/exponentjs/exponent-docs.git","svn_url":"https://github.com/exponentjs/exponent-docs","homepage":null,"size":13565,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12"},"html":{"href":"https://github.com/exponentjs/exponent-docs/pull/12"},"issue":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/issues/12"},"comments":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/exponentjs/exponent-docs/statuses/e0cf2b432cf5144e0425b1881e8fda56882e0c64"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"expbot"}}