{"action":"created","issue":{"url":"https://api.github.com/repos/posthtml/posthtml/issues/103","labels_url":"https://api.github.com/repos/posthtml/posthtml/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/posthtml/posthtml/issues/103/comments","events_url":"https://api.github.com/repos/posthtml/posthtml/issues/103/events","html_url":"https://github.com/posthtml/posthtml/issues/103","id":128695048,"number":103,"title":"posthtml hanging, potentially while walking a tree?","user":{"login":"devinus","id":4836,"avatar_url":"https://avatars.githubusercontent.com/u/4836?v=3","gravatar_id":"","url":"https://api.github.com/users/devinus","html_url":"https://github.com/devinus","followers_url":"https://api.github.com/users/devinus/followers","following_url":"https://api.github.com/users/devinus/following{/other_user}","gists_url":"https://api.github.com/users/devinus/gists{/gist_id}","starred_url":"https://api.github.com/users/devinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinus/subscriptions","organizations_url":"https://api.github.com/users/devinus/orgs","repos_url":"https://api.github.com/users/devinus/repos","events_url":"https://api.github.com/users/devinus/events{/privacy}","received_events_url":"https://api.github.com/users/devinus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-26T01:47:09Z","updated_at":"2016-01-26T02:55:25Z","closed_at":"2016-01-26T02:55:25Z","body":"Hey there,\r\n\r\nWe're exploring converting our many HTML plugins to the PostHTML ecosystem. While converting one of them, we found that a simple change is causing the process to hang.\r\n\r\nhttps://github.com/Rebelmail/html-uglify/tree/posthtml\r\n\r\nRunning the tests with `npm test` in that branch will expose the bug.\r\n\r\nChanging this line https://github.com/Rebelmail/html-uglify/blob/posthtml/lib/main.js#L106 to something like `node.attrs[type] = 'XXX'` seems to make the hang go away.\r\n\r\nMy gut reaction is that this has to do with posthtml getting confused since we're modifying attributes. Any ideas? (Because we're stuck.)"},"comment":{"url":"https://api.github.com/repos/posthtml/posthtml/issues/comments/174790825","html_url":"https://github.com/posthtml/posthtml/issues/103#issuecomment-174790825","issue_url":"https://api.github.com/repos/posthtml/posthtml/issues/103","id":174790825,"user":{"login":"devinus","id":4836,"avatar_url":"https://avatars.githubusercontent.com/u/4836?v=3","gravatar_id":"","url":"https://api.github.com/users/devinus","html_url":"https://github.com/devinus","followers_url":"https://api.github.com/users/devinus/followers","following_url":"https://api.github.com/users/devinus/following{/other_user}","gists_url":"https://api.github.com/users/devinus/gists{/gist_id}","starred_url":"https://api.github.com/users/devinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinus/subscriptions","organizations_url":"https://api.github.com/users/devinus/orgs","repos_url":"https://api.github.com/users/devinus/repos","events_url":"https://api.github.com/users/devinus/events{/privacy}","received_events_url":"https://api.github.com/users/devinus/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T02:55:24Z","updated_at":"2016-01-26T02:55:24Z","body":"I'm an idiot. Ignore."}}