{"action":"closed","issue":{"url":"https://api.github.com/repos/CS2103AUG2016-T11-C3/main/issues/121","repository_url":"https://api.github.com/repos/CS2103AUG2016-T11-C3/main","labels_url":"https://api.github.com/repos/CS2103AUG2016-T11-C3/main/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/CS2103AUG2016-T11-C3/main/issues/121/comments","events_url":"https://api.github.com/repos/CS2103AUG2016-T11-C3/main/issues/121/events","html_url":"https://github.com/CS2103AUG2016-T11-C3/main/issues/121","id":186066904,"number":121,"title":"Feedback for code quality of A0139024M","user":{"login":"kychua","id":7569990,"avatar_url":"https://avatars.githubusercontent.com/u/7569990?v=3","gravatar_id":"","url":"https://api.github.com/users/kychua","html_url":"https://github.com/kychua","followers_url":"https://api.github.com/users/kychua/followers","following_url":"https://api.github.com/users/kychua/following{/other_user}","gists_url":"https://api.github.com/users/kychua/gists{/gist_id}","starred_url":"https://api.github.com/users/kychua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kychua/subscriptions","organizations_url":"https://api.github.com/users/kychua/orgs","repos_url":"https://api.github.com/users/kychua/repos","events_url":"https://api.github.com/users/kychua/events{/privacy}","received_events_url":"https://api.github.com/users/kychua/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-29T08:26:59Z","updated_at":"2016-11-03T02:22:53Z","closed_at":"2016-11-03T02:22:53Z","body":"# main\n- Missing header comments for methods & classes\n  ![](https://cloud.githubusercontent.com/assets/7569990/19828183/246a2736-9df2-11e6-9f01-521439cea1ac.png)\n- Pls follow coding standard (e.g. missing whitespaces, braces e.g. if-else in above pic, method names should be verbs e.g. model.overdueTask(target) -> markOverdue/setOverdue etc., postponed -> postpone) \n- Avoid very long lines (e.g. in checkStatus())\n- Why are you comparing to string instead of enum?\n  ![](https://cloud.githubusercontent.com/assets/7569990/19828187/46fbeb86-9df2-11e6-8a9b-26c5c796bef6.png)\n- SLAP can be improved e.g. checkStatus() method\n- better to throw `AssertionError` than have an empty catch, just in case\n  ![](https://cloud.githubusercontent.com/assets/7569990/19830259/6e617a72-9e26-11e6-9801-c1f154eacf2f.png)\n# test\n- No tests written?\n# doc\n- Remember to update AboutUs to the new format\n"}}
{"actor":{"display_login":"GitMeGet"}}