{"action":"created","comment":{"url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/comments/85161375","pull_request_review_id":5883537,"id":85161375,"diff_hunk":"@@ -0,0 +1,154 @@\n+#include \"catch.hpp\"\n+\n+#include \"cache.h\"\n+#include \"itemlist_formaction.h\"\n+#include \"keymap.h\"\n+#include \"stfl/itemlist.h\"\n+\n+#include <unistd.h>\n+\n+using namespace newsbeuter;\n+\n+TEST_CASE(\"itemlist_formaction::process_op()\") {\n+\n+\tcontroller c;\n+\tnewsbeuter::view v(&c);\n+\tstd::string test_browser_file = \"/tmp/test_browser.txt\";\n+\tstd::string test_url = \"http://test_url\";\n+\tstd::string cache_path = \"test-cache.db\";\n+\tstd::string line;\n+\tint itemCount = 6;\n+\tint openedItemsCount = 0;\n+\tint lineCount = 0;\n+\tint maxItems = 4;\n+\tint openedItemsTarget = 0;","path":"test/itemlist_formaction.cpp","position":24,"original_position":24,"commit_id":"0ee56783d6b20a05205c516fdf33fb6ae8159d36","original_commit_id":"0ee56783d6b20a05205c516fdf33fb6ae8159d36","user":{"login":"Minoru","id":118875,"avatar_url":"https://avatars.githubusercontent.com/u/118875?v=3","gravatar_id":"","url":"https://api.github.com/users/Minoru","html_url":"https://github.com/Minoru","followers_url":"https://api.github.com/users/Minoru/followers","following_url":"https://api.github.com/users/Minoru/following{/other_user}","gists_url":"https://api.github.com/users/Minoru/gists{/gist_id}","starred_url":"https://api.github.com/users/Minoru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minoru/subscriptions","organizations_url":"https://api.github.com/users/Minoru/orgs","repos_url":"https://api.github.com/users/Minoru/repos","events_url":"https://api.github.com/users/Minoru/events{/privacy}","received_events_url":"https://api.github.com/users/Minoru/received_events","type":"User","site_admin":false},"body":"I have two comments regarding all of these `int`s:\r\n1. Some of them look like constants, but I'm not entirely sure. If they are, just mark them `const`.\r\n2. It's kinda hard to read the tests because I have to flick between initializations here and the test cases. I suggest to violate DRY principle and re-declare all of these (save for constants, if any) inside test cases.","created_at":"2016-10-26T16:14:27Z","updated_at":"2016-10-26T16:15:06Z","html_url":"https://github.com/akrennmair/newsbeuter/pull/380#discussion_r85161375","pull_request_url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/comments/85161375"},"html":{"href":"https://github.com/akrennmair/newsbeuter/pull/380#discussion_r85161375"},"pull_request":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380","id":89813029,"html_url":"https://github.com/akrennmair/newsbeuter/pull/380","diff_url":"https://github.com/akrennmair/newsbeuter/pull/380.diff","patch_url":"https://github.com/akrennmair/newsbeuter/pull/380.patch","issue_url":"https://api.github.com/repos/akrennmair/newsbeuter/issues/380","number":380,"state":"open","locked":false,"title":"Open multiple articles in browser","user":{"login":"tkerdonc","id":6058292,"avatar_url":"https://avatars.githubusercontent.com/u/6058292?v=3","gravatar_id":"","url":"https://api.github.com/users/tkerdonc","html_url":"https://github.com/tkerdonc","followers_url":"https://api.github.com/users/tkerdonc/followers","following_url":"https://api.github.com/users/tkerdonc/following{/other_user}","gists_url":"https://api.github.com/users/tkerdonc/gists{/gist_id}","starred_url":"https://api.github.com/users/tkerdonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkerdonc/subscriptions","organizations_url":"https://api.github.com/users/tkerdonc/orgs","repos_url":"https://api.github.com/users/tkerdonc/repos","events_url":"https://api.github.com/users/tkerdonc/events{/privacy}","received_events_url":"https://api.github.com/users/tkerdonc/received_events","type":"User","site_admin":false},"body":"This adds commands to open multiple unread articles from the same\r\nfeed in the browser. These commands are named\r\nopen-all-in-browser and open-all-in-browser-and-mark-read with the\r\ndifference of marking opened items as read or not. Both commands are\r\navailable from the feed list view and the article list view.\r\n\r\nTo avoid mishaps, the number of articles that can be opened by these\r\ncommands is limited by the max-browser-tabs configuration command.","created_at":"2016-10-18T13:17:53Z","updated_at":"2016-10-26T16:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"069478e59fa8fca9885d0cbc46be99beaa27dd59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380/commits","review_comments_url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380/comments","review_comment_url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akrennmair/newsbeuter/issues/380/comments","statuses_url":"https://api.github.com/repos/akrennmair/newsbeuter/statuses/0ee56783d6b20a05205c516fdf33fb6ae8159d36","head":{"label":"tkerdonc:openAllInTabs","ref":"openAllInTabs","sha":"0ee56783d6b20a05205c516fdf33fb6ae8159d36","user":{"login":"tkerdonc","id":6058292,"avatar_url":"https://avatars.githubusercontent.com/u/6058292?v=3","gravatar_id":"","url":"https://api.github.com/users/tkerdonc","html_url":"https://github.com/tkerdonc","followers_url":"https://api.github.com/users/tkerdonc/followers","following_url":"https://api.github.com/users/tkerdonc/following{/other_user}","gists_url":"https://api.github.com/users/tkerdonc/gists{/gist_id}","starred_url":"https://api.github.com/users/tkerdonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkerdonc/subscriptions","organizations_url":"https://api.github.com/users/tkerdonc/orgs","repos_url":"https://api.github.com/users/tkerdonc/repos","events_url":"https://api.github.com/users/tkerdonc/events{/privacy}","received_events_url":"https://api.github.com/users/tkerdonc/received_events","type":"User","site_admin":false},"repo":{"id":71248197,"name":"newsbeuter","full_name":"tkerdonc/newsbeuter","owner":{"login":"tkerdonc","id":6058292,"avatar_url":"https://avatars.githubusercontent.com/u/6058292?v=3","gravatar_id":"","url":"https://api.github.com/users/tkerdonc","html_url":"https://github.com/tkerdonc","followers_url":"https://api.github.com/users/tkerdonc/followers","following_url":"https://api.github.com/users/tkerdonc/following{/other_user}","gists_url":"https://api.github.com/users/tkerdonc/gists{/gist_id}","starred_url":"https://api.github.com/users/tkerdonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkerdonc/subscriptions","organizations_url":"https://api.github.com/users/tkerdonc/orgs","repos_url":"https://api.github.com/users/tkerdonc/repos","events_url":"https://api.github.com/users/tkerdonc/events{/privacy}","received_events_url":"https://api.github.com/users/tkerdonc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkerdonc/newsbeuter","description":"Newsbeuter is an open-source RSS/Atom feed reader for text terminals.","fork":true,"url":"https://api.github.com/repos/tkerdonc/newsbeuter","forks_url":"https://api.github.com/repos/tkerdonc/newsbeuter/forks","keys_url":"https://api.github.com/repos/tkerdonc/newsbeuter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkerdonc/newsbeuter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkerdonc/newsbeuter/teams","hooks_url":"https://api.github.com/repos/tkerdonc/newsbeuter/hooks","issue_events_url":"https://api.github.com/repos/tkerdonc/newsbeuter/issues/events{/number}","events_url":"https://api.github.com/repos/tkerdonc/newsbeuter/events","assignees_url":"https://api.github.com/repos/tkerdonc/newsbeuter/assignees{/user}","branches_url":"https://api.github.com/repos/tkerdonc/newsbeuter/branches{/branch}","tags_url":"https://api.github.com/repos/tkerdonc/newsbeuter/tags","blobs_url":"https://api.github.com/repos/tkerdonc/newsbeuter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkerdonc/newsbeuter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkerdonc/newsbeuter/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkerdonc/newsbeuter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkerdonc/newsbeuter/statuses/{sha}","languages_url":"https://api.github.com/repos/tkerdonc/newsbeuter/languages","stargazers_url":"https://api.github.com/repos/tkerdonc/newsbeuter/stargazers","contributors_url":"https://api.github.com/repos/tkerdonc/newsbeuter/contributors","subscribers_url":"https://api.github.com/repos/tkerdonc/newsbeuter/subscribers","subscription_url":"https://api.github.com/repos/tkerdonc/newsbeuter/subscription","commits_url":"https://api.github.com/repos/tkerdonc/newsbeuter/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkerdonc/newsbeuter/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkerdonc/newsbeuter/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkerdonc/newsbeuter/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkerdonc/newsbeuter/contents/{+path}","compare_url":"https://api.github.com/repos/tkerdonc/newsbeuter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkerdonc/newsbeuter/merges","archive_url":"https://api.github.com/repos/tkerdonc/newsbeuter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkerdonc/newsbeuter/downloads","issues_url":"https://api.github.com/repos/tkerdonc/newsbeuter/issues{/number}","pulls_url":"https://api.github.com/repos/tkerdonc/newsbeuter/pulls{/number}","milestones_url":"https://api.github.com/repos/tkerdonc/newsbeuter/milestones{/number}","notifications_url":"https://api.github.com/repos/tkerdonc/newsbeuter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkerdonc/newsbeuter/labels{/name}","releases_url":"https://api.github.com/repos/tkerdonc/newsbeuter/releases{/id}","deployments_url":"https://api.github.com/repos/tkerdonc/newsbeuter/deployments","created_at":"2016-10-18T12:56:16Z","updated_at":"2016-10-18T12:56:18Z","pushed_at":"2016-10-26T12:57:15Z","git_url":"git://github.com/tkerdonc/newsbeuter.git","ssh_url":"git@github.com:tkerdonc/newsbeuter.git","clone_url":"https://github.com/tkerdonc/newsbeuter.git","svn_url":"https://github.com/tkerdonc/newsbeuter","homepage":"http://www.newsbeuter.org/","size":9572,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akrennmair:master","ref":"master","sha":"cd88b01b74f06d12dcf79c901d5294d84589f0e6","user":{"login":"akrennmair","id":41766,"avatar_url":"https://avatars.githubusercontent.com/u/41766?v=3","gravatar_id":"","url":"https://api.github.com/users/akrennmair","html_url":"https://github.com/akrennmair","followers_url":"https://api.github.com/users/akrennmair/followers","following_url":"https://api.github.com/users/akrennmair/following{/other_user}","gists_url":"https://api.github.com/users/akrennmair/gists{/gist_id}","starred_url":"https://api.github.com/users/akrennmair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrennmair/subscriptions","organizations_url":"https://api.github.com/users/akrennmair/orgs","repos_url":"https://api.github.com/users/akrennmair/repos","events_url":"https://api.github.com/users/akrennmair/events{/privacy}","received_events_url":"https://api.github.com/users/akrennmair/received_events","type":"User","site_admin":false},"repo":{"id":94329,"name":"newsbeuter","full_name":"akrennmair/newsbeuter","owner":{"login":"akrennmair","id":41766,"avatar_url":"https://avatars.githubusercontent.com/u/41766?v=3","gravatar_id":"","url":"https://api.github.com/users/akrennmair","html_url":"https://github.com/akrennmair","followers_url":"https://api.github.com/users/akrennmair/followers","following_url":"https://api.github.com/users/akrennmair/following{/other_user}","gists_url":"https://api.github.com/users/akrennmair/gists{/gist_id}","starred_url":"https://api.github.com/users/akrennmair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrennmair/subscriptions","organizations_url":"https://api.github.com/users/akrennmair/orgs","repos_url":"https://api.github.com/users/akrennmair/repos","events_url":"https://api.github.com/users/akrennmair/events{/privacy}","received_events_url":"https://api.github.com/users/akrennmair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akrennmair/newsbeuter","description":"Newsbeuter is an open-source RSS/Atom feed reader for text terminals.","fork":false,"url":"https://api.github.com/repos/akrennmair/newsbeuter","forks_url":"https://api.github.com/repos/akrennmair/newsbeuter/forks","keys_url":"https://api.github.com/repos/akrennmair/newsbeuter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akrennmair/newsbeuter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akrennmair/newsbeuter/teams","hooks_url":"https://api.github.com/repos/akrennmair/newsbeuter/hooks","issue_events_url":"https://api.github.com/repos/akrennmair/newsbeuter/issues/events{/number}","events_url":"https://api.github.com/repos/akrennmair/newsbeuter/events","assignees_url":"https://api.github.com/repos/akrennmair/newsbeuter/assignees{/user}","branches_url":"https://api.github.com/repos/akrennmair/newsbeuter/branches{/branch}","tags_url":"https://api.github.com/repos/akrennmair/newsbeuter/tags","blobs_url":"https://api.github.com/repos/akrennmair/newsbeuter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akrennmair/newsbeuter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akrennmair/newsbeuter/git/refs{/sha}","trees_url":"https://api.github.com/repos/akrennmair/newsbeuter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akrennmair/newsbeuter/statuses/{sha}","languages_url":"https://api.github.com/repos/akrennmair/newsbeuter/languages","stargazers_url":"https://api.github.com/repos/akrennmair/newsbeuter/stargazers","contributors_url":"https://api.github.com/repos/akrennmair/newsbeuter/contributors","subscribers_url":"https://api.github.com/repos/akrennmair/newsbeuter/subscribers","subscription_url":"https://api.github.com/repos/akrennmair/newsbeuter/subscription","commits_url":"https://api.github.com/repos/akrennmair/newsbeuter/commits{/sha}","git_commits_url":"https://api.github.com/repos/akrennmair/newsbeuter/git/commits{/sha}","comments_url":"https://api.github.com/repos/akrennmair/newsbeuter/comments{/number}","issue_comment_url":"https://api.github.com/repos/akrennmair/newsbeuter/issues/comments{/number}","contents_url":"https://api.github.com/repos/akrennmair/newsbeuter/contents/{+path}","compare_url":"https://api.github.com/repos/akrennmair/newsbeuter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akrennmair/newsbeuter/merges","archive_url":"https://api.github.com/repos/akrennmair/newsbeuter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akrennmair/newsbeuter/downloads","issues_url":"https://api.github.com/repos/akrennmair/newsbeuter/issues{/number}","pulls_url":"https://api.github.com/repos/akrennmair/newsbeuter/pulls{/number}","milestones_url":"https://api.github.com/repos/akrennmair/newsbeuter/milestones{/number}","notifications_url":"https://api.github.com/repos/akrennmair/newsbeuter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akrennmair/newsbeuter/labels{/name}","releases_url":"https://api.github.com/repos/akrennmair/newsbeuter/releases{/id}","deployments_url":"https://api.github.com/repos/akrennmair/newsbeuter/deployments","created_at":"2008-12-20T09:07:32Z","updated_at":"2016-10-24T05:17:02Z","pushed_at":"2016-10-26T15:23:22Z","git_url":"git://github.com/akrennmair/newsbeuter.git","ssh_url":"git@github.com:akrennmair/newsbeuter.git","clone_url":"https://github.com/akrennmair/newsbeuter.git","svn_url":"https://github.com/akrennmair/newsbeuter","homepage":"http://www.newsbeuter.org/","size":10654,"stargazers_count":608,"watchers_count":608,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":106,"forks":98,"open_issues":106,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380"},"html":{"href":"https://github.com/akrennmair/newsbeuter/pull/380"},"issue":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/issues/380"},"comments":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/akrennmair/newsbeuter/statuses/0ee56783d6b20a05205c516fdf33fb6ae8159d36"}}}}
{"actor":{"display_login":"Minoru"}}