{"action":"created","issue":{"url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/6","repository_url":"https://api.github.com/repos/joedolson/wp-accessibility","labels_url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/6/comments","events_url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/6/events","html_url":"https://github.com/joedolson/wp-accessibility/pull/6","id":143066121,"number":6,"title":"Update wp-accessibility.php","user":{"login":"jdelia","id":3217274,"avatar_url":"https://avatars.githubusercontent.com/u/3217274?v=3","gravatar_id":"","url":"https://api.github.com/users/jdelia","html_url":"https://github.com/jdelia","followers_url":"https://api.github.com/users/jdelia/followers","following_url":"https://api.github.com/users/jdelia/following{/other_user}","gists_url":"https://api.github.com/users/jdelia/gists{/gist_id}","starred_url":"https://api.github.com/users/jdelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdelia/subscriptions","organizations_url":"https://api.github.com/users/jdelia/orgs","repos_url":"https://api.github.com/users/jdelia/repos","events_url":"https://api.github.com/users/jdelia/events{/privacy}","received_events_url":"https://api.github.com/users/jdelia/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-23T20:06:04Z","updated_at":"2016-03-28T17:58:25Z","closed_at":"2016-03-28T17:58:25Z","pull_request":{"url":"https://api.github.com/repos/joedolson/wp-accessibility/pulls/6","html_url":"https://github.com/joedolson/wp-accessibility/pull/6","diff_url":"https://github.com/joedolson/wp-accessibility/pull/6.diff","patch_url":"https://github.com/joedolson/wp-accessibility/pull/6.patch"},"body":"Adding a test for is_main_query prevents the navigation menu from vanishing on empty searches as explained by @GaryJones \r\n\r\n\"WPA filters the query to add in a space for `s`\r\n\r\nHowever, that filter also kicks in when WP does a completely un-related query to get the nav menu items (they are posts too remember). Since s=' ' & post_type= nav_menu_item results in no results returned from the query, (presumably because the search query probably limits it to certain post types, and the nav query wants it to be a different post type, it can't be A and B at the same time), then the nav menu fails to show up.\""},"comment":{"url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/comments/202508938","html_url":"https://github.com/joedolson/wp-accessibility/pull/6#issuecomment-202508938","issue_url":"https://api.github.com/repos/joedolson/wp-accessibility/issues/6","id":202508938,"user":{"login":"joedolson","id":1686451,"avatar_url":"https://avatars.githubusercontent.com/u/1686451?v=3","gravatar_id":"","url":"https://api.github.com/users/joedolson","html_url":"https://github.com/joedolson","followers_url":"https://api.github.com/users/joedolson/followers","following_url":"https://api.github.com/users/joedolson/following{/other_user}","gists_url":"https://api.github.com/users/joedolson/gists{/gist_id}","starred_url":"https://api.github.com/users/joedolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joedolson/subscriptions","organizations_url":"https://api.github.com/users/joedolson/orgs","repos_url":"https://api.github.com/users/joedolson/repos","events_url":"https://api.github.com/users/joedolson/events{/privacy}","received_events_url":"https://api.github.com/users/joedolson/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T17:58:25Z","updated_at":"2016-03-28T17:58:25Z","body":"I'm closing without merging because I'm not yet really maintaining this project on GitHub, but I've added props for both of you in the readme."}}