{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/87765779","pull_request_review_id":8363735,"id":87765779,"diff_hunk":"@@ -320,19 +319,22 @@ void removePermissionsFromLocation(Iterable<IpPermission> permissions, final Str\n      * look for the uniqueSecurityGroup rather than the shared securityGroup.\n      *\n      * @param nodeId The id of the node in question\n-     * @param locationId The id of the location in question\n-     * @param securityApi The API to use to list security groups\n+     * @param groupEditor The id of the node in question\n      * @return the security group unique to the given node, or null if one could not be determined.\n      */\n-    private SecurityGroup getUniqueSecurityGroupForNodeCachingSharedGroupIfPreviouslyUnknown(String nodeId, String locationId, SecurityGroupExtension securityApi) {\n-        Set<SecurityGroup> groupsOnNode = securityApi.listSecurityGroupsForNode(nodeId);\n+    private SecurityGroup getUniqueSecurityGroupForNodeCachingSharedGroupIfPreviouslyUnknown(String nodeId,\n+             final JcloudsLocationSecurityGroupEditor groupEditor) {","path":"locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java","position":161,"original_position":161,"commit_id":"392216b30463f7936bafc4aae3b4b569f703b177","original_commit_id":"db25519f5aebedb636e4f6761fae8174f0749ff7","user":{"login":"geomacy","id":14142759,"avatar_url":"https://avatars.githubusercontent.com/u/14142759?v=3","gravatar_id":"","url":"https://api.github.com/users/geomacy","html_url":"https://github.com/geomacy","followers_url":"https://api.github.com/users/geomacy/followers","following_url":"https://api.github.com/users/geomacy/following{/other_user}","gists_url":"https://api.github.com/users/geomacy/gists{/gist_id}","starred_url":"https://api.github.com/users/geomacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomacy/subscriptions","organizations_url":"https://api.github.com/users/geomacy/orgs","repos_url":"https://api.github.com/users/geomacy/repos","events_url":"https://api.github.com/users/geomacy/events{/privacy}","received_events_url":"https://api.github.com/users/geomacy/received_events","type":"User","site_admin":false},"body":"+100!  I'd vote 120 chars max. Much nicer when reviewing code on Github if nothing else.","created_at":"2016-11-14T09:43:27Z","updated_at":"2016-11-14T09:43:27Z","html_url":"https://github.com/apache/brooklyn-server/pull/425#discussion_r87765779","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/87765779"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/425#discussion_r87765779"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/425","id":93171989,"html_url":"https://github.com/apache/brooklyn-server/pull/425","diff_url":"https://github.com/apache/brooklyn-server/pull/425.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/425.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/425","number":425,"state":"open","locked":false,"title":"Do not merge; for review only; network experiments.","user":{"login":"geomacy","id":14142759,"avatar_url":"https://avatars.githubusercontent.com/u/14142759?v=3","gravatar_id":"","url":"https://api.github.com/users/geomacy","html_url":"https://github.com/geomacy","followers_url":"https://api.github.com/users/geomacy/followers","following_url":"https://api.github.com/users/geomacy/following{/other_user}","gists_url":"https://api.github.com/users/geomacy/gists{/gist_id}","starred_url":"https://api.github.com/users/geomacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomacy/subscriptions","organizations_url":"https://api.github.com/users/geomacy/orgs","repos_url":"https://api.github.com/users/geomacy/repos","events_url":"https://api.github.com/users/geomacy/events{/privacy}","received_events_url":"https://api.github.com/users/geomacy/received_events","type":"User","site_admin":false},"body":"Some experimental code relating to a proposal to add security 'networks' into Brooklyn.","created_at":"2016-11-10T15:30:01Z","updated_at":"2016-11-14T09:43:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa99483c8c55876f8f8c0a99252f2bed36edd021","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/425/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/425/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/425/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/392216b30463f7936bafc4aae3b4b569f703b177","head":{"label":"geomacy:network-investigations","ref":"network-investigations","sha":"392216b30463f7936bafc4aae3b4b569f703b177","user":{"login":"geomacy","id":14142759,"avatar_url":"https://avatars.githubusercontent.com/u/14142759?v=3","gravatar_id":"","url":"https://api.github.com/users/geomacy","html_url":"https://github.com/geomacy","followers_url":"https://api.github.com/users/geomacy/followers","following_url":"https://api.github.com/users/geomacy/following{/other_user}","gists_url":"https://api.github.com/users/geomacy/gists{/gist_id}","starred_url":"https://api.github.com/users/geomacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomacy/subscriptions","organizations_url":"https://api.github.com/users/geomacy/orgs","repos_url":"https://api.github.com/users/geomacy/repos","events_url":"https://api.github.com/users/geomacy/events{/privacy}","received_events_url":"https://api.github.com/users/geomacy/received_events","type":"User","site_admin":false},"repo":{"id":50995043,"name":"brooklyn-server","full_name":"geomacy/brooklyn-server","owner":{"login":"geomacy","id":14142759,"avatar_url":"https://avatars.githubusercontent.com/u/14142759?v=3","gravatar_id":"","url":"https://api.github.com/users/geomacy","html_url":"https://github.com/geomacy","followers_url":"https://api.github.com/users/geomacy/followers","following_url":"https://api.github.com/users/geomacy/following{/other_user}","gists_url":"https://api.github.com/users/geomacy/gists{/gist_id}","starred_url":"https://api.github.com/users/geomacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomacy/subscriptions","organizations_url":"https://api.github.com/users/geomacy/orgs","repos_url":"https://api.github.com/users/geomacy/repos","events_url":"https://api.github.com/users/geomacy/events{/privacy}","received_events_url":"https://api.github.com/users/geomacy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geomacy/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/geomacy/brooklyn-server","forks_url":"https://api.github.com/repos/geomacy/brooklyn-server/forks","keys_url":"https://api.github.com/repos/geomacy/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geomacy/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geomacy/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/geomacy/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/geomacy/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/geomacy/brooklyn-server/events","assignees_url":"https://api.github.com/repos/geomacy/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/geomacy/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/geomacy/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/geomacy/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geomacy/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geomacy/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/geomacy/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geomacy/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/geomacy/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/geomacy/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/geomacy/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/geomacy/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/geomacy/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/geomacy/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/geomacy/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/geomacy/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/geomacy/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/geomacy/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/geomacy/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geomacy/brooklyn-server/merges","archive_url":"https://api.github.com/repos/geomacy/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geomacy/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/geomacy/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/geomacy/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/geomacy/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/geomacy/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geomacy/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/geomacy/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/geomacy/brooklyn-server/deployments","created_at":"2016-02-03T11:23:03Z","updated_at":"2016-10-26T10:01:42Z","pushed_at":"2016-11-11T18:14:21Z","git_url":"git://github.com/geomacy/brooklyn-server.git","ssh_url":"git@github.com:geomacy/brooklyn-server.git","clone_url":"https://github.com/geomacy/brooklyn-server.git","svn_url":"https://github.com/geomacy/brooklyn-server","homepage":null,"size":31739,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"691283817f4410cdcfeab1f9f0d63a897ce59db7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-11-01T11:09:27Z","pushed_at":"2016-11-13T16:41:45Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":32840,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":23,"forks":38,"open_issues":23,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/425"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/425"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/425"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/392216b30463f7936bafc4aae3b4b569f703b177"}}}}
{"actor":{"display_login":"geomacy"}}