{"action":"created","comment":{"url":"https://api.github.com/repos/serverless/serverless/pulls/comments/81268721","pull_request_review_id":2260721,"id":81268721,"diff_hunk":"@@ -31,7 +31,16 @@ module.exports = {\n \n   createStack() {\n     const stackName = `${this.serverless.service.service}-${this.options.stage}`;\n-\n+    if (/^[^a-zA-Z].+|.*[^a-zA-Z0-9\\-].*/.test(stackName) || stackName.length > 128) {\n+      const errorMessage = [\n+        `The stack name \"${stackName}\" is not quallify. `,\n+        'A stack name can contain only alphanumeric',\n+        ' (case sensitive) and hyphens. It must characters',","path":"lib/plugins/aws/deploy/lib/createStack.js","position":9,"original_position":9,"commit_id":"478209bfa6025248a1ef949f940a20fc80cca316","original_commit_id":"478209bfa6025248a1ef949f940a20fc80cca316","user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"body":"Could you update it like `It should start with an alphabetic character and shouldn't exceed 128 characters.`\r\n\r\nThank you 👍 ","created_at":"2016-09-30T02:02:14Z","updated_at":"2016-09-30T02:05:02Z","html_url":"https://github.com/serverless/serverless/pull/2198#discussion_r81268721","pull_request_url":"https://api.github.com/repos/serverless/serverless/pulls/2198","_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments/81268721"},"html":{"href":"https://github.com/serverless/serverless/pull/2198#discussion_r81268721"},"pull_request":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2198"}}},"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2198","id":86539454,"html_url":"https://github.com/serverless/serverless/pull/2198","diff_url":"https://github.com/serverless/serverless/pull/2198.diff","patch_url":"https://github.com/serverless/serverless/pull/2198.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2198","number":2198,"state":"open","locked":false,"title":"fix: #1973 deploy fails with unhelpful error message when service name is not a valid CF stack name","user":{"login":"zorrofox","id":1528417,"avatar_url":"https://avatars.githubusercontent.com/u/1528417?v=3","gravatar_id":"","url":"https://api.github.com/users/zorrofox","html_url":"https://github.com/zorrofox","followers_url":"https://api.github.com/users/zorrofox/followers","following_url":"https://api.github.com/users/zorrofox/following{/other_user}","gists_url":"https://api.github.com/users/zorrofox/gists{/gist_id}","starred_url":"https://api.github.com/users/zorrofox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorrofox/subscriptions","organizations_url":"https://api.github.com/users/zorrofox/orgs","repos_url":"https://api.github.com/users/zorrofox/repos","events_url":"https://api.github.com/users/zorrofox/events{/privacy}","received_events_url":"https://api.github.com/users/zorrofox/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Fill out the whole template so we have a good overview on the issue\r\n3. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it\r\n-->\r\n\r\n## What did you implement:\r\n\r\n***Implementing Issue:*** #1973\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\nAdd logic in lib/plugins/aws/deploy/lib/createStack.js createStack() function to test the invalid stack name and throw the correct and meaningful error message.\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\nJust to deploy a invalid AWS CF stack name and the error message will appear.\r\n![image](https://cloud.githubusercontent.com/assets/1528417/18792844/badb36ac-81ea-11e6-8faa-09c9a0704581.png)\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works, e.g. an example serverless.yml\r\nor AWS CLI commands to trigger something.\r\n-->\r\n\r\n\r\n## Todos:\r\n\r\n- [x] Write tests\r\n- [x] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config/commands/resources\r\n- [x] Leave a comment that this is ready for review once you've finished the implementation\r\n","created_at":"2016-09-23T16:08:06Z","updated_at":"2016-09-30T02:05:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467c60af731937828d60260a31a79e6213ded83f","assignee":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/2198/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/2198/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2198/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/478209bfa6025248a1ef949f940a20fc80cca316","head":{"label":"zorrofox:master","ref":"master","sha":"478209bfa6025248a1ef949f940a20fc80cca316","user":{"login":"zorrofox","id":1528417,"avatar_url":"https://avatars.githubusercontent.com/u/1528417?v=3","gravatar_id":"","url":"https://api.github.com/users/zorrofox","html_url":"https://github.com/zorrofox","followers_url":"https://api.github.com/users/zorrofox/followers","following_url":"https://api.github.com/users/zorrofox/following{/other_user}","gists_url":"https://api.github.com/users/zorrofox/gists{/gist_id}","starred_url":"https://api.github.com/users/zorrofox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorrofox/subscriptions","organizations_url":"https://api.github.com/users/zorrofox/orgs","repos_url":"https://api.github.com/users/zorrofox/repos","events_url":"https://api.github.com/users/zorrofox/events{/privacy}","received_events_url":"https://api.github.com/users/zorrofox/received_events","type":"User","site_admin":false},"repo":{"id":69028550,"name":"serverless","full_name":"zorrofox/serverless","owner":{"login":"zorrofox","id":1528417,"avatar_url":"https://avatars.githubusercontent.com/u/1528417?v=3","gravatar_id":"","url":"https://api.github.com/users/zorrofox","html_url":"https://github.com/zorrofox","followers_url":"https://api.github.com/users/zorrofox/followers","following_url":"https://api.github.com/users/zorrofox/following{/other_user}","gists_url":"https://api.github.com/users/zorrofox/gists{/gist_id}","starred_url":"https://api.github.com/users/zorrofox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorrofox/subscriptions","organizations_url":"https://api.github.com/users/zorrofox/orgs","repos_url":"https://api.github.com/users/zorrofox/repos","events_url":"https://api.github.com/users/zorrofox/events{/privacy}","received_events_url":"https://api.github.com/users/zorrofox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zorrofox/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/zorrofox/serverless","forks_url":"https://api.github.com/repos/zorrofox/serverless/forks","keys_url":"https://api.github.com/repos/zorrofox/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zorrofox/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zorrofox/serverless/teams","hooks_url":"https://api.github.com/repos/zorrofox/serverless/hooks","issue_events_url":"https://api.github.com/repos/zorrofox/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/zorrofox/serverless/events","assignees_url":"https://api.github.com/repos/zorrofox/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/zorrofox/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/zorrofox/serverless/tags","blobs_url":"https://api.github.com/repos/zorrofox/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zorrofox/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zorrofox/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/zorrofox/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zorrofox/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/zorrofox/serverless/languages","stargazers_url":"https://api.github.com/repos/zorrofox/serverless/stargazers","contributors_url":"https://api.github.com/repos/zorrofox/serverless/contributors","subscribers_url":"https://api.github.com/repos/zorrofox/serverless/subscribers","subscription_url":"https://api.github.com/repos/zorrofox/serverless/subscription","commits_url":"https://api.github.com/repos/zorrofox/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/zorrofox/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/zorrofox/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/zorrofox/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/zorrofox/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/zorrofox/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zorrofox/serverless/merges","archive_url":"https://api.github.com/repos/zorrofox/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zorrofox/serverless/downloads","issues_url":"https://api.github.com/repos/zorrofox/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/zorrofox/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/zorrofox/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/zorrofox/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zorrofox/serverless/labels{/name}","releases_url":"https://api.github.com/repos/zorrofox/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/zorrofox/serverless/deployments","created_at":"2016-09-23T13:42:48Z","updated_at":"2016-09-23T13:42:50Z","pushed_at":"2016-09-23T16:32:11Z","git_url":"git://github.com/zorrofox/serverless.git","ssh_url":"git@github.com:zorrofox/serverless.git","clone_url":"https://github.com/zorrofox/serverless.git","svn_url":"https://github.com/zorrofox/serverless","homepage":"http://www.serverless.com","size":71356,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"fb14309281bee8fa1ecffe4d95db65b2e60fc6aa","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2016-09-30T01:37:58Z","pushed_at":"2016-09-30T01:54:29Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":89852,"stargazers_count":11022,"watchers_count":11022,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":841,"mirror_url":null,"open_issues_count":176,"forks":841,"open_issues":176,"watchers":11022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2198"},"html":{"href":"https://github.com/serverless/serverless/pull/2198"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/2198"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/2198/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2198/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2198/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/478209bfa6025248a1ef949f940a20fc80cca316"}}}}
{"actor":{"display_login":"pmuens"}}