{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material/pulls/comments/82846067","pull_request_review_id":3724488,"id":82846067,"diff_hunk":"@@ -92,9 +92,22 @@ function MdCheckboxDirective(inputDirective, $mdAria, $mdConstant, $mdTheming, $\n       post: postLink\n     };\n \n-    function postLink(scope, element, attr, ngModelCtrl) {\n+    function postLink(scope, element, attr, ctrls) {\n       var isIndeterminate;\n-      ngModelCtrl = ngModelCtrl || $mdUtil.fakeNgModel();\n+      var containerCtrl = ctrls[0];\n+      var ngModelCtrl = ctrls[1] || $mdUtil.fakeNgModel();\n+      var formCtrl = ctrls[2];\n+\n+      if (containerCtrl) {\n+        var isErrorGetter = containerCtrl.isErrorGetter || function() {\n+          return ngModelCtrl.$invalid && (ngModelCtrl.$touched || (formCtrl && formCtrl.$submitted));\n+        };\n+\n+        containerCtrl.input = element;\n+\n+        scope.$watch(isErrorGetter, containerCtrl.setInvalid);","path":"src/components/checkbox/checkbox.js","position":28,"original_position":28,"commit_id":"19afe979d23f19e58af5066cae0e0e54b8d2f95f","original_commit_id":"19afe979d23f19e58af5066cae0e0e54b8d2f95f","user":{"login":"clshortfuse","id":9271155,"avatar_url":"https://avatars.githubusercontent.com/u/9271155?v=3","gravatar_id":"","url":"https://api.github.com/users/clshortfuse","html_url":"https://github.com/clshortfuse","followers_url":"https://api.github.com/users/clshortfuse/followers","following_url":"https://api.github.com/users/clshortfuse/following{/other_user}","gists_url":"https://api.github.com/users/clshortfuse/gists{/gist_id}","starred_url":"https://api.github.com/users/clshortfuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clshortfuse/subscriptions","organizations_url":"https://api.github.com/users/clshortfuse/orgs","repos_url":"https://api.github.com/users/clshortfuse/repos","events_url":"https://api.github.com/users/clshortfuse/events{/privacy}","received_events_url":"https://api.github.com/users/clshortfuse/received_events","type":"User","site_admin":false},"body":"Okay, I see it now. Reducing the watcher count on these components would be a separate issue. Shouldn't stop this from going through. I just want to keep track of any possible performance degradation.","created_at":"2016-10-11T17:31:02Z","updated_at":"2016-10-11T17:31:02Z","html_url":"https://github.com/angular/material/pull/9473#discussion_r82846067","pull_request_url":"https://api.github.com/repos/angular/material/pulls/9473","_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/comments/82846067"},"html":{"href":"https://github.com/angular/material/pull/9473#discussion_r82846067"},"pull_request":{"href":"https://api.github.com/repos/angular/material/pulls/9473"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/9473","id":83518595,"html_url":"https://github.com/angular/material/pull/9473","diff_url":"https://github.com/angular/material/pull/9473.diff","patch_url":"https://github.com/angular/material/pull/9473.patch","issue_url":"https://api.github.com/repos/angular/material/issues/9473","number":9473,"state":"open","locked":false,"title":"feat(checkbox/switch): add support for animating ng-messages","user":{"login":"Frank3K","id":8014077,"avatar_url":"https://avatars.githubusercontent.com/u/8014077?v=3","gravatar_id":"","url":"https://api.github.com/users/Frank3K","html_url":"https://github.com/Frank3K","followers_url":"https://api.github.com/users/Frank3K/followers","following_url":"https://api.github.com/users/Frank3K/following{/other_user}","gists_url":"https://api.github.com/users/Frank3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank3K/subscriptions","organizations_url":"https://api.github.com/users/Frank3K/orgs","repos_url":"https://api.github.com/users/Frank3K/repos","events_url":"https://api.github.com/users/Frank3K/events{/privacy}","received_events_url":"https://api.github.com/users/Frank3K/received_events","type":"User","site_admin":false},"body":"Add support for animating ng-messages on md-checkbox, in line with input, md-select and md-datepicker (as explained in #9430). Fixes #9430 and #8267.\r\n\r\nTested locally, but still need to add tests. I would appreciate if someone could review.\r\n\r\n- [x] Add tests.\r\n- [x] Add demo.\r\n\r\nThe tests are based on the test of the [input-animations.spec.js](https://github.com/angular/material/blob/master/src/components/input/input-animations.spec.js).","created_at":"2016-08-31T19:58:46Z","updated_at":"2016-10-11T17:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99d2ae8bccaad8766c13d94f268f4b53b00a53c5","assignee":{"login":"topherfangio","id":54370,"avatar_url":"https://avatars.githubusercontent.com/u/54370?v=3","gravatar_id":"","url":"https://api.github.com/users/topherfangio","html_url":"https://github.com/topherfangio","followers_url":"https://api.github.com/users/topherfangio/followers","following_url":"https://api.github.com/users/topherfangio/following{/other_user}","gists_url":"https://api.github.com/users/topherfangio/gists{/gist_id}","starred_url":"https://api.github.com/users/topherfangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topherfangio/subscriptions","organizations_url":"https://api.github.com/users/topherfangio/orgs","repos_url":"https://api.github.com/users/topherfangio/repos","events_url":"https://api.github.com/users/topherfangio/events{/privacy}","received_events_url":"https://api.github.com/users/topherfangio/received_events","type":"User","site_admin":false},"assignees":[{"login":"topherfangio","id":54370,"avatar_url":"https://avatars.githubusercontent.com/u/54370?v=3","gravatar_id":"","url":"https://api.github.com/users/topherfangio","html_url":"https://github.com/topherfangio","followers_url":"https://api.github.com/users/topherfangio/followers","following_url":"https://api.github.com/users/topherfangio/following{/other_user}","gists_url":"https://api.github.com/users/topherfangio/gists{/gist_id}","starred_url":"https://api.github.com/users/topherfangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topherfangio/subscriptions","organizations_url":"https://api.github.com/users/topherfangio/orgs","repos_url":"https://api.github.com/users/topherfangio/repos","events_url":"https://api.github.com/users/topherfangio/events{/privacy}","received_events_url":"https://api.github.com/users/topherfangio/received_events","type":"User","site_admin":false},{"login":"clshortfuse","id":9271155,"avatar_url":"https://avatars.githubusercontent.com/u/9271155?v=3","gravatar_id":"","url":"https://api.github.com/users/clshortfuse","html_url":"https://github.com/clshortfuse","followers_url":"https://api.github.com/users/clshortfuse/followers","following_url":"https://api.github.com/users/clshortfuse/following{/other_user}","gists_url":"https://api.github.com/users/clshortfuse/gists{/gist_id}","starred_url":"https://api.github.com/users/clshortfuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clshortfuse/subscriptions","organizations_url":"https://api.github.com/users/clshortfuse/orgs","repos_url":"https://api.github.com/users/clshortfuse/repos","events_url":"https://api.github.com/users/clshortfuse/events{/privacy}","received_events_url":"https://api.github.com/users/clshortfuse/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/material/milestones/36","html_url":"https://github.com/angular/material/milestones/1.1.2","labels_url":"https://api.github.com/repos/angular/material/milestones/36/labels","id":1485958,"number":36,"title":"1.1.2","description":"","creator":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars.githubusercontent.com/u/210413?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"open_issues":94,"closed_issues":63,"state":"open","created_at":"2016-01-05T21:40:38Z","updated_at":"2016-10-11T17:16:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/material/pulls/9473/commits","review_comments_url":"https://api.github.com/repos/angular/material/pulls/9473/comments","review_comment_url":"https://api.github.com/repos/angular/material/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material/issues/9473/comments","statuses_url":"https://api.github.com/repos/angular/material/statuses/19afe979d23f19e58af5066cae0e0e54b8d2f95f","head":{"label":"Frank3K:feat/md-checkbox-ng-messages","ref":"feat/md-checkbox-ng-messages","sha":"19afe979d23f19e58af5066cae0e0e54b8d2f95f","user":{"login":"Frank3K","id":8014077,"avatar_url":"https://avatars.githubusercontent.com/u/8014077?v=3","gravatar_id":"","url":"https://api.github.com/users/Frank3K","html_url":"https://github.com/Frank3K","followers_url":"https://api.github.com/users/Frank3K/followers","following_url":"https://api.github.com/users/Frank3K/following{/other_user}","gists_url":"https://api.github.com/users/Frank3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank3K/subscriptions","organizations_url":"https://api.github.com/users/Frank3K/orgs","repos_url":"https://api.github.com/users/Frank3K/repos","events_url":"https://api.github.com/users/Frank3K/events{/privacy}","received_events_url":"https://api.github.com/users/Frank3K/received_events","type":"User","site_admin":false},"repo":{"id":23360947,"name":"material","full_name":"Frank3K/material","owner":{"login":"Frank3K","id":8014077,"avatar_url":"https://avatars.githubusercontent.com/u/8014077?v=3","gravatar_id":"","url":"https://api.github.com/users/Frank3K","html_url":"https://github.com/Frank3K","followers_url":"https://api.github.com/users/Frank3K/followers","following_url":"https://api.github.com/users/Frank3K/following{/other_user}","gists_url":"https://api.github.com/users/Frank3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank3K/subscriptions","organizations_url":"https://api.github.com/users/Frank3K/orgs","repos_url":"https://api.github.com/users/Frank3K/repos","events_url":"https://api.github.com/users/Frank3K/events{/privacy}","received_events_url":"https://api.github.com/users/Frank3K/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frank3K/material","description":"Material design for Angular","fork":true,"url":"https://api.github.com/repos/Frank3K/material","forks_url":"https://api.github.com/repos/Frank3K/material/forks","keys_url":"https://api.github.com/repos/Frank3K/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frank3K/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frank3K/material/teams","hooks_url":"https://api.github.com/repos/Frank3K/material/hooks","issue_events_url":"https://api.github.com/repos/Frank3K/material/issues/events{/number}","events_url":"https://api.github.com/repos/Frank3K/material/events","assignees_url":"https://api.github.com/repos/Frank3K/material/assignees{/user}","branches_url":"https://api.github.com/repos/Frank3K/material/branches{/branch}","tags_url":"https://api.github.com/repos/Frank3K/material/tags","blobs_url":"https://api.github.com/repos/Frank3K/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frank3K/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frank3K/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frank3K/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frank3K/material/statuses/{sha}","languages_url":"https://api.github.com/repos/Frank3K/material/languages","stargazers_url":"https://api.github.com/repos/Frank3K/material/stargazers","contributors_url":"https://api.github.com/repos/Frank3K/material/contributors","subscribers_url":"https://api.github.com/repos/Frank3K/material/subscribers","subscription_url":"https://api.github.com/repos/Frank3K/material/subscription","commits_url":"https://api.github.com/repos/Frank3K/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frank3K/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frank3K/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frank3K/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frank3K/material/contents/{+path}","compare_url":"https://api.github.com/repos/Frank3K/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frank3K/material/merges","archive_url":"https://api.github.com/repos/Frank3K/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frank3K/material/downloads","issues_url":"https://api.github.com/repos/Frank3K/material/issues{/number}","pulls_url":"https://api.github.com/repos/Frank3K/material/pulls{/number}","milestones_url":"https://api.github.com/repos/Frank3K/material/milestones{/number}","notifications_url":"https://api.github.com/repos/Frank3K/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frank3K/material/labels{/name}","releases_url":"https://api.github.com/repos/Frank3K/material/releases{/id}","deployments_url":"https://api.github.com/repos/Frank3K/material/deployments","created_at":"2014-08-26T17:45:02Z","updated_at":"2016-08-31T19:54:49Z","pushed_at":"2016-10-08T13:55:41Z","git_url":"git://github.com/Frank3K/material.git","ssh_url":"git@github.com:Frank3K/material.git","clone_url":"https://github.com/Frank3K/material.git","svn_url":"https://github.com/Frank3K/material","homepage":null,"size":44634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"24ac32860541df066aa5cbb1c34d6030b99e4fdc","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material/deployments","created_at":"2014-07-01T19:20:06Z","updated_at":"2016-10-11T17:26:33Z","pushed_at":"2016-10-11T16:07:56Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":82468,"stargazers_count":14618,"watchers_count":14618,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3093,"mirror_url":null,"open_issues_count":390,"forks":3093,"open_issues":390,"watchers":14618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/9473"},"html":{"href":"https://github.com/angular/material/pull/9473"},"issue":{"href":"https://api.github.com/repos/angular/material/issues/9473"},"comments":{"href":"https://api.github.com/repos/angular/material/issues/9473/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material/pulls/9473/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material/pulls/9473/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material/statuses/19afe979d23f19e58af5066cae0e0e54b8d2f95f"}}}}
{"actor":{"display_login":"clshortfuse"}}