{"action":"created","issue":{"url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/218","labels_url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/218/comments","events_url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/218/events","html_url":"https://github.com/elieserdejesus/JamTaba/pull/218","id":124652617,"number":218,"title":"[WIP] Refactoring ninjam code","user":{"login":"elieserdejesus","id":1012741,"avatar_url":"https://avatars.githubusercontent.com/u/1012741?v=3","gravatar_id":"","url":"https://api.github.com/users/elieserdejesus","html_url":"https://github.com/elieserdejesus","followers_url":"https://api.github.com/users/elieserdejesus/followers","following_url":"https://api.github.com/users/elieserdejesus/following{/other_user}","gists_url":"https://api.github.com/users/elieserdejesus/gists{/gist_id}","starred_url":"https://api.github.com/users/elieserdejesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieserdejesus/subscriptions","organizations_url":"https://api.github.com/users/elieserdejesus/orgs","repos_url":"https://api.github.com/users/elieserdejesus/repos","events_url":"https://api.github.com/users/elieserdejesus/events{/privacy}","received_events_url":"https://api.github.com/users/elieserdejesus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elieserdejesus/JamTaba/labels/Refactoring","name":"Refactoring","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/elieserdejesus/JamTaba/milestones/10","html_url":"https://github.com/elieserdejesus/JamTaba/milestones/2.0.11","labels_url":"https://api.github.com/repos/elieserdejesus/JamTaba/milestones/10/labels","id":1470479,"number":10,"title":"2.0.11","description":null,"creator":{"login":"elieserdejesus","id":1012741,"avatar_url":"https://avatars.githubusercontent.com/u/1012741?v=3","gravatar_id":"","url":"https://api.github.com/users/elieserdejesus","html_url":"https://github.com/elieserdejesus","followers_url":"https://api.github.com/users/elieserdejesus/followers","following_url":"https://api.github.com/users/elieserdejesus/following{/other_user}","gists_url":"https://api.github.com/users/elieserdejesus/gists{/gist_id}","starred_url":"https://api.github.com/users/elieserdejesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieserdejesus/subscriptions","organizations_url":"https://api.github.com/users/elieserdejesus/orgs","repos_url":"https://api.github.com/users/elieserdejesus/repos","events_url":"https://api.github.com/users/elieserdejesus/events{/privacy}","received_events_url":"https://api.github.com/users/elieserdejesus/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2015-12-22T00:35:27Z","updated_at":"2016-01-04T04:40:24Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-01-03T15:04:02Z","updated_at":"2016-01-04T18:52:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elieserdejesus/JamTaba/pulls/218","html_url":"https://github.com/elieserdejesus/JamTaba/pull/218","diff_url":"https://github.com/elieserdejesus/JamTaba/pull/218.diff","patch_url":"https://github.com/elieserdejesus/JamTaba/pull/218.patch"},"body":"This code (ninjam protocol related) was the first code I work in Jamtaba. In that moment I was re-learning C++ and learning Qt. Now I'm revising the code and is very fun rewrite these stuff and apply other technics, change some design, etc.\r\n\r\nThe task list is big, but fun:\r\n\r\n- [x] Renaming 'non good' names\r\n- [x] Use const references in parameters\r\n- [x] Review 'stack versus heap'\r\n- [x] Replace STL code with Qt similar (just to avoid mix)\r\n- [x] Use the override keyword to replace the bad \"virtual\"s in overrided functions.\r\n- [x] Clean the old school style casts\r\n- [x] Remove throws\r\n- [x] Remove static stuff\r\n- [ ] Add tests\r\n"},"comment":{"url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/comments/168767358","html_url":"https://github.com/elieserdejesus/JamTaba/pull/218#issuecomment-168767358","issue_url":"https://api.github.com/repos/elieserdejesus/JamTaba/issues/218","id":168767358,"user":{"login":"elieserdejesus","id":1012741,"avatar_url":"https://avatars.githubusercontent.com/u/1012741?v=3","gravatar_id":"","url":"https://api.github.com/users/elieserdejesus","html_url":"https://github.com/elieserdejesus","followers_url":"https://api.github.com/users/elieserdejesus/followers","following_url":"https://api.github.com/users/elieserdejesus/following{/other_user}","gists_url":"https://api.github.com/users/elieserdejesus/gists{/gist_id}","starred_url":"https://api.github.com/users/elieserdejesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieserdejesus/subscriptions","organizations_url":"https://api.github.com/users/elieserdejesus/orgs","repos_url":"https://api.github.com/users/elieserdejesus/repos","events_url":"https://api.github.com/users/elieserdejesus/events{/privacy}","received_events_url":"https://api.github.com/users/elieserdejesus/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T18:52:27Z","updated_at":"2016-01-04T18:52:27Z","body":"Using rebase -iagain to reduce the number of commits. After a lot of squashed commits and tons of conflicts merge the number of commits are small enough :)"}}