{"action":"created","issue":{"url":"https://api.github.com/repos/getredash/redash/issues/1292","repository_url":"https://api.github.com/repos/getredash/redash","labels_url":"https://api.github.com/repos/getredash/redash/issues/1292/labels{/name}","comments_url":"https://api.github.com/repos/getredash/redash/issues/1292/comments","events_url":"https://api.github.com/repos/getredash/redash/issues/1292/events","html_url":"https://github.com/getredash/redash/pull/1292","id":178709041,"number":1292,"title":"Change: improvements to map visualization","user":{"login":"arikfr","id":71468,"avatar_url":"https://avatars.githubusercontent.com/u/71468?v=3","gravatar_id":"","url":"https://api.github.com/users/arikfr","html_url":"https://github.com/arikfr","followers_url":"https://api.github.com/users/arikfr/followers","following_url":"https://api.github.com/users/arikfr/following{/other_user}","gists_url":"https://api.github.com/users/arikfr/gists{/gist_id}","starred_url":"https://api.github.com/users/arikfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arikfr/subscriptions","organizations_url":"https://api.github.com/users/arikfr/orgs","repos_url":"https://api.github.com/users/arikfr/repos","events_url":"https://api.github.com/users/arikfr/events{/privacy}","received_events_url":"https://api.github.com/users/arikfr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/getredash/redash/milestones/8","html_url":"https://github.com/getredash/redash/milestones/v0.12.0","labels_url":"https://api.github.com/repos/getredash/redash/milestones/8/labels","id":1825264,"number":8,"title":"v0.12.0","description":"","creator":{"login":"arikfr","id":71468,"avatar_url":"https://avatars.githubusercontent.com/u/71468?v=3","gravatar_id":"","url":"https://api.github.com/users/arikfr","html_url":"https://github.com/arikfr","followers_url":"https://api.github.com/users/arikfr/followers","following_url":"https://api.github.com/users/arikfr/following{/other_user}","gists_url":"https://api.github.com/users/arikfr/gists{/gist_id}","starred_url":"https://api.github.com/users/arikfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arikfr/subscriptions","organizations_url":"https://api.github.com/users/arikfr/orgs","repos_url":"https://api.github.com/users/arikfr/repos","events_url":"https://api.github.com/users/arikfr/events{/privacy}","received_events_url":"https://api.github.com/users/arikfr/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":5,"state":"open","created_at":"2016-06-14T07:20:45Z","updated_at":"2016-09-22T20:13:51Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-09-22T20:13:46Z","updated_at":"2016-09-26T22:10:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getredash/redash/pulls/1292","html_url":"https://github.com/getredash/redash/pull/1292","diff_url":"https://github.com/getredash/redash/pull/1292.diff","patch_url":"https://github.com/getredash/redash/pull/1292.patch"},"body":"* Fix #557: user can set his own colors for the different groups on the map.\r\n* Add layer selection control.\r\n* Inspired by #1203, added support for markers clustering.\r\n* Changed the map setting screen (to hopefully) be simpler.\r\n* Disabled automatic zoom when scrolling past the window.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/71468/18764403/fdeb7eec-8119-11e6-84ec-c28eec488fa6.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/71468/18764458/2990b4d6-811a-11e6-8e21-30fc819003fb.png)\r\n"},"comment":{"url":"https://api.github.com/repos/getredash/redash/issues/comments/249712716","html_url":"https://github.com/getredash/redash/pull/1292#issuecomment-249712716","issue_url":"https://api.github.com/repos/getredash/redash/issues/1292","id":249712716,"user":{"login":"WesleyBatista","id":755254,"avatar_url":"https://avatars.githubusercontent.com/u/755254?v=3","gravatar_id":"","url":"https://api.github.com/users/WesleyBatista","html_url":"https://github.com/WesleyBatista","followers_url":"https://api.github.com/users/WesleyBatista/followers","following_url":"https://api.github.com/users/WesleyBatista/following{/other_user}","gists_url":"https://api.github.com/users/WesleyBatista/gists{/gist_id}","starred_url":"https://api.github.com/users/WesleyBatista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WesleyBatista/subscriptions","organizations_url":"https://api.github.com/users/WesleyBatista/orgs","repos_url":"https://api.github.com/users/WesleyBatista/repos","events_url":"https://api.github.com/users/WesleyBatista/events{/privacy}","received_events_url":"https://api.github.com/users/WesleyBatista/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T22:10:48Z","updated_at":"2016-09-26T22:10:48Z","body":"Really thanks for implementing it! \r\n\r\nI just had time to test it today. Here are my thoughts:\r\n\r\n**1**. I really like that now we can use `group by` in the visualization settings, and now we are able to select the groups that we want to see in the visualization. 👏 👏 👏 \r\n![captura de tela 2016-09-26 as 17 58 20](https://cloud.githubusercontent.com/assets/755254/18851532/dbef0998-8412-11e6-80ab-bb5e2b1c8eed.png)\r\n\r\n**2**. The colors used by the marker cluster library and ours is not managed very well. for example, take a look at this 5 blue points: \r\n![captura de tela 2016-09-26 as 17 46 59](https://cloud.githubusercontent.com/assets/755254/18852651/be227c06-8417-11e6-8479-6a82cc6cc3d1.png)\r\n![captura de tela 2016-09-26 as 17 46 39](https://cloud.githubusercontent.com/assets/755254/18852656/c3e8c9c4-8417-11e6-9f80-bb9b40a52712.png)\r\nWhen zooming out, the 4 closer to each other are clustered and the color is set to green.\r\n\r\nThe same issue within another use case: looking at the yellow clusters in the next image, I find clusters with the same colors closer to each other, and start to wondering \"why they were not grouped?\", but I know that we have 5 different groups because I used the `group by`. \r\n![captura de tela 2016-09-26 as 18 02 06](https://cloud.githubusercontent.com/assets/755254/18851691/7af7b044-8413-11e6-88ec-cba9fa40e9eb.png)\r\nIt would be more meaningful if the colors used was the group's color, so I would also know which groups they belongs.\r\n\r\n\r\n**3**. the custom layers is something that I miss. The OpenStreet Map default tiles is messy by showing a lot of information in the map, and the colors it uses mixes with the ones used by the clusters/groups. For example, look at this two images: \r\n![captura de tela 2016-09-26 as 18 29 29](https://cloud.githubusercontent.com/assets/755254/18852546/379f8a84-8417-11e6-89a2-13e64038bdd7.png)\r\n\r\n![captura de tela 2016-09-26 as 17 55 40](https://cloud.githubusercontent.com/assets/755254/18851904/76956c70-8414-11e6-9ccd-8b9ab9a0303e.png)\r\nThe **Stamen Toner** layers are more clear by showing only the necessary. That way the user which is taking care of a dashboard, for example, can focus on the main information which is the clusters.\r\n\r\nFor now that is what I found 😄 \r\n"}}
{"actor":{"display_login":"WesleyBatista"}}