{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/13421","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13421/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13421/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13421/events","html_url":"https://github.com/cms-sw/cmssw/pull/13421","id":135370282,"number":13421,"title":"update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers)","user":{"login":"mtosi","id":4946419,"avatar_url":"https://avatars.githubusercontent.com/u/4946419?v=3","gravatar_id":"","url":"https://api.github.com/users/mtosi","html_url":"https://github.com/mtosi","followers_url":"https://api.github.com/users/mtosi/followers","following_url":"https://api.github.com/users/mtosi/following{/other_user}","gists_url":"https://api.github.com/users/mtosi/gists{/gist_id}","starred_url":"https://api.github.com/users/mtosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtosi/subscriptions","organizations_url":"https://api.github.com/users/mtosi/orgs","repos_url":"https://api.github.com/users/mtosi/repos","events_url":"https://api.github.com/users/mtosi/events{/privacy}","received_events_url":"https://api.github.com/users/mtosi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":796,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2016-02-22T17:09:51Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-02-22T09:56:45Z","updated_at":"2016-02-22T22:04:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13421","html_url":"https://github.com/cms-sw/cmssw/pull/13421","diff_url":"https://github.com/cms-sw/cmssw/pull/13421.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/13421.patch"},"body":"this PR is meant to update the name of a trajectory filter parameter (minNumberOfHits --> minNumberOfHitsForLoopers)\r\n\r\nI also take the opportunity of deleting few existAs checks which were still present in the TrackingTools/TrajectoryFiltering package\r\n=> the HLT customization function (HLTrigger/Configuration/python/customizeHLTforCMSSW.py) has been updated in order to make the HLT menu compatible w/ this update (\"usual\" temporary solution waiting for the confDB update)\r\n\r\nin addition, I noticed there were few cases in which the class constructor, where default input parameters were used, was not in synch w/ the default parameter values given by config\r\n=> the default parameters have been updated as well\r\n\r\nI ran \r\nHLTrigger/Configuration/test/cmsDriver.sh\r\nand \r\naddOnTests.py\r\nI got the few errors ([1] from cmsDriver and [2] from addOnTests, respectively)\r\nbut I think they are not related to my changes\r\n\r\n@VinInn @rovere @perrotta @Martin-Grunewald \r\n\r\n[1]\r\nCreating DigiL1RawHLT HIon_MC\r\nDIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon,ENDJOB\r\nentry /store/relval/CMSSW_7_6_0_pre6/RelValZEEMM_13_HI/GEN-SIM/76X_mcRun2_HeavyIon_v4-v1/00000/EA469164-6A69-E511-A361-008CFA008768.root\r\n ###################################################################\r\n # WARNING: this module is deprecated.                             #\r\n # Please use CondCore.CondDB.CondDB_cfi.py                        #\r\n ###################################################################\r\nStep: DIGI Spec: ['pdigi_valid']\r\nStep: L1 Spec:\r\nL1TCalorimeter Sequence configured for Stage-1 (2015) trigger.\r\nL1TMuon Sequence configured for Legacy trigger (Run1 and Run 2015).\r\nL1TGlobal Sequence configured for Legacy trigger (Run1 and Run 2015).\r\nL1TCalorimeter Conditions configured for Stage-1 (2015) trigger.\r\nStep: DIGI2RAW Spec:\r\nL1TDigiToRaw Sequence configured for Stage-1 (2015) trigger.\r\nStep: HLT Spec: ['HIon']\r\nStep: ENDJOB Spec:\r\n# Conditions read from  CMS_CONDITIONS  via FrontierProd\r\ncustomising the process with L1THLT from HLTrigger/Configuration/CustomConfigs\r\ncustomising the process with customizeHLTforFullSim from HLTrigger/Configuration/customizeHLTforMC\r\nConfig file RelVal_DigiL1RawHLT_HIon_MC.py created\r\n\r\nCreating FastSim HIon_MC\r\nGEN,SIM,RECOBEFMIX,DIGI,L1,L1Reco,RECO,HLT:HIon,ENDJOB\r\nTraceback (most recent call last):\r\n  File \"/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/bin/slc6_amd64_gcc493/cmsDriver.py\", line 55, in <module>\r\n    run()\r\n  File \"/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/bin/slc6_amd64_gcc493/cmsDriver.py\", line 11, in run\r\n    options = OptionsFromCommandLine()\r\n  File \"/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/python/Configuration/Applications/cmsDriverOptions.py\", line 33, in OptionsFromCommandLine\r\n    options=OptionsFromItems(sys.argv[1:])\r\n  File \"/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/python/Configuration/Applications/cmsDriverOptions.py\", line 271, in OptionsFromItems\r\n    raise Exception(\"ERROR: the --option fast is only compatible with the default scenario (--scenario=pp)\")\r\nException: ERROR: the --option fast is only compatible with the default scenario (--scenario=pp)\r\n\r\n[2]\r\ncmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier \"GEN-SIM-RAW\" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Wed Feb 17 17:52:54 2016-date Wed Feb 17 17:47:04 2016 s - exit: 34560\r\n\r\nlog file:\r\n/afs/cern.ch/work/t/tosi/public/trackingHLT/update_trajectory_filtering/CMSSW_8_0_X_2016-02-15-2300/src/HLTrigger/Configuration/test/addOnTests/logs/cmsDriver-hlt_mc_GRun_cmsDriver.py_TTbar_Tauola_13TeV_cfi_-s_GEN,SIM,DIGI,L1,DIGI2RAW_--mc_--scenario=pp_-n_10_--conditions_auto:run2_mc_GRun_--relval_9000,50_--datatier_G.log\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/187408064","html_url":"https://github.com/cms-sw/cmssw/pull/13421#issuecomment-187408064","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13421","id":187408064,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T22:04:22Z","updated_at":"2016-02-22T22:04:22Z","body":"@mtosi is this required to be in 80X?\r\nWe should probably start with 81X and then backport.\r\nPlease make a PR in 81X.\r\n"}}