{"action":"created","issue":{"url":"https://api.github.com/repos/pluralsight/guides-cms/issues/86","repository_url":"https://api.github.com/repos/pluralsight/guides-cms","labels_url":"https://api.github.com/repos/pluralsight/guides-cms/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/pluralsight/guides-cms/issues/86/comments","events_url":"https://api.github.com/repos/pluralsight/guides-cms/issues/86/events","html_url":"https://github.com/pluralsight/guides-cms/pull/86","id":157140247,"number":86,"title":"Render markdown on frontend","user":{"login":"paulocheque","id":94350,"avatar_url":"https://avatars.githubusercontent.com/u/94350?v=3","gravatar_id":"","url":"https://api.github.com/users/paulocheque","html_url":"https://github.com/paulocheque","followers_url":"https://api.github.com/users/paulocheque/followers","following_url":"https://api.github.com/users/paulocheque/following{/other_user}","gists_url":"https://api.github.com/users/paulocheque/gists{/gist_id}","starred_url":"https://api.github.com/users/paulocheque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulocheque/subscriptions","organizations_url":"https://api.github.com/users/paulocheque/orgs","repos_url":"https://api.github.com/users/paulocheque/repos","events_url":"https://api.github.com/users/paulocheque/events{/privacy}","received_events_url":"https://api.github.com/users/paulocheque/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-05-27T06:41:17Z","updated_at":"2016-06-27T17:26:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pluralsight/guides-cms/pulls/86","html_url":"https://github.com/pluralsight/guides-cms/pull/86","diff_url":"https://github.com/pluralsight/guides-cms/pull/86.diff","patch_url":"https://github.com/pluralsight/guides-cms/pull/86.patch"},"body":"This PR is not done yet. I have just created it to discuss about it.\r\n\r\n0) I rebased your `render_markdown_on_frontend` branch to the `origin/master`. I guess we should deploy the https://github.com/pluralsight/guides-cms/pull/85 first to avoid merge conflicts. I can rebase it again later.\r\n\r\n1) Before deploying this feature, I believe we should clean the Redis cache. I am using `rendered_text = False`, but I am not sure if this prevent some cache of html.\r\n\r\n2) Now, the preview and the article's page looks identical. If we need to change something in the layout, we need to use one common css file for both pages, to keep the idea.\r\n\r\n3) I removed the github.css files because they were screwing the design up. But maybe some useful css, that let the design closer to the GitHub may be lost. It is not critical I think.\r\n\r\n4) I believe we can remove all the backend code related to the `rendered = True` part. Is that ok? Or we are using this in another feature?\r\n\r\n5) I guess some js/css files can be renamed to be more understanding. For example: `editor_controller.js` instead of `editor_utils.js`. But I believe this should be the last commit to avoid merge issues.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pluralsight/guides-cms/issues/comments/228814362","html_url":"https://github.com/pluralsight/guides-cms/pull/86#issuecomment-228814362","issue_url":"https://api.github.com/repos/pluralsight/guides-cms/issues/86","id":228814362,"user":{"login":"paulocheque","id":94350,"avatar_url":"https://avatars.githubusercontent.com/u/94350?v=3","gravatar_id":"","url":"https://api.github.com/users/paulocheque","html_url":"https://github.com/paulocheque","followers_url":"https://api.github.com/users/paulocheque/followers","following_url":"https://api.github.com/users/paulocheque/following{/other_user}","gists_url":"https://api.github.com/users/paulocheque/gists{/gist_id}","starred_url":"https://api.github.com/users/paulocheque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulocheque/subscriptions","organizations_url":"https://api.github.com/users/paulocheque/orgs","repos_url":"https://api.github.com/users/paulocheque/repos","events_url":"https://api.github.com/users/paulocheque/events{/privacy}","received_events_url":"https://api.github.com/users/paulocheque/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T17:26:08Z","updated_at":"2016-06-27T17:26:08Z","body":"Compare the gfm line breaks enabled and disabled.\r\n\r\n![screen shot 2016-06-27 at 2 22 41 pm](https://cloud.githubusercontent.com/assets/94350/16389167/070cf672-3c73-11e6-8b10-a6fa5a778782.png)\r\n![screen shot 2016-06-27 at 2 22 50 pm](https://cloud.githubusercontent.com/assets/94350/16389168/0726982a-3c73-11e6-97dd-9bc7ad50f408.png)\r\n"}}
{"actor":{"display_login":"paulocheque"}}