{"action":"closed","number":163,"pull_request":{"url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163","id":76319323,"html_url":"https://github.com/dnanexus/dx-toolkit/pull/163","diff_url":"https://github.com/dnanexus/dx-toolkit/pull/163.diff","patch_url":"https://github.com/dnanexus/dx-toolkit/pull/163.patch","issue_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/163","number":163,"state":"closed","locked":false,"title":"Handle ClosedPoolError during DXHTTPRequest","user":{"login":"mckinsel","id":145417,"avatar_url":"https://avatars.githubusercontent.com/u/145417?v=3","gravatar_id":"","url":"https://api.github.com/users/mckinsel","html_url":"https://github.com/mckinsel","followers_url":"https://api.github.com/users/mckinsel/followers","following_url":"https://api.github.com/users/mckinsel/following{/other_user}","gists_url":"https://api.github.com/users/mckinsel/gists{/gist_id}","starred_url":"https://api.github.com/users/mckinsel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckinsel/subscriptions","organizations_url":"https://api.github.com/users/mckinsel/orgs","repos_url":"https://api.github.com/users/mckinsel/repos","events_url":"https://api.github.com/users/mckinsel/events{/privacy}","received_events_url":"https://api.github.com/users/mckinsel/received_events","type":"User","site_admin":false},"body":"DXHTTPRequest uses a global urllib3.PoolManager to actually make requests. The\r\nPoolManager manages urllib3.ConnectionPools, reusing them when appropriate. If\r\na request raises an exception, the PoolManager is \"cleared\", which closes\r\nevery ConnectionPool it manages. In rare cases, a ConnectionPool can be\r\nassigned to a request but then closed before the request is made. This causes\r\na urllib3.exceptions.ClosedPoolError to be raised, which presently is not\r\nhandled and causes the DXHTTPRequest to fail.\r\n\r\nThe ideal solution would fix the concurrency issue, but it appears to be\r\nwithin urllib3 itself. So, this change just catches ClosedPoolError and\r\nretries.","created_at":"2016-07-05T18:21:43Z","updated_at":"2016-07-11T17:01:25Z","closed_at":"2016-07-11T17:01:25Z","merged_at":"2016-07-11T17:01:25Z","merge_commit_sha":"012e190394f3d78c1a04e256401ea903b992914b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163/commits","review_comments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163/comments","review_comment_url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/163/comments","statuses_url":"https://api.github.com/repos/dnanexus/dx-toolkit/statuses/0fea9f95225e94667507cc3c241559d9ccdece6a","head":{"label":"dnanexus:fix_closed_pool_error","ref":"fix_closed_pool_error","sha":"0fea9f95225e94667507cc3c241559d9ccdece6a","user":{"login":"dnanexus","id":1161297,"avatar_url":"https://avatars.githubusercontent.com/u/1161297?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus","html_url":"https://github.com/dnanexus","followers_url":"https://api.github.com/users/dnanexus/followers","following_url":"https://api.github.com/users/dnanexus/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus/subscriptions","organizations_url":"https://api.github.com/users/dnanexus/orgs","repos_url":"https://api.github.com/users/dnanexus/repos","events_url":"https://api.github.com/users/dnanexus/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus/received_events","type":"Organization","site_admin":false},"repo":{"id":4802269,"name":"dx-toolkit","full_name":"dnanexus/dx-toolkit","owner":{"login":"dnanexus","id":1161297,"avatar_url":"https://avatars.githubusercontent.com/u/1161297?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus","html_url":"https://github.com/dnanexus","followers_url":"https://api.github.com/users/dnanexus/followers","following_url":"https://api.github.com/users/dnanexus/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus/subscriptions","organizations_url":"https://api.github.com/users/dnanexus/orgs","repos_url":"https://api.github.com/users/dnanexus/repos","events_url":"https://api.github.com/users/dnanexus/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnanexus/dx-toolkit","description":"DNAnexus platform client libraries","fork":false,"url":"https://api.github.com/repos/dnanexus/dx-toolkit","forks_url":"https://api.github.com/repos/dnanexus/dx-toolkit/forks","keys_url":"https://api.github.com/repos/dnanexus/dx-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnanexus/dx-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnanexus/dx-toolkit/teams","hooks_url":"https://api.github.com/repos/dnanexus/dx-toolkit/hooks","issue_events_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/dnanexus/dx-toolkit/events","assignees_url":"https://api.github.com/repos/dnanexus/dx-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/dnanexus/dx-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/dnanexus/dx-toolkit/tags","blobs_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnanexus/dx-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dnanexus/dx-toolkit/languages","stargazers_url":"https://api.github.com/repos/dnanexus/dx-toolkit/stargazers","contributors_url":"https://api.github.com/repos/dnanexus/dx-toolkit/contributors","subscribers_url":"https://api.github.com/repos/dnanexus/dx-toolkit/subscribers","subscription_url":"https://api.github.com/repos/dnanexus/dx-toolkit/subscription","commits_url":"https://api.github.com/repos/dnanexus/dx-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnanexus/dx-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/dnanexus/dx-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnanexus/dx-toolkit/merges","archive_url":"https://api.github.com/repos/dnanexus/dx-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnanexus/dx-toolkit/downloads","issues_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dnanexus/dx-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dnanexus/dx-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnanexus/dx-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/dnanexus/dx-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/deployments","created_at":"2012-06-27T00:23:47Z","updated_at":"2016-05-16T11:42:13Z","pushed_at":"2016-07-11T17:01:24Z","git_url":"git://github.com/dnanexus/dx-toolkit.git","ssh_url":"git@github.com:dnanexus/dx-toolkit.git","clone_url":"https://github.com/dnanexus/dx-toolkit.git","svn_url":"https://github.com/dnanexus/dx-toolkit","homepage":"http://autodoc.dnanexus.com/","size":19503,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":14,"forks":31,"open_issues":14,"watchers":34,"default_branch":"master"}},"base":{"label":"dnanexus:master","ref":"master","sha":"46e979857a7e5aa9fae1aa745e4971a5af81bf2c","user":{"login":"dnanexus","id":1161297,"avatar_url":"https://avatars.githubusercontent.com/u/1161297?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus","html_url":"https://github.com/dnanexus","followers_url":"https://api.github.com/users/dnanexus/followers","following_url":"https://api.github.com/users/dnanexus/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus/subscriptions","organizations_url":"https://api.github.com/users/dnanexus/orgs","repos_url":"https://api.github.com/users/dnanexus/repos","events_url":"https://api.github.com/users/dnanexus/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus/received_events","type":"Organization","site_admin":false},"repo":{"id":4802269,"name":"dx-toolkit","full_name":"dnanexus/dx-toolkit","owner":{"login":"dnanexus","id":1161297,"avatar_url":"https://avatars.githubusercontent.com/u/1161297?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus","html_url":"https://github.com/dnanexus","followers_url":"https://api.github.com/users/dnanexus/followers","following_url":"https://api.github.com/users/dnanexus/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus/subscriptions","organizations_url":"https://api.github.com/users/dnanexus/orgs","repos_url":"https://api.github.com/users/dnanexus/repos","events_url":"https://api.github.com/users/dnanexus/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnanexus/dx-toolkit","description":"DNAnexus platform client libraries","fork":false,"url":"https://api.github.com/repos/dnanexus/dx-toolkit","forks_url":"https://api.github.com/repos/dnanexus/dx-toolkit/forks","keys_url":"https://api.github.com/repos/dnanexus/dx-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnanexus/dx-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnanexus/dx-toolkit/teams","hooks_url":"https://api.github.com/repos/dnanexus/dx-toolkit/hooks","issue_events_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/dnanexus/dx-toolkit/events","assignees_url":"https://api.github.com/repos/dnanexus/dx-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/dnanexus/dx-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/dnanexus/dx-toolkit/tags","blobs_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnanexus/dx-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dnanexus/dx-toolkit/languages","stargazers_url":"https://api.github.com/repos/dnanexus/dx-toolkit/stargazers","contributors_url":"https://api.github.com/repos/dnanexus/dx-toolkit/contributors","subscribers_url":"https://api.github.com/repos/dnanexus/dx-toolkit/subscribers","subscription_url":"https://api.github.com/repos/dnanexus/dx-toolkit/subscription","commits_url":"https://api.github.com/repos/dnanexus/dx-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnanexus/dx-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnanexus/dx-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/dnanexus/dx-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnanexus/dx-toolkit/merges","archive_url":"https://api.github.com/repos/dnanexus/dx-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnanexus/dx-toolkit/downloads","issues_url":"https://api.github.com/repos/dnanexus/dx-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dnanexus/dx-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dnanexus/dx-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnanexus/dx-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/dnanexus/dx-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/dnanexus/dx-toolkit/deployments","created_at":"2012-06-27T00:23:47Z","updated_at":"2016-05-16T11:42:13Z","pushed_at":"2016-07-11T17:01:24Z","git_url":"git://github.com/dnanexus/dx-toolkit.git","ssh_url":"git@github.com:dnanexus/dx-toolkit.git","clone_url":"https://github.com/dnanexus/dx-toolkit.git","svn_url":"https://github.com/dnanexus/dx-toolkit","homepage":"http://autodoc.dnanexus.com/","size":19503,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":14,"forks":31,"open_issues":14,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163"},"html":{"href":"https://github.com/dnanexus/dx-toolkit/pull/163"},"issue":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/163"},"comments":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/dnanexus/dx-toolkit/statuses/0fea9f95225e94667507cc3c241559d9ccdece6a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"psung","id":146557,"avatar_url":"https://avatars.githubusercontent.com/u/146557?v=3","gravatar_id":"","url":"https://api.github.com/users/psung","html_url":"https://github.com/psung","followers_url":"https://api.github.com/users/psung/followers","following_url":"https://api.github.com/users/psung/following{/other_user}","gists_url":"https://api.github.com/users/psung/gists{/gist_id}","starred_url":"https://api.github.com/users/psung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psung/subscriptions","organizations_url":"https://api.github.com/users/psung/orgs","repos_url":"https://api.github.com/users/psung/repos","events_url":"https://api.github.com/users/psung/events{/privacy}","received_events_url":"https://api.github.com/users/psung/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"psung"}}