{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/3982","repository_url":"https://api.github.com/repos/concrete5/concrete5","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/3982/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3982/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/3982/events","html_url":"https://github.com/concrete5/concrete5/issues/3982","id":162141474,"number":3982,"title":"Entity Manager Installation Issues","user":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/concrete5/concrete5/labels/accepted:ready%20to%20start","name":"accepted:ready to start","color":"009800"},{"url":"https://api.github.com/repos/concrete5/concrete5/labels/priority:love%20to%20have","name":"priority:love to have","color":"5319e7"},{"url":"https://api.github.com/repos/concrete5/concrete5/labels/priority:must%20have","name":"priority:must have","color":"ff0000"},{"url":"https://api.github.com/repos/concrete5/concrete5/labels/type:bug","name":"type:bug","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"assignees":[{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/concrete5/concrete5/milestones/17","html_url":"https://github.com/concrete5/concrete5/milestones/8.0","labels_url":"https://api.github.com/repos/concrete5/concrete5/milestones/17/labels","id":1471857,"number":17,"title":"8.0","description":"","creator":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":14,"state":"open","created_at":"2015-12-22T20:49:37Z","updated_at":"2016-06-29T15:45:06Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2016-06-24T12:58:54Z","updated_at":"2016-06-29T18:39:46Z","closed_at":"2016-06-29T15:45:05Z","body":"Several new problems with the Entity Manager.\r\n\r\n1. When installing v8 I got an error that a particular class could not be found. This was a migration tool class. I have the migration_tool package sitting in my packages/ directory – but it wasn't installed. Nothing was installed, because I was installing concrete5 for the first time. I believe the problem is that the entire src/ directory is being parsed – perhaps all the time, perhaps just on installation? But the package wasn't installed, so the autoloader wasn't working. I believe this is it, but maybe the issue is something else. Regardless you can reproduce by putting the migration tool package in the packages directory and installing concrete5.\r\n\r\n2. There are errors when application/src does not exist. This shouldn't error out. We should just not load up the application entity manager if that's the case. \r\n\r\n3. When deleting an install and reinstalling, I get an error:\r\n\r\nFile mapping drivers must have a valid directory path, however the given path [/Users/andrewembler/git/sjc/web/packages/migration_tool/src] seems to be incorrect!.\r\n\r\nThis is confusing, because I have removed migration tool from my packages directory – but the presence of the old package configuration for the entity manager in generated_overrides is killing my new installation.  \r\n\r\nDo we **have** to have this configuration? Can we perhaps use this configuration if the user needs to do something exotic and specify alternate annotations? Can we use sensible defaults and NOT have this kind of generated override configuration? \r\n\r\n`\r\nreturn array(\r\n    'metadatadriver' => array(\r\n        'packages' => array(\r\n            'annotation' => array(\r\n                'legacy' => array(\r\n                    'migration_tool' => array(\r\n                        array(\r\n                            'namespace' => 'Concrete\\\\Package\\\\MigrationTool',\r\n                            'paths' => array(\r\n                                '/packages/migration_tool/src',\r\n                                '/packages/migration_tool/src/Concrete',\r\n                            ),\r\n                        ),\r\n                        array(\r\n                            'namespace' => 'PortlandLabs\\\\Concrete5\\\\MigrationTool',\r\n                            'paths' => array(\r\n                                '/packages/migration_tool/src/PortlandLabs/Concrete5/MigrationTool',\r\n                            ),\r\n                        ),\r\n                    ),\r\n                ),\r\n            ),\r\n        ),\r\n    ),\r\n);\r\n`"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/229449087","html_url":"https://github.com/concrete5/concrete5/issues/3982#issuecomment-229449087","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3982","id":229449087,"user":{"login":"Kaapiii","id":995643,"avatar_url":"https://avatars.githubusercontent.com/u/995643?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaapiii","html_url":"https://github.com/Kaapiii","followers_url":"https://api.github.com/users/Kaapiii/followers","following_url":"https://api.github.com/users/Kaapiii/following{/other_user}","gists_url":"https://api.github.com/users/Kaapiii/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaapiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaapiii/subscriptions","organizations_url":"https://api.github.com/users/Kaapiii/orgs","repos_url":"https://api.github.com/users/Kaapiii/repos","events_url":"https://api.github.com/users/Kaapiii/events{/privacy}","received_events_url":"https://api.github.com/users/Kaapiii/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T18:39:46Z","updated_at":"2016-06-29T18:39:46Z","body":"That's quite a smart solution. I haven't thought of adding the cleanup to the installation routine. Thanks for merging this."}}
{"actor":{"display_login":"Kaapiii"}}