{"action":"created","issue":{"url":"https://api.github.com/repos/edx/configuration/issues/3481","repository_url":"https://api.github.com/repos/edx/configuration","labels_url":"https://api.github.com/repos/edx/configuration/issues/3481/labels{/name}","comments_url":"https://api.github.com/repos/edx/configuration/issues/3481/comments","events_url":"https://api.github.com/repos/edx/configuration/issues/3481/events","html_url":"https://github.com/edx/configuration/pull/3481","id":190128838,"number":3481,"title":"Make sure Ansible notices migration errors.","user":{"login":"smarnach","id":249196,"avatar_url":"https://avatars.githubusercontent.com/u/249196?v=3","gravatar_id":"","url":"https://api.github.com/users/smarnach","html_url":"https://github.com/smarnach","followers_url":"https://api.github.com/users/smarnach/followers","following_url":"https://api.github.com/users/smarnach/following{/other_user}","gists_url":"https://api.github.com/users/smarnach/gists{/gist_id}","starred_url":"https://api.github.com/users/smarnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarnach/subscriptions","organizations_url":"https://api.github.com/users/smarnach/orgs","repos_url":"https://api.github.com/users/smarnach/repos","events_url":"https://api.github.com/users/smarnach/events{/privacy}","received_events_url":"https://api.github.com/users/smarnach/received_events","type":"User","site_admin":false},"labels":[{"id":128412918,"url":"https://api.github.com/repos/edx/configuration/labels/needs%20triage","name":"needs triage","color":"e11d21","default":false},{"id":99580727,"url":"https://api.github.com/repos/edx/configuration/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-17T18:40:35Z","updated_at":"2016-11-17T18:41:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/configuration/pulls/3481","html_url":"https://github.com/edx/configuration/pull/3481","diff_url":"https://github.com/edx/configuration/pull/3481.diff","patch_url":"https://github.com/edx/configuration/pull/3481.patch"},"body":"The edxapp-migrate{lms,cms} script call `./manage.py migrate` for each database alias (for our instances, this means once for `default` and once for `student_module_history`).  However, Ansible is only seeing the return code of the script, which is the return code of the last command in the script.  If one of the earlier migration commands fails, but the last one succeeds, Ansible will silently ignore the error, and not even show it in the logs.\r\n\r\nThis change configures the shell to error out as soon as any of the migration commands fails, so Ansible will actually notice something went wrong.\r\n\r\nMake sure that the following steps are done before merging\r\n\r\n  - [ ] @devops team member has commented with :+1:\r\n  - [ ] are you adding any new default values that need to be overriden when this goes live?  \r\n    - [ ] Open a ticket (DEVOPS) to make sure that they have been added to secure vars.\r\n    - [ ] Add an entry to the CHANGELOG.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/configuration/issues/comments/261331343","html_url":"https://github.com/edx/configuration/pull/3481#issuecomment-261331343","issue_url":"https://api.github.com/repos/edx/configuration/issues/3481","id":261331343,"user":{"login":"edx-webhook","id":8964148,"avatar_url":"https://avatars.githubusercontent.com/u/8964148?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-webhook","html_url":"https://github.com/edx-webhook","followers_url":"https://api.github.com/users/edx-webhook/followers","following_url":"https://api.github.com/users/edx-webhook/following{/other_user}","gists_url":"https://api.github.com/users/edx-webhook/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-webhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-webhook/subscriptions","organizations_url":"https://api.github.com/users/edx-webhook/orgs","repos_url":"https://api.github.com/users/edx-webhook/repos","events_url":"https://api.github.com/users/edx-webhook/events{/privacy}","received_events_url":"https://api.github.com/users/edx-webhook/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T18:41:05Z","updated_at":"2016-11-17T18:41:05Z","body":"Thanks for the pull request, @smarnach! I've created [OSPR-1583](https://openedx.atlassian.net/browse/OSPR-1583) to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.\n\nFeel free to add as much of the following information to the ticket:\n- supporting documentation\n- edx-code email threads\n- timeline information (\"this must be merged by XX date\", and why that is)\n- partner information (\"this is a course on edx.org\")\n- any other information that can help Product understand the context for the PR\n\nAll technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, [our process documentation is here](http://edx-developer-guide.readthedocs.org/en/latest/process/overview.html).\n\n\n\nIf you like, you can add yourself to the [AUTHORS](https://github.com/edx/configuration/blob/master/AUTHORS)      file for this repo, though that isn't required.     Please see the [CONTRIBUTING](https://github.com/edx/edx-platform/blob/master/CONTRIBUTING.rst)     file for more information."}}
{"actor":{"display_login":"edx-webhook"}}