{"action":"created","issue":{"url":"https://api.github.com/repos/plone/plone.api/issues/217","labels_url":"https://api.github.com/repos/plone/plone.api/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/plone/plone.api/issues/217/comments","events_url":"https://api.github.com/repos/plone/plone.api/issues/217/events","html_url":"https://github.com/plone/plone.api/issues/217","id":57890583,"number":217,"title":"Reconsider pkg_resources.DistributionNotFound","user":{"login":"gforcada","id":1155680,"avatar_url":"https://avatars.githubusercontent.com/u/1155680?v=3","gravatar_id":"","url":"https://api.github.com/users/gforcada","html_url":"https://github.com/gforcada","followers_url":"https://api.github.com/users/gforcada/followers","following_url":"https://api.github.com/users/gforcada/following{/other_user}","gists_url":"https://api.github.com/users/gforcada/gists{/gist_id}","starred_url":"https://api.github.com/users/gforcada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforcada/subscriptions","organizations_url":"https://api.github.com/users/gforcada/orgs","repos_url":"https://api.github.com/users/gforcada/repos","events_url":"https://api.github.com/users/gforcada/events{/privacy}","received_events_url":"https://api.github.com/users/gforcada/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/plone/plone.api/labels/05%20type:%20question","name":"05 type: question","color":"fa00fa"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-17T06:59:40Z","updated_at":"2016-01-11T11:40:03Z","closed_at":"2015-06-12T16:38:00Z","body":"@davisagli has made a point (and some numbers) regarding catching ``pkg_resources.DistributionNotFound`` being way slower than an ``ImportError``.\r\n\r\nThe styleguide clearly says the former, but should we reconsider it due to its slowness?"},"comment":{"url":"https://api.github.com/repos/plone/plone.api/issues/comments/170516107","html_url":"https://github.com/plone/plone.api/issues/217#issuecomment-170516107","issue_url":"https://api.github.com/repos/plone/plone.api/issues/217","id":170516107,"user":{"login":"thet","id":170891,"avatar_url":"https://avatars.githubusercontent.com/u/170891?v=3","gravatar_id":"","url":"https://api.github.com/users/thet","html_url":"https://github.com/thet","followers_url":"https://api.github.com/users/thet/followers","following_url":"https://api.github.com/users/thet/following{/other_user}","gists_url":"https://api.github.com/users/thet/gists{/gist_id}","starred_url":"https://api.github.com/users/thet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thet/subscriptions","organizations_url":"https://api.github.com/users/thet/orgs","repos_url":"https://api.github.com/users/thet/repos","events_url":"https://api.github.com/users/thet/events{/privacy}","received_events_url":"https://api.github.com/users/thet/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T11:40:03Z","updated_at":"2016-01-11T11:40:03Z","body":"``pkg_resources.get_distribution('plone.protect>=3.0,<4.0')`` is not the solution, because we want CSRF protection to work in future Plone versions also.\r\nBut if done with the pkg_resources check and the application fails with an ImportError in Plone 6, it's ok because this is an explicit hint that something has to be fixed."}}