{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/11986","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11986/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11986/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11986/events","html_url":"https://github.com/joomla/joomla-cms/pull/11986","id":175788078,"number":11986,"title":"Move JLanguage::exists to JLanguageHelper::exists","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-09-08T15:39:56Z","updated_at":"2016-09-09T12:48:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11986","html_url":"https://github.com/joomla/joomla-cms/pull/11986","diff_url":"https://github.com/joomla/joomla-cms/pull/11986.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11986.patch"},"body":"### Summary of Changes\r\n\r\nThis PR moves `JLanguage::exists` to `JLanguageHelper::exists` since this method does not needs to be in JLanguage as this method doesn't do any interactions with JLanguage class neither depends on it.\r\nAlso deprecates `JLanguage::exists` and do all necessary replacements in the core.\r\n\r\n### Testing Instructions\r\n\r\n1. Apply patch \r\n2. Test if Jooma works fine\r\n3. Code review.\r\n\r\n### Documentation Changes Required\r\n\r\nNone that i know of."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/245903073","html_url":"https://github.com/joomla/joomla-cms/pull/11986#issuecomment-245903073","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11986","id":245903073,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T12:48:01Z","updated_at":"2016-09-09T12:48:01Z","body":"i did some test and it seems you are right there is no significant change since the performance and memory usage is transfered to `JApplicationCms::initialiseApp` `JLanguage::getInstance` method.\r\n\r\n#### Before patch\r\n![image](https://cloud.githubusercontent.com/assets/9630530/18387288/aff90028-7693-11e6-9e9e-ab59209b1456.png)\r\n\r\n#### After patch\r\n![image](https://cloud.githubusercontent.com/assets/9630530/18387305/d5f09b1a-7693-11e6-9e26-3d96e676fac9.png)\r\n"}}
{"actor":{"display_login":"andrepereiradasilva"}}