{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/88792309","pull_request_review_id":9356518,"id":88792309,"diff_hunk":"@@ -1,30 +1,30 @@\n 'use strict';\n-var common = require('../common');\n-var assert = require('assert');\n-var path = require('path');\n-var fs = require('fs');\n+const common = require('../common');\n+const assert = require('assert');\n+const path = require('path');\n+const fs = require('fs');\n \n-var emptyFile = path.join(common.fixturesDir, 'empty.txt');\n+const emptyFile = path.join(common.fixturesDir, 'empty.txt');\n \n-fs.open(emptyFile, 'r', function(error, fd) {\n+fs.open(emptyFile, 'r', (error, fd) => {\n   assert.ifError(error);\n \n-  var read = fs.createReadStream(emptyFile, { 'fd': fd });\n+  const read = fs.createReadStream(emptyFile, { 'fd': fd });\n \n-  read.once('data', function() {\n+  read.once('data', () => {\n     throw new Error('data event should not emit');","path":"test/parallel/test-fs-empty-readStream.js","position":23,"original_position":23,"commit_id":"60bf43ed14abb4e4942e3451712a62b0d655bf77","original_commit_id":"60bf43ed14abb4e4942e3451712a62b0d655bf77","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"Can you replace the `throw`s with `common.fail()`.","created_at":"2016-11-20T02:30:10Z","updated_at":"2016-11-20T02:30:10Z","html_url":"https://github.com/nodejs/node/pull/9700#discussion_r88792309","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9700","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/88792309"},"html":{"href":"https://github.com/nodejs/node/pull/9700#discussion_r88792309"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9700"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9700","id":94498217,"html_url":"https://github.com/nodejs/node/pull/9700","diff_url":"https://github.com/nodejs/node/pull/9700.diff","patch_url":"https://github.com/nodejs/node/pull/9700.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9700","number":9700,"state":"open","locked":false,"title":"Tests: Refactored to es6","user":{"login":"itsmed","id":13138961,"avatar_url":"https://avatars.githubusercontent.com/u/13138961?v=3","gravatar_id":"","url":"https://api.github.com/users/itsmed","html_url":"https://github.com/itsmed","followers_url":"https://api.github.com/users/itsmed/followers","following_url":"https://api.github.com/users/itsmed/following{/other_user}","gists_url":"https://api.github.com/users/itsmed/gists{/gist_id}","starred_url":"https://api.github.com/users/itsmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsmed/subscriptions","organizations_url":"https://api.github.com/users/itsmed/orgs","repos_url":"https://api.github.com/users/itsmed/repos","events_url":"https://api.github.com/users/itsmed/events{/privacy}","received_events_url":"https://api.github.com/users/itsmed/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nTests\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nChanged var to const, assert.equal to assert.strictEqual. Changed anonymous functions to use arrow functions.","created_at":"2016-11-19T22:33:08Z","updated_at":"2016-11-20T02:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1464eb0dd63a261317c7cb11076b23e01939917","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9700/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9700/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9700/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/60bf43ed14abb4e4942e3451712a62b0d655bf77","head":{"label":"itsmed:strengthen-tests","ref":"strengthen-tests","sha":"60bf43ed14abb4e4942e3451712a62b0d655bf77","user":{"login":"itsmed","id":13138961,"avatar_url":"https://avatars.githubusercontent.com/u/13138961?v=3","gravatar_id":"","url":"https://api.github.com/users/itsmed","html_url":"https://github.com/itsmed","followers_url":"https://api.github.com/users/itsmed/followers","following_url":"https://api.github.com/users/itsmed/following{/other_user}","gists_url":"https://api.github.com/users/itsmed/gists{/gist_id}","starred_url":"https://api.github.com/users/itsmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsmed/subscriptions","organizations_url":"https://api.github.com/users/itsmed/orgs","repos_url":"https://api.github.com/users/itsmed/repos","events_url":"https://api.github.com/users/itsmed/events{/privacy}","received_events_url":"https://api.github.com/users/itsmed/received_events","type":"User","site_admin":false},"repo":{"id":74239221,"name":"node","full_name":"itsmed/node","owner":{"login":"itsmed","id":13138961,"avatar_url":"https://avatars.githubusercontent.com/u/13138961?v=3","gravatar_id":"","url":"https://api.github.com/users/itsmed","html_url":"https://github.com/itsmed","followers_url":"https://api.github.com/users/itsmed/followers","following_url":"https://api.github.com/users/itsmed/following{/other_user}","gists_url":"https://api.github.com/users/itsmed/gists{/gist_id}","starred_url":"https://api.github.com/users/itsmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsmed/subscriptions","organizations_url":"https://api.github.com/users/itsmed/orgs","repos_url":"https://api.github.com/users/itsmed/repos","events_url":"https://api.github.com/users/itsmed/events{/privacy}","received_events_url":"https://api.github.com/users/itsmed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itsmed/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/itsmed/node","forks_url":"https://api.github.com/repos/itsmed/node/forks","keys_url":"https://api.github.com/repos/itsmed/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itsmed/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itsmed/node/teams","hooks_url":"https://api.github.com/repos/itsmed/node/hooks","issue_events_url":"https://api.github.com/repos/itsmed/node/issues/events{/number}","events_url":"https://api.github.com/repos/itsmed/node/events","assignees_url":"https://api.github.com/repos/itsmed/node/assignees{/user}","branches_url":"https://api.github.com/repos/itsmed/node/branches{/branch}","tags_url":"https://api.github.com/repos/itsmed/node/tags","blobs_url":"https://api.github.com/repos/itsmed/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itsmed/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itsmed/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/itsmed/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itsmed/node/statuses/{sha}","languages_url":"https://api.github.com/repos/itsmed/node/languages","stargazers_url":"https://api.github.com/repos/itsmed/node/stargazers","contributors_url":"https://api.github.com/repos/itsmed/node/contributors","subscribers_url":"https://api.github.com/repos/itsmed/node/subscribers","subscription_url":"https://api.github.com/repos/itsmed/node/subscription","commits_url":"https://api.github.com/repos/itsmed/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/itsmed/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/itsmed/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/itsmed/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/itsmed/node/contents/{+path}","compare_url":"https://api.github.com/repos/itsmed/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itsmed/node/merges","archive_url":"https://api.github.com/repos/itsmed/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itsmed/node/downloads","issues_url":"https://api.github.com/repos/itsmed/node/issues{/number}","pulls_url":"https://api.github.com/repos/itsmed/node/pulls{/number}","milestones_url":"https://api.github.com/repos/itsmed/node/milestones{/number}","notifications_url":"https://api.github.com/repos/itsmed/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itsmed/node/labels{/name}","releases_url":"https://api.github.com/repos/itsmed/node/releases{/id}","deployments_url":"https://api.github.com/repos/itsmed/node/deployments","created_at":"2016-11-19T22:26:33Z","updated_at":"2016-11-19T22:27:00Z","pushed_at":"2016-11-19T22:31:17Z","git_url":"git://github.com/itsmed/node.git","ssh_url":"git@github.com:itsmed/node.git","clone_url":"https://github.com/itsmed/node.git","svn_url":"https://github.com/itsmed/node","homepage":"https://nodejs.org","size":245321,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8a6b37bc51a353227b6711d3c1df12c2863e3302","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-20T02:26:27Z","pushed_at":"2016-11-20T02:21:42Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":371351,"stargazers_count":29027,"watchers_count":29027,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4989,"mirror_url":null,"open_issues_count":927,"forks":4989,"open_issues":927,"watchers":29027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9700"},"html":{"href":"https://github.com/nodejs/node/pull/9700"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9700"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9700/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9700/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9700/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/60bf43ed14abb4e4942e3451712a62b0d655bf77"}}}}
{"actor":{"display_login":"cjihrig"}}