{"action":"created","comment":{"url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/comments/84845399","pull_request_review_id":5595786,"id":84845399,"diff_hunk":"@@ -265,6 +265,83 @@ pub mod iter {\n \n }\n \n+pub mod pred {\n+    pub mod entry {\n+        //! Predicate types to be used on iterators over `libimagstore::store::Entry` to filter\n+        //! for links\n+\n+        use std::error::Error;\n+\n+        use filters::filter::Filter;\n+\n+        use libimagstore::store::Entry;\n+        use libimagerror::trace::trace_error;\n+\n+        use super::super::InternalLinker;\n+\n+        pub enum LinkCountOp {","path":"libimagentrylink/src/internal.rs","position":18,"original_position":18,"commit_id":"b7470d21d4577f0a1569a63e752a107dcfcb4156","original_commit_id":"b7470d21d4577f0a1569a63e752a107dcfcb4156","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"Replace this by `std::cmp::Ordering`.","created_at":"2016-10-25T07:39:57Z","updated_at":"2016-10-25T07:39:57Z","html_url":"https://github.com/matthiasbeyer/imag/pull/812#discussion_r84845399","pull_request_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812","_links":{"self":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/comments/84845399"},"html":{"href":"https://github.com/matthiasbeyer/imag/pull/812#discussion_r84845399"},"pull_request":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812"}}},"pull_request":{"url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812","id":89711655,"html_url":"https://github.com/matthiasbeyer/imag/pull/812","diff_url":"https://github.com/matthiasbeyer/imag/pull/812.diff","patch_url":"https://github.com/matthiasbeyer/imag/pull/812.patch","issue_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/812","number":812,"state":"open","locked":false,"title":"libimagentrylink/filter predicates","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"This PR adds some types for filtering with operations on the links of an entry as filter predicate.\r\n\r\nWhat I want to implement:\r\n\r\n- [ ] Filter on entries where the predicate function gets the links of an entry\r\n- [ ] Filter on Link objects\r\n","created_at":"2016-10-17T21:59:20Z","updated_at":"2016-10-25T07:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eace550e944dbe6023a159779d9a3c24eac3d05","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matthiasbeyer/imag/milestones/3","html_url":"https://github.com/matthiasbeyer/imag/milestones/0.3.0","labels_url":"https://api.github.com/repos/matthiasbeyer/imag/milestones/3/labels","id":2011195,"number":3,"title":"0.3.0","description":"By now only a milestone to track what has to be done ASAP after 0.2.0","creator":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":7,"state":"open","created_at":"2016-09-17T17:36:58Z","updated_at":"2016-10-25T07:10:05Z","due_on":"2017-03-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812/commits","review_comments_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812/comments","review_comment_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/812/comments","statuses_url":"https://api.github.com/repos/matthiasbeyer/imag/statuses/b7470d21d4577f0a1569a63e752a107dcfcb4156","head":{"label":"matthiasbeyer:libimagentrylink/filter-predicates","ref":"libimagentrylink/filter-predicates","sha":"b7470d21d4577f0a1569a63e752a107dcfcb4156","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"repo":{"id":45788713,"name":"imag","full_name":"matthiasbeyer/imag","owner":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasbeyer/imag","description":"imag - Text based personal information management suite","fork":false,"url":"https://api.github.com/repos/matthiasbeyer/imag","forks_url":"https://api.github.com/repos/matthiasbeyer/imag/forks","keys_url":"https://api.github.com/repos/matthiasbeyer/imag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasbeyer/imag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasbeyer/imag/teams","hooks_url":"https://api.github.com/repos/matthiasbeyer/imag/hooks","issue_events_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasbeyer/imag/events","assignees_url":"https://api.github.com/repos/matthiasbeyer/imag/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasbeyer/imag/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasbeyer/imag/tags","blobs_url":"https://api.github.com/repos/matthiasbeyer/imag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasbeyer/imag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasbeyer/imag/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasbeyer/imag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasbeyer/imag/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasbeyer/imag/languages","stargazers_url":"https://api.github.com/repos/matthiasbeyer/imag/stargazers","contributors_url":"https://api.github.com/repos/matthiasbeyer/imag/contributors","subscribers_url":"https://api.github.com/repos/matthiasbeyer/imag/subscribers","subscription_url":"https://api.github.com/repos/matthiasbeyer/imag/subscription","commits_url":"https://api.github.com/repos/matthiasbeyer/imag/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasbeyer/imag/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasbeyer/imag/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthiasbeyer/imag/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasbeyer/imag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasbeyer/imag/merges","archive_url":"https://api.github.com/repos/matthiasbeyer/imag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasbeyer/imag/downloads","issues_url":"https://api.github.com/repos/matthiasbeyer/imag/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasbeyer/imag/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasbeyer/imag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasbeyer/imag/labels{/name}","releases_url":"https://api.github.com/repos/matthiasbeyer/imag/releases{/id}","deployments_url":"https://api.github.com/repos/matthiasbeyer/imag/deployments","created_at":"2015-11-08T16:34:25Z","updated_at":"2016-10-25T07:13:28Z","pushed_at":"2016-10-25T07:35:46Z","git_url":"git://github.com/matthiasbeyer/imag.git","ssh_url":"git@github.com:matthiasbeyer/imag.git","clone_url":"https://github.com/matthiasbeyer/imag.git","svn_url":"https://github.com/matthiasbeyer/imag","homepage":"http://imag-pim.org","size":12487,"stargazers_count":131,"watchers_count":131,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":81,"forks":19,"open_issues":81,"watchers":131,"default_branch":"master"}},"base":{"label":"matthiasbeyer:master","ref":"master","sha":"bdbf5cedfbc1270cf25092c129d2399e82944151","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"repo":{"id":45788713,"name":"imag","full_name":"matthiasbeyer/imag","owner":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasbeyer/imag","description":"imag - Text based personal information management suite","fork":false,"url":"https://api.github.com/repos/matthiasbeyer/imag","forks_url":"https://api.github.com/repos/matthiasbeyer/imag/forks","keys_url":"https://api.github.com/repos/matthiasbeyer/imag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasbeyer/imag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasbeyer/imag/teams","hooks_url":"https://api.github.com/repos/matthiasbeyer/imag/hooks","issue_events_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasbeyer/imag/events","assignees_url":"https://api.github.com/repos/matthiasbeyer/imag/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasbeyer/imag/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasbeyer/imag/tags","blobs_url":"https://api.github.com/repos/matthiasbeyer/imag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasbeyer/imag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasbeyer/imag/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasbeyer/imag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasbeyer/imag/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasbeyer/imag/languages","stargazers_url":"https://api.github.com/repos/matthiasbeyer/imag/stargazers","contributors_url":"https://api.github.com/repos/matthiasbeyer/imag/contributors","subscribers_url":"https://api.github.com/repos/matthiasbeyer/imag/subscribers","subscription_url":"https://api.github.com/repos/matthiasbeyer/imag/subscription","commits_url":"https://api.github.com/repos/matthiasbeyer/imag/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasbeyer/imag/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasbeyer/imag/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthiasbeyer/imag/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasbeyer/imag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasbeyer/imag/merges","archive_url":"https://api.github.com/repos/matthiasbeyer/imag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasbeyer/imag/downloads","issues_url":"https://api.github.com/repos/matthiasbeyer/imag/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasbeyer/imag/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasbeyer/imag/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasbeyer/imag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasbeyer/imag/labels{/name}","releases_url":"https://api.github.com/repos/matthiasbeyer/imag/releases{/id}","deployments_url":"https://api.github.com/repos/matthiasbeyer/imag/deployments","created_at":"2015-11-08T16:34:25Z","updated_at":"2016-10-25T07:13:28Z","pushed_at":"2016-10-25T07:35:46Z","git_url":"git://github.com/matthiasbeyer/imag.git","ssh_url":"git@github.com:matthiasbeyer/imag.git","clone_url":"https://github.com/matthiasbeyer/imag.git","svn_url":"https://github.com/matthiasbeyer/imag","homepage":"http://imag-pim.org","size":12487,"stargazers_count":131,"watchers_count":131,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":81,"forks":19,"open_issues":81,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812"},"html":{"href":"https://github.com/matthiasbeyer/imag/pull/812"},"issue":{"href":"https://api.github.com/repos/matthiasbeyer/imag/issues/812"},"comments":{"href":"https://api.github.com/repos/matthiasbeyer/imag/issues/812/comments"},"review_comments":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812/comments"},"review_comment":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matthiasbeyer/imag/pulls/812/commits"},"statuses":{"href":"https://api.github.com/repos/matthiasbeyer/imag/statuses/b7470d21d4577f0a1569a63e752a107dcfcb4156"}}}}
{"actor":{"display_login":"matthiasbeyer"}}