{"action":"created","comment":{"url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/comments/92295848","pull_request_review_id":12808740,"id":92295848,"diff_hunk":"@@ -56,7 +56,7 @@\n \n {% block entity_typeahead_list_widget %}\n {% spaceless %}\n-    {% if simple %}\n+    {% if simple or child == null %}\n         {% set _id, _value, _render = child, child, child %}\n     {% else %}\n         {% set _id, _value, _render = child.id, attribute(child, property ?: 'id'), attribute(child, render) %}","path":"Resources/views/Form/typeahead.html.twig","position":8,"original_position":8,"commit_id":"cd129eac46f110a08c62446c105f8c3681b127fc","original_commit_id":"cd129eac46f110a08c62446c105f8c3681b127fc","user":{"login":"ahoulgrave","id":3420583,"avatar_url":"https://avatars.githubusercontent.com/u/3420583?v=3","gravatar_id":"","url":"https://api.github.com/users/ahoulgrave","html_url":"https://github.com/ahoulgrave","followers_url":"https://api.github.com/users/ahoulgrave/followers","following_url":"https://api.github.com/users/ahoulgrave/following{/other_user}","gists_url":"https://api.github.com/users/ahoulgrave/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoulgrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoulgrave/subscriptions","organizations_url":"https://api.github.com/users/ahoulgrave/orgs","repos_url":"https://api.github.com/users/ahoulgrave/repos","events_url":"https://api.github.com/users/ahoulgrave/events{/privacy}","received_events_url":"https://api.github.com/users/ahoulgrave/received_events","type":"User","site_admin":false},"body":"here `child` var can be `null` (L31). cannot call any property without asking. ","created_at":"2016-12-14T00:03:02Z","updated_at":"2016-12-14T00:03:02Z","html_url":"https://github.com/lifo101/typeahead-bundle/pull/18#discussion_r92295848","pull_request_url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/comments/92295848"},"html":{"href":"https://github.com/lifo101/typeahead-bundle/pull/18#discussion_r92295848"},"pull_request":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18","id":97782352,"html_url":"https://github.com/lifo101/typeahead-bundle/pull/18","diff_url":"https://github.com/lifo101/typeahead-bundle/pull/18.diff","patch_url":"https://github.com/lifo101/typeahead-bundle/pull/18.patch","issue_url":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/18","number":18,"state":"open","locked":false,"title":"Fix for multiple option","user":{"login":"gonzalocelina","id":8448832,"avatar_url":"https://avatars.githubusercontent.com/u/8448832?v=3","gravatar_id":"","url":"https://api.github.com/users/gonzalocelina","html_url":"https://github.com/gonzalocelina","followers_url":"https://api.github.com/users/gonzalocelina/followers","following_url":"https://api.github.com/users/gonzalocelina/following{/other_user}","gists_url":"https://api.github.com/users/gonzalocelina/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalocelina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalocelina/subscriptions","organizations_url":"https://api.github.com/users/gonzalocelina/orgs","repos_url":"https://api.github.com/users/gonzalocelina/repos","events_url":"https://api.github.com/users/gonzalocelina/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalocelina/received_events","type":"User","site_admin":false},"body":"When multiple child is set to null (line 30) and on line 62 is called child.id\r\nThat comprobation throws an error. I don't fully understand why it calls for child.id because after I quit this if() the field started working and it does everything that it should do (adds the <ul>, saves on the DB, list the existing ones if the Entity have them, etc.)\r\nPS: Sorry about my bad english I'm a spanish speaker","created_at":"2016-12-13T16:13:42Z","updated_at":"2016-12-14T00:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"997349aaa18b4bde14756149f9b92c9b343f21c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18/commits","review_comments_url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18/comments","review_comment_url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/18/comments","statuses_url":"https://api.github.com/repos/lifo101/typeahead-bundle/statuses/cd129eac46f110a08c62446c105f8c3681b127fc","head":{"label":"gonzalocelina:gonzalocelina-fix-multiple","ref":"gonzalocelina-fix-multiple","sha":"cd129eac46f110a08c62446c105f8c3681b127fc","user":{"login":"gonzalocelina","id":8448832,"avatar_url":"https://avatars.githubusercontent.com/u/8448832?v=3","gravatar_id":"","url":"https://api.github.com/users/gonzalocelina","html_url":"https://github.com/gonzalocelina","followers_url":"https://api.github.com/users/gonzalocelina/followers","following_url":"https://api.github.com/users/gonzalocelina/following{/other_user}","gists_url":"https://api.github.com/users/gonzalocelina/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalocelina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalocelina/subscriptions","organizations_url":"https://api.github.com/users/gonzalocelina/orgs","repos_url":"https://api.github.com/users/gonzalocelina/repos","events_url":"https://api.github.com/users/gonzalocelina/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalocelina/received_events","type":"User","site_admin":false},"repo":{"id":76374552,"name":"typeahead-bundle","full_name":"gonzalocelina/typeahead-bundle","owner":{"login":"gonzalocelina","id":8448832,"avatar_url":"https://avatars.githubusercontent.com/u/8448832?v=3","gravatar_id":"","url":"https://api.github.com/users/gonzalocelina","html_url":"https://github.com/gonzalocelina","followers_url":"https://api.github.com/users/gonzalocelina/followers","following_url":"https://api.github.com/users/gonzalocelina/following{/other_user}","gists_url":"https://api.github.com/users/gonzalocelina/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalocelina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalocelina/subscriptions","organizations_url":"https://api.github.com/users/gonzalocelina/orgs","repos_url":"https://api.github.com/users/gonzalocelina/repos","events_url":"https://api.github.com/users/gonzalocelina/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalocelina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gonzalocelina/typeahead-bundle","description":"A Symfony2 bundle that provides an enhanced Bootstrap v3 Typeahead form type.","fork":true,"url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle","forks_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/forks","keys_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/teams","hooks_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/hooks","issue_events_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/events","assignees_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/tags","blobs_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/languages","stargazers_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/stargazers","contributors_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/contributors","subscribers_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/subscribers","subscription_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/subscription","commits_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/merges","archive_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/downloads","issues_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/labels{/name}","releases_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/gonzalocelina/typeahead-bundle/deployments","created_at":"2016-12-13T16:03:20Z","updated_at":"2016-12-13T16:03:21Z","pushed_at":"2016-12-13T22:06:19Z","git_url":"git://github.com/gonzalocelina/typeahead-bundle.git","ssh_url":"git@github.com:gonzalocelina/typeahead-bundle.git","clone_url":"https://github.com/gonzalocelina/typeahead-bundle.git","svn_url":"https://github.com/gonzalocelina/typeahead-bundle","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lifo101:master","ref":"master","sha":"2e22e974462b5bd928867da00285baefe360fb61","user":{"login":"lifo101","id":367337,"avatar_url":"https://avatars.githubusercontent.com/u/367337?v=3","gravatar_id":"","url":"https://api.github.com/users/lifo101","html_url":"https://github.com/lifo101","followers_url":"https://api.github.com/users/lifo101/followers","following_url":"https://api.github.com/users/lifo101/following{/other_user}","gists_url":"https://api.github.com/users/lifo101/gists{/gist_id}","starred_url":"https://api.github.com/users/lifo101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifo101/subscriptions","organizations_url":"https://api.github.com/users/lifo101/orgs","repos_url":"https://api.github.com/users/lifo101/repos","events_url":"https://api.github.com/users/lifo101/events{/privacy}","received_events_url":"https://api.github.com/users/lifo101/received_events","type":"User","site_admin":false},"repo":{"id":8751724,"name":"typeahead-bundle","full_name":"lifo101/typeahead-bundle","owner":{"login":"lifo101","id":367337,"avatar_url":"https://avatars.githubusercontent.com/u/367337?v=3","gravatar_id":"","url":"https://api.github.com/users/lifo101","html_url":"https://github.com/lifo101","followers_url":"https://api.github.com/users/lifo101/followers","following_url":"https://api.github.com/users/lifo101/following{/other_user}","gists_url":"https://api.github.com/users/lifo101/gists{/gist_id}","starred_url":"https://api.github.com/users/lifo101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifo101/subscriptions","organizations_url":"https://api.github.com/users/lifo101/orgs","repos_url":"https://api.github.com/users/lifo101/repos","events_url":"https://api.github.com/users/lifo101/events{/privacy}","received_events_url":"https://api.github.com/users/lifo101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lifo101/typeahead-bundle","description":"A Symfony2 bundle that provides an enhanced Bootstrap v3 Typeahead form type.","fork":false,"url":"https://api.github.com/repos/lifo101/typeahead-bundle","forks_url":"https://api.github.com/repos/lifo101/typeahead-bundle/forks","keys_url":"https://api.github.com/repos/lifo101/typeahead-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifo101/typeahead-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifo101/typeahead-bundle/teams","hooks_url":"https://api.github.com/repos/lifo101/typeahead-bundle/hooks","issue_events_url":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/lifo101/typeahead-bundle/events","assignees_url":"https://api.github.com/repos/lifo101/typeahead-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/lifo101/typeahead-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/lifo101/typeahead-bundle/tags","blobs_url":"https://api.github.com/repos/lifo101/typeahead-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifo101/typeahead-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifo101/typeahead-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifo101/typeahead-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifo101/typeahead-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/lifo101/typeahead-bundle/languages","stargazers_url":"https://api.github.com/repos/lifo101/typeahead-bundle/stargazers","contributors_url":"https://api.github.com/repos/lifo101/typeahead-bundle/contributors","subscribers_url":"https://api.github.com/repos/lifo101/typeahead-bundle/subscribers","subscription_url":"https://api.github.com/repos/lifo101/typeahead-bundle/subscription","commits_url":"https://api.github.com/repos/lifo101/typeahead-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifo101/typeahead-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifo101/typeahead-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifo101/typeahead-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/lifo101/typeahead-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifo101/typeahead-bundle/merges","archive_url":"https://api.github.com/repos/lifo101/typeahead-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifo101/typeahead-bundle/downloads","issues_url":"https://api.github.com/repos/lifo101/typeahead-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/lifo101/typeahead-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/lifo101/typeahead-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifo101/typeahead-bundle/labels{/name}","releases_url":"https://api.github.com/repos/lifo101/typeahead-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/lifo101/typeahead-bundle/deployments","created_at":"2013-03-13T12:32:31Z","updated_at":"2016-11-03T08:45:40Z","pushed_at":"2016-12-13T22:06:19Z","git_url":"git://github.com/lifo101/typeahead-bundle.git","ssh_url":"git@github.com:lifo101/typeahead-bundle.git","clone_url":"https://github.com/lifo101/typeahead-bundle.git","svn_url":"https://github.com/lifo101/typeahead-bundle","homepage":"","size":70,"stargazers_count":15,"watchers_count":15,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18"},"html":{"href":"https://github.com/lifo101/typeahead-bundle/pull/18"},"issue":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/18"},"comments":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/lifo101/typeahead-bundle/statuses/cd129eac46f110a08c62446c105f8c3681b127fc"}}}}
{"actor":{"display_login":"ahoulgrave"}}