{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/88837513","pull_request_review_id":9397454,"id":88837513,"diff_hunk":"@@ -188,40 +188,43 @@ private boolean tryParseTime(CharSequence txt, int tokenStart, int tokenEnd) {\n         int localSeconds = -1;\n         int currentPartNumber = 0;\n         int currentPartValue = 0;\n+        int numDigits = 0;\n \n         for (int i = tokenStart; i < tokenEnd; i++) {\n             char c = txt.charAt(i);\n             if (isDigit(c)) {\n                 currentPartValue = currentPartValue * 10 + getNumericalValue(c);\n+                if (++numDigits > 2) {\n+                  return false; // too many digits in this part\n+                }\n             } else if (c == ':') {\n-                if (currentPartValue == 0) {\n-                    // invalid :: (nothing in between)\n+                if (numDigits <= 0) {","path":"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderDateFormatter.java","position":16,"original_position":16,"commit_id":"413168baa0a851349fbebdea78a82cce5b8c8768","original_commit_id":"413168baa0a851349fbebdea78a82cce5b8c8768","user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars.githubusercontent.com/u/849197?v=3","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"body":"`== 0` should be enough","created_at":"2016-11-21T06:45:42Z","updated_at":"2016-11-21T06:45:43Z","html_url":"https://github.com/netty/netty/pull/6050#discussion_r88837513","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6050","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/88837513"},"html":{"href":"https://github.com/netty/netty/pull/6050#discussion_r88837513"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6050"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6050","id":94541516,"html_url":"https://github.com/netty/netty/pull/6050","diff_url":"https://github.com/netty/netty/pull/6050.diff","patch_url":"https://github.com/netty/netty/pull/6050.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6050","number":6050,"state":"open","locked":false,"title":"Fix timestamp parsing in HttpHeaderDateFormatter","user":{"login":"radai-rosenblatt","id":1042632,"avatar_url":"https://avatars.githubusercontent.com/u/1042632?v=3","gravatar_id":"","url":"https://api.github.com/users/radai-rosenblatt","html_url":"https://github.com/radai-rosenblatt","followers_url":"https://api.github.com/users/radai-rosenblatt/followers","following_url":"https://api.github.com/users/radai-rosenblatt/following{/other_user}","gists_url":"https://api.github.com/users/radai-rosenblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/radai-rosenblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radai-rosenblatt/subscriptions","organizations_url":"https://api.github.com/users/radai-rosenblatt/orgs","repos_url":"https://api.github.com/users/radai-rosenblatt/repos","events_url":"https://api.github.com/users/radai-rosenblatt/events{/privacy}","received_events_url":"https://api.github.com/users/radai-rosenblatt/received_events","type":"User","site_admin":false},"body":"Motivation:\r\ncode assumes a numeric value of 0 means no digits were read between separators, which fails for timestamps like 00:00:00\r\n\r\nModifications:\r\nexplicitly check for no digits encountered instead of checking for numeric value 0\r\n\r\nResult:\r\ntimestamps with 00 successfully parse\r\n\r\nSigned-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>","created_at":"2016-11-21T01:09:48Z","updated_at":"2016-11-21T06:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a0785aad9a4e3c801b236f179d28b58e38697c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6050/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6050/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6050/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/413168baa0a851349fbebdea78a82cce5b8c8768","head":{"label":"radai-rosenblatt:6049","ref":"6049","sha":"413168baa0a851349fbebdea78a82cce5b8c8768","user":{"login":"radai-rosenblatt","id":1042632,"avatar_url":"https://avatars.githubusercontent.com/u/1042632?v=3","gravatar_id":"","url":"https://api.github.com/users/radai-rosenblatt","html_url":"https://github.com/radai-rosenblatt","followers_url":"https://api.github.com/users/radai-rosenblatt/followers","following_url":"https://api.github.com/users/radai-rosenblatt/following{/other_user}","gists_url":"https://api.github.com/users/radai-rosenblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/radai-rosenblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radai-rosenblatt/subscriptions","organizations_url":"https://api.github.com/users/radai-rosenblatt/orgs","repos_url":"https://api.github.com/users/radai-rosenblatt/repos","events_url":"https://api.github.com/users/radai-rosenblatt/events{/privacy}","received_events_url":"https://api.github.com/users/radai-rosenblatt/received_events","type":"User","site_admin":false},"repo":{"id":69411082,"name":"netty","full_name":"radai-rosenblatt/netty","owner":{"login":"radai-rosenblatt","id":1042632,"avatar_url":"https://avatars.githubusercontent.com/u/1042632?v=3","gravatar_id":"","url":"https://api.github.com/users/radai-rosenblatt","html_url":"https://github.com/radai-rosenblatt","followers_url":"https://api.github.com/users/radai-rosenblatt/followers","following_url":"https://api.github.com/users/radai-rosenblatt/following{/other_user}","gists_url":"https://api.github.com/users/radai-rosenblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/radai-rosenblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radai-rosenblatt/subscriptions","organizations_url":"https://api.github.com/users/radai-rosenblatt/orgs","repos_url":"https://api.github.com/users/radai-rosenblatt/repos","events_url":"https://api.github.com/users/radai-rosenblatt/events{/privacy}","received_events_url":"https://api.github.com/users/radai-rosenblatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radai-rosenblatt/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/radai-rosenblatt/netty","forks_url":"https://api.github.com/repos/radai-rosenblatt/netty/forks","keys_url":"https://api.github.com/repos/radai-rosenblatt/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radai-rosenblatt/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radai-rosenblatt/netty/teams","hooks_url":"https://api.github.com/repos/radai-rosenblatt/netty/hooks","issue_events_url":"https://api.github.com/repos/radai-rosenblatt/netty/issues/events{/number}","events_url":"https://api.github.com/repos/radai-rosenblatt/netty/events","assignees_url":"https://api.github.com/repos/radai-rosenblatt/netty/assignees{/user}","branches_url":"https://api.github.com/repos/radai-rosenblatt/netty/branches{/branch}","tags_url":"https://api.github.com/repos/radai-rosenblatt/netty/tags","blobs_url":"https://api.github.com/repos/radai-rosenblatt/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radai-rosenblatt/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radai-rosenblatt/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/radai-rosenblatt/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radai-rosenblatt/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/radai-rosenblatt/netty/languages","stargazers_url":"https://api.github.com/repos/radai-rosenblatt/netty/stargazers","contributors_url":"https://api.github.com/repos/radai-rosenblatt/netty/contributors","subscribers_url":"https://api.github.com/repos/radai-rosenblatt/netty/subscribers","subscription_url":"https://api.github.com/repos/radai-rosenblatt/netty/subscription","commits_url":"https://api.github.com/repos/radai-rosenblatt/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/radai-rosenblatt/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/radai-rosenblatt/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/radai-rosenblatt/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/radai-rosenblatt/netty/contents/{+path}","compare_url":"https://api.github.com/repos/radai-rosenblatt/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radai-rosenblatt/netty/merges","archive_url":"https://api.github.com/repos/radai-rosenblatt/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radai-rosenblatt/netty/downloads","issues_url":"https://api.github.com/repos/radai-rosenblatt/netty/issues{/number}","pulls_url":"https://api.github.com/repos/radai-rosenblatt/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/radai-rosenblatt/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/radai-rosenblatt/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radai-rosenblatt/netty/labels{/name}","releases_url":"https://api.github.com/repos/radai-rosenblatt/netty/releases{/id}","deployments_url":"https://api.github.com/repos/radai-rosenblatt/netty/deployments","created_at":"2016-09-28T00:51:13Z","updated_at":"2016-09-28T00:51:27Z","pushed_at":"2016-11-21T03:10:38Z","git_url":"git://github.com/radai-rosenblatt/netty.git","ssh_url":"git@github.com:radai-rosenblatt/netty.git","clone_url":"https://github.com/radai-rosenblatt/netty.git","svn_url":"https://github.com/radai-rosenblatt/netty","homepage":"http://netty.io/","size":42859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"782b7bcf4a1db5f33078fe8f7ded8059770f7fc4","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2016-11-21T06:07:00Z","pushed_at":"2016-11-21T03:10:39Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":73733,"stargazers_count":8284,"watchers_count":8284,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4201,"mirror_url":null,"open_issues_count":341,"forks":4201,"open_issues":341,"watchers":8284,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6050"},"html":{"href":"https://github.com/netty/netty/pull/6050"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6050"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6050/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6050/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6050/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/413168baa0a851349fbebdea78a82cce5b8c8768"}}}}
{"actor":{"display_login":"slandelle"}}