{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/13754","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/13754/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/13754/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/13754/events","html_url":"https://github.com/dotnet/roslyn/pull/13754","id":176540648,"number":13754,"title":"Disable EnC for active methods with v7 syntax and for any method with v7 switch statement","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Local%20Functions","name":"New Language Feature - Local Functions","color":"bfd4f2"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Out%20Variable%20Declaration","name":"New Language Feature - Out Variable Declaration","color":"bfd4f2"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Pattern%20Matching","name":"New Language Feature - Pattern Matching","color":"bfd4f2"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Ref%20Locals%20and%20Returns","name":"New Language Feature - Ref Locals and Returns","color":"bfd4f2"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Tuples","name":"New Language Feature - Tuples","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"assignees":[{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/23","html_url":"https://github.com/dotnet/roslyn/milestones/2.0%20(RC)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/23/labels","id":1926441,"number":23,"title":"2.0 (RC)","description":"","creator":{"login":"ManishJayaswal","id":9527491,"avatar_url":"https://avatars.githubusercontent.com/u/9527491?v=3","gravatar_id":"","url":"https://api.github.com/users/ManishJayaswal","html_url":"https://github.com/ManishJayaswal","followers_url":"https://api.github.com/users/ManishJayaswal/followers","following_url":"https://api.github.com/users/ManishJayaswal/following{/other_user}","gists_url":"https://api.github.com/users/ManishJayaswal/gists{/gist_id}","starred_url":"https://api.github.com/users/ManishJayaswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManishJayaswal/subscriptions","organizations_url":"https://api.github.com/users/ManishJayaswal/orgs","repos_url":"https://api.github.com/users/ManishJayaswal/repos","events_url":"https://api.github.com/users/ManishJayaswal/events{/privacy}","received_events_url":"https://api.github.com/users/ManishJayaswal/received_events","type":"User","site_admin":false},"open_issues":211,"closed_issues":41,"state":"open","created_at":"2016-08-06T00:01:13Z","updated_at":"2016-09-13T05:36:40Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-09-13T03:37:39Z","updated_at":"2016-09-13T16:52:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/13754","html_url":"https://github.com/dotnet/roslyn/pull/13754","diff_url":"https://github.com/dotnet/roslyn/pull/13754.diff","patch_url":"https://github.com/dotnet/roslyn/pull/13754.patch"},"body":"Adding a syntactic check for any v7 syntax around active statement during EnC. \r\nAlso adding a semantic check for v7 switch statement (looking at governing type of the switch).\r\n\r\nAddresses some of the work items in https://github.com/dotnet/roslyn/issues/12379\r\n\r\n@gafter I think it would be good to re-open your PR (https://github.com/dotnet/roslyn/pull/13498) with public API for checking v7 switch statement. I copied that method to unblock myself for now.\r\n\r\nSince tuples and ref shouldn't affect EnC slots, I'm thinking to allow them. Any thoughts?\r\nIf this change looks good, I will do a similar change for VB.\r\n\r\n@dotnet/roslyn-compiler for review."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/246747904","html_url":"https://github.com/dotnet/roslyn/pull/13754#issuecomment-246747904","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/13754","id":246747904,"user":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T16:52:54Z","updated_at":"2016-09-13T16:52:54Z","body":"Re\r\n> @gafter I think it would be good to re-open your PR ([https://github.com/dotnet/roslyn/pull/13498](https://github.com/dotnet/roslyn/pull/13498)) with public API for checking v7 switch statement. I copied that method to unblock myself for now.\r\n\r\nThere would only be a single client for that API - this code. We prefer to see at least two and preferably three potential clients to add a public API."}}
{"actor":{"display_login":"gafter"}}