{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/retrodot/pulls/comments/83469185","pull_request_review_id":4313665,"id":83469185,"diff_hunk":"@@ -51,14 +70,17 @@ def process(user, message)\n     #\n     # Return nil to indicate that we don't actually want to process the command\n     # after all.\n-    def run(user, match_data)\n+    def run\n       raise NotImplementedError\n     end\n \n-    private\n+    # LIBRARY FUNCTIONS\n+    #\n+    # These utility functions are used by chatops commands.\n \n-    def old_incident_warning(incident)\n-      ChatOps.message \"It looks like you may have forgotten to run `#{Config.chatops_prefix}start incident`.  If you really meant incident #{incident.incident_id}, please specify the incident id with your command.\"\n-    end\n+    include ChatOps::MentionHelpers\n+    include ChatOps::TimeStampHelpers\n+    include ChatOps::MessageHelpers\n+    include ChatOps::IncidentHelpers","path":"lib/chat_ops/command.rb","position":120,"original_position":96,"commit_id":"59a773384bbfcf0a093a4acd57cb7411539e2c74","original_commit_id":"9d4a446c82d690dd9cf7f4e3e73e4c8080f99954","user":{"login":"joshuatobin","id":665033,"avatar_url":"https://avatars.githubusercontent.com/u/665033?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuatobin","html_url":"https://github.com/joshuatobin","followers_url":"https://api.github.com/users/joshuatobin/followers","following_url":"https://api.github.com/users/joshuatobin/following{/other_user}","gists_url":"https://api.github.com/users/joshuatobin/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuatobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuatobin/subscriptions","organizations_url":"https://api.github.com/users/joshuatobin/orgs","repos_url":"https://api.github.com/users/joshuatobin/repos","events_url":"https://api.github.com/users/joshuatobin/events{/privacy}","received_events_url":"https://api.github.com/users/joshuatobin/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-10-14T17:47:12Z","updated_at":"2016-10-14T17:47:12Z","html_url":"https://github.com/heroku/retrodot/pull/67#discussion_r83469185","pull_request_url":"https://api.github.com/repos/heroku/retrodot/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/comments/83469185"},"html":{"href":"https://github.com/heroku/retrodot/pull/67#discussion_r83469185"},"pull_request":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/retrodot/pulls/67","id":87565675,"html_url":"https://github.com/heroku/retrodot/pull/67","diff_url":"https://github.com/heroku/retrodot/pull/67.diff","patch_url":"https://github.com/heroku/retrodot/pull/67.patch","issue_url":"https://api.github.com/repos/heroku/retrodot/issues/67","number":67,"state":"open","locked":false,"title":"Chatops methods to command","user":{"login":"lexelby","id":4446653,"avatar_url":"https://avatars.githubusercontent.com/u/4446653?v=3","gravatar_id":"","url":"https://api.github.com/users/lexelby","html_url":"https://github.com/lexelby","followers_url":"https://api.github.com/users/lexelby/followers","following_url":"https://api.github.com/users/lexelby/following{/other_user}","gists_url":"https://api.github.com/users/lexelby/gists{/gist_id}","starred_url":"https://api.github.com/users/lexelby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexelby/subscriptions","organizations_url":"https://api.github.com/users/lexelby/orgs","repos_url":"https://api.github.com/users/lexelby/repos","events_url":"https://api.github.com/users/lexelby/events{/privacy}","received_events_url":"https://api.github.com/users/lexelby/received_events","type":"User","site_admin":false},"body":"Note that this depends on #66.\r\n\r\nLots of changes in here, but it boils down to this:\r\n\r\n1. Move helper methods from `ChatOps` to `ChatOps::Command`.  (Actually, grouped related methods into modules and included them in `ChatOps::Command`.)\r\n2. Instead of passing `user` and `match` to `Command.process` and then passing them in turn to `run()`, store them as instance variables.\r\n3. Use the new instance variable semantics to change from `parse_incident` to always parsing, with `incident_optional` for exceptional commands like `start incident`.\r\n\r\nAll of this makes the code much better organized and easier to work with.\r\n\r\nThe rest of this PR is just a bunch of little changes to make the tests pass.\r\n\r\n@joshuatobin @reidmix","created_at":"2016-09-30T21:01:29Z","updated_at":"2016-10-14T17:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a390dd74123a908510d670e60dc0799b74bc8d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/retrodot/pulls/67/commits","review_comments_url":"https://api.github.com/repos/heroku/retrodot/pulls/67/comments","review_comment_url":"https://api.github.com/repos/heroku/retrodot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/retrodot/issues/67/comments","statuses_url":"https://api.github.com/repos/heroku/retrodot/statuses/59a773384bbfcf0a093a4acd57cb7411539e2c74","head":{"label":"heroku:chatops-methods-to-command","ref":"chatops-methods-to-command","sha":"59a773384bbfcf0a093a4acd57cb7411539e2c74","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":64845715,"name":"retrodot","full_name":"heroku/retrodot","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/retrodot","description":"A self-service tool to automate the facilitation, collection and system of record for the retrospective process","fork":false,"url":"https://api.github.com/repos/heroku/retrodot","forks_url":"https://api.github.com/repos/heroku/retrodot/forks","keys_url":"https://api.github.com/repos/heroku/retrodot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/retrodot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/retrodot/teams","hooks_url":"https://api.github.com/repos/heroku/retrodot/hooks","issue_events_url":"https://api.github.com/repos/heroku/retrodot/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/retrodot/events","assignees_url":"https://api.github.com/repos/heroku/retrodot/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/retrodot/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/retrodot/tags","blobs_url":"https://api.github.com/repos/heroku/retrodot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/retrodot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/retrodot/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/retrodot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/retrodot/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/retrodot/languages","stargazers_url":"https://api.github.com/repos/heroku/retrodot/stargazers","contributors_url":"https://api.github.com/repos/heroku/retrodot/contributors","subscribers_url":"https://api.github.com/repos/heroku/retrodot/subscribers","subscription_url":"https://api.github.com/repos/heroku/retrodot/subscription","commits_url":"https://api.github.com/repos/heroku/retrodot/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/retrodot/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/retrodot/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/retrodot/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/retrodot/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/retrodot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/retrodot/merges","archive_url":"https://api.github.com/repos/heroku/retrodot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/retrodot/downloads","issues_url":"https://api.github.com/repos/heroku/retrodot/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/retrodot/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/retrodot/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/retrodot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/retrodot/labels{/name}","releases_url":"https://api.github.com/repos/heroku/retrodot/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/retrodot/deployments","created_at":"2016-08-03T12:51:55Z","updated_at":"2016-09-01T14:23:25Z","pushed_at":"2016-10-14T15:03:38Z","git_url":"git://github.com/heroku/retrodot.git","ssh_url":"git@github.com:heroku/retrodot.git","clone_url":"https://github.com/heroku/retrodot.git","svn_url":"https://github.com/heroku/retrodot","homepage":null,"size":401,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"c74c0302dba28252aceb6b14fe05005d72cd09ba","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":64845715,"name":"retrodot","full_name":"heroku/retrodot","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/retrodot","description":"A self-service tool to automate the facilitation, collection and system of record for the retrospective process","fork":false,"url":"https://api.github.com/repos/heroku/retrodot","forks_url":"https://api.github.com/repos/heroku/retrodot/forks","keys_url":"https://api.github.com/repos/heroku/retrodot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/retrodot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/retrodot/teams","hooks_url":"https://api.github.com/repos/heroku/retrodot/hooks","issue_events_url":"https://api.github.com/repos/heroku/retrodot/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/retrodot/events","assignees_url":"https://api.github.com/repos/heroku/retrodot/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/retrodot/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/retrodot/tags","blobs_url":"https://api.github.com/repos/heroku/retrodot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/retrodot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/retrodot/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/retrodot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/retrodot/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/retrodot/languages","stargazers_url":"https://api.github.com/repos/heroku/retrodot/stargazers","contributors_url":"https://api.github.com/repos/heroku/retrodot/contributors","subscribers_url":"https://api.github.com/repos/heroku/retrodot/subscribers","subscription_url":"https://api.github.com/repos/heroku/retrodot/subscription","commits_url":"https://api.github.com/repos/heroku/retrodot/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/retrodot/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/retrodot/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/retrodot/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/retrodot/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/retrodot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/retrodot/merges","archive_url":"https://api.github.com/repos/heroku/retrodot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/retrodot/downloads","issues_url":"https://api.github.com/repos/heroku/retrodot/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/retrodot/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/retrodot/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/retrodot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/retrodot/labels{/name}","releases_url":"https://api.github.com/repos/heroku/retrodot/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/retrodot/deployments","created_at":"2016-08-03T12:51:55Z","updated_at":"2016-09-01T14:23:25Z","pushed_at":"2016-10-14T15:03:38Z","git_url":"git://github.com/heroku/retrodot.git","ssh_url":"git@github.com:heroku/retrodot.git","clone_url":"https://github.com/heroku/retrodot.git","svn_url":"https://github.com/heroku/retrodot","homepage":null,"size":401,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/67"},"html":{"href":"https://github.com/heroku/retrodot/pull/67"},"issue":{"href":"https://api.github.com/repos/heroku/retrodot/issues/67"},"comments":{"href":"https://api.github.com/repos/heroku/retrodot/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/retrodot/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/retrodot/statuses/59a773384bbfcf0a093a4acd57cb7411539e2c74"}}}}
{"actor":{"display_login":"joshuatobin"}}